feature_gate.rs 65.7 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

//! Feature gating
//!
L
Luke Gallagher 已提交
13
//! This module implements the gating necessary for preventing certain compiler
14 15 16 17 18
//! features from being used by default. This module will crawl a pre-expanded
//! AST to ensure that there are no features which are used that are not
//! enabled.
//!
//! Features are enabled in programs via the crate-level attributes of
19
//! `#![feature(...)]` with a comma-separated list of features.
B
Brian Anderson 已提交
20 21 22 23
//!
//! For the purpose of future feature-tracking, once code for detection of feature
//! gate usage is added, *do not remove it again* even once the feature
//! becomes stable.
G
GuillaumeGomez 已提交
24

25
use self::AttributeType::*;
26
use self::AttributeGate::*;
27

N
Niko Matsakis 已提交
28
use abi::Abi;
29
use ast::{self, NodeId, PatKind, RangeEnd};
30
use attr;
31
use codemap::{CodeMap, Spanned};
32
use syntax_pos::Span;
33
use errors::{DiagnosticBuilder, Handler, FatalError};
34
use visit::{self, FnKind, Visitor};
J
Jeffrey Seyfried 已提交
35
use parse::ParseSess;
36
use symbol::Symbol;
37

38
use std::ascii::AsciiExt;
T
Tim Neumann 已提交
39
use std::env;
40

41 42 43 44 45 46 47 48
macro_rules! setter {
    ($field: ident) => {{
        fn f(features: &mut Features) -> &mut bool {
            &mut features.$field
        }
        f as fn(&mut Features) -> &mut bool
    }}
}
49

50
macro_rules! declare_features {
51
    ($((active, $feature: ident, $ver: expr, $issue: expr),)+) => {
52 53 54 55 56 57 58 59 60
        /// Represents active features that are currently being implemented or
        /// currently being considered for addition/removal.
        const ACTIVE_FEATURES: &'static [(&'static str, &'static str,
                                          Option<u32>, fn(&mut Features) -> &mut bool)] = &[
            $((stringify!($feature), $ver, $issue, setter!($feature))),+
        ];

        /// A set of features to be used by later passes.
        pub struct Features {
61
            /// #![feature] attrs for stable language features, for error reporting
62
            pub declared_stable_lang_features: Vec<(Symbol, Span)>,
63
            /// #![feature] attrs for non-language (library) features
64
            pub declared_lib_features: Vec<(Symbol, Span)>,
65 66
            $(pub $feature: bool),+
        }
67

68 69 70 71 72 73 74 75 76 77 78
        impl Features {
            pub fn new() -> Features {
                Features {
                    declared_stable_lang_features: Vec::new(),
                    declared_lib_features: Vec::new(),
                    $($feature: false),+
                }
            }
        }
    };

79
    ($((removed, $feature: ident, $ver: expr, $issue: expr),)+) => {
80
        /// Represents unstable features which have since been removed (it was once Active)
81 82 83 84 85
        const REMOVED_FEATURES: &'static [(&'static str, &'static str, Option<u32>)] = &[
            $((stringify!($feature), $ver, $issue)),+
        ];
    };

86 87 88 89 90 91 92
    ($((stable_removed, $feature: ident, $ver: expr, $issue: expr),)+) => {
        /// Represents stable features which have since been removed (it was once Accepted)
        const STABLE_REMOVED_FEATURES: &'static [(&'static str, &'static str, Option<u32>)] = &[
            $((stringify!($feature), $ver, $issue)),+
        ];
    };

93
    ($((accepted, $feature: ident, $ver: expr, $issue: expr),)+) => {
94 95 96 97 98
        /// Those language feature has since been Accepted (it was once Active)
        const ACCEPTED_FEATURES: &'static [(&'static str, &'static str, Option<u32>)] = &[
            $((stringify!($feature), $ver, $issue)),+
        ];
    }
99 100
}

S
Steve Klabnik 已提交
101 102
// If you change this, please modify src/doc/unstable-book as well.
//
B
Brian Anderson 已提交
103
// Don't ever remove anything from this list; set them to 'Removed'.
S
Steve Klabnik 已提交
104
//
B
Brian Anderson 已提交
105 106 107
// The version numbers here correspond to the version in which the current status
// was set. This is most important for knowing when a particular feature became
// stable (active).
S
Steve Klabnik 已提交
108
//
109 110 111 112 113 114 115 116 117 118 119 120
// NB: The featureck.py script parses this information directly out of the source
// so take care when modifying it.

declare_features! (
    (active, asm, "1.0.0", Some(29722)),
    (active, concat_idents, "1.0.0", Some(29599)),
    (active, link_args, "1.0.0", Some(29596)),
    (active, log_syntax, "1.0.0", Some(29598)),
    (active, non_ascii_idents, "1.0.0", Some(28979)),
    (active, plugin_registrar, "1.0.0", Some(29597)),
    (active, thread_local, "1.0.0", Some(29594)),
    (active, trace_macros, "1.0.0", Some(29598)),
A
Aaron Turon 已提交
121 122

    // rustc internal, for now:
123 124
    (active, intrinsics, "1.0.0", None),
    (active, lang_items, "1.0.0", None),
125

126 127 128 129
    (active, link_llvm_intrinsics, "1.0.0", Some(29602)),
    (active, linkage, "1.0.0", Some(29603)),
    (active, quote, "1.0.0", Some(29601)),
    (active, simd, "1.0.0", Some(27731)),
130 131


A
Aaron Turon 已提交
132
    // rustc internal
133 134 135 136 137
    (active, rustc_diagnostic_macros, "1.0.0", None),
    (active, advanced_slice_patterns, "1.0.0", Some(23121)),
    (active, box_syntax, "1.0.0", Some(27779)),
    (active, placement_in_syntax, "1.0.0", Some(27779)),
    (active, unboxed_closures, "1.0.0", Some(29625)),
A
Aaron Turon 已提交
138

139 140 141 142 143 144 145 146 147
    (active, allocator, "1.0.0", Some(27389)),
    (active, fundamental, "1.0.0", Some(29635)),
    (active, main, "1.0.0", Some(29634)),
    (active, needs_allocator, "1.4.0", Some(27389)),
    (active, on_unimplemented, "1.0.0", Some(29628)),
    (active, plugin, "1.0.0", Some(29597)),
    (active, simd_ffi, "1.0.0", Some(27731)),
    (active, start, "1.0.0", Some(29633)),
    (active, structural_match, "1.8.0", Some(31434)),
148 149
    (active, panic_runtime, "1.10.0", Some(32837)),
    (active, needs_panic_runtime, "1.10.0", Some(32837)),
150

151
    // OIBIT specific features
152
    (active, optin_builtin_traits, "1.0.0", Some(13231)),
153

J
Joseph Crail 已提交
154
    // macro reexport needs more discussion and stabilization
155
    (active, macro_reexport, "1.0.0", Some(29638)),
156 157

    // Allows use of #[staged_api]
A
Aaron Turon 已提交
158
    // rustc internal
159
    (active, staged_api, "1.0.0", None),
160

A
Alex Crichton 已提交
161
    // Allows using #![no_core]
162
    (active, no_core, "1.3.0", Some(29639)),
A
Alex Crichton 已提交
163

164
    // Allows using `box` in patterns; RFC 469
165
    (active, box_patterns, "1.0.0", Some(29641)),
166

167 168
    // Allows using the unsafe_destructor_blind_to_params attribute;
    // RFC 1238
169
    (active, dropck_parametricity, "1.3.0", Some(28498)),
170

171 172 173
    // Allows using the may_dangle attribute; RFC 1327
    (active, dropck_eyepatch, "1.10.0", Some(34761)),

174
    // Allows the use of custom attributes; RFC 572
175
    (active, custom_attribute, "1.0.0", Some(29642)),
M
Manish Goregaokar 已提交
176

177 178
    // Allows the use of #[derive(Anything)] as sugar for
    // #[derive_Anything].
179
    (active, custom_derive, "1.0.0", Some(29644)),
180

M
Manish Goregaokar 已提交
181
    // Allows the use of rustc_* attributes; RFC 572
182
    (active, rustc_attrs, "1.0.0", Some(29642)),
H
Huon Wilson 已提交
183

184 185 186 187
    // Allows the use of #[allow_internal_unstable]. This is an
    // attribute on macro_rules! and can't use the attribute handling
    // below (it has to be checked before expansion possibly makes
    // macros disappear).
A
Aaron Turon 已提交
188 189
    //
    // rustc internal
190
    (active, allow_internal_unstable, "1.0.0", None),
191 192

    // #23121. Array patterns have some hazards yet.
193
    (active, slice_patterns, "1.0.0", Some(23121)),
194 195 196

    // Allows the definition of associated constants in `trait` or `impl`
    // blocks.
197
    (active, associated_consts, "1.0.0", Some(29646)),
N
Niko Matsakis 已提交
198 199

    // Allows the definition of `const fn` functions.
200
    (active, const_fn, "1.2.0", Some(24111)),
201

202
    // Allows indexing into constant arrays.
203
    (active, const_indexing, "1.4.0", Some(29947)),
204

205
    // Allows using #[prelude_import] on glob `use` items.
A
Aaron Turon 已提交
206 207
    //
    // rustc internal
208
    (active, prelude_import, "1.2.0", None),
209

B
Brian Anderson 已提交
210
    // Allows default type parameters to influence type inference.
211
    (active, default_type_parameter_fallback, "1.3.0", Some(27336)),
212 213

    // Allows associated type defaults
214
    (active, associated_type_defaults, "1.2.0", Some(29661)),
J
Jared Roesch 已提交
215

216
    // allow `repr(simd)`, and importing the various simd intrinsics
217
    (active, repr_simd, "1.4.0", Some(27731)),
218 219

    // Allows cfg(target_feature = "...").
220
    (active, cfg_target_feature, "1.4.0", Some(29717)),
221 222

    // allow `extern "platform-intrinsic" { ... }`
223
    (active, platform_intrinsics, "1.4.0", Some(27731)),
224 225

    // allow `#[unwind]`
A
Aaron Turon 已提交
226
    // rust runtime internal
227
    (active, unwind_attributes, "1.4.0", None),
V
Vadim Petrochenkov 已提交
228

T
Ticki 已提交
229
    // allow the use of `#[naked]` on functions.
230
    (active, naked_functions, "1.9.0", Some(32408)),
231 232

    // allow `#[no_debug]`
233
    (active, no_debug, "1.5.0", Some(29721)),
234 235

    // allow `#[omit_gdb_pretty_printer_section]`
A
Aaron Turon 已提交
236
    // rustc internal.
237
    (active, omit_gdb_pretty_printer_section, "1.5.0", None),
238 239

    // Allows cfg(target_vendor = "...").
240
    (active, cfg_target_vendor, "1.5.0", Some(29718)),
241 242

    // Allow attributes on expressions and non-item statements
243
    (active, stmt_expr_attributes, "1.6.0", Some(15701)),
244 245

    // allow using type ascription in expressions
246
    (active, type_ascription, "1.6.0", Some(23416)),
247 248

    // Allows cfg(target_thread_local)
249
    (active, cfg_target_thread_local, "1.7.0", Some(29594)),
250 251

    // rustc internal
252
    (active, abi_vectorcall, "1.7.0", None),
A
Alex Burka 已提交
253 254

    // a...b and ...b
255
    (active, inclusive_range_syntax, "1.7.0", Some(28237)),
J
Jorge Aparicio 已提交
256

257 258 259
    // X..Y patterns
    (active, exclusive_range_pattern, "1.11.0", Some(37854)),

A
Aaron Turon 已提交
260
    // impl specialization (RFC 1210)
261
    (active, specialization, "1.7.0", Some(31844)),
262 263

    // pub(restricted) visibilities (RFC 1422)
264 265
    (active, pub_restricted, "1.9.0", Some(32409)),

266 267 268 269
    // Allow Drop types in statics/const functions (RFC 1440)
    (active, drop_types_in_const, "1.9.0", Some(33156)),

    // Allows cfg(target_has_atomic = "...").
270 271
    (active, cfg_target_has_atomic, "1.9.0", Some(32976)),

272
    // Allows `impl Trait` in function return types.
273 274 275
    (active, conservative_impl_trait, "1.12.0", Some(34511)),

    // Permits numeric fields in struct expressions and patterns.
276 277 278
    (active, relaxed_adts, "1.12.0", Some(35626)),

    // The `!` type
279 280 281
    (active, never_type, "1.13.0", Some(35121)),

    // Allows all literals in attribute lists and values of key-value pairs.
282 283 284 285
    (active, attr_literals, "1.13.0", Some(34981)),

    // Allows the sysV64 ABI to be specified on all platforms
    // instead of just the platforms on which it is the C ABI
286 287
    (active, abi_sysv64, "1.13.0", Some(36167)),

288 289
    // Allows untagged unions `union U { ... }`
    (active, untagged_unions, "1.13.0", Some(32836)),
A
Andre Bogus 已提交
290

291 292 293
    // Used to identify the `compiler_builtins` crate
    // rustc internal
    (active, compiler_builtins, "1.13.0", None),
294 295 296

    // Allows attributes on lifetime/type formal parameters in generics (RFC 1327)
    (active, generic_param_attrs, "1.11.0", Some(34761)),
297

298 299
    // The #![windows_subsystem] attribute
    (active, windows_subsystem, "1.14.0", Some(37499)),
300

301 302
    // Allows #[link(..., cfg(..))]
    (active, link_cfg, "1.14.0", Some(37406)),
303 304

    (active, use_extern_macros, "1.15.0", Some(35896)),
305 306 307

    // Allows `break {expr}` with a value inside `loop`s.
    (active, loop_break_value, "1.14.0", Some(37339)),
308 309 310

    // Allows #[target_feature(...)]
    (active, target_feature, "1.15.0", None),
G
Guillaume Gomez 已提交
311

J
Jorge Aparicio 已提交
312 313
    // `extern "ptx-*" fn()`
    (active, abi_ptx, "1.15.0", None),
314 315

    // The `i128` type
E
est31 已提交
316
    (active, i128_type, "1.16.0", Some(35118)),
317 318 319

    // The `unadjusted` ABI. Perma unstable.
    (active, abi_unadjusted, "1.16.0", None),
320

321
    // Macros 1.1
322
    (active, proc_macro, "1.16.0", Some(38356)),
323

324 325
    // Allows attributes on struct literal fields.
    (active, struct_field_attributes, "1.16.0", Some(38814)),
326

V
Vadim Chugunov 已提交
327 328 329
    // Allows #[link(kind="static-nobundle"...]
    (active, static_nobundle, "1.16.0", Some(37403)),

330 331
    // `extern "msp430-interrupt" fn()`
    (active, abi_msp430_interrupt, "1.16.0", Some(38487)),
J
Jorge Aparicio 已提交
332

E
est31 已提交
333 334 335 336
    // Used to identify crates that contain sanitizer runtimes
    // rustc internal
    (active, closure_to_fn_coercion, "1.17.0", Some(39817)),

J
Jorge Aparicio 已提交
337 338 339
    // Used to identify crates that contain sanitizer runtimes
    // rustc internal
    (active, sanitizer_runtime, "1.17.0", None),
340 341 342

    // `extern "x86-interrupt" fn()`
    (active, abi_x86_interrupt, "1.17.0", Some(40180)),
343 344 345 346 347 348 349
);

declare_features! (
    (removed, import_shadowing, "1.0.0", None),
    (removed, managed_boxes, "1.0.0", None),
    // Allows use of unary negate on unsigned integers, e.g. -e for e: u8
    (removed, negate_unsigned, "1.0.0", Some(29645)),
E
est31 已提交
350
    (removed, reflect, "1.0.0", Some(27749)),
351 352 353 354 355
    // A way to temporarily opt out of opt in copy. This will *never* be accepted.
    (removed, opt_out_copy, "1.0.0", None),
    (removed, quad_precision_float, "1.0.0", None),
    (removed, struct_inherit, "1.0.0", None),
    (removed, test_removed_feature, "1.0.0", None),
356
    (removed, visible_private_types, "1.0.0", None),
357
    (removed, unsafe_no_drop_flag, "1.0.0", None),
358 359 360
    // Allows using items which are missing stability attributes
    // rustc internal
    (removed, unmarked_api, "1.0.0", None),
361
    (removed, pushpop_unsafe, "1.2.0", None),
362 363
);

364 365
declare_features! (
    (stable_removed, no_stack_check, "1.0.0", None),
366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381
);

declare_features! (
    (accepted, associated_types, "1.0.0", None),
    // allow overloading augmented assignment operations like `a += b`
    (accepted, augmented_assignments, "1.8.0", Some(28235)),
    // allow empty structs and enum variants with braces
    (accepted, braced_empty_structs, "1.8.0", Some(29720)),
    (accepted, default_type_params, "1.0.0", None),
    (accepted, globs, "1.0.0", None),
    (accepted, if_let, "1.0.0", None),
    // A temporary feature gate used to enable parser extensions needed
    // to bootstrap fix for #5723.
    (accepted, issue_5723_bootstrap, "1.0.0", None),
    (accepted, macro_rules, "1.0.0", None),
    // Allows using #![no_std]
382
    (accepted, no_std, "1.6.0", None),
383 384 385 386 387 388
    (accepted, slicing_syntax, "1.0.0", None),
    (accepted, struct_variant, "1.0.0", None),
    // These are used to test this portion of the compiler, they don't actually
    // mean anything
    (accepted, test_accepted_feature, "1.0.0", None),
    (accepted, tuple_indexing, "1.0.0", None),
D
Daniele Baracchi 已提交
389 390
    // Allows macros to appear in the type position.
    (accepted, type_macros, "1.13.0", Some(27245)),
391 392
    (accepted, while_let, "1.0.0", None),
    // Allows `#[deprecated]` attribute
393
    (accepted, deprecated, "1.9.0", Some(29935)),
N
Nick Cameron 已提交
394
    // `expr?`
395
    (accepted, question_mark, "1.13.0", Some(31436)),
396 397
    // Allows `..` in tuple (struct) patterns
    (accepted, dotdot_in_tuple_patterns, "1.14.0", Some(33627)),
J
Jeffrey Seyfried 已提交
398
    (accepted, item_like_imports, "1.14.0", Some(35120)),
399
    // Allows using `Self` and associated types in struct expressions and patterns.
400
    (accepted, more_struct_aliases, "1.16.0", Some(37544)),
E
est31 已提交
401 402
    // elide `'static` lifetimes in `static`s and `const`s
    (accepted, static_in_const, "1.17.0", Some(35897)),
E
est31 已提交
403 404
    // Allows field shorthands (`x` meaning `x: x`) in struct literal expressions.
    (accepted, field_init_shorthand, "1.17.0", Some(37340)),
T
Taylor Cramer 已提交
405 406
    // Allows the definition recursive static items.
    (accepted, static_recursion, "1.17.0", Some(29719)),
407
);
S
Steve Klabnik 已提交
408 409 410
// If you change this, please modify src/doc/unstable-book as well. You must
// move that documentation into the relevant place in the other docs, and
// remove the chapter on the flag.
411

412 413 414 415 416
#[derive(PartialEq, Copy, Clone, Debug)]
pub enum AttributeType {
    /// Normal, builtin attribute that is consumed
    /// by the compiler before the unused_attribute check
    Normal,
417

418 419 420 421
    /// Builtin attribute that may not be consumed by the compiler
    /// before the unused_attribute check. These attributes
    /// will be ignored by the unused_attribute lint
    Whitelisted,
422

423 424 425 426 427 428 429
    /// Builtin attribute that is only allowed at the crate level
    CrateLevel,
}

pub enum AttributeGate {
    /// Is gated by a given feature gate, reason
    /// and function to check if enabled
430
    Gated(Stability, &'static str, &'static str, fn(&Features) -> bool),
431 432 433 434 435

    /// Ungated attribute, can be used on all release channels
    Ungated,
}

N
Nick Cameron 已提交
436 437 438 439 440 441 442 443 444 445
impl AttributeGate {
    fn is_deprecated(&self) -> bool {
        match *self {
            Gated(Stability::Deprecated(_), ..) => true,
            _ => false,
        }
    }
}

#[derive(Copy, Clone, PartialEq, Eq, Debug)]
446 447
pub enum Stability {
    Unstable,
N
Nick Cameron 已提交
448 449
    // Argument is tracking issue link.
    Deprecated(&'static str),
450 451
}

452 453 454 455
// fn() is not Debug
impl ::std::fmt::Debug for AttributeGate {
    fn fmt(&self, fmt: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
        match *self {
N
Nick Cameron 已提交
456 457
            Gated(ref stab, ref name, ref expl, _) =>
                write!(fmt, "Gated({:?}, {}, {})", stab, name, expl),
458 459 460 461 462 463 464 465 466 467 468 469
            Ungated => write!(fmt, "Ungated")
        }
    }
}

macro_rules! cfg_fn {
    ($field: ident) => {{
        fn f(features: &Features) -> bool {
            features.$field
        }
        f as fn(&Features) -> bool
    }}
470 471
}

N
Nick Cameron 已提交
472
pub fn deprecated_attributes() -> Vec<&'static (&'static str, AttributeType, AttributeGate)> {
473
    BUILTIN_ATTRIBUTES.iter().filter(|a| a.2.is_deprecated()).collect()
N
Nick Cameron 已提交
474 475
}

476 477 478 479
pub fn is_builtin_attr(attr: &ast::Attribute) -> bool {
    BUILTIN_ATTRIBUTES.iter().any(|&(builtin_name, _, _)| attr.check_name(builtin_name))
}

480
// Attributes that have a special meaning to rustc or rustdoc
481
pub const BUILTIN_ATTRIBUTES: &'static [(&'static str, AttributeType, AttributeGate)] = &[
482 483
    // Normal attributes

484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513
    ("warn", Normal, Ungated),
    ("allow", Normal, Ungated),
    ("forbid", Normal, Ungated),
    ("deny", Normal, Ungated),

    ("macro_reexport", Normal, Ungated),
    ("macro_use", Normal, Ungated),
    ("macro_export", Normal, Ungated),
    ("plugin_registrar", Normal, Ungated),

    ("cfg", Normal, Ungated),
    ("cfg_attr", Normal, Ungated),
    ("main", Normal, Ungated),
    ("start", Normal, Ungated),
    ("test", Normal, Ungated),
    ("bench", Normal, Ungated),
    ("simd", Normal, Ungated),
    ("repr", Normal, Ungated),
    ("path", Normal, Ungated),
    ("abi", Normal, Ungated),
    ("automatically_derived", Normal, Ungated),
    ("no_mangle", Normal, Ungated),
    ("no_link", Normal, Ungated),
    ("derive", Normal, Ungated),
    ("should_panic", Normal, Ungated),
    ("ignore", Normal, Ungated),
    ("no_implicit_prelude", Normal, Ungated),
    ("reexport_test_harness_main", Normal, Ungated),
    ("link_args", Normal, Ungated),
    ("macro_escape", Normal, Ungated),
514

515
    // RFC #1445.
516 517
    ("structural_match", Whitelisted, Gated(Stability::Unstable,
                                            "structural_match",
518
                                            "the semantics of constant patterns is \
519 520
                                             not yet settled",
                                            cfg_fn!(structural_match))),
521

522 523
    ("plugin", CrateLevel, Gated(Stability::Unstable,
                                 "plugin",
524
                                 "compiler plugins are experimental \
525 526 527
                                  and possibly buggy",
                                 cfg_fn!(plugin))),

528
    ("no_std", CrateLevel, Ungated),
529 530
    ("no_core", CrateLevel, Gated(Stability::Unstable,
                                  "no_core",
531 532
                                  "no_core is experimental",
                                  cfg_fn!(no_core))),
533 534
    ("lang", Normal, Gated(Stability::Unstable,
                           "lang_items",
535 536
                           "language items are subject to change",
                           cfg_fn!(lang_items))),
537 538
    ("linkage", Whitelisted, Gated(Stability::Unstable,
                                   "linkage",
539
                                   "the `linkage` attribute is experimental \
540 541
                                    and not portable across platforms",
                                   cfg_fn!(linkage))),
542 543
    ("thread_local", Whitelisted, Gated(Stability::Unstable,
                                        "thread_local",
544 545 546
                                        "`#[thread_local]` is an experimental feature, and does \
                                         not currently handle destructors. There is no \
                                         corresponding `#[task_local]` mapping to the task \
547 548
                                         model",
                                        cfg_fn!(thread_local))),
549

550 551
    ("rustc_on_unimplemented", Normal, Gated(Stability::Unstable,
                                             "on_unimplemented",
552
                                             "the `#[rustc_on_unimplemented]` attribute \
553 554
                                              is an experimental feature",
                                             cfg_fn!(on_unimplemented))),
555 556
    ("allocator", Whitelisted, Gated(Stability::Unstable,
                                     "allocator",
557 558
                                     "the `#[allocator]` attribute is an experimental feature",
                                     cfg_fn!(allocator))),
559 560
    ("needs_allocator", Normal, Gated(Stability::Unstable,
                                      "needs_allocator",
561 562
                                      "the `#[needs_allocator]` \
                                       attribute is an experimental \
563 564
                                       feature",
                                      cfg_fn!(needs_allocator))),
565 566
    ("panic_runtime", Whitelisted, Gated(Stability::Unstable,
                                         "panic_runtime",
567 568 569
                                         "the `#[panic_runtime]` attribute is \
                                          an experimental feature",
                                         cfg_fn!(panic_runtime))),
570 571
    ("needs_panic_runtime", Whitelisted, Gated(Stability::Unstable,
                                               "needs_panic_runtime",
572 573 574 575
                                               "the `#[needs_panic_runtime]` \
                                                attribute is an experimental \
                                                feature",
                                               cfg_fn!(needs_panic_runtime))),
576 577
    ("rustc_variance", Normal, Gated(Stability::Unstable,
                                     "rustc_attrs",
578
                                     "the `#[rustc_variance]` attribute \
N
Niko Matsakis 已提交
579
                                      is just used for rustc unit tests \
580 581
                                      and will never be stable",
                                     cfg_fn!(rustc_attrs))),
582 583
    ("rustc_error", Whitelisted, Gated(Stability::Unstable,
                                       "rustc_attrs",
584
                                       "the `#[rustc_error]` attribute \
N
Niko Matsakis 已提交
585
                                        is just used for rustc unit tests \
586 587
                                        and will never be stable",
                                       cfg_fn!(rustc_attrs))),
588 589
    ("rustc_if_this_changed", Whitelisted, Gated(Stability::Unstable,
                                                 "rustc_attrs",
590 591 592 593
                                                 "the `#[rustc_if_this_changed]` attribute \
                                                  is just used for rustc unit tests \
                                                  and will never be stable",
                                                 cfg_fn!(rustc_attrs))),
594 595
    ("rustc_then_this_would_need", Whitelisted, Gated(Stability::Unstable,
                                                      "rustc_attrs",
596 597 598 599
                                                      "the `#[rustc_if_this_changed]` attribute \
                                                       is just used for rustc unit tests \
                                                       and will never be stable",
                                                      cfg_fn!(rustc_attrs))),
600 601
    ("rustc_dirty", Whitelisted, Gated(Stability::Unstable,
                                       "rustc_attrs",
602 603
                                       "the `#[rustc_dirty]` attribute \
                                        is just used for rustc unit tests \
604 605
                                        and will never be stable",
                                       cfg_fn!(rustc_attrs))),
606 607
    ("rustc_clean", Whitelisted, Gated(Stability::Unstable,
                                       "rustc_attrs",
608 609
                                       "the `#[rustc_clean]` attribute \
                                        is just used for rustc unit tests \
610 611
                                        and will never be stable",
                                       cfg_fn!(rustc_attrs))),
612 613
    ("rustc_metadata_dirty", Whitelisted, Gated(Stability::Unstable,
                                                "rustc_attrs",
614 615 616 617
                                                "the `#[rustc_metadata_dirty]` attribute \
                                                 is just used for rustc unit tests \
                                                 and will never be stable",
                                                 cfg_fn!(rustc_attrs))),
618 619
    ("rustc_metadata_clean", Whitelisted, Gated(Stability::Unstable,
                                                "rustc_attrs",
620 621 622 623
                                                "the `#[rustc_metadata_clean]` attribute \
                                                 is just used for rustc unit tests \
                                                 and will never be stable",
                                                 cfg_fn!(rustc_attrs))),
624 625
    ("rustc_partition_reused", Whitelisted, Gated(Stability::Unstable,
                                                  "rustc_attrs",
626 627 628 629
                                                  "this attribute \
                                                   is just used for rustc unit tests \
                                                   and will never be stable",
                                                  cfg_fn!(rustc_attrs))),
630 631
    ("rustc_partition_translated", Whitelisted, Gated(Stability::Unstable,
                                                      "rustc_attrs",
632 633 634 635
                                                      "this attribute \
                                                       is just used for rustc unit tests \
                                                       and will never be stable",
                                                      cfg_fn!(rustc_attrs))),
636 637
    ("rustc_symbol_name", Whitelisted, Gated(Stability::Unstable,
                                             "rustc_attrs",
638 639
                                             "internal rustc attributes will never be stable",
                                             cfg_fn!(rustc_attrs))),
640 641
    ("rustc_item_path", Whitelisted, Gated(Stability::Unstable,
                                           "rustc_attrs",
642 643
                                           "internal rustc attributes will never be stable",
                                           cfg_fn!(rustc_attrs))),
644 645
    ("rustc_move_fragments", Normal, Gated(Stability::Unstable,
                                           "rustc_attrs",
646
                                           "the `#[rustc_move_fragments]` attribute \
N
Niko Matsakis 已提交
647
                                            is just used for rustc unit tests \
648 649
                                            and will never be stable",
                                           cfg_fn!(rustc_attrs))),
650 651
    ("rustc_mir", Whitelisted, Gated(Stability::Unstable,
                                     "rustc_attrs",
652 653
                                     "the `#[rustc_mir]` attribute \
                                      is just used for rustc unit tests \
654 655
                                      and will never be stable",
                                     cfg_fn!(rustc_attrs))),
656 657
    ("rustc_inherit_overflow_checks", Whitelisted, Gated(Stability::Unstable,
                                                         "rustc_attrs",
658 659 660 661 662 663
                                                         "the `#[rustc_inherit_overflow_checks]` \
                                                          attribute is just used to control \
                                                          overflow checking behavior of several \
                                                          libcore functions that are inlined \
                                                          across crates and will never be stable",
                                                          cfg_fn!(rustc_attrs))),
664 665
    ("compiler_builtins", Whitelisted, Gated(Stability::Unstable,
                                             "compiler_builtins",
666 667 668 669 670
                                             "the `#[compiler_builtins]` attribute is used to \
                                              identify the `compiler_builtins` crate which \
                                              contains compiler-rt intrinsics and will never be \
                                              stable",
                                          cfg_fn!(compiler_builtins))),
J
Jorge Aparicio 已提交
671 672 673 674 675 676
    ("sanitizer_runtime", Whitelisted, Gated(Stability::Unstable,
                                             "sanitizer_runtime",
                                             "the `#[sanitizer_runtime]` attribute is used to \
                                              identify crates that contain the runtime of a \
                                              sanitizer and will never be stable",
                                             cfg_fn!(sanitizer_runtime))),
677

678 679
    ("allow_internal_unstable", Normal, Gated(Stability::Unstable,
                                              "allow_internal_unstable",
680 681
                                              EXPLAIN_ALLOW_INTERNAL_UNSTABLE,
                                              cfg_fn!(allow_internal_unstable))),
682

683 684
    ("fundamental", Whitelisted, Gated(Stability::Unstable,
                                       "fundamental",
685
                                       "the `#[fundamental]` attribute \
686 687
                                        is an experimental feature",
                                       cfg_fn!(fundamental))),
688

689
    ("proc_macro_derive", Normal, Ungated),
690

691 692
    ("rustc_copy_clone_marker", Whitelisted, Gated(Stability::Unstable,
                                                   "rustc_attrs",
693 694 695
                                                   "internal implementation detail",
                                                   cfg_fn!(rustc_attrs))),

696
    // FIXME: #14408 whitelist docs since rustdoc looks at them
697
    ("doc", Whitelisted, Ungated),
698 699 700

    // FIXME: #14406 these are processed in trans, which happens after the
    // lint pass
701
    ("cold", Whitelisted, Ungated),
702 703
    ("naked", Whitelisted, Gated(Stability::Unstable,
                                 "naked_functions",
T
Ticki 已提交
704
                                 "the `#[naked]` attribute \
705
                                  is an experimental feature",
706
                                 cfg_fn!(naked_functions))),
707 708 709 710
    ("target_feature", Whitelisted, Gated(
        Stability::Unstable, "target_feature",
        "the `#[target_feature]` attribute is an experimental feature",
        cfg_fn!(target_feature))),
711 712 713 714 715 716 717
    ("export_name", Whitelisted, Ungated),
    ("inline", Whitelisted, Ungated),
    ("link", Whitelisted, Ungated),
    ("link_name", Whitelisted, Ungated),
    ("link_section", Whitelisted, Ungated),
    ("no_builtins", Whitelisted, Ungated),
    ("no_mangle", Whitelisted, Ungated),
N
Nick Cameron 已提交
718 719 720 721 722
    ("no_debug", Whitelisted, Gated(
        Stability::Deprecated("https://github.com/rust-lang/rust/issues/29721"),
        "no_debug",
        "the `#[no_debug]` attribute is an experimental feature",
        cfg_fn!(no_debug))),
723 724
    ("omit_gdb_pretty_printer_section", Whitelisted, Gated(Stability::Unstable,
                                                       "omit_gdb_pretty_printer_section",
725 726
                                                       "the `#[omit_gdb_pretty_printer_section]` \
                                                        attribute is just used for the Rust test \
727 728
                                                        suite",
                                                       cfg_fn!(omit_gdb_pretty_printer_section))),
729 730
    ("unsafe_destructor_blind_to_params",
     Normal,
731
     Gated(Stability::Deprecated("https://github.com/rust-lang/rust/issues/34761"),
732
           "dropck_parametricity",
733 734
           "unsafe_destructor_blind_to_params has been replaced by \
            may_dangle and will be removed in the future",
735
           cfg_fn!(dropck_parametricity))),
736 737
    ("may_dangle",
     Normal,
738 739
     Gated(Stability::Unstable,
           "dropck_eyepatch",
740 741
           "may_dangle has unstable semantics and may be removed in the future",
           cfg_fn!(dropck_eyepatch))),
742 743 744
    ("unwind", Whitelisted, Gated(Stability::Unstable,
                                  "unwind_attributes",
                                  "#[unwind] is experimental",
745
                                  cfg_fn!(unwind_attributes))),
746 747

    // used in resolve
748 749
    ("prelude_import", Whitelisted, Gated(Stability::Unstable,
                                          "prelude_import",
750 751
                                          "`#[prelude_import]` is for use by rustc only",
                                          cfg_fn!(prelude_import))),
752 753 754

    // FIXME: #14407 these are only looked at on-demand so we can't
    // guarantee they'll have already been checked
755
    ("rustc_deprecated", Whitelisted, Ungated),
756 757 758
    ("must_use", Whitelisted, Ungated),
    ("stable", Whitelisted, Ungated),
    ("unstable", Whitelisted, Ungated),
759
    ("deprecated", Normal, Ungated),
760

761 762
    ("rustc_paren_sugar", Normal, Gated(Stability::Unstable,
                                        "unboxed_closures",
763 764
                                        "unboxed_closures are still evolving",
                                        cfg_fn!(unboxed_closures))),
765

766 767 768
    ("windows_subsystem", Whitelisted, Gated(Stability::Unstable,
                                             "windows_subsystem",
                                             "the windows subsystem attribute \
A
Alex Crichton 已提交
769
                                              is currently unstable",
770 771
                                             cfg_fn!(windows_subsystem))),

772 773 774 775 776
    ("proc_macro_attribute", Normal, Gated(Stability::Unstable,
                                           "proc_macro",
                                           "attribute proc macros are currently unstable",
                                           cfg_fn!(proc_macro))),

777 778 779 780 781
    ("proc_macro", Normal, Gated(Stability::Unstable,
                                 "proc_macro",
                                 "function-like proc macros are currently unstable",
                                 cfg_fn!(proc_macro))),

782 783 784 785 786
    ("rustc_derive_registrar", Normal, Gated(Stability::Unstable,
                                             "rustc_derive_registrar",
                                             "used internally by rustc",
                                             cfg_fn!(rustc_attrs))),

787
    // Crate level attributes
788 789 790 791 792 793 794 795
    ("crate_name", CrateLevel, Ungated),
    ("crate_type", CrateLevel, Ungated),
    ("crate_id", CrateLevel, Ungated),
    ("feature", CrateLevel, Ungated),
    ("no_start", CrateLevel, Ungated),
    ("no_main", CrateLevel, Ungated),
    ("no_builtins", CrateLevel, Ungated),
    ("recursion_limit", CrateLevel, Ungated),
796
    ("type_length_limit", CrateLevel, Ungated),
797 798
];

799 800 801
// cfg(...)'s that are feature gated
const GATED_CFGS: &'static [(&'static str, &'static str, fn(&Features) -> bool)] = &[
    // (name in cfg, feature, function to check if the feature is enabled)
802 803 804
    ("target_feature", "cfg_target_feature", cfg_fn!(cfg_target_feature)),
    ("target_vendor", "cfg_target_vendor", cfg_fn!(cfg_target_vendor)),
    ("target_thread_local", "cfg_target_thread_local", cfg_fn!(cfg_target_thread_local)),
805
    ("target_has_atomic", "cfg_target_has_atomic", cfg_fn!(cfg_target_has_atomic)),
806 807 808 809 810 811 812
];

#[derive(Debug, Eq, PartialEq)]
pub struct GatedCfg {
    span: Span,
    index: usize,
}
813

814 815
impl GatedCfg {
    pub fn gate(cfg: &ast::MetaItem) -> Option<GatedCfg> {
816
        let name = &*cfg.name().as_str();
817 818 819 820 821 822 823 824 825
        GATED_CFGS.iter()
                  .position(|info| info.0 == name)
                  .map(|idx| {
                      GatedCfg {
                          span: cfg.span,
                          index: idx
                      }
                  })
    }
J
Jeffrey Seyfried 已提交
826 827

    pub fn check_and_emit(&self, sess: &ParseSess, features: &Features) {
828
        let (cfg, feature, has_feature) = GATED_CFGS[self.index];
J
Jeffrey Seyfried 已提交
829
        if !has_feature(features) && !sess.codemap().span_allows_unstable(self.span) {
830
            let explain = format!("`cfg({})` is experimental and subject to change", cfg);
831
            emit_feature_err(sess, feature, self.span, GateIssue::Language, &explain);
832 833 834 835
        }
    }
}

E
Eduard Burtescu 已提交
836
struct Context<'a> {
L
Leo Testard 已提交
837
    features: &'a Features,
838
    parse_sess: &'a ParseSess,
C
Corey Richardson 已提交
839
    cm: &'a CodeMap,
840
    plugin_attributes: &'a [(String, AttributeType)],
841 842
}

843 844 845 846 847 848
macro_rules! gate_feature_fn {
    ($cx: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{
        let (cx, has_feature, span, name, explain) = ($cx, $has_feature, $span, $name, $explain);
        let has_feature: bool = has_feature(&$cx.features);
        debug!("gate_feature(feature = {:?}, span = {:?}); has? {}", name, span, has_feature);
        if !has_feature && !cx.cm.span_allows_unstable(span) {
849
            emit_feature_err(cx.parse_sess, name, span, GateIssue::Language, explain);
850
        }
851 852 853 854 855 856
    }}
}

macro_rules! gate_feature {
    ($cx: expr, $feature: ident, $span: expr, $explain: expr) => {
        gate_feature_fn!($cx, |x:&Features| x.$feature, $span, stringify!($feature), $explain)
857
    }
858
}
859

860
impl<'a> Context<'a> {
861
    fn check_attribute(&self, attr: &ast::Attribute, is_macro: bool) {
862
        debug!("check_attribute(attr = {:?})", attr);
863
        let name = &*attr.name().as_str();
864
        for &(n, ty, ref gateage) in BUILTIN_ATTRIBUTES {
865
            if n == name {
866
                if let &Gated(_, ref name, ref desc, ref has_feature) = gateage {
867
                    gate_feature_fn!(self, has_feature, attr.span, name, desc);
868
                }
869
                debug!("check_attribute: {:?} is builtin, {:?}, {:?}", name, ty, gateage);
870 871 872
                return;
            }
        }
873
        for &(ref n, ref ty) in self.plugin_attributes {
874
            if n == name {
875
                // Plugins can't gate attributes, so we don't check for it
M
Manish Goregaokar 已提交
876 877
                // unlike the code above; we only use this loop to
                // short-circuit to avoid the checks below
878 879 880 881
                debug!("check_attribute: {:?} is registered by a plugin, {:?}", name, ty);
                return;
            }
        }
882
        if name.starts_with("rustc_") {
883 884 885 886
            gate_feature!(self, rustc_attrs, attr.span,
                          "unless otherwise specified, attributes \
                           with the prefix `rustc_` \
                           are reserved for internal compiler diagnostics");
887
        } else if name.starts_with("derive_") {
L
Leo Testard 已提交
888
            gate_feature!(self, custom_derive, attr.span, EXPLAIN_DERIVE_UNDERSCORE);
889 890
        } else if attr::is_known(attr) {
            debug!("check_attribute: {:?} is known", name);
891
        } else {
M
Manish Goregaokar 已提交
892 893 894 895
            // Only run the custom attribute lint during regular
            // feature gate checking. Macro gating runs
            // before the plugin attributes are registered
            // so we skip this then
896
            if !is_macro {
897 898 899 900 901 902
                gate_feature!(self, custom_attribute, attr.span,
                              &format!("The attribute `{}` is currently \
                                        unknown to the compiler and \
                                        may have meaning \
                                        added to it in the future",
                                       name));
903
            }
904 905
        }
    }
906 907
}

908
pub fn check_attribute(attr: &ast::Attribute, parse_sess: &ParseSess,
L
Leo Testard 已提交
909 910
                       cm: &CodeMap, features: &Features) {
    let cx = Context {
911
        features: features, parse_sess: parse_sess,
L
Leo Testard 已提交
912 913 914 915 916
        cm: cm, plugin_attributes: &[]
    };
    cx.check_attribute(attr, true);
}

917 918 919 920
pub fn find_lang_feature_accepted_version(feature: &str) -> Option<&'static str> {
    ACCEPTED_FEATURES.iter().find(|t| t.0 == feature).map(|t| t.1)
}

921
fn find_lang_feature_issue(feature: &str) -> Option<u32> {
922 923
    if let Some(info) = ACTIVE_FEATURES.iter().find(|t| t.0 == feature) {
        let issue = info.2;
924 925
        // FIXME (#28244): enforce that active features have issue numbers
        // assert!(issue.is_some())
926 927
        issue
    } else {
928 929 930 931
        // search in Accepted, Removed, or Stable Removed features
        let found = ACCEPTED_FEATURES.iter().chain(REMOVED_FEATURES).chain(STABLE_REMOVED_FEATURES)
            .find(|t| t.0 == feature);
        match found {
932 933 934
            Some(&(_, _, issue)) => issue,
            None => panic!("Feature `{}` is not declared anywhere", feature),
        }
935 936 937 938 939 940 941 942
    }
}

pub enum GateIssue {
    Language,
    Library(Option<u32>)
}

943
pub fn emit_feature_err(sess: &ParseSess, feature: &str, span: Span, issue: GateIssue,
944
                        explain: &str) {
945 946 947 948 949
    feature_err(sess, feature, span, issue, explain).emit();
}

pub fn feature_err<'a>(sess: &'a ParseSess, feature: &str, span: Span, issue: GateIssue,
                   explain: &str) -> DiagnosticBuilder<'a> {
950 951
    let diag = &sess.span_diagnostic;

952 953 954 955 956
    let issue = match issue {
        GateIssue::Language => find_lang_feature_issue(feature),
        GateIssue::Library(lib) => lib,
    };

N
Nick Cameron 已提交
957 958
    let mut err = if let Some(n) = issue {
        diag.struct_span_err(span, &format!("{} (see issue #{})", explain, n))
959
    } else {
N
Nick Cameron 已提交
960 961
        diag.struct_span_err(span, explain)
    };
962 963

    // #23973: do not suggest `#![feature(...)]` if we are in beta/stable
T
Tim Neumann 已提交
964 965 966 967
    if sess.unstable_features.is_nightly_build() {
        err.help(&format!("add #![feature({})] to the \
                           crate attributes to enable",
                          feature));
N
Nick Cameron 已提交
968
    }
T
Tim Neumann 已提交
969

970
    err
971 972
}

L
Leo Testard 已提交
973 974 975
const EXPLAIN_BOX_SYNTAX: &'static str =
    "box expression syntax is experimental; you can call `Box::new` instead.";

J
Jeffrey Seyfried 已提交
976
pub const EXPLAIN_STMT_ATTR_SYNTAX: &'static str =
L
Leo Testard 已提交
977 978
    "attributes on non-item statements and expressions are experimental.";

979 980 981
pub const EXPLAIN_ASM: &'static str =
    "inline assembly is not stable enough for use and is subject to change";

982 983 984 985 986 987 988 989
pub const EXPLAIN_LOG_SYNTAX: &'static str =
    "`log_syntax!` is not stable enough for use and is subject to change";

pub const EXPLAIN_CONCAT_IDENTS: &'static str =
    "`concat_idents` is not stable enough for use and is subject to change";

pub const EXPLAIN_TRACE_MACROS: &'static str =
    "`trace_macros` is not stable enough for use and is subject to change";
990 991
pub const EXPLAIN_ALLOW_INTERNAL_UNSTABLE: &'static str =
    "allow_internal_unstable side-steps feature gating and stability checks";
992

993
pub const EXPLAIN_CUSTOM_DERIVE: &'static str =
994
    "`#[derive]` for custom traits is deprecated and will be removed in the future.";
N
Nick Cameron 已提交
995 996

pub const EXPLAIN_DEPR_CUSTOM_DERIVE: &'static str =
997 998
    "`#[derive]` for custom traits is deprecated and will be removed in the future. \
    Prefer using procedural macro custom derive.";
999

L
Leo Testard 已提交
1000 1001
pub const EXPLAIN_DERIVE_UNDERSCORE: &'static str =
    "attributes of the form `#[derive_*]` are reserved for the compiler";
1002

L
Leo Testard 已提交
1003 1004
pub const EXPLAIN_PLACEMENT_IN: &'static str =
    "placement-in expression syntax is experimental and subject to change.";
C
Corey Richardson 已提交
1005

E
est31 已提交
1006 1007 1008
pub const CLOSURE_TO_FN_COERCION: &'static str =
    "non-capturing closure to fn coercion is experimental";

C
Corey Richardson 已提交
1009
struct PostExpansionVisitor<'a> {
N
Nick Cameron 已提交
1010
    context: &'a Context<'a>,
C
Corey Richardson 已提交
1011 1012
}

1013 1014 1015 1016 1017
macro_rules! gate_feature_post {
    ($cx: expr, $feature: ident, $span: expr, $explain: expr) => {{
        let (cx, span) = ($cx, $span);
        if !cx.context.cm.span_allows_unstable(span) {
            gate_feature!(cx.context, $feature, span, $explain)
C
Corey Richardson 已提交
1018
        }
1019
    }}
C
Corey Richardson 已提交
1020 1021
}

1022 1023 1024
impl<'a> PostExpansionVisitor<'a> {
    fn check_abi(&self, abi: Abi, span: Span) {
        match abi {
1025
            Abi::RustIntrinsic => {
1026
                gate_feature_post!(&self, intrinsics, span,
1027 1028
                                   "intrinsics are subject to change");
            },
1029 1030
            Abi::PlatformIntrinsic => {
                gate_feature_post!(&self, platform_intrinsics, span,
1031
                                   "platform intrinsics are experimental and possibly buggy");
1032 1033 1034
            },
            Abi::Vectorcall => {
                gate_feature_post!(&self, abi_vectorcall, span,
1035 1036
                                   "vectorcall is experimental and subject to change");
            },
1037 1038 1039
            Abi::RustCall => {
                gate_feature_post!(&self, unboxed_closures, span,
                                   "rust-call ABI is subject to change");
1040 1041 1042 1043 1044
            },
            Abi::SysV64 => {
                gate_feature_post!(&self, abi_sysv64, span,
                                   "sysv64 ABI is experimental and subject to change");
            },
J
Jorge Aparicio 已提交
1045 1046 1047
            Abi::PtxKernel => {
                gate_feature_post!(&self, abi_ptx, span,
                                   "PTX ABIs are experimental and subject to change");
1048 1049 1050 1051 1052
            },
            Abi::Unadjusted => {
                gate_feature_post!(&self, abi_unadjusted, span,
                                   "unadjusted ABI is an implementation detail and perma-unstable");
            },
1053 1054 1055 1056
            Abi::Msp430Interrupt => {
                gate_feature_post!(&self, abi_msp430_interrupt, span,
                                   "msp430-interrupt ABI is experimental and subject to change");
            },
1057 1058 1059 1060
            Abi::X86Interrupt => {
                gate_feature_post!(&self, abi_x86_interrupt, span,
                                   "x86-interrupt ABI is experimental and subject to change");
            },
J
Jorge Aparicio 已提交
1061 1062 1063 1064 1065 1066 1067 1068 1069
            // Stable
            Abi::Cdecl |
            Abi::Stdcall |
            Abi::Fastcall |
            Abi::Aapcs |
            Abi::Win64 |
            Abi::Rust |
            Abi::C |
            Abi::System => {}
1070 1071 1072 1073
        }
    }
}

1074 1075 1076 1077 1078
fn contains_novel_literal(item: &ast::MetaItem) -> bool {
    use ast::MetaItemKind::*;
    use ast::NestedMetaItemKind::*;

    match item.node {
1079 1080 1081
        Word => false,
        NameValue(ref lit) => !lit.node.is_str(),
        List(ref list) => list.iter().any(|li| {
1082
            match li.node {
1083
                MetaItem(ref mi) => contains_novel_literal(&mi),
1084 1085 1086 1087 1088 1089
                Literal(_) => true,
            }
        }),
    }
}

1090 1091 1092 1093
fn starts_with_digit(s: &str) -> bool {
    s.as_bytes().first().cloned().map_or(false, |b| b >= b'0' && b <= b'9')
}

1094
impl<'a> Visitor<'a> for PostExpansionVisitor<'a> {
1095 1096
    fn visit_attribute(&mut self, attr: &ast::Attribute) {
        if !self.context.cm.span_allows_unstable(attr.span) {
1097
            // check for gated attributes
1098
            self.context.check_attribute(attr, false);
1099
        }
1100

1101
        if contains_novel_literal(&attr.value) {
1102 1103 1104 1105
            gate_feature_post!(&self, attr_literals, attr.span,
                               "non-string literals in attributes, or string \
                               literals in top-level positions, are experimental");
        }
1106 1107
    }

1108
    fn visit_name(&mut self, sp: Span, name: ast::Name) {
1109
        if !name.as_str().is_ascii() {
1110 1111
            gate_feature_post!(&self, non_ascii_idents, sp,
                               "non-ascii idents are not fully supported.");
1112 1113 1114
        }
    }

1115
    fn visit_item(&mut self, i: &'a ast::Item) {
1116
        match i.node {
1117
            ast::ItemKind::ExternCrate(_) => {
1118
                if attr::contains_name(&i.attrs[..], "macro_reexport") {
1119 1120 1121
                    gate_feature_post!(&self, macro_reexport, i.span,
                                       "macros reexports are experimental \
                                        and possibly buggy");
1122 1123 1124
                }
            }

1125
            ast::ItemKind::ForeignMod(ref foreign_module) => {
1126
                if attr::contains_name(&i.attrs[..], "link_args") {
1127
                    gate_feature_post!(&self, link_args, i.span,
1128 1129 1130 1131
                                      "the `link_args` attribute is not portable \
                                       across platforms, it is recommended to \
                                       use `#[link(name = \"foo\")]` instead")
                }
1132
                self.check_abi(foreign_module.abi, i.span);
1133 1134
            }

1135
            ast::ItemKind::Fn(..) => {
1136
                if attr::contains_name(&i.attrs[..], "plugin_registrar") {
1137 1138
                    gate_feature_post!(&self, plugin_registrar, i.span,
                                       "compiler plugins are experimental and possibly buggy");
1139
                }
1140
                if attr::contains_name(&i.attrs[..], "start") {
1141
                    gate_feature_post!(&self, start, i.span,
1142 1143 1144 1145
                                      "a #[start] function is an experimental \
                                       feature whose signature may change \
                                       over time");
                }
1146
                if attr::contains_name(&i.attrs[..], "main") {
1147 1148 1149 1150
                    gate_feature_post!(&self, main, i.span,
                                       "declaration of a nonstandard #[main] \
                                        function may change over time, for now \
                                        a top-level `fn main()` is required");
1151
                }
1152 1153
            }

1154
            ast::ItemKind::Struct(..) => {
1155
                if attr::contains_name(&i.attrs[..], "simd") {
1156 1157
                    gate_feature_post!(&self, simd, i.span,
                                       "SIMD types are experimental and possibly buggy");
1158 1159 1160 1161
                    self.context.parse_sess.span_diagnostic.span_warn(i.span,
                                                                      "the `#[simd]` attribute \
                                                                       is deprecated, use \
                                                                       `#[repr(simd)]` instead");
1162 1163 1164 1165
                }
                for attr in &i.attrs {
                    if attr.name() == "repr" {
                        for item in attr.meta_item_list().unwrap_or(&[]) {
1166
                            if item.check_name("simd") {
1167 1168 1169
                                gate_feature_post!(&self, repr_simd, i.span,
                                                   "SIMD types are experimental \
                                                    and possibly buggy");
1170 1171 1172 1173

                            }
                        }
                    }
1174
                }
D
David Manescu 已提交
1175 1176
            }

1177 1178 1179
            ast::ItemKind::Union(..) => {
                gate_feature_post!(&self, untagged_unions,
                                   i.span,
V
Vadim Petrochenkov 已提交
1180
                                   "unions are unstable and possibly buggy");
1181 1182
            }

1183
            ast::ItemKind::DefaultImpl(..) => {
1184 1185 1186 1187
                gate_feature_post!(&self, optin_builtin_traits,
                                   i.span,
                                   "default trait implementations are experimental \
                                    and possibly buggy");
F
Flavio Percoco 已提交
1188 1189
            }

1190
            ast::ItemKind::Impl(_, polarity, _, _, _, _) => {
1191 1192
                match polarity {
                    ast::ImplPolarity::Negative => {
1193 1194 1195 1196
                        gate_feature_post!(&self, optin_builtin_traits,
                                           i.span,
                                           "negative trait bounds are not yet fully implemented; \
                                            use marker types for now");
1197 1198 1199
                    },
                    _ => {}
                }
1200 1201
            }

1202 1203 1204
            _ => {}
        }

1205
        visit::walk_item(self, i);
1206
    }
1207

1208
    fn visit_foreign_item(&mut self, i: &'a ast::ForeignItem) {
1209 1210
        let links_to_llvm = match attr::first_attr_value_str_by_name(&i.attrs, "link_name") {
            Some(val) => val.as_str().starts_with("llvm."),
1211 1212 1213
            _ => false
        };
        if links_to_llvm {
1214
            gate_feature_post!(&self, link_llvm_intrinsics, i.span,
1215 1216 1217
                              "linking to LLVM intrinsics is experimental");
        }

1218
        visit::walk_foreign_item(self, i)
1219 1220
    }

1221
    fn visit_ty(&mut self, ty: &'a ast::Ty) {
1222 1223 1224 1225
        match ty.node {
            ast::TyKind::BareFn(ref bare_fn_ty) => {
                self.check_abi(bare_fn_ty.abi, ty.span);
            }
1226 1227 1228 1229
            ast::TyKind::ImplTrait(..) => {
                gate_feature_post!(&self, conservative_impl_trait, ty.span,
                                   "`impl Trait` is experimental");
            }
A
Andrew Cann 已提交
1230 1231
            ast::TyKind::Never => {
                gate_feature_post!(&self, never_type, ty.span,
1232 1233
                                   "The `!` type is experimental");
            },
1234 1235 1236 1237 1238
            _ => {}
        }
        visit::walk_ty(self, ty)
    }

1239
    fn visit_fn_ret_ty(&mut self, ret_ty: &'a ast::FunctionRetTy) {
1240 1241
        if let ast::FunctionRetTy::Ty(ref output_ty) = *ret_ty {
            match output_ty.node {
A
Andrew Cann 已提交
1242
                ast::TyKind::Never => return,
1243 1244
                _ => (),
            };
A
Andrew Cann 已提交
1245
            self.visit_ty(output_ty)
1246 1247 1248
        }
    }

1249
    fn visit_expr(&mut self, e: &'a ast::Expr) {
1250
        match e.node {
1251
            ast::ExprKind::Box(_) => {
1252
                gate_feature_post!(&self, box_syntax, e.span, EXPLAIN_BOX_SYNTAX);
1253
            }
1254
            ast::ExprKind::Type(..) => {
1255
                gate_feature_post!(&self, type_ascription, e.span,
1256 1257
                                  "type ascription is experimental");
            }
1258
            ast::ExprKind::Range(_, _, ast::RangeLimits::Closed) => {
1259
                gate_feature_post!(&self, inclusive_range_syntax,
A
Alex Burka 已提交
1260 1261 1262
                                  e.span,
                                  "inclusive range syntax is experimental");
            }
1263 1264 1265
            ast::ExprKind::InPlace(..) => {
                gate_feature_post!(&self, placement_in_syntax, e.span, EXPLAIN_PLACEMENT_IN);
            }
1266 1267
            ast::ExprKind::Struct(_, ref fields, _) => {
                for field in fields {
1268 1269 1270 1271 1272
                    if starts_with_digit(&field.ident.node.name.as_str()) {
                        gate_feature_post!(&self, relaxed_adts,
                                          field.span,
                                          "numeric fields in struct expressions are unstable");
                    }
1273 1274
                }
            }
1275 1276 1277 1278
            ast::ExprKind::Break(_, Some(_)) => {
                gate_feature_post!(&self, loop_break_value, e.span,
                                   "`break` with a value is experimental");
            }
1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290
            ast::ExprKind::Lit(ref lit) => {
                if let ast::LitKind::Int(_, ref ty) = lit.node {
                    match *ty {
                        ast::LitIntType::Signed(ast::IntTy::I128) |
                        ast::LitIntType::Unsigned(ast::UintTy::U128) => {
                            gate_feature_post!(&self, i128_type, e.span,
                                               "128-bit integers are not stable");
                        }
                        _ => {}
                    }
                }
            }
1291 1292
            _ => {}
        }
1293
        visit::walk_expr(self, e);
1294
    }
1295

1296
    fn visit_pat(&mut self, pattern: &'a ast::Pat) {
1297
        match pattern.node {
1298
            PatKind::Slice(_, Some(_), ref last) if !last.is_empty() => {
1299
                gate_feature_post!(&self, advanced_slice_patterns,
1300 1301 1302
                                  pattern.span,
                                  "multiple-element slice matches anywhere \
                                   but at the end of a slice (e.g. \
1303
                                   `[0, ..xs, 0]`) are experimental")
1304
            }
1305
            PatKind::Slice(..) => {
1306
                gate_feature_post!(&self, slice_patterns,
1307 1308 1309
                                  pattern.span,
                                  "slice pattern syntax is experimental");
            }
1310
            PatKind::Box(..) => {
1311
                gate_feature_post!(&self, box_patterns,
1312
                                  pattern.span,
1313
                                  "box pattern syntax is experimental");
1314
            }
1315 1316 1317 1318 1319 1320 1321 1322
            PatKind::Struct(_, ref fields, _) => {
                for field in fields {
                    if starts_with_digit(&field.node.ident.name.as_str()) {
                        gate_feature_post!(&self, relaxed_adts,
                                          field.span,
                                          "numeric fields in struct patterns are unstable");
                    }
                }
1323
            }
1324 1325 1326 1327
            PatKind::Range(_, _, RangeEnd::Excluded) => {
                gate_feature_post!(&self, exclusive_range_pattern, pattern.span,
                                   "exclusive range pattern syntax is experimental");
            }
1328 1329
            _ => {}
        }
1330
        visit::walk_pat(self, pattern)
1331 1332
    }

1333
    fn visit_fn(&mut self,
1334 1335
                fn_kind: FnKind<'a>,
                fn_decl: &'a ast::FnDecl,
1336
                span: Span,
1337
                _node_id: NodeId) {
N
Niko Matsakis 已提交
1338 1339
        // check for const fn declarations
        match fn_kind {
1340
            FnKind::ItemFn(_, _, _, Spanned { node: ast::Constness::Const, .. }, _, _, _) => {
1341
                gate_feature_post!(&self, const_fn, span, "const fn is unstable");
N
Niko Matsakis 已提交
1342 1343 1344 1345 1346 1347 1348 1349 1350
            }
            _ => {
                // stability of const fn methods are covered in
                // visit_trait_item and visit_impl_item below; this is
                // because default methods don't pass through this
                // point.
            }
        }

1351
        match fn_kind {
1352 1353
            FnKind::ItemFn(_, _, _, _, abi, _, _) |
            FnKind::Method(_, &ast::MethodSig { abi, .. }, _, _) => {
1354 1355
                self.check_abi(abi, span);
            }
1356 1357
            _ => {}
        }
1358
        visit::walk_fn(self, fn_kind, fn_decl, span);
1359
    }
1360

1361
    fn visit_trait_item(&mut self, ti: &'a ast::TraitItem) {
1362
        match ti.node {
1363
            ast::TraitItemKind::Const(..) => {
1364
                gate_feature_post!(&self, associated_consts,
1365 1366 1367
                                  ti.span,
                                  "associated constants are experimental")
            }
1368 1369 1370 1371
            ast::TraitItemKind::Method(ref sig, ref block) => {
                if block.is_none() {
                    self.check_abi(sig.abi, ti.span);
                }
1372
                if sig.constness.node == ast::Constness::Const {
1373
                    gate_feature_post!(&self, const_fn, ti.span, "const fn is unstable");
N
Niko Matsakis 已提交
1374 1375
                }
            }
1376
            ast::TraitItemKind::Type(_, Some(_)) => {
1377
                gate_feature_post!(&self, associated_type_defaults, ti.span,
1378 1379
                                  "associated type defaults are unstable");
            }
1380 1381 1382 1383 1384
            _ => {}
        }
        visit::walk_trait_item(self, ti);
    }

1385
    fn visit_impl_item(&mut self, ii: &'a ast::ImplItem) {
A
Aaron Turon 已提交
1386
        if ii.defaultness == ast::Defaultness::Default {
1387
            gate_feature_post!(&self, specialization,
A
Aaron Turon 已提交
1388 1389 1390 1391
                              ii.span,
                              "specialization is unstable");
        }

1392
        match ii.node {
1393
            ast::ImplItemKind::Const(..) => {
1394
                gate_feature_post!(&self, associated_consts,
1395 1396 1397
                                  ii.span,
                                  "associated constants are experimental")
            }
1398
            ast::ImplItemKind::Method(ref sig, _) => {
1399
                if sig.constness.node == ast::Constness::Const {
1400
                    gate_feature_post!(&self, const_fn, ii.span, "const fn is unstable");
N
Niko Matsakis 已提交
1401 1402
                }
            }
1403 1404 1405 1406
            _ => {}
        }
        visit::walk_impl_item(self, ii);
    }
1407

1408
    fn visit_vis(&mut self, vis: &'a ast::Visibility) {
1409 1410
        let span = match *vis {
            ast::Visibility::Crate(span) => span,
1411
            ast::Visibility::Restricted { ref path, .. } => path.span,
1412 1413
            _ => return,
        };
1414
        gate_feature_post!(&self, pub_restricted, span, "`pub(restricted)` syntax is experimental");
1415 1416

        visit::walk_vis(self, vis)
1417
    }
1418

1419
    fn visit_generics(&mut self, g: &'a ast::Generics) {
1420 1421 1422 1423 1424 1425 1426 1427 1428
        for t in &g.ty_params {
            if !t.attrs.is_empty() {
                gate_feature_post!(&self, generic_param_attrs, t.attrs[0].span,
                                   "attributes on type parameter bindings are experimental");
            }
        }
        visit::walk_generics(self, g)
    }

1429
    fn visit_lifetime_def(&mut self, lifetime_def: &'a ast::LifetimeDef) {
1430 1431 1432 1433 1434 1435
        if !lifetime_def.attrs.is_empty() {
            gate_feature_post!(&self, generic_param_attrs, lifetime_def.attrs[0].span,
                               "attributes on lifetime bindings are experimental");
        }
        visit::walk_lifetime_def(self, lifetime_def)
    }
1436 1437
}

J
Jeffrey Seyfried 已提交
1438
pub fn get_features(span_handler: &Handler, krate_attrs: &[ast::Attribute]) -> Features {
1439
    let mut features = Features::new();
N
Nick Cameron 已提交
1440

1441 1442
    let mut feature_checker = MutexFeatureChecker::default();

J
Jeffrey Seyfried 已提交
1443
    for attr in krate_attrs {
S
Steven Fackler 已提交
1444
        if !attr.check_name("feature") {
1445 1446
            continue
        }
1447 1448 1449

        match attr.meta_item_list() {
            None => {
G
ggomez 已提交
1450 1451
                span_err!(span_handler, attr.span, E0555,
                          "malformed feature attribute, expected #![feature(...)]");
1452 1453
            }
            Some(list) => {
1454
                for mi in list {
1455 1456 1457 1458 1459 1460 1461 1462
                    let name = if let Some(word) = mi.word() {
                        word.name()
                    } else {
                        span_err!(span_handler, mi.span, E0556,
                                  "malformed feature, expected just one word");
                        continue
                    };

1463 1464 1465
                    if let Some(&(_, _, _, setter)) = ACTIVE_FEATURES.iter()
                        .find(|& &(n, _, _, _)| name == n) {
                        *(setter(&mut features)) = true;
1466
                        feature_checker.collect(&features, mi.span);
1467 1468
                    }
                    else if let Some(&(_, _, _)) = REMOVED_FEATURES.iter()
1469 1470 1471
                            .find(|& &(n, _, _)| name == n)
                        .or_else(|| STABLE_REMOVED_FEATURES.iter()
                            .find(|& &(n, _, _)| name == n)) {
G
ggomez 已提交
1472
                        span_err!(span_handler, mi.span, E0557, "feature has been removed");
1473 1474 1475
                    }
                    else if let Some(&(_, _, _)) = ACCEPTED_FEATURES.iter()
                        .find(|& &(n, _, _)| name == n) {
1476
                        features.declared_stable_lang_features.push((name, mi.span));
1477 1478
                    } else {
                        features.declared_lib_features.push((name, mi.span));
1479 1480 1481 1482 1483 1484
                    }
                }
            }
        }
    }

1485 1486
    feature_checker.check(span_handler);

L
Leo Testard 已提交
1487
    features
C
Corey Richardson 已提交
1488 1489
}

1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523
// A collector for mutually-exclusive features and their flag spans
#[derive(Default)]
struct MutexFeatureChecker {
    proc_macro: Option<Span>,
    custom_attribute: Option<Span>,
}

impl MutexFeatureChecker {
    // If this method turns out to be a hotspot due to branching,
    // the branching can be eliminated by modifying `setter!()` to set these spans
    // only for the features that need to be checked for mutual exclusion.
    fn collect(&mut self, features: &Features, span: Span) {
        if features.proc_macro {
            // If self.proc_macro is None, set to Some(span)
            self.proc_macro = self.proc_macro.or(Some(span));
        }

        if features.custom_attribute {
            self.custom_attribute = self.custom_attribute.or(Some(span));
        }
    }

    fn check(self, handler: &Handler) {
        if let (Some(pm_span), Some(ca_span)) = (self.proc_macro, self.custom_attribute) {
            handler.struct_span_err(pm_span, "Cannot use `#![feature(proc_macro)]` and \
                                              `#![feature(custom_attribute)] at the same time")
                .span_note(ca_span, "`#![feature(custom_attribute)]` declared here")
                .emit();

            panic!(FatalError);
        }
    }
}

J
Jeffrey Seyfried 已提交
1524 1525 1526
pub fn check_crate(krate: &ast::Crate,
                   sess: &ParseSess,
                   features: &Features,
1527
                   plugin_attributes: &[(String, AttributeType)],
J
Jeffrey Seyfried 已提交
1528 1529 1530 1531
                   unstable: UnstableFeatures) {
    maybe_stage_features(&sess.span_diagnostic, krate, unstable);
    let ctx = Context {
        features: features,
1532
        parse_sess: sess,
J
Jeffrey Seyfried 已提交
1533 1534 1535 1536
        cm: sess.codemap(),
        plugin_attributes: plugin_attributes,
    };
    visit::walk_crate(&mut PostExpansionVisitor { context: &ctx }, krate);
C
Corey Richardson 已提交
1537
}
1538

1539
#[derive(Clone, Copy, PartialEq, Eq, Hash)]
1540 1541 1542 1543
pub enum UnstableFeatures {
    /// Hard errors for unstable features are active, as on
    /// beta/stable channels.
    Disallow,
J
John Hodge 已提交
1544
    /// Allow features to be activated, as on nightly.
1545 1546 1547 1548
    Allow,
    /// Errors are bypassed for bootstrapping. This is required any time
    /// during the build that feature-related lints are set to warn or above
    /// because the build turns on warnings-as-errors and uses lots of unstable
1549
    /// features. As a result, this is always required for building Rust itself.
1550 1551 1552
    Cheat
}

T
Tim Neumann 已提交
1553 1554 1555 1556
impl UnstableFeatures {
    pub fn from_environment() -> UnstableFeatures {
        // Whether this is a feature-staged build, i.e. on the beta or stable channel
        let disable_unstable_features = option_env!("CFG_DISABLE_UNSTABLE_FEATURES").is_some();
1557 1558 1559 1560 1561 1562
        // Whether we should enable unstable features for bootstrapping
        let bootstrap = env::var("RUSTC_BOOTSTRAP").is_ok();
        match (disable_unstable_features, bootstrap) {
            (_, true) => UnstableFeatures::Cheat,
            (true, _) => UnstableFeatures::Disallow,
            (false, _) => UnstableFeatures::Allow
T
Tim Neumann 已提交
1563 1564
        }
    }
1565 1566 1567 1568 1569 1570 1571

    pub fn is_nightly_build(&self) -> bool {
        match *self {
            UnstableFeatures::Allow | UnstableFeatures::Cheat => true,
            _ => false,
        }
    }
T
Tim Neumann 已提交
1572 1573
}

1574
fn maybe_stage_features(span_handler: &Handler, krate: &ast::Crate,
1575 1576 1577 1578 1579 1580 1581 1582 1583 1584
                        unstable: UnstableFeatures) {
    let allow_features = match unstable {
        UnstableFeatures::Allow => true,
        UnstableFeatures::Disallow => false,
        UnstableFeatures::Cheat => true
    };
    if !allow_features {
        for attr in &krate.attrs {
            if attr.check_name("feature") {
                let release_channel = option_env!("CFG_RELEASE_CHANNEL").unwrap_or("(unknown)");
G
ggomez 已提交
1585
                span_err!(span_handler, attr.span, E0554,
G
ggomez 已提交
1586 1587
                          "#[feature] may not be used on the {} release channel",
                          release_channel);
1588 1589 1590 1591
            }
        }
    }
}