feature_gate.rs 59.7 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

//! Feature gating
//!
L
Luke Gallagher 已提交
13
//! This module implements the gating necessary for preventing certain compiler
14 15 16 17 18
//! features from being used by default. This module will crawl a pre-expanded
//! AST to ensure that there are no features which are used that are not
//! enabled.
//!
//! Features are enabled in programs via the crate-level attributes of
19
//! `#![feature(...)]` with a comma-separated list of features.
B
Brian Anderson 已提交
20 21 22 23
//!
//! For the purpose of future feature-tracking, once code for detection of feature
//! gate usage is added, *do not remove it again* even once the feature
//! becomes stable.
G
GuillaumeGomez 已提交
24

25
use self::AttributeType::*;
26
use self::AttributeGate::*;
27

N
Niko Matsakis 已提交
28
use abi::Abi;
29
use ast::{self, NodeId, PatKind};
30
use attr;
31
use codemap::{CodeMap, Spanned};
32
use syntax_pos::Span;
33
use errors::{DiagnosticBuilder, Handler};
34
use visit::{self, FnKind, Visitor};
J
Jeffrey Seyfried 已提交
35
use parse::ParseSess;
36
use symbol::Symbol;
37

38
use std::ascii::AsciiExt;
T
Tim Neumann 已提交
39
use std::env;
40

41 42 43 44 45 46 47 48
macro_rules! setter {
    ($field: ident) => {{
        fn f(features: &mut Features) -> &mut bool {
            &mut features.$field
        }
        f as fn(&mut Features) -> &mut bool
    }}
}
49

50
macro_rules! declare_features {
51
    ($((active, $feature: ident, $ver: expr, $issue: expr),)+) => {
52 53 54 55 56 57 58 59 60
        /// Represents active features that are currently being implemented or
        /// currently being considered for addition/removal.
        const ACTIVE_FEATURES: &'static [(&'static str, &'static str,
                                          Option<u32>, fn(&mut Features) -> &mut bool)] = &[
            $((stringify!($feature), $ver, $issue, setter!($feature))),+
        ];

        /// A set of features to be used by later passes.
        pub struct Features {
61
            /// #![feature] attrs for stable language features, for error reporting
62
            pub declared_stable_lang_features: Vec<(Symbol, Span)>,
63
            /// #![feature] attrs for non-language (library) features
64
            pub declared_lib_features: Vec<(Symbol, Span)>,
65 66
            $(pub $feature: bool),+
        }
67

68 69 70 71 72 73 74 75 76 77 78
        impl Features {
            pub fn new() -> Features {
                Features {
                    declared_stable_lang_features: Vec::new(),
                    declared_lib_features: Vec::new(),
                    $($feature: false),+
                }
            }
        }
    };

79
    ($((removed, $feature: ident, $ver: expr, $issue: expr),)+) => {
80 81 82 83 84 85
        /// Represents features which has since been removed (it was once Active)
        const REMOVED_FEATURES: &'static [(&'static str, &'static str, Option<u32>)] = &[
            $((stringify!($feature), $ver, $issue)),+
        ];
    };

86
    ($((accepted, $feature: ident, $ver: expr, $issue: expr),)+) => {
87 88 89 90 91
        /// Those language feature has since been Accepted (it was once Active)
        const ACCEPTED_FEATURES: &'static [(&'static str, &'static str, Option<u32>)] = &[
            $((stringify!($feature), $ver, $issue)),+
        ];
    }
92 93
}

B
Brian Anderson 已提交
94 95 96 97 98
// If you change this list without updating src/doc/reference.md, @cmr will be sad
// Don't ever remove anything from this list; set them to 'Removed'.
// The version numbers here correspond to the version in which the current status
// was set. This is most important for knowing when a particular feature became
// stable (active).
99 100 101 102 103 104 105 106 107 108 109 110
// NB: The featureck.py script parses this information directly out of the source
// so take care when modifying it.

declare_features! (
    (active, asm, "1.0.0", Some(29722)),
    (active, concat_idents, "1.0.0", Some(29599)),
    (active, link_args, "1.0.0", Some(29596)),
    (active, log_syntax, "1.0.0", Some(29598)),
    (active, non_ascii_idents, "1.0.0", Some(28979)),
    (active, plugin_registrar, "1.0.0", Some(29597)),
    (active, thread_local, "1.0.0", Some(29594)),
    (active, trace_macros, "1.0.0", Some(29598)),
A
Aaron Turon 已提交
111 112

    // rustc internal, for now:
113 114
    (active, intrinsics, "1.0.0", None),
    (active, lang_items, "1.0.0", None),
115

116 117 118 119
    (active, link_llvm_intrinsics, "1.0.0", Some(29602)),
    (active, linkage, "1.0.0", Some(29603)),
    (active, quote, "1.0.0", Some(29601)),
    (active, simd, "1.0.0", Some(27731)),
120 121


A
Aaron Turon 已提交
122
    // rustc internal
123 124 125 126 127 128
    (active, rustc_diagnostic_macros, "1.0.0", None),
    (active, advanced_slice_patterns, "1.0.0", Some(23121)),
    (active, box_syntax, "1.0.0", Some(27779)),
    (active, placement_in_syntax, "1.0.0", Some(27779)),
    (active, reflect, "1.0.0", Some(27749)),
    (active, unboxed_closures, "1.0.0", Some(29625)),
A
Aaron Turon 已提交
129 130

    // rustc internal.
131 132 133 134 135 136 137 138 139 140 141 142
    (active, pushpop_unsafe, "1.2.0", None),

    (active, allocator, "1.0.0", Some(27389)),
    (active, fundamental, "1.0.0", Some(29635)),
    (active, linked_from, "1.3.0", Some(29629)),
    (active, main, "1.0.0", Some(29634)),
    (active, needs_allocator, "1.4.0", Some(27389)),
    (active, on_unimplemented, "1.0.0", Some(29628)),
    (active, plugin, "1.0.0", Some(29597)),
    (active, simd_ffi, "1.0.0", Some(27731)),
    (active, start, "1.0.0", Some(29633)),
    (active, structural_match, "1.8.0", Some(31434)),
143 144
    (active, panic_runtime, "1.10.0", Some(32837)),
    (active, needs_panic_runtime, "1.10.0", Some(32837)),
145

146
    // OIBIT specific features
147
    (active, optin_builtin_traits, "1.0.0", Some(13231)),
148

J
Joseph Crail 已提交
149
    // macro reexport needs more discussion and stabilization
150
    (active, macro_reexport, "1.0.0", Some(29638)),
151 152

    // Allows use of #[staged_api]
A
Aaron Turon 已提交
153
    // rustc internal
154
    (active, staged_api, "1.0.0", None),
155 156

    // Allows using items which are missing stability attributes
A
Aaron Turon 已提交
157
    // rustc internal
158
    (active, unmarked_api, "1.0.0", None),
159

A
Alex Crichton 已提交
160
    // Allows using #![no_core]
161
    (active, no_core, "1.3.0", Some(29639)),
A
Alex Crichton 已提交
162

163
    // Allows using `box` in patterns; RFC 469
164
    (active, box_patterns, "1.0.0", Some(29641)),
165

166 167
    // Allows using the unsafe_destructor_blind_to_params attribute;
    // RFC 1238
168
    (active, dropck_parametricity, "1.3.0", Some(28498)),
169

170 171 172
    // Allows using the may_dangle attribute; RFC 1327
    (active, dropck_eyepatch, "1.10.0", Some(34761)),

173
    // Allows the use of custom attributes; RFC 572
174
    (active, custom_attribute, "1.0.0", Some(29642)),
M
Manish Goregaokar 已提交
175

176 177
    // Allows the use of #[derive(Anything)] as sugar for
    // #[derive_Anything].
178
    (active, custom_derive, "1.0.0", Some(29644)),
179

M
Manish Goregaokar 已提交
180
    // Allows the use of rustc_* attributes; RFC 572
181
    (active, rustc_attrs, "1.0.0", Some(29642)),
H
Huon Wilson 已提交
182

183 184 185 186
    // Allows the use of #[allow_internal_unstable]. This is an
    // attribute on macro_rules! and can't use the attribute handling
    // below (it has to be checked before expansion possibly makes
    // macros disappear).
A
Aaron Turon 已提交
187 188
    //
    // rustc internal
189
    (active, allow_internal_unstable, "1.0.0", None),
190 191

    // #23121. Array patterns have some hazards yet.
192
    (active, slice_patterns, "1.0.0", Some(23121)),
193 194 195

    // Allows the definition of associated constants in `trait` or `impl`
    // blocks.
196
    (active, associated_consts, "1.0.0", Some(29646)),
N
Niko Matsakis 已提交
197 198

    // Allows the definition of `const fn` functions.
199
    (active, const_fn, "1.2.0", Some(24111)),
200

201
    // Allows indexing into constant arrays.
202
    (active, const_indexing, "1.4.0", Some(29947)),
203

204
    // Allows using #[prelude_import] on glob `use` items.
A
Aaron Turon 已提交
205 206
    //
    // rustc internal
207
    (active, prelude_import, "1.2.0", None),
208 209

    // Allows the definition recursive static items.
210
    (active, static_recursion, "1.3.0", Some(29719)),
B
Brian Anderson 已提交
211 212

    // Allows default type parameters to influence type inference.
213
    (active, default_type_parameter_fallback, "1.3.0", Some(27336)),
214 215

    // Allows associated type defaults
216
    (active, associated_type_defaults, "1.2.0", Some(29661)),
J
Jared Roesch 已提交
217

218
    // allow `repr(simd)`, and importing the various simd intrinsics
219
    (active, repr_simd, "1.4.0", Some(27731)),
220 221

    // Allows cfg(target_feature = "...").
222
    (active, cfg_target_feature, "1.4.0", Some(29717)),
223 224

    // allow `extern "platform-intrinsic" { ... }`
225
    (active, platform_intrinsics, "1.4.0", Some(27731)),
226 227

    // allow `#[unwind]`
A
Aaron Turon 已提交
228
    // rust runtime internal
229
    (active, unwind_attributes, "1.4.0", None),
V
Vadim Petrochenkov 已提交
230

T
Ticki 已提交
231
    // allow the use of `#[naked]` on functions.
232
    (active, naked_functions, "1.9.0", Some(32408)),
233 234

    // allow `#[no_debug]`
235
    (active, no_debug, "1.5.0", Some(29721)),
236 237

    // allow `#[omit_gdb_pretty_printer_section]`
A
Aaron Turon 已提交
238
    // rustc internal.
239
    (active, omit_gdb_pretty_printer_section, "1.5.0", None),
240 241

    // Allows cfg(target_vendor = "...").
242
    (active, cfg_target_vendor, "1.5.0", Some(29718)),
243 244

    // Allow attributes on expressions and non-item statements
245
    (active, stmt_expr_attributes, "1.6.0", Some(15701)),
246 247

    // allow using type ascription in expressions
248
    (active, type_ascription, "1.6.0", Some(23416)),
249 250

    // Allows cfg(target_thread_local)
251
    (active, cfg_target_thread_local, "1.7.0", Some(29594)),
252 253

    // rustc internal
254
    (active, abi_vectorcall, "1.7.0", None),
A
Alex Burka 已提交
255 256

    // a...b and ...b
257
    (active, inclusive_range_syntax, "1.7.0", Some(28237)),
J
Jorge Aparicio 已提交
258

A
Aaron Turon 已提交
259
    // impl specialization (RFC 1210)
260
    (active, specialization, "1.7.0", Some(31844)),
261 262

    // pub(restricted) visibilities (RFC 1422)
263 264
    (active, pub_restricted, "1.9.0", Some(32409)),

265 266 267 268
    // Allow Drop types in statics/const functions (RFC 1440)
    (active, drop_types_in_const, "1.9.0", Some(33156)),

    // Allows cfg(target_has_atomic = "...").
269 270
    (active, cfg_target_has_atomic, "1.9.0", Some(32976)),

271
    // Allows `impl Trait` in function return types.
272 273 274
    (active, conservative_impl_trait, "1.12.0", Some(34511)),

    // Permits numeric fields in struct expressions and patterns.
275 276 277
    (active, relaxed_adts, "1.12.0", Some(35626)),

    // The `!` type
278 279 280
    (active, never_type, "1.13.0", Some(35121)),

    // Allows all literals in attribute lists and values of key-value pairs.
281 282 283 284
    (active, attr_literals, "1.13.0", Some(34981)),

    // Allows the sysV64 ABI to be specified on all platforms
    // instead of just the platforms on which it is the C ABI
285 286
    (active, abi_sysv64, "1.13.0", Some(36167)),

287
    // Macros 1.1
288
    (active, proc_macro, "1.13.0", Some(35900)),
289 290 291

    // Allows untagged unions `union U { ... }`
    (active, untagged_unions, "1.13.0", Some(32836)),
A
Andre Bogus 已提交
292 293 294

    // elide `'static` lifetimes in `static`s and `const`s
    (active, static_in_const, "1.13.0", Some(35897)),
295 296 297 298

    // Used to identify the `compiler_builtins` crate
    // rustc internal
    (active, compiler_builtins, "1.13.0", None),
299 300 301

    // Allows attributes on lifetime/type formal parameters in generics (RFC 1327)
    (active, generic_param_attrs, "1.11.0", Some(34761)),
302 303 304

    // Allows field shorthands (`x` meaning `x: x`) in struct literal expressions.
    (active, field_init_shorthand, "1.14.0", Some(37340)),
305 306 307

    // The #![windows_subsystem] attribute
    (active, windows_subsystem, "1.14.0", Some(37499)),
308

309 310
    // Allows using `Self` and associated types in struct expressions and patterns.
    (active, more_struct_aliases, "1.14.0", Some(37544)),
311 312 313

    // Allows #[link(..., cfg(..))]
    (active, link_cfg, "1.14.0", Some(37406)),
314 315

    (active, use_extern_macros, "1.15.0", Some(35896)),
316 317 318 319 320 321 322 323 324 325 326 327
);

declare_features! (
    (removed, import_shadowing, "1.0.0", None),
    (removed, managed_boxes, "1.0.0", None),
    // Allows use of unary negate on unsigned integers, e.g. -e for e: u8
    (removed, negate_unsigned, "1.0.0", Some(29645)),
    // A way to temporarily opt out of opt in copy. This will *never* be accepted.
    (removed, opt_out_copy, "1.0.0", None),
    (removed, quad_precision_float, "1.0.0", None),
    (removed, struct_inherit, "1.0.0", None),
    (removed, test_removed_feature, "1.0.0", None),
328
    (removed, visible_private_types, "1.0.0", None),
329
    (removed, unsafe_no_drop_flag, "1.0.0", None),
330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345
);

declare_features! (
    (accepted, associated_types, "1.0.0", None),
    // allow overloading augmented assignment operations like `a += b`
    (accepted, augmented_assignments, "1.8.0", Some(28235)),
    // allow empty structs and enum variants with braces
    (accepted, braced_empty_structs, "1.8.0", Some(29720)),
    (accepted, default_type_params, "1.0.0", None),
    (accepted, globs, "1.0.0", None),
    (accepted, if_let, "1.0.0", None),
    // A temporary feature gate used to enable parser extensions needed
    // to bootstrap fix for #5723.
    (accepted, issue_5723_bootstrap, "1.0.0", None),
    (accepted, macro_rules, "1.0.0", None),
    // Allows using #![no_std]
346
    (accepted, no_std, "1.6.0", None),
347 348 349 350 351 352
    (accepted, slicing_syntax, "1.0.0", None),
    (accepted, struct_variant, "1.0.0", None),
    // These are used to test this portion of the compiler, they don't actually
    // mean anything
    (accepted, test_accepted_feature, "1.0.0", None),
    (accepted, tuple_indexing, "1.0.0", None),
D
Daniele Baracchi 已提交
353 354
    // Allows macros to appear in the type position.
    (accepted, type_macros, "1.13.0", Some(27245)),
355 356
    (accepted, while_let, "1.0.0", None),
    // Allows `#[deprecated]` attribute
357
    (accepted, deprecated, "1.9.0", Some(29935)),
N
Nick Cameron 已提交
358
    // `expr?`
359
    (accepted, question_mark, "1.13.0", Some(31436)),
360 361
    // Allows `..` in tuple (struct) patterns
    (accepted, dotdot_in_tuple_patterns, "1.14.0", Some(33627)),
J
Jeffrey Seyfried 已提交
362
    (accepted, item_like_imports, "1.14.0", Some(35120)),
363
);
364
// (changing above list without updating src/doc/reference.md makes @cmr sad)
365

366 367 368 369 370
#[derive(PartialEq, Copy, Clone, Debug)]
pub enum AttributeType {
    /// Normal, builtin attribute that is consumed
    /// by the compiler before the unused_attribute check
    Normal,
371

372 373 374 375
    /// Builtin attribute that may not be consumed by the compiler
    /// before the unused_attribute check. These attributes
    /// will be ignored by the unused_attribute lint
    Whitelisted,
376

377 378 379 380 381 382 383
    /// Builtin attribute that is only allowed at the crate level
    CrateLevel,
}

pub enum AttributeGate {
    /// Is gated by a given feature gate, reason
    /// and function to check if enabled
384
    Gated(Stability, &'static str, &'static str, fn(&Features) -> bool),
385 386 387 388 389

    /// Ungated attribute, can be used on all release channels
    Ungated,
}

N
Nick Cameron 已提交
390 391 392 393 394 395 396 397 398 399
impl AttributeGate {
    fn is_deprecated(&self) -> bool {
        match *self {
            Gated(Stability::Deprecated(_), ..) => true,
            _ => false,
        }
    }
}

#[derive(Copy, Clone, PartialEq, Eq, Debug)]
400 401
pub enum Stability {
    Unstable,
N
Nick Cameron 已提交
402 403
    // Argument is tracking issue link.
    Deprecated(&'static str),
404 405
}

406 407 408 409
// fn() is not Debug
impl ::std::fmt::Debug for AttributeGate {
    fn fmt(&self, fmt: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
        match *self {
N
Nick Cameron 已提交
410 411
            Gated(ref stab, ref name, ref expl, _) =>
                write!(fmt, "Gated({:?}, {}, {})", stab, name, expl),
412 413 414 415 416 417 418 419 420 421 422 423
            Ungated => write!(fmt, "Ungated")
        }
    }
}

macro_rules! cfg_fn {
    ($field: ident) => {{
        fn f(features: &Features) -> bool {
            features.$field
        }
        f as fn(&Features) -> bool
    }}
424 425
}

N
Nick Cameron 已提交
426
pub fn deprecated_attributes() -> Vec<&'static (&'static str, AttributeType, AttributeGate)> {
427
    BUILTIN_ATTRIBUTES.iter().filter(|a| a.2.is_deprecated()).collect()
N
Nick Cameron 已提交
428 429
}

430
// Attributes that have a special meaning to rustc or rustdoc
431
pub const BUILTIN_ATTRIBUTES: &'static [(&'static str, AttributeType, AttributeGate)] = &[
432 433
    // Normal attributes

434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463
    ("warn", Normal, Ungated),
    ("allow", Normal, Ungated),
    ("forbid", Normal, Ungated),
    ("deny", Normal, Ungated),

    ("macro_reexport", Normal, Ungated),
    ("macro_use", Normal, Ungated),
    ("macro_export", Normal, Ungated),
    ("plugin_registrar", Normal, Ungated),

    ("cfg", Normal, Ungated),
    ("cfg_attr", Normal, Ungated),
    ("main", Normal, Ungated),
    ("start", Normal, Ungated),
    ("test", Normal, Ungated),
    ("bench", Normal, Ungated),
    ("simd", Normal, Ungated),
    ("repr", Normal, Ungated),
    ("path", Normal, Ungated),
    ("abi", Normal, Ungated),
    ("automatically_derived", Normal, Ungated),
    ("no_mangle", Normal, Ungated),
    ("no_link", Normal, Ungated),
    ("derive", Normal, Ungated),
    ("should_panic", Normal, Ungated),
    ("ignore", Normal, Ungated),
    ("no_implicit_prelude", Normal, Ungated),
    ("reexport_test_harness_main", Normal, Ungated),
    ("link_args", Normal, Ungated),
    ("macro_escape", Normal, Ungated),
464

465
    // RFC #1445.
466 467
    ("structural_match", Whitelisted, Gated(Stability::Unstable,
                                            "structural_match",
468
                                            "the semantics of constant patterns is \
469 470
                                             not yet settled",
                                            cfg_fn!(structural_match))),
471

A
Alex Crichton 已提交
472
    // Not used any more, but we can't feature gate it
473 474
    ("no_stack_check", Normal, Ungated),

475 476
    ("plugin", CrateLevel, Gated(Stability::Unstable,
                                 "plugin",
477
                                 "compiler plugins are experimental \
478 479 480
                                  and possibly buggy",
                                 cfg_fn!(plugin))),

481
    ("no_std", CrateLevel, Ungated),
482 483
    ("no_core", CrateLevel, Gated(Stability::Unstable,
                                  "no_core",
484 485
                                  "no_core is experimental",
                                  cfg_fn!(no_core))),
486 487
    ("lang", Normal, Gated(Stability::Unstable,
                           "lang_items",
488 489
                           "language items are subject to change",
                           cfg_fn!(lang_items))),
490 491
    ("linkage", Whitelisted, Gated(Stability::Unstable,
                                   "linkage",
492
                                   "the `linkage` attribute is experimental \
493 494
                                    and not portable across platforms",
                                   cfg_fn!(linkage))),
495 496
    ("thread_local", Whitelisted, Gated(Stability::Unstable,
                                        "thread_local",
497 498 499
                                        "`#[thread_local]` is an experimental feature, and does \
                                         not currently handle destructors. There is no \
                                         corresponding `#[task_local]` mapping to the task \
500 501
                                         model",
                                        cfg_fn!(thread_local))),
502

503 504
    ("rustc_on_unimplemented", Normal, Gated(Stability::Unstable,
                                             "on_unimplemented",
505
                                             "the `#[rustc_on_unimplemented]` attribute \
506 507
                                              is an experimental feature",
                                             cfg_fn!(on_unimplemented))),
508 509
    ("allocator", Whitelisted, Gated(Stability::Unstable,
                                     "allocator",
510 511
                                     "the `#[allocator]` attribute is an experimental feature",
                                     cfg_fn!(allocator))),
512 513
    ("needs_allocator", Normal, Gated(Stability::Unstable,
                                      "needs_allocator",
514 515
                                      "the `#[needs_allocator]` \
                                       attribute is an experimental \
516 517
                                       feature",
                                      cfg_fn!(needs_allocator))),
518 519
    ("panic_runtime", Whitelisted, Gated(Stability::Unstable,
                                         "panic_runtime",
520 521 522
                                         "the `#[panic_runtime]` attribute is \
                                          an experimental feature",
                                         cfg_fn!(panic_runtime))),
523 524
    ("needs_panic_runtime", Whitelisted, Gated(Stability::Unstable,
                                               "needs_panic_runtime",
525 526 527 528
                                               "the `#[needs_panic_runtime]` \
                                                attribute is an experimental \
                                                feature",
                                               cfg_fn!(needs_panic_runtime))),
529 530
    ("rustc_variance", Normal, Gated(Stability::Unstable,
                                     "rustc_attrs",
531
                                     "the `#[rustc_variance]` attribute \
N
Niko Matsakis 已提交
532
                                      is just used for rustc unit tests \
533 534
                                      and will never be stable",
                                     cfg_fn!(rustc_attrs))),
535 536
    ("rustc_error", Whitelisted, Gated(Stability::Unstable,
                                       "rustc_attrs",
537
                                       "the `#[rustc_error]` attribute \
N
Niko Matsakis 已提交
538
                                        is just used for rustc unit tests \
539 540
                                        and will never be stable",
                                       cfg_fn!(rustc_attrs))),
541 542
    ("rustc_if_this_changed", Whitelisted, Gated(Stability::Unstable,
                                                 "rustc_attrs",
543 544 545 546
                                                 "the `#[rustc_if_this_changed]` attribute \
                                                  is just used for rustc unit tests \
                                                  and will never be stable",
                                                 cfg_fn!(rustc_attrs))),
547 548
    ("rustc_then_this_would_need", Whitelisted, Gated(Stability::Unstable,
                                                      "rustc_attrs",
549 550 551 552
                                                      "the `#[rustc_if_this_changed]` attribute \
                                                       is just used for rustc unit tests \
                                                       and will never be stable",
                                                      cfg_fn!(rustc_attrs))),
553 554
    ("rustc_dirty", Whitelisted, Gated(Stability::Unstable,
                                       "rustc_attrs",
555 556
                                       "the `#[rustc_dirty]` attribute \
                                        is just used for rustc unit tests \
557 558
                                        and will never be stable",
                                       cfg_fn!(rustc_attrs))),
559 560
    ("rustc_clean", Whitelisted, Gated(Stability::Unstable,
                                       "rustc_attrs",
561 562
                                       "the `#[rustc_clean]` attribute \
                                        is just used for rustc unit tests \
563 564
                                        and will never be stable",
                                       cfg_fn!(rustc_attrs))),
565 566
    ("rustc_metadata_dirty", Whitelisted, Gated(Stability::Unstable,
                                                "rustc_attrs",
567 568 569 570
                                                "the `#[rustc_metadata_dirty]` attribute \
                                                 is just used for rustc unit tests \
                                                 and will never be stable",
                                                 cfg_fn!(rustc_attrs))),
571 572
    ("rustc_metadata_clean", Whitelisted, Gated(Stability::Unstable,
                                                "rustc_attrs",
573 574 575 576
                                                "the `#[rustc_metadata_clean]` attribute \
                                                 is just used for rustc unit tests \
                                                 and will never be stable",
                                                 cfg_fn!(rustc_attrs))),
577 578
    ("rustc_partition_reused", Whitelisted, Gated(Stability::Unstable,
                                                  "rustc_attrs",
579 580 581 582
                                                  "this attribute \
                                                   is just used for rustc unit tests \
                                                   and will never be stable",
                                                  cfg_fn!(rustc_attrs))),
583 584
    ("rustc_partition_translated", Whitelisted, Gated(Stability::Unstable,
                                                      "rustc_attrs",
585 586 587 588
                                                      "this attribute \
                                                       is just used for rustc unit tests \
                                                       and will never be stable",
                                                      cfg_fn!(rustc_attrs))),
589 590
    ("rustc_symbol_name", Whitelisted, Gated(Stability::Unstable,
                                             "rustc_attrs",
591 592
                                             "internal rustc attributes will never be stable",
                                             cfg_fn!(rustc_attrs))),
593 594
    ("rustc_item_path", Whitelisted, Gated(Stability::Unstable,
                                           "rustc_attrs",
595 596
                                           "internal rustc attributes will never be stable",
                                           cfg_fn!(rustc_attrs))),
597 598
    ("rustc_move_fragments", Normal, Gated(Stability::Unstable,
                                           "rustc_attrs",
599
                                           "the `#[rustc_move_fragments]` attribute \
N
Niko Matsakis 已提交
600
                                            is just used for rustc unit tests \
601 602
                                            and will never be stable",
                                           cfg_fn!(rustc_attrs))),
603 604
    ("rustc_mir", Whitelisted, Gated(Stability::Unstable,
                                     "rustc_attrs",
605 606
                                     "the `#[rustc_mir]` attribute \
                                      is just used for rustc unit tests \
607 608
                                      and will never be stable",
                                     cfg_fn!(rustc_attrs))),
609 610
    ("rustc_inherit_overflow_checks", Whitelisted, Gated(Stability::Unstable,
                                                         "rustc_attrs",
611 612 613 614 615 616
                                                         "the `#[rustc_inherit_overflow_checks]` \
                                                          attribute is just used to control \
                                                          overflow checking behavior of several \
                                                          libcore functions that are inlined \
                                                          across crates and will never be stable",
                                                          cfg_fn!(rustc_attrs))),
617 618
    ("compiler_builtins", Whitelisted, Gated(Stability::Unstable,
                                             "compiler_builtins",
619 620 621 622 623
                                             "the `#[compiler_builtins]` attribute is used to \
                                              identify the `compiler_builtins` crate which \
                                              contains compiler-rt intrinsics and will never be \
                                              stable",
                                          cfg_fn!(compiler_builtins))),
624

625 626
    ("allow_internal_unstable", Normal, Gated(Stability::Unstable,
                                              "allow_internal_unstable",
627 628
                                              EXPLAIN_ALLOW_INTERNAL_UNSTABLE,
                                              cfg_fn!(allow_internal_unstable))),
629

630 631
    ("fundamental", Whitelisted, Gated(Stability::Unstable,
                                       "fundamental",
632
                                       "the `#[fundamental]` attribute \
633 634
                                        is an experimental feature",
                                       cfg_fn!(fundamental))),
635

636 637
    ("linked_from", Normal, Gated(Stability::Unstable,
                                  "linked_from",
638
                                  "the `#[linked_from]` attribute \
639 640
                                   is an experimental feature",
                                  cfg_fn!(linked_from))),
641

642 643
    ("proc_macro_derive", Normal, Gated(Stability::Unstable,
                                        "proc_macro",
644 645 646
                                        "the `#[proc_macro_derive]` attribute \
                                         is an experimental feature",
                                        cfg_fn!(proc_macro))),
647

648 649
    ("rustc_copy_clone_marker", Whitelisted, Gated(Stability::Unstable,
                                                   "rustc_attrs",
650 651 652
                                                   "internal implementation detail",
                                                   cfg_fn!(rustc_attrs))),

653
    // FIXME: #14408 whitelist docs since rustdoc looks at them
654
    ("doc", Whitelisted, Ungated),
655 656 657

    // FIXME: #14406 these are processed in trans, which happens after the
    // lint pass
658
    ("cold", Whitelisted, Ungated),
659 660
    ("naked", Whitelisted, Gated(Stability::Unstable,
                                 "naked_functions",
T
Ticki 已提交
661
                                 "the `#[naked]` attribute \
662
                                  is an experimental feature",
663
                                 cfg_fn!(naked_functions))),
664 665 666 667 668 669 670
    ("export_name", Whitelisted, Ungated),
    ("inline", Whitelisted, Ungated),
    ("link", Whitelisted, Ungated),
    ("link_name", Whitelisted, Ungated),
    ("link_section", Whitelisted, Ungated),
    ("no_builtins", Whitelisted, Ungated),
    ("no_mangle", Whitelisted, Ungated),
N
Nick Cameron 已提交
671 672 673 674 675
    ("no_debug", Whitelisted, Gated(
        Stability::Deprecated("https://github.com/rust-lang/rust/issues/29721"),
        "no_debug",
        "the `#[no_debug]` attribute is an experimental feature",
        cfg_fn!(no_debug))),
676 677
    ("omit_gdb_pretty_printer_section", Whitelisted, Gated(Stability::Unstable,
                                                       "omit_gdb_pretty_printer_section",
678 679
                                                       "the `#[omit_gdb_pretty_printer_section]` \
                                                        attribute is just used for the Rust test \
680 681
                                                        suite",
                                                       cfg_fn!(omit_gdb_pretty_printer_section))),
682 683
    ("unsafe_destructor_blind_to_params",
     Normal,
684 685
     Gated(Stability::Unstable,
           "dropck_parametricity",
686
           "unsafe_destructor_blind_to_params has unstable semantics \
687 688
            and may be removed in the future",
           cfg_fn!(dropck_parametricity))),
689 690
    ("may_dangle",
     Normal,
691 692
     Gated(Stability::Unstable,
           "dropck_eyepatch",
693 694
           "may_dangle has unstable semantics and may be removed in the future",
           cfg_fn!(dropck_eyepatch))),
695 696 697
    ("unwind", Whitelisted, Gated(Stability::Unstable,
                                  "unwind_attributes",
                                  "#[unwind] is experimental",
698
                                  cfg_fn!(unwind_attributes))),
699 700

    // used in resolve
701 702
    ("prelude_import", Whitelisted, Gated(Stability::Unstable,
                                          "prelude_import",
703 704
                                          "`#[prelude_import]` is for use by rustc only",
                                          cfg_fn!(prelude_import))),
705 706 707

    // FIXME: #14407 these are only looked at on-demand so we can't
    // guarantee they'll have already been checked
708
    ("rustc_deprecated", Whitelisted, Ungated),
709 710 711
    ("must_use", Whitelisted, Ungated),
    ("stable", Whitelisted, Ungated),
    ("unstable", Whitelisted, Ungated),
712
    ("deprecated", Normal, Ungated),
713

714 715
    ("rustc_paren_sugar", Normal, Gated(Stability::Unstable,
                                        "unboxed_closures",
716 717
                                        "unboxed_closures are still evolving",
                                        cfg_fn!(unboxed_closures))),
718 719
    ("rustc_reflect_like", Whitelisted, Gated(Stability::Unstable,
                                              "reflect",
720 721
                                              "defining reflective traits is still evolving",
                                              cfg_fn!(reflect))),
722

723 724 725
    ("windows_subsystem", Whitelisted, Gated(Stability::Unstable,
                                             "windows_subsystem",
                                             "the windows subsystem attribute \
A
Alex Crichton 已提交
726
                                              is currently unstable",
727 728
                                             cfg_fn!(windows_subsystem))),

729
    // Crate level attributes
730 731 732 733 734 735 736 737
    ("crate_name", CrateLevel, Ungated),
    ("crate_type", CrateLevel, Ungated),
    ("crate_id", CrateLevel, Ungated),
    ("feature", CrateLevel, Ungated),
    ("no_start", CrateLevel, Ungated),
    ("no_main", CrateLevel, Ungated),
    ("no_builtins", CrateLevel, Ungated),
    ("recursion_limit", CrateLevel, Ungated),
738 739
];

740 741 742
// cfg(...)'s that are feature gated
const GATED_CFGS: &'static [(&'static str, &'static str, fn(&Features) -> bool)] = &[
    // (name in cfg, feature, function to check if the feature is enabled)
743 744 745
    ("target_feature", "cfg_target_feature", cfg_fn!(cfg_target_feature)),
    ("target_vendor", "cfg_target_vendor", cfg_fn!(cfg_target_vendor)),
    ("target_thread_local", "cfg_target_thread_local", cfg_fn!(cfg_target_thread_local)),
746
    ("target_has_atomic", "cfg_target_has_atomic", cfg_fn!(cfg_target_has_atomic)),
747
    ("proc_macro", "proc_macro", cfg_fn!(proc_macro)),
748 749 750 751 752 753 754
];

#[derive(Debug, Eq, PartialEq)]
pub struct GatedCfg {
    span: Span,
    index: usize,
}
755

756 757
impl GatedCfg {
    pub fn gate(cfg: &ast::MetaItem) -> Option<GatedCfg> {
758
        let name = &*cfg.name().as_str();
759 760 761 762 763 764 765 766 767
        GATED_CFGS.iter()
                  .position(|info| info.0 == name)
                  .map(|idx| {
                      GatedCfg {
                          span: cfg.span,
                          index: idx
                      }
                  })
    }
J
Jeffrey Seyfried 已提交
768 769

    pub fn check_and_emit(&self, sess: &ParseSess, features: &Features) {
770
        let (cfg, feature, has_feature) = GATED_CFGS[self.index];
J
Jeffrey Seyfried 已提交
771
        if !has_feature(features) && !sess.codemap().span_allows_unstable(self.span) {
772
            let explain = format!("`cfg({})` is experimental and subject to change", cfg);
773
            emit_feature_err(sess, feature, self.span, GateIssue::Language, &explain);
774 775 776 777
        }
    }
}

E
Eduard Burtescu 已提交
778
struct Context<'a> {
L
Leo Testard 已提交
779
    features: &'a Features,
780
    parse_sess: &'a ParseSess,
C
Corey Richardson 已提交
781
    cm: &'a CodeMap,
782
    plugin_attributes: &'a [(String, AttributeType)],
783 784
}

785 786 787 788 789 790
macro_rules! gate_feature_fn {
    ($cx: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{
        let (cx, has_feature, span, name, explain) = ($cx, $has_feature, $span, $name, $explain);
        let has_feature: bool = has_feature(&$cx.features);
        debug!("gate_feature(feature = {:?}, span = {:?}); has? {}", name, span, has_feature);
        if !has_feature && !cx.cm.span_allows_unstable(span) {
791
            emit_feature_err(cx.parse_sess, name, span, GateIssue::Language, explain);
792
        }
793 794 795 796 797 798
    }}
}

macro_rules! gate_feature {
    ($cx: expr, $feature: ident, $span: expr, $explain: expr) => {
        gate_feature_fn!($cx, |x:&Features| x.$feature, $span, stringify!($feature), $explain)
799
    }
800
}
801

802
impl<'a> Context<'a> {
803
    fn check_attribute(&self, attr: &ast::Attribute, is_macro: bool) {
804
        debug!("check_attribute(attr = {:?})", attr);
805
        let name = &*attr.name().as_str();
806
        for &(n, ty, ref gateage) in BUILTIN_ATTRIBUTES {
807
            if n == name {
808
                if let &Gated(_, ref name, ref desc, ref has_feature) = gateage {
809
                    gate_feature_fn!(self, has_feature, attr.span, name, desc);
810
                }
811
                debug!("check_attribute: {:?} is builtin, {:?}, {:?}", name, ty, gateage);
812 813 814
                return;
            }
        }
815
        for &(ref n, ref ty) in self.plugin_attributes {
816
            if n == name {
817
                // Plugins can't gate attributes, so we don't check for it
M
Manish Goregaokar 已提交
818 819
                // unlike the code above; we only use this loop to
                // short-circuit to avoid the checks below
820 821 822 823
                debug!("check_attribute: {:?} is registered by a plugin, {:?}", name, ty);
                return;
            }
        }
824
        if name.starts_with("rustc_") {
825 826 827 828
            gate_feature!(self, rustc_attrs, attr.span,
                          "unless otherwise specified, attributes \
                           with the prefix `rustc_` \
                           are reserved for internal compiler diagnostics");
829
        } else if name.starts_with("derive_") {
L
Leo Testard 已提交
830
            gate_feature!(self, custom_derive, attr.span, EXPLAIN_DERIVE_UNDERSCORE);
831 832
        } else if attr::is_known(attr) {
            debug!("check_attribute: {:?} is known", name);
833
        } else {
M
Manish Goregaokar 已提交
834 835 836 837
            // Only run the custom attribute lint during regular
            // feature gate checking. Macro gating runs
            // before the plugin attributes are registered
            // so we skip this then
838
            if !is_macro {
839 840 841 842 843 844
                gate_feature!(self, custom_attribute, attr.span,
                              &format!("The attribute `{}` is currently \
                                        unknown to the compiler and \
                                        may have meaning \
                                        added to it in the future",
                                       name));
845
            }
846 847
        }
    }
848 849
}

850
pub fn check_attribute(attr: &ast::Attribute, parse_sess: &ParseSess,
L
Leo Testard 已提交
851 852
                       cm: &CodeMap, features: &Features) {
    let cx = Context {
853
        features: features, parse_sess: parse_sess,
L
Leo Testard 已提交
854 855 856 857 858
        cm: cm, plugin_attributes: &[]
    };
    cx.check_attribute(attr, true);
}

859 860 861 862
pub fn find_lang_feature_accepted_version(feature: &str) -> Option<&'static str> {
    ACCEPTED_FEATURES.iter().find(|t| t.0 == feature).map(|t| t.1)
}

863
fn find_lang_feature_issue(feature: &str) -> Option<u32> {
864 865
    if let Some(info) = ACTIVE_FEATURES.iter().find(|t| t.0 == feature) {
        let issue = info.2;
866 867
        // FIXME (#28244): enforce that active features have issue numbers
        // assert!(issue.is_some())
868 869 870 871 872 873
        issue
    } else {
        // search in Accepted or Removed features
        ACCEPTED_FEATURES.iter().chain(REMOVED_FEATURES.iter())
            .find(|t| t.0 == feature)
            .unwrap().2
874 875 876 877 878 879 880 881
    }
}

pub enum GateIssue {
    Language,
    Library(Option<u32>)
}

882
pub fn emit_feature_err(sess: &ParseSess, feature: &str, span: Span, issue: GateIssue,
883
                        explain: &str) {
884 885 886 887 888
    feature_err(sess, feature, span, issue, explain).emit();
}

pub fn feature_err<'a>(sess: &'a ParseSess, feature: &str, span: Span, issue: GateIssue,
                   explain: &str) -> DiagnosticBuilder<'a> {
889 890
    let diag = &sess.span_diagnostic;

891 892 893 894 895
    let issue = match issue {
        GateIssue::Language => find_lang_feature_issue(feature),
        GateIssue::Library(lib) => lib,
    };

N
Nick Cameron 已提交
896 897
    let mut err = if let Some(n) = issue {
        diag.struct_span_err(span, &format!("{} (see issue #{})", explain, n))
898
    } else {
N
Nick Cameron 已提交
899 900
        diag.struct_span_err(span, explain)
    };
901 902

    // #23973: do not suggest `#![feature(...)]` if we are in beta/stable
T
Tim Neumann 已提交
903 904 905 906
    if sess.unstable_features.is_nightly_build() {
        err.help(&format!("add #![feature({})] to the \
                           crate attributes to enable",
                          feature));
N
Nick Cameron 已提交
907
    }
T
Tim Neumann 已提交
908

909
    err
910 911
}

L
Leo Testard 已提交
912 913 914
const EXPLAIN_BOX_SYNTAX: &'static str =
    "box expression syntax is experimental; you can call `Box::new` instead.";

J
Jeffrey Seyfried 已提交
915
pub const EXPLAIN_STMT_ATTR_SYNTAX: &'static str =
L
Leo Testard 已提交
916 917
    "attributes on non-item statements and expressions are experimental.";

918 919 920
pub const EXPLAIN_ASM: &'static str =
    "inline assembly is not stable enough for use and is subject to change";

921 922 923 924 925 926 927 928
pub const EXPLAIN_LOG_SYNTAX: &'static str =
    "`log_syntax!` is not stable enough for use and is subject to change";

pub const EXPLAIN_CONCAT_IDENTS: &'static str =
    "`concat_idents` is not stable enough for use and is subject to change";

pub const EXPLAIN_TRACE_MACROS: &'static str =
    "`trace_macros` is not stable enough for use and is subject to change";
929 930
pub const EXPLAIN_ALLOW_INTERNAL_UNSTABLE: &'static str =
    "allow_internal_unstable side-steps feature gating and stability checks";
931

932
pub const EXPLAIN_CUSTOM_DERIVE: &'static str =
N
Nick Cameron 已提交
933 934 935 936 937 938
    "`#[derive]` for custom traits is not stable enough for use. It is deprecated and will \
     be removed in v1.15";

pub const EXPLAIN_DEPR_CUSTOM_DERIVE: &'static str =
    "`#[derive]` for custom traits is deprecated and will be removed in v1.15. Prefer using \
     procedural macro custom derive";
939

L
Leo Testard 已提交
940 941
pub const EXPLAIN_DERIVE_UNDERSCORE: &'static str =
    "attributes of the form `#[derive_*]` are reserved for the compiler";
942

L
Leo Testard 已提交
943 944
pub const EXPLAIN_PLACEMENT_IN: &'static str =
    "placement-in expression syntax is experimental and subject to change.";
C
Corey Richardson 已提交
945 946

struct PostExpansionVisitor<'a> {
N
Nick Cameron 已提交
947
    context: &'a Context<'a>,
C
Corey Richardson 已提交
948 949
}

950 951 952 953 954
macro_rules! gate_feature_post {
    ($cx: expr, $feature: ident, $span: expr, $explain: expr) => {{
        let (cx, span) = ($cx, $span);
        if !cx.context.cm.span_allows_unstable(span) {
            gate_feature!(cx.context, $feature, span, $explain)
C
Corey Richardson 已提交
955
        }
956
    }}
C
Corey Richardson 已提交
957 958
}

959 960 961
impl<'a> PostExpansionVisitor<'a> {
    fn check_abi(&self, abi: Abi, span: Span) {
        match abi {
962
            Abi::RustIntrinsic => {
963
                gate_feature_post!(&self, intrinsics, span,
964 965
                                   "intrinsics are subject to change");
            },
966 967
            Abi::PlatformIntrinsic => {
                gate_feature_post!(&self, platform_intrinsics, span,
968
                                   "platform intrinsics are experimental and possibly buggy");
969 970 971
            },
            Abi::Vectorcall => {
                gate_feature_post!(&self, abi_vectorcall, span,
972 973
                                   "vectorcall is experimental and subject to change");
            },
974 975 976
            Abi::RustCall => {
                gate_feature_post!(&self, unboxed_closures, span,
                                   "rust-call ABI is subject to change");
977 978 979 980 981
            },
            Abi::SysV64 => {
                gate_feature_post!(&self, abi_sysv64, span,
                                   "sysv64 ABI is experimental and subject to change");
            },
982 983 984 985 986
            _ => {}
        }
    }
}

987 988 989 990 991
fn contains_novel_literal(item: &ast::MetaItem) -> bool {
    use ast::MetaItemKind::*;
    use ast::NestedMetaItemKind::*;

    match item.node {
992 993 994
        Word => false,
        NameValue(ref lit) => !lit.node.is_str(),
        List(ref list) => list.iter().any(|li| {
995
            match li.node {
996
                MetaItem(ref mi) => contains_novel_literal(&mi),
997 998 999 1000 1001 1002
                Literal(_) => true,
            }
        }),
    }
}

1003 1004 1005 1006
fn starts_with_digit(s: &str) -> bool {
    s.as_bytes().first().cloned().map_or(false, |b| b >= b'0' && b <= b'9')
}

1007
impl<'a> Visitor for PostExpansionVisitor<'a> {
1008 1009
    fn visit_attribute(&mut self, attr: &ast::Attribute) {
        if !self.context.cm.span_allows_unstable(attr.span) {
1010
            // check for gated attributes
1011
            self.context.check_attribute(attr, false);
1012
        }
1013

1014
        if contains_novel_literal(&attr.value) {
1015 1016 1017 1018
            gate_feature_post!(&self, attr_literals, attr.span,
                               "non-string literals in attributes, or string \
                               literals in top-level positions, are experimental");
        }
1019 1020
    }

1021
    fn visit_name(&mut self, sp: Span, name: ast::Name) {
1022
        if !name.as_str().is_ascii() {
1023 1024
            gate_feature_post!(&self, non_ascii_idents, sp,
                               "non-ascii idents are not fully supported.");
1025 1026 1027
        }
    }

1028
    fn visit_item(&mut self, i: &ast::Item) {
1029
        match i.node {
1030
            ast::ItemKind::ExternCrate(_) => {
1031
                if attr::contains_name(&i.attrs[..], "macro_reexport") {
1032 1033 1034
                    gate_feature_post!(&self, macro_reexport, i.span,
                                       "macros reexports are experimental \
                                        and possibly buggy");
1035 1036 1037
                }
            }

1038
            ast::ItemKind::ForeignMod(ref foreign_module) => {
1039
                if attr::contains_name(&i.attrs[..], "link_args") {
1040
                    gate_feature_post!(&self, link_args, i.span,
1041 1042 1043 1044
                                      "the `link_args` attribute is not portable \
                                       across platforms, it is recommended to \
                                       use `#[link(name = \"foo\")]` instead")
                }
1045
                self.check_abi(foreign_module.abi, i.span);
1046 1047
            }

1048
            ast::ItemKind::Fn(..) => {
1049
                if attr::contains_name(&i.attrs[..], "plugin_registrar") {
1050 1051
                    gate_feature_post!(&self, plugin_registrar, i.span,
                                       "compiler plugins are experimental and possibly buggy");
1052
                }
1053
                if attr::contains_name(&i.attrs[..], "start") {
1054
                    gate_feature_post!(&self, start, i.span,
1055 1056 1057 1058
                                      "a #[start] function is an experimental \
                                       feature whose signature may change \
                                       over time");
                }
1059
                if attr::contains_name(&i.attrs[..], "main") {
1060 1061 1062 1063
                    gate_feature_post!(&self, main, i.span,
                                       "declaration of a nonstandard #[main] \
                                        function may change over time, for now \
                                        a top-level `fn main()` is required");
1064
                }
1065 1066
            }

1067
            ast::ItemKind::Struct(..) => {
1068
                if attr::contains_name(&i.attrs[..], "simd") {
1069 1070
                    gate_feature_post!(&self, simd, i.span,
                                       "SIMD types are experimental and possibly buggy");
1071 1072 1073 1074
                    self.context.parse_sess.span_diagnostic.span_warn(i.span,
                                                                      "the `#[simd]` attribute \
                                                                       is deprecated, use \
                                                                       `#[repr(simd)]` instead");
1075 1076 1077 1078
                }
                for attr in &i.attrs {
                    if attr.name() == "repr" {
                        for item in attr.meta_item_list().unwrap_or(&[]) {
1079
                            if item.check_name("simd") {
1080 1081 1082
                                gate_feature_post!(&self, repr_simd, i.span,
                                                   "SIMD types are experimental \
                                                    and possibly buggy");
1083 1084 1085 1086

                            }
                        }
                    }
1087
                }
D
David Manescu 已提交
1088 1089
            }

1090 1091 1092
            ast::ItemKind::Union(..) => {
                gate_feature_post!(&self, untagged_unions,
                                   i.span,
V
Vadim Petrochenkov 已提交
1093
                                   "unions are unstable and possibly buggy");
1094 1095
            }

1096
            ast::ItemKind::DefaultImpl(..) => {
1097 1098 1099 1100
                gate_feature_post!(&self, optin_builtin_traits,
                                   i.span,
                                   "default trait implementations are experimental \
                                    and possibly buggy");
F
Flavio Percoco 已提交
1101 1102
            }

1103
            ast::ItemKind::Impl(_, polarity, _, _, _, _) => {
1104 1105
                match polarity {
                    ast::ImplPolarity::Negative => {
1106 1107 1108 1109
                        gate_feature_post!(&self, optin_builtin_traits,
                                           i.span,
                                           "negative trait bounds are not yet fully implemented; \
                                            use marker types for now");
1110 1111 1112
                    },
                    _ => {}
                }
1113 1114
            }

1115 1116 1117
            _ => {}
        }

1118
        visit::walk_item(self, i);
1119
    }
1120

1121
    fn visit_foreign_item(&mut self, i: &ast::ForeignItem) {
1122 1123
        let links_to_llvm = match attr::first_attr_value_str_by_name(&i.attrs, "link_name") {
            Some(val) => val.as_str().starts_with("llvm."),
1124 1125 1126
            _ => false
        };
        if links_to_llvm {
1127
            gate_feature_post!(&self, link_llvm_intrinsics, i.span,
1128 1129 1130
                              "linking to LLVM intrinsics is experimental");
        }

1131
        visit::walk_foreign_item(self, i)
1132 1133
    }

1134 1135 1136 1137 1138
    fn visit_ty(&mut self, ty: &ast::Ty) {
        match ty.node {
            ast::TyKind::BareFn(ref bare_fn_ty) => {
                self.check_abi(bare_fn_ty.abi, ty.span);
            }
1139 1140 1141 1142
            ast::TyKind::ImplTrait(..) => {
                gate_feature_post!(&self, conservative_impl_trait, ty.span,
                                   "`impl Trait` is experimental");
            }
A
Andrew Cann 已提交
1143 1144
            ast::TyKind::Never => {
                gate_feature_post!(&self, never_type, ty.span,
1145 1146
                                   "The `!` type is experimental");
            },
1147 1148 1149 1150 1151
            _ => {}
        }
        visit::walk_ty(self, ty)
    }

1152 1153 1154
    fn visit_fn_ret_ty(&mut self, ret_ty: &ast::FunctionRetTy) {
        if let ast::FunctionRetTy::Ty(ref output_ty) = *ret_ty {
            match output_ty.node {
A
Andrew Cann 已提交
1155
                ast::TyKind::Never => return,
1156 1157
                _ => (),
            };
A
Andrew Cann 已提交
1158
            self.visit_ty(output_ty)
1159 1160 1161
        }
    }

1162
    fn visit_expr(&mut self, e: &ast::Expr) {
1163
        match e.node {
1164
            ast::ExprKind::Box(_) => {
1165
                gate_feature_post!(&self, box_syntax, e.span, EXPLAIN_BOX_SYNTAX);
1166
            }
1167
            ast::ExprKind::Type(..) => {
1168
                gate_feature_post!(&self, type_ascription, e.span,
1169 1170
                                  "type ascription is experimental");
            }
1171
            ast::ExprKind::Range(_, _, ast::RangeLimits::Closed) => {
1172
                gate_feature_post!(&self, inclusive_range_syntax,
A
Alex Burka 已提交
1173 1174 1175
                                  e.span,
                                  "inclusive range syntax is experimental");
            }
1176 1177 1178
            ast::ExprKind::InPlace(..) => {
                gate_feature_post!(&self, placement_in_syntax, e.span, EXPLAIN_PLACEMENT_IN);
            }
1179 1180 1181 1182 1183 1184
            ast::ExprKind::Struct(_, ref fields, _) => {
                for field in fields {
                    if field.is_shorthand {
                        gate_feature_post!(&self, field_init_shorthand, field.span,
                                           "struct field shorthands are unstable");
                    }
1185 1186 1187 1188 1189
                    if starts_with_digit(&field.ident.node.name.as_str()) {
                        gate_feature_post!(&self, relaxed_adts,
                                          field.span,
                                          "numeric fields in struct expressions are unstable");
                    }
1190 1191
                }
            }
1192 1193
            _ => {}
        }
1194
        visit::walk_expr(self, e);
1195
    }
1196

1197
    fn visit_pat(&mut self, pattern: &ast::Pat) {
1198
        match pattern.node {
1199
            PatKind::Slice(_, Some(_), ref last) if !last.is_empty() => {
1200
                gate_feature_post!(&self, advanced_slice_patterns,
1201 1202 1203
                                  pattern.span,
                                  "multiple-element slice matches anywhere \
                                   but at the end of a slice (e.g. \
1204
                                   `[0, ..xs, 0]`) are experimental")
1205
            }
1206
            PatKind::Slice(..) => {
1207
                gate_feature_post!(&self, slice_patterns,
1208 1209 1210
                                  pattern.span,
                                  "slice pattern syntax is experimental");
            }
1211
            PatKind::Box(..) => {
1212
                gate_feature_post!(&self, box_patterns,
1213
                                  pattern.span,
1214
                                  "box pattern syntax is experimental");
1215
            }
1216 1217 1218 1219 1220 1221 1222 1223
            PatKind::Struct(_, ref fields, _) => {
                for field in fields {
                    if starts_with_digit(&field.node.ident.name.as_str()) {
                        gate_feature_post!(&self, relaxed_adts,
                                          field.span,
                                          "numeric fields in struct patterns are unstable");
                    }
                }
1224
            }
1225 1226
            _ => {}
        }
1227
        visit::walk_pat(self, pattern)
1228 1229
    }

1230
    fn visit_fn(&mut self,
1231 1232
                fn_kind: FnKind,
                fn_decl: &ast::FnDecl,
1233
                span: Span,
1234
                _node_id: NodeId) {
N
Niko Matsakis 已提交
1235 1236
        // check for const fn declarations
        match fn_kind {
1237
            FnKind::ItemFn(_, _, _, Spanned { node: ast::Constness::Const, .. }, _, _, _) => {
1238
                gate_feature_post!(&self, const_fn, span, "const fn is unstable");
N
Niko Matsakis 已提交
1239 1240 1241 1242 1243 1244 1245 1246 1247
            }
            _ => {
                // stability of const fn methods are covered in
                // visit_trait_item and visit_impl_item below; this is
                // because default methods don't pass through this
                // point.
            }
        }

1248
        match fn_kind {
1249 1250
            FnKind::ItemFn(_, _, _, _, abi, _, _) |
            FnKind::Method(_, &ast::MethodSig { abi, .. }, _, _) => {
1251 1252
                self.check_abi(abi, span);
            }
1253 1254
            _ => {}
        }
1255
        visit::walk_fn(self, fn_kind, fn_decl, span);
1256
    }
1257

1258
    fn visit_trait_item(&mut self, ti: &ast::TraitItem) {
1259
        match ti.node {
1260
            ast::TraitItemKind::Const(..) => {
1261
                gate_feature_post!(&self, associated_consts,
1262 1263 1264
                                  ti.span,
                                  "associated constants are experimental")
            }
1265 1266 1267 1268
            ast::TraitItemKind::Method(ref sig, ref block) => {
                if block.is_none() {
                    self.check_abi(sig.abi, ti.span);
                }
1269
                if sig.constness.node == ast::Constness::Const {
1270
                    gate_feature_post!(&self, const_fn, ti.span, "const fn is unstable");
N
Niko Matsakis 已提交
1271 1272
                }
            }
1273
            ast::TraitItemKind::Type(_, Some(_)) => {
1274
                gate_feature_post!(&self, associated_type_defaults, ti.span,
1275 1276
                                  "associated type defaults are unstable");
            }
1277 1278 1279 1280 1281
            _ => {}
        }
        visit::walk_trait_item(self, ti);
    }

1282
    fn visit_impl_item(&mut self, ii: &ast::ImplItem) {
A
Aaron Turon 已提交
1283
        if ii.defaultness == ast::Defaultness::Default {
1284
            gate_feature_post!(&self, specialization,
A
Aaron Turon 已提交
1285 1286 1287 1288
                              ii.span,
                              "specialization is unstable");
        }

1289
        match ii.node {
1290
            ast::ImplItemKind::Const(..) => {
1291
                gate_feature_post!(&self, associated_consts,
1292 1293 1294
                                  ii.span,
                                  "associated constants are experimental")
            }
1295
            ast::ImplItemKind::Method(ref sig, _) => {
1296
                if sig.constness.node == ast::Constness::Const {
1297
                    gate_feature_post!(&self, const_fn, ii.span, "const fn is unstable");
N
Niko Matsakis 已提交
1298 1299
                }
            }
1300 1301 1302 1303
            _ => {}
        }
        visit::walk_impl_item(self, ii);
    }
1304

1305
    fn visit_vis(&mut self, vis: &ast::Visibility) {
1306 1307
        let span = match *vis {
            ast::Visibility::Crate(span) => span,
1308
            ast::Visibility::Restricted { ref path, .. } => path.span,
1309 1310
            _ => return,
        };
1311
        gate_feature_post!(&self, pub_restricted, span, "`pub(restricted)` syntax is experimental");
1312 1313

        visit::walk_vis(self, vis)
1314
    }
1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332

    fn visit_generics(&mut self, g: &ast::Generics) {
        for t in &g.ty_params {
            if !t.attrs.is_empty() {
                gate_feature_post!(&self, generic_param_attrs, t.attrs[0].span,
                                   "attributes on type parameter bindings are experimental");
            }
        }
        visit::walk_generics(self, g)
    }

    fn visit_lifetime_def(&mut self, lifetime_def: &ast::LifetimeDef) {
        if !lifetime_def.attrs.is_empty() {
            gate_feature_post!(&self, generic_param_attrs, lifetime_def.attrs[0].span,
                               "attributes on lifetime bindings are experimental");
        }
        visit::walk_lifetime_def(self, lifetime_def)
    }
1333 1334
}

J
Jeffrey Seyfried 已提交
1335
pub fn get_features(span_handler: &Handler, krate_attrs: &[ast::Attribute]) -> Features {
1336
    let mut features = Features::new();
N
Nick Cameron 已提交
1337

J
Jeffrey Seyfried 已提交
1338
    for attr in krate_attrs {
S
Steven Fackler 已提交
1339
        if !attr.check_name("feature") {
1340 1341
            continue
        }
1342 1343 1344

        match attr.meta_item_list() {
            None => {
G
ggomez 已提交
1345 1346
                span_err!(span_handler, attr.span, E0555,
                          "malformed feature attribute, expected #![feature(...)]");
1347 1348
            }
            Some(list) => {
1349
                for mi in list {
1350 1351 1352 1353 1354 1355 1356 1357
                    let name = if let Some(word) = mi.word() {
                        word.name()
                    } else {
                        span_err!(span_handler, mi.span, E0556,
                                  "malformed feature, expected just one word");
                        continue
                    };

1358 1359 1360 1361 1362 1363
                    if let Some(&(_, _, _, setter)) = ACTIVE_FEATURES.iter()
                        .find(|& &(n, _, _, _)| name == n) {
                        *(setter(&mut features)) = true;
                    }
                    else if let Some(&(_, _, _)) = REMOVED_FEATURES.iter()
                        .find(|& &(n, _, _)| name == n) {
G
ggomez 已提交
1364
                        span_err!(span_handler, mi.span, E0557, "feature has been removed");
1365 1366 1367
                    }
                    else if let Some(&(_, _, _)) = ACCEPTED_FEATURES.iter()
                        .find(|& &(n, _, _)| name == n) {
1368
                        features.declared_stable_lang_features.push((name, mi.span));
1369 1370
                    } else {
                        features.declared_lib_features.push((name, mi.span));
1371 1372 1373 1374 1375 1376
                    }
                }
            }
        }
    }

L
Leo Testard 已提交
1377
    features
C
Corey Richardson 已提交
1378 1379
}

J
Jeffrey Seyfried 已提交
1380 1381 1382
pub fn check_crate(krate: &ast::Crate,
                   sess: &ParseSess,
                   features: &Features,
1383
                   plugin_attributes: &[(String, AttributeType)],
J
Jeffrey Seyfried 已提交
1384 1385 1386 1387
                   unstable: UnstableFeatures) {
    maybe_stage_features(&sess.span_diagnostic, krate, unstable);
    let ctx = Context {
        features: features,
1388
        parse_sess: sess,
J
Jeffrey Seyfried 已提交
1389 1390 1391 1392
        cm: sess.codemap(),
        plugin_attributes: plugin_attributes,
    };
    visit::walk_crate(&mut PostExpansionVisitor { context: &ctx }, krate);
C
Corey Richardson 已提交
1393
}
1394

1395
#[derive(Clone, Copy, PartialEq, Eq, Hash)]
1396 1397 1398 1399
pub enum UnstableFeatures {
    /// Hard errors for unstable features are active, as on
    /// beta/stable channels.
    Disallow,
J
John Hodge 已提交
1400
    /// Allow features to be activated, as on nightly.
1401 1402 1403 1404
    Allow,
    /// Errors are bypassed for bootstrapping. This is required any time
    /// during the build that feature-related lints are set to warn or above
    /// because the build turns on warnings-as-errors and uses lots of unstable
1405
    /// features. As a result, this is always required for building Rust itself.
1406 1407 1408
    Cheat
}

T
Tim Neumann 已提交
1409 1410 1411 1412
impl UnstableFeatures {
    pub fn from_environment() -> UnstableFeatures {
        // Whether this is a feature-staged build, i.e. on the beta or stable channel
        let disable_unstable_features = option_env!("CFG_DISABLE_UNSTABLE_FEATURES").is_some();
1413 1414 1415 1416 1417 1418
        // Whether we should enable unstable features for bootstrapping
        let bootstrap = env::var("RUSTC_BOOTSTRAP").is_ok();
        match (disable_unstable_features, bootstrap) {
            (_, true) => UnstableFeatures::Cheat,
            (true, _) => UnstableFeatures::Disallow,
            (false, _) => UnstableFeatures::Allow
T
Tim Neumann 已提交
1419 1420
        }
    }
1421 1422 1423 1424 1425 1426 1427

    pub fn is_nightly_build(&self) -> bool {
        match *self {
            UnstableFeatures::Allow | UnstableFeatures::Cheat => true,
            _ => false,
        }
    }
T
Tim Neumann 已提交
1428 1429
}

1430
fn maybe_stage_features(span_handler: &Handler, krate: &ast::Crate,
1431 1432 1433 1434 1435 1436 1437 1438 1439 1440
                        unstable: UnstableFeatures) {
    let allow_features = match unstable {
        UnstableFeatures::Allow => true,
        UnstableFeatures::Disallow => false,
        UnstableFeatures::Cheat => true
    };
    if !allow_features {
        for attr in &krate.attrs {
            if attr.check_name("feature") {
                let release_channel = option_env!("CFG_RELEASE_CHANNEL").unwrap_or("(unknown)");
G
ggomez 已提交
1441
                span_err!(span_handler, attr.span, E0554,
G
ggomez 已提交
1442 1443
                          "#[feature] may not be used on the {} release channel",
                          release_channel);
1444 1445 1446 1447
            }
        }
    }
}