feature_gate.rs 50.9 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

//! Feature gating
//!
L
Luke Gallagher 已提交
13
//! This module implements the gating necessary for preventing certain compiler
14 15 16 17 18
//! features from being used by default. This module will crawl a pre-expanded
//! AST to ensure that there are no features which are used that are not
//! enabled.
//!
//! Features are enabled in programs via the crate-level attributes of
19
//! `#![feature(...)]` with a comma-separated list of features.
B
Brian Anderson 已提交
20 21 22 23
//!
//! For the purpose of future feature-tracking, once code for detection of feature
//! gate usage is added, *do not remove it again* even once the feature
//! becomes stable.
G
GuillaumeGomez 已提交
24

25
use self::AttributeType::*;
26
use self::AttributeGate::*;
27

N
Niko Matsakis 已提交
28
use abi::Abi;
29
use ast::{NodeId, PatKind};
N
Nick Cameron 已提交
30 31 32
use ast;
use attr;
use attr::AttrMetaMethods;
33 34
use codemap::CodeMap;
use syntax_pos::Span;
35
use errors::Handler;
36
use visit::{self, FnKind, Visitor};
J
Jeffrey Seyfried 已提交
37
use parse::ParseSess;
38
use parse::token::InternedString;
39

40 41
use std::ascii::AsciiExt;

42 43 44 45 46 47 48 49
macro_rules! setter {
    ($field: ident) => {{
        fn f(features: &mut Features) -> &mut bool {
            &mut features.$field
        }
        f as fn(&mut Features) -> &mut bool
    }}
}
50

51 52 53 54 55 56 57 58 59 60 61
macro_rules! declare_features {
    ($((active, $feature: ident, $ver: expr, $issue: expr)),+) => {
        /// Represents active features that are currently being implemented or
        /// currently being considered for addition/removal.
        const ACTIVE_FEATURES: &'static [(&'static str, &'static str,
                                          Option<u32>, fn(&mut Features) -> &mut bool)] = &[
            $((stringify!($feature), $ver, $issue, setter!($feature))),+
        ];

        /// A set of features to be used by later passes.
        pub struct Features {
62 63
            /// #![feature] attrs for stable language features, for error reporting
            pub declared_stable_lang_features: Vec<(InternedString, Span)>,
64 65 66 67
            /// #![feature] attrs for non-language (library) features
            pub declared_lib_features: Vec<(InternedString, Span)>,
            $(pub $feature: bool),+
        }
68

69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92
        impl Features {
            pub fn new() -> Features {
                Features {
                    declared_stable_lang_features: Vec::new(),
                    declared_lib_features: Vec::new(),
                    $($feature: false),+
                }
            }
        }
    };

    ($((removed, $feature: ident, $ver: expr, $issue: expr)),+) => {
        /// Represents features which has since been removed (it was once Active)
        const REMOVED_FEATURES: &'static [(&'static str, &'static str, Option<u32>)] = &[
            $((stringify!($feature), $ver, $issue)),+
        ];
    };

    ($((accepted, $feature: ident, $ver: expr, $issue: expr)),+) => {
        /// Those language feature has since been Accepted (it was once Active)
        const ACCEPTED_FEATURES: &'static [(&'static str, &'static str, Option<u32>)] = &[
            $((stringify!($feature), $ver, $issue)),+
        ];
    }
93 94
}

B
Brian Anderson 已提交
95 96 97 98 99
// If you change this list without updating src/doc/reference.md, @cmr will be sad
// Don't ever remove anything from this list; set them to 'Removed'.
// The version numbers here correspond to the version in which the current status
// was set. This is most important for knowing when a particular feature became
// stable (active).
100 101 102 103 104 105 106 107 108 109 110 111
// NB: The featureck.py script parses this information directly out of the source
// so take care when modifying it.

declare_features! (
    (active, asm, "1.0.0", Some(29722)),
    (active, concat_idents, "1.0.0", Some(29599)),
    (active, link_args, "1.0.0", Some(29596)),
    (active, log_syntax, "1.0.0", Some(29598)),
    (active, non_ascii_idents, "1.0.0", Some(28979)),
    (active, plugin_registrar, "1.0.0", Some(29597)),
    (active, thread_local, "1.0.0", Some(29594)),
    (active, trace_macros, "1.0.0", Some(29598)),
A
Aaron Turon 已提交
112 113

    // rustc internal, for now:
114 115
    (active, intrinsics, "1.0.0", None),
    (active, lang_items, "1.0.0", None),
116

117 118 119 120
    (active, link_llvm_intrinsics, "1.0.0", Some(29602)),
    (active, linkage, "1.0.0", Some(29603)),
    (active, quote, "1.0.0", Some(29601)),
    (active, simd, "1.0.0", Some(27731)),
121 122


A
Aaron Turon 已提交
123
    // rustc internal
124 125 126 127 128 129
    (active, rustc_diagnostic_macros, "1.0.0", None),
    (active, advanced_slice_patterns, "1.0.0", Some(23121)),
    (active, box_syntax, "1.0.0", Some(27779)),
    (active, placement_in_syntax, "1.0.0", Some(27779)),
    (active, reflect, "1.0.0", Some(27749)),
    (active, unboxed_closures, "1.0.0", Some(29625)),
A
Aaron Turon 已提交
130 131

    // rustc internal.
132 133 134 135 136 137 138 139 140 141 142 143
    (active, pushpop_unsafe, "1.2.0", None),

    (active, allocator, "1.0.0", Some(27389)),
    (active, fundamental, "1.0.0", Some(29635)),
    (active, linked_from, "1.3.0", Some(29629)),
    (active, main, "1.0.0", Some(29634)),
    (active, needs_allocator, "1.4.0", Some(27389)),
    (active, on_unimplemented, "1.0.0", Some(29628)),
    (active, plugin, "1.0.0", Some(29597)),
    (active, simd_ffi, "1.0.0", Some(27731)),
    (active, start, "1.0.0", Some(29633)),
    (active, structural_match, "1.8.0", Some(31434)),
144 145
    (active, panic_runtime, "1.10.0", Some(32837)),
    (active, needs_panic_runtime, "1.10.0", Some(32837)),
146

147
    // OIBIT specific features
148
    (active, optin_builtin_traits, "1.0.0", Some(13231)),
149

J
Joseph Crail 已提交
150
    // macro reexport needs more discussion and stabilization
151
    (active, macro_reexport, "1.0.0", Some(29638)),
152 153

    // Allows use of #[staged_api]
A
Aaron Turon 已提交
154
    // rustc internal
155
    (active, staged_api, "1.0.0", None),
156 157

    // Allows using items which are missing stability attributes
A
Aaron Turon 已提交
158
    // rustc internal
159
    (active, unmarked_api, "1.0.0", None),
160

A
Alex Crichton 已提交
161
    // Allows using #![no_core]
162
    (active, no_core, "1.3.0", Some(29639)),
A
Alex Crichton 已提交
163

164
    // Allows using `box` in patterns; RFC 469
165
    (active, box_patterns, "1.0.0", Some(29641)),
166

167 168
    // Allows using the unsafe_no_drop_flag attribute (unlikely to
    // switch to Accepted; see RFC 320)
169
    (active, unsafe_no_drop_flag, "1.0.0", None),
170

171 172
    // Allows using the unsafe_destructor_blind_to_params attribute;
    // RFC 1238
173
    (active, dropck_parametricity, "1.3.0", Some(28498)),
174

175
    // Allows the use of custom attributes; RFC 572
176
    (active, custom_attribute, "1.0.0", Some(29642)),
M
Manish Goregaokar 已提交
177

178 179
    // Allows the use of #[derive(Anything)] as sugar for
    // #[derive_Anything].
180
    (active, custom_derive, "1.0.0", Some(29644)),
181

M
Manish Goregaokar 已提交
182
    // Allows the use of rustc_* attributes; RFC 572
183
    (active, rustc_attrs, "1.0.0", Some(29642)),
H
Huon Wilson 已提交
184

185 186 187 188
    // Allows the use of #[allow_internal_unstable]. This is an
    // attribute on macro_rules! and can't use the attribute handling
    // below (it has to be checked before expansion possibly makes
    // macros disappear).
A
Aaron Turon 已提交
189 190
    //
    // rustc internal
191
    (active, allow_internal_unstable, "1.0.0", None),
192 193

    // #23121. Array patterns have some hazards yet.
194
    (active, slice_patterns, "1.0.0", Some(23121)),
195 196 197

    // Allows the definition of associated constants in `trait` or `impl`
    // blocks.
198
    (active, associated_consts, "1.0.0", Some(29646)),
N
Niko Matsakis 已提交
199 200

    // Allows the definition of `const fn` functions.
201
    (active, const_fn, "1.2.0", Some(24111)),
202

203
    // Allows indexing into constant arrays.
204
    (active, const_indexing, "1.4.0", Some(29947)),
205

206
    // Allows using #[prelude_import] on glob `use` items.
A
Aaron Turon 已提交
207 208
    //
    // rustc internal
209
    (active, prelude_import, "1.2.0", None),
210 211

    // Allows the definition recursive static items.
212
    (active, static_recursion, "1.3.0", Some(29719)),
B
Brian Anderson 已提交
213 214

    // Allows default type parameters to influence type inference.
215
    (active, default_type_parameter_fallback, "1.3.0", Some(27336)),
216 217

    // Allows associated type defaults
218
    (active, associated_type_defaults, "1.2.0", Some(29661)),
J
Jared Roesch 已提交
219

A
Aaron Turon 已提交
220
    // Allows macros to appear in the type position.
221
    (active, type_macros, "1.3.0", Some(27245)),
222 223

    // allow `repr(simd)`, and importing the various simd intrinsics
224
    (active, repr_simd, "1.4.0", Some(27731)),
225 226

    // Allows cfg(target_feature = "...").
227
    (active, cfg_target_feature, "1.4.0", Some(29717)),
228 229

    // allow `extern "platform-intrinsic" { ... }`
230
    (active, platform_intrinsics, "1.4.0", Some(27731)),
231 232

    // allow `#[unwind]`
A
Aaron Turon 已提交
233
    // rust runtime internal
234
    (active, unwind_attributes, "1.4.0", None),
V
Vadim Petrochenkov 已提交
235

T
Ticki 已提交
236
    // allow the use of `#[naked]` on functions.
237
    (active, naked_functions, "1.9.0", Some(32408)),
238 239

    // allow `#[no_debug]`
240
    (active, no_debug, "1.5.0", Some(29721)),
241 242

    // allow `#[omit_gdb_pretty_printer_section]`
A
Aaron Turon 已提交
243
    // rustc internal.
244
    (active, omit_gdb_pretty_printer_section, "1.5.0", None),
245 246

    // Allows cfg(target_vendor = "...").
247
    (active, cfg_target_vendor, "1.5.0", Some(29718)),
248 249

    // Allow attributes on expressions and non-item statements
250
    (active, stmt_expr_attributes, "1.6.0", Some(15701)),
251 252

    // allow using type ascription in expressions
253
    (active, type_ascription, "1.6.0", Some(23416)),
254 255

    // Allows cfg(target_thread_local)
256
    (active, cfg_target_thread_local, "1.7.0", Some(29594)),
257 258

    // rustc internal
259
    (active, abi_vectorcall, "1.7.0", None),
A
Alex Burka 已提交
260 261

    // a...b and ...b
262
    (active, inclusive_range_syntax, "1.7.0", Some(28237)),
J
Jorge Aparicio 已提交
263 264

    // `expr?`
265
    (active, question_mark, "1.9.0", Some(31436)),
A
Aaron Turon 已提交
266 267

    // impl specialization (RFC 1210)
268
    (active, specialization, "1.7.0", Some(31844)),
269 270

    // pub(restricted) visibilities (RFC 1422)
271 272
    (active, pub_restricted, "1.9.0", Some(32409)),

273 274 275 276
    // Allow Drop types in statics/const functions (RFC 1440)
    (active, drop_types_in_const, "1.9.0", Some(33156)),

    // Allows cfg(target_has_atomic = "...").
277 278 279
    (active, cfg_target_has_atomic, "1.9.0", Some(32976)),

    // Allows `..` in tuple (struct) patterns
280 281 282
    (active, dotdot_in_tuple_patterns, "1.10.0", Some(33627)),

    // Allows `impl Trait` in function return types.
283 284 285 286
    (active, conservative_impl_trait, "1.12.0", Some(34511)),

    // Allows tuple structs and variants in more contexts,
    // Permits numeric fields in struct expressions and patterns.
287 288 289
    (active, relaxed_adts, "1.12.0", Some(35626)),

    // The `!` type
A
Andrew Cann 已提交
290
    (active, never_type, "1.13.0", Some(35121))
291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330
);

declare_features! (
    (removed, import_shadowing, "1.0.0", None),
    (removed, managed_boxes, "1.0.0", None),
    // Allows use of unary negate on unsigned integers, e.g. -e for e: u8
    (removed, negate_unsigned, "1.0.0", Some(29645)),
    // A way to temporarily opt out of opt in copy. This will *never* be accepted.
    (removed, opt_out_copy, "1.0.0", None),
    (removed, quad_precision_float, "1.0.0", None),
    (removed, struct_inherit, "1.0.0", None),
    (removed, test_removed_feature, "1.0.0", None),
    (removed, visible_private_types, "1.0.0", None)
);

declare_features! (
    (accepted, associated_types, "1.0.0", None),
    // allow overloading augmented assignment operations like `a += b`
    (accepted, augmented_assignments, "1.8.0", Some(28235)),
    // allow empty structs and enum variants with braces
    (accepted, braced_empty_structs, "1.8.0", Some(29720)),
    (accepted, default_type_params, "1.0.0", None),
    (accepted, globs, "1.0.0", None),
    (accepted, if_let, "1.0.0", None),
    // A temporary feature gate used to enable parser extensions needed
    // to bootstrap fix for #5723.
    (accepted, issue_5723_bootstrap, "1.0.0", None),
    (accepted, macro_rules, "1.0.0", None),
    // Allows using #![no_std]
    (accepted, no_std, "1.0.0", None),
    (accepted, slicing_syntax, "1.0.0", None),
    (accepted, struct_variant, "1.0.0", None),
    // These are used to test this portion of the compiler, they don't actually
    // mean anything
    (accepted, test_accepted_feature, "1.0.0", None),
    (accepted, tuple_indexing, "1.0.0", None),
    (accepted, while_let, "1.0.0", None),
    // Allows `#[deprecated]` attribute
    (accepted, deprecated, "1.9.0", Some(29935))
);
331
// (changing above list without updating src/doc/reference.md makes @cmr sad)
332

333 334 335 336 337
#[derive(PartialEq, Copy, Clone, Debug)]
pub enum AttributeType {
    /// Normal, builtin attribute that is consumed
    /// by the compiler before the unused_attribute check
    Normal,
338

339 340 341 342
    /// Builtin attribute that may not be consumed by the compiler
    /// before the unused_attribute check. These attributes
    /// will be ignored by the unused_attribute lint
    Whitelisted,
343

344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373
    /// Builtin attribute that is only allowed at the crate level
    CrateLevel,
}

pub enum AttributeGate {
    /// Is gated by a given feature gate, reason
    /// and function to check if enabled
    Gated(&'static str, &'static str, fn(&Features) -> bool),

    /// Ungated attribute, can be used on all release channels
    Ungated,
}

// fn() is not Debug
impl ::std::fmt::Debug for AttributeGate {
    fn fmt(&self, fmt: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
        match *self {
            Gated(ref name, ref expl, _) => write!(fmt, "Gated({}, {})", name, expl),
            Ungated => write!(fmt, "Ungated")
        }
    }
}

macro_rules! cfg_fn {
    ($field: ident) => {{
        fn f(features: &Features) -> bool {
            features.$field
        }
        f as fn(&Features) -> bool
    }}
374 375
}

376
// Attributes that have a special meaning to rustc or rustdoc
377
pub const KNOWN_ATTRIBUTES: &'static [(&'static str, AttributeType, AttributeGate)] = &[
378 379
    // Normal attributes

380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409
    ("warn", Normal, Ungated),
    ("allow", Normal, Ungated),
    ("forbid", Normal, Ungated),
    ("deny", Normal, Ungated),

    ("macro_reexport", Normal, Ungated),
    ("macro_use", Normal, Ungated),
    ("macro_export", Normal, Ungated),
    ("plugin_registrar", Normal, Ungated),

    ("cfg", Normal, Ungated),
    ("cfg_attr", Normal, Ungated),
    ("main", Normal, Ungated),
    ("start", Normal, Ungated),
    ("test", Normal, Ungated),
    ("bench", Normal, Ungated),
    ("simd", Normal, Ungated),
    ("repr", Normal, Ungated),
    ("path", Normal, Ungated),
    ("abi", Normal, Ungated),
    ("automatically_derived", Normal, Ungated),
    ("no_mangle", Normal, Ungated),
    ("no_link", Normal, Ungated),
    ("derive", Normal, Ungated),
    ("should_panic", Normal, Ungated),
    ("ignore", Normal, Ungated),
    ("no_implicit_prelude", Normal, Ungated),
    ("reexport_test_harness_main", Normal, Ungated),
    ("link_args", Normal, Ungated),
    ("macro_escape", Normal, Ungated),
410

411 412 413
    // RFC #1445.
    ("structural_match", Whitelisted, Gated("structural_match",
                                            "the semantics of constant patterns is \
414 415
                                             not yet settled",
                                            cfg_fn!(structural_match))),
416

A
Alex Crichton 已提交
417
    // Not used any more, but we can't feature gate it
418 419 420 421
    ("no_stack_check", Normal, Ungated),

    ("plugin", CrateLevel, Gated("plugin",
                                 "compiler plugins are experimental \
422 423 424
                                  and possibly buggy",
                                 cfg_fn!(plugin))),

425
    ("no_std", CrateLevel, Ungated),
426
    ("no_core", CrateLevel, Gated("no_core",
427 428
                                  "no_core is experimental",
                                  cfg_fn!(no_core))),
429
    ("lang", Normal, Gated("lang_items",
430 431
                           "language items are subject to change",
                           cfg_fn!(lang_items))),
432 433
    ("linkage", Whitelisted, Gated("linkage",
                                   "the `linkage` attribute is experimental \
434 435
                                    and not portable across platforms",
                                   cfg_fn!(linkage))),
436 437 438 439
    ("thread_local", Whitelisted, Gated("thread_local",
                                        "`#[thread_local]` is an experimental feature, and does \
                                         not currently handle destructors. There is no \
                                         corresponding `#[task_local]` mapping to the task \
440 441
                                         model",
                                        cfg_fn!(thread_local))),
442 443 444

    ("rustc_on_unimplemented", Normal, Gated("on_unimplemented",
                                             "the `#[rustc_on_unimplemented]` attribute \
445 446
                                              is an experimental feature",
                                             cfg_fn!(on_unimplemented))),
447
    ("allocator", Whitelisted, Gated("allocator",
448 449
                                     "the `#[allocator]` attribute is an experimental feature",
                                     cfg_fn!(allocator))),
450 451 452
    ("needs_allocator", Normal, Gated("needs_allocator",
                                      "the `#[needs_allocator]` \
                                       attribute is an experimental \
453 454
                                       feature",
                                      cfg_fn!(needs_allocator))),
455 456 457 458 459 460 461 462 463
    ("panic_runtime", Whitelisted, Gated("panic_runtime",
                                         "the `#[panic_runtime]` attribute is \
                                          an experimental feature",
                                         cfg_fn!(panic_runtime))),
    ("needs_panic_runtime", Whitelisted, Gated("needs_panic_runtime",
                                               "the `#[needs_panic_runtime]` \
                                                attribute is an experimental \
                                                feature",
                                               cfg_fn!(needs_panic_runtime))),
464 465
    ("rustc_variance", Normal, Gated("rustc_attrs",
                                     "the `#[rustc_variance]` attribute \
N
Niko Matsakis 已提交
466
                                      is just used for rustc unit tests \
467 468
                                      and will never be stable",
                                     cfg_fn!(rustc_attrs))),
469 470
    ("rustc_error", Whitelisted, Gated("rustc_attrs",
                                       "the `#[rustc_error]` attribute \
N
Niko Matsakis 已提交
471
                                        is just used for rustc unit tests \
472 473
                                        and will never be stable",
                                       cfg_fn!(rustc_attrs))),
474
    ("rustc_if_this_changed", Whitelisted, Gated("rustc_attrs",
475 476 477 478
                                                 "the `#[rustc_if_this_changed]` attribute \
                                                  is just used for rustc unit tests \
                                                  and will never be stable",
                                                 cfg_fn!(rustc_attrs))),
479
    ("rustc_then_this_would_need", Whitelisted, Gated("rustc_attrs",
480 481 482 483
                                                      "the `#[rustc_if_this_changed]` attribute \
                                                       is just used for rustc unit tests \
                                                       and will never be stable",
                                                      cfg_fn!(rustc_attrs))),
484 485 486
    ("rustc_dirty", Whitelisted, Gated("rustc_attrs",
                                       "the `#[rustc_dirty]` attribute \
                                        is just used for rustc unit tests \
487 488
                                        and will never be stable",
                                       cfg_fn!(rustc_attrs))),
489 490 491
    ("rustc_clean", Whitelisted, Gated("rustc_attrs",
                                       "the `#[rustc_clean]` attribute \
                                        is just used for rustc unit tests \
492 493
                                        and will never be stable",
                                       cfg_fn!(rustc_attrs))),
494 495 496 497 498 499 500 501 502 503
    ("rustc_partition_reused", Whitelisted, Gated("rustc_attrs",
                                                  "this attribute \
                                                   is just used for rustc unit tests \
                                                   and will never be stable",
                                                  cfg_fn!(rustc_attrs))),
    ("rustc_partition_translated", Whitelisted, Gated("rustc_attrs",
                                                      "this attribute \
                                                       is just used for rustc unit tests \
                                                       and will never be stable",
                                                      cfg_fn!(rustc_attrs))),
504
    ("rustc_symbol_name", Whitelisted, Gated("rustc_attrs",
505 506
                                             "internal rustc attributes will never be stable",
                                             cfg_fn!(rustc_attrs))),
507
    ("rustc_item_path", Whitelisted, Gated("rustc_attrs",
508 509
                                           "internal rustc attributes will never be stable",
                                           cfg_fn!(rustc_attrs))),
510 511
    ("rustc_move_fragments", Normal, Gated("rustc_attrs",
                                           "the `#[rustc_move_fragments]` attribute \
N
Niko Matsakis 已提交
512
                                            is just used for rustc unit tests \
513 514
                                            and will never be stable",
                                           cfg_fn!(rustc_attrs))),
515 516 517
    ("rustc_mir", Whitelisted, Gated("rustc_attrs",
                                     "the `#[rustc_mir]` attribute \
                                      is just used for rustc unit tests \
518 519
                                      and will never be stable",
                                     cfg_fn!(rustc_attrs))),
520 521 522
    ("rustc_no_mir", Whitelisted, Gated("rustc_attrs",
                                        "the `#[rustc_no_mir]` attribute \
                                         is just used to make tests pass \
523 524
                                         and will never be stable",
                                        cfg_fn!(rustc_attrs))),
525 526 527 528 529 530 531
    ("rustc_inherit_overflow_checks", Whitelisted, Gated("rustc_attrs",
                                                         "the `#[rustc_inherit_overflow_checks]` \
                                                          attribute is just used to control \
                                                          overflow checking behavior of several \
                                                          libcore functions that are inlined \
                                                          across crates and will never be stable",
                                                          cfg_fn!(rustc_attrs))),
532 533

    ("allow_internal_unstable", Normal, Gated("allow_internal_unstable",
534 535
                                              EXPLAIN_ALLOW_INTERNAL_UNSTABLE,
                                              cfg_fn!(allow_internal_unstable))),
536 537 538

    ("fundamental", Whitelisted, Gated("fundamental",
                                       "the `#[fundamental]` attribute \
539 540
                                        is an experimental feature",
                                       cfg_fn!(fundamental))),
541 542 543

    ("linked_from", Normal, Gated("linked_from",
                                  "the `#[linked_from]` attribute \
544 545
                                   is an experimental feature",
                                  cfg_fn!(linked_from))),
546

547
    // FIXME: #14408 whitelist docs since rustdoc looks at them
548
    ("doc", Whitelisted, Ungated),
549 550 551

    // FIXME: #14406 these are processed in trans, which happens after the
    // lint pass
552
    ("cold", Whitelisted, Ungated),
T
Ticki 已提交
553 554
    ("naked", Whitelisted, Gated("naked_functions",
                                 "the `#[naked]` attribute \
555
                                  is an experimental feature",
556
                                 cfg_fn!(naked_functions))),
557 558 559 560 561 562 563
    ("export_name", Whitelisted, Ungated),
    ("inline", Whitelisted, Ungated),
    ("link", Whitelisted, Ungated),
    ("link_name", Whitelisted, Ungated),
    ("link_section", Whitelisted, Ungated),
    ("no_builtins", Whitelisted, Ungated),
    ("no_mangle", Whitelisted, Ungated),
564 565
    ("no_debug", Whitelisted, Gated("no_debug",
                                    "the `#[no_debug]` attribute \
566 567
                                     is an experimental feature",
                                    cfg_fn!(no_debug))),
568 569 570
    ("omit_gdb_pretty_printer_section", Whitelisted, Gated("omit_gdb_pretty_printer_section",
                                                       "the `#[omit_gdb_pretty_printer_section]` \
                                                        attribute is just used for the Rust test \
571 572
                                                        suite",
                                                       cfg_fn!(omit_gdb_pretty_printer_section))),
573 574
    ("unsafe_no_drop_flag", Whitelisted, Gated("unsafe_no_drop_flag",
                                               "unsafe_no_drop_flag has unstable semantics \
575 576
                                                and may be removed in the future",
                                               cfg_fn!(unsafe_no_drop_flag))),
577 578
    ("unsafe_destructor_blind_to_params",
     Normal,
579
     Gated("dropck_parametricity",
580
           "unsafe_destructor_blind_to_params has unstable semantics \
581 582 583 584
            and may be removed in the future",
           cfg_fn!(dropck_parametricity))),
    ("unwind", Whitelisted, Gated("unwind_attributes", "#[unwind] is experimental",
                                  cfg_fn!(unwind_attributes))),
585 586

    // used in resolve
587
    ("prelude_import", Whitelisted, Gated("prelude_import",
588 589
                                          "`#[prelude_import]` is for use by rustc only",
                                          cfg_fn!(prelude_import))),
590 591 592

    // FIXME: #14407 these are only looked at on-demand so we can't
    // guarantee they'll have already been checked
593
    ("rustc_deprecated", Whitelisted, Ungated),
594 595 596
    ("must_use", Whitelisted, Ungated),
    ("stable", Whitelisted, Ungated),
    ("unstable", Whitelisted, Ungated),
597
    ("deprecated", Normal, Ungated),
598

599
    ("rustc_paren_sugar", Normal, Gated("unboxed_closures",
600 601
                                        "unboxed_closures are still evolving",
                                        cfg_fn!(unboxed_closures))),
602
    ("rustc_reflect_like", Whitelisted, Gated("reflect",
603 604
                                              "defining reflective traits is still evolving",
                                              cfg_fn!(reflect))),
605 606

    // Crate level attributes
607 608 609 610 611 612 613 614
    ("crate_name", CrateLevel, Ungated),
    ("crate_type", CrateLevel, Ungated),
    ("crate_id", CrateLevel, Ungated),
    ("feature", CrateLevel, Ungated),
    ("no_start", CrateLevel, Ungated),
    ("no_main", CrateLevel, Ungated),
    ("no_builtins", CrateLevel, Ungated),
    ("recursion_limit", CrateLevel, Ungated),
615 616
];

617 618 619
// cfg(...)'s that are feature gated
const GATED_CFGS: &'static [(&'static str, &'static str, fn(&Features) -> bool)] = &[
    // (name in cfg, feature, function to check if the feature is enabled)
620 621 622
    ("target_feature", "cfg_target_feature", cfg_fn!(cfg_target_feature)),
    ("target_vendor", "cfg_target_vendor", cfg_fn!(cfg_target_vendor)),
    ("target_thread_local", "cfg_target_thread_local", cfg_fn!(cfg_target_thread_local)),
623
    ("target_has_atomic", "cfg_target_has_atomic", cfg_fn!(cfg_target_has_atomic)),
624 625 626 627 628 629 630
];

#[derive(Debug, Eq, PartialEq)]
pub struct GatedCfg {
    span: Span,
    index: usize,
}
631

632 633 634 635 636 637 638 639 640 641 642 643
impl GatedCfg {
    pub fn gate(cfg: &ast::MetaItem) -> Option<GatedCfg> {
        let name = cfg.name();
        GATED_CFGS.iter()
                  .position(|info| info.0 == name)
                  .map(|idx| {
                      GatedCfg {
                          span: cfg.span,
                          index: idx
                      }
                  })
    }
J
Jeffrey Seyfried 已提交
644 645

    pub fn check_and_emit(&self, sess: &ParseSess, features: &Features) {
646
        let (cfg, feature, has_feature) = GATED_CFGS[self.index];
J
Jeffrey Seyfried 已提交
647 648
        if !has_feature(features) && !sess.codemap().span_allows_unstable(self.span) {
            let diagnostic = &sess.span_diagnostic;
649
            let explain = format!("`cfg({})` is experimental and subject to change", cfg);
650
            emit_feature_err(diagnostic, feature, self.span, GateIssue::Language, &explain);
651 652 653 654
        }
    }
}

E
Eduard Burtescu 已提交
655
struct Context<'a> {
L
Leo Testard 已提交
656
    features: &'a Features,
657
    span_handler: &'a Handler,
C
Corey Richardson 已提交
658
    cm: &'a CodeMap,
659
    plugin_attributes: &'a [(String, AttributeType)],
660 661
}

662 663 664 665 666 667 668
macro_rules! gate_feature_fn {
    ($cx: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{
        let (cx, has_feature, span, name, explain) = ($cx, $has_feature, $span, $name, $explain);
        let has_feature: bool = has_feature(&$cx.features);
        debug!("gate_feature(feature = {:?}, span = {:?}); has? {}", name, span, has_feature);
        if !has_feature && !cx.cm.span_allows_unstable(span) {
            emit_feature_err(cx.span_handler, name, span, GateIssue::Language, explain);
669
        }
670 671 672 673 674 675
    }}
}

macro_rules! gate_feature {
    ($cx: expr, $feature: ident, $span: expr, $explain: expr) => {
        gate_feature_fn!($cx, |x:&Features| x.$feature, $span, stringify!($feature), $explain)
676
    }
677
}
678

679
impl<'a> Context<'a> {
680
    fn check_attribute(&self, attr: &ast::Attribute, is_macro: bool) {
681 682
        debug!("check_attribute(attr = {:?})", attr);
        let name = &*attr.name();
683
        for &(n, ty, ref gateage) in KNOWN_ATTRIBUTES {
684
            if n == name {
685 686
                if let &Gated(ref name, ref desc, ref has_feature) = gateage {
                    gate_feature_fn!(self, has_feature, attr.span, name, desc);
687
                }
688
                debug!("check_attribute: {:?} is known, {:?}, {:?}", name, ty, gateage);
689 690 691
                return;
            }
        }
692
        for &(ref n, ref ty) in self.plugin_attributes {
693
            if n == name {
694
                // Plugins can't gate attributes, so we don't check for it
M
Manish Goregaokar 已提交
695 696
                // unlike the code above; we only use this loop to
                // short-circuit to avoid the checks below
697 698 699 700
                debug!("check_attribute: {:?} is registered by a plugin, {:?}", name, ty);
                return;
            }
        }
701
        if name.starts_with("rustc_") {
702 703 704 705
            gate_feature!(self, rustc_attrs, attr.span,
                          "unless otherwise specified, attributes \
                           with the prefix `rustc_` \
                           are reserved for internal compiler diagnostics");
706
        } else if name.starts_with("derive_") {
L
Leo Testard 已提交
707
            gate_feature!(self, custom_derive, attr.span, EXPLAIN_DERIVE_UNDERSCORE);
708
        } else {
M
Manish Goregaokar 已提交
709 710 711 712
            // Only run the custom attribute lint during regular
            // feature gate checking. Macro gating runs
            // before the plugin attributes are registered
            // so we skip this then
713
            if !is_macro {
714 715 716 717 718 719
                gate_feature!(self, custom_attribute, attr.span,
                              &format!("The attribute `{}` is currently \
                                        unknown to the compiler and \
                                        may have meaning \
                                        added to it in the future",
                                       name));
720
            }
721 722
        }
    }
723 724
}

L
Leo Testard 已提交
725 726 727 728 729 730 731 732 733
pub fn check_attribute(attr: &ast::Attribute, handler: &Handler,
                       cm: &CodeMap, features: &Features) {
    let cx = Context {
        features: features, span_handler: handler,
        cm: cm, plugin_attributes: &[]
    };
    cx.check_attribute(attr, true);
}

734 735 736 737
pub fn find_lang_feature_accepted_version(feature: &str) -> Option<&'static str> {
    ACCEPTED_FEATURES.iter().find(|t| t.0 == feature).map(|t| t.1)
}

738
fn find_lang_feature_issue(feature: &str) -> Option<u32> {
739 740
    if let Some(info) = ACTIVE_FEATURES.iter().find(|t| t.0 == feature) {
        let issue = info.2;
741 742
        // FIXME (#28244): enforce that active features have issue numbers
        // assert!(issue.is_some())
743 744 745 746 747 748
        issue
    } else {
        // search in Accepted or Removed features
        ACCEPTED_FEATURES.iter().chain(REMOVED_FEATURES.iter())
            .find(|t| t.0 == feature)
            .unwrap().2
749 750 751 752 753 754 755 756
    }
}

pub enum GateIssue {
    Language,
    Library(Option<u32>)
}

757
pub fn emit_feature_err(diag: &Handler, feature: &str, span: Span, issue: GateIssue,
758 759 760 761 762 763
                        explain: &str) {
    let issue = match issue {
        GateIssue::Language => find_lang_feature_issue(feature),
        GateIssue::Library(lib) => lib,
    };

N
Nick Cameron 已提交
764 765
    let mut err = if let Some(n) = issue {
        diag.struct_span_err(span, &format!("{} (see issue #{})", explain, n))
766
    } else {
N
Nick Cameron 已提交
767 768
        diag.struct_span_err(span, explain)
    };
769 770

    // #23973: do not suggest `#![feature(...)]` if we are in beta/stable
N
Nick Cameron 已提交
771 772 773 774
    if option_env!("CFG_DISABLE_UNSTABLE_FEATURES").is_some() {
        err.emit();
        return;
    }
775 776 777
    err.help(&format!("add #![feature({})] to the \
                       crate attributes to enable",
                      feature));
N
Nick Cameron 已提交
778
    err.emit();
779 780
}

L
Leo Testard 已提交
781 782 783
const EXPLAIN_BOX_SYNTAX: &'static str =
    "box expression syntax is experimental; you can call `Box::new` instead.";

J
Jeffrey Seyfried 已提交
784
pub const EXPLAIN_STMT_ATTR_SYNTAX: &'static str =
L
Leo Testard 已提交
785 786
    "attributes on non-item statements and expressions are experimental.";

787 788 789
pub const EXPLAIN_ASM: &'static str =
    "inline assembly is not stable enough for use and is subject to change";

790 791 792 793 794 795 796 797
pub const EXPLAIN_LOG_SYNTAX: &'static str =
    "`log_syntax!` is not stable enough for use and is subject to change";

pub const EXPLAIN_CONCAT_IDENTS: &'static str =
    "`concat_idents` is not stable enough for use and is subject to change";

pub const EXPLAIN_TRACE_MACROS: &'static str =
    "`trace_macros` is not stable enough for use and is subject to change";
798 799
pub const EXPLAIN_ALLOW_INTERNAL_UNSTABLE: &'static str =
    "allow_internal_unstable side-steps feature gating and stability checks";
800

801 802 803
pub const EXPLAIN_CUSTOM_DERIVE: &'static str =
    "`#[derive]` for custom traits is not stable enough for use and is subject to change";

L
Leo Testard 已提交
804 805
pub const EXPLAIN_DERIVE_UNDERSCORE: &'static str =
    "attributes of the form `#[derive_*]` are reserved for the compiler";
806

L
Leo Testard 已提交
807 808
pub const EXPLAIN_PLACEMENT_IN: &'static str =
    "placement-in expression syntax is experimental and subject to change.";
C
Corey Richardson 已提交
809 810

struct PostExpansionVisitor<'a> {
N
Nick Cameron 已提交
811
    context: &'a Context<'a>,
C
Corey Richardson 已提交
812 813
}

814 815 816 817 818
macro_rules! gate_feature_post {
    ($cx: expr, $feature: ident, $span: expr, $explain: expr) => {{
        let (cx, span) = ($cx, $span);
        if !cx.context.cm.span_allows_unstable(span) {
            gate_feature!(cx.context, $feature, span, $explain)
C
Corey Richardson 已提交
819
        }
820
    }}
C
Corey Richardson 已提交
821 822
}

823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845
impl<'a> PostExpansionVisitor<'a> {
    fn check_abi(&self, abi: Abi, span: Span) {
        match abi {
            Abi::RustIntrinsic =>
                gate_feature_post!(&self, intrinsics, span,
                                   "intrinsics are subject to change"),
            Abi::PlatformIntrinsic => {
                gate_feature_post!(&self, platform_intrinsics, span,
                                   "platform intrinsics are experimental and possibly buggy")
            },
            Abi::Vectorcall => {
                gate_feature_post!(&self, abi_vectorcall, span,
                                   "vectorcall is experimental and subject to change")
            }
            Abi::RustCall => {
                gate_feature_post!(&self, unboxed_closures, span,
                                   "rust-call ABI is subject to change");
            }
            _ => {}
        }
    }
}

846
impl<'a> Visitor for PostExpansionVisitor<'a> {
847 848
    fn visit_attribute(&mut self, attr: &ast::Attribute) {
        if !self.context.cm.span_allows_unstable(attr.span) {
849
            self.context.check_attribute(attr, false);
850 851 852
        }
    }

853
    fn visit_name(&mut self, sp: Span, name: ast::Name) {
854
        if !name.as_str().is_ascii() {
855 856
            gate_feature_post!(&self, non_ascii_idents, sp,
                               "non-ascii idents are not fully supported.");
857 858 859
        }
    }

860
    fn visit_item(&mut self, i: &ast::Item) {
861
        match i.node {
862
            ast::ItemKind::ExternCrate(_) => {
863
                if attr::contains_name(&i.attrs[..], "macro_reexport") {
864 865 866
                    gate_feature_post!(&self, macro_reexport, i.span,
                                       "macros reexports are experimental \
                                        and possibly buggy");
867 868 869
                }
            }

870
            ast::ItemKind::ForeignMod(ref foreign_module) => {
871
                if attr::contains_name(&i.attrs[..], "link_args") {
872
                    gate_feature_post!(&self, link_args, i.span,
873 874 875 876
                                      "the `link_args` attribute is not portable \
                                       across platforms, it is recommended to \
                                       use `#[link(name = \"foo\")]` instead")
                }
877
                self.check_abi(foreign_module.abi, i.span);
878 879
            }

880
            ast::ItemKind::Fn(..) => {
881
                if attr::contains_name(&i.attrs[..], "plugin_registrar") {
882 883
                    gate_feature_post!(&self, plugin_registrar, i.span,
                                       "compiler plugins are experimental and possibly buggy");
884
                }
885
                if attr::contains_name(&i.attrs[..], "start") {
886
                    gate_feature_post!(&self, start, i.span,
887 888 889 890
                                      "a #[start] function is an experimental \
                                       feature whose signature may change \
                                       over time");
                }
891
                if attr::contains_name(&i.attrs[..], "main") {
892 893 894 895
                    gate_feature_post!(&self, main, i.span,
                                       "declaration of a nonstandard #[main] \
                                        function may change over time, for now \
                                        a top-level `fn main()` is required");
896
                }
897 898
            }

899
            ast::ItemKind::Struct(..) => {
900
                if attr::contains_name(&i.attrs[..], "simd") {
901 902
                    gate_feature_post!(&self, simd, i.span,
                                       "SIMD types are experimental and possibly buggy");
903 904 905 906 907 908 909 910
                    self.context.span_handler.span_warn(i.span,
                                                        "the `#[simd]` attribute is deprecated, \
                                                         use `#[repr(simd)]` instead");
                }
                for attr in &i.attrs {
                    if attr.name() == "repr" {
                        for item in attr.meta_item_list().unwrap_or(&[]) {
                            if item.name() == "simd" {
911 912 913
                                gate_feature_post!(&self, repr_simd, i.span,
                                                   "SIMD types are experimental \
                                                    and possibly buggy");
914 915 916 917

                            }
                        }
                    }
918
                }
D
David Manescu 已提交
919 920
            }

921
            ast::ItemKind::DefaultImpl(..) => {
922 923 924 925
                gate_feature_post!(&self, optin_builtin_traits,
                                   i.span,
                                   "default trait implementations are experimental \
                                    and possibly buggy");
F
Flavio Percoco 已提交
926 927
            }

928
            ast::ItemKind::Impl(_, polarity, _, _, _, _) => {
929 930
                match polarity {
                    ast::ImplPolarity::Negative => {
931 932 933 934
                        gate_feature_post!(&self, optin_builtin_traits,
                                           i.span,
                                           "negative trait bounds are not yet fully implemented; \
                                            use marker types for now");
935 936 937
                    },
                    _ => {}
                }
938 939
            }

940 941 942
            _ => {}
        }

943
        visit::walk_item(self, i);
944
    }
945

946
    fn visit_foreign_item(&mut self, i: &ast::ForeignItem) {
947
        let links_to_llvm = match attr::first_attr_value_str_by_name(&i.attrs,
N
fallout  
Nick Cameron 已提交
948
                                                                     "link_name") {
G
GuillaumeGomez 已提交
949
            Some(val) => val.starts_with("llvm."),
950 951 952
            _ => false
        };
        if links_to_llvm {
953
            gate_feature_post!(&self, link_llvm_intrinsics, i.span,
954 955 956
                              "linking to LLVM intrinsics is experimental");
        }

957
        visit::walk_foreign_item(self, i)
958 959
    }

960 961 962 963 964
    fn visit_ty(&mut self, ty: &ast::Ty) {
        match ty.node {
            ast::TyKind::BareFn(ref bare_fn_ty) => {
                self.check_abi(bare_fn_ty.abi, ty.span);
            }
965 966 967 968
            ast::TyKind::ImplTrait(..) => {
                gate_feature_post!(&self, conservative_impl_trait, ty.span,
                                   "`impl Trait` is experimental");
            }
A
Andrew Cann 已提交
969 970
            ast::TyKind::Never => {
                gate_feature_post!(&self, never_type, ty.span,
971 972
                                   "The `!` type is experimental");
            },
973 974 975 976 977
            _ => {}
        }
        visit::walk_ty(self, ty)
    }

978 979 980
    fn visit_fn_ret_ty(&mut self, ret_ty: &ast::FunctionRetTy) {
        if let ast::FunctionRetTy::Ty(ref output_ty) = *ret_ty {
            match output_ty.node {
A
Andrew Cann 已提交
981
                ast::TyKind::Never => return,
982 983 984 985 986 987
                _ => (),
            };
            visit::walk_ty(self, output_ty)
        }
    }

988
    fn visit_expr(&mut self, e: &ast::Expr) {
989
        match e.node {
990
            ast::ExprKind::Box(_) => {
991
                gate_feature_post!(&self, box_syntax, e.span, EXPLAIN_BOX_SYNTAX);
992
            }
993
            ast::ExprKind::Type(..) => {
994
                gate_feature_post!(&self, type_ascription, e.span,
995 996
                                  "type ascription is experimental");
            }
997
            ast::ExprKind::Range(_, _, ast::RangeLimits::Closed) => {
998
                gate_feature_post!(&self, inclusive_range_syntax,
A
Alex Burka 已提交
999 1000 1001
                                  e.span,
                                  "inclusive range syntax is experimental");
            }
J
Jorge Aparicio 已提交
1002
            ast::ExprKind::Try(..) => {
1003
                gate_feature_post!(&self, question_mark, e.span, "the `?` operator is not stable");
J
Jorge Aparicio 已提交
1004
            }
1005 1006 1007
            ast::ExprKind::InPlace(..) => {
                gate_feature_post!(&self, placement_in_syntax, e.span, EXPLAIN_PLACEMENT_IN);
            }
1008 1009
            _ => {}
        }
1010
        visit::walk_expr(self, e);
1011
    }
1012

1013
    fn visit_pat(&mut self, pattern: &ast::Pat) {
1014
        match pattern.node {
1015
            PatKind::Vec(_, Some(_), ref last) if !last.is_empty() => {
1016
                gate_feature_post!(&self, advanced_slice_patterns,
1017 1018 1019
                                  pattern.span,
                                  "multiple-element slice matches anywhere \
                                   but at the end of a slice (e.g. \
1020
                                   `[0, ..xs, 0]`) are experimental")
1021
            }
1022
            PatKind::Vec(..) => {
1023
                gate_feature_post!(&self, slice_patterns,
1024 1025 1026
                                  pattern.span,
                                  "slice pattern syntax is experimental");
            }
1027
            PatKind::Box(..) => {
1028
                gate_feature_post!(&self, box_patterns,
1029
                                  pattern.span,
1030
                                  "box pattern syntax is experimental");
1031
            }
1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045
            PatKind::Tuple(_, ddpos)
                    if ddpos.is_some() => {
                gate_feature_post!(&self, dotdot_in_tuple_patterns,
                                  pattern.span,
                                  "`..` in tuple patterns is experimental");
            }
            PatKind::TupleStruct(_, ref fields, ddpos)
                    if ddpos.is_some() && !fields.is_empty() => {
                gate_feature_post!(&self, dotdot_in_tuple_patterns,
                                  pattern.span,
                                  "`..` in tuple struct patterns is experimental");
            }
            PatKind::TupleStruct(_, ref fields, ddpos)
                    if ddpos.is_none() && fields.is_empty() => {
1046 1047
                gate_feature_post!(&self, relaxed_adts, pattern.span,
                                   "empty tuple structs patterns are unstable");
1048
            }
1049 1050
            _ => {}
        }
1051
        visit::walk_pat(self, pattern)
1052 1053
    }

1054
    fn visit_fn(&mut self,
1055 1056 1057
                fn_kind: FnKind,
                fn_decl: &ast::FnDecl,
                block: &ast::Block,
1058
                span: Span,
1059
                _node_id: NodeId) {
N
Niko Matsakis 已提交
1060 1061
        // check for const fn declarations
        match fn_kind {
1062
            FnKind::ItemFn(_, _, _, ast::Constness::Const, _, _) => {
1063
                gate_feature_post!(&self, const_fn, span, "const fn is unstable");
N
Niko Matsakis 已提交
1064 1065 1066 1067 1068 1069 1070 1071 1072
            }
            _ => {
                // stability of const fn methods are covered in
                // visit_trait_item and visit_impl_item below; this is
                // because default methods don't pass through this
                // point.
            }
        }

1073
        match fn_kind {
1074
            FnKind::ItemFn(_, _, _, _, abi, _) |
1075 1076 1077
            FnKind::Method(_, &ast::MethodSig { abi, .. }, _) => {
                self.check_abi(abi, span);
            }
1078 1079
            _ => {}
        }
1080
        visit::walk_fn(self, fn_kind, fn_decl, block, span);
1081
    }
1082

1083
    fn visit_trait_item(&mut self, ti: &ast::TraitItem) {
1084
        match ti.node {
1085
            ast::TraitItemKind::Const(..) => {
1086
                gate_feature_post!(&self, associated_consts,
1087 1088 1089
                                  ti.span,
                                  "associated constants are experimental")
            }
1090 1091 1092 1093
            ast::TraitItemKind::Method(ref sig, ref block) => {
                if block.is_none() {
                    self.check_abi(sig.abi, ti.span);
                }
N
Niko Matsakis 已提交
1094
                if sig.constness == ast::Constness::Const {
1095
                    gate_feature_post!(&self, const_fn, ti.span, "const fn is unstable");
N
Niko Matsakis 已提交
1096 1097
                }
            }
1098
            ast::TraitItemKind::Type(_, Some(_)) => {
1099
                gate_feature_post!(&self, associated_type_defaults, ti.span,
1100 1101
                                  "associated type defaults are unstable");
            }
1102 1103 1104 1105 1106
            _ => {}
        }
        visit::walk_trait_item(self, ti);
    }

1107
    fn visit_impl_item(&mut self, ii: &ast::ImplItem) {
A
Aaron Turon 已提交
1108
        if ii.defaultness == ast::Defaultness::Default {
1109
            gate_feature_post!(&self, specialization,
A
Aaron Turon 已提交
1110 1111 1112 1113
                              ii.span,
                              "specialization is unstable");
        }

1114
        match ii.node {
1115
            ast::ImplItemKind::Const(..) => {
1116
                gate_feature_post!(&self, associated_consts,
1117 1118 1119
                                  ii.span,
                                  "associated constants are experimental")
            }
1120
            ast::ImplItemKind::Method(ref sig, _) => {
N
Niko Matsakis 已提交
1121
                if sig.constness == ast::Constness::Const {
1122
                    gate_feature_post!(&self, const_fn, ii.span, "const fn is unstable");
N
Niko Matsakis 已提交
1123 1124
                }
            }
1125 1126 1127 1128
            _ => {}
        }
        visit::walk_impl_item(self, ii);
    }
1129

1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142
    fn visit_variant_data(&mut self, vdata: &ast::VariantData, _: ast::Ident,
                          _: &ast::Generics, _: NodeId, span: Span) {
        if vdata.fields().is_empty() {
            if vdata.is_tuple() {
                gate_feature_post!(&self, relaxed_adts, span,
                                   "empty tuple structs and enum variants are unstable, \
                                    use unit structs and enum variants instead");
            }
        }

        visit::walk_struct_def(self, vdata)
    }

1143
    fn visit_vis(&mut self, vis: &ast::Visibility) {
1144 1145
        let span = match *vis {
            ast::Visibility::Crate(span) => span,
1146
            ast::Visibility::Restricted { ref path, .. } => path.span,
1147 1148
            _ => return,
        };
1149
        gate_feature_post!(&self, pub_restricted, span, "`pub(restricted)` syntax is experimental");
1150 1151

        visit::walk_vis(self, vis)
1152
    }
1153 1154
}

J
Jeffrey Seyfried 已提交
1155
pub fn get_features(span_handler: &Handler, krate_attrs: &[ast::Attribute]) -> Features {
1156
    let mut features = Features::new();
N
Nick Cameron 已提交
1157

J
Jeffrey Seyfried 已提交
1158
    for attr in krate_attrs {
S
Steven Fackler 已提交
1159
        if !attr.check_name("feature") {
1160 1161
            continue
        }
1162 1163 1164

        match attr.meta_item_list() {
            None => {
G
ggomez 已提交
1165 1166
                span_err!(span_handler, attr.span, E0555,
                          "malformed feature attribute, expected #![feature(...)]");
1167 1168
            }
            Some(list) => {
1169
                for mi in list {
1170 1171 1172 1173 1174 1175 1176
                    let name = if mi.is_word() {
                                   mi.name()
                               } else {
                                   span_err!(span_handler, mi.span, E0556,
                                             "malformed feature, expected just one word");
                                   continue
                               };
1177 1178 1179 1180 1181 1182
                    if let Some(&(_, _, _, setter)) = ACTIVE_FEATURES.iter()
                        .find(|& &(n, _, _, _)| name == n) {
                        *(setter(&mut features)) = true;
                    }
                    else if let Some(&(_, _, _)) = REMOVED_FEATURES.iter()
                        .find(|& &(n, _, _)| name == n) {
G
ggomez 已提交
1183
                        span_err!(span_handler, mi.span, E0557, "feature has been removed");
1184 1185 1186
                    }
                    else if let Some(&(_, _, _)) = ACCEPTED_FEATURES.iter()
                        .find(|& &(n, _, _)| name == n) {
1187
                        features.declared_stable_lang_features.push((name, mi.span));
1188 1189
                    } else {
                        features.declared_lib_features.push((name, mi.span));
1190 1191 1192 1193 1194 1195
                    }
                }
            }
        }
    }

L
Leo Testard 已提交
1196
    features
C
Corey Richardson 已提交
1197 1198
}

J
Jeffrey Seyfried 已提交
1199 1200 1201
pub fn check_crate(krate: &ast::Crate,
                   sess: &ParseSess,
                   features: &Features,
1202
                   plugin_attributes: &[(String, AttributeType)],
J
Jeffrey Seyfried 已提交
1203 1204 1205 1206 1207 1208 1209 1210 1211
                   unstable: UnstableFeatures) {
    maybe_stage_features(&sess.span_diagnostic, krate, unstable);
    let ctx = Context {
        features: features,
        span_handler: &sess.span_diagnostic,
        cm: sess.codemap(),
        plugin_attributes: plugin_attributes,
    };
    visit::walk_crate(&mut PostExpansionVisitor { context: &ctx }, krate);
C
Corey Richardson 已提交
1212
}
1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223

#[derive(Clone, Copy)]
pub enum UnstableFeatures {
    /// Hard errors for unstable features are active, as on
    /// beta/stable channels.
    Disallow,
    /// Allow features to me activated, as on nightly.
    Allow,
    /// Errors are bypassed for bootstrapping. This is required any time
    /// during the build that feature-related lints are set to warn or above
    /// because the build turns on warnings-as-errors and uses lots of unstable
1224
    /// features. As a result, this is always required for building Rust itself.
1225 1226 1227
    Cheat
}

1228
fn maybe_stage_features(span_handler: &Handler, krate: &ast::Crate,
1229 1230 1231 1232 1233 1234 1235 1236 1237 1238
                        unstable: UnstableFeatures) {
    let allow_features = match unstable {
        UnstableFeatures::Allow => true,
        UnstableFeatures::Disallow => false,
        UnstableFeatures::Cheat => true
    };
    if !allow_features {
        for attr in &krate.attrs {
            if attr.check_name("feature") {
                let release_channel = option_env!("CFG_RELEASE_CHANNEL").unwrap_or("(unknown)");
G
ggomez 已提交
1239
                span_err!(span_handler, attr.span, E0554,
G
ggomez 已提交
1240 1241
                          "#[feature] may not be used on the {} release channel",
                          release_channel);
1242 1243 1244 1245
            }
        }
    }
}