feature_gate.rs 50.2 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

//! Feature gating
//!
L
Luke Gallagher 已提交
13
//! This module implements the gating necessary for preventing certain compiler
14 15 16 17 18
//! features from being used by default. This module will crawl a pre-expanded
//! AST to ensure that there are no features which are used that are not
//! enabled.
//!
//! Features are enabled in programs via the crate-level attributes of
19
//! `#![feature(...)]` with a comma-separated list of features.
B
Brian Anderson 已提交
20 21 22 23
//!
//! For the purpose of future feature-tracking, once code for detection of feature
//! gate usage is added, *do not remove it again* even once the feature
//! becomes stable.
G
GuillaumeGomez 已提交
24

25
use self::AttributeType::*;
26
use self::AttributeGate::*;
27

N
Niko Matsakis 已提交
28
use abi::Abi;
29
use ast::{NodeId, PatKind};
N
Nick Cameron 已提交
30 31 32
use ast;
use attr;
use attr::AttrMetaMethods;
33 34
use codemap::CodeMap;
use syntax_pos::Span;
35
use errors::Handler;
36
use visit::{self, FnKind, Visitor};
J
Jeffrey Seyfried 已提交
37
use parse::ParseSess;
38
use parse::token::InternedString;
39

40 41
use std::ascii::AsciiExt;

42 43 44 45 46 47 48 49
macro_rules! setter {
    ($field: ident) => {{
        fn f(features: &mut Features) -> &mut bool {
            &mut features.$field
        }
        f as fn(&mut Features) -> &mut bool
    }}
}
50

51 52 53 54 55 56 57 58 59 60 61
macro_rules! declare_features {
    ($((active, $feature: ident, $ver: expr, $issue: expr)),+) => {
        /// Represents active features that are currently being implemented or
        /// currently being considered for addition/removal.
        const ACTIVE_FEATURES: &'static [(&'static str, &'static str,
                                          Option<u32>, fn(&mut Features) -> &mut bool)] = &[
            $((stringify!($feature), $ver, $issue, setter!($feature))),+
        ];

        /// A set of features to be used by later passes.
        pub struct Features {
62 63
            /// #![feature] attrs for stable language features, for error reporting
            pub declared_stable_lang_features: Vec<(InternedString, Span)>,
64 65 66 67
            /// #![feature] attrs for non-language (library) features
            pub declared_lib_features: Vec<(InternedString, Span)>,
            $(pub $feature: bool),+
        }
68

69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92
        impl Features {
            pub fn new() -> Features {
                Features {
                    declared_stable_lang_features: Vec::new(),
                    declared_lib_features: Vec::new(),
                    $($feature: false),+
                }
            }
        }
    };

    ($((removed, $feature: ident, $ver: expr, $issue: expr)),+) => {
        /// Represents features which has since been removed (it was once Active)
        const REMOVED_FEATURES: &'static [(&'static str, &'static str, Option<u32>)] = &[
            $((stringify!($feature), $ver, $issue)),+
        ];
    };

    ($((accepted, $feature: ident, $ver: expr, $issue: expr)),+) => {
        /// Those language feature has since been Accepted (it was once Active)
        const ACCEPTED_FEATURES: &'static [(&'static str, &'static str, Option<u32>)] = &[
            $((stringify!($feature), $ver, $issue)),+
        ];
    }
93 94
}

B
Brian Anderson 已提交
95 96 97 98 99
// If you change this list without updating src/doc/reference.md, @cmr will be sad
// Don't ever remove anything from this list; set them to 'Removed'.
// The version numbers here correspond to the version in which the current status
// was set. This is most important for knowing when a particular feature became
// stable (active).
100 101 102 103 104 105 106 107 108 109 110 111
// NB: The featureck.py script parses this information directly out of the source
// so take care when modifying it.

declare_features! (
    (active, asm, "1.0.0", Some(29722)),
    (active, concat_idents, "1.0.0", Some(29599)),
    (active, link_args, "1.0.0", Some(29596)),
    (active, log_syntax, "1.0.0", Some(29598)),
    (active, non_ascii_idents, "1.0.0", Some(28979)),
    (active, plugin_registrar, "1.0.0", Some(29597)),
    (active, thread_local, "1.0.0", Some(29594)),
    (active, trace_macros, "1.0.0", Some(29598)),
A
Aaron Turon 已提交
112 113

    // rustc internal, for now:
114 115
    (active, intrinsics, "1.0.0", None),
    (active, lang_items, "1.0.0", None),
116

117 118 119 120
    (active, link_llvm_intrinsics, "1.0.0", Some(29602)),
    (active, linkage, "1.0.0", Some(29603)),
    (active, quote, "1.0.0", Some(29601)),
    (active, simd, "1.0.0", Some(27731)),
121 122


A
Aaron Turon 已提交
123
    // rustc internal
124 125 126 127 128 129
    (active, rustc_diagnostic_macros, "1.0.0", None),
    (active, advanced_slice_patterns, "1.0.0", Some(23121)),
    (active, box_syntax, "1.0.0", Some(27779)),
    (active, placement_in_syntax, "1.0.0", Some(27779)),
    (active, reflect, "1.0.0", Some(27749)),
    (active, unboxed_closures, "1.0.0", Some(29625)),
A
Aaron Turon 已提交
130 131

    // rustc internal.
132 133 134 135 136 137 138 139 140 141 142 143
    (active, pushpop_unsafe, "1.2.0", None),

    (active, allocator, "1.0.0", Some(27389)),
    (active, fundamental, "1.0.0", Some(29635)),
    (active, linked_from, "1.3.0", Some(29629)),
    (active, main, "1.0.0", Some(29634)),
    (active, needs_allocator, "1.4.0", Some(27389)),
    (active, on_unimplemented, "1.0.0", Some(29628)),
    (active, plugin, "1.0.0", Some(29597)),
    (active, simd_ffi, "1.0.0", Some(27731)),
    (active, start, "1.0.0", Some(29633)),
    (active, structural_match, "1.8.0", Some(31434)),
144 145
    (active, panic_runtime, "1.10.0", Some(32837)),
    (active, needs_panic_runtime, "1.10.0", Some(32837)),
146

147
    // OIBIT specific features
148
    (active, optin_builtin_traits, "1.0.0", Some(13231)),
149

J
Joseph Crail 已提交
150
    // macro reexport needs more discussion and stabilization
151
    (active, macro_reexport, "1.0.0", Some(29638)),
152 153

    // Allows use of #[staged_api]
A
Aaron Turon 已提交
154
    // rustc internal
155
    (active, staged_api, "1.0.0", None),
156 157

    // Allows using items which are missing stability attributes
A
Aaron Turon 已提交
158
    // rustc internal
159
    (active, unmarked_api, "1.0.0", None),
160

A
Alex Crichton 已提交
161
    // Allows using #![no_core]
162
    (active, no_core, "1.3.0", Some(29639)),
A
Alex Crichton 已提交
163

164
    // Allows using `box` in patterns; RFC 469
165
    (active, box_patterns, "1.0.0", Some(29641)),
166

167 168
    // Allows using the unsafe_destructor_blind_to_params attribute;
    // RFC 1238
169
    (active, dropck_parametricity, "1.3.0", Some(28498)),
170

171
    // Allows the use of custom attributes; RFC 572
172
    (active, custom_attribute, "1.0.0", Some(29642)),
M
Manish Goregaokar 已提交
173

174 175
    // Allows the use of #[derive(Anything)] as sugar for
    // #[derive_Anything].
176
    (active, custom_derive, "1.0.0", Some(29644)),
177

M
Manish Goregaokar 已提交
178
    // Allows the use of rustc_* attributes; RFC 572
179
    (active, rustc_attrs, "1.0.0", Some(29642)),
H
Huon Wilson 已提交
180

181 182 183 184
    // Allows the use of #[allow_internal_unstable]. This is an
    // attribute on macro_rules! and can't use the attribute handling
    // below (it has to be checked before expansion possibly makes
    // macros disappear).
A
Aaron Turon 已提交
185 186
    //
    // rustc internal
187
    (active, allow_internal_unstable, "1.0.0", None),
188 189

    // #23121. Array patterns have some hazards yet.
190
    (active, slice_patterns, "1.0.0", Some(23121)),
191 192 193

    // Allows the definition of associated constants in `trait` or `impl`
    // blocks.
194
    (active, associated_consts, "1.0.0", Some(29646)),
N
Niko Matsakis 已提交
195 196

    // Allows the definition of `const fn` functions.
197
    (active, const_fn, "1.2.0", Some(24111)),
198

199
    // Allows indexing into constant arrays.
200
    (active, const_indexing, "1.4.0", Some(29947)),
201

202
    // Allows using #[prelude_import] on glob `use` items.
A
Aaron Turon 已提交
203 204
    //
    // rustc internal
205
    (active, prelude_import, "1.2.0", None),
206 207

    // Allows the definition recursive static items.
208
    (active, static_recursion, "1.3.0", Some(29719)),
B
Brian Anderson 已提交
209 210

    // Allows default type parameters to influence type inference.
211
    (active, default_type_parameter_fallback, "1.3.0", Some(27336)),
212 213

    // Allows associated type defaults
214
    (active, associated_type_defaults, "1.2.0", Some(29661)),
J
Jared Roesch 已提交
215

216
    // allow `repr(simd)`, and importing the various simd intrinsics
217
    (active, repr_simd, "1.4.0", Some(27731)),
218 219

    // Allows cfg(target_feature = "...").
220
    (active, cfg_target_feature, "1.4.0", Some(29717)),
221 222

    // allow `extern "platform-intrinsic" { ... }`
223
    (active, platform_intrinsics, "1.4.0", Some(27731)),
224 225

    // allow `#[unwind]`
A
Aaron Turon 已提交
226
    // rust runtime internal
227
    (active, unwind_attributes, "1.4.0", None),
V
Vadim Petrochenkov 已提交
228

T
Ticki 已提交
229
    // allow the use of `#[naked]` on functions.
230
    (active, naked_functions, "1.9.0", Some(32408)),
231 232

    // allow `#[no_debug]`
233
    (active, no_debug, "1.5.0", Some(29721)),
234 235

    // allow `#[omit_gdb_pretty_printer_section]`
A
Aaron Turon 已提交
236
    // rustc internal.
237
    (active, omit_gdb_pretty_printer_section, "1.5.0", None),
238 239

    // Allows cfg(target_vendor = "...").
240
    (active, cfg_target_vendor, "1.5.0", Some(29718)),
241 242

    // Allow attributes on expressions and non-item statements
243
    (active, stmt_expr_attributes, "1.6.0", Some(15701)),
244 245

    // allow using type ascription in expressions
246
    (active, type_ascription, "1.6.0", Some(23416)),
247 248

    // Allows cfg(target_thread_local)
249
    (active, cfg_target_thread_local, "1.7.0", Some(29594)),
250 251

    // rustc internal
252
    (active, abi_vectorcall, "1.7.0", None),
A
Alex Burka 已提交
253 254

    // a...b and ...b
255
    (active, inclusive_range_syntax, "1.7.0", Some(28237)),
J
Jorge Aparicio 已提交
256 257

    // `expr?`
258
    (active, question_mark, "1.9.0", Some(31436)),
A
Aaron Turon 已提交
259 260

    // impl specialization (RFC 1210)
261
    (active, specialization, "1.7.0", Some(31844)),
262 263

    // pub(restricted) visibilities (RFC 1422)
264 265
    (active, pub_restricted, "1.9.0", Some(32409)),

266 267 268 269
    // Allow Drop types in statics/const functions (RFC 1440)
    (active, drop_types_in_const, "1.9.0", Some(33156)),

    // Allows cfg(target_has_atomic = "...").
270 271 272
    (active, cfg_target_has_atomic, "1.9.0", Some(32976)),

    // Allows `..` in tuple (struct) patterns
273 274 275
    (active, dotdot_in_tuple_patterns, "1.10.0", Some(33627)),

    // Allows `impl Trait` in function return types.
276 277 278 279
    (active, conservative_impl_trait, "1.12.0", Some(34511)),

    // Allows tuple structs and variants in more contexts,
    // Permits numeric fields in struct expressions and patterns.
280 281 282
    (active, relaxed_adts, "1.12.0", Some(35626)),

    // The `!` type
A
Andrew Cann 已提交
283
    (active, never_type, "1.13.0", Some(35121))
284 285 286 287 288 289 290 291 292 293 294 295
);

declare_features! (
    (removed, import_shadowing, "1.0.0", None),
    (removed, managed_boxes, "1.0.0", None),
    // Allows use of unary negate on unsigned integers, e.g. -e for e: u8
    (removed, negate_unsigned, "1.0.0", Some(29645)),
    // A way to temporarily opt out of opt in copy. This will *never* be accepted.
    (removed, opt_out_copy, "1.0.0", None),
    (removed, quad_precision_float, "1.0.0", None),
    (removed, struct_inherit, "1.0.0", None),
    (removed, test_removed_feature, "1.0.0", None),
296 297
    (removed, visible_private_types, "1.0.0", None),
    (removed, unsafe_no_drop_flag, "1.0.0", None)
298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313
);

declare_features! (
    (accepted, associated_types, "1.0.0", None),
    // allow overloading augmented assignment operations like `a += b`
    (accepted, augmented_assignments, "1.8.0", Some(28235)),
    // allow empty structs and enum variants with braces
    (accepted, braced_empty_structs, "1.8.0", Some(29720)),
    (accepted, default_type_params, "1.0.0", None),
    (accepted, globs, "1.0.0", None),
    (accepted, if_let, "1.0.0", None),
    // A temporary feature gate used to enable parser extensions needed
    // to bootstrap fix for #5723.
    (accepted, issue_5723_bootstrap, "1.0.0", None),
    (accepted, macro_rules, "1.0.0", None),
    // Allows using #![no_std]
314
    (accepted, no_std, "1.6.0", None),
315 316 317 318 319 320
    (accepted, slicing_syntax, "1.0.0", None),
    (accepted, struct_variant, "1.0.0", None),
    // These are used to test this portion of the compiler, they don't actually
    // mean anything
    (accepted, test_accepted_feature, "1.0.0", None),
    (accepted, tuple_indexing, "1.0.0", None),
D
Daniele Baracchi 已提交
321 322
    // Allows macros to appear in the type position.
    (accepted, type_macros, "1.13.0", Some(27245)),
323 324 325 326
    (accepted, while_let, "1.0.0", None),
    // Allows `#[deprecated]` attribute
    (accepted, deprecated, "1.9.0", Some(29935))
);
327
// (changing above list without updating src/doc/reference.md makes @cmr sad)
328

329 330 331 332 333
#[derive(PartialEq, Copy, Clone, Debug)]
pub enum AttributeType {
    /// Normal, builtin attribute that is consumed
    /// by the compiler before the unused_attribute check
    Normal,
334

335 336 337 338
    /// Builtin attribute that may not be consumed by the compiler
    /// before the unused_attribute check. These attributes
    /// will be ignored by the unused_attribute lint
    Whitelisted,
339

340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369
    /// Builtin attribute that is only allowed at the crate level
    CrateLevel,
}

pub enum AttributeGate {
    /// Is gated by a given feature gate, reason
    /// and function to check if enabled
    Gated(&'static str, &'static str, fn(&Features) -> bool),

    /// Ungated attribute, can be used on all release channels
    Ungated,
}

// fn() is not Debug
impl ::std::fmt::Debug for AttributeGate {
    fn fmt(&self, fmt: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
        match *self {
            Gated(ref name, ref expl, _) => write!(fmt, "Gated({}, {})", name, expl),
            Ungated => write!(fmt, "Ungated")
        }
    }
}

macro_rules! cfg_fn {
    ($field: ident) => {{
        fn f(features: &Features) -> bool {
            features.$field
        }
        f as fn(&Features) -> bool
    }}
370 371
}

372
// Attributes that have a special meaning to rustc or rustdoc
373
pub const KNOWN_ATTRIBUTES: &'static [(&'static str, AttributeType, AttributeGate)] = &[
374 375
    // Normal attributes

376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405
    ("warn", Normal, Ungated),
    ("allow", Normal, Ungated),
    ("forbid", Normal, Ungated),
    ("deny", Normal, Ungated),

    ("macro_reexport", Normal, Ungated),
    ("macro_use", Normal, Ungated),
    ("macro_export", Normal, Ungated),
    ("plugin_registrar", Normal, Ungated),

    ("cfg", Normal, Ungated),
    ("cfg_attr", Normal, Ungated),
    ("main", Normal, Ungated),
    ("start", Normal, Ungated),
    ("test", Normal, Ungated),
    ("bench", Normal, Ungated),
    ("simd", Normal, Ungated),
    ("repr", Normal, Ungated),
    ("path", Normal, Ungated),
    ("abi", Normal, Ungated),
    ("automatically_derived", Normal, Ungated),
    ("no_mangle", Normal, Ungated),
    ("no_link", Normal, Ungated),
    ("derive", Normal, Ungated),
    ("should_panic", Normal, Ungated),
    ("ignore", Normal, Ungated),
    ("no_implicit_prelude", Normal, Ungated),
    ("reexport_test_harness_main", Normal, Ungated),
    ("link_args", Normal, Ungated),
    ("macro_escape", Normal, Ungated),
406

407 408 409
    // RFC #1445.
    ("structural_match", Whitelisted, Gated("structural_match",
                                            "the semantics of constant patterns is \
410 411
                                             not yet settled",
                                            cfg_fn!(structural_match))),
412

A
Alex Crichton 已提交
413
    // Not used any more, but we can't feature gate it
414 415 416 417
    ("no_stack_check", Normal, Ungated),

    ("plugin", CrateLevel, Gated("plugin",
                                 "compiler plugins are experimental \
418 419 420
                                  and possibly buggy",
                                 cfg_fn!(plugin))),

421
    ("no_std", CrateLevel, Ungated),
422
    ("no_core", CrateLevel, Gated("no_core",
423 424
                                  "no_core is experimental",
                                  cfg_fn!(no_core))),
425
    ("lang", Normal, Gated("lang_items",
426 427
                           "language items are subject to change",
                           cfg_fn!(lang_items))),
428 429
    ("linkage", Whitelisted, Gated("linkage",
                                   "the `linkage` attribute is experimental \
430 431
                                    and not portable across platforms",
                                   cfg_fn!(linkage))),
432 433 434 435
    ("thread_local", Whitelisted, Gated("thread_local",
                                        "`#[thread_local]` is an experimental feature, and does \
                                         not currently handle destructors. There is no \
                                         corresponding `#[task_local]` mapping to the task \
436 437
                                         model",
                                        cfg_fn!(thread_local))),
438 439 440

    ("rustc_on_unimplemented", Normal, Gated("on_unimplemented",
                                             "the `#[rustc_on_unimplemented]` attribute \
441 442
                                              is an experimental feature",
                                             cfg_fn!(on_unimplemented))),
443
    ("allocator", Whitelisted, Gated("allocator",
444 445
                                     "the `#[allocator]` attribute is an experimental feature",
                                     cfg_fn!(allocator))),
446 447 448
    ("needs_allocator", Normal, Gated("needs_allocator",
                                      "the `#[needs_allocator]` \
                                       attribute is an experimental \
449 450
                                       feature",
                                      cfg_fn!(needs_allocator))),
451 452 453 454 455 456 457 458 459
    ("panic_runtime", Whitelisted, Gated("panic_runtime",
                                         "the `#[panic_runtime]` attribute is \
                                          an experimental feature",
                                         cfg_fn!(panic_runtime))),
    ("needs_panic_runtime", Whitelisted, Gated("needs_panic_runtime",
                                               "the `#[needs_panic_runtime]` \
                                                attribute is an experimental \
                                                feature",
                                               cfg_fn!(needs_panic_runtime))),
460 461
    ("rustc_variance", Normal, Gated("rustc_attrs",
                                     "the `#[rustc_variance]` attribute \
N
Niko Matsakis 已提交
462
                                      is just used for rustc unit tests \
463 464
                                      and will never be stable",
                                     cfg_fn!(rustc_attrs))),
465 466
    ("rustc_error", Whitelisted, Gated("rustc_attrs",
                                       "the `#[rustc_error]` attribute \
N
Niko Matsakis 已提交
467
                                        is just used for rustc unit tests \
468 469
                                        and will never be stable",
                                       cfg_fn!(rustc_attrs))),
470
    ("rustc_if_this_changed", Whitelisted, Gated("rustc_attrs",
471 472 473 474
                                                 "the `#[rustc_if_this_changed]` attribute \
                                                  is just used for rustc unit tests \
                                                  and will never be stable",
                                                 cfg_fn!(rustc_attrs))),
475
    ("rustc_then_this_would_need", Whitelisted, Gated("rustc_attrs",
476 477 478 479
                                                      "the `#[rustc_if_this_changed]` attribute \
                                                       is just used for rustc unit tests \
                                                       and will never be stable",
                                                      cfg_fn!(rustc_attrs))),
480 481 482
    ("rustc_dirty", Whitelisted, Gated("rustc_attrs",
                                       "the `#[rustc_dirty]` attribute \
                                        is just used for rustc unit tests \
483 484
                                        and will never be stable",
                                       cfg_fn!(rustc_attrs))),
485 486 487
    ("rustc_clean", Whitelisted, Gated("rustc_attrs",
                                       "the `#[rustc_clean]` attribute \
                                        is just used for rustc unit tests \
488 489
                                        and will never be stable",
                                       cfg_fn!(rustc_attrs))),
490 491 492 493 494 495 496 497 498 499
    ("rustc_partition_reused", Whitelisted, Gated("rustc_attrs",
                                                  "this attribute \
                                                   is just used for rustc unit tests \
                                                   and will never be stable",
                                                  cfg_fn!(rustc_attrs))),
    ("rustc_partition_translated", Whitelisted, Gated("rustc_attrs",
                                                      "this attribute \
                                                       is just used for rustc unit tests \
                                                       and will never be stable",
                                                      cfg_fn!(rustc_attrs))),
500
    ("rustc_symbol_name", Whitelisted, Gated("rustc_attrs",
501 502
                                             "internal rustc attributes will never be stable",
                                             cfg_fn!(rustc_attrs))),
503
    ("rustc_item_path", Whitelisted, Gated("rustc_attrs",
504 505
                                           "internal rustc attributes will never be stable",
                                           cfg_fn!(rustc_attrs))),
506 507
    ("rustc_move_fragments", Normal, Gated("rustc_attrs",
                                           "the `#[rustc_move_fragments]` attribute \
N
Niko Matsakis 已提交
508
                                            is just used for rustc unit tests \
509 510
                                            and will never be stable",
                                           cfg_fn!(rustc_attrs))),
511 512 513
    ("rustc_mir", Whitelisted, Gated("rustc_attrs",
                                     "the `#[rustc_mir]` attribute \
                                      is just used for rustc unit tests \
514 515
                                      and will never be stable",
                                     cfg_fn!(rustc_attrs))),
516 517 518 519 520 521 522
    ("rustc_inherit_overflow_checks", Whitelisted, Gated("rustc_attrs",
                                                         "the `#[rustc_inherit_overflow_checks]` \
                                                          attribute is just used to control \
                                                          overflow checking behavior of several \
                                                          libcore functions that are inlined \
                                                          across crates and will never be stable",
                                                          cfg_fn!(rustc_attrs))),
523 524

    ("allow_internal_unstable", Normal, Gated("allow_internal_unstable",
525 526
                                              EXPLAIN_ALLOW_INTERNAL_UNSTABLE,
                                              cfg_fn!(allow_internal_unstable))),
527 528 529

    ("fundamental", Whitelisted, Gated("fundamental",
                                       "the `#[fundamental]` attribute \
530 531
                                        is an experimental feature",
                                       cfg_fn!(fundamental))),
532 533 534

    ("linked_from", Normal, Gated("linked_from",
                                  "the `#[linked_from]` attribute \
535 536
                                   is an experimental feature",
                                  cfg_fn!(linked_from))),
537

538
    // FIXME: #14408 whitelist docs since rustdoc looks at them
539
    ("doc", Whitelisted, Ungated),
540 541 542

    // FIXME: #14406 these are processed in trans, which happens after the
    // lint pass
543
    ("cold", Whitelisted, Ungated),
T
Ticki 已提交
544 545
    ("naked", Whitelisted, Gated("naked_functions",
                                 "the `#[naked]` attribute \
546
                                  is an experimental feature",
547
                                 cfg_fn!(naked_functions))),
548 549 550 551 552 553 554
    ("export_name", Whitelisted, Ungated),
    ("inline", Whitelisted, Ungated),
    ("link", Whitelisted, Ungated),
    ("link_name", Whitelisted, Ungated),
    ("link_section", Whitelisted, Ungated),
    ("no_builtins", Whitelisted, Ungated),
    ("no_mangle", Whitelisted, Ungated),
555 556
    ("no_debug", Whitelisted, Gated("no_debug",
                                    "the `#[no_debug]` attribute \
557 558
                                     is an experimental feature",
                                    cfg_fn!(no_debug))),
559 560 561
    ("omit_gdb_pretty_printer_section", Whitelisted, Gated("omit_gdb_pretty_printer_section",
                                                       "the `#[omit_gdb_pretty_printer_section]` \
                                                        attribute is just used for the Rust test \
562 563
                                                        suite",
                                                       cfg_fn!(omit_gdb_pretty_printer_section))),
564 565
    ("unsafe_destructor_blind_to_params",
     Normal,
566
     Gated("dropck_parametricity",
567
           "unsafe_destructor_blind_to_params has unstable semantics \
568 569 570 571
            and may be removed in the future",
           cfg_fn!(dropck_parametricity))),
    ("unwind", Whitelisted, Gated("unwind_attributes", "#[unwind] is experimental",
                                  cfg_fn!(unwind_attributes))),
572 573

    // used in resolve
574
    ("prelude_import", Whitelisted, Gated("prelude_import",
575 576
                                          "`#[prelude_import]` is for use by rustc only",
                                          cfg_fn!(prelude_import))),
577 578 579

    // FIXME: #14407 these are only looked at on-demand so we can't
    // guarantee they'll have already been checked
580
    ("rustc_deprecated", Whitelisted, Ungated),
581 582 583
    ("must_use", Whitelisted, Ungated),
    ("stable", Whitelisted, Ungated),
    ("unstable", Whitelisted, Ungated),
584
    ("deprecated", Normal, Ungated),
585

586
    ("rustc_paren_sugar", Normal, Gated("unboxed_closures",
587 588
                                        "unboxed_closures are still evolving",
                                        cfg_fn!(unboxed_closures))),
589
    ("rustc_reflect_like", Whitelisted, Gated("reflect",
590 591
                                              "defining reflective traits is still evolving",
                                              cfg_fn!(reflect))),
592 593

    // Crate level attributes
594 595 596 597 598 599 600 601
    ("crate_name", CrateLevel, Ungated),
    ("crate_type", CrateLevel, Ungated),
    ("crate_id", CrateLevel, Ungated),
    ("feature", CrateLevel, Ungated),
    ("no_start", CrateLevel, Ungated),
    ("no_main", CrateLevel, Ungated),
    ("no_builtins", CrateLevel, Ungated),
    ("recursion_limit", CrateLevel, Ungated),
602 603
];

604 605 606
// cfg(...)'s that are feature gated
const GATED_CFGS: &'static [(&'static str, &'static str, fn(&Features) -> bool)] = &[
    // (name in cfg, feature, function to check if the feature is enabled)
607 608 609
    ("target_feature", "cfg_target_feature", cfg_fn!(cfg_target_feature)),
    ("target_vendor", "cfg_target_vendor", cfg_fn!(cfg_target_vendor)),
    ("target_thread_local", "cfg_target_thread_local", cfg_fn!(cfg_target_thread_local)),
610
    ("target_has_atomic", "cfg_target_has_atomic", cfg_fn!(cfg_target_has_atomic)),
611 612 613 614 615 616 617
];

#[derive(Debug, Eq, PartialEq)]
pub struct GatedCfg {
    span: Span,
    index: usize,
}
618

619 620 621 622 623 624 625 626 627 628 629 630
impl GatedCfg {
    pub fn gate(cfg: &ast::MetaItem) -> Option<GatedCfg> {
        let name = cfg.name();
        GATED_CFGS.iter()
                  .position(|info| info.0 == name)
                  .map(|idx| {
                      GatedCfg {
                          span: cfg.span,
                          index: idx
                      }
                  })
    }
J
Jeffrey Seyfried 已提交
631 632

    pub fn check_and_emit(&self, sess: &ParseSess, features: &Features) {
633
        let (cfg, feature, has_feature) = GATED_CFGS[self.index];
J
Jeffrey Seyfried 已提交
634 635
        if !has_feature(features) && !sess.codemap().span_allows_unstable(self.span) {
            let diagnostic = &sess.span_diagnostic;
636
            let explain = format!("`cfg({})` is experimental and subject to change", cfg);
637
            emit_feature_err(diagnostic, feature, self.span, GateIssue::Language, &explain);
638 639 640 641
        }
    }
}

E
Eduard Burtescu 已提交
642
struct Context<'a> {
L
Leo Testard 已提交
643
    features: &'a Features,
644
    span_handler: &'a Handler,
C
Corey Richardson 已提交
645
    cm: &'a CodeMap,
646
    plugin_attributes: &'a [(String, AttributeType)],
647 648
}

649 650 651 652 653 654 655
macro_rules! gate_feature_fn {
    ($cx: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{
        let (cx, has_feature, span, name, explain) = ($cx, $has_feature, $span, $name, $explain);
        let has_feature: bool = has_feature(&$cx.features);
        debug!("gate_feature(feature = {:?}, span = {:?}); has? {}", name, span, has_feature);
        if !has_feature && !cx.cm.span_allows_unstable(span) {
            emit_feature_err(cx.span_handler, name, span, GateIssue::Language, explain);
656
        }
657 658 659 660 661 662
    }}
}

macro_rules! gate_feature {
    ($cx: expr, $feature: ident, $span: expr, $explain: expr) => {
        gate_feature_fn!($cx, |x:&Features| x.$feature, $span, stringify!($feature), $explain)
663
    }
664
}
665

666
impl<'a> Context<'a> {
667
    fn check_attribute(&self, attr: &ast::Attribute, is_macro: bool) {
668 669
        debug!("check_attribute(attr = {:?})", attr);
        let name = &*attr.name();
670
        for &(n, ty, ref gateage) in KNOWN_ATTRIBUTES {
671
            if n == name {
672 673
                if let &Gated(ref name, ref desc, ref has_feature) = gateage {
                    gate_feature_fn!(self, has_feature, attr.span, name, desc);
674
                }
675
                debug!("check_attribute: {:?} is known, {:?}, {:?}", name, ty, gateage);
676 677 678
                return;
            }
        }
679
        for &(ref n, ref ty) in self.plugin_attributes {
680
            if n == name {
681
                // Plugins can't gate attributes, so we don't check for it
M
Manish Goregaokar 已提交
682 683
                // unlike the code above; we only use this loop to
                // short-circuit to avoid the checks below
684 685 686 687
                debug!("check_attribute: {:?} is registered by a plugin, {:?}", name, ty);
                return;
            }
        }
688
        if name.starts_with("rustc_") {
689 690 691 692
            gate_feature!(self, rustc_attrs, attr.span,
                          "unless otherwise specified, attributes \
                           with the prefix `rustc_` \
                           are reserved for internal compiler diagnostics");
693
        } else if name.starts_with("derive_") {
L
Leo Testard 已提交
694
            gate_feature!(self, custom_derive, attr.span, EXPLAIN_DERIVE_UNDERSCORE);
695
        } else {
M
Manish Goregaokar 已提交
696 697 698 699
            // Only run the custom attribute lint during regular
            // feature gate checking. Macro gating runs
            // before the plugin attributes are registered
            // so we skip this then
700
            if !is_macro {
701 702 703 704 705 706
                gate_feature!(self, custom_attribute, attr.span,
                              &format!("The attribute `{}` is currently \
                                        unknown to the compiler and \
                                        may have meaning \
                                        added to it in the future",
                                       name));
707
            }
708 709
        }
    }
710 711
}

L
Leo Testard 已提交
712 713 714 715 716 717 718 719 720
pub fn check_attribute(attr: &ast::Attribute, handler: &Handler,
                       cm: &CodeMap, features: &Features) {
    let cx = Context {
        features: features, span_handler: handler,
        cm: cm, plugin_attributes: &[]
    };
    cx.check_attribute(attr, true);
}

721 722 723 724
pub fn find_lang_feature_accepted_version(feature: &str) -> Option<&'static str> {
    ACCEPTED_FEATURES.iter().find(|t| t.0 == feature).map(|t| t.1)
}

725
fn find_lang_feature_issue(feature: &str) -> Option<u32> {
726 727
    if let Some(info) = ACTIVE_FEATURES.iter().find(|t| t.0 == feature) {
        let issue = info.2;
728 729
        // FIXME (#28244): enforce that active features have issue numbers
        // assert!(issue.is_some())
730 731 732 733 734 735
        issue
    } else {
        // search in Accepted or Removed features
        ACCEPTED_FEATURES.iter().chain(REMOVED_FEATURES.iter())
            .find(|t| t.0 == feature)
            .unwrap().2
736 737 738 739 740 741 742 743
    }
}

pub enum GateIssue {
    Language,
    Library(Option<u32>)
}

744
pub fn emit_feature_err(diag: &Handler, feature: &str, span: Span, issue: GateIssue,
745 746 747 748 749 750
                        explain: &str) {
    let issue = match issue {
        GateIssue::Language => find_lang_feature_issue(feature),
        GateIssue::Library(lib) => lib,
    };

N
Nick Cameron 已提交
751 752
    let mut err = if let Some(n) = issue {
        diag.struct_span_err(span, &format!("{} (see issue #{})", explain, n))
753
    } else {
N
Nick Cameron 已提交
754 755
        diag.struct_span_err(span, explain)
    };
756 757

    // #23973: do not suggest `#![feature(...)]` if we are in beta/stable
N
Nick Cameron 已提交
758 759 760 761
    if option_env!("CFG_DISABLE_UNSTABLE_FEATURES").is_some() {
        err.emit();
        return;
    }
762 763 764
    err.help(&format!("add #![feature({})] to the \
                       crate attributes to enable",
                      feature));
N
Nick Cameron 已提交
765
    err.emit();
766 767
}

L
Leo Testard 已提交
768 769 770
const EXPLAIN_BOX_SYNTAX: &'static str =
    "box expression syntax is experimental; you can call `Box::new` instead.";

J
Jeffrey Seyfried 已提交
771
pub const EXPLAIN_STMT_ATTR_SYNTAX: &'static str =
L
Leo Testard 已提交
772 773
    "attributes on non-item statements and expressions are experimental.";

774 775 776
pub const EXPLAIN_ASM: &'static str =
    "inline assembly is not stable enough for use and is subject to change";

777 778 779 780 781 782 783 784
pub const EXPLAIN_LOG_SYNTAX: &'static str =
    "`log_syntax!` is not stable enough for use and is subject to change";

pub const EXPLAIN_CONCAT_IDENTS: &'static str =
    "`concat_idents` is not stable enough for use and is subject to change";

pub const EXPLAIN_TRACE_MACROS: &'static str =
    "`trace_macros` is not stable enough for use and is subject to change";
785 786
pub const EXPLAIN_ALLOW_INTERNAL_UNSTABLE: &'static str =
    "allow_internal_unstable side-steps feature gating and stability checks";
787

788 789 790
pub const EXPLAIN_CUSTOM_DERIVE: &'static str =
    "`#[derive]` for custom traits is not stable enough for use and is subject to change";

L
Leo Testard 已提交
791 792
pub const EXPLAIN_DERIVE_UNDERSCORE: &'static str =
    "attributes of the form `#[derive_*]` are reserved for the compiler";
793

L
Leo Testard 已提交
794 795
pub const EXPLAIN_PLACEMENT_IN: &'static str =
    "placement-in expression syntax is experimental and subject to change.";
C
Corey Richardson 已提交
796 797

struct PostExpansionVisitor<'a> {
N
Nick Cameron 已提交
798
    context: &'a Context<'a>,
C
Corey Richardson 已提交
799 800
}

801 802 803 804 805
macro_rules! gate_feature_post {
    ($cx: expr, $feature: ident, $span: expr, $explain: expr) => {{
        let (cx, span) = ($cx, $span);
        if !cx.context.cm.span_allows_unstable(span) {
            gate_feature!(cx.context, $feature, span, $explain)
C
Corey Richardson 已提交
806
        }
807
    }}
C
Corey Richardson 已提交
808 809
}

810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832
impl<'a> PostExpansionVisitor<'a> {
    fn check_abi(&self, abi: Abi, span: Span) {
        match abi {
            Abi::RustIntrinsic =>
                gate_feature_post!(&self, intrinsics, span,
                                   "intrinsics are subject to change"),
            Abi::PlatformIntrinsic => {
                gate_feature_post!(&self, platform_intrinsics, span,
                                   "platform intrinsics are experimental and possibly buggy")
            },
            Abi::Vectorcall => {
                gate_feature_post!(&self, abi_vectorcall, span,
                                   "vectorcall is experimental and subject to change")
            }
            Abi::RustCall => {
                gate_feature_post!(&self, unboxed_closures, span,
                                   "rust-call ABI is subject to change");
            }
            _ => {}
        }
    }
}

833
impl<'a> Visitor for PostExpansionVisitor<'a> {
834 835
    fn visit_attribute(&mut self, attr: &ast::Attribute) {
        if !self.context.cm.span_allows_unstable(attr.span) {
836
            self.context.check_attribute(attr, false);
837 838 839
        }
    }

840
    fn visit_name(&mut self, sp: Span, name: ast::Name) {
841
        if !name.as_str().is_ascii() {
842 843
            gate_feature_post!(&self, non_ascii_idents, sp,
                               "non-ascii idents are not fully supported.");
844 845 846
        }
    }

847
    fn visit_item(&mut self, i: &ast::Item) {
848
        match i.node {
849
            ast::ItemKind::ExternCrate(_) => {
850
                if attr::contains_name(&i.attrs[..], "macro_reexport") {
851 852 853
                    gate_feature_post!(&self, macro_reexport, i.span,
                                       "macros reexports are experimental \
                                        and possibly buggy");
854 855 856
                }
            }

857
            ast::ItemKind::ForeignMod(ref foreign_module) => {
858
                if attr::contains_name(&i.attrs[..], "link_args") {
859
                    gate_feature_post!(&self, link_args, i.span,
860 861 862 863
                                      "the `link_args` attribute is not portable \
                                       across platforms, it is recommended to \
                                       use `#[link(name = \"foo\")]` instead")
                }
864
                self.check_abi(foreign_module.abi, i.span);
865 866
            }

867
            ast::ItemKind::Fn(..) => {
868
                if attr::contains_name(&i.attrs[..], "plugin_registrar") {
869 870
                    gate_feature_post!(&self, plugin_registrar, i.span,
                                       "compiler plugins are experimental and possibly buggy");
871
                }
872
                if attr::contains_name(&i.attrs[..], "start") {
873
                    gate_feature_post!(&self, start, i.span,
874 875 876 877
                                      "a #[start] function is an experimental \
                                       feature whose signature may change \
                                       over time");
                }
878
                if attr::contains_name(&i.attrs[..], "main") {
879 880 881 882
                    gate_feature_post!(&self, main, i.span,
                                       "declaration of a nonstandard #[main] \
                                        function may change over time, for now \
                                        a top-level `fn main()` is required");
883
                }
884 885
            }

886
            ast::ItemKind::Struct(..) => {
887
                if attr::contains_name(&i.attrs[..], "simd") {
888 889
                    gate_feature_post!(&self, simd, i.span,
                                       "SIMD types are experimental and possibly buggy");
890 891 892 893 894 895 896 897
                    self.context.span_handler.span_warn(i.span,
                                                        "the `#[simd]` attribute is deprecated, \
                                                         use `#[repr(simd)]` instead");
                }
                for attr in &i.attrs {
                    if attr.name() == "repr" {
                        for item in attr.meta_item_list().unwrap_or(&[]) {
                            if item.name() == "simd" {
898 899 900
                                gate_feature_post!(&self, repr_simd, i.span,
                                                   "SIMD types are experimental \
                                                    and possibly buggy");
901 902 903 904

                            }
                        }
                    }
905
                }
D
David Manescu 已提交
906 907
            }

908
            ast::ItemKind::DefaultImpl(..) => {
909 910 911 912
                gate_feature_post!(&self, optin_builtin_traits,
                                   i.span,
                                   "default trait implementations are experimental \
                                    and possibly buggy");
F
Flavio Percoco 已提交
913 914
            }

915
            ast::ItemKind::Impl(_, polarity, _, _, _, _) => {
916 917
                match polarity {
                    ast::ImplPolarity::Negative => {
918 919 920 921
                        gate_feature_post!(&self, optin_builtin_traits,
                                           i.span,
                                           "negative trait bounds are not yet fully implemented; \
                                            use marker types for now");
922 923 924
                    },
                    _ => {}
                }
925 926
            }

927 928 929
            _ => {}
        }

930
        visit::walk_item(self, i);
931
    }
932

933
    fn visit_foreign_item(&mut self, i: &ast::ForeignItem) {
934
        let links_to_llvm = match attr::first_attr_value_str_by_name(&i.attrs,
N
fallout  
Nick Cameron 已提交
935
                                                                     "link_name") {
G
GuillaumeGomez 已提交
936
            Some(val) => val.starts_with("llvm."),
937 938 939
            _ => false
        };
        if links_to_llvm {
940
            gate_feature_post!(&self, link_llvm_intrinsics, i.span,
941 942 943
                              "linking to LLVM intrinsics is experimental");
        }

944
        visit::walk_foreign_item(self, i)
945 946
    }

947 948 949 950 951
    fn visit_ty(&mut self, ty: &ast::Ty) {
        match ty.node {
            ast::TyKind::BareFn(ref bare_fn_ty) => {
                self.check_abi(bare_fn_ty.abi, ty.span);
            }
952 953 954 955
            ast::TyKind::ImplTrait(..) => {
                gate_feature_post!(&self, conservative_impl_trait, ty.span,
                                   "`impl Trait` is experimental");
            }
A
Andrew Cann 已提交
956 957
            ast::TyKind::Never => {
                gate_feature_post!(&self, never_type, ty.span,
958 959
                                   "The `!` type is experimental");
            },
960 961 962 963 964
            _ => {}
        }
        visit::walk_ty(self, ty)
    }

965 966 967
    fn visit_fn_ret_ty(&mut self, ret_ty: &ast::FunctionRetTy) {
        if let ast::FunctionRetTy::Ty(ref output_ty) = *ret_ty {
            match output_ty.node {
A
Andrew Cann 已提交
968
                ast::TyKind::Never => return,
969 970
                _ => (),
            };
A
Andrew Cann 已提交
971
            self.visit_ty(output_ty)
972 973 974
        }
    }

975
    fn visit_expr(&mut self, e: &ast::Expr) {
976
        match e.node {
977
            ast::ExprKind::Box(_) => {
978
                gate_feature_post!(&self, box_syntax, e.span, EXPLAIN_BOX_SYNTAX);
979
            }
980
            ast::ExprKind::Type(..) => {
981
                gate_feature_post!(&self, type_ascription, e.span,
982 983
                                  "type ascription is experimental");
            }
984
            ast::ExprKind::Range(_, _, ast::RangeLimits::Closed) => {
985
                gate_feature_post!(&self, inclusive_range_syntax,
A
Alex Burka 已提交
986 987 988
                                  e.span,
                                  "inclusive range syntax is experimental");
            }
J
Jorge Aparicio 已提交
989
            ast::ExprKind::Try(..) => {
990
                gate_feature_post!(&self, question_mark, e.span, "the `?` operator is not stable");
J
Jorge Aparicio 已提交
991
            }
992 993 994
            ast::ExprKind::InPlace(..) => {
                gate_feature_post!(&self, placement_in_syntax, e.span, EXPLAIN_PLACEMENT_IN);
            }
995 996
            _ => {}
        }
997
        visit::walk_expr(self, e);
998
    }
999

1000
    fn visit_pat(&mut self, pattern: &ast::Pat) {
1001
        match pattern.node {
1002
            PatKind::Vec(_, Some(_), ref last) if !last.is_empty() => {
1003
                gate_feature_post!(&self, advanced_slice_patterns,
1004 1005 1006
                                  pattern.span,
                                  "multiple-element slice matches anywhere \
                                   but at the end of a slice (e.g. \
1007
                                   `[0, ..xs, 0]`) are experimental")
1008
            }
1009
            PatKind::Vec(..) => {
1010
                gate_feature_post!(&self, slice_patterns,
1011 1012 1013
                                  pattern.span,
                                  "slice pattern syntax is experimental");
            }
1014
            PatKind::Box(..) => {
1015
                gate_feature_post!(&self, box_patterns,
1016
                                  pattern.span,
1017
                                  "box pattern syntax is experimental");
1018
            }
1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032
            PatKind::Tuple(_, ddpos)
                    if ddpos.is_some() => {
                gate_feature_post!(&self, dotdot_in_tuple_patterns,
                                  pattern.span,
                                  "`..` in tuple patterns is experimental");
            }
            PatKind::TupleStruct(_, ref fields, ddpos)
                    if ddpos.is_some() && !fields.is_empty() => {
                gate_feature_post!(&self, dotdot_in_tuple_patterns,
                                  pattern.span,
                                  "`..` in tuple struct patterns is experimental");
            }
            PatKind::TupleStruct(_, ref fields, ddpos)
                    if ddpos.is_none() && fields.is_empty() => {
1033 1034
                gate_feature_post!(&self, relaxed_adts, pattern.span,
                                   "empty tuple structs patterns are unstable");
1035
            }
1036 1037
            _ => {}
        }
1038
        visit::walk_pat(self, pattern)
1039 1040
    }

1041
    fn visit_fn(&mut self,
1042 1043 1044
                fn_kind: FnKind,
                fn_decl: &ast::FnDecl,
                block: &ast::Block,
1045
                span: Span,
1046
                _node_id: NodeId) {
N
Niko Matsakis 已提交
1047 1048
        // check for const fn declarations
        match fn_kind {
1049
            FnKind::ItemFn(_, _, _, ast::Constness::Const, _, _) => {
1050
                gate_feature_post!(&self, const_fn, span, "const fn is unstable");
N
Niko Matsakis 已提交
1051 1052 1053 1054 1055 1056 1057 1058 1059
            }
            _ => {
                // stability of const fn methods are covered in
                // visit_trait_item and visit_impl_item below; this is
                // because default methods don't pass through this
                // point.
            }
        }

1060
        match fn_kind {
1061
            FnKind::ItemFn(_, _, _, _, abi, _) |
1062 1063 1064
            FnKind::Method(_, &ast::MethodSig { abi, .. }, _) => {
                self.check_abi(abi, span);
            }
1065 1066
            _ => {}
        }
1067
        visit::walk_fn(self, fn_kind, fn_decl, block, span);
1068
    }
1069

1070
    fn visit_trait_item(&mut self, ti: &ast::TraitItem) {
1071
        match ti.node {
1072
            ast::TraitItemKind::Const(..) => {
1073
                gate_feature_post!(&self, associated_consts,
1074 1075 1076
                                  ti.span,
                                  "associated constants are experimental")
            }
1077 1078 1079 1080
            ast::TraitItemKind::Method(ref sig, ref block) => {
                if block.is_none() {
                    self.check_abi(sig.abi, ti.span);
                }
N
Niko Matsakis 已提交
1081
                if sig.constness == ast::Constness::Const {
1082
                    gate_feature_post!(&self, const_fn, ti.span, "const fn is unstable");
N
Niko Matsakis 已提交
1083 1084
                }
            }
1085
            ast::TraitItemKind::Type(_, Some(_)) => {
1086
                gate_feature_post!(&self, associated_type_defaults, ti.span,
1087 1088
                                  "associated type defaults are unstable");
            }
1089 1090 1091 1092 1093
            _ => {}
        }
        visit::walk_trait_item(self, ti);
    }

1094
    fn visit_impl_item(&mut self, ii: &ast::ImplItem) {
A
Aaron Turon 已提交
1095
        if ii.defaultness == ast::Defaultness::Default {
1096
            gate_feature_post!(&self, specialization,
A
Aaron Turon 已提交
1097 1098 1099 1100
                              ii.span,
                              "specialization is unstable");
        }

1101
        match ii.node {
1102
            ast::ImplItemKind::Const(..) => {
1103
                gate_feature_post!(&self, associated_consts,
1104 1105 1106
                                  ii.span,
                                  "associated constants are experimental")
            }
1107
            ast::ImplItemKind::Method(ref sig, _) => {
N
Niko Matsakis 已提交
1108
                if sig.constness == ast::Constness::Const {
1109
                    gate_feature_post!(&self, const_fn, ii.span, "const fn is unstable");
N
Niko Matsakis 已提交
1110 1111
                }
            }
1112 1113 1114 1115
            _ => {}
        }
        visit::walk_impl_item(self, ii);
    }
1116

1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129
    fn visit_variant_data(&mut self, vdata: &ast::VariantData, _: ast::Ident,
                          _: &ast::Generics, _: NodeId, span: Span) {
        if vdata.fields().is_empty() {
            if vdata.is_tuple() {
                gate_feature_post!(&self, relaxed_adts, span,
                                   "empty tuple structs and enum variants are unstable, \
                                    use unit structs and enum variants instead");
            }
        }

        visit::walk_struct_def(self, vdata)
    }

1130
    fn visit_vis(&mut self, vis: &ast::Visibility) {
1131 1132
        let span = match *vis {
            ast::Visibility::Crate(span) => span,
1133
            ast::Visibility::Restricted { ref path, .. } => path.span,
1134 1135
            _ => return,
        };
1136
        gate_feature_post!(&self, pub_restricted, span, "`pub(restricted)` syntax is experimental");
1137 1138

        visit::walk_vis(self, vis)
1139
    }
1140 1141
}

J
Jeffrey Seyfried 已提交
1142
pub fn get_features(span_handler: &Handler, krate_attrs: &[ast::Attribute]) -> Features {
1143
    let mut features = Features::new();
N
Nick Cameron 已提交
1144

J
Jeffrey Seyfried 已提交
1145
    for attr in krate_attrs {
S
Steven Fackler 已提交
1146
        if !attr.check_name("feature") {
1147 1148
            continue
        }
1149 1150 1151

        match attr.meta_item_list() {
            None => {
G
ggomez 已提交
1152 1153
                span_err!(span_handler, attr.span, E0555,
                          "malformed feature attribute, expected #![feature(...)]");
1154 1155
            }
            Some(list) => {
1156
                for mi in list {
1157 1158 1159 1160 1161 1162 1163
                    let name = if mi.is_word() {
                                   mi.name()
                               } else {
                                   span_err!(span_handler, mi.span, E0556,
                                             "malformed feature, expected just one word");
                                   continue
                               };
1164 1165 1166 1167 1168 1169
                    if let Some(&(_, _, _, setter)) = ACTIVE_FEATURES.iter()
                        .find(|& &(n, _, _, _)| name == n) {
                        *(setter(&mut features)) = true;
                    }
                    else if let Some(&(_, _, _)) = REMOVED_FEATURES.iter()
                        .find(|& &(n, _, _)| name == n) {
G
ggomez 已提交
1170
                        span_err!(span_handler, mi.span, E0557, "feature has been removed");
1171 1172 1173
                    }
                    else if let Some(&(_, _, _)) = ACCEPTED_FEATURES.iter()
                        .find(|& &(n, _, _)| name == n) {
1174
                        features.declared_stable_lang_features.push((name, mi.span));
1175 1176
                    } else {
                        features.declared_lib_features.push((name, mi.span));
1177 1178 1179 1180 1181 1182
                    }
                }
            }
        }
    }

L
Leo Testard 已提交
1183
    features
C
Corey Richardson 已提交
1184 1185
}

J
Jeffrey Seyfried 已提交
1186 1187 1188
pub fn check_crate(krate: &ast::Crate,
                   sess: &ParseSess,
                   features: &Features,
1189
                   plugin_attributes: &[(String, AttributeType)],
J
Jeffrey Seyfried 已提交
1190 1191 1192 1193 1194 1195 1196 1197 1198
                   unstable: UnstableFeatures) {
    maybe_stage_features(&sess.span_diagnostic, krate, unstable);
    let ctx = Context {
        features: features,
        span_handler: &sess.span_diagnostic,
        cm: sess.codemap(),
        plugin_attributes: plugin_attributes,
    };
    visit::walk_crate(&mut PostExpansionVisitor { context: &ctx }, krate);
C
Corey Richardson 已提交
1199
}
1200

1201
#[derive(Clone, Copy, PartialEq, Eq, Hash)]
1202 1203 1204 1205 1206 1207 1208 1209 1210
pub enum UnstableFeatures {
    /// Hard errors for unstable features are active, as on
    /// beta/stable channels.
    Disallow,
    /// Allow features to me activated, as on nightly.
    Allow,
    /// Errors are bypassed for bootstrapping. This is required any time
    /// during the build that feature-related lints are set to warn or above
    /// because the build turns on warnings-as-errors and uses lots of unstable
1211
    /// features. As a result, this is always required for building Rust itself.
1212 1213 1214
    Cheat
}

1215
fn maybe_stage_features(span_handler: &Handler, krate: &ast::Crate,
1216 1217 1218 1219 1220 1221 1222 1223 1224 1225
                        unstable: UnstableFeatures) {
    let allow_features = match unstable {
        UnstableFeatures::Allow => true,
        UnstableFeatures::Disallow => false,
        UnstableFeatures::Cheat => true
    };
    if !allow_features {
        for attr in &krate.attrs {
            if attr.check_name("feature") {
                let release_channel = option_env!("CFG_RELEASE_CHANNEL").unwrap_or("(unknown)");
G
ggomez 已提交
1226
                span_err!(span_handler, attr.span, E0554,
G
ggomez 已提交
1227 1228
                          "#[feature] may not be used on the {} release channel",
                          release_channel);
1229 1230 1231 1232
            }
        }
    }
}