feature_gate.rs 63.8 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

//! Feature gating
//!
L
Luke Gallagher 已提交
13
//! This module implements the gating necessary for preventing certain compiler
14 15 16 17 18
//! features from being used by default. This module will crawl a pre-expanded
//! AST to ensure that there are no features which are used that are not
//! enabled.
//!
//! Features are enabled in programs via the crate-level attributes of
19
//! `#![feature(...)]` with a comma-separated list of features.
B
Brian Anderson 已提交
20 21 22 23
//!
//! For the purpose of future feature-tracking, once code for detection of feature
//! gate usage is added, *do not remove it again* even once the feature
//! becomes stable.
G
GuillaumeGomez 已提交
24

25
use self::AttributeType::*;
26
use self::AttributeGate::*;
27

N
Niko Matsakis 已提交
28
use abi::Abi;
29
use ast::{self, NodeId, PatKind, RangeEnd};
30
use attr;
31
use codemap::{CodeMap, Spanned};
32
use syntax_pos::Span;
33
use errors::{DiagnosticBuilder, Handler, FatalError};
34
use visit::{self, FnKind, Visitor};
J
Jeffrey Seyfried 已提交
35
use parse::ParseSess;
36
use symbol::Symbol;
37

38
use std::ascii::AsciiExt;
T
Tim Neumann 已提交
39
use std::env;
40

41 42 43 44 45 46 47 48
macro_rules! setter {
    ($field: ident) => {{
        fn f(features: &mut Features) -> &mut bool {
            &mut features.$field
        }
        f as fn(&mut Features) -> &mut bool
    }}
}
49

50
macro_rules! declare_features {
51
    ($((active, $feature: ident, $ver: expr, $issue: expr),)+) => {
52 53 54 55 56 57 58 59 60
        /// Represents active features that are currently being implemented or
        /// currently being considered for addition/removal.
        const ACTIVE_FEATURES: &'static [(&'static str, &'static str,
                                          Option<u32>, fn(&mut Features) -> &mut bool)] = &[
            $((stringify!($feature), $ver, $issue, setter!($feature))),+
        ];

        /// A set of features to be used by later passes.
        pub struct Features {
61
            /// #![feature] attrs for stable language features, for error reporting
62
            pub declared_stable_lang_features: Vec<(Symbol, Span)>,
63
            /// #![feature] attrs for non-language (library) features
64
            pub declared_lib_features: Vec<(Symbol, Span)>,
65 66
            $(pub $feature: bool),+
        }
67

68 69 70 71 72 73 74 75 76 77 78
        impl Features {
            pub fn new() -> Features {
                Features {
                    declared_stable_lang_features: Vec::new(),
                    declared_lib_features: Vec::new(),
                    $($feature: false),+
                }
            }
        }
    };

79
    ($((removed, $feature: ident, $ver: expr, $issue: expr),)+) => {
80 81 82 83 84 85
        /// Represents features which has since been removed (it was once Active)
        const REMOVED_FEATURES: &'static [(&'static str, &'static str, Option<u32>)] = &[
            $((stringify!($feature), $ver, $issue)),+
        ];
    };

86
    ($((accepted, $feature: ident, $ver: expr, $issue: expr),)+) => {
87 88 89 90 91
        /// Those language feature has since been Accepted (it was once Active)
        const ACCEPTED_FEATURES: &'static [(&'static str, &'static str, Option<u32>)] = &[
            $((stringify!($feature), $ver, $issue)),+
        ];
    }
92 93
}

B
Brian Anderson 已提交
94 95 96 97 98
// If you change this list without updating src/doc/reference.md, @cmr will be sad
// Don't ever remove anything from this list; set them to 'Removed'.
// The version numbers here correspond to the version in which the current status
// was set. This is most important for knowing when a particular feature became
// stable (active).
99 100 101 102 103 104 105 106 107 108 109 110
// NB: The featureck.py script parses this information directly out of the source
// so take care when modifying it.

declare_features! (
    (active, asm, "1.0.0", Some(29722)),
    (active, concat_idents, "1.0.0", Some(29599)),
    (active, link_args, "1.0.0", Some(29596)),
    (active, log_syntax, "1.0.0", Some(29598)),
    (active, non_ascii_idents, "1.0.0", Some(28979)),
    (active, plugin_registrar, "1.0.0", Some(29597)),
    (active, thread_local, "1.0.0", Some(29594)),
    (active, trace_macros, "1.0.0", Some(29598)),
A
Aaron Turon 已提交
111 112

    // rustc internal, for now:
113 114
    (active, intrinsics, "1.0.0", None),
    (active, lang_items, "1.0.0", None),
115

116 117 118 119
    (active, link_llvm_intrinsics, "1.0.0", Some(29602)),
    (active, linkage, "1.0.0", Some(29603)),
    (active, quote, "1.0.0", Some(29601)),
    (active, simd, "1.0.0", Some(27731)),
120 121


A
Aaron Turon 已提交
122
    // rustc internal
123 124 125 126 127
    (active, rustc_diagnostic_macros, "1.0.0", None),
    (active, advanced_slice_patterns, "1.0.0", Some(23121)),
    (active, box_syntax, "1.0.0", Some(27779)),
    (active, placement_in_syntax, "1.0.0", Some(27779)),
    (active, unboxed_closures, "1.0.0", Some(29625)),
A
Aaron Turon 已提交
128

129 130 131 132 133 134 135 136 137
    (active, allocator, "1.0.0", Some(27389)),
    (active, fundamental, "1.0.0", Some(29635)),
    (active, main, "1.0.0", Some(29634)),
    (active, needs_allocator, "1.4.0", Some(27389)),
    (active, on_unimplemented, "1.0.0", Some(29628)),
    (active, plugin, "1.0.0", Some(29597)),
    (active, simd_ffi, "1.0.0", Some(27731)),
    (active, start, "1.0.0", Some(29633)),
    (active, structural_match, "1.8.0", Some(31434)),
138 139
    (active, panic_runtime, "1.10.0", Some(32837)),
    (active, needs_panic_runtime, "1.10.0", Some(32837)),
140

141
    // OIBIT specific features
142
    (active, optin_builtin_traits, "1.0.0", Some(13231)),
143

J
Joseph Crail 已提交
144
    // macro reexport needs more discussion and stabilization
145
    (active, macro_reexport, "1.0.0", Some(29638)),
146 147

    // Allows use of #[staged_api]
A
Aaron Turon 已提交
148
    // rustc internal
149
    (active, staged_api, "1.0.0", None),
150

A
Alex Crichton 已提交
151
    // Allows using #![no_core]
152
    (active, no_core, "1.3.0", Some(29639)),
A
Alex Crichton 已提交
153

154
    // Allows using `box` in patterns; RFC 469
155
    (active, box_patterns, "1.0.0", Some(29641)),
156

157 158
    // Allows using the unsafe_destructor_blind_to_params attribute;
    // RFC 1238
159
    (active, dropck_parametricity, "1.3.0", Some(28498)),
160

161 162 163
    // Allows using the may_dangle attribute; RFC 1327
    (active, dropck_eyepatch, "1.10.0", Some(34761)),

164
    // Allows the use of custom attributes; RFC 572
165
    (active, custom_attribute, "1.0.0", Some(29642)),
M
Manish Goregaokar 已提交
166

167 168
    // Allows the use of #[derive(Anything)] as sugar for
    // #[derive_Anything].
169
    (active, custom_derive, "1.0.0", Some(29644)),
170

M
Manish Goregaokar 已提交
171
    // Allows the use of rustc_* attributes; RFC 572
172
    (active, rustc_attrs, "1.0.0", Some(29642)),
H
Huon Wilson 已提交
173

174 175 176 177
    // Allows the use of #[allow_internal_unstable]. This is an
    // attribute on macro_rules! and can't use the attribute handling
    // below (it has to be checked before expansion possibly makes
    // macros disappear).
A
Aaron Turon 已提交
178 179
    //
    // rustc internal
180
    (active, allow_internal_unstable, "1.0.0", None),
181 182

    // #23121. Array patterns have some hazards yet.
183
    (active, slice_patterns, "1.0.0", Some(23121)),
184 185 186

    // Allows the definition of associated constants in `trait` or `impl`
    // blocks.
187
    (active, associated_consts, "1.0.0", Some(29646)),
N
Niko Matsakis 已提交
188 189

    // Allows the definition of `const fn` functions.
190
    (active, const_fn, "1.2.0", Some(24111)),
191

192
    // Allows indexing into constant arrays.
193
    (active, const_indexing, "1.4.0", Some(29947)),
194

195
    // Allows using #[prelude_import] on glob `use` items.
A
Aaron Turon 已提交
196 197
    //
    // rustc internal
198
    (active, prelude_import, "1.2.0", None),
199 200

    // Allows the definition recursive static items.
201
    (active, static_recursion, "1.3.0", Some(29719)),
B
Brian Anderson 已提交
202 203

    // Allows default type parameters to influence type inference.
204
    (active, default_type_parameter_fallback, "1.3.0", Some(27336)),
205 206

    // Allows associated type defaults
207
    (active, associated_type_defaults, "1.2.0", Some(29661)),
J
Jared Roesch 已提交
208

209
    // allow `repr(simd)`, and importing the various simd intrinsics
210
    (active, repr_simd, "1.4.0", Some(27731)),
211 212

    // Allows cfg(target_feature = "...").
213
    (active, cfg_target_feature, "1.4.0", Some(29717)),
214 215

    // allow `extern "platform-intrinsic" { ... }`
216
    (active, platform_intrinsics, "1.4.0", Some(27731)),
217 218

    // allow `#[unwind]`
A
Aaron Turon 已提交
219
    // rust runtime internal
220
    (active, unwind_attributes, "1.4.0", None),
V
Vadim Petrochenkov 已提交
221

T
Ticki 已提交
222
    // allow the use of `#[naked]` on functions.
223
    (active, naked_functions, "1.9.0", Some(32408)),
224 225

    // allow `#[no_debug]`
226
    (active, no_debug, "1.5.0", Some(29721)),
227 228

    // allow `#[omit_gdb_pretty_printer_section]`
A
Aaron Turon 已提交
229
    // rustc internal.
230
    (active, omit_gdb_pretty_printer_section, "1.5.0", None),
231 232

    // Allows cfg(target_vendor = "...").
233
    (active, cfg_target_vendor, "1.5.0", Some(29718)),
234 235

    // Allow attributes on expressions and non-item statements
236
    (active, stmt_expr_attributes, "1.6.0", Some(15701)),
237 238

    // allow using type ascription in expressions
239
    (active, type_ascription, "1.6.0", Some(23416)),
240 241

    // Allows cfg(target_thread_local)
242
    (active, cfg_target_thread_local, "1.7.0", Some(29594)),
243 244

    // rustc internal
245
    (active, abi_vectorcall, "1.7.0", None),
A
Alex Burka 已提交
246 247

    // a...b and ...b
248
    (active, inclusive_range_syntax, "1.7.0", Some(28237)),
J
Jorge Aparicio 已提交
249

250 251 252
    // X..Y patterns
    (active, exclusive_range_pattern, "1.11.0", Some(37854)),

A
Aaron Turon 已提交
253
    // impl specialization (RFC 1210)
254
    (active, specialization, "1.7.0", Some(31844)),
255 256

    // pub(restricted) visibilities (RFC 1422)
257 258
    (active, pub_restricted, "1.9.0", Some(32409)),

259 260 261 262
    // Allow Drop types in statics/const functions (RFC 1440)
    (active, drop_types_in_const, "1.9.0", Some(33156)),

    // Allows cfg(target_has_atomic = "...").
263 264
    (active, cfg_target_has_atomic, "1.9.0", Some(32976)),

265
    // Allows `impl Trait` in function return types.
266 267 268
    (active, conservative_impl_trait, "1.12.0", Some(34511)),

    // Permits numeric fields in struct expressions and patterns.
269 270 271
    (active, relaxed_adts, "1.12.0", Some(35626)),

    // The `!` type
272 273 274
    (active, never_type, "1.13.0", Some(35121)),

    // Allows all literals in attribute lists and values of key-value pairs.
275 276 277 278
    (active, attr_literals, "1.13.0", Some(34981)),

    // Allows the sysV64 ABI to be specified on all platforms
    // instead of just the platforms on which it is the C ABI
279 280
    (active, abi_sysv64, "1.13.0", Some(36167)),

281 282
    // Allows untagged unions `union U { ... }`
    (active, untagged_unions, "1.13.0", Some(32836)),
A
Andre Bogus 已提交
283 284 285

    // elide `'static` lifetimes in `static`s and `const`s
    (active, static_in_const, "1.13.0", Some(35897)),
286 287 288 289

    // Used to identify the `compiler_builtins` crate
    // rustc internal
    (active, compiler_builtins, "1.13.0", None),
290 291 292

    // Allows attributes on lifetime/type formal parameters in generics (RFC 1327)
    (active, generic_param_attrs, "1.11.0", Some(34761)),
293 294 295

    // Allows field shorthands (`x` meaning `x: x`) in struct literal expressions.
    (active, field_init_shorthand, "1.14.0", Some(37340)),
296 297 298

    // The #![windows_subsystem] attribute
    (active, windows_subsystem, "1.14.0", Some(37499)),
299

300 301
    // Allows #[link(..., cfg(..))]
    (active, link_cfg, "1.14.0", Some(37406)),
302 303

    (active, use_extern_macros, "1.15.0", Some(35896)),
304 305 306

    // Allows `break {expr}` with a value inside `loop`s.
    (active, loop_break_value, "1.14.0", Some(37339)),
307 308 309

    // Allows #[target_feature(...)]
    (active, target_feature, "1.15.0", None),
G
Guillaume Gomez 已提交
310

J
Jorge Aparicio 已提交
311 312
    // `extern "ptx-*" fn()`
    (active, abi_ptx, "1.15.0", None),
313 314

    // The `i128` type
E
est31 已提交
315
    (active, i128_type, "1.16.0", Some(35118)),
316 317 318

    // The `unadjusted` ABI. Perma unstable.
    (active, abi_unadjusted, "1.16.0", None),
319

320 321 322
    // Macros 1.1
    (active, proc_macro, "1.16.0", Some(35900)),

323 324
    // Allows attributes on struct literal fields.
    (active, struct_field_attributes, "1.16.0", Some(38814)),
325 326 327

    // `extern "msp430-interrupt" fn()`
    (active, abi_msp430_interrupt, "1.16.0", Some(38487)),
328 329 330 331 332 333 334
);

declare_features! (
    (removed, import_shadowing, "1.0.0", None),
    (removed, managed_boxes, "1.0.0", None),
    // Allows use of unary negate on unsigned integers, e.g. -e for e: u8
    (removed, negate_unsigned, "1.0.0", Some(29645)),
E
est31 已提交
335
    (removed, reflect, "1.0.0", Some(27749)),
336 337 338 339 340
    // A way to temporarily opt out of opt in copy. This will *never* be accepted.
    (removed, opt_out_copy, "1.0.0", None),
    (removed, quad_precision_float, "1.0.0", None),
    (removed, struct_inherit, "1.0.0", None),
    (removed, test_removed_feature, "1.0.0", None),
341
    (removed, visible_private_types, "1.0.0", None),
342
    (removed, unsafe_no_drop_flag, "1.0.0", None),
343 344 345
    // Allows using items which are missing stability attributes
    // rustc internal
    (removed, unmarked_api, "1.0.0", None),
346
    (removed, pushpop_unsafe, "1.2.0", None),
347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362
);

declare_features! (
    (accepted, associated_types, "1.0.0", None),
    // allow overloading augmented assignment operations like `a += b`
    (accepted, augmented_assignments, "1.8.0", Some(28235)),
    // allow empty structs and enum variants with braces
    (accepted, braced_empty_structs, "1.8.0", Some(29720)),
    (accepted, default_type_params, "1.0.0", None),
    (accepted, globs, "1.0.0", None),
    (accepted, if_let, "1.0.0", None),
    // A temporary feature gate used to enable parser extensions needed
    // to bootstrap fix for #5723.
    (accepted, issue_5723_bootstrap, "1.0.0", None),
    (accepted, macro_rules, "1.0.0", None),
    // Allows using #![no_std]
363
    (accepted, no_std, "1.6.0", None),
364 365 366 367 368 369
    (accepted, slicing_syntax, "1.0.0", None),
    (accepted, struct_variant, "1.0.0", None),
    // These are used to test this portion of the compiler, they don't actually
    // mean anything
    (accepted, test_accepted_feature, "1.0.0", None),
    (accepted, tuple_indexing, "1.0.0", None),
D
Daniele Baracchi 已提交
370 371
    // Allows macros to appear in the type position.
    (accepted, type_macros, "1.13.0", Some(27245)),
372 373
    (accepted, while_let, "1.0.0", None),
    // Allows `#[deprecated]` attribute
374
    (accepted, deprecated, "1.9.0", Some(29935)),
N
Nick Cameron 已提交
375
    // `expr?`
376
    (accepted, question_mark, "1.13.0", Some(31436)),
377 378
    // Allows `..` in tuple (struct) patterns
    (accepted, dotdot_in_tuple_patterns, "1.14.0", Some(33627)),
J
Jeffrey Seyfried 已提交
379
    (accepted, item_like_imports, "1.14.0", Some(35120)),
380 381
    // Allows using `Self` and associated types in struct expressions and patterns.
    (accepted, more_struct_aliases, "1.14.0", Some(37544)),
382
);
383
// (changing above list without updating src/doc/reference.md makes @cmr sad)
384

385 386 387 388 389
#[derive(PartialEq, Copy, Clone, Debug)]
pub enum AttributeType {
    /// Normal, builtin attribute that is consumed
    /// by the compiler before the unused_attribute check
    Normal,
390

391 392 393 394
    /// Builtin attribute that may not be consumed by the compiler
    /// before the unused_attribute check. These attributes
    /// will be ignored by the unused_attribute lint
    Whitelisted,
395

396 397 398 399 400 401 402
    /// Builtin attribute that is only allowed at the crate level
    CrateLevel,
}

pub enum AttributeGate {
    /// Is gated by a given feature gate, reason
    /// and function to check if enabled
403
    Gated(Stability, &'static str, &'static str, fn(&Features) -> bool),
404 405 406 407 408

    /// Ungated attribute, can be used on all release channels
    Ungated,
}

N
Nick Cameron 已提交
409 410 411 412 413 414 415 416 417 418
impl AttributeGate {
    fn is_deprecated(&self) -> bool {
        match *self {
            Gated(Stability::Deprecated(_), ..) => true,
            _ => false,
        }
    }
}

#[derive(Copy, Clone, PartialEq, Eq, Debug)]
419 420
pub enum Stability {
    Unstable,
N
Nick Cameron 已提交
421 422
    // Argument is tracking issue link.
    Deprecated(&'static str),
423 424
}

425 426 427 428
// fn() is not Debug
impl ::std::fmt::Debug for AttributeGate {
    fn fmt(&self, fmt: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
        match *self {
N
Nick Cameron 已提交
429 430
            Gated(ref stab, ref name, ref expl, _) =>
                write!(fmt, "Gated({:?}, {}, {})", stab, name, expl),
431 432 433 434 435 436 437 438 439 440 441 442
            Ungated => write!(fmt, "Ungated")
        }
    }
}

macro_rules! cfg_fn {
    ($field: ident) => {{
        fn f(features: &Features) -> bool {
            features.$field
        }
        f as fn(&Features) -> bool
    }}
443 444
}

N
Nick Cameron 已提交
445
pub fn deprecated_attributes() -> Vec<&'static (&'static str, AttributeType, AttributeGate)> {
446
    BUILTIN_ATTRIBUTES.iter().filter(|a| a.2.is_deprecated()).collect()
N
Nick Cameron 已提交
447 448
}

449 450 451 452
pub fn is_builtin_attr(attr: &ast::Attribute) -> bool {
    BUILTIN_ATTRIBUTES.iter().any(|&(builtin_name, _, _)| attr.check_name(builtin_name))
}

453
// Attributes that have a special meaning to rustc or rustdoc
454
pub const BUILTIN_ATTRIBUTES: &'static [(&'static str, AttributeType, AttributeGate)] = &[
455 456
    // Normal attributes

457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486
    ("warn", Normal, Ungated),
    ("allow", Normal, Ungated),
    ("forbid", Normal, Ungated),
    ("deny", Normal, Ungated),

    ("macro_reexport", Normal, Ungated),
    ("macro_use", Normal, Ungated),
    ("macro_export", Normal, Ungated),
    ("plugin_registrar", Normal, Ungated),

    ("cfg", Normal, Ungated),
    ("cfg_attr", Normal, Ungated),
    ("main", Normal, Ungated),
    ("start", Normal, Ungated),
    ("test", Normal, Ungated),
    ("bench", Normal, Ungated),
    ("simd", Normal, Ungated),
    ("repr", Normal, Ungated),
    ("path", Normal, Ungated),
    ("abi", Normal, Ungated),
    ("automatically_derived", Normal, Ungated),
    ("no_mangle", Normal, Ungated),
    ("no_link", Normal, Ungated),
    ("derive", Normal, Ungated),
    ("should_panic", Normal, Ungated),
    ("ignore", Normal, Ungated),
    ("no_implicit_prelude", Normal, Ungated),
    ("reexport_test_harness_main", Normal, Ungated),
    ("link_args", Normal, Ungated),
    ("macro_escape", Normal, Ungated),
487

488
    // RFC #1445.
489 490
    ("structural_match", Whitelisted, Gated(Stability::Unstable,
                                            "structural_match",
491
                                            "the semantics of constant patterns is \
492 493
                                             not yet settled",
                                            cfg_fn!(structural_match))),
494

A
Alex Crichton 已提交
495
    // Not used any more, but we can't feature gate it
496 497
    ("no_stack_check", Normal, Ungated),

498 499
    ("plugin", CrateLevel, Gated(Stability::Unstable,
                                 "plugin",
500
                                 "compiler plugins are experimental \
501 502 503
                                  and possibly buggy",
                                 cfg_fn!(plugin))),

504
    ("no_std", CrateLevel, Ungated),
505 506
    ("no_core", CrateLevel, Gated(Stability::Unstable,
                                  "no_core",
507 508
                                  "no_core is experimental",
                                  cfg_fn!(no_core))),
509 510
    ("lang", Normal, Gated(Stability::Unstable,
                           "lang_items",
511 512
                           "language items are subject to change",
                           cfg_fn!(lang_items))),
513 514
    ("linkage", Whitelisted, Gated(Stability::Unstable,
                                   "linkage",
515
                                   "the `linkage` attribute is experimental \
516 517
                                    and not portable across platforms",
                                   cfg_fn!(linkage))),
518 519
    ("thread_local", Whitelisted, Gated(Stability::Unstable,
                                        "thread_local",
520 521 522
                                        "`#[thread_local]` is an experimental feature, and does \
                                         not currently handle destructors. There is no \
                                         corresponding `#[task_local]` mapping to the task \
523 524
                                         model",
                                        cfg_fn!(thread_local))),
525

526 527
    ("rustc_on_unimplemented", Normal, Gated(Stability::Unstable,
                                             "on_unimplemented",
528
                                             "the `#[rustc_on_unimplemented]` attribute \
529 530
                                              is an experimental feature",
                                             cfg_fn!(on_unimplemented))),
531 532
    ("allocator", Whitelisted, Gated(Stability::Unstable,
                                     "allocator",
533 534
                                     "the `#[allocator]` attribute is an experimental feature",
                                     cfg_fn!(allocator))),
535 536
    ("needs_allocator", Normal, Gated(Stability::Unstable,
                                      "needs_allocator",
537 538
                                      "the `#[needs_allocator]` \
                                       attribute is an experimental \
539 540
                                       feature",
                                      cfg_fn!(needs_allocator))),
541 542
    ("panic_runtime", Whitelisted, Gated(Stability::Unstable,
                                         "panic_runtime",
543 544 545
                                         "the `#[panic_runtime]` attribute is \
                                          an experimental feature",
                                         cfg_fn!(panic_runtime))),
546 547
    ("needs_panic_runtime", Whitelisted, Gated(Stability::Unstable,
                                               "needs_panic_runtime",
548 549 550 551
                                               "the `#[needs_panic_runtime]` \
                                                attribute is an experimental \
                                                feature",
                                               cfg_fn!(needs_panic_runtime))),
552 553
    ("rustc_variance", Normal, Gated(Stability::Unstable,
                                     "rustc_attrs",
554
                                     "the `#[rustc_variance]` attribute \
N
Niko Matsakis 已提交
555
                                      is just used for rustc unit tests \
556 557
                                      and will never be stable",
                                     cfg_fn!(rustc_attrs))),
558 559
    ("rustc_error", Whitelisted, Gated(Stability::Unstable,
                                       "rustc_attrs",
560
                                       "the `#[rustc_error]` attribute \
N
Niko Matsakis 已提交
561
                                        is just used for rustc unit tests \
562 563
                                        and will never be stable",
                                       cfg_fn!(rustc_attrs))),
564 565
    ("rustc_if_this_changed", Whitelisted, Gated(Stability::Unstable,
                                                 "rustc_attrs",
566 567 568 569
                                                 "the `#[rustc_if_this_changed]` attribute \
                                                  is just used for rustc unit tests \
                                                  and will never be stable",
                                                 cfg_fn!(rustc_attrs))),
570 571
    ("rustc_then_this_would_need", Whitelisted, Gated(Stability::Unstable,
                                                      "rustc_attrs",
572 573 574 575
                                                      "the `#[rustc_if_this_changed]` attribute \
                                                       is just used for rustc unit tests \
                                                       and will never be stable",
                                                      cfg_fn!(rustc_attrs))),
576 577
    ("rustc_dirty", Whitelisted, Gated(Stability::Unstable,
                                       "rustc_attrs",
578 579
                                       "the `#[rustc_dirty]` attribute \
                                        is just used for rustc unit tests \
580 581
                                        and will never be stable",
                                       cfg_fn!(rustc_attrs))),
582 583
    ("rustc_clean", Whitelisted, Gated(Stability::Unstable,
                                       "rustc_attrs",
584 585
                                       "the `#[rustc_clean]` attribute \
                                        is just used for rustc unit tests \
586 587
                                        and will never be stable",
                                       cfg_fn!(rustc_attrs))),
588 589
    ("rustc_metadata_dirty", Whitelisted, Gated(Stability::Unstable,
                                                "rustc_attrs",
590 591 592 593
                                                "the `#[rustc_metadata_dirty]` attribute \
                                                 is just used for rustc unit tests \
                                                 and will never be stable",
                                                 cfg_fn!(rustc_attrs))),
594 595
    ("rustc_metadata_clean", Whitelisted, Gated(Stability::Unstable,
                                                "rustc_attrs",
596 597 598 599
                                                "the `#[rustc_metadata_clean]` attribute \
                                                 is just used for rustc unit tests \
                                                 and will never be stable",
                                                 cfg_fn!(rustc_attrs))),
600 601
    ("rustc_partition_reused", Whitelisted, Gated(Stability::Unstable,
                                                  "rustc_attrs",
602 603 604 605
                                                  "this attribute \
                                                   is just used for rustc unit tests \
                                                   and will never be stable",
                                                  cfg_fn!(rustc_attrs))),
606 607
    ("rustc_partition_translated", Whitelisted, Gated(Stability::Unstable,
                                                      "rustc_attrs",
608 609 610 611
                                                      "this attribute \
                                                       is just used for rustc unit tests \
                                                       and will never be stable",
                                                      cfg_fn!(rustc_attrs))),
612 613
    ("rustc_symbol_name", Whitelisted, Gated(Stability::Unstable,
                                             "rustc_attrs",
614 615
                                             "internal rustc attributes will never be stable",
                                             cfg_fn!(rustc_attrs))),
616 617
    ("rustc_item_path", Whitelisted, Gated(Stability::Unstable,
                                           "rustc_attrs",
618 619
                                           "internal rustc attributes will never be stable",
                                           cfg_fn!(rustc_attrs))),
620 621
    ("rustc_move_fragments", Normal, Gated(Stability::Unstable,
                                           "rustc_attrs",
622
                                           "the `#[rustc_move_fragments]` attribute \
N
Niko Matsakis 已提交
623
                                            is just used for rustc unit tests \
624 625
                                            and will never be stable",
                                           cfg_fn!(rustc_attrs))),
626 627
    ("rustc_mir", Whitelisted, Gated(Stability::Unstable,
                                     "rustc_attrs",
628 629
                                     "the `#[rustc_mir]` attribute \
                                      is just used for rustc unit tests \
630 631
                                      and will never be stable",
                                     cfg_fn!(rustc_attrs))),
632 633
    ("rustc_inherit_overflow_checks", Whitelisted, Gated(Stability::Unstable,
                                                         "rustc_attrs",
634 635 636 637 638 639
                                                         "the `#[rustc_inherit_overflow_checks]` \
                                                          attribute is just used to control \
                                                          overflow checking behavior of several \
                                                          libcore functions that are inlined \
                                                          across crates and will never be stable",
                                                          cfg_fn!(rustc_attrs))),
640 641
    ("compiler_builtins", Whitelisted, Gated(Stability::Unstable,
                                             "compiler_builtins",
642 643 644 645 646
                                             "the `#[compiler_builtins]` attribute is used to \
                                              identify the `compiler_builtins` crate which \
                                              contains compiler-rt intrinsics and will never be \
                                              stable",
                                          cfg_fn!(compiler_builtins))),
647

648 649
    ("allow_internal_unstable", Normal, Gated(Stability::Unstable,
                                              "allow_internal_unstable",
650 651
                                              EXPLAIN_ALLOW_INTERNAL_UNSTABLE,
                                              cfg_fn!(allow_internal_unstable))),
652

653 654
    ("fundamental", Whitelisted, Gated(Stability::Unstable,
                                       "fundamental",
655
                                       "the `#[fundamental]` attribute \
656 657
                                        is an experimental feature",
                                       cfg_fn!(fundamental))),
658

659
    ("proc_macro_derive", Normal, Ungated),
660

661 662
    ("rustc_copy_clone_marker", Whitelisted, Gated(Stability::Unstable,
                                                   "rustc_attrs",
663 664 665
                                                   "internal implementation detail",
                                                   cfg_fn!(rustc_attrs))),

666
    // FIXME: #14408 whitelist docs since rustdoc looks at them
667
    ("doc", Whitelisted, Ungated),
668 669 670

    // FIXME: #14406 these are processed in trans, which happens after the
    // lint pass
671
    ("cold", Whitelisted, Ungated),
672 673
    ("naked", Whitelisted, Gated(Stability::Unstable,
                                 "naked_functions",
T
Ticki 已提交
674
                                 "the `#[naked]` attribute \
675
                                  is an experimental feature",
676
                                 cfg_fn!(naked_functions))),
677 678 679 680
    ("target_feature", Whitelisted, Gated(
        Stability::Unstable, "target_feature",
        "the `#[target_feature]` attribute is an experimental feature",
        cfg_fn!(target_feature))),
681 682 683 684 685 686 687
    ("export_name", Whitelisted, Ungated),
    ("inline", Whitelisted, Ungated),
    ("link", Whitelisted, Ungated),
    ("link_name", Whitelisted, Ungated),
    ("link_section", Whitelisted, Ungated),
    ("no_builtins", Whitelisted, Ungated),
    ("no_mangle", Whitelisted, Ungated),
N
Nick Cameron 已提交
688 689 690 691 692
    ("no_debug", Whitelisted, Gated(
        Stability::Deprecated("https://github.com/rust-lang/rust/issues/29721"),
        "no_debug",
        "the `#[no_debug]` attribute is an experimental feature",
        cfg_fn!(no_debug))),
693 694
    ("omit_gdb_pretty_printer_section", Whitelisted, Gated(Stability::Unstable,
                                                       "omit_gdb_pretty_printer_section",
695 696
                                                       "the `#[omit_gdb_pretty_printer_section]` \
                                                        attribute is just used for the Rust test \
697 698
                                                        suite",
                                                       cfg_fn!(omit_gdb_pretty_printer_section))),
699 700
    ("unsafe_destructor_blind_to_params",
     Normal,
701
     Gated(Stability::Deprecated("https://github.com/rust-lang/rust/issues/34761"),
702
           "dropck_parametricity",
703 704
           "unsafe_destructor_blind_to_params has been replaced by \
            may_dangle and will be removed in the future",
705
           cfg_fn!(dropck_parametricity))),
706 707
    ("may_dangle",
     Normal,
708 709
     Gated(Stability::Unstable,
           "dropck_eyepatch",
710 711
           "may_dangle has unstable semantics and may be removed in the future",
           cfg_fn!(dropck_eyepatch))),
712 713 714
    ("unwind", Whitelisted, Gated(Stability::Unstable,
                                  "unwind_attributes",
                                  "#[unwind] is experimental",
715
                                  cfg_fn!(unwind_attributes))),
716 717

    // used in resolve
718 719
    ("prelude_import", Whitelisted, Gated(Stability::Unstable,
                                          "prelude_import",
720 721
                                          "`#[prelude_import]` is for use by rustc only",
                                          cfg_fn!(prelude_import))),
722 723 724

    // FIXME: #14407 these are only looked at on-demand so we can't
    // guarantee they'll have already been checked
725
    ("rustc_deprecated", Whitelisted, Ungated),
726 727 728
    ("must_use", Whitelisted, Ungated),
    ("stable", Whitelisted, Ungated),
    ("unstable", Whitelisted, Ungated),
729
    ("deprecated", Normal, Ungated),
730

731 732
    ("rustc_paren_sugar", Normal, Gated(Stability::Unstable,
                                        "unboxed_closures",
733 734
                                        "unboxed_closures are still evolving",
                                        cfg_fn!(unboxed_closures))),
735

736 737 738
    ("windows_subsystem", Whitelisted, Gated(Stability::Unstable,
                                             "windows_subsystem",
                                             "the windows subsystem attribute \
A
Alex Crichton 已提交
739
                                              is currently unstable",
740 741
                                             cfg_fn!(windows_subsystem))),

742 743 744 745 746 747 748 749 750 751
    ("proc_macro_attribute", Normal, Gated(Stability::Unstable,
                                           "proc_macro",
                                           "attribute proc macros are currently unstable",
                                           cfg_fn!(proc_macro))),

    ("rustc_derive_registrar", Normal, Gated(Stability::Unstable,
                                             "rustc_derive_registrar",
                                             "used internally by rustc",
                                             cfg_fn!(rustc_attrs))),

752
    // Crate level attributes
753 754 755 756 757 758 759 760
    ("crate_name", CrateLevel, Ungated),
    ("crate_type", CrateLevel, Ungated),
    ("crate_id", CrateLevel, Ungated),
    ("feature", CrateLevel, Ungated),
    ("no_start", CrateLevel, Ungated),
    ("no_main", CrateLevel, Ungated),
    ("no_builtins", CrateLevel, Ungated),
    ("recursion_limit", CrateLevel, Ungated),
761
    ("type_length_limit", CrateLevel, Ungated),
762 763
];

764 765 766
// cfg(...)'s that are feature gated
const GATED_CFGS: &'static [(&'static str, &'static str, fn(&Features) -> bool)] = &[
    // (name in cfg, feature, function to check if the feature is enabled)
767 768 769
    ("target_feature", "cfg_target_feature", cfg_fn!(cfg_target_feature)),
    ("target_vendor", "cfg_target_vendor", cfg_fn!(cfg_target_vendor)),
    ("target_thread_local", "cfg_target_thread_local", cfg_fn!(cfg_target_thread_local)),
770
    ("target_has_atomic", "cfg_target_has_atomic", cfg_fn!(cfg_target_has_atomic)),
771 772 773 774 775 776 777
];

#[derive(Debug, Eq, PartialEq)]
pub struct GatedCfg {
    span: Span,
    index: usize,
}
778

779 780
impl GatedCfg {
    pub fn gate(cfg: &ast::MetaItem) -> Option<GatedCfg> {
781
        let name = &*cfg.name().as_str();
782 783 784 785 786 787 788 789 790
        GATED_CFGS.iter()
                  .position(|info| info.0 == name)
                  .map(|idx| {
                      GatedCfg {
                          span: cfg.span,
                          index: idx
                      }
                  })
    }
J
Jeffrey Seyfried 已提交
791 792

    pub fn check_and_emit(&self, sess: &ParseSess, features: &Features) {
793
        let (cfg, feature, has_feature) = GATED_CFGS[self.index];
J
Jeffrey Seyfried 已提交
794
        if !has_feature(features) && !sess.codemap().span_allows_unstable(self.span) {
795
            let explain = format!("`cfg({})` is experimental and subject to change", cfg);
796
            emit_feature_err(sess, feature, self.span, GateIssue::Language, &explain);
797 798 799 800
        }
    }
}

E
Eduard Burtescu 已提交
801
struct Context<'a> {
L
Leo Testard 已提交
802
    features: &'a Features,
803
    parse_sess: &'a ParseSess,
C
Corey Richardson 已提交
804
    cm: &'a CodeMap,
805
    plugin_attributes: &'a [(String, AttributeType)],
806 807
}

808 809 810 811 812 813
macro_rules! gate_feature_fn {
    ($cx: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{
        let (cx, has_feature, span, name, explain) = ($cx, $has_feature, $span, $name, $explain);
        let has_feature: bool = has_feature(&$cx.features);
        debug!("gate_feature(feature = {:?}, span = {:?}); has? {}", name, span, has_feature);
        if !has_feature && !cx.cm.span_allows_unstable(span) {
814
            emit_feature_err(cx.parse_sess, name, span, GateIssue::Language, explain);
815
        }
816 817 818 819 820 821
    }}
}

macro_rules! gate_feature {
    ($cx: expr, $feature: ident, $span: expr, $explain: expr) => {
        gate_feature_fn!($cx, |x:&Features| x.$feature, $span, stringify!($feature), $explain)
822
    }
823
}
824

825
impl<'a> Context<'a> {
826
    fn check_attribute(&self, attr: &ast::Attribute, is_macro: bool) {
827
        debug!("check_attribute(attr = {:?})", attr);
828
        let name = &*attr.name().as_str();
829
        for &(n, ty, ref gateage) in BUILTIN_ATTRIBUTES {
830
            if n == name {
831
                if let &Gated(_, ref name, ref desc, ref has_feature) = gateage {
832
                    gate_feature_fn!(self, has_feature, attr.span, name, desc);
833
                }
834
                debug!("check_attribute: {:?} is builtin, {:?}, {:?}", name, ty, gateage);
835 836 837
                return;
            }
        }
838
        for &(ref n, ref ty) in self.plugin_attributes {
839
            if n == name {
840
                // Plugins can't gate attributes, so we don't check for it
M
Manish Goregaokar 已提交
841 842
                // unlike the code above; we only use this loop to
                // short-circuit to avoid the checks below
843 844 845 846
                debug!("check_attribute: {:?} is registered by a plugin, {:?}", name, ty);
                return;
            }
        }
847
        if name.starts_with("rustc_") {
848 849 850 851
            gate_feature!(self, rustc_attrs, attr.span,
                          "unless otherwise specified, attributes \
                           with the prefix `rustc_` \
                           are reserved for internal compiler diagnostics");
852
        } else if name.starts_with("derive_") {
L
Leo Testard 已提交
853
            gate_feature!(self, custom_derive, attr.span, EXPLAIN_DERIVE_UNDERSCORE);
854 855
        } else if attr::is_known(attr) {
            debug!("check_attribute: {:?} is known", name);
856
        } else {
M
Manish Goregaokar 已提交
857 858 859 860
            // Only run the custom attribute lint during regular
            // feature gate checking. Macro gating runs
            // before the plugin attributes are registered
            // so we skip this then
861
            if !is_macro {
862 863 864 865 866 867
                gate_feature!(self, custom_attribute, attr.span,
                              &format!("The attribute `{}` is currently \
                                        unknown to the compiler and \
                                        may have meaning \
                                        added to it in the future",
                                       name));
868
            }
869 870
        }
    }
871 872
}

873
pub fn check_attribute(attr: &ast::Attribute, parse_sess: &ParseSess,
L
Leo Testard 已提交
874 875
                       cm: &CodeMap, features: &Features) {
    let cx = Context {
876
        features: features, parse_sess: parse_sess,
L
Leo Testard 已提交
877 878 879 880 881
        cm: cm, plugin_attributes: &[]
    };
    cx.check_attribute(attr, true);
}

882 883 884 885
pub fn find_lang_feature_accepted_version(feature: &str) -> Option<&'static str> {
    ACCEPTED_FEATURES.iter().find(|t| t.0 == feature).map(|t| t.1)
}

886
fn find_lang_feature_issue(feature: &str) -> Option<u32> {
887 888
    if let Some(info) = ACTIVE_FEATURES.iter().find(|t| t.0 == feature) {
        let issue = info.2;
889 890
        // FIXME (#28244): enforce that active features have issue numbers
        // assert!(issue.is_some())
891 892 893
        issue
    } else {
        // search in Accepted or Removed features
894 895 896 897
        match ACCEPTED_FEATURES.iter().chain(REMOVED_FEATURES).find(|t| t.0 == feature) {
            Some(&(_, _, issue)) => issue,
            None => panic!("Feature `{}` is not declared anywhere", feature),
        }
898 899 900 901 902 903 904 905
    }
}

pub enum GateIssue {
    Language,
    Library(Option<u32>)
}

906
pub fn emit_feature_err(sess: &ParseSess, feature: &str, span: Span, issue: GateIssue,
907
                        explain: &str) {
908 909 910 911 912
    feature_err(sess, feature, span, issue, explain).emit();
}

pub fn feature_err<'a>(sess: &'a ParseSess, feature: &str, span: Span, issue: GateIssue,
                   explain: &str) -> DiagnosticBuilder<'a> {
913 914
    let diag = &sess.span_diagnostic;

915 916 917 918 919
    let issue = match issue {
        GateIssue::Language => find_lang_feature_issue(feature),
        GateIssue::Library(lib) => lib,
    };

N
Nick Cameron 已提交
920 921
    let mut err = if let Some(n) = issue {
        diag.struct_span_err(span, &format!("{} (see issue #{})", explain, n))
922
    } else {
N
Nick Cameron 已提交
923 924
        diag.struct_span_err(span, explain)
    };
925 926

    // #23973: do not suggest `#![feature(...)]` if we are in beta/stable
T
Tim Neumann 已提交
927 928 929 930
    if sess.unstable_features.is_nightly_build() {
        err.help(&format!("add #![feature({})] to the \
                           crate attributes to enable",
                          feature));
N
Nick Cameron 已提交
931
    }
T
Tim Neumann 已提交
932

933
    err
934 935
}

L
Leo Testard 已提交
936 937 938
const EXPLAIN_BOX_SYNTAX: &'static str =
    "box expression syntax is experimental; you can call `Box::new` instead.";

J
Jeffrey Seyfried 已提交
939
pub const EXPLAIN_STMT_ATTR_SYNTAX: &'static str =
L
Leo Testard 已提交
940 941
    "attributes on non-item statements and expressions are experimental.";

942 943 944
pub const EXPLAIN_ASM: &'static str =
    "inline assembly is not stable enough for use and is subject to change";

945 946 947 948 949 950 951 952
pub const EXPLAIN_LOG_SYNTAX: &'static str =
    "`log_syntax!` is not stable enough for use and is subject to change";

pub const EXPLAIN_CONCAT_IDENTS: &'static str =
    "`concat_idents` is not stable enough for use and is subject to change";

pub const EXPLAIN_TRACE_MACROS: &'static str =
    "`trace_macros` is not stable enough for use and is subject to change";
953 954
pub const EXPLAIN_ALLOW_INTERNAL_UNSTABLE: &'static str =
    "allow_internal_unstable side-steps feature gating and stability checks";
955

956
pub const EXPLAIN_CUSTOM_DERIVE: &'static str =
N
Nick Cameron 已提交
957 958 959 960 961 962
    "`#[derive]` for custom traits is not stable enough for use. It is deprecated and will \
     be removed in v1.15";

pub const EXPLAIN_DEPR_CUSTOM_DERIVE: &'static str =
    "`#[derive]` for custom traits is deprecated and will be removed in v1.15. Prefer using \
     procedural macro custom derive";
963

L
Leo Testard 已提交
964 965
pub const EXPLAIN_DERIVE_UNDERSCORE: &'static str =
    "attributes of the form `#[derive_*]` are reserved for the compiler";
966

L
Leo Testard 已提交
967 968
pub const EXPLAIN_PLACEMENT_IN: &'static str =
    "placement-in expression syntax is experimental and subject to change.";
C
Corey Richardson 已提交
969 970

struct PostExpansionVisitor<'a> {
N
Nick Cameron 已提交
971
    context: &'a Context<'a>,
C
Corey Richardson 已提交
972 973
}

974 975 976 977 978
macro_rules! gate_feature_post {
    ($cx: expr, $feature: ident, $span: expr, $explain: expr) => {{
        let (cx, span) = ($cx, $span);
        if !cx.context.cm.span_allows_unstable(span) {
            gate_feature!(cx.context, $feature, span, $explain)
C
Corey Richardson 已提交
979
        }
980
    }}
C
Corey Richardson 已提交
981 982
}

983 984 985
impl<'a> PostExpansionVisitor<'a> {
    fn check_abi(&self, abi: Abi, span: Span) {
        match abi {
986
            Abi::RustIntrinsic => {
987
                gate_feature_post!(&self, intrinsics, span,
988 989
                                   "intrinsics are subject to change");
            },
990 991
            Abi::PlatformIntrinsic => {
                gate_feature_post!(&self, platform_intrinsics, span,
992
                                   "platform intrinsics are experimental and possibly buggy");
993 994 995
            },
            Abi::Vectorcall => {
                gate_feature_post!(&self, abi_vectorcall, span,
996 997
                                   "vectorcall is experimental and subject to change");
            },
998 999 1000
            Abi::RustCall => {
                gate_feature_post!(&self, unboxed_closures, span,
                                   "rust-call ABI is subject to change");
1001 1002 1003 1004 1005
            },
            Abi::SysV64 => {
                gate_feature_post!(&self, abi_sysv64, span,
                                   "sysv64 ABI is experimental and subject to change");
            },
J
Jorge Aparicio 已提交
1006 1007 1008
            Abi::PtxKernel => {
                gate_feature_post!(&self, abi_ptx, span,
                                   "PTX ABIs are experimental and subject to change");
1009 1010 1011 1012 1013
            },
            Abi::Unadjusted => {
                gate_feature_post!(&self, abi_unadjusted, span,
                                   "unadjusted ABI is an implementation detail and perma-unstable");
            },
1014 1015 1016 1017
            Abi::Msp430Interrupt => {
                gate_feature_post!(&self, abi_msp430_interrupt, span,
                                   "msp430-interrupt ABI is experimental and subject to change");
            },
J
Jorge Aparicio 已提交
1018 1019 1020 1021 1022 1023 1024 1025 1026
            // Stable
            Abi::Cdecl |
            Abi::Stdcall |
            Abi::Fastcall |
            Abi::Aapcs |
            Abi::Win64 |
            Abi::Rust |
            Abi::C |
            Abi::System => {}
1027 1028 1029 1030
        }
    }
}

1031 1032 1033 1034 1035
fn contains_novel_literal(item: &ast::MetaItem) -> bool {
    use ast::MetaItemKind::*;
    use ast::NestedMetaItemKind::*;

    match item.node {
1036 1037 1038
        Word => false,
        NameValue(ref lit) => !lit.node.is_str(),
        List(ref list) => list.iter().any(|li| {
1039
            match li.node {
1040
                MetaItem(ref mi) => contains_novel_literal(&mi),
1041 1042 1043 1044 1045 1046
                Literal(_) => true,
            }
        }),
    }
}

1047 1048 1049 1050
fn starts_with_digit(s: &str) -> bool {
    s.as_bytes().first().cloned().map_or(false, |b| b >= b'0' && b <= b'9')
}

1051
impl<'a> Visitor<'a> for PostExpansionVisitor<'a> {
1052 1053
    fn visit_attribute(&mut self, attr: &ast::Attribute) {
        if !self.context.cm.span_allows_unstable(attr.span) {
1054
            // check for gated attributes
1055
            self.context.check_attribute(attr, false);
1056
        }
1057

1058
        if contains_novel_literal(&attr.value) {
1059 1060 1061 1062
            gate_feature_post!(&self, attr_literals, attr.span,
                               "non-string literals in attributes, or string \
                               literals in top-level positions, are experimental");
        }
1063 1064
    }

1065
    fn visit_name(&mut self, sp: Span, name: ast::Name) {
1066
        if !name.as_str().is_ascii() {
1067 1068
            gate_feature_post!(&self, non_ascii_idents, sp,
                               "non-ascii idents are not fully supported.");
1069 1070 1071
        }
    }

1072
    fn visit_item(&mut self, i: &'a ast::Item) {
1073
        match i.node {
1074
            ast::ItemKind::ExternCrate(_) => {
1075
                if attr::contains_name(&i.attrs[..], "macro_reexport") {
1076 1077 1078
                    gate_feature_post!(&self, macro_reexport, i.span,
                                       "macros reexports are experimental \
                                        and possibly buggy");
1079 1080 1081
                }
            }

1082
            ast::ItemKind::ForeignMod(ref foreign_module) => {
1083
                if attr::contains_name(&i.attrs[..], "link_args") {
1084
                    gate_feature_post!(&self, link_args, i.span,
1085 1086 1087 1088
                                      "the `link_args` attribute is not portable \
                                       across platforms, it is recommended to \
                                       use `#[link(name = \"foo\")]` instead")
                }
1089
                self.check_abi(foreign_module.abi, i.span);
1090 1091
            }

1092
            ast::ItemKind::Fn(..) => {
1093
                if attr::contains_name(&i.attrs[..], "plugin_registrar") {
1094 1095
                    gate_feature_post!(&self, plugin_registrar, i.span,
                                       "compiler plugins are experimental and possibly buggy");
1096
                }
1097
                if attr::contains_name(&i.attrs[..], "start") {
1098
                    gate_feature_post!(&self, start, i.span,
1099 1100 1101 1102
                                      "a #[start] function is an experimental \
                                       feature whose signature may change \
                                       over time");
                }
1103
                if attr::contains_name(&i.attrs[..], "main") {
1104 1105 1106 1107
                    gate_feature_post!(&self, main, i.span,
                                       "declaration of a nonstandard #[main] \
                                        function may change over time, for now \
                                        a top-level `fn main()` is required");
1108
                }
1109 1110
            }

1111
            ast::ItemKind::Struct(..) => {
1112
                if attr::contains_name(&i.attrs[..], "simd") {
1113 1114
                    gate_feature_post!(&self, simd, i.span,
                                       "SIMD types are experimental and possibly buggy");
1115 1116 1117 1118
                    self.context.parse_sess.span_diagnostic.span_warn(i.span,
                                                                      "the `#[simd]` attribute \
                                                                       is deprecated, use \
                                                                       `#[repr(simd)]` instead");
1119 1120 1121 1122
                }
                for attr in &i.attrs {
                    if attr.name() == "repr" {
                        for item in attr.meta_item_list().unwrap_or(&[]) {
1123
                            if item.check_name("simd") {
1124 1125 1126
                                gate_feature_post!(&self, repr_simd, i.span,
                                                   "SIMD types are experimental \
                                                    and possibly buggy");
1127 1128 1129 1130

                            }
                        }
                    }
1131
                }
D
David Manescu 已提交
1132 1133
            }

1134 1135 1136
            ast::ItemKind::Union(..) => {
                gate_feature_post!(&self, untagged_unions,
                                   i.span,
V
Vadim Petrochenkov 已提交
1137
                                   "unions are unstable and possibly buggy");
1138 1139
            }

1140
            ast::ItemKind::DefaultImpl(..) => {
1141 1142 1143 1144
                gate_feature_post!(&self, optin_builtin_traits,
                                   i.span,
                                   "default trait implementations are experimental \
                                    and possibly buggy");
F
Flavio Percoco 已提交
1145 1146
            }

1147
            ast::ItemKind::Impl(_, polarity, _, _, _, _) => {
1148 1149
                match polarity {
                    ast::ImplPolarity::Negative => {
1150 1151 1152 1153
                        gate_feature_post!(&self, optin_builtin_traits,
                                           i.span,
                                           "negative trait bounds are not yet fully implemented; \
                                            use marker types for now");
1154 1155 1156
                    },
                    _ => {}
                }
1157 1158
            }

1159 1160 1161
            _ => {}
        }

1162
        visit::walk_item(self, i);
1163
    }
1164

1165
    fn visit_foreign_item(&mut self, i: &'a ast::ForeignItem) {
1166 1167
        let links_to_llvm = match attr::first_attr_value_str_by_name(&i.attrs, "link_name") {
            Some(val) => val.as_str().starts_with("llvm."),
1168 1169 1170
            _ => false
        };
        if links_to_llvm {
1171
            gate_feature_post!(&self, link_llvm_intrinsics, i.span,
1172 1173 1174
                              "linking to LLVM intrinsics is experimental");
        }

1175
        visit::walk_foreign_item(self, i)
1176 1177
    }

1178
    fn visit_ty(&mut self, ty: &'a ast::Ty) {
1179 1180 1181 1182
        match ty.node {
            ast::TyKind::BareFn(ref bare_fn_ty) => {
                self.check_abi(bare_fn_ty.abi, ty.span);
            }
1183 1184 1185 1186
            ast::TyKind::ImplTrait(..) => {
                gate_feature_post!(&self, conservative_impl_trait, ty.span,
                                   "`impl Trait` is experimental");
            }
A
Andrew Cann 已提交
1187 1188
            ast::TyKind::Never => {
                gate_feature_post!(&self, never_type, ty.span,
1189 1190
                                   "The `!` type is experimental");
            },
1191 1192 1193 1194 1195
            _ => {}
        }
        visit::walk_ty(self, ty)
    }

1196
    fn visit_fn_ret_ty(&mut self, ret_ty: &'a ast::FunctionRetTy) {
1197 1198
        if let ast::FunctionRetTy::Ty(ref output_ty) = *ret_ty {
            match output_ty.node {
A
Andrew Cann 已提交
1199
                ast::TyKind::Never => return,
1200 1201
                _ => (),
            };
A
Andrew Cann 已提交
1202
            self.visit_ty(output_ty)
1203 1204 1205
        }
    }

1206
    fn visit_expr(&mut self, e: &'a ast::Expr) {
1207
        match e.node {
1208
            ast::ExprKind::Box(_) => {
1209
                gate_feature_post!(&self, box_syntax, e.span, EXPLAIN_BOX_SYNTAX);
1210
            }
1211
            ast::ExprKind::Type(..) => {
1212
                gate_feature_post!(&self, type_ascription, e.span,
1213 1214
                                  "type ascription is experimental");
            }
1215
            ast::ExprKind::Range(_, _, ast::RangeLimits::Closed) => {
1216
                gate_feature_post!(&self, inclusive_range_syntax,
A
Alex Burka 已提交
1217 1218 1219
                                  e.span,
                                  "inclusive range syntax is experimental");
            }
1220 1221 1222
            ast::ExprKind::InPlace(..) => {
                gate_feature_post!(&self, placement_in_syntax, e.span, EXPLAIN_PLACEMENT_IN);
            }
1223 1224 1225 1226 1227 1228
            ast::ExprKind::Struct(_, ref fields, _) => {
                for field in fields {
                    if field.is_shorthand {
                        gate_feature_post!(&self, field_init_shorthand, field.span,
                                           "struct field shorthands are unstable");
                    }
1229 1230 1231 1232 1233
                    if starts_with_digit(&field.ident.node.name.as_str()) {
                        gate_feature_post!(&self, relaxed_adts,
                                          field.span,
                                          "numeric fields in struct expressions are unstable");
                    }
1234 1235
                }
            }
1236 1237 1238 1239
            ast::ExprKind::Break(_, Some(_)) => {
                gate_feature_post!(&self, loop_break_value, e.span,
                                   "`break` with a value is experimental");
            }
1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251
            ast::ExprKind::Lit(ref lit) => {
                if let ast::LitKind::Int(_, ref ty) = lit.node {
                    match *ty {
                        ast::LitIntType::Signed(ast::IntTy::I128) |
                        ast::LitIntType::Unsigned(ast::UintTy::U128) => {
                            gate_feature_post!(&self, i128_type, e.span,
                                               "128-bit integers are not stable");
                        }
                        _ => {}
                    }
                }
            }
1252 1253
            _ => {}
        }
1254
        visit::walk_expr(self, e);
1255
    }
1256

1257
    fn visit_pat(&mut self, pattern: &'a ast::Pat) {
1258
        match pattern.node {
1259
            PatKind::Slice(_, Some(_), ref last) if !last.is_empty() => {
1260
                gate_feature_post!(&self, advanced_slice_patterns,
1261 1262 1263
                                  pattern.span,
                                  "multiple-element slice matches anywhere \
                                   but at the end of a slice (e.g. \
1264
                                   `[0, ..xs, 0]`) are experimental")
1265
            }
1266
            PatKind::Slice(..) => {
1267
                gate_feature_post!(&self, slice_patterns,
1268 1269 1270
                                  pattern.span,
                                  "slice pattern syntax is experimental");
            }
1271
            PatKind::Box(..) => {
1272
                gate_feature_post!(&self, box_patterns,
1273
                                  pattern.span,
1274
                                  "box pattern syntax is experimental");
1275
            }
1276 1277 1278 1279 1280 1281 1282 1283
            PatKind::Struct(_, ref fields, _) => {
                for field in fields {
                    if starts_with_digit(&field.node.ident.name.as_str()) {
                        gate_feature_post!(&self, relaxed_adts,
                                          field.span,
                                          "numeric fields in struct patterns are unstable");
                    }
                }
1284
            }
1285 1286 1287 1288
            PatKind::Range(_, _, RangeEnd::Excluded) => {
                gate_feature_post!(&self, exclusive_range_pattern, pattern.span,
                                   "exclusive range pattern syntax is experimental");
            }
1289 1290
            _ => {}
        }
1291
        visit::walk_pat(self, pattern)
1292 1293
    }

1294
    fn visit_fn(&mut self,
1295 1296
                fn_kind: FnKind<'a>,
                fn_decl: &'a ast::FnDecl,
1297
                span: Span,
1298
                _node_id: NodeId) {
N
Niko Matsakis 已提交
1299 1300
        // check for const fn declarations
        match fn_kind {
1301
            FnKind::ItemFn(_, _, _, Spanned { node: ast::Constness::Const, .. }, _, _, _) => {
1302
                gate_feature_post!(&self, const_fn, span, "const fn is unstable");
N
Niko Matsakis 已提交
1303 1304 1305 1306 1307 1308 1309 1310 1311
            }
            _ => {
                // stability of const fn methods are covered in
                // visit_trait_item and visit_impl_item below; this is
                // because default methods don't pass through this
                // point.
            }
        }

1312
        match fn_kind {
1313 1314
            FnKind::ItemFn(_, _, _, _, abi, _, _) |
            FnKind::Method(_, &ast::MethodSig { abi, .. }, _, _) => {
1315 1316
                self.check_abi(abi, span);
            }
1317 1318
            _ => {}
        }
1319
        visit::walk_fn(self, fn_kind, fn_decl, span);
1320
    }
1321

1322
    fn visit_trait_item(&mut self, ti: &'a ast::TraitItem) {
1323
        match ti.node {
1324
            ast::TraitItemKind::Const(..) => {
1325
                gate_feature_post!(&self, associated_consts,
1326 1327 1328
                                  ti.span,
                                  "associated constants are experimental")
            }
1329 1330 1331 1332
            ast::TraitItemKind::Method(ref sig, ref block) => {
                if block.is_none() {
                    self.check_abi(sig.abi, ti.span);
                }
1333
                if sig.constness.node == ast::Constness::Const {
1334
                    gate_feature_post!(&self, const_fn, ti.span, "const fn is unstable");
N
Niko Matsakis 已提交
1335 1336
                }
            }
1337
            ast::TraitItemKind::Type(_, Some(_)) => {
1338
                gate_feature_post!(&self, associated_type_defaults, ti.span,
1339 1340
                                  "associated type defaults are unstable");
            }
1341 1342 1343 1344 1345
            _ => {}
        }
        visit::walk_trait_item(self, ti);
    }

1346
    fn visit_impl_item(&mut self, ii: &'a ast::ImplItem) {
A
Aaron Turon 已提交
1347
        if ii.defaultness == ast::Defaultness::Default {
1348
            gate_feature_post!(&self, specialization,
A
Aaron Turon 已提交
1349 1350 1351 1352
                              ii.span,
                              "specialization is unstable");
        }

1353
        match ii.node {
1354
            ast::ImplItemKind::Const(..) => {
1355
                gate_feature_post!(&self, associated_consts,
1356 1357 1358
                                  ii.span,
                                  "associated constants are experimental")
            }
1359
            ast::ImplItemKind::Method(ref sig, _) => {
1360
                if sig.constness.node == ast::Constness::Const {
1361
                    gate_feature_post!(&self, const_fn, ii.span, "const fn is unstable");
N
Niko Matsakis 已提交
1362 1363
                }
            }
1364 1365 1366 1367
            _ => {}
        }
        visit::walk_impl_item(self, ii);
    }
1368

1369
    fn visit_vis(&mut self, vis: &'a ast::Visibility) {
1370 1371
        let span = match *vis {
            ast::Visibility::Crate(span) => span,
1372
            ast::Visibility::Restricted { ref path, .. } => path.span,
1373 1374
            _ => return,
        };
1375
        gate_feature_post!(&self, pub_restricted, span, "`pub(restricted)` syntax is experimental");
1376 1377

        visit::walk_vis(self, vis)
1378
    }
1379

1380
    fn visit_generics(&mut self, g: &'a ast::Generics) {
1381 1382 1383 1384 1385 1386 1387 1388 1389
        for t in &g.ty_params {
            if !t.attrs.is_empty() {
                gate_feature_post!(&self, generic_param_attrs, t.attrs[0].span,
                                   "attributes on type parameter bindings are experimental");
            }
        }
        visit::walk_generics(self, g)
    }

1390
    fn visit_lifetime_def(&mut self, lifetime_def: &'a ast::LifetimeDef) {
1391 1392 1393 1394 1395 1396
        if !lifetime_def.attrs.is_empty() {
            gate_feature_post!(&self, generic_param_attrs, lifetime_def.attrs[0].span,
                               "attributes on lifetime bindings are experimental");
        }
        visit::walk_lifetime_def(self, lifetime_def)
    }
1397 1398
}

J
Jeffrey Seyfried 已提交
1399
pub fn get_features(span_handler: &Handler, krate_attrs: &[ast::Attribute]) -> Features {
1400
    let mut features = Features::new();
N
Nick Cameron 已提交
1401

1402 1403
    let mut feature_checker = MutexFeatureChecker::default();

J
Jeffrey Seyfried 已提交
1404
    for attr in krate_attrs {
S
Steven Fackler 已提交
1405
        if !attr.check_name("feature") {
1406 1407
            continue
        }
1408 1409 1410

        match attr.meta_item_list() {
            None => {
G
ggomez 已提交
1411 1412
                span_err!(span_handler, attr.span, E0555,
                          "malformed feature attribute, expected #![feature(...)]");
1413 1414
            }
            Some(list) => {
1415
                for mi in list {
1416 1417 1418 1419 1420 1421 1422 1423
                    let name = if let Some(word) = mi.word() {
                        word.name()
                    } else {
                        span_err!(span_handler, mi.span, E0556,
                                  "malformed feature, expected just one word");
                        continue
                    };

1424 1425 1426
                    if let Some(&(_, _, _, setter)) = ACTIVE_FEATURES.iter()
                        .find(|& &(n, _, _, _)| name == n) {
                        *(setter(&mut features)) = true;
1427
                        feature_checker.collect(&features, mi.span);
1428 1429 1430
                    }
                    else if let Some(&(_, _, _)) = REMOVED_FEATURES.iter()
                        .find(|& &(n, _, _)| name == n) {
G
ggomez 已提交
1431
                        span_err!(span_handler, mi.span, E0557, "feature has been removed");
1432 1433 1434
                    }
                    else if let Some(&(_, _, _)) = ACCEPTED_FEATURES.iter()
                        .find(|& &(n, _, _)| name == n) {
1435
                        features.declared_stable_lang_features.push((name, mi.span));
1436 1437
                    } else {
                        features.declared_lib_features.push((name, mi.span));
1438 1439 1440 1441 1442 1443
                    }
                }
            }
        }
    }

1444 1445
    feature_checker.check(span_handler);

L
Leo Testard 已提交
1446
    features
C
Corey Richardson 已提交
1447 1448
}

1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482
// A collector for mutually-exclusive features and their flag spans
#[derive(Default)]
struct MutexFeatureChecker {
    proc_macro: Option<Span>,
    custom_attribute: Option<Span>,
}

impl MutexFeatureChecker {
    // If this method turns out to be a hotspot due to branching,
    // the branching can be eliminated by modifying `setter!()` to set these spans
    // only for the features that need to be checked for mutual exclusion.
    fn collect(&mut self, features: &Features, span: Span) {
        if features.proc_macro {
            // If self.proc_macro is None, set to Some(span)
            self.proc_macro = self.proc_macro.or(Some(span));
        }

        if features.custom_attribute {
            self.custom_attribute = self.custom_attribute.or(Some(span));
        }
    }

    fn check(self, handler: &Handler) {
        if let (Some(pm_span), Some(ca_span)) = (self.proc_macro, self.custom_attribute) {
            handler.struct_span_err(pm_span, "Cannot use `#![feature(proc_macro)]` and \
                                              `#![feature(custom_attribute)] at the same time")
                .span_note(ca_span, "`#![feature(custom_attribute)]` declared here")
                .emit();

            panic!(FatalError);
        }
    }
}

J
Jeffrey Seyfried 已提交
1483 1484 1485
pub fn check_crate(krate: &ast::Crate,
                   sess: &ParseSess,
                   features: &Features,
1486
                   plugin_attributes: &[(String, AttributeType)],
J
Jeffrey Seyfried 已提交
1487 1488 1489 1490
                   unstable: UnstableFeatures) {
    maybe_stage_features(&sess.span_diagnostic, krate, unstable);
    let ctx = Context {
        features: features,
1491
        parse_sess: sess,
J
Jeffrey Seyfried 已提交
1492 1493 1494 1495
        cm: sess.codemap(),
        plugin_attributes: plugin_attributes,
    };
    visit::walk_crate(&mut PostExpansionVisitor { context: &ctx }, krate);
C
Corey Richardson 已提交
1496
}
1497

1498
#[derive(Clone, Copy, PartialEq, Eq, Hash)]
1499 1500 1501 1502
pub enum UnstableFeatures {
    /// Hard errors for unstable features are active, as on
    /// beta/stable channels.
    Disallow,
J
John Hodge 已提交
1503
    /// Allow features to be activated, as on nightly.
1504 1505 1506 1507
    Allow,
    /// Errors are bypassed for bootstrapping. This is required any time
    /// during the build that feature-related lints are set to warn or above
    /// because the build turns on warnings-as-errors and uses lots of unstable
1508
    /// features. As a result, this is always required for building Rust itself.
1509 1510 1511
    Cheat
}

T
Tim Neumann 已提交
1512 1513 1514 1515
impl UnstableFeatures {
    pub fn from_environment() -> UnstableFeatures {
        // Whether this is a feature-staged build, i.e. on the beta or stable channel
        let disable_unstable_features = option_env!("CFG_DISABLE_UNSTABLE_FEATURES").is_some();
1516 1517 1518 1519 1520 1521
        // Whether we should enable unstable features for bootstrapping
        let bootstrap = env::var("RUSTC_BOOTSTRAP").is_ok();
        match (disable_unstable_features, bootstrap) {
            (_, true) => UnstableFeatures::Cheat,
            (true, _) => UnstableFeatures::Disallow,
            (false, _) => UnstableFeatures::Allow
T
Tim Neumann 已提交
1522 1523
        }
    }
1524 1525 1526 1527 1528 1529 1530

    pub fn is_nightly_build(&self) -> bool {
        match *self {
            UnstableFeatures::Allow | UnstableFeatures::Cheat => true,
            _ => false,
        }
    }
T
Tim Neumann 已提交
1531 1532
}

1533
fn maybe_stage_features(span_handler: &Handler, krate: &ast::Crate,
1534 1535 1536 1537 1538 1539 1540 1541 1542 1543
                        unstable: UnstableFeatures) {
    let allow_features = match unstable {
        UnstableFeatures::Allow => true,
        UnstableFeatures::Disallow => false,
        UnstableFeatures::Cheat => true
    };
    if !allow_features {
        for attr in &krate.attrs {
            if attr.check_name("feature") {
                let release_channel = option_env!("CFG_RELEASE_CHANNEL").unwrap_or("(unknown)");
G
ggomez 已提交
1544
                span_err!(span_handler, attr.span, E0554,
G
ggomez 已提交
1545 1546
                          "#[feature] may not be used on the {} release channel",
                          release_channel);
1547 1548 1549 1550
            }
        }
    }
}