feature_gate.rs 55.1 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

//! Feature gating
//!
L
Luke Gallagher 已提交
13
//! This module implements the gating necessary for preventing certain compiler
14 15 16 17 18
//! features from being used by default. This module will crawl a pre-expanded
//! AST to ensure that there are no features which are used that are not
//! enabled.
//!
//! Features are enabled in programs via the crate-level attributes of
19
//! `#![feature(...)]` with a comma-separated list of features.
B
Brian Anderson 已提交
20 21 22 23
//!
//! For the purpose of future feature-tracking, once code for detection of feature
//! gate usage is added, *do not remove it again* even once the feature
//! becomes stable.
G
GuillaumeGomez 已提交
24

25
use self::AttributeType::*;
26
use self::AttributeGate::*;
27

N
Niko Matsakis 已提交
28
use abi::Abi;
29
use ast::{self, NodeId, PatKind};
30
use attr;
31
use codemap::{CodeMap, Spanned};
32
use syntax_pos::Span;
33
use errors::Handler;
34
use visit::{self, FnKind, Visitor};
J
Jeffrey Seyfried 已提交
35
use parse::ParseSess;
36
use parse::token::InternedString;
37

38
use std::ascii::AsciiExt;
T
Tim Neumann 已提交
39
use std::env;
40

41 42 43 44 45 46 47 48
macro_rules! setter {
    ($field: ident) => {{
        fn f(features: &mut Features) -> &mut bool {
            &mut features.$field
        }
        f as fn(&mut Features) -> &mut bool
    }}
}
49

50
macro_rules! declare_features {
51
    ($((active, $feature: ident, $ver: expr, $issue: expr),)+) => {
52 53 54 55 56 57 58 59 60
        /// Represents active features that are currently being implemented or
        /// currently being considered for addition/removal.
        const ACTIVE_FEATURES: &'static [(&'static str, &'static str,
                                          Option<u32>, fn(&mut Features) -> &mut bool)] = &[
            $((stringify!($feature), $ver, $issue, setter!($feature))),+
        ];

        /// A set of features to be used by later passes.
        pub struct Features {
61 62
            /// #![feature] attrs for stable language features, for error reporting
            pub declared_stable_lang_features: Vec<(InternedString, Span)>,
63 64 65 66
            /// #![feature] attrs for non-language (library) features
            pub declared_lib_features: Vec<(InternedString, Span)>,
            $(pub $feature: bool),+
        }
67

68 69 70 71 72 73 74 75 76 77 78
        impl Features {
            pub fn new() -> Features {
                Features {
                    declared_stable_lang_features: Vec::new(),
                    declared_lib_features: Vec::new(),
                    $($feature: false),+
                }
            }
        }
    };

79
    ($((removed, $feature: ident, $ver: expr, $issue: expr),)+) => {
80 81 82 83 84 85
        /// Represents features which has since been removed (it was once Active)
        const REMOVED_FEATURES: &'static [(&'static str, &'static str, Option<u32>)] = &[
            $((stringify!($feature), $ver, $issue)),+
        ];
    };

86
    ($((accepted, $feature: ident, $ver: expr, $issue: expr),)+) => {
87 88 89 90 91
        /// Those language feature has since been Accepted (it was once Active)
        const ACCEPTED_FEATURES: &'static [(&'static str, &'static str, Option<u32>)] = &[
            $((stringify!($feature), $ver, $issue)),+
        ];
    }
92 93
}

B
Brian Anderson 已提交
94 95 96 97 98
// If you change this list without updating src/doc/reference.md, @cmr will be sad
// Don't ever remove anything from this list; set them to 'Removed'.
// The version numbers here correspond to the version in which the current status
// was set. This is most important for knowing when a particular feature became
// stable (active).
99 100 101 102 103 104 105 106 107 108 109 110
// NB: The featureck.py script parses this information directly out of the source
// so take care when modifying it.

declare_features! (
    (active, asm, "1.0.0", Some(29722)),
    (active, concat_idents, "1.0.0", Some(29599)),
    (active, link_args, "1.0.0", Some(29596)),
    (active, log_syntax, "1.0.0", Some(29598)),
    (active, non_ascii_idents, "1.0.0", Some(28979)),
    (active, plugin_registrar, "1.0.0", Some(29597)),
    (active, thread_local, "1.0.0", Some(29594)),
    (active, trace_macros, "1.0.0", Some(29598)),
A
Aaron Turon 已提交
111 112

    // rustc internal, for now:
113 114
    (active, intrinsics, "1.0.0", None),
    (active, lang_items, "1.0.0", None),
115

116 117 118 119
    (active, link_llvm_intrinsics, "1.0.0", Some(29602)),
    (active, linkage, "1.0.0", Some(29603)),
    (active, quote, "1.0.0", Some(29601)),
    (active, simd, "1.0.0", Some(27731)),
120 121


A
Aaron Turon 已提交
122
    // rustc internal
123 124 125 126 127 128
    (active, rustc_diagnostic_macros, "1.0.0", None),
    (active, advanced_slice_patterns, "1.0.0", Some(23121)),
    (active, box_syntax, "1.0.0", Some(27779)),
    (active, placement_in_syntax, "1.0.0", Some(27779)),
    (active, reflect, "1.0.0", Some(27749)),
    (active, unboxed_closures, "1.0.0", Some(29625)),
A
Aaron Turon 已提交
129 130

    // rustc internal.
131 132 133 134 135 136 137 138 139 140 141 142
    (active, pushpop_unsafe, "1.2.0", None),

    (active, allocator, "1.0.0", Some(27389)),
    (active, fundamental, "1.0.0", Some(29635)),
    (active, linked_from, "1.3.0", Some(29629)),
    (active, main, "1.0.0", Some(29634)),
    (active, needs_allocator, "1.4.0", Some(27389)),
    (active, on_unimplemented, "1.0.0", Some(29628)),
    (active, plugin, "1.0.0", Some(29597)),
    (active, simd_ffi, "1.0.0", Some(27731)),
    (active, start, "1.0.0", Some(29633)),
    (active, structural_match, "1.8.0", Some(31434)),
143 144
    (active, panic_runtime, "1.10.0", Some(32837)),
    (active, needs_panic_runtime, "1.10.0", Some(32837)),
145

146
    // OIBIT specific features
147
    (active, optin_builtin_traits, "1.0.0", Some(13231)),
148

J
Joseph Crail 已提交
149
    // macro reexport needs more discussion and stabilization
150
    (active, macro_reexport, "1.0.0", Some(29638)),
151 152

    // Allows use of #[staged_api]
A
Aaron Turon 已提交
153
    // rustc internal
154
    (active, staged_api, "1.0.0", None),
155 156

    // Allows using items which are missing stability attributes
A
Aaron Turon 已提交
157
    // rustc internal
158
    (active, unmarked_api, "1.0.0", None),
159

A
Alex Crichton 已提交
160
    // Allows using #![no_core]
161
    (active, no_core, "1.3.0", Some(29639)),
A
Alex Crichton 已提交
162

163
    // Allows using `box` in patterns; RFC 469
164
    (active, box_patterns, "1.0.0", Some(29641)),
165

166 167
    // Allows using the unsafe_destructor_blind_to_params attribute;
    // RFC 1238
168
    (active, dropck_parametricity, "1.3.0", Some(28498)),
169

170
    // Allows the use of custom attributes; RFC 572
171
    (active, custom_attribute, "1.0.0", Some(29642)),
M
Manish Goregaokar 已提交
172

173 174
    // Allows the use of #[derive(Anything)] as sugar for
    // #[derive_Anything].
175
    (active, custom_derive, "1.0.0", Some(29644)),
176

M
Manish Goregaokar 已提交
177
    // Allows the use of rustc_* attributes; RFC 572
178
    (active, rustc_attrs, "1.0.0", Some(29642)),
H
Huon Wilson 已提交
179

180 181 182 183
    // Allows the use of #[allow_internal_unstable]. This is an
    // attribute on macro_rules! and can't use the attribute handling
    // below (it has to be checked before expansion possibly makes
    // macros disappear).
A
Aaron Turon 已提交
184 185
    //
    // rustc internal
186
    (active, allow_internal_unstable, "1.0.0", None),
187 188

    // #23121. Array patterns have some hazards yet.
189
    (active, slice_patterns, "1.0.0", Some(23121)),
190 191 192

    // Allows the definition of associated constants in `trait` or `impl`
    // blocks.
193
    (active, associated_consts, "1.0.0", Some(29646)),
N
Niko Matsakis 已提交
194 195

    // Allows the definition of `const fn` functions.
196
    (active, const_fn, "1.2.0", Some(24111)),
197

198
    // Allows indexing into constant arrays.
199
    (active, const_indexing, "1.4.0", Some(29947)),
200

201
    // Allows using #[prelude_import] on glob `use` items.
A
Aaron Turon 已提交
202 203
    //
    // rustc internal
204
    (active, prelude_import, "1.2.0", None),
205 206

    // Allows the definition recursive static items.
207
    (active, static_recursion, "1.3.0", Some(29719)),
B
Brian Anderson 已提交
208 209

    // Allows default type parameters to influence type inference.
210
    (active, default_type_parameter_fallback, "1.3.0", Some(27336)),
211 212

    // Allows associated type defaults
213
    (active, associated_type_defaults, "1.2.0", Some(29661)),
J
Jared Roesch 已提交
214

215
    // allow `repr(simd)`, and importing the various simd intrinsics
216
    (active, repr_simd, "1.4.0", Some(27731)),
217 218

    // Allows cfg(target_feature = "...").
219
    (active, cfg_target_feature, "1.4.0", Some(29717)),
220 221

    // allow `extern "platform-intrinsic" { ... }`
222
    (active, platform_intrinsics, "1.4.0", Some(27731)),
223 224

    // allow `#[unwind]`
A
Aaron Turon 已提交
225
    // rust runtime internal
226
    (active, unwind_attributes, "1.4.0", None),
V
Vadim Petrochenkov 已提交
227

T
Ticki 已提交
228
    // allow the use of `#[naked]` on functions.
229
    (active, naked_functions, "1.9.0", Some(32408)),
230 231

    // allow `#[no_debug]`
232
    (active, no_debug, "1.5.0", Some(29721)),
233 234

    // allow `#[omit_gdb_pretty_printer_section]`
A
Aaron Turon 已提交
235
    // rustc internal.
236
    (active, omit_gdb_pretty_printer_section, "1.5.0", None),
237 238

    // Allows cfg(target_vendor = "...").
239
    (active, cfg_target_vendor, "1.5.0", Some(29718)),
240 241

    // Allow attributes on expressions and non-item statements
242
    (active, stmt_expr_attributes, "1.6.0", Some(15701)),
243 244

    // allow using type ascription in expressions
245
    (active, type_ascription, "1.6.0", Some(23416)),
246 247

    // Allows cfg(target_thread_local)
248
    (active, cfg_target_thread_local, "1.7.0", Some(29594)),
249 250

    // rustc internal
251
    (active, abi_vectorcall, "1.7.0", None),
A
Alex Burka 已提交
252 253

    // a...b and ...b
254
    (active, inclusive_range_syntax, "1.7.0", Some(28237)),
J
Jorge Aparicio 已提交
255 256

    // `expr?`
257
    (active, question_mark, "1.9.0", Some(31436)),
A
Aaron Turon 已提交
258 259

    // impl specialization (RFC 1210)
260
    (active, specialization, "1.7.0", Some(31844)),
261 262

    // pub(restricted) visibilities (RFC 1422)
263 264
    (active, pub_restricted, "1.9.0", Some(32409)),

265 266 267 268
    // Allow Drop types in statics/const functions (RFC 1440)
    (active, drop_types_in_const, "1.9.0", Some(33156)),

    // Allows cfg(target_has_atomic = "...").
269 270 271
    (active, cfg_target_has_atomic, "1.9.0", Some(32976)),

    // Allows `..` in tuple (struct) patterns
272 273 274
    (active, dotdot_in_tuple_patterns, "1.10.0", Some(33627)),

    // Allows `impl Trait` in function return types.
275 276 277 278
    (active, conservative_impl_trait, "1.12.0", Some(34511)),

    // Allows tuple structs and variants in more contexts,
    // Permits numeric fields in struct expressions and patterns.
279 280 281
    (active, relaxed_adts, "1.12.0", Some(35626)),

    // The `!` type
282 283 284
    (active, never_type, "1.13.0", Some(35121)),

    // Allows all literals in attribute lists and values of key-value pairs.
285 286 287 288
    (active, attr_literals, "1.13.0", Some(34981)),

    // Allows the sysV64 ABI to be specified on all platforms
    // instead of just the platforms on which it is the C ABI
289 290 291
    (active, abi_sysv64, "1.13.0", Some(36167)),

    // Use the import semantics from RFC 1560.
292 293 294 295
    (active, item_like_imports, "1.13.0", Some(35120)),

    // Macros 1.1
    (active, rustc_macro, "1.13.0", Some(35900)),
296 297 298

    // Allows untagged unions `union U { ... }`
    (active, untagged_unions, "1.13.0", Some(32836)),
A
Andre Bogus 已提交
299 300 301

    // elide `'static` lifetimes in `static`s and `const`s
    (active, static_in_const, "1.13.0", Some(35897)),
302 303 304 305

    // Used to identify the `compiler_builtins` crate
    // rustc internal
    (active, compiler_builtins, "1.13.0", None),
306 307 308 309 310 311 312 313 314 315 316 317
);

declare_features! (
    (removed, import_shadowing, "1.0.0", None),
    (removed, managed_boxes, "1.0.0", None),
    // Allows use of unary negate on unsigned integers, e.g. -e for e: u8
    (removed, negate_unsigned, "1.0.0", Some(29645)),
    // A way to temporarily opt out of opt in copy. This will *never* be accepted.
    (removed, opt_out_copy, "1.0.0", None),
    (removed, quad_precision_float, "1.0.0", None),
    (removed, struct_inherit, "1.0.0", None),
    (removed, test_removed_feature, "1.0.0", None),
318
    (removed, visible_private_types, "1.0.0", None),
319
    (removed, unsafe_no_drop_flag, "1.0.0", None),
320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335
);

declare_features! (
    (accepted, associated_types, "1.0.0", None),
    // allow overloading augmented assignment operations like `a += b`
    (accepted, augmented_assignments, "1.8.0", Some(28235)),
    // allow empty structs and enum variants with braces
    (accepted, braced_empty_structs, "1.8.0", Some(29720)),
    (accepted, default_type_params, "1.0.0", None),
    (accepted, globs, "1.0.0", None),
    (accepted, if_let, "1.0.0", None),
    // A temporary feature gate used to enable parser extensions needed
    // to bootstrap fix for #5723.
    (accepted, issue_5723_bootstrap, "1.0.0", None),
    (accepted, macro_rules, "1.0.0", None),
    // Allows using #![no_std]
336
    (accepted, no_std, "1.6.0", None),
337 338 339 340 341 342
    (accepted, slicing_syntax, "1.0.0", None),
    (accepted, struct_variant, "1.0.0", None),
    // These are used to test this portion of the compiler, they don't actually
    // mean anything
    (accepted, test_accepted_feature, "1.0.0", None),
    (accepted, tuple_indexing, "1.0.0", None),
D
Daniele Baracchi 已提交
343 344
    // Allows macros to appear in the type position.
    (accepted, type_macros, "1.13.0", Some(27245)),
345 346
    (accepted, while_let, "1.0.0", None),
    // Allows `#[deprecated]` attribute
347
    (accepted, deprecated, "1.9.0", Some(29935)),
348
);
349
// (changing above list without updating src/doc/reference.md makes @cmr sad)
350

351 352 353 354 355
#[derive(PartialEq, Copy, Clone, Debug)]
pub enum AttributeType {
    /// Normal, builtin attribute that is consumed
    /// by the compiler before the unused_attribute check
    Normal,
356

357 358 359 360
    /// Builtin attribute that may not be consumed by the compiler
    /// before the unused_attribute check. These attributes
    /// will be ignored by the unused_attribute lint
    Whitelisted,
361

362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391
    /// Builtin attribute that is only allowed at the crate level
    CrateLevel,
}

pub enum AttributeGate {
    /// Is gated by a given feature gate, reason
    /// and function to check if enabled
    Gated(&'static str, &'static str, fn(&Features) -> bool),

    /// Ungated attribute, can be used on all release channels
    Ungated,
}

// fn() is not Debug
impl ::std::fmt::Debug for AttributeGate {
    fn fmt(&self, fmt: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
        match *self {
            Gated(ref name, ref expl, _) => write!(fmt, "Gated({}, {})", name, expl),
            Ungated => write!(fmt, "Ungated")
        }
    }
}

macro_rules! cfg_fn {
    ($field: ident) => {{
        fn f(features: &Features) -> bool {
            features.$field
        }
        f as fn(&Features) -> bool
    }}
392 393
}

394
// Attributes that have a special meaning to rustc or rustdoc
395
pub const KNOWN_ATTRIBUTES: &'static [(&'static str, AttributeType, AttributeGate)] = &[
396 397
    // Normal attributes

398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427
    ("warn", Normal, Ungated),
    ("allow", Normal, Ungated),
    ("forbid", Normal, Ungated),
    ("deny", Normal, Ungated),

    ("macro_reexport", Normal, Ungated),
    ("macro_use", Normal, Ungated),
    ("macro_export", Normal, Ungated),
    ("plugin_registrar", Normal, Ungated),

    ("cfg", Normal, Ungated),
    ("cfg_attr", Normal, Ungated),
    ("main", Normal, Ungated),
    ("start", Normal, Ungated),
    ("test", Normal, Ungated),
    ("bench", Normal, Ungated),
    ("simd", Normal, Ungated),
    ("repr", Normal, Ungated),
    ("path", Normal, Ungated),
    ("abi", Normal, Ungated),
    ("automatically_derived", Normal, Ungated),
    ("no_mangle", Normal, Ungated),
    ("no_link", Normal, Ungated),
    ("derive", Normal, Ungated),
    ("should_panic", Normal, Ungated),
    ("ignore", Normal, Ungated),
    ("no_implicit_prelude", Normal, Ungated),
    ("reexport_test_harness_main", Normal, Ungated),
    ("link_args", Normal, Ungated),
    ("macro_escape", Normal, Ungated),
428

429 430 431
    // RFC #1445.
    ("structural_match", Whitelisted, Gated("structural_match",
                                            "the semantics of constant patterns is \
432 433
                                             not yet settled",
                                            cfg_fn!(structural_match))),
434

A
Alex Crichton 已提交
435
    // Not used any more, but we can't feature gate it
436 437 438 439
    ("no_stack_check", Normal, Ungated),

    ("plugin", CrateLevel, Gated("plugin",
                                 "compiler plugins are experimental \
440 441 442
                                  and possibly buggy",
                                 cfg_fn!(plugin))),

443
    ("no_std", CrateLevel, Ungated),
444
    ("no_core", CrateLevel, Gated("no_core",
445 446
                                  "no_core is experimental",
                                  cfg_fn!(no_core))),
447
    ("lang", Normal, Gated("lang_items",
448 449
                           "language items are subject to change",
                           cfg_fn!(lang_items))),
450 451
    ("linkage", Whitelisted, Gated("linkage",
                                   "the `linkage` attribute is experimental \
452 453
                                    and not portable across platforms",
                                   cfg_fn!(linkage))),
454 455 456 457
    ("thread_local", Whitelisted, Gated("thread_local",
                                        "`#[thread_local]` is an experimental feature, and does \
                                         not currently handle destructors. There is no \
                                         corresponding `#[task_local]` mapping to the task \
458 459
                                         model",
                                        cfg_fn!(thread_local))),
460 461 462

    ("rustc_on_unimplemented", Normal, Gated("on_unimplemented",
                                             "the `#[rustc_on_unimplemented]` attribute \
463 464
                                              is an experimental feature",
                                             cfg_fn!(on_unimplemented))),
465
    ("allocator", Whitelisted, Gated("allocator",
466 467
                                     "the `#[allocator]` attribute is an experimental feature",
                                     cfg_fn!(allocator))),
468 469 470
    ("needs_allocator", Normal, Gated("needs_allocator",
                                      "the `#[needs_allocator]` \
                                       attribute is an experimental \
471 472
                                       feature",
                                      cfg_fn!(needs_allocator))),
473 474 475 476 477 478 479 480 481
    ("panic_runtime", Whitelisted, Gated("panic_runtime",
                                         "the `#[panic_runtime]` attribute is \
                                          an experimental feature",
                                         cfg_fn!(panic_runtime))),
    ("needs_panic_runtime", Whitelisted, Gated("needs_panic_runtime",
                                               "the `#[needs_panic_runtime]` \
                                                attribute is an experimental \
                                                feature",
                                               cfg_fn!(needs_panic_runtime))),
482 483
    ("rustc_variance", Normal, Gated("rustc_attrs",
                                     "the `#[rustc_variance]` attribute \
N
Niko Matsakis 已提交
484
                                      is just used for rustc unit tests \
485 486
                                      and will never be stable",
                                     cfg_fn!(rustc_attrs))),
487 488
    ("rustc_error", Whitelisted, Gated("rustc_attrs",
                                       "the `#[rustc_error]` attribute \
N
Niko Matsakis 已提交
489
                                        is just used for rustc unit tests \
490 491
                                        and will never be stable",
                                       cfg_fn!(rustc_attrs))),
492
    ("rustc_if_this_changed", Whitelisted, Gated("rustc_attrs",
493 494 495 496
                                                 "the `#[rustc_if_this_changed]` attribute \
                                                  is just used for rustc unit tests \
                                                  and will never be stable",
                                                 cfg_fn!(rustc_attrs))),
497
    ("rustc_then_this_would_need", Whitelisted, Gated("rustc_attrs",
498 499 500 501
                                                      "the `#[rustc_if_this_changed]` attribute \
                                                       is just used for rustc unit tests \
                                                       and will never be stable",
                                                      cfg_fn!(rustc_attrs))),
502 503 504
    ("rustc_dirty", Whitelisted, Gated("rustc_attrs",
                                       "the `#[rustc_dirty]` attribute \
                                        is just used for rustc unit tests \
505 506
                                        and will never be stable",
                                       cfg_fn!(rustc_attrs))),
507 508 509
    ("rustc_clean", Whitelisted, Gated("rustc_attrs",
                                       "the `#[rustc_clean]` attribute \
                                        is just used for rustc unit tests \
510 511
                                        and will never be stable",
                                       cfg_fn!(rustc_attrs))),
512 513 514 515 516 517 518 519 520 521
    ("rustc_metadata_dirty", Whitelisted, Gated("rustc_attrs",
                                                "the `#[rustc_metadata_dirty]` attribute \
                                                 is just used for rustc unit tests \
                                                 and will never be stable",
                                                 cfg_fn!(rustc_attrs))),
    ("rustc_metadata_clean", Whitelisted, Gated("rustc_attrs",
                                                "the `#[rustc_metadata_clean]` attribute \
                                                 is just used for rustc unit tests \
                                                 and will never be stable",
                                                 cfg_fn!(rustc_attrs))),
522 523 524 525 526 527 528 529 530 531
    ("rustc_partition_reused", Whitelisted, Gated("rustc_attrs",
                                                  "this attribute \
                                                   is just used for rustc unit tests \
                                                   and will never be stable",
                                                  cfg_fn!(rustc_attrs))),
    ("rustc_partition_translated", Whitelisted, Gated("rustc_attrs",
                                                      "this attribute \
                                                       is just used for rustc unit tests \
                                                       and will never be stable",
                                                      cfg_fn!(rustc_attrs))),
532
    ("rustc_symbol_name", Whitelisted, Gated("rustc_attrs",
533 534
                                             "internal rustc attributes will never be stable",
                                             cfg_fn!(rustc_attrs))),
535
    ("rustc_item_path", Whitelisted, Gated("rustc_attrs",
536 537
                                           "internal rustc attributes will never be stable",
                                           cfg_fn!(rustc_attrs))),
538 539
    ("rustc_move_fragments", Normal, Gated("rustc_attrs",
                                           "the `#[rustc_move_fragments]` attribute \
N
Niko Matsakis 已提交
540
                                            is just used for rustc unit tests \
541 542
                                            and will never be stable",
                                           cfg_fn!(rustc_attrs))),
543 544 545
    ("rustc_mir", Whitelisted, Gated("rustc_attrs",
                                     "the `#[rustc_mir]` attribute \
                                      is just used for rustc unit tests \
546 547
                                      and will never be stable",
                                     cfg_fn!(rustc_attrs))),
548 549 550 551 552 553 554
    ("rustc_inherit_overflow_checks", Whitelisted, Gated("rustc_attrs",
                                                         "the `#[rustc_inherit_overflow_checks]` \
                                                          attribute is just used to control \
                                                          overflow checking behavior of several \
                                                          libcore functions that are inlined \
                                                          across crates and will never be stable",
                                                          cfg_fn!(rustc_attrs))),
555 556 557 558 559 560
    ("compiler_builtins", Whitelisted, Gated("compiler_builtins",
                                             "the `#[compiler_builtins]` attribute is used to \
                                              identify the `compiler_builtins` crate which \
                                              contains compiler-rt intrinsics and will never be \
                                              stable",
                                          cfg_fn!(compiler_builtins))),
561 562

    ("allow_internal_unstable", Normal, Gated("allow_internal_unstable",
563 564
                                              EXPLAIN_ALLOW_INTERNAL_UNSTABLE,
                                              cfg_fn!(allow_internal_unstable))),
565 566 567

    ("fundamental", Whitelisted, Gated("fundamental",
                                       "the `#[fundamental]` attribute \
568 569
                                        is an experimental feature",
                                       cfg_fn!(fundamental))),
570 571 572

    ("linked_from", Normal, Gated("linked_from",
                                  "the `#[linked_from]` attribute \
573 574
                                   is an experimental feature",
                                  cfg_fn!(linked_from))),
575

576 577 578 579 580 581 582 583 584
    ("rustc_macro_derive", Normal, Gated("rustc_macro",
                                         "the `#[rustc_macro_derive]` attribute \
                                          is an experimental feature",
                                         cfg_fn!(rustc_macro))),

    ("rustc_copy_clone_marker", Whitelisted, Gated("rustc_attrs",
                                                   "internal implementation detail",
                                                   cfg_fn!(rustc_attrs))),

585
    // FIXME: #14408 whitelist docs since rustdoc looks at them
586
    ("doc", Whitelisted, Ungated),
587 588 589

    // FIXME: #14406 these are processed in trans, which happens after the
    // lint pass
590
    ("cold", Whitelisted, Ungated),
T
Ticki 已提交
591 592
    ("naked", Whitelisted, Gated("naked_functions",
                                 "the `#[naked]` attribute \
593
                                  is an experimental feature",
594
                                 cfg_fn!(naked_functions))),
595 596 597 598 599 600 601
    ("export_name", Whitelisted, Ungated),
    ("inline", Whitelisted, Ungated),
    ("link", Whitelisted, Ungated),
    ("link_name", Whitelisted, Ungated),
    ("link_section", Whitelisted, Ungated),
    ("no_builtins", Whitelisted, Ungated),
    ("no_mangle", Whitelisted, Ungated),
602 603
    ("no_debug", Whitelisted, Gated("no_debug",
                                    "the `#[no_debug]` attribute \
604 605
                                     is an experimental feature",
                                    cfg_fn!(no_debug))),
606 607 608
    ("omit_gdb_pretty_printer_section", Whitelisted, Gated("omit_gdb_pretty_printer_section",
                                                       "the `#[omit_gdb_pretty_printer_section]` \
                                                        attribute is just used for the Rust test \
609 610
                                                        suite",
                                                       cfg_fn!(omit_gdb_pretty_printer_section))),
611 612
    ("unsafe_destructor_blind_to_params",
     Normal,
613
     Gated("dropck_parametricity",
614
           "unsafe_destructor_blind_to_params has unstable semantics \
615 616 617 618
            and may be removed in the future",
           cfg_fn!(dropck_parametricity))),
    ("unwind", Whitelisted, Gated("unwind_attributes", "#[unwind] is experimental",
                                  cfg_fn!(unwind_attributes))),
619 620

    // used in resolve
621
    ("prelude_import", Whitelisted, Gated("prelude_import",
622 623
                                          "`#[prelude_import]` is for use by rustc only",
                                          cfg_fn!(prelude_import))),
624 625 626

    // FIXME: #14407 these are only looked at on-demand so we can't
    // guarantee they'll have already been checked
627
    ("rustc_deprecated", Whitelisted, Ungated),
628 629 630
    ("must_use", Whitelisted, Ungated),
    ("stable", Whitelisted, Ungated),
    ("unstable", Whitelisted, Ungated),
631
    ("deprecated", Normal, Ungated),
632

633
    ("rustc_paren_sugar", Normal, Gated("unboxed_closures",
634 635
                                        "unboxed_closures are still evolving",
                                        cfg_fn!(unboxed_closures))),
636
    ("rustc_reflect_like", Whitelisted, Gated("reflect",
637 638
                                              "defining reflective traits is still evolving",
                                              cfg_fn!(reflect))),
639 640

    // Crate level attributes
641 642 643 644 645 646 647 648
    ("crate_name", CrateLevel, Ungated),
    ("crate_type", CrateLevel, Ungated),
    ("crate_id", CrateLevel, Ungated),
    ("feature", CrateLevel, Ungated),
    ("no_start", CrateLevel, Ungated),
    ("no_main", CrateLevel, Ungated),
    ("no_builtins", CrateLevel, Ungated),
    ("recursion_limit", CrateLevel, Ungated),
649 650
];

651 652 653
// cfg(...)'s that are feature gated
const GATED_CFGS: &'static [(&'static str, &'static str, fn(&Features) -> bool)] = &[
    // (name in cfg, feature, function to check if the feature is enabled)
654 655 656
    ("target_feature", "cfg_target_feature", cfg_fn!(cfg_target_feature)),
    ("target_vendor", "cfg_target_vendor", cfg_fn!(cfg_target_vendor)),
    ("target_thread_local", "cfg_target_thread_local", cfg_fn!(cfg_target_thread_local)),
657
    ("target_has_atomic", "cfg_target_has_atomic", cfg_fn!(cfg_target_has_atomic)),
658
    ("rustc_macro", "rustc_macro", cfg_fn!(rustc_macro)),
659 660 661 662 663 664 665
];

#[derive(Debug, Eq, PartialEq)]
pub struct GatedCfg {
    span: Span,
    index: usize,
}
666

667 668 669 670 671 672 673 674 675 676 677 678
impl GatedCfg {
    pub fn gate(cfg: &ast::MetaItem) -> Option<GatedCfg> {
        let name = cfg.name();
        GATED_CFGS.iter()
                  .position(|info| info.0 == name)
                  .map(|idx| {
                      GatedCfg {
                          span: cfg.span,
                          index: idx
                      }
                  })
    }
J
Jeffrey Seyfried 已提交
679 680

    pub fn check_and_emit(&self, sess: &ParseSess, features: &Features) {
681
        let (cfg, feature, has_feature) = GATED_CFGS[self.index];
J
Jeffrey Seyfried 已提交
682
        if !has_feature(features) && !sess.codemap().span_allows_unstable(self.span) {
683
            let explain = format!("`cfg({})` is experimental and subject to change", cfg);
684
            emit_feature_err(sess, feature, self.span, GateIssue::Language, &explain);
685 686 687 688
        }
    }
}

E
Eduard Burtescu 已提交
689
struct Context<'a> {
L
Leo Testard 已提交
690
    features: &'a Features,
691
    parse_sess: &'a ParseSess,
C
Corey Richardson 已提交
692
    cm: &'a CodeMap,
693
    plugin_attributes: &'a [(String, AttributeType)],
694 695
}

696 697 698 699 700 701
macro_rules! gate_feature_fn {
    ($cx: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{
        let (cx, has_feature, span, name, explain) = ($cx, $has_feature, $span, $name, $explain);
        let has_feature: bool = has_feature(&$cx.features);
        debug!("gate_feature(feature = {:?}, span = {:?}); has? {}", name, span, has_feature);
        if !has_feature && !cx.cm.span_allows_unstable(span) {
702
            emit_feature_err(cx.parse_sess, name, span, GateIssue::Language, explain);
703
        }
704 705 706 707 708 709
    }}
}

macro_rules! gate_feature {
    ($cx: expr, $feature: ident, $span: expr, $explain: expr) => {
        gate_feature_fn!($cx, |x:&Features| x.$feature, $span, stringify!($feature), $explain)
710
    }
711
}
712

713
impl<'a> Context<'a> {
714
    fn check_attribute(&self, attr: &ast::Attribute, is_macro: bool) {
715 716
        debug!("check_attribute(attr = {:?})", attr);
        let name = &*attr.name();
717
        for &(n, ty, ref gateage) in KNOWN_ATTRIBUTES {
718
            if n == name {
719 720
                if let &Gated(ref name, ref desc, ref has_feature) = gateage {
                    gate_feature_fn!(self, has_feature, attr.span, name, desc);
721
                }
722
                debug!("check_attribute: {:?} is known, {:?}, {:?}", name, ty, gateage);
723 724 725
                return;
            }
        }
726
        for &(ref n, ref ty) in self.plugin_attributes {
727
            if n == name {
728
                // Plugins can't gate attributes, so we don't check for it
M
Manish Goregaokar 已提交
729 730
                // unlike the code above; we only use this loop to
                // short-circuit to avoid the checks below
731 732 733 734
                debug!("check_attribute: {:?} is registered by a plugin, {:?}", name, ty);
                return;
            }
        }
735
        if name.starts_with("rustc_") {
736 737 738 739
            gate_feature!(self, rustc_attrs, attr.span,
                          "unless otherwise specified, attributes \
                           with the prefix `rustc_` \
                           are reserved for internal compiler diagnostics");
740
        } else if name.starts_with("derive_") {
L
Leo Testard 已提交
741
            gate_feature!(self, custom_derive, attr.span, EXPLAIN_DERIVE_UNDERSCORE);
742
        } else {
M
Manish Goregaokar 已提交
743 744 745 746
            // Only run the custom attribute lint during regular
            // feature gate checking. Macro gating runs
            // before the plugin attributes are registered
            // so we skip this then
747
            if !is_macro {
748 749 750 751 752 753
                gate_feature!(self, custom_attribute, attr.span,
                              &format!("The attribute `{}` is currently \
                                        unknown to the compiler and \
                                        may have meaning \
                                        added to it in the future",
                                       name));
754
            }
755 756
        }
    }
757 758
}

759
pub fn check_attribute(attr: &ast::Attribute, parse_sess: &ParseSess,
L
Leo Testard 已提交
760 761
                       cm: &CodeMap, features: &Features) {
    let cx = Context {
762
        features: features, parse_sess: parse_sess,
L
Leo Testard 已提交
763 764 765 766 767
        cm: cm, plugin_attributes: &[]
    };
    cx.check_attribute(attr, true);
}

768 769 770 771
pub fn find_lang_feature_accepted_version(feature: &str) -> Option<&'static str> {
    ACCEPTED_FEATURES.iter().find(|t| t.0 == feature).map(|t| t.1)
}

772
fn find_lang_feature_issue(feature: &str) -> Option<u32> {
773 774
    if let Some(info) = ACTIVE_FEATURES.iter().find(|t| t.0 == feature) {
        let issue = info.2;
775 776
        // FIXME (#28244): enforce that active features have issue numbers
        // assert!(issue.is_some())
777 778 779 780 781 782
        issue
    } else {
        // search in Accepted or Removed features
        ACCEPTED_FEATURES.iter().chain(REMOVED_FEATURES.iter())
            .find(|t| t.0 == feature)
            .unwrap().2
783 784 785 786 787 788 789 790
    }
}

pub enum GateIssue {
    Language,
    Library(Option<u32>)
}

791
pub fn emit_feature_err(sess: &ParseSess, feature: &str, span: Span, issue: GateIssue,
792
                        explain: &str) {
793 794
    let diag = &sess.span_diagnostic;

795 796 797 798 799
    let issue = match issue {
        GateIssue::Language => find_lang_feature_issue(feature),
        GateIssue::Library(lib) => lib,
    };

N
Nick Cameron 已提交
800 801
    let mut err = if let Some(n) = issue {
        diag.struct_span_err(span, &format!("{} (see issue #{})", explain, n))
802
    } else {
N
Nick Cameron 已提交
803 804
        diag.struct_span_err(span, explain)
    };
805 806

    // #23973: do not suggest `#![feature(...)]` if we are in beta/stable
T
Tim Neumann 已提交
807 808 809 810
    if sess.unstable_features.is_nightly_build() {
        err.help(&format!("add #![feature({})] to the \
                           crate attributes to enable",
                          feature));
N
Nick Cameron 已提交
811
    }
T
Tim Neumann 已提交
812

N
Nick Cameron 已提交
813
    err.emit();
814 815
}

L
Leo Testard 已提交
816 817 818
const EXPLAIN_BOX_SYNTAX: &'static str =
    "box expression syntax is experimental; you can call `Box::new` instead.";

J
Jeffrey Seyfried 已提交
819
pub const EXPLAIN_STMT_ATTR_SYNTAX: &'static str =
L
Leo Testard 已提交
820 821
    "attributes on non-item statements and expressions are experimental.";

822 823 824
pub const EXPLAIN_ASM: &'static str =
    "inline assembly is not stable enough for use and is subject to change";

825 826 827 828 829 830 831 832
pub const EXPLAIN_LOG_SYNTAX: &'static str =
    "`log_syntax!` is not stable enough for use and is subject to change";

pub const EXPLAIN_CONCAT_IDENTS: &'static str =
    "`concat_idents` is not stable enough for use and is subject to change";

pub const EXPLAIN_TRACE_MACROS: &'static str =
    "`trace_macros` is not stable enough for use and is subject to change";
833 834
pub const EXPLAIN_ALLOW_INTERNAL_UNSTABLE: &'static str =
    "allow_internal_unstable side-steps feature gating and stability checks";
835

836 837 838
pub const EXPLAIN_CUSTOM_DERIVE: &'static str =
    "`#[derive]` for custom traits is not stable enough for use and is subject to change";

L
Leo Testard 已提交
839 840
pub const EXPLAIN_DERIVE_UNDERSCORE: &'static str =
    "attributes of the form `#[derive_*]` are reserved for the compiler";
841

L
Leo Testard 已提交
842 843
pub const EXPLAIN_PLACEMENT_IN: &'static str =
    "placement-in expression syntax is experimental and subject to change.";
C
Corey Richardson 已提交
844 845

struct PostExpansionVisitor<'a> {
N
Nick Cameron 已提交
846
    context: &'a Context<'a>,
C
Corey Richardson 已提交
847 848
}

849 850 851 852 853
macro_rules! gate_feature_post {
    ($cx: expr, $feature: ident, $span: expr, $explain: expr) => {{
        let (cx, span) = ($cx, $span);
        if !cx.context.cm.span_allows_unstable(span) {
            gate_feature!(cx.context, $feature, span, $explain)
C
Corey Richardson 已提交
854
        }
855
    }}
C
Corey Richardson 已提交
856 857
}

858 859 860
impl<'a> PostExpansionVisitor<'a> {
    fn check_abi(&self, abi: Abi, span: Span) {
        match abi {
861
            Abi::RustIntrinsic => {
862
                gate_feature_post!(&self, intrinsics, span,
863 864
                                   "intrinsics are subject to change");
            },
865 866
            Abi::PlatformIntrinsic => {
                gate_feature_post!(&self, platform_intrinsics, span,
867
                                   "platform intrinsics are experimental and possibly buggy");
868 869 870
            },
            Abi::Vectorcall => {
                gate_feature_post!(&self, abi_vectorcall, span,
871 872
                                   "vectorcall is experimental and subject to change");
            },
873 874 875
            Abi::RustCall => {
                gate_feature_post!(&self, unboxed_closures, span,
                                   "rust-call ABI is subject to change");
876 877 878 879 880
            },
            Abi::SysV64 => {
                gate_feature_post!(&self, abi_sysv64, span,
                                   "sysv64 ABI is experimental and subject to change");
            },
881 882 883 884 885
            _ => {}
        }
    }
}

886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901
fn contains_novel_literal(item: &ast::MetaItem) -> bool {
    use ast::MetaItemKind::*;
    use ast::NestedMetaItemKind::*;

    match item.node {
        Word(..) => false,
        NameValue(_, ref lit) => !lit.node.is_str(),
        List(_, ref list) => list.iter().any(|li| {
            match li.node {
                MetaItem(ref mi) => contains_novel_literal(&**mi),
                Literal(_) => true,
            }
        }),
    }
}

902
impl<'a> Visitor for PostExpansionVisitor<'a> {
903 904
    fn visit_attribute(&mut self, attr: &ast::Attribute) {
        if !self.context.cm.span_allows_unstable(attr.span) {
905
            // check for gated attributes
906
            self.context.check_attribute(attr, false);
907
        }
908 909 910 911 912 913

        if contains_novel_literal(&*(attr.node.value)) {
            gate_feature_post!(&self, attr_literals, attr.span,
                               "non-string literals in attributes, or string \
                               literals in top-level positions, are experimental");
        }
914 915
    }

916
    fn visit_name(&mut self, sp: Span, name: ast::Name) {
917
        if !name.as_str().is_ascii() {
918 919
            gate_feature_post!(&self, non_ascii_idents, sp,
                               "non-ascii idents are not fully supported.");
920 921 922
        }
    }

923
    fn visit_item(&mut self, i: &ast::Item) {
924
        match i.node {
925
            ast::ItemKind::ExternCrate(_) => {
926
                if attr::contains_name(&i.attrs[..], "macro_reexport") {
927 928 929
                    gate_feature_post!(&self, macro_reexport, i.span,
                                       "macros reexports are experimental \
                                        and possibly buggy");
930 931 932
                }
            }

933
            ast::ItemKind::ForeignMod(ref foreign_module) => {
934
                if attr::contains_name(&i.attrs[..], "link_args") {
935
                    gate_feature_post!(&self, link_args, i.span,
936 937 938 939
                                      "the `link_args` attribute is not portable \
                                       across platforms, it is recommended to \
                                       use `#[link(name = \"foo\")]` instead")
                }
940
                self.check_abi(foreign_module.abi, i.span);
941 942
            }

943
            ast::ItemKind::Fn(..) => {
944
                if attr::contains_name(&i.attrs[..], "plugin_registrar") {
945 946
                    gate_feature_post!(&self, plugin_registrar, i.span,
                                       "compiler plugins are experimental and possibly buggy");
947
                }
948
                if attr::contains_name(&i.attrs[..], "start") {
949
                    gate_feature_post!(&self, start, i.span,
950 951 952 953
                                      "a #[start] function is an experimental \
                                       feature whose signature may change \
                                       over time");
                }
954
                if attr::contains_name(&i.attrs[..], "main") {
955 956 957 958
                    gate_feature_post!(&self, main, i.span,
                                       "declaration of a nonstandard #[main] \
                                        function may change over time, for now \
                                        a top-level `fn main()` is required");
959
                }
960 961
            }

962
            ast::ItemKind::Struct(..) => {
963
                if attr::contains_name(&i.attrs[..], "simd") {
964 965
                    gate_feature_post!(&self, simd, i.span,
                                       "SIMD types are experimental and possibly buggy");
966 967 968 969
                    self.context.parse_sess.span_diagnostic.span_warn(i.span,
                                                                      "the `#[simd]` attribute \
                                                                       is deprecated, use \
                                                                       `#[repr(simd)]` instead");
970 971 972 973
                }
                for attr in &i.attrs {
                    if attr.name() == "repr" {
                        for item in attr.meta_item_list().unwrap_or(&[]) {
974
                            if item.check_name("simd") {
975 976 977
                                gate_feature_post!(&self, repr_simd, i.span,
                                                   "SIMD types are experimental \
                                                    and possibly buggy");
978 979 980 981

                            }
                        }
                    }
982
                }
D
David Manescu 已提交
983 984
            }

985 986 987
            ast::ItemKind::Union(..) => {
                gate_feature_post!(&self, untagged_unions,
                                   i.span,
V
Vadim Petrochenkov 已提交
988
                                   "unions are unstable and possibly buggy");
989 990
            }

991
            ast::ItemKind::DefaultImpl(..) => {
992 993 994 995
                gate_feature_post!(&self, optin_builtin_traits,
                                   i.span,
                                   "default trait implementations are experimental \
                                    and possibly buggy");
F
Flavio Percoco 已提交
996 997
            }

998
            ast::ItemKind::Impl(_, polarity, _, _, _, _) => {
999 1000
                match polarity {
                    ast::ImplPolarity::Negative => {
1001 1002 1003 1004
                        gate_feature_post!(&self, optin_builtin_traits,
                                           i.span,
                                           "negative trait bounds are not yet fully implemented; \
                                            use marker types for now");
1005 1006 1007
                    },
                    _ => {}
                }
1008 1009
            }

1010 1011 1012
            _ => {}
        }

1013
        visit::walk_item(self, i);
1014
    }
1015

1016
    fn visit_foreign_item(&mut self, i: &ast::ForeignItem) {
1017
        let links_to_llvm = match attr::first_attr_value_str_by_name(&i.attrs,
N
fallout  
Nick Cameron 已提交
1018
                                                                     "link_name") {
G
GuillaumeGomez 已提交
1019
            Some(val) => val.starts_with("llvm."),
1020 1021 1022
            _ => false
        };
        if links_to_llvm {
1023
            gate_feature_post!(&self, link_llvm_intrinsics, i.span,
1024 1025 1026
                              "linking to LLVM intrinsics is experimental");
        }

1027
        visit::walk_foreign_item(self, i)
1028 1029
    }

1030 1031 1032 1033 1034
    fn visit_ty(&mut self, ty: &ast::Ty) {
        match ty.node {
            ast::TyKind::BareFn(ref bare_fn_ty) => {
                self.check_abi(bare_fn_ty.abi, ty.span);
            }
1035 1036 1037 1038
            ast::TyKind::ImplTrait(..) => {
                gate_feature_post!(&self, conservative_impl_trait, ty.span,
                                   "`impl Trait` is experimental");
            }
A
Andrew Cann 已提交
1039 1040
            ast::TyKind::Never => {
                gate_feature_post!(&self, never_type, ty.span,
1041 1042
                                   "The `!` type is experimental");
            },
1043 1044 1045 1046 1047
            _ => {}
        }
        visit::walk_ty(self, ty)
    }

1048 1049 1050
    fn visit_fn_ret_ty(&mut self, ret_ty: &ast::FunctionRetTy) {
        if let ast::FunctionRetTy::Ty(ref output_ty) = *ret_ty {
            match output_ty.node {
A
Andrew Cann 已提交
1051
                ast::TyKind::Never => return,
1052 1053
                _ => (),
            };
A
Andrew Cann 已提交
1054
            self.visit_ty(output_ty)
1055 1056 1057
        }
    }

1058
    fn visit_expr(&mut self, e: &ast::Expr) {
1059
        match e.node {
1060
            ast::ExprKind::Box(_) => {
1061
                gate_feature_post!(&self, box_syntax, e.span, EXPLAIN_BOX_SYNTAX);
1062
            }
1063
            ast::ExprKind::Type(..) => {
1064
                gate_feature_post!(&self, type_ascription, e.span,
1065 1066
                                  "type ascription is experimental");
            }
1067
            ast::ExprKind::Range(_, _, ast::RangeLimits::Closed) => {
1068
                gate_feature_post!(&self, inclusive_range_syntax,
A
Alex Burka 已提交
1069 1070 1071
                                  e.span,
                                  "inclusive range syntax is experimental");
            }
J
Jorge Aparicio 已提交
1072
            ast::ExprKind::Try(..) => {
1073
                gate_feature_post!(&self, question_mark, e.span, "the `?` operator is not stable");
J
Jorge Aparicio 已提交
1074
            }
1075 1076 1077
            ast::ExprKind::InPlace(..) => {
                gate_feature_post!(&self, placement_in_syntax, e.span, EXPLAIN_PLACEMENT_IN);
            }
1078 1079
            _ => {}
        }
1080
        visit::walk_expr(self, e);
1081
    }
1082

1083
    fn visit_pat(&mut self, pattern: &ast::Pat) {
1084
        match pattern.node {
1085
            PatKind::Vec(_, Some(_), ref last) if !last.is_empty() => {
1086
                gate_feature_post!(&self, advanced_slice_patterns,
1087 1088 1089
                                  pattern.span,
                                  "multiple-element slice matches anywhere \
                                   but at the end of a slice (e.g. \
1090
                                   `[0, ..xs, 0]`) are experimental")
1091
            }
1092
            PatKind::Vec(..) => {
1093
                gate_feature_post!(&self, slice_patterns,
1094 1095 1096
                                  pattern.span,
                                  "slice pattern syntax is experimental");
            }
1097
            PatKind::Box(..) => {
1098
                gate_feature_post!(&self, box_patterns,
1099
                                  pattern.span,
1100
                                  "box pattern syntax is experimental");
1101
            }
1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115
            PatKind::Tuple(_, ddpos)
                    if ddpos.is_some() => {
                gate_feature_post!(&self, dotdot_in_tuple_patterns,
                                  pattern.span,
                                  "`..` in tuple patterns is experimental");
            }
            PatKind::TupleStruct(_, ref fields, ddpos)
                    if ddpos.is_some() && !fields.is_empty() => {
                gate_feature_post!(&self, dotdot_in_tuple_patterns,
                                  pattern.span,
                                  "`..` in tuple struct patterns is experimental");
            }
            PatKind::TupleStruct(_, ref fields, ddpos)
                    if ddpos.is_none() && fields.is_empty() => {
1116 1117
                gate_feature_post!(&self, relaxed_adts, pattern.span,
                                   "empty tuple structs patterns are unstable");
1118
            }
1119 1120
            _ => {}
        }
1121
        visit::walk_pat(self, pattern)
1122 1123
    }

1124
    fn visit_fn(&mut self,
1125 1126 1127
                fn_kind: FnKind,
                fn_decl: &ast::FnDecl,
                block: &ast::Block,
1128
                span: Span,
1129
                _node_id: NodeId) {
N
Niko Matsakis 已提交
1130 1131
        // check for const fn declarations
        match fn_kind {
1132
            FnKind::ItemFn(_, _, _, Spanned { node: ast::Constness::Const, .. }, _, _) => {
1133
                gate_feature_post!(&self, const_fn, span, "const fn is unstable");
N
Niko Matsakis 已提交
1134 1135 1136 1137 1138 1139 1140 1141 1142
            }
            _ => {
                // stability of const fn methods are covered in
                // visit_trait_item and visit_impl_item below; this is
                // because default methods don't pass through this
                // point.
            }
        }

1143
        match fn_kind {
1144
            FnKind::ItemFn(_, _, _, _, abi, _) |
1145 1146 1147
            FnKind::Method(_, &ast::MethodSig { abi, .. }, _) => {
                self.check_abi(abi, span);
            }
1148 1149
            _ => {}
        }
1150
        visit::walk_fn(self, fn_kind, fn_decl, block, span);
1151
    }
1152

1153
    fn visit_trait_item(&mut self, ti: &ast::TraitItem) {
1154
        match ti.node {
1155
            ast::TraitItemKind::Const(..) => {
1156
                gate_feature_post!(&self, associated_consts,
1157 1158 1159
                                  ti.span,
                                  "associated constants are experimental")
            }
1160 1161 1162 1163
            ast::TraitItemKind::Method(ref sig, ref block) => {
                if block.is_none() {
                    self.check_abi(sig.abi, ti.span);
                }
1164
                if sig.constness.node == ast::Constness::Const {
1165
                    gate_feature_post!(&self, const_fn, ti.span, "const fn is unstable");
N
Niko Matsakis 已提交
1166 1167
                }
            }
1168
            ast::TraitItemKind::Type(_, Some(_)) => {
1169
                gate_feature_post!(&self, associated_type_defaults, ti.span,
1170 1171
                                  "associated type defaults are unstable");
            }
1172 1173 1174 1175 1176
            _ => {}
        }
        visit::walk_trait_item(self, ti);
    }

1177
    fn visit_impl_item(&mut self, ii: &ast::ImplItem) {
A
Aaron Turon 已提交
1178
        if ii.defaultness == ast::Defaultness::Default {
1179
            gate_feature_post!(&self, specialization,
A
Aaron Turon 已提交
1180 1181 1182 1183
                              ii.span,
                              "specialization is unstable");
        }

1184
        match ii.node {
1185
            ast::ImplItemKind::Const(..) => {
1186
                gate_feature_post!(&self, associated_consts,
1187 1188 1189
                                  ii.span,
                                  "associated constants are experimental")
            }
1190
            ast::ImplItemKind::Method(ref sig, _) => {
1191
                if sig.constness.node == ast::Constness::Const {
1192
                    gate_feature_post!(&self, const_fn, ii.span, "const fn is unstable");
N
Niko Matsakis 已提交
1193 1194
                }
            }
1195 1196 1197 1198
            _ => {}
        }
        visit::walk_impl_item(self, ii);
    }
1199

1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212
    fn visit_variant_data(&mut self, vdata: &ast::VariantData, _: ast::Ident,
                          _: &ast::Generics, _: NodeId, span: Span) {
        if vdata.fields().is_empty() {
            if vdata.is_tuple() {
                gate_feature_post!(&self, relaxed_adts, span,
                                   "empty tuple structs and enum variants are unstable, \
                                    use unit structs and enum variants instead");
            }
        }

        visit::walk_struct_def(self, vdata)
    }

1213
    fn visit_vis(&mut self, vis: &ast::Visibility) {
1214 1215
        let span = match *vis {
            ast::Visibility::Crate(span) => span,
1216
            ast::Visibility::Restricted { ref path, .. } => path.span,
1217 1218
            _ => return,
        };
1219
        gate_feature_post!(&self, pub_restricted, span, "`pub(restricted)` syntax is experimental");
1220 1221

        visit::walk_vis(self, vis)
1222
    }
1223 1224
}

J
Jeffrey Seyfried 已提交
1225
pub fn get_features(span_handler: &Handler, krate_attrs: &[ast::Attribute]) -> Features {
1226
    let mut features = Features::new();
N
Nick Cameron 已提交
1227

J
Jeffrey Seyfried 已提交
1228
    for attr in krate_attrs {
S
Steven Fackler 已提交
1229
        if !attr.check_name("feature") {
1230 1231
            continue
        }
1232 1233 1234

        match attr.meta_item_list() {
            None => {
G
ggomez 已提交
1235 1236
                span_err!(span_handler, attr.span, E0555,
                          "malformed feature attribute, expected #![feature(...)]");
1237 1238
            }
            Some(list) => {
1239
                for mi in list {
1240 1241 1242 1243 1244 1245 1246 1247
                    let name = if let Some(word) = mi.word() {
                        word.name()
                    } else {
                        span_err!(span_handler, mi.span, E0556,
                                  "malformed feature, expected just one word");
                        continue
                    };

1248 1249 1250 1251 1252 1253
                    if let Some(&(_, _, _, setter)) = ACTIVE_FEATURES.iter()
                        .find(|& &(n, _, _, _)| name == n) {
                        *(setter(&mut features)) = true;
                    }
                    else if let Some(&(_, _, _)) = REMOVED_FEATURES.iter()
                        .find(|& &(n, _, _)| name == n) {
G
ggomez 已提交
1254
                        span_err!(span_handler, mi.span, E0557, "feature has been removed");
1255 1256 1257
                    }
                    else if let Some(&(_, _, _)) = ACCEPTED_FEATURES.iter()
                        .find(|& &(n, _, _)| name == n) {
1258
                        features.declared_stable_lang_features.push((name, mi.span));
1259 1260
                    } else {
                        features.declared_lib_features.push((name, mi.span));
1261 1262 1263 1264 1265 1266
                    }
                }
            }
        }
    }

L
Leo Testard 已提交
1267
    features
C
Corey Richardson 已提交
1268 1269
}

J
Jeffrey Seyfried 已提交
1270 1271 1272
pub fn check_crate(krate: &ast::Crate,
                   sess: &ParseSess,
                   features: &Features,
1273
                   plugin_attributes: &[(String, AttributeType)],
J
Jeffrey Seyfried 已提交
1274 1275 1276 1277
                   unstable: UnstableFeatures) {
    maybe_stage_features(&sess.span_diagnostic, krate, unstable);
    let ctx = Context {
        features: features,
1278
        parse_sess: sess,
J
Jeffrey Seyfried 已提交
1279 1280 1281 1282
        cm: sess.codemap(),
        plugin_attributes: plugin_attributes,
    };
    visit::walk_crate(&mut PostExpansionVisitor { context: &ctx }, krate);
C
Corey Richardson 已提交
1283
}
1284

1285
#[derive(Clone, Copy, PartialEq, Eq, Hash)]
1286 1287 1288 1289 1290 1291 1292 1293 1294
pub enum UnstableFeatures {
    /// Hard errors for unstable features are active, as on
    /// beta/stable channels.
    Disallow,
    /// Allow features to me activated, as on nightly.
    Allow,
    /// Errors are bypassed for bootstrapping. This is required any time
    /// during the build that feature-related lints are set to warn or above
    /// because the build turns on warnings-as-errors and uses lots of unstable
1295
    /// features. As a result, this is always required for building Rust itself.
1296 1297 1298
    Cheat
}

T
Tim Neumann 已提交
1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313
impl UnstableFeatures {
    pub fn from_environment() -> UnstableFeatures {
        // Whether this is a feature-staged build, i.e. on the beta or stable channel
        let disable_unstable_features = option_env!("CFG_DISABLE_UNSTABLE_FEATURES").is_some();
        // The secret key needed to get through the rustc build itself by
        // subverting the unstable features lints
        let bootstrap_secret_key = option_env!("CFG_BOOTSTRAP_KEY");
        // The matching key to the above, only known by the build system
        let bootstrap_provided_key = env::var("RUSTC_BOOTSTRAP_KEY").ok();
        match (disable_unstable_features, bootstrap_secret_key, bootstrap_provided_key) {
            (_, Some(ref s), Some(ref p)) if s == p => UnstableFeatures::Cheat,
            (true, _, _) => UnstableFeatures::Disallow,
            (false, _, _) => UnstableFeatures::Allow
        }
    }
1314 1315 1316 1317 1318 1319 1320

    pub fn is_nightly_build(&self) -> bool {
        match *self {
            UnstableFeatures::Allow | UnstableFeatures::Cheat => true,
            _ => false,
        }
    }
T
Tim Neumann 已提交
1321 1322
}

1323
fn maybe_stage_features(span_handler: &Handler, krate: &ast::Crate,
1324 1325 1326 1327 1328 1329 1330 1331 1332 1333
                        unstable: UnstableFeatures) {
    let allow_features = match unstable {
        UnstableFeatures::Allow => true,
        UnstableFeatures::Disallow => false,
        UnstableFeatures::Cheat => true
    };
    if !allow_features {
        for attr in &krate.attrs {
            if attr.check_name("feature") {
                let release_channel = option_env!("CFG_RELEASE_CHANNEL").unwrap_or("(unknown)");
G
ggomez 已提交
1334
                span_err!(span_handler, attr.span, E0554,
G
ggomez 已提交
1335 1336
                          "#[feature] may not be used on the {} release channel",
                          release_channel);
1337 1338 1339 1340
            }
        }
    }
}