feature_gate.rs 52.1 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

//! Feature gating
//!
L
Luke Gallagher 已提交
13
//! This module implements the gating necessary for preventing certain compiler
14 15 16 17 18
//! features from being used by default. This module will crawl a pre-expanded
//! AST to ensure that there are no features which are used that are not
//! enabled.
//!
//! Features are enabled in programs via the crate-level attributes of
19
//! `#![feature(...)]` with a comma-separated list of features.
B
Brian Anderson 已提交
20 21 22 23
//!
//! For the purpose of future feature-tracking, once code for detection of feature
//! gate usage is added, *do not remove it again* even once the feature
//! becomes stable.
G
GuillaumeGomez 已提交
24

25
use self::AttributeType::*;
26
use self::AttributeGate::*;
27

N
Niko Matsakis 已提交
28
use abi::Abi;
29
use ast::{self, NodeId, PatKind};
30
use attr;
31
use codemap::{CodeMap, Spanned};
32
use syntax_pos::Span;
33
use errors::Handler;
34
use visit::{self, FnKind, Visitor};
J
Jeffrey Seyfried 已提交
35
use parse::ParseSess;
36
use parse::token::InternedString;
37

38 39
use std::ascii::AsciiExt;

40 41 42 43 44 45 46 47
macro_rules! setter {
    ($field: ident) => {{
        fn f(features: &mut Features) -> &mut bool {
            &mut features.$field
        }
        f as fn(&mut Features) -> &mut bool
    }}
}
48

49
macro_rules! declare_features {
50
    ($((active, $feature: ident, $ver: expr, $issue: expr),)+) => {
51 52 53 54 55 56 57 58 59
        /// Represents active features that are currently being implemented or
        /// currently being considered for addition/removal.
        const ACTIVE_FEATURES: &'static [(&'static str, &'static str,
                                          Option<u32>, fn(&mut Features) -> &mut bool)] = &[
            $((stringify!($feature), $ver, $issue, setter!($feature))),+
        ];

        /// A set of features to be used by later passes.
        pub struct Features {
60 61
            /// #![feature] attrs for stable language features, for error reporting
            pub declared_stable_lang_features: Vec<(InternedString, Span)>,
62 63 64 65
            /// #![feature] attrs for non-language (library) features
            pub declared_lib_features: Vec<(InternedString, Span)>,
            $(pub $feature: bool),+
        }
66

67 68 69 70 71 72 73 74 75 76 77
        impl Features {
            pub fn new() -> Features {
                Features {
                    declared_stable_lang_features: Vec::new(),
                    declared_lib_features: Vec::new(),
                    $($feature: false),+
                }
            }
        }
    };

78
    ($((removed, $feature: ident, $ver: expr, $issue: expr),)+) => {
79 80 81 82 83 84
        /// Represents features which has since been removed (it was once Active)
        const REMOVED_FEATURES: &'static [(&'static str, &'static str, Option<u32>)] = &[
            $((stringify!($feature), $ver, $issue)),+
        ];
    };

85
    ($((accepted, $feature: ident, $ver: expr, $issue: expr),)+) => {
86 87 88 89 90
        /// Those language feature has since been Accepted (it was once Active)
        const ACCEPTED_FEATURES: &'static [(&'static str, &'static str, Option<u32>)] = &[
            $((stringify!($feature), $ver, $issue)),+
        ];
    }
91 92
}

B
Brian Anderson 已提交
93 94 95 96 97
// If you change this list without updating src/doc/reference.md, @cmr will be sad
// Don't ever remove anything from this list; set them to 'Removed'.
// The version numbers here correspond to the version in which the current status
// was set. This is most important for knowing when a particular feature became
// stable (active).
98 99 100 101 102 103 104 105 106 107 108 109
// NB: The featureck.py script parses this information directly out of the source
// so take care when modifying it.

declare_features! (
    (active, asm, "1.0.0", Some(29722)),
    (active, concat_idents, "1.0.0", Some(29599)),
    (active, link_args, "1.0.0", Some(29596)),
    (active, log_syntax, "1.0.0", Some(29598)),
    (active, non_ascii_idents, "1.0.0", Some(28979)),
    (active, plugin_registrar, "1.0.0", Some(29597)),
    (active, thread_local, "1.0.0", Some(29594)),
    (active, trace_macros, "1.0.0", Some(29598)),
A
Aaron Turon 已提交
110 111

    // rustc internal, for now:
112 113
    (active, intrinsics, "1.0.0", None),
    (active, lang_items, "1.0.0", None),
114

115 116 117 118
    (active, link_llvm_intrinsics, "1.0.0", Some(29602)),
    (active, linkage, "1.0.0", Some(29603)),
    (active, quote, "1.0.0", Some(29601)),
    (active, simd, "1.0.0", Some(27731)),
119 120


A
Aaron Turon 已提交
121
    // rustc internal
122 123 124 125 126 127
    (active, rustc_diagnostic_macros, "1.0.0", None),
    (active, advanced_slice_patterns, "1.0.0", Some(23121)),
    (active, box_syntax, "1.0.0", Some(27779)),
    (active, placement_in_syntax, "1.0.0", Some(27779)),
    (active, reflect, "1.0.0", Some(27749)),
    (active, unboxed_closures, "1.0.0", Some(29625)),
A
Aaron Turon 已提交
128 129

    // rustc internal.
130 131 132 133 134 135 136 137 138 139 140 141
    (active, pushpop_unsafe, "1.2.0", None),

    (active, allocator, "1.0.0", Some(27389)),
    (active, fundamental, "1.0.0", Some(29635)),
    (active, linked_from, "1.3.0", Some(29629)),
    (active, main, "1.0.0", Some(29634)),
    (active, needs_allocator, "1.4.0", Some(27389)),
    (active, on_unimplemented, "1.0.0", Some(29628)),
    (active, plugin, "1.0.0", Some(29597)),
    (active, simd_ffi, "1.0.0", Some(27731)),
    (active, start, "1.0.0", Some(29633)),
    (active, structural_match, "1.8.0", Some(31434)),
142 143
    (active, panic_runtime, "1.10.0", Some(32837)),
    (active, needs_panic_runtime, "1.10.0", Some(32837)),
144

145
    // OIBIT specific features
146
    (active, optin_builtin_traits, "1.0.0", Some(13231)),
147

J
Joseph Crail 已提交
148
    // macro reexport needs more discussion and stabilization
149
    (active, macro_reexport, "1.0.0", Some(29638)),
150 151

    // Allows use of #[staged_api]
A
Aaron Turon 已提交
152
    // rustc internal
153
    (active, staged_api, "1.0.0", None),
154 155

    // Allows using items which are missing stability attributes
A
Aaron Turon 已提交
156
    // rustc internal
157
    (active, unmarked_api, "1.0.0", None),
158

A
Alex Crichton 已提交
159
    // Allows using #![no_core]
160
    (active, no_core, "1.3.0", Some(29639)),
A
Alex Crichton 已提交
161

162
    // Allows using `box` in patterns; RFC 469
163
    (active, box_patterns, "1.0.0", Some(29641)),
164

165 166
    // Allows using the unsafe_destructor_blind_to_params attribute;
    // RFC 1238
167
    (active, dropck_parametricity, "1.3.0", Some(28498)),
168

169
    // Allows the use of custom attributes; RFC 572
170
    (active, custom_attribute, "1.0.0", Some(29642)),
M
Manish Goregaokar 已提交
171

172 173
    // Allows the use of #[derive(Anything)] as sugar for
    // #[derive_Anything].
174
    (active, custom_derive, "1.0.0", Some(29644)),
175

M
Manish Goregaokar 已提交
176
    // Allows the use of rustc_* attributes; RFC 572
177
    (active, rustc_attrs, "1.0.0", Some(29642)),
H
Huon Wilson 已提交
178

179 180 181 182
    // Allows the use of #[allow_internal_unstable]. This is an
    // attribute on macro_rules! and can't use the attribute handling
    // below (it has to be checked before expansion possibly makes
    // macros disappear).
A
Aaron Turon 已提交
183 184
    //
    // rustc internal
185
    (active, allow_internal_unstable, "1.0.0", None),
186 187

    // #23121. Array patterns have some hazards yet.
188
    (active, slice_patterns, "1.0.0", Some(23121)),
189 190 191

    // Allows the definition of associated constants in `trait` or `impl`
    // blocks.
192
    (active, associated_consts, "1.0.0", Some(29646)),
N
Niko Matsakis 已提交
193 194

    // Allows the definition of `const fn` functions.
195
    (active, const_fn, "1.2.0", Some(24111)),
196

197
    // Allows indexing into constant arrays.
198
    (active, const_indexing, "1.4.0", Some(29947)),
199

200
    // Allows using #[prelude_import] on glob `use` items.
A
Aaron Turon 已提交
201 202
    //
    // rustc internal
203
    (active, prelude_import, "1.2.0", None),
204 205

    // Allows the definition recursive static items.
206
    (active, static_recursion, "1.3.0", Some(29719)),
B
Brian Anderson 已提交
207 208

    // Allows default type parameters to influence type inference.
209
    (active, default_type_parameter_fallback, "1.3.0", Some(27336)),
210 211

    // Allows associated type defaults
212
    (active, associated_type_defaults, "1.2.0", Some(29661)),
J
Jared Roesch 已提交
213

214
    // allow `repr(simd)`, and importing the various simd intrinsics
215
    (active, repr_simd, "1.4.0", Some(27731)),
216 217

    // Allows cfg(target_feature = "...").
218
    (active, cfg_target_feature, "1.4.0", Some(29717)),
219 220

    // allow `extern "platform-intrinsic" { ... }`
221
    (active, platform_intrinsics, "1.4.0", Some(27731)),
222 223

    // allow `#[unwind]`
A
Aaron Turon 已提交
224
    // rust runtime internal
225
    (active, unwind_attributes, "1.4.0", None),
V
Vadim Petrochenkov 已提交
226

T
Ticki 已提交
227
    // allow the use of `#[naked]` on functions.
228
    (active, naked_functions, "1.9.0", Some(32408)),
229 230

    // allow `#[no_debug]`
231
    (active, no_debug, "1.5.0", Some(29721)),
232 233

    // allow `#[omit_gdb_pretty_printer_section]`
A
Aaron Turon 已提交
234
    // rustc internal.
235
    (active, omit_gdb_pretty_printer_section, "1.5.0", None),
236 237

    // Allows cfg(target_vendor = "...").
238
    (active, cfg_target_vendor, "1.5.0", Some(29718)),
239 240

    // Allow attributes on expressions and non-item statements
241
    (active, stmt_expr_attributes, "1.6.0", Some(15701)),
242 243

    // allow using type ascription in expressions
244
    (active, type_ascription, "1.6.0", Some(23416)),
245 246

    // Allows cfg(target_thread_local)
247
    (active, cfg_target_thread_local, "1.7.0", Some(29594)),
248 249

    // rustc internal
250
    (active, abi_vectorcall, "1.7.0", None),
A
Alex Burka 已提交
251 252

    // a...b and ...b
253
    (active, inclusive_range_syntax, "1.7.0", Some(28237)),
J
Jorge Aparicio 已提交
254 255

    // `expr?`
256
    (active, question_mark, "1.9.0", Some(31436)),
A
Aaron Turon 已提交
257 258

    // impl specialization (RFC 1210)
259
    (active, specialization, "1.7.0", Some(31844)),
260 261

    // pub(restricted) visibilities (RFC 1422)
262 263
    (active, pub_restricted, "1.9.0", Some(32409)),

264 265 266 267
    // Allow Drop types in statics/const functions (RFC 1440)
    (active, drop_types_in_const, "1.9.0", Some(33156)),

    // Allows cfg(target_has_atomic = "...").
268 269 270
    (active, cfg_target_has_atomic, "1.9.0", Some(32976)),

    // Allows `..` in tuple (struct) patterns
271 272 273
    (active, dotdot_in_tuple_patterns, "1.10.0", Some(33627)),

    // Allows `impl Trait` in function return types.
274 275 276 277
    (active, conservative_impl_trait, "1.12.0", Some(34511)),

    // Allows tuple structs and variants in more contexts,
    // Permits numeric fields in struct expressions and patterns.
278 279 280
    (active, relaxed_adts, "1.12.0", Some(35626)),

    // The `!` type
281 282 283
    (active, never_type, "1.13.0", Some(35121)),

    // Allows all literals in attribute lists and values of key-value pairs.
284 285 286 287
    (active, attr_literals, "1.13.0", Some(34981)),

    // Allows the sysV64 ABI to be specified on all platforms
    // instead of just the platforms on which it is the C ABI
288 289 290
    (active, abi_sysv64, "1.13.0", Some(36167)),

    // Use the import semantics from RFC 1560.
291 292 293 294
    (active, item_like_imports, "1.13.0", Some(35120)),

    // Macros 1.1
    (active, rustc_macro, "1.13.0", Some(35900)),
295 296 297 298 299 300 301 302 303 304 305 306
);

declare_features! (
    (removed, import_shadowing, "1.0.0", None),
    (removed, managed_boxes, "1.0.0", None),
    // Allows use of unary negate on unsigned integers, e.g. -e for e: u8
    (removed, negate_unsigned, "1.0.0", Some(29645)),
    // A way to temporarily opt out of opt in copy. This will *never* be accepted.
    (removed, opt_out_copy, "1.0.0", None),
    (removed, quad_precision_float, "1.0.0", None),
    (removed, struct_inherit, "1.0.0", None),
    (removed, test_removed_feature, "1.0.0", None),
307
    (removed, visible_private_types, "1.0.0", None),
308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323
);

declare_features! (
    (accepted, associated_types, "1.0.0", None),
    // allow overloading augmented assignment operations like `a += b`
    (accepted, augmented_assignments, "1.8.0", Some(28235)),
    // allow empty structs and enum variants with braces
    (accepted, braced_empty_structs, "1.8.0", Some(29720)),
    (accepted, default_type_params, "1.0.0", None),
    (accepted, globs, "1.0.0", None),
    (accepted, if_let, "1.0.0", None),
    // A temporary feature gate used to enable parser extensions needed
    // to bootstrap fix for #5723.
    (accepted, issue_5723_bootstrap, "1.0.0", None),
    (accepted, macro_rules, "1.0.0", None),
    // Allows using #![no_std]
324
    (accepted, no_std, "1.6.0", None),
325 326 327 328 329 330
    (accepted, slicing_syntax, "1.0.0", None),
    (accepted, struct_variant, "1.0.0", None),
    // These are used to test this portion of the compiler, they don't actually
    // mean anything
    (accepted, test_accepted_feature, "1.0.0", None),
    (accepted, tuple_indexing, "1.0.0", None),
D
Daniele Baracchi 已提交
331 332
    // Allows macros to appear in the type position.
    (accepted, type_macros, "1.13.0", Some(27245)),
333 334
    (accepted, while_let, "1.0.0", None),
    // Allows `#[deprecated]` attribute
335
    (accepted, deprecated, "1.9.0", Some(29935)),
336
);
337
// (changing above list without updating src/doc/reference.md makes @cmr sad)
338

339 340 341 342 343
#[derive(PartialEq, Copy, Clone, Debug)]
pub enum AttributeType {
    /// Normal, builtin attribute that is consumed
    /// by the compiler before the unused_attribute check
    Normal,
344

345 346 347 348
    /// Builtin attribute that may not be consumed by the compiler
    /// before the unused_attribute check. These attributes
    /// will be ignored by the unused_attribute lint
    Whitelisted,
349

350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379
    /// Builtin attribute that is only allowed at the crate level
    CrateLevel,
}

pub enum AttributeGate {
    /// Is gated by a given feature gate, reason
    /// and function to check if enabled
    Gated(&'static str, &'static str, fn(&Features) -> bool),

    /// Ungated attribute, can be used on all release channels
    Ungated,
}

// fn() is not Debug
impl ::std::fmt::Debug for AttributeGate {
    fn fmt(&self, fmt: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
        match *self {
            Gated(ref name, ref expl, _) => write!(fmt, "Gated({}, {})", name, expl),
            Ungated => write!(fmt, "Ungated")
        }
    }
}

macro_rules! cfg_fn {
    ($field: ident) => {{
        fn f(features: &Features) -> bool {
            features.$field
        }
        f as fn(&Features) -> bool
    }}
380 381
}

382
// Attributes that have a special meaning to rustc or rustdoc
383
pub const KNOWN_ATTRIBUTES: &'static [(&'static str, AttributeType, AttributeGate)] = &[
384 385
    // Normal attributes

386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415
    ("warn", Normal, Ungated),
    ("allow", Normal, Ungated),
    ("forbid", Normal, Ungated),
    ("deny", Normal, Ungated),

    ("macro_reexport", Normal, Ungated),
    ("macro_use", Normal, Ungated),
    ("macro_export", Normal, Ungated),
    ("plugin_registrar", Normal, Ungated),

    ("cfg", Normal, Ungated),
    ("cfg_attr", Normal, Ungated),
    ("main", Normal, Ungated),
    ("start", Normal, Ungated),
    ("test", Normal, Ungated),
    ("bench", Normal, Ungated),
    ("simd", Normal, Ungated),
    ("repr", Normal, Ungated),
    ("path", Normal, Ungated),
    ("abi", Normal, Ungated),
    ("automatically_derived", Normal, Ungated),
    ("no_mangle", Normal, Ungated),
    ("no_link", Normal, Ungated),
    ("derive", Normal, Ungated),
    ("should_panic", Normal, Ungated),
    ("ignore", Normal, Ungated),
    ("no_implicit_prelude", Normal, Ungated),
    ("reexport_test_harness_main", Normal, Ungated),
    ("link_args", Normal, Ungated),
    ("macro_escape", Normal, Ungated),
416

417 418 419
    // RFC #1445.
    ("structural_match", Whitelisted, Gated("structural_match",
                                            "the semantics of constant patterns is \
420 421
                                             not yet settled",
                                            cfg_fn!(structural_match))),
422

A
Alex Crichton 已提交
423
    // Not used any more, but we can't feature gate it
424 425 426 427
    ("no_stack_check", Normal, Ungated),

    ("plugin", CrateLevel, Gated("plugin",
                                 "compiler plugins are experimental \
428 429 430
                                  and possibly buggy",
                                 cfg_fn!(plugin))),

431
    ("no_std", CrateLevel, Ungated),
432
    ("no_core", CrateLevel, Gated("no_core",
433 434
                                  "no_core is experimental",
                                  cfg_fn!(no_core))),
435
    ("lang", Normal, Gated("lang_items",
436 437
                           "language items are subject to change",
                           cfg_fn!(lang_items))),
438 439
    ("linkage", Whitelisted, Gated("linkage",
                                   "the `linkage` attribute is experimental \
440 441
                                    and not portable across platforms",
                                   cfg_fn!(linkage))),
442 443 444 445
    ("thread_local", Whitelisted, Gated("thread_local",
                                        "`#[thread_local]` is an experimental feature, and does \
                                         not currently handle destructors. There is no \
                                         corresponding `#[task_local]` mapping to the task \
446 447
                                         model",
                                        cfg_fn!(thread_local))),
448 449 450

    ("rustc_on_unimplemented", Normal, Gated("on_unimplemented",
                                             "the `#[rustc_on_unimplemented]` attribute \
451 452
                                              is an experimental feature",
                                             cfg_fn!(on_unimplemented))),
453
    ("allocator", Whitelisted, Gated("allocator",
454 455
                                     "the `#[allocator]` attribute is an experimental feature",
                                     cfg_fn!(allocator))),
456 457 458
    ("needs_allocator", Normal, Gated("needs_allocator",
                                      "the `#[needs_allocator]` \
                                       attribute is an experimental \
459 460
                                       feature",
                                      cfg_fn!(needs_allocator))),
461 462 463 464 465 466 467 468 469
    ("panic_runtime", Whitelisted, Gated("panic_runtime",
                                         "the `#[panic_runtime]` attribute is \
                                          an experimental feature",
                                         cfg_fn!(panic_runtime))),
    ("needs_panic_runtime", Whitelisted, Gated("needs_panic_runtime",
                                               "the `#[needs_panic_runtime]` \
                                                attribute is an experimental \
                                                feature",
                                               cfg_fn!(needs_panic_runtime))),
470 471
    ("rustc_variance", Normal, Gated("rustc_attrs",
                                     "the `#[rustc_variance]` attribute \
N
Niko Matsakis 已提交
472
                                      is just used for rustc unit tests \
473 474
                                      and will never be stable",
                                     cfg_fn!(rustc_attrs))),
475 476
    ("rustc_error", Whitelisted, Gated("rustc_attrs",
                                       "the `#[rustc_error]` attribute \
N
Niko Matsakis 已提交
477
                                        is just used for rustc unit tests \
478 479
                                        and will never be stable",
                                       cfg_fn!(rustc_attrs))),
480
    ("rustc_if_this_changed", Whitelisted, Gated("rustc_attrs",
481 482 483 484
                                                 "the `#[rustc_if_this_changed]` attribute \
                                                  is just used for rustc unit tests \
                                                  and will never be stable",
                                                 cfg_fn!(rustc_attrs))),
485
    ("rustc_then_this_would_need", Whitelisted, Gated("rustc_attrs",
486 487 488 489
                                                      "the `#[rustc_if_this_changed]` attribute \
                                                       is just used for rustc unit tests \
                                                       and will never be stable",
                                                      cfg_fn!(rustc_attrs))),
490 491 492
    ("rustc_dirty", Whitelisted, Gated("rustc_attrs",
                                       "the `#[rustc_dirty]` attribute \
                                        is just used for rustc unit tests \
493 494
                                        and will never be stable",
                                       cfg_fn!(rustc_attrs))),
495 496 497
    ("rustc_clean", Whitelisted, Gated("rustc_attrs",
                                       "the `#[rustc_clean]` attribute \
                                        is just used for rustc unit tests \
498 499
                                        and will never be stable",
                                       cfg_fn!(rustc_attrs))),
500 501 502 503 504 505 506 507 508 509
    ("rustc_partition_reused", Whitelisted, Gated("rustc_attrs",
                                                  "this attribute \
                                                   is just used for rustc unit tests \
                                                   and will never be stable",
                                                  cfg_fn!(rustc_attrs))),
    ("rustc_partition_translated", Whitelisted, Gated("rustc_attrs",
                                                      "this attribute \
                                                       is just used for rustc unit tests \
                                                       and will never be stable",
                                                      cfg_fn!(rustc_attrs))),
510
    ("rustc_symbol_name", Whitelisted, Gated("rustc_attrs",
511 512
                                             "internal rustc attributes will never be stable",
                                             cfg_fn!(rustc_attrs))),
513
    ("rustc_item_path", Whitelisted, Gated("rustc_attrs",
514 515
                                           "internal rustc attributes will never be stable",
                                           cfg_fn!(rustc_attrs))),
516 517
    ("rustc_move_fragments", Normal, Gated("rustc_attrs",
                                           "the `#[rustc_move_fragments]` attribute \
N
Niko Matsakis 已提交
518
                                            is just used for rustc unit tests \
519 520
                                            and will never be stable",
                                           cfg_fn!(rustc_attrs))),
521 522 523
    ("rustc_mir", Whitelisted, Gated("rustc_attrs",
                                     "the `#[rustc_mir]` attribute \
                                      is just used for rustc unit tests \
524 525
                                      and will never be stable",
                                     cfg_fn!(rustc_attrs))),
526 527 528 529 530 531 532
    ("rustc_inherit_overflow_checks", Whitelisted, Gated("rustc_attrs",
                                                         "the `#[rustc_inherit_overflow_checks]` \
                                                          attribute is just used to control \
                                                          overflow checking behavior of several \
                                                          libcore functions that are inlined \
                                                          across crates and will never be stable",
                                                          cfg_fn!(rustc_attrs))),
533 534

    ("allow_internal_unstable", Normal, Gated("allow_internal_unstable",
535 536
                                              EXPLAIN_ALLOW_INTERNAL_UNSTABLE,
                                              cfg_fn!(allow_internal_unstable))),
537 538 539

    ("fundamental", Whitelisted, Gated("fundamental",
                                       "the `#[fundamental]` attribute \
540 541
                                        is an experimental feature",
                                       cfg_fn!(fundamental))),
542 543 544

    ("linked_from", Normal, Gated("linked_from",
                                  "the `#[linked_from]` attribute \
545 546
                                   is an experimental feature",
                                  cfg_fn!(linked_from))),
547

548 549 550 551 552 553 554 555 556
    ("rustc_macro_derive", Normal, Gated("rustc_macro",
                                         "the `#[rustc_macro_derive]` attribute \
                                          is an experimental feature",
                                         cfg_fn!(rustc_macro))),

    ("rustc_copy_clone_marker", Whitelisted, Gated("rustc_attrs",
                                                   "internal implementation detail",
                                                   cfg_fn!(rustc_attrs))),

557
    // FIXME: #14408 whitelist docs since rustdoc looks at them
558
    ("doc", Whitelisted, Ungated),
559 560 561

    // FIXME: #14406 these are processed in trans, which happens after the
    // lint pass
562
    ("cold", Whitelisted, Ungated),
T
Ticki 已提交
563 564
    ("naked", Whitelisted, Gated("naked_functions",
                                 "the `#[naked]` attribute \
565
                                  is an experimental feature",
566
                                 cfg_fn!(naked_functions))),
567 568 569 570 571 572 573
    ("export_name", Whitelisted, Ungated),
    ("inline", Whitelisted, Ungated),
    ("link", Whitelisted, Ungated),
    ("link_name", Whitelisted, Ungated),
    ("link_section", Whitelisted, Ungated),
    ("no_builtins", Whitelisted, Ungated),
    ("no_mangle", Whitelisted, Ungated),
574 575
    ("no_debug", Whitelisted, Gated("no_debug",
                                    "the `#[no_debug]` attribute \
576 577
                                     is an experimental feature",
                                    cfg_fn!(no_debug))),
578 579 580
    ("omit_gdb_pretty_printer_section", Whitelisted, Gated("omit_gdb_pretty_printer_section",
                                                       "the `#[omit_gdb_pretty_printer_section]` \
                                                        attribute is just used for the Rust test \
581 582
                                                        suite",
                                                       cfg_fn!(omit_gdb_pretty_printer_section))),
583 584
    ("unsafe_destructor_blind_to_params",
     Normal,
585
     Gated("dropck_parametricity",
586
           "unsafe_destructor_blind_to_params has unstable semantics \
587 588 589 590
            and may be removed in the future",
           cfg_fn!(dropck_parametricity))),
    ("unwind", Whitelisted, Gated("unwind_attributes", "#[unwind] is experimental",
                                  cfg_fn!(unwind_attributes))),
591 592

    // used in resolve
593
    ("prelude_import", Whitelisted, Gated("prelude_import",
594 595
                                          "`#[prelude_import]` is for use by rustc only",
                                          cfg_fn!(prelude_import))),
596 597 598

    // FIXME: #14407 these are only looked at on-demand so we can't
    // guarantee they'll have already been checked
599
    ("rustc_deprecated", Whitelisted, Ungated),
600 601 602
    ("must_use", Whitelisted, Ungated),
    ("stable", Whitelisted, Ungated),
    ("unstable", Whitelisted, Ungated),
603
    ("deprecated", Normal, Ungated),
604

605
    ("rustc_paren_sugar", Normal, Gated("unboxed_closures",
606 607
                                        "unboxed_closures are still evolving",
                                        cfg_fn!(unboxed_closures))),
608
    ("rustc_reflect_like", Whitelisted, Gated("reflect",
609 610
                                              "defining reflective traits is still evolving",
                                              cfg_fn!(reflect))),
611 612

    // Crate level attributes
613 614 615 616 617 618 619 620
    ("crate_name", CrateLevel, Ungated),
    ("crate_type", CrateLevel, Ungated),
    ("crate_id", CrateLevel, Ungated),
    ("feature", CrateLevel, Ungated),
    ("no_start", CrateLevel, Ungated),
    ("no_main", CrateLevel, Ungated),
    ("no_builtins", CrateLevel, Ungated),
    ("recursion_limit", CrateLevel, Ungated),
621 622
];

623 624 625
// cfg(...)'s that are feature gated
const GATED_CFGS: &'static [(&'static str, &'static str, fn(&Features) -> bool)] = &[
    // (name in cfg, feature, function to check if the feature is enabled)
626 627 628
    ("target_feature", "cfg_target_feature", cfg_fn!(cfg_target_feature)),
    ("target_vendor", "cfg_target_vendor", cfg_fn!(cfg_target_vendor)),
    ("target_thread_local", "cfg_target_thread_local", cfg_fn!(cfg_target_thread_local)),
629
    ("target_has_atomic", "cfg_target_has_atomic", cfg_fn!(cfg_target_has_atomic)),
630
    ("rustc_macro", "rustc_macro", cfg_fn!(rustc_macro)),
631 632 633 634 635 636 637
];

#[derive(Debug, Eq, PartialEq)]
pub struct GatedCfg {
    span: Span,
    index: usize,
}
638

639 640 641 642 643 644 645 646 647 648 649 650
impl GatedCfg {
    pub fn gate(cfg: &ast::MetaItem) -> Option<GatedCfg> {
        let name = cfg.name();
        GATED_CFGS.iter()
                  .position(|info| info.0 == name)
                  .map(|idx| {
                      GatedCfg {
                          span: cfg.span,
                          index: idx
                      }
                  })
    }
J
Jeffrey Seyfried 已提交
651 652

    pub fn check_and_emit(&self, sess: &ParseSess, features: &Features) {
653
        let (cfg, feature, has_feature) = GATED_CFGS[self.index];
J
Jeffrey Seyfried 已提交
654 655
        if !has_feature(features) && !sess.codemap().span_allows_unstable(self.span) {
            let diagnostic = &sess.span_diagnostic;
656
            let explain = format!("`cfg({})` is experimental and subject to change", cfg);
657
            emit_feature_err(diagnostic, feature, self.span, GateIssue::Language, &explain);
658 659 660 661
        }
    }
}

E
Eduard Burtescu 已提交
662
struct Context<'a> {
L
Leo Testard 已提交
663
    features: &'a Features,
664
    span_handler: &'a Handler,
C
Corey Richardson 已提交
665
    cm: &'a CodeMap,
666
    plugin_attributes: &'a [(String, AttributeType)],
667 668
}

669 670 671 672 673 674 675
macro_rules! gate_feature_fn {
    ($cx: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{
        let (cx, has_feature, span, name, explain) = ($cx, $has_feature, $span, $name, $explain);
        let has_feature: bool = has_feature(&$cx.features);
        debug!("gate_feature(feature = {:?}, span = {:?}); has? {}", name, span, has_feature);
        if !has_feature && !cx.cm.span_allows_unstable(span) {
            emit_feature_err(cx.span_handler, name, span, GateIssue::Language, explain);
676
        }
677 678 679 680 681 682
    }}
}

macro_rules! gate_feature {
    ($cx: expr, $feature: ident, $span: expr, $explain: expr) => {
        gate_feature_fn!($cx, |x:&Features| x.$feature, $span, stringify!($feature), $explain)
683
    }
684
}
685

686
impl<'a> Context<'a> {
687
    fn check_attribute(&self, attr: &ast::Attribute, is_macro: bool) {
688 689
        debug!("check_attribute(attr = {:?})", attr);
        let name = &*attr.name();
690
        for &(n, ty, ref gateage) in KNOWN_ATTRIBUTES {
691
            if n == name {
692 693
                if let &Gated(ref name, ref desc, ref has_feature) = gateage {
                    gate_feature_fn!(self, has_feature, attr.span, name, desc);
694
                }
695
                debug!("check_attribute: {:?} is known, {:?}, {:?}", name, ty, gateage);
696 697 698
                return;
            }
        }
699
        for &(ref n, ref ty) in self.plugin_attributes {
700
            if n == name {
701
                // Plugins can't gate attributes, so we don't check for it
M
Manish Goregaokar 已提交
702 703
                // unlike the code above; we only use this loop to
                // short-circuit to avoid the checks below
704 705 706 707
                debug!("check_attribute: {:?} is registered by a plugin, {:?}", name, ty);
                return;
            }
        }
708
        if name.starts_with("rustc_") {
709 710 711 712
            gate_feature!(self, rustc_attrs, attr.span,
                          "unless otherwise specified, attributes \
                           with the prefix `rustc_` \
                           are reserved for internal compiler diagnostics");
713
        } else if name.starts_with("derive_") {
L
Leo Testard 已提交
714
            gate_feature!(self, custom_derive, attr.span, EXPLAIN_DERIVE_UNDERSCORE);
715
        } else {
M
Manish Goregaokar 已提交
716 717 718 719
            // Only run the custom attribute lint during regular
            // feature gate checking. Macro gating runs
            // before the plugin attributes are registered
            // so we skip this then
720
            if !is_macro {
721 722 723 724 725 726
                gate_feature!(self, custom_attribute, attr.span,
                              &format!("The attribute `{}` is currently \
                                        unknown to the compiler and \
                                        may have meaning \
                                        added to it in the future",
                                       name));
727
            }
728 729
        }
    }
730 731
}

L
Leo Testard 已提交
732 733 734 735 736 737 738 739 740
pub fn check_attribute(attr: &ast::Attribute, handler: &Handler,
                       cm: &CodeMap, features: &Features) {
    let cx = Context {
        features: features, span_handler: handler,
        cm: cm, plugin_attributes: &[]
    };
    cx.check_attribute(attr, true);
}

741 742 743 744
pub fn find_lang_feature_accepted_version(feature: &str) -> Option<&'static str> {
    ACCEPTED_FEATURES.iter().find(|t| t.0 == feature).map(|t| t.1)
}

745
fn find_lang_feature_issue(feature: &str) -> Option<u32> {
746 747
    if let Some(info) = ACTIVE_FEATURES.iter().find(|t| t.0 == feature) {
        let issue = info.2;
748 749
        // FIXME (#28244): enforce that active features have issue numbers
        // assert!(issue.is_some())
750 751 752 753 754 755
        issue
    } else {
        // search in Accepted or Removed features
        ACCEPTED_FEATURES.iter().chain(REMOVED_FEATURES.iter())
            .find(|t| t.0 == feature)
            .unwrap().2
756 757 758 759 760 761 762 763
    }
}

pub enum GateIssue {
    Language,
    Library(Option<u32>)
}

764
pub fn emit_feature_err(diag: &Handler, feature: &str, span: Span, issue: GateIssue,
765 766 767 768 769 770
                        explain: &str) {
    let issue = match issue {
        GateIssue::Language => find_lang_feature_issue(feature),
        GateIssue::Library(lib) => lib,
    };

N
Nick Cameron 已提交
771 772
    let mut err = if let Some(n) = issue {
        diag.struct_span_err(span, &format!("{} (see issue #{})", explain, n))
773
    } else {
N
Nick Cameron 已提交
774 775
        diag.struct_span_err(span, explain)
    };
776 777

    // #23973: do not suggest `#![feature(...)]` if we are in beta/stable
N
Nick Cameron 已提交
778 779 780 781
    if option_env!("CFG_DISABLE_UNSTABLE_FEATURES").is_some() {
        err.emit();
        return;
    }
782 783 784
    err.help(&format!("add #![feature({})] to the \
                       crate attributes to enable",
                      feature));
N
Nick Cameron 已提交
785
    err.emit();
786 787
}

L
Leo Testard 已提交
788 789 790
const EXPLAIN_BOX_SYNTAX: &'static str =
    "box expression syntax is experimental; you can call `Box::new` instead.";

J
Jeffrey Seyfried 已提交
791
pub const EXPLAIN_STMT_ATTR_SYNTAX: &'static str =
L
Leo Testard 已提交
792 793
    "attributes on non-item statements and expressions are experimental.";

794 795 796
pub const EXPLAIN_ASM: &'static str =
    "inline assembly is not stable enough for use and is subject to change";

797 798 799 800 801 802 803 804
pub const EXPLAIN_LOG_SYNTAX: &'static str =
    "`log_syntax!` is not stable enough for use and is subject to change";

pub const EXPLAIN_CONCAT_IDENTS: &'static str =
    "`concat_idents` is not stable enough for use and is subject to change";

pub const EXPLAIN_TRACE_MACROS: &'static str =
    "`trace_macros` is not stable enough for use and is subject to change";
805 806
pub const EXPLAIN_ALLOW_INTERNAL_UNSTABLE: &'static str =
    "allow_internal_unstable side-steps feature gating and stability checks";
807

808 809 810
pub const EXPLAIN_CUSTOM_DERIVE: &'static str =
    "`#[derive]` for custom traits is not stable enough for use and is subject to change";

L
Leo Testard 已提交
811 812
pub const EXPLAIN_DERIVE_UNDERSCORE: &'static str =
    "attributes of the form `#[derive_*]` are reserved for the compiler";
813

L
Leo Testard 已提交
814 815
pub const EXPLAIN_PLACEMENT_IN: &'static str =
    "placement-in expression syntax is experimental and subject to change.";
C
Corey Richardson 已提交
816 817

struct PostExpansionVisitor<'a> {
N
Nick Cameron 已提交
818
    context: &'a Context<'a>,
C
Corey Richardson 已提交
819 820
}

821 822 823 824 825
macro_rules! gate_feature_post {
    ($cx: expr, $feature: ident, $span: expr, $explain: expr) => {{
        let (cx, span) = ($cx, $span);
        if !cx.context.cm.span_allows_unstable(span) {
            gate_feature!(cx.context, $feature, span, $explain)
C
Corey Richardson 已提交
826
        }
827
    }}
C
Corey Richardson 已提交
828 829
}

830 831 832
impl<'a> PostExpansionVisitor<'a> {
    fn check_abi(&self, abi: Abi, span: Span) {
        match abi {
833
            Abi::RustIntrinsic => {
834
                gate_feature_post!(&self, intrinsics, span,
835 836
                                   "intrinsics are subject to change");
            },
837 838
            Abi::PlatformIntrinsic => {
                gate_feature_post!(&self, platform_intrinsics, span,
839
                                   "platform intrinsics are experimental and possibly buggy");
840 841 842
            },
            Abi::Vectorcall => {
                gate_feature_post!(&self, abi_vectorcall, span,
843 844
                                   "vectorcall is experimental and subject to change");
            },
845 846 847
            Abi::RustCall => {
                gate_feature_post!(&self, unboxed_closures, span,
                                   "rust-call ABI is subject to change");
848 849 850 851 852
            },
            Abi::SysV64 => {
                gate_feature_post!(&self, abi_sysv64, span,
                                   "sysv64 ABI is experimental and subject to change");
            },
853 854 855 856 857
            _ => {}
        }
    }
}

858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873
fn contains_novel_literal(item: &ast::MetaItem) -> bool {
    use ast::MetaItemKind::*;
    use ast::NestedMetaItemKind::*;

    match item.node {
        Word(..) => false,
        NameValue(_, ref lit) => !lit.node.is_str(),
        List(_, ref list) => list.iter().any(|li| {
            match li.node {
                MetaItem(ref mi) => contains_novel_literal(&**mi),
                Literal(_) => true,
            }
        }),
    }
}

874
impl<'a> Visitor for PostExpansionVisitor<'a> {
875 876
    fn visit_attribute(&mut self, attr: &ast::Attribute) {
        if !self.context.cm.span_allows_unstable(attr.span) {
877
            // check for gated attributes
878
            self.context.check_attribute(attr, false);
879
        }
880 881 882 883 884 885

        if contains_novel_literal(&*(attr.node.value)) {
            gate_feature_post!(&self, attr_literals, attr.span,
                               "non-string literals in attributes, or string \
                               literals in top-level positions, are experimental");
        }
886 887
    }

888
    fn visit_name(&mut self, sp: Span, name: ast::Name) {
889
        if !name.as_str().is_ascii() {
890 891
            gate_feature_post!(&self, non_ascii_idents, sp,
                               "non-ascii idents are not fully supported.");
892 893 894
        }
    }

895
    fn visit_item(&mut self, i: &ast::Item) {
896
        match i.node {
897
            ast::ItemKind::ExternCrate(_) => {
898
                if attr::contains_name(&i.attrs[..], "macro_reexport") {
899 900 901
                    gate_feature_post!(&self, macro_reexport, i.span,
                                       "macros reexports are experimental \
                                        and possibly buggy");
902 903 904
                }
            }

905
            ast::ItemKind::ForeignMod(ref foreign_module) => {
906
                if attr::contains_name(&i.attrs[..], "link_args") {
907
                    gate_feature_post!(&self, link_args, i.span,
908 909 910 911
                                      "the `link_args` attribute is not portable \
                                       across platforms, it is recommended to \
                                       use `#[link(name = \"foo\")]` instead")
                }
912
                self.check_abi(foreign_module.abi, i.span);
913 914
            }

915
            ast::ItemKind::Fn(..) => {
916
                if attr::contains_name(&i.attrs[..], "plugin_registrar") {
917 918
                    gate_feature_post!(&self, plugin_registrar, i.span,
                                       "compiler plugins are experimental and possibly buggy");
919
                }
920
                if attr::contains_name(&i.attrs[..], "start") {
921
                    gate_feature_post!(&self, start, i.span,
922 923 924 925
                                      "a #[start] function is an experimental \
                                       feature whose signature may change \
                                       over time");
                }
926
                if attr::contains_name(&i.attrs[..], "main") {
927 928 929 930
                    gate_feature_post!(&self, main, i.span,
                                       "declaration of a nonstandard #[main] \
                                        function may change over time, for now \
                                        a top-level `fn main()` is required");
931
                }
932 933
            }

934
            ast::ItemKind::Struct(..) => {
935
                if attr::contains_name(&i.attrs[..], "simd") {
936 937
                    gate_feature_post!(&self, simd, i.span,
                                       "SIMD types are experimental and possibly buggy");
938 939 940 941 942 943 944
                    self.context.span_handler.span_warn(i.span,
                                                        "the `#[simd]` attribute is deprecated, \
                                                         use `#[repr(simd)]` instead");
                }
                for attr in &i.attrs {
                    if attr.name() == "repr" {
                        for item in attr.meta_item_list().unwrap_or(&[]) {
945
                            if item.check_name("simd") {
946 947 948
                                gate_feature_post!(&self, repr_simd, i.span,
                                                   "SIMD types are experimental \
                                                    and possibly buggy");
949 950 951 952

                            }
                        }
                    }
953
                }
D
David Manescu 已提交
954 955
            }

956
            ast::ItemKind::DefaultImpl(..) => {
957 958 959 960
                gate_feature_post!(&self, optin_builtin_traits,
                                   i.span,
                                   "default trait implementations are experimental \
                                    and possibly buggy");
F
Flavio Percoco 已提交
961 962
            }

963
            ast::ItemKind::Impl(_, polarity, _, _, _, _) => {
964 965
                match polarity {
                    ast::ImplPolarity::Negative => {
966 967 968 969
                        gate_feature_post!(&self, optin_builtin_traits,
                                           i.span,
                                           "negative trait bounds are not yet fully implemented; \
                                            use marker types for now");
970 971 972
                    },
                    _ => {}
                }
973 974
            }

975 976 977
            _ => {}
        }

978
        visit::walk_item(self, i);
979
    }
980

981
    fn visit_foreign_item(&mut self, i: &ast::ForeignItem) {
982
        let links_to_llvm = match attr::first_attr_value_str_by_name(&i.attrs,
N
fallout  
Nick Cameron 已提交
983
                                                                     "link_name") {
G
GuillaumeGomez 已提交
984
            Some(val) => val.starts_with("llvm."),
985 986 987
            _ => false
        };
        if links_to_llvm {
988
            gate_feature_post!(&self, link_llvm_intrinsics, i.span,
989 990 991
                              "linking to LLVM intrinsics is experimental");
        }

992
        visit::walk_foreign_item(self, i)
993 994
    }

995 996 997 998 999
    fn visit_ty(&mut self, ty: &ast::Ty) {
        match ty.node {
            ast::TyKind::BareFn(ref bare_fn_ty) => {
                self.check_abi(bare_fn_ty.abi, ty.span);
            }
1000 1001 1002 1003
            ast::TyKind::ImplTrait(..) => {
                gate_feature_post!(&self, conservative_impl_trait, ty.span,
                                   "`impl Trait` is experimental");
            }
A
Andrew Cann 已提交
1004 1005
            ast::TyKind::Never => {
                gate_feature_post!(&self, never_type, ty.span,
1006 1007
                                   "The `!` type is experimental");
            },
1008 1009 1010 1011 1012
            _ => {}
        }
        visit::walk_ty(self, ty)
    }

1013 1014 1015
    fn visit_fn_ret_ty(&mut self, ret_ty: &ast::FunctionRetTy) {
        if let ast::FunctionRetTy::Ty(ref output_ty) = *ret_ty {
            match output_ty.node {
A
Andrew Cann 已提交
1016
                ast::TyKind::Never => return,
1017 1018
                _ => (),
            };
A
Andrew Cann 已提交
1019
            self.visit_ty(output_ty)
1020 1021 1022
        }
    }

1023
    fn visit_expr(&mut self, e: &ast::Expr) {
1024
        match e.node {
1025
            ast::ExprKind::Box(_) => {
1026
                gate_feature_post!(&self, box_syntax, e.span, EXPLAIN_BOX_SYNTAX);
1027
            }
1028
            ast::ExprKind::Type(..) => {
1029
                gate_feature_post!(&self, type_ascription, e.span,
1030 1031
                                  "type ascription is experimental");
            }
1032
            ast::ExprKind::Range(_, _, ast::RangeLimits::Closed) => {
1033
                gate_feature_post!(&self, inclusive_range_syntax,
A
Alex Burka 已提交
1034 1035 1036
                                  e.span,
                                  "inclusive range syntax is experimental");
            }
J
Jorge Aparicio 已提交
1037
            ast::ExprKind::Try(..) => {
1038
                gate_feature_post!(&self, question_mark, e.span, "the `?` operator is not stable");
J
Jorge Aparicio 已提交
1039
            }
1040 1041 1042
            ast::ExprKind::InPlace(..) => {
                gate_feature_post!(&self, placement_in_syntax, e.span, EXPLAIN_PLACEMENT_IN);
            }
1043 1044
            _ => {}
        }
1045
        visit::walk_expr(self, e);
1046
    }
1047

1048
    fn visit_pat(&mut self, pattern: &ast::Pat) {
1049
        match pattern.node {
1050
            PatKind::Vec(_, Some(_), ref last) if !last.is_empty() => {
1051
                gate_feature_post!(&self, advanced_slice_patterns,
1052 1053 1054
                                  pattern.span,
                                  "multiple-element slice matches anywhere \
                                   but at the end of a slice (e.g. \
1055
                                   `[0, ..xs, 0]`) are experimental")
1056
            }
1057
            PatKind::Vec(..) => {
1058
                gate_feature_post!(&self, slice_patterns,
1059 1060 1061
                                  pattern.span,
                                  "slice pattern syntax is experimental");
            }
1062
            PatKind::Box(..) => {
1063
                gate_feature_post!(&self, box_patterns,
1064
                                  pattern.span,
1065
                                  "box pattern syntax is experimental");
1066
            }
1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080
            PatKind::Tuple(_, ddpos)
                    if ddpos.is_some() => {
                gate_feature_post!(&self, dotdot_in_tuple_patterns,
                                  pattern.span,
                                  "`..` in tuple patterns is experimental");
            }
            PatKind::TupleStruct(_, ref fields, ddpos)
                    if ddpos.is_some() && !fields.is_empty() => {
                gate_feature_post!(&self, dotdot_in_tuple_patterns,
                                  pattern.span,
                                  "`..` in tuple struct patterns is experimental");
            }
            PatKind::TupleStruct(_, ref fields, ddpos)
                    if ddpos.is_none() && fields.is_empty() => {
1081 1082
                gate_feature_post!(&self, relaxed_adts, pattern.span,
                                   "empty tuple structs patterns are unstable");
1083
            }
1084 1085
            _ => {}
        }
1086
        visit::walk_pat(self, pattern)
1087 1088
    }

1089
    fn visit_fn(&mut self,
1090 1091 1092
                fn_kind: FnKind,
                fn_decl: &ast::FnDecl,
                block: &ast::Block,
1093
                span: Span,
1094
                _node_id: NodeId) {
N
Niko Matsakis 已提交
1095 1096
        // check for const fn declarations
        match fn_kind {
1097
            FnKind::ItemFn(_, _, _, Spanned { node: ast::Constness::Const, .. }, _, _) => {
1098
                gate_feature_post!(&self, const_fn, span, "const fn is unstable");
N
Niko Matsakis 已提交
1099 1100 1101 1102 1103 1104 1105 1106 1107
            }
            _ => {
                // stability of const fn methods are covered in
                // visit_trait_item and visit_impl_item below; this is
                // because default methods don't pass through this
                // point.
            }
        }

1108
        match fn_kind {
1109
            FnKind::ItemFn(_, _, _, _, abi, _) |
1110 1111 1112
            FnKind::Method(_, &ast::MethodSig { abi, .. }, _) => {
                self.check_abi(abi, span);
            }
1113 1114
            _ => {}
        }
1115
        visit::walk_fn(self, fn_kind, fn_decl, block, span);
1116
    }
1117

1118
    fn visit_trait_item(&mut self, ti: &ast::TraitItem) {
1119
        match ti.node {
1120
            ast::TraitItemKind::Const(..) => {
1121
                gate_feature_post!(&self, associated_consts,
1122 1123 1124
                                  ti.span,
                                  "associated constants are experimental")
            }
1125 1126 1127 1128
            ast::TraitItemKind::Method(ref sig, ref block) => {
                if block.is_none() {
                    self.check_abi(sig.abi, ti.span);
                }
1129
                if sig.constness.node == ast::Constness::Const {
1130
                    gate_feature_post!(&self, const_fn, ti.span, "const fn is unstable");
N
Niko Matsakis 已提交
1131 1132
                }
            }
1133
            ast::TraitItemKind::Type(_, Some(_)) => {
1134
                gate_feature_post!(&self, associated_type_defaults, ti.span,
1135 1136
                                  "associated type defaults are unstable");
            }
1137 1138 1139 1140 1141
            _ => {}
        }
        visit::walk_trait_item(self, ti);
    }

1142
    fn visit_impl_item(&mut self, ii: &ast::ImplItem) {
A
Aaron Turon 已提交
1143
        if ii.defaultness == ast::Defaultness::Default {
1144
            gate_feature_post!(&self, specialization,
A
Aaron Turon 已提交
1145 1146 1147 1148
                              ii.span,
                              "specialization is unstable");
        }

1149
        match ii.node {
1150
            ast::ImplItemKind::Const(..) => {
1151
                gate_feature_post!(&self, associated_consts,
1152 1153 1154
                                  ii.span,
                                  "associated constants are experimental")
            }
1155
            ast::ImplItemKind::Method(ref sig, _) => {
1156
                if sig.constness.node == ast::Constness::Const {
1157
                    gate_feature_post!(&self, const_fn, ii.span, "const fn is unstable");
N
Niko Matsakis 已提交
1158 1159
                }
            }
1160 1161 1162 1163
            _ => {}
        }
        visit::walk_impl_item(self, ii);
    }
1164

1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177
    fn visit_variant_data(&mut self, vdata: &ast::VariantData, _: ast::Ident,
                          _: &ast::Generics, _: NodeId, span: Span) {
        if vdata.fields().is_empty() {
            if vdata.is_tuple() {
                gate_feature_post!(&self, relaxed_adts, span,
                                   "empty tuple structs and enum variants are unstable, \
                                    use unit structs and enum variants instead");
            }
        }

        visit::walk_struct_def(self, vdata)
    }

1178
    fn visit_vis(&mut self, vis: &ast::Visibility) {
1179 1180
        let span = match *vis {
            ast::Visibility::Crate(span) => span,
1181
            ast::Visibility::Restricted { ref path, .. } => path.span,
1182 1183
            _ => return,
        };
1184
        gate_feature_post!(&self, pub_restricted, span, "`pub(restricted)` syntax is experimental");
1185 1186

        visit::walk_vis(self, vis)
1187
    }
1188 1189
}

J
Jeffrey Seyfried 已提交
1190
pub fn get_features(span_handler: &Handler, krate_attrs: &[ast::Attribute]) -> Features {
1191
    let mut features = Features::new();
N
Nick Cameron 已提交
1192

J
Jeffrey Seyfried 已提交
1193
    for attr in krate_attrs {
S
Steven Fackler 已提交
1194
        if !attr.check_name("feature") {
1195 1196
            continue
        }
1197 1198 1199

        match attr.meta_item_list() {
            None => {
G
ggomez 已提交
1200 1201
                span_err!(span_handler, attr.span, E0555,
                          "malformed feature attribute, expected #![feature(...)]");
1202 1203
            }
            Some(list) => {
1204
                for mi in list {
1205 1206 1207 1208 1209 1210 1211 1212
                    let name = if let Some(word) = mi.word() {
                        word.name()
                    } else {
                        span_err!(span_handler, mi.span, E0556,
                                  "malformed feature, expected just one word");
                        continue
                    };

1213 1214 1215 1216 1217 1218
                    if let Some(&(_, _, _, setter)) = ACTIVE_FEATURES.iter()
                        .find(|& &(n, _, _, _)| name == n) {
                        *(setter(&mut features)) = true;
                    }
                    else if let Some(&(_, _, _)) = REMOVED_FEATURES.iter()
                        .find(|& &(n, _, _)| name == n) {
G
ggomez 已提交
1219
                        span_err!(span_handler, mi.span, E0557, "feature has been removed");
1220 1221 1222
                    }
                    else if let Some(&(_, _, _)) = ACCEPTED_FEATURES.iter()
                        .find(|& &(n, _, _)| name == n) {
1223
                        features.declared_stable_lang_features.push((name, mi.span));
1224 1225
                    } else {
                        features.declared_lib_features.push((name, mi.span));
1226 1227 1228 1229 1230 1231
                    }
                }
            }
        }
    }

L
Leo Testard 已提交
1232
    features
C
Corey Richardson 已提交
1233 1234
}

J
Jeffrey Seyfried 已提交
1235 1236 1237
pub fn check_crate(krate: &ast::Crate,
                   sess: &ParseSess,
                   features: &Features,
1238
                   plugin_attributes: &[(String, AttributeType)],
J
Jeffrey Seyfried 已提交
1239 1240 1241 1242 1243 1244 1245 1246 1247
                   unstable: UnstableFeatures) {
    maybe_stage_features(&sess.span_diagnostic, krate, unstable);
    let ctx = Context {
        features: features,
        span_handler: &sess.span_diagnostic,
        cm: sess.codemap(),
        plugin_attributes: plugin_attributes,
    };
    visit::walk_crate(&mut PostExpansionVisitor { context: &ctx }, krate);
C
Corey Richardson 已提交
1248
}
1249

1250
#[derive(Clone, Copy, PartialEq, Eq, Hash)]
1251 1252 1253 1254 1255 1256 1257 1258 1259
pub enum UnstableFeatures {
    /// Hard errors for unstable features are active, as on
    /// beta/stable channels.
    Disallow,
    /// Allow features to me activated, as on nightly.
    Allow,
    /// Errors are bypassed for bootstrapping. This is required any time
    /// during the build that feature-related lints are set to warn or above
    /// because the build turns on warnings-as-errors and uses lots of unstable
1260
    /// features. As a result, this is always required for building Rust itself.
1261 1262 1263
    Cheat
}

1264
fn maybe_stage_features(span_handler: &Handler, krate: &ast::Crate,
1265 1266 1267 1268 1269 1270 1271 1272 1273 1274
                        unstable: UnstableFeatures) {
    let allow_features = match unstable {
        UnstableFeatures::Allow => true,
        UnstableFeatures::Disallow => false,
        UnstableFeatures::Cheat => true
    };
    if !allow_features {
        for attr in &krate.attrs {
            if attr.check_name("feature") {
                let release_channel = option_env!("CFG_RELEASE_CHANNEL").unwrap_or("(unknown)");
G
ggomez 已提交
1275
                span_err!(span_handler, attr.span, E0554,
G
ggomez 已提交
1276 1277
                          "#[feature] may not be used on the {} release channel",
                          release_channel);
1278 1279 1280 1281
            }
        }
    }
}