feature_gate.rs 63.8 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

//! Feature gating
//!
L
Luke Gallagher 已提交
13
//! This module implements the gating necessary for preventing certain compiler
14 15 16 17 18
//! features from being used by default. This module will crawl a pre-expanded
//! AST to ensure that there are no features which are used that are not
//! enabled.
//!
//! Features are enabled in programs via the crate-level attributes of
19
//! `#![feature(...)]` with a comma-separated list of features.
B
Brian Anderson 已提交
20 21 22 23
//!
//! For the purpose of future feature-tracking, once code for detection of feature
//! gate usage is added, *do not remove it again* even once the feature
//! becomes stable.
G
GuillaumeGomez 已提交
24

25
use self::AttributeType::*;
26
use self::AttributeGate::*;
27

N
Niko Matsakis 已提交
28
use abi::Abi;
29
use ast::{self, NodeId, PatKind};
30
use attr;
31
use codemap::{CodeMap, Spanned};
32
use syntax_pos::Span;
33
use errors::{DiagnosticBuilder, Handler, FatalError};
34
use visit::{self, FnKind, Visitor};
J
Jeffrey Seyfried 已提交
35
use parse::ParseSess;
36
use symbol::Symbol;
37

38
use std::ascii::AsciiExt;
T
Tim Neumann 已提交
39
use std::env;
40

41 42 43 44 45 46 47 48
macro_rules! setter {
    ($field: ident) => {{
        fn f(features: &mut Features) -> &mut bool {
            &mut features.$field
        }
        f as fn(&mut Features) -> &mut bool
    }}
}
49

50
macro_rules! declare_features {
51
    ($((active, $feature: ident, $ver: expr, $issue: expr),)+) => {
52 53 54 55 56 57 58 59 60
        /// Represents active features that are currently being implemented or
        /// currently being considered for addition/removal.
        const ACTIVE_FEATURES: &'static [(&'static str, &'static str,
                                          Option<u32>, fn(&mut Features) -> &mut bool)] = &[
            $((stringify!($feature), $ver, $issue, setter!($feature))),+
        ];

        /// A set of features to be used by later passes.
        pub struct Features {
61
            /// #![feature] attrs for stable language features, for error reporting
62
            pub declared_stable_lang_features: Vec<(Symbol, Span)>,
63
            /// #![feature] attrs for non-language (library) features
64
            pub declared_lib_features: Vec<(Symbol, Span)>,
65 66
            $(pub $feature: bool),+
        }
67

68 69 70 71 72 73 74 75 76 77 78
        impl Features {
            pub fn new() -> Features {
                Features {
                    declared_stable_lang_features: Vec::new(),
                    declared_lib_features: Vec::new(),
                    $($feature: false),+
                }
            }
        }
    };

79
    ($((removed, $feature: ident, $ver: expr, $issue: expr),)+) => {
80 81 82 83 84 85
        /// Represents features which has since been removed (it was once Active)
        const REMOVED_FEATURES: &'static [(&'static str, &'static str, Option<u32>)] = &[
            $((stringify!($feature), $ver, $issue)),+
        ];
    };

86
    ($((accepted, $feature: ident, $ver: expr, $issue: expr),)+) => {
87 88 89 90 91
        /// Those language feature has since been Accepted (it was once Active)
        const ACCEPTED_FEATURES: &'static [(&'static str, &'static str, Option<u32>)] = &[
            $((stringify!($feature), $ver, $issue)),+
        ];
    }
92 93
}

B
Brian Anderson 已提交
94 95 96 97 98
// If you change this list without updating src/doc/reference.md, @cmr will be sad
// Don't ever remove anything from this list; set them to 'Removed'.
// The version numbers here correspond to the version in which the current status
// was set. This is most important for knowing when a particular feature became
// stable (active).
99 100 101 102 103 104 105 106 107 108 109 110
// NB: The featureck.py script parses this information directly out of the source
// so take care when modifying it.

declare_features! (
    (active, asm, "1.0.0", Some(29722)),
    (active, concat_idents, "1.0.0", Some(29599)),
    (active, link_args, "1.0.0", Some(29596)),
    (active, log_syntax, "1.0.0", Some(29598)),
    (active, non_ascii_idents, "1.0.0", Some(28979)),
    (active, plugin_registrar, "1.0.0", Some(29597)),
    (active, thread_local, "1.0.0", Some(29594)),
    (active, trace_macros, "1.0.0", Some(29598)),
A
Aaron Turon 已提交
111 112

    // rustc internal, for now:
113 114
    (active, intrinsics, "1.0.0", None),
    (active, lang_items, "1.0.0", None),
115

116 117 118 119
    (active, link_llvm_intrinsics, "1.0.0", Some(29602)),
    (active, linkage, "1.0.0", Some(29603)),
    (active, quote, "1.0.0", Some(29601)),
    (active, simd, "1.0.0", Some(27731)),
120 121


A
Aaron Turon 已提交
122
    // rustc internal
123 124 125 126 127 128
    (active, rustc_diagnostic_macros, "1.0.0", None),
    (active, advanced_slice_patterns, "1.0.0", Some(23121)),
    (active, box_syntax, "1.0.0", Some(27779)),
    (active, placement_in_syntax, "1.0.0", Some(27779)),
    (active, reflect, "1.0.0", Some(27749)),
    (active, unboxed_closures, "1.0.0", Some(29625)),
A
Aaron Turon 已提交
129

130 131 132 133 134 135 136 137 138
    (active, allocator, "1.0.0", Some(27389)),
    (active, fundamental, "1.0.0", Some(29635)),
    (active, main, "1.0.0", Some(29634)),
    (active, needs_allocator, "1.4.0", Some(27389)),
    (active, on_unimplemented, "1.0.0", Some(29628)),
    (active, plugin, "1.0.0", Some(29597)),
    (active, simd_ffi, "1.0.0", Some(27731)),
    (active, start, "1.0.0", Some(29633)),
    (active, structural_match, "1.8.0", Some(31434)),
139 140
    (active, panic_runtime, "1.10.0", Some(32837)),
    (active, needs_panic_runtime, "1.10.0", Some(32837)),
141

142
    // OIBIT specific features
143
    (active, optin_builtin_traits, "1.0.0", Some(13231)),
144

J
Joseph Crail 已提交
145
    // macro reexport needs more discussion and stabilization
146
    (active, macro_reexport, "1.0.0", Some(29638)),
147 148

    // Allows use of #[staged_api]
A
Aaron Turon 已提交
149
    // rustc internal
150
    (active, staged_api, "1.0.0", None),
151

A
Alex Crichton 已提交
152
    // Allows using #![no_core]
153
    (active, no_core, "1.3.0", Some(29639)),
A
Alex Crichton 已提交
154

155
    // Allows using `box` in patterns; RFC 469
156
    (active, box_patterns, "1.0.0", Some(29641)),
157

158 159
    // Allows using the unsafe_destructor_blind_to_params attribute;
    // RFC 1238
160
    (active, dropck_parametricity, "1.3.0", Some(28498)),
161

162 163 164
    // Allows using the may_dangle attribute; RFC 1327
    (active, dropck_eyepatch, "1.10.0", Some(34761)),

165
    // Allows the use of custom attributes; RFC 572
166
    (active, custom_attribute, "1.0.0", Some(29642)),
M
Manish Goregaokar 已提交
167

168 169
    // Allows the use of #[derive(Anything)] as sugar for
    // #[derive_Anything].
170
    (active, custom_derive, "1.0.0", Some(29644)),
171

M
Manish Goregaokar 已提交
172
    // Allows the use of rustc_* attributes; RFC 572
173
    (active, rustc_attrs, "1.0.0", Some(29642)),
H
Huon Wilson 已提交
174

175 176 177 178
    // Allows the use of #[allow_internal_unstable]. This is an
    // attribute on macro_rules! and can't use the attribute handling
    // below (it has to be checked before expansion possibly makes
    // macros disappear).
A
Aaron Turon 已提交
179 180
    //
    // rustc internal
181
    (active, allow_internal_unstable, "1.0.0", None),
182 183

    // #23121. Array patterns have some hazards yet.
184
    (active, slice_patterns, "1.0.0", Some(23121)),
185 186 187

    // Allows the definition of associated constants in `trait` or `impl`
    // blocks.
188
    (active, associated_consts, "1.0.0", Some(29646)),
N
Niko Matsakis 已提交
189 190

    // Allows the definition of `const fn` functions.
191
    (active, const_fn, "1.2.0", Some(24111)),
192

193
    // Allows indexing into constant arrays.
194
    (active, const_indexing, "1.4.0", Some(29947)),
195

196
    // Allows using #[prelude_import] on glob `use` items.
A
Aaron Turon 已提交
197 198
    //
    // rustc internal
199
    (active, prelude_import, "1.2.0", None),
200 201

    // Allows the definition recursive static items.
202
    (active, static_recursion, "1.3.0", Some(29719)),
B
Brian Anderson 已提交
203 204

    // Allows default type parameters to influence type inference.
205
    (active, default_type_parameter_fallback, "1.3.0", Some(27336)),
206 207

    // Allows associated type defaults
208
    (active, associated_type_defaults, "1.2.0", Some(29661)),
J
Jared Roesch 已提交
209

210
    // allow `repr(simd)`, and importing the various simd intrinsics
211
    (active, repr_simd, "1.4.0", Some(27731)),
212 213

    // Allows cfg(target_feature = "...").
214
    (active, cfg_target_feature, "1.4.0", Some(29717)),
215 216

    // allow `extern "platform-intrinsic" { ... }`
217
    (active, platform_intrinsics, "1.4.0", Some(27731)),
218 219

    // allow `#[unwind]`
A
Aaron Turon 已提交
220
    // rust runtime internal
221
    (active, unwind_attributes, "1.4.0", None),
V
Vadim Petrochenkov 已提交
222

T
Ticki 已提交
223
    // allow the use of `#[naked]` on functions.
224
    (active, naked_functions, "1.9.0", Some(32408)),
225 226

    // allow `#[no_debug]`
227
    (active, no_debug, "1.5.0", Some(29721)),
228 229

    // allow `#[omit_gdb_pretty_printer_section]`
A
Aaron Turon 已提交
230
    // rustc internal.
231
    (active, omit_gdb_pretty_printer_section, "1.5.0", None),
232 233

    // Allows cfg(target_vendor = "...").
234
    (active, cfg_target_vendor, "1.5.0", Some(29718)),
235 236

    // Allow attributes on expressions and non-item statements
237
    (active, stmt_expr_attributes, "1.6.0", Some(15701)),
238 239

    // allow using type ascription in expressions
240
    (active, type_ascription, "1.6.0", Some(23416)),
241 242

    // Allows cfg(target_thread_local)
243
    (active, cfg_target_thread_local, "1.7.0", Some(29594)),
244 245

    // rustc internal
246
    (active, abi_vectorcall, "1.7.0", None),
A
Alex Burka 已提交
247 248

    // a...b and ...b
249
    (active, inclusive_range_syntax, "1.7.0", Some(28237)),
J
Jorge Aparicio 已提交
250

A
Aaron Turon 已提交
251
    // impl specialization (RFC 1210)
252
    (active, specialization, "1.7.0", Some(31844)),
253 254

    // pub(restricted) visibilities (RFC 1422)
255 256
    (active, pub_restricted, "1.9.0", Some(32409)),

257 258 259 260
    // Allow Drop types in statics/const functions (RFC 1440)
    (active, drop_types_in_const, "1.9.0", Some(33156)),

    // Allows cfg(target_has_atomic = "...").
261 262
    (active, cfg_target_has_atomic, "1.9.0", Some(32976)),

263
    // Allows `impl Trait` in function return types.
264 265 266
    (active, conservative_impl_trait, "1.12.0", Some(34511)),

    // Permits numeric fields in struct expressions and patterns.
267 268 269
    (active, relaxed_adts, "1.12.0", Some(35626)),

    // The `!` type
270 271 272
    (active, never_type, "1.13.0", Some(35121)),

    // Allows all literals in attribute lists and values of key-value pairs.
273 274 275 276
    (active, attr_literals, "1.13.0", Some(34981)),

    // Allows the sysV64 ABI to be specified on all platforms
    // instead of just the platforms on which it is the C ABI
277 278
    (active, abi_sysv64, "1.13.0", Some(36167)),

279 280
    // Allows untagged unions `union U { ... }`
    (active, untagged_unions, "1.13.0", Some(32836)),
A
Andre Bogus 已提交
281 282 283

    // elide `'static` lifetimes in `static`s and `const`s
    (active, static_in_const, "1.13.0", Some(35897)),
284 285 286 287

    // Used to identify the `compiler_builtins` crate
    // rustc internal
    (active, compiler_builtins, "1.13.0", None),
288 289 290

    // Allows attributes on lifetime/type formal parameters in generics (RFC 1327)
    (active, generic_param_attrs, "1.11.0", Some(34761)),
291 292 293

    // Allows field shorthands (`x` meaning `x: x`) in struct literal expressions.
    (active, field_init_shorthand, "1.14.0", Some(37340)),
294 295 296

    // The #![windows_subsystem] attribute
    (active, windows_subsystem, "1.14.0", Some(37499)),
297

298 299
    // Allows using `Self` and associated types in struct expressions and patterns.
    (active, more_struct_aliases, "1.14.0", Some(37544)),
300

G
Guillaume Gomez 已提交
301

302 303
    // Allows #[link(..., cfg(..))]
    (active, link_cfg, "1.14.0", Some(37406)),
304 305

    (active, use_extern_macros, "1.15.0", Some(35896)),
306 307 308

    // Allows `break {expr}` with a value inside `loop`s.
    (active, loop_break_value, "1.14.0", Some(37339)),
309 310 311

    // Allows #[target_feature(...)]
    (active, target_feature, "1.15.0", None),
G
Guillaume Gomez 已提交
312

J
Jorge Aparicio 已提交
313 314
    // `extern "ptx-*" fn()`
    (active, abi_ptx, "1.15.0", None),
315 316

    // The `i128` type
E
est31 已提交
317
    (active, i128_type, "1.16.0", Some(35118)),
318 319 320

    // The `unadjusted` ABI. Perma unstable.
    (active, abi_unadjusted, "1.16.0", None),
321

322 323 324
    // Macros 1.1
    (active, proc_macro, "1.16.0", Some(35900)),

325 326
    // Allows attributes on struct literal fields.
    (active, struct_field_attributes, "1.16.0", Some(38814)),
327 328 329

    // `extern "msp430-interrupt" fn()`
    (active, abi_msp430_interrupt, "1.16.0", Some(38487)),
330 331 332 333 334 335 336 337 338 339 340 341
);

declare_features! (
    (removed, import_shadowing, "1.0.0", None),
    (removed, managed_boxes, "1.0.0", None),
    // Allows use of unary negate on unsigned integers, e.g. -e for e: u8
    (removed, negate_unsigned, "1.0.0", Some(29645)),
    // A way to temporarily opt out of opt in copy. This will *never* be accepted.
    (removed, opt_out_copy, "1.0.0", None),
    (removed, quad_precision_float, "1.0.0", None),
    (removed, struct_inherit, "1.0.0", None),
    (removed, test_removed_feature, "1.0.0", None),
342
    (removed, visible_private_types, "1.0.0", None),
343
    (removed, unsafe_no_drop_flag, "1.0.0", None),
344 345 346
    // Allows using items which are missing stability attributes
    // rustc internal
    (removed, unmarked_api, "1.0.0", None),
347
    (removed, pushpop_unsafe, "1.2.0", None),
348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363
);

declare_features! (
    (accepted, associated_types, "1.0.0", None),
    // allow overloading augmented assignment operations like `a += b`
    (accepted, augmented_assignments, "1.8.0", Some(28235)),
    // allow empty structs and enum variants with braces
    (accepted, braced_empty_structs, "1.8.0", Some(29720)),
    (accepted, default_type_params, "1.0.0", None),
    (accepted, globs, "1.0.0", None),
    (accepted, if_let, "1.0.0", None),
    // A temporary feature gate used to enable parser extensions needed
    // to bootstrap fix for #5723.
    (accepted, issue_5723_bootstrap, "1.0.0", None),
    (accepted, macro_rules, "1.0.0", None),
    // Allows using #![no_std]
364
    (accepted, no_std, "1.6.0", None),
365 366 367 368 369 370
    (accepted, slicing_syntax, "1.0.0", None),
    (accepted, struct_variant, "1.0.0", None),
    // These are used to test this portion of the compiler, they don't actually
    // mean anything
    (accepted, test_accepted_feature, "1.0.0", None),
    (accepted, tuple_indexing, "1.0.0", None),
D
Daniele Baracchi 已提交
371 372
    // Allows macros to appear in the type position.
    (accepted, type_macros, "1.13.0", Some(27245)),
373 374
    (accepted, while_let, "1.0.0", None),
    // Allows `#[deprecated]` attribute
375
    (accepted, deprecated, "1.9.0", Some(29935)),
N
Nick Cameron 已提交
376
    // `expr?`
377
    (accepted, question_mark, "1.13.0", Some(31436)),
378 379
    // Allows `..` in tuple (struct) patterns
    (accepted, dotdot_in_tuple_patterns, "1.14.0", Some(33627)),
J
Jeffrey Seyfried 已提交
380
    (accepted, item_like_imports, "1.14.0", Some(35120)),
381
);
382
// (changing above list without updating src/doc/reference.md makes @cmr sad)
383

384 385 386 387 388
#[derive(PartialEq, Copy, Clone, Debug)]
pub enum AttributeType {
    /// Normal, builtin attribute that is consumed
    /// by the compiler before the unused_attribute check
    Normal,
389

390 391 392 393
    /// Builtin attribute that may not be consumed by the compiler
    /// before the unused_attribute check. These attributes
    /// will be ignored by the unused_attribute lint
    Whitelisted,
394

395 396 397 398 399 400 401
    /// Builtin attribute that is only allowed at the crate level
    CrateLevel,
}

pub enum AttributeGate {
    /// Is gated by a given feature gate, reason
    /// and function to check if enabled
402
    Gated(Stability, &'static str, &'static str, fn(&Features) -> bool),
403 404 405 406 407

    /// Ungated attribute, can be used on all release channels
    Ungated,
}

N
Nick Cameron 已提交
408 409 410 411 412 413 414 415 416 417
impl AttributeGate {
    fn is_deprecated(&self) -> bool {
        match *self {
            Gated(Stability::Deprecated(_), ..) => true,
            _ => false,
        }
    }
}

#[derive(Copy, Clone, PartialEq, Eq, Debug)]
418 419
pub enum Stability {
    Unstable,
N
Nick Cameron 已提交
420 421
    // Argument is tracking issue link.
    Deprecated(&'static str),
422 423
}

424 425 426 427
// fn() is not Debug
impl ::std::fmt::Debug for AttributeGate {
    fn fmt(&self, fmt: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
        match *self {
N
Nick Cameron 已提交
428 429
            Gated(ref stab, ref name, ref expl, _) =>
                write!(fmt, "Gated({:?}, {}, {})", stab, name, expl),
430 431 432 433 434 435 436 437 438 439 440 441
            Ungated => write!(fmt, "Ungated")
        }
    }
}

macro_rules! cfg_fn {
    ($field: ident) => {{
        fn f(features: &Features) -> bool {
            features.$field
        }
        f as fn(&Features) -> bool
    }}
442 443
}

N
Nick Cameron 已提交
444
pub fn deprecated_attributes() -> Vec<&'static (&'static str, AttributeType, AttributeGate)> {
445
    BUILTIN_ATTRIBUTES.iter().filter(|a| a.2.is_deprecated()).collect()
N
Nick Cameron 已提交
446 447
}

448 449 450 451
pub fn is_builtin_attr(attr: &ast::Attribute) -> bool {
    BUILTIN_ATTRIBUTES.iter().any(|&(builtin_name, _, _)| attr.check_name(builtin_name))
}

452
// Attributes that have a special meaning to rustc or rustdoc
453
pub const BUILTIN_ATTRIBUTES: &'static [(&'static str, AttributeType, AttributeGate)] = &[
454 455
    // Normal attributes

456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485
    ("warn", Normal, Ungated),
    ("allow", Normal, Ungated),
    ("forbid", Normal, Ungated),
    ("deny", Normal, Ungated),

    ("macro_reexport", Normal, Ungated),
    ("macro_use", Normal, Ungated),
    ("macro_export", Normal, Ungated),
    ("plugin_registrar", Normal, Ungated),

    ("cfg", Normal, Ungated),
    ("cfg_attr", Normal, Ungated),
    ("main", Normal, Ungated),
    ("start", Normal, Ungated),
    ("test", Normal, Ungated),
    ("bench", Normal, Ungated),
    ("simd", Normal, Ungated),
    ("repr", Normal, Ungated),
    ("path", Normal, Ungated),
    ("abi", Normal, Ungated),
    ("automatically_derived", Normal, Ungated),
    ("no_mangle", Normal, Ungated),
    ("no_link", Normal, Ungated),
    ("derive", Normal, Ungated),
    ("should_panic", Normal, Ungated),
    ("ignore", Normal, Ungated),
    ("no_implicit_prelude", Normal, Ungated),
    ("reexport_test_harness_main", Normal, Ungated),
    ("link_args", Normal, Ungated),
    ("macro_escape", Normal, Ungated),
486

487
    // RFC #1445.
488 489
    ("structural_match", Whitelisted, Gated(Stability::Unstable,
                                            "structural_match",
490
                                            "the semantics of constant patterns is \
491 492
                                             not yet settled",
                                            cfg_fn!(structural_match))),
493

A
Alex Crichton 已提交
494
    // Not used any more, but we can't feature gate it
495 496
    ("no_stack_check", Normal, Ungated),

497 498
    ("plugin", CrateLevel, Gated(Stability::Unstable,
                                 "plugin",
499
                                 "compiler plugins are experimental \
500 501 502
                                  and possibly buggy",
                                 cfg_fn!(plugin))),

503
    ("no_std", CrateLevel, Ungated),
504 505
    ("no_core", CrateLevel, Gated(Stability::Unstable,
                                  "no_core",
506 507
                                  "no_core is experimental",
                                  cfg_fn!(no_core))),
508 509
    ("lang", Normal, Gated(Stability::Unstable,
                           "lang_items",
510 511
                           "language items are subject to change",
                           cfg_fn!(lang_items))),
512 513
    ("linkage", Whitelisted, Gated(Stability::Unstable,
                                   "linkage",
514
                                   "the `linkage` attribute is experimental \
515 516
                                    and not portable across platforms",
                                   cfg_fn!(linkage))),
517 518
    ("thread_local", Whitelisted, Gated(Stability::Unstable,
                                        "thread_local",
519 520 521
                                        "`#[thread_local]` is an experimental feature, and does \
                                         not currently handle destructors. There is no \
                                         corresponding `#[task_local]` mapping to the task \
522 523
                                         model",
                                        cfg_fn!(thread_local))),
524

525 526
    ("rustc_on_unimplemented", Normal, Gated(Stability::Unstable,
                                             "on_unimplemented",
527
                                             "the `#[rustc_on_unimplemented]` attribute \
528 529
                                              is an experimental feature",
                                             cfg_fn!(on_unimplemented))),
530 531
    ("allocator", Whitelisted, Gated(Stability::Unstable,
                                     "allocator",
532 533
                                     "the `#[allocator]` attribute is an experimental feature",
                                     cfg_fn!(allocator))),
534 535
    ("needs_allocator", Normal, Gated(Stability::Unstable,
                                      "needs_allocator",
536 537
                                      "the `#[needs_allocator]` \
                                       attribute is an experimental \
538 539
                                       feature",
                                      cfg_fn!(needs_allocator))),
540 541
    ("panic_runtime", Whitelisted, Gated(Stability::Unstable,
                                         "panic_runtime",
542 543 544
                                         "the `#[panic_runtime]` attribute is \
                                          an experimental feature",
                                         cfg_fn!(panic_runtime))),
545 546
    ("needs_panic_runtime", Whitelisted, Gated(Stability::Unstable,
                                               "needs_panic_runtime",
547 548 549 550
                                               "the `#[needs_panic_runtime]` \
                                                attribute is an experimental \
                                                feature",
                                               cfg_fn!(needs_panic_runtime))),
551 552
    ("rustc_variance", Normal, Gated(Stability::Unstable,
                                     "rustc_attrs",
553
                                     "the `#[rustc_variance]` attribute \
N
Niko Matsakis 已提交
554
                                      is just used for rustc unit tests \
555 556
                                      and will never be stable",
                                     cfg_fn!(rustc_attrs))),
557 558
    ("rustc_error", Whitelisted, Gated(Stability::Unstable,
                                       "rustc_attrs",
559
                                       "the `#[rustc_error]` attribute \
N
Niko Matsakis 已提交
560
                                        is just used for rustc unit tests \
561 562
                                        and will never be stable",
                                       cfg_fn!(rustc_attrs))),
563 564
    ("rustc_if_this_changed", Whitelisted, Gated(Stability::Unstable,
                                                 "rustc_attrs",
565 566 567 568
                                                 "the `#[rustc_if_this_changed]` attribute \
                                                  is just used for rustc unit tests \
                                                  and will never be stable",
                                                 cfg_fn!(rustc_attrs))),
569 570
    ("rustc_then_this_would_need", Whitelisted, Gated(Stability::Unstable,
                                                      "rustc_attrs",
571 572 573 574
                                                      "the `#[rustc_if_this_changed]` attribute \
                                                       is just used for rustc unit tests \
                                                       and will never be stable",
                                                      cfg_fn!(rustc_attrs))),
575 576
    ("rustc_dirty", Whitelisted, Gated(Stability::Unstable,
                                       "rustc_attrs",
577 578
                                       "the `#[rustc_dirty]` attribute \
                                        is just used for rustc unit tests \
579 580
                                        and will never be stable",
                                       cfg_fn!(rustc_attrs))),
581 582
    ("rustc_clean", Whitelisted, Gated(Stability::Unstable,
                                       "rustc_attrs",
583 584
                                       "the `#[rustc_clean]` attribute \
                                        is just used for rustc unit tests \
585 586
                                        and will never be stable",
                                       cfg_fn!(rustc_attrs))),
587 588
    ("rustc_metadata_dirty", Whitelisted, Gated(Stability::Unstable,
                                                "rustc_attrs",
589 590 591 592
                                                "the `#[rustc_metadata_dirty]` attribute \
                                                 is just used for rustc unit tests \
                                                 and will never be stable",
                                                 cfg_fn!(rustc_attrs))),
593 594
    ("rustc_metadata_clean", Whitelisted, Gated(Stability::Unstable,
                                                "rustc_attrs",
595 596 597 598
                                                "the `#[rustc_metadata_clean]` attribute \
                                                 is just used for rustc unit tests \
                                                 and will never be stable",
                                                 cfg_fn!(rustc_attrs))),
599 600
    ("rustc_partition_reused", Whitelisted, Gated(Stability::Unstable,
                                                  "rustc_attrs",
601 602 603 604
                                                  "this attribute \
                                                   is just used for rustc unit tests \
                                                   and will never be stable",
                                                  cfg_fn!(rustc_attrs))),
605 606
    ("rustc_partition_translated", Whitelisted, Gated(Stability::Unstable,
                                                      "rustc_attrs",
607 608 609 610
                                                      "this attribute \
                                                       is just used for rustc unit tests \
                                                       and will never be stable",
                                                      cfg_fn!(rustc_attrs))),
611 612
    ("rustc_symbol_name", Whitelisted, Gated(Stability::Unstable,
                                             "rustc_attrs",
613 614
                                             "internal rustc attributes will never be stable",
                                             cfg_fn!(rustc_attrs))),
615 616
    ("rustc_item_path", Whitelisted, Gated(Stability::Unstable,
                                           "rustc_attrs",
617 618
                                           "internal rustc attributes will never be stable",
                                           cfg_fn!(rustc_attrs))),
619 620
    ("rustc_move_fragments", Normal, Gated(Stability::Unstable,
                                           "rustc_attrs",
621
                                           "the `#[rustc_move_fragments]` attribute \
N
Niko Matsakis 已提交
622
                                            is just used for rustc unit tests \
623 624
                                            and will never be stable",
                                           cfg_fn!(rustc_attrs))),
625 626
    ("rustc_mir", Whitelisted, Gated(Stability::Unstable,
                                     "rustc_attrs",
627 628
                                     "the `#[rustc_mir]` attribute \
                                      is just used for rustc unit tests \
629 630
                                      and will never be stable",
                                     cfg_fn!(rustc_attrs))),
631 632
    ("rustc_inherit_overflow_checks", Whitelisted, Gated(Stability::Unstable,
                                                         "rustc_attrs",
633 634 635 636 637 638
                                                         "the `#[rustc_inherit_overflow_checks]` \
                                                          attribute is just used to control \
                                                          overflow checking behavior of several \
                                                          libcore functions that are inlined \
                                                          across crates and will never be stable",
                                                          cfg_fn!(rustc_attrs))),
639 640
    ("compiler_builtins", Whitelisted, Gated(Stability::Unstable,
                                             "compiler_builtins",
641 642 643 644 645
                                             "the `#[compiler_builtins]` attribute is used to \
                                              identify the `compiler_builtins` crate which \
                                              contains compiler-rt intrinsics and will never be \
                                              stable",
                                          cfg_fn!(compiler_builtins))),
646

647 648
    ("allow_internal_unstable", Normal, Gated(Stability::Unstable,
                                              "allow_internal_unstable",
649 650
                                              EXPLAIN_ALLOW_INTERNAL_UNSTABLE,
                                              cfg_fn!(allow_internal_unstable))),
651

652 653
    ("fundamental", Whitelisted, Gated(Stability::Unstable,
                                       "fundamental",
654
                                       "the `#[fundamental]` attribute \
655 656
                                        is an experimental feature",
                                       cfg_fn!(fundamental))),
657

658
    ("proc_macro_derive", Normal, Ungated),
659

660 661
    ("rustc_copy_clone_marker", Whitelisted, Gated(Stability::Unstable,
                                                   "rustc_attrs",
662 663 664
                                                   "internal implementation detail",
                                                   cfg_fn!(rustc_attrs))),

665
    // FIXME: #14408 whitelist docs since rustdoc looks at them
666
    ("doc", Whitelisted, Ungated),
667 668 669

    // FIXME: #14406 these are processed in trans, which happens after the
    // lint pass
670
    ("cold", Whitelisted, Ungated),
671 672
    ("naked", Whitelisted, Gated(Stability::Unstable,
                                 "naked_functions",
T
Ticki 已提交
673
                                 "the `#[naked]` attribute \
674
                                  is an experimental feature",
675
                                 cfg_fn!(naked_functions))),
676 677 678 679
    ("target_feature", Whitelisted, Gated(
        Stability::Unstable, "target_feature",
        "the `#[target_feature]` attribute is an experimental feature",
        cfg_fn!(target_feature))),
680 681 682 683 684 685 686
    ("export_name", Whitelisted, Ungated),
    ("inline", Whitelisted, Ungated),
    ("link", Whitelisted, Ungated),
    ("link_name", Whitelisted, Ungated),
    ("link_section", Whitelisted, Ungated),
    ("no_builtins", Whitelisted, Ungated),
    ("no_mangle", Whitelisted, Ungated),
N
Nick Cameron 已提交
687 688 689 690 691
    ("no_debug", Whitelisted, Gated(
        Stability::Deprecated("https://github.com/rust-lang/rust/issues/29721"),
        "no_debug",
        "the `#[no_debug]` attribute is an experimental feature",
        cfg_fn!(no_debug))),
692 693
    ("omit_gdb_pretty_printer_section", Whitelisted, Gated(Stability::Unstable,
                                                       "omit_gdb_pretty_printer_section",
694 695
                                                       "the `#[omit_gdb_pretty_printer_section]` \
                                                        attribute is just used for the Rust test \
696 697
                                                        suite",
                                                       cfg_fn!(omit_gdb_pretty_printer_section))),
698 699
    ("unsafe_destructor_blind_to_params",
     Normal,
700
     Gated(Stability::Deprecated("https://github.com/rust-lang/rust/issues/34761"),
701
           "dropck_parametricity",
702 703
           "unsafe_destructor_blind_to_params has been replaced by \
            may_dangle and will be removed in the future",
704
           cfg_fn!(dropck_parametricity))),
705 706
    ("may_dangle",
     Normal,
707 708
     Gated(Stability::Unstable,
           "dropck_eyepatch",
709 710
           "may_dangle has unstable semantics and may be removed in the future",
           cfg_fn!(dropck_eyepatch))),
711 712 713
    ("unwind", Whitelisted, Gated(Stability::Unstable,
                                  "unwind_attributes",
                                  "#[unwind] is experimental",
714
                                  cfg_fn!(unwind_attributes))),
715 716

    // used in resolve
717 718
    ("prelude_import", Whitelisted, Gated(Stability::Unstable,
                                          "prelude_import",
719 720
                                          "`#[prelude_import]` is for use by rustc only",
                                          cfg_fn!(prelude_import))),
721 722 723

    // FIXME: #14407 these are only looked at on-demand so we can't
    // guarantee they'll have already been checked
724
    ("rustc_deprecated", Whitelisted, Ungated),
725 726 727
    ("must_use", Whitelisted, Ungated),
    ("stable", Whitelisted, Ungated),
    ("unstable", Whitelisted, Ungated),
728
    ("deprecated", Normal, Ungated),
729

730 731
    ("rustc_paren_sugar", Normal, Gated(Stability::Unstable,
                                        "unboxed_closures",
732 733
                                        "unboxed_closures are still evolving",
                                        cfg_fn!(unboxed_closures))),
734 735
    ("rustc_reflect_like", Whitelisted, Gated(Stability::Unstable,
                                              "reflect",
736 737
                                              "defining reflective traits is still evolving",
                                              cfg_fn!(reflect))),
738

739 740 741
    ("windows_subsystem", Whitelisted, Gated(Stability::Unstable,
                                             "windows_subsystem",
                                             "the windows subsystem attribute \
A
Alex Crichton 已提交
742
                                              is currently unstable",
743 744
                                             cfg_fn!(windows_subsystem))),

745 746 747 748 749 750 751 752 753 754
    ("proc_macro_attribute", Normal, Gated(Stability::Unstable,
                                           "proc_macro",
                                           "attribute proc macros are currently unstable",
                                           cfg_fn!(proc_macro))),

    ("rustc_derive_registrar", Normal, Gated(Stability::Unstable,
                                             "rustc_derive_registrar",
                                             "used internally by rustc",
                                             cfg_fn!(rustc_attrs))),

755
    // Crate level attributes
756 757 758 759 760 761 762 763
    ("crate_name", CrateLevel, Ungated),
    ("crate_type", CrateLevel, Ungated),
    ("crate_id", CrateLevel, Ungated),
    ("feature", CrateLevel, Ungated),
    ("no_start", CrateLevel, Ungated),
    ("no_main", CrateLevel, Ungated),
    ("no_builtins", CrateLevel, Ungated),
    ("recursion_limit", CrateLevel, Ungated),
764
    ("type_length_limit", CrateLevel, Ungated),
765 766
];

767 768 769
// cfg(...)'s that are feature gated
const GATED_CFGS: &'static [(&'static str, &'static str, fn(&Features) -> bool)] = &[
    // (name in cfg, feature, function to check if the feature is enabled)
770 771 772
    ("target_feature", "cfg_target_feature", cfg_fn!(cfg_target_feature)),
    ("target_vendor", "cfg_target_vendor", cfg_fn!(cfg_target_vendor)),
    ("target_thread_local", "cfg_target_thread_local", cfg_fn!(cfg_target_thread_local)),
773
    ("target_has_atomic", "cfg_target_has_atomic", cfg_fn!(cfg_target_has_atomic)),
774 775 776 777 778 779 780
];

#[derive(Debug, Eq, PartialEq)]
pub struct GatedCfg {
    span: Span,
    index: usize,
}
781

782 783
impl GatedCfg {
    pub fn gate(cfg: &ast::MetaItem) -> Option<GatedCfg> {
784
        let name = &*cfg.name().as_str();
785 786 787 788 789 790 791 792 793
        GATED_CFGS.iter()
                  .position(|info| info.0 == name)
                  .map(|idx| {
                      GatedCfg {
                          span: cfg.span,
                          index: idx
                      }
                  })
    }
J
Jeffrey Seyfried 已提交
794 795

    pub fn check_and_emit(&self, sess: &ParseSess, features: &Features) {
796
        let (cfg, feature, has_feature) = GATED_CFGS[self.index];
J
Jeffrey Seyfried 已提交
797
        if !has_feature(features) && !sess.codemap().span_allows_unstable(self.span) {
798
            let explain = format!("`cfg({})` is experimental and subject to change", cfg);
799
            emit_feature_err(sess, feature, self.span, GateIssue::Language, &explain);
800 801 802 803
        }
    }
}

E
Eduard Burtescu 已提交
804
struct Context<'a> {
L
Leo Testard 已提交
805
    features: &'a Features,
806
    parse_sess: &'a ParseSess,
C
Corey Richardson 已提交
807
    cm: &'a CodeMap,
808
    plugin_attributes: &'a [(String, AttributeType)],
809 810
}

811 812 813 814 815 816
macro_rules! gate_feature_fn {
    ($cx: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{
        let (cx, has_feature, span, name, explain) = ($cx, $has_feature, $span, $name, $explain);
        let has_feature: bool = has_feature(&$cx.features);
        debug!("gate_feature(feature = {:?}, span = {:?}); has? {}", name, span, has_feature);
        if !has_feature && !cx.cm.span_allows_unstable(span) {
817
            emit_feature_err(cx.parse_sess, name, span, GateIssue::Language, explain);
818
        }
819 820 821 822 823 824
    }}
}

macro_rules! gate_feature {
    ($cx: expr, $feature: ident, $span: expr, $explain: expr) => {
        gate_feature_fn!($cx, |x:&Features| x.$feature, $span, stringify!($feature), $explain)
825
    }
826
}
827

828
impl<'a> Context<'a> {
829
    fn check_attribute(&self, attr: &ast::Attribute, is_macro: bool) {
830
        debug!("check_attribute(attr = {:?})", attr);
831
        let name = &*attr.name().as_str();
832
        for &(n, ty, ref gateage) in BUILTIN_ATTRIBUTES {
833
            if n == name {
834
                if let &Gated(_, ref name, ref desc, ref has_feature) = gateage {
835
                    gate_feature_fn!(self, has_feature, attr.span, name, desc);
836
                }
837
                debug!("check_attribute: {:?} is builtin, {:?}, {:?}", name, ty, gateage);
838 839 840
                return;
            }
        }
841
        for &(ref n, ref ty) in self.plugin_attributes {
842
            if n == name {
843
                // Plugins can't gate attributes, so we don't check for it
M
Manish Goregaokar 已提交
844 845
                // unlike the code above; we only use this loop to
                // short-circuit to avoid the checks below
846 847 848 849
                debug!("check_attribute: {:?} is registered by a plugin, {:?}", name, ty);
                return;
            }
        }
850
        if name.starts_with("rustc_") {
851 852 853 854
            gate_feature!(self, rustc_attrs, attr.span,
                          "unless otherwise specified, attributes \
                           with the prefix `rustc_` \
                           are reserved for internal compiler diagnostics");
855
        } else if name.starts_with("derive_") {
L
Leo Testard 已提交
856
            gate_feature!(self, custom_derive, attr.span, EXPLAIN_DERIVE_UNDERSCORE);
857 858
        } else if attr::is_known(attr) {
            debug!("check_attribute: {:?} is known", name);
859
        } else {
M
Manish Goregaokar 已提交
860 861 862 863
            // Only run the custom attribute lint during regular
            // feature gate checking. Macro gating runs
            // before the plugin attributes are registered
            // so we skip this then
864
            if !is_macro {
865 866 867 868 869 870
                gate_feature!(self, custom_attribute, attr.span,
                              &format!("The attribute `{}` is currently \
                                        unknown to the compiler and \
                                        may have meaning \
                                        added to it in the future",
                                       name));
871
            }
872 873
        }
    }
874 875
}

876
pub fn check_attribute(attr: &ast::Attribute, parse_sess: &ParseSess,
L
Leo Testard 已提交
877 878
                       cm: &CodeMap, features: &Features) {
    let cx = Context {
879
        features: features, parse_sess: parse_sess,
L
Leo Testard 已提交
880 881 882 883 884
        cm: cm, plugin_attributes: &[]
    };
    cx.check_attribute(attr, true);
}

885 886 887 888
pub fn find_lang_feature_accepted_version(feature: &str) -> Option<&'static str> {
    ACCEPTED_FEATURES.iter().find(|t| t.0 == feature).map(|t| t.1)
}

889
fn find_lang_feature_issue(feature: &str) -> Option<u32> {
890 891
    if let Some(info) = ACTIVE_FEATURES.iter().find(|t| t.0 == feature) {
        let issue = info.2;
892 893
        // FIXME (#28244): enforce that active features have issue numbers
        // assert!(issue.is_some())
894 895 896
        issue
    } else {
        // search in Accepted or Removed features
897 898 899 900
        match ACCEPTED_FEATURES.iter().chain(REMOVED_FEATURES).find(|t| t.0 == feature) {
            Some(&(_, _, issue)) => issue,
            None => panic!("Feature `{}` is not declared anywhere", feature),
        }
901 902 903 904 905 906 907 908
    }
}

pub enum GateIssue {
    Language,
    Library(Option<u32>)
}

909
pub fn emit_feature_err(sess: &ParseSess, feature: &str, span: Span, issue: GateIssue,
910
                        explain: &str) {
911 912 913 914 915
    feature_err(sess, feature, span, issue, explain).emit();
}

pub fn feature_err<'a>(sess: &'a ParseSess, feature: &str, span: Span, issue: GateIssue,
                   explain: &str) -> DiagnosticBuilder<'a> {
916 917
    let diag = &sess.span_diagnostic;

918 919 920 921 922
    let issue = match issue {
        GateIssue::Language => find_lang_feature_issue(feature),
        GateIssue::Library(lib) => lib,
    };

N
Nick Cameron 已提交
923 924
    let mut err = if let Some(n) = issue {
        diag.struct_span_err(span, &format!("{} (see issue #{})", explain, n))
925
    } else {
N
Nick Cameron 已提交
926 927
        diag.struct_span_err(span, explain)
    };
928 929

    // #23973: do not suggest `#![feature(...)]` if we are in beta/stable
T
Tim Neumann 已提交
930 931 932 933
    if sess.unstable_features.is_nightly_build() {
        err.help(&format!("add #![feature({})] to the \
                           crate attributes to enable",
                          feature));
N
Nick Cameron 已提交
934
    }
T
Tim Neumann 已提交
935

936
    err
937 938
}

L
Leo Testard 已提交
939 940 941
const EXPLAIN_BOX_SYNTAX: &'static str =
    "box expression syntax is experimental; you can call `Box::new` instead.";

J
Jeffrey Seyfried 已提交
942
pub const EXPLAIN_STMT_ATTR_SYNTAX: &'static str =
L
Leo Testard 已提交
943 944
    "attributes on non-item statements and expressions are experimental.";

945 946 947
pub const EXPLAIN_ASM: &'static str =
    "inline assembly is not stable enough for use and is subject to change";

948 949 950 951 952 953 954 955
pub const EXPLAIN_LOG_SYNTAX: &'static str =
    "`log_syntax!` is not stable enough for use and is subject to change";

pub const EXPLAIN_CONCAT_IDENTS: &'static str =
    "`concat_idents` is not stable enough for use and is subject to change";

pub const EXPLAIN_TRACE_MACROS: &'static str =
    "`trace_macros` is not stable enough for use and is subject to change";
956 957
pub const EXPLAIN_ALLOW_INTERNAL_UNSTABLE: &'static str =
    "allow_internal_unstable side-steps feature gating and stability checks";
958

959
pub const EXPLAIN_CUSTOM_DERIVE: &'static str =
N
Nick Cameron 已提交
960 961 962 963 964 965
    "`#[derive]` for custom traits is not stable enough for use. It is deprecated and will \
     be removed in v1.15";

pub const EXPLAIN_DEPR_CUSTOM_DERIVE: &'static str =
    "`#[derive]` for custom traits is deprecated and will be removed in v1.15. Prefer using \
     procedural macro custom derive";
966

L
Leo Testard 已提交
967 968
pub const EXPLAIN_DERIVE_UNDERSCORE: &'static str =
    "attributes of the form `#[derive_*]` are reserved for the compiler";
969

L
Leo Testard 已提交
970 971
pub const EXPLAIN_PLACEMENT_IN: &'static str =
    "placement-in expression syntax is experimental and subject to change.";
C
Corey Richardson 已提交
972 973

struct PostExpansionVisitor<'a> {
N
Nick Cameron 已提交
974
    context: &'a Context<'a>,
C
Corey Richardson 已提交
975 976
}

977 978 979 980 981
macro_rules! gate_feature_post {
    ($cx: expr, $feature: ident, $span: expr, $explain: expr) => {{
        let (cx, span) = ($cx, $span);
        if !cx.context.cm.span_allows_unstable(span) {
            gate_feature!(cx.context, $feature, span, $explain)
C
Corey Richardson 已提交
982
        }
983
    }}
C
Corey Richardson 已提交
984 985
}

986 987 988
impl<'a> PostExpansionVisitor<'a> {
    fn check_abi(&self, abi: Abi, span: Span) {
        match abi {
989
            Abi::RustIntrinsic => {
990
                gate_feature_post!(&self, intrinsics, span,
991 992
                                   "intrinsics are subject to change");
            },
993 994
            Abi::PlatformIntrinsic => {
                gate_feature_post!(&self, platform_intrinsics, span,
995
                                   "platform intrinsics are experimental and possibly buggy");
996 997 998
            },
            Abi::Vectorcall => {
                gate_feature_post!(&self, abi_vectorcall, span,
999 1000
                                   "vectorcall is experimental and subject to change");
            },
1001 1002 1003
            Abi::RustCall => {
                gate_feature_post!(&self, unboxed_closures, span,
                                   "rust-call ABI is subject to change");
1004 1005 1006 1007 1008
            },
            Abi::SysV64 => {
                gate_feature_post!(&self, abi_sysv64, span,
                                   "sysv64 ABI is experimental and subject to change");
            },
J
Jorge Aparicio 已提交
1009 1010 1011
            Abi::PtxKernel => {
                gate_feature_post!(&self, abi_ptx, span,
                                   "PTX ABIs are experimental and subject to change");
1012 1013 1014 1015 1016
            },
            Abi::Unadjusted => {
                gate_feature_post!(&self, abi_unadjusted, span,
                                   "unadjusted ABI is an implementation detail and perma-unstable");
            },
1017 1018 1019 1020
            Abi::Msp430Interrupt => {
                gate_feature_post!(&self, abi_msp430_interrupt, span,
                                   "msp430-interrupt ABI is experimental and subject to change");
            },
J
Jorge Aparicio 已提交
1021 1022 1023 1024 1025 1026 1027 1028 1029
            // Stable
            Abi::Cdecl |
            Abi::Stdcall |
            Abi::Fastcall |
            Abi::Aapcs |
            Abi::Win64 |
            Abi::Rust |
            Abi::C |
            Abi::System => {}
1030 1031 1032 1033
        }
    }
}

1034 1035 1036 1037 1038
fn contains_novel_literal(item: &ast::MetaItem) -> bool {
    use ast::MetaItemKind::*;
    use ast::NestedMetaItemKind::*;

    match item.node {
1039 1040 1041
        Word => false,
        NameValue(ref lit) => !lit.node.is_str(),
        List(ref list) => list.iter().any(|li| {
1042
            match li.node {
1043
                MetaItem(ref mi) => contains_novel_literal(&mi),
1044 1045 1046 1047 1048 1049
                Literal(_) => true,
            }
        }),
    }
}

1050 1051 1052 1053
fn starts_with_digit(s: &str) -> bool {
    s.as_bytes().first().cloned().map_or(false, |b| b >= b'0' && b <= b'9')
}

1054
impl<'a> Visitor<'a> for PostExpansionVisitor<'a> {
1055 1056
    fn visit_attribute(&mut self, attr: &ast::Attribute) {
        if !self.context.cm.span_allows_unstable(attr.span) {
1057
            // check for gated attributes
1058
            self.context.check_attribute(attr, false);
1059
        }
1060

1061
        if contains_novel_literal(&attr.value) {
1062 1063 1064 1065
            gate_feature_post!(&self, attr_literals, attr.span,
                               "non-string literals in attributes, or string \
                               literals in top-level positions, are experimental");
        }
1066 1067
    }

1068
    fn visit_name(&mut self, sp: Span, name: ast::Name) {
1069
        if !name.as_str().is_ascii() {
1070 1071
            gate_feature_post!(&self, non_ascii_idents, sp,
                               "non-ascii idents are not fully supported.");
1072 1073 1074
        }
    }

1075
    fn visit_item(&mut self, i: &'a ast::Item) {
1076
        match i.node {
1077
            ast::ItemKind::ExternCrate(_) => {
1078
                if attr::contains_name(&i.attrs[..], "macro_reexport") {
1079 1080 1081
                    gate_feature_post!(&self, macro_reexport, i.span,
                                       "macros reexports are experimental \
                                        and possibly buggy");
1082 1083 1084
                }
            }

1085
            ast::ItemKind::ForeignMod(ref foreign_module) => {
1086
                if attr::contains_name(&i.attrs[..], "link_args") {
1087
                    gate_feature_post!(&self, link_args, i.span,
1088 1089 1090 1091
                                      "the `link_args` attribute is not portable \
                                       across platforms, it is recommended to \
                                       use `#[link(name = \"foo\")]` instead")
                }
1092
                self.check_abi(foreign_module.abi, i.span);
1093 1094
            }

1095
            ast::ItemKind::Fn(..) => {
1096
                if attr::contains_name(&i.attrs[..], "plugin_registrar") {
1097 1098
                    gate_feature_post!(&self, plugin_registrar, i.span,
                                       "compiler plugins are experimental and possibly buggy");
1099
                }
1100
                if attr::contains_name(&i.attrs[..], "start") {
1101
                    gate_feature_post!(&self, start, i.span,
1102 1103 1104 1105
                                      "a #[start] function is an experimental \
                                       feature whose signature may change \
                                       over time");
                }
1106
                if attr::contains_name(&i.attrs[..], "main") {
1107 1108 1109 1110
                    gate_feature_post!(&self, main, i.span,
                                       "declaration of a nonstandard #[main] \
                                        function may change over time, for now \
                                        a top-level `fn main()` is required");
1111
                }
1112 1113
            }

1114
            ast::ItemKind::Struct(..) => {
1115
                if attr::contains_name(&i.attrs[..], "simd") {
1116 1117
                    gate_feature_post!(&self, simd, i.span,
                                       "SIMD types are experimental and possibly buggy");
1118 1119 1120 1121
                    self.context.parse_sess.span_diagnostic.span_warn(i.span,
                                                                      "the `#[simd]` attribute \
                                                                       is deprecated, use \
                                                                       `#[repr(simd)]` instead");
1122 1123 1124 1125
                }
                for attr in &i.attrs {
                    if attr.name() == "repr" {
                        for item in attr.meta_item_list().unwrap_or(&[]) {
1126
                            if item.check_name("simd") {
1127 1128 1129
                                gate_feature_post!(&self, repr_simd, i.span,
                                                   "SIMD types are experimental \
                                                    and possibly buggy");
1130 1131 1132 1133

                            }
                        }
                    }
1134
                }
D
David Manescu 已提交
1135 1136
            }

1137 1138 1139
            ast::ItemKind::Union(..) => {
                gate_feature_post!(&self, untagged_unions,
                                   i.span,
V
Vadim Petrochenkov 已提交
1140
                                   "unions are unstable and possibly buggy");
1141 1142
            }

1143
            ast::ItemKind::DefaultImpl(..) => {
1144 1145 1146 1147
                gate_feature_post!(&self, optin_builtin_traits,
                                   i.span,
                                   "default trait implementations are experimental \
                                    and possibly buggy");
F
Flavio Percoco 已提交
1148 1149
            }

1150
            ast::ItemKind::Impl(_, polarity, _, _, _, _) => {
1151 1152
                match polarity {
                    ast::ImplPolarity::Negative => {
1153 1154 1155 1156
                        gate_feature_post!(&self, optin_builtin_traits,
                                           i.span,
                                           "negative trait bounds are not yet fully implemented; \
                                            use marker types for now");
1157 1158 1159
                    },
                    _ => {}
                }
1160 1161
            }

1162 1163 1164
            _ => {}
        }

1165
        visit::walk_item(self, i);
1166
    }
1167

1168
    fn visit_foreign_item(&mut self, i: &'a ast::ForeignItem) {
1169 1170
        let links_to_llvm = match attr::first_attr_value_str_by_name(&i.attrs, "link_name") {
            Some(val) => val.as_str().starts_with("llvm."),
1171 1172 1173
            _ => false
        };
        if links_to_llvm {
1174
            gate_feature_post!(&self, link_llvm_intrinsics, i.span,
1175 1176 1177
                              "linking to LLVM intrinsics is experimental");
        }

1178
        visit::walk_foreign_item(self, i)
1179 1180
    }

1181
    fn visit_ty(&mut self, ty: &'a ast::Ty) {
1182 1183 1184 1185
        match ty.node {
            ast::TyKind::BareFn(ref bare_fn_ty) => {
                self.check_abi(bare_fn_ty.abi, ty.span);
            }
1186 1187 1188 1189
            ast::TyKind::ImplTrait(..) => {
                gate_feature_post!(&self, conservative_impl_trait, ty.span,
                                   "`impl Trait` is experimental");
            }
A
Andrew Cann 已提交
1190 1191
            ast::TyKind::Never => {
                gate_feature_post!(&self, never_type, ty.span,
1192 1193
                                   "The `!` type is experimental");
            },
1194 1195 1196 1197 1198
            _ => {}
        }
        visit::walk_ty(self, ty)
    }

1199
    fn visit_fn_ret_ty(&mut self, ret_ty: &'a ast::FunctionRetTy) {
1200 1201
        if let ast::FunctionRetTy::Ty(ref output_ty) = *ret_ty {
            match output_ty.node {
A
Andrew Cann 已提交
1202
                ast::TyKind::Never => return,
1203 1204
                _ => (),
            };
A
Andrew Cann 已提交
1205
            self.visit_ty(output_ty)
1206 1207 1208
        }
    }

1209
    fn visit_expr(&mut self, e: &'a ast::Expr) {
1210
        match e.node {
1211
            ast::ExprKind::Box(_) => {
1212
                gate_feature_post!(&self, box_syntax, e.span, EXPLAIN_BOX_SYNTAX);
1213
            }
1214
            ast::ExprKind::Type(..) => {
1215
                gate_feature_post!(&self, type_ascription, e.span,
1216 1217
                                  "type ascription is experimental");
            }
1218
            ast::ExprKind::Range(_, _, ast::RangeLimits::Closed) => {
1219
                gate_feature_post!(&self, inclusive_range_syntax,
A
Alex Burka 已提交
1220 1221 1222
                                  e.span,
                                  "inclusive range syntax is experimental");
            }
1223 1224 1225
            ast::ExprKind::InPlace(..) => {
                gate_feature_post!(&self, placement_in_syntax, e.span, EXPLAIN_PLACEMENT_IN);
            }
1226 1227 1228 1229 1230 1231
            ast::ExprKind::Struct(_, ref fields, _) => {
                for field in fields {
                    if field.is_shorthand {
                        gate_feature_post!(&self, field_init_shorthand, field.span,
                                           "struct field shorthands are unstable");
                    }
1232 1233 1234 1235 1236
                    if starts_with_digit(&field.ident.node.name.as_str()) {
                        gate_feature_post!(&self, relaxed_adts,
                                          field.span,
                                          "numeric fields in struct expressions are unstable");
                    }
1237 1238
                }
            }
1239 1240 1241 1242
            ast::ExprKind::Break(_, Some(_)) => {
                gate_feature_post!(&self, loop_break_value, e.span,
                                   "`break` with a value is experimental");
            }
1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254
            ast::ExprKind::Lit(ref lit) => {
                if let ast::LitKind::Int(_, ref ty) = lit.node {
                    match *ty {
                        ast::LitIntType::Signed(ast::IntTy::I128) |
                        ast::LitIntType::Unsigned(ast::UintTy::U128) => {
                            gate_feature_post!(&self, i128_type, e.span,
                                               "128-bit integers are not stable");
                        }
                        _ => {}
                    }
                }
            }
1255 1256
            _ => {}
        }
1257
        visit::walk_expr(self, e);
1258
    }
1259

1260
    fn visit_pat(&mut self, pattern: &'a ast::Pat) {
1261
        match pattern.node {
1262
            PatKind::Slice(_, Some(_), ref last) if !last.is_empty() => {
1263
                gate_feature_post!(&self, advanced_slice_patterns,
1264 1265 1266
                                  pattern.span,
                                  "multiple-element slice matches anywhere \
                                   but at the end of a slice (e.g. \
1267
                                   `[0, ..xs, 0]`) are experimental")
1268
            }
1269
            PatKind::Slice(..) => {
1270
                gate_feature_post!(&self, slice_patterns,
1271 1272 1273
                                  pattern.span,
                                  "slice pattern syntax is experimental");
            }
1274
            PatKind::Box(..) => {
1275
                gate_feature_post!(&self, box_patterns,
1276
                                  pattern.span,
1277
                                  "box pattern syntax is experimental");
1278
            }
1279 1280 1281 1282 1283 1284 1285 1286
            PatKind::Struct(_, ref fields, _) => {
                for field in fields {
                    if starts_with_digit(&field.node.ident.name.as_str()) {
                        gate_feature_post!(&self, relaxed_adts,
                                          field.span,
                                          "numeric fields in struct patterns are unstable");
                    }
                }
1287
            }
1288 1289
            _ => {}
        }
1290
        visit::walk_pat(self, pattern)
1291 1292
    }

1293
    fn visit_fn(&mut self,
1294 1295
                fn_kind: FnKind<'a>,
                fn_decl: &'a ast::FnDecl,
1296
                span: Span,
1297
                _node_id: NodeId) {
N
Niko Matsakis 已提交
1298 1299
        // check for const fn declarations
        match fn_kind {
1300
            FnKind::ItemFn(_, _, _, Spanned { node: ast::Constness::Const, .. }, _, _, _) => {
1301
                gate_feature_post!(&self, const_fn, span, "const fn is unstable");
N
Niko Matsakis 已提交
1302 1303 1304 1305 1306 1307 1308 1309 1310
            }
            _ => {
                // stability of const fn methods are covered in
                // visit_trait_item and visit_impl_item below; this is
                // because default methods don't pass through this
                // point.
            }
        }

1311
        match fn_kind {
1312 1313
            FnKind::ItemFn(_, _, _, _, abi, _, _) |
            FnKind::Method(_, &ast::MethodSig { abi, .. }, _, _) => {
1314 1315
                self.check_abi(abi, span);
            }
1316 1317
            _ => {}
        }
1318
        visit::walk_fn(self, fn_kind, fn_decl, span);
1319
    }
1320

1321
    fn visit_trait_item(&mut self, ti: &'a ast::TraitItem) {
1322
        match ti.node {
1323
            ast::TraitItemKind::Const(..) => {
1324
                gate_feature_post!(&self, associated_consts,
1325 1326 1327
                                  ti.span,
                                  "associated constants are experimental")
            }
1328 1329 1330 1331
            ast::TraitItemKind::Method(ref sig, ref block) => {
                if block.is_none() {
                    self.check_abi(sig.abi, ti.span);
                }
1332
                if sig.constness.node == ast::Constness::Const {
1333
                    gate_feature_post!(&self, const_fn, ti.span, "const fn is unstable");
N
Niko Matsakis 已提交
1334 1335
                }
            }
1336
            ast::TraitItemKind::Type(_, Some(_)) => {
1337
                gate_feature_post!(&self, associated_type_defaults, ti.span,
1338 1339
                                  "associated type defaults are unstable");
            }
1340 1341 1342 1343 1344
            _ => {}
        }
        visit::walk_trait_item(self, ti);
    }

1345
    fn visit_impl_item(&mut self, ii: &'a ast::ImplItem) {
A
Aaron Turon 已提交
1346
        if ii.defaultness == ast::Defaultness::Default {
1347
            gate_feature_post!(&self, specialization,
A
Aaron Turon 已提交
1348 1349 1350 1351
                              ii.span,
                              "specialization is unstable");
        }

1352
        match ii.node {
1353
            ast::ImplItemKind::Const(..) => {
1354
                gate_feature_post!(&self, associated_consts,
1355 1356 1357
                                  ii.span,
                                  "associated constants are experimental")
            }
1358
            ast::ImplItemKind::Method(ref sig, _) => {
1359
                if sig.constness.node == ast::Constness::Const {
1360
                    gate_feature_post!(&self, const_fn, ii.span, "const fn is unstable");
N
Niko Matsakis 已提交
1361 1362
                }
            }
1363 1364 1365 1366
            _ => {}
        }
        visit::walk_impl_item(self, ii);
    }
1367

1368
    fn visit_vis(&mut self, vis: &'a ast::Visibility) {
1369 1370
        let span = match *vis {
            ast::Visibility::Crate(span) => span,
1371
            ast::Visibility::Restricted { ref path, .. } => path.span,
1372 1373
            _ => return,
        };
1374
        gate_feature_post!(&self, pub_restricted, span, "`pub(restricted)` syntax is experimental");
1375 1376

        visit::walk_vis(self, vis)
1377
    }
1378

1379
    fn visit_generics(&mut self, g: &'a ast::Generics) {
1380 1381 1382 1383 1384 1385 1386 1387 1388
        for t in &g.ty_params {
            if !t.attrs.is_empty() {
                gate_feature_post!(&self, generic_param_attrs, t.attrs[0].span,
                                   "attributes on type parameter bindings are experimental");
            }
        }
        visit::walk_generics(self, g)
    }

1389
    fn visit_lifetime_def(&mut self, lifetime_def: &'a ast::LifetimeDef) {
1390 1391 1392 1393 1394 1395
        if !lifetime_def.attrs.is_empty() {
            gate_feature_post!(&self, generic_param_attrs, lifetime_def.attrs[0].span,
                               "attributes on lifetime bindings are experimental");
        }
        visit::walk_lifetime_def(self, lifetime_def)
    }
1396 1397
}

J
Jeffrey Seyfried 已提交
1398
pub fn get_features(span_handler: &Handler, krate_attrs: &[ast::Attribute]) -> Features {
1399
    let mut features = Features::new();
N
Nick Cameron 已提交
1400

1401 1402
    let mut feature_checker = MutexFeatureChecker::default();

J
Jeffrey Seyfried 已提交
1403
    for attr in krate_attrs {
S
Steven Fackler 已提交
1404
        if !attr.check_name("feature") {
1405 1406
            continue
        }
1407 1408 1409

        match attr.meta_item_list() {
            None => {
G
ggomez 已提交
1410 1411
                span_err!(span_handler, attr.span, E0555,
                          "malformed feature attribute, expected #![feature(...)]");
1412 1413
            }
            Some(list) => {
1414
                for mi in list {
1415 1416 1417 1418 1419 1420 1421 1422
                    let name = if let Some(word) = mi.word() {
                        word.name()
                    } else {
                        span_err!(span_handler, mi.span, E0556,
                                  "malformed feature, expected just one word");
                        continue
                    };

1423 1424 1425
                    if let Some(&(_, _, _, setter)) = ACTIVE_FEATURES.iter()
                        .find(|& &(n, _, _, _)| name == n) {
                        *(setter(&mut features)) = true;
1426
                        feature_checker.collect(&features, mi.span);
1427 1428 1429
                    }
                    else if let Some(&(_, _, _)) = REMOVED_FEATURES.iter()
                        .find(|& &(n, _, _)| name == n) {
G
ggomez 已提交
1430
                        span_err!(span_handler, mi.span, E0557, "feature has been removed");
1431 1432 1433
                    }
                    else if let Some(&(_, _, _)) = ACCEPTED_FEATURES.iter()
                        .find(|& &(n, _, _)| name == n) {
1434
                        features.declared_stable_lang_features.push((name, mi.span));
1435 1436
                    } else {
                        features.declared_lib_features.push((name, mi.span));
1437 1438 1439 1440 1441 1442
                    }
                }
            }
        }
    }

1443 1444
    feature_checker.check(span_handler);

L
Leo Testard 已提交
1445
    features
C
Corey Richardson 已提交
1446 1447
}

1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481
// A collector for mutually-exclusive features and their flag spans
#[derive(Default)]
struct MutexFeatureChecker {
    proc_macro: Option<Span>,
    custom_attribute: Option<Span>,
}

impl MutexFeatureChecker {
    // If this method turns out to be a hotspot due to branching,
    // the branching can be eliminated by modifying `setter!()` to set these spans
    // only for the features that need to be checked for mutual exclusion.
    fn collect(&mut self, features: &Features, span: Span) {
        if features.proc_macro {
            // If self.proc_macro is None, set to Some(span)
            self.proc_macro = self.proc_macro.or(Some(span));
        }

        if features.custom_attribute {
            self.custom_attribute = self.custom_attribute.or(Some(span));
        }
    }

    fn check(self, handler: &Handler) {
        if let (Some(pm_span), Some(ca_span)) = (self.proc_macro, self.custom_attribute) {
            handler.struct_span_err(pm_span, "Cannot use `#![feature(proc_macro)]` and \
                                              `#![feature(custom_attribute)] at the same time")
                .span_note(ca_span, "`#![feature(custom_attribute)]` declared here")
                .emit();

            panic!(FatalError);
        }
    }
}

J
Jeffrey Seyfried 已提交
1482 1483 1484
pub fn check_crate(krate: &ast::Crate,
                   sess: &ParseSess,
                   features: &Features,
1485
                   plugin_attributes: &[(String, AttributeType)],
J
Jeffrey Seyfried 已提交
1486 1487 1488 1489
                   unstable: UnstableFeatures) {
    maybe_stage_features(&sess.span_diagnostic, krate, unstable);
    let ctx = Context {
        features: features,
1490
        parse_sess: sess,
J
Jeffrey Seyfried 已提交
1491 1492 1493 1494
        cm: sess.codemap(),
        plugin_attributes: plugin_attributes,
    };
    visit::walk_crate(&mut PostExpansionVisitor { context: &ctx }, krate);
C
Corey Richardson 已提交
1495
}
1496

1497
#[derive(Clone, Copy, PartialEq, Eq, Hash)]
1498 1499 1500 1501
pub enum UnstableFeatures {
    /// Hard errors for unstable features are active, as on
    /// beta/stable channels.
    Disallow,
J
John Hodge 已提交
1502
    /// Allow features to be activated, as on nightly.
1503 1504 1505 1506
    Allow,
    /// Errors are bypassed for bootstrapping. This is required any time
    /// during the build that feature-related lints are set to warn or above
    /// because the build turns on warnings-as-errors and uses lots of unstable
1507
    /// features. As a result, this is always required for building Rust itself.
1508 1509 1510
    Cheat
}

T
Tim Neumann 已提交
1511 1512 1513 1514
impl UnstableFeatures {
    pub fn from_environment() -> UnstableFeatures {
        // Whether this is a feature-staged build, i.e. on the beta or stable channel
        let disable_unstable_features = option_env!("CFG_DISABLE_UNSTABLE_FEATURES").is_some();
1515 1516 1517 1518 1519 1520
        // Whether we should enable unstable features for bootstrapping
        let bootstrap = env::var("RUSTC_BOOTSTRAP").is_ok();
        match (disable_unstable_features, bootstrap) {
            (_, true) => UnstableFeatures::Cheat,
            (true, _) => UnstableFeatures::Disallow,
            (false, _) => UnstableFeatures::Allow
T
Tim Neumann 已提交
1521 1522
        }
    }
1523 1524 1525 1526 1527 1528 1529

    pub fn is_nightly_build(&self) -> bool {
        match *self {
            UnstableFeatures::Allow | UnstableFeatures::Cheat => true,
            _ => false,
        }
    }
T
Tim Neumann 已提交
1530 1531
}

1532
fn maybe_stage_features(span_handler: &Handler, krate: &ast::Crate,
1533 1534 1535 1536 1537 1538 1539 1540 1541 1542
                        unstable: UnstableFeatures) {
    let allow_features = match unstable {
        UnstableFeatures::Allow => true,
        UnstableFeatures::Disallow => false,
        UnstableFeatures::Cheat => true
    };
    if !allow_features {
        for attr in &krate.attrs {
            if attr.check_name("feature") {
                let release_channel = option_env!("CFG_RELEASE_CHANNEL").unwrap_or("(unknown)");
G
ggomez 已提交
1543
                span_err!(span_handler, attr.span, E0554,
G
ggomez 已提交
1544 1545
                          "#[feature] may not be used on the {} release channel",
                          release_channel);
1546 1547 1548 1549
            }
        }
    }
}