feature_gate.rs 64.2 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

//! Feature gating
//!
L
Luke Gallagher 已提交
13
//! This module implements the gating necessary for preventing certain compiler
14 15 16 17 18
//! features from being used by default. This module will crawl a pre-expanded
//! AST to ensure that there are no features which are used that are not
//! enabled.
//!
//! Features are enabled in programs via the crate-level attributes of
19
//! `#![feature(...)]` with a comma-separated list of features.
B
Brian Anderson 已提交
20 21 22 23
//!
//! For the purpose of future feature-tracking, once code for detection of feature
//! gate usage is added, *do not remove it again* even once the feature
//! becomes stable.
G
GuillaumeGomez 已提交
24

25
use self::AttributeType::*;
26
use self::AttributeGate::*;
27

N
Niko Matsakis 已提交
28
use abi::Abi;
29
use ast::{self, NodeId, PatKind, RangeEnd};
30
use attr;
31
use codemap::{CodeMap, Spanned};
32
use syntax_pos::Span;
33
use errors::{DiagnosticBuilder, Handler, FatalError};
34
use visit::{self, FnKind, Visitor};
J
Jeffrey Seyfried 已提交
35
use parse::ParseSess;
36
use symbol::Symbol;
37

38
use std::ascii::AsciiExt;
T
Tim Neumann 已提交
39
use std::env;
40

41 42 43 44 45 46 47 48
macro_rules! setter {
    ($field: ident) => {{
        fn f(features: &mut Features) -> &mut bool {
            &mut features.$field
        }
        f as fn(&mut Features) -> &mut bool
    }}
}
49

50
macro_rules! declare_features {
51
    ($((active, $feature: ident, $ver: expr, $issue: expr),)+) => {
52 53 54 55 56 57 58 59 60
        /// Represents active features that are currently being implemented or
        /// currently being considered for addition/removal.
        const ACTIVE_FEATURES: &'static [(&'static str, &'static str,
                                          Option<u32>, fn(&mut Features) -> &mut bool)] = &[
            $((stringify!($feature), $ver, $issue, setter!($feature))),+
        ];

        /// A set of features to be used by later passes.
        pub struct Features {
61
            /// #![feature] attrs for stable language features, for error reporting
62
            pub declared_stable_lang_features: Vec<(Symbol, Span)>,
63
            /// #![feature] attrs for non-language (library) features
64
            pub declared_lib_features: Vec<(Symbol, Span)>,
65 66
            $(pub $feature: bool),+
        }
67

68 69 70 71 72 73 74 75 76 77 78
        impl Features {
            pub fn new() -> Features {
                Features {
                    declared_stable_lang_features: Vec::new(),
                    declared_lib_features: Vec::new(),
                    $($feature: false),+
                }
            }
        }
    };

79
    ($((removed, $feature: ident, $ver: expr, $issue: expr),)+) => {
80 81 82 83 84 85
        /// Represents features which has since been removed (it was once Active)
        const REMOVED_FEATURES: &'static [(&'static str, &'static str, Option<u32>)] = &[
            $((stringify!($feature), $ver, $issue)),+
        ];
    };

86
    ($((accepted, $feature: ident, $ver: expr, $issue: expr),)+) => {
87 88 89 90 91
        /// Those language feature has since been Accepted (it was once Active)
        const ACCEPTED_FEATURES: &'static [(&'static str, &'static str, Option<u32>)] = &[
            $((stringify!($feature), $ver, $issue)),+
        ];
    }
92 93
}

B
Brian Anderson 已提交
94 95 96 97 98
// If you change this list without updating src/doc/reference.md, @cmr will be sad
// Don't ever remove anything from this list; set them to 'Removed'.
// The version numbers here correspond to the version in which the current status
// was set. This is most important for knowing when a particular feature became
// stable (active).
99 100 101 102 103 104 105 106 107 108 109 110
// NB: The featureck.py script parses this information directly out of the source
// so take care when modifying it.

declare_features! (
    (active, asm, "1.0.0", Some(29722)),
    (active, concat_idents, "1.0.0", Some(29599)),
    (active, link_args, "1.0.0", Some(29596)),
    (active, log_syntax, "1.0.0", Some(29598)),
    (active, non_ascii_idents, "1.0.0", Some(28979)),
    (active, plugin_registrar, "1.0.0", Some(29597)),
    (active, thread_local, "1.0.0", Some(29594)),
    (active, trace_macros, "1.0.0", Some(29598)),
A
Aaron Turon 已提交
111 112

    // rustc internal, for now:
113 114
    (active, intrinsics, "1.0.0", None),
    (active, lang_items, "1.0.0", None),
115

116 117 118 119
    (active, link_llvm_intrinsics, "1.0.0", Some(29602)),
    (active, linkage, "1.0.0", Some(29603)),
    (active, quote, "1.0.0", Some(29601)),
    (active, simd, "1.0.0", Some(27731)),
120 121


A
Aaron Turon 已提交
122
    // rustc internal
123 124 125 126 127
    (active, rustc_diagnostic_macros, "1.0.0", None),
    (active, advanced_slice_patterns, "1.0.0", Some(23121)),
    (active, box_syntax, "1.0.0", Some(27779)),
    (active, placement_in_syntax, "1.0.0", Some(27779)),
    (active, unboxed_closures, "1.0.0", Some(29625)),
A
Aaron Turon 已提交
128

129 130 131 132 133 134 135 136 137
    (active, allocator, "1.0.0", Some(27389)),
    (active, fundamental, "1.0.0", Some(29635)),
    (active, main, "1.0.0", Some(29634)),
    (active, needs_allocator, "1.4.0", Some(27389)),
    (active, on_unimplemented, "1.0.0", Some(29628)),
    (active, plugin, "1.0.0", Some(29597)),
    (active, simd_ffi, "1.0.0", Some(27731)),
    (active, start, "1.0.0", Some(29633)),
    (active, structural_match, "1.8.0", Some(31434)),
138 139
    (active, panic_runtime, "1.10.0", Some(32837)),
    (active, needs_panic_runtime, "1.10.0", Some(32837)),
140

141
    // OIBIT specific features
142
    (active, optin_builtin_traits, "1.0.0", Some(13231)),
143

J
Joseph Crail 已提交
144
    // macro reexport needs more discussion and stabilization
145
    (active, macro_reexport, "1.0.0", Some(29638)),
146 147

    // Allows use of #[staged_api]
A
Aaron Turon 已提交
148
    // rustc internal
149
    (active, staged_api, "1.0.0", None),
150

A
Alex Crichton 已提交
151
    // Allows using #![no_core]
152
    (active, no_core, "1.3.0", Some(29639)),
A
Alex Crichton 已提交
153

154
    // Allows using `box` in patterns; RFC 469
155
    (active, box_patterns, "1.0.0", Some(29641)),
156

157 158
    // Allows using the unsafe_destructor_blind_to_params attribute;
    // RFC 1238
159
    (active, dropck_parametricity, "1.3.0", Some(28498)),
160

161 162 163
    // Allows using the may_dangle attribute; RFC 1327
    (active, dropck_eyepatch, "1.10.0", Some(34761)),

164
    // Allows the use of custom attributes; RFC 572
165
    (active, custom_attribute, "1.0.0", Some(29642)),
M
Manish Goregaokar 已提交
166

167 168
    // Allows the use of #[derive(Anything)] as sugar for
    // #[derive_Anything].
169
    (active, custom_derive, "1.0.0", Some(29644)),
170

M
Manish Goregaokar 已提交
171
    // Allows the use of rustc_* attributes; RFC 572
172
    (active, rustc_attrs, "1.0.0", Some(29642)),
H
Huon Wilson 已提交
173

174 175 176 177
    // Allows the use of #[allow_internal_unstable]. This is an
    // attribute on macro_rules! and can't use the attribute handling
    // below (it has to be checked before expansion possibly makes
    // macros disappear).
A
Aaron Turon 已提交
178 179
    //
    // rustc internal
180
    (active, allow_internal_unstable, "1.0.0", None),
181 182

    // #23121. Array patterns have some hazards yet.
183
    (active, slice_patterns, "1.0.0", Some(23121)),
184 185 186

    // Allows the definition of associated constants in `trait` or `impl`
    // blocks.
187
    (active, associated_consts, "1.0.0", Some(29646)),
N
Niko Matsakis 已提交
188 189

    // Allows the definition of `const fn` functions.
190
    (active, const_fn, "1.2.0", Some(24111)),
191

192
    // Allows indexing into constant arrays.
193
    (active, const_indexing, "1.4.0", Some(29947)),
194

195
    // Allows using #[prelude_import] on glob `use` items.
A
Aaron Turon 已提交
196 197
    //
    // rustc internal
198
    (active, prelude_import, "1.2.0", None),
199 200

    // Allows the definition recursive static items.
201
    (active, static_recursion, "1.3.0", Some(29719)),
B
Brian Anderson 已提交
202 203

    // Allows default type parameters to influence type inference.
204
    (active, default_type_parameter_fallback, "1.3.0", Some(27336)),
205 206

    // Allows associated type defaults
207
    (active, associated_type_defaults, "1.2.0", Some(29661)),
J
Jared Roesch 已提交
208

209
    // allow `repr(simd)`, and importing the various simd intrinsics
210
    (active, repr_simd, "1.4.0", Some(27731)),
211 212

    // Allows cfg(target_feature = "...").
213
    (active, cfg_target_feature, "1.4.0", Some(29717)),
214 215

    // allow `extern "platform-intrinsic" { ... }`
216
    (active, platform_intrinsics, "1.4.0", Some(27731)),
217 218

    // allow `#[unwind]`
A
Aaron Turon 已提交
219
    // rust runtime internal
220
    (active, unwind_attributes, "1.4.0", None),
V
Vadim Petrochenkov 已提交
221

T
Ticki 已提交
222
    // allow the use of `#[naked]` on functions.
223
    (active, naked_functions, "1.9.0", Some(32408)),
224 225

    // allow `#[no_debug]`
226
    (active, no_debug, "1.5.0", Some(29721)),
227 228

    // allow `#[omit_gdb_pretty_printer_section]`
A
Aaron Turon 已提交
229
    // rustc internal.
230
    (active, omit_gdb_pretty_printer_section, "1.5.0", None),
231 232

    // Allows cfg(target_vendor = "...").
233
    (active, cfg_target_vendor, "1.5.0", Some(29718)),
234 235

    // Allow attributes on expressions and non-item statements
236
    (active, stmt_expr_attributes, "1.6.0", Some(15701)),
237 238

    // allow using type ascription in expressions
239
    (active, type_ascription, "1.6.0", Some(23416)),
240 241

    // Allows cfg(target_thread_local)
242
    (active, cfg_target_thread_local, "1.7.0", Some(29594)),
243 244

    // rustc internal
245
    (active, abi_vectorcall, "1.7.0", None),
A
Alex Burka 已提交
246 247

    // a...b and ...b
248
    (active, inclusive_range_syntax, "1.7.0", Some(28237)),
J
Jorge Aparicio 已提交
249

250 251 252
    // X..Y patterns
    (active, exclusive_range_pattern, "1.11.0", Some(37854)),

A
Aaron Turon 已提交
253
    // impl specialization (RFC 1210)
254
    (active, specialization, "1.7.0", Some(31844)),
255 256

    // pub(restricted) visibilities (RFC 1422)
257 258
    (active, pub_restricted, "1.9.0", Some(32409)),

259 260 261 262
    // Allow Drop types in statics/const functions (RFC 1440)
    (active, drop_types_in_const, "1.9.0", Some(33156)),

    // Allows cfg(target_has_atomic = "...").
263 264
    (active, cfg_target_has_atomic, "1.9.0", Some(32976)),

265
    // Allows `impl Trait` in function return types.
266 267 268
    (active, conservative_impl_trait, "1.12.0", Some(34511)),

    // Permits numeric fields in struct expressions and patterns.
269 270 271
    (active, relaxed_adts, "1.12.0", Some(35626)),

    // The `!` type
272 273 274
    (active, never_type, "1.13.0", Some(35121)),

    // Allows all literals in attribute lists and values of key-value pairs.
275 276 277 278
    (active, attr_literals, "1.13.0", Some(34981)),

    // Allows the sysV64 ABI to be specified on all platforms
    // instead of just the platforms on which it is the C ABI
279 280
    (active, abi_sysv64, "1.13.0", Some(36167)),

281 282
    // Allows untagged unions `union U { ... }`
    (active, untagged_unions, "1.13.0", Some(32836)),
A
Andre Bogus 已提交
283

284 285 286
    // Used to identify the `compiler_builtins` crate
    // rustc internal
    (active, compiler_builtins, "1.13.0", None),
287 288 289

    // Allows attributes on lifetime/type formal parameters in generics (RFC 1327)
    (active, generic_param_attrs, "1.11.0", Some(34761)),
290

291 292
    // The #![windows_subsystem] attribute
    (active, windows_subsystem, "1.14.0", Some(37499)),
293

294 295
    // Allows #[link(..., cfg(..))]
    (active, link_cfg, "1.14.0", Some(37406)),
296 297

    (active, use_extern_macros, "1.15.0", Some(35896)),
298 299 300

    // Allows `break {expr}` with a value inside `loop`s.
    (active, loop_break_value, "1.14.0", Some(37339)),
301 302 303

    // Allows #[target_feature(...)]
    (active, target_feature, "1.15.0", None),
G
Guillaume Gomez 已提交
304

J
Jorge Aparicio 已提交
305 306
    // `extern "ptx-*" fn()`
    (active, abi_ptx, "1.15.0", None),
307 308

    // The `i128` type
E
est31 已提交
309
    (active, i128_type, "1.16.0", Some(35118)),
310 311 312

    // The `unadjusted` ABI. Perma unstable.
    (active, abi_unadjusted, "1.16.0", None),
313

314
    // Macros 1.1
315
    (active, proc_macro, "1.16.0", Some(38356)),
316

317 318
    // Allows attributes on struct literal fields.
    (active, struct_field_attributes, "1.16.0", Some(38814)),
319

V
Vadim Chugunov 已提交
320 321 322
    // Allows #[link(kind="static-nobundle"...]
    (active, static_nobundle, "1.16.0", Some(37403)),

323 324
    // `extern "msp430-interrupt" fn()`
    (active, abi_msp430_interrupt, "1.16.0", Some(38487)),
J
Jorge Aparicio 已提交
325 326 327 328

    // Used to identify crates that contain sanitizer runtimes
    // rustc internal
    (active, sanitizer_runtime, "1.17.0", None),
329 330 331 332 333 334 335
);

declare_features! (
    (removed, import_shadowing, "1.0.0", None),
    (removed, managed_boxes, "1.0.0", None),
    // Allows use of unary negate on unsigned integers, e.g. -e for e: u8
    (removed, negate_unsigned, "1.0.0", Some(29645)),
E
est31 已提交
336
    (removed, reflect, "1.0.0", Some(27749)),
337 338 339 340 341
    // A way to temporarily opt out of opt in copy. This will *never* be accepted.
    (removed, opt_out_copy, "1.0.0", None),
    (removed, quad_precision_float, "1.0.0", None),
    (removed, struct_inherit, "1.0.0", None),
    (removed, test_removed_feature, "1.0.0", None),
342
    (removed, visible_private_types, "1.0.0", None),
343
    (removed, unsafe_no_drop_flag, "1.0.0", None),
344 345 346
    // Allows using items which are missing stability attributes
    // rustc internal
    (removed, unmarked_api, "1.0.0", None),
347
    (removed, pushpop_unsafe, "1.2.0", None),
348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363
);

declare_features! (
    (accepted, associated_types, "1.0.0", None),
    // allow overloading augmented assignment operations like `a += b`
    (accepted, augmented_assignments, "1.8.0", Some(28235)),
    // allow empty structs and enum variants with braces
    (accepted, braced_empty_structs, "1.8.0", Some(29720)),
    (accepted, default_type_params, "1.0.0", None),
    (accepted, globs, "1.0.0", None),
    (accepted, if_let, "1.0.0", None),
    // A temporary feature gate used to enable parser extensions needed
    // to bootstrap fix for #5723.
    (accepted, issue_5723_bootstrap, "1.0.0", None),
    (accepted, macro_rules, "1.0.0", None),
    // Allows using #![no_std]
364
    (accepted, no_std, "1.6.0", None),
365 366 367 368 369 370
    (accepted, slicing_syntax, "1.0.0", None),
    (accepted, struct_variant, "1.0.0", None),
    // These are used to test this portion of the compiler, they don't actually
    // mean anything
    (accepted, test_accepted_feature, "1.0.0", None),
    (accepted, tuple_indexing, "1.0.0", None),
D
Daniele Baracchi 已提交
371 372
    // Allows macros to appear in the type position.
    (accepted, type_macros, "1.13.0", Some(27245)),
373 374
    (accepted, while_let, "1.0.0", None),
    // Allows `#[deprecated]` attribute
375
    (accepted, deprecated, "1.9.0", Some(29935)),
N
Nick Cameron 已提交
376
    // `expr?`
377
    (accepted, question_mark, "1.13.0", Some(31436)),
378 379
    // Allows `..` in tuple (struct) patterns
    (accepted, dotdot_in_tuple_patterns, "1.14.0", Some(33627)),
J
Jeffrey Seyfried 已提交
380
    (accepted, item_like_imports, "1.14.0", Some(35120)),
381
    // Allows using `Self` and associated types in struct expressions and patterns.
382
    (accepted, more_struct_aliases, "1.16.0", Some(37544)),
E
est31 已提交
383 384
    // elide `'static` lifetimes in `static`s and `const`s
    (accepted, static_in_const, "1.17.0", Some(35897)),
E
est31 已提交
385 386
    // Allows field shorthands (`x` meaning `x: x`) in struct literal expressions.
    (accepted, field_init_shorthand, "1.17.0", Some(37340)),
387
);
388
// (changing above list without updating src/doc/reference.md makes @cmr sad)
389

390 391 392 393 394
#[derive(PartialEq, Copy, Clone, Debug)]
pub enum AttributeType {
    /// Normal, builtin attribute that is consumed
    /// by the compiler before the unused_attribute check
    Normal,
395

396 397 398 399
    /// Builtin attribute that may not be consumed by the compiler
    /// before the unused_attribute check. These attributes
    /// will be ignored by the unused_attribute lint
    Whitelisted,
400

401 402 403 404 405 406 407
    /// Builtin attribute that is only allowed at the crate level
    CrateLevel,
}

pub enum AttributeGate {
    /// Is gated by a given feature gate, reason
    /// and function to check if enabled
408
    Gated(Stability, &'static str, &'static str, fn(&Features) -> bool),
409 410 411 412 413

    /// Ungated attribute, can be used on all release channels
    Ungated,
}

N
Nick Cameron 已提交
414 415 416 417 418 419 420 421 422 423
impl AttributeGate {
    fn is_deprecated(&self) -> bool {
        match *self {
            Gated(Stability::Deprecated(_), ..) => true,
            _ => false,
        }
    }
}

#[derive(Copy, Clone, PartialEq, Eq, Debug)]
424 425
pub enum Stability {
    Unstable,
N
Nick Cameron 已提交
426 427
    // Argument is tracking issue link.
    Deprecated(&'static str),
428 429
}

430 431 432 433
// fn() is not Debug
impl ::std::fmt::Debug for AttributeGate {
    fn fmt(&self, fmt: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
        match *self {
N
Nick Cameron 已提交
434 435
            Gated(ref stab, ref name, ref expl, _) =>
                write!(fmt, "Gated({:?}, {}, {})", stab, name, expl),
436 437 438 439 440 441 442 443 444 445 446 447
            Ungated => write!(fmt, "Ungated")
        }
    }
}

macro_rules! cfg_fn {
    ($field: ident) => {{
        fn f(features: &Features) -> bool {
            features.$field
        }
        f as fn(&Features) -> bool
    }}
448 449
}

N
Nick Cameron 已提交
450
pub fn deprecated_attributes() -> Vec<&'static (&'static str, AttributeType, AttributeGate)> {
451
    BUILTIN_ATTRIBUTES.iter().filter(|a| a.2.is_deprecated()).collect()
N
Nick Cameron 已提交
452 453
}

454 455 456 457
pub fn is_builtin_attr(attr: &ast::Attribute) -> bool {
    BUILTIN_ATTRIBUTES.iter().any(|&(builtin_name, _, _)| attr.check_name(builtin_name))
}

458
// Attributes that have a special meaning to rustc or rustdoc
459
pub const BUILTIN_ATTRIBUTES: &'static [(&'static str, AttributeType, AttributeGate)] = &[
460 461
    // Normal attributes

462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491
    ("warn", Normal, Ungated),
    ("allow", Normal, Ungated),
    ("forbid", Normal, Ungated),
    ("deny", Normal, Ungated),

    ("macro_reexport", Normal, Ungated),
    ("macro_use", Normal, Ungated),
    ("macro_export", Normal, Ungated),
    ("plugin_registrar", Normal, Ungated),

    ("cfg", Normal, Ungated),
    ("cfg_attr", Normal, Ungated),
    ("main", Normal, Ungated),
    ("start", Normal, Ungated),
    ("test", Normal, Ungated),
    ("bench", Normal, Ungated),
    ("simd", Normal, Ungated),
    ("repr", Normal, Ungated),
    ("path", Normal, Ungated),
    ("abi", Normal, Ungated),
    ("automatically_derived", Normal, Ungated),
    ("no_mangle", Normal, Ungated),
    ("no_link", Normal, Ungated),
    ("derive", Normal, Ungated),
    ("should_panic", Normal, Ungated),
    ("ignore", Normal, Ungated),
    ("no_implicit_prelude", Normal, Ungated),
    ("reexport_test_harness_main", Normal, Ungated),
    ("link_args", Normal, Ungated),
    ("macro_escape", Normal, Ungated),
492

493
    // RFC #1445.
494 495
    ("structural_match", Whitelisted, Gated(Stability::Unstable,
                                            "structural_match",
496
                                            "the semantics of constant patterns is \
497 498
                                             not yet settled",
                                            cfg_fn!(structural_match))),
499

A
Alex Crichton 已提交
500
    // Not used any more, but we can't feature gate it
501 502
    ("no_stack_check", Normal, Ungated),

503 504
    ("plugin", CrateLevel, Gated(Stability::Unstable,
                                 "plugin",
505
                                 "compiler plugins are experimental \
506 507 508
                                  and possibly buggy",
                                 cfg_fn!(plugin))),

509
    ("no_std", CrateLevel, Ungated),
510 511
    ("no_core", CrateLevel, Gated(Stability::Unstable,
                                  "no_core",
512 513
                                  "no_core is experimental",
                                  cfg_fn!(no_core))),
514 515
    ("lang", Normal, Gated(Stability::Unstable,
                           "lang_items",
516 517
                           "language items are subject to change",
                           cfg_fn!(lang_items))),
518 519
    ("linkage", Whitelisted, Gated(Stability::Unstable,
                                   "linkage",
520
                                   "the `linkage` attribute is experimental \
521 522
                                    and not portable across platforms",
                                   cfg_fn!(linkage))),
523 524
    ("thread_local", Whitelisted, Gated(Stability::Unstable,
                                        "thread_local",
525 526 527
                                        "`#[thread_local]` is an experimental feature, and does \
                                         not currently handle destructors. There is no \
                                         corresponding `#[task_local]` mapping to the task \
528 529
                                         model",
                                        cfg_fn!(thread_local))),
530

531 532
    ("rustc_on_unimplemented", Normal, Gated(Stability::Unstable,
                                             "on_unimplemented",
533
                                             "the `#[rustc_on_unimplemented]` attribute \
534 535
                                              is an experimental feature",
                                             cfg_fn!(on_unimplemented))),
536 537
    ("allocator", Whitelisted, Gated(Stability::Unstable,
                                     "allocator",
538 539
                                     "the `#[allocator]` attribute is an experimental feature",
                                     cfg_fn!(allocator))),
540 541
    ("needs_allocator", Normal, Gated(Stability::Unstable,
                                      "needs_allocator",
542 543
                                      "the `#[needs_allocator]` \
                                       attribute is an experimental \
544 545
                                       feature",
                                      cfg_fn!(needs_allocator))),
546 547
    ("panic_runtime", Whitelisted, Gated(Stability::Unstable,
                                         "panic_runtime",
548 549 550
                                         "the `#[panic_runtime]` attribute is \
                                          an experimental feature",
                                         cfg_fn!(panic_runtime))),
551 552
    ("needs_panic_runtime", Whitelisted, Gated(Stability::Unstable,
                                               "needs_panic_runtime",
553 554 555 556
                                               "the `#[needs_panic_runtime]` \
                                                attribute is an experimental \
                                                feature",
                                               cfg_fn!(needs_panic_runtime))),
557 558
    ("rustc_variance", Normal, Gated(Stability::Unstable,
                                     "rustc_attrs",
559
                                     "the `#[rustc_variance]` attribute \
N
Niko Matsakis 已提交
560
                                      is just used for rustc unit tests \
561 562
                                      and will never be stable",
                                     cfg_fn!(rustc_attrs))),
563 564
    ("rustc_error", Whitelisted, Gated(Stability::Unstable,
                                       "rustc_attrs",
565
                                       "the `#[rustc_error]` attribute \
N
Niko Matsakis 已提交
566
                                        is just used for rustc unit tests \
567 568
                                        and will never be stable",
                                       cfg_fn!(rustc_attrs))),
569 570
    ("rustc_if_this_changed", Whitelisted, Gated(Stability::Unstable,
                                                 "rustc_attrs",
571 572 573 574
                                                 "the `#[rustc_if_this_changed]` attribute \
                                                  is just used for rustc unit tests \
                                                  and will never be stable",
                                                 cfg_fn!(rustc_attrs))),
575 576
    ("rustc_then_this_would_need", Whitelisted, Gated(Stability::Unstable,
                                                      "rustc_attrs",
577 578 579 580
                                                      "the `#[rustc_if_this_changed]` attribute \
                                                       is just used for rustc unit tests \
                                                       and will never be stable",
                                                      cfg_fn!(rustc_attrs))),
581 582
    ("rustc_dirty", Whitelisted, Gated(Stability::Unstable,
                                       "rustc_attrs",
583 584
                                       "the `#[rustc_dirty]` attribute \
                                        is just used for rustc unit tests \
585 586
                                        and will never be stable",
                                       cfg_fn!(rustc_attrs))),
587 588
    ("rustc_clean", Whitelisted, Gated(Stability::Unstable,
                                       "rustc_attrs",
589 590
                                       "the `#[rustc_clean]` attribute \
                                        is just used for rustc unit tests \
591 592
                                        and will never be stable",
                                       cfg_fn!(rustc_attrs))),
593 594
    ("rustc_metadata_dirty", Whitelisted, Gated(Stability::Unstable,
                                                "rustc_attrs",
595 596 597 598
                                                "the `#[rustc_metadata_dirty]` attribute \
                                                 is just used for rustc unit tests \
                                                 and will never be stable",
                                                 cfg_fn!(rustc_attrs))),
599 600
    ("rustc_metadata_clean", Whitelisted, Gated(Stability::Unstable,
                                                "rustc_attrs",
601 602 603 604
                                                "the `#[rustc_metadata_clean]` attribute \
                                                 is just used for rustc unit tests \
                                                 and will never be stable",
                                                 cfg_fn!(rustc_attrs))),
605 606
    ("rustc_partition_reused", Whitelisted, Gated(Stability::Unstable,
                                                  "rustc_attrs",
607 608 609 610
                                                  "this attribute \
                                                   is just used for rustc unit tests \
                                                   and will never be stable",
                                                  cfg_fn!(rustc_attrs))),
611 612
    ("rustc_partition_translated", Whitelisted, Gated(Stability::Unstable,
                                                      "rustc_attrs",
613 614 615 616
                                                      "this attribute \
                                                       is just used for rustc unit tests \
                                                       and will never be stable",
                                                      cfg_fn!(rustc_attrs))),
617 618
    ("rustc_symbol_name", Whitelisted, Gated(Stability::Unstable,
                                             "rustc_attrs",
619 620
                                             "internal rustc attributes will never be stable",
                                             cfg_fn!(rustc_attrs))),
621 622
    ("rustc_item_path", Whitelisted, Gated(Stability::Unstable,
                                           "rustc_attrs",
623 624
                                           "internal rustc attributes will never be stable",
                                           cfg_fn!(rustc_attrs))),
625 626
    ("rustc_move_fragments", Normal, Gated(Stability::Unstable,
                                           "rustc_attrs",
627
                                           "the `#[rustc_move_fragments]` attribute \
N
Niko Matsakis 已提交
628
                                            is just used for rustc unit tests \
629 630
                                            and will never be stable",
                                           cfg_fn!(rustc_attrs))),
631 632
    ("rustc_mir", Whitelisted, Gated(Stability::Unstable,
                                     "rustc_attrs",
633 634
                                     "the `#[rustc_mir]` attribute \
                                      is just used for rustc unit tests \
635 636
                                      and will never be stable",
                                     cfg_fn!(rustc_attrs))),
637 638
    ("rustc_inherit_overflow_checks", Whitelisted, Gated(Stability::Unstable,
                                                         "rustc_attrs",
639 640 641 642 643 644
                                                         "the `#[rustc_inherit_overflow_checks]` \
                                                          attribute is just used to control \
                                                          overflow checking behavior of several \
                                                          libcore functions that are inlined \
                                                          across crates and will never be stable",
                                                          cfg_fn!(rustc_attrs))),
645 646
    ("compiler_builtins", Whitelisted, Gated(Stability::Unstable,
                                             "compiler_builtins",
647 648 649 650 651
                                             "the `#[compiler_builtins]` attribute is used to \
                                              identify the `compiler_builtins` crate which \
                                              contains compiler-rt intrinsics and will never be \
                                              stable",
                                          cfg_fn!(compiler_builtins))),
J
Jorge Aparicio 已提交
652 653 654 655 656 657
    ("sanitizer_runtime", Whitelisted, Gated(Stability::Unstable,
                                             "sanitizer_runtime",
                                             "the `#[sanitizer_runtime]` attribute is used to \
                                              identify crates that contain the runtime of a \
                                              sanitizer and will never be stable",
                                             cfg_fn!(sanitizer_runtime))),
658

659 660
    ("allow_internal_unstable", Normal, Gated(Stability::Unstable,
                                              "allow_internal_unstable",
661 662
                                              EXPLAIN_ALLOW_INTERNAL_UNSTABLE,
                                              cfg_fn!(allow_internal_unstable))),
663

664 665
    ("fundamental", Whitelisted, Gated(Stability::Unstable,
                                       "fundamental",
666
                                       "the `#[fundamental]` attribute \
667 668
                                        is an experimental feature",
                                       cfg_fn!(fundamental))),
669

670
    ("proc_macro_derive", Normal, Ungated),
671

672 673
    ("rustc_copy_clone_marker", Whitelisted, Gated(Stability::Unstable,
                                                   "rustc_attrs",
674 675 676
                                                   "internal implementation detail",
                                                   cfg_fn!(rustc_attrs))),

677
    // FIXME: #14408 whitelist docs since rustdoc looks at them
678
    ("doc", Whitelisted, Ungated),
679 680 681

    // FIXME: #14406 these are processed in trans, which happens after the
    // lint pass
682
    ("cold", Whitelisted, Ungated),
683 684
    ("naked", Whitelisted, Gated(Stability::Unstable,
                                 "naked_functions",
T
Ticki 已提交
685
                                 "the `#[naked]` attribute \
686
                                  is an experimental feature",
687
                                 cfg_fn!(naked_functions))),
688 689 690 691
    ("target_feature", Whitelisted, Gated(
        Stability::Unstable, "target_feature",
        "the `#[target_feature]` attribute is an experimental feature",
        cfg_fn!(target_feature))),
692 693 694 695 696 697 698
    ("export_name", Whitelisted, Ungated),
    ("inline", Whitelisted, Ungated),
    ("link", Whitelisted, Ungated),
    ("link_name", Whitelisted, Ungated),
    ("link_section", Whitelisted, Ungated),
    ("no_builtins", Whitelisted, Ungated),
    ("no_mangle", Whitelisted, Ungated),
N
Nick Cameron 已提交
699 700 701 702 703
    ("no_debug", Whitelisted, Gated(
        Stability::Deprecated("https://github.com/rust-lang/rust/issues/29721"),
        "no_debug",
        "the `#[no_debug]` attribute is an experimental feature",
        cfg_fn!(no_debug))),
704 705
    ("omit_gdb_pretty_printer_section", Whitelisted, Gated(Stability::Unstable,
                                                       "omit_gdb_pretty_printer_section",
706 707
                                                       "the `#[omit_gdb_pretty_printer_section]` \
                                                        attribute is just used for the Rust test \
708 709
                                                        suite",
                                                       cfg_fn!(omit_gdb_pretty_printer_section))),
710 711
    ("unsafe_destructor_blind_to_params",
     Normal,
712
     Gated(Stability::Deprecated("https://github.com/rust-lang/rust/issues/34761"),
713
           "dropck_parametricity",
714 715
           "unsafe_destructor_blind_to_params has been replaced by \
            may_dangle and will be removed in the future",
716
           cfg_fn!(dropck_parametricity))),
717 718
    ("may_dangle",
     Normal,
719 720
     Gated(Stability::Unstable,
           "dropck_eyepatch",
721 722
           "may_dangle has unstable semantics and may be removed in the future",
           cfg_fn!(dropck_eyepatch))),
723 724 725
    ("unwind", Whitelisted, Gated(Stability::Unstable,
                                  "unwind_attributes",
                                  "#[unwind] is experimental",
726
                                  cfg_fn!(unwind_attributes))),
727 728

    // used in resolve
729 730
    ("prelude_import", Whitelisted, Gated(Stability::Unstable,
                                          "prelude_import",
731 732
                                          "`#[prelude_import]` is for use by rustc only",
                                          cfg_fn!(prelude_import))),
733 734 735

    // FIXME: #14407 these are only looked at on-demand so we can't
    // guarantee they'll have already been checked
736
    ("rustc_deprecated", Whitelisted, Ungated),
737 738 739
    ("must_use", Whitelisted, Ungated),
    ("stable", Whitelisted, Ungated),
    ("unstable", Whitelisted, Ungated),
740
    ("deprecated", Normal, Ungated),
741

742 743
    ("rustc_paren_sugar", Normal, Gated(Stability::Unstable,
                                        "unboxed_closures",
744 745
                                        "unboxed_closures are still evolving",
                                        cfg_fn!(unboxed_closures))),
746

747 748 749
    ("windows_subsystem", Whitelisted, Gated(Stability::Unstable,
                                             "windows_subsystem",
                                             "the windows subsystem attribute \
A
Alex Crichton 已提交
750
                                              is currently unstable",
751 752
                                             cfg_fn!(windows_subsystem))),

753 754 755 756 757 758 759 760 761 762
    ("proc_macro_attribute", Normal, Gated(Stability::Unstable,
                                           "proc_macro",
                                           "attribute proc macros are currently unstable",
                                           cfg_fn!(proc_macro))),

    ("rustc_derive_registrar", Normal, Gated(Stability::Unstable,
                                             "rustc_derive_registrar",
                                             "used internally by rustc",
                                             cfg_fn!(rustc_attrs))),

763
    // Crate level attributes
764 765 766 767 768 769 770 771
    ("crate_name", CrateLevel, Ungated),
    ("crate_type", CrateLevel, Ungated),
    ("crate_id", CrateLevel, Ungated),
    ("feature", CrateLevel, Ungated),
    ("no_start", CrateLevel, Ungated),
    ("no_main", CrateLevel, Ungated),
    ("no_builtins", CrateLevel, Ungated),
    ("recursion_limit", CrateLevel, Ungated),
772
    ("type_length_limit", CrateLevel, Ungated),
773 774
];

775 776 777
// cfg(...)'s that are feature gated
const GATED_CFGS: &'static [(&'static str, &'static str, fn(&Features) -> bool)] = &[
    // (name in cfg, feature, function to check if the feature is enabled)
778 779 780
    ("target_feature", "cfg_target_feature", cfg_fn!(cfg_target_feature)),
    ("target_vendor", "cfg_target_vendor", cfg_fn!(cfg_target_vendor)),
    ("target_thread_local", "cfg_target_thread_local", cfg_fn!(cfg_target_thread_local)),
781
    ("target_has_atomic", "cfg_target_has_atomic", cfg_fn!(cfg_target_has_atomic)),
782 783 784 785 786 787 788
];

#[derive(Debug, Eq, PartialEq)]
pub struct GatedCfg {
    span: Span,
    index: usize,
}
789

790 791
impl GatedCfg {
    pub fn gate(cfg: &ast::MetaItem) -> Option<GatedCfg> {
792
        let name = &*cfg.name().as_str();
793 794 795 796 797 798 799 800 801
        GATED_CFGS.iter()
                  .position(|info| info.0 == name)
                  .map(|idx| {
                      GatedCfg {
                          span: cfg.span,
                          index: idx
                      }
                  })
    }
J
Jeffrey Seyfried 已提交
802 803

    pub fn check_and_emit(&self, sess: &ParseSess, features: &Features) {
804
        let (cfg, feature, has_feature) = GATED_CFGS[self.index];
J
Jeffrey Seyfried 已提交
805
        if !has_feature(features) && !sess.codemap().span_allows_unstable(self.span) {
806
            let explain = format!("`cfg({})` is experimental and subject to change", cfg);
807
            emit_feature_err(sess, feature, self.span, GateIssue::Language, &explain);
808 809 810 811
        }
    }
}

E
Eduard Burtescu 已提交
812
struct Context<'a> {
L
Leo Testard 已提交
813
    features: &'a Features,
814
    parse_sess: &'a ParseSess,
C
Corey Richardson 已提交
815
    cm: &'a CodeMap,
816
    plugin_attributes: &'a [(String, AttributeType)],
817 818
}

819 820 821 822 823 824
macro_rules! gate_feature_fn {
    ($cx: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{
        let (cx, has_feature, span, name, explain) = ($cx, $has_feature, $span, $name, $explain);
        let has_feature: bool = has_feature(&$cx.features);
        debug!("gate_feature(feature = {:?}, span = {:?}); has? {}", name, span, has_feature);
        if !has_feature && !cx.cm.span_allows_unstable(span) {
825
            emit_feature_err(cx.parse_sess, name, span, GateIssue::Language, explain);
826
        }
827 828 829 830 831 832
    }}
}

macro_rules! gate_feature {
    ($cx: expr, $feature: ident, $span: expr, $explain: expr) => {
        gate_feature_fn!($cx, |x:&Features| x.$feature, $span, stringify!($feature), $explain)
833
    }
834
}
835

836
impl<'a> Context<'a> {
837
    fn check_attribute(&self, attr: &ast::Attribute, is_macro: bool) {
838
        debug!("check_attribute(attr = {:?})", attr);
839
        let name = &*attr.name().as_str();
840
        for &(n, ty, ref gateage) in BUILTIN_ATTRIBUTES {
841
            if n == name {
842
                if let &Gated(_, ref name, ref desc, ref has_feature) = gateage {
843
                    gate_feature_fn!(self, has_feature, attr.span, name, desc);
844
                }
845
                debug!("check_attribute: {:?} is builtin, {:?}, {:?}", name, ty, gateage);
846 847 848
                return;
            }
        }
849
        for &(ref n, ref ty) in self.plugin_attributes {
850
            if n == name {
851
                // Plugins can't gate attributes, so we don't check for it
M
Manish Goregaokar 已提交
852 853
                // unlike the code above; we only use this loop to
                // short-circuit to avoid the checks below
854 855 856 857
                debug!("check_attribute: {:?} is registered by a plugin, {:?}", name, ty);
                return;
            }
        }
858
        if name.starts_with("rustc_") {
859 860 861 862
            gate_feature!(self, rustc_attrs, attr.span,
                          "unless otherwise specified, attributes \
                           with the prefix `rustc_` \
                           are reserved for internal compiler diagnostics");
863
        } else if name.starts_with("derive_") {
L
Leo Testard 已提交
864
            gate_feature!(self, custom_derive, attr.span, EXPLAIN_DERIVE_UNDERSCORE);
865 866
        } else if attr::is_known(attr) {
            debug!("check_attribute: {:?} is known", name);
867
        } else {
M
Manish Goregaokar 已提交
868 869 870 871
            // Only run the custom attribute lint during regular
            // feature gate checking. Macro gating runs
            // before the plugin attributes are registered
            // so we skip this then
872
            if !is_macro {
873 874 875 876 877 878
                gate_feature!(self, custom_attribute, attr.span,
                              &format!("The attribute `{}` is currently \
                                        unknown to the compiler and \
                                        may have meaning \
                                        added to it in the future",
                                       name));
879
            }
880 881
        }
    }
882 883
}

884
pub fn check_attribute(attr: &ast::Attribute, parse_sess: &ParseSess,
L
Leo Testard 已提交
885 886
                       cm: &CodeMap, features: &Features) {
    let cx = Context {
887
        features: features, parse_sess: parse_sess,
L
Leo Testard 已提交
888 889 890 891 892
        cm: cm, plugin_attributes: &[]
    };
    cx.check_attribute(attr, true);
}

893 894 895 896
pub fn find_lang_feature_accepted_version(feature: &str) -> Option<&'static str> {
    ACCEPTED_FEATURES.iter().find(|t| t.0 == feature).map(|t| t.1)
}

897
fn find_lang_feature_issue(feature: &str) -> Option<u32> {
898 899
    if let Some(info) = ACTIVE_FEATURES.iter().find(|t| t.0 == feature) {
        let issue = info.2;
900 901
        // FIXME (#28244): enforce that active features have issue numbers
        // assert!(issue.is_some())
902 903 904
        issue
    } else {
        // search in Accepted or Removed features
905 906 907 908
        match ACCEPTED_FEATURES.iter().chain(REMOVED_FEATURES).find(|t| t.0 == feature) {
            Some(&(_, _, issue)) => issue,
            None => panic!("Feature `{}` is not declared anywhere", feature),
        }
909 910 911 912 913 914 915 916
    }
}

pub enum GateIssue {
    Language,
    Library(Option<u32>)
}

917
pub fn emit_feature_err(sess: &ParseSess, feature: &str, span: Span, issue: GateIssue,
918
                        explain: &str) {
919 920 921 922 923
    feature_err(sess, feature, span, issue, explain).emit();
}

pub fn feature_err<'a>(sess: &'a ParseSess, feature: &str, span: Span, issue: GateIssue,
                   explain: &str) -> DiagnosticBuilder<'a> {
924 925
    let diag = &sess.span_diagnostic;

926 927 928 929 930
    let issue = match issue {
        GateIssue::Language => find_lang_feature_issue(feature),
        GateIssue::Library(lib) => lib,
    };

N
Nick Cameron 已提交
931 932
    let mut err = if let Some(n) = issue {
        diag.struct_span_err(span, &format!("{} (see issue #{})", explain, n))
933
    } else {
N
Nick Cameron 已提交
934 935
        diag.struct_span_err(span, explain)
    };
936 937

    // #23973: do not suggest `#![feature(...)]` if we are in beta/stable
T
Tim Neumann 已提交
938 939 940 941
    if sess.unstable_features.is_nightly_build() {
        err.help(&format!("add #![feature({})] to the \
                           crate attributes to enable",
                          feature));
N
Nick Cameron 已提交
942
    }
T
Tim Neumann 已提交
943

944
    err
945 946
}

L
Leo Testard 已提交
947 948 949
const EXPLAIN_BOX_SYNTAX: &'static str =
    "box expression syntax is experimental; you can call `Box::new` instead.";

J
Jeffrey Seyfried 已提交
950
pub const EXPLAIN_STMT_ATTR_SYNTAX: &'static str =
L
Leo Testard 已提交
951 952
    "attributes on non-item statements and expressions are experimental.";

953 954 955
pub const EXPLAIN_ASM: &'static str =
    "inline assembly is not stable enough for use and is subject to change";

956 957 958 959 960 961 962 963
pub const EXPLAIN_LOG_SYNTAX: &'static str =
    "`log_syntax!` is not stable enough for use and is subject to change";

pub const EXPLAIN_CONCAT_IDENTS: &'static str =
    "`concat_idents` is not stable enough for use and is subject to change";

pub const EXPLAIN_TRACE_MACROS: &'static str =
    "`trace_macros` is not stable enough for use and is subject to change";
964 965
pub const EXPLAIN_ALLOW_INTERNAL_UNSTABLE: &'static str =
    "allow_internal_unstable side-steps feature gating and stability checks";
966

967
pub const EXPLAIN_CUSTOM_DERIVE: &'static str =
968
    "`#[derive]` for custom traits is deprecated and will be removed in the future.";
N
Nick Cameron 已提交
969 970

pub const EXPLAIN_DEPR_CUSTOM_DERIVE: &'static str =
971 972
    "`#[derive]` for custom traits is deprecated and will be removed in the future. \
    Prefer using procedural macro custom derive.";
973

L
Leo Testard 已提交
974 975
pub const EXPLAIN_DERIVE_UNDERSCORE: &'static str =
    "attributes of the form `#[derive_*]` are reserved for the compiler";
976

L
Leo Testard 已提交
977 978
pub const EXPLAIN_PLACEMENT_IN: &'static str =
    "placement-in expression syntax is experimental and subject to change.";
C
Corey Richardson 已提交
979 980

struct PostExpansionVisitor<'a> {
N
Nick Cameron 已提交
981
    context: &'a Context<'a>,
C
Corey Richardson 已提交
982 983
}

984 985 986 987 988
macro_rules! gate_feature_post {
    ($cx: expr, $feature: ident, $span: expr, $explain: expr) => {{
        let (cx, span) = ($cx, $span);
        if !cx.context.cm.span_allows_unstable(span) {
            gate_feature!(cx.context, $feature, span, $explain)
C
Corey Richardson 已提交
989
        }
990
    }}
C
Corey Richardson 已提交
991 992
}

993 994 995
impl<'a> PostExpansionVisitor<'a> {
    fn check_abi(&self, abi: Abi, span: Span) {
        match abi {
996
            Abi::RustIntrinsic => {
997
                gate_feature_post!(&self, intrinsics, span,
998 999
                                   "intrinsics are subject to change");
            },
1000 1001
            Abi::PlatformIntrinsic => {
                gate_feature_post!(&self, platform_intrinsics, span,
1002
                                   "platform intrinsics are experimental and possibly buggy");
1003 1004 1005
            },
            Abi::Vectorcall => {
                gate_feature_post!(&self, abi_vectorcall, span,
1006 1007
                                   "vectorcall is experimental and subject to change");
            },
1008 1009 1010
            Abi::RustCall => {
                gate_feature_post!(&self, unboxed_closures, span,
                                   "rust-call ABI is subject to change");
1011 1012 1013 1014 1015
            },
            Abi::SysV64 => {
                gate_feature_post!(&self, abi_sysv64, span,
                                   "sysv64 ABI is experimental and subject to change");
            },
J
Jorge Aparicio 已提交
1016 1017 1018
            Abi::PtxKernel => {
                gate_feature_post!(&self, abi_ptx, span,
                                   "PTX ABIs are experimental and subject to change");
1019 1020 1021 1022 1023
            },
            Abi::Unadjusted => {
                gate_feature_post!(&self, abi_unadjusted, span,
                                   "unadjusted ABI is an implementation detail and perma-unstable");
            },
1024 1025 1026 1027
            Abi::Msp430Interrupt => {
                gate_feature_post!(&self, abi_msp430_interrupt, span,
                                   "msp430-interrupt ABI is experimental and subject to change");
            },
J
Jorge Aparicio 已提交
1028 1029 1030 1031 1032 1033 1034 1035 1036
            // Stable
            Abi::Cdecl |
            Abi::Stdcall |
            Abi::Fastcall |
            Abi::Aapcs |
            Abi::Win64 |
            Abi::Rust |
            Abi::C |
            Abi::System => {}
1037 1038 1039 1040
        }
    }
}

1041 1042 1043 1044 1045
fn contains_novel_literal(item: &ast::MetaItem) -> bool {
    use ast::MetaItemKind::*;
    use ast::NestedMetaItemKind::*;

    match item.node {
1046 1047 1048
        Word => false,
        NameValue(ref lit) => !lit.node.is_str(),
        List(ref list) => list.iter().any(|li| {
1049
            match li.node {
1050
                MetaItem(ref mi) => contains_novel_literal(&mi),
1051 1052 1053 1054 1055 1056
                Literal(_) => true,
            }
        }),
    }
}

1057 1058 1059 1060
fn starts_with_digit(s: &str) -> bool {
    s.as_bytes().first().cloned().map_or(false, |b| b >= b'0' && b <= b'9')
}

1061
impl<'a> Visitor<'a> for PostExpansionVisitor<'a> {
1062 1063
    fn visit_attribute(&mut self, attr: &ast::Attribute) {
        if !self.context.cm.span_allows_unstable(attr.span) {
1064
            // check for gated attributes
1065
            self.context.check_attribute(attr, false);
1066
        }
1067

1068
        if contains_novel_literal(&attr.value) {
1069 1070 1071 1072
            gate_feature_post!(&self, attr_literals, attr.span,
                               "non-string literals in attributes, or string \
                               literals in top-level positions, are experimental");
        }
1073 1074
    }

1075
    fn visit_name(&mut self, sp: Span, name: ast::Name) {
1076
        if !name.as_str().is_ascii() {
1077 1078
            gate_feature_post!(&self, non_ascii_idents, sp,
                               "non-ascii idents are not fully supported.");
1079 1080 1081
        }
    }

1082
    fn visit_item(&mut self, i: &'a ast::Item) {
1083
        match i.node {
1084
            ast::ItemKind::ExternCrate(_) => {
1085
                if attr::contains_name(&i.attrs[..], "macro_reexport") {
1086 1087 1088
                    gate_feature_post!(&self, macro_reexport, i.span,
                                       "macros reexports are experimental \
                                        and possibly buggy");
1089 1090 1091
                }
            }

1092
            ast::ItemKind::ForeignMod(ref foreign_module) => {
1093
                if attr::contains_name(&i.attrs[..], "link_args") {
1094
                    gate_feature_post!(&self, link_args, i.span,
1095 1096 1097 1098
                                      "the `link_args` attribute is not portable \
                                       across platforms, it is recommended to \
                                       use `#[link(name = \"foo\")]` instead")
                }
1099
                self.check_abi(foreign_module.abi, i.span);
1100 1101
            }

1102
            ast::ItemKind::Fn(..) => {
1103
                if attr::contains_name(&i.attrs[..], "plugin_registrar") {
1104 1105
                    gate_feature_post!(&self, plugin_registrar, i.span,
                                       "compiler plugins are experimental and possibly buggy");
1106
                }
1107
                if attr::contains_name(&i.attrs[..], "start") {
1108
                    gate_feature_post!(&self, start, i.span,
1109 1110 1111 1112
                                      "a #[start] function is an experimental \
                                       feature whose signature may change \
                                       over time");
                }
1113
                if attr::contains_name(&i.attrs[..], "main") {
1114 1115 1116 1117
                    gate_feature_post!(&self, main, i.span,
                                       "declaration of a nonstandard #[main] \
                                        function may change over time, for now \
                                        a top-level `fn main()` is required");
1118
                }
1119 1120
            }

1121
            ast::ItemKind::Struct(..) => {
1122
                if attr::contains_name(&i.attrs[..], "simd") {
1123 1124
                    gate_feature_post!(&self, simd, i.span,
                                       "SIMD types are experimental and possibly buggy");
1125 1126 1127 1128
                    self.context.parse_sess.span_diagnostic.span_warn(i.span,
                                                                      "the `#[simd]` attribute \
                                                                       is deprecated, use \
                                                                       `#[repr(simd)]` instead");
1129 1130 1131 1132
                }
                for attr in &i.attrs {
                    if attr.name() == "repr" {
                        for item in attr.meta_item_list().unwrap_or(&[]) {
1133
                            if item.check_name("simd") {
1134 1135 1136
                                gate_feature_post!(&self, repr_simd, i.span,
                                                   "SIMD types are experimental \
                                                    and possibly buggy");
1137 1138 1139 1140

                            }
                        }
                    }
1141
                }
D
David Manescu 已提交
1142 1143
            }

1144 1145 1146
            ast::ItemKind::Union(..) => {
                gate_feature_post!(&self, untagged_unions,
                                   i.span,
V
Vadim Petrochenkov 已提交
1147
                                   "unions are unstable and possibly buggy");
1148 1149
            }

1150
            ast::ItemKind::DefaultImpl(..) => {
1151 1152 1153 1154
                gate_feature_post!(&self, optin_builtin_traits,
                                   i.span,
                                   "default trait implementations are experimental \
                                    and possibly buggy");
F
Flavio Percoco 已提交
1155 1156
            }

1157
            ast::ItemKind::Impl(_, polarity, _, _, _, _) => {
1158 1159
                match polarity {
                    ast::ImplPolarity::Negative => {
1160 1161 1162 1163
                        gate_feature_post!(&self, optin_builtin_traits,
                                           i.span,
                                           "negative trait bounds are not yet fully implemented; \
                                            use marker types for now");
1164 1165 1166
                    },
                    _ => {}
                }
1167 1168
            }

1169 1170 1171
            _ => {}
        }

1172
        visit::walk_item(self, i);
1173
    }
1174

1175
    fn visit_foreign_item(&mut self, i: &'a ast::ForeignItem) {
1176 1177
        let links_to_llvm = match attr::first_attr_value_str_by_name(&i.attrs, "link_name") {
            Some(val) => val.as_str().starts_with("llvm."),
1178 1179 1180
            _ => false
        };
        if links_to_llvm {
1181
            gate_feature_post!(&self, link_llvm_intrinsics, i.span,
1182 1183 1184
                              "linking to LLVM intrinsics is experimental");
        }

1185
        visit::walk_foreign_item(self, i)
1186 1187
    }

1188
    fn visit_ty(&mut self, ty: &'a ast::Ty) {
1189 1190 1191 1192
        match ty.node {
            ast::TyKind::BareFn(ref bare_fn_ty) => {
                self.check_abi(bare_fn_ty.abi, ty.span);
            }
1193 1194 1195 1196
            ast::TyKind::ImplTrait(..) => {
                gate_feature_post!(&self, conservative_impl_trait, ty.span,
                                   "`impl Trait` is experimental");
            }
A
Andrew Cann 已提交
1197 1198
            ast::TyKind::Never => {
                gate_feature_post!(&self, never_type, ty.span,
1199 1200
                                   "The `!` type is experimental");
            },
1201 1202 1203 1204 1205
            _ => {}
        }
        visit::walk_ty(self, ty)
    }

1206
    fn visit_fn_ret_ty(&mut self, ret_ty: &'a ast::FunctionRetTy) {
1207 1208
        if let ast::FunctionRetTy::Ty(ref output_ty) = *ret_ty {
            match output_ty.node {
A
Andrew Cann 已提交
1209
                ast::TyKind::Never => return,
1210 1211
                _ => (),
            };
A
Andrew Cann 已提交
1212
            self.visit_ty(output_ty)
1213 1214 1215
        }
    }

1216
    fn visit_expr(&mut self, e: &'a ast::Expr) {
1217
        match e.node {
1218
            ast::ExprKind::Box(_) => {
1219
                gate_feature_post!(&self, box_syntax, e.span, EXPLAIN_BOX_SYNTAX);
1220
            }
1221
            ast::ExprKind::Type(..) => {
1222
                gate_feature_post!(&self, type_ascription, e.span,
1223 1224
                                  "type ascription is experimental");
            }
1225
            ast::ExprKind::Range(_, _, ast::RangeLimits::Closed) => {
1226
                gate_feature_post!(&self, inclusive_range_syntax,
A
Alex Burka 已提交
1227 1228 1229
                                  e.span,
                                  "inclusive range syntax is experimental");
            }
1230 1231 1232
            ast::ExprKind::InPlace(..) => {
                gate_feature_post!(&self, placement_in_syntax, e.span, EXPLAIN_PLACEMENT_IN);
            }
1233 1234
            ast::ExprKind::Struct(_, ref fields, _) => {
                for field in fields {
1235 1236 1237 1238 1239
                    if starts_with_digit(&field.ident.node.name.as_str()) {
                        gate_feature_post!(&self, relaxed_adts,
                                          field.span,
                                          "numeric fields in struct expressions are unstable");
                    }
1240 1241
                }
            }
1242 1243 1244 1245
            ast::ExprKind::Break(_, Some(_)) => {
                gate_feature_post!(&self, loop_break_value, e.span,
                                   "`break` with a value is experimental");
            }
1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257
            ast::ExprKind::Lit(ref lit) => {
                if let ast::LitKind::Int(_, ref ty) = lit.node {
                    match *ty {
                        ast::LitIntType::Signed(ast::IntTy::I128) |
                        ast::LitIntType::Unsigned(ast::UintTy::U128) => {
                            gate_feature_post!(&self, i128_type, e.span,
                                               "128-bit integers are not stable");
                        }
                        _ => {}
                    }
                }
            }
1258 1259
            _ => {}
        }
1260
        visit::walk_expr(self, e);
1261
    }
1262

1263
    fn visit_pat(&mut self, pattern: &'a ast::Pat) {
1264
        match pattern.node {
1265
            PatKind::Slice(_, Some(_), ref last) if !last.is_empty() => {
1266
                gate_feature_post!(&self, advanced_slice_patterns,
1267 1268 1269
                                  pattern.span,
                                  "multiple-element slice matches anywhere \
                                   but at the end of a slice (e.g. \
1270
                                   `[0, ..xs, 0]`) are experimental")
1271
            }
1272
            PatKind::Slice(..) => {
1273
                gate_feature_post!(&self, slice_patterns,
1274 1275 1276
                                  pattern.span,
                                  "slice pattern syntax is experimental");
            }
1277
            PatKind::Box(..) => {
1278
                gate_feature_post!(&self, box_patterns,
1279
                                  pattern.span,
1280
                                  "box pattern syntax is experimental");
1281
            }
1282 1283 1284 1285 1286 1287 1288 1289
            PatKind::Struct(_, ref fields, _) => {
                for field in fields {
                    if starts_with_digit(&field.node.ident.name.as_str()) {
                        gate_feature_post!(&self, relaxed_adts,
                                          field.span,
                                          "numeric fields in struct patterns are unstable");
                    }
                }
1290
            }
1291 1292 1293 1294
            PatKind::Range(_, _, RangeEnd::Excluded) => {
                gate_feature_post!(&self, exclusive_range_pattern, pattern.span,
                                   "exclusive range pattern syntax is experimental");
            }
1295 1296
            _ => {}
        }
1297
        visit::walk_pat(self, pattern)
1298 1299
    }

1300
    fn visit_fn(&mut self,
1301 1302
                fn_kind: FnKind<'a>,
                fn_decl: &'a ast::FnDecl,
1303
                span: Span,
1304
                _node_id: NodeId) {
N
Niko Matsakis 已提交
1305 1306
        // check for const fn declarations
        match fn_kind {
1307
            FnKind::ItemFn(_, _, _, Spanned { node: ast::Constness::Const, .. }, _, _, _) => {
1308
                gate_feature_post!(&self, const_fn, span, "const fn is unstable");
N
Niko Matsakis 已提交
1309 1310 1311 1312 1313 1314 1315 1316 1317
            }
            _ => {
                // stability of const fn methods are covered in
                // visit_trait_item and visit_impl_item below; this is
                // because default methods don't pass through this
                // point.
            }
        }

1318
        match fn_kind {
1319 1320
            FnKind::ItemFn(_, _, _, _, abi, _, _) |
            FnKind::Method(_, &ast::MethodSig { abi, .. }, _, _) => {
1321 1322
                self.check_abi(abi, span);
            }
1323 1324
            _ => {}
        }
1325
        visit::walk_fn(self, fn_kind, fn_decl, span);
1326
    }
1327

1328
    fn visit_trait_item(&mut self, ti: &'a ast::TraitItem) {
1329
        match ti.node {
1330
            ast::TraitItemKind::Const(..) => {
1331
                gate_feature_post!(&self, associated_consts,
1332 1333 1334
                                  ti.span,
                                  "associated constants are experimental")
            }
1335 1336 1337 1338
            ast::TraitItemKind::Method(ref sig, ref block) => {
                if block.is_none() {
                    self.check_abi(sig.abi, ti.span);
                }
1339
                if sig.constness.node == ast::Constness::Const {
1340
                    gate_feature_post!(&self, const_fn, ti.span, "const fn is unstable");
N
Niko Matsakis 已提交
1341 1342
                }
            }
1343
            ast::TraitItemKind::Type(_, Some(_)) => {
1344
                gate_feature_post!(&self, associated_type_defaults, ti.span,
1345 1346
                                  "associated type defaults are unstable");
            }
1347 1348 1349 1350 1351
            _ => {}
        }
        visit::walk_trait_item(self, ti);
    }

1352
    fn visit_impl_item(&mut self, ii: &'a ast::ImplItem) {
A
Aaron Turon 已提交
1353
        if ii.defaultness == ast::Defaultness::Default {
1354
            gate_feature_post!(&self, specialization,
A
Aaron Turon 已提交
1355 1356 1357 1358
                              ii.span,
                              "specialization is unstable");
        }

1359
        match ii.node {
1360
            ast::ImplItemKind::Const(..) => {
1361
                gate_feature_post!(&self, associated_consts,
1362 1363 1364
                                  ii.span,
                                  "associated constants are experimental")
            }
1365
            ast::ImplItemKind::Method(ref sig, _) => {
1366
                if sig.constness.node == ast::Constness::Const {
1367
                    gate_feature_post!(&self, const_fn, ii.span, "const fn is unstable");
N
Niko Matsakis 已提交
1368 1369
                }
            }
1370 1371 1372 1373
            _ => {}
        }
        visit::walk_impl_item(self, ii);
    }
1374

1375
    fn visit_vis(&mut self, vis: &'a ast::Visibility) {
1376 1377
        let span = match *vis {
            ast::Visibility::Crate(span) => span,
1378
            ast::Visibility::Restricted { ref path, .. } => path.span,
1379 1380
            _ => return,
        };
1381
        gate_feature_post!(&self, pub_restricted, span, "`pub(restricted)` syntax is experimental");
1382 1383

        visit::walk_vis(self, vis)
1384
    }
1385

1386
    fn visit_generics(&mut self, g: &'a ast::Generics) {
1387 1388 1389 1390 1391 1392 1393 1394 1395
        for t in &g.ty_params {
            if !t.attrs.is_empty() {
                gate_feature_post!(&self, generic_param_attrs, t.attrs[0].span,
                                   "attributes on type parameter bindings are experimental");
            }
        }
        visit::walk_generics(self, g)
    }

1396
    fn visit_lifetime_def(&mut self, lifetime_def: &'a ast::LifetimeDef) {
1397 1398 1399 1400 1401 1402
        if !lifetime_def.attrs.is_empty() {
            gate_feature_post!(&self, generic_param_attrs, lifetime_def.attrs[0].span,
                               "attributes on lifetime bindings are experimental");
        }
        visit::walk_lifetime_def(self, lifetime_def)
    }
1403 1404
}

J
Jeffrey Seyfried 已提交
1405
pub fn get_features(span_handler: &Handler, krate_attrs: &[ast::Attribute]) -> Features {
1406
    let mut features = Features::new();
N
Nick Cameron 已提交
1407

1408 1409
    let mut feature_checker = MutexFeatureChecker::default();

J
Jeffrey Seyfried 已提交
1410
    for attr in krate_attrs {
S
Steven Fackler 已提交
1411
        if !attr.check_name("feature") {
1412 1413
            continue
        }
1414 1415 1416

        match attr.meta_item_list() {
            None => {
G
ggomez 已提交
1417 1418
                span_err!(span_handler, attr.span, E0555,
                          "malformed feature attribute, expected #![feature(...)]");
1419 1420
            }
            Some(list) => {
1421
                for mi in list {
1422 1423 1424 1425 1426 1427 1428 1429
                    let name = if let Some(word) = mi.word() {
                        word.name()
                    } else {
                        span_err!(span_handler, mi.span, E0556,
                                  "malformed feature, expected just one word");
                        continue
                    };

1430 1431 1432
                    if let Some(&(_, _, _, setter)) = ACTIVE_FEATURES.iter()
                        .find(|& &(n, _, _, _)| name == n) {
                        *(setter(&mut features)) = true;
1433
                        feature_checker.collect(&features, mi.span);
1434 1435 1436
                    }
                    else if let Some(&(_, _, _)) = REMOVED_FEATURES.iter()
                        .find(|& &(n, _, _)| name == n) {
G
ggomez 已提交
1437
                        span_err!(span_handler, mi.span, E0557, "feature has been removed");
1438 1439 1440
                    }
                    else if let Some(&(_, _, _)) = ACCEPTED_FEATURES.iter()
                        .find(|& &(n, _, _)| name == n) {
1441
                        features.declared_stable_lang_features.push((name, mi.span));
1442 1443
                    } else {
                        features.declared_lib_features.push((name, mi.span));
1444 1445 1446 1447 1448 1449
                    }
                }
            }
        }
    }

1450 1451
    feature_checker.check(span_handler);

L
Leo Testard 已提交
1452
    features
C
Corey Richardson 已提交
1453 1454
}

1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488
// A collector for mutually-exclusive features and their flag spans
#[derive(Default)]
struct MutexFeatureChecker {
    proc_macro: Option<Span>,
    custom_attribute: Option<Span>,
}

impl MutexFeatureChecker {
    // If this method turns out to be a hotspot due to branching,
    // the branching can be eliminated by modifying `setter!()` to set these spans
    // only for the features that need to be checked for mutual exclusion.
    fn collect(&mut self, features: &Features, span: Span) {
        if features.proc_macro {
            // If self.proc_macro is None, set to Some(span)
            self.proc_macro = self.proc_macro.or(Some(span));
        }

        if features.custom_attribute {
            self.custom_attribute = self.custom_attribute.or(Some(span));
        }
    }

    fn check(self, handler: &Handler) {
        if let (Some(pm_span), Some(ca_span)) = (self.proc_macro, self.custom_attribute) {
            handler.struct_span_err(pm_span, "Cannot use `#![feature(proc_macro)]` and \
                                              `#![feature(custom_attribute)] at the same time")
                .span_note(ca_span, "`#![feature(custom_attribute)]` declared here")
                .emit();

            panic!(FatalError);
        }
    }
}

J
Jeffrey Seyfried 已提交
1489 1490 1491
pub fn check_crate(krate: &ast::Crate,
                   sess: &ParseSess,
                   features: &Features,
1492
                   plugin_attributes: &[(String, AttributeType)],
J
Jeffrey Seyfried 已提交
1493 1494 1495 1496
                   unstable: UnstableFeatures) {
    maybe_stage_features(&sess.span_diagnostic, krate, unstable);
    let ctx = Context {
        features: features,
1497
        parse_sess: sess,
J
Jeffrey Seyfried 已提交
1498 1499 1500 1501
        cm: sess.codemap(),
        plugin_attributes: plugin_attributes,
    };
    visit::walk_crate(&mut PostExpansionVisitor { context: &ctx }, krate);
C
Corey Richardson 已提交
1502
}
1503

1504
#[derive(Clone, Copy, PartialEq, Eq, Hash)]
1505 1506 1507 1508
pub enum UnstableFeatures {
    /// Hard errors for unstable features are active, as on
    /// beta/stable channels.
    Disallow,
J
John Hodge 已提交
1509
    /// Allow features to be activated, as on nightly.
1510 1511 1512 1513
    Allow,
    /// Errors are bypassed for bootstrapping. This is required any time
    /// during the build that feature-related lints are set to warn or above
    /// because the build turns on warnings-as-errors and uses lots of unstable
1514
    /// features. As a result, this is always required for building Rust itself.
1515 1516 1517
    Cheat
}

T
Tim Neumann 已提交
1518 1519 1520 1521
impl UnstableFeatures {
    pub fn from_environment() -> UnstableFeatures {
        // Whether this is a feature-staged build, i.e. on the beta or stable channel
        let disable_unstable_features = option_env!("CFG_DISABLE_UNSTABLE_FEATURES").is_some();
1522 1523 1524 1525 1526 1527
        // Whether we should enable unstable features for bootstrapping
        let bootstrap = env::var("RUSTC_BOOTSTRAP").is_ok();
        match (disable_unstable_features, bootstrap) {
            (_, true) => UnstableFeatures::Cheat,
            (true, _) => UnstableFeatures::Disallow,
            (false, _) => UnstableFeatures::Allow
T
Tim Neumann 已提交
1528 1529
        }
    }
1530 1531 1532 1533 1534 1535 1536

    pub fn is_nightly_build(&self) -> bool {
        match *self {
            UnstableFeatures::Allow | UnstableFeatures::Cheat => true,
            _ => false,
        }
    }
T
Tim Neumann 已提交
1537 1538
}

1539
fn maybe_stage_features(span_handler: &Handler, krate: &ast::Crate,
1540 1541 1542 1543 1544 1545 1546 1547 1548 1549
                        unstable: UnstableFeatures) {
    let allow_features = match unstable {
        UnstableFeatures::Allow => true,
        UnstableFeatures::Disallow => false,
        UnstableFeatures::Cheat => true
    };
    if !allow_features {
        for attr in &krate.attrs {
            if attr.check_name("feature") {
                let release_channel = option_env!("CFG_RELEASE_CHANNEL").unwrap_or("(unknown)");
G
ggomez 已提交
1550
                span_err!(span_handler, attr.span, E0554,
G
ggomez 已提交
1551 1552
                          "#[feature] may not be used on the {} release channel",
                          release_channel);
1553 1554 1555 1556
            }
        }
    }
}