feature_gate.rs 52.4 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

//! Feature gating
//!
L
Luke Gallagher 已提交
13
//! This module implements the gating necessary for preventing certain compiler
14 15 16 17 18
//! features from being used by default. This module will crawl a pre-expanded
//! AST to ensure that there are no features which are used that are not
//! enabled.
//!
//! Features are enabled in programs via the crate-level attributes of
19
//! `#![feature(...)]` with a comma-separated list of features.
B
Brian Anderson 已提交
20 21 22 23
//!
//! For the purpose of future feature-tracking, once code for detection of feature
//! gate usage is added, *do not remove it again* even once the feature
//! becomes stable.
G
GuillaumeGomez 已提交
24

25
use self::AttributeType::*;
26
use self::AttributeGate::*;
27

N
Niko Matsakis 已提交
28
use abi::Abi;
29
use ast::{self, NodeId, PatKind};
30
use attr;
31
use codemap::{CodeMap, Spanned};
32
use syntax_pos::Span;
33
use errors::Handler;
34
use visit::{self, FnKind, Visitor};
J
Jeffrey Seyfried 已提交
35
use parse::ParseSess;
36
use parse::token::InternedString;
37

38 39
use std::ascii::AsciiExt;

40 41 42 43 44 45 46 47
macro_rules! setter {
    ($field: ident) => {{
        fn f(features: &mut Features) -> &mut bool {
            &mut features.$field
        }
        f as fn(&mut Features) -> &mut bool
    }}
}
48

49
macro_rules! declare_features {
50
    ($((active, $feature: ident, $ver: expr, $issue: expr),)+) => {
51 52 53 54 55 56 57 58 59
        /// Represents active features that are currently being implemented or
        /// currently being considered for addition/removal.
        const ACTIVE_FEATURES: &'static [(&'static str, &'static str,
                                          Option<u32>, fn(&mut Features) -> &mut bool)] = &[
            $((stringify!($feature), $ver, $issue, setter!($feature))),+
        ];

        /// A set of features to be used by later passes.
        pub struct Features {
60 61
            /// #![feature] attrs for stable language features, for error reporting
            pub declared_stable_lang_features: Vec<(InternedString, Span)>,
62 63 64 65
            /// #![feature] attrs for non-language (library) features
            pub declared_lib_features: Vec<(InternedString, Span)>,
            $(pub $feature: bool),+
        }
66

67 68 69 70 71 72 73 74 75 76 77
        impl Features {
            pub fn new() -> Features {
                Features {
                    declared_stable_lang_features: Vec::new(),
                    declared_lib_features: Vec::new(),
                    $($feature: false),+
                }
            }
        }
    };

78
    ($((removed, $feature: ident, $ver: expr, $issue: expr),)+) => {
79 80 81 82 83 84
        /// Represents features which has since been removed (it was once Active)
        const REMOVED_FEATURES: &'static [(&'static str, &'static str, Option<u32>)] = &[
            $((stringify!($feature), $ver, $issue)),+
        ];
    };

85
    ($((accepted, $feature: ident, $ver: expr, $issue: expr),)+) => {
86 87 88 89 90
        /// Those language feature has since been Accepted (it was once Active)
        const ACCEPTED_FEATURES: &'static [(&'static str, &'static str, Option<u32>)] = &[
            $((stringify!($feature), $ver, $issue)),+
        ];
    }
91 92
}

B
Brian Anderson 已提交
93 94 95 96 97
// If you change this list without updating src/doc/reference.md, @cmr will be sad
// Don't ever remove anything from this list; set them to 'Removed'.
// The version numbers here correspond to the version in which the current status
// was set. This is most important for knowing when a particular feature became
// stable (active).
98 99 100 101 102 103 104 105 106 107 108 109
// NB: The featureck.py script parses this information directly out of the source
// so take care when modifying it.

declare_features! (
    (active, asm, "1.0.0", Some(29722)),
    (active, concat_idents, "1.0.0", Some(29599)),
    (active, link_args, "1.0.0", Some(29596)),
    (active, log_syntax, "1.0.0", Some(29598)),
    (active, non_ascii_idents, "1.0.0", Some(28979)),
    (active, plugin_registrar, "1.0.0", Some(29597)),
    (active, thread_local, "1.0.0", Some(29594)),
    (active, trace_macros, "1.0.0", Some(29598)),
A
Aaron Turon 已提交
110 111

    // rustc internal, for now:
112 113
    (active, intrinsics, "1.0.0", None),
    (active, lang_items, "1.0.0", None),
114

115 116 117 118
    (active, link_llvm_intrinsics, "1.0.0", Some(29602)),
    (active, linkage, "1.0.0", Some(29603)),
    (active, quote, "1.0.0", Some(29601)),
    (active, simd, "1.0.0", Some(27731)),
119 120


A
Aaron Turon 已提交
121
    // rustc internal
122 123 124 125 126 127
    (active, rustc_diagnostic_macros, "1.0.0", None),
    (active, advanced_slice_patterns, "1.0.0", Some(23121)),
    (active, box_syntax, "1.0.0", Some(27779)),
    (active, placement_in_syntax, "1.0.0", Some(27779)),
    (active, reflect, "1.0.0", Some(27749)),
    (active, unboxed_closures, "1.0.0", Some(29625)),
A
Aaron Turon 已提交
128 129

    // rustc internal.
130 131 132 133 134 135 136 137 138 139 140 141
    (active, pushpop_unsafe, "1.2.0", None),

    (active, allocator, "1.0.0", Some(27389)),
    (active, fundamental, "1.0.0", Some(29635)),
    (active, linked_from, "1.3.0", Some(29629)),
    (active, main, "1.0.0", Some(29634)),
    (active, needs_allocator, "1.4.0", Some(27389)),
    (active, on_unimplemented, "1.0.0", Some(29628)),
    (active, plugin, "1.0.0", Some(29597)),
    (active, simd_ffi, "1.0.0", Some(27731)),
    (active, start, "1.0.0", Some(29633)),
    (active, structural_match, "1.8.0", Some(31434)),
142 143
    (active, panic_runtime, "1.10.0", Some(32837)),
    (active, needs_panic_runtime, "1.10.0", Some(32837)),
144

145
    // OIBIT specific features
146
    (active, optin_builtin_traits, "1.0.0", Some(13231)),
147

J
Joseph Crail 已提交
148
    // macro reexport needs more discussion and stabilization
149
    (active, macro_reexport, "1.0.0", Some(29638)),
150 151

    // Allows use of #[staged_api]
A
Aaron Turon 已提交
152
    // rustc internal
153
    (active, staged_api, "1.0.0", None),
154 155

    // Allows using items which are missing stability attributes
A
Aaron Turon 已提交
156
    // rustc internal
157
    (active, unmarked_api, "1.0.0", None),
158

A
Alex Crichton 已提交
159
    // Allows using #![no_core]
160
    (active, no_core, "1.3.0", Some(29639)),
A
Alex Crichton 已提交
161

162
    // Allows using `box` in patterns; RFC 469
163
    (active, box_patterns, "1.0.0", Some(29641)),
164

165 166
    // Allows using the unsafe_destructor_blind_to_params attribute;
    // RFC 1238
167
    (active, dropck_parametricity, "1.3.0", Some(28498)),
168

169
    // Allows the use of custom attributes; RFC 572
170
    (active, custom_attribute, "1.0.0", Some(29642)),
M
Manish Goregaokar 已提交
171

172 173
    // Allows the use of #[derive(Anything)] as sugar for
    // #[derive_Anything].
174
    (active, custom_derive, "1.0.0", Some(29644)),
175

M
Manish Goregaokar 已提交
176
    // Allows the use of rustc_* attributes; RFC 572
177
    (active, rustc_attrs, "1.0.0", Some(29642)),
H
Huon Wilson 已提交
178

179 180 181 182
    // Allows the use of #[allow_internal_unstable]. This is an
    // attribute on macro_rules! and can't use the attribute handling
    // below (it has to be checked before expansion possibly makes
    // macros disappear).
A
Aaron Turon 已提交
183 184
    //
    // rustc internal
185
    (active, allow_internal_unstable, "1.0.0", None),
186 187

    // #23121. Array patterns have some hazards yet.
188
    (active, slice_patterns, "1.0.0", Some(23121)),
189 190 191

    // Allows the definition of associated constants in `trait` or `impl`
    // blocks.
192
    (active, associated_consts, "1.0.0", Some(29646)),
N
Niko Matsakis 已提交
193 194

    // Allows the definition of `const fn` functions.
195
    (active, const_fn, "1.2.0", Some(24111)),
196

197
    // Allows indexing into constant arrays.
198
    (active, const_indexing, "1.4.0", Some(29947)),
199

200
    // Allows using #[prelude_import] on glob `use` items.
A
Aaron Turon 已提交
201 202
    //
    // rustc internal
203
    (active, prelude_import, "1.2.0", None),
204 205

    // Allows the definition recursive static items.
206
    (active, static_recursion, "1.3.0", Some(29719)),
B
Brian Anderson 已提交
207 208

    // Allows default type parameters to influence type inference.
209
    (active, default_type_parameter_fallback, "1.3.0", Some(27336)),
210 211

    // Allows associated type defaults
212
    (active, associated_type_defaults, "1.2.0", Some(29661)),
J
Jared Roesch 已提交
213

214
    // allow `repr(simd)`, and importing the various simd intrinsics
215
    (active, repr_simd, "1.4.0", Some(27731)),
216 217

    // Allows cfg(target_feature = "...").
218
    (active, cfg_target_feature, "1.4.0", Some(29717)),
219 220

    // allow `extern "platform-intrinsic" { ... }`
221
    (active, platform_intrinsics, "1.4.0", Some(27731)),
222 223

    // allow `#[unwind]`
A
Aaron Turon 已提交
224
    // rust runtime internal
225
    (active, unwind_attributes, "1.4.0", None),
V
Vadim Petrochenkov 已提交
226

T
Ticki 已提交
227
    // allow the use of `#[naked]` on functions.
228
    (active, naked_functions, "1.9.0", Some(32408)),
229 230

    // allow `#[no_debug]`
231
    (active, no_debug, "1.5.0", Some(29721)),
232 233

    // allow `#[omit_gdb_pretty_printer_section]`
A
Aaron Turon 已提交
234
    // rustc internal.
235
    (active, omit_gdb_pretty_printer_section, "1.5.0", None),
236 237

    // Allows cfg(target_vendor = "...").
238
    (active, cfg_target_vendor, "1.5.0", Some(29718)),
239 240

    // Allow attributes on expressions and non-item statements
241
    (active, stmt_expr_attributes, "1.6.0", Some(15701)),
242 243

    // allow using type ascription in expressions
244
    (active, type_ascription, "1.6.0", Some(23416)),
245 246

    // Allows cfg(target_thread_local)
247
    (active, cfg_target_thread_local, "1.7.0", Some(29594)),
248 249

    // rustc internal
250
    (active, abi_vectorcall, "1.7.0", None),
A
Alex Burka 已提交
251 252

    // a...b and ...b
253
    (active, inclusive_range_syntax, "1.7.0", Some(28237)),
J
Jorge Aparicio 已提交
254 255

    // `expr?`
256
    (active, question_mark, "1.9.0", Some(31436)),
A
Aaron Turon 已提交
257 258

    // impl specialization (RFC 1210)
259
    (active, specialization, "1.7.0", Some(31844)),
260 261

    // pub(restricted) visibilities (RFC 1422)
262 263
    (active, pub_restricted, "1.9.0", Some(32409)),

264 265 266 267
    // Allow Drop types in statics/const functions (RFC 1440)
    (active, drop_types_in_const, "1.9.0", Some(33156)),

    // Allows cfg(target_has_atomic = "...").
268 269 270
    (active, cfg_target_has_atomic, "1.9.0", Some(32976)),

    // Allows `..` in tuple (struct) patterns
271 272 273
    (active, dotdot_in_tuple_patterns, "1.10.0", Some(33627)),

    // Allows `impl Trait` in function return types.
274 275 276 277
    (active, conservative_impl_trait, "1.12.0", Some(34511)),

    // Allows tuple structs and variants in more contexts,
    // Permits numeric fields in struct expressions and patterns.
278 279 280
    (active, relaxed_adts, "1.12.0", Some(35626)),

    // The `!` type
281 282 283
    (active, never_type, "1.13.0", Some(35121)),

    // Allows all literals in attribute lists and values of key-value pairs.
284 285 286 287
    (active, attr_literals, "1.13.0", Some(34981)),

    // Allows the sysV64 ABI to be specified on all platforms
    // instead of just the platforms on which it is the C ABI
288 289 290
    (active, abi_sysv64, "1.13.0", Some(36167)),

    // Use the import semantics from RFC 1560.
291 292 293 294
    (active, item_like_imports, "1.13.0", Some(35120)),

    // Macros 1.1
    (active, rustc_macro, "1.13.0", Some(35900)),
295 296 297

    // Allows untagged unions `union U { ... }`
    (active, untagged_unions, "1.13.0", Some(32836)),
298 299 300 301 302 303 304 305 306 307 308 309
);

declare_features! (
    (removed, import_shadowing, "1.0.0", None),
    (removed, managed_boxes, "1.0.0", None),
    // Allows use of unary negate on unsigned integers, e.g. -e for e: u8
    (removed, negate_unsigned, "1.0.0", Some(29645)),
    // A way to temporarily opt out of opt in copy. This will *never* be accepted.
    (removed, opt_out_copy, "1.0.0", None),
    (removed, quad_precision_float, "1.0.0", None),
    (removed, struct_inherit, "1.0.0", None),
    (removed, test_removed_feature, "1.0.0", None),
310
    (removed, visible_private_types, "1.0.0", None),
311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326
);

declare_features! (
    (accepted, associated_types, "1.0.0", None),
    // allow overloading augmented assignment operations like `a += b`
    (accepted, augmented_assignments, "1.8.0", Some(28235)),
    // allow empty structs and enum variants with braces
    (accepted, braced_empty_structs, "1.8.0", Some(29720)),
    (accepted, default_type_params, "1.0.0", None),
    (accepted, globs, "1.0.0", None),
    (accepted, if_let, "1.0.0", None),
    // A temporary feature gate used to enable parser extensions needed
    // to bootstrap fix for #5723.
    (accepted, issue_5723_bootstrap, "1.0.0", None),
    (accepted, macro_rules, "1.0.0", None),
    // Allows using #![no_std]
327
    (accepted, no_std, "1.6.0", None),
328 329 330 331 332 333
    (accepted, slicing_syntax, "1.0.0", None),
    (accepted, struct_variant, "1.0.0", None),
    // These are used to test this portion of the compiler, they don't actually
    // mean anything
    (accepted, test_accepted_feature, "1.0.0", None),
    (accepted, tuple_indexing, "1.0.0", None),
D
Daniele Baracchi 已提交
334 335
    // Allows macros to appear in the type position.
    (accepted, type_macros, "1.13.0", Some(27245)),
336 337
    (accepted, while_let, "1.0.0", None),
    // Allows `#[deprecated]` attribute
338
    (accepted, deprecated, "1.9.0", Some(29935)),
339
);
340
// (changing above list without updating src/doc/reference.md makes @cmr sad)
341

342 343 344 345 346
#[derive(PartialEq, Copy, Clone, Debug)]
pub enum AttributeType {
    /// Normal, builtin attribute that is consumed
    /// by the compiler before the unused_attribute check
    Normal,
347

348 349 350 351
    /// Builtin attribute that may not be consumed by the compiler
    /// before the unused_attribute check. These attributes
    /// will be ignored by the unused_attribute lint
    Whitelisted,
352

353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382
    /// Builtin attribute that is only allowed at the crate level
    CrateLevel,
}

pub enum AttributeGate {
    /// Is gated by a given feature gate, reason
    /// and function to check if enabled
    Gated(&'static str, &'static str, fn(&Features) -> bool),

    /// Ungated attribute, can be used on all release channels
    Ungated,
}

// fn() is not Debug
impl ::std::fmt::Debug for AttributeGate {
    fn fmt(&self, fmt: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
        match *self {
            Gated(ref name, ref expl, _) => write!(fmt, "Gated({}, {})", name, expl),
            Ungated => write!(fmt, "Ungated")
        }
    }
}

macro_rules! cfg_fn {
    ($field: ident) => {{
        fn f(features: &Features) -> bool {
            features.$field
        }
        f as fn(&Features) -> bool
    }}
383 384
}

385
// Attributes that have a special meaning to rustc or rustdoc
386
pub const KNOWN_ATTRIBUTES: &'static [(&'static str, AttributeType, AttributeGate)] = &[
387 388
    // Normal attributes

389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418
    ("warn", Normal, Ungated),
    ("allow", Normal, Ungated),
    ("forbid", Normal, Ungated),
    ("deny", Normal, Ungated),

    ("macro_reexport", Normal, Ungated),
    ("macro_use", Normal, Ungated),
    ("macro_export", Normal, Ungated),
    ("plugin_registrar", Normal, Ungated),

    ("cfg", Normal, Ungated),
    ("cfg_attr", Normal, Ungated),
    ("main", Normal, Ungated),
    ("start", Normal, Ungated),
    ("test", Normal, Ungated),
    ("bench", Normal, Ungated),
    ("simd", Normal, Ungated),
    ("repr", Normal, Ungated),
    ("path", Normal, Ungated),
    ("abi", Normal, Ungated),
    ("automatically_derived", Normal, Ungated),
    ("no_mangle", Normal, Ungated),
    ("no_link", Normal, Ungated),
    ("derive", Normal, Ungated),
    ("should_panic", Normal, Ungated),
    ("ignore", Normal, Ungated),
    ("no_implicit_prelude", Normal, Ungated),
    ("reexport_test_harness_main", Normal, Ungated),
    ("link_args", Normal, Ungated),
    ("macro_escape", Normal, Ungated),
419

420 421 422
    // RFC #1445.
    ("structural_match", Whitelisted, Gated("structural_match",
                                            "the semantics of constant patterns is \
423 424
                                             not yet settled",
                                            cfg_fn!(structural_match))),
425

A
Alex Crichton 已提交
426
    // Not used any more, but we can't feature gate it
427 428 429 430
    ("no_stack_check", Normal, Ungated),

    ("plugin", CrateLevel, Gated("plugin",
                                 "compiler plugins are experimental \
431 432 433
                                  and possibly buggy",
                                 cfg_fn!(plugin))),

434
    ("no_std", CrateLevel, Ungated),
435
    ("no_core", CrateLevel, Gated("no_core",
436 437
                                  "no_core is experimental",
                                  cfg_fn!(no_core))),
438
    ("lang", Normal, Gated("lang_items",
439 440
                           "language items are subject to change",
                           cfg_fn!(lang_items))),
441 442
    ("linkage", Whitelisted, Gated("linkage",
                                   "the `linkage` attribute is experimental \
443 444
                                    and not portable across platforms",
                                   cfg_fn!(linkage))),
445 446 447 448
    ("thread_local", Whitelisted, Gated("thread_local",
                                        "`#[thread_local]` is an experimental feature, and does \
                                         not currently handle destructors. There is no \
                                         corresponding `#[task_local]` mapping to the task \
449 450
                                         model",
                                        cfg_fn!(thread_local))),
451 452 453

    ("rustc_on_unimplemented", Normal, Gated("on_unimplemented",
                                             "the `#[rustc_on_unimplemented]` attribute \
454 455
                                              is an experimental feature",
                                             cfg_fn!(on_unimplemented))),
456
    ("allocator", Whitelisted, Gated("allocator",
457 458
                                     "the `#[allocator]` attribute is an experimental feature",
                                     cfg_fn!(allocator))),
459 460 461
    ("needs_allocator", Normal, Gated("needs_allocator",
                                      "the `#[needs_allocator]` \
                                       attribute is an experimental \
462 463
                                       feature",
                                      cfg_fn!(needs_allocator))),
464 465 466 467 468 469 470 471 472
    ("panic_runtime", Whitelisted, Gated("panic_runtime",
                                         "the `#[panic_runtime]` attribute is \
                                          an experimental feature",
                                         cfg_fn!(panic_runtime))),
    ("needs_panic_runtime", Whitelisted, Gated("needs_panic_runtime",
                                               "the `#[needs_panic_runtime]` \
                                                attribute is an experimental \
                                                feature",
                                               cfg_fn!(needs_panic_runtime))),
473 474
    ("rustc_variance", Normal, Gated("rustc_attrs",
                                     "the `#[rustc_variance]` attribute \
N
Niko Matsakis 已提交
475
                                      is just used for rustc unit tests \
476 477
                                      and will never be stable",
                                     cfg_fn!(rustc_attrs))),
478 479
    ("rustc_error", Whitelisted, Gated("rustc_attrs",
                                       "the `#[rustc_error]` attribute \
N
Niko Matsakis 已提交
480
                                        is just used for rustc unit tests \
481 482
                                        and will never be stable",
                                       cfg_fn!(rustc_attrs))),
483
    ("rustc_if_this_changed", Whitelisted, Gated("rustc_attrs",
484 485 486 487
                                                 "the `#[rustc_if_this_changed]` attribute \
                                                  is just used for rustc unit tests \
                                                  and will never be stable",
                                                 cfg_fn!(rustc_attrs))),
488
    ("rustc_then_this_would_need", Whitelisted, Gated("rustc_attrs",
489 490 491 492
                                                      "the `#[rustc_if_this_changed]` attribute \
                                                       is just used for rustc unit tests \
                                                       and will never be stable",
                                                      cfg_fn!(rustc_attrs))),
493 494 495
    ("rustc_dirty", Whitelisted, Gated("rustc_attrs",
                                       "the `#[rustc_dirty]` attribute \
                                        is just used for rustc unit tests \
496 497
                                        and will never be stable",
                                       cfg_fn!(rustc_attrs))),
498 499 500
    ("rustc_clean", Whitelisted, Gated("rustc_attrs",
                                       "the `#[rustc_clean]` attribute \
                                        is just used for rustc unit tests \
501 502
                                        and will never be stable",
                                       cfg_fn!(rustc_attrs))),
503 504 505 506 507 508 509 510 511 512
    ("rustc_partition_reused", Whitelisted, Gated("rustc_attrs",
                                                  "this attribute \
                                                   is just used for rustc unit tests \
                                                   and will never be stable",
                                                  cfg_fn!(rustc_attrs))),
    ("rustc_partition_translated", Whitelisted, Gated("rustc_attrs",
                                                      "this attribute \
                                                       is just used for rustc unit tests \
                                                       and will never be stable",
                                                      cfg_fn!(rustc_attrs))),
513
    ("rustc_symbol_name", Whitelisted, Gated("rustc_attrs",
514 515
                                             "internal rustc attributes will never be stable",
                                             cfg_fn!(rustc_attrs))),
516
    ("rustc_item_path", Whitelisted, Gated("rustc_attrs",
517 518
                                           "internal rustc attributes will never be stable",
                                           cfg_fn!(rustc_attrs))),
519 520
    ("rustc_move_fragments", Normal, Gated("rustc_attrs",
                                           "the `#[rustc_move_fragments]` attribute \
N
Niko Matsakis 已提交
521
                                            is just used for rustc unit tests \
522 523
                                            and will never be stable",
                                           cfg_fn!(rustc_attrs))),
524 525 526
    ("rustc_mir", Whitelisted, Gated("rustc_attrs",
                                     "the `#[rustc_mir]` attribute \
                                      is just used for rustc unit tests \
527 528
                                      and will never be stable",
                                     cfg_fn!(rustc_attrs))),
529 530 531 532 533 534 535
    ("rustc_inherit_overflow_checks", Whitelisted, Gated("rustc_attrs",
                                                         "the `#[rustc_inherit_overflow_checks]` \
                                                          attribute is just used to control \
                                                          overflow checking behavior of several \
                                                          libcore functions that are inlined \
                                                          across crates and will never be stable",
                                                          cfg_fn!(rustc_attrs))),
536 537

    ("allow_internal_unstable", Normal, Gated("allow_internal_unstable",
538 539
                                              EXPLAIN_ALLOW_INTERNAL_UNSTABLE,
                                              cfg_fn!(allow_internal_unstable))),
540 541 542

    ("fundamental", Whitelisted, Gated("fundamental",
                                       "the `#[fundamental]` attribute \
543 544
                                        is an experimental feature",
                                       cfg_fn!(fundamental))),
545 546 547

    ("linked_from", Normal, Gated("linked_from",
                                  "the `#[linked_from]` attribute \
548 549
                                   is an experimental feature",
                                  cfg_fn!(linked_from))),
550

551 552 553 554 555 556 557 558 559
    ("rustc_macro_derive", Normal, Gated("rustc_macro",
                                         "the `#[rustc_macro_derive]` attribute \
                                          is an experimental feature",
                                         cfg_fn!(rustc_macro))),

    ("rustc_copy_clone_marker", Whitelisted, Gated("rustc_attrs",
                                                   "internal implementation detail",
                                                   cfg_fn!(rustc_attrs))),

560
    // FIXME: #14408 whitelist docs since rustdoc looks at them
561
    ("doc", Whitelisted, Ungated),
562 563 564

    // FIXME: #14406 these are processed in trans, which happens after the
    // lint pass
565
    ("cold", Whitelisted, Ungated),
T
Ticki 已提交
566 567
    ("naked", Whitelisted, Gated("naked_functions",
                                 "the `#[naked]` attribute \
568
                                  is an experimental feature",
569
                                 cfg_fn!(naked_functions))),
570 571 572 573 574 575 576
    ("export_name", Whitelisted, Ungated),
    ("inline", Whitelisted, Ungated),
    ("link", Whitelisted, Ungated),
    ("link_name", Whitelisted, Ungated),
    ("link_section", Whitelisted, Ungated),
    ("no_builtins", Whitelisted, Ungated),
    ("no_mangle", Whitelisted, Ungated),
577 578
    ("no_debug", Whitelisted, Gated("no_debug",
                                    "the `#[no_debug]` attribute \
579 580
                                     is an experimental feature",
                                    cfg_fn!(no_debug))),
581 582 583
    ("omit_gdb_pretty_printer_section", Whitelisted, Gated("omit_gdb_pretty_printer_section",
                                                       "the `#[omit_gdb_pretty_printer_section]` \
                                                        attribute is just used for the Rust test \
584 585
                                                        suite",
                                                       cfg_fn!(omit_gdb_pretty_printer_section))),
586 587
    ("unsafe_destructor_blind_to_params",
     Normal,
588
     Gated("dropck_parametricity",
589
           "unsafe_destructor_blind_to_params has unstable semantics \
590 591 592 593
            and may be removed in the future",
           cfg_fn!(dropck_parametricity))),
    ("unwind", Whitelisted, Gated("unwind_attributes", "#[unwind] is experimental",
                                  cfg_fn!(unwind_attributes))),
594 595

    // used in resolve
596
    ("prelude_import", Whitelisted, Gated("prelude_import",
597 598
                                          "`#[prelude_import]` is for use by rustc only",
                                          cfg_fn!(prelude_import))),
599 600 601

    // FIXME: #14407 these are only looked at on-demand so we can't
    // guarantee they'll have already been checked
602
    ("rustc_deprecated", Whitelisted, Ungated),
603 604 605
    ("must_use", Whitelisted, Ungated),
    ("stable", Whitelisted, Ungated),
    ("unstable", Whitelisted, Ungated),
606
    ("deprecated", Normal, Ungated),
607

608
    ("rustc_paren_sugar", Normal, Gated("unboxed_closures",
609 610
                                        "unboxed_closures are still evolving",
                                        cfg_fn!(unboxed_closures))),
611
    ("rustc_reflect_like", Whitelisted, Gated("reflect",
612 613
                                              "defining reflective traits is still evolving",
                                              cfg_fn!(reflect))),
614 615

    // Crate level attributes
616 617 618 619 620 621 622 623
    ("crate_name", CrateLevel, Ungated),
    ("crate_type", CrateLevel, Ungated),
    ("crate_id", CrateLevel, Ungated),
    ("feature", CrateLevel, Ungated),
    ("no_start", CrateLevel, Ungated),
    ("no_main", CrateLevel, Ungated),
    ("no_builtins", CrateLevel, Ungated),
    ("recursion_limit", CrateLevel, Ungated),
624 625
];

626 627 628
// cfg(...)'s that are feature gated
const GATED_CFGS: &'static [(&'static str, &'static str, fn(&Features) -> bool)] = &[
    // (name in cfg, feature, function to check if the feature is enabled)
629 630 631
    ("target_feature", "cfg_target_feature", cfg_fn!(cfg_target_feature)),
    ("target_vendor", "cfg_target_vendor", cfg_fn!(cfg_target_vendor)),
    ("target_thread_local", "cfg_target_thread_local", cfg_fn!(cfg_target_thread_local)),
632
    ("target_has_atomic", "cfg_target_has_atomic", cfg_fn!(cfg_target_has_atomic)),
633
    ("rustc_macro", "rustc_macro", cfg_fn!(rustc_macro)),
634 635 636 637 638 639 640
];

#[derive(Debug, Eq, PartialEq)]
pub struct GatedCfg {
    span: Span,
    index: usize,
}
641

642 643 644 645 646 647 648 649 650 651 652 653
impl GatedCfg {
    pub fn gate(cfg: &ast::MetaItem) -> Option<GatedCfg> {
        let name = cfg.name();
        GATED_CFGS.iter()
                  .position(|info| info.0 == name)
                  .map(|idx| {
                      GatedCfg {
                          span: cfg.span,
                          index: idx
                      }
                  })
    }
J
Jeffrey Seyfried 已提交
654 655

    pub fn check_and_emit(&self, sess: &ParseSess, features: &Features) {
656
        let (cfg, feature, has_feature) = GATED_CFGS[self.index];
J
Jeffrey Seyfried 已提交
657 658
        if !has_feature(features) && !sess.codemap().span_allows_unstable(self.span) {
            let diagnostic = &sess.span_diagnostic;
659
            let explain = format!("`cfg({})` is experimental and subject to change", cfg);
660
            emit_feature_err(diagnostic, feature, self.span, GateIssue::Language, &explain);
661 662 663 664
        }
    }
}

E
Eduard Burtescu 已提交
665
struct Context<'a> {
L
Leo Testard 已提交
666
    features: &'a Features,
667
    span_handler: &'a Handler,
C
Corey Richardson 已提交
668
    cm: &'a CodeMap,
669
    plugin_attributes: &'a [(String, AttributeType)],
670 671
}

672 673 674 675 676 677 678
macro_rules! gate_feature_fn {
    ($cx: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{
        let (cx, has_feature, span, name, explain) = ($cx, $has_feature, $span, $name, $explain);
        let has_feature: bool = has_feature(&$cx.features);
        debug!("gate_feature(feature = {:?}, span = {:?}); has? {}", name, span, has_feature);
        if !has_feature && !cx.cm.span_allows_unstable(span) {
            emit_feature_err(cx.span_handler, name, span, GateIssue::Language, explain);
679
        }
680 681 682 683 684 685
    }}
}

macro_rules! gate_feature {
    ($cx: expr, $feature: ident, $span: expr, $explain: expr) => {
        gate_feature_fn!($cx, |x:&Features| x.$feature, $span, stringify!($feature), $explain)
686
    }
687
}
688

689
impl<'a> Context<'a> {
690
    fn check_attribute(&self, attr: &ast::Attribute, is_macro: bool) {
691 692
        debug!("check_attribute(attr = {:?})", attr);
        let name = &*attr.name();
693
        for &(n, ty, ref gateage) in KNOWN_ATTRIBUTES {
694
            if n == name {
695 696
                if let &Gated(ref name, ref desc, ref has_feature) = gateage {
                    gate_feature_fn!(self, has_feature, attr.span, name, desc);
697
                }
698
                debug!("check_attribute: {:?} is known, {:?}, {:?}", name, ty, gateage);
699 700 701
                return;
            }
        }
702
        for &(ref n, ref ty) in self.plugin_attributes {
703
            if n == name {
704
                // Plugins can't gate attributes, so we don't check for it
M
Manish Goregaokar 已提交
705 706
                // unlike the code above; we only use this loop to
                // short-circuit to avoid the checks below
707 708 709 710
                debug!("check_attribute: {:?} is registered by a plugin, {:?}", name, ty);
                return;
            }
        }
711
        if name.starts_with("rustc_") {
712 713 714 715
            gate_feature!(self, rustc_attrs, attr.span,
                          "unless otherwise specified, attributes \
                           with the prefix `rustc_` \
                           are reserved for internal compiler diagnostics");
716
        } else if name.starts_with("derive_") {
L
Leo Testard 已提交
717
            gate_feature!(self, custom_derive, attr.span, EXPLAIN_DERIVE_UNDERSCORE);
718
        } else {
M
Manish Goregaokar 已提交
719 720 721 722
            // Only run the custom attribute lint during regular
            // feature gate checking. Macro gating runs
            // before the plugin attributes are registered
            // so we skip this then
723
            if !is_macro {
724 725 726 727 728 729
                gate_feature!(self, custom_attribute, attr.span,
                              &format!("The attribute `{}` is currently \
                                        unknown to the compiler and \
                                        may have meaning \
                                        added to it in the future",
                                       name));
730
            }
731 732
        }
    }
733 734
}

L
Leo Testard 已提交
735 736 737 738 739 740 741 742 743
pub fn check_attribute(attr: &ast::Attribute, handler: &Handler,
                       cm: &CodeMap, features: &Features) {
    let cx = Context {
        features: features, span_handler: handler,
        cm: cm, plugin_attributes: &[]
    };
    cx.check_attribute(attr, true);
}

744 745 746 747
pub fn find_lang_feature_accepted_version(feature: &str) -> Option<&'static str> {
    ACCEPTED_FEATURES.iter().find(|t| t.0 == feature).map(|t| t.1)
}

748
fn find_lang_feature_issue(feature: &str) -> Option<u32> {
749 750
    if let Some(info) = ACTIVE_FEATURES.iter().find(|t| t.0 == feature) {
        let issue = info.2;
751 752
        // FIXME (#28244): enforce that active features have issue numbers
        // assert!(issue.is_some())
753 754 755 756 757 758
        issue
    } else {
        // search in Accepted or Removed features
        ACCEPTED_FEATURES.iter().chain(REMOVED_FEATURES.iter())
            .find(|t| t.0 == feature)
            .unwrap().2
759 760 761 762 763 764 765 766
    }
}

pub enum GateIssue {
    Language,
    Library(Option<u32>)
}

767
pub fn emit_feature_err(diag: &Handler, feature: &str, span: Span, issue: GateIssue,
768 769 770 771 772 773
                        explain: &str) {
    let issue = match issue {
        GateIssue::Language => find_lang_feature_issue(feature),
        GateIssue::Library(lib) => lib,
    };

N
Nick Cameron 已提交
774 775
    let mut err = if let Some(n) = issue {
        diag.struct_span_err(span, &format!("{} (see issue #{})", explain, n))
776
    } else {
N
Nick Cameron 已提交
777 778
        diag.struct_span_err(span, explain)
    };
779 780

    // #23973: do not suggest `#![feature(...)]` if we are in beta/stable
N
Nick Cameron 已提交
781 782 783 784
    if option_env!("CFG_DISABLE_UNSTABLE_FEATURES").is_some() {
        err.emit();
        return;
    }
785 786 787
    err.help(&format!("add #![feature({})] to the \
                       crate attributes to enable",
                      feature));
N
Nick Cameron 已提交
788
    err.emit();
789 790
}

L
Leo Testard 已提交
791 792 793
const EXPLAIN_BOX_SYNTAX: &'static str =
    "box expression syntax is experimental; you can call `Box::new` instead.";

J
Jeffrey Seyfried 已提交
794
pub const EXPLAIN_STMT_ATTR_SYNTAX: &'static str =
L
Leo Testard 已提交
795 796
    "attributes on non-item statements and expressions are experimental.";

797 798 799
pub const EXPLAIN_ASM: &'static str =
    "inline assembly is not stable enough for use and is subject to change";

800 801 802 803 804 805 806 807
pub const EXPLAIN_LOG_SYNTAX: &'static str =
    "`log_syntax!` is not stable enough for use and is subject to change";

pub const EXPLAIN_CONCAT_IDENTS: &'static str =
    "`concat_idents` is not stable enough for use and is subject to change";

pub const EXPLAIN_TRACE_MACROS: &'static str =
    "`trace_macros` is not stable enough for use and is subject to change";
808 809
pub const EXPLAIN_ALLOW_INTERNAL_UNSTABLE: &'static str =
    "allow_internal_unstable side-steps feature gating and stability checks";
810

811 812 813
pub const EXPLAIN_CUSTOM_DERIVE: &'static str =
    "`#[derive]` for custom traits is not stable enough for use and is subject to change";

L
Leo Testard 已提交
814 815
pub const EXPLAIN_DERIVE_UNDERSCORE: &'static str =
    "attributes of the form `#[derive_*]` are reserved for the compiler";
816

L
Leo Testard 已提交
817 818
pub const EXPLAIN_PLACEMENT_IN: &'static str =
    "placement-in expression syntax is experimental and subject to change.";
C
Corey Richardson 已提交
819 820

struct PostExpansionVisitor<'a> {
N
Nick Cameron 已提交
821
    context: &'a Context<'a>,
C
Corey Richardson 已提交
822 823
}

824 825 826 827 828
macro_rules! gate_feature_post {
    ($cx: expr, $feature: ident, $span: expr, $explain: expr) => {{
        let (cx, span) = ($cx, $span);
        if !cx.context.cm.span_allows_unstable(span) {
            gate_feature!(cx.context, $feature, span, $explain)
C
Corey Richardson 已提交
829
        }
830
    }}
C
Corey Richardson 已提交
831 832
}

833 834 835
impl<'a> PostExpansionVisitor<'a> {
    fn check_abi(&self, abi: Abi, span: Span) {
        match abi {
836
            Abi::RustIntrinsic => {
837
                gate_feature_post!(&self, intrinsics, span,
838 839
                                   "intrinsics are subject to change");
            },
840 841
            Abi::PlatformIntrinsic => {
                gate_feature_post!(&self, platform_intrinsics, span,
842
                                   "platform intrinsics are experimental and possibly buggy");
843 844 845
            },
            Abi::Vectorcall => {
                gate_feature_post!(&self, abi_vectorcall, span,
846 847
                                   "vectorcall is experimental and subject to change");
            },
848 849 850
            Abi::RustCall => {
                gate_feature_post!(&self, unboxed_closures, span,
                                   "rust-call ABI is subject to change");
851 852 853 854 855
            },
            Abi::SysV64 => {
                gate_feature_post!(&self, abi_sysv64, span,
                                   "sysv64 ABI is experimental and subject to change");
            },
856 857 858 859 860
            _ => {}
        }
    }
}

861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876
fn contains_novel_literal(item: &ast::MetaItem) -> bool {
    use ast::MetaItemKind::*;
    use ast::NestedMetaItemKind::*;

    match item.node {
        Word(..) => false,
        NameValue(_, ref lit) => !lit.node.is_str(),
        List(_, ref list) => list.iter().any(|li| {
            match li.node {
                MetaItem(ref mi) => contains_novel_literal(&**mi),
                Literal(_) => true,
            }
        }),
    }
}

877
impl<'a> Visitor for PostExpansionVisitor<'a> {
878 879
    fn visit_attribute(&mut self, attr: &ast::Attribute) {
        if !self.context.cm.span_allows_unstable(attr.span) {
880
            // check for gated attributes
881
            self.context.check_attribute(attr, false);
882
        }
883 884 885 886 887 888

        if contains_novel_literal(&*(attr.node.value)) {
            gate_feature_post!(&self, attr_literals, attr.span,
                               "non-string literals in attributes, or string \
                               literals in top-level positions, are experimental");
        }
889 890
    }

891
    fn visit_name(&mut self, sp: Span, name: ast::Name) {
892
        if !name.as_str().is_ascii() {
893 894
            gate_feature_post!(&self, non_ascii_idents, sp,
                               "non-ascii idents are not fully supported.");
895 896 897
        }
    }

898
    fn visit_item(&mut self, i: &ast::Item) {
899
        match i.node {
900
            ast::ItemKind::ExternCrate(_) => {
901
                if attr::contains_name(&i.attrs[..], "macro_reexport") {
902 903 904
                    gate_feature_post!(&self, macro_reexport, i.span,
                                       "macros reexports are experimental \
                                        and possibly buggy");
905 906 907
                }
            }

908
            ast::ItemKind::ForeignMod(ref foreign_module) => {
909
                if attr::contains_name(&i.attrs[..], "link_args") {
910
                    gate_feature_post!(&self, link_args, i.span,
911 912 913 914
                                      "the `link_args` attribute is not portable \
                                       across platforms, it is recommended to \
                                       use `#[link(name = \"foo\")]` instead")
                }
915
                self.check_abi(foreign_module.abi, i.span);
916 917
            }

918
            ast::ItemKind::Fn(..) => {
919
                if attr::contains_name(&i.attrs[..], "plugin_registrar") {
920 921
                    gate_feature_post!(&self, plugin_registrar, i.span,
                                       "compiler plugins are experimental and possibly buggy");
922
                }
923
                if attr::contains_name(&i.attrs[..], "start") {
924
                    gate_feature_post!(&self, start, i.span,
925 926 927 928
                                      "a #[start] function is an experimental \
                                       feature whose signature may change \
                                       over time");
                }
929
                if attr::contains_name(&i.attrs[..], "main") {
930 931 932 933
                    gate_feature_post!(&self, main, i.span,
                                       "declaration of a nonstandard #[main] \
                                        function may change over time, for now \
                                        a top-level `fn main()` is required");
934
                }
935 936
            }

937
            ast::ItemKind::Struct(..) => {
938
                if attr::contains_name(&i.attrs[..], "simd") {
939 940
                    gate_feature_post!(&self, simd, i.span,
                                       "SIMD types are experimental and possibly buggy");
941 942 943 944 945 946 947
                    self.context.span_handler.span_warn(i.span,
                                                        "the `#[simd]` attribute is deprecated, \
                                                         use `#[repr(simd)]` instead");
                }
                for attr in &i.attrs {
                    if attr.name() == "repr" {
                        for item in attr.meta_item_list().unwrap_or(&[]) {
948
                            if item.check_name("simd") {
949 950 951
                                gate_feature_post!(&self, repr_simd, i.span,
                                                   "SIMD types are experimental \
                                                    and possibly buggy");
952 953 954 955

                            }
                        }
                    }
956
                }
D
David Manescu 已提交
957 958
            }

959 960 961 962 963 964
            ast::ItemKind::Union(..) => {
                gate_feature_post!(&self, untagged_unions,
                                   i.span,
                                   "unions are unstable and not fully implemented");
            }

965
            ast::ItemKind::DefaultImpl(..) => {
966 967 968 969
                gate_feature_post!(&self, optin_builtin_traits,
                                   i.span,
                                   "default trait implementations are experimental \
                                    and possibly buggy");
F
Flavio Percoco 已提交
970 971
            }

972
            ast::ItemKind::Impl(_, polarity, _, _, _, _) => {
973 974
                match polarity {
                    ast::ImplPolarity::Negative => {
975 976 977 978
                        gate_feature_post!(&self, optin_builtin_traits,
                                           i.span,
                                           "negative trait bounds are not yet fully implemented; \
                                            use marker types for now");
979 980 981
                    },
                    _ => {}
                }
982 983
            }

984 985 986
            _ => {}
        }

987
        visit::walk_item(self, i);
988
    }
989

990
    fn visit_foreign_item(&mut self, i: &ast::ForeignItem) {
991
        let links_to_llvm = match attr::first_attr_value_str_by_name(&i.attrs,
N
fallout  
Nick Cameron 已提交
992
                                                                     "link_name") {
G
GuillaumeGomez 已提交
993
            Some(val) => val.starts_with("llvm."),
994 995 996
            _ => false
        };
        if links_to_llvm {
997
            gate_feature_post!(&self, link_llvm_intrinsics, i.span,
998 999 1000
                              "linking to LLVM intrinsics is experimental");
        }

1001
        visit::walk_foreign_item(self, i)
1002 1003
    }

1004 1005 1006 1007 1008
    fn visit_ty(&mut self, ty: &ast::Ty) {
        match ty.node {
            ast::TyKind::BareFn(ref bare_fn_ty) => {
                self.check_abi(bare_fn_ty.abi, ty.span);
            }
1009 1010 1011 1012
            ast::TyKind::ImplTrait(..) => {
                gate_feature_post!(&self, conservative_impl_trait, ty.span,
                                   "`impl Trait` is experimental");
            }
A
Andrew Cann 已提交
1013 1014
            ast::TyKind::Never => {
                gate_feature_post!(&self, never_type, ty.span,
1015 1016
                                   "The `!` type is experimental");
            },
1017 1018 1019 1020 1021
            _ => {}
        }
        visit::walk_ty(self, ty)
    }

1022 1023 1024
    fn visit_fn_ret_ty(&mut self, ret_ty: &ast::FunctionRetTy) {
        if let ast::FunctionRetTy::Ty(ref output_ty) = *ret_ty {
            match output_ty.node {
A
Andrew Cann 已提交
1025
                ast::TyKind::Never => return,
1026 1027
                _ => (),
            };
A
Andrew Cann 已提交
1028
            self.visit_ty(output_ty)
1029 1030 1031
        }
    }

1032
    fn visit_expr(&mut self, e: &ast::Expr) {
1033
        match e.node {
1034
            ast::ExprKind::Box(_) => {
1035
                gate_feature_post!(&self, box_syntax, e.span, EXPLAIN_BOX_SYNTAX);
1036
            }
1037
            ast::ExprKind::Type(..) => {
1038
                gate_feature_post!(&self, type_ascription, e.span,
1039 1040
                                  "type ascription is experimental");
            }
1041
            ast::ExprKind::Range(_, _, ast::RangeLimits::Closed) => {
1042
                gate_feature_post!(&self, inclusive_range_syntax,
A
Alex Burka 已提交
1043 1044 1045
                                  e.span,
                                  "inclusive range syntax is experimental");
            }
J
Jorge Aparicio 已提交
1046
            ast::ExprKind::Try(..) => {
1047
                gate_feature_post!(&self, question_mark, e.span, "the `?` operator is not stable");
J
Jorge Aparicio 已提交
1048
            }
1049 1050 1051
            ast::ExprKind::InPlace(..) => {
                gate_feature_post!(&self, placement_in_syntax, e.span, EXPLAIN_PLACEMENT_IN);
            }
1052 1053
            _ => {}
        }
1054
        visit::walk_expr(self, e);
1055
    }
1056

1057
    fn visit_pat(&mut self, pattern: &ast::Pat) {
1058
        match pattern.node {
1059
            PatKind::Vec(_, Some(_), ref last) if !last.is_empty() => {
1060
                gate_feature_post!(&self, advanced_slice_patterns,
1061 1062 1063
                                  pattern.span,
                                  "multiple-element slice matches anywhere \
                                   but at the end of a slice (e.g. \
1064
                                   `[0, ..xs, 0]`) are experimental")
1065
            }
1066
            PatKind::Vec(..) => {
1067
                gate_feature_post!(&self, slice_patterns,
1068 1069 1070
                                  pattern.span,
                                  "slice pattern syntax is experimental");
            }
1071
            PatKind::Box(..) => {
1072
                gate_feature_post!(&self, box_patterns,
1073
                                  pattern.span,
1074
                                  "box pattern syntax is experimental");
1075
            }
1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089
            PatKind::Tuple(_, ddpos)
                    if ddpos.is_some() => {
                gate_feature_post!(&self, dotdot_in_tuple_patterns,
                                  pattern.span,
                                  "`..` in tuple patterns is experimental");
            }
            PatKind::TupleStruct(_, ref fields, ddpos)
                    if ddpos.is_some() && !fields.is_empty() => {
                gate_feature_post!(&self, dotdot_in_tuple_patterns,
                                  pattern.span,
                                  "`..` in tuple struct patterns is experimental");
            }
            PatKind::TupleStruct(_, ref fields, ddpos)
                    if ddpos.is_none() && fields.is_empty() => {
1090 1091
                gate_feature_post!(&self, relaxed_adts, pattern.span,
                                   "empty tuple structs patterns are unstable");
1092
            }
1093 1094
            _ => {}
        }
1095
        visit::walk_pat(self, pattern)
1096 1097
    }

1098
    fn visit_fn(&mut self,
1099 1100 1101
                fn_kind: FnKind,
                fn_decl: &ast::FnDecl,
                block: &ast::Block,
1102
                span: Span,
1103
                _node_id: NodeId) {
N
Niko Matsakis 已提交
1104 1105
        // check for const fn declarations
        match fn_kind {
1106
            FnKind::ItemFn(_, _, _, Spanned { node: ast::Constness::Const, .. }, _, _) => {
1107
                gate_feature_post!(&self, const_fn, span, "const fn is unstable");
N
Niko Matsakis 已提交
1108 1109 1110 1111 1112 1113 1114 1115 1116
            }
            _ => {
                // stability of const fn methods are covered in
                // visit_trait_item and visit_impl_item below; this is
                // because default methods don't pass through this
                // point.
            }
        }

1117
        match fn_kind {
1118
            FnKind::ItemFn(_, _, _, _, abi, _) |
1119 1120 1121
            FnKind::Method(_, &ast::MethodSig { abi, .. }, _) => {
                self.check_abi(abi, span);
            }
1122 1123
            _ => {}
        }
1124
        visit::walk_fn(self, fn_kind, fn_decl, block, span);
1125
    }
1126

1127
    fn visit_trait_item(&mut self, ti: &ast::TraitItem) {
1128
        match ti.node {
1129
            ast::TraitItemKind::Const(..) => {
1130
                gate_feature_post!(&self, associated_consts,
1131 1132 1133
                                  ti.span,
                                  "associated constants are experimental")
            }
1134 1135 1136 1137
            ast::TraitItemKind::Method(ref sig, ref block) => {
                if block.is_none() {
                    self.check_abi(sig.abi, ti.span);
                }
1138
                if sig.constness.node == ast::Constness::Const {
1139
                    gate_feature_post!(&self, const_fn, ti.span, "const fn is unstable");
N
Niko Matsakis 已提交
1140 1141
                }
            }
1142
            ast::TraitItemKind::Type(_, Some(_)) => {
1143
                gate_feature_post!(&self, associated_type_defaults, ti.span,
1144 1145
                                  "associated type defaults are unstable");
            }
1146 1147 1148 1149 1150
            _ => {}
        }
        visit::walk_trait_item(self, ti);
    }

1151
    fn visit_impl_item(&mut self, ii: &ast::ImplItem) {
A
Aaron Turon 已提交
1152
        if ii.defaultness == ast::Defaultness::Default {
1153
            gate_feature_post!(&self, specialization,
A
Aaron Turon 已提交
1154 1155 1156 1157
                              ii.span,
                              "specialization is unstable");
        }

1158
        match ii.node {
1159
            ast::ImplItemKind::Const(..) => {
1160
                gate_feature_post!(&self, associated_consts,
1161 1162 1163
                                  ii.span,
                                  "associated constants are experimental")
            }
1164
            ast::ImplItemKind::Method(ref sig, _) => {
1165
                if sig.constness.node == ast::Constness::Const {
1166
                    gate_feature_post!(&self, const_fn, ii.span, "const fn is unstable");
N
Niko Matsakis 已提交
1167 1168
                }
            }
1169 1170 1171 1172
            _ => {}
        }
        visit::walk_impl_item(self, ii);
    }
1173

1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186
    fn visit_variant_data(&mut self, vdata: &ast::VariantData, _: ast::Ident,
                          _: &ast::Generics, _: NodeId, span: Span) {
        if vdata.fields().is_empty() {
            if vdata.is_tuple() {
                gate_feature_post!(&self, relaxed_adts, span,
                                   "empty tuple structs and enum variants are unstable, \
                                    use unit structs and enum variants instead");
            }
        }

        visit::walk_struct_def(self, vdata)
    }

1187
    fn visit_vis(&mut self, vis: &ast::Visibility) {
1188 1189
        let span = match *vis {
            ast::Visibility::Crate(span) => span,
1190
            ast::Visibility::Restricted { ref path, .. } => path.span,
1191 1192
            _ => return,
        };
1193
        gate_feature_post!(&self, pub_restricted, span, "`pub(restricted)` syntax is experimental");
1194 1195

        visit::walk_vis(self, vis)
1196
    }
1197 1198
}

J
Jeffrey Seyfried 已提交
1199
pub fn get_features(span_handler: &Handler, krate_attrs: &[ast::Attribute]) -> Features {
1200
    let mut features = Features::new();
N
Nick Cameron 已提交
1201

J
Jeffrey Seyfried 已提交
1202
    for attr in krate_attrs {
S
Steven Fackler 已提交
1203
        if !attr.check_name("feature") {
1204 1205
            continue
        }
1206 1207 1208

        match attr.meta_item_list() {
            None => {
G
ggomez 已提交
1209 1210
                span_err!(span_handler, attr.span, E0555,
                          "malformed feature attribute, expected #![feature(...)]");
1211 1212
            }
            Some(list) => {
1213
                for mi in list {
1214 1215 1216 1217 1218 1219 1220 1221
                    let name = if let Some(word) = mi.word() {
                        word.name()
                    } else {
                        span_err!(span_handler, mi.span, E0556,
                                  "malformed feature, expected just one word");
                        continue
                    };

1222 1223 1224 1225 1226 1227
                    if let Some(&(_, _, _, setter)) = ACTIVE_FEATURES.iter()
                        .find(|& &(n, _, _, _)| name == n) {
                        *(setter(&mut features)) = true;
                    }
                    else if let Some(&(_, _, _)) = REMOVED_FEATURES.iter()
                        .find(|& &(n, _, _)| name == n) {
G
ggomez 已提交
1228
                        span_err!(span_handler, mi.span, E0557, "feature has been removed");
1229 1230 1231
                    }
                    else if let Some(&(_, _, _)) = ACCEPTED_FEATURES.iter()
                        .find(|& &(n, _, _)| name == n) {
1232
                        features.declared_stable_lang_features.push((name, mi.span));
1233 1234
                    } else {
                        features.declared_lib_features.push((name, mi.span));
1235 1236 1237 1238 1239 1240
                    }
                }
            }
        }
    }

L
Leo Testard 已提交
1241
    features
C
Corey Richardson 已提交
1242 1243
}

J
Jeffrey Seyfried 已提交
1244 1245 1246
pub fn check_crate(krate: &ast::Crate,
                   sess: &ParseSess,
                   features: &Features,
1247
                   plugin_attributes: &[(String, AttributeType)],
J
Jeffrey Seyfried 已提交
1248 1249 1250 1251 1252 1253 1254 1255 1256
                   unstable: UnstableFeatures) {
    maybe_stage_features(&sess.span_diagnostic, krate, unstable);
    let ctx = Context {
        features: features,
        span_handler: &sess.span_diagnostic,
        cm: sess.codemap(),
        plugin_attributes: plugin_attributes,
    };
    visit::walk_crate(&mut PostExpansionVisitor { context: &ctx }, krate);
C
Corey Richardson 已提交
1257
}
1258

1259
#[derive(Clone, Copy, PartialEq, Eq, Hash)]
1260 1261 1262 1263 1264 1265 1266 1267 1268
pub enum UnstableFeatures {
    /// Hard errors for unstable features are active, as on
    /// beta/stable channels.
    Disallow,
    /// Allow features to me activated, as on nightly.
    Allow,
    /// Errors are bypassed for bootstrapping. This is required any time
    /// during the build that feature-related lints are set to warn or above
    /// because the build turns on warnings-as-errors and uses lots of unstable
1269
    /// features. As a result, this is always required for building Rust itself.
1270 1271 1272
    Cheat
}

1273
fn maybe_stage_features(span_handler: &Handler, krate: &ast::Crate,
1274 1275 1276 1277 1278 1279 1280 1281 1282 1283
                        unstable: UnstableFeatures) {
    let allow_features = match unstable {
        UnstableFeatures::Allow => true,
        UnstableFeatures::Disallow => false,
        UnstableFeatures::Cheat => true
    };
    if !allow_features {
        for attr in &krate.attrs {
            if attr.check_name("feature") {
                let release_channel = option_env!("CFG_RELEASE_CHANNEL").unwrap_or("(unknown)");
G
ggomez 已提交
1284
                span_err!(span_handler, attr.span, E0554,
G
ggomez 已提交
1285 1286
                          "#[feature] may not be used on the {} release channel",
                          release_channel);
1287 1288 1289 1290
            }
        }
    }
}