i915_gem_execbuffer.c 49.1 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28
/*
 * Copyright © 2008,2010 Intel Corporation
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice (including the next
 * paragraph) shall be included in all copies or substantial portions of the
 * Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
 * IN THE SOFTWARE.
 *
 * Authors:
 *    Eric Anholt <eric@anholt.net>
 *    Chris Wilson <chris@chris-wilson.co.uk>
 *
 */

29 30
#include <drm/drmP.h>
#include <drm/i915_drm.h>
31 32 33
#include "i915_drv.h"
#include "i915_trace.h"
#include "intel_drv.h"
34
#include <linux/dma_remapping.h>
35
#include <linux/uaccess.h>
36

37 38
#define  __EXEC_OBJECT_HAS_PIN (1<<31)
#define  __EXEC_OBJECT_HAS_FENCE (1<<30)
39
#define  __EXEC_OBJECT_NEEDS_MAP (1<<29)
40 41 42
#define  __EXEC_OBJECT_NEEDS_BIAS (1<<28)

#define BATCH_OFFSET_BIAS (256*1024)
43

44 45
struct eb_vmas {
	struct list_head vmas;
46
	int and;
47
	union {
48
		struct i915_vma *lut[0];
49 50
		struct hlist_head buckets[0];
	};
51 52
};

53
static struct eb_vmas *
B
Ben Widawsky 已提交
54
eb_create(struct drm_i915_gem_execbuffer2 *args)
55
{
56
	struct eb_vmas *eb = NULL;
57 58

	if (args->flags & I915_EXEC_HANDLE_LUT) {
59
		unsigned size = args->buffer_count;
60 61
		size *= sizeof(struct i915_vma *);
		size += sizeof(struct eb_vmas);
62 63 64 65
		eb = kmalloc(size, GFP_TEMPORARY | __GFP_NOWARN | __GFP_NORETRY);
	}

	if (eb == NULL) {
66 67
		unsigned size = args->buffer_count;
		unsigned count = PAGE_SIZE / sizeof(struct hlist_head) / 2;
L
Lauri Kasanen 已提交
68
		BUILD_BUG_ON_NOT_POWER_OF_2(PAGE_SIZE / sizeof(struct hlist_head));
69 70 71
		while (count > 2*size)
			count >>= 1;
		eb = kzalloc(count*sizeof(struct hlist_head) +
72
			     sizeof(struct eb_vmas),
73 74 75 76 77 78 79 80
			     GFP_TEMPORARY);
		if (eb == NULL)
			return eb;

		eb->and = count - 1;
	} else
		eb->and = -args->buffer_count;

81
	INIT_LIST_HEAD(&eb->vmas);
82 83 84 85
	return eb;
}

static void
86
eb_reset(struct eb_vmas *eb)
87
{
88 89
	if (eb->and >= 0)
		memset(eb->buckets, 0, (eb->and+1)*sizeof(struct hlist_head));
90 91
}

92
static int
93 94 95 96 97
eb_lookup_vmas(struct eb_vmas *eb,
	       struct drm_i915_gem_exec_object2 *exec,
	       const struct drm_i915_gem_execbuffer2 *args,
	       struct i915_address_space *vm,
	       struct drm_file *file)
98
{
99 100
	struct drm_i915_gem_object *obj;
	struct list_head objects;
101
	int i, ret;
102

103
	INIT_LIST_HEAD(&objects);
104
	spin_lock(&file->table_lock);
105 106
	/* Grab a reference to the object and release the lock so we can lookup
	 * or create the VMA without using GFP_ATOMIC */
107
	for (i = 0; i < args->buffer_count; i++) {
108 109 110 111 112
		obj = to_intel_bo(idr_find(&file->object_idr, exec[i].handle));
		if (obj == NULL) {
			spin_unlock(&file->table_lock);
			DRM_DEBUG("Invalid object handle %d at index %d\n",
				   exec[i].handle, i);
113
			ret = -ENOENT;
114
			goto err;
115 116
		}

117
		if (!list_empty(&obj->obj_exec_link)) {
118 119 120
			spin_unlock(&file->table_lock);
			DRM_DEBUG("Object %p [handle %d, index %d] appears more than once in object list\n",
				   obj, exec[i].handle, i);
121
			ret = -EINVAL;
122
			goto err;
123 124 125
		}

		drm_gem_object_reference(&obj->base);
126 127 128
		list_add_tail(&obj->obj_exec_link, &objects);
	}
	spin_unlock(&file->table_lock);
129

130
	i = 0;
131
	while (!list_empty(&objects)) {
132
		struct i915_vma *vma;
133

134 135 136 137
		obj = list_first_entry(&objects,
				       struct drm_i915_gem_object,
				       obj_exec_link);

138 139 140 141 142 143 144 145
		/*
		 * NOTE: We can leak any vmas created here when something fails
		 * later on. But that's no issue since vma_unbind can deal with
		 * vmas which are not actually bound. And since only
		 * lookup_or_create exists as an interface to get at the vma
		 * from the (obj, vm) we don't run the risk of creating
		 * duplicated vmas for the same vm.
		 */
146
		vma = i915_gem_obj_lookup_or_create_vma(obj, vm);
147 148 149
		if (IS_ERR(vma)) {
			DRM_DEBUG("Failed to lookup VMA\n");
			ret = PTR_ERR(vma);
150
			goto err;
151 152
		}

153
		/* Transfer ownership from the objects list to the vmas list. */
154
		list_add_tail(&vma->exec_list, &eb->vmas);
155
		list_del_init(&obj->obj_exec_link);
156 157

		vma->exec_entry = &exec[i];
158
		if (eb->and < 0) {
159
			eb->lut[i] = vma;
160 161
		} else {
			uint32_t handle = args->flags & I915_EXEC_HANDLE_LUT ? i : exec[i].handle;
162 163
			vma->exec_handle = handle;
			hlist_add_head(&vma->exec_node,
164 165
				       &eb->buckets[handle & eb->and]);
		}
166
		++i;
167 168
	}

169
	return 0;
170 171


172
err:
173 174 175 176 177
	while (!list_empty(&objects)) {
		obj = list_first_entry(&objects,
				       struct drm_i915_gem_object,
				       obj_exec_link);
		list_del_init(&obj->obj_exec_link);
178
		drm_gem_object_unreference(&obj->base);
179
	}
180 181 182 183 184
	/*
	 * Objects already transfered to the vmas list will be unreferenced by
	 * eb_destroy.
	 */

185
	return ret;
186 187
}

188
static struct i915_vma *eb_get_vma(struct eb_vmas *eb, unsigned long handle)
189
{
190 191 192 193 194 195 196
	if (eb->and < 0) {
		if (handle >= -eb->and)
			return NULL;
		return eb->lut[handle];
	} else {
		struct hlist_head *head;
		struct hlist_node *node;
197

198 199
		head = &eb->buckets[handle & eb->and];
		hlist_for_each(node, head) {
200
			struct i915_vma *vma;
201

202 203 204
			vma = hlist_entry(node, struct i915_vma, exec_node);
			if (vma->exec_handle == handle)
				return vma;
205 206 207
		}
		return NULL;
	}
208 209
}

210 211 212 213 214 215 216 217 218 219 220 221 222 223 224
static void
i915_gem_execbuffer_unreserve_vma(struct i915_vma *vma)
{
	struct drm_i915_gem_exec_object2 *entry;
	struct drm_i915_gem_object *obj = vma->obj;

	if (!drm_mm_node_allocated(&vma->node))
		return;

	entry = vma->exec_entry;

	if (entry->flags & __EXEC_OBJECT_HAS_FENCE)
		i915_gem_object_unpin_fence(obj);

	if (entry->flags & __EXEC_OBJECT_HAS_PIN)
225
		vma->pin_count--;
226

C
Chris Wilson 已提交
227
	entry->flags &= ~(__EXEC_OBJECT_HAS_FENCE | __EXEC_OBJECT_HAS_PIN);
228 229 230 231
}

static void eb_destroy(struct eb_vmas *eb)
{
232 233
	while (!list_empty(&eb->vmas)) {
		struct i915_vma *vma;
234

235 236
		vma = list_first_entry(&eb->vmas,
				       struct i915_vma,
237
				       exec_list);
238
		list_del_init(&vma->exec_list);
239
		i915_gem_execbuffer_unreserve_vma(vma);
240
		drm_gem_object_unreference(&vma->obj->base);
241
	}
242 243 244
	kfree(eb);
}

245 246
static inline int use_cpu_reloc(struct drm_i915_gem_object *obj)
{
247 248
	return (HAS_LLC(obj->base.dev) ||
		obj->base.write_domain == I915_GEM_DOMAIN_CPU ||
249 250 251
		obj->cache_level != I915_CACHE_NONE);
}

252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276
/* Used to convert any address to canonical form.
 * Starting from gen8, some commands (e.g. STATE_BASE_ADDRESS,
 * MI_LOAD_REGISTER_MEM and others, see Broadwell PRM Vol2a) require the
 * addresses to be in a canonical form:
 * "GraphicsAddress[63:48] are ignored by the HW and assumed to be in correct
 * canonical form [63:48] == [47]."
 */
#define GEN8_HIGH_ADDRESS_BIT 47
static inline uint64_t gen8_canonical_addr(uint64_t address)
{
	return sign_extend64(address, GEN8_HIGH_ADDRESS_BIT);
}

static inline uint64_t gen8_noncanonical_addr(uint64_t address)
{
	return address & ((1ULL << (GEN8_HIGH_ADDRESS_BIT + 1)) - 1);
}

static inline uint64_t
relocation_target(struct drm_i915_gem_relocation_entry *reloc,
		  uint64_t target_offset)
{
	return gen8_canonical_addr((int)reloc->delta + target_offset);
}

277 278
static int
relocate_entry_cpu(struct drm_i915_gem_object *obj,
B
Ben Widawsky 已提交
279 280
		   struct drm_i915_gem_relocation_entry *reloc,
		   uint64_t target_offset)
281
{
282
	struct drm_device *dev = obj->base.dev;
283
	uint32_t page_offset = offset_in_page(reloc->offset);
284
	uint64_t delta = relocation_target(reloc, target_offset);
285
	char *vaddr;
286
	int ret;
287

288
	ret = i915_gem_object_set_to_cpu_domain(obj, true);
289 290 291
	if (ret)
		return ret;

292
	vaddr = kmap_atomic(i915_gem_object_get_dirty_page(obj,
293
				reloc->offset >> PAGE_SHIFT));
B
Ben Widawsky 已提交
294
	*(uint32_t *)(vaddr + page_offset) = lower_32_bits(delta);
295 296 297 298 299 300

	if (INTEL_INFO(dev)->gen >= 8) {
		page_offset = offset_in_page(page_offset + sizeof(uint32_t));

		if (page_offset == 0) {
			kunmap_atomic(vaddr);
301
			vaddr = kmap_atomic(i915_gem_object_get_dirty_page(obj,
302 303 304
			    (reloc->offset + sizeof(uint32_t)) >> PAGE_SHIFT));
		}

B
Ben Widawsky 已提交
305
		*(uint32_t *)(vaddr + page_offset) = upper_32_bits(delta);
306 307
	}

308 309 310 311 312 313 314
	kunmap_atomic(vaddr);

	return 0;
}

static int
relocate_entry_gtt(struct drm_i915_gem_object *obj,
B
Ben Widawsky 已提交
315 316
		   struct drm_i915_gem_relocation_entry *reloc,
		   uint64_t target_offset)
317 318 319
{
	struct drm_device *dev = obj->base.dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
320
	uint64_t delta = relocation_target(reloc, target_offset);
321
	uint64_t offset;
322
	void __iomem *reloc_page;
323
	int ret;
324 325 326 327 328 329 330 331 332 333

	ret = i915_gem_object_set_to_gtt_domain(obj, true);
	if (ret)
		return ret;

	ret = i915_gem_object_put_fence(obj);
	if (ret)
		return ret;

	/* Map the page containing the relocation we're going to perform.  */
334 335
	offset = i915_gem_obj_ggtt_offset(obj);
	offset += reloc->offset;
336
	reloc_page = io_mapping_map_atomic_wc(dev_priv->gtt.mappable,
337 338
					      offset & PAGE_MASK);
	iowrite32(lower_32_bits(delta), reloc_page + offset_in_page(offset));
339 340

	if (INTEL_INFO(dev)->gen >= 8) {
341
		offset += sizeof(uint32_t);
342

343
		if (offset_in_page(offset) == 0) {
344
			io_mapping_unmap_atomic(reloc_page);
345 346 347
			reloc_page =
				io_mapping_map_atomic_wc(dev_priv->gtt.mappable,
							 offset);
348 349
		}

350 351
		iowrite32(upper_32_bits(delta),
			  reloc_page + offset_in_page(offset));
352 353
	}

354 355 356 357 358
	io_mapping_unmap_atomic(reloc_page);

	return 0;
}

359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374
static void
clflush_write32(void *addr, uint32_t value)
{
	/* This is not a fast path, so KISS. */
	drm_clflush_virt_range(addr, sizeof(uint32_t));
	*(uint32_t *)addr = value;
	drm_clflush_virt_range(addr, sizeof(uint32_t));
}

static int
relocate_entry_clflush(struct drm_i915_gem_object *obj,
		       struct drm_i915_gem_relocation_entry *reloc,
		       uint64_t target_offset)
{
	struct drm_device *dev = obj->base.dev;
	uint32_t page_offset = offset_in_page(reloc->offset);
375
	uint64_t delta = relocation_target(reloc, target_offset);
376 377 378 379 380 381 382
	char *vaddr;
	int ret;

	ret = i915_gem_object_set_to_gtt_domain(obj, true);
	if (ret)
		return ret;

383
	vaddr = kmap_atomic(i915_gem_object_get_dirty_page(obj,
384 385 386 387 388 389 390 391
				reloc->offset >> PAGE_SHIFT));
	clflush_write32(vaddr + page_offset, lower_32_bits(delta));

	if (INTEL_INFO(dev)->gen >= 8) {
		page_offset = offset_in_page(page_offset + sizeof(uint32_t));

		if (page_offset == 0) {
			kunmap_atomic(vaddr);
392
			vaddr = kmap_atomic(i915_gem_object_get_dirty_page(obj,
393 394 395 396 397 398 399 400 401 402 403
			    (reloc->offset + sizeof(uint32_t)) >> PAGE_SHIFT));
		}

		clflush_write32(vaddr + page_offset, upper_32_bits(delta));
	}

	kunmap_atomic(vaddr);

	return 0;
}

404 405
static int
i915_gem_execbuffer_relocate_entry(struct drm_i915_gem_object *obj,
406
				   struct eb_vmas *eb,
407
				   struct drm_i915_gem_relocation_entry *reloc)
408 409 410
{
	struct drm_device *dev = obj->base.dev;
	struct drm_gem_object *target_obj;
411
	struct drm_i915_gem_object *target_i915_obj;
412
	struct i915_vma *target_vma;
B
Ben Widawsky 已提交
413
	uint64_t target_offset;
414
	int ret;
415

416
	/* we've already hold a reference to all valid objects */
417 418
	target_vma = eb_get_vma(eb, reloc->target_handle);
	if (unlikely(target_vma == NULL))
419
		return -ENOENT;
420 421
	target_i915_obj = target_vma->obj;
	target_obj = &target_vma->obj->base;
422

423
	target_offset = gen8_canonical_addr(target_vma->node.start);
424

425 426 427 428
	/* Sandybridge PPGTT errata: We need a global gtt mapping for MI and
	 * pipe_control writes because the gpu doesn't properly redirect them
	 * through the ppgtt for non_secure batchbuffers. */
	if (unlikely(IS_GEN6(dev) &&
429
	    reloc->write_domain == I915_GEM_DOMAIN_INSTRUCTION)) {
430
		ret = i915_vma_bind(target_vma, target_i915_obj->cache_level,
431
				    PIN_GLOBAL);
432 433 434
		if (WARN_ONCE(ret, "Unexpected failure to bind target VMA!"))
			return ret;
	}
435

436
	/* Validate that the target is in a valid r/w GPU domain */
437
	if (unlikely(reloc->write_domain & (reloc->write_domain - 1))) {
438
		DRM_DEBUG("reloc with multiple write domains: "
439 440 441 442 443 444
			  "obj %p target %d offset %d "
			  "read %08x write %08x",
			  obj, reloc->target_handle,
			  (int) reloc->offset,
			  reloc->read_domains,
			  reloc->write_domain);
445
		return -EINVAL;
446
	}
447 448
	if (unlikely((reloc->write_domain | reloc->read_domains)
		     & ~I915_GEM_GPU_DOMAINS)) {
449
		DRM_DEBUG("reloc with read/write non-GPU domains: "
450 451 452 453 454 455
			  "obj %p target %d offset %d "
			  "read %08x write %08x",
			  obj, reloc->target_handle,
			  (int) reloc->offset,
			  reloc->read_domains,
			  reloc->write_domain);
456
		return -EINVAL;
457 458 459 460 461 462 463 464 465
	}

	target_obj->pending_read_domains |= reloc->read_domains;
	target_obj->pending_write_domain |= reloc->write_domain;

	/* If the relocation already has the right value in it, no
	 * more work needs to be done.
	 */
	if (target_offset == reloc->presumed_offset)
466
		return 0;
467 468

	/* Check that the relocation address is valid... */
469 470
	if (unlikely(reloc->offset >
		obj->base.size - (INTEL_INFO(dev)->gen >= 8 ? 8 : 4))) {
471
		DRM_DEBUG("Relocation beyond object bounds: "
472 473 474 475
			  "obj %p target %d offset %d size %d.\n",
			  obj, reloc->target_handle,
			  (int) reloc->offset,
			  (int) obj->base.size);
476
		return -EINVAL;
477
	}
478
	if (unlikely(reloc->offset & 3)) {
479
		DRM_DEBUG("Relocation not 4-byte aligned: "
480 481 482
			  "obj %p target %d offset %d.\n",
			  obj, reloc->target_handle,
			  (int) reloc->offset);
483
		return -EINVAL;
484 485
	}

486
	/* We can't wait for rendering with pagefaults disabled */
487
	if (obj->active && pagefault_disabled())
488 489
		return -EFAULT;

490
	if (use_cpu_reloc(obj))
B
Ben Widawsky 已提交
491
		ret = relocate_entry_cpu(obj, reloc, target_offset);
492
	else if (obj->map_and_fenceable)
B
Ben Widawsky 已提交
493
		ret = relocate_entry_gtt(obj, reloc, target_offset);
494 495 496 497 498 499
	else if (cpu_has_clflush)
		ret = relocate_entry_clflush(obj, reloc, target_offset);
	else {
		WARN_ONCE(1, "Impossible case in relocation handling\n");
		ret = -ENODEV;
	}
500

501 502 503
	if (ret)
		return ret;

504 505 506
	/* and update the user's relocation entry */
	reloc->presumed_offset = target_offset;

507
	return 0;
508 509 510
}

static int
511 512
i915_gem_execbuffer_relocate_vma(struct i915_vma *vma,
				 struct eb_vmas *eb)
513
{
514 515
#define N_RELOC(x) ((x) / sizeof(struct drm_i915_gem_relocation_entry))
	struct drm_i915_gem_relocation_entry stack_reloc[N_RELOC(512)];
516
	struct drm_i915_gem_relocation_entry __user *user_relocs;
517
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
518
	int remain, ret;
519

V
Ville Syrjälä 已提交
520
	user_relocs = to_user_ptr(entry->relocs_ptr);
521

522 523 524 525 526 527 528 529 530
	remain = entry->relocation_count;
	while (remain) {
		struct drm_i915_gem_relocation_entry *r = stack_reloc;
		int count = remain;
		if (count > ARRAY_SIZE(stack_reloc))
			count = ARRAY_SIZE(stack_reloc);
		remain -= count;

		if (__copy_from_user_inatomic(r, user_relocs, count*sizeof(r[0])))
531 532
			return -EFAULT;

533 534
		do {
			u64 offset = r->presumed_offset;
535

536
			ret = i915_gem_execbuffer_relocate_entry(vma->obj, eb, r);
537 538 539 540 541 542 543 544 545 546 547 548 549
			if (ret)
				return ret;

			if (r->presumed_offset != offset &&
			    __copy_to_user_inatomic(&user_relocs->presumed_offset,
						    &r->presumed_offset,
						    sizeof(r->presumed_offset))) {
				return -EFAULT;
			}

			user_relocs++;
			r++;
		} while (--count);
550 551 552
	}

	return 0;
553
#undef N_RELOC
554 555 556
}

static int
557 558 559
i915_gem_execbuffer_relocate_vma_slow(struct i915_vma *vma,
				      struct eb_vmas *eb,
				      struct drm_i915_gem_relocation_entry *relocs)
560
{
561
	const struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
562 563 564
	int i, ret;

	for (i = 0; i < entry->relocation_count; i++) {
565
		ret = i915_gem_execbuffer_relocate_entry(vma->obj, eb, &relocs[i]);
566 567 568 569 570 571 572 573
		if (ret)
			return ret;
	}

	return 0;
}

static int
B
Ben Widawsky 已提交
574
i915_gem_execbuffer_relocate(struct eb_vmas *eb)
575
{
576
	struct i915_vma *vma;
577 578 579 580 581 582 583 584 585 586
	int ret = 0;

	/* This is the fast path and we cannot handle a pagefault whilst
	 * holding the struct mutex lest the user pass in the relocations
	 * contained within a mmaped bo. For in such a case we, the page
	 * fault handler would call i915_gem_fault() and we would try to
	 * acquire the struct mutex again. Obviously this is bad and so
	 * lockdep complains vehemently.
	 */
	pagefault_disable();
587 588
	list_for_each_entry(vma, &eb->vmas, exec_list) {
		ret = i915_gem_execbuffer_relocate_vma(vma, eb);
589
		if (ret)
590
			break;
591
	}
592
	pagefault_enable();
593

594
	return ret;
595 596
}

597 598 599 600 601 602
static bool only_mappable_for_reloc(unsigned int flags)
{
	return (flags & (EXEC_OBJECT_NEEDS_FENCE | __EXEC_OBJECT_NEEDS_MAP)) ==
		__EXEC_OBJECT_NEEDS_MAP;
}

603
static int
604
i915_gem_execbuffer_reserve_vma(struct i915_vma *vma,
605
				struct intel_engine_cs *ring,
606
				bool *need_reloc)
607
{
608
	struct drm_i915_gem_object *obj = vma->obj;
609
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
610
	uint64_t flags;
611 612
	int ret;

613
	flags = PIN_USER;
614 615 616
	if (entry->flags & EXEC_OBJECT_NEEDS_GTT)
		flags |= PIN_GLOBAL;

617
	if (!drm_mm_node_allocated(&vma->node)) {
618 619 620 621 622
		/* Wa32bitGeneralStateOffset & Wa32bitInstructionBaseOffset,
		 * limit address to the first 4GBs for unflagged objects.
		 */
		if ((entry->flags & EXEC_OBJECT_SUPPORTS_48B_ADDRESS) == 0)
			flags |= PIN_ZONE_4G;
623 624 625 626
		if (entry->flags & __EXEC_OBJECT_NEEDS_MAP)
			flags |= PIN_GLOBAL | PIN_MAPPABLE;
		if (entry->flags & __EXEC_OBJECT_NEEDS_BIAS)
			flags |= BATCH_OFFSET_BIAS | PIN_OFFSET_BIAS;
627 628
		if (entry->flags & EXEC_OBJECT_PINNED)
			flags |= entry->offset | PIN_OFFSET_FIXED;
629 630
		if ((flags & PIN_MAPPABLE) == 0)
			flags |= PIN_HIGH;
631
	}
632 633

	ret = i915_gem_object_pin(obj, vma->vm, entry->alignment, flags);
634 635 636 637
	if ((ret == -ENOSPC  || ret == -E2BIG) &&
	    only_mappable_for_reloc(entry->flags))
		ret = i915_gem_object_pin(obj, vma->vm,
					  entry->alignment,
638
					  flags & ~PIN_MAPPABLE);
639 640 641
	if (ret)
		return ret;

642 643
	entry->flags |= __EXEC_OBJECT_HAS_PIN;

644 645 646 647
	if (entry->flags & EXEC_OBJECT_NEEDS_FENCE) {
		ret = i915_gem_object_get_fence(obj);
		if (ret)
			return ret;
648

649 650
		if (i915_gem_object_pin_fence(obj))
			entry->flags |= __EXEC_OBJECT_HAS_FENCE;
651 652
	}

653 654
	if (entry->offset != vma->node.start) {
		entry->offset = vma->node.start;
655 656 657 658 659 660 661 662
		*need_reloc = true;
	}

	if (entry->flags & EXEC_OBJECT_WRITE) {
		obj->base.pending_read_domains = I915_GEM_DOMAIN_RENDER;
		obj->base.pending_write_domain = I915_GEM_DOMAIN_RENDER;
	}

663
	return 0;
664
}
665

666
static bool
667
need_reloc_mappable(struct i915_vma *vma)
668 669 670
{
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;

671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691
	if (entry->relocation_count == 0)
		return false;

	if (!i915_is_ggtt(vma->vm))
		return false;

	/* See also use_cpu_reloc() */
	if (HAS_LLC(vma->obj->base.dev))
		return false;

	if (vma->obj->base.write_domain == I915_GEM_DOMAIN_CPU)
		return false;

	return true;
}

static bool
eb_vma_misplaced(struct i915_vma *vma)
{
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
	struct drm_i915_gem_object *obj = vma->obj;
692

693
	WARN_ON(entry->flags & __EXEC_OBJECT_NEEDS_MAP &&
694 695 696 697 698 699
	       !i915_is_ggtt(vma->vm));

	if (entry->alignment &&
	    vma->node.start & (entry->alignment - 1))
		return true;

700 701 702 703
	if (entry->flags & EXEC_OBJECT_PINNED &&
	    vma->node.start != entry->offset)
		return true;

704 705 706 707
	if (entry->flags & __EXEC_OBJECT_NEEDS_BIAS &&
	    vma->node.start < BATCH_OFFSET_BIAS)
		return true;

708 709 710 711
	/* avoid costly ping-pong once a batch bo ended up non-mappable */
	if (entry->flags & __EXEC_OBJECT_NEEDS_MAP && !obj->map_and_fenceable)
		return !only_mappable_for_reloc(entry->flags);

712 713 714 715
	if ((entry->flags & EXEC_OBJECT_SUPPORTS_48B_ADDRESS) == 0 &&
	    (vma->node.start + vma->node.size - 1) >> 32)
		return true;

716 717 718
	return false;
}

719
static int
720
i915_gem_execbuffer_reserve(struct intel_engine_cs *ring,
721
			    struct list_head *vmas,
722
			    struct intel_context *ctx,
723
			    bool *need_relocs)
724
{
725
	struct drm_i915_gem_object *obj;
726
	struct i915_vma *vma;
727
	struct i915_address_space *vm;
728
	struct list_head ordered_vmas;
729
	struct list_head pinned_vmas;
730 731
	bool has_fenced_gpu_access = INTEL_INFO(ring->dev)->gen < 4;
	int retry;
732

733 734
	i915_gem_retire_requests_ring(ring);

735 736
	vm = list_first_entry(vmas, struct i915_vma, exec_list)->vm;

737
	INIT_LIST_HEAD(&ordered_vmas);
738
	INIT_LIST_HEAD(&pinned_vmas);
739
	while (!list_empty(vmas)) {
740 741 742
		struct drm_i915_gem_exec_object2 *entry;
		bool need_fence, need_mappable;

743 744 745
		vma = list_first_entry(vmas, struct i915_vma, exec_list);
		obj = vma->obj;
		entry = vma->exec_entry;
746

747 748 749
		if (ctx->flags & CONTEXT_NO_ZEROMAP)
			entry->flags |= __EXEC_OBJECT_NEEDS_BIAS;

750 751
		if (!has_fenced_gpu_access)
			entry->flags &= ~EXEC_OBJECT_NEEDS_FENCE;
752 753 754
		need_fence =
			entry->flags & EXEC_OBJECT_NEEDS_FENCE &&
			obj->tiling_mode != I915_TILING_NONE;
755
		need_mappable = need_fence || need_reloc_mappable(vma);
756

757 758 759
		if (entry->flags & EXEC_OBJECT_PINNED)
			list_move_tail(&vma->exec_list, &pinned_vmas);
		else if (need_mappable) {
760
			entry->flags |= __EXEC_OBJECT_NEEDS_MAP;
761
			list_move(&vma->exec_list, &ordered_vmas);
762
		} else
763
			list_move_tail(&vma->exec_list, &ordered_vmas);
764

765
		obj->base.pending_read_domains = I915_GEM_GPU_DOMAINS & ~I915_GEM_DOMAIN_COMMAND;
766
		obj->base.pending_write_domain = 0;
767
	}
768
	list_splice(&ordered_vmas, vmas);
769
	list_splice(&pinned_vmas, vmas);
770 771 772 773 774 775 776 777 778 779

	/* Attempt to pin all of the buffers into the GTT.
	 * This is done in 3 phases:
	 *
	 * 1a. Unbind all objects that do not match the GTT constraints for
	 *     the execbuffer (fenceable, mappable, alignment etc).
	 * 1b. Increment pin count for already bound objects.
	 * 2.  Bind new objects.
	 * 3.  Decrement pin count.
	 *
780
	 * This avoid unnecessary unbinding of later objects in order to make
781 782 783 784
	 * room for the earlier objects *unless* we need to defragment.
	 */
	retry = 0;
	do {
785
		int ret = 0;
786 787

		/* Unbind any ill-fitting objects or pin. */
788 789
		list_for_each_entry(vma, vmas, exec_list) {
			if (!drm_mm_node_allocated(&vma->node))
790 791
				continue;

792
			if (eb_vma_misplaced(vma))
793
				ret = i915_vma_unbind(vma);
794
			else
795
				ret = i915_gem_execbuffer_reserve_vma(vma, ring, need_relocs);
796
			if (ret)
797 798 799 800
				goto err;
		}

		/* Bind fresh objects */
801 802
		list_for_each_entry(vma, vmas, exec_list) {
			if (drm_mm_node_allocated(&vma->node))
803
				continue;
804

805
			ret = i915_gem_execbuffer_reserve_vma(vma, ring, need_relocs);
806 807
			if (ret)
				goto err;
808 809
		}

810
err:
C
Chris Wilson 已提交
811
		if (ret != -ENOSPC || retry++)
812 813
			return ret;

814 815 816 817
		/* Decrement pin count for bound objects */
		list_for_each_entry(vma, vmas, exec_list)
			i915_gem_execbuffer_unreserve_vma(vma);

818
		ret = i915_gem_evict_vm(vm, true);
819 820 821 822 823 824 825
		if (ret)
			return ret;
	} while (1);
}

static int
i915_gem_execbuffer_relocate_slow(struct drm_device *dev,
826
				  struct drm_i915_gem_execbuffer2 *args,
827
				  struct drm_file *file,
828
				  struct intel_engine_cs *ring,
829
				  struct eb_vmas *eb,
830 831
				  struct drm_i915_gem_exec_object2 *exec,
				  struct intel_context *ctx)
832 833
{
	struct drm_i915_gem_relocation_entry *reloc;
834 835
	struct i915_address_space *vm;
	struct i915_vma *vma;
836
	bool need_relocs;
837
	int *reloc_offset;
838
	int i, total, ret;
839
	unsigned count = args->buffer_count;
840

841 842
	vm = list_first_entry(&eb->vmas, struct i915_vma, exec_list)->vm;

843
	/* We may process another execbuffer during the unlock... */
844 845 846
	while (!list_empty(&eb->vmas)) {
		vma = list_first_entry(&eb->vmas, struct i915_vma, exec_list);
		list_del_init(&vma->exec_list);
847
		i915_gem_execbuffer_unreserve_vma(vma);
848
		drm_gem_object_unreference(&vma->obj->base);
849 850
	}

851 852 853 854
	mutex_unlock(&dev->struct_mutex);

	total = 0;
	for (i = 0; i < count; i++)
855
		total += exec[i].relocation_count;
856

857
	reloc_offset = drm_malloc_ab(count, sizeof(*reloc_offset));
858
	reloc = drm_malloc_ab(total, sizeof(*reloc));
859 860 861
	if (reloc == NULL || reloc_offset == NULL) {
		drm_free_large(reloc);
		drm_free_large(reloc_offset);
862 863 864 865 866 867 868
		mutex_lock(&dev->struct_mutex);
		return -ENOMEM;
	}

	total = 0;
	for (i = 0; i < count; i++) {
		struct drm_i915_gem_relocation_entry __user *user_relocs;
869 870
		u64 invalid_offset = (u64)-1;
		int j;
871

V
Ville Syrjälä 已提交
872
		user_relocs = to_user_ptr(exec[i].relocs_ptr);
873 874

		if (copy_from_user(reloc+total, user_relocs,
875
				   exec[i].relocation_count * sizeof(*reloc))) {
876 877 878 879 880
			ret = -EFAULT;
			mutex_lock(&dev->struct_mutex);
			goto err;
		}

881 882 883 884 885 886 887 888 889 890
		/* As we do not update the known relocation offsets after
		 * relocating (due to the complexities in lock handling),
		 * we need to mark them as invalid now so that we force the
		 * relocation processing next time. Just in case the target
		 * object is evicted and then rebound into its old
		 * presumed_offset before the next execbuffer - if that
		 * happened we would make the mistake of assuming that the
		 * relocations were valid.
		 */
		for (j = 0; j < exec[i].relocation_count; j++) {
891 892 893
			if (__copy_to_user(&user_relocs[j].presumed_offset,
					   &invalid_offset,
					   sizeof(invalid_offset))) {
894 895 896 897 898 899
				ret = -EFAULT;
				mutex_lock(&dev->struct_mutex);
				goto err;
			}
		}

900
		reloc_offset[i] = total;
901
		total += exec[i].relocation_count;
902 903 904 905 906 907 908 909
	}

	ret = i915_mutex_lock_interruptible(dev);
	if (ret) {
		mutex_lock(&dev->struct_mutex);
		goto err;
	}

910 911
	/* reacquire the objects */
	eb_reset(eb);
912
	ret = eb_lookup_vmas(eb, exec, args, vm, file);
913 914
	if (ret)
		goto err;
915

916
	need_relocs = (args->flags & I915_EXEC_NO_RELOC) == 0;
917
	ret = i915_gem_execbuffer_reserve(ring, &eb->vmas, ctx, &need_relocs);
918 919 920
	if (ret)
		goto err;

921 922 923 924
	list_for_each_entry(vma, &eb->vmas, exec_list) {
		int offset = vma->exec_entry - exec;
		ret = i915_gem_execbuffer_relocate_vma_slow(vma, eb,
							    reloc + reloc_offset[offset]);
925 926 927 928 929 930 931 932 933 934 935 936
		if (ret)
			goto err;
	}

	/* Leave the user relocations as are, this is the painfully slow path,
	 * and we want to avoid the complication of dropping the lock whilst
	 * having buffers reserved in the aperture and so causing spurious
	 * ENOSPC for random operations.
	 */

err:
	drm_free_large(reloc);
937
	drm_free_large(reloc_offset);
938 939 940 941
	return ret;
}

static int
942
i915_gem_execbuffer_move_to_gpu(struct drm_i915_gem_request *req,
943
				struct list_head *vmas)
944
{
945
	const unsigned other_rings = ~intel_ring_flag(req->ring);
946
	struct i915_vma *vma;
947
	uint32_t flush_domains = 0;
948
	bool flush_chipset = false;
949
	int ret;
950

951 952
	list_for_each_entry(vma, vmas, exec_list) {
		struct drm_i915_gem_object *obj = vma->obj;
953 954

		if (obj->active & other_rings) {
955
			ret = i915_gem_object_sync(obj, req->ring, &req);
956 957 958
			if (ret)
				return ret;
		}
959 960

		if (obj->base.write_domain & I915_GEM_DOMAIN_CPU)
961
			flush_chipset |= i915_gem_clflush_object(obj, false);
962 963

		flush_domains |= obj->base.write_domain;
964 965
	}

966
	if (flush_chipset)
967
		i915_gem_chipset_flush(req->ring->dev);
968 969 970 971

	if (flush_domains & I915_GEM_DOMAIN_GTT)
		wmb();

972 973 974
	/* Unconditionally invalidate gpu caches and ensure that we do flush
	 * any residual writes from the previous batch.
	 */
975
	return intel_ring_invalidate_all_caches(req);
976 977
}

978 979
static bool
i915_gem_check_execbuffer(struct drm_i915_gem_execbuffer2 *exec)
980
{
981 982 983
	if (exec->flags & __I915_EXEC_UNKNOWN_FLAGS)
		return false;

C
Chris Wilson 已提交
984 985 986 987 988 989 990 991 992 993 994 995 996 997 998
	/* Kernel clipping was a DRI1 misfeature */
	if (exec->num_cliprects || exec->cliprects_ptr)
		return false;

	if (exec->DR4 == 0xffffffff) {
		DRM_DEBUG("UXA submitting garbage DR4, fixing up\n");
		exec->DR4 = 0;
	}
	if (exec->DR1 || exec->DR4)
		return false;

	if ((exec->batch_start_offset | exec->batch_len) & 0x7)
		return false;

	return true;
999 1000 1001
}

static int
1002 1003
validate_exec_list(struct drm_device *dev,
		   struct drm_i915_gem_exec_object2 *exec,
1004 1005
		   int count)
{
1006 1007
	unsigned relocs_total = 0;
	unsigned relocs_max = UINT_MAX / sizeof(struct drm_i915_gem_relocation_entry);
1008 1009 1010 1011 1012 1013
	unsigned invalid_flags;
	int i;

	invalid_flags = __EXEC_OBJECT_UNKNOWN_FLAGS;
	if (USES_FULL_PPGTT(dev))
		invalid_flags |= EXEC_OBJECT_NEEDS_GTT;
1014 1015

	for (i = 0; i < count; i++) {
V
Ville Syrjälä 已提交
1016
		char __user *ptr = to_user_ptr(exec[i].relocs_ptr);
1017 1018
		int length; /* limited by fault_in_pages_readable() */

1019
		if (exec[i].flags & invalid_flags)
1020 1021
			return -EINVAL;

1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036
		/* Offset can be used as input (EXEC_OBJECT_PINNED), reject
		 * any non-page-aligned or non-canonical addresses.
		 */
		if (exec[i].flags & EXEC_OBJECT_PINNED) {
			if (exec[i].offset !=
			    gen8_canonical_addr(exec[i].offset & PAGE_MASK))
				return -EINVAL;

			/* From drm_mm perspective address space is continuous,
			 * so from this point we're always using non-canonical
			 * form internally.
			 */
			exec[i].offset = gen8_noncanonical_addr(exec[i].offset);
		}

1037 1038 1039
		if (exec[i].alignment && !is_power_of_2(exec[i].alignment))
			return -EINVAL;

1040 1041 1042 1043 1044
		/* First check for malicious input causing overflow in
		 * the worst case where we need to allocate the entire
		 * relocation tree as a single array.
		 */
		if (exec[i].relocation_count > relocs_max - relocs_total)
1045
			return -EINVAL;
1046
		relocs_total += exec[i].relocation_count;
1047 1048 1049

		length = exec[i].relocation_count *
			sizeof(struct drm_i915_gem_relocation_entry);
1050 1051 1052 1053 1054
		/*
		 * We must check that the entire relocation array is safe
		 * to read, but since we may need to update the presumed
		 * offsets during execution, check for full write access.
		 */
1055 1056 1057
		if (!access_ok(VERIFY_WRITE, ptr, length))
			return -EFAULT;

1058
		if (likely(!i915.prefault_disable)) {
1059 1060 1061
			if (fault_in_multipages_readable(ptr, length))
				return -EFAULT;
		}
1062 1063 1064 1065 1066
	}

	return 0;
}

1067
static struct intel_context *
1068
i915_gem_validate_context(struct drm_device *dev, struct drm_file *file,
1069
			  struct intel_engine_cs *ring, const u32 ctx_id)
1070
{
1071
	struct intel_context *ctx = NULL;
1072 1073
	struct i915_ctx_hang_stats *hs;

1074
	if (ring->id != RCS && ctx_id != DEFAULT_CONTEXT_HANDLE)
1075 1076
		return ERR_PTR(-EINVAL);

1077
	ctx = i915_gem_context_get(file->driver_priv, ctx_id);
1078
	if (IS_ERR(ctx))
1079
		return ctx;
1080

1081
	hs = &ctx->hang_stats;
1082 1083
	if (hs->banned) {
		DRM_DEBUG("Context %u tried to submit while banned\n", ctx_id);
1084
		return ERR_PTR(-EIO);
1085 1086
	}

1087
	if (i915.enable_execlists && !ctx->engine[ring->id].state) {
1088
		int ret = intel_lr_context_deferred_alloc(ctx, ring);
1089 1090 1091 1092 1093 1094
		if (ret) {
			DRM_DEBUG("Could not create LRC %u: %d\n", ctx_id, ret);
			return ERR_PTR(ret);
		}
	}

1095
	return ctx;
1096 1097
}

1098
void
1099
i915_gem_execbuffer_move_to_active(struct list_head *vmas,
1100
				   struct drm_i915_gem_request *req)
1101
{
1102
	struct intel_engine_cs *ring = i915_gem_request_get_ring(req);
1103
	struct i915_vma *vma;
1104

1105
	list_for_each_entry(vma, vmas, exec_list) {
1106
		struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
1107
		struct drm_i915_gem_object *obj = vma->obj;
1108 1109
		u32 old_read = obj->base.read_domains;
		u32 old_write = obj->base.write_domain;
C
Chris Wilson 已提交
1110

1111
		obj->dirty = 1; /* be paranoid  */
1112
		obj->base.write_domain = obj->base.pending_write_domain;
1113 1114 1115
		if (obj->base.write_domain == 0)
			obj->base.pending_read_domains |= obj->base.read_domains;
		obj->base.read_domains = obj->base.pending_read_domains;
1116

1117
		i915_vma_move_to_active(vma, req);
1118
		if (obj->base.write_domain) {
1119
			i915_gem_request_assign(&obj->last_write_req, req);
1120

1121
			intel_fb_obj_invalidate(obj, ORIGIN_CS);
1122 1123 1124

			/* update for the implicit flush after a batch */
			obj->base.write_domain &= ~I915_GEM_GPU_DOMAINS;
1125
		}
1126
		if (entry->flags & EXEC_OBJECT_NEEDS_FENCE) {
1127
			i915_gem_request_assign(&obj->last_fenced_req, req);
1128 1129 1130 1131 1132 1133
			if (entry->flags & __EXEC_OBJECT_HAS_FENCE) {
				struct drm_i915_private *dev_priv = to_i915(ring->dev);
				list_move_tail(&dev_priv->fence_regs[obj->fence_reg].lru_list,
					       &dev_priv->mm.fence_list);
			}
		}
1134

C
Chris Wilson 已提交
1135
		trace_i915_gem_object_change_domain(obj, old_read, old_write);
1136 1137 1138
	}
}

1139
void
1140
i915_gem_execbuffer_retire_commands(struct i915_execbuffer_params *params)
1141
{
1142
	/* Unconditionally force add_request to emit a full flush. */
1143
	params->ring->gpu_caches_dirty = true;
1144

1145
	/* Add a breadcrumb for the completion of the batch buffer */
1146
	__i915_add_request(params->request, params->batch_obj, true);
1147
}
1148

1149 1150
static int
i915_reset_gen7_sol_offsets(struct drm_device *dev,
1151
			    struct drm_i915_gem_request *req)
1152
{
1153
	struct intel_engine_cs *ring = req->ring;
1154
	struct drm_i915_private *dev_priv = dev->dev_private;
1155 1156
	int ret, i;

1157 1158 1159 1160
	if (!IS_GEN7(dev) || ring != &dev_priv->ring[RCS]) {
		DRM_DEBUG("sol reset is gen7/rcs only\n");
		return -EINVAL;
	}
1161

1162
	ret = intel_ring_begin(req, 4 * 3);
1163 1164 1165 1166 1167
	if (ret)
		return ret;

	for (i = 0; i < 4; i++) {
		intel_ring_emit(ring, MI_LOAD_REGISTER_IMM(1));
1168
		intel_ring_emit_reg(ring, GEN7_SO_WRITE_OFFSET(i));
1169 1170 1171 1172 1173 1174 1175 1176
		intel_ring_emit(ring, 0);
	}

	intel_ring_advance(ring);

	return 0;
}

1177 1178 1179 1180 1181 1182 1183
static struct drm_i915_gem_object*
i915_gem_execbuffer_parse(struct intel_engine_cs *ring,
			  struct drm_i915_gem_exec_object2 *shadow_exec_entry,
			  struct eb_vmas *eb,
			  struct drm_i915_gem_object *batch_obj,
			  u32 batch_start_offset,
			  u32 batch_len,
1184
			  bool is_master)
1185 1186
{
	struct drm_i915_gem_object *shadow_batch_obj;
1187
	struct i915_vma *vma;
1188 1189
	int ret;

1190
	shadow_batch_obj = i915_gem_batch_pool_get(&ring->batch_pool,
1191
						   PAGE_ALIGN(batch_len));
1192 1193 1194 1195 1196 1197 1198 1199 1200
	if (IS_ERR(shadow_batch_obj))
		return shadow_batch_obj;

	ret = i915_parse_cmds(ring,
			      batch_obj,
			      shadow_batch_obj,
			      batch_start_offset,
			      batch_len,
			      is_master);
1201 1202
	if (ret)
		goto err;
1203

1204 1205 1206
	ret = i915_gem_obj_ggtt_pin(shadow_batch_obj, 0, 0);
	if (ret)
		goto err;
1207

C
Chris Wilson 已提交
1208 1209
	i915_gem_object_unpin_pages(shadow_batch_obj);

1210
	memset(shadow_exec_entry, 0, sizeof(*shadow_exec_entry));
1211

1212 1213
	vma = i915_gem_obj_to_ggtt(shadow_batch_obj);
	vma->exec_entry = shadow_exec_entry;
C
Chris Wilson 已提交
1214
	vma->exec_entry->flags = __EXEC_OBJECT_HAS_PIN;
1215 1216
	drm_gem_object_reference(&shadow_batch_obj->base);
	list_add_tail(&vma->exec_list, &eb->vmas);
1217

1218 1219 1220
	shadow_batch_obj->base.pending_read_domains = I915_GEM_DOMAIN_COMMAND;

	return shadow_batch_obj;
1221

1222
err:
C
Chris Wilson 已提交
1223
	i915_gem_object_unpin_pages(shadow_batch_obj);
1224 1225 1226 1227
	if (ret == -EACCES) /* unhandled chained batch */
		return batch_obj;
	else
		return ERR_PTR(ret);
1228
}
1229

1230
int
1231
i915_gem_ringbuffer_submission(struct i915_execbuffer_params *params,
1232
			       struct drm_i915_gem_execbuffer2 *args,
1233
			       struct list_head *vmas)
1234
{
1235 1236
	struct drm_device *dev = params->dev;
	struct intel_engine_cs *ring = params->ring;
1237
	struct drm_i915_private *dev_priv = dev->dev_private;
1238
	u64 exec_start, exec_len;
1239 1240
	int instp_mode;
	u32 instp_mask;
C
Chris Wilson 已提交
1241
	int ret;
1242

1243
	ret = i915_gem_execbuffer_move_to_gpu(params->request, vmas);
1244
	if (ret)
C
Chris Wilson 已提交
1245
		return ret;
1246

1247
	ret = i915_switch_context(params->request);
1248
	if (ret)
C
Chris Wilson 已提交
1249
		return ret;
1250

1251
	WARN(params->ctx->ppgtt && params->ctx->ppgtt->pd_dirty_rings & (1<<ring->id),
1252
	     "%s didn't clear reload\n", ring->name);
1253

1254 1255 1256 1257 1258 1259 1260 1261
	instp_mode = args->flags & I915_EXEC_CONSTANTS_MASK;
	instp_mask = I915_EXEC_CONSTANTS_MASK;
	switch (instp_mode) {
	case I915_EXEC_CONSTANTS_REL_GENERAL:
	case I915_EXEC_CONSTANTS_ABSOLUTE:
	case I915_EXEC_CONSTANTS_REL_SURFACE:
		if (instp_mode != 0 && ring != &dev_priv->ring[RCS]) {
			DRM_DEBUG("non-0 rel constants mode on non-RCS\n");
C
Chris Wilson 已提交
1262
			return -EINVAL;
1263 1264 1265 1266 1267
		}

		if (instp_mode != dev_priv->relative_constants_mode) {
			if (INTEL_INFO(dev)->gen < 4) {
				DRM_DEBUG("no rel constants on pre-gen4\n");
C
Chris Wilson 已提交
1268
				return -EINVAL;
1269 1270 1271 1272 1273
			}

			if (INTEL_INFO(dev)->gen > 5 &&
			    instp_mode == I915_EXEC_CONSTANTS_REL_SURFACE) {
				DRM_DEBUG("rel surface constants mode invalid on gen5+\n");
C
Chris Wilson 已提交
1274
				return -EINVAL;
1275 1276 1277 1278 1279 1280 1281 1282 1283
			}

			/* The HW changed the meaning on this bit on gen6 */
			if (INTEL_INFO(dev)->gen >= 6)
				instp_mask &= ~I915_EXEC_CONSTANTS_REL_SURFACE;
		}
		break;
	default:
		DRM_DEBUG("execbuf with unknown constants: %d\n", instp_mode);
C
Chris Wilson 已提交
1284
		return -EINVAL;
1285 1286 1287
	}

	if (ring == &dev_priv->ring[RCS] &&
C
Chris Wilson 已提交
1288
	    instp_mode != dev_priv->relative_constants_mode) {
1289
		ret = intel_ring_begin(params->request, 4);
1290
		if (ret)
C
Chris Wilson 已提交
1291
			return ret;
1292 1293 1294

		intel_ring_emit(ring, MI_NOOP);
		intel_ring_emit(ring, MI_LOAD_REGISTER_IMM(1));
1295
		intel_ring_emit_reg(ring, INSTPM);
1296 1297 1298 1299 1300 1301 1302
		intel_ring_emit(ring, instp_mask << 16 | instp_mode);
		intel_ring_advance(ring);

		dev_priv->relative_constants_mode = instp_mode;
	}

	if (args->flags & I915_EXEC_GEN7_SOL_RESET) {
1303
		ret = i915_reset_gen7_sol_offsets(dev, params->request);
1304
		if (ret)
C
Chris Wilson 已提交
1305
			return ret;
1306 1307
	}

1308 1309 1310 1311
	exec_len   = args->batch_len;
	exec_start = params->batch_obj_vm_offset +
		     params->args_batch_start_offset;

1312 1313 1314
	if (exec_len == 0)
		exec_len = params->batch_obj->base.size;

C
Chris Wilson 已提交
1315 1316 1317 1318 1319
	ret = ring->dispatch_execbuffer(params->request,
					exec_start, exec_len,
					params->dispatch_flags);
	if (ret)
		return ret;
1320

1321
	trace_i915_gem_ring_dispatch(params->request, params->dispatch_flags);
1322

1323
	i915_gem_execbuffer_move_to_active(vmas, params->request);
1324
	i915_gem_execbuffer_retire_commands(params);
1325

C
Chris Wilson 已提交
1326
	return 0;
1327 1328
}

1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346
/**
 * Find one BSD ring to dispatch the corresponding BSD command.
 * The Ring ID is returned.
 */
static int gen8_dispatch_bsd_ring(struct drm_device *dev,
				  struct drm_file *file)
{
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct drm_i915_file_private *file_priv = file->driver_priv;

	/* Check whether the file_priv is using one ring */
	if (file_priv->bsd_ring)
		return file_priv->bsd_ring->id;
	else {
		/* If no, use the ping-pong mechanism to select one ring */
		int ring_id;

		mutex_lock(&dev->struct_mutex);
1347
		if (dev_priv->mm.bsd_ring_dispatch_index == 0) {
1348
			ring_id = VCS;
1349
			dev_priv->mm.bsd_ring_dispatch_index = 1;
1350 1351
		} else {
			ring_id = VCS2;
1352
			dev_priv->mm.bsd_ring_dispatch_index = 0;
1353 1354 1355 1356 1357 1358 1359
		}
		file_priv->bsd_ring = &dev_priv->ring[ring_id];
		mutex_unlock(&dev->struct_mutex);
		return ring_id;
	}
}

1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373
static struct drm_i915_gem_object *
eb_get_batch(struct eb_vmas *eb)
{
	struct i915_vma *vma = list_entry(eb->vmas.prev, typeof(*vma), exec_list);

	/*
	 * SNA is doing fancy tricks with compressing batch buffers, which leads
	 * to negative relocation deltas. Usually that works out ok since the
	 * relocate address is still positive, except when the batch is placed
	 * very low in the GTT. Ensure this doesn't happen.
	 *
	 * Note that actual hangs have only been observed on gen7, but for
	 * paranoia do it everywhere.
	 */
1374 1375
	if ((vma->exec_entry->flags & EXEC_OBJECT_PINNED) == 0)
		vma->exec_entry->flags |= __EXEC_OBJECT_NEEDS_BIAS;
1376 1377 1378 1379

	return vma->obj;
}

1380 1381 1382 1383
static int
i915_gem_do_execbuffer(struct drm_device *dev, void *data,
		       struct drm_file *file,
		       struct drm_i915_gem_execbuffer2 *args,
1384
		       struct drm_i915_gem_exec_object2 *exec)
1385
{
1386
	struct drm_i915_private *dev_priv = dev->dev_private;
1387
	struct eb_vmas *eb;
1388
	struct drm_i915_gem_object *batch_obj;
1389
	struct drm_i915_gem_exec_object2 shadow_exec_entry;
1390
	struct intel_engine_cs *ring;
1391
	struct intel_context *ctx;
1392
	struct i915_address_space *vm;
1393 1394
	struct i915_execbuffer_params params_master; /* XXX: will be removed later */
	struct i915_execbuffer_params *params = &params_master;
1395
	const u32 ctx_id = i915_execbuffer2_get_context_id(*args);
1396
	u32 dispatch_flags;
1397
	int ret;
1398
	bool need_relocs;
1399

1400
	if (!i915_gem_check_execbuffer(args))
1401 1402
		return -EINVAL;

1403
	ret = validate_exec_list(dev, exec, args->buffer_count);
1404 1405 1406
	if (ret)
		return ret;

1407
	dispatch_flags = 0;
1408 1409 1410 1411
	if (args->flags & I915_EXEC_SECURE) {
		if (!file->is_master || !capable(CAP_SYS_ADMIN))
		    return -EPERM;

1412
		dispatch_flags |= I915_DISPATCH_SECURE;
1413
	}
1414
	if (args->flags & I915_EXEC_IS_PINNED)
1415
		dispatch_flags |= I915_DISPATCH_PINNED;
1416

1417
	if ((args->flags & I915_EXEC_RING_MASK) > LAST_USER_RING) {
1418
		DRM_DEBUG("execbuf with unknown ring: %d\n",
1419 1420 1421
			  (int)(args->flags & I915_EXEC_RING_MASK));
		return -EINVAL;
	}
1422

1423 1424 1425 1426 1427 1428 1429
	if (((args->flags & I915_EXEC_RING_MASK) != I915_EXEC_BSD) &&
	    ((args->flags & I915_EXEC_BSD_MASK) != 0)) {
		DRM_DEBUG("execbuf with non bsd ring but with invalid "
			"bsd dispatch flags: %d\n", (int)(args->flags));
		return -EINVAL;
	} 

1430 1431
	if ((args->flags & I915_EXEC_RING_MASK) == I915_EXEC_DEFAULT)
		ring = &dev_priv->ring[RCS];
1432 1433 1434
	else if ((args->flags & I915_EXEC_RING_MASK) == I915_EXEC_BSD) {
		if (HAS_BSD2(dev)) {
			int ring_id;
1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451

			switch (args->flags & I915_EXEC_BSD_MASK) {
			case I915_EXEC_BSD_DEFAULT:
				ring_id = gen8_dispatch_bsd_ring(dev, file);
				ring = &dev_priv->ring[ring_id];
				break;
			case I915_EXEC_BSD_RING1:
				ring = &dev_priv->ring[VCS];
				break;
			case I915_EXEC_BSD_RING2:
				ring = &dev_priv->ring[VCS2];
				break;
			default:
				DRM_DEBUG("execbuf with unknown bsd ring: %d\n",
					  (int)(args->flags & I915_EXEC_BSD_MASK));
				return -EINVAL;
			}
1452 1453 1454
		} else
			ring = &dev_priv->ring[VCS];
	} else
1455 1456
		ring = &dev_priv->ring[(args->flags & I915_EXEC_RING_MASK) - 1];

1457 1458 1459 1460 1461
	if (!intel_ring_initialized(ring)) {
		DRM_DEBUG("execbuf with invalid ring: %d\n",
			  (int)(args->flags & I915_EXEC_RING_MASK));
		return -EINVAL;
	}
1462 1463

	if (args->buffer_count < 1) {
1464
		DRM_DEBUG("execbuf with %d buffers\n", args->buffer_count);
1465 1466 1467
		return -EINVAL;
	}

1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481
	if (args->flags & I915_EXEC_RESOURCE_STREAMER) {
		if (!HAS_RESOURCE_STREAMER(dev)) {
			DRM_DEBUG("RS is only allowed for Haswell, Gen8 and above\n");
			return -EINVAL;
		}
		if (ring->id != RCS) {
			DRM_DEBUG("RS is not available on %s\n",
				 ring->name);
			return -EINVAL;
		}

		dispatch_flags |= I915_DISPATCH_RS;
	}

1482 1483
	intel_runtime_pm_get(dev_priv);

1484 1485 1486 1487
	ret = i915_mutex_lock_interruptible(dev);
	if (ret)
		goto pre_mutex_err;

1488
	ctx = i915_gem_validate_context(dev, file, ring, ctx_id);
1489
	if (IS_ERR(ctx)) {
1490
		mutex_unlock(&dev->struct_mutex);
1491
		ret = PTR_ERR(ctx);
1492
		goto pre_mutex_err;
1493
	}
1494 1495 1496

	i915_gem_context_reference(ctx);

1497 1498 1499
	if (ctx->ppgtt)
		vm = &ctx->ppgtt->base;
	else
1500
		vm = &dev_priv->gtt.base;
1501

1502 1503
	memset(&params_master, 0x00, sizeof(params_master));

B
Ben Widawsky 已提交
1504
	eb = eb_create(args);
1505
	if (eb == NULL) {
1506
		i915_gem_context_unreference(ctx);
1507 1508 1509 1510 1511
		mutex_unlock(&dev->struct_mutex);
		ret = -ENOMEM;
		goto pre_mutex_err;
	}

1512
	/* Look up object handles */
1513
	ret = eb_lookup_vmas(eb, exec, args, vm, file);
1514 1515
	if (ret)
		goto err;
1516

1517
	/* take note of the batch buffer before we might reorder the lists */
1518
	batch_obj = eb_get_batch(eb);
1519

1520
	/* Move the objects en-masse into the GTT, evicting if necessary. */
1521
	need_relocs = (args->flags & I915_EXEC_NO_RELOC) == 0;
1522
	ret = i915_gem_execbuffer_reserve(ring, &eb->vmas, ctx, &need_relocs);
1523 1524 1525 1526
	if (ret)
		goto err;

	/* The objects are in their final locations, apply the relocations. */
1527
	if (need_relocs)
B
Ben Widawsky 已提交
1528
		ret = i915_gem_execbuffer_relocate(eb);
1529 1530
	if (ret) {
		if (ret == -EFAULT) {
1531
			ret = i915_gem_execbuffer_relocate_slow(dev, args, file, ring,
1532
								eb, exec, ctx);
1533 1534 1535 1536 1537 1538 1539 1540
			BUG_ON(!mutex_is_locked(&dev->struct_mutex));
		}
		if (ret)
			goto err;
	}

	/* Set the pending read domains for the batch buffer to COMMAND */
	if (batch_obj->base.pending_write_domain) {
1541
		DRM_DEBUG("Attempting to use self-modifying batch buffer\n");
1542 1543 1544 1545
		ret = -EINVAL;
		goto err;
	}

1546
	params->args_batch_start_offset = args->batch_start_offset;
1547
	if (i915_needs_cmd_parser(ring) && args->batch_len) {
1548 1549 1550
		struct drm_i915_gem_object *parsed_batch_obj;

		parsed_batch_obj = i915_gem_execbuffer_parse(ring,
1551 1552 1553 1554 1555
						      &shadow_exec_entry,
						      eb,
						      batch_obj,
						      args->batch_start_offset,
						      args->batch_len,
1556
						      file->is_master);
1557 1558
		if (IS_ERR(parsed_batch_obj)) {
			ret = PTR_ERR(parsed_batch_obj);
1559 1560
			goto err;
		}
1561 1562

		/*
1563 1564
		 * parsed_batch_obj == batch_obj means batch not fully parsed:
		 * Accept, but don't promote to secure.
1565 1566
		 */

1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577
		if (parsed_batch_obj != batch_obj) {
			/*
			 * Batch parsed and accepted:
			 *
			 * Set the DISPATCH_SECURE bit to remove the NON_SECURE
			 * bit from MI_BATCH_BUFFER_START commands issued in
			 * the dispatch_execbuffer implementations. We
			 * specifically don't want that set on batches the
			 * command parser has accepted.
			 */
			dispatch_flags |= I915_DISPATCH_SECURE;
1578
			params->args_batch_start_offset = 0;
1579 1580
			batch_obj = parsed_batch_obj;
		}
1581 1582
	}

1583 1584
	batch_obj->base.pending_read_domains |= I915_GEM_DOMAIN_COMMAND;

1585 1586
	/* snb/ivb/vlv conflate the "batch in ppgtt" bit with the "non-secure
	 * batch" bit. Hence we need to pin secure batches into the global gtt.
B
Ben Widawsky 已提交
1587
	 * hsw should have this fixed, but bdw mucks it up again. */
1588
	if (dispatch_flags & I915_DISPATCH_SECURE) {
1589 1590 1591 1592 1593 1594
		/*
		 * So on first glance it looks freaky that we pin the batch here
		 * outside of the reservation loop. But:
		 * - The batch is already pinned into the relevant ppgtt, so we
		 *   already have the backing storage fully allocated.
		 * - No other BO uses the global gtt (well contexts, but meh),
1595
		 *   so we don't really have issues with multiple objects not
1596 1597 1598 1599 1600 1601
		 *   fitting due to fragmentation.
		 * So this is actually safe.
		 */
		ret = i915_gem_obj_ggtt_pin(batch_obj, 0, 0);
		if (ret)
			goto err;
1602

1603
		params->batch_obj_vm_offset = i915_gem_obj_ggtt_offset(batch_obj);
1604
	} else
1605
		params->batch_obj_vm_offset = i915_gem_obj_offset(batch_obj, vm);
1606

1607
	/* Allocate a request for this batch buffer nice and early. */
1608
	ret = i915_gem_request_alloc(ring, ctx, &params->request);
1609 1610 1611
	if (ret)
		goto err_batch_unpin;

1612 1613 1614 1615
	ret = i915_gem_request_add_to_client(params->request, file);
	if (ret)
		goto err_batch_unpin;

1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629
	/*
	 * Save assorted stuff away to pass through to *_submission().
	 * NB: This data should be 'persistent' and not local as it will
	 * kept around beyond the duration of the IOCTL once the GPU
	 * scheduler arrives.
	 */
	params->dev                     = dev;
	params->file                    = file;
	params->ring                    = ring;
	params->dispatch_flags          = dispatch_flags;
	params->batch_obj               = batch_obj;
	params->ctx                     = ctx;

	ret = dev_priv->gt.execbuf_submit(params, args, &eb->vmas);
1630

1631
err_batch_unpin:
1632 1633 1634 1635 1636 1637
	/*
	 * FIXME: We crucially rely upon the active tracking for the (ppgtt)
	 * batch vma for correctness. For less ugly and less fragility this
	 * needs to be adjusted to also track the ggtt batch vma properly as
	 * active.
	 */
1638
	if (dispatch_flags & I915_DISPATCH_SECURE)
1639
		i915_gem_object_ggtt_unpin(batch_obj);
1640

1641
err:
1642 1643
	/* the request owns the ref now */
	i915_gem_context_unreference(ctx);
1644
	eb_destroy(eb);
1645

1646 1647 1648 1649 1650
	/*
	 * If the request was created but not successfully submitted then it
	 * must be freed again. If it was submitted then it is being tracked
	 * on the active request list and no clean up is required here.
	 */
1651
	if (ret && params->request)
1652 1653
		i915_gem_request_cancel(params->request);

1654 1655 1656
	mutex_unlock(&dev->struct_mutex);

pre_mutex_err:
1657 1658 1659
	/* intel_gpu_busy should also get a ref, so it will free when the device
	 * is really idle. */
	intel_runtime_pm_put(dev_priv);
1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677
	return ret;
}

/*
 * Legacy execbuffer just creates an exec2 list from the original exec object
 * list array and passes it to the real function.
 */
int
i915_gem_execbuffer(struct drm_device *dev, void *data,
		    struct drm_file *file)
{
	struct drm_i915_gem_execbuffer *args = data;
	struct drm_i915_gem_execbuffer2 exec2;
	struct drm_i915_gem_exec_object *exec_list = NULL;
	struct drm_i915_gem_exec_object2 *exec2_list = NULL;
	int ret, i;

	if (args->buffer_count < 1) {
1678
		DRM_DEBUG("execbuf with %d buffers\n", args->buffer_count);
1679 1680 1681 1682 1683 1684 1685
		return -EINVAL;
	}

	/* Copy in the exec list from userland */
	exec_list = drm_malloc_ab(sizeof(*exec_list), args->buffer_count);
	exec2_list = drm_malloc_ab(sizeof(*exec2_list), args->buffer_count);
	if (exec_list == NULL || exec2_list == NULL) {
1686
		DRM_DEBUG("Failed to allocate exec list for %d buffers\n",
1687 1688 1689 1690 1691 1692
			  args->buffer_count);
		drm_free_large(exec_list);
		drm_free_large(exec2_list);
		return -ENOMEM;
	}
	ret = copy_from_user(exec_list,
V
Ville Syrjälä 已提交
1693
			     to_user_ptr(args->buffers_ptr),
1694 1695
			     sizeof(*exec_list) * args->buffer_count);
	if (ret != 0) {
1696
		DRM_DEBUG("copy %d exec entries failed %d\n",
1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723
			  args->buffer_count, ret);
		drm_free_large(exec_list);
		drm_free_large(exec2_list);
		return -EFAULT;
	}

	for (i = 0; i < args->buffer_count; i++) {
		exec2_list[i].handle = exec_list[i].handle;
		exec2_list[i].relocation_count = exec_list[i].relocation_count;
		exec2_list[i].relocs_ptr = exec_list[i].relocs_ptr;
		exec2_list[i].alignment = exec_list[i].alignment;
		exec2_list[i].offset = exec_list[i].offset;
		if (INTEL_INFO(dev)->gen < 4)
			exec2_list[i].flags = EXEC_OBJECT_NEEDS_FENCE;
		else
			exec2_list[i].flags = 0;
	}

	exec2.buffers_ptr = args->buffers_ptr;
	exec2.buffer_count = args->buffer_count;
	exec2.batch_start_offset = args->batch_start_offset;
	exec2.batch_len = args->batch_len;
	exec2.DR1 = args->DR1;
	exec2.DR4 = args->DR4;
	exec2.num_cliprects = args->num_cliprects;
	exec2.cliprects_ptr = args->cliprects_ptr;
	exec2.flags = I915_EXEC_RENDER;
1724
	i915_execbuffer2_set_context_id(exec2, 0);
1725

1726
	ret = i915_gem_do_execbuffer(dev, data, file, &exec2, exec2_list);
1727
	if (!ret) {
1728 1729 1730
		struct drm_i915_gem_exec_object __user *user_exec_list =
			to_user_ptr(args->buffers_ptr);

1731
		/* Copy the new buffer offsets back to the user's exec list. */
1732
		for (i = 0; i < args->buffer_count; i++) {
1733 1734
			exec2_list[i].offset =
				gen8_canonical_addr(exec2_list[i].offset);
1735 1736 1737 1738 1739 1740 1741 1742 1743 1744
			ret = __copy_to_user(&user_exec_list[i].offset,
					     &exec2_list[i].offset,
					     sizeof(user_exec_list[i].offset));
			if (ret) {
				ret = -EFAULT;
				DRM_DEBUG("failed to copy %d exec entries "
					  "back to user (%d)\n",
					  args->buffer_count, ret);
				break;
			}
1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760
		}
	}

	drm_free_large(exec_list);
	drm_free_large(exec2_list);
	return ret;
}

int
i915_gem_execbuffer2(struct drm_device *dev, void *data,
		     struct drm_file *file)
{
	struct drm_i915_gem_execbuffer2 *args = data;
	struct drm_i915_gem_exec_object2 *exec2_list = NULL;
	int ret;

1761 1762
	if (args->buffer_count < 1 ||
	    args->buffer_count > UINT_MAX / sizeof(*exec2_list)) {
1763
		DRM_DEBUG("execbuf2 with %d buffers\n", args->buffer_count);
1764 1765 1766
		return -EINVAL;
	}

1767 1768 1769 1770 1771
	if (args->rsvd2 != 0) {
		DRM_DEBUG("dirty rvsd2 field\n");
		return -EINVAL;
	}

1772
	exec2_list = kmalloc(sizeof(*exec2_list)*args->buffer_count,
1773
			     GFP_TEMPORARY | __GFP_NOWARN | __GFP_NORETRY);
1774 1775 1776
	if (exec2_list == NULL)
		exec2_list = drm_malloc_ab(sizeof(*exec2_list),
					   args->buffer_count);
1777
	if (exec2_list == NULL) {
1778
		DRM_DEBUG("Failed to allocate exec list for %d buffers\n",
1779 1780 1781 1782
			  args->buffer_count);
		return -ENOMEM;
	}
	ret = copy_from_user(exec2_list,
V
Ville Syrjälä 已提交
1783
			     to_user_ptr(args->buffers_ptr),
1784 1785
			     sizeof(*exec2_list) * args->buffer_count);
	if (ret != 0) {
1786
		DRM_DEBUG("copy %d exec entries failed %d\n",
1787 1788 1789 1790 1791
			  args->buffer_count, ret);
		drm_free_large(exec2_list);
		return -EFAULT;
	}

1792
	ret = i915_gem_do_execbuffer(dev, data, file, args, exec2_list);
1793 1794
	if (!ret) {
		/* Copy the new buffer offsets back to the user's exec list. */
1795
		struct drm_i915_gem_exec_object2 __user *user_exec_list =
1796 1797 1798 1799
				   to_user_ptr(args->buffers_ptr);
		int i;

		for (i = 0; i < args->buffer_count; i++) {
1800 1801
			exec2_list[i].offset =
				gen8_canonical_addr(exec2_list[i].offset);
1802 1803 1804 1805 1806 1807 1808 1809 1810 1811
			ret = __copy_to_user(&user_exec_list[i].offset,
					     &exec2_list[i].offset,
					     sizeof(user_exec_list[i].offset));
			if (ret) {
				ret = -EFAULT;
				DRM_DEBUG("failed to copy %d exec entries "
					  "back to user\n",
					  args->buffer_count);
				break;
			}
1812 1813 1814 1815 1816 1817
		}
	}

	drm_free_large(exec2_list);
	return ret;
}