i915_gem_execbuffer.c 52.7 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28
/*
 * Copyright © 2008,2010 Intel Corporation
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice (including the next
 * paragraph) shall be included in all copies or substantial portions of the
 * Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
 * IN THE SOFTWARE.
 *
 * Authors:
 *    Eric Anholt <eric@anholt.net>
 *    Chris Wilson <chris@chris-wilson.co.uk>
 *
 */

29 30 31 32
#include <linux/dma_remapping.h>
#include <linux/reservation.h>
#include <linux/uaccess.h>

33 34
#include <drm/drmP.h>
#include <drm/i915_drm.h>
35

36 37 38
#include "i915_drv.h"
#include "i915_trace.h"
#include "intel_drv.h"
39
#include "intel_frontbuffer.h"
40

41 42
#define DBG_USE_CPU_RELOC 0 /* -1 force GTT relocs; 1 force CPU relocs */

43 44 45 46 47
#define  __EXEC_OBJECT_HAS_PIN		(1<<31)
#define  __EXEC_OBJECT_HAS_FENCE	(1<<30)
#define  __EXEC_OBJECT_NEEDS_MAP	(1<<29)
#define  __EXEC_OBJECT_NEEDS_BIAS	(1<<28)
#define  __EXEC_OBJECT_INTERNAL_FLAGS (0xf<<28) /* all of the above */
48 49

#define BATCH_OFFSET_BIAS (256*1024)
50

51 52 53
struct i915_execbuffer_params {
	struct drm_device               *dev;
	struct drm_file                 *file;
54 55 56
	struct i915_vma			*batch;
	u32				dispatch_flags;
	u32				args_batch_start_offset;
57 58 59 60 61
	struct intel_engine_cs          *engine;
	struct i915_gem_context         *ctx;
	struct drm_i915_gem_request     *request;
};

62
struct eb_vmas {
63
	struct drm_i915_private *i915;
64
	struct list_head vmas;
65
	int and;
66
	union {
67
		struct i915_vma *lut[0];
68 69
		struct hlist_head buckets[0];
	};
70 71
};

72
static struct eb_vmas *
73 74
eb_create(struct drm_i915_private *i915,
	  struct drm_i915_gem_execbuffer2 *args)
75
{
76
	struct eb_vmas *eb = NULL;
77 78

	if (args->flags & I915_EXEC_HANDLE_LUT) {
79
		unsigned size = args->buffer_count;
80 81
		size *= sizeof(struct i915_vma *);
		size += sizeof(struct eb_vmas);
82 83 84 85
		eb = kmalloc(size, GFP_TEMPORARY | __GFP_NOWARN | __GFP_NORETRY);
	}

	if (eb == NULL) {
86 87
		unsigned size = args->buffer_count;
		unsigned count = PAGE_SIZE / sizeof(struct hlist_head) / 2;
L
Lauri Kasanen 已提交
88
		BUILD_BUG_ON_NOT_POWER_OF_2(PAGE_SIZE / sizeof(struct hlist_head));
89 90 91
		while (count > 2*size)
			count >>= 1;
		eb = kzalloc(count*sizeof(struct hlist_head) +
92
			     sizeof(struct eb_vmas),
93 94 95 96 97 98 99 100
			     GFP_TEMPORARY);
		if (eb == NULL)
			return eb;

		eb->and = count - 1;
	} else
		eb->and = -args->buffer_count;

101
	eb->i915 = i915;
102
	INIT_LIST_HEAD(&eb->vmas);
103 104 105 106
	return eb;
}

static void
107
eb_reset(struct eb_vmas *eb)
108
{
109 110
	if (eb->and >= 0)
		memset(eb->buckets, 0, (eb->and+1)*sizeof(struct hlist_head));
111 112
}

113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132
static struct i915_vma *
eb_get_batch(struct eb_vmas *eb)
{
	struct i915_vma *vma = list_entry(eb->vmas.prev, typeof(*vma), exec_list);

	/*
	 * SNA is doing fancy tricks with compressing batch buffers, which leads
	 * to negative relocation deltas. Usually that works out ok since the
	 * relocate address is still positive, except when the batch is placed
	 * very low in the GTT. Ensure this doesn't happen.
	 *
	 * Note that actual hangs have only been observed on gen7, but for
	 * paranoia do it everywhere.
	 */
	if ((vma->exec_entry->flags & EXEC_OBJECT_PINNED) == 0)
		vma->exec_entry->flags |= __EXEC_OBJECT_NEEDS_BIAS;

	return vma;
}

133
static int
134 135 136 137 138
eb_lookup_vmas(struct eb_vmas *eb,
	       struct drm_i915_gem_exec_object2 *exec,
	       const struct drm_i915_gem_execbuffer2 *args,
	       struct i915_address_space *vm,
	       struct drm_file *file)
139
{
140 141
	struct drm_i915_gem_object *obj;
	struct list_head objects;
142
	int i, ret;
143

144
	INIT_LIST_HEAD(&objects);
145
	spin_lock(&file->table_lock);
146 147
	/* Grab a reference to the object and release the lock so we can lookup
	 * or create the VMA without using GFP_ATOMIC */
148
	for (i = 0; i < args->buffer_count; i++) {
149 150 151 152 153
		obj = to_intel_bo(idr_find(&file->object_idr, exec[i].handle));
		if (obj == NULL) {
			spin_unlock(&file->table_lock);
			DRM_DEBUG("Invalid object handle %d at index %d\n",
				   exec[i].handle, i);
154
			ret = -ENOENT;
155
			goto err;
156 157
		}

158
		if (!list_empty(&obj->obj_exec_link)) {
159 160 161
			spin_unlock(&file->table_lock);
			DRM_DEBUG("Object %p [handle %d, index %d] appears more than once in object list\n",
				   obj, exec[i].handle, i);
162
			ret = -EINVAL;
163
			goto err;
164 165
		}

166
		i915_gem_object_get(obj);
167 168 169
		list_add_tail(&obj->obj_exec_link, &objects);
	}
	spin_unlock(&file->table_lock);
170

171
	i = 0;
172
	while (!list_empty(&objects)) {
173
		struct i915_vma *vma;
174

175 176 177 178
		obj = list_first_entry(&objects,
				       struct drm_i915_gem_object,
				       obj_exec_link);

179 180 181 182 183 184 185 186
		/*
		 * NOTE: We can leak any vmas created here when something fails
		 * later on. But that's no issue since vma_unbind can deal with
		 * vmas which are not actually bound. And since only
		 * lookup_or_create exists as an interface to get at the vma
		 * from the (obj, vm) we don't run the risk of creating
		 * duplicated vmas for the same vm.
		 */
C
Chris Wilson 已提交
187 188
		vma = i915_gem_obj_lookup_or_create_vma(obj, vm, NULL);
		if (unlikely(IS_ERR(vma))) {
189 190
			DRM_DEBUG("Failed to lookup VMA\n");
			ret = PTR_ERR(vma);
191
			goto err;
192 193
		}

194
		/* Transfer ownership from the objects list to the vmas list. */
195
		list_add_tail(&vma->exec_list, &eb->vmas);
196
		list_del_init(&obj->obj_exec_link);
197 198

		vma->exec_entry = &exec[i];
199
		if (eb->and < 0) {
200
			eb->lut[i] = vma;
201 202
		} else {
			uint32_t handle = args->flags & I915_EXEC_HANDLE_LUT ? i : exec[i].handle;
203 204
			vma->exec_handle = handle;
			hlist_add_head(&vma->exec_node,
205 206
				       &eb->buckets[handle & eb->and]);
		}
207
		++i;
208 209
	}

210
	return 0;
211 212


213
err:
214 215 216 217 218
	while (!list_empty(&objects)) {
		obj = list_first_entry(&objects,
				       struct drm_i915_gem_object,
				       obj_exec_link);
		list_del_init(&obj->obj_exec_link);
219
		i915_gem_object_put(obj);
220
	}
221 222 223 224 225
	/*
	 * Objects already transfered to the vmas list will be unreferenced by
	 * eb_destroy.
	 */

226
	return ret;
227 228
}

229
static struct i915_vma *eb_get_vma(struct eb_vmas *eb, unsigned long handle)
230
{
231 232 233 234 235 236
	if (eb->and < 0) {
		if (handle >= -eb->and)
			return NULL;
		return eb->lut[handle];
	} else {
		struct hlist_head *head;
237
		struct i915_vma *vma;
238

239
		head = &eb->buckets[handle & eb->and];
240
		hlist_for_each_entry(vma, head, exec_node) {
241 242
			if (vma->exec_handle == handle)
				return vma;
243 244 245
		}
		return NULL;
	}
246 247
}

248 249 250 251 252 253 254 255 256 257 258
static void
i915_gem_execbuffer_unreserve_vma(struct i915_vma *vma)
{
	struct drm_i915_gem_exec_object2 *entry;

	if (!drm_mm_node_allocated(&vma->node))
		return;

	entry = vma->exec_entry;

	if (entry->flags & __EXEC_OBJECT_HAS_FENCE)
259
		i915_vma_unpin_fence(vma);
260 261

	if (entry->flags & __EXEC_OBJECT_HAS_PIN)
262
		__i915_vma_unpin(vma);
263

C
Chris Wilson 已提交
264
	entry->flags &= ~(__EXEC_OBJECT_HAS_FENCE | __EXEC_OBJECT_HAS_PIN);
265 266 267 268
}

static void eb_destroy(struct eb_vmas *eb)
{
269 270
	while (!list_empty(&eb->vmas)) {
		struct i915_vma *vma;
271

272 273
		vma = list_first_entry(&eb->vmas,
				       struct i915_vma,
274
				       exec_list);
275
		list_del_init(&vma->exec_list);
276
		i915_gem_execbuffer_unreserve_vma(vma);
277
		i915_vma_put(vma);
278
	}
279 280 281
	kfree(eb);
}

282 283
static inline int use_cpu_reloc(struct drm_i915_gem_object *obj)
{
284 285 286
	if (!i915_gem_object_has_struct_page(obj))
		return false;

287 288 289
	if (DBG_USE_CPU_RELOC)
		return DBG_USE_CPU_RELOC > 0;

290
	return (HAS_LLC(to_i915(obj->base.dev)) ||
291
		obj->base.write_domain == I915_GEM_DOMAIN_CPU ||
292 293 294
		obj->cache_level != I915_CACHE_NONE);
}

295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313
/* Used to convert any address to canonical form.
 * Starting from gen8, some commands (e.g. STATE_BASE_ADDRESS,
 * MI_LOAD_REGISTER_MEM and others, see Broadwell PRM Vol2a) require the
 * addresses to be in a canonical form:
 * "GraphicsAddress[63:48] are ignored by the HW and assumed to be in correct
 * canonical form [63:48] == [47]."
 */
#define GEN8_HIGH_ADDRESS_BIT 47
static inline uint64_t gen8_canonical_addr(uint64_t address)
{
	return sign_extend64(address, GEN8_HIGH_ADDRESS_BIT);
}

static inline uint64_t gen8_noncanonical_addr(uint64_t address)
{
	return address & ((1ULL << (GEN8_HIGH_ADDRESS_BIT + 1)) - 1);
}

static inline uint64_t
314
relocation_target(const struct drm_i915_gem_relocation_entry *reloc,
315 316 317 318 319
		  uint64_t target_offset)
{
	return gen8_canonical_addr((int)reloc->delta + target_offset);
}

320
struct reloc_cache {
321 322 323
	struct drm_i915_private *i915;
	struct drm_mm_node node;
	unsigned long vaddr;
324
	unsigned int page;
325
	bool use_64bit_reloc;
326 327
};

328 329
static void reloc_cache_init(struct reloc_cache *cache,
			     struct drm_i915_private *i915)
330
{
331
	cache->page = -1;
332 333
	cache->vaddr = 0;
	cache->i915 = i915;
334 335
	/* Must be a variable in the struct to allow GCC to unroll. */
	cache->use_64bit_reloc = HAS_64BIT_RELOC(i915);
336
	cache->node.allocated = false;
337
}
338

339 340 341 342 343 344 345 346
static inline void *unmask_page(unsigned long p)
{
	return (void *)(uintptr_t)(p & PAGE_MASK);
}

static inline unsigned int unmask_flags(unsigned long p)
{
	return p & ~PAGE_MASK;
347 348
}

349 350
#define KMAP 0x4 /* after CLFLUSH_FLAGS */

351 352
static void reloc_cache_fini(struct reloc_cache *cache)
{
353
	void *vaddr;
354

355 356
	if (!cache->vaddr)
		return;
357

358 359 360 361
	vaddr = unmask_page(cache->vaddr);
	if (cache->vaddr & KMAP) {
		if (cache->vaddr & CLFLUSH_AFTER)
			mb();
362

363 364 365
		kunmap_atomic(vaddr);
		i915_gem_obj_finish_shmem_access((struct drm_i915_gem_object *)cache->node.mm);
	} else {
366
		wmb();
367
		io_mapping_unmap_atomic((void __iomem *)vaddr);
368 369 370 371 372
		if (cache->node.allocated) {
			struct i915_ggtt *ggtt = &cache->i915->ggtt;

			ggtt->base.clear_range(&ggtt->base,
					       cache->node.start,
373
					       cache->node.size);
374 375 376
			drm_mm_remove_node(&cache->node);
		} else {
			i915_vma_unpin((struct i915_vma *)cache->node.mm);
377
		}
378 379 380 381 382 383 384
	}
}

static void *reloc_kmap(struct drm_i915_gem_object *obj,
			struct reloc_cache *cache,
			int page)
{
385 386 387 388 389 390 391
	void *vaddr;

	if (cache->vaddr) {
		kunmap_atomic(unmask_page(cache->vaddr));
	} else {
		unsigned int flushes;
		int ret;
392

393 394 395 396 397 398
		ret = i915_gem_obj_prepare_shmem_write(obj, &flushes);
		if (ret)
			return ERR_PTR(ret);

		BUILD_BUG_ON(KMAP & CLFLUSH_FLAGS);
		BUILD_BUG_ON((KMAP | CLFLUSH_FLAGS) & PAGE_MASK);
399

400 401 402 403
		cache->vaddr = flushes | KMAP;
		cache->node.mm = (void *)obj;
		if (flushes)
			mb();
404 405
	}

406 407
	vaddr = kmap_atomic(i915_gem_object_get_dirty_page(obj, page));
	cache->vaddr = unmask_flags(cache->vaddr) | (unsigned long)vaddr;
408
	cache->page = page;
409

410
	return vaddr;
411 412
}

413 414 415
static void *reloc_iomap(struct drm_i915_gem_object *obj,
			 struct reloc_cache *cache,
			 int page)
416
{
417 418
	struct i915_ggtt *ggtt = &cache->i915->ggtt;
	unsigned long offset;
419
	void *vaddr;
420

421
	if (cache->vaddr) {
422
		io_mapping_unmap_atomic((void __force __iomem *) unmask_page(cache->vaddr));
423 424 425
	} else {
		struct i915_vma *vma;
		int ret;
426

427 428
		if (use_cpu_reloc(obj))
			return NULL;
429

430 431 432
		ret = i915_gem_object_set_to_gtt_domain(obj, true);
		if (ret)
			return ERR_PTR(ret);
433

434 435
		vma = i915_gem_object_ggtt_pin(obj, NULL, 0, 0,
					       PIN_MAPPABLE | PIN_NONBLOCK);
436 437 438 439 440 441 442 443
		if (IS_ERR(vma)) {
			memset(&cache->node, 0, sizeof(cache->node));
			ret = drm_mm_insert_node_in_range_generic
				(&ggtt->base.mm, &cache->node,
				 4096, 0, 0,
				 0, ggtt->mappable_end,
				 DRM_MM_SEARCH_DEFAULT,
				 DRM_MM_CREATE_DEFAULT);
444 445
			if (ret) /* no inactive aperture space, use cpu reloc */
				return NULL;
446
		} else {
447
			ret = i915_vma_put_fence(vma);
448 449 450 451
			if (ret) {
				i915_vma_unpin(vma);
				return ERR_PTR(ret);
			}
452

453 454
			cache->node.start = vma->node.start;
			cache->node.mm = (void *)vma;
455
		}
456
	}
457

458 459
	offset = cache->node.start;
	if (cache->node.allocated) {
460
		wmb();
461 462 463 464 465
		ggtt->base.insert_page(&ggtt->base,
				       i915_gem_object_get_dma_address(obj, page),
				       offset, I915_CACHE_NONE, 0);
	} else {
		offset += page << PAGE_SHIFT;
466 467
	}

468
	vaddr = (void __force *) io_mapping_map_atomic_wc(&cache->i915->ggtt.mappable, offset);
469 470
	cache->page = page;
	cache->vaddr = (unsigned long)vaddr;
471

472
	return vaddr;
473 474
}

475 476 477
static void *reloc_vaddr(struct drm_i915_gem_object *obj,
			 struct reloc_cache *cache,
			 int page)
478
{
479
	void *vaddr;
480

481 482 483 484 485 486 487 488
	if (cache->page == page) {
		vaddr = unmask_page(cache->vaddr);
	} else {
		vaddr = NULL;
		if ((cache->vaddr & KMAP) == 0)
			vaddr = reloc_iomap(obj, cache, page);
		if (!vaddr)
			vaddr = reloc_kmap(obj, cache, page);
489 490
	}

491
	return vaddr;
492 493
}

494
static void clflush_write32(u32 *addr, u32 value, unsigned int flushes)
495
{
496 497 498 499 500
	if (unlikely(flushes & (CLFLUSH_BEFORE | CLFLUSH_AFTER))) {
		if (flushes & CLFLUSH_BEFORE) {
			clflushopt(addr);
			mb();
		}
501

502
		*addr = value;
503

504 505 506 507 508 509 510 511 512 513
		/* Writes to the same cacheline are serialised by the CPU
		 * (including clflush). On the write path, we only require
		 * that it hits memory in an orderly fashion and place
		 * mb barriers at the start and end of the relocation phase
		 * to ensure ordering of clflush wrt to the system.
		 */
		if (flushes & CLFLUSH_AFTER)
			clflushopt(addr);
	} else
		*addr = value;
514 515 516
}

static int
517 518 519 520
relocate_entry(struct drm_i915_gem_object *obj,
	       const struct drm_i915_gem_relocation_entry *reloc,
	       struct reloc_cache *cache,
	       u64 target_offset)
521
{
522 523 524
	u64 offset = reloc->offset;
	bool wide = cache->use_64bit_reloc;
	void *vaddr;
525

526 527 528 529 530 531 532 533 534 535 536 537 538 539 540
	target_offset = relocation_target(reloc, target_offset);
repeat:
	vaddr = reloc_vaddr(obj, cache, offset >> PAGE_SHIFT);
	if (IS_ERR(vaddr))
		return PTR_ERR(vaddr);

	clflush_write32(vaddr + offset_in_page(offset),
			lower_32_bits(target_offset),
			cache->vaddr);

	if (wide) {
		offset += sizeof(u32);
		target_offset >>= 32;
		wide = false;
		goto repeat;
541 542 543 544 545
	}

	return 0;
}

546 547
static int
i915_gem_execbuffer_relocate_entry(struct drm_i915_gem_object *obj,
548
				   struct eb_vmas *eb,
549 550
				   struct drm_i915_gem_relocation_entry *reloc,
				   struct reloc_cache *cache)
551
{
552
	struct drm_i915_private *dev_priv = to_i915(obj->base.dev);
553
	struct drm_gem_object *target_obj;
554
	struct drm_i915_gem_object *target_i915_obj;
555
	struct i915_vma *target_vma;
B
Ben Widawsky 已提交
556
	uint64_t target_offset;
557
	int ret;
558

559
	/* we've already hold a reference to all valid objects */
560 561
	target_vma = eb_get_vma(eb, reloc->target_handle);
	if (unlikely(target_vma == NULL))
562
		return -ENOENT;
563 564
	target_i915_obj = target_vma->obj;
	target_obj = &target_vma->obj->base;
565

566
	target_offset = gen8_canonical_addr(target_vma->node.start);
567

568 569 570
	/* Sandybridge PPGTT errata: We need a global gtt mapping for MI and
	 * pipe_control writes because the gpu doesn't properly redirect them
	 * through the ppgtt for non_secure batchbuffers. */
571
	if (unlikely(IS_GEN6(dev_priv) &&
572
	    reloc->write_domain == I915_GEM_DOMAIN_INSTRUCTION)) {
573
		ret = i915_vma_bind(target_vma, target_i915_obj->cache_level,
574
				    PIN_GLOBAL);
575 576 577
		if (WARN_ONCE(ret, "Unexpected failure to bind target VMA!"))
			return ret;
	}
578

579
	/* Validate that the target is in a valid r/w GPU domain */
580
	if (unlikely(reloc->write_domain & (reloc->write_domain - 1))) {
581
		DRM_DEBUG("reloc with multiple write domains: "
582 583 584 585 586 587
			  "obj %p target %d offset %d "
			  "read %08x write %08x",
			  obj, reloc->target_handle,
			  (int) reloc->offset,
			  reloc->read_domains,
			  reloc->write_domain);
588
		return -EINVAL;
589
	}
590 591
	if (unlikely((reloc->write_domain | reloc->read_domains)
		     & ~I915_GEM_GPU_DOMAINS)) {
592
		DRM_DEBUG("reloc with read/write non-GPU domains: "
593 594 595 596 597 598
			  "obj %p target %d offset %d "
			  "read %08x write %08x",
			  obj, reloc->target_handle,
			  (int) reloc->offset,
			  reloc->read_domains,
			  reloc->write_domain);
599
		return -EINVAL;
600 601 602 603 604 605 606 607 608
	}

	target_obj->pending_read_domains |= reloc->read_domains;
	target_obj->pending_write_domain |= reloc->write_domain;

	/* If the relocation already has the right value in it, no
	 * more work needs to be done.
	 */
	if (target_offset == reloc->presumed_offset)
609
		return 0;
610 611

	/* Check that the relocation address is valid... */
612
	if (unlikely(reloc->offset >
613
		     obj->base.size - (cache->use_64bit_reloc ? 8 : 4))) {
614
		DRM_DEBUG("Relocation beyond object bounds: "
615 616 617 618
			  "obj %p target %d offset %d size %d.\n",
			  obj, reloc->target_handle,
			  (int) reloc->offset,
			  (int) obj->base.size);
619
		return -EINVAL;
620
	}
621
	if (unlikely(reloc->offset & 3)) {
622
		DRM_DEBUG("Relocation not 4-byte aligned: "
623 624 625
			  "obj %p target %d offset %d.\n",
			  obj, reloc->target_handle,
			  (int) reloc->offset);
626
		return -EINVAL;
627 628
	}

629
	ret = relocate_entry(obj, reloc, cache, target_offset);
630 631 632
	if (ret)
		return ret;

633 634
	/* and update the user's relocation entry */
	reloc->presumed_offset = target_offset;
635
	return 0;
636 637 638
}

static int
639 640
i915_gem_execbuffer_relocate_vma(struct i915_vma *vma,
				 struct eb_vmas *eb)
641
{
642 643
#define N_RELOC(x) ((x) / sizeof(struct drm_i915_gem_relocation_entry))
	struct drm_i915_gem_relocation_entry stack_reloc[N_RELOC(512)];
644
	struct drm_i915_gem_relocation_entry __user *user_relocs;
645
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
646 647
	struct reloc_cache cache;
	int remain, ret = 0;
648

649
	user_relocs = u64_to_user_ptr(entry->relocs_ptr);
650
	reloc_cache_init(&cache, eb->i915);
651

652 653 654
	remain = entry->relocation_count;
	while (remain) {
		struct drm_i915_gem_relocation_entry *r = stack_reloc;
655 656 657 658
		unsigned long unwritten;
		unsigned int count;

		count = min_t(unsigned int, remain, ARRAY_SIZE(stack_reloc));
659 660
		remain -= count;

661 662 663 664 665 666 667 668 669 670 671
		/* This is the fast path and we cannot handle a pagefault
		 * whilst holding the struct mutex lest the user pass in the
		 * relocations contained within a mmaped bo. For in such a case
		 * we, the page fault handler would call i915_gem_fault() and
		 * we would try to acquire the struct mutex again. Obviously
		 * this is bad and so lockdep complains vehemently.
		 */
		pagefault_disable();
		unwritten = __copy_from_user_inatomic(r, user_relocs, count*sizeof(r[0]));
		pagefault_enable();
		if (unlikely(unwritten)) {
672 673 674
			ret = -EFAULT;
			goto out;
		}
675

676 677
		do {
			u64 offset = r->presumed_offset;
678

679
			ret = i915_gem_execbuffer_relocate_entry(vma->obj, eb, r, &cache);
680
			if (ret)
681
				goto out;
682

683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702
			if (r->presumed_offset != offset) {
				pagefault_disable();
				unwritten = __put_user(r->presumed_offset,
						       &user_relocs->presumed_offset);
				pagefault_enable();
				if (unlikely(unwritten)) {
					/* Note that reporting an error now
					 * leaves everything in an inconsistent
					 * state as we have *already* changed
					 * the relocation value inside the
					 * object. As we have not changed the
					 * reloc.presumed_offset or will not
					 * change the execobject.offset, on the
					 * call we may not rewrite the value
					 * inside the object, leaving it
					 * dangling and causing a GPU hang.
					 */
					ret = -EFAULT;
					goto out;
				}
703 704 705 706 707
			}

			user_relocs++;
			r++;
		} while (--count);
708 709
	}

710 711 712
out:
	reloc_cache_fini(&cache);
	return ret;
713
#undef N_RELOC
714 715 716
}

static int
717 718 719
i915_gem_execbuffer_relocate_vma_slow(struct i915_vma *vma,
				      struct eb_vmas *eb,
				      struct drm_i915_gem_relocation_entry *relocs)
720
{
721
	const struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
722 723
	struct reloc_cache cache;
	int i, ret = 0;
724

725
	reloc_cache_init(&cache, eb->i915);
726
	for (i = 0; i < entry->relocation_count; i++) {
727
		ret = i915_gem_execbuffer_relocate_entry(vma->obj, eb, &relocs[i], &cache);
728
		if (ret)
729
			break;
730
	}
731
	reloc_cache_fini(&cache);
732

733
	return ret;
734 735 736
}

static int
B
Ben Widawsky 已提交
737
i915_gem_execbuffer_relocate(struct eb_vmas *eb)
738
{
739
	struct i915_vma *vma;
740 741
	int ret = 0;

742 743
	list_for_each_entry(vma, &eb->vmas, exec_list) {
		ret = i915_gem_execbuffer_relocate_vma(vma, eb);
744
		if (ret)
745
			break;
746 747
	}

748
	return ret;
749 750
}

751 752 753 754 755 756
static bool only_mappable_for_reloc(unsigned int flags)
{
	return (flags & (EXEC_OBJECT_NEEDS_FENCE | __EXEC_OBJECT_NEEDS_MAP)) ==
		__EXEC_OBJECT_NEEDS_MAP;
}

757
static int
758
i915_gem_execbuffer_reserve_vma(struct i915_vma *vma,
759
				struct intel_engine_cs *engine,
760
				bool *need_reloc)
761
{
762
	struct drm_i915_gem_object *obj = vma->obj;
763
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
764
	uint64_t flags;
765 766
	int ret;

767
	flags = PIN_USER;
768 769 770
	if (entry->flags & EXEC_OBJECT_NEEDS_GTT)
		flags |= PIN_GLOBAL;

771
	if (!drm_mm_node_allocated(&vma->node)) {
772 773 774 775 776
		/* Wa32bitGeneralStateOffset & Wa32bitInstructionBaseOffset,
		 * limit address to the first 4GBs for unflagged objects.
		 */
		if ((entry->flags & EXEC_OBJECT_SUPPORTS_48B_ADDRESS) == 0)
			flags |= PIN_ZONE_4G;
777 778 779 780
		if (entry->flags & __EXEC_OBJECT_NEEDS_MAP)
			flags |= PIN_GLOBAL | PIN_MAPPABLE;
		if (entry->flags & __EXEC_OBJECT_NEEDS_BIAS)
			flags |= BATCH_OFFSET_BIAS | PIN_OFFSET_BIAS;
781 782
		if (entry->flags & EXEC_OBJECT_PINNED)
			flags |= entry->offset | PIN_OFFSET_FIXED;
783 784
		if ((flags & PIN_MAPPABLE) == 0)
			flags |= PIN_HIGH;
785
	}
786

787 788 789 790 791
	ret = i915_vma_pin(vma,
			   entry->pad_to_size,
			   entry->alignment,
			   flags);
	if ((ret == -ENOSPC || ret == -E2BIG) &&
792
	    only_mappable_for_reloc(entry->flags))
793 794 795 796
		ret = i915_vma_pin(vma,
				   entry->pad_to_size,
				   entry->alignment,
				   flags & ~PIN_MAPPABLE);
797 798 799
	if (ret)
		return ret;

800 801
	entry->flags |= __EXEC_OBJECT_HAS_PIN;

802
	if (entry->flags & EXEC_OBJECT_NEEDS_FENCE) {
803
		ret = i915_vma_get_fence(vma);
804 805
		if (ret)
			return ret;
806

807
		if (i915_vma_pin_fence(vma))
808
			entry->flags |= __EXEC_OBJECT_HAS_FENCE;
809 810
	}

811 812
	if (entry->offset != vma->node.start) {
		entry->offset = vma->node.start;
813 814 815 816 817 818 819 820
		*need_reloc = true;
	}

	if (entry->flags & EXEC_OBJECT_WRITE) {
		obj->base.pending_read_domains = I915_GEM_DOMAIN_RENDER;
		obj->base.pending_write_domain = I915_GEM_DOMAIN_RENDER;
	}

821
	return 0;
822
}
823

824
static bool
825
need_reloc_mappable(struct i915_vma *vma)
826 827 828
{
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;

829 830 831
	if (entry->relocation_count == 0)
		return false;

832
	if (!i915_vma_is_ggtt(vma))
833 834 835
		return false;

	/* See also use_cpu_reloc() */
836
	if (HAS_LLC(to_i915(vma->obj->base.dev)))
837 838 839 840 841 842 843 844 845 846 847 848
		return false;

	if (vma->obj->base.write_domain == I915_GEM_DOMAIN_CPU)
		return false;

	return true;
}

static bool
eb_vma_misplaced(struct i915_vma *vma)
{
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
849

850 851
	WARN_ON(entry->flags & __EXEC_OBJECT_NEEDS_MAP &&
		!i915_vma_is_ggtt(vma));
852 853 854 855 856

	if (entry->alignment &&
	    vma->node.start & (entry->alignment - 1))
		return true;

857 858 859
	if (vma->node.size < entry->pad_to_size)
		return true;

860 861 862 863
	if (entry->flags & EXEC_OBJECT_PINNED &&
	    vma->node.start != entry->offset)
		return true;

864 865 866 867
	if (entry->flags & __EXEC_OBJECT_NEEDS_BIAS &&
	    vma->node.start < BATCH_OFFSET_BIAS)
		return true;

868
	/* avoid costly ping-pong once a batch bo ended up non-mappable */
869 870
	if (entry->flags & __EXEC_OBJECT_NEEDS_MAP &&
	    !i915_vma_is_map_and_fenceable(vma))
871 872
		return !only_mappable_for_reloc(entry->flags);

873 874 875 876
	if ((entry->flags & EXEC_OBJECT_SUPPORTS_48B_ADDRESS) == 0 &&
	    (vma->node.start + vma->node.size - 1) >> 32)
		return true;

877 878 879
	return false;
}

880
static int
881
i915_gem_execbuffer_reserve(struct intel_engine_cs *engine,
882
			    struct list_head *vmas,
883
			    struct i915_gem_context *ctx,
884
			    bool *need_relocs)
885
{
886
	struct drm_i915_gem_object *obj;
887
	struct i915_vma *vma;
888
	struct i915_address_space *vm;
889
	struct list_head ordered_vmas;
890
	struct list_head pinned_vmas;
891
	bool has_fenced_gpu_access = INTEL_GEN(engine->i915) < 4;
892
	int retry;
893

894 895
	vm = list_first_entry(vmas, struct i915_vma, exec_list)->vm;

896
	INIT_LIST_HEAD(&ordered_vmas);
897
	INIT_LIST_HEAD(&pinned_vmas);
898
	while (!list_empty(vmas)) {
899 900 901
		struct drm_i915_gem_exec_object2 *entry;
		bool need_fence, need_mappable;

902 903 904
		vma = list_first_entry(vmas, struct i915_vma, exec_list);
		obj = vma->obj;
		entry = vma->exec_entry;
905

906 907 908
		if (ctx->flags & CONTEXT_NO_ZEROMAP)
			entry->flags |= __EXEC_OBJECT_NEEDS_BIAS;

909 910
		if (!has_fenced_gpu_access)
			entry->flags &= ~EXEC_OBJECT_NEEDS_FENCE;
911 912
		need_fence =
			entry->flags & EXEC_OBJECT_NEEDS_FENCE &&
913
			i915_gem_object_is_tiled(obj);
914
		need_mappable = need_fence || need_reloc_mappable(vma);
915

916 917 918
		if (entry->flags & EXEC_OBJECT_PINNED)
			list_move_tail(&vma->exec_list, &pinned_vmas);
		else if (need_mappable) {
919
			entry->flags |= __EXEC_OBJECT_NEEDS_MAP;
920
			list_move(&vma->exec_list, &ordered_vmas);
921
		} else
922
			list_move_tail(&vma->exec_list, &ordered_vmas);
923

924
		obj->base.pending_read_domains = I915_GEM_GPU_DOMAINS & ~I915_GEM_DOMAIN_COMMAND;
925
		obj->base.pending_write_domain = 0;
926
	}
927
	list_splice(&ordered_vmas, vmas);
928
	list_splice(&pinned_vmas, vmas);
929 930 931 932 933 934 935 936 937 938

	/* Attempt to pin all of the buffers into the GTT.
	 * This is done in 3 phases:
	 *
	 * 1a. Unbind all objects that do not match the GTT constraints for
	 *     the execbuffer (fenceable, mappable, alignment etc).
	 * 1b. Increment pin count for already bound objects.
	 * 2.  Bind new objects.
	 * 3.  Decrement pin count.
	 *
939
	 * This avoid unnecessary unbinding of later objects in order to make
940 941 942 943
	 * room for the earlier objects *unless* we need to defragment.
	 */
	retry = 0;
	do {
944
		int ret = 0;
945 946

		/* Unbind any ill-fitting objects or pin. */
947 948
		list_for_each_entry(vma, vmas, exec_list) {
			if (!drm_mm_node_allocated(&vma->node))
949 950
				continue;

951
			if (eb_vma_misplaced(vma))
952
				ret = i915_vma_unbind(vma);
953
			else
954 955 956
				ret = i915_gem_execbuffer_reserve_vma(vma,
								      engine,
								      need_relocs);
957
			if (ret)
958 959 960 961
				goto err;
		}

		/* Bind fresh objects */
962 963
		list_for_each_entry(vma, vmas, exec_list) {
			if (drm_mm_node_allocated(&vma->node))
964
				continue;
965

966 967
			ret = i915_gem_execbuffer_reserve_vma(vma, engine,
							      need_relocs);
968 969
			if (ret)
				goto err;
970 971
		}

972
err:
C
Chris Wilson 已提交
973
		if (ret != -ENOSPC || retry++)
974 975
			return ret;

976 977 978 979
		/* Decrement pin count for bound objects */
		list_for_each_entry(vma, vmas, exec_list)
			i915_gem_execbuffer_unreserve_vma(vma);

980
		ret = i915_gem_evict_vm(vm, true);
981 982 983 984 985 986 987
		if (ret)
			return ret;
	} while (1);
}

static int
i915_gem_execbuffer_relocate_slow(struct drm_device *dev,
988
				  struct drm_i915_gem_execbuffer2 *args,
989
				  struct drm_file *file,
990
				  struct intel_engine_cs *engine,
991
				  struct eb_vmas *eb,
992
				  struct drm_i915_gem_exec_object2 *exec,
993
				  struct i915_gem_context *ctx)
994 995
{
	struct drm_i915_gem_relocation_entry *reloc;
996 997
	struct i915_address_space *vm;
	struct i915_vma *vma;
998
	bool need_relocs;
999
	int *reloc_offset;
1000
	int i, total, ret;
1001
	unsigned count = args->buffer_count;
1002

1003 1004
	vm = list_first_entry(&eb->vmas, struct i915_vma, exec_list)->vm;

1005
	/* We may process another execbuffer during the unlock... */
1006 1007 1008
	while (!list_empty(&eb->vmas)) {
		vma = list_first_entry(&eb->vmas, struct i915_vma, exec_list);
		list_del_init(&vma->exec_list);
1009
		i915_gem_execbuffer_unreserve_vma(vma);
1010
		i915_vma_put(vma);
1011 1012
	}

1013 1014 1015 1016
	mutex_unlock(&dev->struct_mutex);

	total = 0;
	for (i = 0; i < count; i++)
1017
		total += exec[i].relocation_count;
1018

1019
	reloc_offset = drm_malloc_ab(count, sizeof(*reloc_offset));
1020
	reloc = drm_malloc_ab(total, sizeof(*reloc));
1021 1022 1023
	if (reloc == NULL || reloc_offset == NULL) {
		drm_free_large(reloc);
		drm_free_large(reloc_offset);
1024 1025 1026 1027 1028 1029 1030
		mutex_lock(&dev->struct_mutex);
		return -ENOMEM;
	}

	total = 0;
	for (i = 0; i < count; i++) {
		struct drm_i915_gem_relocation_entry __user *user_relocs;
1031 1032
		u64 invalid_offset = (u64)-1;
		int j;
1033

1034
		user_relocs = u64_to_user_ptr(exec[i].relocs_ptr);
1035 1036

		if (copy_from_user(reloc+total, user_relocs,
1037
				   exec[i].relocation_count * sizeof(*reloc))) {
1038 1039 1040 1041 1042
			ret = -EFAULT;
			mutex_lock(&dev->struct_mutex);
			goto err;
		}

1043 1044 1045 1046 1047 1048 1049 1050 1051 1052
		/* As we do not update the known relocation offsets after
		 * relocating (due to the complexities in lock handling),
		 * we need to mark them as invalid now so that we force the
		 * relocation processing next time. Just in case the target
		 * object is evicted and then rebound into its old
		 * presumed_offset before the next execbuffer - if that
		 * happened we would make the mistake of assuming that the
		 * relocations were valid.
		 */
		for (j = 0; j < exec[i].relocation_count; j++) {
1053 1054 1055
			if (__copy_to_user(&user_relocs[j].presumed_offset,
					   &invalid_offset,
					   sizeof(invalid_offset))) {
1056 1057 1058 1059 1060 1061
				ret = -EFAULT;
				mutex_lock(&dev->struct_mutex);
				goto err;
			}
		}

1062
		reloc_offset[i] = total;
1063
		total += exec[i].relocation_count;
1064 1065 1066 1067 1068 1069 1070 1071
	}

	ret = i915_mutex_lock_interruptible(dev);
	if (ret) {
		mutex_lock(&dev->struct_mutex);
		goto err;
	}

1072 1073
	/* reacquire the objects */
	eb_reset(eb);
1074
	ret = eb_lookup_vmas(eb, exec, args, vm, file);
1075 1076
	if (ret)
		goto err;
1077

1078
	need_relocs = (args->flags & I915_EXEC_NO_RELOC) == 0;
1079 1080
	ret = i915_gem_execbuffer_reserve(engine, &eb->vmas, ctx,
					  &need_relocs);
1081 1082 1083
	if (ret)
		goto err;

1084 1085 1086 1087
	list_for_each_entry(vma, &eb->vmas, exec_list) {
		int offset = vma->exec_entry - exec;
		ret = i915_gem_execbuffer_relocate_vma_slow(vma, eb,
							    reloc + reloc_offset[offset]);
1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099
		if (ret)
			goto err;
	}

	/* Leave the user relocations as are, this is the painfully slow path,
	 * and we want to avoid the complication of dropping the lock whilst
	 * having buffers reserved in the aperture and so causing spurious
	 * ENOSPC for random operations.
	 */

err:
	drm_free_large(reloc);
1100
	drm_free_large(reloc_offset);
1101 1102 1103 1104
	return ret;
}

static int
1105
i915_gem_execbuffer_move_to_gpu(struct drm_i915_gem_request *req,
1106
				struct list_head *vmas)
1107
{
1108
	struct i915_vma *vma;
1109
	int ret;
1110

1111 1112
	list_for_each_entry(vma, vmas, exec_list) {
		struct drm_i915_gem_object *obj = vma->obj;
1113

1114 1115 1116 1117
		ret = i915_gem_request_await_object
			(req, obj, obj->base.pending_write_domain);
		if (ret)
			return ret;
1118

1119
		if (obj->base.write_domain & I915_GEM_DOMAIN_CPU)
1120
			i915_gem_clflush_object(obj, false);
1121 1122
	}

1123 1124
	/* Unconditionally flush any chipset caches (for streaming writes). */
	i915_gem_chipset_flush(req->engine->i915);
1125

1126
	/* Unconditionally invalidate GPU caches and TLBs. */
1127
	return req->engine->emit_flush(req, EMIT_INVALIDATE);
1128 1129
}

1130 1131
static bool
i915_gem_check_execbuffer(struct drm_i915_gem_execbuffer2 *exec)
1132
{
1133 1134 1135
	if (exec->flags & __I915_EXEC_UNKNOWN_FLAGS)
		return false;

C
Chris Wilson 已提交
1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150
	/* Kernel clipping was a DRI1 misfeature */
	if (exec->num_cliprects || exec->cliprects_ptr)
		return false;

	if (exec->DR4 == 0xffffffff) {
		DRM_DEBUG("UXA submitting garbage DR4, fixing up\n");
		exec->DR4 = 0;
	}
	if (exec->DR1 || exec->DR4)
		return false;

	if ((exec->batch_start_offset | exec->batch_len) & 0x7)
		return false;

	return true;
1151 1152 1153
}

static int
1154 1155
validate_exec_list(struct drm_device *dev,
		   struct drm_i915_gem_exec_object2 *exec,
1156 1157
		   int count)
{
1158 1159
	unsigned relocs_total = 0;
	unsigned relocs_max = UINT_MAX / sizeof(struct drm_i915_gem_relocation_entry);
1160 1161 1162
	unsigned invalid_flags;
	int i;

1163 1164 1165
	/* INTERNAL flags must not overlap with external ones */
	BUILD_BUG_ON(__EXEC_OBJECT_INTERNAL_FLAGS & ~__EXEC_OBJECT_UNKNOWN_FLAGS);

1166 1167 1168
	invalid_flags = __EXEC_OBJECT_UNKNOWN_FLAGS;
	if (USES_FULL_PPGTT(dev))
		invalid_flags |= EXEC_OBJECT_NEEDS_GTT;
1169 1170

	for (i = 0; i < count; i++) {
1171
		char __user *ptr = u64_to_user_ptr(exec[i].relocs_ptr);
1172 1173
		int length; /* limited by fault_in_pages_readable() */

1174
		if (exec[i].flags & invalid_flags)
1175 1176
			return -EINVAL;

1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191
		/* Offset can be used as input (EXEC_OBJECT_PINNED), reject
		 * any non-page-aligned or non-canonical addresses.
		 */
		if (exec[i].flags & EXEC_OBJECT_PINNED) {
			if (exec[i].offset !=
			    gen8_canonical_addr(exec[i].offset & PAGE_MASK))
				return -EINVAL;

			/* From drm_mm perspective address space is continuous,
			 * so from this point we're always using non-canonical
			 * form internally.
			 */
			exec[i].offset = gen8_noncanonical_addr(exec[i].offset);
		}

1192 1193 1194
		if (exec[i].alignment && !is_power_of_2(exec[i].alignment))
			return -EINVAL;

1195 1196 1197 1198 1199 1200 1201 1202
		/* pad_to_size was once a reserved field, so sanitize it */
		if (exec[i].flags & EXEC_OBJECT_PAD_TO_SIZE) {
			if (offset_in_page(exec[i].pad_to_size))
				return -EINVAL;
		} else {
			exec[i].pad_to_size = 0;
		}

1203 1204 1205 1206 1207
		/* First check for malicious input causing overflow in
		 * the worst case where we need to allocate the entire
		 * relocation tree as a single array.
		 */
		if (exec[i].relocation_count > relocs_max - relocs_total)
1208
			return -EINVAL;
1209
		relocs_total += exec[i].relocation_count;
1210 1211 1212

		length = exec[i].relocation_count *
			sizeof(struct drm_i915_gem_relocation_entry);
1213 1214 1215 1216 1217
		/*
		 * We must check that the entire relocation array is safe
		 * to read, but since we may need to update the presumed
		 * offsets during execution, check for full write access.
		 */
1218 1219 1220
		if (!access_ok(VERIFY_WRITE, ptr, length))
			return -EFAULT;

1221
		if (likely(!i915.prefault_disable)) {
1222
			if (fault_in_pages_readable(ptr, length))
1223 1224
				return -EFAULT;
		}
1225 1226 1227 1228 1229
	}

	return 0;
}

1230
static struct i915_gem_context *
1231
i915_gem_validate_context(struct drm_device *dev, struct drm_file *file,
1232
			  struct intel_engine_cs *engine, const u32 ctx_id)
1233
{
1234
	struct i915_gem_context *ctx;
1235 1236
	struct i915_ctx_hang_stats *hs;

1237
	ctx = i915_gem_context_lookup(file->driver_priv, ctx_id);
1238
	if (IS_ERR(ctx))
1239
		return ctx;
1240

1241
	hs = &ctx->hang_stats;
1242 1243
	if (hs->banned) {
		DRM_DEBUG("Context %u tried to submit while banned\n", ctx_id);
1244
		return ERR_PTR(-EIO);
1245 1246
	}

1247
	return ctx;
1248 1249
}

1250 1251 1252 1253 1254 1255
static bool gpu_write_needs_clflush(struct drm_i915_gem_object *obj)
{
	return !(obj->cache_level == I915_CACHE_NONE ||
		 obj->cache_level == I915_CACHE_WT);
}

1256 1257 1258 1259 1260 1261 1262 1263 1264
void i915_vma_move_to_active(struct i915_vma *vma,
			     struct drm_i915_gem_request *req,
			     unsigned int flags)
{
	struct drm_i915_gem_object *obj = vma->obj;
	const unsigned int idx = req->engine->id;

	GEM_BUG_ON(!drm_mm_node_allocated(&vma->node));

1265 1266 1267 1268 1269 1270 1271
	/* Add a reference if we're newly entering the active list.
	 * The order in which we add operations to the retirement queue is
	 * vital here: mark_active adds to the start of the callback list,
	 * such that subsequent callbacks are called first. Therefore we
	 * add the active reference first and queue for it to be dropped
	 * *last*.
	 */
1272 1273 1274 1275 1276
	if (!i915_vma_is_active(vma))
		obj->active_count++;
	i915_vma_set_active(vma, idx);
	i915_gem_active_set(&vma->last_read[idx], req);
	list_move_tail(&vma->vm_link, &vma->vm->active_list);
1277 1278

	if (flags & EXEC_OBJECT_WRITE) {
1279
		i915_gem_active_set(&vma->last_write, req);
1280 1281 1282 1283 1284

		intel_fb_obj_invalidate(obj, ORIGIN_CS);

		/* update for the implicit flush after a batch */
		obj->base.write_domain &= ~I915_GEM_GPU_DOMAINS;
1285 1286
		if (!obj->cache_dirty && gpu_write_needs_clflush(obj))
			obj->cache_dirty = true;
1287 1288
	}

1289 1290
	if (flags & EXEC_OBJECT_NEEDS_FENCE)
		i915_gem_active_set(&vma->last_fence, req);
1291 1292
}

1293 1294 1295 1296
static void eb_export_fence(struct drm_i915_gem_object *obj,
			    struct drm_i915_gem_request *req,
			    unsigned int flags)
{
1297
	struct reservation_object *resv = obj->resv;
1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310

	/* Ignore errors from failing to allocate the new fence, we can't
	 * handle an error right now. Worst case should be missed
	 * synchronisation leading to rendering corruption.
	 */
	ww_mutex_lock(&resv->lock, NULL);
	if (flags & EXEC_OBJECT_WRITE)
		reservation_object_add_excl_fence(resv, &req->fence);
	else if (reservation_object_reserve_shared(resv) == 0)
		reservation_object_add_shared_fence(resv, &req->fence);
	ww_mutex_unlock(&resv->lock);
}

1311
static void
1312
i915_gem_execbuffer_move_to_active(struct list_head *vmas,
1313
				   struct drm_i915_gem_request *req)
1314
{
1315
	struct i915_vma *vma;
1316

1317 1318
	list_for_each_entry(vma, vmas, exec_list) {
		struct drm_i915_gem_object *obj = vma->obj;
1319 1320
		u32 old_read = obj->base.read_domains;
		u32 old_write = obj->base.write_domain;
C
Chris Wilson 已提交
1321

1322
		obj->base.write_domain = obj->base.pending_write_domain;
1323 1324 1325
		if (obj->base.write_domain)
			vma->exec_entry->flags |= EXEC_OBJECT_WRITE;
		else
1326 1327
			obj->base.pending_read_domains |= obj->base.read_domains;
		obj->base.read_domains = obj->base.pending_read_domains;
1328

1329
		i915_vma_move_to_active(vma, req, vma->exec_entry->flags);
1330
		eb_export_fence(obj, req, vma->exec_entry->flags);
C
Chris Wilson 已提交
1331
		trace_i915_gem_object_change_domain(obj, old_read, old_write);
1332 1333 1334
	}
}

1335
static int
1336
i915_reset_gen7_sol_offsets(struct drm_i915_gem_request *req)
1337
{
1338
	struct intel_ring *ring = req->ring;
1339 1340
	int ret, i;

1341
	if (!IS_GEN7(req->i915) || req->engine->id != RCS) {
1342 1343 1344
		DRM_DEBUG("sol reset is gen7/rcs only\n");
		return -EINVAL;
	}
1345

1346
	ret = intel_ring_begin(req, 4 * 3);
1347 1348 1349 1350
	if (ret)
		return ret;

	for (i = 0; i < 4; i++) {
1351 1352 1353
		intel_ring_emit(ring, MI_LOAD_REGISTER_IMM(1));
		intel_ring_emit_reg(ring, GEN7_SO_WRITE_OFFSET(i));
		intel_ring_emit(ring, 0);
1354 1355
	}

1356
	intel_ring_advance(ring);
1357 1358 1359 1360

	return 0;
}

C
Chris Wilson 已提交
1361
static struct i915_vma *
1362
i915_gem_execbuffer_parse(struct intel_engine_cs *engine,
1363 1364
			  struct drm_i915_gem_exec_object2 *shadow_exec_entry,
			  struct drm_i915_gem_object *batch_obj,
1365
			  struct eb_vmas *eb,
1366 1367
			  u32 batch_start_offset,
			  u32 batch_len,
1368
			  bool is_master)
1369 1370
{
	struct drm_i915_gem_object *shadow_batch_obj;
1371
	struct i915_vma *vma;
1372 1373
	int ret;

1374
	shadow_batch_obj = i915_gem_batch_pool_get(&engine->batch_pool,
1375
						   PAGE_ALIGN(batch_len));
1376
	if (IS_ERR(shadow_batch_obj))
1377
		return ERR_CAST(shadow_batch_obj);
1378

1379 1380 1381 1382 1383 1384
	ret = intel_engine_cmd_parser(engine,
				      batch_obj,
				      shadow_batch_obj,
				      batch_start_offset,
				      batch_len,
				      is_master);
C
Chris Wilson 已提交
1385 1386 1387 1388 1389 1390 1391
	if (ret) {
		if (ret == -EACCES) /* unhandled chained batch */
			vma = NULL;
		else
			vma = ERR_PTR(ret);
		goto out;
	}
1392

C
Chris Wilson 已提交
1393 1394 1395
	vma = i915_gem_object_ggtt_pin(shadow_batch_obj, NULL, 0, 0, 0);
	if (IS_ERR(vma))
		goto out;
C
Chris Wilson 已提交
1396

1397
	memset(shadow_exec_entry, 0, sizeof(*shadow_exec_entry));
1398

1399
	vma->exec_entry = shadow_exec_entry;
C
Chris Wilson 已提交
1400
	vma->exec_entry->flags = __EXEC_OBJECT_HAS_PIN;
1401
	i915_gem_object_get(shadow_batch_obj);
1402
	list_add_tail(&vma->exec_list, &eb->vmas);
1403

C
Chris Wilson 已提交
1404
out:
C
Chris Wilson 已提交
1405
	i915_gem_object_unpin_pages(shadow_batch_obj);
C
Chris Wilson 已提交
1406
	return vma;
1407
}
1408

1409 1410 1411 1412
static int
execbuf_submit(struct i915_execbuffer_params *params,
	       struct drm_i915_gem_execbuffer2 *args,
	       struct list_head *vmas)
1413
{
1414
	struct drm_i915_private *dev_priv = params->request->i915;
1415
	u64 exec_start, exec_len;
1416 1417
	int instp_mode;
	u32 instp_mask;
C
Chris Wilson 已提交
1418
	int ret;
1419

1420
	ret = i915_gem_execbuffer_move_to_gpu(params->request, vmas);
1421
	if (ret)
C
Chris Wilson 已提交
1422
		return ret;
1423

1424
	ret = i915_switch_context(params->request);
1425
	if (ret)
C
Chris Wilson 已提交
1426
		return ret;
1427 1428 1429 1430 1431 1432 1433

	instp_mode = args->flags & I915_EXEC_CONSTANTS_MASK;
	instp_mask = I915_EXEC_CONSTANTS_MASK;
	switch (instp_mode) {
	case I915_EXEC_CONSTANTS_REL_GENERAL:
	case I915_EXEC_CONSTANTS_ABSOLUTE:
	case I915_EXEC_CONSTANTS_REL_SURFACE:
1434
		if (instp_mode != 0 && params->engine->id != RCS) {
1435
			DRM_DEBUG("non-0 rel constants mode on non-RCS\n");
C
Chris Wilson 已提交
1436
			return -EINVAL;
1437 1438 1439
		}

		if (instp_mode != dev_priv->relative_constants_mode) {
1440
			if (INTEL_INFO(dev_priv)->gen < 4) {
1441
				DRM_DEBUG("no rel constants on pre-gen4\n");
C
Chris Wilson 已提交
1442
				return -EINVAL;
1443 1444
			}

1445
			if (INTEL_INFO(dev_priv)->gen > 5 &&
1446 1447
			    instp_mode == I915_EXEC_CONSTANTS_REL_SURFACE) {
				DRM_DEBUG("rel surface constants mode invalid on gen5+\n");
C
Chris Wilson 已提交
1448
				return -EINVAL;
1449 1450 1451
			}

			/* The HW changed the meaning on this bit on gen6 */
1452
			if (INTEL_INFO(dev_priv)->gen >= 6)
1453 1454 1455 1456 1457
				instp_mask &= ~I915_EXEC_CONSTANTS_REL_SURFACE;
		}
		break;
	default:
		DRM_DEBUG("execbuf with unknown constants: %d\n", instp_mode);
C
Chris Wilson 已提交
1458
		return -EINVAL;
1459 1460
	}

1461
	if (params->engine->id == RCS &&
C
Chris Wilson 已提交
1462
	    instp_mode != dev_priv->relative_constants_mode) {
1463
		struct intel_ring *ring = params->request->ring;
1464

1465
		ret = intel_ring_begin(params->request, 4);
1466
		if (ret)
C
Chris Wilson 已提交
1467
			return ret;
1468

1469 1470 1471 1472 1473
		intel_ring_emit(ring, MI_NOOP);
		intel_ring_emit(ring, MI_LOAD_REGISTER_IMM(1));
		intel_ring_emit_reg(ring, INSTPM);
		intel_ring_emit(ring, instp_mask << 16 | instp_mode);
		intel_ring_advance(ring);
1474 1475 1476 1477 1478

		dev_priv->relative_constants_mode = instp_mode;
	}

	if (args->flags & I915_EXEC_GEN7_SOL_RESET) {
1479
		ret = i915_reset_gen7_sol_offsets(params->request);
1480
		if (ret)
C
Chris Wilson 已提交
1481
			return ret;
1482 1483
	}

1484
	exec_len   = args->batch_len;
1485
	exec_start = params->batch->node.start +
1486 1487
		     params->args_batch_start_offset;

1488
	if (exec_len == 0)
1489
		exec_len = params->batch->size - params->args_batch_start_offset;
1490

1491 1492 1493
	ret = params->engine->emit_bb_start(params->request,
					    exec_start, exec_len,
					    params->dispatch_flags);
C
Chris Wilson 已提交
1494 1495
	if (ret)
		return ret;
1496

1497
	trace_i915_gem_ring_dispatch(params->request, params->dispatch_flags);
1498

1499
	i915_gem_execbuffer_move_to_active(vmas, params->request);
1500

C
Chris Wilson 已提交
1501
	return 0;
1502 1503
}

1504 1505
/**
 * Find one BSD ring to dispatch the corresponding BSD command.
1506
 * The engine index is returned.
1507
 */
1508
static unsigned int
1509 1510
gen8_dispatch_bsd_engine(struct drm_i915_private *dev_priv,
			 struct drm_file *file)
1511 1512 1513
{
	struct drm_i915_file_private *file_priv = file->driver_priv;

1514
	/* Check whether the file_priv has already selected one ring. */
1515 1516 1517
	if ((int)file_priv->bsd_engine < 0)
		file_priv->bsd_engine = atomic_fetch_xor(1,
			 &dev_priv->mm.bsd_engine_dispatch_index);
1518

1519
	return file_priv->bsd_engine;
1520 1521
}

1522 1523
#define I915_USER_RINGS (4)

1524
static const enum intel_engine_id user_ring_map[I915_USER_RINGS + 1] = {
1525 1526 1527 1528 1529 1530 1531
	[I915_EXEC_DEFAULT]	= RCS,
	[I915_EXEC_RENDER]	= RCS,
	[I915_EXEC_BLT]		= BCS,
	[I915_EXEC_BSD]		= VCS,
	[I915_EXEC_VEBOX]	= VECS
};

1532 1533 1534 1535
static struct intel_engine_cs *
eb_select_engine(struct drm_i915_private *dev_priv,
		 struct drm_file *file,
		 struct drm_i915_gem_execbuffer2 *args)
1536 1537
{
	unsigned int user_ring_id = args->flags & I915_EXEC_RING_MASK;
1538
	struct intel_engine_cs *engine;
1539 1540 1541

	if (user_ring_id > I915_USER_RINGS) {
		DRM_DEBUG("execbuf with unknown ring: %u\n", user_ring_id);
1542
		return NULL;
1543 1544 1545 1546 1547 1548
	}

	if ((user_ring_id != I915_EXEC_BSD) &&
	    ((args->flags & I915_EXEC_BSD_MASK) != 0)) {
		DRM_DEBUG("execbuf with non bsd ring but with invalid "
			  "bsd dispatch flags: %d\n", (int)(args->flags));
1549
		return NULL;
1550 1551 1552 1553 1554 1555
	}

	if (user_ring_id == I915_EXEC_BSD && HAS_BSD2(dev_priv)) {
		unsigned int bsd_idx = args->flags & I915_EXEC_BSD_MASK;

		if (bsd_idx == I915_EXEC_BSD_DEFAULT) {
1556
			bsd_idx = gen8_dispatch_bsd_engine(dev_priv, file);
1557 1558
		} else if (bsd_idx >= I915_EXEC_BSD_RING1 &&
			   bsd_idx <= I915_EXEC_BSD_RING2) {
1559
			bsd_idx >>= I915_EXEC_BSD_SHIFT;
1560 1561 1562 1563
			bsd_idx--;
		} else {
			DRM_DEBUG("execbuf with unknown bsd ring: %u\n",
				  bsd_idx);
1564
			return NULL;
1565 1566
		}

1567
		engine = dev_priv->engine[_VCS(bsd_idx)];
1568
	} else {
1569
		engine = dev_priv->engine[user_ring_map[user_ring_id]];
1570 1571
	}

1572
	if (!engine) {
1573
		DRM_DEBUG("execbuf with invalid ring: %u\n", user_ring_id);
1574
		return NULL;
1575 1576
	}

1577
	return engine;
1578 1579
}

1580 1581 1582 1583
static int
i915_gem_do_execbuffer(struct drm_device *dev, void *data,
		       struct drm_file *file,
		       struct drm_i915_gem_execbuffer2 *args,
1584
		       struct drm_i915_gem_exec_object2 *exec)
1585
{
1586 1587
	struct drm_i915_private *dev_priv = to_i915(dev);
	struct i915_ggtt *ggtt = &dev_priv->ggtt;
1588
	struct eb_vmas *eb;
1589
	struct drm_i915_gem_exec_object2 shadow_exec_entry;
1590
	struct intel_engine_cs *engine;
1591
	struct i915_gem_context *ctx;
1592
	struct i915_address_space *vm;
1593 1594
	struct i915_execbuffer_params params_master; /* XXX: will be removed later */
	struct i915_execbuffer_params *params = &params_master;
1595
	const u32 ctx_id = i915_execbuffer2_get_context_id(*args);
1596
	u32 dispatch_flags;
1597
	int ret;
1598
	bool need_relocs;
1599

1600
	if (!i915_gem_check_execbuffer(args))
1601 1602
		return -EINVAL;

1603
	ret = validate_exec_list(dev, exec, args->buffer_count);
1604 1605 1606
	if (ret)
		return ret;

1607
	dispatch_flags = 0;
1608
	if (args->flags & I915_EXEC_SECURE) {
1609
		if (!drm_is_current_master(file) || !capable(CAP_SYS_ADMIN))
1610 1611
		    return -EPERM;

1612
		dispatch_flags |= I915_DISPATCH_SECURE;
1613
	}
1614
	if (args->flags & I915_EXEC_IS_PINNED)
1615
		dispatch_flags |= I915_DISPATCH_PINNED;
1616

1617 1618 1619
	engine = eb_select_engine(dev_priv, file, args);
	if (!engine)
		return -EINVAL;
1620 1621

	if (args->buffer_count < 1) {
1622
		DRM_DEBUG("execbuf with %d buffers\n", args->buffer_count);
1623 1624 1625
		return -EINVAL;
	}

1626
	if (args->flags & I915_EXEC_RESOURCE_STREAMER) {
1627
		if (!HAS_RESOURCE_STREAMER(dev_priv)) {
1628 1629 1630
			DRM_DEBUG("RS is only allowed for Haswell, Gen8 and above\n");
			return -EINVAL;
		}
1631
		if (engine->id != RCS) {
1632
			DRM_DEBUG("RS is not available on %s\n",
1633
				 engine->name);
1634 1635 1636 1637 1638 1639
			return -EINVAL;
		}

		dispatch_flags |= I915_DISPATCH_RS;
	}

1640 1641 1642 1643 1644 1645
	/* Take a local wakeref for preparing to dispatch the execbuf as
	 * we expect to access the hardware fairly frequently in the
	 * process. Upon first dispatch, we acquire another prolonged
	 * wakeref that we hold until the GPU has been idle for at least
	 * 100ms.
	 */
1646 1647
	intel_runtime_pm_get(dev_priv);

1648 1649 1650 1651
	ret = i915_mutex_lock_interruptible(dev);
	if (ret)
		goto pre_mutex_err;

1652
	ctx = i915_gem_validate_context(dev, file, engine, ctx_id);
1653
	if (IS_ERR(ctx)) {
1654
		mutex_unlock(&dev->struct_mutex);
1655
		ret = PTR_ERR(ctx);
1656
		goto pre_mutex_err;
1657
	}
1658

1659
	i915_gem_context_get(ctx);
1660

1661 1662 1663
	if (ctx->ppgtt)
		vm = &ctx->ppgtt->base;
	else
1664
		vm = &ggtt->base;
1665

1666 1667
	memset(&params_master, 0x00, sizeof(params_master));

1668
	eb = eb_create(dev_priv, args);
1669
	if (eb == NULL) {
1670
		i915_gem_context_put(ctx);
1671 1672 1673 1674 1675
		mutex_unlock(&dev->struct_mutex);
		ret = -ENOMEM;
		goto pre_mutex_err;
	}

1676
	/* Look up object handles */
1677
	ret = eb_lookup_vmas(eb, exec, args, vm, file);
1678 1679
	if (ret)
		goto err;
1680

1681
	/* take note of the batch buffer before we might reorder the lists */
1682
	params->batch = eb_get_batch(eb);
1683

1684
	/* Move the objects en-masse into the GTT, evicting if necessary. */
1685
	need_relocs = (args->flags & I915_EXEC_NO_RELOC) == 0;
1686 1687
	ret = i915_gem_execbuffer_reserve(engine, &eb->vmas, ctx,
					  &need_relocs);
1688 1689 1690 1691
	if (ret)
		goto err;

	/* The objects are in their final locations, apply the relocations. */
1692
	if (need_relocs)
B
Ben Widawsky 已提交
1693
		ret = i915_gem_execbuffer_relocate(eb);
1694 1695
	if (ret) {
		if (ret == -EFAULT) {
1696 1697
			ret = i915_gem_execbuffer_relocate_slow(dev, args, file,
								engine,
1698
								eb, exec, ctx);
1699 1700 1701 1702 1703 1704 1705
			BUG_ON(!mutex_is_locked(&dev->struct_mutex));
		}
		if (ret)
			goto err;
	}

	/* Set the pending read domains for the batch buffer to COMMAND */
1706
	if (params->batch->obj->base.pending_write_domain) {
1707
		DRM_DEBUG("Attempting to use self-modifying batch buffer\n");
1708 1709 1710
		ret = -EINVAL;
		goto err;
	}
1711 1712 1713 1714 1715 1716
	if (args->batch_start_offset > params->batch->size ||
	    args->batch_len > params->batch->size - args->batch_start_offset) {
		DRM_DEBUG("Attempting to use out-of-bounds batch\n");
		ret = -EINVAL;
		goto err;
	}
1717

1718
	params->args_batch_start_offset = args->batch_start_offset;
1719
	if (intel_engine_needs_cmd_parser(engine) && args->batch_len) {
1720 1721 1722 1723 1724 1725 1726 1727 1728 1729
		struct i915_vma *vma;

		vma = i915_gem_execbuffer_parse(engine, &shadow_exec_entry,
						params->batch->obj,
						eb,
						args->batch_start_offset,
						args->batch_len,
						drm_is_current_master(file));
		if (IS_ERR(vma)) {
			ret = PTR_ERR(vma);
1730 1731
			goto err;
		}
1732

1733
		if (vma) {
1734 1735 1736 1737 1738 1739 1740 1741 1742 1743
			/*
			 * Batch parsed and accepted:
			 *
			 * Set the DISPATCH_SECURE bit to remove the NON_SECURE
			 * bit from MI_BATCH_BUFFER_START commands issued in
			 * the dispatch_execbuffer implementations. We
			 * specifically don't want that set on batches the
			 * command parser has accepted.
			 */
			dispatch_flags |= I915_DISPATCH_SECURE;
1744
			params->args_batch_start_offset = 0;
1745
			params->batch = vma;
1746
		}
1747 1748
	}

1749
	params->batch->obj->base.pending_read_domains |= I915_GEM_DOMAIN_COMMAND;
1750

1751 1752
	/* snb/ivb/vlv conflate the "batch in ppgtt" bit with the "non-secure
	 * batch" bit. Hence we need to pin secure batches into the global gtt.
B
Ben Widawsky 已提交
1753
	 * hsw should have this fixed, but bdw mucks it up again. */
1754
	if (dispatch_flags & I915_DISPATCH_SECURE) {
1755
		struct drm_i915_gem_object *obj = params->batch->obj;
C
Chris Wilson 已提交
1756
		struct i915_vma *vma;
1757

1758 1759 1760 1761 1762 1763
		/*
		 * So on first glance it looks freaky that we pin the batch here
		 * outside of the reservation loop. But:
		 * - The batch is already pinned into the relevant ppgtt, so we
		 *   already have the backing storage fully allocated.
		 * - No other BO uses the global gtt (well contexts, but meh),
1764
		 *   so we don't really have issues with multiple objects not
1765 1766 1767
		 *   fitting due to fragmentation.
		 * So this is actually safe.
		 */
C
Chris Wilson 已提交
1768 1769 1770
		vma = i915_gem_object_ggtt_pin(obj, NULL, 0, 0, 0);
		if (IS_ERR(vma)) {
			ret = PTR_ERR(vma);
1771
			goto err;
C
Chris Wilson 已提交
1772
		}
1773

C
Chris Wilson 已提交
1774
		params->batch = vma;
1775
	}
1776

1777
	/* Allocate a request for this batch buffer nice and early. */
1778 1779 1780
	params->request = i915_gem_request_alloc(engine, ctx);
	if (IS_ERR(params->request)) {
		ret = PTR_ERR(params->request);
1781
		goto err_batch_unpin;
1782
	}
1783

1784 1785 1786 1787 1788 1789
	/* Whilst this request exists, batch_obj will be on the
	 * active_list, and so will hold the active reference. Only when this
	 * request is retired will the the batch_obj be moved onto the
	 * inactive_list and lose its active reference. Hence we do not need
	 * to explicitly hold another reference here.
	 */
C
Chris Wilson 已提交
1790
	params->request->batch = params->batch;
1791

1792
	ret = i915_gem_request_add_to_client(params->request, file);
1793
	if (ret)
1794
		goto err_request;
1795

1796 1797 1798 1799 1800 1801 1802 1803
	/*
	 * Save assorted stuff away to pass through to *_submission().
	 * NB: This data should be 'persistent' and not local as it will
	 * kept around beyond the duration of the IOCTL once the GPU
	 * scheduler arrives.
	 */
	params->dev                     = dev;
	params->file                    = file;
1804
	params->engine                    = engine;
1805 1806 1807
	params->dispatch_flags          = dispatch_flags;
	params->ctx                     = ctx;

1808
	ret = execbuf_submit(params, args, &eb->vmas);
1809
err_request:
1810
	__i915_add_request(params->request, ret == 0);
1811

1812
err_batch_unpin:
1813 1814 1815 1816 1817 1818
	/*
	 * FIXME: We crucially rely upon the active tracking for the (ppgtt)
	 * batch vma for correctness. For less ugly and less fragility this
	 * needs to be adjusted to also track the ggtt batch vma properly as
	 * active.
	 */
1819
	if (dispatch_flags & I915_DISPATCH_SECURE)
1820
		i915_vma_unpin(params->batch);
1821
err:
1822
	/* the request owns the ref now */
1823
	i915_gem_context_put(ctx);
1824
	eb_destroy(eb);
1825 1826 1827 1828

	mutex_unlock(&dev->struct_mutex);

pre_mutex_err:
1829 1830 1831
	/* intel_gpu_busy should also get a ref, so it will free when the device
	 * is really idle. */
	intel_runtime_pm_put(dev_priv);
1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849
	return ret;
}

/*
 * Legacy execbuffer just creates an exec2 list from the original exec object
 * list array and passes it to the real function.
 */
int
i915_gem_execbuffer(struct drm_device *dev, void *data,
		    struct drm_file *file)
{
	struct drm_i915_gem_execbuffer *args = data;
	struct drm_i915_gem_execbuffer2 exec2;
	struct drm_i915_gem_exec_object *exec_list = NULL;
	struct drm_i915_gem_exec_object2 *exec2_list = NULL;
	int ret, i;

	if (args->buffer_count < 1) {
1850
		DRM_DEBUG("execbuf with %d buffers\n", args->buffer_count);
1851 1852 1853 1854 1855 1856 1857
		return -EINVAL;
	}

	/* Copy in the exec list from userland */
	exec_list = drm_malloc_ab(sizeof(*exec_list), args->buffer_count);
	exec2_list = drm_malloc_ab(sizeof(*exec2_list), args->buffer_count);
	if (exec_list == NULL || exec2_list == NULL) {
1858
		DRM_DEBUG("Failed to allocate exec list for %d buffers\n",
1859 1860 1861 1862 1863 1864
			  args->buffer_count);
		drm_free_large(exec_list);
		drm_free_large(exec2_list);
		return -ENOMEM;
	}
	ret = copy_from_user(exec_list,
1865
			     u64_to_user_ptr(args->buffers_ptr),
1866 1867
			     sizeof(*exec_list) * args->buffer_count);
	if (ret != 0) {
1868
		DRM_DEBUG("copy %d exec entries failed %d\n",
1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895
			  args->buffer_count, ret);
		drm_free_large(exec_list);
		drm_free_large(exec2_list);
		return -EFAULT;
	}

	for (i = 0; i < args->buffer_count; i++) {
		exec2_list[i].handle = exec_list[i].handle;
		exec2_list[i].relocation_count = exec_list[i].relocation_count;
		exec2_list[i].relocs_ptr = exec_list[i].relocs_ptr;
		exec2_list[i].alignment = exec_list[i].alignment;
		exec2_list[i].offset = exec_list[i].offset;
		if (INTEL_INFO(dev)->gen < 4)
			exec2_list[i].flags = EXEC_OBJECT_NEEDS_FENCE;
		else
			exec2_list[i].flags = 0;
	}

	exec2.buffers_ptr = args->buffers_ptr;
	exec2.buffer_count = args->buffer_count;
	exec2.batch_start_offset = args->batch_start_offset;
	exec2.batch_len = args->batch_len;
	exec2.DR1 = args->DR1;
	exec2.DR4 = args->DR4;
	exec2.num_cliprects = args->num_cliprects;
	exec2.cliprects_ptr = args->cliprects_ptr;
	exec2.flags = I915_EXEC_RENDER;
1896
	i915_execbuffer2_set_context_id(exec2, 0);
1897

1898
	ret = i915_gem_do_execbuffer(dev, data, file, &exec2, exec2_list);
1899
	if (!ret) {
1900
		struct drm_i915_gem_exec_object __user *user_exec_list =
1901
			u64_to_user_ptr(args->buffers_ptr);
1902

1903
		/* Copy the new buffer offsets back to the user's exec list. */
1904
		for (i = 0; i < args->buffer_count; i++) {
1905 1906
			exec2_list[i].offset =
				gen8_canonical_addr(exec2_list[i].offset);
1907 1908 1909 1910 1911 1912 1913 1914 1915 1916
			ret = __copy_to_user(&user_exec_list[i].offset,
					     &exec2_list[i].offset,
					     sizeof(user_exec_list[i].offset));
			if (ret) {
				ret = -EFAULT;
				DRM_DEBUG("failed to copy %d exec entries "
					  "back to user (%d)\n",
					  args->buffer_count, ret);
				break;
			}
1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932
		}
	}

	drm_free_large(exec_list);
	drm_free_large(exec2_list);
	return ret;
}

int
i915_gem_execbuffer2(struct drm_device *dev, void *data,
		     struct drm_file *file)
{
	struct drm_i915_gem_execbuffer2 *args = data;
	struct drm_i915_gem_exec_object2 *exec2_list = NULL;
	int ret;

1933 1934
	if (args->buffer_count < 1 ||
	    args->buffer_count > UINT_MAX / sizeof(*exec2_list)) {
1935
		DRM_DEBUG("execbuf2 with %d buffers\n", args->buffer_count);
1936 1937 1938
		return -EINVAL;
	}

1939 1940 1941 1942 1943
	if (args->rsvd2 != 0) {
		DRM_DEBUG("dirty rvsd2 field\n");
		return -EINVAL;
	}

1944 1945 1946
	exec2_list = drm_malloc_gfp(args->buffer_count,
				    sizeof(*exec2_list),
				    GFP_TEMPORARY);
1947
	if (exec2_list == NULL) {
1948
		DRM_DEBUG("Failed to allocate exec list for %d buffers\n",
1949 1950 1951 1952
			  args->buffer_count);
		return -ENOMEM;
	}
	ret = copy_from_user(exec2_list,
1953
			     u64_to_user_ptr(args->buffers_ptr),
1954 1955
			     sizeof(*exec2_list) * args->buffer_count);
	if (ret != 0) {
1956
		DRM_DEBUG("copy %d exec entries failed %d\n",
1957 1958 1959 1960 1961
			  args->buffer_count, ret);
		drm_free_large(exec2_list);
		return -EFAULT;
	}

1962
	ret = i915_gem_do_execbuffer(dev, data, file, args, exec2_list);
1963 1964
	if (!ret) {
		/* Copy the new buffer offsets back to the user's exec list. */
1965
		struct drm_i915_gem_exec_object2 __user *user_exec_list =
1966
				   u64_to_user_ptr(args->buffers_ptr);
1967 1968 1969
		int i;

		for (i = 0; i < args->buffer_count; i++) {
1970 1971
			exec2_list[i].offset =
				gen8_canonical_addr(exec2_list[i].offset);
1972 1973 1974 1975 1976 1977 1978 1979 1980 1981
			ret = __copy_to_user(&user_exec_list[i].offset,
					     &exec2_list[i].offset,
					     sizeof(user_exec_list[i].offset));
			if (ret) {
				ret = -EFAULT;
				DRM_DEBUG("failed to copy %d exec entries "
					  "back to user\n",
					  args->buffer_count);
				break;
			}
1982 1983 1984 1985 1986 1987
		}
	}

	drm_free_large(exec2_list);
	return ret;
}