i915_gem_execbuffer.c 49.3 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28
/*
 * Copyright © 2008,2010 Intel Corporation
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice (including the next
 * paragraph) shall be included in all copies or substantial portions of the
 * Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
 * IN THE SOFTWARE.
 *
 * Authors:
 *    Eric Anholt <eric@anholt.net>
 *    Chris Wilson <chris@chris-wilson.co.uk>
 *
 */

29 30
#include <drm/drmP.h>
#include <drm/i915_drm.h>
31 32 33
#include "i915_drv.h"
#include "i915_trace.h"
#include "intel_drv.h"
34
#include <linux/dma_remapping.h>
35
#include <linux/uaccess.h>
36

37 38
#define  __EXEC_OBJECT_HAS_PIN (1<<31)
#define  __EXEC_OBJECT_HAS_FENCE (1<<30)
39
#define  __EXEC_OBJECT_NEEDS_MAP (1<<29)
40 41 42
#define  __EXEC_OBJECT_NEEDS_BIAS (1<<28)

#define BATCH_OFFSET_BIAS (256*1024)
43

44 45
struct eb_vmas {
	struct list_head vmas;
46
	int and;
47
	union {
48
		struct i915_vma *lut[0];
49 50
		struct hlist_head buckets[0];
	};
51 52
};

53
static struct eb_vmas *
B
Ben Widawsky 已提交
54
eb_create(struct drm_i915_gem_execbuffer2 *args)
55
{
56
	struct eb_vmas *eb = NULL;
57 58

	if (args->flags & I915_EXEC_HANDLE_LUT) {
59
		unsigned size = args->buffer_count;
60 61
		size *= sizeof(struct i915_vma *);
		size += sizeof(struct eb_vmas);
62 63 64 65
		eb = kmalloc(size, GFP_TEMPORARY | __GFP_NOWARN | __GFP_NORETRY);
	}

	if (eb == NULL) {
66 67
		unsigned size = args->buffer_count;
		unsigned count = PAGE_SIZE / sizeof(struct hlist_head) / 2;
L
Lauri Kasanen 已提交
68
		BUILD_BUG_ON_NOT_POWER_OF_2(PAGE_SIZE / sizeof(struct hlist_head));
69 70 71
		while (count > 2*size)
			count >>= 1;
		eb = kzalloc(count*sizeof(struct hlist_head) +
72
			     sizeof(struct eb_vmas),
73 74 75 76 77 78 79 80
			     GFP_TEMPORARY);
		if (eb == NULL)
			return eb;

		eb->and = count - 1;
	} else
		eb->and = -args->buffer_count;

81
	INIT_LIST_HEAD(&eb->vmas);
82 83 84 85
	return eb;
}

static void
86
eb_reset(struct eb_vmas *eb)
87
{
88 89
	if (eb->and >= 0)
		memset(eb->buckets, 0, (eb->and+1)*sizeof(struct hlist_head));
90 91
}

92
static int
93 94 95 96 97
eb_lookup_vmas(struct eb_vmas *eb,
	       struct drm_i915_gem_exec_object2 *exec,
	       const struct drm_i915_gem_execbuffer2 *args,
	       struct i915_address_space *vm,
	       struct drm_file *file)
98
{
99 100
	struct drm_i915_gem_object *obj;
	struct list_head objects;
101
	int i, ret;
102

103
	INIT_LIST_HEAD(&objects);
104
	spin_lock(&file->table_lock);
105 106
	/* Grab a reference to the object and release the lock so we can lookup
	 * or create the VMA without using GFP_ATOMIC */
107
	for (i = 0; i < args->buffer_count; i++) {
108 109 110 111 112
		obj = to_intel_bo(idr_find(&file->object_idr, exec[i].handle));
		if (obj == NULL) {
			spin_unlock(&file->table_lock);
			DRM_DEBUG("Invalid object handle %d at index %d\n",
				   exec[i].handle, i);
113
			ret = -ENOENT;
114
			goto err;
115 116
		}

117
		if (!list_empty(&obj->obj_exec_link)) {
118 119 120
			spin_unlock(&file->table_lock);
			DRM_DEBUG("Object %p [handle %d, index %d] appears more than once in object list\n",
				   obj, exec[i].handle, i);
121
			ret = -EINVAL;
122
			goto err;
123 124 125
		}

		drm_gem_object_reference(&obj->base);
126 127 128
		list_add_tail(&obj->obj_exec_link, &objects);
	}
	spin_unlock(&file->table_lock);
129

130
	i = 0;
131
	while (!list_empty(&objects)) {
132
		struct i915_vma *vma;
133

134 135 136 137
		obj = list_first_entry(&objects,
				       struct drm_i915_gem_object,
				       obj_exec_link);

138 139 140 141 142 143 144 145
		/*
		 * NOTE: We can leak any vmas created here when something fails
		 * later on. But that's no issue since vma_unbind can deal with
		 * vmas which are not actually bound. And since only
		 * lookup_or_create exists as an interface to get at the vma
		 * from the (obj, vm) we don't run the risk of creating
		 * duplicated vmas for the same vm.
		 */
146
		vma = i915_gem_obj_lookup_or_create_vma(obj, vm);
147 148 149
		if (IS_ERR(vma)) {
			DRM_DEBUG("Failed to lookup VMA\n");
			ret = PTR_ERR(vma);
150
			goto err;
151 152
		}

153
		/* Transfer ownership from the objects list to the vmas list. */
154
		list_add_tail(&vma->exec_list, &eb->vmas);
155
		list_del_init(&obj->obj_exec_link);
156 157

		vma->exec_entry = &exec[i];
158
		if (eb->and < 0) {
159
			eb->lut[i] = vma;
160 161
		} else {
			uint32_t handle = args->flags & I915_EXEC_HANDLE_LUT ? i : exec[i].handle;
162 163
			vma->exec_handle = handle;
			hlist_add_head(&vma->exec_node,
164 165
				       &eb->buckets[handle & eb->and]);
		}
166
		++i;
167 168
	}

169
	return 0;
170 171


172
err:
173 174 175 176 177
	while (!list_empty(&objects)) {
		obj = list_first_entry(&objects,
				       struct drm_i915_gem_object,
				       obj_exec_link);
		list_del_init(&obj->obj_exec_link);
178
		drm_gem_object_unreference(&obj->base);
179
	}
180 181 182 183 184
	/*
	 * Objects already transfered to the vmas list will be unreferenced by
	 * eb_destroy.
	 */

185
	return ret;
186 187
}

188
static struct i915_vma *eb_get_vma(struct eb_vmas *eb, unsigned long handle)
189
{
190 191 192 193 194 195
	if (eb->and < 0) {
		if (handle >= -eb->and)
			return NULL;
		return eb->lut[handle];
	} else {
		struct hlist_head *head;
196
		struct i915_vma *vma;
197

198
		head = &eb->buckets[handle & eb->and];
199
		hlist_for_each_entry(vma, head, exec_node) {
200 201
			if (vma->exec_handle == handle)
				return vma;
202 203 204
		}
		return NULL;
	}
205 206
}

207 208 209 210 211 212 213 214 215 216 217 218 219 220 221
static void
i915_gem_execbuffer_unreserve_vma(struct i915_vma *vma)
{
	struct drm_i915_gem_exec_object2 *entry;
	struct drm_i915_gem_object *obj = vma->obj;

	if (!drm_mm_node_allocated(&vma->node))
		return;

	entry = vma->exec_entry;

	if (entry->flags & __EXEC_OBJECT_HAS_FENCE)
		i915_gem_object_unpin_fence(obj);

	if (entry->flags & __EXEC_OBJECT_HAS_PIN)
222
		vma->pin_count--;
223

C
Chris Wilson 已提交
224
	entry->flags &= ~(__EXEC_OBJECT_HAS_FENCE | __EXEC_OBJECT_HAS_PIN);
225 226 227 228
}

static void eb_destroy(struct eb_vmas *eb)
{
229 230
	while (!list_empty(&eb->vmas)) {
		struct i915_vma *vma;
231

232 233
		vma = list_first_entry(&eb->vmas,
				       struct i915_vma,
234
				       exec_list);
235
		list_del_init(&vma->exec_list);
236
		i915_gem_execbuffer_unreserve_vma(vma);
237
		drm_gem_object_unreference(&vma->obj->base);
238
	}
239 240 241
	kfree(eb);
}

242 243
static inline int use_cpu_reloc(struct drm_i915_gem_object *obj)
{
244 245
	return (HAS_LLC(obj->base.dev) ||
		obj->base.write_domain == I915_GEM_DOMAIN_CPU ||
246 247 248
		obj->cache_level != I915_CACHE_NONE);
}

249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273
/* Used to convert any address to canonical form.
 * Starting from gen8, some commands (e.g. STATE_BASE_ADDRESS,
 * MI_LOAD_REGISTER_MEM and others, see Broadwell PRM Vol2a) require the
 * addresses to be in a canonical form:
 * "GraphicsAddress[63:48] are ignored by the HW and assumed to be in correct
 * canonical form [63:48] == [47]."
 */
#define GEN8_HIGH_ADDRESS_BIT 47
static inline uint64_t gen8_canonical_addr(uint64_t address)
{
	return sign_extend64(address, GEN8_HIGH_ADDRESS_BIT);
}

static inline uint64_t gen8_noncanonical_addr(uint64_t address)
{
	return address & ((1ULL << (GEN8_HIGH_ADDRESS_BIT + 1)) - 1);
}

static inline uint64_t
relocation_target(struct drm_i915_gem_relocation_entry *reloc,
		  uint64_t target_offset)
{
	return gen8_canonical_addr((int)reloc->delta + target_offset);
}

274 275
static int
relocate_entry_cpu(struct drm_i915_gem_object *obj,
B
Ben Widawsky 已提交
276 277
		   struct drm_i915_gem_relocation_entry *reloc,
		   uint64_t target_offset)
278
{
279
	struct drm_device *dev = obj->base.dev;
280
	uint32_t page_offset = offset_in_page(reloc->offset);
281
	uint64_t delta = relocation_target(reloc, target_offset);
282
	char *vaddr;
283
	int ret;
284

285
	ret = i915_gem_object_set_to_cpu_domain(obj, true);
286 287 288
	if (ret)
		return ret;

289
	vaddr = kmap_atomic(i915_gem_object_get_dirty_page(obj,
290
				reloc->offset >> PAGE_SHIFT));
B
Ben Widawsky 已提交
291
	*(uint32_t *)(vaddr + page_offset) = lower_32_bits(delta);
292 293 294 295 296 297

	if (INTEL_INFO(dev)->gen >= 8) {
		page_offset = offset_in_page(page_offset + sizeof(uint32_t));

		if (page_offset == 0) {
			kunmap_atomic(vaddr);
298
			vaddr = kmap_atomic(i915_gem_object_get_dirty_page(obj,
299 300 301
			    (reloc->offset + sizeof(uint32_t)) >> PAGE_SHIFT));
		}

B
Ben Widawsky 已提交
302
		*(uint32_t *)(vaddr + page_offset) = upper_32_bits(delta);
303 304
	}

305 306 307 308 309 310 311
	kunmap_atomic(vaddr);

	return 0;
}

static int
relocate_entry_gtt(struct drm_i915_gem_object *obj,
B
Ben Widawsky 已提交
312 313
		   struct drm_i915_gem_relocation_entry *reloc,
		   uint64_t target_offset)
314 315 316
{
	struct drm_device *dev = obj->base.dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
317
	uint64_t delta = relocation_target(reloc, target_offset);
318
	uint64_t offset;
319
	void __iomem *reloc_page;
320
	int ret;
321 322 323 324 325 326 327 328 329 330

	ret = i915_gem_object_set_to_gtt_domain(obj, true);
	if (ret)
		return ret;

	ret = i915_gem_object_put_fence(obj);
	if (ret)
		return ret;

	/* Map the page containing the relocation we're going to perform.  */
331 332
	offset = i915_gem_obj_ggtt_offset(obj);
	offset += reloc->offset;
333
	reloc_page = io_mapping_map_atomic_wc(dev_priv->gtt.mappable,
334 335
					      offset & PAGE_MASK);
	iowrite32(lower_32_bits(delta), reloc_page + offset_in_page(offset));
336 337

	if (INTEL_INFO(dev)->gen >= 8) {
338
		offset += sizeof(uint32_t);
339

340
		if (offset_in_page(offset) == 0) {
341
			io_mapping_unmap_atomic(reloc_page);
342 343 344
			reloc_page =
				io_mapping_map_atomic_wc(dev_priv->gtt.mappable,
							 offset);
345 346
		}

347 348
		iowrite32(upper_32_bits(delta),
			  reloc_page + offset_in_page(offset));
349 350
	}

351 352 353 354 355
	io_mapping_unmap_atomic(reloc_page);

	return 0;
}

356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371
static void
clflush_write32(void *addr, uint32_t value)
{
	/* This is not a fast path, so KISS. */
	drm_clflush_virt_range(addr, sizeof(uint32_t));
	*(uint32_t *)addr = value;
	drm_clflush_virt_range(addr, sizeof(uint32_t));
}

static int
relocate_entry_clflush(struct drm_i915_gem_object *obj,
		       struct drm_i915_gem_relocation_entry *reloc,
		       uint64_t target_offset)
{
	struct drm_device *dev = obj->base.dev;
	uint32_t page_offset = offset_in_page(reloc->offset);
372
	uint64_t delta = relocation_target(reloc, target_offset);
373 374 375 376 377 378 379
	char *vaddr;
	int ret;

	ret = i915_gem_object_set_to_gtt_domain(obj, true);
	if (ret)
		return ret;

380
	vaddr = kmap_atomic(i915_gem_object_get_dirty_page(obj,
381 382 383 384 385 386 387 388
				reloc->offset >> PAGE_SHIFT));
	clflush_write32(vaddr + page_offset, lower_32_bits(delta));

	if (INTEL_INFO(dev)->gen >= 8) {
		page_offset = offset_in_page(page_offset + sizeof(uint32_t));

		if (page_offset == 0) {
			kunmap_atomic(vaddr);
389
			vaddr = kmap_atomic(i915_gem_object_get_dirty_page(obj,
390 391 392 393 394 395 396 397 398 399 400
			    (reloc->offset + sizeof(uint32_t)) >> PAGE_SHIFT));
		}

		clflush_write32(vaddr + page_offset, upper_32_bits(delta));
	}

	kunmap_atomic(vaddr);

	return 0;
}

401 402
static int
i915_gem_execbuffer_relocate_entry(struct drm_i915_gem_object *obj,
403
				   struct eb_vmas *eb,
404
				   struct drm_i915_gem_relocation_entry *reloc)
405 406 407
{
	struct drm_device *dev = obj->base.dev;
	struct drm_gem_object *target_obj;
408
	struct drm_i915_gem_object *target_i915_obj;
409
	struct i915_vma *target_vma;
B
Ben Widawsky 已提交
410
	uint64_t target_offset;
411
	int ret;
412

413
	/* we've already hold a reference to all valid objects */
414 415
	target_vma = eb_get_vma(eb, reloc->target_handle);
	if (unlikely(target_vma == NULL))
416
		return -ENOENT;
417 418
	target_i915_obj = target_vma->obj;
	target_obj = &target_vma->obj->base;
419

420
	target_offset = gen8_canonical_addr(target_vma->node.start);
421

422 423 424 425
	/* Sandybridge PPGTT errata: We need a global gtt mapping for MI and
	 * pipe_control writes because the gpu doesn't properly redirect them
	 * through the ppgtt for non_secure batchbuffers. */
	if (unlikely(IS_GEN6(dev) &&
426
	    reloc->write_domain == I915_GEM_DOMAIN_INSTRUCTION)) {
427
		ret = i915_vma_bind(target_vma, target_i915_obj->cache_level,
428
				    PIN_GLOBAL);
429 430 431
		if (WARN_ONCE(ret, "Unexpected failure to bind target VMA!"))
			return ret;
	}
432

433
	/* Validate that the target is in a valid r/w GPU domain */
434
	if (unlikely(reloc->write_domain & (reloc->write_domain - 1))) {
435
		DRM_DEBUG("reloc with multiple write domains: "
436 437 438 439 440 441
			  "obj %p target %d offset %d "
			  "read %08x write %08x",
			  obj, reloc->target_handle,
			  (int) reloc->offset,
			  reloc->read_domains,
			  reloc->write_domain);
442
		return -EINVAL;
443
	}
444 445
	if (unlikely((reloc->write_domain | reloc->read_domains)
		     & ~I915_GEM_GPU_DOMAINS)) {
446
		DRM_DEBUG("reloc with read/write non-GPU domains: "
447 448 449 450 451 452
			  "obj %p target %d offset %d "
			  "read %08x write %08x",
			  obj, reloc->target_handle,
			  (int) reloc->offset,
			  reloc->read_domains,
			  reloc->write_domain);
453
		return -EINVAL;
454 455 456 457 458 459 460 461 462
	}

	target_obj->pending_read_domains |= reloc->read_domains;
	target_obj->pending_write_domain |= reloc->write_domain;

	/* If the relocation already has the right value in it, no
	 * more work needs to be done.
	 */
	if (target_offset == reloc->presumed_offset)
463
		return 0;
464 465

	/* Check that the relocation address is valid... */
466 467
	if (unlikely(reloc->offset >
		obj->base.size - (INTEL_INFO(dev)->gen >= 8 ? 8 : 4))) {
468
		DRM_DEBUG("Relocation beyond object bounds: "
469 470 471 472
			  "obj %p target %d offset %d size %d.\n",
			  obj, reloc->target_handle,
			  (int) reloc->offset,
			  (int) obj->base.size);
473
		return -EINVAL;
474
	}
475
	if (unlikely(reloc->offset & 3)) {
476
		DRM_DEBUG("Relocation not 4-byte aligned: "
477 478 479
			  "obj %p target %d offset %d.\n",
			  obj, reloc->target_handle,
			  (int) reloc->offset);
480
		return -EINVAL;
481 482
	}

483
	/* We can't wait for rendering with pagefaults disabled */
484
	if (obj->active && pagefault_disabled())
485 486
		return -EFAULT;

487
	if (use_cpu_reloc(obj))
B
Ben Widawsky 已提交
488
		ret = relocate_entry_cpu(obj, reloc, target_offset);
489
	else if (obj->map_and_fenceable)
B
Ben Widawsky 已提交
490
		ret = relocate_entry_gtt(obj, reloc, target_offset);
491 492 493 494 495 496
	else if (cpu_has_clflush)
		ret = relocate_entry_clflush(obj, reloc, target_offset);
	else {
		WARN_ONCE(1, "Impossible case in relocation handling\n");
		ret = -ENODEV;
	}
497

498 499 500
	if (ret)
		return ret;

501 502 503
	/* and update the user's relocation entry */
	reloc->presumed_offset = target_offset;

504
	return 0;
505 506 507
}

static int
508 509
i915_gem_execbuffer_relocate_vma(struct i915_vma *vma,
				 struct eb_vmas *eb)
510
{
511 512
#define N_RELOC(x) ((x) / sizeof(struct drm_i915_gem_relocation_entry))
	struct drm_i915_gem_relocation_entry stack_reloc[N_RELOC(512)];
513
	struct drm_i915_gem_relocation_entry __user *user_relocs;
514
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
515
	int remain, ret;
516

V
Ville Syrjälä 已提交
517
	user_relocs = to_user_ptr(entry->relocs_ptr);
518

519 520 521 522 523 524 525 526 527
	remain = entry->relocation_count;
	while (remain) {
		struct drm_i915_gem_relocation_entry *r = stack_reloc;
		int count = remain;
		if (count > ARRAY_SIZE(stack_reloc))
			count = ARRAY_SIZE(stack_reloc);
		remain -= count;

		if (__copy_from_user_inatomic(r, user_relocs, count*sizeof(r[0])))
528 529
			return -EFAULT;

530 531
		do {
			u64 offset = r->presumed_offset;
532

533
			ret = i915_gem_execbuffer_relocate_entry(vma->obj, eb, r);
534 535 536 537 538 539 540 541 542 543 544 545 546
			if (ret)
				return ret;

			if (r->presumed_offset != offset &&
			    __copy_to_user_inatomic(&user_relocs->presumed_offset,
						    &r->presumed_offset,
						    sizeof(r->presumed_offset))) {
				return -EFAULT;
			}

			user_relocs++;
			r++;
		} while (--count);
547 548 549
	}

	return 0;
550
#undef N_RELOC
551 552 553
}

static int
554 555 556
i915_gem_execbuffer_relocate_vma_slow(struct i915_vma *vma,
				      struct eb_vmas *eb,
				      struct drm_i915_gem_relocation_entry *relocs)
557
{
558
	const struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
559 560 561
	int i, ret;

	for (i = 0; i < entry->relocation_count; i++) {
562
		ret = i915_gem_execbuffer_relocate_entry(vma->obj, eb, &relocs[i]);
563 564 565 566 567 568 569 570
		if (ret)
			return ret;
	}

	return 0;
}

static int
B
Ben Widawsky 已提交
571
i915_gem_execbuffer_relocate(struct eb_vmas *eb)
572
{
573
	struct i915_vma *vma;
574 575 576 577 578 579 580 581 582 583
	int ret = 0;

	/* This is the fast path and we cannot handle a pagefault whilst
	 * holding the struct mutex lest the user pass in the relocations
	 * contained within a mmaped bo. For in such a case we, the page
	 * fault handler would call i915_gem_fault() and we would try to
	 * acquire the struct mutex again. Obviously this is bad and so
	 * lockdep complains vehemently.
	 */
	pagefault_disable();
584 585
	list_for_each_entry(vma, &eb->vmas, exec_list) {
		ret = i915_gem_execbuffer_relocate_vma(vma, eb);
586
		if (ret)
587
			break;
588
	}
589
	pagefault_enable();
590

591
	return ret;
592 593
}

594 595 596 597 598 599
static bool only_mappable_for_reloc(unsigned int flags)
{
	return (flags & (EXEC_OBJECT_NEEDS_FENCE | __EXEC_OBJECT_NEEDS_MAP)) ==
		__EXEC_OBJECT_NEEDS_MAP;
}

600
static int
601
i915_gem_execbuffer_reserve_vma(struct i915_vma *vma,
602
				struct intel_engine_cs *engine,
603
				bool *need_reloc)
604
{
605
	struct drm_i915_gem_object *obj = vma->obj;
606
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
607
	uint64_t flags;
608 609
	int ret;

610
	flags = PIN_USER;
611 612 613
	if (entry->flags & EXEC_OBJECT_NEEDS_GTT)
		flags |= PIN_GLOBAL;

614
	if (!drm_mm_node_allocated(&vma->node)) {
615 616 617 618 619
		/* Wa32bitGeneralStateOffset & Wa32bitInstructionBaseOffset,
		 * limit address to the first 4GBs for unflagged objects.
		 */
		if ((entry->flags & EXEC_OBJECT_SUPPORTS_48B_ADDRESS) == 0)
			flags |= PIN_ZONE_4G;
620 621 622 623
		if (entry->flags & __EXEC_OBJECT_NEEDS_MAP)
			flags |= PIN_GLOBAL | PIN_MAPPABLE;
		if (entry->flags & __EXEC_OBJECT_NEEDS_BIAS)
			flags |= BATCH_OFFSET_BIAS | PIN_OFFSET_BIAS;
624 625
		if (entry->flags & EXEC_OBJECT_PINNED)
			flags |= entry->offset | PIN_OFFSET_FIXED;
626 627
		if ((flags & PIN_MAPPABLE) == 0)
			flags |= PIN_HIGH;
628
	}
629 630

	ret = i915_gem_object_pin(obj, vma->vm, entry->alignment, flags);
631 632 633 634
	if ((ret == -ENOSPC  || ret == -E2BIG) &&
	    only_mappable_for_reloc(entry->flags))
		ret = i915_gem_object_pin(obj, vma->vm,
					  entry->alignment,
635
					  flags & ~PIN_MAPPABLE);
636 637 638
	if (ret)
		return ret;

639 640
	entry->flags |= __EXEC_OBJECT_HAS_PIN;

641 642 643 644
	if (entry->flags & EXEC_OBJECT_NEEDS_FENCE) {
		ret = i915_gem_object_get_fence(obj);
		if (ret)
			return ret;
645

646 647
		if (i915_gem_object_pin_fence(obj))
			entry->flags |= __EXEC_OBJECT_HAS_FENCE;
648 649
	}

650 651
	if (entry->offset != vma->node.start) {
		entry->offset = vma->node.start;
652 653 654 655 656 657 658 659
		*need_reloc = true;
	}

	if (entry->flags & EXEC_OBJECT_WRITE) {
		obj->base.pending_read_domains = I915_GEM_DOMAIN_RENDER;
		obj->base.pending_write_domain = I915_GEM_DOMAIN_RENDER;
	}

660
	return 0;
661
}
662

663
static bool
664
need_reloc_mappable(struct i915_vma *vma)
665 666 667
{
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;

668 669 670
	if (entry->relocation_count == 0)
		return false;

671
	if (!vma->is_ggtt)
672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688
		return false;

	/* See also use_cpu_reloc() */
	if (HAS_LLC(vma->obj->base.dev))
		return false;

	if (vma->obj->base.write_domain == I915_GEM_DOMAIN_CPU)
		return false;

	return true;
}

static bool
eb_vma_misplaced(struct i915_vma *vma)
{
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
	struct drm_i915_gem_object *obj = vma->obj;
689

690
	WARN_ON(entry->flags & __EXEC_OBJECT_NEEDS_MAP && !vma->is_ggtt);
691 692 693 694 695

	if (entry->alignment &&
	    vma->node.start & (entry->alignment - 1))
		return true;

696 697 698 699
	if (entry->flags & EXEC_OBJECT_PINNED &&
	    vma->node.start != entry->offset)
		return true;

700 701 702 703
	if (entry->flags & __EXEC_OBJECT_NEEDS_BIAS &&
	    vma->node.start < BATCH_OFFSET_BIAS)
		return true;

704 705 706 707
	/* avoid costly ping-pong once a batch bo ended up non-mappable */
	if (entry->flags & __EXEC_OBJECT_NEEDS_MAP && !obj->map_and_fenceable)
		return !only_mappable_for_reloc(entry->flags);

708 709 710 711
	if ((entry->flags & EXEC_OBJECT_SUPPORTS_48B_ADDRESS) == 0 &&
	    (vma->node.start + vma->node.size - 1) >> 32)
		return true;

712 713 714
	return false;
}

715
static int
716
i915_gem_execbuffer_reserve(struct intel_engine_cs *engine,
717
			    struct list_head *vmas,
718
			    struct intel_context *ctx,
719
			    bool *need_relocs)
720
{
721
	struct drm_i915_gem_object *obj;
722
	struct i915_vma *vma;
723
	struct i915_address_space *vm;
724
	struct list_head ordered_vmas;
725
	struct list_head pinned_vmas;
726
	bool has_fenced_gpu_access = INTEL_INFO(engine->dev)->gen < 4;
727
	int retry;
728

729
	i915_gem_retire_requests_ring(engine);
730

731 732
	vm = list_first_entry(vmas, struct i915_vma, exec_list)->vm;

733
	INIT_LIST_HEAD(&ordered_vmas);
734
	INIT_LIST_HEAD(&pinned_vmas);
735
	while (!list_empty(vmas)) {
736 737 738
		struct drm_i915_gem_exec_object2 *entry;
		bool need_fence, need_mappable;

739 740 741
		vma = list_first_entry(vmas, struct i915_vma, exec_list);
		obj = vma->obj;
		entry = vma->exec_entry;
742

743 744 745
		if (ctx->flags & CONTEXT_NO_ZEROMAP)
			entry->flags |= __EXEC_OBJECT_NEEDS_BIAS;

746 747
		if (!has_fenced_gpu_access)
			entry->flags &= ~EXEC_OBJECT_NEEDS_FENCE;
748 749 750
		need_fence =
			entry->flags & EXEC_OBJECT_NEEDS_FENCE &&
			obj->tiling_mode != I915_TILING_NONE;
751
		need_mappable = need_fence || need_reloc_mappable(vma);
752

753 754 755
		if (entry->flags & EXEC_OBJECT_PINNED)
			list_move_tail(&vma->exec_list, &pinned_vmas);
		else if (need_mappable) {
756
			entry->flags |= __EXEC_OBJECT_NEEDS_MAP;
757
			list_move(&vma->exec_list, &ordered_vmas);
758
		} else
759
			list_move_tail(&vma->exec_list, &ordered_vmas);
760

761
		obj->base.pending_read_domains = I915_GEM_GPU_DOMAINS & ~I915_GEM_DOMAIN_COMMAND;
762
		obj->base.pending_write_domain = 0;
763
	}
764
	list_splice(&ordered_vmas, vmas);
765
	list_splice(&pinned_vmas, vmas);
766 767 768 769 770 771 772 773 774 775

	/* Attempt to pin all of the buffers into the GTT.
	 * This is done in 3 phases:
	 *
	 * 1a. Unbind all objects that do not match the GTT constraints for
	 *     the execbuffer (fenceable, mappable, alignment etc).
	 * 1b. Increment pin count for already bound objects.
	 * 2.  Bind new objects.
	 * 3.  Decrement pin count.
	 *
776
	 * This avoid unnecessary unbinding of later objects in order to make
777 778 779 780
	 * room for the earlier objects *unless* we need to defragment.
	 */
	retry = 0;
	do {
781
		int ret = 0;
782 783

		/* Unbind any ill-fitting objects or pin. */
784 785
		list_for_each_entry(vma, vmas, exec_list) {
			if (!drm_mm_node_allocated(&vma->node))
786 787
				continue;

788
			if (eb_vma_misplaced(vma))
789
				ret = i915_vma_unbind(vma);
790
			else
791 792 793
				ret = i915_gem_execbuffer_reserve_vma(vma,
								      engine,
								      need_relocs);
794
			if (ret)
795 796 797 798
				goto err;
		}

		/* Bind fresh objects */
799 800
		list_for_each_entry(vma, vmas, exec_list) {
			if (drm_mm_node_allocated(&vma->node))
801
				continue;
802

803 804
			ret = i915_gem_execbuffer_reserve_vma(vma, engine,
							      need_relocs);
805 806
			if (ret)
				goto err;
807 808
		}

809
err:
C
Chris Wilson 已提交
810
		if (ret != -ENOSPC || retry++)
811 812
			return ret;

813 814 815 816
		/* Decrement pin count for bound objects */
		list_for_each_entry(vma, vmas, exec_list)
			i915_gem_execbuffer_unreserve_vma(vma);

817
		ret = i915_gem_evict_vm(vm, true);
818 819 820 821 822 823 824
		if (ret)
			return ret;
	} while (1);
}

static int
i915_gem_execbuffer_relocate_slow(struct drm_device *dev,
825
				  struct drm_i915_gem_execbuffer2 *args,
826
				  struct drm_file *file,
827
				  struct intel_engine_cs *engine,
828
				  struct eb_vmas *eb,
829 830
				  struct drm_i915_gem_exec_object2 *exec,
				  struct intel_context *ctx)
831 832
{
	struct drm_i915_gem_relocation_entry *reloc;
833 834
	struct i915_address_space *vm;
	struct i915_vma *vma;
835
	bool need_relocs;
836
	int *reloc_offset;
837
	int i, total, ret;
838
	unsigned count = args->buffer_count;
839

840 841
	vm = list_first_entry(&eb->vmas, struct i915_vma, exec_list)->vm;

842
	/* We may process another execbuffer during the unlock... */
843 844 845
	while (!list_empty(&eb->vmas)) {
		vma = list_first_entry(&eb->vmas, struct i915_vma, exec_list);
		list_del_init(&vma->exec_list);
846
		i915_gem_execbuffer_unreserve_vma(vma);
847
		drm_gem_object_unreference(&vma->obj->base);
848 849
	}

850 851 852 853
	mutex_unlock(&dev->struct_mutex);

	total = 0;
	for (i = 0; i < count; i++)
854
		total += exec[i].relocation_count;
855

856
	reloc_offset = drm_malloc_ab(count, sizeof(*reloc_offset));
857
	reloc = drm_malloc_ab(total, sizeof(*reloc));
858 859 860
	if (reloc == NULL || reloc_offset == NULL) {
		drm_free_large(reloc);
		drm_free_large(reloc_offset);
861 862 863 864 865 866 867
		mutex_lock(&dev->struct_mutex);
		return -ENOMEM;
	}

	total = 0;
	for (i = 0; i < count; i++) {
		struct drm_i915_gem_relocation_entry __user *user_relocs;
868 869
		u64 invalid_offset = (u64)-1;
		int j;
870

V
Ville Syrjälä 已提交
871
		user_relocs = to_user_ptr(exec[i].relocs_ptr);
872 873

		if (copy_from_user(reloc+total, user_relocs,
874
				   exec[i].relocation_count * sizeof(*reloc))) {
875 876 877 878 879
			ret = -EFAULT;
			mutex_lock(&dev->struct_mutex);
			goto err;
		}

880 881 882 883 884 885 886 887 888 889
		/* As we do not update the known relocation offsets after
		 * relocating (due to the complexities in lock handling),
		 * we need to mark them as invalid now so that we force the
		 * relocation processing next time. Just in case the target
		 * object is evicted and then rebound into its old
		 * presumed_offset before the next execbuffer - if that
		 * happened we would make the mistake of assuming that the
		 * relocations were valid.
		 */
		for (j = 0; j < exec[i].relocation_count; j++) {
890 891 892
			if (__copy_to_user(&user_relocs[j].presumed_offset,
					   &invalid_offset,
					   sizeof(invalid_offset))) {
893 894 895 896 897 898
				ret = -EFAULT;
				mutex_lock(&dev->struct_mutex);
				goto err;
			}
		}

899
		reloc_offset[i] = total;
900
		total += exec[i].relocation_count;
901 902 903 904 905 906 907 908
	}

	ret = i915_mutex_lock_interruptible(dev);
	if (ret) {
		mutex_lock(&dev->struct_mutex);
		goto err;
	}

909 910
	/* reacquire the objects */
	eb_reset(eb);
911
	ret = eb_lookup_vmas(eb, exec, args, vm, file);
912 913
	if (ret)
		goto err;
914

915
	need_relocs = (args->flags & I915_EXEC_NO_RELOC) == 0;
916 917
	ret = i915_gem_execbuffer_reserve(engine, &eb->vmas, ctx,
					  &need_relocs);
918 919 920
	if (ret)
		goto err;

921 922 923 924
	list_for_each_entry(vma, &eb->vmas, exec_list) {
		int offset = vma->exec_entry - exec;
		ret = i915_gem_execbuffer_relocate_vma_slow(vma, eb,
							    reloc + reloc_offset[offset]);
925 926 927 928 929 930 931 932 933 934 935 936
		if (ret)
			goto err;
	}

	/* Leave the user relocations as are, this is the painfully slow path,
	 * and we want to avoid the complication of dropping the lock whilst
	 * having buffers reserved in the aperture and so causing spurious
	 * ENOSPC for random operations.
	 */

err:
	drm_free_large(reloc);
937
	drm_free_large(reloc_offset);
938 939 940 941
	return ret;
}

static int
942
i915_gem_execbuffer_move_to_gpu(struct drm_i915_gem_request *req,
943
				struct list_head *vmas)
944
{
945
	const unsigned other_rings = ~intel_ring_flag(req->ring);
946
	struct i915_vma *vma;
947
	uint32_t flush_domains = 0;
948
	bool flush_chipset = false;
949
	int ret;
950

951 952
	list_for_each_entry(vma, vmas, exec_list) {
		struct drm_i915_gem_object *obj = vma->obj;
953 954

		if (obj->active & other_rings) {
955
			ret = i915_gem_object_sync(obj, req->ring, &req);
956 957 958
			if (ret)
				return ret;
		}
959 960

		if (obj->base.write_domain & I915_GEM_DOMAIN_CPU)
961
			flush_chipset |= i915_gem_clflush_object(obj, false);
962 963

		flush_domains |= obj->base.write_domain;
964 965
	}

966
	if (flush_chipset)
967
		i915_gem_chipset_flush(req->ring->dev);
968 969 970 971

	if (flush_domains & I915_GEM_DOMAIN_GTT)
		wmb();

972 973 974
	/* Unconditionally invalidate gpu caches and ensure that we do flush
	 * any residual writes from the previous batch.
	 */
975
	return intel_ring_invalidate_all_caches(req);
976 977
}

978 979
static bool
i915_gem_check_execbuffer(struct drm_i915_gem_execbuffer2 *exec)
980
{
981 982 983
	if (exec->flags & __I915_EXEC_UNKNOWN_FLAGS)
		return false;

C
Chris Wilson 已提交
984 985 986 987 988 989 990 991 992 993 994 995 996 997 998
	/* Kernel clipping was a DRI1 misfeature */
	if (exec->num_cliprects || exec->cliprects_ptr)
		return false;

	if (exec->DR4 == 0xffffffff) {
		DRM_DEBUG("UXA submitting garbage DR4, fixing up\n");
		exec->DR4 = 0;
	}
	if (exec->DR1 || exec->DR4)
		return false;

	if ((exec->batch_start_offset | exec->batch_len) & 0x7)
		return false;

	return true;
999 1000 1001
}

static int
1002 1003
validate_exec_list(struct drm_device *dev,
		   struct drm_i915_gem_exec_object2 *exec,
1004 1005
		   int count)
{
1006 1007
	unsigned relocs_total = 0;
	unsigned relocs_max = UINT_MAX / sizeof(struct drm_i915_gem_relocation_entry);
1008 1009 1010 1011 1012 1013
	unsigned invalid_flags;
	int i;

	invalid_flags = __EXEC_OBJECT_UNKNOWN_FLAGS;
	if (USES_FULL_PPGTT(dev))
		invalid_flags |= EXEC_OBJECT_NEEDS_GTT;
1014 1015

	for (i = 0; i < count; i++) {
V
Ville Syrjälä 已提交
1016
		char __user *ptr = to_user_ptr(exec[i].relocs_ptr);
1017 1018
		int length; /* limited by fault_in_pages_readable() */

1019
		if (exec[i].flags & invalid_flags)
1020 1021
			return -EINVAL;

1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036
		/* Offset can be used as input (EXEC_OBJECT_PINNED), reject
		 * any non-page-aligned or non-canonical addresses.
		 */
		if (exec[i].flags & EXEC_OBJECT_PINNED) {
			if (exec[i].offset !=
			    gen8_canonical_addr(exec[i].offset & PAGE_MASK))
				return -EINVAL;

			/* From drm_mm perspective address space is continuous,
			 * so from this point we're always using non-canonical
			 * form internally.
			 */
			exec[i].offset = gen8_noncanonical_addr(exec[i].offset);
		}

1037 1038 1039
		if (exec[i].alignment && !is_power_of_2(exec[i].alignment))
			return -EINVAL;

1040 1041 1042 1043 1044
		/* First check for malicious input causing overflow in
		 * the worst case where we need to allocate the entire
		 * relocation tree as a single array.
		 */
		if (exec[i].relocation_count > relocs_max - relocs_total)
1045
			return -EINVAL;
1046
		relocs_total += exec[i].relocation_count;
1047 1048 1049

		length = exec[i].relocation_count *
			sizeof(struct drm_i915_gem_relocation_entry);
1050 1051 1052 1053 1054
		/*
		 * We must check that the entire relocation array is safe
		 * to read, but since we may need to update the presumed
		 * offsets during execution, check for full write access.
		 */
1055 1056 1057
		if (!access_ok(VERIFY_WRITE, ptr, length))
			return -EFAULT;

1058
		if (likely(!i915.prefault_disable)) {
1059 1060 1061
			if (fault_in_multipages_readable(ptr, length))
				return -EFAULT;
		}
1062 1063 1064 1065 1066
	}

	return 0;
}

1067
static struct intel_context *
1068
i915_gem_validate_context(struct drm_device *dev, struct drm_file *file,
1069
			  struct intel_engine_cs *engine, const u32 ctx_id)
1070
{
1071
	struct intel_context *ctx = NULL;
1072 1073
	struct i915_ctx_hang_stats *hs;

1074
	if (engine->id != RCS && ctx_id != DEFAULT_CONTEXT_HANDLE)
1075 1076
		return ERR_PTR(-EINVAL);

1077
	ctx = i915_gem_context_get(file->driver_priv, ctx_id);
1078
	if (IS_ERR(ctx))
1079
		return ctx;
1080

1081
	hs = &ctx->hang_stats;
1082 1083
	if (hs->banned) {
		DRM_DEBUG("Context %u tried to submit while banned\n", ctx_id);
1084
		return ERR_PTR(-EIO);
1085 1086
	}

1087 1088
	if (i915.enable_execlists && !ctx->engine[engine->id].state) {
		int ret = intel_lr_context_deferred_alloc(ctx, engine);
1089 1090 1091 1092 1093 1094
		if (ret) {
			DRM_DEBUG("Could not create LRC %u: %d\n", ctx_id, ret);
			return ERR_PTR(ret);
		}
	}

1095
	return ctx;
1096 1097
}

1098
void
1099
i915_gem_execbuffer_move_to_active(struct list_head *vmas,
1100
				   struct drm_i915_gem_request *req)
1101
{
1102
	struct intel_engine_cs *engine = i915_gem_request_get_ring(req);
1103
	struct i915_vma *vma;
1104

1105
	list_for_each_entry(vma, vmas, exec_list) {
1106
		struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
1107
		struct drm_i915_gem_object *obj = vma->obj;
1108 1109
		u32 old_read = obj->base.read_domains;
		u32 old_write = obj->base.write_domain;
C
Chris Wilson 已提交
1110

1111
		obj->dirty = 1; /* be paranoid  */
1112
		obj->base.write_domain = obj->base.pending_write_domain;
1113 1114 1115
		if (obj->base.write_domain == 0)
			obj->base.pending_read_domains |= obj->base.read_domains;
		obj->base.read_domains = obj->base.pending_read_domains;
1116

1117
		i915_vma_move_to_active(vma, req);
1118
		if (obj->base.write_domain) {
1119
			i915_gem_request_assign(&obj->last_write_req, req);
1120

1121
			intel_fb_obj_invalidate(obj, ORIGIN_CS);
1122 1123 1124

			/* update for the implicit flush after a batch */
			obj->base.write_domain &= ~I915_GEM_GPU_DOMAINS;
1125
		}
1126
		if (entry->flags & EXEC_OBJECT_NEEDS_FENCE) {
1127
			i915_gem_request_assign(&obj->last_fenced_req, req);
1128
			if (entry->flags & __EXEC_OBJECT_HAS_FENCE) {
1129
				struct drm_i915_private *dev_priv = to_i915(engine->dev);
1130 1131 1132 1133
				list_move_tail(&dev_priv->fence_regs[obj->fence_reg].lru_list,
					       &dev_priv->mm.fence_list);
			}
		}
1134

C
Chris Wilson 已提交
1135
		trace_i915_gem_object_change_domain(obj, old_read, old_write);
1136 1137 1138
	}
}

1139
void
1140
i915_gem_execbuffer_retire_commands(struct i915_execbuffer_params *params)
1141
{
1142
	/* Unconditionally force add_request to emit a full flush. */
1143
	params->ring->gpu_caches_dirty = true;
1144

1145
	/* Add a breadcrumb for the completion of the batch buffer */
1146
	__i915_add_request(params->request, params->batch_obj, true);
1147
}
1148

1149 1150
static int
i915_reset_gen7_sol_offsets(struct drm_device *dev,
1151
			    struct drm_i915_gem_request *req)
1152
{
1153
	struct intel_engine_cs *engine = req->ring;
1154
	struct drm_i915_private *dev_priv = dev->dev_private;
1155 1156
	int ret, i;

1157
	if (!IS_GEN7(dev) || engine != &dev_priv->ring[RCS]) {
1158 1159 1160
		DRM_DEBUG("sol reset is gen7/rcs only\n");
		return -EINVAL;
	}
1161

1162
	ret = intel_ring_begin(req, 4 * 3);
1163 1164 1165 1166
	if (ret)
		return ret;

	for (i = 0; i < 4; i++) {
1167 1168 1169
		intel_ring_emit(engine, MI_LOAD_REGISTER_IMM(1));
		intel_ring_emit_reg(engine, GEN7_SO_WRITE_OFFSET(i));
		intel_ring_emit(engine, 0);
1170 1171
	}

1172
	intel_ring_advance(engine);
1173 1174 1175 1176

	return 0;
}

1177
static struct drm_i915_gem_object*
1178
i915_gem_execbuffer_parse(struct intel_engine_cs *engine,
1179 1180 1181 1182 1183
			  struct drm_i915_gem_exec_object2 *shadow_exec_entry,
			  struct eb_vmas *eb,
			  struct drm_i915_gem_object *batch_obj,
			  u32 batch_start_offset,
			  u32 batch_len,
1184
			  bool is_master)
1185 1186
{
	struct drm_i915_gem_object *shadow_batch_obj;
1187
	struct i915_vma *vma;
1188 1189
	int ret;

1190
	shadow_batch_obj = i915_gem_batch_pool_get(&engine->batch_pool,
1191
						   PAGE_ALIGN(batch_len));
1192 1193 1194
	if (IS_ERR(shadow_batch_obj))
		return shadow_batch_obj;

1195
	ret = i915_parse_cmds(engine,
1196 1197 1198 1199 1200
			      batch_obj,
			      shadow_batch_obj,
			      batch_start_offset,
			      batch_len,
			      is_master);
1201 1202
	if (ret)
		goto err;
1203

1204 1205 1206
	ret = i915_gem_obj_ggtt_pin(shadow_batch_obj, 0, 0);
	if (ret)
		goto err;
1207

C
Chris Wilson 已提交
1208 1209
	i915_gem_object_unpin_pages(shadow_batch_obj);

1210
	memset(shadow_exec_entry, 0, sizeof(*shadow_exec_entry));
1211

1212 1213
	vma = i915_gem_obj_to_ggtt(shadow_batch_obj);
	vma->exec_entry = shadow_exec_entry;
C
Chris Wilson 已提交
1214
	vma->exec_entry->flags = __EXEC_OBJECT_HAS_PIN;
1215 1216
	drm_gem_object_reference(&shadow_batch_obj->base);
	list_add_tail(&vma->exec_list, &eb->vmas);
1217

1218 1219 1220
	shadow_batch_obj->base.pending_read_domains = I915_GEM_DOMAIN_COMMAND;

	return shadow_batch_obj;
1221

1222
err:
C
Chris Wilson 已提交
1223
	i915_gem_object_unpin_pages(shadow_batch_obj);
1224 1225 1226 1227
	if (ret == -EACCES) /* unhandled chained batch */
		return batch_obj;
	else
		return ERR_PTR(ret);
1228
}
1229

1230
int
1231
i915_gem_ringbuffer_submission(struct i915_execbuffer_params *params,
1232
			       struct drm_i915_gem_execbuffer2 *args,
1233
			       struct list_head *vmas)
1234
{
1235
	struct drm_device *dev = params->dev;
1236
	struct intel_engine_cs *engine = params->ring;
1237
	struct drm_i915_private *dev_priv = dev->dev_private;
1238
	u64 exec_start, exec_len;
1239 1240
	int instp_mode;
	u32 instp_mask;
C
Chris Wilson 已提交
1241
	int ret;
1242

1243
	ret = i915_gem_execbuffer_move_to_gpu(params->request, vmas);
1244
	if (ret)
C
Chris Wilson 已提交
1245
		return ret;
1246

1247
	ret = i915_switch_context(params->request);
1248
	if (ret)
C
Chris Wilson 已提交
1249
		return ret;
1250

1251 1252
	WARN(params->ctx->ppgtt && params->ctx->ppgtt->pd_dirty_rings & (1<<engine->id),
	     "%s didn't clear reload\n", engine->name);
1253

1254 1255 1256 1257 1258 1259
	instp_mode = args->flags & I915_EXEC_CONSTANTS_MASK;
	instp_mask = I915_EXEC_CONSTANTS_MASK;
	switch (instp_mode) {
	case I915_EXEC_CONSTANTS_REL_GENERAL:
	case I915_EXEC_CONSTANTS_ABSOLUTE:
	case I915_EXEC_CONSTANTS_REL_SURFACE:
1260
		if (instp_mode != 0 && engine != &dev_priv->ring[RCS]) {
1261
			DRM_DEBUG("non-0 rel constants mode on non-RCS\n");
C
Chris Wilson 已提交
1262
			return -EINVAL;
1263 1264 1265 1266 1267
		}

		if (instp_mode != dev_priv->relative_constants_mode) {
			if (INTEL_INFO(dev)->gen < 4) {
				DRM_DEBUG("no rel constants on pre-gen4\n");
C
Chris Wilson 已提交
1268
				return -EINVAL;
1269 1270 1271 1272 1273
			}

			if (INTEL_INFO(dev)->gen > 5 &&
			    instp_mode == I915_EXEC_CONSTANTS_REL_SURFACE) {
				DRM_DEBUG("rel surface constants mode invalid on gen5+\n");
C
Chris Wilson 已提交
1274
				return -EINVAL;
1275 1276 1277 1278 1279 1280 1281 1282 1283
			}

			/* The HW changed the meaning on this bit on gen6 */
			if (INTEL_INFO(dev)->gen >= 6)
				instp_mask &= ~I915_EXEC_CONSTANTS_REL_SURFACE;
		}
		break;
	default:
		DRM_DEBUG("execbuf with unknown constants: %d\n", instp_mode);
C
Chris Wilson 已提交
1284
		return -EINVAL;
1285 1286
	}

1287
	if (engine == &dev_priv->ring[RCS] &&
C
Chris Wilson 已提交
1288
	    instp_mode != dev_priv->relative_constants_mode) {
1289
		ret = intel_ring_begin(params->request, 4);
1290
		if (ret)
C
Chris Wilson 已提交
1291
			return ret;
1292

1293 1294 1295 1296 1297
		intel_ring_emit(engine, MI_NOOP);
		intel_ring_emit(engine, MI_LOAD_REGISTER_IMM(1));
		intel_ring_emit_reg(engine, INSTPM);
		intel_ring_emit(engine, instp_mask << 16 | instp_mode);
		intel_ring_advance(engine);
1298 1299 1300 1301 1302

		dev_priv->relative_constants_mode = instp_mode;
	}

	if (args->flags & I915_EXEC_GEN7_SOL_RESET) {
1303
		ret = i915_reset_gen7_sol_offsets(dev, params->request);
1304
		if (ret)
C
Chris Wilson 已提交
1305
			return ret;
1306 1307
	}

1308 1309 1310 1311
	exec_len   = args->batch_len;
	exec_start = params->batch_obj_vm_offset +
		     params->args_batch_start_offset;

1312 1313 1314
	if (exec_len == 0)
		exec_len = params->batch_obj->base.size;

1315
	ret = engine->dispatch_execbuffer(params->request,
C
Chris Wilson 已提交
1316 1317 1318 1319
					exec_start, exec_len,
					params->dispatch_flags);
	if (ret)
		return ret;
1320

1321
	trace_i915_gem_ring_dispatch(params->request, params->dispatch_flags);
1322

1323
	i915_gem_execbuffer_move_to_active(vmas, params->request);
1324
	i915_gem_execbuffer_retire_commands(params);
1325

C
Chris Wilson 已提交
1326
	return 0;
1327 1328
}

1329 1330
/**
 * Find one BSD ring to dispatch the corresponding BSD command.
1331
 * The ring index is returned.
1332
 */
1333 1334
static unsigned int
gen8_dispatch_bsd_ring(struct drm_i915_private *dev_priv, struct drm_file *file)
1335 1336 1337
{
	struct drm_i915_file_private *file_priv = file->driver_priv;

1338 1339 1340 1341 1342 1343 1344
	/* Check whether the file_priv has already selected one ring. */
	if ((int)file_priv->bsd_ring < 0) {
		/* If not, use the ping-pong mechanism to select one. */
		mutex_lock(&dev_priv->dev->struct_mutex);
		file_priv->bsd_ring = dev_priv->mm.bsd_ring_dispatch_index;
		dev_priv->mm.bsd_ring_dispatch_index ^= 1;
		mutex_unlock(&dev_priv->dev->struct_mutex);
1345
	}
1346 1347

	return file_priv->bsd_ring;
1348 1349
}

1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363
static struct drm_i915_gem_object *
eb_get_batch(struct eb_vmas *eb)
{
	struct i915_vma *vma = list_entry(eb->vmas.prev, typeof(*vma), exec_list);

	/*
	 * SNA is doing fancy tricks with compressing batch buffers, which leads
	 * to negative relocation deltas. Usually that works out ok since the
	 * relocate address is still positive, except when the batch is placed
	 * very low in the GTT. Ensure this doesn't happen.
	 *
	 * Note that actual hangs have only been observed on gen7, but for
	 * paranoia do it everywhere.
	 */
1364 1365
	if ((vma->exec_entry->flags & EXEC_OBJECT_PINNED) == 0)
		vma->exec_entry->flags |= __EXEC_OBJECT_NEEDS_BIAS;
1366 1367 1368 1369

	return vma->obj;
}

1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406
#define I915_USER_RINGS (4)

static const enum intel_ring_id user_ring_map[I915_USER_RINGS + 1] = {
	[I915_EXEC_DEFAULT]	= RCS,
	[I915_EXEC_RENDER]	= RCS,
	[I915_EXEC_BLT]		= BCS,
	[I915_EXEC_BSD]		= VCS,
	[I915_EXEC_VEBOX]	= VECS
};

static int
eb_select_ring(struct drm_i915_private *dev_priv,
	       struct drm_file *file,
	       struct drm_i915_gem_execbuffer2 *args,
	       struct intel_engine_cs **ring)
{
	unsigned int user_ring_id = args->flags & I915_EXEC_RING_MASK;

	if (user_ring_id > I915_USER_RINGS) {
		DRM_DEBUG("execbuf with unknown ring: %u\n", user_ring_id);
		return -EINVAL;
	}

	if ((user_ring_id != I915_EXEC_BSD) &&
	    ((args->flags & I915_EXEC_BSD_MASK) != 0)) {
		DRM_DEBUG("execbuf with non bsd ring but with invalid "
			  "bsd dispatch flags: %d\n", (int)(args->flags));
		return -EINVAL;
	}

	if (user_ring_id == I915_EXEC_BSD && HAS_BSD2(dev_priv)) {
		unsigned int bsd_idx = args->flags & I915_EXEC_BSD_MASK;

		if (bsd_idx == I915_EXEC_BSD_DEFAULT) {
			bsd_idx = gen8_dispatch_bsd_ring(dev_priv, file);
		} else if (bsd_idx >= I915_EXEC_BSD_RING1 &&
			   bsd_idx <= I915_EXEC_BSD_RING2) {
1407
			bsd_idx >>= I915_EXEC_BSD_SHIFT;
1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427
			bsd_idx--;
		} else {
			DRM_DEBUG("execbuf with unknown bsd ring: %u\n",
				  bsd_idx);
			return -EINVAL;
		}

		*ring = &dev_priv->ring[_VCS(bsd_idx)];
	} else {
		*ring = &dev_priv->ring[user_ring_map[user_ring_id]];
	}

	if (!intel_ring_initialized(*ring)) {
		DRM_DEBUG("execbuf with invalid ring: %u\n", user_ring_id);
		return -EINVAL;
	}

	return 0;
}

1428 1429 1430 1431
static int
i915_gem_do_execbuffer(struct drm_device *dev, void *data,
		       struct drm_file *file,
		       struct drm_i915_gem_execbuffer2 *args,
1432
		       struct drm_i915_gem_exec_object2 *exec)
1433
{
1434
	struct drm_i915_private *dev_priv = dev->dev_private;
1435
	struct drm_i915_gem_request *req = NULL;
1436
	struct eb_vmas *eb;
1437
	struct drm_i915_gem_object *batch_obj;
1438
	struct drm_i915_gem_exec_object2 shadow_exec_entry;
1439
	struct intel_engine_cs *engine;
1440
	struct intel_context *ctx;
1441
	struct i915_address_space *vm;
1442 1443
	struct i915_execbuffer_params params_master; /* XXX: will be removed later */
	struct i915_execbuffer_params *params = &params_master;
1444
	const u32 ctx_id = i915_execbuffer2_get_context_id(*args);
1445
	u32 dispatch_flags;
1446
	int ret;
1447
	bool need_relocs;
1448

1449
	if (!i915_gem_check_execbuffer(args))
1450 1451
		return -EINVAL;

1452
	ret = validate_exec_list(dev, exec, args->buffer_count);
1453 1454 1455
	if (ret)
		return ret;

1456
	dispatch_flags = 0;
1457 1458 1459 1460
	if (args->flags & I915_EXEC_SECURE) {
		if (!file->is_master || !capable(CAP_SYS_ADMIN))
		    return -EPERM;

1461
		dispatch_flags |= I915_DISPATCH_SECURE;
1462
	}
1463
	if (args->flags & I915_EXEC_IS_PINNED)
1464
		dispatch_flags |= I915_DISPATCH_PINNED;
1465

1466
	ret = eb_select_ring(dev_priv, file, args, &engine);
1467 1468
	if (ret)
		return ret;
1469 1470

	if (args->buffer_count < 1) {
1471
		DRM_DEBUG("execbuf with %d buffers\n", args->buffer_count);
1472 1473 1474
		return -EINVAL;
	}

1475 1476 1477 1478 1479
	if (args->flags & I915_EXEC_RESOURCE_STREAMER) {
		if (!HAS_RESOURCE_STREAMER(dev)) {
			DRM_DEBUG("RS is only allowed for Haswell, Gen8 and above\n");
			return -EINVAL;
		}
1480
		if (engine->id != RCS) {
1481
			DRM_DEBUG("RS is not available on %s\n",
1482
				 engine->name);
1483 1484 1485 1486 1487 1488
			return -EINVAL;
		}

		dispatch_flags |= I915_DISPATCH_RS;
	}

1489 1490
	intel_runtime_pm_get(dev_priv);

1491 1492 1493 1494
	ret = i915_mutex_lock_interruptible(dev);
	if (ret)
		goto pre_mutex_err;

1495
	ctx = i915_gem_validate_context(dev, file, engine, ctx_id);
1496
	if (IS_ERR(ctx)) {
1497
		mutex_unlock(&dev->struct_mutex);
1498
		ret = PTR_ERR(ctx);
1499
		goto pre_mutex_err;
1500
	}
1501 1502 1503

	i915_gem_context_reference(ctx);

1504 1505 1506
	if (ctx->ppgtt)
		vm = &ctx->ppgtt->base;
	else
1507
		vm = &dev_priv->gtt.base;
1508

1509 1510
	memset(&params_master, 0x00, sizeof(params_master));

B
Ben Widawsky 已提交
1511
	eb = eb_create(args);
1512
	if (eb == NULL) {
1513
		i915_gem_context_unreference(ctx);
1514 1515 1516 1517 1518
		mutex_unlock(&dev->struct_mutex);
		ret = -ENOMEM;
		goto pre_mutex_err;
	}

1519
	/* Look up object handles */
1520
	ret = eb_lookup_vmas(eb, exec, args, vm, file);
1521 1522
	if (ret)
		goto err;
1523

1524
	/* take note of the batch buffer before we might reorder the lists */
1525
	batch_obj = eb_get_batch(eb);
1526

1527
	/* Move the objects en-masse into the GTT, evicting if necessary. */
1528
	need_relocs = (args->flags & I915_EXEC_NO_RELOC) == 0;
1529 1530
	ret = i915_gem_execbuffer_reserve(engine, &eb->vmas, ctx,
					  &need_relocs);
1531 1532 1533 1534
	if (ret)
		goto err;

	/* The objects are in their final locations, apply the relocations. */
1535
	if (need_relocs)
B
Ben Widawsky 已提交
1536
		ret = i915_gem_execbuffer_relocate(eb);
1537 1538
	if (ret) {
		if (ret == -EFAULT) {
1539 1540
			ret = i915_gem_execbuffer_relocate_slow(dev, args, file,
								engine,
1541
								eb, exec, ctx);
1542 1543 1544 1545 1546 1547 1548 1549
			BUG_ON(!mutex_is_locked(&dev->struct_mutex));
		}
		if (ret)
			goto err;
	}

	/* Set the pending read domains for the batch buffer to COMMAND */
	if (batch_obj->base.pending_write_domain) {
1550
		DRM_DEBUG("Attempting to use self-modifying batch buffer\n");
1551 1552 1553 1554
		ret = -EINVAL;
		goto err;
	}

1555
	params->args_batch_start_offset = args->batch_start_offset;
1556
	if (i915_needs_cmd_parser(engine) && args->batch_len) {
1557 1558
		struct drm_i915_gem_object *parsed_batch_obj;

1559 1560 1561 1562 1563 1564 1565
		parsed_batch_obj = i915_gem_execbuffer_parse(engine,
							     &shadow_exec_entry,
							     eb,
							     batch_obj,
							     args->batch_start_offset,
							     args->batch_len,
							     file->is_master);
1566 1567
		if (IS_ERR(parsed_batch_obj)) {
			ret = PTR_ERR(parsed_batch_obj);
1568 1569
			goto err;
		}
1570 1571

		/*
1572 1573
		 * parsed_batch_obj == batch_obj means batch not fully parsed:
		 * Accept, but don't promote to secure.
1574 1575
		 */

1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586
		if (parsed_batch_obj != batch_obj) {
			/*
			 * Batch parsed and accepted:
			 *
			 * Set the DISPATCH_SECURE bit to remove the NON_SECURE
			 * bit from MI_BATCH_BUFFER_START commands issued in
			 * the dispatch_execbuffer implementations. We
			 * specifically don't want that set on batches the
			 * command parser has accepted.
			 */
			dispatch_flags |= I915_DISPATCH_SECURE;
1587
			params->args_batch_start_offset = 0;
1588 1589
			batch_obj = parsed_batch_obj;
		}
1590 1591
	}

1592 1593
	batch_obj->base.pending_read_domains |= I915_GEM_DOMAIN_COMMAND;

1594 1595
	/* snb/ivb/vlv conflate the "batch in ppgtt" bit with the "non-secure
	 * batch" bit. Hence we need to pin secure batches into the global gtt.
B
Ben Widawsky 已提交
1596
	 * hsw should have this fixed, but bdw mucks it up again. */
1597
	if (dispatch_flags & I915_DISPATCH_SECURE) {
1598 1599 1600 1601 1602 1603
		/*
		 * So on first glance it looks freaky that we pin the batch here
		 * outside of the reservation loop. But:
		 * - The batch is already pinned into the relevant ppgtt, so we
		 *   already have the backing storage fully allocated.
		 * - No other BO uses the global gtt (well contexts, but meh),
1604
		 *   so we don't really have issues with multiple objects not
1605 1606 1607 1608 1609 1610
		 *   fitting due to fragmentation.
		 * So this is actually safe.
		 */
		ret = i915_gem_obj_ggtt_pin(batch_obj, 0, 0);
		if (ret)
			goto err;
1611

1612
		params->batch_obj_vm_offset = i915_gem_obj_ggtt_offset(batch_obj);
1613
	} else
1614
		params->batch_obj_vm_offset = i915_gem_obj_offset(batch_obj, vm);
1615

1616
	/* Allocate a request for this batch buffer nice and early. */
1617
	req = i915_gem_request_alloc(engine, ctx);
1618 1619
	if (IS_ERR(req)) {
		ret = PTR_ERR(req);
1620
		goto err_batch_unpin;
1621
	}
1622

1623
	ret = i915_gem_request_add_to_client(req, file);
1624 1625 1626
	if (ret)
		goto err_batch_unpin;

1627 1628 1629 1630 1631 1632 1633 1634
	/*
	 * Save assorted stuff away to pass through to *_submission().
	 * NB: This data should be 'persistent' and not local as it will
	 * kept around beyond the duration of the IOCTL once the GPU
	 * scheduler arrives.
	 */
	params->dev                     = dev;
	params->file                    = file;
1635
	params->ring                    = engine;
1636 1637 1638
	params->dispatch_flags          = dispatch_flags;
	params->batch_obj               = batch_obj;
	params->ctx                     = ctx;
1639
	params->request                 = req;
1640 1641

	ret = dev_priv->gt.execbuf_submit(params, args, &eb->vmas);
1642

1643
err_batch_unpin:
1644 1645 1646 1647 1648 1649
	/*
	 * FIXME: We crucially rely upon the active tracking for the (ppgtt)
	 * batch vma for correctness. For less ugly and less fragility this
	 * needs to be adjusted to also track the ggtt batch vma properly as
	 * active.
	 */
1650
	if (dispatch_flags & I915_DISPATCH_SECURE)
1651
		i915_gem_object_ggtt_unpin(batch_obj);
1652

1653
err:
1654 1655
	/* the request owns the ref now */
	i915_gem_context_unreference(ctx);
1656
	eb_destroy(eb);
1657

1658 1659 1660 1661 1662
	/*
	 * If the request was created but not successfully submitted then it
	 * must be freed again. If it was submitted then it is being tracked
	 * on the active request list and no clean up is required here.
	 */
1663
	if (ret && !IS_ERR_OR_NULL(req))
1664
		i915_gem_request_cancel(req);
1665

1666 1667 1668
	mutex_unlock(&dev->struct_mutex);

pre_mutex_err:
1669 1670 1671
	/* intel_gpu_busy should also get a ref, so it will free when the device
	 * is really idle. */
	intel_runtime_pm_put(dev_priv);
1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689
	return ret;
}

/*
 * Legacy execbuffer just creates an exec2 list from the original exec object
 * list array and passes it to the real function.
 */
int
i915_gem_execbuffer(struct drm_device *dev, void *data,
		    struct drm_file *file)
{
	struct drm_i915_gem_execbuffer *args = data;
	struct drm_i915_gem_execbuffer2 exec2;
	struct drm_i915_gem_exec_object *exec_list = NULL;
	struct drm_i915_gem_exec_object2 *exec2_list = NULL;
	int ret, i;

	if (args->buffer_count < 1) {
1690
		DRM_DEBUG("execbuf with %d buffers\n", args->buffer_count);
1691 1692 1693 1694 1695 1696 1697
		return -EINVAL;
	}

	/* Copy in the exec list from userland */
	exec_list = drm_malloc_ab(sizeof(*exec_list), args->buffer_count);
	exec2_list = drm_malloc_ab(sizeof(*exec2_list), args->buffer_count);
	if (exec_list == NULL || exec2_list == NULL) {
1698
		DRM_DEBUG("Failed to allocate exec list for %d buffers\n",
1699 1700 1701 1702 1703 1704
			  args->buffer_count);
		drm_free_large(exec_list);
		drm_free_large(exec2_list);
		return -ENOMEM;
	}
	ret = copy_from_user(exec_list,
V
Ville Syrjälä 已提交
1705
			     to_user_ptr(args->buffers_ptr),
1706 1707
			     sizeof(*exec_list) * args->buffer_count);
	if (ret != 0) {
1708
		DRM_DEBUG("copy %d exec entries failed %d\n",
1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735
			  args->buffer_count, ret);
		drm_free_large(exec_list);
		drm_free_large(exec2_list);
		return -EFAULT;
	}

	for (i = 0; i < args->buffer_count; i++) {
		exec2_list[i].handle = exec_list[i].handle;
		exec2_list[i].relocation_count = exec_list[i].relocation_count;
		exec2_list[i].relocs_ptr = exec_list[i].relocs_ptr;
		exec2_list[i].alignment = exec_list[i].alignment;
		exec2_list[i].offset = exec_list[i].offset;
		if (INTEL_INFO(dev)->gen < 4)
			exec2_list[i].flags = EXEC_OBJECT_NEEDS_FENCE;
		else
			exec2_list[i].flags = 0;
	}

	exec2.buffers_ptr = args->buffers_ptr;
	exec2.buffer_count = args->buffer_count;
	exec2.batch_start_offset = args->batch_start_offset;
	exec2.batch_len = args->batch_len;
	exec2.DR1 = args->DR1;
	exec2.DR4 = args->DR4;
	exec2.num_cliprects = args->num_cliprects;
	exec2.cliprects_ptr = args->cliprects_ptr;
	exec2.flags = I915_EXEC_RENDER;
1736
	i915_execbuffer2_set_context_id(exec2, 0);
1737

1738
	ret = i915_gem_do_execbuffer(dev, data, file, &exec2, exec2_list);
1739
	if (!ret) {
1740 1741 1742
		struct drm_i915_gem_exec_object __user *user_exec_list =
			to_user_ptr(args->buffers_ptr);

1743
		/* Copy the new buffer offsets back to the user's exec list. */
1744
		for (i = 0; i < args->buffer_count; i++) {
1745 1746
			exec2_list[i].offset =
				gen8_canonical_addr(exec2_list[i].offset);
1747 1748 1749 1750 1751 1752 1753 1754 1755 1756
			ret = __copy_to_user(&user_exec_list[i].offset,
					     &exec2_list[i].offset,
					     sizeof(user_exec_list[i].offset));
			if (ret) {
				ret = -EFAULT;
				DRM_DEBUG("failed to copy %d exec entries "
					  "back to user (%d)\n",
					  args->buffer_count, ret);
				break;
			}
1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772
		}
	}

	drm_free_large(exec_list);
	drm_free_large(exec2_list);
	return ret;
}

int
i915_gem_execbuffer2(struct drm_device *dev, void *data,
		     struct drm_file *file)
{
	struct drm_i915_gem_execbuffer2 *args = data;
	struct drm_i915_gem_exec_object2 *exec2_list = NULL;
	int ret;

1773 1774
	if (args->buffer_count < 1 ||
	    args->buffer_count > UINT_MAX / sizeof(*exec2_list)) {
1775
		DRM_DEBUG("execbuf2 with %d buffers\n", args->buffer_count);
1776 1777 1778
		return -EINVAL;
	}

1779 1780 1781 1782 1783
	if (args->rsvd2 != 0) {
		DRM_DEBUG("dirty rvsd2 field\n");
		return -EINVAL;
	}

1784
	exec2_list = kmalloc(sizeof(*exec2_list)*args->buffer_count,
1785
			     GFP_TEMPORARY | __GFP_NOWARN | __GFP_NORETRY);
1786 1787 1788
	if (exec2_list == NULL)
		exec2_list = drm_malloc_ab(sizeof(*exec2_list),
					   args->buffer_count);
1789
	if (exec2_list == NULL) {
1790
		DRM_DEBUG("Failed to allocate exec list for %d buffers\n",
1791 1792 1793 1794
			  args->buffer_count);
		return -ENOMEM;
	}
	ret = copy_from_user(exec2_list,
V
Ville Syrjälä 已提交
1795
			     to_user_ptr(args->buffers_ptr),
1796 1797
			     sizeof(*exec2_list) * args->buffer_count);
	if (ret != 0) {
1798
		DRM_DEBUG("copy %d exec entries failed %d\n",
1799 1800 1801 1802 1803
			  args->buffer_count, ret);
		drm_free_large(exec2_list);
		return -EFAULT;
	}

1804
	ret = i915_gem_do_execbuffer(dev, data, file, args, exec2_list);
1805 1806
	if (!ret) {
		/* Copy the new buffer offsets back to the user's exec list. */
1807
		struct drm_i915_gem_exec_object2 __user *user_exec_list =
1808 1809 1810 1811
				   to_user_ptr(args->buffers_ptr);
		int i;

		for (i = 0; i < args->buffer_count; i++) {
1812 1813
			exec2_list[i].offset =
				gen8_canonical_addr(exec2_list[i].offset);
1814 1815 1816 1817 1818 1819 1820 1821 1822 1823
			ret = __copy_to_user(&user_exec_list[i].offset,
					     &exec2_list[i].offset,
					     sizeof(user_exec_list[i].offset));
			if (ret) {
				ret = -EFAULT;
				DRM_DEBUG("failed to copy %d exec entries "
					  "back to user\n",
					  args->buffer_count);
				break;
			}
1824 1825 1826 1827 1828 1829
		}
	}

	drm_free_large(exec2_list);
	return ret;
}