i915_gem_execbuffer.c 51.2 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28
/*
 * Copyright © 2008,2010 Intel Corporation
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice (including the next
 * paragraph) shall be included in all copies or substantial portions of the
 * Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
 * IN THE SOFTWARE.
 *
 * Authors:
 *    Eric Anholt <eric@anholt.net>
 *    Chris Wilson <chris@chris-wilson.co.uk>
 *
 */

29 30 31 32
#include <linux/dma_remapping.h>
#include <linux/reservation.h>
#include <linux/uaccess.h>

33 34
#include <drm/drmP.h>
#include <drm/i915_drm.h>
35

36
#include "i915_drv.h"
37
#include "i915_gem_dmabuf.h"
38 39
#include "i915_trace.h"
#include "intel_drv.h"
40
#include "intel_frontbuffer.h"
41

42 43 44 45 46
#define  __EXEC_OBJECT_HAS_PIN		(1<<31)
#define  __EXEC_OBJECT_HAS_FENCE	(1<<30)
#define  __EXEC_OBJECT_NEEDS_MAP	(1<<29)
#define  __EXEC_OBJECT_NEEDS_BIAS	(1<<28)
#define  __EXEC_OBJECT_INTERNAL_FLAGS (0xf<<28) /* all of the above */
47 48

#define BATCH_OFFSET_BIAS (256*1024)
49

50 51 52
struct i915_execbuffer_params {
	struct drm_device               *dev;
	struct drm_file                 *file;
53 54 55
	struct i915_vma			*batch;
	u32				dispatch_flags;
	u32				args_batch_start_offset;
56 57 58 59 60
	struct intel_engine_cs          *engine;
	struct i915_gem_context         *ctx;
	struct drm_i915_gem_request     *request;
};

61 62
struct eb_vmas {
	struct list_head vmas;
63
	int and;
64
	union {
65
		struct i915_vma *lut[0];
66 67
		struct hlist_head buckets[0];
	};
68 69
};

70
static struct eb_vmas *
B
Ben Widawsky 已提交
71
eb_create(struct drm_i915_gem_execbuffer2 *args)
72
{
73
	struct eb_vmas *eb = NULL;
74 75

	if (args->flags & I915_EXEC_HANDLE_LUT) {
76
		unsigned size = args->buffer_count;
77 78
		size *= sizeof(struct i915_vma *);
		size += sizeof(struct eb_vmas);
79 80 81 82
		eb = kmalloc(size, GFP_TEMPORARY | __GFP_NOWARN | __GFP_NORETRY);
	}

	if (eb == NULL) {
83 84
		unsigned size = args->buffer_count;
		unsigned count = PAGE_SIZE / sizeof(struct hlist_head) / 2;
L
Lauri Kasanen 已提交
85
		BUILD_BUG_ON_NOT_POWER_OF_2(PAGE_SIZE / sizeof(struct hlist_head));
86 87 88
		while (count > 2*size)
			count >>= 1;
		eb = kzalloc(count*sizeof(struct hlist_head) +
89
			     sizeof(struct eb_vmas),
90 91 92 93 94 95 96 97
			     GFP_TEMPORARY);
		if (eb == NULL)
			return eb;

		eb->and = count - 1;
	} else
		eb->and = -args->buffer_count;

98
	INIT_LIST_HEAD(&eb->vmas);
99 100 101 102
	return eb;
}

static void
103
eb_reset(struct eb_vmas *eb)
104
{
105 106
	if (eb->and >= 0)
		memset(eb->buckets, 0, (eb->and+1)*sizeof(struct hlist_head));
107 108
}

109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128
static struct i915_vma *
eb_get_batch(struct eb_vmas *eb)
{
	struct i915_vma *vma = list_entry(eb->vmas.prev, typeof(*vma), exec_list);

	/*
	 * SNA is doing fancy tricks with compressing batch buffers, which leads
	 * to negative relocation deltas. Usually that works out ok since the
	 * relocate address is still positive, except when the batch is placed
	 * very low in the GTT. Ensure this doesn't happen.
	 *
	 * Note that actual hangs have only been observed on gen7, but for
	 * paranoia do it everywhere.
	 */
	if ((vma->exec_entry->flags & EXEC_OBJECT_PINNED) == 0)
		vma->exec_entry->flags |= __EXEC_OBJECT_NEEDS_BIAS;

	return vma;
}

129
static int
130 131 132 133 134
eb_lookup_vmas(struct eb_vmas *eb,
	       struct drm_i915_gem_exec_object2 *exec,
	       const struct drm_i915_gem_execbuffer2 *args,
	       struct i915_address_space *vm,
	       struct drm_file *file)
135
{
136 137
	struct drm_i915_gem_object *obj;
	struct list_head objects;
138
	int i, ret;
139

140
	INIT_LIST_HEAD(&objects);
141
	spin_lock(&file->table_lock);
142 143
	/* Grab a reference to the object and release the lock so we can lookup
	 * or create the VMA without using GFP_ATOMIC */
144
	for (i = 0; i < args->buffer_count; i++) {
145 146 147 148 149
		obj = to_intel_bo(idr_find(&file->object_idr, exec[i].handle));
		if (obj == NULL) {
			spin_unlock(&file->table_lock);
			DRM_DEBUG("Invalid object handle %d at index %d\n",
				   exec[i].handle, i);
150
			ret = -ENOENT;
151
			goto err;
152 153
		}

154
		if (!list_empty(&obj->obj_exec_link)) {
155 156 157
			spin_unlock(&file->table_lock);
			DRM_DEBUG("Object %p [handle %d, index %d] appears more than once in object list\n",
				   obj, exec[i].handle, i);
158
			ret = -EINVAL;
159
			goto err;
160 161
		}

162
		i915_gem_object_get(obj);
163 164 165
		list_add_tail(&obj->obj_exec_link, &objects);
	}
	spin_unlock(&file->table_lock);
166

167
	i = 0;
168
	while (!list_empty(&objects)) {
169
		struct i915_vma *vma;
170

171 172 173 174
		obj = list_first_entry(&objects,
				       struct drm_i915_gem_object,
				       obj_exec_link);

175 176 177 178 179 180 181 182
		/*
		 * NOTE: We can leak any vmas created here when something fails
		 * later on. But that's no issue since vma_unbind can deal with
		 * vmas which are not actually bound. And since only
		 * lookup_or_create exists as an interface to get at the vma
		 * from the (obj, vm) we don't run the risk of creating
		 * duplicated vmas for the same vm.
		 */
C
Chris Wilson 已提交
183 184
		vma = i915_gem_obj_lookup_or_create_vma(obj, vm, NULL);
		if (unlikely(IS_ERR(vma))) {
185 186
			DRM_DEBUG("Failed to lookup VMA\n");
			ret = PTR_ERR(vma);
187
			goto err;
188 189
		}

190
		/* Transfer ownership from the objects list to the vmas list. */
191
		list_add_tail(&vma->exec_list, &eb->vmas);
192
		list_del_init(&obj->obj_exec_link);
193 194

		vma->exec_entry = &exec[i];
195
		if (eb->and < 0) {
196
			eb->lut[i] = vma;
197 198
		} else {
			uint32_t handle = args->flags & I915_EXEC_HANDLE_LUT ? i : exec[i].handle;
199 200
			vma->exec_handle = handle;
			hlist_add_head(&vma->exec_node,
201 202
				       &eb->buckets[handle & eb->and]);
		}
203
		++i;
204 205
	}

206
	return 0;
207 208


209
err:
210 211 212 213 214
	while (!list_empty(&objects)) {
		obj = list_first_entry(&objects,
				       struct drm_i915_gem_object,
				       obj_exec_link);
		list_del_init(&obj->obj_exec_link);
215
		i915_gem_object_put(obj);
216
	}
217 218 219 220 221
	/*
	 * Objects already transfered to the vmas list will be unreferenced by
	 * eb_destroy.
	 */

222
	return ret;
223 224
}

225
static struct i915_vma *eb_get_vma(struct eb_vmas *eb, unsigned long handle)
226
{
227 228 229 230 231 232
	if (eb->and < 0) {
		if (handle >= -eb->and)
			return NULL;
		return eb->lut[handle];
	} else {
		struct hlist_head *head;
233
		struct i915_vma *vma;
234

235
		head = &eb->buckets[handle & eb->and];
236
		hlist_for_each_entry(vma, head, exec_node) {
237 238
			if (vma->exec_handle == handle)
				return vma;
239 240 241
		}
		return NULL;
	}
242 243
}

244 245 246 247 248 249 250 251 252 253 254 255 256 257 258
static void
i915_gem_execbuffer_unreserve_vma(struct i915_vma *vma)
{
	struct drm_i915_gem_exec_object2 *entry;
	struct drm_i915_gem_object *obj = vma->obj;

	if (!drm_mm_node_allocated(&vma->node))
		return;

	entry = vma->exec_entry;

	if (entry->flags & __EXEC_OBJECT_HAS_FENCE)
		i915_gem_object_unpin_fence(obj);

	if (entry->flags & __EXEC_OBJECT_HAS_PIN)
259
		__i915_vma_unpin(vma);
260

C
Chris Wilson 已提交
261
	entry->flags &= ~(__EXEC_OBJECT_HAS_FENCE | __EXEC_OBJECT_HAS_PIN);
262 263 264 265
}

static void eb_destroy(struct eb_vmas *eb)
{
266 267
	while (!list_empty(&eb->vmas)) {
		struct i915_vma *vma;
268

269 270
		vma = list_first_entry(&eb->vmas,
				       struct i915_vma,
271
				       exec_list);
272
		list_del_init(&vma->exec_list);
273
		i915_gem_execbuffer_unreserve_vma(vma);
274
		i915_vma_put(vma);
275
	}
276 277 278
	kfree(eb);
}

279 280
static inline int use_cpu_reloc(struct drm_i915_gem_object *obj)
{
281 282
	return (HAS_LLC(obj->base.dev) ||
		obj->base.write_domain == I915_GEM_DOMAIN_CPU ||
283 284 285
		obj->cache_level != I915_CACHE_NONE);
}

286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310
/* Used to convert any address to canonical form.
 * Starting from gen8, some commands (e.g. STATE_BASE_ADDRESS,
 * MI_LOAD_REGISTER_MEM and others, see Broadwell PRM Vol2a) require the
 * addresses to be in a canonical form:
 * "GraphicsAddress[63:48] are ignored by the HW and assumed to be in correct
 * canonical form [63:48] == [47]."
 */
#define GEN8_HIGH_ADDRESS_BIT 47
static inline uint64_t gen8_canonical_addr(uint64_t address)
{
	return sign_extend64(address, GEN8_HIGH_ADDRESS_BIT);
}

static inline uint64_t gen8_noncanonical_addr(uint64_t address)
{
	return address & ((1ULL << (GEN8_HIGH_ADDRESS_BIT + 1)) - 1);
}

static inline uint64_t
relocation_target(struct drm_i915_gem_relocation_entry *reloc,
		  uint64_t target_offset)
{
	return gen8_canonical_addr((int)reloc->delta + target_offset);
}

311 312
static int
relocate_entry_cpu(struct drm_i915_gem_object *obj,
B
Ben Widawsky 已提交
313 314
		   struct drm_i915_gem_relocation_entry *reloc,
		   uint64_t target_offset)
315
{
316
	struct drm_device *dev = obj->base.dev;
317
	uint32_t page_offset = offset_in_page(reloc->offset);
318
	uint64_t delta = relocation_target(reloc, target_offset);
319
	char *vaddr;
320
	int ret;
321

322
	ret = i915_gem_object_set_to_cpu_domain(obj, true);
323 324 325
	if (ret)
		return ret;

326
	vaddr = kmap_atomic(i915_gem_object_get_dirty_page(obj,
327
				reloc->offset >> PAGE_SHIFT));
B
Ben Widawsky 已提交
328
	*(uint32_t *)(vaddr + page_offset) = lower_32_bits(delta);
329 330 331 332 333 334

	if (INTEL_INFO(dev)->gen >= 8) {
		page_offset = offset_in_page(page_offset + sizeof(uint32_t));

		if (page_offset == 0) {
			kunmap_atomic(vaddr);
335
			vaddr = kmap_atomic(i915_gem_object_get_dirty_page(obj,
336 337 338
			    (reloc->offset + sizeof(uint32_t)) >> PAGE_SHIFT));
		}

B
Ben Widawsky 已提交
339
		*(uint32_t *)(vaddr + page_offset) = upper_32_bits(delta);
340 341
	}

342 343 344 345 346 347 348
	kunmap_atomic(vaddr);

	return 0;
}

static int
relocate_entry_gtt(struct drm_i915_gem_object *obj,
B
Ben Widawsky 已提交
349 350
		   struct drm_i915_gem_relocation_entry *reloc,
		   uint64_t target_offset)
351
{
C
Chris Wilson 已提交
352
	struct drm_i915_private *dev_priv = to_i915(obj->base.dev);
353
	struct i915_ggtt *ggtt = &dev_priv->ggtt;
C
Chris Wilson 已提交
354
	struct i915_vma *vma;
355
	uint64_t delta = relocation_target(reloc, target_offset);
356
	uint64_t offset;
357
	void __iomem *reloc_page;
358
	int ret;
359

C
Chris Wilson 已提交
360 361 362 363
	vma = i915_gem_object_ggtt_pin(obj, NULL, 0, 0, PIN_MAPPABLE);
	if (IS_ERR(vma))
		return PTR_ERR(vma);

364 365
	ret = i915_gem_object_set_to_gtt_domain(obj, true);
	if (ret)
C
Chris Wilson 已提交
366
		goto unpin;
367 368 369

	ret = i915_gem_object_put_fence(obj);
	if (ret)
C
Chris Wilson 已提交
370
		goto unpin;
371 372

	/* Map the page containing the relocation we're going to perform.  */
C
Chris Wilson 已提交
373
	offset = vma->node.start + reloc->offset;
374
	reloc_page = io_mapping_map_atomic_wc(ggtt->mappable,
375 376
					      offset & PAGE_MASK);
	iowrite32(lower_32_bits(delta), reloc_page + offset_in_page(offset));
377

C
Chris Wilson 已提交
378
	if (INTEL_GEN(dev_priv) >= 8) {
379
		offset += sizeof(uint32_t);
380

381
		if (offset_in_page(offset) == 0) {
382
			io_mapping_unmap_atomic(reloc_page);
383
			reloc_page =
384
				io_mapping_map_atomic_wc(ggtt->mappable,
385
							 offset);
386 387
		}

388 389
		iowrite32(upper_32_bits(delta),
			  reloc_page + offset_in_page(offset));
390 391
	}

392 393
	io_mapping_unmap_atomic(reloc_page);

C
Chris Wilson 已提交
394 395 396
unpin:
	i915_vma_unpin(vma);
	return ret;
397 398
}

399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414
static void
clflush_write32(void *addr, uint32_t value)
{
	/* This is not a fast path, so KISS. */
	drm_clflush_virt_range(addr, sizeof(uint32_t));
	*(uint32_t *)addr = value;
	drm_clflush_virt_range(addr, sizeof(uint32_t));
}

static int
relocate_entry_clflush(struct drm_i915_gem_object *obj,
		       struct drm_i915_gem_relocation_entry *reloc,
		       uint64_t target_offset)
{
	struct drm_device *dev = obj->base.dev;
	uint32_t page_offset = offset_in_page(reloc->offset);
415
	uint64_t delta = relocation_target(reloc, target_offset);
416 417 418 419 420 421 422
	char *vaddr;
	int ret;

	ret = i915_gem_object_set_to_gtt_domain(obj, true);
	if (ret)
		return ret;

423
	vaddr = kmap_atomic(i915_gem_object_get_dirty_page(obj,
424 425 426 427 428 429 430 431
				reloc->offset >> PAGE_SHIFT));
	clflush_write32(vaddr + page_offset, lower_32_bits(delta));

	if (INTEL_INFO(dev)->gen >= 8) {
		page_offset = offset_in_page(page_offset + sizeof(uint32_t));

		if (page_offset == 0) {
			kunmap_atomic(vaddr);
432
			vaddr = kmap_atomic(i915_gem_object_get_dirty_page(obj,
433 434 435 436 437 438 439 440 441 442 443
			    (reloc->offset + sizeof(uint32_t)) >> PAGE_SHIFT));
		}

		clflush_write32(vaddr + page_offset, upper_32_bits(delta));
	}

	kunmap_atomic(vaddr);

	return 0;
}

444 445
static bool object_is_idle(struct drm_i915_gem_object *obj)
{
446
	unsigned long active = i915_gem_object_get_active(obj);
447 448 449 450 451 452 453 454 455 456 457
	int idx;

	for_each_active(active, idx) {
		if (!i915_gem_active_is_idle(&obj->last_read[idx],
					     &obj->base.dev->struct_mutex))
			return false;
	}

	return true;
}

458 459
static int
i915_gem_execbuffer_relocate_entry(struct drm_i915_gem_object *obj,
460
				   struct eb_vmas *eb,
461
				   struct drm_i915_gem_relocation_entry *reloc)
462 463 464
{
	struct drm_device *dev = obj->base.dev;
	struct drm_gem_object *target_obj;
465
	struct drm_i915_gem_object *target_i915_obj;
466
	struct i915_vma *target_vma;
B
Ben Widawsky 已提交
467
	uint64_t target_offset;
468
	int ret;
469

470
	/* we've already hold a reference to all valid objects */
471 472
	target_vma = eb_get_vma(eb, reloc->target_handle);
	if (unlikely(target_vma == NULL))
473
		return -ENOENT;
474 475
	target_i915_obj = target_vma->obj;
	target_obj = &target_vma->obj->base;
476

477
	target_offset = gen8_canonical_addr(target_vma->node.start);
478

479 480 481 482
	/* Sandybridge PPGTT errata: We need a global gtt mapping for MI and
	 * pipe_control writes because the gpu doesn't properly redirect them
	 * through the ppgtt for non_secure batchbuffers. */
	if (unlikely(IS_GEN6(dev) &&
483
	    reloc->write_domain == I915_GEM_DOMAIN_INSTRUCTION)) {
484
		ret = i915_vma_bind(target_vma, target_i915_obj->cache_level,
485
				    PIN_GLOBAL);
486 487 488
		if (WARN_ONCE(ret, "Unexpected failure to bind target VMA!"))
			return ret;
	}
489

490
	/* Validate that the target is in a valid r/w GPU domain */
491
	if (unlikely(reloc->write_domain & (reloc->write_domain - 1))) {
492
		DRM_DEBUG("reloc with multiple write domains: "
493 494 495 496 497 498
			  "obj %p target %d offset %d "
			  "read %08x write %08x",
			  obj, reloc->target_handle,
			  (int) reloc->offset,
			  reloc->read_domains,
			  reloc->write_domain);
499
		return -EINVAL;
500
	}
501 502
	if (unlikely((reloc->write_domain | reloc->read_domains)
		     & ~I915_GEM_GPU_DOMAINS)) {
503
		DRM_DEBUG("reloc with read/write non-GPU domains: "
504 505 506 507 508 509
			  "obj %p target %d offset %d "
			  "read %08x write %08x",
			  obj, reloc->target_handle,
			  (int) reloc->offset,
			  reloc->read_domains,
			  reloc->write_domain);
510
		return -EINVAL;
511 512 513 514 515 516 517 518 519
	}

	target_obj->pending_read_domains |= reloc->read_domains;
	target_obj->pending_write_domain |= reloc->write_domain;

	/* If the relocation already has the right value in it, no
	 * more work needs to be done.
	 */
	if (target_offset == reloc->presumed_offset)
520
		return 0;
521 522

	/* Check that the relocation address is valid... */
523 524
	if (unlikely(reloc->offset >
		obj->base.size - (INTEL_INFO(dev)->gen >= 8 ? 8 : 4))) {
525
		DRM_DEBUG("Relocation beyond object bounds: "
526 527 528 529
			  "obj %p target %d offset %d size %d.\n",
			  obj, reloc->target_handle,
			  (int) reloc->offset,
			  (int) obj->base.size);
530
		return -EINVAL;
531
	}
532
	if (unlikely(reloc->offset & 3)) {
533
		DRM_DEBUG("Relocation not 4-byte aligned: "
534 535 536
			  "obj %p target %d offset %d.\n",
			  obj, reloc->target_handle,
			  (int) reloc->offset);
537
		return -EINVAL;
538 539
	}

540
	/* We can't wait for rendering with pagefaults disabled */
541
	if (pagefault_disabled() && !object_is_idle(obj))
542 543
		return -EFAULT;

544
	if (use_cpu_reloc(obj))
B
Ben Widawsky 已提交
545
		ret = relocate_entry_cpu(obj, reloc, target_offset);
546
	else if (obj->map_and_fenceable)
B
Ben Widawsky 已提交
547
		ret = relocate_entry_gtt(obj, reloc, target_offset);
548
	else if (static_cpu_has(X86_FEATURE_CLFLUSH))
549 550 551 552 553
		ret = relocate_entry_clflush(obj, reloc, target_offset);
	else {
		WARN_ONCE(1, "Impossible case in relocation handling\n");
		ret = -ENODEV;
	}
554

555 556 557
	if (ret)
		return ret;

558 559 560
	/* and update the user's relocation entry */
	reloc->presumed_offset = target_offset;

561
	return 0;
562 563 564
}

static int
565 566
i915_gem_execbuffer_relocate_vma(struct i915_vma *vma,
				 struct eb_vmas *eb)
567
{
568 569
#define N_RELOC(x) ((x) / sizeof(struct drm_i915_gem_relocation_entry))
	struct drm_i915_gem_relocation_entry stack_reloc[N_RELOC(512)];
570
	struct drm_i915_gem_relocation_entry __user *user_relocs;
571
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
572
	int remain, ret;
573

574
	user_relocs = u64_to_user_ptr(entry->relocs_ptr);
575

576 577 578 579 580 581 582 583 584
	remain = entry->relocation_count;
	while (remain) {
		struct drm_i915_gem_relocation_entry *r = stack_reloc;
		int count = remain;
		if (count > ARRAY_SIZE(stack_reloc))
			count = ARRAY_SIZE(stack_reloc);
		remain -= count;

		if (__copy_from_user_inatomic(r, user_relocs, count*sizeof(r[0])))
585 586
			return -EFAULT;

587 588
		do {
			u64 offset = r->presumed_offset;
589

590
			ret = i915_gem_execbuffer_relocate_entry(vma->obj, eb, r);
591 592 593 594
			if (ret)
				return ret;

			if (r->presumed_offset != offset &&
595
			    __put_user(r->presumed_offset, &user_relocs->presumed_offset)) {
596 597 598 599 600 601
				return -EFAULT;
			}

			user_relocs++;
			r++;
		} while (--count);
602 603 604
	}

	return 0;
605
#undef N_RELOC
606 607 608
}

static int
609 610 611
i915_gem_execbuffer_relocate_vma_slow(struct i915_vma *vma,
				      struct eb_vmas *eb,
				      struct drm_i915_gem_relocation_entry *relocs)
612
{
613
	const struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
614 615 616
	int i, ret;

	for (i = 0; i < entry->relocation_count; i++) {
617
		ret = i915_gem_execbuffer_relocate_entry(vma->obj, eb, &relocs[i]);
618 619 620 621 622 623 624 625
		if (ret)
			return ret;
	}

	return 0;
}

static int
B
Ben Widawsky 已提交
626
i915_gem_execbuffer_relocate(struct eb_vmas *eb)
627
{
628
	struct i915_vma *vma;
629 630 631 632 633 634 635 636 637 638
	int ret = 0;

	/* This is the fast path and we cannot handle a pagefault whilst
	 * holding the struct mutex lest the user pass in the relocations
	 * contained within a mmaped bo. For in such a case we, the page
	 * fault handler would call i915_gem_fault() and we would try to
	 * acquire the struct mutex again. Obviously this is bad and so
	 * lockdep complains vehemently.
	 */
	pagefault_disable();
639 640
	list_for_each_entry(vma, &eb->vmas, exec_list) {
		ret = i915_gem_execbuffer_relocate_vma(vma, eb);
641
		if (ret)
642
			break;
643
	}
644
	pagefault_enable();
645

646
	return ret;
647 648
}

649 650 651 652 653 654
static bool only_mappable_for_reloc(unsigned int flags)
{
	return (flags & (EXEC_OBJECT_NEEDS_FENCE | __EXEC_OBJECT_NEEDS_MAP)) ==
		__EXEC_OBJECT_NEEDS_MAP;
}

655
static int
656
i915_gem_execbuffer_reserve_vma(struct i915_vma *vma,
657
				struct intel_engine_cs *engine,
658
				bool *need_reloc)
659
{
660
	struct drm_i915_gem_object *obj = vma->obj;
661
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
662
	uint64_t flags;
663 664
	int ret;

665
	flags = PIN_USER;
666 667 668
	if (entry->flags & EXEC_OBJECT_NEEDS_GTT)
		flags |= PIN_GLOBAL;

669
	if (!drm_mm_node_allocated(&vma->node)) {
670 671 672 673 674
		/* Wa32bitGeneralStateOffset & Wa32bitInstructionBaseOffset,
		 * limit address to the first 4GBs for unflagged objects.
		 */
		if ((entry->flags & EXEC_OBJECT_SUPPORTS_48B_ADDRESS) == 0)
			flags |= PIN_ZONE_4G;
675 676 677 678
		if (entry->flags & __EXEC_OBJECT_NEEDS_MAP)
			flags |= PIN_GLOBAL | PIN_MAPPABLE;
		if (entry->flags & __EXEC_OBJECT_NEEDS_BIAS)
			flags |= BATCH_OFFSET_BIAS | PIN_OFFSET_BIAS;
679 680
		if (entry->flags & EXEC_OBJECT_PINNED)
			flags |= entry->offset | PIN_OFFSET_FIXED;
681 682
		if ((flags & PIN_MAPPABLE) == 0)
			flags |= PIN_HIGH;
683
	}
684

685 686 687 688 689
	ret = i915_vma_pin(vma,
			   entry->pad_to_size,
			   entry->alignment,
			   flags);
	if ((ret == -ENOSPC || ret == -E2BIG) &&
690
	    only_mappable_for_reloc(entry->flags))
691 692 693 694
		ret = i915_vma_pin(vma,
				   entry->pad_to_size,
				   entry->alignment,
				   flags & ~PIN_MAPPABLE);
695 696 697
	if (ret)
		return ret;

698 699
	entry->flags |= __EXEC_OBJECT_HAS_PIN;

700 701 702 703
	if (entry->flags & EXEC_OBJECT_NEEDS_FENCE) {
		ret = i915_gem_object_get_fence(obj);
		if (ret)
			return ret;
704

705 706
		if (i915_gem_object_pin_fence(obj))
			entry->flags |= __EXEC_OBJECT_HAS_FENCE;
707 708
	}

709 710
	if (entry->offset != vma->node.start) {
		entry->offset = vma->node.start;
711 712 713 714 715 716 717 718
		*need_reloc = true;
	}

	if (entry->flags & EXEC_OBJECT_WRITE) {
		obj->base.pending_read_domains = I915_GEM_DOMAIN_RENDER;
		obj->base.pending_write_domain = I915_GEM_DOMAIN_RENDER;
	}

719
	return 0;
720
}
721

722
static bool
723
need_reloc_mappable(struct i915_vma *vma)
724 725 726
{
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;

727 728 729
	if (entry->relocation_count == 0)
		return false;

730
	if (!i915_vma_is_ggtt(vma))
731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747
		return false;

	/* See also use_cpu_reloc() */
	if (HAS_LLC(vma->obj->base.dev))
		return false;

	if (vma->obj->base.write_domain == I915_GEM_DOMAIN_CPU)
		return false;

	return true;
}

static bool
eb_vma_misplaced(struct i915_vma *vma)
{
	struct drm_i915_gem_exec_object2 *entry = vma->exec_entry;
	struct drm_i915_gem_object *obj = vma->obj;
748

749 750
	WARN_ON(entry->flags & __EXEC_OBJECT_NEEDS_MAP &&
		!i915_vma_is_ggtt(vma));
751 752 753 754 755

	if (entry->alignment &&
	    vma->node.start & (entry->alignment - 1))
		return true;

756 757 758
	if (vma->node.size < entry->pad_to_size)
		return true;

759 760 761 762
	if (entry->flags & EXEC_OBJECT_PINNED &&
	    vma->node.start != entry->offset)
		return true;

763 764 765 766
	if (entry->flags & __EXEC_OBJECT_NEEDS_BIAS &&
	    vma->node.start < BATCH_OFFSET_BIAS)
		return true;

767 768 769 770
	/* avoid costly ping-pong once a batch bo ended up non-mappable */
	if (entry->flags & __EXEC_OBJECT_NEEDS_MAP && !obj->map_and_fenceable)
		return !only_mappable_for_reloc(entry->flags);

771 772 773 774
	if ((entry->flags & EXEC_OBJECT_SUPPORTS_48B_ADDRESS) == 0 &&
	    (vma->node.start + vma->node.size - 1) >> 32)
		return true;

775 776 777
	return false;
}

778
static int
779
i915_gem_execbuffer_reserve(struct intel_engine_cs *engine,
780
			    struct list_head *vmas,
781
			    struct i915_gem_context *ctx,
782
			    bool *need_relocs)
783
{
784
	struct drm_i915_gem_object *obj;
785
	struct i915_vma *vma;
786
	struct i915_address_space *vm;
787
	struct list_head ordered_vmas;
788
	struct list_head pinned_vmas;
789
	bool has_fenced_gpu_access = INTEL_GEN(engine->i915) < 4;
790
	int retry;
791

792 793
	vm = list_first_entry(vmas, struct i915_vma, exec_list)->vm;

794
	INIT_LIST_HEAD(&ordered_vmas);
795
	INIT_LIST_HEAD(&pinned_vmas);
796
	while (!list_empty(vmas)) {
797 798 799
		struct drm_i915_gem_exec_object2 *entry;
		bool need_fence, need_mappable;

800 801 802
		vma = list_first_entry(vmas, struct i915_vma, exec_list);
		obj = vma->obj;
		entry = vma->exec_entry;
803

804 805 806
		if (ctx->flags & CONTEXT_NO_ZEROMAP)
			entry->flags |= __EXEC_OBJECT_NEEDS_BIAS;

807 808
		if (!has_fenced_gpu_access)
			entry->flags &= ~EXEC_OBJECT_NEEDS_FENCE;
809 810
		need_fence =
			entry->flags & EXEC_OBJECT_NEEDS_FENCE &&
811
			i915_gem_object_is_tiled(obj);
812
		need_mappable = need_fence || need_reloc_mappable(vma);
813

814 815 816
		if (entry->flags & EXEC_OBJECT_PINNED)
			list_move_tail(&vma->exec_list, &pinned_vmas);
		else if (need_mappable) {
817
			entry->flags |= __EXEC_OBJECT_NEEDS_MAP;
818
			list_move(&vma->exec_list, &ordered_vmas);
819
		} else
820
			list_move_tail(&vma->exec_list, &ordered_vmas);
821

822
		obj->base.pending_read_domains = I915_GEM_GPU_DOMAINS & ~I915_GEM_DOMAIN_COMMAND;
823
		obj->base.pending_write_domain = 0;
824
	}
825
	list_splice(&ordered_vmas, vmas);
826
	list_splice(&pinned_vmas, vmas);
827 828 829 830 831 832 833 834 835 836

	/* Attempt to pin all of the buffers into the GTT.
	 * This is done in 3 phases:
	 *
	 * 1a. Unbind all objects that do not match the GTT constraints for
	 *     the execbuffer (fenceable, mappable, alignment etc).
	 * 1b. Increment pin count for already bound objects.
	 * 2.  Bind new objects.
	 * 3.  Decrement pin count.
	 *
837
	 * This avoid unnecessary unbinding of later objects in order to make
838 839 840 841
	 * room for the earlier objects *unless* we need to defragment.
	 */
	retry = 0;
	do {
842
		int ret = 0;
843 844

		/* Unbind any ill-fitting objects or pin. */
845 846
		list_for_each_entry(vma, vmas, exec_list) {
			if (!drm_mm_node_allocated(&vma->node))
847 848
				continue;

849
			if (eb_vma_misplaced(vma))
850
				ret = i915_vma_unbind(vma);
851
			else
852 853 854
				ret = i915_gem_execbuffer_reserve_vma(vma,
								      engine,
								      need_relocs);
855
			if (ret)
856 857 858 859
				goto err;
		}

		/* Bind fresh objects */
860 861
		list_for_each_entry(vma, vmas, exec_list) {
			if (drm_mm_node_allocated(&vma->node))
862
				continue;
863

864 865
			ret = i915_gem_execbuffer_reserve_vma(vma, engine,
							      need_relocs);
866 867
			if (ret)
				goto err;
868 869
		}

870
err:
C
Chris Wilson 已提交
871
		if (ret != -ENOSPC || retry++)
872 873
			return ret;

874 875 876 877
		/* Decrement pin count for bound objects */
		list_for_each_entry(vma, vmas, exec_list)
			i915_gem_execbuffer_unreserve_vma(vma);

878
		ret = i915_gem_evict_vm(vm, true);
879 880 881 882 883 884 885
		if (ret)
			return ret;
	} while (1);
}

static int
i915_gem_execbuffer_relocate_slow(struct drm_device *dev,
886
				  struct drm_i915_gem_execbuffer2 *args,
887
				  struct drm_file *file,
888
				  struct intel_engine_cs *engine,
889
				  struct eb_vmas *eb,
890
				  struct drm_i915_gem_exec_object2 *exec,
891
				  struct i915_gem_context *ctx)
892 893
{
	struct drm_i915_gem_relocation_entry *reloc;
894 895
	struct i915_address_space *vm;
	struct i915_vma *vma;
896
	bool need_relocs;
897
	int *reloc_offset;
898
	int i, total, ret;
899
	unsigned count = args->buffer_count;
900

901 902
	vm = list_first_entry(&eb->vmas, struct i915_vma, exec_list)->vm;

903
	/* We may process another execbuffer during the unlock... */
904 905 906
	while (!list_empty(&eb->vmas)) {
		vma = list_first_entry(&eb->vmas, struct i915_vma, exec_list);
		list_del_init(&vma->exec_list);
907
		i915_gem_execbuffer_unreserve_vma(vma);
908
		i915_vma_put(vma);
909 910
	}

911 912 913 914
	mutex_unlock(&dev->struct_mutex);

	total = 0;
	for (i = 0; i < count; i++)
915
		total += exec[i].relocation_count;
916

917
	reloc_offset = drm_malloc_ab(count, sizeof(*reloc_offset));
918
	reloc = drm_malloc_ab(total, sizeof(*reloc));
919 920 921
	if (reloc == NULL || reloc_offset == NULL) {
		drm_free_large(reloc);
		drm_free_large(reloc_offset);
922 923 924 925 926 927 928
		mutex_lock(&dev->struct_mutex);
		return -ENOMEM;
	}

	total = 0;
	for (i = 0; i < count; i++) {
		struct drm_i915_gem_relocation_entry __user *user_relocs;
929 930
		u64 invalid_offset = (u64)-1;
		int j;
931

932
		user_relocs = u64_to_user_ptr(exec[i].relocs_ptr);
933 934

		if (copy_from_user(reloc+total, user_relocs,
935
				   exec[i].relocation_count * sizeof(*reloc))) {
936 937 938 939 940
			ret = -EFAULT;
			mutex_lock(&dev->struct_mutex);
			goto err;
		}

941 942 943 944 945 946 947 948 949 950
		/* As we do not update the known relocation offsets after
		 * relocating (due to the complexities in lock handling),
		 * we need to mark them as invalid now so that we force the
		 * relocation processing next time. Just in case the target
		 * object is evicted and then rebound into its old
		 * presumed_offset before the next execbuffer - if that
		 * happened we would make the mistake of assuming that the
		 * relocations were valid.
		 */
		for (j = 0; j < exec[i].relocation_count; j++) {
951 952 953
			if (__copy_to_user(&user_relocs[j].presumed_offset,
					   &invalid_offset,
					   sizeof(invalid_offset))) {
954 955 956 957 958 959
				ret = -EFAULT;
				mutex_lock(&dev->struct_mutex);
				goto err;
			}
		}

960
		reloc_offset[i] = total;
961
		total += exec[i].relocation_count;
962 963 964 965 966 967 968 969
	}

	ret = i915_mutex_lock_interruptible(dev);
	if (ret) {
		mutex_lock(&dev->struct_mutex);
		goto err;
	}

970 971
	/* reacquire the objects */
	eb_reset(eb);
972
	ret = eb_lookup_vmas(eb, exec, args, vm, file);
973 974
	if (ret)
		goto err;
975

976
	need_relocs = (args->flags & I915_EXEC_NO_RELOC) == 0;
977 978
	ret = i915_gem_execbuffer_reserve(engine, &eb->vmas, ctx,
					  &need_relocs);
979 980 981
	if (ret)
		goto err;

982 983 984 985
	list_for_each_entry(vma, &eb->vmas, exec_list) {
		int offset = vma->exec_entry - exec;
		ret = i915_gem_execbuffer_relocate_vma_slow(vma, eb,
							    reloc + reloc_offset[offset]);
986 987 988 989 990 991 992 993 994 995 996 997
		if (ret)
			goto err;
	}

	/* Leave the user relocations as are, this is the painfully slow path,
	 * and we want to avoid the complication of dropping the lock whilst
	 * having buffers reserved in the aperture and so causing spurious
	 * ENOSPC for random operations.
	 */

err:
	drm_free_large(reloc);
998
	drm_free_large(reloc_offset);
999 1000 1001
	return ret;
}

1002 1003 1004 1005 1006 1007 1008 1009 1010 1011
static unsigned int eb_other_engines(struct drm_i915_gem_request *req)
{
	unsigned int mask;

	mask = ~intel_engine_flag(req->engine) & I915_BO_ACTIVE_MASK;
	mask <<= I915_BO_ACTIVE_SHIFT;

	return mask;
}

1012
static int
1013
i915_gem_execbuffer_move_to_gpu(struct drm_i915_gem_request *req,
1014
				struct list_head *vmas)
1015
{
1016
	const unsigned int other_rings = eb_other_engines(req);
1017
	struct i915_vma *vma;
1018
	uint32_t flush_domains = 0;
1019
	bool flush_chipset = false;
1020
	int ret;
1021

1022 1023
	list_for_each_entry(vma, vmas, exec_list) {
		struct drm_i915_gem_object *obj = vma->obj;
1024

1025
		if (obj->flags & other_rings) {
1026
			ret = i915_gem_object_sync(obj, req);
1027 1028 1029
			if (ret)
				return ret;
		}
1030 1031

		if (obj->base.write_domain & I915_GEM_DOMAIN_CPU)
1032
			flush_chipset |= i915_gem_clflush_object(obj, false);
1033 1034

		flush_domains |= obj->base.write_domain;
1035 1036
	}

1037
	if (flush_chipset)
1038
		i915_gem_chipset_flush(req->engine->i915);
1039 1040 1041 1042

	if (flush_domains & I915_GEM_DOMAIN_GTT)
		wmb();

1043
	/* Unconditionally invalidate GPU caches and TLBs. */
1044
	return req->engine->emit_flush(req, EMIT_INVALIDATE);
1045 1046
}

1047 1048
static bool
i915_gem_check_execbuffer(struct drm_i915_gem_execbuffer2 *exec)
1049
{
1050 1051 1052
	if (exec->flags & __I915_EXEC_UNKNOWN_FLAGS)
		return false;

C
Chris Wilson 已提交
1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067
	/* Kernel clipping was a DRI1 misfeature */
	if (exec->num_cliprects || exec->cliprects_ptr)
		return false;

	if (exec->DR4 == 0xffffffff) {
		DRM_DEBUG("UXA submitting garbage DR4, fixing up\n");
		exec->DR4 = 0;
	}
	if (exec->DR1 || exec->DR4)
		return false;

	if ((exec->batch_start_offset | exec->batch_len) & 0x7)
		return false;

	return true;
1068 1069 1070
}

static int
1071 1072
validate_exec_list(struct drm_device *dev,
		   struct drm_i915_gem_exec_object2 *exec,
1073 1074
		   int count)
{
1075 1076
	unsigned relocs_total = 0;
	unsigned relocs_max = UINT_MAX / sizeof(struct drm_i915_gem_relocation_entry);
1077 1078 1079
	unsigned invalid_flags;
	int i;

1080 1081 1082
	/* INTERNAL flags must not overlap with external ones */
	BUILD_BUG_ON(__EXEC_OBJECT_INTERNAL_FLAGS & ~__EXEC_OBJECT_UNKNOWN_FLAGS);

1083 1084 1085
	invalid_flags = __EXEC_OBJECT_UNKNOWN_FLAGS;
	if (USES_FULL_PPGTT(dev))
		invalid_flags |= EXEC_OBJECT_NEEDS_GTT;
1086 1087

	for (i = 0; i < count; i++) {
1088
		char __user *ptr = u64_to_user_ptr(exec[i].relocs_ptr);
1089 1090
		int length; /* limited by fault_in_pages_readable() */

1091
		if (exec[i].flags & invalid_flags)
1092 1093
			return -EINVAL;

1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108
		/* Offset can be used as input (EXEC_OBJECT_PINNED), reject
		 * any non-page-aligned or non-canonical addresses.
		 */
		if (exec[i].flags & EXEC_OBJECT_PINNED) {
			if (exec[i].offset !=
			    gen8_canonical_addr(exec[i].offset & PAGE_MASK))
				return -EINVAL;

			/* From drm_mm perspective address space is continuous,
			 * so from this point we're always using non-canonical
			 * form internally.
			 */
			exec[i].offset = gen8_noncanonical_addr(exec[i].offset);
		}

1109 1110 1111
		if (exec[i].alignment && !is_power_of_2(exec[i].alignment))
			return -EINVAL;

1112 1113 1114 1115 1116 1117 1118 1119
		/* pad_to_size was once a reserved field, so sanitize it */
		if (exec[i].flags & EXEC_OBJECT_PAD_TO_SIZE) {
			if (offset_in_page(exec[i].pad_to_size))
				return -EINVAL;
		} else {
			exec[i].pad_to_size = 0;
		}

1120 1121 1122 1123 1124
		/* First check for malicious input causing overflow in
		 * the worst case where we need to allocate the entire
		 * relocation tree as a single array.
		 */
		if (exec[i].relocation_count > relocs_max - relocs_total)
1125
			return -EINVAL;
1126
		relocs_total += exec[i].relocation_count;
1127 1128 1129

		length = exec[i].relocation_count *
			sizeof(struct drm_i915_gem_relocation_entry);
1130 1131 1132 1133 1134
		/*
		 * We must check that the entire relocation array is safe
		 * to read, but since we may need to update the presumed
		 * offsets during execution, check for full write access.
		 */
1135 1136 1137
		if (!access_ok(VERIFY_WRITE, ptr, length))
			return -EFAULT;

1138
		if (likely(!i915.prefault_disable)) {
1139 1140 1141
			if (fault_in_multipages_readable(ptr, length))
				return -EFAULT;
		}
1142 1143 1144 1145 1146
	}

	return 0;
}

1147
static struct i915_gem_context *
1148
i915_gem_validate_context(struct drm_device *dev, struct drm_file *file,
1149
			  struct intel_engine_cs *engine, const u32 ctx_id)
1150
{
1151
	struct i915_gem_context *ctx = NULL;
1152 1153
	struct i915_ctx_hang_stats *hs;

1154
	if (engine->id != RCS && ctx_id != DEFAULT_CONTEXT_HANDLE)
1155 1156
		return ERR_PTR(-EINVAL);

1157
	ctx = i915_gem_context_lookup(file->driver_priv, ctx_id);
1158
	if (IS_ERR(ctx))
1159
		return ctx;
1160

1161
	hs = &ctx->hang_stats;
1162 1163
	if (hs->banned) {
		DRM_DEBUG("Context %u tried to submit while banned\n", ctx_id);
1164
		return ERR_PTR(-EIO);
1165 1166
	}

1167
	return ctx;
1168 1169
}

1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180
void i915_vma_move_to_active(struct i915_vma *vma,
			     struct drm_i915_gem_request *req,
			     unsigned int flags)
{
	struct drm_i915_gem_object *obj = vma->obj;
	const unsigned int idx = req->engine->id;

	GEM_BUG_ON(!drm_mm_node_allocated(&vma->node));

	obj->dirty = 1; /* be paranoid  */

1181 1182 1183 1184 1185 1186 1187
	/* Add a reference if we're newly entering the active list.
	 * The order in which we add operations to the retirement queue is
	 * vital here: mark_active adds to the start of the callback list,
	 * such that subsequent callbacks are called first. Therefore we
	 * add the active reference first and queue for it to be dropped
	 * *last*.
	 */
1188
	if (!i915_gem_object_is_active(obj))
1189
		i915_gem_object_get(obj);
1190
	i915_gem_object_set_active(obj, idx);
1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211
	i915_gem_active_set(&obj->last_read[idx], req);

	if (flags & EXEC_OBJECT_WRITE) {
		i915_gem_active_set(&obj->last_write, req);

		intel_fb_obj_invalidate(obj, ORIGIN_CS);

		/* update for the implicit flush after a batch */
		obj->base.write_domain &= ~I915_GEM_GPU_DOMAINS;
	}

	if (flags & EXEC_OBJECT_NEEDS_FENCE) {
		i915_gem_active_set(&obj->last_fence, req);
		if (flags & __EXEC_OBJECT_HAS_FENCE) {
			struct drm_i915_private *dev_priv = req->i915;

			list_move_tail(&dev_priv->fence_regs[obj->fence_reg].lru_list,
				       &dev_priv->mm.fence_list);
		}
	}

1212 1213
	i915_vma_set_active(vma, idx);
	i915_gem_active_set(&vma->last_read[idx], req);
1214 1215 1216
	list_move_tail(&vma->vm_link, &vma->vm->active_list);
}

1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238
static void eb_export_fence(struct drm_i915_gem_object *obj,
			    struct drm_i915_gem_request *req,
			    unsigned int flags)
{
	struct reservation_object *resv;

	resv = i915_gem_object_get_dmabuf_resv(obj);
	if (!resv)
		return;

	/* Ignore errors from failing to allocate the new fence, we can't
	 * handle an error right now. Worst case should be missed
	 * synchronisation leading to rendering corruption.
	 */
	ww_mutex_lock(&resv->lock, NULL);
	if (flags & EXEC_OBJECT_WRITE)
		reservation_object_add_excl_fence(resv, &req->fence);
	else if (reservation_object_reserve_shared(resv) == 0)
		reservation_object_add_shared_fence(resv, &req->fence);
	ww_mutex_unlock(&resv->lock);
}

1239
static void
1240
i915_gem_execbuffer_move_to_active(struct list_head *vmas,
1241
				   struct drm_i915_gem_request *req)
1242
{
1243
	struct i915_vma *vma;
1244

1245 1246
	list_for_each_entry(vma, vmas, exec_list) {
		struct drm_i915_gem_object *obj = vma->obj;
1247 1248
		u32 old_read = obj->base.read_domains;
		u32 old_write = obj->base.write_domain;
C
Chris Wilson 已提交
1249

1250
		obj->base.write_domain = obj->base.pending_write_domain;
1251 1252 1253
		if (obj->base.write_domain)
			vma->exec_entry->flags |= EXEC_OBJECT_WRITE;
		else
1254 1255
			obj->base.pending_read_domains |= obj->base.read_domains;
		obj->base.read_domains = obj->base.pending_read_domains;
1256

1257
		i915_vma_move_to_active(vma, req, vma->exec_entry->flags);
1258
		eb_export_fence(obj, req, vma->exec_entry->flags);
C
Chris Wilson 已提交
1259
		trace_i915_gem_object_change_domain(obj, old_read, old_write);
1260 1261 1262
	}
}

1263
static int
1264
i915_reset_gen7_sol_offsets(struct drm_i915_gem_request *req)
1265
{
1266
	struct intel_ring *ring = req->ring;
1267 1268
	int ret, i;

1269
	if (!IS_GEN7(req->i915) || req->engine->id != RCS) {
1270 1271 1272
		DRM_DEBUG("sol reset is gen7/rcs only\n");
		return -EINVAL;
	}
1273

1274
	ret = intel_ring_begin(req, 4 * 3);
1275 1276 1277 1278
	if (ret)
		return ret;

	for (i = 0; i < 4; i++) {
1279 1280 1281
		intel_ring_emit(ring, MI_LOAD_REGISTER_IMM(1));
		intel_ring_emit_reg(ring, GEN7_SO_WRITE_OFFSET(i));
		intel_ring_emit(ring, 0);
1282 1283
	}

1284
	intel_ring_advance(ring);
1285 1286 1287 1288

	return 0;
}

C
Chris Wilson 已提交
1289
static struct i915_vma *
1290
i915_gem_execbuffer_parse(struct intel_engine_cs *engine,
1291 1292
			  struct drm_i915_gem_exec_object2 *shadow_exec_entry,
			  struct drm_i915_gem_object *batch_obj,
1293
			  struct eb_vmas *eb,
1294 1295
			  u32 batch_start_offset,
			  u32 batch_len,
1296
			  bool is_master)
1297 1298
{
	struct drm_i915_gem_object *shadow_batch_obj;
1299
	struct i915_vma *vma;
1300 1301
	int ret;

1302
	shadow_batch_obj = i915_gem_batch_pool_get(&engine->batch_pool,
1303
						   PAGE_ALIGN(batch_len));
1304
	if (IS_ERR(shadow_batch_obj))
1305
		return ERR_CAST(shadow_batch_obj);
1306

1307 1308 1309 1310 1311 1312
	ret = intel_engine_cmd_parser(engine,
				      batch_obj,
				      shadow_batch_obj,
				      batch_start_offset,
				      batch_len,
				      is_master);
C
Chris Wilson 已提交
1313 1314 1315 1316 1317 1318 1319
	if (ret) {
		if (ret == -EACCES) /* unhandled chained batch */
			vma = NULL;
		else
			vma = ERR_PTR(ret);
		goto out;
	}
1320

C
Chris Wilson 已提交
1321 1322 1323
	vma = i915_gem_object_ggtt_pin(shadow_batch_obj, NULL, 0, 0, 0);
	if (IS_ERR(vma))
		goto out;
C
Chris Wilson 已提交
1324

1325
	memset(shadow_exec_entry, 0, sizeof(*shadow_exec_entry));
1326

1327
	vma->exec_entry = shadow_exec_entry;
C
Chris Wilson 已提交
1328
	vma->exec_entry->flags = __EXEC_OBJECT_HAS_PIN;
1329
	i915_gem_object_get(shadow_batch_obj);
1330
	list_add_tail(&vma->exec_list, &eb->vmas);
1331

C
Chris Wilson 已提交
1332
out:
C
Chris Wilson 已提交
1333
	i915_gem_object_unpin_pages(shadow_batch_obj);
C
Chris Wilson 已提交
1334
	return vma;
1335
}
1336

1337 1338 1339 1340
static int
execbuf_submit(struct i915_execbuffer_params *params,
	       struct drm_i915_gem_execbuffer2 *args,
	       struct list_head *vmas)
1341
{
1342
	struct drm_i915_private *dev_priv = params->request->i915;
1343
	u64 exec_start, exec_len;
1344 1345
	int instp_mode;
	u32 instp_mask;
C
Chris Wilson 已提交
1346
	int ret;
1347

1348
	ret = i915_gem_execbuffer_move_to_gpu(params->request, vmas);
1349
	if (ret)
C
Chris Wilson 已提交
1350
		return ret;
1351

1352
	ret = i915_switch_context(params->request);
1353
	if (ret)
C
Chris Wilson 已提交
1354
		return ret;
1355 1356 1357 1358 1359 1360 1361

	instp_mode = args->flags & I915_EXEC_CONSTANTS_MASK;
	instp_mask = I915_EXEC_CONSTANTS_MASK;
	switch (instp_mode) {
	case I915_EXEC_CONSTANTS_REL_GENERAL:
	case I915_EXEC_CONSTANTS_ABSOLUTE:
	case I915_EXEC_CONSTANTS_REL_SURFACE:
1362
		if (instp_mode != 0 && params->engine->id != RCS) {
1363
			DRM_DEBUG("non-0 rel constants mode on non-RCS\n");
C
Chris Wilson 已提交
1364
			return -EINVAL;
1365 1366 1367
		}

		if (instp_mode != dev_priv->relative_constants_mode) {
1368
			if (INTEL_INFO(dev_priv)->gen < 4) {
1369
				DRM_DEBUG("no rel constants on pre-gen4\n");
C
Chris Wilson 已提交
1370
				return -EINVAL;
1371 1372
			}

1373
			if (INTEL_INFO(dev_priv)->gen > 5 &&
1374 1375
			    instp_mode == I915_EXEC_CONSTANTS_REL_SURFACE) {
				DRM_DEBUG("rel surface constants mode invalid on gen5+\n");
C
Chris Wilson 已提交
1376
				return -EINVAL;
1377 1378 1379
			}

			/* The HW changed the meaning on this bit on gen6 */
1380
			if (INTEL_INFO(dev_priv)->gen >= 6)
1381 1382 1383 1384 1385
				instp_mask &= ~I915_EXEC_CONSTANTS_REL_SURFACE;
		}
		break;
	default:
		DRM_DEBUG("execbuf with unknown constants: %d\n", instp_mode);
C
Chris Wilson 已提交
1386
		return -EINVAL;
1387 1388
	}

1389
	if (params->engine->id == RCS &&
C
Chris Wilson 已提交
1390
	    instp_mode != dev_priv->relative_constants_mode) {
1391
		struct intel_ring *ring = params->request->ring;
1392

1393
		ret = intel_ring_begin(params->request, 4);
1394
		if (ret)
C
Chris Wilson 已提交
1395
			return ret;
1396

1397 1398 1399 1400 1401
		intel_ring_emit(ring, MI_NOOP);
		intel_ring_emit(ring, MI_LOAD_REGISTER_IMM(1));
		intel_ring_emit_reg(ring, INSTPM);
		intel_ring_emit(ring, instp_mask << 16 | instp_mode);
		intel_ring_advance(ring);
1402 1403 1404 1405 1406

		dev_priv->relative_constants_mode = instp_mode;
	}

	if (args->flags & I915_EXEC_GEN7_SOL_RESET) {
1407
		ret = i915_reset_gen7_sol_offsets(params->request);
1408
		if (ret)
C
Chris Wilson 已提交
1409
			return ret;
1410 1411
	}

1412
	exec_len   = args->batch_len;
1413
	exec_start = params->batch->node.start +
1414 1415
		     params->args_batch_start_offset;

1416
	if (exec_len == 0)
1417
		exec_len = params->batch->size;
1418

1419 1420 1421
	ret = params->engine->emit_bb_start(params->request,
					    exec_start, exec_len,
					    params->dispatch_flags);
C
Chris Wilson 已提交
1422 1423
	if (ret)
		return ret;
1424

1425
	trace_i915_gem_ring_dispatch(params->request, params->dispatch_flags);
1426

1427
	i915_gem_execbuffer_move_to_active(vmas, params->request);
1428

C
Chris Wilson 已提交
1429
	return 0;
1430 1431
}

1432 1433
/**
 * Find one BSD ring to dispatch the corresponding BSD command.
1434
 * The engine index is returned.
1435
 */
1436
static unsigned int
1437 1438
gen8_dispatch_bsd_engine(struct drm_i915_private *dev_priv,
			 struct drm_file *file)
1439 1440 1441
{
	struct drm_i915_file_private *file_priv = file->driver_priv;

1442
	/* Check whether the file_priv has already selected one ring. */
1443
	if ((int)file_priv->bsd_engine < 0) {
1444
		/* If not, use the ping-pong mechanism to select one. */
1445
		mutex_lock(&dev_priv->drm.struct_mutex);
1446 1447
		file_priv->bsd_engine = dev_priv->mm.bsd_engine_dispatch_index;
		dev_priv->mm.bsd_engine_dispatch_index ^= 1;
1448
		mutex_unlock(&dev_priv->drm.struct_mutex);
1449
	}
1450

1451
	return file_priv->bsd_engine;
1452 1453
}

1454 1455
#define I915_USER_RINGS (4)

1456
static const enum intel_engine_id user_ring_map[I915_USER_RINGS + 1] = {
1457 1458 1459 1460 1461 1462 1463
	[I915_EXEC_DEFAULT]	= RCS,
	[I915_EXEC_RENDER]	= RCS,
	[I915_EXEC_BLT]		= BCS,
	[I915_EXEC_BSD]		= VCS,
	[I915_EXEC_VEBOX]	= VECS
};

1464 1465 1466 1467
static struct intel_engine_cs *
eb_select_engine(struct drm_i915_private *dev_priv,
		 struct drm_file *file,
		 struct drm_i915_gem_execbuffer2 *args)
1468 1469
{
	unsigned int user_ring_id = args->flags & I915_EXEC_RING_MASK;
1470
	struct intel_engine_cs *engine;
1471 1472 1473

	if (user_ring_id > I915_USER_RINGS) {
		DRM_DEBUG("execbuf with unknown ring: %u\n", user_ring_id);
1474
		return NULL;
1475 1476 1477 1478 1479 1480
	}

	if ((user_ring_id != I915_EXEC_BSD) &&
	    ((args->flags & I915_EXEC_BSD_MASK) != 0)) {
		DRM_DEBUG("execbuf with non bsd ring but with invalid "
			  "bsd dispatch flags: %d\n", (int)(args->flags));
1481
		return NULL;
1482 1483 1484 1485 1486 1487
	}

	if (user_ring_id == I915_EXEC_BSD && HAS_BSD2(dev_priv)) {
		unsigned int bsd_idx = args->flags & I915_EXEC_BSD_MASK;

		if (bsd_idx == I915_EXEC_BSD_DEFAULT) {
1488
			bsd_idx = gen8_dispatch_bsd_engine(dev_priv, file);
1489 1490
		} else if (bsd_idx >= I915_EXEC_BSD_RING1 &&
			   bsd_idx <= I915_EXEC_BSD_RING2) {
1491
			bsd_idx >>= I915_EXEC_BSD_SHIFT;
1492 1493 1494 1495
			bsd_idx--;
		} else {
			DRM_DEBUG("execbuf with unknown bsd ring: %u\n",
				  bsd_idx);
1496
			return NULL;
1497 1498
		}

1499
		engine = &dev_priv->engine[_VCS(bsd_idx)];
1500
	} else {
1501
		engine = &dev_priv->engine[user_ring_map[user_ring_id]];
1502 1503
	}

1504
	if (!intel_engine_initialized(engine)) {
1505
		DRM_DEBUG("execbuf with invalid ring: %u\n", user_ring_id);
1506
		return NULL;
1507 1508
	}

1509
	return engine;
1510 1511
}

1512 1513 1514 1515
static int
i915_gem_do_execbuffer(struct drm_device *dev, void *data,
		       struct drm_file *file,
		       struct drm_i915_gem_execbuffer2 *args,
1516
		       struct drm_i915_gem_exec_object2 *exec)
1517
{
1518 1519
	struct drm_i915_private *dev_priv = to_i915(dev);
	struct i915_ggtt *ggtt = &dev_priv->ggtt;
1520
	struct eb_vmas *eb;
1521
	struct drm_i915_gem_exec_object2 shadow_exec_entry;
1522
	struct intel_engine_cs *engine;
1523
	struct i915_gem_context *ctx;
1524
	struct i915_address_space *vm;
1525 1526
	struct i915_execbuffer_params params_master; /* XXX: will be removed later */
	struct i915_execbuffer_params *params = &params_master;
1527
	const u32 ctx_id = i915_execbuffer2_get_context_id(*args);
1528
	u32 dispatch_flags;
1529
	int ret;
1530
	bool need_relocs;
1531

1532
	if (!i915_gem_check_execbuffer(args))
1533 1534
		return -EINVAL;

1535
	ret = validate_exec_list(dev, exec, args->buffer_count);
1536 1537 1538
	if (ret)
		return ret;

1539
	dispatch_flags = 0;
1540
	if (args->flags & I915_EXEC_SECURE) {
1541
		if (!drm_is_current_master(file) || !capable(CAP_SYS_ADMIN))
1542 1543
		    return -EPERM;

1544
		dispatch_flags |= I915_DISPATCH_SECURE;
1545
	}
1546
	if (args->flags & I915_EXEC_IS_PINNED)
1547
		dispatch_flags |= I915_DISPATCH_PINNED;
1548

1549 1550 1551
	engine = eb_select_engine(dev_priv, file, args);
	if (!engine)
		return -EINVAL;
1552 1553

	if (args->buffer_count < 1) {
1554
		DRM_DEBUG("execbuf with %d buffers\n", args->buffer_count);
1555 1556 1557
		return -EINVAL;
	}

1558 1559 1560 1561 1562
	if (args->flags & I915_EXEC_RESOURCE_STREAMER) {
		if (!HAS_RESOURCE_STREAMER(dev)) {
			DRM_DEBUG("RS is only allowed for Haswell, Gen8 and above\n");
			return -EINVAL;
		}
1563
		if (engine->id != RCS) {
1564
			DRM_DEBUG("RS is not available on %s\n",
1565
				 engine->name);
1566 1567 1568 1569 1570 1571
			return -EINVAL;
		}

		dispatch_flags |= I915_DISPATCH_RS;
	}

1572 1573 1574 1575 1576 1577
	/* Take a local wakeref for preparing to dispatch the execbuf as
	 * we expect to access the hardware fairly frequently in the
	 * process. Upon first dispatch, we acquire another prolonged
	 * wakeref that we hold until the GPU has been idle for at least
	 * 100ms.
	 */
1578 1579
	intel_runtime_pm_get(dev_priv);

1580 1581 1582 1583
	ret = i915_mutex_lock_interruptible(dev);
	if (ret)
		goto pre_mutex_err;

1584
	ctx = i915_gem_validate_context(dev, file, engine, ctx_id);
1585
	if (IS_ERR(ctx)) {
1586
		mutex_unlock(&dev->struct_mutex);
1587
		ret = PTR_ERR(ctx);
1588
		goto pre_mutex_err;
1589
	}
1590

1591
	i915_gem_context_get(ctx);
1592

1593 1594 1595
	if (ctx->ppgtt)
		vm = &ctx->ppgtt->base;
	else
1596
		vm = &ggtt->base;
1597

1598 1599
	memset(&params_master, 0x00, sizeof(params_master));

B
Ben Widawsky 已提交
1600
	eb = eb_create(args);
1601
	if (eb == NULL) {
1602
		i915_gem_context_put(ctx);
1603 1604 1605 1606 1607
		mutex_unlock(&dev->struct_mutex);
		ret = -ENOMEM;
		goto pre_mutex_err;
	}

1608
	/* Look up object handles */
1609
	ret = eb_lookup_vmas(eb, exec, args, vm, file);
1610 1611
	if (ret)
		goto err;
1612

1613
	/* take note of the batch buffer before we might reorder the lists */
1614
	params->batch = eb_get_batch(eb);
1615

1616
	/* Move the objects en-masse into the GTT, evicting if necessary. */
1617
	need_relocs = (args->flags & I915_EXEC_NO_RELOC) == 0;
1618 1619
	ret = i915_gem_execbuffer_reserve(engine, &eb->vmas, ctx,
					  &need_relocs);
1620 1621 1622 1623
	if (ret)
		goto err;

	/* The objects are in their final locations, apply the relocations. */
1624
	if (need_relocs)
B
Ben Widawsky 已提交
1625
		ret = i915_gem_execbuffer_relocate(eb);
1626 1627
	if (ret) {
		if (ret == -EFAULT) {
1628 1629
			ret = i915_gem_execbuffer_relocate_slow(dev, args, file,
								engine,
1630
								eb, exec, ctx);
1631 1632 1633 1634 1635 1636 1637
			BUG_ON(!mutex_is_locked(&dev->struct_mutex));
		}
		if (ret)
			goto err;
	}

	/* Set the pending read domains for the batch buffer to COMMAND */
1638
	if (params->batch->obj->base.pending_write_domain) {
1639
		DRM_DEBUG("Attempting to use self-modifying batch buffer\n");
1640 1641 1642 1643
		ret = -EINVAL;
		goto err;
	}

1644
	params->args_batch_start_offset = args->batch_start_offset;
1645
	if (intel_engine_needs_cmd_parser(engine) && args->batch_len) {
1646 1647 1648 1649 1650 1651 1652 1653 1654 1655
		struct i915_vma *vma;

		vma = i915_gem_execbuffer_parse(engine, &shadow_exec_entry,
						params->batch->obj,
						eb,
						args->batch_start_offset,
						args->batch_len,
						drm_is_current_master(file));
		if (IS_ERR(vma)) {
			ret = PTR_ERR(vma);
1656 1657
			goto err;
		}
1658

1659
		if (vma) {
1660 1661 1662 1663 1664 1665 1666 1667 1668 1669
			/*
			 * Batch parsed and accepted:
			 *
			 * Set the DISPATCH_SECURE bit to remove the NON_SECURE
			 * bit from MI_BATCH_BUFFER_START commands issued in
			 * the dispatch_execbuffer implementations. We
			 * specifically don't want that set on batches the
			 * command parser has accepted.
			 */
			dispatch_flags |= I915_DISPATCH_SECURE;
1670
			params->args_batch_start_offset = 0;
1671
			params->batch = vma;
1672
		}
1673 1674
	}

1675
	params->batch->obj->base.pending_read_domains |= I915_GEM_DOMAIN_COMMAND;
1676

1677 1678
	/* snb/ivb/vlv conflate the "batch in ppgtt" bit with the "non-secure
	 * batch" bit. Hence we need to pin secure batches into the global gtt.
B
Ben Widawsky 已提交
1679
	 * hsw should have this fixed, but bdw mucks it up again. */
1680
	if (dispatch_flags & I915_DISPATCH_SECURE) {
1681
		struct drm_i915_gem_object *obj = params->batch->obj;
C
Chris Wilson 已提交
1682
		struct i915_vma *vma;
1683

1684 1685 1686 1687 1688 1689
		/*
		 * So on first glance it looks freaky that we pin the batch here
		 * outside of the reservation loop. But:
		 * - The batch is already pinned into the relevant ppgtt, so we
		 *   already have the backing storage fully allocated.
		 * - No other BO uses the global gtt (well contexts, but meh),
1690
		 *   so we don't really have issues with multiple objects not
1691 1692 1693
		 *   fitting due to fragmentation.
		 * So this is actually safe.
		 */
C
Chris Wilson 已提交
1694 1695 1696
		vma = i915_gem_object_ggtt_pin(obj, NULL, 0, 0, 0);
		if (IS_ERR(vma)) {
			ret = PTR_ERR(vma);
1697
			goto err;
C
Chris Wilson 已提交
1698
		}
1699

C
Chris Wilson 已提交
1700
		params->batch = vma;
1701
	}
1702

1703
	/* Allocate a request for this batch buffer nice and early. */
1704 1705 1706
	params->request = i915_gem_request_alloc(engine, ctx);
	if (IS_ERR(params->request)) {
		ret = PTR_ERR(params->request);
1707
		goto err_batch_unpin;
1708
	}
1709

1710 1711 1712 1713 1714 1715
	/* Whilst this request exists, batch_obj will be on the
	 * active_list, and so will hold the active reference. Only when this
	 * request is retired will the the batch_obj be moved onto the
	 * inactive_list and lose its active reference. Hence we do not need
	 * to explicitly hold another reference here.
	 */
C
Chris Wilson 已提交
1716
	params->request->batch = params->batch;
1717

1718
	ret = i915_gem_request_add_to_client(params->request, file);
1719
	if (ret)
1720
		goto err_request;
1721

1722 1723 1724 1725 1726 1727 1728 1729
	/*
	 * Save assorted stuff away to pass through to *_submission().
	 * NB: This data should be 'persistent' and not local as it will
	 * kept around beyond the duration of the IOCTL once the GPU
	 * scheduler arrives.
	 */
	params->dev                     = dev;
	params->file                    = file;
1730
	params->engine                    = engine;
1731 1732 1733
	params->dispatch_flags          = dispatch_flags;
	params->ctx                     = ctx;

1734
	ret = execbuf_submit(params, args, &eb->vmas);
1735
err_request:
1736
	__i915_add_request(params->request, ret == 0);
1737

1738
err_batch_unpin:
1739 1740 1741 1742 1743 1744
	/*
	 * FIXME: We crucially rely upon the active tracking for the (ppgtt)
	 * batch vma for correctness. For less ugly and less fragility this
	 * needs to be adjusted to also track the ggtt batch vma properly as
	 * active.
	 */
1745
	if (dispatch_flags & I915_DISPATCH_SECURE)
1746
		i915_vma_unpin(params->batch);
1747
err:
1748
	/* the request owns the ref now */
1749
	i915_gem_context_put(ctx);
1750
	eb_destroy(eb);
1751 1752 1753 1754

	mutex_unlock(&dev->struct_mutex);

pre_mutex_err:
1755 1756 1757
	/* intel_gpu_busy should also get a ref, so it will free when the device
	 * is really idle. */
	intel_runtime_pm_put(dev_priv);
1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775
	return ret;
}

/*
 * Legacy execbuffer just creates an exec2 list from the original exec object
 * list array and passes it to the real function.
 */
int
i915_gem_execbuffer(struct drm_device *dev, void *data,
		    struct drm_file *file)
{
	struct drm_i915_gem_execbuffer *args = data;
	struct drm_i915_gem_execbuffer2 exec2;
	struct drm_i915_gem_exec_object *exec_list = NULL;
	struct drm_i915_gem_exec_object2 *exec2_list = NULL;
	int ret, i;

	if (args->buffer_count < 1) {
1776
		DRM_DEBUG("execbuf with %d buffers\n", args->buffer_count);
1777 1778 1779 1780 1781 1782 1783
		return -EINVAL;
	}

	/* Copy in the exec list from userland */
	exec_list = drm_malloc_ab(sizeof(*exec_list), args->buffer_count);
	exec2_list = drm_malloc_ab(sizeof(*exec2_list), args->buffer_count);
	if (exec_list == NULL || exec2_list == NULL) {
1784
		DRM_DEBUG("Failed to allocate exec list for %d buffers\n",
1785 1786 1787 1788 1789 1790
			  args->buffer_count);
		drm_free_large(exec_list);
		drm_free_large(exec2_list);
		return -ENOMEM;
	}
	ret = copy_from_user(exec_list,
1791
			     u64_to_user_ptr(args->buffers_ptr),
1792 1793
			     sizeof(*exec_list) * args->buffer_count);
	if (ret != 0) {
1794
		DRM_DEBUG("copy %d exec entries failed %d\n",
1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821
			  args->buffer_count, ret);
		drm_free_large(exec_list);
		drm_free_large(exec2_list);
		return -EFAULT;
	}

	for (i = 0; i < args->buffer_count; i++) {
		exec2_list[i].handle = exec_list[i].handle;
		exec2_list[i].relocation_count = exec_list[i].relocation_count;
		exec2_list[i].relocs_ptr = exec_list[i].relocs_ptr;
		exec2_list[i].alignment = exec_list[i].alignment;
		exec2_list[i].offset = exec_list[i].offset;
		if (INTEL_INFO(dev)->gen < 4)
			exec2_list[i].flags = EXEC_OBJECT_NEEDS_FENCE;
		else
			exec2_list[i].flags = 0;
	}

	exec2.buffers_ptr = args->buffers_ptr;
	exec2.buffer_count = args->buffer_count;
	exec2.batch_start_offset = args->batch_start_offset;
	exec2.batch_len = args->batch_len;
	exec2.DR1 = args->DR1;
	exec2.DR4 = args->DR4;
	exec2.num_cliprects = args->num_cliprects;
	exec2.cliprects_ptr = args->cliprects_ptr;
	exec2.flags = I915_EXEC_RENDER;
1822
	i915_execbuffer2_set_context_id(exec2, 0);
1823

1824
	ret = i915_gem_do_execbuffer(dev, data, file, &exec2, exec2_list);
1825
	if (!ret) {
1826
		struct drm_i915_gem_exec_object __user *user_exec_list =
1827
			u64_to_user_ptr(args->buffers_ptr);
1828

1829
		/* Copy the new buffer offsets back to the user's exec list. */
1830
		for (i = 0; i < args->buffer_count; i++) {
1831 1832
			exec2_list[i].offset =
				gen8_canonical_addr(exec2_list[i].offset);
1833 1834 1835 1836 1837 1838 1839 1840 1841 1842
			ret = __copy_to_user(&user_exec_list[i].offset,
					     &exec2_list[i].offset,
					     sizeof(user_exec_list[i].offset));
			if (ret) {
				ret = -EFAULT;
				DRM_DEBUG("failed to copy %d exec entries "
					  "back to user (%d)\n",
					  args->buffer_count, ret);
				break;
			}
1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858
		}
	}

	drm_free_large(exec_list);
	drm_free_large(exec2_list);
	return ret;
}

int
i915_gem_execbuffer2(struct drm_device *dev, void *data,
		     struct drm_file *file)
{
	struct drm_i915_gem_execbuffer2 *args = data;
	struct drm_i915_gem_exec_object2 *exec2_list = NULL;
	int ret;

1859 1860
	if (args->buffer_count < 1 ||
	    args->buffer_count > UINT_MAX / sizeof(*exec2_list)) {
1861
		DRM_DEBUG("execbuf2 with %d buffers\n", args->buffer_count);
1862 1863 1864
		return -EINVAL;
	}

1865 1866 1867 1868 1869
	if (args->rsvd2 != 0) {
		DRM_DEBUG("dirty rvsd2 field\n");
		return -EINVAL;
	}

1870 1871 1872
	exec2_list = drm_malloc_gfp(args->buffer_count,
				    sizeof(*exec2_list),
				    GFP_TEMPORARY);
1873
	if (exec2_list == NULL) {
1874
		DRM_DEBUG("Failed to allocate exec list for %d buffers\n",
1875 1876 1877 1878
			  args->buffer_count);
		return -ENOMEM;
	}
	ret = copy_from_user(exec2_list,
1879
			     u64_to_user_ptr(args->buffers_ptr),
1880 1881
			     sizeof(*exec2_list) * args->buffer_count);
	if (ret != 0) {
1882
		DRM_DEBUG("copy %d exec entries failed %d\n",
1883 1884 1885 1886 1887
			  args->buffer_count, ret);
		drm_free_large(exec2_list);
		return -EFAULT;
	}

1888
	ret = i915_gem_do_execbuffer(dev, data, file, args, exec2_list);
1889 1890
	if (!ret) {
		/* Copy the new buffer offsets back to the user's exec list. */
1891
		struct drm_i915_gem_exec_object2 __user *user_exec_list =
1892
				   u64_to_user_ptr(args->buffers_ptr);
1893 1894 1895
		int i;

		for (i = 0; i < args->buffer_count; i++) {
1896 1897
			exec2_list[i].offset =
				gen8_canonical_addr(exec2_list[i].offset);
1898 1899 1900 1901 1902 1903 1904 1905 1906 1907
			ret = __copy_to_user(&user_exec_list[i].offset,
					     &exec2_list[i].offset,
					     sizeof(user_exec_list[i].offset));
			if (ret) {
				ret = -EFAULT;
				DRM_DEBUG("failed to copy %d exec entries "
					  "back to user\n",
					  args->buffer_count);
				break;
			}
1908 1909 1910 1911 1912 1913
		}
	}

	drm_free_large(exec2_list);
	return ret;
}