user_spec.rb 151.0 KB
Newer Older
1 2
# frozen_string_literal: true

G
gitlabhq 已提交
3 4
require 'spec_helper'

5
RSpec.describe User do
B
Bob Van Landuyt 已提交
6
  include ProjectForksHelper
7
  include TermsHelper
8
  include ExclusiveLeaseHelpers
9

S
Shinya Maeda 已提交
10
  it_behaves_like 'having unique enum values'
S
Shinya Maeda 已提交
11

12 13 14 15 16 17 18
  describe 'modules' do
    subject { described_class }

    it { is_expected.to include_module(Gitlab::ConfigHelper) }
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
    it { is_expected.to include_module(TokenAuthenticatable) }
19
    it { is_expected.to include_module(BlocksJsonSerialization) }
20
    it { is_expected.to include_module(AsyncDeviseEmail) }
21 22
  end

23 24
  describe 'delegations' do
    it { is_expected.to delegate_method(:path).to(:namespace).with_prefix }
25

26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43
    it { is_expected.to delegate_method(:notes_filter_for).to(:user_preference) }
    it { is_expected.to delegate_method(:set_notes_filter).to(:user_preference) }

    it { is_expected.to delegate_method(:first_day_of_week).to(:user_preference) }
    it { is_expected.to delegate_method(:first_day_of_week=).to(:user_preference).with_arguments(:args) }

    it { is_expected.to delegate_method(:timezone).to(:user_preference) }
    it { is_expected.to delegate_method(:timezone=).to(:user_preference).with_arguments(:args) }

    it { is_expected.to delegate_method(:time_display_relative).to(:user_preference) }
    it { is_expected.to delegate_method(:time_display_relative=).to(:user_preference).with_arguments(:args) }

    it { is_expected.to delegate_method(:time_format_in_24h).to(:user_preference) }
    it { is_expected.to delegate_method(:time_format_in_24h=).to(:user_preference).with_arguments(:args) }

    it { is_expected.to delegate_method(:show_whitespace_in_diffs).to(:user_preference) }
    it { is_expected.to delegate_method(:show_whitespace_in_diffs=).to(:user_preference).with_arguments(:args) }

44
    it { is_expected.to delegate_method(:tab_width).to(:user_preference) }
45 46 47 48 49 50 51 52 53 54 55
    it { is_expected.to delegate_method(:tab_width=).to(:user_preference).with_arguments(:args) }

    it { is_expected.to delegate_method(:sourcegraph_enabled).to(:user_preference) }
    it { is_expected.to delegate_method(:sourcegraph_enabled=).to(:user_preference).with_arguments(:args) }

    it { is_expected.to delegate_method(:setup_for_company).to(:user_preference) }
    it { is_expected.to delegate_method(:setup_for_company=).to(:user_preference).with_arguments(:args) }

    it { is_expected.to delegate_method(:render_whitespace_in_code).to(:user_preference) }
    it { is_expected.to delegate_method(:render_whitespace_in_code=).to(:user_preference).with_arguments(:args) }

56 57 58
    it { is_expected.to delegate_method(:experience_level).to(:user_preference) }
    it { is_expected.to delegate_method(:experience_level=).to(:user_preference).with_arguments(:args) }

59 60
    it { is_expected.to delegate_method(:job_title).to(:user_detail).allow_nil }
    it { is_expected.to delegate_method(:job_title=).to(:user_detail).with_arguments(:args).allow_nil }
61 62
  end

63
  describe 'associations' do
64
    it { is_expected.to have_one(:namespace) }
B
Bob Van Landuyt 已提交
65
    it { is_expected.to have_one(:status) }
66
    it { is_expected.to have_one(:user_detail) }
67
    it { is_expected.to have_one(:user_highest_role) }
68
    it { is_expected.to have_many(:snippets).dependent(:destroy) }
69 70 71
    it { is_expected.to have_many(:members) }
    it { is_expected.to have_many(:project_members) }
    it { is_expected.to have_many(:group_members) }
72 73
    it { is_expected.to have_many(:groups) }
    it { is_expected.to have_many(:keys).dependent(:destroy) }
74
    it { is_expected.to have_many(:deploy_keys).dependent(:nullify) }
75
    it { is_expected.to have_many(:events).dependent(:delete_all) }
76
    it { is_expected.to have_many(:issues).dependent(:destroy) }
77 78 79
    it { is_expected.to have_many(:notes).dependent(:destroy) }
    it { is_expected.to have_many(:merge_requests).dependent(:destroy) }
    it { is_expected.to have_many(:identities).dependent(:destroy) }
80
    it { is_expected.to have_many(:spam_logs).dependent(:destroy) }
81
    it { is_expected.to have_many(:todos) }
82
    it { is_expected.to have_many(:award_emoji).dependent(:destroy) }
K
Kamil Trzcinski 已提交
83
    it { is_expected.to have_many(:triggers).dependent(:destroy) }
84 85
    it { is_expected.to have_many(:builds).dependent(:nullify) }
    it { is_expected.to have_many(:pipelines).dependent(:nullify) }
K
Kamil Trzcinski 已提交
86
    it { is_expected.to have_many(:chat_names).dependent(:destroy) }
J
Jan Provaznik 已提交
87
    it { is_expected.to have_many(:uploads) }
88
    it { is_expected.to have_many(:reported_abuse_reports).dependent(:destroy).class_name('AbuseReport') }
89
    it { is_expected.to have_many(:custom_attributes).class_name('UserCustomAttribute') }
90
    it { is_expected.to have_many(:releases).dependent(:nullify) }
91
    it { is_expected.to have_many(:metrics_users_starred_dashboards).inverse_of(:user) }
92
    it { is_expected.to have_many(:reviews).inverse_of(:author) }
93

94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154
    describe "#bio" do
      it 'syncs bio with `user_details.bio` on create' do
        user = create(:user, bio: 'my bio')

        expect(user.bio).to eq(user.user_detail.bio)
      end

      context 'when `migrate_bio_to_user_details` feature flag is off' do
        before do
          stub_feature_flags(migrate_bio_to_user_details: false)
        end

        it 'does not sync bio with `user_details.bio`' do
          user = create(:user, bio: 'my bio')

          expect(user.bio).to eq('my bio')
          expect(user.user_detail.bio).to eq('')
        end
      end

      it 'syncs bio with `user_details.bio` on update' do
        user = create(:user)

        user.update!(bio: 'my bio')

        expect(user.bio).to eq(user.user_detail.bio)
      end

      context 'when `user_details` association already exists' do
        let(:user) { create(:user) }

        before do
          create(:user_detail, user: user)
        end

        it 'syncs bio with `user_details.bio`' do
          user.update!(bio: 'my bio')

          expect(user.bio).to eq(user.user_detail.bio)
        end

        it 'falls back to "" when nil is given' do
          user.update!(bio: nil)

          expect(user.bio).to eq(nil)
          expect(user.user_detail.bio).to eq('')
        end

        # very unlikely scenario
        it 'truncates long bio when syncing to user_details' do
          invalid_bio = 'a' * 256
          truncated_bio = 'a' * 255

          user.bio = invalid_bio
          user.save(validate: false)

          expect(user.user_detail.bio).to eq(truncated_bio)
        end
      end
    end

155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180
    describe "#abuse_report" do
      let(:current_user) { create(:user) }
      let(:other_user) { create(:user) }

      it { is_expected.to have_one(:abuse_report) }

      it "refers to the abuse report whose user_id is the current user" do
        abuse_report = create(:abuse_report, reporter: other_user, user: current_user)

        expect(current_user.abuse_report).to eq(abuse_report)
      end

      it "does not refer to the abuse report whose reporter_id is the current user" do
        create(:abuse_report, reporter: current_user, user: other_user)

        expect(current_user.abuse_report).to be_nil
      end

      it "does not update the user_id of an abuse report when the user is updated" do
        abuse_report = create(:abuse_report, reporter: current_user, user: other_user)

        current_user.block

        expect(abuse_report.reload.user).to eq(other_user)
      end
    end
181 182 183 184

    describe '#group_members' do
      it 'does not include group memberships for which user is a requester' do
        user = create(:user)
185
        group = create(:group, :public)
186 187 188 189 190 191 192 193 194
        group.request_access(user)

        expect(user.group_members).to be_empty
      end
    end

    describe '#project_members' do
      it 'does not include project memberships for which user is a requester' do
        user = create(:user)
195
        project = create(:project, :public)
196 197 198 199 200
        project.request_access(user)

        expect(user.project_members).to be_empty
      end
    end
201 202
  end

203 204 205 206 207 208 209 210 211 212 213 214
  describe 'Devise emails' do
    let!(:user) { create(:user) }

    describe 'behaviour' do
      it 'sends emails asynchronously' do
        expect do
          user.update!(email: 'hello@hello.com')
        end.to have_enqueued_job.on_queue('mailers').exactly(:twice)
      end
    end
  end

215
  describe 'validations' do
216
    describe 'password' do
217
      let!(:user) { build_stubbed(:user) }
218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262

      before do
        allow(Devise).to receive(:password_length).and_return(8..128)
        allow(described_class).to receive(:password_length).and_return(10..130)
      end

      context 'length' do
        it { is_expected.to validate_length_of(:password).is_at_least(10).is_at_most(130) }
      end

      context 'length validator' do
        context 'for a short password' do
          before do
            user.password = user.password_confirmation = 'abc'
          end

          it 'does not run the default Devise password length validation' do
            expect(user).to be_invalid
            expect(user.errors.full_messages.join).not_to include('is too short (minimum is 8 characters)')
          end

          it 'runs the custom password length validator' do
            expect(user).to be_invalid
            expect(user.errors.full_messages.join).to include('is too short (minimum is 10 characters)')
          end
        end

        context 'for a long password' do
          before do
            user.password = user.password_confirmation = 'a' * 140
          end

          it 'does not run the default Devise password length validation' do
            expect(user).to be_invalid
            expect(user.errors.full_messages.join).not_to include('is too long (maximum is 128 characters)')
          end

          it 'runs the custom password length validator' do
            expect(user).to be_invalid
            expect(user.errors.full_messages.join).to include('is too long (maximum is 130 characters)')
          end
        end
      end
    end

263 264
    describe 'name' do
      it { is_expected.to validate_presence_of(:name) }
265
      it { is_expected.to validate_length_of(:name).is_at_most(255) }
266 267
    end

268
    describe 'first name' do
269
      it { is_expected.to validate_length_of(:first_name).is_at_most(127) }
270 271 272
    end

    describe 'last name' do
273
      it { is_expected.to validate_length_of(:last_name).is_at_most(127) }
274 275
    end

R
Robert Speicher 已提交
276 277 278 279 280 281 282 283 284
    describe 'username' do
      it 'validates presence' do
        expect(subject).to validate_presence_of(:username)
      end

      it 'rejects blacklisted names' do
        user = build(:user, username: 'dashboard')

        expect(user).not_to be_valid
285
        expect(user.errors.messages[:username]).to eq ['dashboard is a reserved name']
R
Robert Speicher 已提交
286 287
      end

288 289 290 291 292 293 294 295 296 297 298 299
      it 'allows child names' do
        user = build(:user, username: 'avatar')

        expect(user).to be_valid
      end

      it 'allows wildcard names' do
        user = build(:user, username: 'blob')

        expect(user).to be_valid
      end

300 301 302 303 304 305 306
      context 'when username is changed' do
        let(:user) { build_stubbed(:user, username: 'old_path', namespace: build_stubbed(:namespace)) }

        it 'validates move_dir is allowed for the namespace' do
          expect(user.namespace).to receive(:any_project_has_container_registry_tags?).and_return(true)
          user.username = 'new_path'
          expect(user).to be_invalid
307
          expect(user.errors.messages[:username].first).to eq(_('cannot be changed if a personal project has container registry tags.'))
308 309
        end
      end
310

311 312 313 314 315 316 317 318 319
      context 'when the username is in use by another user' do
        let(:username) { 'foo' }
        let!(:other_user) { create(:user, username: username) }

        it 'is invalid' do
          user = build(:user, username: username)

          expect(user).not_to be_valid
          expect(user.errors.full_messages).to eq(['Username has already been taken'])
320 321
        end
      end
R
Robert Speicher 已提交
322 323
    end

324 325 326 327 328 329 330 331 332 333
    it 'has a DB-level NOT NULL constraint on projects_limit' do
      user = create(:user)

      expect(user.persisted?).to eq(true)

      expect do
        user.update_columns(projects_limit: nil)
      end.to raise_error(ActiveRecord::StatementInvalid)
    end

334 335 336 337
    it { is_expected.to validate_presence_of(:projects_limit) }
    it { is_expected.to validate_numericality_of(:projects_limit) }
    it { is_expected.to allow_value(0).for(:projects_limit) }
    it { is_expected.not_to allow_value(-1).for(:projects_limit) }
338
    it { is_expected.not_to allow_value(Gitlab::Database::MAX_INT_VALUE + 1).for(:projects_limit) }
339

340
    it { is_expected.to validate_length_of(:bio).is_at_most(255) }
341

342 343 344
    it_behaves_like 'an object with email-formated attributes', :email do
      subject { build(:user) }
    end
345

346
    it_behaves_like 'an object with RFC3696 compliant email-formated attributes', :public_email, :notification_email do
347
      subject { create(:user).tap { |user| user.emails << build(:email, email: email_value, confirmed_at: Time.current) } }
348
    end
349

350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365
    describe '#commit_email' do
      subject(:user) { create(:user) }

      it 'defaults to the primary email' do
        expect(user.email).to be_present
        expect(user.commit_email).to eq(user.email)
      end

      it 'defaults to the primary email when the column in the database is null' do
        user.update_column(:commit_email, nil)

        found_user = described_class.find_by(id: user.id)

        expect(found_user.commit_email).to eq(user.email)
      end

366 367 368 369 370 371
      it 'returns the private commit email when commit_email has _private' do
        user.update_column(:commit_email, Gitlab::PrivateCommitEmail::TOKEN)

        expect(user.commit_email).to eq(user.private_commit_email)
      end

372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404
      it 'can be set to a confirmed email' do
        confirmed = create(:email, :confirmed, user: user)
        user.commit_email = confirmed.email

        expect(user).to be_valid
        expect(user.commit_email).to eq(confirmed.email)
      end

      it 'can not be set to an unconfirmed email' do
        unconfirmed = create(:email, user: user)
        user.commit_email = unconfirmed.email

        # This should set the commit_email attribute to the primary email
        expect(user).to be_valid
        expect(user.commit_email).to eq(user.email)
      end

      it 'can not be set to a non-existent email' do
        user.commit_email = 'non-existent-email@nonexistent.nonexistent'

        # This should set the commit_email attribute to the primary email
        expect(user).to be_valid
        expect(user.commit_email).to eq(user.email)
      end

      it 'can not be set to an invalid email, even if confirmed' do
        confirmed = create(:email, :confirmed, :skip_validate, user: user, email: 'invalid')
        user.commit_email = confirmed.email

        expect(user).not_to be_valid
      end
    end

405
    describe 'email' do
406
      context 'when no signup domains whitelisted' do
407
        before do
408
          allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return([])
409
        end
410

411 412 413 414 415 416
        it 'accepts any email' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end
      end

417 418 419 420 421 422 423 424 425 426 427 428 429 430
      context 'bad regex' do
        before do
          allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['([a-zA-Z0-9]+)+\.com'])
        end

        it 'does not hang on evil input' do
          user = build(:user, email: 'user@aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa!.com')

          expect do
            Timeout.timeout(2.seconds) { user.valid? }
          end.not_to raise_error
        end
      end

431
      context 'when a signup domain is whitelisted and subdomains are allowed' do
432
        before do
433
          allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['example.com', '*.example.com'])
434
        end
435

436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451
        it 'accepts info@example.com' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end

        it 'accepts info@test.example.com' do
          user = build(:user, email: "info@test.example.com")
          expect(user).to be_valid
        end

        it 'rejects example@test.com' do
          user = build(:user, email: "example@test.com")
          expect(user).to be_invalid
        end
      end

452
      context 'when a signup domain is whitelisted and subdomains are not allowed' do
453
        before do
454
          allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['example.com'])
455
        end
456 457 458 459 460 461 462 463 464 465 466 467 468 469 470

        it 'accepts info@example.com' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end

        it 'rejects info@test.example.com' do
          user = build(:user, email: "info@test.example.com")
          expect(user).to be_invalid
        end

        it 'rejects example@test.com' do
          user = build(:user, email: "example@test.com")
          expect(user).to be_invalid
        end
471 472 473 474 475

        it 'accepts example@test.com when added by another user' do
          user = build(:user, email: "example@test.com", created_by_id: 1)
          expect(user).to be_valid
        end
476
      end
477

478 479 480 481 482 483
      context 'domain blacklist' do
        before do
          allow_any_instance_of(ApplicationSetting).to receive(:domain_blacklist_enabled?).and_return(true)
          allow_any_instance_of(ApplicationSetting).to receive(:domain_blacklist).and_return(['example.com'])
        end

484 485 486 487 488 489 490 491 492 493 494 495 496 497
        context 'bad regex' do
          before do
            allow_any_instance_of(ApplicationSetting).to receive(:domain_blacklist).and_return(['([a-zA-Z0-9]+)+\.com'])
          end

          it 'does not hang on evil input' do
            user = build(:user, email: 'user@aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa!.com')

            expect do
              Timeout.timeout(2.seconds) { user.valid? }
            end.not_to raise_error
          end
        end

498
        context 'when a signup domain is blacklisted' do
499 500 501 502 503 504 505 506 507
          it 'accepts info@test.com' do
            user = build(:user, email: 'info@test.com')
            expect(user).to be_valid
          end

          it 'rejects info@example.com' do
            user = build(:user, email: 'info@example.com')
            expect(user).not_to be_valid
          end
508 509 510 511 512

          it 'accepts info@example.com when added by another user' do
            user = build(:user, email: 'info@example.com', created_by_id: 1)
            expect(user).to be_valid
          end
513 514
        end

515
        context 'when a signup domain is blacklisted but a wildcard subdomain is allowed' do
516 517
          before do
            allow_any_instance_of(ApplicationSetting).to receive(:domain_blacklist).and_return(['test.example.com'])
518
            allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['*.example.com'])
519 520
          end

521
          it 'gives priority to whitelist and allow info@test.example.com' do
522 523 524 525 526 527 528
            user = build(:user, email: 'info@test.example.com')
            expect(user).to be_valid
          end
        end

        context 'with both lists containing a domain' do
          before do
529
            allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['test.com'])
530 531 532 533 534 535 536 537 538 539 540 541 542 543
          end

          it 'accepts info@test.com' do
            user = build(:user, email: 'info@test.com')
            expect(user).to be_valid
          end

          it 'rejects info@example.com' do
            user = build(:user, email: 'info@example.com')
            expect(user).not_to be_valid
          end
        end
      end

544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579
      context 'email restrictions' do
        context 'when email restriction is disabled' do
          before do
            stub_application_setting(email_restrictions_enabled: false)
            stub_application_setting(email_restrictions: '\+')
          end

          it 'does accept email address' do
            user = build(:user, email: 'info+1@test.com')

            expect(user).to be_valid
          end
        end

        context 'when email restrictions is enabled' do
          before do
            stub_application_setting(email_restrictions_enabled: true)
            stub_application_setting(email_restrictions: '([\+]|\b(\w*gitlab.com\w*)\b)')
          end

          it 'does not accept email address with + characters' do
            user = build(:user, email: 'info+1@test.com')

            expect(user).not_to be_valid
          end

          it 'does not accept email with a gitlab domain' do
            user = build(:user, email: 'info@gitlab.com')

            expect(user).not_to be_valid
          end

          it 'adds an error message when email is not accepted' do
            user = build(:user, email: 'info@gitlab.com')

            expect(user).not_to be_valid
580
            expect(user.errors.messages[:email].first).to eq(_('is not allowed. Try again with a different email address, or contact your GitLab admin.'))
581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598
          end

          it 'does accept a valid email address' do
            user = build(:user, email: 'info@test.com')

            expect(user).to be_valid
          end

          context 'when created_by_id is set' do
            it 'does accept the email address' do
              user = build(:user, email: 'info+1@test.com', created_by_id: 1)

              expect(user).to be_valid
            end
          end
        end
      end

599 600 601 602 603
      context 'owns_notification_email' do
        it 'accepts temp_oauth_email emails' do
          user = build(:user, email: "temp-email-for-oauth@example.com")
          expect(user).to be_valid
        end
604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629

        it 'does not accept not verified emails' do
          email = create(:email)
          user = email.user
          user.update(notification_email: email.email)

          expect(user).to be_invalid
        end
      end

      context 'owns_public_email' do
        it 'accepts verified emails' do
          email = create(:email, :confirmed, email: 'test@test.com')
          user = email.user
          user.update(public_email: email.email)

          expect(user).to be_valid
        end

        it 'does not accept not verified emails' do
          email = create(:email)
          user = email.user
          user.update(public_email: email.email)

          expect(user).to be_invalid
        end
630
      end
631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664

      context 'set_commit_email' do
        it 'keeps commit email when private commit email is being used' do
          user = create(:user, commit_email: Gitlab::PrivateCommitEmail::TOKEN)

          expect(user.read_attribute(:commit_email)).to eq(Gitlab::PrivateCommitEmail::TOKEN)
        end

        it 'keeps the commit email when nil' do
          user = create(:user, commit_email: nil)

          expect(user.read_attribute(:commit_email)).to be_nil
        end

        it 'reverts to nil when email is not verified' do
          user = create(:user, commit_email: "foo@bar.com")

          expect(user.read_attribute(:commit_email)).to be_nil
        end
      end

      context 'owns_commit_email' do
        it 'accepts private commit email' do
          user = build(:user, commit_email: Gitlab::PrivateCommitEmail::TOKEN)

          expect(user).to be_valid
        end

        it 'accepts nil commit email' do
          user = build(:user, commit_email: nil)

          expect(user).to be_valid
        end
      end
665
    end
666 667 668 669 670 671 672
  end

  describe "scopes" do
    describe ".with_two_factor" do
      it "returns users with 2fa enabled via OTP" do
        user_with_2fa = create(:user, :two_factor_via_otp)
        user_without_2fa = create(:user)
673
        users_with_two_factor = described_class.with_two_factor.pluck(:id)
674 675 676 677 678 679 680 681

        expect(users_with_two_factor).to include(user_with_2fa.id)
        expect(users_with_two_factor).not_to include(user_without_2fa.id)
      end

      it "returns users with 2fa enabled via U2F" do
        user_with_2fa = create(:user, :two_factor_via_u2f)
        user_without_2fa = create(:user)
682
        users_with_two_factor = described_class.with_two_factor.pluck(:id)
683 684 685 686 687 688 689 690

        expect(users_with_two_factor).to include(user_with_2fa.id)
        expect(users_with_two_factor).not_to include(user_without_2fa.id)
      end

      it "returns users with 2fa enabled via OTP and U2F" do
        user_with_2fa = create(:user, :two_factor_via_otp, :two_factor_via_u2f)
        user_without_2fa = create(:user)
691
        users_with_two_factor = described_class.with_two_factor.pluck(:id)
692 693 694 695

        expect(users_with_two_factor).to eq([user_with_2fa.id])
        expect(users_with_two_factor).not_to include(user_without_2fa.id)
      end
696 697 698 699 700 701 702 703

      it 'works with ORDER BY' do
        user_with_2fa = create(:user, :two_factor_via_otp, :two_factor_via_u2f)

        expect(described_class
          .with_two_factor
          .reorder_by_name).to eq([user_with_2fa])
      end
704 705 706 707 708 709
    end

    describe ".without_two_factor" do
      it "excludes users with 2fa enabled via OTP" do
        user_with_2fa = create(:user, :two_factor_via_otp)
        user_without_2fa = create(:user)
710
        users_without_two_factor = described_class.without_two_factor.pluck(:id)
711 712 713 714 715 716 717 718

        expect(users_without_two_factor).to include(user_without_2fa.id)
        expect(users_without_two_factor).not_to include(user_with_2fa.id)
      end

      it "excludes users with 2fa enabled via U2F" do
        user_with_2fa = create(:user, :two_factor_via_u2f)
        user_without_2fa = create(:user)
719
        users_without_two_factor = described_class.without_two_factor.pluck(:id)
720 721 722 723 724 725 726 727

        expect(users_without_two_factor).to include(user_without_2fa.id)
        expect(users_without_two_factor).not_to include(user_with_2fa.id)
      end

      it "excludes users with 2fa enabled via OTP and U2F" do
        user_with_2fa = create(:user, :two_factor_via_otp, :two_factor_via_u2f)
        user_without_2fa = create(:user)
728
        users_without_two_factor = described_class.without_two_factor.pluck(:id)
729 730 731 732 733

        expect(users_without_two_factor).to include(user_without_2fa.id)
        expect(users_without_two_factor).not_to include(user_with_2fa.id)
      end
    end
V
Valery Sizov 已提交
734

735 736 737 738 739 740 741 742 743 744 745 746 747 748
    describe '.random_password' do
      let(:random_password) { described_class.random_password }

      before do
        expect(User).to receive(:password_length).and_return(88..128)
      end

      context 'length' do
        it 'conforms to the current password length settings' do
          expect(random_password.length).to eq(128)
        end
      end
    end

749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776
    describe '.password_length' do
      let(:password_length) { described_class.password_length }

      it 'is expected to be a Range' do
        expect(password_length).to be_a(Range)
      end

      context 'minimum value' do
        before do
          stub_application_setting(minimum_password_length: 101)
        end

        it 'is determined by the current value of `minimum_password_length` attribute of application_setting' do
          expect(password_length.min).to eq(101)
        end
      end

      context 'maximum value' do
        before do
          allow(Devise.password_length).to receive(:max).and_return(201)
        end

        it 'is determined by the current value of `Devise.password_length.max`' do
          expect(password_length.max).to eq(201)
        end
      end
    end

Y
Yorick Peterse 已提交
777 778 779 780
    describe '.limit_to_todo_authors' do
      context 'when filtering by todo authors' do
        let(:user1) { create(:user) }
        let(:user2) { create(:user) }
V
Valery Sizov 已提交
781

Y
Yorick Peterse 已提交
782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825
        before do
          create(:todo, user: user1, author: user1, state: :done)
          create(:todo, user: user2, author: user2, state: :pending)
        end

        it 'only returns users that have authored todos' do
          users = described_class.limit_to_todo_authors(
            user: user2,
            with_todos: true,
            todo_state: :pending
          )

          expect(users).to eq([user2])
        end

        it 'ignores users that do not have a todo in the matching state' do
          users = described_class.limit_to_todo_authors(
            user: user1,
            with_todos: true,
            todo_state: :pending
          )

          expect(users).to be_empty
        end
      end

      context 'when not filtering by todo authors' do
        it 'returns the input relation' do
          user1 = create(:user)
          user2 = create(:user)
          rel = described_class.limit_to_todo_authors(user: user1)

          expect(rel).to include(user1, user2)
        end
      end

      context 'when no user is provided' do
        it 'returns the input relation' do
          user1 = create(:user)
          user2 = create(:user)
          rel = described_class.limit_to_todo_authors

          expect(rel).to include(user1, user2)
        end
V
Valery Sizov 已提交
826 827
      end
    end
828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844

    describe '.by_username' do
      it 'finds users regardless of the case passed' do
        user = create(:user, username: 'CaMeLcAsEd')
        user2 = create(:user, username: 'UPPERCASE')

        expect(described_class.by_username(%w(CAMELCASED uppercase)))
          .to contain_exactly(user, user2)
      end

      it 'finds a single user regardless of the case passed' do
        user = create(:user, username: 'CaMeLcAsEd')

        expect(described_class.by_username('CAMELCASED'))
          .to contain_exactly(user)
      end
    end
845 846 847 848 849 850 851 852

    describe '.with_expiring_and_not_notified_personal_access_tokens' do
      let_it_be(:user1) { create(:user) }
      let_it_be(:user2) { create(:user) }
      let_it_be(:user3) { create(:user) }

      let_it_be(:expired_token) { create(:personal_access_token, user: user1, expires_at: 2.days.ago) }
      let_it_be(:revoked_token) { create(:personal_access_token, user: user1, revoked: true) }
853
      let_it_be(:impersonation_token) { create(:personal_access_token, :impersonation, user: user1, expires_at: 2.days.from_now) }
854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874
      let_it_be(:valid_token_and_notified) { create(:personal_access_token, user: user2, expires_at: 2.days.from_now, expire_notification_delivered: true) }
      let_it_be(:valid_token1) { create(:personal_access_token, user: user2, expires_at: 2.days.from_now) }
      let_it_be(:valid_token2) { create(:personal_access_token, user: user2, expires_at: 2.days.from_now) }
      let(:users) { described_class.with_expiring_and_not_notified_personal_access_tokens(from) }

      context 'in one day' do
        let(:from) { 1.day.from_now }

        it "doesn't include an user" do
          expect(users).to be_empty
        end
      end

      context 'in three days' do
        let(:from) { 3.days.from_now }

        it 'only includes user2' do
          expect(users).to contain_exactly(user2)
        end
      end
    end
875 876 877 878

    describe '.active_without_ghosts' do
      let_it_be(:user1) { create(:user, :external) }
      let_it_be(:user2) { create(:user, state: 'blocked') }
879
      let_it_be(:user3) { create(:user, :ghost) }
880 881 882 883 884 885 886 887 888 889
      let_it_be(:user4) { create(:user) }

      it 'returns all active users but ghost users' do
        expect(described_class.active_without_ghosts).to match_array([user1, user4])
      end
    end

    describe '.without_ghosts' do
      let_it_be(:user1) { create(:user, :external) }
      let_it_be(:user2) { create(:user, state: 'blocked') }
890
      let_it_be(:user3) { create(:user, :ghost) }
891 892 893 894 895

      it 'returns users without ghosts users' do
        expect(described_class.without_ghosts).to match_array([user1, user2])
      end
    end
G
gitlabhq 已提交
896 897 898
  end

  describe "Respond to" do
B
blackst0ne 已提交
899
    it { is_expected.to respond_to(:admin?) }
900
    it { is_expected.to respond_to(:name) }
Z
Zeger-Jan van de Weg 已提交
901 902 903 904
    it { is_expected.to respond_to(:external?) }
  end

  describe 'before save hook' do
905
    describe '#default_private_profile_to_false' do
906 907 908 909 910 911 912 913 914 915
      let(:user) { create(:user, private_profile: true) }

      it 'converts nil to false' do
        user.private_profile = nil
        user.save!

        expect(user.private_profile).to eq false
      end
    end

Z
Zeger-Jan van de Weg 已提交
916 917 918 919 920 921 922 923 924 925
    context 'when saving an external user' do
      let(:user)          { create(:user) }
      let(:external_user) { create(:user, external: true) }

      it "sets other properties aswell" do
        expect(external_user.can_create_team).to be_falsey
        expect(external_user.can_create_group).to be_falsey
        expect(external_user.projects_limit).to be 0
      end
    end
926

927 928
    describe '#check_for_verified_email' do
      let(:user)      { create(:user) }
929 930
      let(:secondary) { create(:email, :confirmed, email: 'secondary@example.com', user: user) }

931
      it 'allows a verfied secondary email to be used as the primary without needing reconfirmation' do
L
Lin Jen-Shin 已提交
932
        user.update!(email: secondary.email)
933 934 935 936 937 938
        user.reload
        expect(user.email).to eq secondary.email
        expect(user.unconfirmed_email).to eq nil
        expect(user.confirmed?).to be_truthy
      end
    end
G
gitlabhq 已提交
939 940
  end

941
  describe 'after commit hook' do
942 943 944 945 946 947 948 949 950 951 952
    describe '#update_emails_with_primary_email' do
      before do
        @user = create(:user, email: 'primary@example.com').tap do |user|
          user.skip_reconfirmation!
        end
        @secondary = create :email, email: 'secondary@example.com', user: @user
        @user.reload
      end

      it 'gets called when email updated' do
        expect(@user).to receive(:update_emails_with_primary_email)
953

L
Lin Jen-Shin 已提交
954
        @user.update!(email: 'new_primary@example.com')
955 956
      end

957
      it 'adds old primary to secondary emails when secondary is a new email ' do
L
Lin Jen-Shin 已提交
958
        @user.update!(email: 'new_primary@example.com')
959
        @user.reload
960

961 962
        expect(@user.emails.count).to eq 2
        expect(@user.emails.pluck(:email)).to match_array([@secondary.email, 'primary@example.com'])
963 964 965
      end

      it 'adds old primary to secondary emails if secondary is becoming a primary' do
L
Lin Jen-Shin 已提交
966
        @user.update!(email: @secondary.email)
967
        @user.reload
968

969 970 971 972 973
        expect(@user.emails.count).to eq 1
        expect(@user.emails.first.email).to eq 'primary@example.com'
      end

      it 'transfers old confirmation values into new secondary' do
L
Lin Jen-Shin 已提交
974
        @user.update!(email: @secondary.email)
975
        @user.reload
976

977 978 979
        expect(@user.emails.count).to eq 1
        expect(@user.emails.first.confirmed_at).not_to eq nil
      end
980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081

      context 'when the first email was unconfirmed and the second email gets confirmed' do
        let(:user) { create(:user, :unconfirmed, email: 'should-be-unconfirmed@test.com') }

        before do
          user.update!(email: 'should-be-confirmed@test.com')
          user.confirm
        end

        it 'updates user.email' do
          expect(user.email).to eq('should-be-confirmed@test.com')
        end

        it 'confirms user.email' do
          expect(user).to be_confirmed
        end

        it 'keeps the unconfirmed email unconfirmed' do
          email = user.emails.first

          expect(email.email).to eq('should-be-unconfirmed@test.com')
          expect(email).not_to be_confirmed
        end

        it 'has only one email association' do
          expect(user.emails.size).to eq(1)
        end
      end
    end

    context 'when an existing email record is set as primary' do
      let(:user) { create(:user, email: 'confirmed@test.com') }

      context 'when it is unconfirmed' do
        let(:originally_unconfirmed_email) { 'should-stay-unconfirmed@test.com' }

        before do
          user.emails << create(:email, email: originally_unconfirmed_email, confirmed_at: nil)

          user.update!(email: originally_unconfirmed_email)
        end

        it 'keeps the user confirmed' do
          expect(user).to be_confirmed
        end

        it 'keeps the original email' do
          expect(user.email).to eq('confirmed@test.com')
        end

        context 'when the email gets confirmed' do
          before do
            user.confirm
          end

          it 'keeps the user confirmed' do
            expect(user).to be_confirmed
          end

          it 'updates the email' do
            expect(user.email).to eq(originally_unconfirmed_email)
          end
        end
      end

      context 'when it is confirmed' do
        let!(:old_confirmed_email) { user.email }
        let(:confirmed_email) { 'already-confirmed@test.com' }

        before do
          user.emails << create(:email, :confirmed, email: confirmed_email)

          user.update!(email: confirmed_email)
        end

        it 'keeps the user confirmed' do
          expect(user).to be_confirmed
        end

        it 'updates the email' do
          expect(user.email).to eq(confirmed_email)
        end

        it 'moves the old email' do
          email = user.reload.emails.first

          expect(email.email).to eq(old_confirmed_email)
          expect(email).to be_confirmed
        end
      end
    end

    context 'when unconfirmed user deletes a confirmed additional email' do
      let(:user) { create(:user, :unconfirmed) }

      before do
        user.emails << create(:email, :confirmed)
      end

      it 'does not affect the confirmed status' do
        expect { user.emails.confirmed.destroy_all }.not_to change { user.confirmed? } # rubocop: disable Cop/DestroyAll
      end
1082
    end
1083 1084

    describe '#update_notification_email' do
1085
      # Regression: https://gitlab.com/gitlab-org/gitlab-foss/issues/22846
1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143
      context 'when changing :email' do
        let(:user) { create(:user) }
        let(:new_email) { 'new-email@example.com' }

        it 'sets :unconfirmed_email' do
          expect do
            user.tap { |u| u.update!(email: new_email) }.reload
          end.to change(user, :unconfirmed_email).to(new_email)
        end
        it 'does not change :notification_email' do
          expect do
            user.tap { |u| u.update!(email: new_email) }.reload
          end.not_to change(user, :notification_email)
        end

        it 'updates :notification_email to the new email once confirmed' do
          user.update!(email: new_email)

          expect do
            user.tap(&:confirm).reload
          end.to change(user, :notification_email).to eq(new_email)
        end

        context 'and :notification_email is set to a secondary email' do
          let!(:email_attrs) { attributes_for(:email, :confirmed, user: user) }
          let(:secondary) { create(:email, :confirmed, email: 'secondary@example.com', user: user) }

          before do
            user.emails.create(email_attrs)
            user.tap { |u| u.update!(notification_email: email_attrs[:email]) }.reload
          end

          it 'does not change :notification_email to :email' do
            expect do
              user.tap { |u| u.update!(email: new_email) }.reload
            end.not_to change(user, :notification_email)
          end

          it 'does not change :notification_email to :email once confirmed' do
            user.update!(email: new_email)

            expect do
              user.tap(&:confirm).reload
            end.not_to change(user, :notification_email)
          end
        end
      end
    end

    describe '#update_invalid_gpg_signatures' do
      let(:user) do
        create(:user, email: 'tula.torphy@abshire.ca').tap do |user|
          user.skip_reconfirmation!
        end
      end

      it 'does nothing when the name is updated' do
        expect(user).not_to receive(:update_invalid_gpg_signatures)
L
Lin Jen-Shin 已提交
1144
        user.update!(name: 'Bette')
1145 1146 1147 1148
      end

      it 'synchronizes the gpg keys when the email is updated' do
        expect(user).to receive(:update_invalid_gpg_signatures).at_most(:twice)
L
Lin Jen-Shin 已提交
1149
        user.update!(email: 'shawnee.ritchie@denesik.com')
1150 1151
      end
    end
1152 1153
  end

1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165
  describe 'name getters' do
    let(:user) { create(:user, name: 'Kane Martin William') }

    it 'derives first name from full name, if not present' do
      expect(user.first_name).to eq('Kane')
    end

    it 'derives last name from full name, if not present' do
      expect(user.last_name).to eq('Martin William')
    end
  end

T
Thiago Presa 已提交
1166
  describe '#highest_role' do
1167
    let_it_be(:user) { create(:user) }
1168

1169 1170 1171
    context 'when user_highest_role does not exist' do
      it 'returns NO_ACCESS' do
        expect(user.highest_role).to eq(Gitlab::Access::NO_ACCESS)
1172 1173 1174
      end
    end

1175 1176 1177 1178
    context 'when user_highest_role exists' do
      context 'stored highest access level is nil' do
        it 'returns Gitlab::Access::NO_ACCESS' do
          create(:user_highest_role, user: user)
T
Thiago Presa 已提交
1179

1180 1181
          expect(user.highest_role).to eq(Gitlab::Access::NO_ACCESS)
        end
T
Thiago Presa 已提交
1182 1183
      end

1184 1185 1186
      context 'stored highest access level present' do
        context 'with association :user_highest_role' do
          let(:another_user) { create(:user) }
T
Thiago Presa 已提交
1187

1188 1189 1190 1191
          before do
            create(:user_highest_role, :maintainer, user: user)
            create(:user_highest_role, :developer, user: another_user)
          end
T
Thiago Presa 已提交
1192

1193 1194
          it 'returns the correct highest role' do
            users = User.includes(:user_highest_role).where(id: [user.id, another_user.id])
T
Thiago Presa 已提交
1195

1196 1197 1198 1199 1200 1201
            expect(users.collect { |u| [u.id, u.highest_role] }).to contain_exactly(
              [user.id, Gitlab::Access::MAINTAINER],
              [another_user.id, Gitlab::Access::DEVELOPER]
            )
          end
        end
T
Thiago Presa 已提交
1202 1203 1204 1205
      end
    end
  end

1206
  describe '#update_tracked_fields!', :clean_gitlab_redis_shared_state do
1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220
    let(:request) { OpenStruct.new(remote_ip: "127.0.0.1") }
    let(:user) { create(:user) }

    it 'writes trackable attributes' do
      expect do
        user.update_tracked_fields!(request)
      end.to change { user.reload.current_sign_in_at }
    end

    it 'does not write trackable attributes when called a second time within the hour' do
      user.update_tracked_fields!(request)

      expect do
        user.update_tracked_fields!(request)
1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231
      end.not_to change { user.reload.current_sign_in_at }
    end

    it 'writes trackable attributes for a different user' do
      user2 = create(:user)

      user.update_tracked_fields!(request)

      expect do
        user2.update_tracked_fields!(request)
      end.to change { user2.reload.current_sign_in_at }
1232
    end
1233 1234 1235 1236 1237 1238 1239 1240

    it 'does not write if the DB is in read-only mode' do
      expect(Gitlab::Database).to receive(:read_only?).and_return(true)

      expect do
        user.update_tracked_fields!(request)
      end.not_to change { user.reload.current_sign_in_at }
    end
1241 1242
  end

1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259
  shared_context 'user keys' do
    let(:user) { create(:user) }
    let!(:key) { create(:key, user: user) }
    let!(:deploy_key) { create(:deploy_key, user: user) }
  end

  describe '#keys' do
    include_context 'user keys'

    context 'with key and deploy key stored' do
      it 'returns stored key, but not deploy_key' do
        expect(user.keys).to include key
        expect(user.keys).not_to include deploy_key
      end
    end
  end

1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277
  describe '#accessible_deploy_keys' do
    let(:user) { create(:user) }
    let(:project) { create(:project) }
    let!(:private_deploy_keys_project) { create(:deploy_keys_project) }
    let!(:public_deploy_keys_project) { create(:deploy_keys_project) }
    let!(:accessible_deploy_keys_project) { create(:deploy_keys_project, project: project) }

    before do
      public_deploy_keys_project.deploy_key.update(public: true)
      project.add_developer(user)
    end

    it 'user can only see deploy keys accessible to right projects' do
      expect(user.accessible_deploy_keys).to match_array([public_deploy_keys_project.deploy_key,
                                                          accessible_deploy_keys_project.deploy_key])
    end
  end

1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288
  describe '#deploy_keys' do
    include_context 'user keys'

    context 'with key and deploy key stored' do
      it 'returns stored deploy key, but not normal key' do
        expect(user.deploy_keys).to include deploy_key
        expect(user.deploy_keys).not_to include key
      end
    end
  end

1289
  describe '#confirm' do
1290 1291 1292
    before do
      allow_any_instance_of(ApplicationSetting).to receive(:send_user_confirmation_email).and_return(true)
    end
1293

1294 1295 1296 1297 1298 1299 1300
    let(:user) { create(:user, confirmed_at: nil, unconfirmed_email: 'test@gitlab.com') }

    it 'returns unconfirmed' do
      expect(user.confirmed?).to be_falsey
    end

    it 'confirms a user' do
1301
      user.confirm
1302 1303 1304 1305
      expect(user.confirmed?).to be_truthy
    end
  end

1306 1307 1308 1309 1310 1311 1312 1313
  describe '#to_reference' do
    let(:user) { create(:user) }

    it 'returns a String reference to the object' do
      expect(user.to_reference).to eq "@#{user.username}"
    end
  end

1314
  describe '#generate_password' do
1315
    it "does not generate password by default" do
1316
      user = create(:user, password: 'abcdefghe')
1317

1318
      expect(user.password).to eq('abcdefghe')
1319
    end
1320 1321
  end

1322 1323 1324 1325 1326 1327 1328 1329 1330
  describe 'ensure user preference' do
    it 'has user preference upon user initialization' do
      user = build(:user)

      expect(user.user_preference).to be_present
      expect(user.user_preference).not_to be_persisted
    end
  end

1331 1332 1333
  describe 'ensure incoming email token' do
    it 'has incoming email token' do
      user = create(:user)
1334

1335 1336
      expect(user.incoming_email_token).not_to be_blank
    end
1337 1338

    it 'uses SecureRandom to generate the incoming email token' do
1339 1340 1341 1342
      allow_next_instance_of(User) do |user|
        allow(user).to receive(:update_highest_role)
      end

1343 1344 1345 1346 1347 1348
      expect(SecureRandom).to receive(:hex).and_return('3b8ca303')

      user = create(:user)

      expect(user.incoming_email_token).to eql('gitlab')
    end
1349 1350
  end

1351 1352 1353 1354 1355 1356 1357
  describe '#ensure_user_rights_and_limits' do
    describe 'with external user' do
      let(:user) { create(:user, external: true) }

      it 'receives callback when external changes' do
        expect(user).to receive(:ensure_user_rights_and_limits)

L
Lin Jen-Shin 已提交
1358
        user.update(external: false)
1359 1360 1361
      end

      it 'ensures correct rights and limits for user' do
T
Tiago Botelho 已提交
1362 1363
        stub_config_setting(default_can_create_group: true)

L
Lin Jen-Shin 已提交
1364
        expect { user.update(external: false) }.to change { user.can_create_group }.to(true)
1365
          .and change { user.projects_limit }.to(Gitlab::CurrentSettings.default_projects_limit)
1366 1367 1368 1369 1370 1371 1372 1373 1374
      end
    end

    describe 'without external user' do
      let(:user) { create(:user, external: false) }

      it 'receives callback when external changes' do
        expect(user).to receive(:ensure_user_rights_and_limits)

L
Lin Jen-Shin 已提交
1375
        user.update(external: true)
1376 1377 1378
      end

      it 'ensures correct rights and limits for user' do
L
Lin Jen-Shin 已提交
1379
        expect { user.update(external: true) }.to change { user.can_create_group }.to(false)
1380 1381 1382 1383 1384
          .and change { user.projects_limit }.to(0)
      end
    end
  end

1385 1386 1387 1388
  describe 'feed token' do
    it 'ensures a feed token on read' do
      user = create(:user, feed_token: nil)
      feed_token = user.feed_token
1389

1390 1391
      expect(feed_token).not_to be_blank
      expect(user.reload.feed_token).to eq feed_token
1392 1393 1394
    end
  end

1395 1396 1397 1398 1399 1400 1401 1402 1403 1404
  describe 'static object token' do
    it 'ensures a static object token on read' do
      user = create(:user, static_object_token: nil)
      static_object_token = user.static_object_token

      expect(static_object_token).not_to be_blank
      expect(user.reload.static_object_token).to eq static_object_token
    end
  end

1405
  describe '#recently_sent_password_reset?' do
1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418
    it 'is false when reset_password_sent_at is nil' do
      user = build_stubbed(:user, reset_password_sent_at: nil)

      expect(user.recently_sent_password_reset?).to eq false
    end

    it 'is false when sent more than one minute ago' do
      user = build_stubbed(:user, reset_password_sent_at: 5.minutes.ago)

      expect(user.recently_sent_password_reset?).to eq false
    end

    it 'is true when sent less than one minute ago' do
1419
      user = build_stubbed(:user, reset_password_sent_at: Time.current)
1420 1421 1422 1423 1424

      expect(user.recently_sent_password_reset?).to eq true
    end
  end

R
Robert Speicher 已提交
1425 1426 1427 1428 1429 1430 1431
  describe '#disable_two_factor!' do
    it 'clears all 2FA-related fields' do
      user = create(:user, :two_factor)

      expect(user).to be_two_factor_enabled
      expect(user.encrypted_otp_secret).not_to be_nil
      expect(user.otp_backup_codes).not_to be_nil
1432
      expect(user.otp_grace_period_started_at).not_to be_nil
R
Robert Speicher 已提交
1433 1434 1435 1436 1437 1438 1439 1440

      user.disable_two_factor!

      expect(user).not_to be_two_factor_enabled
      expect(user.encrypted_otp_secret).to be_nil
      expect(user.encrypted_otp_secret_iv).to be_nil
      expect(user.encrypted_otp_secret_salt).to be_nil
      expect(user.otp_backup_codes).to be_nil
1441
      expect(user.otp_grace_period_started_at).to be_nil
R
Robert Speicher 已提交
1442 1443 1444
    end
  end

1445 1446
  describe 'projects' do
    before do
1447
      @user = create(:user)
1448

1449 1450
      @project = create(:project, namespace: @user.namespace)
      @project_2 = create(:project, group: create(:group)) do |project|
1451
        project.add_maintainer(@user)
1452
      end
1453
      @project_3 = create(:project, group: create(:group)) do |project|
1454 1455
        project.add_developer(@user)
      end
1456 1457
    end

1458 1459 1460 1461 1462 1463 1464 1465 1466
    it { expect(@user.authorized_projects).to include(@project) }
    it { expect(@user.authorized_projects).to include(@project_2) }
    it { expect(@user.authorized_projects).to include(@project_3) }
    it { expect(@user.owned_projects).to include(@project) }
    it { expect(@user.owned_projects).not_to include(@project_2) }
    it { expect(@user.owned_projects).not_to include(@project_3) }
    it { expect(@user.personal_projects).to include(@project) }
    it { expect(@user.personal_projects).not_to include(@project_2) }
    it { expect(@user.personal_projects).not_to include(@project_3) }
1467 1468 1469
  end

  describe 'groups' do
1470 1471 1472
    let(:user) { create(:user) }
    let(:group) { create(:group) }

1473
    before do
1474
      group.add_owner(user)
1475 1476
    end

1477 1478 1479 1480 1481 1482
    it { expect(user.several_namespaces?).to be_truthy }
    it { expect(user.authorized_groups).to eq([group]) }
    it { expect(user.owned_groups).to eq([group]) }
    it { expect(user.namespaces).to contain_exactly(user.namespace, group) }
    it { expect(user.manageable_namespaces).to contain_exactly(user.namespace, group) }

1483
    context 'with child groups' do
1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502
      let!(:subgroup) { create(:group, parent: group) }

      describe '#manageable_namespaces' do
        it 'includes all the namespaces the user can manage' do
          expect(user.manageable_namespaces).to contain_exactly(user.namespace, group, subgroup)
        end
      end

      describe '#manageable_groups' do
        it 'includes all the namespaces the user can manage' do
          expect(user.manageable_groups).to contain_exactly(group, subgroup)
        end

        it 'does not include duplicates if a membership was added for the subgroup' do
          subgroup.add_owner(user)

          expect(user.manageable_groups).to contain_exactly(group, subgroup)
        end
      end
1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517

      describe '#manageable_groups_with_routes' do
        it 'eager loads routes from manageable groups' do
          control_count =
            ActiveRecord::QueryRecorder.new(skip_cached: false) do
              user.manageable_groups_with_routes.map(&:route)
            end.count

          create(:group, parent: subgroup)

          expect do
            user.manageable_groups_with_routes.map(&:route)
          end.not_to exceed_all_query_limit(control_count)
        end
      end
1518
    end
1519 1520
  end

1521 1522 1523 1524
  describe 'group multiple owners' do
    before do
      @user = create :user
      @user2 = create :user
1525 1526
      @group = create :group
      @group.add_owner(@user)
1527

1528
      @group.add_user(@user2, GroupMember::OWNER)
1529 1530
    end

1531
    it { expect(@user2.several_namespaces?).to be_truthy }
1532 1533
  end

1534 1535 1536
  describe 'namespaced' do
    before do
      @user = create :user
1537
      @project = create(:project, namespace: @user.namespace)
1538 1539
    end

1540
    it { expect(@user.several_namespaces?).to be_falsey }
1541
    it { expect(@user.namespaces).to eq([@user.namespace]) }
1542 1543 1544 1545 1546
  end

  describe 'blocking user' do
    let(:user) { create(:user, name: 'John Smith') }

1547
    it 'blocks user' do
1548
      user.block
1549

1550
      expect(user.blocked?).to be_truthy
1551
    end
1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567

    context 'when user has running CI pipelines' do
      let(:service) { double }

      before do
        pipeline = create(:ci_pipeline, :running, user: user)
        create(:ci_build, :running, pipeline: pipeline)
      end

      it 'cancels all running pipelines and related jobs' do
        expect(Ci::CancelUserPipelinesService).to receive(:new).and_return(service)
        expect(service).to receive(:execute).with(user)

        user.block
      end
    end
1568 1569
  end

1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593
  describe 'deactivating a user' do
    let(:user) { create(:user, name: 'John Smith') }

    context "an active user" do
      it "can be deactivated" do
        user.deactivate

        expect(user.deactivated?).to be_truthy
      end
    end

    context "a user who is blocked" do
      before do
        user.block
      end

      it "cannot be deactivated" do
        user.deactivate

        expect(user.reload.deactivated?).to be_falsy
      end
    end
  end

1594
  describe '.filter_items' do
1595 1596 1597
    let(:user) { double }

    it 'filters by active users by default' do
1598
      expect(described_class).to receive(:active_without_ghosts).and_return([user])
1599

1600
      expect(described_class.filter_items(nil)).to include user
1601 1602
    end

1603
    it 'filters by admins' do
1604
      expect(described_class).to receive(:admins).and_return([user])
1605

1606
      expect(described_class.filter_items('admins')).to include user
1607 1608
    end

1609
    it 'filters by blocked' do
1610
      expect(described_class).to receive(:blocked).and_return([user])
1611

1612
      expect(described_class.filter_items('blocked')).to include user
1613 1614
    end

1615 1616 1617 1618 1619 1620
    it 'filters by deactivated' do
      expect(described_class).to receive(:deactivated).and_return([user])

      expect(described_class.filter_items('deactivated')).to include user
    end

1621
    it 'filters by two_factor_disabled' do
1622
      expect(described_class).to receive(:without_two_factor).and_return([user])
1623

1624
      expect(described_class.filter_items('two_factor_disabled')).to include user
1625 1626 1627
    end

    it 'filters by two_factor_enabled' do
1628
      expect(described_class).to receive(:with_two_factor).and_return([user])
1629

1630
      expect(described_class.filter_items('two_factor_enabled')).to include user
1631 1632 1633
    end

    it 'filters by wop' do
1634
      expect(described_class).to receive(:without_projects).and_return([user])
1635

1636
      expect(described_class.filter_items('wop')).to include user
1637
    end
1638 1639
  end

B
Ben Bodenmiller 已提交
1640
  describe '.without_projects' do
1641
    let!(:project) { create(:project, :public) }
B
Ben Bodenmiller 已提交
1642 1643 1644 1645 1646 1647
    let!(:user) { create(:user) }
    let!(:user_without_project) { create(:user) }
    let!(:user_without_project2) { create(:user) }

    before do
      # add user to project
1648
      project.add_maintainer(user)
B
Ben Bodenmiller 已提交
1649 1650 1651 1652 1653 1654 1655 1656

      # create invite to projet
      create(:project_member, :developer, project: project, invite_token: '1234', invite_email: 'inviteduser1@example.com')

      # create request to join project
      project.request_access(user_without_project2)
    end

1657 1658 1659
    it { expect(described_class.without_projects).not_to include user }
    it { expect(described_class.without_projects).to include user_without_project }
    it { expect(described_class.without_projects).to include user_without_project2 }
B
Ben Bodenmiller 已提交
1660 1661
  end

1662 1663 1664
  describe 'user creation' do
    describe 'normal user' do
      let(:user) { create(:user, name: 'John Smith') }
D
Dmitriy Zaporozhets 已提交
1665

B
blackst0ne 已提交
1666
      it { expect(user.admin?).to be_falsey }
1667 1668 1669 1670
      it { expect(user.require_ssh_key?).to be_truthy }
      it { expect(user.can_create_group?).to be_truthy }
      it { expect(user.can_create_project?).to be_truthy }
      it { expect(user.first_name).to eq('John') }
1671
      it { expect(user.external).to be_falsey }
1672
    end
1673

D
Dmitriy Zaporozhets 已提交
1674
    describe 'with defaults' do
1675
      let(:user) { described_class.new }
D
Dmitriy Zaporozhets 已提交
1676

1677
      it "applies defaults to user" do
1678 1679
        expect(user.projects_limit).to eq(Gitlab.config.gitlab.default_projects_limit)
        expect(user.can_create_group).to eq(Gitlab.config.gitlab.default_can_create_group)
1680
        expect(user.theme_id).to eq(Gitlab.config.gitlab.default_theme)
Z
Zeger-Jan van de Weg 已提交
1681
        expect(user.external).to be_falsey
1682
        expect(user.private_profile).to eq(false)
1683 1684 1685
      end
    end

D
Dmitriy Zaporozhets 已提交
1686
    describe 'with default overrides' do
1687
      let(:user) { described_class.new(projects_limit: 123, can_create_group: false, can_create_team: true) }
D
Dmitriy Zaporozhets 已提交
1688

1689
      it "applies defaults to user" do
1690 1691
        expect(user.projects_limit).to eq(123)
        expect(user.can_create_group).to be_falsey
1692
        expect(user.theme_id).to eq(1)
1693
      end
1694 1695 1696 1697 1698 1699 1700

      it 'does not undo projects_limit setting if it matches old DB default of 10' do
        # If the real default project limit is 10 then this test is worthless
        expect(Gitlab.config.gitlab.default_projects_limit).not_to eq(10)
        user = described_class.new(projects_limit: 10)
        expect(user.projects_limit).to eq(10)
      end
1701
    end
1702

1703
    context 'when Gitlab::CurrentSettings.user_default_external is true' do
1704 1705 1706 1707 1708
      before do
        stub_application_setting(user_default_external: true)
      end

      it "creates external user by default" do
1709
        user = create(:user)
1710 1711

        expect(user.external).to be_truthy
1712 1713
        expect(user.can_create_group).to be_falsey
        expect(user.projects_limit).to be 0
1714 1715 1716 1717
      end

      describe 'with default overrides' do
        it "creates a non-external user" do
1718
          user = create(:user, external: false)
1719 1720 1721 1722 1723

          expect(user.external).to be_falsey
        end
      end
    end
1724

Y
Yorick Peterse 已提交
1725
    describe '#require_ssh_key?', :use_clean_rails_memory_store_caching do
1726 1727 1728
      protocol_and_expectation = {
        'http' => false,
        'ssh' => true,
1729
        '' => true
1730 1731 1732 1733 1734 1735 1736 1737 1738
      }

      protocol_and_expectation.each do |protocol, expected|
        it "has correct require_ssh_key?" do
          stub_application_setting(enabled_git_access_protocol: protocol)
          user = build(:user)

          expect(user.require_ssh_key?).to eq(expected)
        end
1739
      end
Y
Yorick Peterse 已提交
1740 1741 1742 1743 1744 1745

      it 'returns false when the user has 1 or more SSH keys' do
        key = create(:personal_key)

        expect(key.user.require_ssh_key?).to eq(false)
      end
1746
    end
1747
  end
1748

1749 1750 1751 1752 1753 1754 1755 1756
  describe '.find_for_database_authentication' do
    it 'strips whitespace from login' do
      user = create(:user)

      expect(described_class.find_for_database_authentication({ login: " #{user.username} " })).to eq user
    end
  end

1757
  describe '.find_by_any_email' do
1758 1759 1760 1761 1762 1763 1764 1765
    it 'finds user through private commit email' do
      user = create(:user)
      private_email = user.private_commit_email

      expect(described_class.find_by_any_email(private_email)).to eq(user)
      expect(described_class.find_by_any_email(private_email, confirmed: true)).to eq(user)
    end

1766 1767 1768
    it 'finds by primary email' do
      user = create(:user, email: 'foo@example.com')

1769
      expect(described_class.find_by_any_email(user.email)).to eq user
1770
      expect(described_class.find_by_any_email(user.email, confirmed: true)).to eq user
1771 1772
    end

1773 1774 1775 1776 1777 1778 1779
    it 'finds by uppercased email' do
      user = create(:user, email: 'foo@example.com')

      expect(described_class.find_by_any_email(user.email.upcase)).to eq user
      expect(described_class.find_by_any_email(user.email.upcase, confirmed: true)).to eq user
    end

1780 1781
    context 'finds by secondary email' do
      let(:user) { email.user }
1782

1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811
      context 'primary email confirmed' do
        context 'secondary email confirmed' do
          let!(:email) { create(:email, :confirmed, email: 'foo@example.com') }

          it 'finds user respecting the confirmed flag' do
            expect(described_class.find_by_any_email(email.email)).to eq user
            expect(described_class.find_by_any_email(email.email, confirmed: true)).to eq user
          end
        end

        context 'secondary email not confirmed' do
          let!(:email) { create(:email, email: 'foo@example.com') }

          it 'finds user respecting the confirmed flag' do
            expect(described_class.find_by_any_email(email.email)).to eq user
            expect(described_class.find_by_any_email(email.email, confirmed: true)).to be_nil
          end
        end
      end

      context 'primary email not confirmed' do
        let(:user) { create(:user, confirmed_at: nil) }
        let!(:email) { create(:email, :confirmed, user: user, email: 'foo@example.com') }

        it 'finds user respecting the confirmed flag' do
          expect(described_class.find_by_any_email(email.email)).to eq user
          expect(described_class.find_by_any_email(email.email, confirmed: true)).to be_nil
        end
      end
1812 1813 1814
    end

    it 'returns nil when nothing found' do
1815
      expect(described_class.find_by_any_email('')).to be_nil
1816
    end
1817 1818 1819 1820 1821 1822 1823

    it 'returns nil when user is not confirmed' do
      user = create(:user, email: 'foo@example.com', confirmed_at: nil)

      expect(described_class.find_by_any_email(user.email, confirmed: false)).to eq(user)
      expect(described_class.find_by_any_email(user.email, confirmed: true)).to be_nil
    end
1824 1825
  end

Y
Yorick Peterse 已提交
1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836
  describe '.by_any_email' do
    it 'returns an ActiveRecord::Relation' do
      expect(described_class.by_any_email('foo@example.com'))
        .to be_a_kind_of(ActiveRecord::Relation)
    end

    it 'returns a relation of users' do
      user = create(:user)

      expect(described_class.by_any_email(user.email)).to eq([user])
    end
1837 1838 1839 1840 1841 1842

    it 'returns a relation of users for confirmed users' do
      user = create(:user)

      expect(described_class.by_any_email(user.email, confirmed: true)).to eq([user])
    end
1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858

    it 'finds user through a private commit email' do
      user = create(:user)
      private_email = user.private_commit_email

      expect(described_class.by_any_email(private_email)).to eq([user])
      expect(described_class.by_any_email(private_email, confirmed: true)).to eq([user])
    end

    it 'finds user through a private commit email in an array' do
      user = create(:user)
      private_email = user.private_commit_email

      expect(described_class.by_any_email([private_email])).to eq([user])
      expect(described_class.by_any_email([private_email], confirmed: true)).to eq([user])
    end
Y
Yorick Peterse 已提交
1859 1860
  end

1861
  describe '.search' do
1862 1863
    let!(:user) { create(:user, name: 'user', username: 'usern', email: 'email@gmail.com') }
    let!(:user2) { create(:user, name: 'user name', username: 'username', email: 'someemail@gmail.com') }
1864
    let!(:user3) { create(:user, name: 'us', username: 'se', email: 'foo@gmail.com') }
1865

1866 1867 1868 1869
    describe 'name matching' do
      it 'returns users with a matching name with exact match first' do
        expect(described_class.search(user.name)).to eq([user, user2])
      end
1870

1871
      it 'returns users with a partially matching name' do
1872
        expect(described_class.search(user.name[0..2])).to eq([user, user2])
1873
      end
1874

1875 1876 1877
      it 'returns users with a matching name regardless of the casing' do
        expect(described_class.search(user2.name.upcase)).to eq([user2])
      end
1878 1879 1880 1881 1882 1883 1884 1885

      it 'returns users with a exact matching name shorter than 3 chars' do
        expect(described_class.search(user3.name)).to eq([user3])
      end

      it 'returns users with a exact matching name shorter than 3 chars regardless of the casing' do
        expect(described_class.search(user3.name.upcase)).to eq([user3])
      end
1886 1887
    end

1888 1889
    describe 'email matching' do
      it 'returns users with a matching Email' do
1890
        expect(described_class.search(user.email)).to eq([user])
1891
      end
1892

1893 1894
      it 'does not return users with a partially matching Email' do
        expect(described_class.search(user.email[0..2])).not_to include(user, user2)
1895
      end
1896

1897 1898 1899
      it 'returns users with a matching Email regardless of the casing' do
        expect(described_class.search(user2.email.upcase)).to eq([user2])
      end
1900 1901
    end

1902 1903 1904 1905
    describe 'username matching' do
      it 'returns users with a matching username' do
        expect(described_class.search(user.username)).to eq([user, user2])
      end
1906

1907 1908 1909 1910
      it 'returns users with a matching username starting with a @' do
        expect(described_class.search("@#{user.username}")).to eq([user, user2])
      end

1911
      it 'returns users with a partially matching username' do
1912
        expect(described_class.search(user.username[0..2])).to eq([user, user2])
1913
      end
1914

1915 1916 1917 1918
      it 'returns users with a partially matching username starting with @' do
        expect(described_class.search("@#{user.username[0..2]}")).to eq([user, user2])
      end

1919 1920 1921
      it 'returns users with a matching username regardless of the casing' do
        expect(described_class.search(user2.username.upcase)).to eq([user2])
      end
1922 1923 1924 1925 1926 1927 1928 1929

      it 'returns users with a exact matching username shorter than 3 chars' do
        expect(described_class.search(user3.username)).to eq([user3])
      end

      it 'returns users with a exact matching username shorter than 3 chars regardless of the casing' do
        expect(described_class.search(user3.username.upcase)).to eq([user3])
      end
M
Marin Jankovski 已提交
1930
    end
1931 1932 1933 1934 1935 1936 1937 1938

    it 'returns no matches for an empty string' do
      expect(described_class.search('')).to be_empty
    end

    it 'returns no matches for nil' do
      expect(described_class.search(nil)).to be_empty
    end
1939 1940 1941
  end

  describe '.search_with_secondary_emails' do
D
Douwe Maan 已提交
1942
    delegate :search_with_secondary_emails, to: :described_class
1943

1944 1945
    let!(:user) { create(:user, name: 'John Doe', username: 'john.doe', email: 'john.doe@example.com' ) }
    let!(:another_user) { create(:user, name: 'Albert Smith', username: 'albert.smith', email: 'albert.smith@example.com' ) }
1946 1947 1948
    let!(:email) do
      create(:email, user: another_user, email: 'alias@example.com')
    end
1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965

    it 'returns users with a matching name' do
      expect(search_with_secondary_emails(user.name)).to eq([user])
    end

    it 'returns users with a partially matching name' do
      expect(search_with_secondary_emails(user.name[0..2])).to eq([user])
    end

    it 'returns users with a matching name regardless of the casing' do
      expect(search_with_secondary_emails(user.name.upcase)).to eq([user])
    end

    it 'returns users with a matching email' do
      expect(search_with_secondary_emails(user.email)).to eq([user])
    end

1966 1967
    it 'does not return users with a partially matching email' do
      expect(search_with_secondary_emails(user.email[0..2])).not_to include([user])
1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989
    end

    it 'returns users with a matching email regardless of the casing' do
      expect(search_with_secondary_emails(user.email.upcase)).to eq([user])
    end

    it 'returns users with a matching username' do
      expect(search_with_secondary_emails(user.username)).to eq([user])
    end

    it 'returns users with a partially matching username' do
      expect(search_with_secondary_emails(user.username[0..2])).to eq([user])
    end

    it 'returns users with a matching username regardless of the casing' do
      expect(search_with_secondary_emails(user.username.upcase)).to eq([user])
    end

    it 'returns users with a matching whole secondary email' do
      expect(search_with_secondary_emails(email.email)).to eq([email.user])
    end

1990 1991
    it 'does not return users with a matching part of secondary email' do
      expect(search_with_secondary_emails(email.email[1..4])).not_to include([email.user])
1992
    end
1993 1994 1995 1996 1997 1998 1999 2000

    it 'returns no matches for an empty string' do
      expect(search_with_secondary_emails('')).to be_empty
    end

    it 'returns no matches for nil' do
      expect(search_with_secondary_emails(nil)).to be_empty
    end
M
Marin Jankovski 已提交
2001 2002
  end

Y
Yorick Peterse 已提交
2003
  describe '.find_by_ssh_key_id' do
2004 2005
    let_it_be(:user) { create(:user) }
    let_it_be(:key) { create(:key, user: user) }
Y
Yorick Peterse 已提交
2006

2007
    context 'using an existing SSH key ID' do
Y
Yorick Peterse 已提交
2008 2009 2010 2011 2012
      it 'returns the corresponding User' do
        expect(described_class.find_by_ssh_key_id(key.id)).to eq(user)
      end
    end

2013 2014 2015 2016 2017 2018 2019
    it 'only performs a single query' do
      key # Don't count the queries for creating the key and user

      expect { described_class.find_by_ssh_key_id(key.id) }
        .not_to exceed_query_limit(1)
    end

Y
Yorick Peterse 已提交
2020 2021 2022 2023 2024 2025 2026
    context 'using an invalid SSH key ID' do
      it 'returns nil' do
        expect(described_class.find_by_ssh_key_id(-1)).to be_nil
      end
    end
  end

2027 2028 2029 2030
  describe '.by_login' do
    let(:username) { 'John' }
    let!(:user) { create(:user, username: username) }

2031
    it 'gets the correct user' do
2032 2033 2034 2035 2036 2037
      expect(described_class.by_login(user.email.upcase)).to eq user
      expect(described_class.by_login(user.email)).to eq user
      expect(described_class.by_login(username.downcase)).to eq user
      expect(described_class.by_login(username)).to eq user
      expect(described_class.by_login(nil)).to be_nil
      expect(described_class.by_login('')).to be_nil
2038 2039 2040
    end
  end

2041 2042 2043 2044 2045 2046 2047
  describe '.find_by_username' do
    it 'returns nil if not found' do
      expect(described_class.find_by_username('JohnDoe')).to be_nil
    end

    it 'is case-insensitive' do
      user = create(:user, username: 'JohnDoe')
2048

2049 2050 2051 2052
      expect(described_class.find_by_username('JOHNDOE')).to eq user
    end
  end

R
Robert Speicher 已提交
2053 2054
  describe '.find_by_username!' do
    it 'raises RecordNotFound' do
2055 2056
      expect { described_class.find_by_username!('JohnDoe') }
        .to raise_error(ActiveRecord::RecordNotFound)
R
Robert Speicher 已提交
2057 2058 2059 2060
    end

    it 'is case-insensitive' do
      user = create(:user, username: 'JohnDoe')
2061

R
Robert Speicher 已提交
2062 2063 2064 2065
      expect(described_class.find_by_username!('JOHNDOE')).to eq user
    end
  end

2066 2067 2068 2069 2070 2071 2072
  describe '.find_by_full_path' do
    let!(:user) { create(:user) }

    context 'with a route matching the given path' do
      let!(:route) { user.namespace.route }

      it 'returns the user' do
2073
        expect(described_class.find_by_full_path(route.path)).to eq(user)
2074 2075 2076
      end

      it 'is case-insensitive' do
2077 2078
        expect(described_class.find_by_full_path(route.path.upcase)).to eq(user)
        expect(described_class.find_by_full_path(route.path.downcase)).to eq(user)
2079 2080 2081 2082 2083 2084 2085 2086
      end
    end

    context 'with a redirect route matching the given path' do
      let!(:redirect_route) { user.namespace.redirect_routes.create(path: 'foo') }

      context 'without the follow_redirects option' do
        it 'returns nil' do
2087
          expect(described_class.find_by_full_path(redirect_route.path)).to eq(nil)
2088 2089 2090 2091 2092
        end
      end

      context 'with the follow_redirects option set to true' do
        it 'returns the user' do
2093
          expect(described_class.find_by_full_path(redirect_route.path, follow_redirects: true)).to eq(user)
2094 2095 2096
        end

        it 'is case-insensitive' do
2097 2098
          expect(described_class.find_by_full_path(redirect_route.path.upcase, follow_redirects: true)).to eq(user)
          expect(described_class.find_by_full_path(redirect_route.path.downcase, follow_redirects: true)).to eq(user)
2099 2100 2101 2102 2103 2104 2105
        end
      end
    end

    context 'without a route or a redirect route matching the given path' do
      context 'without the follow_redirects option' do
        it 'returns nil' do
2106
          expect(described_class.find_by_full_path('unknown')).to eq(nil)
2107 2108 2109 2110
        end
      end
      context 'with the follow_redirects option set to true' do
        it 'returns nil' do
2111
          expect(described_class.find_by_full_path('unknown', follow_redirects: true)).to eq(nil)
2112 2113 2114 2115 2116
        end
      end
    end

    context 'with a group route matching the given path' do
2117 2118
      let!(:group) { create(:group, path: 'group_path') }

M
Michael Kozono 已提交
2119
      context 'when the group namespace has an owner_id (legacy data)' do
2120 2121 2122
        before do
          group.update!(owner_id: user.id)
        end
2123

M
Michael Kozono 已提交
2124
        it 'returns nil' do
2125
          expect(described_class.find_by_full_path('group_path')).to eq(nil)
M
Michael Kozono 已提交
2126 2127 2128 2129 2130
        end
      end

      context 'when the group namespace does not have an owner_id' do
        it 'returns nil' do
2131
          expect(described_class.find_by_full_path('group_path')).to eq(nil)
M
Michael Kozono 已提交
2132
        end
2133 2134 2135 2136
      end
    end
  end

G
GitLab 已提交
2137
  describe 'all_ssh_keys' do
2138
    it { is_expected.to have_many(:keys).dependent(:destroy) }
G
GitLab 已提交
2139

2140
    it "has all ssh keys" do
G
GitLab 已提交
2141 2142 2143
      user = create :user
      key = create :key, key: "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQD33bWLBxu48Sev9Fert1yzEO4WGcWglWF7K/AwblIUFselOt/QdOL9DSjpQGxLagO1s9wl53STIO8qGS4Ms0EJZyIXOEFMjFJ5xmjSy+S37By4sG7SsltQEHMxtbtFOaW5LV2wCrX+rUsRNqLMamZjgjcPO0/EgGCXIGMAYW4O7cwGZdXWYIhQ1Vwy+CsVMDdPkPgBXqK7nR/ey8KMs8ho5fMNgB5hBw/AL9fNGhRw3QTD6Q12Nkhl4VZES2EsZqlpNnJttnPdp847DUsT6yuLRlfiQfz5Cn9ysHFdXObMN5VYIiPFwHeYCZp1X2S4fDZooRE8uOLTfxWHPXwrhqSH", user_id: user.id

2144
      expect(user.all_ssh_keys).to include(a_string_starting_with(key.key))
G
GitLab 已提交
2145
    end
G
GitLab 已提交
2146
  end
2147

2148
  describe '#avatar_type' do
D
Dmitriy Zaporozhets 已提交
2149 2150
    let(:user) { create(:user) }

2151
    it 'is true if avatar is image' do
D
Dmitriy Zaporozhets 已提交
2152
      user.update_attribute(:avatar, 'uploads/avatar.png')
2153

2154
      expect(user.avatar_type).to be_truthy
D
Dmitriy Zaporozhets 已提交
2155 2156
    end

2157
    it 'is false if avatar is html page' do
D
Dmitriy Zaporozhets 已提交
2158
      user.update_attribute(:avatar, 'uploads/avatar.html')
2159

2160
      expect(user.avatar_type).to eq(['file format is not supported. Please try one of the following supported formats: png, jpg, jpeg, gif, bmp, tiff, ico'])
D
Dmitriy Zaporozhets 已提交
2161 2162
    end
  end
J
Jerome Dalbert 已提交
2163

2164 2165 2166 2167
  describe '#avatar_url' do
    let(:user) { create(:user, :with_avatar) }

    context 'when avatar file is uploaded' do
2168
      it 'shows correct avatar url' do
2169 2170
        expect(user.avatar_url).to eq(user.avatar.url)
        expect(user.avatar_url(only_path: false)).to eq([Gitlab.config.gitlab.url, user.avatar.url].join)
2171
      end
2172 2173 2174
    end
  end

2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192
  describe '#accept_pending_invitations!' do
    let(:user) { create(:user, email: 'user@email.com') }
    let!(:project_member_invite) { create(:project_member, :invited, invite_email: user.email) }
    let!(:group_member_invite) { create(:group_member, :invited, invite_email: user.email) }
    let!(:external_project_member_invite) { create(:project_member, :invited, invite_email: 'external@email.com') }
    let!(:external_group_member_invite) { create(:group_member, :invited, invite_email: 'external@email.com') }

    it 'accepts all the user members pending invitations and returns the accepted_members' do
      accepted_members = user.accept_pending_invitations!

      expect(accepted_members).to match_array([project_member_invite, group_member_invite])
      expect(group_member_invite.reload).not_to be_invite
      expect(project_member_invite.reload).not_to be_invite
      expect(external_project_member_invite.reload).to be_invite
      expect(external_group_member_invite.reload).to be_invite
    end
  end

2193 2194
  describe '#all_emails' do
    let(:user) { create(:user) }
2195
    let!(:email_confirmed) { create :email, user: user, confirmed_at: Time.current }
2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207
    let!(:email_unconfirmed) { create :email, user: user }

    context 'when `include_private_email` is true' do
      it 'returns all emails' do
        expect(user.reload.all_emails).to contain_exactly(
          user.email,
          user.private_commit_email,
          email_unconfirmed.email,
          email_confirmed.email
        )
      end
    end
2208

2209 2210 2211 2212 2213 2214 2215 2216
    context 'when `include_private_email` is false' do
      it 'does not include the private commit email' do
        expect(user.reload.all_emails(include_private_email: false)).to contain_exactly(
          user.email,
          email_unconfirmed.email,
          email_confirmed.email
        )
      end
2217 2218 2219
    end
  end

2220
  describe '#verified_emails' do
2221 2222 2223
    let(:user) { create(:user) }

    it 'returns only confirmed emails' do
2224
      email_confirmed = create :email, user: user, confirmed_at: Time.current
B
Brett Walker 已提交
2225
      create :email, user: user
2226

2227 2228 2229 2230 2231
      expect(user.verified_emails).to contain_exactly(
        user.email,
        user.private_commit_email,
        email_confirmed.email
      )
2232 2233 2234
    end
  end

2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259
  describe '#public_verified_emails' do
    let(:user) { create(:user) }

    it 'returns only confirmed public emails' do
      email_confirmed = create :email, user: user, confirmed_at: Time.current
      create :email, user: user

      expect(user.public_verified_emails).to contain_exactly(
        user.email,
        email_confirmed.email
      )
    end

    it 'returns confirmed public emails plus main user email when user is not confirmed' do
      user = create(:user, confirmed_at: nil)
      email_confirmed = create :email, user: user, confirmed_at: Time.current
      create :email, user: user

      expect(user.public_verified_emails).to contain_exactly(
        user.email,
        email_confirmed.email
      )
    end
  end

2260 2261 2262 2263
  describe '#verified_email?' do
    let(:user) { create(:user) }

    it 'returns true when the email is verified/confirmed' do
2264
      email_confirmed = create :email, user: user, confirmed_at: Time.current
B
Brett Walker 已提交
2265
      create :email, user: user
2266 2267 2268
      user.reload

      expect(user.verified_email?(user.email)).to be_truthy
2269
      expect(user.verified_email?(email_confirmed.email.titlecase)).to be_truthy
2270 2271
    end

2272 2273 2274 2275
    it 'returns true when user is found through private commit email' do
      expect(user.verified_email?(user.private_commit_email)).to be_truthy
    end

2276 2277 2278 2279 2280 2281 2282 2283
    it 'returns true for an outdated private commit email' do
      old_email = user.private_commit_email

      user.update!(username: 'changed-username')

      expect(user.verified_email?(old_email)).to be_truthy
    end

2284 2285 2286 2287 2288 2289 2290 2291
    it 'returns false when the email is not verified/confirmed' do
      email_unconfirmed = create :email, user: user
      user.reload

      expect(user.verified_email?(email_unconfirmed.email)).to be_falsy
    end
  end

2292
  describe '#requires_ldap_check?' do
2293
    let(:user) { described_class.new }
2294

2295 2296
    it 'is false when LDAP is disabled' do
      # Create a condition which would otherwise cause 'true' to be returned
2297
      allow(user).to receive(:ldap_user?).and_return(true)
2298
      user.last_credential_check_at = nil
2299

2300
      expect(user.requires_ldap_check?).to be_falsey
2301 2302
    end

2303
    context 'when LDAP is enabled' do
2304 2305 2306
      before do
        allow(Gitlab.config.ldap).to receive(:enabled).and_return(true)
      end
2307

2308
      it 'is false for non-LDAP users' do
2309
        allow(user).to receive(:ldap_user?).and_return(false)
2310

2311
        expect(user.requires_ldap_check?).to be_falsey
2312 2313
      end

2314
      context 'and when the user is an LDAP user' do
2315 2316 2317
        before do
          allow(user).to receive(:ldap_user?).and_return(true)
        end
2318 2319 2320

        it 'is true when the user has never had an LDAP check before' do
          user.last_credential_check_at = nil
2321

2322
          expect(user.requires_ldap_check?).to be_truthy
2323 2324 2325 2326
        end

        it 'is true when the last LDAP check happened over 1 hour ago' do
          user.last_credential_check_at = 2.hours.ago
2327

2328
          expect(user.requires_ldap_check?).to be_truthy
2329
        end
2330 2331 2332 2333
      end
    end
  end

2334
  context 'ldap synchronized user' do
2335
    describe '#ldap_user?' do
2336 2337
      it 'is true if provider name starts with ldap' do
        user = create(:omniauth_user, provider: 'ldapmain')
2338

2339 2340
        expect(user.ldap_user?).to be_truthy
      end
2341

2342 2343
      it 'is false for other providers' do
        user = create(:omniauth_user, provider: 'other-provider')
2344

2345 2346 2347 2348 2349
        expect(user.ldap_user?).to be_falsey
      end

      it 'is false if no extern_uid is provided' do
        user = create(:omniauth_user, extern_uid: nil)
2350

2351 2352
        expect(user.ldap_user?).to be_falsey
      end
2353 2354
    end

2355
    describe '#ldap_identity' do
2356 2357
      it 'returns ldap identity' do
        user = create :omniauth_user
2358

2359 2360
        expect(user.ldap_identity.provider).not_to be_empty
      end
2361 2362
    end

2363 2364 2365 2366 2367
    describe '#ldap_block' do
      let(:user) { create(:omniauth_user, provider: 'ldapmain', name: 'John Smith') }

      it 'blocks user flaging the action caming from ldap' do
        user.ldap_block
2368

2369 2370 2371
        expect(user.blocked?).to be_truthy
        expect(user.ldap_blocked?).to be_truthy
      end
2372 2373 2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384

      context 'on a read-only instance' do
        before do
          allow(Gitlab::Database).to receive(:read_only?).and_return(true)
        end

        it 'does not block user' do
          user.ldap_block

          expect(user.blocked?).to be_falsey
          expect(user.ldap_blocked?).to be_falsey
        end
      end
2385 2386 2387
    end
  end

J
Jerome Dalbert 已提交
2388 2389 2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402 2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426
  describe '#full_website_url' do
    let(:user) { create(:user) }

    it 'begins with http if website url omits it' do
      user.website_url = 'test.com'

      expect(user.full_website_url).to eq 'http://test.com'
    end

    it 'begins with http if website url begins with http' do
      user.website_url = 'http://test.com'

      expect(user.full_website_url).to eq 'http://test.com'
    end

    it 'begins with https if website url begins with https' do
      user.website_url = 'https://test.com'

      expect(user.full_website_url).to eq 'https://test.com'
    end
  end

  describe '#short_website_url' do
    let(:user) { create(:user) }

    it 'does not begin with http if website url omits it' do
      user.website_url = 'test.com'

      expect(user.short_website_url).to eq 'test.com'
    end

    it 'does not begin with http if website url begins with http' do
      user.website_url = 'http://test.com'

      expect(user.short_website_url).to eq 'test.com'
    end

    it 'does not begin with https if website url begins with https' do
      user.website_url = 'https://test.com'
2427

J
Jerome Dalbert 已提交
2428 2429
      expect(user.short_website_url).to eq 'test.com'
    end
G
GitLab 已提交
2430
  end
C
Ciro Santilli 已提交
2431

2432 2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443
  describe '#sanitize_attrs' do
    let(:user) { build(:user, name: 'test & user', skype: 'test&user') }

    it 'encodes HTML entities in the Skype attribute' do
      expect { user.sanitize_attrs }.to change { user.skype }.to('test&amp;user')
    end

    it 'does not encode HTML entities in the name attribute' do
      expect { user.sanitize_attrs }.not_to change { user.name }
    end
  end

2444 2445
  describe '#starred?' do
    it 'determines if user starred a project' do
2446
      user = create :user
2447 2448
      project1 = create(:project, :public)
      project2 = create(:project, :public)
2449

2450 2451
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_falsey
2452 2453

      star1 = UsersStarProject.create!(project: project1, user: user)
2454

2455 2456
      expect(user.starred?(project1)).to be_truthy
      expect(user.starred?(project2)).to be_falsey
2457 2458

      star2 = UsersStarProject.create!(project: project2, user: user)
2459

2460 2461
      expect(user.starred?(project1)).to be_truthy
      expect(user.starred?(project2)).to be_truthy
2462 2463

      star1.destroy
2464

2465 2466
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_truthy
2467 2468

      star2.destroy
2469

2470 2471
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_falsey
2472 2473 2474
    end
  end

2475 2476
  describe '#toggle_star' do
    it 'toggles stars' do
C
Ciro Santilli 已提交
2477
      user = create :user
2478
      project = create(:project, :public)
C
Ciro Santilli 已提交
2479

2480
      expect(user.starred?(project)).to be_falsey
2481

C
Ciro Santilli 已提交
2482
      user.toggle_star(project)
2483

2484
      expect(user.starred?(project)).to be_truthy
2485

C
Ciro Santilli 已提交
2486
      user.toggle_star(project)
2487

2488
      expect(user.starred?(project)).to be_falsey
C
Ciro Santilli 已提交
2489 2490
    end
  end
V
Valery Sizov 已提交
2491

2492 2493
  describe '.find_by_private_commit_email' do
    context 'with email' do
2494
      let_it_be(:user) { create(:user) }
2495 2496 2497 2498 2499 2500 2501 2502 2503 2504 2505 2506 2507 2508 2509

      it 'returns user through private commit email' do
        expect(described_class.find_by_private_commit_email(user.private_commit_email)).to eq(user)
      end

      it 'returns nil when email other than private_commit_email is used' do
        expect(described_class.find_by_private_commit_email(user.email)).to be_nil
      end
    end

    it 'returns nil when email is nil' do
      expect(described_class.find_by_private_commit_email(nil)).to be_nil
    end
  end

2510
  describe '#sort_by_attribute' do
V
Valery Sizov 已提交
2511
    before do
2512
      described_class.delete_all
2513 2514 2515
      @user = create :user, created_at: Date.today, current_sign_in_at: Date.today, name: 'Alpha'
      @user1 = create :user, created_at: Date.today - 1, current_sign_in_at: Date.today - 1, name: 'Omega'
      @user2 = create :user, created_at: Date.today - 2, name: 'Beta'
V
Valery Sizov 已提交
2516
    end
2517

2518
    context 'when sort by recent_sign_in' do
2519
      let(:users) { described_class.sort_by_attribute('recent_sign_in') }
2520 2521 2522 2523

      it 'sorts users by recent sign-in time' do
        expect(users.first).to eq(@user)
        expect(users.second).to eq(@user1)
2524 2525 2526
      end

      it 'pushes users who never signed in to the end' do
2527
        expect(users.third).to eq(@user2)
2528
      end
V
Valery Sizov 已提交
2529 2530
    end

2531
    context 'when sort by oldest_sign_in' do
2532
      let(:users) { described_class.sort_by_attribute('oldest_sign_in') }
2533

2534
      it 'sorts users by the oldest sign-in time' do
2535 2536
        expect(users.first).to eq(@user1)
        expect(users.second).to eq(@user)
2537 2538 2539
      end

      it 'pushes users who never signed in to the end' do
2540
        expect(users.third).to eq(@user2)
2541
      end
V
Valery Sizov 已提交
2542 2543
    end

2544
    it 'sorts users in descending order by their creation time' do
2545
      expect(described_class.sort_by_attribute('created_desc').first).to eq(@user)
V
Valery Sizov 已提交
2546 2547
    end

2548
    it 'sorts users in ascending order by their creation time' do
2549
      expect(described_class.sort_by_attribute('created_asc').first).to eq(@user2)
V
Valery Sizov 已提交
2550 2551
    end

2552
    it 'sorts users by id in descending order when nil is passed' do
2553
      expect(described_class.sort_by_attribute(nil).first).to eq(@user2)
V
Valery Sizov 已提交
2554 2555
    end
  end
2556

2557 2558 2559 2560 2561 2562 2563 2564 2565 2566 2567 2568 2569 2570 2571 2572 2573 2574 2575 2576 2577 2578 2579 2580 2581 2582 2583 2584 2585 2586 2587 2588 2589 2590 2591 2592 2593 2594 2595 2596 2597 2598 2599 2600 2601 2602 2603 2604 2605 2606 2607 2608 2609 2610 2611 2612 2613 2614 2615 2616 2617 2618 2619 2620 2621 2622 2623 2624 2625 2626 2627 2628 2629 2630 2631 2632 2633 2634 2635 2636 2637 2638 2639 2640 2641 2642 2643 2644 2645
  describe "#last_active_at" do
    let(:last_activity_on) { 5.days.ago.to_date }
    let(:current_sign_in_at) { 8.days.ago }

    context 'for a user that has `last_activity_on` set' do
      let(:user) { create(:user, last_activity_on: last_activity_on) }

      it 'returns `last_activity_on` with current time zone' do
        expect(user.last_active_at).to eq(last_activity_on.to_time.in_time_zone)
      end
    end

    context 'for a user that has `current_sign_in_at` set' do
      let(:user) { create(:user, current_sign_in_at: current_sign_in_at) }

      it 'returns `current_sign_in_at`' do
        expect(user.last_active_at).to eq(current_sign_in_at)
      end
    end

    context 'for a user that has both `current_sign_in_at` & ``last_activity_on`` set' do
      let(:user) { create(:user, current_sign_in_at: current_sign_in_at, last_activity_on: last_activity_on) }

      it 'returns the latest among `current_sign_in_at` & `last_activity_on`' do
        latest_event = [current_sign_in_at, last_activity_on.to_time.in_time_zone].max
        expect(user.last_active_at).to eq(latest_event)
      end
    end

    context 'for a user that does not have both `current_sign_in_at` & `last_activity_on` set' do
      let(:user) { create(:user, current_sign_in_at: nil, last_activity_on: nil) }

      it 'returns nil' do
        expect(user.last_active_at).to eq(nil)
      end
    end
  end

  describe "#can_be_deactivated?" do
    let(:activity) { {} }
    let(:user) { create(:user, name: 'John Smith', **activity) }
    let(:day_within_minium_inactive_days_threshold) { User::MINIMUM_INACTIVE_DAYS.pred.days.ago }
    let(:day_outside_minium_inactive_days_threshold) { User::MINIMUM_INACTIVE_DAYS.next.days.ago }

    shared_examples 'not eligible for deactivation' do
      it 'returns false' do
        expect(user.can_be_deactivated?).to be_falsey
      end
    end

    shared_examples 'eligible for deactivation' do
      it 'returns true' do
        expect(user.can_be_deactivated?).to be_truthy
      end
    end

    context "a user who is not active" do
      before do
        user.block
      end

      it_behaves_like 'not eligible for deactivation'
    end

    context 'a user who has activity within the specified minimum inactive days' do
      let(:activity) { { last_activity_on: day_within_minium_inactive_days_threshold } }

      it_behaves_like 'not eligible for deactivation'
    end

    context 'a user who has signed in within the specified minimum inactive days' do
      let(:activity) { { current_sign_in_at: day_within_minium_inactive_days_threshold } }

      it_behaves_like 'not eligible for deactivation'
    end

    context 'a user who has no activity within the specified minimum inactive days' do
      let(:activity) { { last_activity_on: day_outside_minium_inactive_days_threshold } }

      it_behaves_like 'eligible for deactivation'
    end

    context 'a user who has not signed in within the specified minimum inactive days' do
      let(:activity) { { current_sign_in_at: day_outside_minium_inactive_days_threshold } }

      it_behaves_like 'eligible for deactivation'
    end
  end

2646
  describe "#contributed_projects" do
2647
    subject { create(:user) }
2648

2649
    let!(:project1) { create(:project) }
B
Bob Van Landuyt 已提交
2650
    let!(:project2) { fork_project(project3) }
2651
    let!(:project3) { create(:project) }
2652
    let!(:merge_request) { create(:merge_request, source_project: project2, target_project: project3, author: subject) }
2653
    let!(:push_event) { create(:push_event, project: project1, author: subject) }
2654
    let!(:merge_event) { create(:event, :created, project: project3, target: merge_request, author: subject) }
2655 2656

    before do
2657 2658
      project1.add_maintainer(subject)
      project2.add_maintainer(subject)
2659 2660 2661
    end

    it "includes IDs for projects the user has pushed to" do
2662
      expect(subject.contributed_projects).to include(project1)
2663 2664 2665
    end

    it "includes IDs for projects the user has had merge requests merged into" do
2666
      expect(subject.contributed_projects).to include(project3)
2667 2668 2669
    end

    it "doesn't include IDs for unrelated projects" do
2670
      expect(subject.contributed_projects).not_to include(project2)
2671 2672
    end
  end
2673

2674 2675 2676 2677 2678 2679 2680 2681 2682 2683 2684 2685 2686 2687 2688 2689 2690
  describe '#fork_of' do
    let(:user) { create(:user) }

    it "returns a user's fork of a project" do
      project = create(:project, :public)
      user_fork = fork_project(project, user, namespace: user.namespace)

      expect(user.fork_of(project)).to eq(user_fork)
    end

    it 'returns nil if the project does not have a fork network' do
      project = create(:project)

      expect(user.fork_of(project)).to be_nil
    end
  end

2691
  describe '#can_be_removed?' do
2692 2693 2694 2695 2696 2697 2698 2699 2700 2701 2702 2703 2704 2705 2706
    subject { create(:user) }

    context 'no owned groups' do
      it { expect(subject.can_be_removed?).to be_truthy }
    end

    context 'has owned groups' do
      before do
        group = create(:group)
        group.add_owner(subject)
      end

      it { expect(subject.can_be_removed?).to be_falsey }
    end
  end
2707 2708

  describe "#recent_push" do
2709 2710 2711
    let(:user) { build(:user) }
    let(:project) { build(:project) }
    let(:event) { build(:push_event) }
2712

2713 2714 2715 2716
    it 'returns the last push event for the user' do
      expect_any_instance_of(Users::LastPushEventService)
        .to receive(:last_event_for_user)
        .and_return(event)
2717

2718
      expect(user.recent_push).to eq(event)
2719 2720
    end

2721 2722 2723 2724
    it 'returns the last push event for a project when one is given' do
      expect_any_instance_of(Users::LastPushEventService)
        .to receive(:last_event_for_project)
        .and_return(event)
2725

2726
      expect(user.recent_push(project)).to eq(event)
2727
    end
2728
  end
2729 2730 2731 2732

  describe '#authorized_groups' do
    let!(:user) { create(:user) }
    let!(:private_group) { create(:group) }
2733 2734 2735 2736
    let!(:child_group) { create(:group, parent: private_group) }

    let!(:project_group) { create(:group) }
    let!(:project) { create(:project, group: project_group) }
2737 2738

    before do
2739 2740
      private_group.add_user(user, Gitlab::Access::MAINTAINER)
      project.add_maintainer(user)
2741 2742
    end

2743
    subject { user.authorized_groups }
2744

2745 2746 2747 2748 2749 2750 2751 2752 2753
    it { is_expected.to contain_exactly private_group, project_group }
  end

  describe '#membership_groups' do
    let!(:user) { create(:user) }
    let!(:parent_group) { create(:group) }
    let!(:child_group) { create(:group, parent: parent_group) }

    before do
2754
      parent_group.add_user(user, Gitlab::Access::MAINTAINER)
2755 2756 2757 2758
    end

    subject { user.membership_groups }

2759
    it { is_expected.to contain_exactly parent_group, child_group }
2760 2761
  end

2762 2763
  describe '#authorizations_for_projects' do
    let!(:user) { create(:user) }
2764

2765 2766 2767 2768
    subject { Project.where("EXISTS (?)", user.authorizations_for_projects) }

    it 'includes projects that belong to a user, but no other projects' do
      owned = create(:project, :private, namespace: user.namespace)
2769
      member = create(:project, :private).tap { |p| p.add_maintainer(user) }
2770 2771 2772 2773 2774 2775 2776 2777 2778 2779 2780 2781 2782 2783 2784 2785 2786
      other = create(:project)

      expect(subject).to include(owned)
      expect(subject).to include(member)
      expect(subject).not_to include(other)
    end

    it 'includes projects a user has access to, but no other projects' do
      other_user = create(:user)
      accessible = create(:project, :private, namespace: other_user.namespace) do |project|
        project.add_developer(user)
      end
      other = create(:project)

      expect(subject).to include(accessible)
      expect(subject).not_to include(other)
    end
2787 2788 2789 2790 2791 2792 2793 2794 2795 2796 2797 2798 2799 2800 2801 2802 2803 2804 2805 2806 2807 2808 2809 2810 2811 2812 2813

    context 'with min_access_level' do
      let!(:user) { create(:user) }
      let!(:project) { create(:project, :private, namespace: user.namespace) }

      before do
        project.add_developer(user)
      end

      subject { Project.where("EXISTS (?)", user.authorizations_for_projects(min_access_level: min_access_level)) }

      context 'when developer access' do
        let(:min_access_level) { Gitlab::Access::DEVELOPER }

        it 'includes projects a user has access to' do
          expect(subject).to include(project)
        end
      end

      context 'when owner access' do
        let(:min_access_level) { Gitlab::Access::OWNER }

        it 'does not include projects with higher access level' do
          expect(subject).not_to include(project)
        end
      end
    end
2814 2815
  end

2816
  describe '#authorized_projects', :delete do
2817 2818 2819
    context 'with a minimum access level' do
      it 'includes projects for which the user is an owner' do
        user = create(:user)
2820
        project = create(:project, :private, namespace: user.namespace)
2821

D
Douwe Maan 已提交
2822 2823
        expect(user.authorized_projects(Gitlab::Access::REPORTER))
          .to contain_exactly(project)
2824
      end
2825

2826
      it 'includes projects for which the user is a maintainer' do
2827
        user = create(:user)
2828
        project = create(:project, :private)
2829

2830
        project.add_maintainer(user)
2831

D
Douwe Maan 已提交
2832 2833
        expect(user.authorized_projects(Gitlab::Access::REPORTER))
          .to contain_exactly(project)
2834 2835
      end
    end
2836 2837 2838

    it "includes user's personal projects" do
      user    = create(:user)
2839
      project = create(:project, :private, namespace: user.namespace)
2840 2841 2842 2843 2844 2845 2846

      expect(user.authorized_projects).to include(project)
    end

    it "includes personal projects user has been given access to" do
      user1   = create(:user)
      user2   = create(:user)
2847
      project = create(:project, :private, namespace: user1.namespace)
2848

2849
      project.add_developer(user2)
2850 2851 2852 2853 2854 2855

      expect(user2.authorized_projects).to include(project)
    end

    it "includes projects of groups user has been added to" do
      group   = create(:group)
2856
      project = create(:project, group: group)
2857 2858 2859 2860 2861 2862 2863 2864 2865
      user    = create(:user)

      group.add_developer(user)

      expect(user.authorized_projects).to include(project)
    end

    it "does not include projects of groups user has been removed from" do
      group   = create(:group)
2866
      project = create(:project, group: group)
2867 2868 2869
      user    = create(:user)

      member = group.add_developer(user)
2870

2871 2872 2873
      expect(user.authorized_projects).to include(project)

      member.destroy
2874

2875 2876 2877 2878 2879
      expect(user.authorized_projects).not_to include(project)
    end

    it "includes projects shared with user's group" do
      user    = create(:user)
2880
      project = create(:project, :private)
2881 2882 2883 2884
      group   = create(:group) do |group|
        group.add_reporter(user)
      end
      create(:project_group_link, group: group, project: project)
2885 2886 2887 2888 2889 2890 2891

      expect(user.authorized_projects).to include(project)
    end

    it "does not include destroyed projects user had access to" do
      user1   = create(:user)
      user2   = create(:user)
2892
      project = create(:project, :private, namespace: user1.namespace)
2893

2894
      project.add_developer(user2)
2895

2896 2897 2898
      expect(user2.authorized_projects).to include(project)

      project.destroy
2899

2900 2901 2902 2903 2904
      expect(user2.authorized_projects).not_to include(project)
    end

    it "does not include projects of destroyed groups user had access to" do
      group   = create(:group)
2905
      project = create(:project, namespace: group)
2906 2907 2908
      user    = create(:user)

      group.add_developer(user)
2909

2910 2911 2912
      expect(user.authorized_projects).to include(project)

      group.destroy
2913

2914 2915
      expect(user.authorized_projects).not_to include(project)
    end
2916
  end
2917

2918 2919 2920 2921
  describe '#projects_where_can_admin_issues' do
    let(:user) { create(:user) }

    it 'includes projects for which the user access level is above or equal to reporter' do
2922 2923
      reporter_project  = create(:project) { |p| p.add_reporter(user) }
      developer_project = create(:project) { |p| p.add_developer(user) }
2924
      maintainer_project = create(:project) { |p| p.add_maintainer(user) }
2925

2926 2927
      expect(user.projects_where_can_admin_issues.to_a).to match_array([maintainer_project, developer_project, reporter_project])
      expect(user.can?(:admin_issue, maintainer_project)).to eq(true)
2928 2929 2930 2931 2932
      expect(user.can?(:admin_issue, developer_project)).to eq(true)
      expect(user.can?(:admin_issue, reporter_project)).to eq(true)
    end

    it 'does not include for which the user access level is below reporter' do
2933 2934
      project = create(:project)
      guest_project = create(:project) { |p| p.add_guest(user) }
2935 2936 2937 2938 2939 2940 2941

      expect(user.projects_where_can_admin_issues.to_a).to be_empty
      expect(user.can?(:admin_issue, guest_project)).to eq(false)
      expect(user.can?(:admin_issue, project)).to eq(false)
    end

    it 'does not include archived projects' do
2942
      project = create(:project, :archived)
2943 2944 2945 2946 2947 2948

      expect(user.projects_where_can_admin_issues.to_a).to be_empty
      expect(user.can?(:admin_issue, project)).to eq(false)
    end

    it 'does not include projects for which issues are disabled' do
2949
      project = create(:project, :issues_disabled)
2950 2951 2952 2953 2954 2955

      expect(user.projects_where_can_admin_issues.to_a).to be_empty
      expect(user.can?(:admin_issue, project)).to eq(false)
    end
  end

2956
  describe '#ci_owned_runners' do
2957 2958
    let(:user) { create(:user) }

2959 2960 2961 2962 2963 2964 2965 2966 2967
    shared_examples :nested_groups_owner do
      context 'when the user is the owner of a multi-level group' do
        before do
          set_permissions_for_users
        end

        it 'loads all the runners in the tree of groups' do
          expect(user.ci_owned_runners).to contain_exactly(runner, group_runner)
        end
2968 2969 2970
      end
    end

2971 2972 2973 2974 2975
    shared_examples :group_owner do
      context 'when the user is the owner of a one level group' do
        before do
          group.add_owner(user)
        end
2976

2977 2978 2979
        it 'loads the runners in the group' do
          expect(user.ci_owned_runners).to contain_exactly(group_runner)
        end
2980 2981 2982
      end
    end

2983 2984 2985 2986 2987 2988 2989 2990 2991 2992 2993 2994 2995 2996 2997 2998
    shared_examples :project_owner do
      context 'when the user is the owner of a project' do
        it 'loads the runner belonging to the project' do
          expect(user.ci_owned_runners).to contain_exactly(runner)
        end
      end
    end

    shared_examples :project_member do
      context 'when the user is a maintainer' do
        before do
          add_user(:maintainer)
        end

        it 'loads the runners of the project' do
          expect(user.ci_owned_runners).to contain_exactly(project_runner)
2999 3000 3001
        end
      end

3002 3003 3004 3005 3006 3007 3008 3009
      context 'when the user is a developer' do
        before do
          add_user(:developer)
        end

        it 'does not load any runner' do
          expect(user.ci_owned_runners).to be_empty
        end
3010 3011
      end

3012 3013 3014 3015
      context 'when the user is a reporter' do
        before do
          add_user(:reporter)
        end
3016

3017 3018
        it 'does not load any runner' do
          expect(user.ci_owned_runners).to be_empty
3019 3020 3021
        end
      end

3022 3023 3024 3025 3026 3027 3028 3029
      context 'when the user is a guest' do
        before do
          add_user(:guest)
        end

        it 'does not load any runner' do
          expect(user.ci_owned_runners).to be_empty
        end
3030 3031 3032
      end
    end

3033
    shared_examples :group_member do
3034
      context 'when the user is a maintainer' do
3035
        before do
3036
          add_user(:maintainer)
3037
        end
3038

3039
        it 'does not load the runners of the group' do
3040
          expect(user.ci_owned_runners).to be_empty
3041
        end
3042 3043
      end

3044
      context 'when the user is a developer' do
3045
        before do
3046
          add_user(:developer)
3047
        end
3048

3049
        it 'does not load any runner' do
3050
          expect(user.ci_owned_runners).to be_empty
3051
        end
3052 3053
      end

3054
      context 'when the user is a reporter' do
3055
        before do
3056
          add_user(:reporter)
3057 3058
        end

3059 3060
        it 'does not load any runner' do
          expect(user.ci_owned_runners).to be_empty
3061 3062 3063
        end
      end

3064 3065 3066 3067 3068 3069 3070 3071 3072
      context 'when the user is a guest' do
        before do
          add_user(:guest)
        end

        it 'does not load any runner' do
          expect(user.ci_owned_runners).to be_empty
        end
      end
3073 3074
    end

3075 3076 3077 3078 3079 3080 3081 3082 3083 3084 3085 3086 3087 3088 3089 3090 3091
    context 'without any projects nor groups' do
      it 'does not load any runner' do
        expect(user.ci_owned_runners).to be_empty
      end
    end

    context 'with runner in a personal project' do
      let!(:namespace) { create(:namespace, owner: user) }
      let!(:project) { create(:project, namespace: namespace) }
      let!(:runner) { create(:ci_runner, :project, projects: [project]) }

      it_behaves_like :project_owner
    end

    context 'with group runner in a non owned group' do
      let!(:group) { create(:group) }
      let!(:runner) { create(:ci_runner, :group, groups: [group]) }
3092 3093 3094 3095 3096

      def add_user(access)
        group.add_user(user, access)
      end

3097
      it_behaves_like :group_member
3098 3099
    end

3100 3101 3102 3103 3104 3105 3106 3107 3108
    context 'with group runner in an owned group' do
      let!(:group) { create(:group) }
      let!(:group_runner) { create(:ci_runner, :group, groups: [group]) }

      it_behaves_like :group_owner
    end

    context 'with group runner in an owned group and group runner in a different owner subgroup' do
      let!(:group) { create(:group) }
3109
      let!(:runner) { create(:ci_runner, :group, groups: [group]) }
3110 3111 3112 3113 3114 3115 3116 3117 3118 3119 3120 3121 3122
      let!(:subgroup) { create(:group, parent: group) }
      let!(:group_runner) { create(:ci_runner, :group, groups: [subgroup]) }
      let!(:another_user) { create(:user) }

      def set_permissions_for_users
        group.add_owner(user)
        subgroup.add_owner(another_user)
      end

      it_behaves_like :nested_groups_owner
    end

    context 'with personal project runner in an an owned group and a group runner in that same group' do
3123
      let!(:group) { create(:group) }
3124 3125 3126
      let!(:group_runner) { create(:ci_runner, :group, groups: [group]) }
      let!(:project) { create(:project, group: group) }
      let!(:runner) { create(:ci_runner, :project, projects: [project]) }
3127

3128 3129
      def set_permissions_for_users
        group.add_owner(user)
3130 3131
      end

3132
      it_behaves_like :nested_groups_owner
3133 3134
    end

3135 3136 3137 3138 3139 3140 3141 3142 3143 3144 3145 3146 3147 3148 3149 3150 3151 3152 3153 3154 3155 3156 3157 3158 3159 3160 3161 3162 3163 3164 3165 3166 3167 3168 3169 3170 3171 3172 3173 3174 3175 3176 3177 3178 3179 3180 3181
    context 'with personal project runner in an owned group and a group runner in a subgroup' do
      let!(:group) { create(:group) }
      let!(:subgroup) { create(:group, parent: group) }
      let!(:group_runner) { create(:ci_runner, :group, groups: [subgroup]) }
      let!(:project) { create(:project, group: group) }
      let!(:runner) { create(:ci_runner, :project, projects: [project]) }

      def set_permissions_for_users
        group.add_owner(user)
      end

      it_behaves_like :nested_groups_owner
    end

    context 'with personal project runner in an owned group in an owned namespace and a group runner in that group' do
      let!(:namespace) { create(:namespace, owner: user) }
      let!(:group) { create(:group) }
      let!(:group_runner) { create(:ci_runner, :group, groups: [group]) }
      let!(:project) { create(:project, namespace: namespace, group: group) }
      let!(:runner) { create(:ci_runner, :project, projects: [project]) }

      def set_permissions_for_users
        group.add_owner(user)
      end

      it_behaves_like :nested_groups_owner
    end

    context 'with personal project runner in an owned namespace, an owned group, a subgroup and a group runner in that subgroup' do
      let!(:namespace) { create(:namespace, owner: user) }
      let!(:group) { create(:group) }
      let!(:subgroup) { create(:group, parent: group) }
      let!(:group_runner) { create(:ci_runner, :group, groups: [subgroup]) }
      let!(:project) { create(:project, namespace: namespace, group: group) }
      let!(:runner) { create(:ci_runner, :project, projects: [project]) }

      def set_permissions_for_users
        group.add_owner(user)
      end

      it_behaves_like :nested_groups_owner
    end

    context 'with a project runner that belong to projects that belong to a not owned group' do
      let!(:group) { create(:group) }
      let!(:project) { create(:project, group: group) }
      let!(:project_runner) { create(:ci_runner, :project, projects: [project]) }
3182

L
Lin Jen-Shin 已提交
3183
      def add_user(access)
3184
        project.add_user(user, access)
3185 3186
      end

3187
      it_behaves_like :project_member
3188
    end
3189

3190 3191 3192 3193 3194 3195 3196 3197 3198 3199 3200 3201 3202 3203
    context 'with project runners that belong to projects that do not belong to any group' do
      let!(:project) { create(:project) }
      let!(:runner) { create(:ci_runner, :project, projects: [project]) }

      it 'does not load any runner' do
        expect(user.ci_owned_runners).to be_empty
      end
    end

    context 'with a group runner that belongs to a subgroup of a group owned by another user' do
      let!(:group) { create(:group) }
      let!(:subgroup) { create(:group, parent: group) }
      let!(:runner) { create(:ci_runner, :group, groups: [subgroup]) }
      let!(:another_user) { create(:user) }
3204 3205

      def add_user(access)
3206
        subgroup.add_user(user, access)
3207 3208 3209
        group.add_user(another_user, :owner)
      end

3210
      it_behaves_like :group_member
3211
    end
3212 3213
  end

3214
  describe '#projects_with_reporter_access_limited_to' do
3215 3216
    let(:project1) { create(:project) }
    let(:project2) { create(:project) }
3217 3218 3219
    let(:user) { create(:user) }

    before do
3220 3221
      project1.add_reporter(user)
      project2.add_guest(user)
3222 3223 3224 3225 3226 3227 3228 3229 3230 3231 3232 3233 3234 3235 3236
    end

    it 'returns the projects when using a single project ID' do
      projects = user.projects_with_reporter_access_limited_to(project1.id)

      expect(projects).to eq([project1])
    end

    it 'returns the projects when using an Array of project IDs' do
      projects = user.projects_with_reporter_access_limited_to([project1.id])

      expect(projects).to eq([project1])
    end

    it 'returns the projects when using an ActiveRecord relation' do
3237 3238
      projects = user
        .projects_with_reporter_access_limited_to(Project.select(:id))
3239 3240 3241 3242 3243 3244 3245 3246 3247 3248

      expect(projects).to eq([project1])
    end

    it 'does not return projects you do not have reporter access to' do
      projects = user.projects_with_reporter_access_limited_to(project2.id)

      expect(projects).to be_empty
    end
  end
3249

3250 3251
  describe '#all_expanded_groups' do
    # foo/bar would also match foo/barbaz instead of just foo/bar and foo/bar/baz
3252 3253
    let!(:user) { create(:user) }

3254 3255 3256 3257 3258 3259 3260 3261 3262 3263 3264 3265 3266 3267 3268 3269
    #                group
    #        _______ (foo) _______
    #       |                     |
    #       |                     |
    # nested_group_1        nested_group_2
    # (bar)                 (barbaz)
    #       |                     |
    #       |                     |
    # nested_group_1_1      nested_group_2_1
    # (baz)                 (baz)
    #
    let!(:group) { create :group }
    let!(:nested_group_1) { create :group, parent: group, name: 'bar' }
    let!(:nested_group_1_1) { create :group, parent: nested_group_1, name: 'baz' }
    let!(:nested_group_2) { create :group, parent: group, name: 'barbaz' }
    let!(:nested_group_2_1) { create :group, parent: nested_group_2, name: 'baz' }
3270

3271 3272 3273 3274 3275 3276
    subject { user.all_expanded_groups }

    context 'user is not a member of any group' do
      it 'returns an empty array' do
        is_expected.to eq([])
      end
3277 3278
    end

3279 3280
    context 'user is member of all groups' do
      before do
3281 3282 3283 3284 3285
        group.add_reporter(user)
        nested_group_1.add_developer(user)
        nested_group_1_1.add_maintainer(user)
        nested_group_2.add_developer(user)
        nested_group_2_1.add_maintainer(user)
3286
      end
3287

3288 3289 3290 3291 3292 3293 3294 3295
      it 'returns all groups' do
        is_expected.to match_array [
          group,
          nested_group_1, nested_group_1_1,
          nested_group_2, nested_group_2_1
        ]
      end
    end
3296

3297
    context 'user is member of the top group' do
3298 3299 3300
      before do
        group.add_owner(user)
      end
3301

3302 3303 3304 3305 3306 3307
      it 'returns all groups' do
        is_expected.to match_array [
          group,
          nested_group_1, nested_group_1_1,
          nested_group_2, nested_group_2_1
        ]
3308 3309
      end
    end
3310

3311
    context 'user is member of the first child (internal node), branch 1' do
3312 3313 3314
      before do
        nested_group_1.add_owner(user)
      end
3315

3316 3317 3318 3319 3320 3321 3322 3323
      it 'returns the groups in the hierarchy' do
        is_expected.to match_array [
          group,
          nested_group_1, nested_group_1_1
        ]
      end
    end

3324
    context 'user is member of the first child (internal node), branch 2' do
3325 3326 3327
      before do
        nested_group_2.add_owner(user)
      end
3328

3329 3330 3331 3332 3333 3334
      it 'returns the groups in the hierarchy' do
        is_expected.to match_array [
          group,
          nested_group_2, nested_group_2_1
        ]
      end
3335 3336
    end

3337
    context 'user is member of the last child (leaf node)' do
3338 3339 3340
      before do
        nested_group_1_1.add_owner(user)
      end
3341 3342 3343 3344 3345 3346 3347 3348

      it 'returns the groups in the hierarchy' do
        is_expected.to match_array [
          group,
          nested_group_1, nested_group_1_1
        ]
      end
    end
3349 3350
  end

3351
  describe '#refresh_authorized_projects', :clean_gitlab_redis_shared_state do
3352 3353
    let(:project1) { create(:project) }
    let(:project2) { create(:project) }
3354 3355 3356
    let(:user) { create(:user) }

    before do
3357 3358
      project1.add_reporter(user)
      project2.add_guest(user)
3359 3360 3361 3362 3363 3364 3365 3366 3367 3368 3369 3370 3371 3372

      user.project_authorizations.delete_all
      user.refresh_authorized_projects
    end

    it 'refreshes the list of authorized projects' do
      expect(user.project_authorizations.count).to eq(2)
    end

    it 'stores the correct access levels' do
      expect(user.project_authorizations.where(access_level: Gitlab::Access::GUEST).exists?).to eq(true)
      expect(user.project_authorizations.where(access_level: Gitlab::Access::REPORTER).exists?).to eq(true)
    end
  end
D
Douwe Maan 已提交
3373 3374 3375 3376 3377 3378 3379 3380 3381 3382 3383 3384 3385 3386 3387 3388 3389 3390 3391 3392 3393 3394 3395 3396 3397 3398 3399 3400 3401 3402 3403 3404 3405

  describe '#access_level=' do
    let(:user) { build(:user) }

    it 'does nothing for an invalid access level' do
      user.access_level = :invalid_access_level

      expect(user.access_level).to eq(:regular)
      expect(user.admin).to be false
    end

    it "assigns the 'admin' access level" do
      user.access_level = :admin

      expect(user.access_level).to eq(:admin)
      expect(user.admin).to be true
    end

    it "doesn't clear existing access levels when an invalid access level is passed in" do
      user.access_level = :admin
      user.access_level = :invalid_access_level

      expect(user.access_level).to eq(:admin)
      expect(user.admin).to be true
    end

    it "accepts string values in addition to symbols" do
      user.access_level = 'admin'

      expect(user.access_level).to eq(:admin)
      expect(user.admin).to be true
    end
  end
3406

3407
  describe '#can_read_all_resources?', :request_store do
3408
    it 'returns false for regular user' do
3409
      user = build_stubbed(:user)
3410

3411
      expect(user.can_read_all_resources?).to be_falsy
3412 3413
    end

3414 3415
    context 'for admin user' do
      include_context 'custom session'
3416

3417
      let(:user) { build_stubbed(:user, :admin) }
3418 3419 3420

      context 'when admin mode is disabled' do
        it 'returns false' do
3421
          expect(user.can_read_all_resources?).to be_falsy
3422 3423 3424 3425 3426
        end
      end

      context 'when admin mode is enabled' do
        before do
3427
          Gitlab::Auth::CurrentUserMode.new(user).request_admin_mode!
3428 3429 3430 3431
          Gitlab::Auth::CurrentUserMode.new(user).enable_admin_mode!(password: user.password)
        end

        it 'returns true' do
3432
          expect(user.can_read_all_resources?).to be_truthy
3433 3434
        end
      end
3435 3436 3437
    end
  end

3438 3439
  describe '.ghost' do
    it "creates a ghost user if one isn't already present" do
3440
      ghost = described_class.ghost
3441 3442 3443

      expect(ghost).to be_ghost
      expect(ghost).to be_persisted
3444 3445
      expect(ghost.namespace).not_to be_nil
      expect(ghost.namespace).to be_persisted
3446
      expect(ghost.user_type).to eq 'ghost'
3447 3448 3449 3450
    end

    it "does not create a second ghost user if one is already present" do
      expect do
3451 3452 3453 3454
        described_class.ghost
        described_class.ghost
      end.to change { described_class.count }.by(1)
      expect(described_class.ghost).to eq(described_class.ghost)
3455 3456 3457 3458 3459
    end

    context "when a regular user exists with the username 'ghost'" do
      it "creates a ghost user with a non-conflicting username" do
        create(:user, username: 'ghost')
3460
        ghost = described_class.ghost
3461 3462

        expect(ghost).to be_persisted
3463
        expect(ghost.username).to eq('ghost1')
3464 3465 3466 3467 3468 3469
      end
    end

    context "when a regular user exists with the email 'ghost@example.com'" do
      it "creates a ghost user with a non-conflicting email" do
        create(:user, email: 'ghost@example.com')
3470
        ghost = described_class.ghost
3471 3472

        expect(ghost).to be_persisted
3473
        expect(ghost.email).to eq('ghost1@example.com')
3474 3475
      end
    end
3476 3477 3478 3479 3480 3481 3482

    context 'when a domain whitelist is in place' do
      before do
        stub_application_setting(domain_whitelist: ['gitlab.com'])
      end

      it 'creates a ghost user' do
3483
        expect(described_class.ghost).to be_persisted
3484 3485
      end
    end
3486
  end
3487 3488 3489 3490 3491 3492 3493 3494 3495 3496 3497 3498 3499 3500 3501 3502

  describe '#update_two_factor_requirement' do
    let(:user) { create :user }

    context 'with 2FA requirement on groups' do
      let(:group1) { create :group, require_two_factor_authentication: true, two_factor_grace_period: 23 }
      let(:group2) { create :group, require_two_factor_authentication: true, two_factor_grace_period: 32 }

      before do
        group1.add_user(user, GroupMember::OWNER)
        group2.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'requires 2FA' do
3503
        expect(user.require_two_factor_authentication_from_group).to be true
3504 3505 3506 3507 3508 3509 3510
      end

      it 'uses the shortest grace period' do
        expect(user.two_factor_grace_period).to be 23
      end
    end

3511
    context 'with 2FA requirement from expanded groups' do
3512
      let!(:group1) { create :group, require_two_factor_authentication: true }
3513
      let!(:group1a) { create :group, parent: group1 }
3514 3515 3516 3517 3518 3519 3520 3521

      before do
        group1a.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'requires 2FA' do
3522
        expect(user.require_two_factor_authentication_from_group).to be true
3523 3524 3525
      end
    end

3526
    context 'with 2FA requirement on nested child group' do
3527 3528 3529 3530 3531 3532 3533 3534 3535 3536
      let!(:group1) { create :group, require_two_factor_authentication: false }
      let!(:group1a) { create :group, require_two_factor_authentication: true, parent: group1 }

      before do
        group1.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'requires 2FA' do
3537
        expect(user.require_two_factor_authentication_from_group).to be true
3538 3539 3540
      end
    end

3541 3542 3543 3544 3545 3546 3547 3548 3549 3550 3551 3552 3553 3554 3555 3556 3557 3558 3559 3560 3561
    context "with 2FA requirement from shared project's group" do
      let!(:group1) { create :group, require_two_factor_authentication: true }
      let!(:group2) { create :group }
      let(:shared_project) { create(:project, namespace: group1) }

      before do
        shared_project.project_group_links.create!(
          group: group2,
          group_access: ProjectGroupLink.default_access
        )

        group2.add_user(user, GroupMember::OWNER)
      end

      it 'does not require 2FA' do
        user.update_two_factor_requirement

        expect(user.require_two_factor_authentication_from_group).to be false
      end
    end

3562 3563 3564 3565 3566 3567 3568 3569 3570 3571
    context 'without 2FA requirement on groups' do
      let(:group) { create :group }

      before do
        group.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'does not require 2FA' do
3572
        expect(user.require_two_factor_authentication_from_group).to be false
3573 3574 3575 3576 3577 3578 3579
      end

      it 'falls back to the default grace period' do
        expect(user.two_factor_grace_period).to be 48
      end
    end
  end
J
James Lopez 已提交
3580

3581
  describe '.active' do
J
James Lopez 已提交
3582
    before do
3583
      described_class.ghost
J
James Lopez 已提交
3584 3585 3586 3587 3588
      create(:user, name: 'user', state: 'active')
      create(:user, name: 'user', state: 'blocked')
    end

    it 'only counts active and non internal users' do
3589
      expect(described_class.active.count).to eq(1)
J
James Lopez 已提交
3590 3591
    end
  end
3592 3593 3594 3595 3596 3597 3598 3599

  describe 'preferred language' do
    it 'is English by default' do
      user = create(:user)

      expect(user.preferred_language).to eq('en')
    end
  end
3600

3601
  describe '#invalidate_issue_cache_counts' do
3602 3603 3604 3605 3606 3607 3608 3609 3610 3611 3612 3613 3614
    let(:user) { build_stubbed(:user) }

    it 'invalidates cache for issue counter' do
      cache_mock = double

      expect(cache_mock).to receive(:delete).with(['users', user.id, 'assigned_open_issues_count'])

      allow(Rails).to receive(:cache).and_return(cache_mock)

      user.invalidate_issue_cache_counts
    end
  end

3615
  describe '#invalidate_merge_request_cache_counts' do
3616 3617 3618 3619 3620 3621 3622 3623 3624 3625 3626 3627
    let(:user) { build_stubbed(:user) }

    it 'invalidates cache for Merge Request counter' do
      cache_mock = double

      expect(cache_mock).to receive(:delete).with(['users', user.id, 'assigned_open_merge_requests_count'])

      allow(Rails).to receive(:cache).and_return(cache_mock)

      user.invalidate_merge_request_cache_counts
    end
  end
3628

3629
  describe '#invalidate_personal_projects_count' do
A
Andreas Brandl 已提交
3630 3631 3632 3633 3634 3635 3636 3637 3638 3639 3640 3641 3642
    let(:user) { build_stubbed(:user) }

    it 'invalidates cache for personal projects counter' do
      cache_mock = double

      expect(cache_mock).to receive(:delete).with(['users', user.id, 'personal_projects_count'])

      allow(Rails).to receive(:cache).and_return(cache_mock)

      user.invalidate_personal_projects_count
    end
  end

3643
  describe '#allow_password_authentication_for_web?' do
3644 3645 3646
    context 'regular user' do
      let(:user) { build(:user) }

3647 3648
      it 'returns true when password authentication is enabled for the web interface' do
        expect(user.allow_password_authentication_for_web?).to be_truthy
3649 3650
      end

3651 3652
      it 'returns false when password authentication is disabled for the web interface' do
        stub_application_setting(password_authentication_enabled_for_web: false)
3653

3654
        expect(user.allow_password_authentication_for_web?).to be_falsey
3655 3656 3657 3658 3659 3660
      end
    end

    it 'returns false for ldap user' do
      user = create(:omniauth_user, provider: 'ldapmain')

3661 3662 3663 3664 3665 3666 3667 3668 3669 3670 3671 3672 3673 3674 3675 3676 3677 3678 3679 3680 3681 3682 3683
      expect(user.allow_password_authentication_for_web?).to be_falsey
    end
  end

  describe '#allow_password_authentication_for_git?' do
    context 'regular user' do
      let(:user) { build(:user) }

      it 'returns true when password authentication is enabled for Git' do
        expect(user.allow_password_authentication_for_git?).to be_truthy
      end

      it 'returns false when password authentication is disabled Git' do
        stub_application_setting(password_authentication_enabled_for_git: false)

        expect(user.allow_password_authentication_for_git?).to be_falsey
      end
    end

    it 'returns false for ldap user' do
      user = create(:omniauth_user, provider: 'ldapmain')

      expect(user.allow_password_authentication_for_git?).to be_falsey
3684 3685
    end
  end
3686

3687 3688 3689 3690 3691 3692
  describe '#assigned_open_merge_requests_count' do
    it 'returns number of open merge requests from non-archived projects' do
      user    = create(:user)
      project = create(:project, :public)
      archived_project = create(:project, :public, :archived)

3693 3694 3695
      create(:merge_request, source_project: project, author: user, assignees: [user])
      create(:merge_request, :closed, source_project: project, author: user, assignees: [user])
      create(:merge_request, source_project: archived_project, author: user, assignees: [user])
3696 3697 3698 3699 3700 3701 3702 3703 3704 3705 3706 3707 3708 3709 3710 3711 3712 3713 3714

      expect(user.assigned_open_merge_requests_count(force: true)).to eq 1
    end
  end

  describe '#assigned_open_issues_count' do
    it 'returns number of open issues from non-archived projects' do
      user    = create(:user)
      project = create(:project, :public)
      archived_project = create(:project, :public, :archived)

      create(:issue, project: project, author: user, assignees: [user])
      create(:issue, :closed, project: project, author: user, assignees: [user])
      create(:issue, project: archived_project, author: user, assignees: [user])

      expect(user.assigned_open_issues_count(force: true)).to eq 1
    end
  end

3715 3716 3717 3718 3719
  describe '#personal_projects_count' do
    it 'returns the number of personal projects using a single query' do
      user = build(:user)
      projects = double(:projects, count: 1)

A
Andreas Brandl 已提交
3720
      expect(user).to receive(:personal_projects).and_return(projects)
3721

A
Andreas Brandl 已提交
3722
      expect(user.personal_projects_count).to eq(1)
3723 3724 3725 3726 3727 3728 3729 3730 3731 3732 3733 3734 3735
    end
  end

  describe '#projects_limit_left' do
    it 'returns the number of projects that can be created by the user' do
      user = build(:user)

      allow(user).to receive(:projects_limit).and_return(10)
      allow(user).to receive(:personal_projects_count).and_return(5)

      expect(user.projects_limit_left).to eq(5)
    end
  end
3736 3737 3738 3739 3740 3741 3742

  describe '#ensure_namespace_correct' do
    context 'for a new user' do
      let(:user) { build(:user) }

      it 'creates the namespace' do
        expect(user.namespace).to be_nil
3743

3744
        user.save!
3745

3746 3747 3748 3749 3750 3751 3752 3753 3754
        expect(user.namespace).not_to be_nil
      end
    end

    context 'for an existing user' do
      let(:username) { 'foo' }
      let(:user) { create(:user, username: username) }

      context 'when the user is updated' do
3755
        context 'when the username or name is changed' do
3756 3757 3758 3759
          let(:new_username) { 'bar' }

          it 'changes the namespace (just to compare to when username is not changed)' do
            expect do
3760
              Timecop.freeze(1.second.from_now) do
S
Sean McGivern 已提交
3761
                user.update!(username: new_username)
3762
              end
3763 3764 3765
            end.to change { user.namespace.updated_at }
          end

3766
          it 'updates the namespace path when the username was changed' do
L
Lin Jen-Shin 已提交
3767
            user.update!(username: new_username)
3768

3769
            expect(user.namespace.path).to eq(new_username)
3770 3771
          end

3772 3773
          it 'updates the namespace name if the name was changed' do
            user.update!(name: 'New name')
3774

3775 3776 3777 3778 3779 3780 3781 3782 3783
            expect(user.namespace.name).to eq('New name')
          end

          it 'updates nested routes for the namespace if the name was changed' do
            project = create(:project, namespace: user.namespace)

            user.update!(name: 'New name')

            expect(project.route.reload.name).to include('New name')
3784 3785 3786
          end

          context 'when there is a validation error (namespace name taken) while updating namespace' do
3787
            let!(:conflicting_namespace) { create(:group, path: new_username) }
3788

3789
            it 'causes the user save to fail' do
L
Lin Jen-Shin 已提交
3790
              expect(user.update(username: new_username)).to be_falsey
3791
              expect(user.namespace.errors.messages[:path].first).to eq(_('has already been taken'))
3792
            end
3793 3794

            it 'adds the namespace errors to the user' do
L
Lin Jen-Shin 已提交
3795
              user.update(username: new_username)
3796

3797
              expect(user.errors.full_messages.first).to eq('Username has already been taken')
3798
            end
3799 3800 3801 3802 3803 3804
          end
        end

        context 'when the username is not changed' do
          it 'does not change the namespace' do
            expect do
L
Lin Jen-Shin 已提交
3805
              user.update!(email: 'asdf@asdf.com')
3806 3807 3808 3809 3810 3811
            end.not_to change { user.namespace.updated_at }
          end
        end
      end
    end
  end
A
Alexis Reigel 已提交
3812

3813 3814 3815 3816 3817 3818 3819 3820 3821 3822 3823 3824 3825 3826 3827 3828 3829 3830 3831 3832 3833 3834
  describe '#username_changed_hook' do
    context 'for a new user' do
      let(:user) { build(:user) }

      it 'does not trigger system hook' do
        expect(user).not_to receive(:system_hook_service)

        user.save!
      end
    end

    context 'for an existing user' do
      let(:user) { create(:user, username: 'old-username') }

      context 'when the username is changed' do
        let(:new_username) { 'very-new-name' }

        it 'triggers the rename system hook' do
          system_hook_service = SystemHooksService.new
          expect(system_hook_service).to receive(:execute_hooks_for).with(user, :rename)
          expect(user).to receive(:system_hook_service).and_return(system_hook_service)

L
Lin Jen-Shin 已提交
3835
          user.update!(username: new_username)
3836 3837 3838 3839 3840 3841 3842
        end
      end

      context 'when the username is not changed' do
        it 'does not trigger system hook' do
          expect(user).not_to receive(:system_hook_service)

L
Lin Jen-Shin 已提交
3843
          user.update!(email: 'asdf@asdf.com')
3844 3845 3846 3847 3848
        end
      end
    end
  end

3849 3850 3851 3852 3853 3854 3855 3856 3857 3858 3859 3860 3861 3862 3863 3864 3865 3866 3867 3868 3869 3870 3871 3872 3873 3874 3875 3876 3877 3878 3879 3880 3881 3882 3883 3884 3885 3886 3887 3888 3889
  describe '#will_save_change_to_login?' do
    let(:user) { create(:user, username: 'old-username', email: 'old-email@example.org') }
    let(:new_username) { 'new-name' }
    let(:new_email) { 'new-email@example.org' }

    subject { user.will_save_change_to_login? }

    context 'when the username is changed' do
      before do
        user.username = new_username
      end

      it { is_expected.to be true }
    end

    context 'when the email is changed' do
      before do
        user.email = new_email
      end

      it { is_expected.to be true }
    end

    context 'when both email and username are changed' do
      before do
        user.username = new_username
        user.email = new_email
      end

      it { is_expected.to be true }
    end

    context 'when email and username aren\'t changed' do
      before do
        user.name = 'new_name'
      end

      it { is_expected.to be_falsy }
    end
  end

3890 3891 3892 3893 3894 3895
  describe '#sync_attribute?' do
    let(:user) { described_class.new }

    context 'oauth user' do
      it 'returns true if name can be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(name location))
3896

3897 3898 3899 3900 3901
        expect(user.sync_attribute?(:name)).to be_truthy
      end

      it 'returns true if email can be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(name email))
3902

3903 3904 3905 3906 3907
        expect(user.sync_attribute?(:email)).to be_truthy
      end

      it 'returns true if location can be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(location email))
3908

3909 3910 3911 3912 3913
        expect(user.sync_attribute?(:email)).to be_truthy
      end

      it 'returns false if name can not be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(location email))
3914

3915 3916 3917 3918
        expect(user.sync_attribute?(:name)).to be_falsey
      end

      it 'returns false if email can not be synced' do
3919
        stub_omniauth_setting(sync_profile_attributes: %w(location name))
3920

3921
        expect(user.sync_attribute?(:email)).to be_falsey
3922 3923 3924
      end

      it 'returns false if location can not be synced' do
3925
        stub_omniauth_setting(sync_profile_attributes: %w(name email))
3926

3927
        expect(user.sync_attribute?(:location)).to be_falsey
3928 3929 3930 3931
      end

      it 'returns true for all syncable attributes if all syncable attributes can be synced' do
        stub_omniauth_setting(sync_profile_attributes: true)
3932

3933 3934 3935 3936 3937 3938 3939 3940 3941 3942 3943 3944 3945 3946 3947
        expect(user.sync_attribute?(:name)).to be_truthy
        expect(user.sync_attribute?(:email)).to be_truthy
        expect(user.sync_attribute?(:location)).to be_truthy
      end

      it 'returns false for all syncable attributes but email if no syncable attributes are declared' do
        expect(user.sync_attribute?(:name)).to be_falsey
        expect(user.sync_attribute?(:email)).to be_truthy
        expect(user.sync_attribute?(:location)).to be_falsey
      end
    end

    context 'ldap user' do
      it 'returns true for email if ldap user' do
        allow(user).to receive(:ldap_user?).and_return(true)
3948

3949 3950 3951 3952 3953 3954 3955 3956
        expect(user.sync_attribute?(:name)).to be_falsey
        expect(user.sync_attribute?(:email)).to be_truthy
        expect(user.sync_attribute?(:location)).to be_falsey
      end

      it 'returns true for email and location if ldap user and location declared as syncable' do
        allow(user).to receive(:ldap_user?).and_return(true)
        stub_omniauth_setting(sync_profile_attributes: %w(location))
3957

3958 3959 3960 3961 3962 3963
        expect(user.sync_attribute?(:name)).to be_falsey
        expect(user.sync_attribute?(:email)).to be_truthy
        expect(user.sync_attribute?(:location)).to be_truthy
      end
    end
  end
3964 3965 3966 3967 3968 3969 3970 3971 3972 3973 3974 3975 3976 3977 3978 3979

  describe '#confirm_deletion_with_password?' do
    where(
      password_automatically_set: [true, false],
      ldap_user: [true, false],
      password_authentication_disabled: [true, false]
    )

    with_them do
      let!(:user) { create(:user, password_automatically_set: password_automatically_set) }
      let!(:identity) { create(:identity, user: user) if ldap_user }

      # Only confirm deletion with password if all inputs are false
      let(:expected) { !(password_automatically_set || ldap_user || password_authentication_disabled) }

      before do
3980 3981
        stub_application_setting(password_authentication_enabled_for_web: !password_authentication_disabled)
        stub_application_setting(password_authentication_enabled_for_git: !password_authentication_disabled)
3982 3983 3984 3985 3986 3987 3988 3989 3990 3991 3992 3993 3994 3995 3996 3997 3998 3999 4000 4001 4002 4003 4004 4005 4006 4007 4008 4009
      end

      it 'returns false unless all inputs are true' do
        expect(user.confirm_deletion_with_password?).to eq(expected)
      end
    end
  end

  describe '#delete_async' do
    let(:user) { create(:user) }
    let(:deleted_by) { create(:user) }

    it 'blocks the user then schedules them for deletion if a hard delete is specified' do
      expect(DeleteUserWorker).to receive(:perform_async).with(deleted_by.id, user.id, hard_delete: true)

      user.delete_async(deleted_by: deleted_by, params: { hard_delete: true })

      expect(user).to be_blocked
    end

    it 'schedules user for deletion without blocking them' do
      expect(DeleteUserWorker).to receive(:perform_async).with(deleted_by.id, user.id, {})

      user.delete_async(deleted_by: deleted_by)

      expect(user).not_to be_blocked
    end
  end
4010 4011 4012 4013 4014 4015

  describe '#max_member_access_for_project_ids' do
    shared_examples 'max member access for projects' do
      let(:user) { create(:user) }
      let(:group) { create(:group) }
      let(:owner_project) { create(:project, group: group) }
4016
      let(:maintainer_project) { create(:project) }
4017 4018 4019 4020 4021 4022
      let(:reporter_project) { create(:project) }
      let(:developer_project) { create(:project) }
      let(:guest_project) { create(:project) }
      let(:no_access_project) { create(:project) }

      let(:projects) do
4023
        [owner_project, maintainer_project, reporter_project, developer_project, guest_project, no_access_project].map(&:id)
4024 4025 4026 4027 4028
      end

      let(:expected) do
        {
          owner_project.id => Gitlab::Access::OWNER,
4029
          maintainer_project.id => Gitlab::Access::MAINTAINER,
4030 4031 4032 4033 4034 4035 4036 4037 4038
          reporter_project.id => Gitlab::Access::REPORTER,
          developer_project.id => Gitlab::Access::DEVELOPER,
          guest_project.id => Gitlab::Access::GUEST,
          no_access_project.id => Gitlab::Access::NO_ACCESS
        }
      end

      before do
        create(:group_member, user: user, group: group)
4039
        maintainer_project.add_maintainer(user)
4040 4041 4042 4043 4044 4045 4046 4047 4048 4049 4050 4051 4052 4053 4054 4055 4056 4057 4058 4059 4060 4061 4062 4063 4064 4065
        reporter_project.add_reporter(user)
        developer_project.add_developer(user)
        guest_project.add_guest(user)
      end

      it 'returns correct roles for different projects' do
        expect(user.max_member_access_for_project_ids(projects)).to eq(expected)
      end
    end

    context 'with RequestStore enabled', :request_store do
      include_examples 'max member access for projects'

      def access_levels(projects)
        user.max_member_access_for_project_ids(projects)
      end

      it 'does not perform extra queries when asked for projects who have already been found' do
        access_levels(projects)

        expect { access_levels(projects) }.not_to exceed_query_limit(0)

        expect(access_levels(projects)).to eq(expected)
      end

      it 'only requests the extra projects when uncached projects are passed' do
4066
        second_maintainer_project = create(:project)
4067
        second_developer_project = create(:project)
4068
        second_maintainer_project.add_maintainer(user)
4069 4070
        second_developer_project.add_developer(user)

4071
        all_projects = projects + [second_maintainer_project.id, second_developer_project.id]
4072

4073
        expected_all = expected.merge(second_maintainer_project.id => Gitlab::Access::MAINTAINER,
4074 4075 4076 4077 4078 4079 4080
                                      second_developer_project.id => Gitlab::Access::DEVELOPER)

        access_levels(projects)

        queries = ActiveRecord::QueryRecorder.new { access_levels(all_projects) }

        expect(queries.count).to eq(1)
4081
        expect(queries.log_message).to match(/\W(#{second_maintainer_project.id}, #{second_developer_project.id})\W/)
4082 4083 4084 4085 4086 4087 4088 4089 4090 4091 4092 4093 4094
        expect(access_levels(all_projects)).to eq(expected_all)
      end
    end

    context 'with RequestStore disabled' do
      include_examples 'max member access for projects'
    end
  end

  describe '#max_member_access_for_group_ids' do
    shared_examples 'max member access for groups' do
      let(:user) { create(:user) }
      let(:owner_group) { create(:group) }
4095
      let(:maintainer_group) { create(:group) }
4096 4097 4098 4099 4100 4101
      let(:reporter_group) { create(:group) }
      let(:developer_group) { create(:group) }
      let(:guest_group) { create(:group) }
      let(:no_access_group) { create(:group) }

      let(:groups) do
4102
        [owner_group, maintainer_group, reporter_group, developer_group, guest_group, no_access_group].map(&:id)
4103 4104 4105 4106 4107
      end

      let(:expected) do
        {
          owner_group.id => Gitlab::Access::OWNER,
4108
          maintainer_group.id => Gitlab::Access::MAINTAINER,
4109 4110 4111 4112 4113 4114 4115 4116 4117
          reporter_group.id => Gitlab::Access::REPORTER,
          developer_group.id => Gitlab::Access::DEVELOPER,
          guest_group.id => Gitlab::Access::GUEST,
          no_access_group.id => Gitlab::Access::NO_ACCESS
        }
      end

      before do
        owner_group.add_owner(user)
4118
        maintainer_group.add_maintainer(user)
4119 4120 4121 4122 4123 4124 4125 4126 4127 4128 4129 4130 4131 4132 4133 4134 4135 4136 4137 4138 4139 4140 4141 4142 4143 4144
        reporter_group.add_reporter(user)
        developer_group.add_developer(user)
        guest_group.add_guest(user)
      end

      it 'returns correct roles for different groups' do
        expect(user.max_member_access_for_group_ids(groups)).to eq(expected)
      end
    end

    context 'with RequestStore enabled', :request_store do
      include_examples 'max member access for groups'

      def access_levels(groups)
        user.max_member_access_for_group_ids(groups)
      end

      it 'does not perform extra queries when asked for groups who have already been found' do
        access_levels(groups)

        expect { access_levels(groups) }.not_to exceed_query_limit(0)

        expect(access_levels(groups)).to eq(expected)
      end

      it 'only requests the extra groups when uncached groups are passed' do
4145
        second_maintainer_group = create(:group)
4146
        second_developer_group = create(:group)
4147
        second_maintainer_group.add_maintainer(user)
4148 4149
        second_developer_group.add_developer(user)

4150
        all_groups = groups + [second_maintainer_group.id, second_developer_group.id]
4151

4152
        expected_all = expected.merge(second_maintainer_group.id => Gitlab::Access::MAINTAINER,
4153 4154 4155 4156 4157 4158 4159
                                      second_developer_group.id => Gitlab::Access::DEVELOPER)

        access_levels(groups)

        queries = ActiveRecord::QueryRecorder.new { access_levels(all_groups) }

        expect(queries.count).to eq(1)
4160
        expect(queries.log_message).to match(/\W(#{second_maintainer_group.id}, #{second_developer_group.id})\W/)
4161 4162 4163 4164 4165 4166 4167 4168
        expect(access_levels(all_groups)).to eq(expected_all)
      end
    end

    context 'with RequestStore disabled' do
      include_examples 'max member access for groups'
    end
  end
4169

B
Bob Van Landuyt 已提交
4170 4171
  context 'changing a username' do
    let(:user) { create(:user, username: 'foo') }
4172

B
Bob Van Landuyt 已提交
4173 4174 4175
    it 'creates a redirect route' do
      expect { user.update!(username: 'bar') }
        .to change { RedirectRoute.where(path: 'foo').count }.by(1)
4176 4177
    end

B
Bob Van Landuyt 已提交
4178 4179 4180 4181 4182
    it 'deletes the redirect when a user with the old username was created' do
      user.update!(username: 'bar')

      expect { create(:user, username: 'foo') }
        .to change { RedirectRoute.where(path: 'foo').count }.by(-1)
4183 4184
    end
  end
4185 4186 4187

  describe '#required_terms_not_accepted?' do
    let(:user) { build(:user) }
4188

4189 4190 4191 4192 4193 4194 4195 4196 4197 4198 4199 4200 4201 4202 4203 4204 4205 4206 4207 4208 4209 4210 4211
    subject { user.required_terms_not_accepted? }

    context "when terms are not enforced" do
      it { is_expected.to be_falsy }
    end

    context "when terms are enforced and accepted by the user" do
      before do
        enforce_terms
        accept_terms(user)
      end

      it { is_expected.to be_falsy }
    end

    context "when terms are enforced but the user has not accepted" do
      before do
        enforce_terms
      end

      it { is_expected.to be_truthy }
    end
  end
4212 4213 4214 4215 4216 4217 4218 4219 4220 4221 4222 4223 4224 4225

  describe '#increment_failed_attempts!' do
    subject(:user) { create(:user, failed_attempts: 0) }

    it 'logs failed sign-in attempts' do
      expect { user.increment_failed_attempts! }.to change(user, :failed_attempts).from(0).to(1)
    end

    it 'does not log failed sign-in attempts when in a GitLab read-only instance' do
      allow(Gitlab::Database).to receive(:read_only?) { true }

      expect { user.increment_failed_attempts! }.not_to change(user, :failed_attempts)
    end
  end
J
Jan Provaznik 已提交
4226

4227
  describe '#requires_usage_stats_consent?' do
4228
    let(:user) { create(:user, :admin, created_at: 8.days.ago) }
4229 4230 4231 4232 4233 4234 4235

    before do
      allow(user).to receive(:has_current_license?).and_return false
    end

    context 'in single-user environment' do
      it 'requires user consent after one week' do
4236
        create(:user, :ghost)
4237 4238 4239 4240 4241 4242 4243 4244 4245 4246 4247 4248 4249 4250 4251

        expect(user.requires_usage_stats_consent?).to be true
      end

      it 'requires user consent after one week if there is another ghost user' do
        expect(user.requires_usage_stats_consent?).to be true
      end

      it 'does not require consent in the first week' do
        user.created_at = 6.days.ago

        expect(user.requires_usage_stats_consent?).to be false
      end

      it 'does not require consent if usage stats were set by this user' do
S
Stan Hu 已提交
4252
        create(:application_setting, usage_stats_set_by_user_id: user.id)
4253 4254 4255 4256 4257 4258 4259 4260 4261 4262 4263 4264 4265 4266 4267 4268

        expect(user.requires_usage_stats_consent?).to be false
      end
    end

    context 'in multi-user environment' do
      before do
        create(:user)
      end

      it 'does not require consent' do
        expect(user.requires_usage_stats_consent?).to be false
      end
    end
  end

J
Jan Provaznik 已提交
4269
  context 'with uploads' do
4270
    it_behaves_like 'model with uploads', false do
J
Jan Provaznik 已提交
4271 4272 4273 4274 4275
      let(:model_object) { create(:user, :with_avatar) }
      let(:upload_attribute) { :avatar }
      let(:uploader_class) { AttachmentUploader }
    end
  end
Y
Yorick Peterse 已提交
4276 4277 4278 4279 4280 4281 4282 4283 4284 4285 4286 4287 4288 4289 4290 4291 4292 4293 4294 4295 4296 4297 4298 4299 4300 4301 4302 4303 4304 4305 4306 4307 4308 4309 4310 4311 4312 4313 4314 4315 4316 4317 4318 4319 4320 4321 4322 4323 4324 4325 4326 4327 4328 4329 4330 4331 4332 4333 4334 4335 4336 4337 4338 4339 4340 4341 4342 4343 4344 4345 4346 4347 4348 4349 4350 4351 4352 4353 4354 4355 4356 4357

  describe '.union_with_user' do
    context 'when no user ID is provided' do
      it 'returns the input relation' do
        user = create(:user)

        expect(described_class.union_with_user).to eq([user])
      end
    end

    context 'when a user ID is provided' do
      it 'includes the user object in the returned relation' do
        user1 = create(:user)
        user2 = create(:user)
        users = described_class.where(id: user1.id).union_with_user(user2.id)

        expect(users).to include(user1)
        expect(users).to include(user2)
      end

      it 'does not re-apply any WHERE conditions on the outer query' do
        relation = described_class.where(id: 1).union_with_user(2)

        expect(relation.arel.where_sql).to be_nil
      end
    end
  end

  describe '.optionally_search' do
    context 'using nil as the argument' do
      it 'returns the current relation' do
        user = create(:user)

        expect(described_class.optionally_search).to eq([user])
      end
    end

    context 'using an empty String as the argument' do
      it 'returns the current relation' do
        user = create(:user)

        expect(described_class.optionally_search('')).to eq([user])
      end
    end

    context 'using a non-empty String' do
      it 'returns users matching the search query' do
        user1 = create(:user)
        create(:user)

        expect(described_class.optionally_search(user1.name)).to eq([user1])
      end
    end
  end

  describe '.where_not_in' do
    context 'without an argument' do
      it 'returns the current relation' do
        user = create(:user)

        expect(described_class.where_not_in).to eq([user])
      end
    end

    context 'using a list of user IDs' do
      it 'excludes the users from the returned relation' do
        user1 = create(:user)
        user2 = create(:user)

        expect(described_class.where_not_in([user2.id])).to eq([user1])
      end
    end
  end

  describe '.reorder_by_name' do
    it 'reorders the input relation' do
      user1 = create(:user, name: 'A')
      user2 = create(:user, name: 'B')

      expect(described_class.reorder_by_name).to eq([user1, user2])
    end
  end
4358

4359 4360 4361 4362 4363 4364 4365 4366 4367 4368 4369 4370 4371 4372 4373 4374 4375 4376 4377 4378 4379 4380 4381 4382 4383 4384 4385 4386 4387 4388 4389
  describe '#notification_settings_for' do
    let(:user) { create(:user) }
    let(:source) { nil }

    subject { user.notification_settings_for(source) }

    context 'when source is nil' do
      it 'returns a blank global notification settings object' do
        expect(subject.source).to eq(nil)
        expect(subject.notification_email).to eq(nil)
        expect(subject.level).to eq('global')
      end
    end

    context 'when source is a Group' do
      let(:group) { create(:group) }

      subject { user.notification_settings_for(group, inherit: true) }

      context 'when group has no existing notification settings' do
        context 'when group has no ancestors' do
          it 'will be a default Global notification setting' do
            expect(subject.notification_email).to eq(nil)
            expect(subject.level).to eq('global')
          end
        end

        context 'when group has ancestors' do
          context 'when an ancestor has a level other than Global' do
            let(:ancestor) { create(:group) }
            let(:group) { create(:group, parent: ancestor) }
4390
            let(:email) { create(:email, :confirmed, email: 'ancestor@example.com', user: user) }
4391 4392

            before do
4393
              create(:notification_setting, user: user, source: ancestor, level: 'participating', notification_email: email.email)
4394 4395 4396 4397 4398 4399 4400 4401 4402 4403 4404 4405 4406 4407 4408 4409 4410 4411 4412 4413 4414 4415 4416 4417
            end

            it 'has the same level set' do
              expect(subject.level).to eq('participating')
            end

            it 'has the same email set' do
              expect(subject.notification_email).to eq('ancestor@example.com')
            end

            context 'when inherit is false' do
              subject { user.notification_settings_for(group) }

              it 'does not inherit settings' do
                expect(subject.notification_email).to eq(nil)
                expect(subject.level).to eq('global')
              end
            end
          end

          context 'when an ancestor has a Global level but has an email set' do
            let(:grand_ancestor) { create(:group) }
            let(:ancestor) { create(:group, parent: grand_ancestor) }
            let(:group) { create(:group, parent: ancestor) }
4418 4419
            let(:ancestor_email) { create(:email, :confirmed, email: 'ancestor@example.com', user: user) }
            let(:grand_email) { create(:email, :confirmed, email: 'grand@example.com', user: user) }
4420 4421

            before do
4422 4423
              create(:notification_setting, user: user, source: grand_ancestor, level: 'participating', notification_email: grand_email.email)
              create(:notification_setting, user: user, source: ancestor, level: 'global', notification_email: ancestor_email.email)
4424 4425 4426 4427 4428 4429 4430 4431 4432 4433 4434 4435
            end

            it 'has the same email set' do
              expect(subject.level).to eq('global')
              expect(subject.notification_email).to eq('ancestor@example.com')
            end
          end
        end
      end
    end
  end

4436 4437 4438 4439 4440 4441 4442 4443 4444 4445 4446 4447 4448 4449 4450 4451 4452 4453 4454 4455 4456 4457 4458 4459 4460
  describe '#notification_email_for' do
    let(:user) { create(:user) }
    let(:group) { create(:group) }

    subject { user.notification_email_for(group) }

    context 'when group is nil' do
      let(:group) { nil }

      it 'returns global notification email' do
        is_expected.to eq(user.notification_email)
      end
    end

    context 'when group has no notification email set' do
      it 'returns global notification email' do
        create(:notification_setting, user: user, source: group, notification_email: '')

        is_expected.to eq(user.notification_email)
      end
    end

    context 'when group has notification email set' do
      it 'returns group notification email' do
        group_notification_email = 'user+group@example.com'
4461
        create(:email, :confirmed, user: user, email: group_notification_email)
4462 4463 4464 4465 4466 4467
        create(:notification_setting, user: user, source: group, notification_email: group_notification_email)

        is_expected.to eq(group_notification_email)
      end
    end
  end
4468 4469 4470 4471 4472 4473 4474 4475 4476 4477 4478 4479 4480 4481 4482 4483 4484 4485 4486 4487 4488 4489 4490 4491 4492 4493 4494 4495 4496 4497

  describe '#password_expired?' do
    let(:user) { build(:user, password_expires_at: password_expires_at) }

    subject { user.password_expired? }

    context 'when password_expires_at is not set' do
      let(:password_expires_at) {}

      it 'returns false' do
        is_expected.to be_falsey
      end
    end

    context 'when password_expires_at is in the past' do
      let(:password_expires_at) { 1.minute.ago }

      it 'returns true' do
        is_expected.to be_truthy
      end
    end

    context 'when password_expires_at is in the future' do
      let(:password_expires_at) { 1.minute.from_now }

      it 'returns false' do
        is_expected.to be_falsey
      end
    end
  end
4498 4499 4500 4501 4502 4503 4504 4505 4506 4507 4508 4509

  describe '#read_only_attribute?' do
    context 'when synced attributes metadata is present' do
      it 'delegates to synced_attributes_metadata' do
        subject.build_user_synced_attributes_metadata

        expect(subject.build_user_synced_attributes_metadata)
          .to receive(:read_only?).with(:email).and_return('return-value')
        expect(subject.read_only_attribute?(:email)).to eq('return-value')
      end
    end

4510
    context 'when synced attributes metadata is not present' do
4511 4512 4513 4514 4515
      it 'is false for any attribute' do
        expect(subject.read_only_attribute?(:email)).to be_falsey
      end
    end
  end
4516

4517 4518 4519 4520 4521 4522
  describe '.active_without_ghosts' do
    let_it_be(:user1) { create(:user, :external) }
    let_it_be(:user2) { create(:user, state: 'blocked') }
    let_it_be(:user3) { create(:user, :ghost) }
    let_it_be(:user4) { create(:user, user_type: :support_bot) }
    let_it_be(:user5) { create(:user, state: 'blocked', user_type: :support_bot) }
4523

4524 4525
    it 'returns all active users including active bots but ghost users' do
      expect(described_class.active_without_ghosts).to match_array([user1, user4])
4526 4527 4528
    end
  end

4529 4530 4531
  describe '#dismissed_callout?' do
    subject(:user) { create(:user) }

4532
    let(:feature_name) { UserCallout.feature_names.each_key.first }
4533 4534 4535 4536 4537 4538 4539 4540 4541 4542 4543 4544 4545 4546 4547 4548 4549 4550 4551 4552 4553 4554 4555 4556 4557 4558 4559 4560 4561 4562

    context 'when no callout dismissal record exists' do
      it 'returns false when no ignore_dismissal_earlier_than provided' do
        expect(user.dismissed_callout?(feature_name: feature_name)).to eq false
      end

      it 'returns false when ignore_dismissal_earlier_than provided' do
        expect(user.dismissed_callout?(feature_name: feature_name, ignore_dismissal_earlier_than: 3.months.ago)).to eq false
      end
    end

    context 'when dismissed callout exists' do
      before do
        create(:user_callout, user: user, feature_name: feature_name, dismissed_at: 4.months.ago)
      end

      it 'returns true when no ignore_dismissal_earlier_than provided' do
        expect(user.dismissed_callout?(feature_name: feature_name)).to eq true
      end

      it 'returns true when ignore_dismissal_earlier_than is earlier than dismissed_at' do
        expect(user.dismissed_callout?(feature_name: feature_name, ignore_dismissal_earlier_than: 6.months.ago)).to eq true
      end

      it 'returns false when ignore_dismissal_earlier_than is later than dismissed_at' do
        expect(user.dismissed_callout?(feature_name: feature_name, ignore_dismissal_earlier_than: 3.months.ago)).to eq false
      end
    end
  end

4563 4564 4565 4566 4567 4568 4569 4570 4571 4572 4573 4574
  describe '#hook_attrs' do
    it 'includes name, username, avatar_url, and email' do
      user = create(:user)
      user_attributes = {
        name: user.name,
        username: user.username,
        avatar_url: user.avatar_url(only_path: false),
        email: user.email
      }
      expect(user.hook_attrs).to eq(user_attributes)
    end
  end
4575 4576 4577 4578 4579 4580 4581 4582 4583 4584 4585 4586 4587 4588 4589

  describe 'user detail' do
    context 'when user is initialized' do
      let(:user) { build(:user) }

      it { expect(user.user_detail).to be_present }
      it { expect(user.user_detail).not_to be_persisted }
    end

    context 'when user detail exists' do
      let(:user) { create(:user, job_title: 'Engineer') }

      it { expect(user.user_detail).to be_persisted }
    end
  end
4590

4591 4592 4593 4594 4595 4596 4597 4598 4599 4600 4601 4602 4603 4604 4605 4606 4607 4608 4609
  describe '#current_highest_access_level' do
    let_it_be(:user) { create(:user) }

    context 'when no memberships exist' do
      it 'returns nil' do
        expect(user.current_highest_access_level).to be_nil
      end
    end

    context 'when memberships exist' do
      it 'returns the highest access level for non requested memberships' do
        create(:group_member, :reporter, user_id: user.id)
        create(:project_member, :guest, user_id: user.id)
        create(:project_member, :maintainer, user_id: user.id, requested_at: Time.current)

        expect(user.current_highest_access_level).to eq(Gitlab::Access::REPORTER)
      end
    end
  end
4610 4611 4612

  context 'when after_commit :update_highest_role' do
    describe 'create user' do
4613 4614 4615 4616 4617
      subject { create(:user) }

      it 'schedules a job in the future', :aggregate_failures, :clean_gitlab_redis_shared_state do
        allow_next_instance_of(Gitlab::ExclusiveLease) do |instance|
          allow(instance).to receive(:try_obtain).and_return('uuid')
4618 4619
        end

4620 4621 4622
        expect(UpdateHighestRoleWorker).to receive(:perform_in).and_call_original

        expect { subject }.to change(UpdateHighestRoleWorker.jobs, :size).by(1)
4623 4624 4625 4626 4627
      end
    end

    context 'when user already exists' do
      let!(:user) { create(:user) }
4628
      let(:user_id) { user.id }
4629 4630 4631 4632 4633 4634 4635

      describe 'update user' do
        using RSpec::Parameterized::TableSyntax

        where(:attributes) do
          [
            { state: 'blocked' },
4636
            { user_type: :ghost },
4637 4638
            { user_type: :alert_bot },
            { user_type: :support_bot }
4639 4640 4641 4642 4643
          ]
        end

        with_them do
          context 'when state was changed' do
4644
            subject { user.update(attributes) }
4645

4646
            include_examples 'update highest role with exclusive lease'
4647 4648 4649 4650
          end
        end

        context 'when state was not changed' do
4651
          subject { user.update(email: 'newmail@example.com') }
4652

4653
          include_examples 'does not update the highest role'
4654 4655
        end
      end
4656 4657 4658 4659 4660 4661

      describe 'destroy user' do
        subject { user.destroy }

        include_examples 'does not update the highest role'
      end
4662 4663
    end
  end
4664 4665 4666 4667 4668 4669 4670 4671 4672 4673 4674 4675 4676 4677 4678 4679

  describe '#active_for_authentication?' do
    subject { user.active_for_authentication? }

    let(:user) { create(:user) }

    context 'when user is blocked' do
      before do
        user.block
      end

      it { is_expected.to be false }
    end

    context 'when user is a ghost user' do
      before do
4680
        user.update(user_type: :ghost)
4681 4682 4683 4684 4685 4686 4687 4688 4689 4690 4691
      end

      it { is_expected.to be false }
    end

    context 'based on user type' do
      using RSpec::Parameterized::TableSyntax

      where(:user_type, :expected_result) do
        'human'             | true
        'alert_bot'         | false
4692
        'support_bot'       | false
4693 4694 4695 4696 4697 4698 4699 4700 4701 4702 4703 4704 4705 4706 4707 4708 4709 4710 4711 4712 4713 4714 4715 4716 4717 4718 4719
      end

      with_them do
        before do
          user.update(user_type: user_type)
        end

        it { is_expected.to be expected_result }
      end
    end
  end

  describe '#inactive_message' do
    subject { user.inactive_message }

    let(:user) { create(:user) }

    context 'when user is blocked' do
      before do
        user.block
      end

      it { is_expected.to eq User::BLOCKED_MESSAGE }
    end

    context 'when user is an internal user' do
      before do
4720
        user.update(user_type: :ghost)
4721 4722 4723 4724 4725 4726 4727 4728 4729 4730 4731 4732 4733
      end

      it { is_expected.to be User::LOGIN_FORBIDDEN }
    end

    context 'when user is locked' do
      before do
        user.lock_access!
      end

      it { is_expected.to be :locked }
    end
  end
4734 4735 4736 4737 4738 4739 4740 4741 4742 4743 4744 4745 4746 4747 4748 4749 4750 4751 4752 4753 4754 4755 4756 4757 4758 4759

  describe '#password_required?' do
    let_it_be(:user) { create(:user) }

    shared_examples 'does not require password to be present' do
      it { expect(user).not_to validate_presence_of(:password) }

      it { expect(user).not_to validate_presence_of(:password_confirmation) }
    end

    context 'when user is an internal user' do
      before do
        user.update(user_type: 'alert_bot')
      end

      it_behaves_like 'does not require password to be present'
    end

    context 'when user is a project bot user' do
      before do
        user.update(user_type: 'project_bot')
      end

      it_behaves_like 'does not require password to be present'
    end
  end
4760

4761 4762 4763 4764 4765 4766 4767
  context 'bot users' do
    shared_examples 'bot users' do |bot_type|
      it 'creates the user if it does not exist' do
        expect do
          described_class.public_send(bot_type)
        end.to change { User.where(user_type: bot_type).count }.by(1)
      end
4768

4769 4770 4771 4772 4773 4774
      it 'creates a route for the namespace of the created user' do
        bot_user = described_class.public_send(bot_type)

        expect(bot_user.namespace.route).to be_present
      end

4775 4776
      it 'does not create a new user if it already exists' do
        described_class.public_send(bot_type)
4777

4778 4779 4780 4781
        expect do
          described_class.public_send(bot_type)
        end.not_to change { User.count }
      end
4782
    end
4783

4784 4785 4786 4787 4788 4789 4790 4791 4792
    shared_examples 'bot user avatars' do |bot_type, avatar_filename|
      it 'sets the custom avatar for the created bot' do
        bot_user = described_class.public_send(bot_type)

        expect(bot_user.avatar.url).to be_present
        expect(bot_user.avatar.filename).to eq(avatar_filename)
      end
    end

4793 4794 4795 4796
    it_behaves_like 'bot users', :alert_bot
    it_behaves_like 'bot users', :support_bot
    it_behaves_like 'bot users', :migration_bot
    it_behaves_like 'bot users', :ghost
4797 4798 4799

    it_behaves_like 'bot user avatars', :alert_bot, 'alert-bot.png'
    it_behaves_like 'bot user avatars', :support_bot, 'support-bot.png'
4800
  end
G
gitlabhq 已提交
4801
end