Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
a32f1ddd
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
a32f1ddd
编写于
9月 14, 2017
作者:
B
Brett Walker
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
fixes for rubocop
上级
a000c2a1
变更
5
隐藏空白更改
内联
并排
Showing
5 changed file
with
12 addition
and
15 deletion
+12
-15
app/controllers/profiles/emails_controller.rb
app/controllers/profiles/emails_controller.rb
+1
-2
app/services/emails/create_service.rb
app/services/emails/create_service.rb
+1
-1
spec/controllers/profiles/emails_controller_spec.rb
spec/controllers/profiles/emails_controller_spec.rb
+2
-2
spec/models/gpg_key_spec.rb
spec/models/gpg_key_spec.rb
+4
-4
spec/models/user_spec.rb
spec/models/user_spec.rb
+4
-6
未找到文件。
app/controllers/profiles/emails_controller.rb
浏览文件 @
a32f1ddd
class
Profiles::EmailsController
<
Profiles
::
ApplicationController
before_action
:find_email
,
only:
[
:destroy
,
:resend_confirmation_instructions
]
def
index
...
...
@@ -39,7 +38,7 @@ class Profiles::EmailsController < Profiles::ApplicationController
def
email_params
params
.
require
(
:email
).
permit
(
:email
)
end
def
find_email
@email
=
current_user
.
emails
.
find
(
params
[
:id
])
end
...
...
app/services/emails/create_service.rb
浏览文件 @
a32f1ddd
module
Emails
class
CreateService
<
::
Emails
::
BaseService
def
execute
(
options
=
{})
@user
.
emails
.
create
({
email:
@email
}.
merge
(
options
))
@user
.
emails
.
create
({
email:
@email
}.
merge
(
options
))
end
end
end
spec/controllers/profiles/emails_controller_spec.rb
浏览文件 @
a32f1ddd
...
...
@@ -8,7 +8,7 @@ describe Profiles::EmailsController do
end
describe
'#create'
do
let
(
:email_params
)
{
{
email:
"add_email@example.com"
}
}
let
(
:email_params
)
{
{
email:
"add_email@example.com"
}
}
it
'sends an email confirmation'
do
expect
{
post
(
:create
,
{
email:
email_params
})}.
to
change
{
ActionMailer
::
Base
.
deliveries
.
size
}
...
...
@@ -18,7 +18,7 @@ describe Profiles::EmailsController do
end
describe
'#resend_confirmation_instructions'
do
let
(
:email_params
)
{
{
email:
"add_email@example.com"
}
}
let
(
:email_params
)
{
{
email:
"add_email@example.com"
}
}
it
'resends an email confirmation'
do
email
=
user
.
emails
.
create
(
email:
'add_email@example.com'
)
...
...
spec/models/gpg_key_spec.rb
浏览文件 @
a32f1ddd
...
...
@@ -88,17 +88,17 @@ describe GpgKey do
describe
'#emails_with_verified_status'
do
it
'email is verified if the user has the matching email'
do
user
=
create
:user
,
email:
'bette.cartwright@example.com'
user
=
create
:user
,
email:
'bette.cartwright@example.com'
gpg_key
=
create
:gpg_key
,
key:
GpgHelpers
::
User2
.
public_key
,
user:
user
email_unconfirmed
=
create
:email
,
user:
user
create
:email
,
user:
user
user
.
reload
expect
(
gpg_key
.
emails_with_verified_status
).
to
eq
(
'bette.cartwright@example.com'
=>
true
,
'bette.cartwright@example.net'
=>
false
'bette.cartwright@example.net'
=>
false
)
email_confirmed
=
create
:email
,
:confirmed
,
user:
user
,
email:
'bette.cartwright@example.net'
create
:email
,
:confirmed
,
user:
user
,
email:
'bette.cartwright@example.net'
user
.
reload
expect
(
gpg_key
.
emails_with_verified_status
).
to
eq
(
'bette.cartwright@example.com'
=>
true
,
...
...
spec/models/user_spec.rb
浏览文件 @
a32f1ddd
...
...
@@ -409,14 +409,12 @@ describe User do
end
it
'transfers old confirmation values into new secondary'
do
org_user
=
@user
@user
.
update_attributes!
(
email:
@secondary
.
email
)
@user
.
reload
expect
(
@user
.
emails
.
count
).
to
eq
1
expect
(
@user
.
emails
.
first
.
confirmed_at
).
not_to
eq
nil
end
end
end
describe
'#update_tracked_fields!'
,
:clean_gitlab_redis_shared_state
do
...
...
@@ -1146,8 +1144,8 @@ describe User do
let
(
:user
)
{
create
(
:user
)
}
it
'returns only confirmed emails'
do
email_confirmed
=
create
:email
,
user:
user
,
confirmed_at:
Time
.
now
email_unconfirmed
=
create
:email
,
user:
user
email_confirmed
=
create
:email
,
user:
user
,
confirmed_at:
Time
.
now
create
:email
,
user:
user
user
.
reload
expect
(
user
.
verified_emails
).
to
match_array
([
user
.
email
,
email_confirmed
.
email
])
end
...
...
@@ -1157,8 +1155,8 @@ describe User do
let
(
:user
)
{
create
(
:user
)
}
it
'returns true when the email is verified/confirmed'
do
email_confirmed
=
create
:email
,
user:
user
,
confirmed_at:
Time
.
now
email_unconfirmed
=
create
:email
,
user:
user
email_confirmed
=
create
:email
,
user:
user
,
confirmed_at:
Time
.
now
create
:email
,
user:
user
user
.
reload
expect
(
user
.
verified_email?
(
user
.
email
)).
to
be_truthy
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录