user_spec.rb 82.7 KB
Newer Older
G
gitlabhq 已提交
1 2
require 'spec_helper'

3
describe User do
B
Bob Van Landuyt 已提交
4
  include ProjectForksHelper
5

6 7 8 9 10 11 12
  describe 'modules' do
    subject { described_class }

    it { is_expected.to include_module(Gitlab::ConfigHelper) }
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
    it { is_expected.to include_module(TokenAuthenticatable) }
13
    it { is_expected.to include_module(BlocksJsonSerialization) }
14 15
  end

16 17 18 19
  describe 'delegations' do
    it { is_expected.to delegate_method(:path).to(:namespace).with_prefix }
  end

20
  describe 'associations' do
21
    it { is_expected.to have_one(:namespace) }
22
    it { is_expected.to have_many(:snippets).dependent(:destroy) }
23 24 25
    it { is_expected.to have_many(:members) }
    it { is_expected.to have_many(:project_members) }
    it { is_expected.to have_many(:group_members) }
26 27
    it { is_expected.to have_many(:groups) }
    it { is_expected.to have_many(:keys).dependent(:destroy) }
28
    it { is_expected.to have_many(:deploy_keys).dependent(:destroy) }
29
    it { is_expected.to have_many(:events).dependent(:destroy) }
30
    it { is_expected.to have_many(:recent_events).class_name('Event') }
31
    it { is_expected.to have_many(:issues).dependent(:destroy) }
32 33 34
    it { is_expected.to have_many(:notes).dependent(:destroy) }
    it { is_expected.to have_many(:merge_requests).dependent(:destroy) }
    it { is_expected.to have_many(:identities).dependent(:destroy) }
35
    it { is_expected.to have_many(:spam_logs).dependent(:destroy) }
36
    it { is_expected.to have_many(:todos).dependent(:destroy) }
37
    it { is_expected.to have_many(:award_emoji).dependent(:destroy) }
K
Kamil Trzcinski 已提交
38
    it { is_expected.to have_many(:triggers).dependent(:destroy) }
39 40
    it { is_expected.to have_many(:builds).dependent(:nullify) }
    it { is_expected.to have_many(:pipelines).dependent(:nullify) }
K
Kamil Trzcinski 已提交
41
    it { is_expected.to have_many(:chat_names).dependent(:destroy) }
42
    it { is_expected.to have_many(:uploads).dependent(:destroy) }
43
    it { is_expected.to have_many(:reported_abuse_reports).dependent(:destroy).class_name('AbuseReport') }
44
    it { is_expected.to have_many(:custom_attributes).class_name('UserCustomAttribute') }
45

46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71
    describe "#abuse_report" do
      let(:current_user) { create(:user) }
      let(:other_user) { create(:user) }

      it { is_expected.to have_one(:abuse_report) }

      it "refers to the abuse report whose user_id is the current user" do
        abuse_report = create(:abuse_report, reporter: other_user, user: current_user)

        expect(current_user.abuse_report).to eq(abuse_report)
      end

      it "does not refer to the abuse report whose reporter_id is the current user" do
        create(:abuse_report, reporter: current_user, user: other_user)

        expect(current_user.abuse_report).to be_nil
      end

      it "does not update the user_id of an abuse report when the user is updated" do
        abuse_report = create(:abuse_report, reporter: current_user, user: other_user)

        current_user.block

        expect(abuse_report.reload.user).to eq(other_user)
      end
    end
72 73 74 75

    describe '#group_members' do
      it 'does not include group memberships for which user is a requester' do
        user = create(:user)
76
        group = create(:group, :public, :access_requestable)
77 78 79 80 81 82 83 84 85
        group.request_access(user)

        expect(user.group_members).to be_empty
      end
    end

    describe '#project_members' do
      it 'does not include project memberships for which user is a requester' do
        user = create(:user)
86
        project = create(:project, :public, :access_requestable)
87 88 89 90 91
        project.request_access(user)

        expect(user.project_members).to be_empty
      end
    end
92 93 94
  end

  describe 'validations' do
R
Robert Speicher 已提交
95 96 97 98 99 100 101 102 103 104 105 106
    describe 'username' do
      it 'validates presence' do
        expect(subject).to validate_presence_of(:username)
      end

      it 'rejects blacklisted names' do
        user = build(:user, username: 'dashboard')

        expect(user).not_to be_valid
        expect(user.errors.values).to eq [['dashboard is a reserved name']]
      end

107 108 109 110 111 112 113 114 115 116 117 118
      it 'allows child names' do
        user = build(:user, username: 'avatar')

        expect(user).to be_valid
      end

      it 'allows wildcard names' do
        user = build(:user, username: 'blob')

        expect(user).to be_valid
      end

R
Robert Speicher 已提交
119
      it 'validates uniqueness' do
120 121 122
        user = build(:user)

        expect(user).to validate_uniqueness_of(:username).case_insensitive
R
Robert Speicher 已提交
123
      end
124 125 126 127 128 129 130 131 132 133 134

      context 'when username is changed' do
        let(:user) { build_stubbed(:user, username: 'old_path', namespace: build_stubbed(:namespace)) }

        it 'validates move_dir is allowed for the namespace' do
          expect(user.namespace).to receive(:any_project_has_container_registry_tags?).and_return(true)
          user.username = 'new_path'
          expect(user).to be_invalid
          expect(user.errors.messages[:username].first).to match('cannot be changed if a personal project has container registry tags')
        end
      end
R
Robert Speicher 已提交
135 136
    end

137 138 139 140 141 142 143 144 145 146
    it 'has a DB-level NOT NULL constraint on projects_limit' do
      user = create(:user)

      expect(user.persisted?).to eq(true)

      expect do
        user.update_columns(projects_limit: nil)
      end.to raise_error(ActiveRecord::StatementInvalid)
    end

147 148 149 150
    it { is_expected.to validate_presence_of(:projects_limit) }
    it { is_expected.to validate_numericality_of(:projects_limit) }
    it { is_expected.to allow_value(0).for(:projects_limit) }
    it { is_expected.not_to allow_value(-1).for(:projects_limit) }
151
    it { is_expected.not_to allow_value(Gitlab::Database::MAX_INT_VALUE + 1).for(:projects_limit) }
152

153
    it { is_expected.to validate_length_of(:bio).is_at_most(255) }
154

155 156 157
    it_behaves_like 'an object with email-formated attributes', :email do
      subject { build(:user) }
    end
158

159 160 161
    it_behaves_like 'an object with email-formated attributes', :public_email, :notification_email do
      subject { build(:user).tap { |user| user.emails << build(:email, email: email_value) } }
    end
162

163
    describe 'email' do
164
      context 'when no signup domains whitelisted' do
165
        before do
166
          allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return([])
167
        end
168

169 170 171 172 173 174
        it 'accepts any email' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end
      end

175
      context 'when a signup domain is whitelisted and subdomains are allowed' do
176
        before do
177
          allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['example.com', '*.example.com'])
178
        end
179

180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195
        it 'accepts info@example.com' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end

        it 'accepts info@test.example.com' do
          user = build(:user, email: "info@test.example.com")
          expect(user).to be_valid
        end

        it 'rejects example@test.com' do
          user = build(:user, email: "example@test.com")
          expect(user).to be_invalid
        end
      end

196
      context 'when a signup domain is whitelisted and subdomains are not allowed' do
197
        before do
198
          allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['example.com'])
199
        end
200 201 202 203 204 205 206 207 208 209 210 211 212 213 214

        it 'accepts info@example.com' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end

        it 'rejects info@test.example.com' do
          user = build(:user, email: "info@test.example.com")
          expect(user).to be_invalid
        end

        it 'rejects example@test.com' do
          user = build(:user, email: "example@test.com")
          expect(user).to be_invalid
        end
215 216 217 218 219

        it 'accepts example@test.com when added by another user' do
          user = build(:user, email: "example@test.com", created_by_id: 1)
          expect(user).to be_valid
        end
220
      end
221

222 223 224 225 226 227
      context 'domain blacklist' do
        before do
          allow_any_instance_of(ApplicationSetting).to receive(:domain_blacklist_enabled?).and_return(true)
          allow_any_instance_of(ApplicationSetting).to receive(:domain_blacklist).and_return(['example.com'])
        end

228
        context 'when a signup domain is blacklisted' do
229 230 231 232 233 234 235 236 237
          it 'accepts info@test.com' do
            user = build(:user, email: 'info@test.com')
            expect(user).to be_valid
          end

          it 'rejects info@example.com' do
            user = build(:user, email: 'info@example.com')
            expect(user).not_to be_valid
          end
238 239 240 241 242

          it 'accepts info@example.com when added by another user' do
            user = build(:user, email: 'info@example.com', created_by_id: 1)
            expect(user).to be_valid
          end
243 244
        end

245
        context 'when a signup domain is blacklisted but a wildcard subdomain is allowed' do
246 247
          before do
            allow_any_instance_of(ApplicationSetting).to receive(:domain_blacklist).and_return(['test.example.com'])
248
            allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['*.example.com'])
249 250
          end

251
          it 'gives priority to whitelist and allow info@test.example.com' do
252 253 254 255 256 257 258
            user = build(:user, email: 'info@test.example.com')
            expect(user).to be_valid
          end
        end

        context 'with both lists containing a domain' do
          before do
259
            allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['test.com'])
260 261 262 263 264 265 266 267 268 269 270 271 272 273
          end

          it 'accepts info@test.com' do
            user = build(:user, email: 'info@test.com')
            expect(user).to be_valid
          end

          it 'rejects info@example.com' do
            user = build(:user, email: 'info@example.com')
            expect(user).not_to be_valid
          end
        end
      end

274 275 276 277 278 279
      context 'owns_notification_email' do
        it 'accepts temp_oauth_email emails' do
          user = build(:user, email: "temp-email-for-oauth@example.com")
          expect(user).to be_valid
        end
      end
280
    end
281 282 283 284 285 286 287
  end

  describe "scopes" do
    describe ".with_two_factor" do
      it "returns users with 2fa enabled via OTP" do
        user_with_2fa = create(:user, :two_factor_via_otp)
        user_without_2fa = create(:user)
288
        users_with_two_factor = described_class.with_two_factor.pluck(:id)
289 290 291 292 293 294 295 296

        expect(users_with_two_factor).to include(user_with_2fa.id)
        expect(users_with_two_factor).not_to include(user_without_2fa.id)
      end

      it "returns users with 2fa enabled via U2F" do
        user_with_2fa = create(:user, :two_factor_via_u2f)
        user_without_2fa = create(:user)
297
        users_with_two_factor = described_class.with_two_factor.pluck(:id)
298 299 300 301 302 303 304 305

        expect(users_with_two_factor).to include(user_with_2fa.id)
        expect(users_with_two_factor).not_to include(user_without_2fa.id)
      end

      it "returns users with 2fa enabled via OTP and U2F" do
        user_with_2fa = create(:user, :two_factor_via_otp, :two_factor_via_u2f)
        user_without_2fa = create(:user)
306
        users_with_two_factor = described_class.with_two_factor.pluck(:id)
307 308 309 310 311 312 313 314 315 316

        expect(users_with_two_factor).to eq([user_with_2fa.id])
        expect(users_with_two_factor).not_to include(user_without_2fa.id)
      end
    end

    describe ".without_two_factor" do
      it "excludes users with 2fa enabled via OTP" do
        user_with_2fa = create(:user, :two_factor_via_otp)
        user_without_2fa = create(:user)
317
        users_without_two_factor = described_class.without_two_factor.pluck(:id)
318 319 320 321 322 323 324 325

        expect(users_without_two_factor).to include(user_without_2fa.id)
        expect(users_without_two_factor).not_to include(user_with_2fa.id)
      end

      it "excludes users with 2fa enabled via U2F" do
        user_with_2fa = create(:user, :two_factor_via_u2f)
        user_without_2fa = create(:user)
326
        users_without_two_factor = described_class.without_two_factor.pluck(:id)
327 328 329 330 331 332 333 334

        expect(users_without_two_factor).to include(user_without_2fa.id)
        expect(users_without_two_factor).not_to include(user_with_2fa.id)
      end

      it "excludes users with 2fa enabled via OTP and U2F" do
        user_with_2fa = create(:user, :two_factor_via_otp, :two_factor_via_u2f)
        user_without_2fa = create(:user)
335
        users_without_two_factor = described_class.without_two_factor.pluck(:id)
336 337 338 339 340

        expect(users_without_two_factor).to include(user_without_2fa.id)
        expect(users_without_two_factor).not_to include(user_with_2fa.id)
      end
    end
V
Valery Sizov 已提交
341 342 343 344 345 346 347 348 349 350

    describe '.todo_authors' do
      it 'filters users' do
        create :user
        user_2 = create :user
        user_3 = create :user
        current_user = create :user
        create(:todo, user: current_user, author: user_2, state: :done)
        create(:todo, user: current_user, author: user_3, state: :pending)

351 352
        expect(described_class.todo_authors(current_user.id, 'pending')).to eq [user_3]
        expect(described_class.todo_authors(current_user.id, 'done')).to eq [user_2]
V
Valery Sizov 已提交
353 354
      end
    end
G
gitlabhq 已提交
355 356 357
  end

  describe "Respond to" do
B
blackst0ne 已提交
358
    it { is_expected.to respond_to(:admin?) }
359
    it { is_expected.to respond_to(:name) }
Z
Zeger-Jan van de Weg 已提交
360 361 362 363 364 365 366 367 368 369 370 371 372 373
    it { is_expected.to respond_to(:external?) }
  end

  describe 'before save hook' do
    context 'when saving an external user' do
      let(:user)          { create(:user) }
      let(:external_user) { create(:user, external: true) }

      it "sets other properties aswell" do
        expect(external_user.can_create_team).to be_falsey
        expect(external_user.can_create_group).to be_falsey
        expect(external_user.projects_limit).to be 0
      end
    end
374

375 376
    describe '#check_for_verified_email' do
      let(:user)      { create(:user) }
377 378
      let(:secondary) { create(:email, :confirmed, email: 'secondary@example.com', user: user) }

379 380 381 382 383 384 385 386
      it 'allows a verfied secondary email to be used as the primary without needing reconfirmation' do
        user.update_attributes!(email: secondary.email)
        user.reload
        expect(user.email).to eq secondary.email
        expect(user.unconfirmed_email).to eq nil
        expect(user.confirmed?).to be_truthy
      end
    end
G
gitlabhq 已提交
387 388
  end

389
  describe 'after commit hook' do
390 391 392 393 394 395 396 397 398 399 400 401 402
    describe '.update_invalid_gpg_signatures' do
      let(:user) do
        create(:user, email: 'tula.torphy@abshire.ca').tap do |user|
          user.skip_reconfirmation!
        end
      end

      it 'does nothing when the name is updated' do
        expect(user).not_to receive(:update_invalid_gpg_signatures)
        user.update_attributes!(name: 'Bette')
      end

      it 'synchronizes the gpg keys when the email is updated' do
403
        expect(user).to receive(:update_invalid_gpg_signatures).at_most(:twice)
404 405 406
        user.update_attributes!(email: 'shawnee.ritchie@denesik.com')
      end
    end
407 408 409 410 411 412 413 414 415 416 417 418

    describe '#update_emails_with_primary_email' do
      before do
        @user = create(:user, email: 'primary@example.com').tap do |user|
          user.skip_reconfirmation!
        end
        @secondary = create :email, email: 'secondary@example.com', user: @user
        @user.reload
      end

      it 'gets called when email updated' do
        expect(@user).to receive(:update_emails_with_primary_email)
419

420 421 422
        @user.update_attributes!(email: 'new_primary@example.com')
      end

423
      it 'adds old primary to secondary emails when secondary is a new email ' do
424 425
        @user.update_attributes!(email: 'new_primary@example.com')
        @user.reload
426

427 428
        expect(@user.emails.count).to eq 2
        expect(@user.emails.pluck(:email)).to match_array([@secondary.email, 'primary@example.com'])
429 430 431 432 433
      end

      it 'adds old primary to secondary emails if secondary is becoming a primary' do
        @user.update_attributes!(email: @secondary.email)
        @user.reload
434

435 436 437 438 439 440 441
        expect(@user.emails.count).to eq 1
        expect(@user.emails.first.email).to eq 'primary@example.com'
      end

      it 'transfers old confirmation values into new secondary' do
        @user.update_attributes!(email: @secondary.email)
        @user.reload
442

443 444 445 446
        expect(@user.emails.count).to eq 1
        expect(@user.emails.first.confirmed_at).not_to eq nil
      end
    end
447 448
  end

449
  describe '#update_tracked_fields!', :clean_gitlab_redis_shared_state do
450 451 452 453 454 455 456 457 458 459 460 461 462 463
    let(:request) { OpenStruct.new(remote_ip: "127.0.0.1") }
    let(:user) { create(:user) }

    it 'writes trackable attributes' do
      expect do
        user.update_tracked_fields!(request)
      end.to change { user.reload.current_sign_in_at }
    end

    it 'does not write trackable attributes when called a second time within the hour' do
      user.update_tracked_fields!(request)

      expect do
        user.update_tracked_fields!(request)
464 465 466 467 468 469 470 471 472 473 474
      end.not_to change { user.reload.current_sign_in_at }
    end

    it 'writes trackable attributes for a different user' do
      user2 = create(:user)

      user.update_tracked_fields!(request)

      expect do
        user2.update_tracked_fields!(request)
      end.to change { user2.reload.current_sign_in_at }
475 476 477
    end
  end

478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505
  shared_context 'user keys' do
    let(:user) { create(:user) }
    let!(:key) { create(:key, user: user) }
    let!(:deploy_key) { create(:deploy_key, user: user) }
  end

  describe '#keys' do
    include_context 'user keys'

    context 'with key and deploy key stored' do
      it 'returns stored key, but not deploy_key' do
        expect(user.keys).to include key
        expect(user.keys).not_to include deploy_key
      end
    end
  end

  describe '#deploy_keys' do
    include_context 'user keys'

    context 'with key and deploy key stored' do
      it 'returns stored deploy key, but not normal key' do
        expect(user.deploy_keys).to include deploy_key
        expect(user.deploy_keys).not_to include key
      end
    end
  end

506
  describe '#confirm' do
507 508 509
    before do
      allow_any_instance_of(ApplicationSetting).to receive(:send_user_confirmation_email).and_return(true)
    end
510

511 512 513 514 515 516 517
    let(:user) { create(:user, confirmed_at: nil, unconfirmed_email: 'test@gitlab.com') }

    it 'returns unconfirmed' do
      expect(user.confirmed?).to be_falsey
    end

    it 'confirms a user' do
518
      user.confirm
519 520 521 522
      expect(user.confirmed?).to be_truthy
    end
  end

523 524 525 526 527 528 529 530
  describe '#to_reference' do
    let(:user) { create(:user) }

    it 'returns a String reference to the object' do
      expect(user.to_reference).to eq "@#{user.username}"
    end
  end

531
  describe '#generate_password' do
532
    it "does not generate password by default" do
533
      user = create(:user, password: 'abcdefghe')
534

535
      expect(user.password).to eq('abcdefghe')
536
    end
537 538
  end

539 540 541
  describe 'ensure incoming email token' do
    it 'has incoming email token' do
      user = create(:user)
542

543 544 545 546
      expect(user.incoming_email_token).not_to be_blank
    end
  end

547 548 549 550 551 552 553 554 555 556 557
  describe '#ensure_user_rights_and_limits' do
    describe 'with external user' do
      let(:user) { create(:user, external: true) }

      it 'receives callback when external changes' do
        expect(user).to receive(:ensure_user_rights_and_limits)

        user.update_attributes(external: false)
      end

      it 'ensures correct rights and limits for user' do
T
Tiago Botelho 已提交
558 559
        stub_config_setting(default_can_create_group: true)

560
        expect { user.update_attributes(external: false) }.to change { user.can_create_group }.to(true)
561
          .and change { user.projects_limit }.to(Gitlab::CurrentSettings.default_projects_limit)
562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580
      end
    end

    describe 'without external user' do
      let(:user) { create(:user, external: false) }

      it 'receives callback when external changes' do
        expect(user).to receive(:ensure_user_rights_and_limits)

        user.update_attributes(external: true)
      end

      it 'ensures correct rights and limits for user' do
        expect { user.update_attributes(external: true) }.to change { user.can_create_group }.to(false)
          .and change { user.projects_limit }.to(0)
      end
    end
  end

581
  describe 'rss token' do
A
Alexis Reigel 已提交
582 583 584
    it 'ensures an rss token on read' do
      user = create(:user, rss_token: nil)
      rss_token = user.rss_token
585

A
Alexis Reigel 已提交
586 587
      expect(rss_token).not_to be_blank
      expect(user.reload.rss_token).to eq rss_token
588 589 590
    end
  end

591
  describe '#recently_sent_password_reset?' do
592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610
    it 'is false when reset_password_sent_at is nil' do
      user = build_stubbed(:user, reset_password_sent_at: nil)

      expect(user.recently_sent_password_reset?).to eq false
    end

    it 'is false when sent more than one minute ago' do
      user = build_stubbed(:user, reset_password_sent_at: 5.minutes.ago)

      expect(user.recently_sent_password_reset?).to eq false
    end

    it 'is true when sent less than one minute ago' do
      user = build_stubbed(:user, reset_password_sent_at: Time.now)

      expect(user.recently_sent_password_reset?).to eq true
    end
  end

R
Robert Speicher 已提交
611 612 613 614 615 616 617
  describe '#disable_two_factor!' do
    it 'clears all 2FA-related fields' do
      user = create(:user, :two_factor)

      expect(user).to be_two_factor_enabled
      expect(user.encrypted_otp_secret).not_to be_nil
      expect(user.otp_backup_codes).not_to be_nil
618
      expect(user.otp_grace_period_started_at).not_to be_nil
R
Robert Speicher 已提交
619 620 621 622 623 624 625 626

      user.disable_two_factor!

      expect(user).not_to be_two_factor_enabled
      expect(user.encrypted_otp_secret).to be_nil
      expect(user.encrypted_otp_secret_iv).to be_nil
      expect(user.encrypted_otp_secret_salt).to be_nil
      expect(user.otp_backup_codes).to be_nil
627
      expect(user.otp_grace_period_started_at).to be_nil
R
Robert Speicher 已提交
628 629 630
    end
  end

631 632
  describe 'projects' do
    before do
633
      @user = create(:user)
634

635 636
      @project = create(:project, namespace: @user.namespace)
      @project_2 = create(:project, group: create(:group)) do |project|
637 638
        project.add_master(@user)
      end
639
      @project_3 = create(:project, group: create(:group)) do |project|
640 641
        project.add_developer(@user)
      end
642 643
    end

644 645 646 647 648 649 650 651 652
    it { expect(@user.authorized_projects).to include(@project) }
    it { expect(@user.authorized_projects).to include(@project_2) }
    it { expect(@user.authorized_projects).to include(@project_3) }
    it { expect(@user.owned_projects).to include(@project) }
    it { expect(@user.owned_projects).not_to include(@project_2) }
    it { expect(@user.owned_projects).not_to include(@project_3) }
    it { expect(@user.personal_projects).to include(@project) }
    it { expect(@user.personal_projects).not_to include(@project_2) }
    it { expect(@user.personal_projects).not_to include(@project_3) }
653 654 655
  end

  describe 'groups' do
656 657 658
    let(:user) { create(:user) }
    let(:group) { create(:group) }

659
    before do
660
      group.add_owner(user)
661 662
    end

663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689
    it { expect(user.several_namespaces?).to be_truthy }
    it { expect(user.authorized_groups).to eq([group]) }
    it { expect(user.owned_groups).to eq([group]) }
    it { expect(user.namespaces).to contain_exactly(user.namespace, group) }
    it { expect(user.manageable_namespaces).to contain_exactly(user.namespace, group) }

    context 'with child groups', :nested_groups do
      let!(:subgroup) { create(:group, parent: group) }

      describe '#manageable_namespaces' do
        it 'includes all the namespaces the user can manage' do
          expect(user.manageable_namespaces).to contain_exactly(user.namespace, group, subgroup)
        end
      end

      describe '#manageable_groups' do
        it 'includes all the namespaces the user can manage' do
          expect(user.manageable_groups).to contain_exactly(group, subgroup)
        end

        it 'does not include duplicates if a membership was added for the subgroup' do
          subgroup.add_owner(user)

          expect(user.manageable_groups).to contain_exactly(group, subgroup)
        end
      end
    end
690 691
  end

692 693 694 695
  describe 'group multiple owners' do
    before do
      @user = create :user
      @user2 = create :user
696 697
      @group = create :group
      @group.add_owner(@user)
698

699
      @group.add_user(@user2, GroupMember::OWNER)
700 701
    end

702
    it { expect(@user2.several_namespaces?).to be_truthy }
703 704
  end

705 706 707
  describe 'namespaced' do
    before do
      @user = create :user
708
      @project = create(:project, namespace: @user.namespace)
709 710
    end

711
    it { expect(@user.several_namespaces?).to be_falsey }
712
    it { expect(@user.namespaces).to eq([@user.namespace]) }
713 714 715 716 717
  end

  describe 'blocking user' do
    let(:user) { create(:user, name: 'John Smith') }

718
    it "blocks user" do
719
      user.block
720

721
      expect(user.blocked?).to be_truthy
722 723 724
    end
  end

725 726 727 728
  describe '.filter' do
    let(:user) { double }

    it 'filters by active users by default' do
729
      expect(described_class).to receive(:active).and_return([user])
730

731
      expect(described_class.filter(nil)).to include user
732 733
    end

734
    it 'filters by admins' do
735
      expect(described_class).to receive(:admins).and_return([user])
736

737
      expect(described_class.filter('admins')).to include user
738 739
    end

740
    it 'filters by blocked' do
741
      expect(described_class).to receive(:blocked).and_return([user])
742

743
      expect(described_class.filter('blocked')).to include user
744 745 746
    end

    it 'filters by two_factor_disabled' do
747
      expect(described_class).to receive(:without_two_factor).and_return([user])
748

749
      expect(described_class.filter('two_factor_disabled')).to include user
750 751 752
    end

    it 'filters by two_factor_enabled' do
753
      expect(described_class).to receive(:with_two_factor).and_return([user])
754

755
      expect(described_class.filter('two_factor_enabled')).to include user
756 757 758
    end

    it 'filters by wop' do
759
      expect(described_class).to receive(:without_projects).and_return([user])
760

761
      expect(described_class.filter('wop')).to include user
762
    end
763 764
  end

B
Ben Bodenmiller 已提交
765
  describe '.without_projects' do
766
    let!(:project) { create(:project, :public, :access_requestable) }
B
Ben Bodenmiller 已提交
767 768 769 770 771 772
    let!(:user) { create(:user) }
    let!(:user_without_project) { create(:user) }
    let!(:user_without_project2) { create(:user) }

    before do
      # add user to project
773
      project.add_master(user)
B
Ben Bodenmiller 已提交
774 775 776 777 778 779 780 781

      # create invite to projet
      create(:project_member, :developer, project: project, invite_token: '1234', invite_email: 'inviteduser1@example.com')

      # create request to join project
      project.request_access(user_without_project2)
    end

782 783 784
    it { expect(described_class.without_projects).not_to include user }
    it { expect(described_class.without_projects).to include user_without_project }
    it { expect(described_class.without_projects).to include user_without_project2 }
B
Ben Bodenmiller 已提交
785 786
  end

787 788 789
  describe 'user creation' do
    describe 'normal user' do
      let(:user) { create(:user, name: 'John Smith') }
D
Dmitriy Zaporozhets 已提交
790

B
blackst0ne 已提交
791
      it { expect(user.admin?).to be_falsey }
792 793 794 795
      it { expect(user.require_ssh_key?).to be_truthy }
      it { expect(user.can_create_group?).to be_truthy }
      it { expect(user.can_create_project?).to be_truthy }
      it { expect(user.first_name).to eq('John') }
796
      it { expect(user.external).to be_falsey }
797
    end
798

D
Dmitriy Zaporozhets 已提交
799
    describe 'with defaults' do
800
      let(:user) { described_class.new }
D
Dmitriy Zaporozhets 已提交
801

802
      it "applies defaults to user" do
803 804
        expect(user.projects_limit).to eq(Gitlab.config.gitlab.default_projects_limit)
        expect(user.can_create_group).to eq(Gitlab.config.gitlab.default_can_create_group)
805
        expect(user.theme_id).to eq(Gitlab.config.gitlab.default_theme)
Z
Zeger-Jan van de Weg 已提交
806
        expect(user.external).to be_falsey
807 808 809
      end
    end

D
Dmitriy Zaporozhets 已提交
810
    describe 'with default overrides' do
811
      let(:user) { described_class.new(projects_limit: 123, can_create_group: false, can_create_team: true) }
D
Dmitriy Zaporozhets 已提交
812

813
      it "applies defaults to user" do
814 815
        expect(user.projects_limit).to eq(123)
        expect(user.can_create_group).to be_falsey
816
        expect(user.theme_id).to eq(1)
817
      end
818 819 820 821 822 823 824

      it 'does not undo projects_limit setting if it matches old DB default of 10' do
        # If the real default project limit is 10 then this test is worthless
        expect(Gitlab.config.gitlab.default_projects_limit).not_to eq(10)
        user = described_class.new(projects_limit: 10)
        expect(user.projects_limit).to eq(10)
      end
825
    end
826

827
    context 'when Gitlab::CurrentSettings.user_default_external is true' do
828 829 830 831 832
      before do
        stub_application_setting(user_default_external: true)
      end

      it "creates external user by default" do
833
        user = create(:user)
834 835

        expect(user.external).to be_truthy
836 837
        expect(user.can_create_group).to be_falsey
        expect(user.projects_limit).to be 0
838 839 840 841
      end

      describe 'with default overrides' do
        it "creates a non-external user" do
842
          user = create(:user, external: false)
843 844 845 846 847

          expect(user.external).to be_falsey
        end
      end
    end
848

Y
Yorick Peterse 已提交
849
    describe '#require_ssh_key?', :use_clean_rails_memory_store_caching do
850 851 852
      protocol_and_expectation = {
        'http' => false,
        'ssh' => true,
853
        '' => true
854 855 856 857 858 859 860 861 862
      }

      protocol_and_expectation.each do |protocol, expected|
        it "has correct require_ssh_key?" do
          stub_application_setting(enabled_git_access_protocol: protocol)
          user = build(:user)

          expect(user.require_ssh_key?).to eq(expected)
        end
863
      end
Y
Yorick Peterse 已提交
864 865 866 867 868 869

      it 'returns false when the user has 1 or more SSH keys' do
        key = create(:personal_key)

        expect(key.user.require_ssh_key?).to eq(false)
      end
870
    end
871
  end
872

873
  describe '.find_by_any_email' do
874 875 876
    it 'finds by primary email' do
      user = create(:user, email: 'foo@example.com')

877
      expect(described_class.find_by_any_email(user.email)).to eq user
878 879 880 881 882 883
    end

    it 'finds by secondary email' do
      email = create(:email, email: 'foo@example.com')
      user  = email.user

884
      expect(described_class.find_by_any_email(email.email)).to eq user
885 886 887
    end

    it 'returns nil when nothing found' do
888
      expect(described_class.find_by_any_email('')).to be_nil
889 890 891
    end
  end

Y
Yorick Peterse 已提交
892 893 894 895 896 897 898 899 900 901 902 903 904
  describe '.by_any_email' do
    it 'returns an ActiveRecord::Relation' do
      expect(described_class.by_any_email('foo@example.com'))
        .to be_a_kind_of(ActiveRecord::Relation)
    end

    it 'returns a relation of users' do
      user = create(:user)

      expect(described_class.by_any_email(user.email)).to eq([user])
    end
  end

905
  describe '.search' do
906 907
    let!(:user) { create(:user, name: 'user', username: 'usern', email: 'email@gmail.com') }
    let!(:user2) { create(:user, name: 'user name', username: 'username', email: 'someemail@gmail.com') }
908
    let!(:user3) { create(:user, name: 'us', username: 'se', email: 'foo@gmail.com') }
909

910 911 912 913
    describe 'name matching' do
      it 'returns users with a matching name with exact match first' do
        expect(described_class.search(user.name)).to eq([user, user2])
      end
914

915
      it 'returns users with a partially matching name' do
916
        expect(described_class.search(user.name[0..2])).to eq([user, user2])
917
      end
918

919 920 921
      it 'returns users with a matching name regardless of the casing' do
        expect(described_class.search(user2.name.upcase)).to eq([user2])
      end
922 923 924 925 926 927 928 929

      it 'returns users with a exact matching name shorter than 3 chars' do
        expect(described_class.search(user3.name)).to eq([user3])
      end

      it 'returns users with a exact matching name shorter than 3 chars regardless of the casing' do
        expect(described_class.search(user3.name.upcase)).to eq([user3])
      end
930 931
    end

932 933
    describe 'email matching' do
      it 'returns users with a matching Email' do
934
        expect(described_class.search(user.email)).to eq([user])
935
      end
936

937 938
      it 'does not return users with a partially matching Email' do
        expect(described_class.search(user.email[0..2])).not_to include(user, user2)
939
      end
940

941 942 943
      it 'returns users with a matching Email regardless of the casing' do
        expect(described_class.search(user2.email.upcase)).to eq([user2])
      end
944 945
    end

946 947 948 949
    describe 'username matching' do
      it 'returns users with a matching username' do
        expect(described_class.search(user.username)).to eq([user, user2])
      end
950

951
      it 'returns users with a partially matching username' do
952
        expect(described_class.search(user.username[0..2])).to eq([user, user2])
953
      end
954

955 956 957
      it 'returns users with a matching username regardless of the casing' do
        expect(described_class.search(user2.username.upcase)).to eq([user2])
      end
958 959 960 961 962 963 964 965

      it 'returns users with a exact matching username shorter than 3 chars' do
        expect(described_class.search(user3.username)).to eq([user3])
      end

      it 'returns users with a exact matching username shorter than 3 chars regardless of the casing' do
        expect(described_class.search(user3.username.upcase)).to eq([user3])
      end
M
Marin Jankovski 已提交
966
    end
967 968 969 970 971 972 973 974

    it 'returns no matches for an empty string' do
      expect(described_class.search('')).to be_empty
    end

    it 'returns no matches for nil' do
      expect(described_class.search(nil)).to be_empty
    end
975 976 977
  end

  describe '.search_with_secondary_emails' do
D
Douwe Maan 已提交
978
    delegate :search_with_secondary_emails, to: :described_class
979

980 981
    let!(:user) { create(:user, name: 'John Doe', username: 'john.doe', email: 'john.doe@example.com' ) }
    let!(:another_user) { create(:user, name: 'Albert Smith', username: 'albert.smith', email: 'albert.smith@example.com' ) }
982 983 984
    let!(:email) do
      create(:email, user: another_user, email: 'alias@example.com')
    end
985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001

    it 'returns users with a matching name' do
      expect(search_with_secondary_emails(user.name)).to eq([user])
    end

    it 'returns users with a partially matching name' do
      expect(search_with_secondary_emails(user.name[0..2])).to eq([user])
    end

    it 'returns users with a matching name regardless of the casing' do
      expect(search_with_secondary_emails(user.name.upcase)).to eq([user])
    end

    it 'returns users with a matching email' do
      expect(search_with_secondary_emails(user.email)).to eq([user])
    end

1002 1003
    it 'does not return users with a partially matching email' do
      expect(search_with_secondary_emails(user.email[0..2])).not_to include([user])
1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025
    end

    it 'returns users with a matching email regardless of the casing' do
      expect(search_with_secondary_emails(user.email.upcase)).to eq([user])
    end

    it 'returns users with a matching username' do
      expect(search_with_secondary_emails(user.username)).to eq([user])
    end

    it 'returns users with a partially matching username' do
      expect(search_with_secondary_emails(user.username[0..2])).to eq([user])
    end

    it 'returns users with a matching username regardless of the casing' do
      expect(search_with_secondary_emails(user.username.upcase)).to eq([user])
    end

    it 'returns users with a matching whole secondary email' do
      expect(search_with_secondary_emails(email.email)).to eq([email.user])
    end

1026 1027
    it 'does not return users with a matching part of secondary email' do
      expect(search_with_secondary_emails(email.email[1..4])).not_to include([email.user])
1028
    end
1029 1030 1031 1032 1033 1034 1035 1036

    it 'returns no matches for an empty string' do
      expect(search_with_secondary_emails('')).to be_empty
    end

    it 'returns no matches for nil' do
      expect(search_with_secondary_emails(nil)).to be_empty
    end
M
Marin Jankovski 已提交
1037 1038
  end

Y
Yorick Peterse 已提交
1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055
  describe '.find_by_ssh_key_id' do
    context 'using an existing SSH key ID' do
      let(:user) { create(:user) }
      let(:key) { create(:key, user: user) }

      it 'returns the corresponding User' do
        expect(described_class.find_by_ssh_key_id(key.id)).to eq(user)
      end
    end

    context 'using an invalid SSH key ID' do
      it 'returns nil' do
        expect(described_class.find_by_ssh_key_id(-1)).to be_nil
      end
    end
  end

1056 1057 1058 1059
  describe '.by_login' do
    let(:username) { 'John' }
    let!(:user) { create(:user, username: username) }

1060
    it 'gets the correct user' do
1061 1062 1063 1064 1065 1066
      expect(described_class.by_login(user.email.upcase)).to eq user
      expect(described_class.by_login(user.email)).to eq user
      expect(described_class.by_login(username.downcase)).to eq user
      expect(described_class.by_login(username)).to eq user
      expect(described_class.by_login(nil)).to be_nil
      expect(described_class.by_login('')).to be_nil
1067 1068 1069
    end
  end

1070 1071 1072 1073 1074 1075 1076
  describe '.find_by_username' do
    it 'returns nil if not found' do
      expect(described_class.find_by_username('JohnDoe')).to be_nil
    end

    it 'is case-insensitive' do
      user = create(:user, username: 'JohnDoe')
1077

1078 1079 1080 1081
      expect(described_class.find_by_username('JOHNDOE')).to eq user
    end
  end

R
Robert Speicher 已提交
1082 1083
  describe '.find_by_username!' do
    it 'raises RecordNotFound' do
1084 1085
      expect { described_class.find_by_username!('JohnDoe') }
        .to raise_error(ActiveRecord::RecordNotFound)
R
Robert Speicher 已提交
1086 1087 1088 1089
    end

    it 'is case-insensitive' do
      user = create(:user, username: 'JohnDoe')
1090

R
Robert Speicher 已提交
1091 1092 1093 1094
      expect(described_class.find_by_username!('JOHNDOE')).to eq user
    end
  end

1095 1096 1097 1098 1099 1100 1101
  describe '.find_by_full_path' do
    let!(:user) { create(:user) }

    context 'with a route matching the given path' do
      let!(:route) { user.namespace.route }

      it 'returns the user' do
1102
        expect(described_class.find_by_full_path(route.path)).to eq(user)
1103 1104 1105
      end

      it 'is case-insensitive' do
1106 1107
        expect(described_class.find_by_full_path(route.path.upcase)).to eq(user)
        expect(described_class.find_by_full_path(route.path.downcase)).to eq(user)
1108 1109 1110 1111 1112 1113 1114 1115
      end
    end

    context 'with a redirect route matching the given path' do
      let!(:redirect_route) { user.namespace.redirect_routes.create(path: 'foo') }

      context 'without the follow_redirects option' do
        it 'returns nil' do
1116
          expect(described_class.find_by_full_path(redirect_route.path)).to eq(nil)
1117 1118 1119 1120 1121
        end
      end

      context 'with the follow_redirects option set to true' do
        it 'returns the user' do
1122
          expect(described_class.find_by_full_path(redirect_route.path, follow_redirects: true)).to eq(user)
1123 1124 1125
        end

        it 'is case-insensitive' do
1126 1127
          expect(described_class.find_by_full_path(redirect_route.path.upcase, follow_redirects: true)).to eq(user)
          expect(described_class.find_by_full_path(redirect_route.path.downcase, follow_redirects: true)).to eq(user)
1128 1129 1130 1131 1132 1133 1134
        end
      end
    end

    context 'without a route or a redirect route matching the given path' do
      context 'without the follow_redirects option' do
        it 'returns nil' do
1135
          expect(described_class.find_by_full_path('unknown')).to eq(nil)
1136 1137 1138 1139
        end
      end
      context 'with the follow_redirects option set to true' do
        it 'returns nil' do
1140
          expect(described_class.find_by_full_path('unknown', follow_redirects: true)).to eq(nil)
1141 1142 1143 1144 1145
        end
      end
    end

    context 'with a group route matching the given path' do
M
Michael Kozono 已提交
1146 1147
      context 'when the group namespace has an owner_id (legacy data)' do
        let!(:group) { create(:group, path: 'group_path', owner: user) }
1148

M
Michael Kozono 已提交
1149
        it 'returns nil' do
1150
          expect(described_class.find_by_full_path('group_path')).to eq(nil)
M
Michael Kozono 已提交
1151 1152 1153 1154 1155 1156 1157
        end
      end

      context 'when the group namespace does not have an owner_id' do
        let!(:group) { create(:group, path: 'group_path') }

        it 'returns nil' do
1158
          expect(described_class.find_by_full_path('group_path')).to eq(nil)
M
Michael Kozono 已提交
1159
        end
1160 1161 1162 1163
      end
    end
  end

G
GitLab 已提交
1164
  describe 'all_ssh_keys' do
1165
    it { is_expected.to have_many(:keys).dependent(:destroy) }
G
GitLab 已提交
1166

1167
    it "has all ssh keys" do
G
GitLab 已提交
1168 1169 1170
      user = create :user
      key = create :key, key: "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQD33bWLBxu48Sev9Fert1yzEO4WGcWglWF7K/AwblIUFselOt/QdOL9DSjpQGxLagO1s9wl53STIO8qGS4Ms0EJZyIXOEFMjFJ5xmjSy+S37By4sG7SsltQEHMxtbtFOaW5LV2wCrX+rUsRNqLMamZjgjcPO0/EgGCXIGMAYW4O7cwGZdXWYIhQ1Vwy+CsVMDdPkPgBXqK7nR/ey8KMs8ho5fMNgB5hBw/AL9fNGhRw3QTD6Q12Nkhl4VZES2EsZqlpNnJttnPdp847DUsT6yuLRlfiQfz5Cn9ysHFdXObMN5VYIiPFwHeYCZp1X2S4fDZooRE8uOLTfxWHPXwrhqSH", user_id: user.id

1171
      expect(user.all_ssh_keys).to include(a_string_starting_with(key.key))
G
GitLab 已提交
1172
    end
G
GitLab 已提交
1173
  end
1174

1175
  describe '#avatar_type' do
D
Dmitriy Zaporozhets 已提交
1176 1177
    let(:user) { create(:user) }

1178
    it 'is true if avatar is image' do
D
Dmitriy Zaporozhets 已提交
1179
      user.update_attribute(:avatar, 'uploads/avatar.png')
1180

1181
      expect(user.avatar_type).to be_truthy
D
Dmitriy Zaporozhets 已提交
1182 1183
    end

1184
    it 'is false if avatar is html page' do
D
Dmitriy Zaporozhets 已提交
1185
      user.update_attribute(:avatar, 'uploads/avatar.html')
1186

1187
      expect(user.avatar_type).to eq(['only images allowed'])
D
Dmitriy Zaporozhets 已提交
1188 1189
    end
  end
J
Jerome Dalbert 已提交
1190

1191 1192 1193 1194
  describe '#avatar_url' do
    let(:user) { create(:user, :with_avatar) }

    context 'when avatar file is uploaded' do
1195
      it 'shows correct avatar url' do
1196 1197
        expect(user.avatar_url).to eq(user.avatar.url)
        expect(user.avatar_url(only_path: false)).to eq([Gitlab.config.gitlab.url, user.avatar.url].join)
1198
      end
1199 1200 1201
    end
  end

1202 1203 1204 1205 1206 1207 1208
  describe '#all_emails' do
    let(:user) { create(:user) }

    it 'returns all emails' do
      email_confirmed   = create :email, user: user, confirmed_at: Time.now
      email_unconfirmed = create :email, user: user
      user.reload
1209

1210
      expect(user.all_emails).to match_array([user.email, email_unconfirmed.email, email_confirmed.email])
1211 1212 1213
    end
  end

1214
  describe '#verified_emails' do
1215 1216 1217
    let(:user) { create(:user) }

    it 'returns only confirmed emails' do
B
Brett Walker 已提交
1218 1219
      email_confirmed = create :email, user: user, confirmed_at: Time.now
      create :email, user: user
1220
      user.reload
1221

1222
      expect(user.verified_emails).to match_array([user.email, email_confirmed.email])
1223 1224 1225 1226 1227 1228 1229
    end
  end

  describe '#verified_email?' do
    let(:user) { create(:user) }

    it 'returns true when the email is verified/confirmed' do
B
Brett Walker 已提交
1230 1231
      email_confirmed = create :email, user: user, confirmed_at: Time.now
      create :email, user: user
1232 1233 1234
      user.reload

      expect(user.verified_email?(user.email)).to be_truthy
1235
      expect(user.verified_email?(email_confirmed.email.titlecase)).to be_truthy
1236 1237 1238 1239 1240 1241 1242 1243 1244 1245
    end

    it 'returns false when the email is not verified/confirmed' do
      email_unconfirmed = create :email, user: user
      user.reload

      expect(user.verified_email?(email_unconfirmed.email)).to be_falsy
    end
  end

1246
  describe '#requires_ldap_check?' do
1247
    let(:user) { described_class.new }
1248

1249 1250
    it 'is false when LDAP is disabled' do
      # Create a condition which would otherwise cause 'true' to be returned
1251
      allow(user).to receive(:ldap_user?).and_return(true)
1252
      user.last_credential_check_at = nil
1253

1254
      expect(user.requires_ldap_check?).to be_falsey
1255 1256
    end

1257
    context 'when LDAP is enabled' do
1258 1259 1260
      before do
        allow(Gitlab.config.ldap).to receive(:enabled).and_return(true)
      end
1261

1262
      it 'is false for non-LDAP users' do
1263
        allow(user).to receive(:ldap_user?).and_return(false)
1264

1265
        expect(user.requires_ldap_check?).to be_falsey
1266 1267
      end

1268
      context 'and when the user is an LDAP user' do
1269 1270 1271
        before do
          allow(user).to receive(:ldap_user?).and_return(true)
        end
1272 1273 1274

        it 'is true when the user has never had an LDAP check before' do
          user.last_credential_check_at = nil
1275

1276
          expect(user.requires_ldap_check?).to be_truthy
1277 1278 1279 1280
        end

        it 'is true when the last LDAP check happened over 1 hour ago' do
          user.last_credential_check_at = 2.hours.ago
1281

1282
          expect(user.requires_ldap_check?).to be_truthy
1283
        end
1284 1285 1286 1287
      end
    end
  end

1288
  context 'ldap synchronized user' do
1289
    describe '#ldap_user?' do
1290 1291
      it 'is true if provider name starts with ldap' do
        user = create(:omniauth_user, provider: 'ldapmain')
1292

1293 1294
        expect(user.ldap_user?).to be_truthy
      end
1295

1296 1297
      it 'is false for other providers' do
        user = create(:omniauth_user, provider: 'other-provider')
1298

1299 1300 1301 1302 1303
        expect(user.ldap_user?).to be_falsey
      end

      it 'is false if no extern_uid is provided' do
        user = create(:omniauth_user, extern_uid: nil)
1304

1305 1306
        expect(user.ldap_user?).to be_falsey
      end
1307 1308
    end

1309
    describe '#ldap_identity' do
1310 1311
      it 'returns ldap identity' do
        user = create :omniauth_user
1312

1313 1314
        expect(user.ldap_identity.provider).not_to be_empty
      end
1315 1316
    end

1317 1318 1319 1320 1321
    describe '#ldap_block' do
      let(:user) { create(:omniauth_user, provider: 'ldapmain', name: 'John Smith') }

      it 'blocks user flaging the action caming from ldap' do
        user.ldap_block
1322

1323 1324 1325
        expect(user.blocked?).to be_truthy
        expect(user.ldap_blocked?).to be_truthy
      end
1326 1327 1328
    end
  end

J
Jerome Dalbert 已提交
1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367
  describe '#full_website_url' do
    let(:user) { create(:user) }

    it 'begins with http if website url omits it' do
      user.website_url = 'test.com'

      expect(user.full_website_url).to eq 'http://test.com'
    end

    it 'begins with http if website url begins with http' do
      user.website_url = 'http://test.com'

      expect(user.full_website_url).to eq 'http://test.com'
    end

    it 'begins with https if website url begins with https' do
      user.website_url = 'https://test.com'

      expect(user.full_website_url).to eq 'https://test.com'
    end
  end

  describe '#short_website_url' do
    let(:user) { create(:user) }

    it 'does not begin with http if website url omits it' do
      user.website_url = 'test.com'

      expect(user.short_website_url).to eq 'test.com'
    end

    it 'does not begin with http if website url begins with http' do
      user.website_url = 'http://test.com'

      expect(user.short_website_url).to eq 'test.com'
    end

    it 'does not begin with https if website url begins with https' do
      user.website_url = 'https://test.com'
1368

J
Jerome Dalbert 已提交
1369 1370
      expect(user.short_website_url).to eq 'test.com'
    end
G
GitLab 已提交
1371
  end
C
Ciro Santilli 已提交
1372

1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384
  describe '#sanitize_attrs' do
    let(:user) { build(:user, name: 'test & user', skype: 'test&user') }

    it 'encodes HTML entities in the Skype attribute' do
      expect { user.sanitize_attrs }.to change { user.skype }.to('test&amp;user')
    end

    it 'does not encode HTML entities in the name attribute' do
      expect { user.sanitize_attrs }.not_to change { user.name }
    end
  end

1385 1386
  describe '#starred?' do
    it 'determines if user starred a project' do
1387
      user = create :user
1388 1389
      project1 = create(:project, :public)
      project2 = create(:project, :public)
1390

1391 1392
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_falsey
1393 1394

      star1 = UsersStarProject.create!(project: project1, user: user)
1395

1396 1397
      expect(user.starred?(project1)).to be_truthy
      expect(user.starred?(project2)).to be_falsey
1398 1399

      star2 = UsersStarProject.create!(project: project2, user: user)
1400

1401 1402
      expect(user.starred?(project1)).to be_truthy
      expect(user.starred?(project2)).to be_truthy
1403 1404

      star1.destroy
1405

1406 1407
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_truthy
1408 1409

      star2.destroy
1410

1411 1412
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_falsey
1413 1414 1415
    end
  end

1416 1417
  describe '#toggle_star' do
    it 'toggles stars' do
C
Ciro Santilli 已提交
1418
      user = create :user
1419
      project = create(:project, :public)
C
Ciro Santilli 已提交
1420

1421
      expect(user.starred?(project)).to be_falsey
1422

C
Ciro Santilli 已提交
1423
      user.toggle_star(project)
1424

1425
      expect(user.starred?(project)).to be_truthy
1426

C
Ciro Santilli 已提交
1427
      user.toggle_star(project)
1428

1429
      expect(user.starred?(project)).to be_falsey
C
Ciro Santilli 已提交
1430 1431
    end
  end
V
Valery Sizov 已提交
1432

1433
  describe '#sort' do
V
Valery Sizov 已提交
1434
    before do
1435
      described_class.delete_all
V
Valery Sizov 已提交
1436 1437
      @user = create :user, created_at: Date.today, last_sign_in_at: Date.today, name: 'Alpha'
      @user1 = create :user, created_at: Date.today - 1, last_sign_in_at: Date.today - 1, name: 'Omega'
1438
      @user2 = create :user, created_at: Date.today - 2, last_sign_in_at: nil, name: 'Beta'
V
Valery Sizov 已提交
1439
    end
1440

1441 1442
    context 'when sort by recent_sign_in' do
      it 'sorts users by the recent sign-in time' do
1443
        expect(described_class.sort('recent_sign_in').first).to eq(@user)
1444 1445 1446
      end

      it 'pushes users who never signed in to the end' do
1447
        expect(described_class.sort('recent_sign_in').third).to eq(@user2)
1448
      end
V
Valery Sizov 已提交
1449 1450
    end

1451 1452
    context 'when sort by oldest_sign_in' do
      it 'sorts users by the oldest sign-in time' do
1453
        expect(described_class.sort('oldest_sign_in').first).to eq(@user1)
1454 1455 1456
      end

      it 'pushes users who never signed in to the end' do
1457
        expect(described_class.sort('oldest_sign_in').third).to eq(@user2)
1458
      end
V
Valery Sizov 已提交
1459 1460
    end

1461
    it 'sorts users in descending order by their creation time' do
1462
      expect(described_class.sort('created_desc').first).to eq(@user)
V
Valery Sizov 已提交
1463 1464
    end

1465
    it 'sorts users in ascending order by their creation time' do
1466
      expect(described_class.sort('created_asc').first).to eq(@user2)
V
Valery Sizov 已提交
1467 1468
    end

1469
    it 'sorts users by id in descending order when nil is passed' do
1470
      expect(described_class.sort(nil).first).to eq(@user2)
V
Valery Sizov 已提交
1471 1472
    end
  end
1473

1474
  describe "#contributed_projects" do
1475
    subject { create(:user) }
1476
    let!(:project1) { create(:project) }
B
Bob Van Landuyt 已提交
1477
    let!(:project2) { fork_project(project3) }
1478
    let!(:project3) { create(:project) }
1479
    let!(:merge_request) { create(:merge_request, source_project: project2, target_project: project3, author: subject) }
1480
    let!(:push_event) { create(:push_event, project: project1, author: subject) }
1481
    let!(:merge_event) { create(:event, :created, project: project3, target: merge_request, author: subject) }
1482 1483

    before do
1484 1485
      project1.add_master(subject)
      project2.add_master(subject)
1486 1487 1488
    end

    it "includes IDs for projects the user has pushed to" do
1489
      expect(subject.contributed_projects).to include(project1)
1490 1491 1492
    end

    it "includes IDs for projects the user has had merge requests merged into" do
1493
      expect(subject.contributed_projects).to include(project3)
1494 1495 1496
    end

    it "doesn't include IDs for unrelated projects" do
1497
      expect(subject.contributed_projects).not_to include(project2)
1498 1499
    end
  end
1500

1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517
  describe '#fork_of' do
    let(:user) { create(:user) }

    it "returns a user's fork of a project" do
      project = create(:project, :public)
      user_fork = fork_project(project, user, namespace: user.namespace)

      expect(user.fork_of(project)).to eq(user_fork)
    end

    it 'returns nil if the project does not have a fork network' do
      project = create(:project)

      expect(user.fork_of(project)).to be_nil
    end
  end

1518
  describe '#can_be_removed?' do
1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533
    subject { create(:user) }

    context 'no owned groups' do
      it { expect(subject.can_be_removed?).to be_truthy }
    end

    context 'has owned groups' do
      before do
        group = create(:group)
        group.add_owner(subject)
      end

      it { expect(subject.can_be_removed?).to be_falsey }
    end
  end
1534 1535

  describe "#recent_push" do
1536 1537 1538
    let(:user) { build(:user) }
    let(:project) { build(:project) }
    let(:event) { build(:push_event) }
1539

1540 1541 1542 1543
    it 'returns the last push event for the user' do
      expect_any_instance_of(Users::LastPushEventService)
        .to receive(:last_event_for_user)
        .and_return(event)
1544

1545
      expect(user.recent_push).to eq(event)
1546 1547
    end

1548 1549 1550 1551
    it 'returns the last push event for a project when one is given' do
      expect_any_instance_of(Users::LastPushEventService)
        .to receive(:last_event_for_project)
        .and_return(event)
1552

1553
      expect(user.recent_push(project)).to eq(event)
1554
    end
1555
  end
1556 1557 1558 1559 1560 1561 1562 1563 1564

  describe '#authorized_groups' do
    let!(:user) { create(:user) }
    let!(:private_group) { create(:group) }

    before do
      private_group.add_user(user, Gitlab::Access::MASTER)
    end

1565
    subject { user.authorized_groups }
1566

1567
    it { is_expected.to eq([private_group]) }
1568 1569
  end

1570
  describe '#authorized_projects', :delete do
1571 1572 1573
    context 'with a minimum access level' do
      it 'includes projects for which the user is an owner' do
        user = create(:user)
1574
        project = create(:project, :private, namespace: user.namespace)
1575

D
Douwe Maan 已提交
1576 1577
        expect(user.authorized_projects(Gitlab::Access::REPORTER))
          .to contain_exactly(project)
1578
      end
1579

1580 1581
      it 'includes projects for which the user is a master' do
        user = create(:user)
1582
        project = create(:project, :private)
1583

1584
        project.add_master(user)
1585

D
Douwe Maan 已提交
1586 1587
        expect(user.authorized_projects(Gitlab::Access::REPORTER))
          .to contain_exactly(project)
1588 1589
      end
    end
1590 1591 1592

    it "includes user's personal projects" do
      user    = create(:user)
1593
      project = create(:project, :private, namespace: user.namespace)
1594 1595 1596 1597 1598 1599 1600

      expect(user.authorized_projects).to include(project)
    end

    it "includes personal projects user has been given access to" do
      user1   = create(:user)
      user2   = create(:user)
1601
      project = create(:project, :private, namespace: user1.namespace)
1602

1603
      project.add_developer(user2)
1604 1605 1606 1607 1608 1609

      expect(user2.authorized_projects).to include(project)
    end

    it "includes projects of groups user has been added to" do
      group   = create(:group)
1610
      project = create(:project, group: group)
1611 1612 1613 1614 1615 1616 1617 1618 1619
      user    = create(:user)

      group.add_developer(user)

      expect(user.authorized_projects).to include(project)
    end

    it "does not include projects of groups user has been removed from" do
      group   = create(:group)
1620
      project = create(:project, group: group)
1621 1622 1623
      user    = create(:user)

      member = group.add_developer(user)
1624

1625 1626 1627
      expect(user.authorized_projects).to include(project)

      member.destroy
1628

1629 1630 1631 1632 1633
      expect(user.authorized_projects).not_to include(project)
    end

    it "includes projects shared with user's group" do
      user    = create(:user)
1634
      project = create(:project, :private)
1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645
      group   = create(:group)

      group.add_reporter(user)
      project.project_group_links.create(group: group)

      expect(user.authorized_projects).to include(project)
    end

    it "does not include destroyed projects user had access to" do
      user1   = create(:user)
      user2   = create(:user)
1646
      project = create(:project, :private, namespace: user1.namespace)
1647

1648
      project.add_developer(user2)
1649

1650 1651 1652
      expect(user2.authorized_projects).to include(project)

      project.destroy
1653

1654 1655 1656 1657 1658
      expect(user2.authorized_projects).not_to include(project)
    end

    it "does not include projects of destroyed groups user had access to" do
      group   = create(:group)
1659
      project = create(:project, namespace: group)
1660 1661 1662
      user    = create(:user)

      group.add_developer(user)
1663

1664 1665 1666
      expect(user.authorized_projects).to include(project)

      group.destroy
1667

1668 1669
      expect(user.authorized_projects).not_to include(project)
    end
1670
  end
1671

1672 1673 1674 1675
  describe '#projects_where_can_admin_issues' do
    let(:user) { create(:user) }

    it 'includes projects for which the user access level is above or equal to reporter' do
1676 1677 1678
      reporter_project  = create(:project) { |p| p.add_reporter(user) }
      developer_project = create(:project) { |p| p.add_developer(user) }
      master_project    = create(:project) { |p| p.add_master(user) }
1679

1680
      expect(user.projects_where_can_admin_issues.to_a).to match_array([master_project, developer_project, reporter_project])
1681 1682 1683 1684 1685 1686
      expect(user.can?(:admin_issue, master_project)).to eq(true)
      expect(user.can?(:admin_issue, developer_project)).to eq(true)
      expect(user.can?(:admin_issue, reporter_project)).to eq(true)
    end

    it 'does not include for which the user access level is below reporter' do
1687 1688
      project = create(:project)
      guest_project = create(:project) { |p| p.add_guest(user) }
1689 1690 1691 1692 1693 1694 1695

      expect(user.projects_where_can_admin_issues.to_a).to be_empty
      expect(user.can?(:admin_issue, guest_project)).to eq(false)
      expect(user.can?(:admin_issue, project)).to eq(false)
    end

    it 'does not include archived projects' do
1696
      project = create(:project, :archived)
1697 1698 1699 1700 1701 1702

      expect(user.projects_where_can_admin_issues.to_a).to be_empty
      expect(user.can?(:admin_issue, project)).to eq(false)
    end

    it 'does not include projects for which issues are disabled' do
1703
      project = create(:project, :issues_disabled)
1704 1705 1706 1707 1708 1709

      expect(user.projects_where_can_admin_issues.to_a).to be_empty
      expect(user.can?(:admin_issue, project)).to eq(false)
    end
  end

1710 1711 1712 1713
  describe '#ci_authorized_runners' do
    let(:user) { create(:user) }
    let(:runner) { create(:ci_runner) }

1714 1715 1716
    before do
      project.runners << runner
    end
1717 1718

    context 'without any projects' do
1719
      let(:project) { create(:project) }
1720 1721

      it 'does not load' do
1722
        expect(user.ci_authorized_runners).to be_empty
1723 1724 1725 1726 1727
      end
    end

    context 'with personal projects runners' do
      let(:namespace) { create(:namespace, owner: user) }
1728
      let(:project) { create(:project, namespace: namespace) }
1729 1730

      it 'loads' do
1731
        expect(user.ci_authorized_runners).to contain_exactly(runner)
1732 1733 1734 1735
      end
    end

    shared_examples :member do
1736
      context 'when the user is a master' do
1737
        before do
1738
          add_user(:master)
1739
        end
1740

1741 1742 1743
        it 'loads' do
          expect(user.ci_authorized_runners).to contain_exactly(runner)
        end
1744 1745
      end

1746
      context 'when the user is a developer' do
1747
        before do
1748
          add_user(:developer)
1749
        end
1750

1751 1752 1753
        it 'does not load' do
          expect(user.ci_authorized_runners).to be_empty
        end
1754 1755 1756 1757 1758
      end
    end

    context 'with groups projects runners' do
      let(:group) { create(:group) }
1759
      let(:project) { create(:project, group: group) }
1760

L
Lin Jen-Shin 已提交
1761
      def add_user(access)
1762 1763 1764 1765 1766 1767 1768
        group.add_user(user, access)
      end

      it_behaves_like :member
    end

    context 'with other projects runners' do
1769
      let(:project) { create(:project) }
1770

L
Lin Jen-Shin 已提交
1771
      def add_user(access)
1772
        project.add_role(user, access)
1773 1774 1775 1776 1777 1778
      end

      it_behaves_like :member
    end
  end

1779
  describe '#projects_with_reporter_access_limited_to' do
1780 1781
    let(:project1) { create(:project) }
    let(:project2) { create(:project) }
1782 1783 1784
    let(:user) { create(:user) }

    before do
1785 1786
      project1.add_reporter(user)
      project2.add_guest(user)
1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801
    end

    it 'returns the projects when using a single project ID' do
      projects = user.projects_with_reporter_access_limited_to(project1.id)

      expect(projects).to eq([project1])
    end

    it 'returns the projects when using an Array of project IDs' do
      projects = user.projects_with_reporter_access_limited_to([project1.id])

      expect(projects).to eq([project1])
    end

    it 'returns the projects when using an ActiveRecord relation' do
1802 1803
      projects = user
        .projects_with_reporter_access_limited_to(Project.select(:id))
1804 1805 1806 1807 1808 1809 1810 1811 1812 1813

      expect(projects).to eq([project1])
    end

    it 'does not return projects you do not have reporter access to' do
      projects = user.projects_with_reporter_access_limited_to(project2.id)

      expect(projects).to be_empty
    end
  end
1814

1815 1816
  describe '#all_expanded_groups' do
    # foo/bar would also match foo/barbaz instead of just foo/bar and foo/bar/baz
1817 1818
    let!(:user) { create(:user) }

1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834
    #                group
    #        _______ (foo) _______
    #       |                     |
    #       |                     |
    # nested_group_1        nested_group_2
    # (bar)                 (barbaz)
    #       |                     |
    #       |                     |
    # nested_group_1_1      nested_group_2_1
    # (baz)                 (baz)
    #
    let!(:group) { create :group }
    let!(:nested_group_1) { create :group, parent: group, name: 'bar' }
    let!(:nested_group_1_1) { create :group, parent: nested_group_1, name: 'baz' }
    let!(:nested_group_2) { create :group, parent: group, name: 'barbaz' }
    let!(:nested_group_2_1) { create :group, parent: nested_group_2, name: 'baz' }
1835

1836 1837 1838 1839 1840 1841
    subject { user.all_expanded_groups }

    context 'user is not a member of any group' do
      it 'returns an empty array' do
        is_expected.to eq([])
      end
1842 1843
    end

1844 1845 1846 1847 1848 1849 1850 1851
    context 'user is member of all groups' do
      before do
        group.add_owner(user)
        nested_group_1.add_owner(user)
        nested_group_1_1.add_owner(user)
        nested_group_2.add_owner(user)
        nested_group_2_1.add_owner(user)
      end
1852

1853 1854 1855 1856 1857 1858 1859 1860
      it 'returns all groups' do
        is_expected.to match_array [
          group,
          nested_group_1, nested_group_1_1,
          nested_group_2, nested_group_2_1
        ]
      end
    end
1861

1862
    context 'user is member of the top group' do
1863 1864 1865
      before do
        group.add_owner(user)
      end
1866

1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880
      if Group.supports_nested_groups?
        it 'returns all groups' do
          is_expected.to match_array [
            group,
            nested_group_1, nested_group_1_1,
            nested_group_2, nested_group_2_1
          ]
        end
      else
        it 'returns the top-level groups' do
          is_expected.to match_array [group]
        end
      end
    end
1881

1882
    context 'user is member of the first child (internal node), branch 1', :nested_groups do
1883 1884 1885
      before do
        nested_group_1.add_owner(user)
      end
1886

1887 1888 1889 1890 1891 1892 1893 1894 1895
      it 'returns the groups in the hierarchy' do
        is_expected.to match_array [
          group,
          nested_group_1, nested_group_1_1
        ]
      end
    end

    context 'user is member of the first child (internal node), branch 2', :nested_groups do
1896 1897 1898
      before do
        nested_group_2.add_owner(user)
      end
1899

1900 1901 1902 1903 1904 1905
      it 'returns the groups in the hierarchy' do
        is_expected.to match_array [
          group,
          nested_group_2, nested_group_2_1
        ]
      end
1906 1907
    end

1908
    context 'user is member of the last child (leaf node)', :nested_groups do
1909 1910 1911
      before do
        nested_group_1_1.add_owner(user)
      end
1912 1913 1914 1915 1916 1917 1918 1919

      it 'returns the groups in the hierarchy' do
        is_expected.to match_array [
          group,
          nested_group_1, nested_group_1_1
        ]
      end
    end
1920 1921
  end

1922
  describe '#refresh_authorized_projects', :clean_gitlab_redis_shared_state do
1923 1924
    let(:project1) { create(:project) }
    let(:project2) { create(:project) }
1925 1926 1927
    let(:user) { create(:user) }

    before do
1928 1929
      project1.add_reporter(user)
      project2.add_guest(user)
1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943

      user.project_authorizations.delete_all
      user.refresh_authorized_projects
    end

    it 'refreshes the list of authorized projects' do
      expect(user.project_authorizations.count).to eq(2)
    end

    it 'stores the correct access levels' do
      expect(user.project_authorizations.where(access_level: Gitlab::Access::GUEST).exists?).to eq(true)
      expect(user.project_authorizations.where(access_level: Gitlab::Access::REPORTER).exists?).to eq(true)
    end
  end
D
Douwe Maan 已提交
1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976

  describe '#access_level=' do
    let(:user) { build(:user) }

    it 'does nothing for an invalid access level' do
      user.access_level = :invalid_access_level

      expect(user.access_level).to eq(:regular)
      expect(user.admin).to be false
    end

    it "assigns the 'admin' access level" do
      user.access_level = :admin

      expect(user.access_level).to eq(:admin)
      expect(user.admin).to be true
    end

    it "doesn't clear existing access levels when an invalid access level is passed in" do
      user.access_level = :admin
      user.access_level = :invalid_access_level

      expect(user.access_level).to eq(:admin)
      expect(user.admin).to be true
    end

    it "accepts string values in addition to symbols" do
      user.access_level = 'admin'

      expect(user.access_level).to eq(:admin)
      expect(user.admin).to be true
    end
  end
1977

1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991
  describe '#full_private_access?' do
    it 'returns false for regular user' do
      user = build(:user)

      expect(user.full_private_access?).to be_falsy
    end

    it 'returns true for admin user' do
      user = build(:user, :admin)

      expect(user.full_private_access?).to be_truthy
    end
  end

1992 1993
  describe '.ghost' do
    it "creates a ghost user if one isn't already present" do
1994
      ghost = described_class.ghost
1995 1996 1997 1998 1999 2000 2001

      expect(ghost).to be_ghost
      expect(ghost).to be_persisted
    end

    it "does not create a second ghost user if one is already present" do
      expect do
2002 2003 2004 2005
        described_class.ghost
        described_class.ghost
      end.to change { described_class.count }.by(1)
      expect(described_class.ghost).to eq(described_class.ghost)
2006 2007 2008 2009 2010
    end

    context "when a regular user exists with the username 'ghost'" do
      it "creates a ghost user with a non-conflicting username" do
        create(:user, username: 'ghost')
2011
        ghost = described_class.ghost
2012 2013

        expect(ghost).to be_persisted
2014
        expect(ghost.username).to eq('ghost1')
2015 2016 2017 2018 2019 2020
      end
    end

    context "when a regular user exists with the email 'ghost@example.com'" do
      it "creates a ghost user with a non-conflicting email" do
        create(:user, email: 'ghost@example.com')
2021
        ghost = described_class.ghost
2022 2023

        expect(ghost).to be_persisted
2024
        expect(ghost.email).to eq('ghost1@example.com')
2025 2026
      end
    end
2027 2028 2029 2030 2031 2032 2033

    context 'when a domain whitelist is in place' do
      before do
        stub_application_setting(domain_whitelist: ['gitlab.com'])
      end

      it 'creates a ghost user' do
2034
        expect(described_class.ghost).to be_persisted
2035 2036
      end
    end
2037
  end
2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053

  describe '#update_two_factor_requirement' do
    let(:user) { create :user }

    context 'with 2FA requirement on groups' do
      let(:group1) { create :group, require_two_factor_authentication: true, two_factor_grace_period: 23 }
      let(:group2) { create :group, require_two_factor_authentication: true, two_factor_grace_period: 32 }

      before do
        group1.add_user(user, GroupMember::OWNER)
        group2.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'requires 2FA' do
2054
        expect(user.require_two_factor_authentication_from_group).to be true
2055 2056 2057 2058 2059 2060 2061
      end

      it 'uses the shortest grace period' do
        expect(user.two_factor_grace_period).to be 23
      end
    end

2062
    context 'with 2FA requirement on nested parent group', :nested_groups do
2063 2064 2065 2066 2067 2068 2069 2070 2071 2072
      let!(:group1) { create :group, require_two_factor_authentication: true }
      let!(:group1a) { create :group, require_two_factor_authentication: false, parent: group1 }

      before do
        group1a.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'requires 2FA' do
2073
        expect(user.require_two_factor_authentication_from_group).to be true
2074 2075 2076
      end
    end

2077
    context 'with 2FA requirement on nested child group', :nested_groups do
2078 2079 2080 2081 2082 2083 2084 2085 2086 2087
      let!(:group1) { create :group, require_two_factor_authentication: false }
      let!(:group1a) { create :group, require_two_factor_authentication: true, parent: group1 }

      before do
        group1.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'requires 2FA' do
2088
        expect(user.require_two_factor_authentication_from_group).to be true
2089 2090 2091
      end
    end

2092 2093 2094 2095 2096 2097 2098 2099 2100 2101
    context 'without 2FA requirement on groups' do
      let(:group) { create :group }

      before do
        group.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'does not require 2FA' do
2102
        expect(user.require_two_factor_authentication_from_group).to be false
2103 2104 2105 2106 2107 2108 2109
      end

      it 'falls back to the default grace period' do
        expect(user.two_factor_grace_period).to be 48
      end
    end
  end
J
James Lopez 已提交
2110 2111 2112

  context '.active' do
    before do
2113
      described_class.ghost
J
James Lopez 已提交
2114 2115 2116 2117 2118
      create(:user, name: 'user', state: 'active')
      create(:user, name: 'user', state: 'blocked')
    end

    it 'only counts active and non internal users' do
2119
      expect(described_class.active.count).to eq(1)
J
James Lopez 已提交
2120 2121
    end
  end
2122 2123 2124 2125 2126 2127 2128 2129

  describe 'preferred language' do
    it 'is English by default' do
      user = create(:user)

      expect(user.preferred_language).to eq('en')
    end
  end
2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157

  context '#invalidate_issue_cache_counts' do
    let(:user) { build_stubbed(:user) }

    it 'invalidates cache for issue counter' do
      cache_mock = double

      expect(cache_mock).to receive(:delete).with(['users', user.id, 'assigned_open_issues_count'])

      allow(Rails).to receive(:cache).and_return(cache_mock)

      user.invalidate_issue_cache_counts
    end
  end

  context '#invalidate_merge_request_cache_counts' do
    let(:user) { build_stubbed(:user) }

    it 'invalidates cache for Merge Request counter' do
      cache_mock = double

      expect(cache_mock).to receive(:delete).with(['users', user.id, 'assigned_open_merge_requests_count'])

      allow(Rails).to receive(:cache).and_return(cache_mock)

      user.invalidate_merge_request_cache_counts
    end
  end
2158

2159
  describe '#allow_password_authentication_for_web?' do
2160 2161 2162
    context 'regular user' do
      let(:user) { build(:user) }

2163 2164
      it 'returns true when password authentication is enabled for the web interface' do
        expect(user.allow_password_authentication_for_web?).to be_truthy
2165 2166
      end

2167 2168
      it 'returns false when password authentication is disabled for the web interface' do
        stub_application_setting(password_authentication_enabled_for_web: false)
2169

2170
        expect(user.allow_password_authentication_for_web?).to be_falsey
2171 2172 2173 2174 2175 2176
      end
    end

    it 'returns false for ldap user' do
      user = create(:omniauth_user, provider: 'ldapmain')

2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199
      expect(user.allow_password_authentication_for_web?).to be_falsey
    end
  end

  describe '#allow_password_authentication_for_git?' do
    context 'regular user' do
      let(:user) { build(:user) }

      it 'returns true when password authentication is enabled for Git' do
        expect(user.allow_password_authentication_for_git?).to be_truthy
      end

      it 'returns false when password authentication is disabled Git' do
        stub_application_setting(password_authentication_enabled_for_git: false)

        expect(user.allow_password_authentication_for_git?).to be_falsey
      end
    end

    it 'returns false for ldap user' do
      user = create(:omniauth_user, provider: 'ldapmain')

      expect(user.allow_password_authentication_for_git?).to be_falsey
2200 2201
    end
  end
2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225

  describe '#personal_projects_count' do
    it 'returns the number of personal projects using a single query' do
      user = build(:user)
      projects = double(:projects, count: 1)

      expect(user).to receive(:personal_projects).once.and_return(projects)

      2.times do
        expect(user.personal_projects_count).to eq(1)
      end
    end
  end

  describe '#projects_limit_left' do
    it 'returns the number of projects that can be created by the user' do
      user = build(:user)

      allow(user).to receive(:projects_limit).and_return(10)
      allow(user).to receive(:personal_projects_count).and_return(5)

      expect(user.projects_limit_left).to eq(5)
    end
  end
2226 2227 2228 2229 2230 2231 2232

  describe '#ensure_namespace_correct' do
    context 'for a new user' do
      let(:user) { build(:user) }

      it 'creates the namespace' do
        expect(user.namespace).to be_nil
2233

2234
        user.save!
2235

2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255
        expect(user.namespace).not_to be_nil
      end
    end

    context 'for an existing user' do
      let(:username) { 'foo' }
      let(:user) { create(:user, username: username) }

      context 'when the user is updated' do
        context 'when the username is changed' do
          let(:new_username) { 'bar' }

          it 'changes the namespace (just to compare to when username is not changed)' do
            expect do
              user.update_attributes!(username: new_username)
            end.to change { user.namespace.updated_at }
          end

          it 'updates the namespace name' do
            user.update_attributes!(username: new_username)
2256

2257 2258 2259 2260 2261
            expect(user.namespace.name).to eq(new_username)
          end

          it 'updates the namespace path' do
            user.update_attributes!(username: new_username)
2262

2263 2264 2265 2266 2267 2268
            expect(user.namespace.path).to eq(new_username)
          end

          context 'when there is a validation error (namespace name taken) while updating namespace' do
            let!(:conflicting_namespace) { create(:group, name: new_username, path: 'quz') }

2269
            it 'causes the user save to fail' do
2270 2271 2272
              expect(user.update_attributes(username: new_username)).to be_falsey
              expect(user.namespace.errors.messages[:name].first).to eq('has already been taken')
            end
2273 2274 2275

            it 'adds the namespace errors to the user' do
              user.update_attributes(username: new_username)
2276

2277 2278
              expect(user.errors.full_messages.first).to eq('Namespace name has already been taken')
            end
2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291
          end
        end

        context 'when the username is not changed' do
          it 'does not change the namespace' do
            expect do
              user.update_attributes!(email: 'asdf@asdf.com')
            end.not_to change { user.namespace.updated_at }
          end
        end
      end
    end
  end
A
Alexis Reigel 已提交
2292

2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328
  describe '#username_changed_hook' do
    context 'for a new user' do
      let(:user) { build(:user) }

      it 'does not trigger system hook' do
        expect(user).not_to receive(:system_hook_service)

        user.save!
      end
    end

    context 'for an existing user' do
      let(:user) { create(:user, username: 'old-username') }

      context 'when the username is changed' do
        let(:new_username) { 'very-new-name' }

        it 'triggers the rename system hook' do
          system_hook_service = SystemHooksService.new
          expect(system_hook_service).to receive(:execute_hooks_for).with(user, :rename)
          expect(user).to receive(:system_hook_service).and_return(system_hook_service)

          user.update_attributes!(username: new_username)
        end
      end

      context 'when the username is not changed' do
        it 'does not trigger system hook' do
          expect(user).not_to receive(:system_hook_service)

          user.update_attributes!(email: 'asdf@asdf.com')
        end
      end
    end
  end

2329 2330 2331 2332 2333 2334
  describe '#sync_attribute?' do
    let(:user) { described_class.new }

    context 'oauth user' do
      it 'returns true if name can be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(name location))
2335

2336 2337 2338 2339 2340
        expect(user.sync_attribute?(:name)).to be_truthy
      end

      it 'returns true if email can be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(name email))
2341

2342 2343 2344 2345 2346
        expect(user.sync_attribute?(:email)).to be_truthy
      end

      it 'returns true if location can be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(location email))
2347

2348 2349 2350 2351 2352
        expect(user.sync_attribute?(:email)).to be_truthy
      end

      it 'returns false if name can not be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(location email))
2353

2354 2355 2356 2357 2358
        expect(user.sync_attribute?(:name)).to be_falsey
      end

      it 'returns false if email can not be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(location email))
2359

2360 2361 2362 2363 2364
        expect(user.sync_attribute?(:name)).to be_falsey
      end

      it 'returns false if location can not be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(location email))
2365

2366 2367 2368 2369 2370
        expect(user.sync_attribute?(:name)).to be_falsey
      end

      it 'returns true for all syncable attributes if all syncable attributes can be synced' do
        stub_omniauth_setting(sync_profile_attributes: true)
2371

2372 2373 2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386
        expect(user.sync_attribute?(:name)).to be_truthy
        expect(user.sync_attribute?(:email)).to be_truthy
        expect(user.sync_attribute?(:location)).to be_truthy
      end

      it 'returns false for all syncable attributes but email if no syncable attributes are declared' do
        expect(user.sync_attribute?(:name)).to be_falsey
        expect(user.sync_attribute?(:email)).to be_truthy
        expect(user.sync_attribute?(:location)).to be_falsey
      end
    end

    context 'ldap user' do
      it 'returns true for email if ldap user' do
        allow(user).to receive(:ldap_user?).and_return(true)
2387

2388 2389 2390 2391 2392 2393 2394 2395
        expect(user.sync_attribute?(:name)).to be_falsey
        expect(user.sync_attribute?(:email)).to be_truthy
        expect(user.sync_attribute?(:location)).to be_falsey
      end

      it 'returns true for email and location if ldap user and location declared as syncable' do
        allow(user).to receive(:ldap_user?).and_return(true)
        stub_omniauth_setting(sync_profile_attributes: %w(location))
2396

2397 2398 2399 2400 2401 2402
        expect(user.sync_attribute?(:name)).to be_falsey
        expect(user.sync_attribute?(:email)).to be_truthy
        expect(user.sync_attribute?(:location)).to be_truthy
      end
    end
  end
2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418

  describe '#confirm_deletion_with_password?' do
    where(
      password_automatically_set: [true, false],
      ldap_user: [true, false],
      password_authentication_disabled: [true, false]
    )

    with_them do
      let!(:user) { create(:user, password_automatically_set: password_automatically_set) }
      let!(:identity) { create(:identity, user: user) if ldap_user }

      # Only confirm deletion with password if all inputs are false
      let(:expected) { !(password_automatically_set || ldap_user || password_authentication_disabled) }

      before do
2419 2420
        stub_application_setting(password_authentication_enabled_for_web: !password_authentication_disabled)
        stub_application_setting(password_authentication_enabled_for_git: !password_authentication_disabled)
2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448
      end

      it 'returns false unless all inputs are true' do
        expect(user.confirm_deletion_with_password?).to eq(expected)
      end
    end
  end

  describe '#delete_async' do
    let(:user) { create(:user) }
    let(:deleted_by) { create(:user) }

    it 'blocks the user then schedules them for deletion if a hard delete is specified' do
      expect(DeleteUserWorker).to receive(:perform_async).with(deleted_by.id, user.id, hard_delete: true)

      user.delete_async(deleted_by: deleted_by, params: { hard_delete: true })

      expect(user).to be_blocked
    end

    it 'schedules user for deletion without blocking them' do
      expect(DeleteUserWorker).to receive(:perform_async).with(deleted_by.id, user.id, {})

      user.delete_async(deleted_by: deleted_by)

      expect(user).not_to be_blocked
    end
  end
2449 2450 2451 2452 2453 2454 2455 2456 2457 2458 2459 2460 2461 2462 2463 2464 2465 2466 2467 2468 2469 2470 2471 2472 2473 2474 2475 2476 2477 2478 2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489 2490 2491 2492 2493 2494 2495 2496 2497 2498 2499 2500 2501 2502 2503 2504 2505 2506 2507 2508 2509 2510 2511 2512 2513 2514 2515 2516 2517 2518 2519 2520 2521 2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537 2538 2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555 2556 2557 2558 2559 2560 2561 2562 2563 2564 2565 2566 2567 2568 2569 2570 2571 2572 2573 2574 2575 2576 2577 2578 2579 2580 2581 2582 2583 2584 2585 2586 2587 2588 2589 2590 2591 2592 2593 2594 2595 2596 2597 2598 2599 2600 2601 2602 2603 2604 2605 2606 2607

  describe '#max_member_access_for_project_ids' do
    shared_examples 'max member access for projects' do
      let(:user) { create(:user) }
      let(:group) { create(:group) }
      let(:owner_project) { create(:project, group: group) }
      let(:master_project) { create(:project) }
      let(:reporter_project) { create(:project) }
      let(:developer_project) { create(:project) }
      let(:guest_project) { create(:project) }
      let(:no_access_project) { create(:project) }

      let(:projects) do
        [owner_project, master_project, reporter_project, developer_project, guest_project, no_access_project].map(&:id)
      end

      let(:expected) do
        {
          owner_project.id => Gitlab::Access::OWNER,
          master_project.id => Gitlab::Access::MASTER,
          reporter_project.id => Gitlab::Access::REPORTER,
          developer_project.id => Gitlab::Access::DEVELOPER,
          guest_project.id => Gitlab::Access::GUEST,
          no_access_project.id => Gitlab::Access::NO_ACCESS
        }
      end

      before do
        create(:group_member, user: user, group: group)
        master_project.add_master(user)
        reporter_project.add_reporter(user)
        developer_project.add_developer(user)
        guest_project.add_guest(user)
      end

      it 'returns correct roles for different projects' do
        expect(user.max_member_access_for_project_ids(projects)).to eq(expected)
      end
    end

    context 'with RequestStore enabled', :request_store do
      include_examples 'max member access for projects'

      def access_levels(projects)
        user.max_member_access_for_project_ids(projects)
      end

      it 'does not perform extra queries when asked for projects who have already been found' do
        access_levels(projects)

        expect { access_levels(projects) }.not_to exceed_query_limit(0)

        expect(access_levels(projects)).to eq(expected)
      end

      it 'only requests the extra projects when uncached projects are passed' do
        second_master_project = create(:project)
        second_developer_project = create(:project)
        second_master_project.add_master(user)
        second_developer_project.add_developer(user)

        all_projects = projects + [second_master_project.id, second_developer_project.id]

        expected_all = expected.merge(second_master_project.id => Gitlab::Access::MASTER,
                                      second_developer_project.id => Gitlab::Access::DEVELOPER)

        access_levels(projects)

        queries = ActiveRecord::QueryRecorder.new { access_levels(all_projects) }

        expect(queries.count).to eq(1)
        expect(queries.log_message).to match(/\W(#{second_master_project.id}, #{second_developer_project.id})\W/)
        expect(access_levels(all_projects)).to eq(expected_all)
      end
    end

    context 'with RequestStore disabled' do
      include_examples 'max member access for projects'
    end
  end

  describe '#max_member_access_for_group_ids' do
    shared_examples 'max member access for groups' do
      let(:user) { create(:user) }
      let(:owner_group) { create(:group) }
      let(:master_group) { create(:group) }
      let(:reporter_group) { create(:group) }
      let(:developer_group) { create(:group) }
      let(:guest_group) { create(:group) }
      let(:no_access_group) { create(:group) }

      let(:groups) do
        [owner_group, master_group, reporter_group, developer_group, guest_group, no_access_group].map(&:id)
      end

      let(:expected) do
        {
          owner_group.id => Gitlab::Access::OWNER,
          master_group.id => Gitlab::Access::MASTER,
          reporter_group.id => Gitlab::Access::REPORTER,
          developer_group.id => Gitlab::Access::DEVELOPER,
          guest_group.id => Gitlab::Access::GUEST,
          no_access_group.id => Gitlab::Access::NO_ACCESS
        }
      end

      before do
        owner_group.add_owner(user)
        master_group.add_master(user)
        reporter_group.add_reporter(user)
        developer_group.add_developer(user)
        guest_group.add_guest(user)
      end

      it 'returns correct roles for different groups' do
        expect(user.max_member_access_for_group_ids(groups)).to eq(expected)
      end
    end

    context 'with RequestStore enabled', :request_store do
      include_examples 'max member access for groups'

      def access_levels(groups)
        user.max_member_access_for_group_ids(groups)
      end

      it 'does not perform extra queries when asked for groups who have already been found' do
        access_levels(groups)

        expect { access_levels(groups) }.not_to exceed_query_limit(0)

        expect(access_levels(groups)).to eq(expected)
      end

      it 'only requests the extra groups when uncached groups are passed' do
        second_master_group = create(:group)
        second_developer_group = create(:group)
        second_master_group.add_master(user)
        second_developer_group.add_developer(user)

        all_groups = groups + [second_master_group.id, second_developer_group.id]

        expected_all = expected.merge(second_master_group.id => Gitlab::Access::MASTER,
                                      second_developer_group.id => Gitlab::Access::DEVELOPER)

        access_levels(groups)

        queries = ActiveRecord::QueryRecorder.new { access_levels(all_groups) }

        expect(queries.count).to eq(1)
        expect(queries.log_message).to match(/\W(#{second_master_group.id}, #{second_developer_group.id})\W/)
        expect(access_levels(all_groups)).to eq(expected_all)
      end
    end

    context 'with RequestStore disabled' do
      include_examples 'max member access for groups'
    end
  end
2608 2609 2610 2611 2612 2613 2614 2615 2616 2617 2618 2619 2620 2621 2622 2623 2624 2625 2626 2627 2628 2629 2630 2631

  describe "#username_previously_taken?" do
    let(:user1) { create(:user, username: 'foo') }

    context 'when the username has been taken before' do
      before do
        user1.username = 'bar'
        user1.save!
      end

      it 'should raise an ActiveRecord::RecordInvalid exception' do
        user2 = build(:user, username: 'foo')
        expect { user2.save! }.to raise_error(ActiveRecord::RecordInvalid, /Path foo has been taken before/)
      end
    end

    context 'when the username has not been taken before' do
      it 'should be valid' do
        expect(RedirectRoute.count).to eq(0)
        user2 = build(:user, username: 'baz')
        expect(user2).to be_valid
      end
    end
  end
G
gitlabhq 已提交
2632
end