user_spec.rb 38.7 KB
Newer Older
G
gitlabhq 已提交
1 2
require 'spec_helper'

D
Douwe Maan 已提交
3
describe User, models: true do
4 5
  include Gitlab::CurrentSettings

6 7 8 9 10 11 12 13 14 15 16
  describe 'modules' do
    subject { described_class }

    it { is_expected.to include_module(Gitlab::ConfigHelper) }
    it { is_expected.to include_module(Gitlab::CurrentSettings) }
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
    it { is_expected.to include_module(TokenAuthenticatable) }
  end

  describe 'associations' do
17
    it { is_expected.to have_one(:namespace) }
18
    it { is_expected.to have_many(:snippets).dependent(:destroy) }
19 20 21
    it { is_expected.to have_many(:project_members).dependent(:destroy) }
    it { is_expected.to have_many(:groups) }
    it { is_expected.to have_many(:keys).dependent(:destroy) }
22
    it { is_expected.to have_many(:events).dependent(:destroy) }
23 24 25 26 27 28 29
    it { is_expected.to have_many(:recent_events).class_name('Event') }
    it { is_expected.to have_many(:issues).dependent(:destroy) }
    it { is_expected.to have_many(:notes).dependent(:destroy) }
    it { is_expected.to have_many(:assigned_issues).dependent(:destroy) }
    it { is_expected.to have_many(:merge_requests).dependent(:destroy) }
    it { is_expected.to have_many(:assigned_merge_requests).dependent(:destroy) }
    it { is_expected.to have_many(:identities).dependent(:destroy) }
R
Rémy Coutable 已提交
30
    it { is_expected.to have_one(:abuse_report) }
31
    it { is_expected.to have_many(:spam_logs).dependent(:destroy) }
32
    it { is_expected.to have_many(:todos).dependent(:destroy) }
33
    it { is_expected.to have_many(:award_emoji).dependent(:destroy) }
34 35
    it { is_expected.to have_many(:builds).dependent(:nullify) }
    it { is_expected.to have_many(:pipelines).dependent(:nullify) }
36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55

    describe '#group_members' do
      it 'does not include group memberships for which user is a requester' do
        user = create(:user)
        group = create(:group, :public)
        group.request_access(user)

        expect(user.group_members).to be_empty
      end
    end

    describe '#project_members' do
      it 'does not include project memberships for which user is a requester' do
        user = create(:user)
        project = create(:project, :public)
        project.request_access(user)

        expect(user.project_members).to be_empty
      end
    end
56 57 58
  end

  describe 'validations' do
R
Robert Speicher 已提交
59 60 61 62 63 64 65 66 67 68 69 70 71
    describe 'username' do
      it 'validates presence' do
        expect(subject).to validate_presence_of(:username)
      end

      it 'rejects blacklisted names' do
        user = build(:user, username: 'dashboard')

        expect(user).not_to be_valid
        expect(user.errors.values).to eq [['dashboard is a reserved name']]
      end

      it 'validates uniqueness' do
72
        expect(subject).to validate_uniqueness_of(:username).case_insensitive
R
Robert Speicher 已提交
73 74 75
      end
    end

76 77 78 79
    it { is_expected.to validate_presence_of(:projects_limit) }
    it { is_expected.to validate_numericality_of(:projects_limit) }
    it { is_expected.to allow_value(0).for(:projects_limit) }
    it { is_expected.not_to allow_value(-1).for(:projects_limit) }
80

81
    it { is_expected.to validate_length_of(:bio).is_within(0..255) }
82

83 84 85
    it_behaves_like 'an object with email-formated attributes', :email do
      subject { build(:user) }
    end
86

87 88 89
    it_behaves_like 'an object with email-formated attributes', :public_email, :notification_email do
      subject { build(:user).tap { |user| user.emails << build(:email, email: email_value) } }
    end
90

91
    describe 'email' do
92
      context 'when no signup domains whitelisted' do
93
        before do
94
          allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return([])
95
        end
96

97 98 99 100 101 102
        it 'accepts any email' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end
      end

103
      context 'when a signup domain is whitelisted and subdomains are allowed' do
104
        before do
105
          allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['example.com', '*.example.com'])
106
        end
107

108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123
        it 'accepts info@example.com' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end

        it 'accepts info@test.example.com' do
          user = build(:user, email: "info@test.example.com")
          expect(user).to be_valid
        end

        it 'rejects example@test.com' do
          user = build(:user, email: "example@test.com")
          expect(user).to be_invalid
        end
      end

124
      context 'when a signup domain is whitelisted and subdomains are not allowed' do
125
        before do
126
          allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['example.com'])
127
        end
128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143

        it 'accepts info@example.com' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end

        it 'rejects info@test.example.com' do
          user = build(:user, email: "info@test.example.com")
          expect(user).to be_invalid
        end

        it 'rejects example@test.com' do
          user = build(:user, email: "example@test.com")
          expect(user).to be_invalid
        end
      end
144

145 146 147 148 149 150
      context 'domain blacklist' do
        before do
          allow_any_instance_of(ApplicationSetting).to receive(:domain_blacklist_enabled?).and_return(true)
          allow_any_instance_of(ApplicationSetting).to receive(:domain_blacklist).and_return(['example.com'])
        end

151
        context 'when a signup domain is blacklisted' do
152 153 154 155 156 157 158 159 160 161 162
          it 'accepts info@test.com' do
            user = build(:user, email: 'info@test.com')
            expect(user).to be_valid
          end

          it 'rejects info@example.com' do
            user = build(:user, email: 'info@example.com')
            expect(user).not_to be_valid
          end
        end

163
        context 'when a signup domain is blacklisted but a wildcard subdomain is allowed' do
164 165
          before do
            allow_any_instance_of(ApplicationSetting).to receive(:domain_blacklist).and_return(['test.example.com'])
166
            allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['*.example.com'])
167 168
          end

169
          it 'gives priority to whitelist and allow info@test.example.com' do
170 171 172 173 174 175 176
            user = build(:user, email: 'info@test.example.com')
            expect(user).to be_valid
          end
        end

        context 'with both lists containing a domain' do
          before do
177
            allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['test.com'])
178 179 180 181 182 183 184 185 186 187 188 189 190 191
          end

          it 'accepts info@test.com' do
            user = build(:user, email: 'info@test.com')
            expect(user).to be_valid
          end

          it 'rejects info@example.com' do
            user = build(:user, email: 'info@example.com')
            expect(user).not_to be_valid
          end
        end
      end

192 193 194 195 196 197
      context 'owns_notification_email' do
        it 'accepts temp_oauth_email emails' do
          user = build(:user, email: "temp-email-for-oauth@example.com")
          expect(user).to be_valid
        end
      end
198
    end
199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258
  end

  describe "scopes" do
    describe ".with_two_factor" do
      it "returns users with 2fa enabled via OTP" do
        user_with_2fa = create(:user, :two_factor_via_otp)
        user_without_2fa = create(:user)
        users_with_two_factor = User.with_two_factor.pluck(:id)

        expect(users_with_two_factor).to include(user_with_2fa.id)
        expect(users_with_two_factor).not_to include(user_without_2fa.id)
      end

      it "returns users with 2fa enabled via U2F" do
        user_with_2fa = create(:user, :two_factor_via_u2f)
        user_without_2fa = create(:user)
        users_with_two_factor = User.with_two_factor.pluck(:id)

        expect(users_with_two_factor).to include(user_with_2fa.id)
        expect(users_with_two_factor).not_to include(user_without_2fa.id)
      end

      it "returns users with 2fa enabled via OTP and U2F" do
        user_with_2fa = create(:user, :two_factor_via_otp, :two_factor_via_u2f)
        user_without_2fa = create(:user)
        users_with_two_factor = User.with_two_factor.pluck(:id)

        expect(users_with_two_factor).to eq([user_with_2fa.id])
        expect(users_with_two_factor).not_to include(user_without_2fa.id)
      end
    end

    describe ".without_two_factor" do
      it "excludes users with 2fa enabled via OTP" do
        user_with_2fa = create(:user, :two_factor_via_otp)
        user_without_2fa = create(:user)
        users_without_two_factor = User.without_two_factor.pluck(:id)

        expect(users_without_two_factor).to include(user_without_2fa.id)
        expect(users_without_two_factor).not_to include(user_with_2fa.id)
      end

      it "excludes users with 2fa enabled via U2F" do
        user_with_2fa = create(:user, :two_factor_via_u2f)
        user_without_2fa = create(:user)
        users_without_two_factor = User.without_two_factor.pluck(:id)

        expect(users_without_two_factor).to include(user_without_2fa.id)
        expect(users_without_two_factor).not_to include(user_with_2fa.id)
      end

      it "excludes users with 2fa enabled via OTP and U2F" do
        user_with_2fa = create(:user, :two_factor_via_otp, :two_factor_via_u2f)
        user_without_2fa = create(:user)
        users_without_two_factor = User.without_two_factor.pluck(:id)

        expect(users_without_two_factor).to include(user_without_2fa.id)
        expect(users_without_two_factor).not_to include(user_with_2fa.id)
      end
    end
V
Valery Sizov 已提交
259 260 261 262 263 264 265 266 267 268 269 270 271 272

    describe '.todo_authors' do
      it 'filters users' do
        create :user
        user_2 = create :user
        user_3 = create :user
        current_user = create :user
        create(:todo, user: current_user, author: user_2, state: :done)
        create(:todo, user: current_user, author: user_3, state: :pending)

        expect(User.todo_authors(current_user.id, 'pending')).to eq [user_3]
        expect(User.todo_authors(current_user.id, 'done')).to eq [user_2]
      end
    end
G
gitlabhq 已提交
273 274 275
  end

  describe "Respond to" do
276 277 278
    it { is_expected.to respond_to(:is_admin?) }
    it { is_expected.to respond_to(:name) }
    it { is_expected.to respond_to(:private_token) }
Z
Zeger-Jan van de Weg 已提交
279 280 281 282 283 284 285 286 287 288 289 290 291 292
    it { is_expected.to respond_to(:external?) }
  end

  describe 'before save hook' do
    context 'when saving an external user' do
      let(:user)          { create(:user) }
      let(:external_user) { create(:user, external: true) }

      it "sets other properties aswell" do
        expect(external_user.can_create_team).to be_falsey
        expect(external_user.can_create_group).to be_falsey
        expect(external_user.projects_limit).to be 0
      end
    end
G
gitlabhq 已提交
293 294
  end

295
  describe '#confirm' do
296 297 298
    before do
      allow_any_instance_of(ApplicationSetting).to receive(:send_user_confirmation_email).and_return(true)
    end
299

300 301 302 303 304 305 306
    let(:user) { create(:user, confirmed_at: nil, unconfirmed_email: 'test@gitlab.com') }

    it 'returns unconfirmed' do
      expect(user.confirmed?).to be_falsey
    end

    it 'confirms a user' do
307
      user.confirm
308 309 310 311
      expect(user.confirmed?).to be_truthy
    end
  end

312 313 314 315 316 317 318 319
  describe '#to_reference' do
    let(:user) { create(:user) }

    it 'returns a String reference to the object' do
      expect(user.to_reference).to eq "@#{user.username}"
    end
  end

320
  describe '#generate_password' do
321
    it "executes callback when force_random_password specified" do
322
      user = build(:user, force_random_password: true)
323
      expect(user).to receive(:generate_password)
324 325 326
      user.save
    end

327
    it "does not generate password by default" do
328
      user = create(:user, password: 'abcdefghe')
329
      expect(user.password).to eq('abcdefghe')
330
    end
331

332
    it "generates password when forcing random password" do
333
      allow(Devise).to receive(:friendly_token).and_return('123456789')
334
      user = create(:user, password: 'abcdefg', force_random_password: true)
335
      expect(user.password).to eq('12345678')
336
    end
337 338
  end

339
  describe 'authentication token' do
340
    it "has authentication token" do
341
      user = create(:user)
342
      expect(user.authentication_token).not_to be_blank
343
    end
N
Nihad Abbasov 已提交
344
  end
345

346
  describe '#recently_sent_password_reset?' do
347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365
    it 'is false when reset_password_sent_at is nil' do
      user = build_stubbed(:user, reset_password_sent_at: nil)

      expect(user.recently_sent_password_reset?).to eq false
    end

    it 'is false when sent more than one minute ago' do
      user = build_stubbed(:user, reset_password_sent_at: 5.minutes.ago)

      expect(user.recently_sent_password_reset?).to eq false
    end

    it 'is true when sent less than one minute ago' do
      user = build_stubbed(:user, reset_password_sent_at: Time.now)

      expect(user.recently_sent_password_reset?).to eq true
    end
  end

R
Robert Speicher 已提交
366 367 368 369 370 371 372
  describe '#disable_two_factor!' do
    it 'clears all 2FA-related fields' do
      user = create(:user, :two_factor)

      expect(user).to be_two_factor_enabled
      expect(user.encrypted_otp_secret).not_to be_nil
      expect(user.otp_backup_codes).not_to be_nil
373
      expect(user.otp_grace_period_started_at).not_to be_nil
R
Robert Speicher 已提交
374 375 376 377 378 379 380 381

      user.disable_two_factor!

      expect(user).not_to be_two_factor_enabled
      expect(user.encrypted_otp_secret).to be_nil
      expect(user.encrypted_otp_secret_iv).to be_nil
      expect(user.encrypted_otp_secret_salt).to be_nil
      expect(user.otp_backup_codes).to be_nil
382
      expect(user.otp_grace_period_started_at).to be_nil
R
Robert Speicher 已提交
383 384 385
    end
  end

386 387 388 389
  describe 'projects' do
    before do
      @user = create :user
      @project = create :project, namespace: @user.namespace
D
Dmitriy Zaporozhets 已提交
390 391
      @project_2 = create :project, group: create(:group) # Grant MASTER access to the user
      @project_3 = create :project, group: create(:group) # Grant DEVELOPER access to the user
392

393 394
      @project_2.team << [@user, :master]
      @project_3.team << [@user, :developer]
395 396
    end

397 398 399 400 401 402 403 404 405
    it { expect(@user.authorized_projects).to include(@project) }
    it { expect(@user.authorized_projects).to include(@project_2) }
    it { expect(@user.authorized_projects).to include(@project_3) }
    it { expect(@user.owned_projects).to include(@project) }
    it { expect(@user.owned_projects).not_to include(@project_2) }
    it { expect(@user.owned_projects).not_to include(@project_3) }
    it { expect(@user.personal_projects).to include(@project) }
    it { expect(@user.personal_projects).not_to include(@project_2) }
    it { expect(@user.personal_projects).not_to include(@project_3) }
406 407 408 409 410
  end

  describe 'groups' do
    before do
      @user = create :user
411 412
      @group = create :group
      @group.add_owner(@user)
413 414
    end

415 416 417
    it { expect(@user.several_namespaces?).to be_truthy }
    it { expect(@user.authorized_groups).to eq([@group]) }
    it { expect(@user.owned_groups).to eq([@group]) }
418
    it { expect(@user.namespaces).to match_array([@user.namespace, @group]) }
419 420
  end

421 422 423 424
  describe 'group multiple owners' do
    before do
      @user = create :user
      @user2 = create :user
425 426
      @group = create :group
      @group.add_owner(@user)
427

428
      @group.add_user(@user2, GroupMember::OWNER)
429 430
    end

431
    it { expect(@user2.several_namespaces?).to be_truthy }
432 433
  end

434 435 436 437 438 439
  describe 'namespaced' do
    before do
      @user = create :user
      @project = create :project, namespace: @user.namespace
    end

440
    it { expect(@user.several_namespaces?).to be_falsey }
441
    it { expect(@user.namespaces).to eq([@user.namespace]) }
442 443 444 445 446
  end

  describe 'blocking user' do
    let(:user) { create(:user, name: 'John Smith') }

447
    it "blocks user" do
448
      user.block
449
      expect(user.blocked?).to be_truthy
450 451 452
    end
  end

453 454 455 456 457 458 459
  describe '.filter' do
    let(:user) { double }

    it 'filters by active users by default' do
      expect(User).to receive(:active).and_return([user])

      expect(User.filter(nil)).to include user
460 461
    end

462 463 464 465
    it 'filters by admins' do
      expect(User).to receive(:admins).and_return([user])

      expect(User.filter('admins')).to include user
466 467
    end

468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490
    it 'filters by blocked' do
      expect(User).to receive(:blocked).and_return([user])

      expect(User.filter('blocked')).to include user
    end

    it 'filters by two_factor_disabled' do
      expect(User).to receive(:without_two_factor).and_return([user])

      expect(User.filter('two_factor_disabled')).to include user
    end

    it 'filters by two_factor_enabled' do
      expect(User).to receive(:with_two_factor).and_return([user])

      expect(User.filter('two_factor_enabled')).to include user
    end

    it 'filters by wop' do
      expect(User).to receive(:without_projects).and_return([user])

      expect(User.filter('wop')).to include user
    end
491 492
  end

493
  describe '.not_in_project' do
494
    before do
495
      User.delete_all
496 497 498 499
      @user = create :user
      @project = create :project
    end

500
    it { expect(User.not_in_project(@project)).to include(@user, @project.owner) }
501
  end
D
Dmitriy Zaporozhets 已提交
502

503 504 505
  describe 'user creation' do
    describe 'normal user' do
      let(:user) { create(:user, name: 'John Smith') }
D
Dmitriy Zaporozhets 已提交
506

507 508 509 510 511
      it { expect(user.is_admin?).to be_falsey }
      it { expect(user.require_ssh_key?).to be_truthy }
      it { expect(user.can_create_group?).to be_truthy }
      it { expect(user.can_create_project?).to be_truthy }
      it { expect(user.first_name).to eq('John') }
512
      it { expect(user.external).to be_falsey }
513
    end
514

D
Dmitriy Zaporozhets 已提交
515
    describe 'with defaults' do
516
      let(:user) { User.new }
D
Dmitriy Zaporozhets 已提交
517

518
      it "applies defaults to user" do
519 520 521
        expect(user.projects_limit).to eq(Gitlab.config.gitlab.default_projects_limit)
        expect(user.can_create_group).to eq(Gitlab.config.gitlab.default_can_create_group)
        expect(user.theme_id).to eq(Gitlab.config.gitlab.default_theme)
Z
Zeger-Jan van de Weg 已提交
522
        expect(user.external).to be_falsey
523 524 525
      end
    end

D
Dmitriy Zaporozhets 已提交
526
    describe 'with default overrides' do
527
      let(:user) { User.new(projects_limit: 123, can_create_group: false, can_create_team: true, theme_id: 1) }
D
Dmitriy Zaporozhets 已提交
528

529
      it "applies defaults to user" do
530 531
        expect(user.projects_limit).to eq(123)
        expect(user.can_create_group).to be_falsey
532
        expect(user.theme_id).to eq(1)
533
      end
534
    end
535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554

    context 'when current_application_settings.user_default_external is true' do
      before do
        stub_application_setting(user_default_external: true)
      end

      it "creates external user by default" do
        user = build(:user)

        expect(user.external).to be_truthy
      end

      describe 'with default overrides' do
        it "creates a non-external user" do
          user = build(:user, external: false)

          expect(user.external).to be_falsey
        end
      end
    end
555
  end
556

557
  describe '.find_by_any_email' do
558 559 560
    it 'finds by primary email' do
      user = create(:user, email: 'foo@example.com')

561
      expect(User.find_by_any_email(user.email)).to eq user
562 563 564 565 566 567
    end

    it 'finds by secondary email' do
      email = create(:email, email: 'foo@example.com')
      user  = email.user

568
      expect(User.find_by_any_email(email.email)).to eq user
569 570 571
    end

    it 'returns nil when nothing found' do
572
      expect(User.find_by_any_email('')).to be_nil
573 574 575
    end
  end

576 577 578 579 580 581 582 583 584 585 586
  describe '.search' do
    let(:user) { create(:user) }

    it 'returns users with a matching name' do
      expect(described_class.search(user.name)).to eq([user])
    end

    it 'returns users with a partially matching name' do
      expect(described_class.search(user.name[0..2])).to eq([user])
    end

Y
Yorick Peterse 已提交
587
    it 'returns users with a matching name regardless of the casing' do
588 589 590 591 592 593 594 595 596 597 598
      expect(described_class.search(user.name.upcase)).to eq([user])
    end

    it 'returns users with a matching Email' do
      expect(described_class.search(user.email)).to eq([user])
    end

    it 'returns users with a partially matching Email' do
      expect(described_class.search(user.email[0..2])).to eq([user])
    end

Y
Yorick Peterse 已提交
599
    it 'returns users with a matching Email regardless of the casing' do
600 601 602 603 604 605 606 607 608 609 610
      expect(described_class.search(user.email.upcase)).to eq([user])
    end

    it 'returns users with a matching username' do
      expect(described_class.search(user.username)).to eq([user])
    end

    it 'returns users with a partially matching username' do
      expect(described_class.search(user.username[0..2])).to eq([user])
    end

Y
Yorick Peterse 已提交
611
    it 'returns users with a matching username regardless of the casing' do
612
      expect(described_class.search(user.username.upcase)).to eq([user])
M
Marin Jankovski 已提交
613
    end
614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687
  end

  describe '.search_with_secondary_emails' do
    def search_with_secondary_emails(query)
      described_class.search_with_secondary_emails(query)
    end

    let!(:user) { create(:user) }
    let!(:email) { create(:email) }

    it 'returns users with a matching name' do
      expect(search_with_secondary_emails(user.name)).to eq([user])
    end

    it 'returns users with a partially matching name' do
      expect(search_with_secondary_emails(user.name[0..2])).to eq([user])
    end

    it 'returns users with a matching name regardless of the casing' do
      expect(search_with_secondary_emails(user.name.upcase)).to eq([user])
    end

    it 'returns users with a matching email' do
      expect(search_with_secondary_emails(user.email)).to eq([user])
    end

    it 'returns users with a partially matching email' do
      expect(search_with_secondary_emails(user.email[0..2])).to eq([user])
    end

    it 'returns users with a matching email regardless of the casing' do
      expect(search_with_secondary_emails(user.email.upcase)).to eq([user])
    end

    it 'returns users with a matching username' do
      expect(search_with_secondary_emails(user.username)).to eq([user])
    end

    it 'returns users with a partially matching username' do
      expect(search_with_secondary_emails(user.username[0..2])).to eq([user])
    end

    it 'returns users with a matching username regardless of the casing' do
      expect(search_with_secondary_emails(user.username.upcase)).to eq([user])
    end

    it 'returns users with a matching whole secondary email' do
      expect(search_with_secondary_emails(email.email)).to eq([email.user])
    end

    it 'returns users with a matching part of secondary email' do
      expect(search_with_secondary_emails(email.email[1..4])).to eq([email.user])
    end

    it 'return users with a matching part of secondary email regardless of case' do
      expect(search_with_secondary_emails(email.email[1..4].upcase)).to eq([email.user])
      expect(search_with_secondary_emails(email.email[1..4].downcase)).to eq([email.user])
      expect(search_with_secondary_emails(email.email[1..4].capitalize)).to eq([email.user])
    end

    it 'returns multiple users with matching secondary emails' do
      email1 = create(:email, email: '1_testemail@example.com')
      email2 = create(:email, email: '2_testemail@example.com')
      email3 = create(:email, email: 'other@email.com')
      email3.user.update_attributes!(email: 'another@mail.com')

      expect(
        search_with_secondary_emails('testemail@example.com').map(&:id)
      ).to include(email1.user.id, email2.user.id)

      expect(
        search_with_secondary_emails('testemail@example.com').map(&:id)
      ).not_to include(email3.user.id)
    end
M
Marin Jankovski 已提交
688 689
  end

690
  describe 'by_username_or_id' do
D
Dmitriy Zaporozhets 已提交
691 692
    let(:user1) { create(:user, username: 'foo') }

693
    it "gets the correct user" do
694 695 696 697
      expect(User.by_username_or_id(user1.id)).to eq(user1)
      expect(User.by_username_or_id('foo')).to eq(user1)
      expect(User.by_username_or_id(-1)).to be_nil
      expect(User.by_username_or_id('bar')).to be_nil
698 699
    end
  end
G
GitLab 已提交
700

Y
Yorick Peterse 已提交
701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717
  describe '.find_by_ssh_key_id' do
    context 'using an existing SSH key ID' do
      let(:user) { create(:user) }
      let(:key) { create(:key, user: user) }

      it 'returns the corresponding User' do
        expect(described_class.find_by_ssh_key_id(key.id)).to eq(user)
      end
    end

    context 'using an invalid SSH key ID' do
      it 'returns nil' do
        expect(described_class.find_by_ssh_key_id(-1)).to be_nil
      end
    end
  end

718 719 720 721
  describe '.by_login' do
    let(:username) { 'John' }
    let!(:user) { create(:user, username: username) }

722
    it 'gets the correct user' do
723 724 725 726 727 728 729 730 731
      expect(User.by_login(user.email.upcase)).to eq user
      expect(User.by_login(user.email)).to eq user
      expect(User.by_login(username.downcase)).to eq user
      expect(User.by_login(username)).to eq user
      expect(User.by_login(nil)).to be_nil
      expect(User.by_login('')).to be_nil
    end
  end

R
Robert Speicher 已提交
732 733 734 735 736 737 738 739 740 741 742 743
  describe '.find_by_username!' do
    it 'raises RecordNotFound' do
      expect { described_class.find_by_username!('JohnDoe') }.
        to raise_error(ActiveRecord::RecordNotFound)
    end

    it 'is case-insensitive' do
      user = create(:user, username: 'JohnDoe')
      expect(described_class.find_by_username!('JOHNDOE')).to eq user
    end
  end

G
GitLab 已提交
744
  describe 'all_ssh_keys' do
745
    it { is_expected.to have_many(:keys).dependent(:destroy) }
G
GitLab 已提交
746

747
    it "has all ssh keys" do
G
GitLab 已提交
748 749 750
      user = create :user
      key = create :key, key: "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQD33bWLBxu48Sev9Fert1yzEO4WGcWglWF7K/AwblIUFselOt/QdOL9DSjpQGxLagO1s9wl53STIO8qGS4Ms0EJZyIXOEFMjFJ5xmjSy+S37By4sG7SsltQEHMxtbtFOaW5LV2wCrX+rUsRNqLMamZjgjcPO0/EgGCXIGMAYW4O7cwGZdXWYIhQ1Vwy+CsVMDdPkPgBXqK7nR/ey8KMs8ho5fMNgB5hBw/AL9fNGhRw3QTD6Q12Nkhl4VZES2EsZqlpNnJttnPdp847DUsT6yuLRlfiQfz5Cn9ysHFdXObMN5VYIiPFwHeYCZp1X2S4fDZooRE8uOLTfxWHPXwrhqSH", user_id: user.id

751
      expect(user.all_ssh_keys).to include(a_string_starting_with(key.key))
G
GitLab 已提交
752
    end
G
GitLab 已提交
753
  end
754

755
  describe '#avatar_type' do
D
Dmitriy Zaporozhets 已提交
756 757
    let(:user) { create(:user) }

758
    it "is true if avatar is image" do
D
Dmitriy Zaporozhets 已提交
759
      user.update_attribute(:avatar, 'uploads/avatar.png')
760
      expect(user.avatar_type).to be_truthy
D
Dmitriy Zaporozhets 已提交
761 762
    end

763
    it "is false if avatar is html page" do
D
Dmitriy Zaporozhets 已提交
764
      user.update_attribute(:avatar, 'uploads/avatar.html')
765
      expect(user.avatar_type).to eq(["only images allowed"])
D
Dmitriy Zaporozhets 已提交
766 767
    end
  end
J
Jerome Dalbert 已提交
768

769
  describe '#requires_ldap_check?' do
770 771
    let(:user) { User.new }

772 773
    it 'is false when LDAP is disabled' do
      # Create a condition which would otherwise cause 'true' to be returned
774
      allow(user).to receive(:ldap_user?).and_return(true)
775
      user.last_credential_check_at = nil
776
      expect(user.requires_ldap_check?).to be_falsey
777 778
    end

779
    context 'when LDAP is enabled' do
780 781 782
      before do
        allow(Gitlab.config.ldap).to receive(:enabled).and_return(true)
      end
783

784
      it 'is false for non-LDAP users' do
785
        allow(user).to receive(:ldap_user?).and_return(false)
786
        expect(user.requires_ldap_check?).to be_falsey
787 788
      end

789
      context 'and when the user is an LDAP user' do
790 791 792
        before do
          allow(user).to receive(:ldap_user?).and_return(true)
        end
793 794 795

        it 'is true when the user has never had an LDAP check before' do
          user.last_credential_check_at = nil
796
          expect(user.requires_ldap_check?).to be_truthy
797 798 799 800
        end

        it 'is true when the last LDAP check happened over 1 hour ago' do
          user.last_credential_check_at = 2.hours.ago
801
          expect(user.requires_ldap_check?).to be_truthy
802
        end
803 804 805 806
      end
    end
  end

807
  context 'ldap synchronized user' do
808
    describe '#ldap_user?' do
809 810 811 812
      it 'is true if provider name starts with ldap' do
        user = create(:omniauth_user, provider: 'ldapmain')
        expect(user.ldap_user?).to be_truthy
      end
813

814 815 816 817 818 819 820 821 822
      it 'is false for other providers' do
        user = create(:omniauth_user, provider: 'other-provider')
        expect(user.ldap_user?).to be_falsey
      end

      it 'is false if no extern_uid is provided' do
        user = create(:omniauth_user, extern_uid: nil)
        expect(user.ldap_user?).to be_falsey
      end
823 824
    end

825
    describe '#ldap_identity' do
826 827 828 829
      it 'returns ldap identity' do
        user = create :omniauth_user
        expect(user.ldap_identity.provider).not_to be_empty
      end
830 831
    end

832 833 834 835 836 837 838 839
    describe '#ldap_block' do
      let(:user) { create(:omniauth_user, provider: 'ldapmain', name: 'John Smith') }

      it 'blocks user flaging the action caming from ldap' do
        user.ldap_block
        expect(user.blocked?).to be_truthy
        expect(user.ldap_blocked?).to be_truthy
      end
840 841 842
    end
  end

J
Jerome Dalbert 已提交
843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881
  describe '#full_website_url' do
    let(:user) { create(:user) }

    it 'begins with http if website url omits it' do
      user.website_url = 'test.com'

      expect(user.full_website_url).to eq 'http://test.com'
    end

    it 'begins with http if website url begins with http' do
      user.website_url = 'http://test.com'

      expect(user.full_website_url).to eq 'http://test.com'
    end

    it 'begins with https if website url begins with https' do
      user.website_url = 'https://test.com'

      expect(user.full_website_url).to eq 'https://test.com'
    end
  end

  describe '#short_website_url' do
    let(:user) { create(:user) }

    it 'does not begin with http if website url omits it' do
      user.website_url = 'test.com'

      expect(user.short_website_url).to eq 'test.com'
    end

    it 'does not begin with http if website url begins with http' do
      user.website_url = 'http://test.com'

      expect(user.short_website_url).to eq 'test.com'
    end

    it 'does not begin with https if website url begins with https' do
      user.website_url = 'https://test.com'
882

J
Jerome Dalbert 已提交
883 884
      expect(user.short_website_url).to eq 'test.com'
    end
G
GitLab 已提交
885
  end
C
Ciro Santilli 已提交
886

887 888 889 890 891 892
  describe "#starred?" do
    it "determines if user starred a project" do
      user = create :user
      project1 = create :project, :public
      project2 = create :project, :public

893 894
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_falsey
895 896

      star1 = UsersStarProject.create!(project: project1, user: user)
897 898
      expect(user.starred?(project1)).to be_truthy
      expect(user.starred?(project2)).to be_falsey
899 900

      star2 = UsersStarProject.create!(project: project2, user: user)
901 902
      expect(user.starred?(project1)).to be_truthy
      expect(user.starred?(project2)).to be_truthy
903 904

      star1.destroy
905 906
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_truthy
907 908

      star2.destroy
909 910
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_falsey
911 912 913
    end
  end

C
Ciro Santilli 已提交
914 915 916 917 918
  describe "#toggle_star" do
    it "toggles stars" do
      user = create :user
      project = create :project, :public

919
      expect(user.starred?(project)).to be_falsey
C
Ciro Santilli 已提交
920
      user.toggle_star(project)
921
      expect(user.starred?(project)).to be_truthy
C
Ciro Santilli 已提交
922
      user.toggle_star(project)
923
      expect(user.starred?(project)).to be_falsey
C
Ciro Santilli 已提交
924 925
    end
  end
V
Valery Sizov 已提交
926 927 928 929 930 931 932

  describe "#sort" do
    before do
      User.delete_all
      @user = create :user, created_at: Date.today, last_sign_in_at: Date.today, name: 'Alpha'
      @user1 = create :user, created_at: Date.today - 1, last_sign_in_at: Date.today - 1, name: 'Omega'
    end
933

Y
Yorick Peterse 已提交
934
    it "sorts users by the recent sign-in time" do
935
      expect(User.sort('recent_sign_in').first).to eq(@user)
V
Valery Sizov 已提交
936 937
    end

Y
Yorick Peterse 已提交
938
    it "sorts users by the oldest sign-in time" do
939
      expect(User.sort('oldest_sign_in').first).to eq(@user1)
V
Valery Sizov 已提交
940 941
    end

Y
Yorick Peterse 已提交
942
    it "sorts users in descending order by their creation time" do
943
      expect(User.sort('created_desc').first).to eq(@user)
V
Valery Sizov 已提交
944 945
    end

Y
Yorick Peterse 已提交
946
    it "sorts users in ascending order by their creation time" do
947
      expect(User.sort('created_asc').first).to eq(@user1)
V
Valery Sizov 已提交
948 949
    end

Y
Yorick Peterse 已提交
950 951
    it "sorts users by id in descending order when nil is passed" do
      expect(User.sort(nil).first).to eq(@user1)
V
Valery Sizov 已提交
952 953
    end
  end
954

955
  describe "#contributed_projects" do
956 957 958 959 960 961 962 963 964 965 966 967 968 969
    subject { create(:user) }
    let!(:project1) { create(:project) }
    let!(:project2) { create(:project, forked_from_project: project3) }
    let!(:project3) { create(:project) }
    let!(:merge_request) { create(:merge_request, source_project: project2, target_project: project3, author: subject) }
    let!(:push_event) { create(:event, action: Event::PUSHED, project: project1, target: project1, author: subject) }
    let!(:merge_event) { create(:event, action: Event::CREATED, project: project3, target: merge_request, author: subject) }

    before do
      project1.team << [subject, :master]
      project2.team << [subject, :master]
    end

    it "includes IDs for projects the user has pushed to" do
970
      expect(subject.contributed_projects).to include(project1)
971 972 973
    end

    it "includes IDs for projects the user has had merge requests merged into" do
974
      expect(subject.contributed_projects).to include(project3)
975 976 977
    end

    it "doesn't include IDs for unrelated projects" do
978
      expect(subject.contributed_projects).not_to include(project2)
979 980
    end
  end
981

982
  describe '#can_be_removed?' do
983 984 985 986 987 988 989 990 991 992 993 994 995 996 997
    subject { create(:user) }

    context 'no owned groups' do
      it { expect(subject.can_be_removed?).to be_truthy }
    end

    context 'has owned groups' do
      before do
        group = create(:group)
        group.add_owner(subject)
      end

      it { expect(subject.can_be_removed?).to be_falsey }
    end
  end
998 999 1000 1001 1002

  describe "#recent_push" do
    subject { create(:user) }
    let!(:project1) { create(:project) }
    let!(:project2) { create(:project, forked_from_project: project1) }
1003
    let!(:push_data) do
1004
      Gitlab::DataBuilder::Push.build_sample(project2, subject)
1005
    end
1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027
    let!(:push_event) { create(:event, action: Event::PUSHED, project: project2, target: project1, author: subject, data: push_data) }

    before do
      project1.team << [subject, :master]
      project2.team << [subject, :master]
    end

    it "includes push event" do
      expect(subject.recent_push).to eq(push_event)
    end

    it "excludes push event if branch has been deleted" do
      allow_any_instance_of(Repository).to receive(:branch_names).and_return(['foo'])

      expect(subject.recent_push).to eq(nil)
    end

    it "excludes push event if MR is opened for it" do
      create(:merge_request, source_project: project2, target_project: project1, source_branch: project2.default_branch, target_branch: 'fix', author: subject)

      expect(subject.recent_push).to eq(nil)
    end
1028 1029 1030 1031 1032 1033 1034 1035 1036 1037

    it "includes push events on any of the provided projects" do
      expect(subject.recent_push(project1)).to eq(nil)
      expect(subject.recent_push(project2)).to eq(push_event)

      push_data1 = Gitlab::DataBuilder::Push.build_sample(project1, subject)
      push_event1 = create(:event, action: Event::PUSHED, project: project1, target: project1, author: subject, data: push_data1)

      expect(subject.recent_push([project1, project2])).to eq(push_event1) # Newest
    end
1038
  end
1039 1040 1041 1042 1043 1044 1045 1046 1047

  describe '#authorized_groups' do
    let!(:user) { create(:user) }
    let!(:private_group) { create(:group) }

    before do
      private_group.add_user(user, Gitlab::Access::MASTER)
    end

1048
    subject { user.authorized_groups }
1049

1050
    it { is_expected.to eq([private_group]) }
1051 1052 1053
  end

  describe '#authorized_projects' do
1054 1055 1056 1057
    context 'with a minimum access level' do
      it 'includes projects for which the user is an owner' do
        user = create(:user)
        project = create(:empty_project, :private, namespace: user.namespace)
1058

1059 1060 1061
        expect(user.authorized_projects(Gitlab::Access::REPORTER))
          .to contain_exactly(project)
      end
1062

1063 1064 1065 1066 1067
      it 'includes projects for which the user is a master' do
        user = create(:user)
        project = create(:empty_project, :private)

        project.team << [user, Gitlab::Access::MASTER]
1068

1069 1070 1071 1072
        expect(user.authorized_projects(Gitlab::Access::REPORTER))
          .to contain_exactly(project)
      end
    end
1073
  end
1074

1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113
  describe '#projects_where_can_admin_issues' do
    let(:user) { create(:user) }

    it 'includes projects for which the user access level is above or equal to reporter' do
      create(:project)
      reporter_project = create(:project)
      developer_project = create(:project)
      master_project = create(:project)

      reporter_project.team << [user, :reporter]
      developer_project.team << [user, :developer]
      master_project.team << [user, :master]

      expect(user.projects_where_can_admin_issues.to_a).to eq([master_project, developer_project, reporter_project])
      expect(user.can?(:admin_issue, master_project)).to eq(true)
      expect(user.can?(:admin_issue, developer_project)).to eq(true)
      expect(user.can?(:admin_issue, reporter_project)).to eq(true)
    end

    it 'does not include for which the user access level is below reporter' do
      project = create(:project)
      guest_project = create(:project)

      guest_project.team << [user, :guest]

      expect(user.projects_where_can_admin_issues.to_a).to be_empty
      expect(user.can?(:admin_issue, guest_project)).to eq(false)
      expect(user.can?(:admin_issue, project)).to eq(false)
    end

    it 'does not include archived projects' do
      project = create(:project)
      project.update_attributes(archived: true)

      expect(user.projects_where_can_admin_issues.to_a).to be_empty
      expect(user.can?(:admin_issue, project)).to eq(false)
    end

    it 'does not include projects for which issues are disabled' do
F
Felipe Artur 已提交
1114
      project = create(:project, issues_access_level: ProjectFeature::DISABLED)
1115 1116 1117 1118 1119 1120

      expect(user.projects_where_can_admin_issues.to_a).to be_empty
      expect(user.can?(:admin_issue, project)).to eq(false)
    end
  end

1121 1122 1123 1124
  describe '#ci_authorized_runners' do
    let(:user) { create(:user) }
    let(:runner) { create(:ci_runner) }

1125 1126 1127
    before do
      project.runners << runner
    end
1128 1129 1130 1131 1132

    context 'without any projects' do
      let(:project) { create(:project) }

      it 'does not load' do
1133
        expect(user.ci_authorized_runners).to be_empty
1134 1135 1136 1137 1138 1139 1140 1141
      end
    end

    context 'with personal projects runners' do
      let(:namespace) { create(:namespace, owner: user) }
      let(:project) { create(:project, namespace: namespace) }

      it 'loads' do
1142
        expect(user.ci_authorized_runners).to contain_exactly(runner)
1143 1144 1145 1146
      end
    end

    shared_examples :member do
1147
      context 'when the user is a master' do
1148 1149 1150
        before do
          add_user(Gitlab::Access::MASTER)
        end
1151

1152 1153 1154
        it 'loads' do
          expect(user.ci_authorized_runners).to contain_exactly(runner)
        end
1155 1156
      end

1157
      context 'when the user is a developer' do
1158 1159 1160
        before do
          add_user(Gitlab::Access::DEVELOPER)
        end
1161

1162 1163 1164
        it 'does not load' do
          expect(user.ci_authorized_runners).to be_empty
        end
1165 1166 1167 1168 1169 1170 1171
      end
    end

    context 'with groups projects runners' do
      let(:group) { create(:group) }
      let(:project) { create(:project, group: group) }

L
Lin Jen-Shin 已提交
1172
      def add_user(access)
1173 1174 1175 1176 1177 1178 1179 1180 1181
        group.add_user(user, access)
      end

      it_behaves_like :member
    end

    context 'with other projects runners' do
      let(:project) { create(:project) }

L
Lin Jen-Shin 已提交
1182
      def add_user(access)
L
Lin Jen-Shin 已提交
1183
        project.team << [user, access]
1184 1185 1186 1187 1188 1189
      end

      it_behaves_like :member
    end
  end

1190 1191
  describe '#viewable_starred_projects' do
    let(:user) { create(:user) }
S
Sean McGivern 已提交
1192 1193 1194
    let(:public_project) { create(:empty_project, :public) }
    let(:private_project) { create(:empty_project, :private) }
    let(:private_viewable_project) { create(:empty_project, :private) }
1195 1196 1197 1198

    before do
      private_viewable_project.team << [user, Gitlab::Access::MASTER]

S
Sean McGivern 已提交
1199 1200 1201
      [public_project, private_project, private_viewable_project].each do |project|
        user.toggle_star(project)
      end
1202 1203
    end

S
Sean McGivern 已提交
1204 1205
    it 'returns only starred projects the user can view' do
      expect(user.viewable_starred_projects).not_to include(private_project)
1206 1207
    end
  end
G
gitlabhq 已提交
1208
end