user_spec.rb 82.0 KB
Newer Older
G
gitlabhq 已提交
1 2
require 'spec_helper'

3
describe User do
4
  include Gitlab::CurrentSettings
B
Bob Van Landuyt 已提交
5
  include ProjectForksHelper
6

7 8 9 10 11 12 13 14 15 16
  describe 'modules' do
    subject { described_class }

    it { is_expected.to include_module(Gitlab::ConfigHelper) }
    it { is_expected.to include_module(Gitlab::CurrentSettings) }
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
    it { is_expected.to include_module(TokenAuthenticatable) }
  end

17 18 19 20
  describe 'delegations' do
    it { is_expected.to delegate_method(:path).to(:namespace).with_prefix }
  end

21
  describe 'associations' do
22
    it { is_expected.to have_one(:namespace) }
23
    it { is_expected.to have_many(:snippets).dependent(:destroy) }
24 25 26
    it { is_expected.to have_many(:project_members).dependent(:destroy) }
    it { is_expected.to have_many(:groups) }
    it { is_expected.to have_many(:keys).dependent(:destroy) }
27
    it { is_expected.to have_many(:deploy_keys).dependent(:destroy) }
28
    it { is_expected.to have_many(:events).dependent(:destroy) }
29
    it { is_expected.to have_many(:recent_events).class_name('Event') }
30
    it { is_expected.to have_many(:issues).dependent(:destroy) }
31 32 33
    it { is_expected.to have_many(:notes).dependent(:destroy) }
    it { is_expected.to have_many(:merge_requests).dependent(:destroy) }
    it { is_expected.to have_many(:identities).dependent(:destroy) }
34
    it { is_expected.to have_many(:spam_logs).dependent(:destroy) }
35
    it { is_expected.to have_many(:todos).dependent(:destroy) }
36
    it { is_expected.to have_many(:award_emoji).dependent(:destroy) }
K
Kamil Trzcinski 已提交
37
    it { is_expected.to have_many(:triggers).dependent(:destroy) }
38 39
    it { is_expected.to have_many(:builds).dependent(:nullify) }
    it { is_expected.to have_many(:pipelines).dependent(:nullify) }
K
Kamil Trzcinski 已提交
40
    it { is_expected.to have_many(:chat_names).dependent(:destroy) }
41
    it { is_expected.to have_many(:uploads).dependent(:destroy) }
42
    it { is_expected.to have_many(:reported_abuse_reports).dependent(:destroy).class_name('AbuseReport') }
43
    it { is_expected.to have_many(:custom_attributes).class_name('UserCustomAttribute') }
44

45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70
    describe "#abuse_report" do
      let(:current_user) { create(:user) }
      let(:other_user) { create(:user) }

      it { is_expected.to have_one(:abuse_report) }

      it "refers to the abuse report whose user_id is the current user" do
        abuse_report = create(:abuse_report, reporter: other_user, user: current_user)

        expect(current_user.abuse_report).to eq(abuse_report)
      end

      it "does not refer to the abuse report whose reporter_id is the current user" do
        create(:abuse_report, reporter: current_user, user: other_user)

        expect(current_user.abuse_report).to be_nil
      end

      it "does not update the user_id of an abuse report when the user is updated" do
        abuse_report = create(:abuse_report, reporter: current_user, user: other_user)

        current_user.block

        expect(abuse_report.reload.user).to eq(other_user)
      end
    end
71 72 73 74

    describe '#group_members' do
      it 'does not include group memberships for which user is a requester' do
        user = create(:user)
75
        group = create(:group, :public, :access_requestable)
76 77 78 79 80 81 82 83 84
        group.request_access(user)

        expect(user.group_members).to be_empty
      end
    end

    describe '#project_members' do
      it 'does not include project memberships for which user is a requester' do
        user = create(:user)
85
        project = create(:project, :public, :access_requestable)
86 87 88 89 90
        project.request_access(user)

        expect(user.project_members).to be_empty
      end
    end
91 92 93
  end

  describe 'validations' do
R
Robert Speicher 已提交
94 95 96 97 98 99 100 101 102 103 104 105
    describe 'username' do
      it 'validates presence' do
        expect(subject).to validate_presence_of(:username)
      end

      it 'rejects blacklisted names' do
        user = build(:user, username: 'dashboard')

        expect(user).not_to be_valid
        expect(user.errors.values).to eq [['dashboard is a reserved name']]
      end

106 107 108 109 110 111 112 113 114 115 116 117
      it 'allows child names' do
        user = build(:user, username: 'avatar')

        expect(user).to be_valid
      end

      it 'allows wildcard names' do
        user = build(:user, username: 'blob')

        expect(user).to be_valid
      end

R
Robert Speicher 已提交
118
      it 'validates uniqueness' do
119 120 121
        user = build(:user)

        expect(user).to validate_uniqueness_of(:username).case_insensitive
R
Robert Speicher 已提交
122
      end
123 124 125 126 127 128 129 130 131 132 133

      context 'when username is changed' do
        let(:user) { build_stubbed(:user, username: 'old_path', namespace: build_stubbed(:namespace)) }

        it 'validates move_dir is allowed for the namespace' do
          expect(user.namespace).to receive(:any_project_has_container_registry_tags?).and_return(true)
          user.username = 'new_path'
          expect(user).to be_invalid
          expect(user.errors.messages[:username].first).to match('cannot be changed if a personal project has container registry tags')
        end
      end
R
Robert Speicher 已提交
134 135
    end

136 137 138 139
    it { is_expected.to validate_presence_of(:projects_limit) }
    it { is_expected.to validate_numericality_of(:projects_limit) }
    it { is_expected.to allow_value(0).for(:projects_limit) }
    it { is_expected.not_to allow_value(-1).for(:projects_limit) }
140
    it { is_expected.not_to allow_value(Gitlab::Database::MAX_INT_VALUE + 1).for(:projects_limit) }
141

142
    it { is_expected.to validate_length_of(:bio).is_at_most(255) }
143

144 145 146
    it_behaves_like 'an object with email-formated attributes', :email do
      subject { build(:user) }
    end
147

148 149 150
    it_behaves_like 'an object with email-formated attributes', :public_email, :notification_email do
      subject { build(:user).tap { |user| user.emails << build(:email, email: email_value) } }
    end
151

152
    describe 'email' do
153
      context 'when no signup domains whitelisted' do
154
        before do
155
          allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return([])
156
        end
157

158 159 160 161 162 163
        it 'accepts any email' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end
      end

164
      context 'when a signup domain is whitelisted and subdomains are allowed' do
165
        before do
166
          allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['example.com', '*.example.com'])
167
        end
168

169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184
        it 'accepts info@example.com' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end

        it 'accepts info@test.example.com' do
          user = build(:user, email: "info@test.example.com")
          expect(user).to be_valid
        end

        it 'rejects example@test.com' do
          user = build(:user, email: "example@test.com")
          expect(user).to be_invalid
        end
      end

185
      context 'when a signup domain is whitelisted and subdomains are not allowed' do
186
        before do
187
          allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['example.com'])
188
        end
189 190 191 192 193 194 195 196 197 198 199 200 201 202 203

        it 'accepts info@example.com' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end

        it 'rejects info@test.example.com' do
          user = build(:user, email: "info@test.example.com")
          expect(user).to be_invalid
        end

        it 'rejects example@test.com' do
          user = build(:user, email: "example@test.com")
          expect(user).to be_invalid
        end
204 205 206 207 208

        it 'accepts example@test.com when added by another user' do
          user = build(:user, email: "example@test.com", created_by_id: 1)
          expect(user).to be_valid
        end
209
      end
210

211 212 213 214 215 216
      context 'domain blacklist' do
        before do
          allow_any_instance_of(ApplicationSetting).to receive(:domain_blacklist_enabled?).and_return(true)
          allow_any_instance_of(ApplicationSetting).to receive(:domain_blacklist).and_return(['example.com'])
        end

217
        context 'when a signup domain is blacklisted' do
218 219 220 221 222 223 224 225 226
          it 'accepts info@test.com' do
            user = build(:user, email: 'info@test.com')
            expect(user).to be_valid
          end

          it 'rejects info@example.com' do
            user = build(:user, email: 'info@example.com')
            expect(user).not_to be_valid
          end
227 228 229 230 231

          it 'accepts info@example.com when added by another user' do
            user = build(:user, email: 'info@example.com', created_by_id: 1)
            expect(user).to be_valid
          end
232 233
        end

234
        context 'when a signup domain is blacklisted but a wildcard subdomain is allowed' do
235 236
          before do
            allow_any_instance_of(ApplicationSetting).to receive(:domain_blacklist).and_return(['test.example.com'])
237
            allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['*.example.com'])
238 239
          end

240
          it 'gives priority to whitelist and allow info@test.example.com' do
241 242 243 244 245 246 247
            user = build(:user, email: 'info@test.example.com')
            expect(user).to be_valid
          end
        end

        context 'with both lists containing a domain' do
          before do
248
            allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['test.com'])
249 250 251 252 253 254 255 256 257 258 259 260 261 262
          end

          it 'accepts info@test.com' do
            user = build(:user, email: 'info@test.com')
            expect(user).to be_valid
          end

          it 'rejects info@example.com' do
            user = build(:user, email: 'info@example.com')
            expect(user).not_to be_valid
          end
        end
      end

263 264 265 266 267 268
      context 'owns_notification_email' do
        it 'accepts temp_oauth_email emails' do
          user = build(:user, email: "temp-email-for-oauth@example.com")
          expect(user).to be_valid
        end
      end
269
    end
270 271 272 273 274 275 276
  end

  describe "scopes" do
    describe ".with_two_factor" do
      it "returns users with 2fa enabled via OTP" do
        user_with_2fa = create(:user, :two_factor_via_otp)
        user_without_2fa = create(:user)
277
        users_with_two_factor = described_class.with_two_factor.pluck(:id)
278 279 280 281 282 283 284 285

        expect(users_with_two_factor).to include(user_with_2fa.id)
        expect(users_with_two_factor).not_to include(user_without_2fa.id)
      end

      it "returns users with 2fa enabled via U2F" do
        user_with_2fa = create(:user, :two_factor_via_u2f)
        user_without_2fa = create(:user)
286
        users_with_two_factor = described_class.with_two_factor.pluck(:id)
287 288 289 290 291 292 293 294

        expect(users_with_two_factor).to include(user_with_2fa.id)
        expect(users_with_two_factor).not_to include(user_without_2fa.id)
      end

      it "returns users with 2fa enabled via OTP and U2F" do
        user_with_2fa = create(:user, :two_factor_via_otp, :two_factor_via_u2f)
        user_without_2fa = create(:user)
295
        users_with_two_factor = described_class.with_two_factor.pluck(:id)
296 297 298 299 300 301 302 303 304 305

        expect(users_with_two_factor).to eq([user_with_2fa.id])
        expect(users_with_two_factor).not_to include(user_without_2fa.id)
      end
    end

    describe ".without_two_factor" do
      it "excludes users with 2fa enabled via OTP" do
        user_with_2fa = create(:user, :two_factor_via_otp)
        user_without_2fa = create(:user)
306
        users_without_two_factor = described_class.without_two_factor.pluck(:id)
307 308 309 310 311 312 313 314

        expect(users_without_two_factor).to include(user_without_2fa.id)
        expect(users_without_two_factor).not_to include(user_with_2fa.id)
      end

      it "excludes users with 2fa enabled via U2F" do
        user_with_2fa = create(:user, :two_factor_via_u2f)
        user_without_2fa = create(:user)
315
        users_without_two_factor = described_class.without_two_factor.pluck(:id)
316 317 318 319 320 321 322 323

        expect(users_without_two_factor).to include(user_without_2fa.id)
        expect(users_without_two_factor).not_to include(user_with_2fa.id)
      end

      it "excludes users with 2fa enabled via OTP and U2F" do
        user_with_2fa = create(:user, :two_factor_via_otp, :two_factor_via_u2f)
        user_without_2fa = create(:user)
324
        users_without_two_factor = described_class.without_two_factor.pluck(:id)
325 326 327 328 329

        expect(users_without_two_factor).to include(user_without_2fa.id)
        expect(users_without_two_factor).not_to include(user_with_2fa.id)
      end
    end
V
Valery Sizov 已提交
330 331 332 333 334 335 336 337 338 339

    describe '.todo_authors' do
      it 'filters users' do
        create :user
        user_2 = create :user
        user_3 = create :user
        current_user = create :user
        create(:todo, user: current_user, author: user_2, state: :done)
        create(:todo, user: current_user, author: user_3, state: :pending)

340 341
        expect(described_class.todo_authors(current_user.id, 'pending')).to eq [user_3]
        expect(described_class.todo_authors(current_user.id, 'done')).to eq [user_2]
V
Valery Sizov 已提交
342 343
      end
    end
G
gitlabhq 已提交
344 345 346
  end

  describe "Respond to" do
B
blackst0ne 已提交
347
    it { is_expected.to respond_to(:admin?) }
348
    it { is_expected.to respond_to(:name) }
Z
Zeger-Jan van de Weg 已提交
349 350 351 352 353 354 355 356 357 358 359 360 361 362
    it { is_expected.to respond_to(:external?) }
  end

  describe 'before save hook' do
    context 'when saving an external user' do
      let(:user)          { create(:user) }
      let(:external_user) { create(:user, external: true) }

      it "sets other properties aswell" do
        expect(external_user.can_create_team).to be_falsey
        expect(external_user.can_create_group).to be_falsey
        expect(external_user.projects_limit).to be 0
      end
    end
363

364 365
    describe '#check_for_verified_email' do
      let(:user)      { create(:user) }
366 367
      let(:secondary) { create(:email, :confirmed, email: 'secondary@example.com', user: user) }

368 369 370 371 372 373 374 375
      it 'allows a verfied secondary email to be used as the primary without needing reconfirmation' do
        user.update_attributes!(email: secondary.email)
        user.reload
        expect(user.email).to eq secondary.email
        expect(user.unconfirmed_email).to eq nil
        expect(user.confirmed?).to be_truthy
      end
    end
G
gitlabhq 已提交
376 377
  end

378
  describe 'after commit hook' do
379 380 381 382 383 384 385 386 387 388 389 390 391
    describe '.update_invalid_gpg_signatures' do
      let(:user) do
        create(:user, email: 'tula.torphy@abshire.ca').tap do |user|
          user.skip_reconfirmation!
        end
      end

      it 'does nothing when the name is updated' do
        expect(user).not_to receive(:update_invalid_gpg_signatures)
        user.update_attributes!(name: 'Bette')
      end

      it 'synchronizes the gpg keys when the email is updated' do
392
        expect(user).to receive(:update_invalid_gpg_signatures).at_most(:twice)
393 394 395
        user.update_attributes!(email: 'shawnee.ritchie@denesik.com')
      end
    end
396 397 398 399 400 401 402 403 404 405 406 407

    describe '#update_emails_with_primary_email' do
      before do
        @user = create(:user, email: 'primary@example.com').tap do |user|
          user.skip_reconfirmation!
        end
        @secondary = create :email, email: 'secondary@example.com', user: @user
        @user.reload
      end

      it 'gets called when email updated' do
        expect(@user).to receive(:update_emails_with_primary_email)
408

409 410 411
        @user.update_attributes!(email: 'new_primary@example.com')
      end

412
      it 'adds old primary to secondary emails when secondary is a new email ' do
413 414
        @user.update_attributes!(email: 'new_primary@example.com')
        @user.reload
415

416 417
        expect(@user.emails.count).to eq 2
        expect(@user.emails.pluck(:email)).to match_array([@secondary.email, 'primary@example.com'])
418 419 420 421 422
      end

      it 'adds old primary to secondary emails if secondary is becoming a primary' do
        @user.update_attributes!(email: @secondary.email)
        @user.reload
423

424 425 426 427 428 429 430
        expect(@user.emails.count).to eq 1
        expect(@user.emails.first.email).to eq 'primary@example.com'
      end

      it 'transfers old confirmation values into new secondary' do
        @user.update_attributes!(email: @secondary.email)
        @user.reload
431

432 433 434 435
        expect(@user.emails.count).to eq 1
        expect(@user.emails.first.confirmed_at).not_to eq nil
      end
    end
436 437
  end

438
  describe '#update_tracked_fields!', :clean_gitlab_redis_shared_state do
439 440 441 442 443 444 445 446 447 448 449 450 451 452
    let(:request) { OpenStruct.new(remote_ip: "127.0.0.1") }
    let(:user) { create(:user) }

    it 'writes trackable attributes' do
      expect do
        user.update_tracked_fields!(request)
      end.to change { user.reload.current_sign_in_at }
    end

    it 'does not write trackable attributes when called a second time within the hour' do
      user.update_tracked_fields!(request)

      expect do
        user.update_tracked_fields!(request)
453 454 455 456 457 458 459 460 461 462 463
      end.not_to change { user.reload.current_sign_in_at }
    end

    it 'writes trackable attributes for a different user' do
      user2 = create(:user)

      user.update_tracked_fields!(request)

      expect do
        user2.update_tracked_fields!(request)
      end.to change { user2.reload.current_sign_in_at }
464 465 466
    end
  end

467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494
  shared_context 'user keys' do
    let(:user) { create(:user) }
    let!(:key) { create(:key, user: user) }
    let!(:deploy_key) { create(:deploy_key, user: user) }
  end

  describe '#keys' do
    include_context 'user keys'

    context 'with key and deploy key stored' do
      it 'returns stored key, but not deploy_key' do
        expect(user.keys).to include key
        expect(user.keys).not_to include deploy_key
      end
    end
  end

  describe '#deploy_keys' do
    include_context 'user keys'

    context 'with key and deploy key stored' do
      it 'returns stored deploy key, but not normal key' do
        expect(user.deploy_keys).to include deploy_key
        expect(user.deploy_keys).not_to include key
      end
    end
  end

495
  describe '#confirm' do
496 497 498
    before do
      allow_any_instance_of(ApplicationSetting).to receive(:send_user_confirmation_email).and_return(true)
    end
499

500 501 502 503 504 505 506
    let(:user) { create(:user, confirmed_at: nil, unconfirmed_email: 'test@gitlab.com') }

    it 'returns unconfirmed' do
      expect(user.confirmed?).to be_falsey
    end

    it 'confirms a user' do
507
      user.confirm
508 509 510 511
      expect(user.confirmed?).to be_truthy
    end
  end

512 513 514 515 516 517 518 519
  describe '#to_reference' do
    let(:user) { create(:user) }

    it 'returns a String reference to the object' do
      expect(user.to_reference).to eq "@#{user.username}"
    end
  end

520
  describe '#generate_password' do
521
    it "does not generate password by default" do
522
      user = create(:user, password: 'abcdefghe')
523

524
      expect(user.password).to eq('abcdefghe')
525
    end
526 527
  end

528 529 530
  describe 'ensure incoming email token' do
    it 'has incoming email token' do
      user = create(:user)
531

532 533 534 535
      expect(user.incoming_email_token).not_to be_blank
    end
  end

536 537 538 539 540 541 542 543 544 545 546
  describe '#ensure_user_rights_and_limits' do
    describe 'with external user' do
      let(:user) { create(:user, external: true) }

      it 'receives callback when external changes' do
        expect(user).to receive(:ensure_user_rights_and_limits)

        user.update_attributes(external: false)
      end

      it 'ensures correct rights and limits for user' do
T
Tiago Botelho 已提交
547 548
        stub_config_setting(default_can_create_group: true)

549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569
        expect { user.update_attributes(external: false) }.to change { user.can_create_group }.to(true)
          .and change { user.projects_limit }.to(current_application_settings.default_projects_limit)
      end
    end

    describe 'without external user' do
      let(:user) { create(:user, external: false) }

      it 'receives callback when external changes' do
        expect(user).to receive(:ensure_user_rights_and_limits)

        user.update_attributes(external: true)
      end

      it 'ensures correct rights and limits for user' do
        expect { user.update_attributes(external: true) }.to change { user.can_create_group }.to(false)
          .and change { user.projects_limit }.to(0)
      end
    end
  end

570
  describe 'rss token' do
A
Alexis Reigel 已提交
571 572 573
    it 'ensures an rss token on read' do
      user = create(:user, rss_token: nil)
      rss_token = user.rss_token
574

A
Alexis Reigel 已提交
575 576
      expect(rss_token).not_to be_blank
      expect(user.reload.rss_token).to eq rss_token
577 578 579
    end
  end

580
  describe '#recently_sent_password_reset?' do
581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599
    it 'is false when reset_password_sent_at is nil' do
      user = build_stubbed(:user, reset_password_sent_at: nil)

      expect(user.recently_sent_password_reset?).to eq false
    end

    it 'is false when sent more than one minute ago' do
      user = build_stubbed(:user, reset_password_sent_at: 5.minutes.ago)

      expect(user.recently_sent_password_reset?).to eq false
    end

    it 'is true when sent less than one minute ago' do
      user = build_stubbed(:user, reset_password_sent_at: Time.now)

      expect(user.recently_sent_password_reset?).to eq true
    end
  end

R
Robert Speicher 已提交
600 601 602 603 604 605 606
  describe '#disable_two_factor!' do
    it 'clears all 2FA-related fields' do
      user = create(:user, :two_factor)

      expect(user).to be_two_factor_enabled
      expect(user.encrypted_otp_secret).not_to be_nil
      expect(user.otp_backup_codes).not_to be_nil
607
      expect(user.otp_grace_period_started_at).not_to be_nil
R
Robert Speicher 已提交
608 609 610 611 612 613 614 615

      user.disable_two_factor!

      expect(user).not_to be_two_factor_enabled
      expect(user.encrypted_otp_secret).to be_nil
      expect(user.encrypted_otp_secret_iv).to be_nil
      expect(user.encrypted_otp_secret_salt).to be_nil
      expect(user.otp_backup_codes).to be_nil
616
      expect(user.otp_grace_period_started_at).to be_nil
R
Robert Speicher 已提交
617 618 619
    end
  end

620 621
  describe 'projects' do
    before do
622
      @user = create(:user)
623

624 625
      @project = create(:project, namespace: @user.namespace)
      @project_2 = create(:project, group: create(:group)) do |project|
626 627
        project.add_master(@user)
      end
628
      @project_3 = create(:project, group: create(:group)) do |project|
629 630
        project.add_developer(@user)
      end
631 632
    end

633 634 635 636 637 638 639 640 641
    it { expect(@user.authorized_projects).to include(@project) }
    it { expect(@user.authorized_projects).to include(@project_2) }
    it { expect(@user.authorized_projects).to include(@project_3) }
    it { expect(@user.owned_projects).to include(@project) }
    it { expect(@user.owned_projects).not_to include(@project_2) }
    it { expect(@user.owned_projects).not_to include(@project_3) }
    it { expect(@user.personal_projects).to include(@project) }
    it { expect(@user.personal_projects).not_to include(@project_2) }
    it { expect(@user.personal_projects).not_to include(@project_3) }
642 643 644
  end

  describe 'groups' do
645 646 647
    let(:user) { create(:user) }
    let(:group) { create(:group) }

648
    before do
649
      group.add_owner(user)
650 651
    end

652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678
    it { expect(user.several_namespaces?).to be_truthy }
    it { expect(user.authorized_groups).to eq([group]) }
    it { expect(user.owned_groups).to eq([group]) }
    it { expect(user.namespaces).to contain_exactly(user.namespace, group) }
    it { expect(user.manageable_namespaces).to contain_exactly(user.namespace, group) }

    context 'with child groups', :nested_groups do
      let!(:subgroup) { create(:group, parent: group) }

      describe '#manageable_namespaces' do
        it 'includes all the namespaces the user can manage' do
          expect(user.manageable_namespaces).to contain_exactly(user.namespace, group, subgroup)
        end
      end

      describe '#manageable_groups' do
        it 'includes all the namespaces the user can manage' do
          expect(user.manageable_groups).to contain_exactly(group, subgroup)
        end

        it 'does not include duplicates if a membership was added for the subgroup' do
          subgroup.add_owner(user)

          expect(user.manageable_groups).to contain_exactly(group, subgroup)
        end
      end
    end
679 680
  end

681 682 683 684
  describe 'group multiple owners' do
    before do
      @user = create :user
      @user2 = create :user
685 686
      @group = create :group
      @group.add_owner(@user)
687

688
      @group.add_user(@user2, GroupMember::OWNER)
689 690
    end

691
    it { expect(@user2.several_namespaces?).to be_truthy }
692 693
  end

694 695 696
  describe 'namespaced' do
    before do
      @user = create :user
697
      @project = create(:project, namespace: @user.namespace)
698 699
    end

700
    it { expect(@user.several_namespaces?).to be_falsey }
701
    it { expect(@user.namespaces).to eq([@user.namespace]) }
702 703 704 705 706
  end

  describe 'blocking user' do
    let(:user) { create(:user, name: 'John Smith') }

707
    it "blocks user" do
708
      user.block
709

710
      expect(user.blocked?).to be_truthy
711 712 713
    end
  end

714 715 716 717
  describe '.filter' do
    let(:user) { double }

    it 'filters by active users by default' do
718
      expect(described_class).to receive(:active).and_return([user])
719

720
      expect(described_class.filter(nil)).to include user
721 722
    end

723
    it 'filters by admins' do
724
      expect(described_class).to receive(:admins).and_return([user])
725

726
      expect(described_class.filter('admins')).to include user
727 728
    end

729
    it 'filters by blocked' do
730
      expect(described_class).to receive(:blocked).and_return([user])
731

732
      expect(described_class.filter('blocked')).to include user
733 734 735
    end

    it 'filters by two_factor_disabled' do
736
      expect(described_class).to receive(:without_two_factor).and_return([user])
737

738
      expect(described_class.filter('two_factor_disabled')).to include user
739 740 741
    end

    it 'filters by two_factor_enabled' do
742
      expect(described_class).to receive(:with_two_factor).and_return([user])
743

744
      expect(described_class.filter('two_factor_enabled')).to include user
745 746 747
    end

    it 'filters by wop' do
748
      expect(described_class).to receive(:without_projects).and_return([user])
749

750
      expect(described_class.filter('wop')).to include user
751
    end
752 753
  end

B
Ben Bodenmiller 已提交
754
  describe '.without_projects' do
755
    let!(:project) { create(:project, :public, :access_requestable) }
B
Ben Bodenmiller 已提交
756 757 758 759 760 761 762 763 764 765 766 767 768 769 770
    let!(:user) { create(:user) }
    let!(:user_without_project) { create(:user) }
    let!(:user_without_project2) { create(:user) }

    before do
      # add user to project
      project.team << [user, :master]

      # create invite to projet
      create(:project_member, :developer, project: project, invite_token: '1234', invite_email: 'inviteduser1@example.com')

      # create request to join project
      project.request_access(user_without_project2)
    end

771 772 773
    it { expect(described_class.without_projects).not_to include user }
    it { expect(described_class.without_projects).to include user_without_project }
    it { expect(described_class.without_projects).to include user_without_project2 }
B
Ben Bodenmiller 已提交
774 775
  end

776 777 778
  describe 'user creation' do
    describe 'normal user' do
      let(:user) { create(:user, name: 'John Smith') }
D
Dmitriy Zaporozhets 已提交
779

B
blackst0ne 已提交
780
      it { expect(user.admin?).to be_falsey }
781 782 783 784
      it { expect(user.require_ssh_key?).to be_truthy }
      it { expect(user.can_create_group?).to be_truthy }
      it { expect(user.can_create_project?).to be_truthy }
      it { expect(user.first_name).to eq('John') }
785
      it { expect(user.external).to be_falsey }
786
    end
787

D
Dmitriy Zaporozhets 已提交
788
    describe 'with defaults' do
789
      let(:user) { described_class.new }
D
Dmitriy Zaporozhets 已提交
790

791
      it "applies defaults to user" do
792 793
        expect(user.projects_limit).to eq(Gitlab.config.gitlab.default_projects_limit)
        expect(user.can_create_group).to eq(Gitlab.config.gitlab.default_can_create_group)
794
        expect(user.theme_id).to eq(Gitlab.config.gitlab.default_theme)
Z
Zeger-Jan van de Weg 已提交
795
        expect(user.external).to be_falsey
796 797 798
      end
    end

D
Dmitriy Zaporozhets 已提交
799
    describe 'with default overrides' do
800
      let(:user) { described_class.new(projects_limit: 123, can_create_group: false, can_create_team: true) }
D
Dmitriy Zaporozhets 已提交
801

802
      it "applies defaults to user" do
803 804
        expect(user.projects_limit).to eq(123)
        expect(user.can_create_group).to be_falsey
805
        expect(user.theme_id).to eq(1)
806
      end
807
    end
808 809 810 811 812 813 814

    context 'when current_application_settings.user_default_external is true' do
      before do
        stub_application_setting(user_default_external: true)
      end

      it "creates external user by default" do
815
        user = create(:user)
816 817

        expect(user.external).to be_truthy
818 819
        expect(user.can_create_group).to be_falsey
        expect(user.projects_limit).to be 0
820 821 822 823
      end

      describe 'with default overrides' do
        it "creates a non-external user" do
824
          user = create(:user, external: false)
825 826 827 828 829

          expect(user.external).to be_falsey
        end
      end
    end
830

Y
Yorick Peterse 已提交
831
    describe '#require_ssh_key?', :use_clean_rails_memory_store_caching do
832 833 834
      protocol_and_expectation = {
        'http' => false,
        'ssh' => true,
835
        '' => true
836 837 838 839 840 841 842 843 844
      }

      protocol_and_expectation.each do |protocol, expected|
        it "has correct require_ssh_key?" do
          stub_application_setting(enabled_git_access_protocol: protocol)
          user = build(:user)

          expect(user.require_ssh_key?).to eq(expected)
        end
845
      end
Y
Yorick Peterse 已提交
846 847 848 849 850 851

      it 'returns false when the user has 1 or more SSH keys' do
        key = create(:personal_key)

        expect(key.user.require_ssh_key?).to eq(false)
      end
852
    end
853
  end
854

855
  describe '.find_by_any_email' do
856 857 858
    it 'finds by primary email' do
      user = create(:user, email: 'foo@example.com')

859
      expect(described_class.find_by_any_email(user.email)).to eq user
860 861 862 863 864 865
    end

    it 'finds by secondary email' do
      email = create(:email, email: 'foo@example.com')
      user  = email.user

866
      expect(described_class.find_by_any_email(email.email)).to eq user
867 868 869
    end

    it 'returns nil when nothing found' do
870
      expect(described_class.find_by_any_email('')).to be_nil
871 872 873
    end
  end

Y
Yorick Peterse 已提交
874 875 876 877 878 879 880 881 882 883 884 885 886
  describe '.by_any_email' do
    it 'returns an ActiveRecord::Relation' do
      expect(described_class.by_any_email('foo@example.com'))
        .to be_a_kind_of(ActiveRecord::Relation)
    end

    it 'returns a relation of users' do
      user = create(:user)

      expect(described_class.by_any_email(user.email)).to eq([user])
    end
  end

887
  describe '.search' do
888 889
    let!(:user) { create(:user, name: 'user', username: 'usern', email: 'email@gmail.com') }
    let!(:user2) { create(:user, name: 'user name', username: 'username', email: 'someemail@gmail.com') }
890
    let!(:user3) { create(:user, name: 'us', username: 'se', email: 'foo@gmail.com') }
891

892 893 894 895
    describe 'name matching' do
      it 'returns users with a matching name with exact match first' do
        expect(described_class.search(user.name)).to eq([user, user2])
      end
896

897
      it 'returns users with a partially matching name' do
898
        expect(described_class.search(user.name[0..2])).to eq([user, user2])
899
      end
900

901 902 903
      it 'returns users with a matching name regardless of the casing' do
        expect(described_class.search(user2.name.upcase)).to eq([user2])
      end
904 905 906 907 908 909 910 911

      it 'returns users with a exact matching name shorter than 3 chars' do
        expect(described_class.search(user3.name)).to eq([user3])
      end

      it 'returns users with a exact matching name shorter than 3 chars regardless of the casing' do
        expect(described_class.search(user3.name.upcase)).to eq([user3])
      end
912 913
    end

914 915 916 917
    describe 'email matching' do
      it 'returns users with a matching Email' do
        expect(described_class.search(user.email)).to eq([user, user2])
      end
918

919
      it 'returns users with a partially matching Email' do
920
        expect(described_class.search(user.email[0..2])).to eq([user, user2])
921
      end
922

923 924 925
      it 'returns users with a matching Email regardless of the casing' do
        expect(described_class.search(user2.email.upcase)).to eq([user2])
      end
926 927
    end

928 929 930 931
    describe 'username matching' do
      it 'returns users with a matching username' do
        expect(described_class.search(user.username)).to eq([user, user2])
      end
932

933
      it 'returns users with a partially matching username' do
934
        expect(described_class.search(user.username[0..2])).to eq([user, user2])
935
      end
936

937 938 939
      it 'returns users with a matching username regardless of the casing' do
        expect(described_class.search(user2.username.upcase)).to eq([user2])
      end
940 941 942 943 944 945 946 947

      it 'returns users with a exact matching username shorter than 3 chars' do
        expect(described_class.search(user3.username)).to eq([user3])
      end

      it 'returns users with a exact matching username shorter than 3 chars regardless of the casing' do
        expect(described_class.search(user3.username.upcase)).to eq([user3])
      end
M
Marin Jankovski 已提交
948
    end
949 950 951
  end

  describe '.search_with_secondary_emails' do
D
Douwe Maan 已提交
952
    delegate :search_with_secondary_emails, to: :described_class
953

954 955
    let!(:user) { create(:user, name: 'John Doe', username: 'john.doe', email: 'john.doe@example.com' ) }
    let!(:another_user) { create(:user, name: 'Albert Smith', username: 'albert.smith', email: 'albert.smith@example.com' ) }
956 957 958
    let!(:email) do
      create(:email, user: another_user, email: 'alias@example.com')
    end
959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023

    it 'returns users with a matching name' do
      expect(search_with_secondary_emails(user.name)).to eq([user])
    end

    it 'returns users with a partially matching name' do
      expect(search_with_secondary_emails(user.name[0..2])).to eq([user])
    end

    it 'returns users with a matching name regardless of the casing' do
      expect(search_with_secondary_emails(user.name.upcase)).to eq([user])
    end

    it 'returns users with a matching email' do
      expect(search_with_secondary_emails(user.email)).to eq([user])
    end

    it 'returns users with a partially matching email' do
      expect(search_with_secondary_emails(user.email[0..2])).to eq([user])
    end

    it 'returns users with a matching email regardless of the casing' do
      expect(search_with_secondary_emails(user.email.upcase)).to eq([user])
    end

    it 'returns users with a matching username' do
      expect(search_with_secondary_emails(user.username)).to eq([user])
    end

    it 'returns users with a partially matching username' do
      expect(search_with_secondary_emails(user.username[0..2])).to eq([user])
    end

    it 'returns users with a matching username regardless of the casing' do
      expect(search_with_secondary_emails(user.username.upcase)).to eq([user])
    end

    it 'returns users with a matching whole secondary email' do
      expect(search_with_secondary_emails(email.email)).to eq([email.user])
    end

    it 'returns users with a matching part of secondary email' do
      expect(search_with_secondary_emails(email.email[1..4])).to eq([email.user])
    end

    it 'return users with a matching part of secondary email regardless of case' do
      expect(search_with_secondary_emails(email.email[1..4].upcase)).to eq([email.user])
      expect(search_with_secondary_emails(email.email[1..4].downcase)).to eq([email.user])
      expect(search_with_secondary_emails(email.email[1..4].capitalize)).to eq([email.user])
    end

    it 'returns multiple users with matching secondary emails' do
      email1 = create(:email, email: '1_testemail@example.com')
      email2 = create(:email, email: '2_testemail@example.com')
      email3 = create(:email, email: 'other@email.com')
      email3.user.update_attributes!(email: 'another@mail.com')

      expect(
        search_with_secondary_emails('testemail@example.com').map(&:id)
      ).to include(email1.user.id, email2.user.id)

      expect(
        search_with_secondary_emails('testemail@example.com').map(&:id)
      ).not_to include(email3.user.id)
    end
M
Marin Jankovski 已提交
1024 1025
  end

Y
Yorick Peterse 已提交
1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042
  describe '.find_by_ssh_key_id' do
    context 'using an existing SSH key ID' do
      let(:user) { create(:user) }
      let(:key) { create(:key, user: user) }

      it 'returns the corresponding User' do
        expect(described_class.find_by_ssh_key_id(key.id)).to eq(user)
      end
    end

    context 'using an invalid SSH key ID' do
      it 'returns nil' do
        expect(described_class.find_by_ssh_key_id(-1)).to be_nil
      end
    end
  end

1043 1044 1045 1046
  describe '.by_login' do
    let(:username) { 'John' }
    let!(:user) { create(:user, username: username) }

1047
    it 'gets the correct user' do
1048 1049 1050 1051 1052 1053
      expect(described_class.by_login(user.email.upcase)).to eq user
      expect(described_class.by_login(user.email)).to eq user
      expect(described_class.by_login(username.downcase)).to eq user
      expect(described_class.by_login(username)).to eq user
      expect(described_class.by_login(nil)).to be_nil
      expect(described_class.by_login('')).to be_nil
1054 1055 1056
    end
  end

1057 1058 1059 1060 1061 1062 1063
  describe '.find_by_username' do
    it 'returns nil if not found' do
      expect(described_class.find_by_username('JohnDoe')).to be_nil
    end

    it 'is case-insensitive' do
      user = create(:user, username: 'JohnDoe')
1064

1065 1066 1067 1068
      expect(described_class.find_by_username('JOHNDOE')).to eq user
    end
  end

R
Robert Speicher 已提交
1069 1070
  describe '.find_by_username!' do
    it 'raises RecordNotFound' do
1071 1072
      expect { described_class.find_by_username!('JohnDoe') }
        .to raise_error(ActiveRecord::RecordNotFound)
R
Robert Speicher 已提交
1073 1074 1075 1076
    end

    it 'is case-insensitive' do
      user = create(:user, username: 'JohnDoe')
1077

R
Robert Speicher 已提交
1078 1079 1080 1081
      expect(described_class.find_by_username!('JOHNDOE')).to eq user
    end
  end

1082 1083 1084 1085 1086 1087 1088
  describe '.find_by_full_path' do
    let!(:user) { create(:user) }

    context 'with a route matching the given path' do
      let!(:route) { user.namespace.route }

      it 'returns the user' do
1089
        expect(described_class.find_by_full_path(route.path)).to eq(user)
1090 1091 1092
      end

      it 'is case-insensitive' do
1093 1094
        expect(described_class.find_by_full_path(route.path.upcase)).to eq(user)
        expect(described_class.find_by_full_path(route.path.downcase)).to eq(user)
1095 1096 1097 1098 1099 1100 1101 1102
      end
    end

    context 'with a redirect route matching the given path' do
      let!(:redirect_route) { user.namespace.redirect_routes.create(path: 'foo') }

      context 'without the follow_redirects option' do
        it 'returns nil' do
1103
          expect(described_class.find_by_full_path(redirect_route.path)).to eq(nil)
1104 1105 1106 1107 1108
        end
      end

      context 'with the follow_redirects option set to true' do
        it 'returns the user' do
1109
          expect(described_class.find_by_full_path(redirect_route.path, follow_redirects: true)).to eq(user)
1110 1111 1112
        end

        it 'is case-insensitive' do
1113 1114
          expect(described_class.find_by_full_path(redirect_route.path.upcase, follow_redirects: true)).to eq(user)
          expect(described_class.find_by_full_path(redirect_route.path.downcase, follow_redirects: true)).to eq(user)
1115 1116 1117 1118 1119 1120 1121
        end
      end
    end

    context 'without a route or a redirect route matching the given path' do
      context 'without the follow_redirects option' do
        it 'returns nil' do
1122
          expect(described_class.find_by_full_path('unknown')).to eq(nil)
1123 1124 1125 1126
        end
      end
      context 'with the follow_redirects option set to true' do
        it 'returns nil' do
1127
          expect(described_class.find_by_full_path('unknown', follow_redirects: true)).to eq(nil)
1128 1129 1130 1131 1132
        end
      end
    end

    context 'with a group route matching the given path' do
M
Michael Kozono 已提交
1133 1134
      context 'when the group namespace has an owner_id (legacy data)' do
        let!(:group) { create(:group, path: 'group_path', owner: user) }
1135

M
Michael Kozono 已提交
1136
        it 'returns nil' do
1137
          expect(described_class.find_by_full_path('group_path')).to eq(nil)
M
Michael Kozono 已提交
1138 1139 1140 1141 1142 1143 1144
        end
      end

      context 'when the group namespace does not have an owner_id' do
        let!(:group) { create(:group, path: 'group_path') }

        it 'returns nil' do
1145
          expect(described_class.find_by_full_path('group_path')).to eq(nil)
M
Michael Kozono 已提交
1146
        end
1147 1148 1149 1150
      end
    end
  end

G
GitLab 已提交
1151
  describe 'all_ssh_keys' do
1152
    it { is_expected.to have_many(:keys).dependent(:destroy) }
G
GitLab 已提交
1153

1154
    it "has all ssh keys" do
G
GitLab 已提交
1155 1156 1157
      user = create :user
      key = create :key, key: "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQD33bWLBxu48Sev9Fert1yzEO4WGcWglWF7K/AwblIUFselOt/QdOL9DSjpQGxLagO1s9wl53STIO8qGS4Ms0EJZyIXOEFMjFJ5xmjSy+S37By4sG7SsltQEHMxtbtFOaW5LV2wCrX+rUsRNqLMamZjgjcPO0/EgGCXIGMAYW4O7cwGZdXWYIhQ1Vwy+CsVMDdPkPgBXqK7nR/ey8KMs8ho5fMNgB5hBw/AL9fNGhRw3QTD6Q12Nkhl4VZES2EsZqlpNnJttnPdp847DUsT6yuLRlfiQfz5Cn9ysHFdXObMN5VYIiPFwHeYCZp1X2S4fDZooRE8uOLTfxWHPXwrhqSH", user_id: user.id

1158
      expect(user.all_ssh_keys).to include(a_string_starting_with(key.key))
G
GitLab 已提交
1159
    end
G
GitLab 已提交
1160
  end
1161

1162
  describe '#avatar_type' do
D
Dmitriy Zaporozhets 已提交
1163 1164
    let(:user) { create(:user) }

1165
    it 'is true if avatar is image' do
D
Dmitriy Zaporozhets 已提交
1166
      user.update_attribute(:avatar, 'uploads/avatar.png')
1167

1168
      expect(user.avatar_type).to be_truthy
D
Dmitriy Zaporozhets 已提交
1169 1170
    end

1171
    it 'is false if avatar is html page' do
D
Dmitriy Zaporozhets 已提交
1172
      user.update_attribute(:avatar, 'uploads/avatar.html')
1173

1174
      expect(user.avatar_type).to eq(['only images allowed'])
D
Dmitriy Zaporozhets 已提交
1175 1176
    end
  end
J
Jerome Dalbert 已提交
1177

1178 1179 1180 1181
  describe '#avatar_url' do
    let(:user) { create(:user, :with_avatar) }

    context 'when avatar file is uploaded' do
1182
      it 'shows correct avatar url' do
1183 1184
        expect(user.avatar_url).to eq(user.avatar.url)
        expect(user.avatar_url(only_path: false)).to eq([Gitlab.config.gitlab.url, user.avatar.url].join)
1185
      end
1186 1187 1188
    end
  end

1189 1190 1191 1192 1193 1194 1195
  describe '#all_emails' do
    let(:user) { create(:user) }

    it 'returns all emails' do
      email_confirmed   = create :email, user: user, confirmed_at: Time.now
      email_unconfirmed = create :email, user: user
      user.reload
1196

1197
      expect(user.all_emails).to match_array([user.email, email_unconfirmed.email, email_confirmed.email])
1198 1199 1200
    end
  end

1201
  describe '#verified_emails' do
1202 1203 1204
    let(:user) { create(:user) }

    it 'returns only confirmed emails' do
B
Brett Walker 已提交
1205 1206
      email_confirmed = create :email, user: user, confirmed_at: Time.now
      create :email, user: user
1207
      user.reload
1208

1209
      expect(user.verified_emails).to match_array([user.email, email_confirmed.email])
1210 1211 1212 1213 1214 1215 1216
    end
  end

  describe '#verified_email?' do
    let(:user) { create(:user) }

    it 'returns true when the email is verified/confirmed' do
B
Brett Walker 已提交
1217 1218
      email_confirmed = create :email, user: user, confirmed_at: Time.now
      create :email, user: user
1219 1220 1221
      user.reload

      expect(user.verified_email?(user.email)).to be_truthy
1222
      expect(user.verified_email?(email_confirmed.email.titlecase)).to be_truthy
1223 1224 1225 1226 1227 1228 1229 1230 1231 1232
    end

    it 'returns false when the email is not verified/confirmed' do
      email_unconfirmed = create :email, user: user
      user.reload

      expect(user.verified_email?(email_unconfirmed.email)).to be_falsy
    end
  end

1233
  describe '#requires_ldap_check?' do
1234
    let(:user) { described_class.new }
1235

1236 1237
    it 'is false when LDAP is disabled' do
      # Create a condition which would otherwise cause 'true' to be returned
1238
      allow(user).to receive(:ldap_user?).and_return(true)
1239
      user.last_credential_check_at = nil
1240

1241
      expect(user.requires_ldap_check?).to be_falsey
1242 1243
    end

1244
    context 'when LDAP is enabled' do
1245 1246 1247
      before do
        allow(Gitlab.config.ldap).to receive(:enabled).and_return(true)
      end
1248

1249
      it 'is false for non-LDAP users' do
1250
        allow(user).to receive(:ldap_user?).and_return(false)
1251

1252
        expect(user.requires_ldap_check?).to be_falsey
1253 1254
      end

1255
      context 'and when the user is an LDAP user' do
1256 1257 1258
        before do
          allow(user).to receive(:ldap_user?).and_return(true)
        end
1259 1260 1261

        it 'is true when the user has never had an LDAP check before' do
          user.last_credential_check_at = nil
1262

1263
          expect(user.requires_ldap_check?).to be_truthy
1264 1265 1266 1267
        end

        it 'is true when the last LDAP check happened over 1 hour ago' do
          user.last_credential_check_at = 2.hours.ago
1268

1269
          expect(user.requires_ldap_check?).to be_truthy
1270
        end
1271 1272 1273 1274
      end
    end
  end

1275
  context 'ldap synchronized user' do
1276
    describe '#ldap_user?' do
1277 1278
      it 'is true if provider name starts with ldap' do
        user = create(:omniauth_user, provider: 'ldapmain')
1279

1280 1281
        expect(user.ldap_user?).to be_truthy
      end
1282

1283 1284
      it 'is false for other providers' do
        user = create(:omniauth_user, provider: 'other-provider')
1285

1286 1287 1288 1289 1290
        expect(user.ldap_user?).to be_falsey
      end

      it 'is false if no extern_uid is provided' do
        user = create(:omniauth_user, extern_uid: nil)
1291

1292 1293
        expect(user.ldap_user?).to be_falsey
      end
1294 1295
    end

1296
    describe '#ldap_identity' do
1297 1298
      it 'returns ldap identity' do
        user = create :omniauth_user
1299

1300 1301
        expect(user.ldap_identity.provider).not_to be_empty
      end
1302 1303
    end

1304 1305 1306 1307 1308
    describe '#ldap_block' do
      let(:user) { create(:omniauth_user, provider: 'ldapmain', name: 'John Smith') }

      it 'blocks user flaging the action caming from ldap' do
        user.ldap_block
1309

1310 1311 1312
        expect(user.blocked?).to be_truthy
        expect(user.ldap_blocked?).to be_truthy
      end
1313 1314 1315
    end
  end

J
Jerome Dalbert 已提交
1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354
  describe '#full_website_url' do
    let(:user) { create(:user) }

    it 'begins with http if website url omits it' do
      user.website_url = 'test.com'

      expect(user.full_website_url).to eq 'http://test.com'
    end

    it 'begins with http if website url begins with http' do
      user.website_url = 'http://test.com'

      expect(user.full_website_url).to eq 'http://test.com'
    end

    it 'begins with https if website url begins with https' do
      user.website_url = 'https://test.com'

      expect(user.full_website_url).to eq 'https://test.com'
    end
  end

  describe '#short_website_url' do
    let(:user) { create(:user) }

    it 'does not begin with http if website url omits it' do
      user.website_url = 'test.com'

      expect(user.short_website_url).to eq 'test.com'
    end

    it 'does not begin with http if website url begins with http' do
      user.website_url = 'http://test.com'

      expect(user.short_website_url).to eq 'test.com'
    end

    it 'does not begin with https if website url begins with https' do
      user.website_url = 'https://test.com'
1355

J
Jerome Dalbert 已提交
1356 1357
      expect(user.short_website_url).to eq 'test.com'
    end
G
GitLab 已提交
1358
  end
C
Ciro Santilli 已提交
1359

1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371
  describe '#sanitize_attrs' do
    let(:user) { build(:user, name: 'test & user', skype: 'test&user') }

    it 'encodes HTML entities in the Skype attribute' do
      expect { user.sanitize_attrs }.to change { user.skype }.to('test&amp;user')
    end

    it 'does not encode HTML entities in the name attribute' do
      expect { user.sanitize_attrs }.not_to change { user.name }
    end
  end

1372 1373
  describe '#starred?' do
    it 'determines if user starred a project' do
1374
      user = create :user
1375 1376
      project1 = create(:project, :public)
      project2 = create(:project, :public)
1377

1378 1379
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_falsey
1380 1381

      star1 = UsersStarProject.create!(project: project1, user: user)
1382

1383 1384
      expect(user.starred?(project1)).to be_truthy
      expect(user.starred?(project2)).to be_falsey
1385 1386

      star2 = UsersStarProject.create!(project: project2, user: user)
1387

1388 1389
      expect(user.starred?(project1)).to be_truthy
      expect(user.starred?(project2)).to be_truthy
1390 1391

      star1.destroy
1392

1393 1394
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_truthy
1395 1396

      star2.destroy
1397

1398 1399
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_falsey
1400 1401 1402
    end
  end

1403 1404
  describe '#toggle_star' do
    it 'toggles stars' do
C
Ciro Santilli 已提交
1405
      user = create :user
1406
      project = create(:project, :public)
C
Ciro Santilli 已提交
1407

1408
      expect(user.starred?(project)).to be_falsey
1409

C
Ciro Santilli 已提交
1410
      user.toggle_star(project)
1411

1412
      expect(user.starred?(project)).to be_truthy
1413

C
Ciro Santilli 已提交
1414
      user.toggle_star(project)
1415

1416
      expect(user.starred?(project)).to be_falsey
C
Ciro Santilli 已提交
1417 1418
    end
  end
V
Valery Sizov 已提交
1419

1420
  describe '#sort' do
V
Valery Sizov 已提交
1421
    before do
1422
      described_class.delete_all
V
Valery Sizov 已提交
1423 1424
      @user = create :user, created_at: Date.today, last_sign_in_at: Date.today, name: 'Alpha'
      @user1 = create :user, created_at: Date.today - 1, last_sign_in_at: Date.today - 1, name: 'Omega'
1425
      @user2 = create :user, created_at: Date.today - 2, last_sign_in_at: nil, name: 'Beta'
V
Valery Sizov 已提交
1426
    end
1427

1428 1429
    context 'when sort by recent_sign_in' do
      it 'sorts users by the recent sign-in time' do
1430
        expect(described_class.sort('recent_sign_in').first).to eq(@user)
1431 1432 1433
      end

      it 'pushes users who never signed in to the end' do
1434
        expect(described_class.sort('recent_sign_in').third).to eq(@user2)
1435
      end
V
Valery Sizov 已提交
1436 1437
    end

1438 1439
    context 'when sort by oldest_sign_in' do
      it 'sorts users by the oldest sign-in time' do
1440
        expect(described_class.sort('oldest_sign_in').first).to eq(@user1)
1441 1442 1443
      end

      it 'pushes users who never signed in to the end' do
1444
        expect(described_class.sort('oldest_sign_in').third).to eq(@user2)
1445
      end
V
Valery Sizov 已提交
1446 1447
    end

1448
    it 'sorts users in descending order by their creation time' do
1449
      expect(described_class.sort('created_desc').first).to eq(@user)
V
Valery Sizov 已提交
1450 1451
    end

1452
    it 'sorts users in ascending order by their creation time' do
1453
      expect(described_class.sort('created_asc').first).to eq(@user2)
V
Valery Sizov 已提交
1454 1455
    end

1456
    it 'sorts users by id in descending order when nil is passed' do
1457
      expect(described_class.sort(nil).first).to eq(@user2)
V
Valery Sizov 已提交
1458 1459
    end
  end
1460

1461
  describe "#contributed_projects" do
1462
    subject { create(:user) }
1463
    let!(:project1) { create(:project) }
B
Bob Van Landuyt 已提交
1464
    let!(:project2) { fork_project(project3) }
1465
    let!(:project3) { create(:project) }
1466
    let!(:merge_request) { create(:merge_request, source_project: project2, target_project: project3, author: subject) }
1467
    let!(:push_event) { create(:push_event, project: project1, author: subject) }
1468
    let!(:merge_event) { create(:event, :created, project: project3, target: merge_request, author: subject) }
1469 1470 1471 1472 1473 1474 1475

    before do
      project1.team << [subject, :master]
      project2.team << [subject, :master]
    end

    it "includes IDs for projects the user has pushed to" do
1476
      expect(subject.contributed_projects).to include(project1)
1477 1478 1479
    end

    it "includes IDs for projects the user has had merge requests merged into" do
1480
      expect(subject.contributed_projects).to include(project3)
1481 1482 1483
    end

    it "doesn't include IDs for unrelated projects" do
1484
      expect(subject.contributed_projects).not_to include(project2)
1485 1486
    end
  end
1487

1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504
  describe '#fork_of' do
    let(:user) { create(:user) }

    it "returns a user's fork of a project" do
      project = create(:project, :public)
      user_fork = fork_project(project, user, namespace: user.namespace)

      expect(user.fork_of(project)).to eq(user_fork)
    end

    it 'returns nil if the project does not have a fork network' do
      project = create(:project)

      expect(user.fork_of(project)).to be_nil
    end
  end

1505
  describe '#can_be_removed?' do
1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520
    subject { create(:user) }

    context 'no owned groups' do
      it { expect(subject.can_be_removed?).to be_truthy }
    end

    context 'has owned groups' do
      before do
        group = create(:group)
        group.add_owner(subject)
      end

      it { expect(subject.can_be_removed?).to be_falsey }
    end
  end
1521 1522

  describe "#recent_push" do
1523 1524 1525
    let(:user) { build(:user) }
    let(:project) { build(:project) }
    let(:event) { build(:push_event) }
1526

1527 1528 1529 1530
    it 'returns the last push event for the user' do
      expect_any_instance_of(Users::LastPushEventService)
        .to receive(:last_event_for_user)
        .and_return(event)
1531

1532
      expect(user.recent_push).to eq(event)
1533 1534
    end

1535 1536 1537 1538
    it 'returns the last push event for a project when one is given' do
      expect_any_instance_of(Users::LastPushEventService)
        .to receive(:last_event_for_project)
        .and_return(event)
1539

1540
      expect(user.recent_push(project)).to eq(event)
1541
    end
1542
  end
1543 1544 1545 1546 1547 1548 1549 1550 1551

  describe '#authorized_groups' do
    let!(:user) { create(:user) }
    let!(:private_group) { create(:group) }

    before do
      private_group.add_user(user, Gitlab::Access::MASTER)
    end

1552
    subject { user.authorized_groups }
1553

1554
    it { is_expected.to eq([private_group]) }
1555 1556
  end

1557
  describe '#authorized_projects', :truncate do
1558 1559 1560
    context 'with a minimum access level' do
      it 'includes projects for which the user is an owner' do
        user = create(:user)
1561
        project = create(:project, :private, namespace: user.namespace)
1562

D
Douwe Maan 已提交
1563 1564
        expect(user.authorized_projects(Gitlab::Access::REPORTER))
          .to contain_exactly(project)
1565
      end
1566

1567 1568
      it 'includes projects for which the user is a master' do
        user = create(:user)
1569
        project = create(:project, :private)
1570 1571

        project.team << [user, Gitlab::Access::MASTER]
1572

D
Douwe Maan 已提交
1573 1574
        expect(user.authorized_projects(Gitlab::Access::REPORTER))
          .to contain_exactly(project)
1575 1576
      end
    end
1577 1578 1579

    it "includes user's personal projects" do
      user    = create(:user)
1580
      project = create(:project, :private, namespace: user.namespace)
1581 1582 1583 1584 1585 1586 1587

      expect(user.authorized_projects).to include(project)
    end

    it "includes personal projects user has been given access to" do
      user1   = create(:user)
      user2   = create(:user)
1588
      project = create(:project, :private, namespace: user1.namespace)
1589 1590 1591 1592 1593 1594 1595 1596

      project.team << [user2, Gitlab::Access::DEVELOPER]

      expect(user2.authorized_projects).to include(project)
    end

    it "includes projects of groups user has been added to" do
      group   = create(:group)
1597
      project = create(:project, group: group)
1598 1599 1600 1601 1602 1603 1604 1605 1606
      user    = create(:user)

      group.add_developer(user)

      expect(user.authorized_projects).to include(project)
    end

    it "does not include projects of groups user has been removed from" do
      group   = create(:group)
1607
      project = create(:project, group: group)
1608 1609 1610
      user    = create(:user)

      member = group.add_developer(user)
1611

1612 1613 1614
      expect(user.authorized_projects).to include(project)

      member.destroy
1615

1616 1617 1618 1619 1620
      expect(user.authorized_projects).not_to include(project)
    end

    it "includes projects shared with user's group" do
      user    = create(:user)
1621
      project = create(:project, :private)
1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632
      group   = create(:group)

      group.add_reporter(user)
      project.project_group_links.create(group: group)

      expect(user.authorized_projects).to include(project)
    end

    it "does not include destroyed projects user had access to" do
      user1   = create(:user)
      user2   = create(:user)
1633
      project = create(:project, :private, namespace: user1.namespace)
1634 1635

      project.team << [user2, Gitlab::Access::DEVELOPER]
1636

1637 1638 1639
      expect(user2.authorized_projects).to include(project)

      project.destroy
1640

1641 1642 1643 1644 1645
      expect(user2.authorized_projects).not_to include(project)
    end

    it "does not include projects of destroyed groups user had access to" do
      group   = create(:group)
1646
      project = create(:project, namespace: group)
1647 1648 1649
      user    = create(:user)

      group.add_developer(user)
1650

1651 1652 1653
      expect(user.authorized_projects).to include(project)

      group.destroy
1654

1655 1656
      expect(user.authorized_projects).not_to include(project)
    end
1657
  end
1658

1659 1660 1661 1662
  describe '#projects_where_can_admin_issues' do
    let(:user) { create(:user) }

    it 'includes projects for which the user access level is above or equal to reporter' do
1663 1664 1665
      reporter_project  = create(:project) { |p| p.add_reporter(user) }
      developer_project = create(:project) { |p| p.add_developer(user) }
      master_project    = create(:project) { |p| p.add_master(user) }
1666

1667
      expect(user.projects_where_can_admin_issues.to_a).to match_array([master_project, developer_project, reporter_project])
1668 1669 1670 1671 1672 1673
      expect(user.can?(:admin_issue, master_project)).to eq(true)
      expect(user.can?(:admin_issue, developer_project)).to eq(true)
      expect(user.can?(:admin_issue, reporter_project)).to eq(true)
    end

    it 'does not include for which the user access level is below reporter' do
1674 1675
      project = create(:project)
      guest_project = create(:project) { |p| p.add_guest(user) }
1676 1677 1678 1679 1680 1681 1682

      expect(user.projects_where_can_admin_issues.to_a).to be_empty
      expect(user.can?(:admin_issue, guest_project)).to eq(false)
      expect(user.can?(:admin_issue, project)).to eq(false)
    end

    it 'does not include archived projects' do
1683
      project = create(:project, :archived)
1684 1685 1686 1687 1688 1689

      expect(user.projects_where_can_admin_issues.to_a).to be_empty
      expect(user.can?(:admin_issue, project)).to eq(false)
    end

    it 'does not include projects for which issues are disabled' do
1690
      project = create(:project, :issues_disabled)
1691 1692 1693 1694 1695 1696

      expect(user.projects_where_can_admin_issues.to_a).to be_empty
      expect(user.can?(:admin_issue, project)).to eq(false)
    end
  end

1697 1698 1699 1700
  describe '#ci_authorized_runners' do
    let(:user) { create(:user) }
    let(:runner) { create(:ci_runner) }

1701 1702 1703
    before do
      project.runners << runner
    end
1704 1705

    context 'without any projects' do
1706
      let(:project) { create(:project) }
1707 1708

      it 'does not load' do
1709
        expect(user.ci_authorized_runners).to be_empty
1710 1711 1712 1713 1714
      end
    end

    context 'with personal projects runners' do
      let(:namespace) { create(:namespace, owner: user) }
1715
      let(:project) { create(:project, namespace: namespace) }
1716 1717

      it 'loads' do
1718
        expect(user.ci_authorized_runners).to contain_exactly(runner)
1719 1720 1721 1722
      end
    end

    shared_examples :member do
1723
      context 'when the user is a master' do
1724 1725 1726
        before do
          add_user(Gitlab::Access::MASTER)
        end
1727

1728 1729 1730
        it 'loads' do
          expect(user.ci_authorized_runners).to contain_exactly(runner)
        end
1731 1732
      end

1733
      context 'when the user is a developer' do
1734 1735 1736
        before do
          add_user(Gitlab::Access::DEVELOPER)
        end
1737

1738 1739 1740
        it 'does not load' do
          expect(user.ci_authorized_runners).to be_empty
        end
1741 1742 1743 1744 1745
      end
    end

    context 'with groups projects runners' do
      let(:group) { create(:group) }
1746
      let(:project) { create(:project, group: group) }
1747

L
Lin Jen-Shin 已提交
1748
      def add_user(access)
1749 1750 1751 1752 1753 1754 1755
        group.add_user(user, access)
      end

      it_behaves_like :member
    end

    context 'with other projects runners' do
1756
      let(:project) { create(:project) }
1757

L
Lin Jen-Shin 已提交
1758
      def add_user(access)
L
Lin Jen-Shin 已提交
1759
        project.team << [user, access]
1760 1761 1762 1763 1764 1765
      end

      it_behaves_like :member
    end
  end

1766
  describe '#projects_with_reporter_access_limited_to' do
1767 1768
    let(:project1) { create(:project) }
    let(:project2) { create(:project) }
1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788
    let(:user) { create(:user) }

    before do
      project1.team << [user, :reporter]
      project2.team << [user, :guest]
    end

    it 'returns the projects when using a single project ID' do
      projects = user.projects_with_reporter_access_limited_to(project1.id)

      expect(projects).to eq([project1])
    end

    it 'returns the projects when using an Array of project IDs' do
      projects = user.projects_with_reporter_access_limited_to([project1.id])

      expect(projects).to eq([project1])
    end

    it 'returns the projects when using an ActiveRecord relation' do
1789 1790
      projects = user
        .projects_with_reporter_access_limited_to(Project.select(:id))
1791 1792 1793 1794 1795 1796 1797 1798 1799 1800

      expect(projects).to eq([project1])
    end

    it 'does not return projects you do not have reporter access to' do
      projects = user.projects_with_reporter_access_limited_to(project2.id)

      expect(projects).to be_empty
    end
  end
1801

1802 1803
  describe '#all_expanded_groups' do
    # foo/bar would also match foo/barbaz instead of just foo/bar and foo/bar/baz
1804 1805
    let!(:user) { create(:user) }

1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821
    #                group
    #        _______ (foo) _______
    #       |                     |
    #       |                     |
    # nested_group_1        nested_group_2
    # (bar)                 (barbaz)
    #       |                     |
    #       |                     |
    # nested_group_1_1      nested_group_2_1
    # (baz)                 (baz)
    #
    let!(:group) { create :group }
    let!(:nested_group_1) { create :group, parent: group, name: 'bar' }
    let!(:nested_group_1_1) { create :group, parent: nested_group_1, name: 'baz' }
    let!(:nested_group_2) { create :group, parent: group, name: 'barbaz' }
    let!(:nested_group_2_1) { create :group, parent: nested_group_2, name: 'baz' }
1822

1823 1824 1825 1826 1827 1828
    subject { user.all_expanded_groups }

    context 'user is not a member of any group' do
      it 'returns an empty array' do
        is_expected.to eq([])
      end
1829 1830
    end

1831 1832 1833 1834 1835 1836 1837 1838
    context 'user is member of all groups' do
      before do
        group.add_owner(user)
        nested_group_1.add_owner(user)
        nested_group_1_1.add_owner(user)
        nested_group_2.add_owner(user)
        nested_group_2_1.add_owner(user)
      end
1839

1840 1841 1842 1843 1844 1845 1846 1847
      it 'returns all groups' do
        is_expected.to match_array [
          group,
          nested_group_1, nested_group_1_1,
          nested_group_2, nested_group_2_1
        ]
      end
    end
1848

1849
    context 'user is member of the top group' do
1850 1851 1852
      before do
        group.add_owner(user)
      end
1853

1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867
      if Group.supports_nested_groups?
        it 'returns all groups' do
          is_expected.to match_array [
            group,
            nested_group_1, nested_group_1_1,
            nested_group_2, nested_group_2_1
          ]
        end
      else
        it 'returns the top-level groups' do
          is_expected.to match_array [group]
        end
      end
    end
1868

1869
    context 'user is member of the first child (internal node), branch 1', :nested_groups do
1870 1871 1872
      before do
        nested_group_1.add_owner(user)
      end
1873

1874 1875 1876 1877 1878 1879 1880 1881 1882
      it 'returns the groups in the hierarchy' do
        is_expected.to match_array [
          group,
          nested_group_1, nested_group_1_1
        ]
      end
    end

    context 'user is member of the first child (internal node), branch 2', :nested_groups do
1883 1884 1885
      before do
        nested_group_2.add_owner(user)
      end
1886

1887 1888 1889 1890 1891 1892
      it 'returns the groups in the hierarchy' do
        is_expected.to match_array [
          group,
          nested_group_2, nested_group_2_1
        ]
      end
1893 1894
    end

1895
    context 'user is member of the last child (leaf node)', :nested_groups do
1896 1897 1898
      before do
        nested_group_1_1.add_owner(user)
      end
1899 1900 1901 1902 1903 1904 1905 1906

      it 'returns the groups in the hierarchy' do
        is_expected.to match_array [
          group,
          nested_group_1, nested_group_1_1
        ]
      end
    end
1907 1908
  end

1909
  describe '#refresh_authorized_projects', :clean_gitlab_redis_shared_state do
1910 1911
    let(:project1) { create(:project) }
    let(:project2) { create(:project) }
1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930
    let(:user) { create(:user) }

    before do
      project1.team << [user, :reporter]
      project2.team << [user, :guest]

      user.project_authorizations.delete_all
      user.refresh_authorized_projects
    end

    it 'refreshes the list of authorized projects' do
      expect(user.project_authorizations.count).to eq(2)
    end

    it 'stores the correct access levels' do
      expect(user.project_authorizations.where(access_level: Gitlab::Access::GUEST).exists?).to eq(true)
      expect(user.project_authorizations.where(access_level: Gitlab::Access::REPORTER).exists?).to eq(true)
    end
  end
D
Douwe Maan 已提交
1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963

  describe '#access_level=' do
    let(:user) { build(:user) }

    it 'does nothing for an invalid access level' do
      user.access_level = :invalid_access_level

      expect(user.access_level).to eq(:regular)
      expect(user.admin).to be false
    end

    it "assigns the 'admin' access level" do
      user.access_level = :admin

      expect(user.access_level).to eq(:admin)
      expect(user.admin).to be true
    end

    it "doesn't clear existing access levels when an invalid access level is passed in" do
      user.access_level = :admin
      user.access_level = :invalid_access_level

      expect(user.access_level).to eq(:admin)
      expect(user.admin).to be true
    end

    it "accepts string values in addition to symbols" do
      user.access_level = 'admin'

      expect(user.access_level).to eq(:admin)
      expect(user.admin).to be true
    end
  end
1964

1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978
  describe '#full_private_access?' do
    it 'returns false for regular user' do
      user = build(:user)

      expect(user.full_private_access?).to be_falsy
    end

    it 'returns true for admin user' do
      user = build(:user, :admin)

      expect(user.full_private_access?).to be_truthy
    end
  end

1979 1980
  describe '.ghost' do
    it "creates a ghost user if one isn't already present" do
1981
      ghost = described_class.ghost
1982 1983 1984 1985 1986 1987 1988

      expect(ghost).to be_ghost
      expect(ghost).to be_persisted
    end

    it "does not create a second ghost user if one is already present" do
      expect do
1989 1990 1991 1992
        described_class.ghost
        described_class.ghost
      end.to change { described_class.count }.by(1)
      expect(described_class.ghost).to eq(described_class.ghost)
1993 1994 1995 1996 1997
    end

    context "when a regular user exists with the username 'ghost'" do
      it "creates a ghost user with a non-conflicting username" do
        create(:user, username: 'ghost')
1998
        ghost = described_class.ghost
1999 2000

        expect(ghost).to be_persisted
2001
        expect(ghost.username).to eq('ghost1')
2002 2003 2004 2005 2006 2007
      end
    end

    context "when a regular user exists with the email 'ghost@example.com'" do
      it "creates a ghost user with a non-conflicting email" do
        create(:user, email: 'ghost@example.com')
2008
        ghost = described_class.ghost
2009 2010

        expect(ghost).to be_persisted
2011
        expect(ghost.email).to eq('ghost1@example.com')
2012 2013
      end
    end
2014 2015 2016 2017 2018 2019 2020

    context 'when a domain whitelist is in place' do
      before do
        stub_application_setting(domain_whitelist: ['gitlab.com'])
      end

      it 'creates a ghost user' do
2021
        expect(described_class.ghost).to be_persisted
2022 2023
      end
    end
2024
  end
2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040

  describe '#update_two_factor_requirement' do
    let(:user) { create :user }

    context 'with 2FA requirement on groups' do
      let(:group1) { create :group, require_two_factor_authentication: true, two_factor_grace_period: 23 }
      let(:group2) { create :group, require_two_factor_authentication: true, two_factor_grace_period: 32 }

      before do
        group1.add_user(user, GroupMember::OWNER)
        group2.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'requires 2FA' do
2041
        expect(user.require_two_factor_authentication_from_group).to be true
2042 2043 2044 2045 2046 2047 2048
      end

      it 'uses the shortest grace period' do
        expect(user.two_factor_grace_period).to be 23
      end
    end

2049
    context 'with 2FA requirement on nested parent group', :nested_groups do
2050 2051 2052 2053 2054 2055 2056 2057 2058 2059
      let!(:group1) { create :group, require_two_factor_authentication: true }
      let!(:group1a) { create :group, require_two_factor_authentication: false, parent: group1 }

      before do
        group1a.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'requires 2FA' do
2060
        expect(user.require_two_factor_authentication_from_group).to be true
2061 2062 2063
      end
    end

2064
    context 'with 2FA requirement on nested child group', :nested_groups do
2065 2066 2067 2068 2069 2070 2071 2072 2073 2074
      let!(:group1) { create :group, require_two_factor_authentication: false }
      let!(:group1a) { create :group, require_two_factor_authentication: true, parent: group1 }

      before do
        group1.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'requires 2FA' do
2075
        expect(user.require_two_factor_authentication_from_group).to be true
2076 2077 2078
      end
    end

2079 2080 2081 2082 2083 2084 2085 2086 2087 2088
    context 'without 2FA requirement on groups' do
      let(:group) { create :group }

      before do
        group.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'does not require 2FA' do
2089
        expect(user.require_two_factor_authentication_from_group).to be false
2090 2091 2092 2093 2094 2095 2096
      end

      it 'falls back to the default grace period' do
        expect(user.two_factor_grace_period).to be 48
      end
    end
  end
J
James Lopez 已提交
2097 2098 2099

  context '.active' do
    before do
2100
      described_class.ghost
J
James Lopez 已提交
2101 2102 2103 2104 2105
      create(:user, name: 'user', state: 'active')
      create(:user, name: 'user', state: 'blocked')
    end

    it 'only counts active and non internal users' do
2106
      expect(described_class.active.count).to eq(1)
J
James Lopez 已提交
2107 2108
    end
  end
2109 2110 2111 2112 2113 2114 2115 2116

  describe 'preferred language' do
    it 'is English by default' do
      user = create(:user)

      expect(user.preferred_language).to eq('en')
    end
  end
2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144

  context '#invalidate_issue_cache_counts' do
    let(:user) { build_stubbed(:user) }

    it 'invalidates cache for issue counter' do
      cache_mock = double

      expect(cache_mock).to receive(:delete).with(['users', user.id, 'assigned_open_issues_count'])

      allow(Rails).to receive(:cache).and_return(cache_mock)

      user.invalidate_issue_cache_counts
    end
  end

  context '#invalidate_merge_request_cache_counts' do
    let(:user) { build_stubbed(:user) }

    it 'invalidates cache for Merge Request counter' do
      cache_mock = double

      expect(cache_mock).to receive(:delete).with(['users', user.id, 'assigned_open_merge_requests_count'])

      allow(Rails).to receive(:cache).and_return(cache_mock)

      user.invalidate_merge_request_cache_counts
    end
  end
2145

2146
  describe '#allow_password_authentication_for_web?' do
2147 2148 2149
    context 'regular user' do
      let(:user) { build(:user) }

2150 2151
      it 'returns true when password authentication is enabled for the web interface' do
        expect(user.allow_password_authentication_for_web?).to be_truthy
2152 2153
      end

2154 2155
      it 'returns false when password authentication is disabled for the web interface' do
        stub_application_setting(password_authentication_enabled_for_web: false)
2156

2157
        expect(user.allow_password_authentication_for_web?).to be_falsey
2158 2159 2160 2161 2162 2163
      end
    end

    it 'returns false for ldap user' do
      user = create(:omniauth_user, provider: 'ldapmain')

2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186
      expect(user.allow_password_authentication_for_web?).to be_falsey
    end
  end

  describe '#allow_password_authentication_for_git?' do
    context 'regular user' do
      let(:user) { build(:user) }

      it 'returns true when password authentication is enabled for Git' do
        expect(user.allow_password_authentication_for_git?).to be_truthy
      end

      it 'returns false when password authentication is disabled Git' do
        stub_application_setting(password_authentication_enabled_for_git: false)

        expect(user.allow_password_authentication_for_git?).to be_falsey
      end
    end

    it 'returns false for ldap user' do
      user = create(:omniauth_user, provider: 'ldapmain')

      expect(user.allow_password_authentication_for_git?).to be_falsey
2187 2188
    end
  end
2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212

  describe '#personal_projects_count' do
    it 'returns the number of personal projects using a single query' do
      user = build(:user)
      projects = double(:projects, count: 1)

      expect(user).to receive(:personal_projects).once.and_return(projects)

      2.times do
        expect(user.personal_projects_count).to eq(1)
      end
    end
  end

  describe '#projects_limit_left' do
    it 'returns the number of projects that can be created by the user' do
      user = build(:user)

      allow(user).to receive(:projects_limit).and_return(10)
      allow(user).to receive(:personal_projects_count).and_return(5)

      expect(user.projects_limit_left).to eq(5)
    end
  end
2213 2214 2215 2216 2217 2218 2219

  describe '#ensure_namespace_correct' do
    context 'for a new user' do
      let(:user) { build(:user) }

      it 'creates the namespace' do
        expect(user.namespace).to be_nil
2220

2221
        user.save!
2222

2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242
        expect(user.namespace).not_to be_nil
      end
    end

    context 'for an existing user' do
      let(:username) { 'foo' }
      let(:user) { create(:user, username: username) }

      context 'when the user is updated' do
        context 'when the username is changed' do
          let(:new_username) { 'bar' }

          it 'changes the namespace (just to compare to when username is not changed)' do
            expect do
              user.update_attributes!(username: new_username)
            end.to change { user.namespace.updated_at }
          end

          it 'updates the namespace name' do
            user.update_attributes!(username: new_username)
2243

2244 2245 2246 2247 2248
            expect(user.namespace.name).to eq(new_username)
          end

          it 'updates the namespace path' do
            user.update_attributes!(username: new_username)
2249

2250 2251 2252 2253 2254 2255
            expect(user.namespace.path).to eq(new_username)
          end

          context 'when there is a validation error (namespace name taken) while updating namespace' do
            let!(:conflicting_namespace) { create(:group, name: new_username, path: 'quz') }

2256
            it 'causes the user save to fail' do
2257 2258 2259
              expect(user.update_attributes(username: new_username)).to be_falsey
              expect(user.namespace.errors.messages[:name].first).to eq('has already been taken')
            end
2260 2261 2262

            it 'adds the namespace errors to the user' do
              user.update_attributes(username: new_username)
2263

2264 2265
              expect(user.errors.full_messages.first).to eq('Namespace name has already been taken')
            end
2266 2267 2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278
          end
        end

        context 'when the username is not changed' do
          it 'does not change the namespace' do
            expect do
              user.update_attributes!(email: 'asdf@asdf.com')
            end.not_to change { user.namespace.updated_at }
          end
        end
      end
    end
  end
A
Alexis Reigel 已提交
2279

2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315
  describe '#username_changed_hook' do
    context 'for a new user' do
      let(:user) { build(:user) }

      it 'does not trigger system hook' do
        expect(user).not_to receive(:system_hook_service)

        user.save!
      end
    end

    context 'for an existing user' do
      let(:user) { create(:user, username: 'old-username') }

      context 'when the username is changed' do
        let(:new_username) { 'very-new-name' }

        it 'triggers the rename system hook' do
          system_hook_service = SystemHooksService.new
          expect(system_hook_service).to receive(:execute_hooks_for).with(user, :rename)
          expect(user).to receive(:system_hook_service).and_return(system_hook_service)

          user.update_attributes!(username: new_username)
        end
      end

      context 'when the username is not changed' do
        it 'does not trigger system hook' do
          expect(user).not_to receive(:system_hook_service)

          user.update_attributes!(email: 'asdf@asdf.com')
        end
      end
    end
  end

2316 2317 2318 2319 2320 2321
  describe '#sync_attribute?' do
    let(:user) { described_class.new }

    context 'oauth user' do
      it 'returns true if name can be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(name location))
2322

2323 2324 2325 2326 2327
        expect(user.sync_attribute?(:name)).to be_truthy
      end

      it 'returns true if email can be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(name email))
2328

2329 2330 2331 2332 2333
        expect(user.sync_attribute?(:email)).to be_truthy
      end

      it 'returns true if location can be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(location email))
2334

2335 2336 2337 2338 2339
        expect(user.sync_attribute?(:email)).to be_truthy
      end

      it 'returns false if name can not be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(location email))
2340

2341 2342 2343 2344 2345
        expect(user.sync_attribute?(:name)).to be_falsey
      end

      it 'returns false if email can not be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(location email))
2346

2347 2348 2349 2350 2351
        expect(user.sync_attribute?(:name)).to be_falsey
      end

      it 'returns false if location can not be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(location email))
2352

2353 2354 2355 2356 2357
        expect(user.sync_attribute?(:name)).to be_falsey
      end

      it 'returns true for all syncable attributes if all syncable attributes can be synced' do
        stub_omniauth_setting(sync_profile_attributes: true)
2358

2359 2360 2361 2362 2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373
        expect(user.sync_attribute?(:name)).to be_truthy
        expect(user.sync_attribute?(:email)).to be_truthy
        expect(user.sync_attribute?(:location)).to be_truthy
      end

      it 'returns false for all syncable attributes but email if no syncable attributes are declared' do
        expect(user.sync_attribute?(:name)).to be_falsey
        expect(user.sync_attribute?(:email)).to be_truthy
        expect(user.sync_attribute?(:location)).to be_falsey
      end
    end

    context 'ldap user' do
      it 'returns true for email if ldap user' do
        allow(user).to receive(:ldap_user?).and_return(true)
2374

2375 2376 2377 2378 2379 2380 2381 2382
        expect(user.sync_attribute?(:name)).to be_falsey
        expect(user.sync_attribute?(:email)).to be_truthy
        expect(user.sync_attribute?(:location)).to be_falsey
      end

      it 'returns true for email and location if ldap user and location declared as syncable' do
        allow(user).to receive(:ldap_user?).and_return(true)
        stub_omniauth_setting(sync_profile_attributes: %w(location))
2383

2384 2385 2386 2387 2388 2389
        expect(user.sync_attribute?(:name)).to be_falsey
        expect(user.sync_attribute?(:email)).to be_truthy
        expect(user.sync_attribute?(:location)).to be_truthy
      end
    end
  end
2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402 2403 2404 2405

  describe '#confirm_deletion_with_password?' do
    where(
      password_automatically_set: [true, false],
      ldap_user: [true, false],
      password_authentication_disabled: [true, false]
    )

    with_them do
      let!(:user) { create(:user, password_automatically_set: password_automatically_set) }
      let!(:identity) { create(:identity, user: user) if ldap_user }

      # Only confirm deletion with password if all inputs are false
      let(:expected) { !(password_automatically_set || ldap_user || password_authentication_disabled) }

      before do
2406 2407
        stub_application_setting(password_authentication_enabled_for_web: !password_authentication_disabled)
        stub_application_setting(password_authentication_enabled_for_git: !password_authentication_disabled)
2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435
      end

      it 'returns false unless all inputs are true' do
        expect(user.confirm_deletion_with_password?).to eq(expected)
      end
    end
  end

  describe '#delete_async' do
    let(:user) { create(:user) }
    let(:deleted_by) { create(:user) }

    it 'blocks the user then schedules them for deletion if a hard delete is specified' do
      expect(DeleteUserWorker).to receive(:perform_async).with(deleted_by.id, user.id, hard_delete: true)

      user.delete_async(deleted_by: deleted_by, params: { hard_delete: true })

      expect(user).to be_blocked
    end

    it 'schedules user for deletion without blocking them' do
      expect(DeleteUserWorker).to receive(:perform_async).with(deleted_by.id, user.id, {})

      user.delete_async(deleted_by: deleted_by)

      expect(user).not_to be_blocked
    end
  end
2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453 2454 2455 2456 2457 2458 2459 2460 2461 2462 2463 2464 2465 2466 2467 2468 2469 2470 2471 2472 2473 2474 2475 2476 2477 2478 2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489 2490 2491 2492 2493 2494 2495 2496 2497 2498 2499 2500 2501 2502 2503 2504 2505 2506 2507 2508 2509 2510 2511 2512 2513 2514 2515 2516 2517 2518 2519 2520 2521 2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537 2538 2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555 2556 2557 2558 2559 2560 2561 2562 2563 2564 2565 2566 2567 2568 2569 2570 2571 2572 2573 2574 2575 2576 2577 2578 2579 2580 2581 2582 2583 2584 2585 2586 2587 2588 2589 2590 2591 2592 2593 2594

  describe '#max_member_access_for_project_ids' do
    shared_examples 'max member access for projects' do
      let(:user) { create(:user) }
      let(:group) { create(:group) }
      let(:owner_project) { create(:project, group: group) }
      let(:master_project) { create(:project) }
      let(:reporter_project) { create(:project) }
      let(:developer_project) { create(:project) }
      let(:guest_project) { create(:project) }
      let(:no_access_project) { create(:project) }

      let(:projects) do
        [owner_project, master_project, reporter_project, developer_project, guest_project, no_access_project].map(&:id)
      end

      let(:expected) do
        {
          owner_project.id => Gitlab::Access::OWNER,
          master_project.id => Gitlab::Access::MASTER,
          reporter_project.id => Gitlab::Access::REPORTER,
          developer_project.id => Gitlab::Access::DEVELOPER,
          guest_project.id => Gitlab::Access::GUEST,
          no_access_project.id => Gitlab::Access::NO_ACCESS
        }
      end

      before do
        create(:group_member, user: user, group: group)
        master_project.add_master(user)
        reporter_project.add_reporter(user)
        developer_project.add_developer(user)
        guest_project.add_guest(user)
      end

      it 'returns correct roles for different projects' do
        expect(user.max_member_access_for_project_ids(projects)).to eq(expected)
      end
    end

    context 'with RequestStore enabled', :request_store do
      include_examples 'max member access for projects'

      def access_levels(projects)
        user.max_member_access_for_project_ids(projects)
      end

      it 'does not perform extra queries when asked for projects who have already been found' do
        access_levels(projects)

        expect { access_levels(projects) }.not_to exceed_query_limit(0)

        expect(access_levels(projects)).to eq(expected)
      end

      it 'only requests the extra projects when uncached projects are passed' do
        second_master_project = create(:project)
        second_developer_project = create(:project)
        second_master_project.add_master(user)
        second_developer_project.add_developer(user)

        all_projects = projects + [second_master_project.id, second_developer_project.id]

        expected_all = expected.merge(second_master_project.id => Gitlab::Access::MASTER,
                                      second_developer_project.id => Gitlab::Access::DEVELOPER)

        access_levels(projects)

        queries = ActiveRecord::QueryRecorder.new { access_levels(all_projects) }

        expect(queries.count).to eq(1)
        expect(queries.log_message).to match(/\W(#{second_master_project.id}, #{second_developer_project.id})\W/)
        expect(access_levels(all_projects)).to eq(expected_all)
      end
    end

    context 'with RequestStore disabled' do
      include_examples 'max member access for projects'
    end
  end

  describe '#max_member_access_for_group_ids' do
    shared_examples 'max member access for groups' do
      let(:user) { create(:user) }
      let(:owner_group) { create(:group) }
      let(:master_group) { create(:group) }
      let(:reporter_group) { create(:group) }
      let(:developer_group) { create(:group) }
      let(:guest_group) { create(:group) }
      let(:no_access_group) { create(:group) }

      let(:groups) do
        [owner_group, master_group, reporter_group, developer_group, guest_group, no_access_group].map(&:id)
      end

      let(:expected) do
        {
          owner_group.id => Gitlab::Access::OWNER,
          master_group.id => Gitlab::Access::MASTER,
          reporter_group.id => Gitlab::Access::REPORTER,
          developer_group.id => Gitlab::Access::DEVELOPER,
          guest_group.id => Gitlab::Access::GUEST,
          no_access_group.id => Gitlab::Access::NO_ACCESS
        }
      end

      before do
        owner_group.add_owner(user)
        master_group.add_master(user)
        reporter_group.add_reporter(user)
        developer_group.add_developer(user)
        guest_group.add_guest(user)
      end

      it 'returns correct roles for different groups' do
        expect(user.max_member_access_for_group_ids(groups)).to eq(expected)
      end
    end

    context 'with RequestStore enabled', :request_store do
      include_examples 'max member access for groups'

      def access_levels(groups)
        user.max_member_access_for_group_ids(groups)
      end

      it 'does not perform extra queries when asked for groups who have already been found' do
        access_levels(groups)

        expect { access_levels(groups) }.not_to exceed_query_limit(0)

        expect(access_levels(groups)).to eq(expected)
      end

      it 'only requests the extra groups when uncached groups are passed' do
        second_master_group = create(:group)
        second_developer_group = create(:group)
        second_master_group.add_master(user)
        second_developer_group.add_developer(user)

        all_groups = groups + [second_master_group.id, second_developer_group.id]

        expected_all = expected.merge(second_master_group.id => Gitlab::Access::MASTER,
                                      second_developer_group.id => Gitlab::Access::DEVELOPER)

        access_levels(groups)

        queries = ActiveRecord::QueryRecorder.new { access_levels(all_groups) }

        expect(queries.count).to eq(1)
        expect(queries.log_message).to match(/\W(#{second_master_group.id}, #{second_developer_group.id})\W/)
        expect(access_levels(all_groups)).to eq(expected_all)
      end
    end

    context 'with RequestStore disabled' do
      include_examples 'max member access for groups'
    end
  end
G
gitlabhq 已提交
2595
end