user_spec.rb 71.4 KB
Newer Older
G
gitlabhq 已提交
1 2
require 'spec_helper'

3
describe User do
4 5
  include Gitlab::CurrentSettings

6 7 8 9 10 11 12 13 14 15
  describe 'modules' do
    subject { described_class }

    it { is_expected.to include_module(Gitlab::ConfigHelper) }
    it { is_expected.to include_module(Gitlab::CurrentSettings) }
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
    it { is_expected.to include_module(TokenAuthenticatable) }
  end

16 17 18 19
  describe 'delegations' do
    it { is_expected.to delegate_method(:path).to(:namespace).with_prefix }
  end

20
  describe 'associations' do
21
    it { is_expected.to have_one(:namespace) }
22
    it { is_expected.to have_many(:snippets).dependent(:destroy) }
23 24 25
    it { is_expected.to have_many(:project_members).dependent(:destroy) }
    it { is_expected.to have_many(:groups) }
    it { is_expected.to have_many(:keys).dependent(:destroy) }
26
    it { is_expected.to have_many(:deploy_keys).dependent(:destroy) }
27
    it { is_expected.to have_many(:events).dependent(:destroy) }
28
    it { is_expected.to have_many(:recent_events).class_name('Event') }
29
    it { is_expected.to have_many(:issues).dependent(:destroy) }
30 31 32
    it { is_expected.to have_many(:notes).dependent(:destroy) }
    it { is_expected.to have_many(:merge_requests).dependent(:destroy) }
    it { is_expected.to have_many(:identities).dependent(:destroy) }
33
    it { is_expected.to have_many(:spam_logs).dependent(:destroy) }
34
    it { is_expected.to have_many(:todos).dependent(:destroy) }
35
    it { is_expected.to have_many(:award_emoji).dependent(:destroy) }
K
Kamil Trzcinski 已提交
36
    it { is_expected.to have_many(:triggers).dependent(:destroy) }
37 38
    it { is_expected.to have_many(:builds).dependent(:nullify) }
    it { is_expected.to have_many(:pipelines).dependent(:nullify) }
K
Kamil Trzcinski 已提交
39
    it { is_expected.to have_many(:chat_names).dependent(:destroy) }
40
    it { is_expected.to have_many(:uploads).dependent(:destroy) }
41
    it { is_expected.to have_many(:reported_abuse_reports).dependent(:destroy).class_name('AbuseReport') }
42

43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68
    describe "#abuse_report" do
      let(:current_user) { create(:user) }
      let(:other_user) { create(:user) }

      it { is_expected.to have_one(:abuse_report) }

      it "refers to the abuse report whose user_id is the current user" do
        abuse_report = create(:abuse_report, reporter: other_user, user: current_user)

        expect(current_user.abuse_report).to eq(abuse_report)
      end

      it "does not refer to the abuse report whose reporter_id is the current user" do
        create(:abuse_report, reporter: current_user, user: other_user)

        expect(current_user.abuse_report).to be_nil
      end

      it "does not update the user_id of an abuse report when the user is updated" do
        abuse_report = create(:abuse_report, reporter: current_user, user: other_user)

        current_user.block

        expect(abuse_report.reload.user).to eq(other_user)
      end
    end
69 70 71 72

    describe '#group_members' do
      it 'does not include group memberships for which user is a requester' do
        user = create(:user)
73
        group = create(:group, :public, :access_requestable)
74 75 76 77 78 79 80 81 82
        group.request_access(user)

        expect(user.group_members).to be_empty
      end
    end

    describe '#project_members' do
      it 'does not include project memberships for which user is a requester' do
        user = create(:user)
83
        project = create(:project, :public, :access_requestable)
84 85 86 87 88
        project.request_access(user)

        expect(user.project_members).to be_empty
      end
    end
89 90 91
  end

  describe 'validations' do
R
Robert Speicher 已提交
92 93 94 95 96 97 98 99 100 101 102 103
    describe 'username' do
      it 'validates presence' do
        expect(subject).to validate_presence_of(:username)
      end

      it 'rejects blacklisted names' do
        user = build(:user, username: 'dashboard')

        expect(user).not_to be_valid
        expect(user.errors.values).to eq [['dashboard is a reserved name']]
      end

104 105 106 107 108 109 110 111 112 113 114 115
      it 'allows child names' do
        user = build(:user, username: 'avatar')

        expect(user).to be_valid
      end

      it 'allows wildcard names' do
        user = build(:user, username: 'blob')

        expect(user).to be_valid
      end

R
Robert Speicher 已提交
116
      it 'validates uniqueness' do
117 118 119
        user = build(:user)

        expect(user).to validate_uniqueness_of(:username).case_insensitive
R
Robert Speicher 已提交
120
      end
121 122 123 124 125 126 127 128 129 130 131

      context 'when username is changed' do
        let(:user) { build_stubbed(:user, username: 'old_path', namespace: build_stubbed(:namespace)) }

        it 'validates move_dir is allowed for the namespace' do
          expect(user.namespace).to receive(:any_project_has_container_registry_tags?).and_return(true)
          user.username = 'new_path'
          expect(user).to be_invalid
          expect(user.errors.messages[:username].first).to match('cannot be changed if a personal project has container registry tags')
        end
      end
R
Robert Speicher 已提交
132 133
    end

134 135 136 137
    it { is_expected.to validate_presence_of(:projects_limit) }
    it { is_expected.to validate_numericality_of(:projects_limit) }
    it { is_expected.to allow_value(0).for(:projects_limit) }
    it { is_expected.not_to allow_value(-1).for(:projects_limit) }
138
    it { is_expected.not_to allow_value(Gitlab::Database::MAX_INT_VALUE + 1).for(:projects_limit) }
139

140
    it { is_expected.to validate_length_of(:bio).is_at_most(255) }
141

142 143 144
    it_behaves_like 'an object with email-formated attributes', :email do
      subject { build(:user) }
    end
145

146 147 148
    it_behaves_like 'an object with email-formated attributes', :public_email, :notification_email do
      subject { build(:user).tap { |user| user.emails << build(:email, email: email_value) } }
    end
149

150
    describe 'email' do
151
      context 'when no signup domains whitelisted' do
152
        before do
153
          allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return([])
154
        end
155

156 157 158 159 160 161
        it 'accepts any email' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end
      end

162
      context 'when a signup domain is whitelisted and subdomains are allowed' do
163
        before do
164
          allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['example.com', '*.example.com'])
165
        end
166

167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182
        it 'accepts info@example.com' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end

        it 'accepts info@test.example.com' do
          user = build(:user, email: "info@test.example.com")
          expect(user).to be_valid
        end

        it 'rejects example@test.com' do
          user = build(:user, email: "example@test.com")
          expect(user).to be_invalid
        end
      end

183
      context 'when a signup domain is whitelisted and subdomains are not allowed' do
184
        before do
185
          allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['example.com'])
186
        end
187 188 189 190 191 192 193 194 195 196 197 198 199 200 201

        it 'accepts info@example.com' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end

        it 'rejects info@test.example.com' do
          user = build(:user, email: "info@test.example.com")
          expect(user).to be_invalid
        end

        it 'rejects example@test.com' do
          user = build(:user, email: "example@test.com")
          expect(user).to be_invalid
        end
202 203 204 205 206

        it 'accepts example@test.com when added by another user' do
          user = build(:user, email: "example@test.com", created_by_id: 1)
          expect(user).to be_valid
        end
207
      end
208

209 210 211 212 213 214
      context 'domain blacklist' do
        before do
          allow_any_instance_of(ApplicationSetting).to receive(:domain_blacklist_enabled?).and_return(true)
          allow_any_instance_of(ApplicationSetting).to receive(:domain_blacklist).and_return(['example.com'])
        end

215
        context 'when a signup domain is blacklisted' do
216 217 218 219 220 221 222 223 224
          it 'accepts info@test.com' do
            user = build(:user, email: 'info@test.com')
            expect(user).to be_valid
          end

          it 'rejects info@example.com' do
            user = build(:user, email: 'info@example.com')
            expect(user).not_to be_valid
          end
225 226 227 228 229

          it 'accepts info@example.com when added by another user' do
            user = build(:user, email: 'info@example.com', created_by_id: 1)
            expect(user).to be_valid
          end
230 231
        end

232
        context 'when a signup domain is blacklisted but a wildcard subdomain is allowed' do
233 234
          before do
            allow_any_instance_of(ApplicationSetting).to receive(:domain_blacklist).and_return(['test.example.com'])
235
            allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['*.example.com'])
236 237
          end

238
          it 'gives priority to whitelist and allow info@test.example.com' do
239 240 241 242 243 244 245
            user = build(:user, email: 'info@test.example.com')
            expect(user).to be_valid
          end
        end

        context 'with both lists containing a domain' do
          before do
246
            allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['test.com'])
247 248 249 250 251 252 253 254 255 256 257 258 259 260
          end

          it 'accepts info@test.com' do
            user = build(:user, email: 'info@test.com')
            expect(user).to be_valid
          end

          it 'rejects info@example.com' do
            user = build(:user, email: 'info@example.com')
            expect(user).not_to be_valid
          end
        end
      end

261 262 263 264 265 266
      context 'owns_notification_email' do
        it 'accepts temp_oauth_email emails' do
          user = build(:user, email: "temp-email-for-oauth@example.com")
          expect(user).to be_valid
        end
      end
267
    end
268 269 270 271 272 273 274
  end

  describe "scopes" do
    describe ".with_two_factor" do
      it "returns users with 2fa enabled via OTP" do
        user_with_2fa = create(:user, :two_factor_via_otp)
        user_without_2fa = create(:user)
275
        users_with_two_factor = described_class.with_two_factor.pluck(:id)
276 277 278 279 280 281 282 283

        expect(users_with_two_factor).to include(user_with_2fa.id)
        expect(users_with_two_factor).not_to include(user_without_2fa.id)
      end

      it "returns users with 2fa enabled via U2F" do
        user_with_2fa = create(:user, :two_factor_via_u2f)
        user_without_2fa = create(:user)
284
        users_with_two_factor = described_class.with_two_factor.pluck(:id)
285 286 287 288 289 290 291 292

        expect(users_with_two_factor).to include(user_with_2fa.id)
        expect(users_with_two_factor).not_to include(user_without_2fa.id)
      end

      it "returns users with 2fa enabled via OTP and U2F" do
        user_with_2fa = create(:user, :two_factor_via_otp, :two_factor_via_u2f)
        user_without_2fa = create(:user)
293
        users_with_two_factor = described_class.with_two_factor.pluck(:id)
294 295 296 297 298 299 300 301 302 303

        expect(users_with_two_factor).to eq([user_with_2fa.id])
        expect(users_with_two_factor).not_to include(user_without_2fa.id)
      end
    end

    describe ".without_two_factor" do
      it "excludes users with 2fa enabled via OTP" do
        user_with_2fa = create(:user, :two_factor_via_otp)
        user_without_2fa = create(:user)
304
        users_without_two_factor = described_class.without_two_factor.pluck(:id)
305 306 307 308 309 310 311 312

        expect(users_without_two_factor).to include(user_without_2fa.id)
        expect(users_without_two_factor).not_to include(user_with_2fa.id)
      end

      it "excludes users with 2fa enabled via U2F" do
        user_with_2fa = create(:user, :two_factor_via_u2f)
        user_without_2fa = create(:user)
313
        users_without_two_factor = described_class.without_two_factor.pluck(:id)
314 315 316 317 318 319 320 321

        expect(users_without_two_factor).to include(user_without_2fa.id)
        expect(users_without_two_factor).not_to include(user_with_2fa.id)
      end

      it "excludes users with 2fa enabled via OTP and U2F" do
        user_with_2fa = create(:user, :two_factor_via_otp, :two_factor_via_u2f)
        user_without_2fa = create(:user)
322
        users_without_two_factor = described_class.without_two_factor.pluck(:id)
323 324 325 326 327

        expect(users_without_two_factor).to include(user_without_2fa.id)
        expect(users_without_two_factor).not_to include(user_with_2fa.id)
      end
    end
V
Valery Sizov 已提交
328 329 330 331 332 333 334 335 336 337

    describe '.todo_authors' do
      it 'filters users' do
        create :user
        user_2 = create :user
        user_3 = create :user
        current_user = create :user
        create(:todo, user: current_user, author: user_2, state: :done)
        create(:todo, user: current_user, author: user_3, state: :pending)

338 339
        expect(described_class.todo_authors(current_user.id, 'pending')).to eq [user_3]
        expect(described_class.todo_authors(current_user.id, 'done')).to eq [user_2]
V
Valery Sizov 已提交
340 341
      end
    end
G
gitlabhq 已提交
342 343 344
  end

  describe "Respond to" do
B
blackst0ne 已提交
345
    it { is_expected.to respond_to(:admin?) }
346 347
    it { is_expected.to respond_to(:name) }
    it { is_expected.to respond_to(:private_token) }
Z
Zeger-Jan van de Weg 已提交
348 349 350 351 352 353 354 355 356 357 358 359 360 361
    it { is_expected.to respond_to(:external?) }
  end

  describe 'before save hook' do
    context 'when saving an external user' do
      let(:user)          { create(:user) }
      let(:external_user) { create(:user, external: true) }

      it "sets other properties aswell" do
        expect(external_user.can_create_team).to be_falsey
        expect(external_user.can_create_group).to be_falsey
        expect(external_user.projects_limit).to be 0
      end
    end
362 363 364 365 366 367 368 369 370 371 372 373 374
    
    describe '#check_for_verified_email' do
      let(:user)      { create(:user) }
      let(:secondary) { create(:email, :confirmed, email: 'secondary@example.com', user: user, ) }
      
      it 'allows a verfied secondary email to be used as the primary without needing reconfirmation' do
        user.update_attributes!(email: secondary.email)
        user.reload
        expect(user.email).to eq secondary.email
        expect(user.unconfirmed_email).to eq nil
        expect(user.confirmed?).to be_truthy
      end
    end
G
gitlabhq 已提交
375 376
  end

377
  describe 'after commit hook' do
378 379 380 381 382 383 384 385 386 387 388 389 390
    describe '.update_invalid_gpg_signatures' do
      let(:user) do
        create(:user, email: 'tula.torphy@abshire.ca').tap do |user|
          user.skip_reconfirmation!
        end
      end

      it 'does nothing when the name is updated' do
        expect(user).not_to receive(:update_invalid_gpg_signatures)
        user.update_attributes!(name: 'Bette')
      end

      it 'synchronizes the gpg keys when the email is updated' do
391
        expect(user).to receive(:update_invalid_gpg_signatures).at_most(:twice)
392 393 394
        user.update_attributes!(email: 'shawnee.ritchie@denesik.com')
      end
    end
395 396 397 398 399 400 401 402 403 404 405 406 407 408 409

    describe '#update_emails_with_primary_email' do
      before do
        @user = create(:user, email: 'primary@example.com').tap do |user|
          user.skip_reconfirmation!
        end
        @secondary = create :email, email: 'secondary@example.com', user: @user
        @user.reload
      end

      it 'gets called when email updated' do
        expect(@user).to receive(:update_emails_with_primary_email)
        @user.update_attributes!(email: 'new_primary@example.com')
      end

410
      it 'adds old primary to secondary emails when secondary is a new email ' do
411 412
        @user.update_attributes!(email: 'new_primary@example.com')
        @user.reload
413 414
        expect(@user.emails.count).to eq 2
        expect(@user.emails.pluck(:email)).to match_array([@secondary.email, 'primary@example.com'])
415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430
      end

      it 'adds old primary to secondary emails if secondary is becoming a primary' do
        @user.update_attributes!(email: @secondary.email)
        @user.reload
        expect(@user.emails.count).to eq 1
        expect(@user.emails.first.email).to eq 'primary@example.com'
      end

      it 'transfers old confirmation values into new secondary' do
        @user.update_attributes!(email: @secondary.email)
        @user.reload
        expect(@user.emails.count).to eq 1
        expect(@user.emails.first.confirmed_at).not_to eq nil
      end
    end
431 432
  end

433
  describe '#update_tracked_fields!', :clean_gitlab_redis_shared_state do
434 435 436 437 438 439 440 441 442 443 444 445 446 447
    let(:request) { OpenStruct.new(remote_ip: "127.0.0.1") }
    let(:user) { create(:user) }

    it 'writes trackable attributes' do
      expect do
        user.update_tracked_fields!(request)
      end.to change { user.reload.current_sign_in_at }
    end

    it 'does not write trackable attributes when called a second time within the hour' do
      user.update_tracked_fields!(request)

      expect do
        user.update_tracked_fields!(request)
448 449 450 451 452 453 454 455 456 457 458
      end.not_to change { user.reload.current_sign_in_at }
    end

    it 'writes trackable attributes for a different user' do
      user2 = create(:user)

      user.update_tracked_fields!(request)

      expect do
        user2.update_tracked_fields!(request)
      end.to change { user2.reload.current_sign_in_at }
459 460 461
    end
  end

462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489
  shared_context 'user keys' do
    let(:user) { create(:user) }
    let!(:key) { create(:key, user: user) }
    let!(:deploy_key) { create(:deploy_key, user: user) }
  end

  describe '#keys' do
    include_context 'user keys'

    context 'with key and deploy key stored' do
      it 'returns stored key, but not deploy_key' do
        expect(user.keys).to include key
        expect(user.keys).not_to include deploy_key
      end
    end
  end

  describe '#deploy_keys' do
    include_context 'user keys'

    context 'with key and deploy key stored' do
      it 'returns stored deploy key, but not normal key' do
        expect(user.deploy_keys).to include deploy_key
        expect(user.deploy_keys).not_to include key
      end
    end
  end

490
  describe '#confirm' do
491 492 493
    before do
      allow_any_instance_of(ApplicationSetting).to receive(:send_user_confirmation_email).and_return(true)
    end
494

495 496 497 498 499 500 501
    let(:user) { create(:user, confirmed_at: nil, unconfirmed_email: 'test@gitlab.com') }

    it 'returns unconfirmed' do
      expect(user.confirmed?).to be_falsey
    end

    it 'confirms a user' do
502
      user.confirm
503 504 505 506
      expect(user.confirmed?).to be_truthy
    end
  end

507 508 509 510 511 512 513 514
  describe '#to_reference' do
    let(:user) { create(:user) }

    it 'returns a String reference to the object' do
      expect(user.to_reference).to eq "@#{user.username}"
    end
  end

515
  describe '#generate_password' do
516
    it "does not generate password by default" do
517
      user = create(:user, password: 'abcdefghe')
518
      expect(user.password).to eq('abcdefghe')
519
    end
520 521
  end

522
  describe 'authentication token' do
523
    it "has authentication token" do
524
      user = create(:user)
525
      expect(user.authentication_token).not_to be_blank
526
    end
N
Nihad Abbasov 已提交
527
  end
528

529 530 531 532 533 534 535
  describe 'ensure incoming email token' do
    it 'has incoming email token' do
      user = create(:user)
      expect(user.incoming_email_token).not_to be_blank
    end
  end

536 537 538 539 540 541 542 543 544 545 546
  describe '#ensure_user_rights_and_limits' do
    describe 'with external user' do
      let(:user) { create(:user, external: true) }

      it 'receives callback when external changes' do
        expect(user).to receive(:ensure_user_rights_and_limits)

        user.update_attributes(external: false)
      end

      it 'ensures correct rights and limits for user' do
T
Tiago Botelho 已提交
547 548
        stub_config_setting(default_can_create_group: true)

549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569
        expect { user.update_attributes(external: false) }.to change { user.can_create_group }.to(true)
          .and change { user.projects_limit }.to(current_application_settings.default_projects_limit)
      end
    end

    describe 'without external user' do
      let(:user) { create(:user, external: false) }

      it 'receives callback when external changes' do
        expect(user).to receive(:ensure_user_rights_and_limits)

        user.update_attributes(external: true)
      end

      it 'ensures correct rights and limits for user' do
        expect { user.update_attributes(external: true) }.to change { user.can_create_group }.to(false)
          .and change { user.projects_limit }.to(0)
      end
    end
  end

570
  describe 'rss token' do
A
Alexis Reigel 已提交
571 572 573 574 575
    it 'ensures an rss token on read' do
      user = create(:user, rss_token: nil)
      rss_token = user.rss_token
      expect(rss_token).not_to be_blank
      expect(user.reload.rss_token).to eq rss_token
576 577 578
    end
  end

579
  describe '#recently_sent_password_reset?' do
580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598
    it 'is false when reset_password_sent_at is nil' do
      user = build_stubbed(:user, reset_password_sent_at: nil)

      expect(user.recently_sent_password_reset?).to eq false
    end

    it 'is false when sent more than one minute ago' do
      user = build_stubbed(:user, reset_password_sent_at: 5.minutes.ago)

      expect(user.recently_sent_password_reset?).to eq false
    end

    it 'is true when sent less than one minute ago' do
      user = build_stubbed(:user, reset_password_sent_at: Time.now)

      expect(user.recently_sent_password_reset?).to eq true
    end
  end

R
Robert Speicher 已提交
599 600 601 602 603 604 605
  describe '#disable_two_factor!' do
    it 'clears all 2FA-related fields' do
      user = create(:user, :two_factor)

      expect(user).to be_two_factor_enabled
      expect(user.encrypted_otp_secret).not_to be_nil
      expect(user.otp_backup_codes).not_to be_nil
606
      expect(user.otp_grace_period_started_at).not_to be_nil
R
Robert Speicher 已提交
607 608 609 610 611 612 613 614

      user.disable_two_factor!

      expect(user).not_to be_two_factor_enabled
      expect(user.encrypted_otp_secret).to be_nil
      expect(user.encrypted_otp_secret_iv).to be_nil
      expect(user.encrypted_otp_secret_salt).to be_nil
      expect(user.otp_backup_codes).to be_nil
615
      expect(user.otp_grace_period_started_at).to be_nil
R
Robert Speicher 已提交
616 617 618
    end
  end

619 620
  describe 'projects' do
    before do
621
      @user = create(:user)
622

623 624
      @project = create(:project, namespace: @user.namespace)
      @project_2 = create(:project, group: create(:group)) do |project|
625 626
        project.add_master(@user)
      end
627
      @project_3 = create(:project, group: create(:group)) do |project|
628 629
        project.add_developer(@user)
      end
630 631
    end

632 633 634 635 636 637 638 639 640
    it { expect(@user.authorized_projects).to include(@project) }
    it { expect(@user.authorized_projects).to include(@project_2) }
    it { expect(@user.authorized_projects).to include(@project_3) }
    it { expect(@user.owned_projects).to include(@project) }
    it { expect(@user.owned_projects).not_to include(@project_2) }
    it { expect(@user.owned_projects).not_to include(@project_3) }
    it { expect(@user.personal_projects).to include(@project) }
    it { expect(@user.personal_projects).not_to include(@project_2) }
    it { expect(@user.personal_projects).not_to include(@project_3) }
641 642 643 644 645
  end

  describe 'groups' do
    before do
      @user = create :user
646 647
      @group = create :group
      @group.add_owner(@user)
648 649
    end

650 651 652
    it { expect(@user.several_namespaces?).to be_truthy }
    it { expect(@user.authorized_groups).to eq([@group]) }
    it { expect(@user.owned_groups).to eq([@group]) }
653
    it { expect(@user.namespaces).to match_array([@user.namespace, @group]) }
654 655
  end

656 657 658 659
  describe 'group multiple owners' do
    before do
      @user = create :user
      @user2 = create :user
660 661
      @group = create :group
      @group.add_owner(@user)
662

663
      @group.add_user(@user2, GroupMember::OWNER)
664 665
    end

666
    it { expect(@user2.several_namespaces?).to be_truthy }
667 668
  end

669 670 671
  describe 'namespaced' do
    before do
      @user = create :user
672
      @project = create(:project, namespace: @user.namespace)
673 674
    end

675
    it { expect(@user.several_namespaces?).to be_falsey }
676
    it { expect(@user.namespaces).to eq([@user.namespace]) }
677 678 679 680 681
  end

  describe 'blocking user' do
    let(:user) { create(:user, name: 'John Smith') }

682
    it "blocks user" do
683
      user.block
684
      expect(user.blocked?).to be_truthy
685 686 687
    end
  end

688 689 690 691
  describe '.filter' do
    let(:user) { double }

    it 'filters by active users by default' do
692
      expect(described_class).to receive(:active).and_return([user])
693

694
      expect(described_class.filter(nil)).to include user
695 696
    end

697
    it 'filters by admins' do
698
      expect(described_class).to receive(:admins).and_return([user])
699

700
      expect(described_class.filter('admins')).to include user
701 702
    end

703
    it 'filters by blocked' do
704
      expect(described_class).to receive(:blocked).and_return([user])
705

706
      expect(described_class.filter('blocked')).to include user
707 708 709
    end

    it 'filters by two_factor_disabled' do
710
      expect(described_class).to receive(:without_two_factor).and_return([user])
711

712
      expect(described_class.filter('two_factor_disabled')).to include user
713 714 715
    end

    it 'filters by two_factor_enabled' do
716
      expect(described_class).to receive(:with_two_factor).and_return([user])
717

718
      expect(described_class.filter('two_factor_enabled')).to include user
719 720 721
    end

    it 'filters by wop' do
722
      expect(described_class).to receive(:without_projects).and_return([user])
723

724
      expect(described_class.filter('wop')).to include user
725
    end
726 727
  end

B
Ben Bodenmiller 已提交
728
  describe '.without_projects' do
729
    let!(:project) { create(:project, :public, :access_requestable) }
B
Ben Bodenmiller 已提交
730 731 732 733 734 735 736 737 738 739 740 741 742 743 744
    let!(:user) { create(:user) }
    let!(:user_without_project) { create(:user) }
    let!(:user_without_project2) { create(:user) }

    before do
      # add user to project
      project.team << [user, :master]

      # create invite to projet
      create(:project_member, :developer, project: project, invite_token: '1234', invite_email: 'inviteduser1@example.com')

      # create request to join project
      project.request_access(user_without_project2)
    end

745 746 747
    it { expect(described_class.without_projects).not_to include user }
    it { expect(described_class.without_projects).to include user_without_project }
    it { expect(described_class.without_projects).to include user_without_project2 }
B
Ben Bodenmiller 已提交
748 749
  end

750 751 752
  describe 'user creation' do
    describe 'normal user' do
      let(:user) { create(:user, name: 'John Smith') }
D
Dmitriy Zaporozhets 已提交
753

B
blackst0ne 已提交
754
      it { expect(user.admin?).to be_falsey }
755 756 757 758
      it { expect(user.require_ssh_key?).to be_truthy }
      it { expect(user.can_create_group?).to be_truthy }
      it { expect(user.can_create_project?).to be_truthy }
      it { expect(user.first_name).to eq('John') }
759
      it { expect(user.external).to be_falsey }
760
    end
761

D
Dmitriy Zaporozhets 已提交
762
    describe 'with defaults' do
763
      let(:user) { described_class.new }
D
Dmitriy Zaporozhets 已提交
764

765
      it "applies defaults to user" do
766 767
        expect(user.projects_limit).to eq(Gitlab.config.gitlab.default_projects_limit)
        expect(user.can_create_group).to eq(Gitlab.config.gitlab.default_can_create_group)
768
        expect(user.theme_id).to eq(Gitlab.config.gitlab.default_theme)
Z
Zeger-Jan van de Weg 已提交
769
        expect(user.external).to be_falsey
770 771 772
      end
    end

D
Dmitriy Zaporozhets 已提交
773
    describe 'with default overrides' do
774
      let(:user) { described_class.new(projects_limit: 123, can_create_group: false, can_create_team: true) }
D
Dmitriy Zaporozhets 已提交
775

776
      it "applies defaults to user" do
777 778
        expect(user.projects_limit).to eq(123)
        expect(user.can_create_group).to be_falsey
779
        expect(user.theme_id).to eq(1)
780
      end
781
    end
782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801

    context 'when current_application_settings.user_default_external is true' do
      before do
        stub_application_setting(user_default_external: true)
      end

      it "creates external user by default" do
        user = build(:user)

        expect(user.external).to be_truthy
      end

      describe 'with default overrides' do
        it "creates a non-external user" do
          user = build(:user, external: false)

          expect(user.external).to be_falsey
        end
      end
    end
802

803 804 805 806
    describe '#require_ssh_key?' do
      protocol_and_expectation = {
        'http' => false,
        'ssh' => true,
807
        '' => true
808 809 810 811 812 813 814 815 816
      }

      protocol_and_expectation.each do |protocol, expected|
        it "has correct require_ssh_key?" do
          stub_application_setting(enabled_git_access_protocol: protocol)
          user = build(:user)

          expect(user.require_ssh_key?).to eq(expected)
        end
817 818
      end
    end
819
  end
820

821
  describe '.find_by_any_email' do
822 823 824
    it 'finds by primary email' do
      user = create(:user, email: 'foo@example.com')

825
      expect(described_class.find_by_any_email(user.email)).to eq user
826 827 828 829 830 831
    end

    it 'finds by secondary email' do
      email = create(:email, email: 'foo@example.com')
      user  = email.user

832
      expect(described_class.find_by_any_email(email.email)).to eq user
833 834 835
    end

    it 'returns nil when nothing found' do
836
      expect(described_class.find_by_any_email('')).to be_nil
837 838 839
    end
  end

840
  describe '.search' do
841 842
    let!(:user) { create(:user, name: 'user', username: 'usern', email: 'email@gmail.com') }
    let!(:user2) { create(:user, name: 'user name', username: 'username', email: 'someemail@gmail.com') }
843
    let!(:user3) { create(:user, name: 'us', username: 'se', email: 'foo@gmail.com') }
844

845 846 847 848
    describe 'name matching' do
      it 'returns users with a matching name with exact match first' do
        expect(described_class.search(user.name)).to eq([user, user2])
      end
849

850
      it 'returns users with a partially matching name' do
851
        expect(described_class.search(user.name[0..2])).to eq([user, user2])
852
      end
853

854 855 856
      it 'returns users with a matching name regardless of the casing' do
        expect(described_class.search(user2.name.upcase)).to eq([user2])
      end
857 858 859 860 861 862 863 864

      it 'returns users with a exact matching name shorter than 3 chars' do
        expect(described_class.search(user3.name)).to eq([user3])
      end

      it 'returns users with a exact matching name shorter than 3 chars regardless of the casing' do
        expect(described_class.search(user3.name.upcase)).to eq([user3])
      end
865 866
    end

867 868 869 870
    describe 'email matching' do
      it 'returns users with a matching Email' do
        expect(described_class.search(user.email)).to eq([user, user2])
      end
871

872
      it 'returns users with a partially matching Email' do
873
        expect(described_class.search(user.email[0..2])).to eq([user, user2])
874
      end
875

876 877 878
      it 'returns users with a matching Email regardless of the casing' do
        expect(described_class.search(user2.email.upcase)).to eq([user2])
      end
879 880
    end

881 882 883 884
    describe 'username matching' do
      it 'returns users with a matching username' do
        expect(described_class.search(user.username)).to eq([user, user2])
      end
885

886
      it 'returns users with a partially matching username' do
887
        expect(described_class.search(user.username[0..2])).to eq([user, user2])
888
      end
889

890 891 892
      it 'returns users with a matching username regardless of the casing' do
        expect(described_class.search(user2.username.upcase)).to eq([user2])
      end
893 894 895 896 897 898 899 900

      it 'returns users with a exact matching username shorter than 3 chars' do
        expect(described_class.search(user3.username)).to eq([user3])
      end

      it 'returns users with a exact matching username shorter than 3 chars regardless of the casing' do
        expect(described_class.search(user3.username.upcase)).to eq([user3])
      end
M
Marin Jankovski 已提交
901
    end
902 903 904
  end

  describe '.search_with_secondary_emails' do
D
Douwe Maan 已提交
905
    delegate :search_with_secondary_emails, to: :described_class
906

907 908
    let!(:user) { create(:user, name: 'John Doe', username: 'john.doe', email: 'john.doe@example.com' ) }
    let!(:another_user) { create(:user, name: 'Albert Smith', username: 'albert.smith', email: 'albert.smith@example.com' ) }
909 910 911
    let!(:email) do
      create(:email, user: another_user, email: 'alias@example.com')
    end
912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976

    it 'returns users with a matching name' do
      expect(search_with_secondary_emails(user.name)).to eq([user])
    end

    it 'returns users with a partially matching name' do
      expect(search_with_secondary_emails(user.name[0..2])).to eq([user])
    end

    it 'returns users with a matching name regardless of the casing' do
      expect(search_with_secondary_emails(user.name.upcase)).to eq([user])
    end

    it 'returns users with a matching email' do
      expect(search_with_secondary_emails(user.email)).to eq([user])
    end

    it 'returns users with a partially matching email' do
      expect(search_with_secondary_emails(user.email[0..2])).to eq([user])
    end

    it 'returns users with a matching email regardless of the casing' do
      expect(search_with_secondary_emails(user.email.upcase)).to eq([user])
    end

    it 'returns users with a matching username' do
      expect(search_with_secondary_emails(user.username)).to eq([user])
    end

    it 'returns users with a partially matching username' do
      expect(search_with_secondary_emails(user.username[0..2])).to eq([user])
    end

    it 'returns users with a matching username regardless of the casing' do
      expect(search_with_secondary_emails(user.username.upcase)).to eq([user])
    end

    it 'returns users with a matching whole secondary email' do
      expect(search_with_secondary_emails(email.email)).to eq([email.user])
    end

    it 'returns users with a matching part of secondary email' do
      expect(search_with_secondary_emails(email.email[1..4])).to eq([email.user])
    end

    it 'return users with a matching part of secondary email regardless of case' do
      expect(search_with_secondary_emails(email.email[1..4].upcase)).to eq([email.user])
      expect(search_with_secondary_emails(email.email[1..4].downcase)).to eq([email.user])
      expect(search_with_secondary_emails(email.email[1..4].capitalize)).to eq([email.user])
    end

    it 'returns multiple users with matching secondary emails' do
      email1 = create(:email, email: '1_testemail@example.com')
      email2 = create(:email, email: '2_testemail@example.com')
      email3 = create(:email, email: 'other@email.com')
      email3.user.update_attributes!(email: 'another@mail.com')

      expect(
        search_with_secondary_emails('testemail@example.com').map(&:id)
      ).to include(email1.user.id, email2.user.id)

      expect(
        search_with_secondary_emails('testemail@example.com').map(&:id)
      ).not_to include(email3.user.id)
    end
M
Marin Jankovski 已提交
977 978
  end

Y
Yorick Peterse 已提交
979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995
  describe '.find_by_ssh_key_id' do
    context 'using an existing SSH key ID' do
      let(:user) { create(:user) }
      let(:key) { create(:key, user: user) }

      it 'returns the corresponding User' do
        expect(described_class.find_by_ssh_key_id(key.id)).to eq(user)
      end
    end

    context 'using an invalid SSH key ID' do
      it 'returns nil' do
        expect(described_class.find_by_ssh_key_id(-1)).to be_nil
      end
    end
  end

996 997 998 999
  describe '.by_login' do
    let(:username) { 'John' }
    let!(:user) { create(:user, username: username) }

1000
    it 'gets the correct user' do
1001 1002 1003 1004 1005 1006
      expect(described_class.by_login(user.email.upcase)).to eq user
      expect(described_class.by_login(user.email)).to eq user
      expect(described_class.by_login(username.downcase)).to eq user
      expect(described_class.by_login(username)).to eq user
      expect(described_class.by_login(nil)).to be_nil
      expect(described_class.by_login('')).to be_nil
1007 1008 1009
    end
  end

1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020
  describe '.find_by_username' do
    it 'returns nil if not found' do
      expect(described_class.find_by_username('JohnDoe')).to be_nil
    end

    it 'is case-insensitive' do
      user = create(:user, username: 'JohnDoe')
      expect(described_class.find_by_username('JOHNDOE')).to eq user
    end
  end

R
Robert Speicher 已提交
1021 1022
  describe '.find_by_username!' do
    it 'raises RecordNotFound' do
1023 1024
      expect { described_class.find_by_username!('JohnDoe') }
        .to raise_error(ActiveRecord::RecordNotFound)
R
Robert Speicher 已提交
1025 1026 1027 1028 1029 1030 1031 1032
    end

    it 'is case-insensitive' do
      user = create(:user, username: 'JohnDoe')
      expect(described_class.find_by_username!('JOHNDOE')).to eq user
    end
  end

1033 1034 1035 1036 1037 1038 1039
  describe '.find_by_full_path' do
    let!(:user) { create(:user) }

    context 'with a route matching the given path' do
      let!(:route) { user.namespace.route }

      it 'returns the user' do
1040
        expect(described_class.find_by_full_path(route.path)).to eq(user)
1041 1042 1043
      end

      it 'is case-insensitive' do
1044 1045
        expect(described_class.find_by_full_path(route.path.upcase)).to eq(user)
        expect(described_class.find_by_full_path(route.path.downcase)).to eq(user)
1046 1047 1048 1049 1050 1051 1052 1053
      end
    end

    context 'with a redirect route matching the given path' do
      let!(:redirect_route) { user.namespace.redirect_routes.create(path: 'foo') }

      context 'without the follow_redirects option' do
        it 'returns nil' do
1054
          expect(described_class.find_by_full_path(redirect_route.path)).to eq(nil)
1055 1056 1057 1058 1059
        end
      end

      context 'with the follow_redirects option set to true' do
        it 'returns the user' do
1060
          expect(described_class.find_by_full_path(redirect_route.path, follow_redirects: true)).to eq(user)
1061 1062 1063
        end

        it 'is case-insensitive' do
1064 1065
          expect(described_class.find_by_full_path(redirect_route.path.upcase, follow_redirects: true)).to eq(user)
          expect(described_class.find_by_full_path(redirect_route.path.downcase, follow_redirects: true)).to eq(user)
1066 1067 1068 1069 1070 1071 1072
        end
      end
    end

    context 'without a route or a redirect route matching the given path' do
      context 'without the follow_redirects option' do
        it 'returns nil' do
1073
          expect(described_class.find_by_full_path('unknown')).to eq(nil)
1074 1075 1076 1077
        end
      end
      context 'with the follow_redirects option set to true' do
        it 'returns nil' do
1078
          expect(described_class.find_by_full_path('unknown', follow_redirects: true)).to eq(nil)
1079 1080 1081 1082 1083
        end
      end
    end

    context 'with a group route matching the given path' do
M
Michael Kozono 已提交
1084 1085
      context 'when the group namespace has an owner_id (legacy data)' do
        let!(:group) { create(:group, path: 'group_path', owner: user) }
1086

M
Michael Kozono 已提交
1087
        it 'returns nil' do
1088
          expect(described_class.find_by_full_path('group_path')).to eq(nil)
M
Michael Kozono 已提交
1089 1090 1091 1092 1093 1094 1095
        end
      end

      context 'when the group namespace does not have an owner_id' do
        let!(:group) { create(:group, path: 'group_path') }

        it 'returns nil' do
1096
          expect(described_class.find_by_full_path('group_path')).to eq(nil)
M
Michael Kozono 已提交
1097
        end
1098 1099 1100 1101
      end
    end
  end

G
GitLab 已提交
1102
  describe 'all_ssh_keys' do
1103
    it { is_expected.to have_many(:keys).dependent(:destroy) }
G
GitLab 已提交
1104

1105
    it "has all ssh keys" do
G
GitLab 已提交
1106 1107 1108
      user = create :user
      key = create :key, key: "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQD33bWLBxu48Sev9Fert1yzEO4WGcWglWF7K/AwblIUFselOt/QdOL9DSjpQGxLagO1s9wl53STIO8qGS4Ms0EJZyIXOEFMjFJ5xmjSy+S37By4sG7SsltQEHMxtbtFOaW5LV2wCrX+rUsRNqLMamZjgjcPO0/EgGCXIGMAYW4O7cwGZdXWYIhQ1Vwy+CsVMDdPkPgBXqK7nR/ey8KMs8ho5fMNgB5hBw/AL9fNGhRw3QTD6Q12Nkhl4VZES2EsZqlpNnJttnPdp847DUsT6yuLRlfiQfz5Cn9ysHFdXObMN5VYIiPFwHeYCZp1X2S4fDZooRE8uOLTfxWHPXwrhqSH", user_id: user.id

1109
      expect(user.all_ssh_keys).to include(a_string_starting_with(key.key))
G
GitLab 已提交
1110
    end
G
GitLab 已提交
1111
  end
1112

1113
  describe '#avatar_type' do
D
Dmitriy Zaporozhets 已提交
1114 1115
    let(:user) { create(:user) }

1116
    it 'is true if avatar is image' do
D
Dmitriy Zaporozhets 已提交
1117
      user.update_attribute(:avatar, 'uploads/avatar.png')
1118
      expect(user.avatar_type).to be_truthy
D
Dmitriy Zaporozhets 已提交
1119 1120
    end

1121
    it 'is false if avatar is html page' do
D
Dmitriy Zaporozhets 已提交
1122
      user.update_attribute(:avatar, 'uploads/avatar.html')
1123
      expect(user.avatar_type).to eq(['only images allowed'])
D
Dmitriy Zaporozhets 已提交
1124 1125
    end
  end
J
Jerome Dalbert 已提交
1126

1127 1128 1129 1130
  describe '#avatar_url' do
    let(:user) { create(:user, :with_avatar) }

    context 'when avatar file is uploaded' do
1131
      let(:gitlab_host) { "http://#{Gitlab.config.gitlab.host}" }
1132
      let(:avatar_path) { "/uploads/-/system/user/avatar/#{user.id}/dk.png" }
1133

1134 1135 1136 1137 1138 1139 1140 1141
      it 'shows correct avatar url' do
        expect(user.avatar_url).to eq(avatar_path)
        expect(user.avatar_url(only_path: false)).to eq([gitlab_host, avatar_path].join)

        allow(ActionController::Base).to receive(:asset_host).and_return(gitlab_host)

        expect(user.avatar_url).to eq([gitlab_host, avatar_path].join)
      end
1142 1143 1144
    end
  end

1145 1146 1147 1148 1149 1150 1151
  describe '#all_emails' do
    let(:user) { create(:user) }

    it 'returns all emails' do
      email_confirmed   = create :email, user: user, confirmed_at: Time.now
      email_unconfirmed = create :email, user: user
      user.reload
1152
      expect(user.all_emails).to match_array([user.email, email_unconfirmed.email, email_confirmed.email])
1153 1154 1155
    end
  end

1156
  describe '#verified_emails' do
1157 1158 1159
    let(:user) { create(:user) }

    it 'returns only confirmed emails' do
B
Brett Walker 已提交
1160 1161
      email_confirmed = create :email, user: user, confirmed_at: Time.now
      create :email, user: user
1162
      user.reload
1163
      expect(user.verified_emails).to match_array([user.email, email_confirmed.email])
1164 1165 1166 1167 1168 1169 1170
    end
  end

  describe '#verified_email?' do
    let(:user) { create(:user) }

    it 'returns true when the email is verified/confirmed' do
B
Brett Walker 已提交
1171 1172
      email_confirmed = create :email, user: user, confirmed_at: Time.now
      create :email, user: user
1173 1174 1175
      user.reload

      expect(user.verified_email?(user.email)).to be_truthy
1176
      expect(user.verified_email?(email_confirmed.email.titlecase)).to be_truthy
1177 1178 1179 1180 1181 1182 1183 1184 1185 1186
    end

    it 'returns false when the email is not verified/confirmed' do
      email_unconfirmed = create :email, user: user
      user.reload

      expect(user.verified_email?(email_unconfirmed.email)).to be_falsy
    end
  end

1187
  describe '#requires_ldap_check?' do
1188
    let(:user) { described_class.new }
1189

1190 1191
    it 'is false when LDAP is disabled' do
      # Create a condition which would otherwise cause 'true' to be returned
1192
      allow(user).to receive(:ldap_user?).and_return(true)
1193
      user.last_credential_check_at = nil
1194
      expect(user.requires_ldap_check?).to be_falsey
1195 1196
    end

1197
    context 'when LDAP is enabled' do
1198 1199 1200
      before do
        allow(Gitlab.config.ldap).to receive(:enabled).and_return(true)
      end
1201

1202
      it 'is false for non-LDAP users' do
1203
        allow(user).to receive(:ldap_user?).and_return(false)
1204
        expect(user.requires_ldap_check?).to be_falsey
1205 1206
      end

1207
      context 'and when the user is an LDAP user' do
1208 1209 1210
        before do
          allow(user).to receive(:ldap_user?).and_return(true)
        end
1211 1212 1213

        it 'is true when the user has never had an LDAP check before' do
          user.last_credential_check_at = nil
1214
          expect(user.requires_ldap_check?).to be_truthy
1215 1216 1217 1218
        end

        it 'is true when the last LDAP check happened over 1 hour ago' do
          user.last_credential_check_at = 2.hours.ago
1219
          expect(user.requires_ldap_check?).to be_truthy
1220
        end
1221 1222 1223 1224
      end
    end
  end

1225
  context 'ldap synchronized user' do
1226
    describe '#ldap_user?' do
1227 1228 1229 1230
      it 'is true if provider name starts with ldap' do
        user = create(:omniauth_user, provider: 'ldapmain')
        expect(user.ldap_user?).to be_truthy
      end
1231

1232 1233 1234 1235 1236 1237 1238 1239 1240
      it 'is false for other providers' do
        user = create(:omniauth_user, provider: 'other-provider')
        expect(user.ldap_user?).to be_falsey
      end

      it 'is false if no extern_uid is provided' do
        user = create(:omniauth_user, extern_uid: nil)
        expect(user.ldap_user?).to be_falsey
      end
1241 1242
    end

1243
    describe '#ldap_identity' do
1244 1245 1246 1247
      it 'returns ldap identity' do
        user = create :omniauth_user
        expect(user.ldap_identity.provider).not_to be_empty
      end
1248 1249
    end

1250 1251 1252 1253 1254 1255 1256 1257
    describe '#ldap_block' do
      let(:user) { create(:omniauth_user, provider: 'ldapmain', name: 'John Smith') }

      it 'blocks user flaging the action caming from ldap' do
        user.ldap_block
        expect(user.blocked?).to be_truthy
        expect(user.ldap_blocked?).to be_truthy
      end
1258 1259 1260
    end
  end

J
Jerome Dalbert 已提交
1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299
  describe '#full_website_url' do
    let(:user) { create(:user) }

    it 'begins with http if website url omits it' do
      user.website_url = 'test.com'

      expect(user.full_website_url).to eq 'http://test.com'
    end

    it 'begins with http if website url begins with http' do
      user.website_url = 'http://test.com'

      expect(user.full_website_url).to eq 'http://test.com'
    end

    it 'begins with https if website url begins with https' do
      user.website_url = 'https://test.com'

      expect(user.full_website_url).to eq 'https://test.com'
    end
  end

  describe '#short_website_url' do
    let(:user) { create(:user) }

    it 'does not begin with http if website url omits it' do
      user.website_url = 'test.com'

      expect(user.short_website_url).to eq 'test.com'
    end

    it 'does not begin with http if website url begins with http' do
      user.website_url = 'http://test.com'

      expect(user.short_website_url).to eq 'test.com'
    end

    it 'does not begin with https if website url begins with https' do
      user.website_url = 'https://test.com'
1300

J
Jerome Dalbert 已提交
1301 1302
      expect(user.short_website_url).to eq 'test.com'
    end
G
GitLab 已提交
1303
  end
C
Ciro Santilli 已提交
1304

1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316
  describe '#sanitize_attrs' do
    let(:user) { build(:user, name: 'test & user', skype: 'test&user') }

    it 'encodes HTML entities in the Skype attribute' do
      expect { user.sanitize_attrs }.to change { user.skype }.to('test&amp;user')
    end

    it 'does not encode HTML entities in the name attribute' do
      expect { user.sanitize_attrs }.not_to change { user.name }
    end
  end

1317 1318
  describe '#starred?' do
    it 'determines if user starred a project' do
1319
      user = create :user
1320 1321
      project1 = create(:project, :public)
      project2 = create(:project, :public)
1322

1323 1324
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_falsey
1325 1326

      star1 = UsersStarProject.create!(project: project1, user: user)
1327 1328
      expect(user.starred?(project1)).to be_truthy
      expect(user.starred?(project2)).to be_falsey
1329 1330

      star2 = UsersStarProject.create!(project: project2, user: user)
1331 1332
      expect(user.starred?(project1)).to be_truthy
      expect(user.starred?(project2)).to be_truthy
1333 1334

      star1.destroy
1335 1336
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_truthy
1337 1338

      star2.destroy
1339 1340
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_falsey
1341 1342 1343
    end
  end

1344 1345
  describe '#toggle_star' do
    it 'toggles stars' do
C
Ciro Santilli 已提交
1346
      user = create :user
1347
      project = create(:project, :public)
C
Ciro Santilli 已提交
1348

1349
      expect(user.starred?(project)).to be_falsey
C
Ciro Santilli 已提交
1350
      user.toggle_star(project)
1351
      expect(user.starred?(project)).to be_truthy
C
Ciro Santilli 已提交
1352
      user.toggle_star(project)
1353
      expect(user.starred?(project)).to be_falsey
C
Ciro Santilli 已提交
1354 1355
    end
  end
V
Valery Sizov 已提交
1356

1357
  describe '#sort' do
V
Valery Sizov 已提交
1358
    before do
1359
      described_class.delete_all
V
Valery Sizov 已提交
1360 1361
      @user = create :user, created_at: Date.today, last_sign_in_at: Date.today, name: 'Alpha'
      @user1 = create :user, created_at: Date.today - 1, last_sign_in_at: Date.today - 1, name: 'Omega'
1362
      @user2 = create :user, created_at: Date.today - 2, last_sign_in_at: nil, name: 'Beta'
V
Valery Sizov 已提交
1363
    end
1364

1365 1366
    context 'when sort by recent_sign_in' do
      it 'sorts users by the recent sign-in time' do
1367
        expect(described_class.sort('recent_sign_in').first).to eq(@user)
1368 1369 1370
      end

      it 'pushes users who never signed in to the end' do
1371
        expect(described_class.sort('recent_sign_in').third).to eq(@user2)
1372
      end
V
Valery Sizov 已提交
1373 1374
    end

1375 1376
    context 'when sort by oldest_sign_in' do
      it 'sorts users by the oldest sign-in time' do
1377
        expect(described_class.sort('oldest_sign_in').first).to eq(@user1)
1378 1379 1380
      end

      it 'pushes users who never signed in to the end' do
1381
        expect(described_class.sort('oldest_sign_in').third).to eq(@user2)
1382
      end
V
Valery Sizov 已提交
1383 1384
    end

1385
    it 'sorts users in descending order by their creation time' do
1386
      expect(described_class.sort('created_desc').first).to eq(@user)
V
Valery Sizov 已提交
1387 1388
    end

1389
    it 'sorts users in ascending order by their creation time' do
1390
      expect(described_class.sort('created_asc').first).to eq(@user2)
V
Valery Sizov 已提交
1391 1392
    end

1393
    it 'sorts users by id in descending order when nil is passed' do
1394
      expect(described_class.sort(nil).first).to eq(@user2)
V
Valery Sizov 已提交
1395 1396
    end
  end
1397

1398
  describe "#contributed_projects" do
1399
    subject { create(:user) }
1400 1401 1402
    let!(:project1) { create(:project) }
    let!(:project2) { create(:project, forked_from_project: project3) }
    let!(:project3) { create(:project) }
1403
    let!(:merge_request) { create(:merge_request, source_project: project2, target_project: project3, author: subject) }
1404
    let!(:push_event) { create(:push_event, project: project1, author: subject) }
1405
    let!(:merge_event) { create(:event, :created, project: project3, target: merge_request, author: subject) }
1406 1407 1408 1409 1410 1411 1412

    before do
      project1.team << [subject, :master]
      project2.team << [subject, :master]
    end

    it "includes IDs for projects the user has pushed to" do
1413
      expect(subject.contributed_projects).to include(project1)
1414 1415 1416
    end

    it "includes IDs for projects the user has had merge requests merged into" do
1417
      expect(subject.contributed_projects).to include(project3)
1418 1419 1420
    end

    it "doesn't include IDs for unrelated projects" do
1421
      expect(subject.contributed_projects).not_to include(project2)
1422 1423
    end
  end
1424

1425
  describe '#can_be_removed?' do
1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440
    subject { create(:user) }

    context 'no owned groups' do
      it { expect(subject.can_be_removed?).to be_truthy }
    end

    context 'has owned groups' do
      before do
        group = create(:group)
        group.add_owner(subject)
      end

      it { expect(subject.can_be_removed?).to be_falsey }
    end
  end
1441 1442

  describe "#recent_push" do
1443 1444 1445
    let(:user) { build(:user) }
    let(:project) { build(:project) }
    let(:event) { build(:push_event) }
1446

1447 1448 1449 1450
    it 'returns the last push event for the user' do
      expect_any_instance_of(Users::LastPushEventService)
        .to receive(:last_event_for_user)
        .and_return(event)
1451

1452
      expect(user.recent_push).to eq(event)
1453 1454
    end

1455 1456 1457 1458
    it 'returns the last push event for a project when one is given' do
      expect_any_instance_of(Users::LastPushEventService)
        .to receive(:last_event_for_project)
        .and_return(event)
1459

1460
      expect(user.recent_push(project)).to eq(event)
1461
    end
1462
  end
1463 1464 1465 1466 1467 1468 1469 1470 1471

  describe '#authorized_groups' do
    let!(:user) { create(:user) }
    let!(:private_group) { create(:group) }

    before do
      private_group.add_user(user, Gitlab::Access::MASTER)
    end

1472
    subject { user.authorized_groups }
1473

1474
    it { is_expected.to eq([private_group]) }
1475 1476
  end

1477
  describe '#authorized_projects', truncate: true do
1478 1479 1480
    context 'with a minimum access level' do
      it 'includes projects for which the user is an owner' do
        user = create(:user)
1481
        project = create(:project, :private, namespace: user.namespace)
1482

D
Douwe Maan 已提交
1483 1484
        expect(user.authorized_projects(Gitlab::Access::REPORTER))
          .to contain_exactly(project)
1485
      end
1486

1487 1488
      it 'includes projects for which the user is a master' do
        user = create(:user)
1489
        project = create(:project, :private)
1490 1491

        project.team << [user, Gitlab::Access::MASTER]
1492

D
Douwe Maan 已提交
1493 1494
        expect(user.authorized_projects(Gitlab::Access::REPORTER))
          .to contain_exactly(project)
1495 1496
      end
    end
1497 1498 1499

    it "includes user's personal projects" do
      user    = create(:user)
1500
      project = create(:project, :private, namespace: user.namespace)
1501 1502 1503 1504 1505 1506 1507

      expect(user.authorized_projects).to include(project)
    end

    it "includes personal projects user has been given access to" do
      user1   = create(:user)
      user2   = create(:user)
1508
      project = create(:project, :private, namespace: user1.namespace)
1509 1510 1511 1512 1513 1514 1515 1516

      project.team << [user2, Gitlab::Access::DEVELOPER]

      expect(user2.authorized_projects).to include(project)
    end

    it "includes projects of groups user has been added to" do
      group   = create(:group)
1517
      project = create(:project, group: group)
1518 1519 1520 1521 1522 1523 1524 1525 1526
      user    = create(:user)

      group.add_developer(user)

      expect(user.authorized_projects).to include(project)
    end

    it "does not include projects of groups user has been removed from" do
      group   = create(:group)
1527
      project = create(:project, group: group)
1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538
      user    = create(:user)

      member = group.add_developer(user)
      expect(user.authorized_projects).to include(project)

      member.destroy
      expect(user.authorized_projects).not_to include(project)
    end

    it "includes projects shared with user's group" do
      user    = create(:user)
1539
      project = create(:project, :private)
1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550
      group   = create(:group)

      group.add_reporter(user)
      project.project_group_links.create(group: group)

      expect(user.authorized_projects).to include(project)
    end

    it "does not include destroyed projects user had access to" do
      user1   = create(:user)
      user2   = create(:user)
1551
      project = create(:project, :private, namespace: user1.namespace)
1552 1553 1554 1555 1556 1557 1558 1559 1560 1561

      project.team << [user2, Gitlab::Access::DEVELOPER]
      expect(user2.authorized_projects).to include(project)

      project.destroy
      expect(user2.authorized_projects).not_to include(project)
    end

    it "does not include projects of destroyed groups user had access to" do
      group   = create(:group)
1562
      project = create(:project, namespace: group)
1563 1564 1565 1566 1567 1568 1569 1570
      user    = create(:user)

      group.add_developer(user)
      expect(user.authorized_projects).to include(project)

      group.destroy
      expect(user.authorized_projects).not_to include(project)
    end
1571
  end
1572

1573 1574 1575 1576
  describe '#projects_where_can_admin_issues' do
    let(:user) { create(:user) }

    it 'includes projects for which the user access level is above or equal to reporter' do
1577 1578 1579
      reporter_project  = create(:project) { |p| p.add_reporter(user) }
      developer_project = create(:project) { |p| p.add_developer(user) }
      master_project    = create(:project) { |p| p.add_master(user) }
1580

1581
      expect(user.projects_where_can_admin_issues.to_a).to match_array([master_project, developer_project, reporter_project])
1582 1583 1584 1585 1586 1587
      expect(user.can?(:admin_issue, master_project)).to eq(true)
      expect(user.can?(:admin_issue, developer_project)).to eq(true)
      expect(user.can?(:admin_issue, reporter_project)).to eq(true)
    end

    it 'does not include for which the user access level is below reporter' do
1588 1589
      project = create(:project)
      guest_project = create(:project) { |p| p.add_guest(user) }
1590 1591 1592 1593 1594 1595 1596

      expect(user.projects_where_can_admin_issues.to_a).to be_empty
      expect(user.can?(:admin_issue, guest_project)).to eq(false)
      expect(user.can?(:admin_issue, project)).to eq(false)
    end

    it 'does not include archived projects' do
1597
      project = create(:project, :archived)
1598 1599 1600 1601 1602 1603

      expect(user.projects_where_can_admin_issues.to_a).to be_empty
      expect(user.can?(:admin_issue, project)).to eq(false)
    end

    it 'does not include projects for which issues are disabled' do
1604
      project = create(:project, :issues_disabled)
1605 1606 1607 1608 1609 1610

      expect(user.projects_where_can_admin_issues.to_a).to be_empty
      expect(user.can?(:admin_issue, project)).to eq(false)
    end
  end

1611 1612 1613 1614
  describe '#ci_authorized_runners' do
    let(:user) { create(:user) }
    let(:runner) { create(:ci_runner) }

1615 1616 1617
    before do
      project.runners << runner
    end
1618 1619

    context 'without any projects' do
1620
      let(:project) { create(:project) }
1621 1622

      it 'does not load' do
1623
        expect(user.ci_authorized_runners).to be_empty
1624 1625 1626 1627 1628
      end
    end

    context 'with personal projects runners' do
      let(:namespace) { create(:namespace, owner: user) }
1629
      let(:project) { create(:project, namespace: namespace) }
1630 1631

      it 'loads' do
1632
        expect(user.ci_authorized_runners).to contain_exactly(runner)
1633 1634 1635 1636
      end
    end

    shared_examples :member do
1637
      context 'when the user is a master' do
1638 1639 1640
        before do
          add_user(Gitlab::Access::MASTER)
        end
1641

1642 1643 1644
        it 'loads' do
          expect(user.ci_authorized_runners).to contain_exactly(runner)
        end
1645 1646
      end

1647
      context 'when the user is a developer' do
1648 1649 1650
        before do
          add_user(Gitlab::Access::DEVELOPER)
        end
1651

1652 1653 1654
        it 'does not load' do
          expect(user.ci_authorized_runners).to be_empty
        end
1655 1656 1657 1658 1659
      end
    end

    context 'with groups projects runners' do
      let(:group) { create(:group) }
1660
      let(:project) { create(:project, group: group) }
1661

L
Lin Jen-Shin 已提交
1662
      def add_user(access)
1663 1664 1665 1666 1667 1668 1669
        group.add_user(user, access)
      end

      it_behaves_like :member
    end

    context 'with other projects runners' do
1670
      let(:project) { create(:project) }
1671

L
Lin Jen-Shin 已提交
1672
      def add_user(access)
L
Lin Jen-Shin 已提交
1673
        project.team << [user, access]
1674 1675 1676 1677 1678 1679
      end

      it_behaves_like :member
    end
  end

1680
  describe '#projects_with_reporter_access_limited_to' do
1681 1682
    let(:project1) { create(:project) }
    let(:project2) { create(:project) }
1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702
    let(:user) { create(:user) }

    before do
      project1.team << [user, :reporter]
      project2.team << [user, :guest]
    end

    it 'returns the projects when using a single project ID' do
      projects = user.projects_with_reporter_access_limited_to(project1.id)

      expect(projects).to eq([project1])
    end

    it 'returns the projects when using an Array of project IDs' do
      projects = user.projects_with_reporter_access_limited_to([project1.id])

      expect(projects).to eq([project1])
    end

    it 'returns the projects when using an ActiveRecord relation' do
1703 1704
      projects = user
        .projects_with_reporter_access_limited_to(Project.select(:id))
1705 1706 1707 1708 1709 1710 1711 1712 1713 1714

      expect(projects).to eq([project1])
    end

    it 'does not return projects you do not have reporter access to' do
      projects = user.projects_with_reporter_access_limited_to(project2.id)

      expect(projects).to be_empty
    end
  end
1715

1716 1717
  describe '#all_expanded_groups' do
    # foo/bar would also match foo/barbaz instead of just foo/bar and foo/bar/baz
1718 1719
    let!(:user) { create(:user) }

1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735
    #                group
    #        _______ (foo) _______
    #       |                     |
    #       |                     |
    # nested_group_1        nested_group_2
    # (bar)                 (barbaz)
    #       |                     |
    #       |                     |
    # nested_group_1_1      nested_group_2_1
    # (baz)                 (baz)
    #
    let!(:group) { create :group }
    let!(:nested_group_1) { create :group, parent: group, name: 'bar' }
    let!(:nested_group_1_1) { create :group, parent: nested_group_1, name: 'baz' }
    let!(:nested_group_2) { create :group, parent: group, name: 'barbaz' }
    let!(:nested_group_2_1) { create :group, parent: nested_group_2, name: 'baz' }
1736

1737 1738 1739 1740 1741 1742
    subject { user.all_expanded_groups }

    context 'user is not a member of any group' do
      it 'returns an empty array' do
        is_expected.to eq([])
      end
1743 1744
    end

1745 1746 1747 1748 1749 1750 1751 1752
    context 'user is member of all groups' do
      before do
        group.add_owner(user)
        nested_group_1.add_owner(user)
        nested_group_1_1.add_owner(user)
        nested_group_2.add_owner(user)
        nested_group_2_1.add_owner(user)
      end
1753

1754 1755 1756 1757 1758 1759 1760 1761
      it 'returns all groups' do
        is_expected.to match_array [
          group,
          nested_group_1, nested_group_1_1,
          nested_group_2, nested_group_2_1
        ]
      end
    end
1762

1763
    context 'user is member of the top group' do
1764 1765 1766
      before do
        group.add_owner(user)
      end
1767

1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781
      if Group.supports_nested_groups?
        it 'returns all groups' do
          is_expected.to match_array [
            group,
            nested_group_1, nested_group_1_1,
            nested_group_2, nested_group_2_1
          ]
        end
      else
        it 'returns the top-level groups' do
          is_expected.to match_array [group]
        end
      end
    end
1782

1783
    context 'user is member of the first child (internal node), branch 1', :nested_groups do
1784 1785 1786
      before do
        nested_group_1.add_owner(user)
      end
1787

1788 1789 1790 1791 1792 1793 1794 1795 1796
      it 'returns the groups in the hierarchy' do
        is_expected.to match_array [
          group,
          nested_group_1, nested_group_1_1
        ]
      end
    end

    context 'user is member of the first child (internal node), branch 2', :nested_groups do
1797 1798 1799
      before do
        nested_group_2.add_owner(user)
      end
1800

1801 1802 1803 1804 1805 1806
      it 'returns the groups in the hierarchy' do
        is_expected.to match_array [
          group,
          nested_group_2, nested_group_2_1
        ]
      end
1807 1808
    end

1809
    context 'user is member of the last child (leaf node)', :nested_groups do
1810 1811 1812
      before do
        nested_group_1_1.add_owner(user)
      end
1813 1814 1815 1816 1817 1818 1819 1820

      it 'returns the groups in the hierarchy' do
        is_expected.to match_array [
          group,
          nested_group_1, nested_group_1_1
        ]
      end
    end
1821 1822
  end

1823
  describe '#refresh_authorized_projects', clean_gitlab_redis_shared_state: true do
1824 1825
    let(:project1) { create(:project) }
    let(:project2) { create(:project) }
1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844
    let(:user) { create(:user) }

    before do
      project1.team << [user, :reporter]
      project2.team << [user, :guest]

      user.project_authorizations.delete_all
      user.refresh_authorized_projects
    end

    it 'refreshes the list of authorized projects' do
      expect(user.project_authorizations.count).to eq(2)
    end

    it 'stores the correct access levels' do
      expect(user.project_authorizations.where(access_level: Gitlab::Access::GUEST).exists?).to eq(true)
      expect(user.project_authorizations.where(access_level: Gitlab::Access::REPORTER).exists?).to eq(true)
    end
  end
D
Douwe Maan 已提交
1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877

  describe '#access_level=' do
    let(:user) { build(:user) }

    it 'does nothing for an invalid access level' do
      user.access_level = :invalid_access_level

      expect(user.access_level).to eq(:regular)
      expect(user.admin).to be false
    end

    it "assigns the 'admin' access level" do
      user.access_level = :admin

      expect(user.access_level).to eq(:admin)
      expect(user.admin).to be true
    end

    it "doesn't clear existing access levels when an invalid access level is passed in" do
      user.access_level = :admin
      user.access_level = :invalid_access_level

      expect(user.access_level).to eq(:admin)
      expect(user.admin).to be true
    end

    it "accepts string values in addition to symbols" do
      user.access_level = 'admin'

      expect(user.access_level).to eq(:admin)
      expect(user.admin).to be true
    end
  end
1878

1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892
  describe '#full_private_access?' do
    it 'returns false for regular user' do
      user = build(:user)

      expect(user.full_private_access?).to be_falsy
    end

    it 'returns true for admin user' do
      user = build(:user, :admin)

      expect(user.full_private_access?).to be_truthy
    end
  end

1893 1894
  describe '.ghost' do
    it "creates a ghost user if one isn't already present" do
1895
      ghost = described_class.ghost
1896 1897 1898 1899 1900 1901 1902

      expect(ghost).to be_ghost
      expect(ghost).to be_persisted
    end

    it "does not create a second ghost user if one is already present" do
      expect do
1903 1904 1905 1906
        described_class.ghost
        described_class.ghost
      end.to change { described_class.count }.by(1)
      expect(described_class.ghost).to eq(described_class.ghost)
1907 1908 1909 1910 1911
    end

    context "when a regular user exists with the username 'ghost'" do
      it "creates a ghost user with a non-conflicting username" do
        create(:user, username: 'ghost')
1912
        ghost = described_class.ghost
1913 1914

        expect(ghost).to be_persisted
1915
        expect(ghost.username).to eq('ghost1')
1916 1917 1918 1919 1920 1921
      end
    end

    context "when a regular user exists with the email 'ghost@example.com'" do
      it "creates a ghost user with a non-conflicting email" do
        create(:user, email: 'ghost@example.com')
1922
        ghost = described_class.ghost
1923 1924

        expect(ghost).to be_persisted
1925
        expect(ghost.email).to eq('ghost1@example.com')
1926 1927
      end
    end
1928 1929 1930 1931 1932 1933 1934

    context 'when a domain whitelist is in place' do
      before do
        stub_application_setting(domain_whitelist: ['gitlab.com'])
      end

      it 'creates a ghost user' do
1935
        expect(described_class.ghost).to be_persisted
1936 1937
      end
    end
1938
  end
1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954

  describe '#update_two_factor_requirement' do
    let(:user) { create :user }

    context 'with 2FA requirement on groups' do
      let(:group1) { create :group, require_two_factor_authentication: true, two_factor_grace_period: 23 }
      let(:group2) { create :group, require_two_factor_authentication: true, two_factor_grace_period: 32 }

      before do
        group1.add_user(user, GroupMember::OWNER)
        group2.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'requires 2FA' do
1955
        expect(user.require_two_factor_authentication_from_group).to be true
1956 1957 1958 1959 1960 1961 1962
      end

      it 'uses the shortest grace period' do
        expect(user.two_factor_grace_period).to be 23
      end
    end

1963
    context 'with 2FA requirement on nested parent group', :nested_groups do
1964 1965 1966 1967 1968 1969 1970 1971 1972 1973
      let!(:group1) { create :group, require_two_factor_authentication: true }
      let!(:group1a) { create :group, require_two_factor_authentication: false, parent: group1 }

      before do
        group1a.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'requires 2FA' do
1974
        expect(user.require_two_factor_authentication_from_group).to be true
1975 1976 1977
      end
    end

1978
    context 'with 2FA requirement on nested child group', :nested_groups do
1979 1980 1981 1982 1983 1984 1985 1986 1987 1988
      let!(:group1) { create :group, require_two_factor_authentication: false }
      let!(:group1a) { create :group, require_two_factor_authentication: true, parent: group1 }

      before do
        group1.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'requires 2FA' do
1989
        expect(user.require_two_factor_authentication_from_group).to be true
1990 1991 1992
      end
    end

1993 1994 1995 1996 1997 1998 1999 2000 2001 2002
    context 'without 2FA requirement on groups' do
      let(:group) { create :group }

      before do
        group.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'does not require 2FA' do
2003
        expect(user.require_two_factor_authentication_from_group).to be false
2004 2005 2006 2007 2008 2009 2010
      end

      it 'falls back to the default grace period' do
        expect(user.two_factor_grace_period).to be 48
      end
    end
  end
J
James Lopez 已提交
2011 2012 2013

  context '.active' do
    before do
2014
      described_class.ghost
J
James Lopez 已提交
2015 2016 2017 2018 2019
      create(:user, name: 'user', state: 'active')
      create(:user, name: 'user', state: 'blocked')
    end

    it 'only counts active and non internal users' do
2020
      expect(described_class.active.count).to eq(1)
J
James Lopez 已提交
2021 2022
    end
  end
2023 2024 2025 2026 2027 2028 2029 2030

  describe 'preferred language' do
    it 'is English by default' do
      user = create(:user)

      expect(user.preferred_language).to eq('en')
    end
  end
2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058

  context '#invalidate_issue_cache_counts' do
    let(:user) { build_stubbed(:user) }

    it 'invalidates cache for issue counter' do
      cache_mock = double

      expect(cache_mock).to receive(:delete).with(['users', user.id, 'assigned_open_issues_count'])

      allow(Rails).to receive(:cache).and_return(cache_mock)

      user.invalidate_issue_cache_counts
    end
  end

  context '#invalidate_merge_request_cache_counts' do
    let(:user) { build_stubbed(:user) }

    it 'invalidates cache for Merge Request counter' do
      cache_mock = double

      expect(cache_mock).to receive(:delete).with(['users', user.id, 'assigned_open_merge_requests_count'])

      allow(Rails).to receive(:cache).and_return(cache_mock)

      user.invalidate_merge_request_cache_counts
    end
  end
2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080

  describe '#allow_password_authentication?' do
    context 'regular user' do
      let(:user) { build(:user) }

      it 'returns true when sign-in is enabled' do
        expect(user.allow_password_authentication?).to be_truthy
      end

      it 'returns false when sign-in is disabled' do
        stub_application_setting(password_authentication_enabled: false)

        expect(user.allow_password_authentication?).to be_falsey
      end
    end

    it 'returns false for ldap user' do
      user = create(:omniauth_user, provider: 'ldapmain')

      expect(user.allow_password_authentication?).to be_falsey
    end
  end
2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104

  describe '#personal_projects_count' do
    it 'returns the number of personal projects using a single query' do
      user = build(:user)
      projects = double(:projects, count: 1)

      expect(user).to receive(:personal_projects).once.and_return(projects)

      2.times do
        expect(user.personal_projects_count).to eq(1)
      end
    end
  end

  describe '#projects_limit_left' do
    it 'returns the number of projects that can be created by the user' do
      user = build(:user)

      allow(user).to receive(:projects_limit).and_return(10)
      allow(user).to receive(:personal_projects_count).and_return(5)

      expect(user.projects_limit_left).to eq(5)
    end
  end
2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143

  describe '#ensure_namespace_correct' do
    context 'for a new user' do
      let(:user) { build(:user) }

      it 'creates the namespace' do
        expect(user.namespace).to be_nil
        user.save!
        expect(user.namespace).not_to be_nil
      end
    end

    context 'for an existing user' do
      let(:username) { 'foo' }
      let(:user) { create(:user, username: username) }

      context 'when the user is updated' do
        context 'when the username is changed' do
          let(:new_username) { 'bar' }

          it 'changes the namespace (just to compare to when username is not changed)' do
            expect do
              user.update_attributes!(username: new_username)
            end.to change { user.namespace.updated_at }
          end

          it 'updates the namespace name' do
            user.update_attributes!(username: new_username)
            expect(user.namespace.name).to eq(new_username)
          end

          it 'updates the namespace path' do
            user.update_attributes!(username: new_username)
            expect(user.namespace.path).to eq(new_username)
          end

          context 'when there is a validation error (namespace name taken) while updating namespace' do
            let!(:conflicting_namespace) { create(:group, name: new_username, path: 'quz') }

2144
            it 'causes the user save to fail' do
2145 2146 2147
              expect(user.update_attributes(username: new_username)).to be_falsey
              expect(user.namespace.errors.messages[:name].first).to eq('has already been taken')
            end
2148 2149 2150 2151 2152

            it 'adds the namespace errors to the user' do
              user.update_attributes(username: new_username)
              expect(user.errors.full_messages.first).to eq('Namespace name has already been taken')
            end
2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165
          end
        end

        context 'when the username is not changed' do
          it 'does not change the namespace' do
            expect do
              user.update_attributes!(email: 'asdf@asdf.com')
            end.not_to change { user.namespace.updated_at }
          end
        end
      end
    end
  end
A
Alexis Reigel 已提交
2166

2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231
  describe '#sync_attribute?' do
    let(:user) { described_class.new }

    context 'oauth user' do
      it 'returns true if name can be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(name location))
        expect(user.sync_attribute?(:name)).to be_truthy
      end

      it 'returns true if email can be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(name email))
        expect(user.sync_attribute?(:email)).to be_truthy
      end

      it 'returns true if location can be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(location email))
        expect(user.sync_attribute?(:email)).to be_truthy
      end

      it 'returns false if name can not be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(location email))
        expect(user.sync_attribute?(:name)).to be_falsey
      end

      it 'returns false if email can not be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(location email))
        expect(user.sync_attribute?(:name)).to be_falsey
      end

      it 'returns false if location can not be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(location email))
        expect(user.sync_attribute?(:name)).to be_falsey
      end

      it 'returns true for all syncable attributes if all syncable attributes can be synced' do
        stub_omniauth_setting(sync_profile_attributes: true)
        expect(user.sync_attribute?(:name)).to be_truthy
        expect(user.sync_attribute?(:email)).to be_truthy
        expect(user.sync_attribute?(:location)).to be_truthy
      end

      it 'returns false for all syncable attributes but email if no syncable attributes are declared' do
        expect(user.sync_attribute?(:name)).to be_falsey
        expect(user.sync_attribute?(:email)).to be_truthy
        expect(user.sync_attribute?(:location)).to be_falsey
      end
    end

    context 'ldap user' do
      it 'returns true for email if ldap user' do
        allow(user).to receive(:ldap_user?).and_return(true)
        expect(user.sync_attribute?(:name)).to be_falsey
        expect(user.sync_attribute?(:email)).to be_truthy
        expect(user.sync_attribute?(:location)).to be_falsey
      end

      it 'returns true for email and location if ldap user and location declared as syncable' do
        allow(user).to receive(:ldap_user?).and_return(true)
        stub_omniauth_setting(sync_profile_attributes: %w(location))
        expect(user.sync_attribute?(:name)).to be_falsey
        expect(user.sync_attribute?(:email)).to be_truthy
        expect(user.sync_attribute?(:location)).to be_truthy
      end
    end
  end
G
gitlabhq 已提交
2232
end