user_spec.rb 73.5 KB
Newer Older
G
gitlabhq 已提交
1 2
require 'spec_helper'

3
describe User do
4
  include Gitlab::CurrentSettings
B
Bob Van Landuyt 已提交
5
  include ProjectForksHelper
6

7 8 9 10 11 12 13 14 15 16
  describe 'modules' do
    subject { described_class }

    it { is_expected.to include_module(Gitlab::ConfigHelper) }
    it { is_expected.to include_module(Gitlab::CurrentSettings) }
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
    it { is_expected.to include_module(TokenAuthenticatable) }
  end

17 18 19 20
  describe 'delegations' do
    it { is_expected.to delegate_method(:path).to(:namespace).with_prefix }
  end

21
  describe 'associations' do
22
    it { is_expected.to have_one(:namespace) }
23
    it { is_expected.to have_many(:snippets).dependent(:destroy) }
24 25 26
    it { is_expected.to have_many(:project_members).dependent(:destroy) }
    it { is_expected.to have_many(:groups) }
    it { is_expected.to have_many(:keys).dependent(:destroy) }
27
    it { is_expected.to have_many(:deploy_keys).dependent(:destroy) }
28
    it { is_expected.to have_many(:events).dependent(:destroy) }
29
    it { is_expected.to have_many(:recent_events).class_name('Event') }
30
    it { is_expected.to have_many(:issues).dependent(:destroy) }
31 32 33
    it { is_expected.to have_many(:notes).dependent(:destroy) }
    it { is_expected.to have_many(:merge_requests).dependent(:destroy) }
    it { is_expected.to have_many(:identities).dependent(:destroy) }
34
    it { is_expected.to have_many(:spam_logs).dependent(:destroy) }
35
    it { is_expected.to have_many(:todos).dependent(:destroy) }
36
    it { is_expected.to have_many(:award_emoji).dependent(:destroy) }
K
Kamil Trzcinski 已提交
37
    it { is_expected.to have_many(:triggers).dependent(:destroy) }
38 39
    it { is_expected.to have_many(:builds).dependent(:nullify) }
    it { is_expected.to have_many(:pipelines).dependent(:nullify) }
K
Kamil Trzcinski 已提交
40
    it { is_expected.to have_many(:chat_names).dependent(:destroy) }
41
    it { is_expected.to have_many(:uploads).dependent(:destroy) }
42
    it { is_expected.to have_many(:reported_abuse_reports).dependent(:destroy).class_name('AbuseReport') }
43
    it { is_expected.to have_many(:custom_attributes).class_name('UserCustomAttribute') }
44

45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70
    describe "#abuse_report" do
      let(:current_user) { create(:user) }
      let(:other_user) { create(:user) }

      it { is_expected.to have_one(:abuse_report) }

      it "refers to the abuse report whose user_id is the current user" do
        abuse_report = create(:abuse_report, reporter: other_user, user: current_user)

        expect(current_user.abuse_report).to eq(abuse_report)
      end

      it "does not refer to the abuse report whose reporter_id is the current user" do
        create(:abuse_report, reporter: current_user, user: other_user)

        expect(current_user.abuse_report).to be_nil
      end

      it "does not update the user_id of an abuse report when the user is updated" do
        abuse_report = create(:abuse_report, reporter: current_user, user: other_user)

        current_user.block

        expect(abuse_report.reload.user).to eq(other_user)
      end
    end
71 72 73 74

    describe '#group_members' do
      it 'does not include group memberships for which user is a requester' do
        user = create(:user)
75
        group = create(:group, :public, :access_requestable)
76 77 78 79 80 81 82 83 84
        group.request_access(user)

        expect(user.group_members).to be_empty
      end
    end

    describe '#project_members' do
      it 'does not include project memberships for which user is a requester' do
        user = create(:user)
85
        project = create(:project, :public, :access_requestable)
86 87 88 89 90
        project.request_access(user)

        expect(user.project_members).to be_empty
      end
    end
91 92 93
  end

  describe 'validations' do
R
Robert Speicher 已提交
94 95 96 97 98 99 100 101 102 103 104 105
    describe 'username' do
      it 'validates presence' do
        expect(subject).to validate_presence_of(:username)
      end

      it 'rejects blacklisted names' do
        user = build(:user, username: 'dashboard')

        expect(user).not_to be_valid
        expect(user.errors.values).to eq [['dashboard is a reserved name']]
      end

106 107 108 109 110 111 112 113 114 115 116 117
      it 'allows child names' do
        user = build(:user, username: 'avatar')

        expect(user).to be_valid
      end

      it 'allows wildcard names' do
        user = build(:user, username: 'blob')

        expect(user).to be_valid
      end

R
Robert Speicher 已提交
118
      it 'validates uniqueness' do
119 120 121
        user = build(:user)

        expect(user).to validate_uniqueness_of(:username).case_insensitive
R
Robert Speicher 已提交
122
      end
123 124 125 126 127 128 129 130 131 132 133

      context 'when username is changed' do
        let(:user) { build_stubbed(:user, username: 'old_path', namespace: build_stubbed(:namespace)) }

        it 'validates move_dir is allowed for the namespace' do
          expect(user.namespace).to receive(:any_project_has_container_registry_tags?).and_return(true)
          user.username = 'new_path'
          expect(user).to be_invalid
          expect(user.errors.messages[:username].first).to match('cannot be changed if a personal project has container registry tags')
        end
      end
R
Robert Speicher 已提交
134 135
    end

136 137 138 139
    it { is_expected.to validate_presence_of(:projects_limit) }
    it { is_expected.to validate_numericality_of(:projects_limit) }
    it { is_expected.to allow_value(0).for(:projects_limit) }
    it { is_expected.not_to allow_value(-1).for(:projects_limit) }
140
    it { is_expected.not_to allow_value(Gitlab::Database::MAX_INT_VALUE + 1).for(:projects_limit) }
141

142
    it { is_expected.to validate_length_of(:bio).is_at_most(255) }
143

144 145 146
    it_behaves_like 'an object with email-formated attributes', :email do
      subject { build(:user) }
    end
147

148 149 150
    it_behaves_like 'an object with email-formated attributes', :public_email, :notification_email do
      subject { build(:user).tap { |user| user.emails << build(:email, email: email_value) } }
    end
151

152
    describe 'email' do
153
      context 'when no signup domains whitelisted' do
154
        before do
155
          allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return([])
156
        end
157

158 159 160 161 162 163
        it 'accepts any email' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end
      end

164
      context 'when a signup domain is whitelisted and subdomains are allowed' do
165
        before do
166
          allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['example.com', '*.example.com'])
167
        end
168

169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184
        it 'accepts info@example.com' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end

        it 'accepts info@test.example.com' do
          user = build(:user, email: "info@test.example.com")
          expect(user).to be_valid
        end

        it 'rejects example@test.com' do
          user = build(:user, email: "example@test.com")
          expect(user).to be_invalid
        end
      end

185
      context 'when a signup domain is whitelisted and subdomains are not allowed' do
186
        before do
187
          allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['example.com'])
188
        end
189 190 191 192 193 194 195 196 197 198 199 200 201 202 203

        it 'accepts info@example.com' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end

        it 'rejects info@test.example.com' do
          user = build(:user, email: "info@test.example.com")
          expect(user).to be_invalid
        end

        it 'rejects example@test.com' do
          user = build(:user, email: "example@test.com")
          expect(user).to be_invalid
        end
204 205 206 207 208

        it 'accepts example@test.com when added by another user' do
          user = build(:user, email: "example@test.com", created_by_id: 1)
          expect(user).to be_valid
        end
209
      end
210

211 212 213 214 215 216
      context 'domain blacklist' do
        before do
          allow_any_instance_of(ApplicationSetting).to receive(:domain_blacklist_enabled?).and_return(true)
          allow_any_instance_of(ApplicationSetting).to receive(:domain_blacklist).and_return(['example.com'])
        end

217
        context 'when a signup domain is blacklisted' do
218 219 220 221 222 223 224 225 226
          it 'accepts info@test.com' do
            user = build(:user, email: 'info@test.com')
            expect(user).to be_valid
          end

          it 'rejects info@example.com' do
            user = build(:user, email: 'info@example.com')
            expect(user).not_to be_valid
          end
227 228 229 230 231

          it 'accepts info@example.com when added by another user' do
            user = build(:user, email: 'info@example.com', created_by_id: 1)
            expect(user).to be_valid
          end
232 233
        end

234
        context 'when a signup domain is blacklisted but a wildcard subdomain is allowed' do
235 236
          before do
            allow_any_instance_of(ApplicationSetting).to receive(:domain_blacklist).and_return(['test.example.com'])
237
            allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['*.example.com'])
238 239
          end

240
          it 'gives priority to whitelist and allow info@test.example.com' do
241 242 243 244 245 246 247
            user = build(:user, email: 'info@test.example.com')
            expect(user).to be_valid
          end
        end

        context 'with both lists containing a domain' do
          before do
248
            allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['test.com'])
249 250 251 252 253 254 255 256 257 258 259 260 261 262
          end

          it 'accepts info@test.com' do
            user = build(:user, email: 'info@test.com')
            expect(user).to be_valid
          end

          it 'rejects info@example.com' do
            user = build(:user, email: 'info@example.com')
            expect(user).not_to be_valid
          end
        end
      end

263 264 265 266 267 268
      context 'owns_notification_email' do
        it 'accepts temp_oauth_email emails' do
          user = build(:user, email: "temp-email-for-oauth@example.com")
          expect(user).to be_valid
        end
      end
269
    end
270 271 272 273 274 275 276
  end

  describe "scopes" do
    describe ".with_two_factor" do
      it "returns users with 2fa enabled via OTP" do
        user_with_2fa = create(:user, :two_factor_via_otp)
        user_without_2fa = create(:user)
277
        users_with_two_factor = described_class.with_two_factor.pluck(:id)
278 279 280 281 282 283 284 285

        expect(users_with_two_factor).to include(user_with_2fa.id)
        expect(users_with_two_factor).not_to include(user_without_2fa.id)
      end

      it "returns users with 2fa enabled via U2F" do
        user_with_2fa = create(:user, :two_factor_via_u2f)
        user_without_2fa = create(:user)
286
        users_with_two_factor = described_class.with_two_factor.pluck(:id)
287 288 289 290 291 292 293 294

        expect(users_with_two_factor).to include(user_with_2fa.id)
        expect(users_with_two_factor).not_to include(user_without_2fa.id)
      end

      it "returns users with 2fa enabled via OTP and U2F" do
        user_with_2fa = create(:user, :two_factor_via_otp, :two_factor_via_u2f)
        user_without_2fa = create(:user)
295
        users_with_two_factor = described_class.with_two_factor.pluck(:id)
296 297 298 299 300 301 302 303 304 305

        expect(users_with_two_factor).to eq([user_with_2fa.id])
        expect(users_with_two_factor).not_to include(user_without_2fa.id)
      end
    end

    describe ".without_two_factor" do
      it "excludes users with 2fa enabled via OTP" do
        user_with_2fa = create(:user, :two_factor_via_otp)
        user_without_2fa = create(:user)
306
        users_without_two_factor = described_class.without_two_factor.pluck(:id)
307 308 309 310 311 312 313 314

        expect(users_without_two_factor).to include(user_without_2fa.id)
        expect(users_without_two_factor).not_to include(user_with_2fa.id)
      end

      it "excludes users with 2fa enabled via U2F" do
        user_with_2fa = create(:user, :two_factor_via_u2f)
        user_without_2fa = create(:user)
315
        users_without_two_factor = described_class.without_two_factor.pluck(:id)
316 317 318 319 320 321 322 323

        expect(users_without_two_factor).to include(user_without_2fa.id)
        expect(users_without_two_factor).not_to include(user_with_2fa.id)
      end

      it "excludes users with 2fa enabled via OTP and U2F" do
        user_with_2fa = create(:user, :two_factor_via_otp, :two_factor_via_u2f)
        user_without_2fa = create(:user)
324
        users_without_two_factor = described_class.without_two_factor.pluck(:id)
325 326 327 328 329

        expect(users_without_two_factor).to include(user_without_2fa.id)
        expect(users_without_two_factor).not_to include(user_with_2fa.id)
      end
    end
V
Valery Sizov 已提交
330 331 332 333 334 335 336 337 338 339

    describe '.todo_authors' do
      it 'filters users' do
        create :user
        user_2 = create :user
        user_3 = create :user
        current_user = create :user
        create(:todo, user: current_user, author: user_2, state: :done)
        create(:todo, user: current_user, author: user_3, state: :pending)

340 341
        expect(described_class.todo_authors(current_user.id, 'pending')).to eq [user_3]
        expect(described_class.todo_authors(current_user.id, 'done')).to eq [user_2]
V
Valery Sizov 已提交
342 343
      end
    end
G
gitlabhq 已提交
344 345 346
  end

  describe "Respond to" do
B
blackst0ne 已提交
347
    it { is_expected.to respond_to(:admin?) }
348 349
    it { is_expected.to respond_to(:name) }
    it { is_expected.to respond_to(:private_token) }
Z
Zeger-Jan van de Weg 已提交
350 351 352 353 354 355 356 357 358 359 360 361 362 363
    it { is_expected.to respond_to(:external?) }
  end

  describe 'before save hook' do
    context 'when saving an external user' do
      let(:user)          { create(:user) }
      let(:external_user) { create(:user, external: true) }

      it "sets other properties aswell" do
        expect(external_user.can_create_team).to be_falsey
        expect(external_user.can_create_group).to be_falsey
        expect(external_user.projects_limit).to be 0
      end
    end
364

365 366
    describe '#check_for_verified_email' do
      let(:user)      { create(:user) }
367 368
      let(:secondary) { create(:email, :confirmed, email: 'secondary@example.com', user: user) }

369 370 371 372 373 374 375 376
      it 'allows a verfied secondary email to be used as the primary without needing reconfirmation' do
        user.update_attributes!(email: secondary.email)
        user.reload
        expect(user.email).to eq secondary.email
        expect(user.unconfirmed_email).to eq nil
        expect(user.confirmed?).to be_truthy
      end
    end
G
gitlabhq 已提交
377 378
  end

379
  describe 'after commit hook' do
380 381 382 383 384 385 386 387 388 389 390 391 392
    describe '.update_invalid_gpg_signatures' do
      let(:user) do
        create(:user, email: 'tula.torphy@abshire.ca').tap do |user|
          user.skip_reconfirmation!
        end
      end

      it 'does nothing when the name is updated' do
        expect(user).not_to receive(:update_invalid_gpg_signatures)
        user.update_attributes!(name: 'Bette')
      end

      it 'synchronizes the gpg keys when the email is updated' do
393
        expect(user).to receive(:update_invalid_gpg_signatures).at_most(:twice)
394 395 396
        user.update_attributes!(email: 'shawnee.ritchie@denesik.com')
      end
    end
397 398 399 400 401 402 403 404 405 406 407 408

    describe '#update_emails_with_primary_email' do
      before do
        @user = create(:user, email: 'primary@example.com').tap do |user|
          user.skip_reconfirmation!
        end
        @secondary = create :email, email: 'secondary@example.com', user: @user
        @user.reload
      end

      it 'gets called when email updated' do
        expect(@user).to receive(:update_emails_with_primary_email)
409

410 411 412
        @user.update_attributes!(email: 'new_primary@example.com')
      end

413
      it 'adds old primary to secondary emails when secondary is a new email ' do
414 415
        @user.update_attributes!(email: 'new_primary@example.com')
        @user.reload
416

417 418
        expect(@user.emails.count).to eq 2
        expect(@user.emails.pluck(:email)).to match_array([@secondary.email, 'primary@example.com'])
419 420 421 422 423
      end

      it 'adds old primary to secondary emails if secondary is becoming a primary' do
        @user.update_attributes!(email: @secondary.email)
        @user.reload
424

425 426 427 428 429 430 431
        expect(@user.emails.count).to eq 1
        expect(@user.emails.first.email).to eq 'primary@example.com'
      end

      it 'transfers old confirmation values into new secondary' do
        @user.update_attributes!(email: @secondary.email)
        @user.reload
432

433 434 435 436
        expect(@user.emails.count).to eq 1
        expect(@user.emails.first.confirmed_at).not_to eq nil
      end
    end
437 438
  end

439
  describe '#update_tracked_fields!', :clean_gitlab_redis_shared_state do
440 441 442 443 444 445 446 447 448 449 450 451 452 453
    let(:request) { OpenStruct.new(remote_ip: "127.0.0.1") }
    let(:user) { create(:user) }

    it 'writes trackable attributes' do
      expect do
        user.update_tracked_fields!(request)
      end.to change { user.reload.current_sign_in_at }
    end

    it 'does not write trackable attributes when called a second time within the hour' do
      user.update_tracked_fields!(request)

      expect do
        user.update_tracked_fields!(request)
454 455 456 457 458 459 460 461 462 463 464
      end.not_to change { user.reload.current_sign_in_at }
    end

    it 'writes trackable attributes for a different user' do
      user2 = create(:user)

      user.update_tracked_fields!(request)

      expect do
        user2.update_tracked_fields!(request)
      end.to change { user2.reload.current_sign_in_at }
465 466 467
    end
  end

468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495
  shared_context 'user keys' do
    let(:user) { create(:user) }
    let!(:key) { create(:key, user: user) }
    let!(:deploy_key) { create(:deploy_key, user: user) }
  end

  describe '#keys' do
    include_context 'user keys'

    context 'with key and deploy key stored' do
      it 'returns stored key, but not deploy_key' do
        expect(user.keys).to include key
        expect(user.keys).not_to include deploy_key
      end
    end
  end

  describe '#deploy_keys' do
    include_context 'user keys'

    context 'with key and deploy key stored' do
      it 'returns stored deploy key, but not normal key' do
        expect(user.deploy_keys).to include deploy_key
        expect(user.deploy_keys).not_to include key
      end
    end
  end

496
  describe '#confirm' do
497 498 499
    before do
      allow_any_instance_of(ApplicationSetting).to receive(:send_user_confirmation_email).and_return(true)
    end
500

501 502 503 504 505 506 507
    let(:user) { create(:user, confirmed_at: nil, unconfirmed_email: 'test@gitlab.com') }

    it 'returns unconfirmed' do
      expect(user.confirmed?).to be_falsey
    end

    it 'confirms a user' do
508
      user.confirm
509 510 511 512
      expect(user.confirmed?).to be_truthy
    end
  end

513 514 515 516 517 518 519 520
  describe '#to_reference' do
    let(:user) { create(:user) }

    it 'returns a String reference to the object' do
      expect(user.to_reference).to eq "@#{user.username}"
    end
  end

521
  describe '#generate_password' do
522
    it "does not generate password by default" do
523
      user = create(:user, password: 'abcdefghe')
524

525
      expect(user.password).to eq('abcdefghe')
526
    end
527 528
  end

529
  describe 'authentication token' do
530
    it "has authentication token" do
531
      user = create(:user)
532

533
      expect(user.authentication_token).not_to be_blank
534
    end
N
Nihad Abbasov 已提交
535
  end
536

537 538 539
  describe 'ensure incoming email token' do
    it 'has incoming email token' do
      user = create(:user)
540

541 542 543 544
      expect(user.incoming_email_token).not_to be_blank
    end
  end

545 546 547 548 549 550 551 552 553 554 555
  describe '#ensure_user_rights_and_limits' do
    describe 'with external user' do
      let(:user) { create(:user, external: true) }

      it 'receives callback when external changes' do
        expect(user).to receive(:ensure_user_rights_and_limits)

        user.update_attributes(external: false)
      end

      it 'ensures correct rights and limits for user' do
T
Tiago Botelho 已提交
556 557
        stub_config_setting(default_can_create_group: true)

558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578
        expect { user.update_attributes(external: false) }.to change { user.can_create_group }.to(true)
          .and change { user.projects_limit }.to(current_application_settings.default_projects_limit)
      end
    end

    describe 'without external user' do
      let(:user) { create(:user, external: false) }

      it 'receives callback when external changes' do
        expect(user).to receive(:ensure_user_rights_and_limits)

        user.update_attributes(external: true)
      end

      it 'ensures correct rights and limits for user' do
        expect { user.update_attributes(external: true) }.to change { user.can_create_group }.to(false)
          .and change { user.projects_limit }.to(0)
      end
    end
  end

579
  describe 'rss token' do
A
Alexis Reigel 已提交
580 581 582
    it 'ensures an rss token on read' do
      user = create(:user, rss_token: nil)
      rss_token = user.rss_token
583

A
Alexis Reigel 已提交
584 585
      expect(rss_token).not_to be_blank
      expect(user.reload.rss_token).to eq rss_token
586 587 588
    end
  end

589
  describe '#recently_sent_password_reset?' do
590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608
    it 'is false when reset_password_sent_at is nil' do
      user = build_stubbed(:user, reset_password_sent_at: nil)

      expect(user.recently_sent_password_reset?).to eq false
    end

    it 'is false when sent more than one minute ago' do
      user = build_stubbed(:user, reset_password_sent_at: 5.minutes.ago)

      expect(user.recently_sent_password_reset?).to eq false
    end

    it 'is true when sent less than one minute ago' do
      user = build_stubbed(:user, reset_password_sent_at: Time.now)

      expect(user.recently_sent_password_reset?).to eq true
    end
  end

R
Robert Speicher 已提交
609 610 611 612 613 614 615
  describe '#disable_two_factor!' do
    it 'clears all 2FA-related fields' do
      user = create(:user, :two_factor)

      expect(user).to be_two_factor_enabled
      expect(user.encrypted_otp_secret).not_to be_nil
      expect(user.otp_backup_codes).not_to be_nil
616
      expect(user.otp_grace_period_started_at).not_to be_nil
R
Robert Speicher 已提交
617 618 619 620 621 622 623 624

      user.disable_two_factor!

      expect(user).not_to be_two_factor_enabled
      expect(user.encrypted_otp_secret).to be_nil
      expect(user.encrypted_otp_secret_iv).to be_nil
      expect(user.encrypted_otp_secret_salt).to be_nil
      expect(user.otp_backup_codes).to be_nil
625
      expect(user.otp_grace_period_started_at).to be_nil
R
Robert Speicher 已提交
626 627 628
    end
  end

629 630
  describe 'projects' do
    before do
631
      @user = create(:user)
632

633 634
      @project = create(:project, namespace: @user.namespace)
      @project_2 = create(:project, group: create(:group)) do |project|
635 636
        project.add_master(@user)
      end
637
      @project_3 = create(:project, group: create(:group)) do |project|
638 639
        project.add_developer(@user)
      end
640 641
    end

642 643 644 645 646 647 648 649 650
    it { expect(@user.authorized_projects).to include(@project) }
    it { expect(@user.authorized_projects).to include(@project_2) }
    it { expect(@user.authorized_projects).to include(@project_3) }
    it { expect(@user.owned_projects).to include(@project) }
    it { expect(@user.owned_projects).not_to include(@project_2) }
    it { expect(@user.owned_projects).not_to include(@project_3) }
    it { expect(@user.personal_projects).to include(@project) }
    it { expect(@user.personal_projects).not_to include(@project_2) }
    it { expect(@user.personal_projects).not_to include(@project_3) }
651 652 653 654 655
  end

  describe 'groups' do
    before do
      @user = create :user
656 657
      @group = create :group
      @group.add_owner(@user)
658 659
    end

660 661 662
    it { expect(@user.several_namespaces?).to be_truthy }
    it { expect(@user.authorized_groups).to eq([@group]) }
    it { expect(@user.owned_groups).to eq([@group]) }
663
    it { expect(@user.namespaces).to match_array([@user.namespace, @group]) }
664 665
  end

666 667 668 669
  describe 'group multiple owners' do
    before do
      @user = create :user
      @user2 = create :user
670 671
      @group = create :group
      @group.add_owner(@user)
672

673
      @group.add_user(@user2, GroupMember::OWNER)
674 675
    end

676
    it { expect(@user2.several_namespaces?).to be_truthy }
677 678
  end

679 680 681
  describe 'namespaced' do
    before do
      @user = create :user
682
      @project = create(:project, namespace: @user.namespace)
683 684
    end

685
    it { expect(@user.several_namespaces?).to be_falsey }
686
    it { expect(@user.namespaces).to eq([@user.namespace]) }
687 688 689 690 691
  end

  describe 'blocking user' do
    let(:user) { create(:user, name: 'John Smith') }

692
    it "blocks user" do
693
      user.block
694

695
      expect(user.blocked?).to be_truthy
696 697 698
    end
  end

699 700 701 702
  describe '.filter' do
    let(:user) { double }

    it 'filters by active users by default' do
703
      expect(described_class).to receive(:active).and_return([user])
704

705
      expect(described_class.filter(nil)).to include user
706 707
    end

708
    it 'filters by admins' do
709
      expect(described_class).to receive(:admins).and_return([user])
710

711
      expect(described_class.filter('admins')).to include user
712 713
    end

714
    it 'filters by blocked' do
715
      expect(described_class).to receive(:blocked).and_return([user])
716

717
      expect(described_class.filter('blocked')).to include user
718 719 720
    end

    it 'filters by two_factor_disabled' do
721
      expect(described_class).to receive(:without_two_factor).and_return([user])
722

723
      expect(described_class.filter('two_factor_disabled')).to include user
724 725 726
    end

    it 'filters by two_factor_enabled' do
727
      expect(described_class).to receive(:with_two_factor).and_return([user])
728

729
      expect(described_class.filter('two_factor_enabled')).to include user
730 731 732
    end

    it 'filters by wop' do
733
      expect(described_class).to receive(:without_projects).and_return([user])
734

735
      expect(described_class.filter('wop')).to include user
736
    end
737 738
  end

B
Ben Bodenmiller 已提交
739
  describe '.without_projects' do
740
    let!(:project) { create(:project, :public, :access_requestable) }
B
Ben Bodenmiller 已提交
741 742 743 744 745 746 747 748 749 750 751 752 753 754 755
    let!(:user) { create(:user) }
    let!(:user_without_project) { create(:user) }
    let!(:user_without_project2) { create(:user) }

    before do
      # add user to project
      project.team << [user, :master]

      # create invite to projet
      create(:project_member, :developer, project: project, invite_token: '1234', invite_email: 'inviteduser1@example.com')

      # create request to join project
      project.request_access(user_without_project2)
    end

756 757 758
    it { expect(described_class.without_projects).not_to include user }
    it { expect(described_class.without_projects).to include user_without_project }
    it { expect(described_class.without_projects).to include user_without_project2 }
B
Ben Bodenmiller 已提交
759 760
  end

761 762 763
  describe 'user creation' do
    describe 'normal user' do
      let(:user) { create(:user, name: 'John Smith') }
D
Dmitriy Zaporozhets 已提交
764

B
blackst0ne 已提交
765
      it { expect(user.admin?).to be_falsey }
766 767 768 769
      it { expect(user.require_ssh_key?).to be_truthy }
      it { expect(user.can_create_group?).to be_truthy }
      it { expect(user.can_create_project?).to be_truthy }
      it { expect(user.first_name).to eq('John') }
770
      it { expect(user.external).to be_falsey }
771
    end
772

D
Dmitriy Zaporozhets 已提交
773
    describe 'with defaults' do
774
      let(:user) { described_class.new }
D
Dmitriy Zaporozhets 已提交
775

776
      it "applies defaults to user" do
777 778
        expect(user.projects_limit).to eq(Gitlab.config.gitlab.default_projects_limit)
        expect(user.can_create_group).to eq(Gitlab.config.gitlab.default_can_create_group)
779
        expect(user.theme_id).to eq(Gitlab.config.gitlab.default_theme)
Z
Zeger-Jan van de Weg 已提交
780
        expect(user.external).to be_falsey
781 782 783
      end
    end

D
Dmitriy Zaporozhets 已提交
784
    describe 'with default overrides' do
785
      let(:user) { described_class.new(projects_limit: 123, can_create_group: false, can_create_team: true) }
D
Dmitriy Zaporozhets 已提交
786

787
      it "applies defaults to user" do
788 789
        expect(user.projects_limit).to eq(123)
        expect(user.can_create_group).to be_falsey
790
        expect(user.theme_id).to eq(1)
791
      end
792
    end
793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812

    context 'when current_application_settings.user_default_external is true' do
      before do
        stub_application_setting(user_default_external: true)
      end

      it "creates external user by default" do
        user = build(:user)

        expect(user.external).to be_truthy
      end

      describe 'with default overrides' do
        it "creates a non-external user" do
          user = build(:user, external: false)

          expect(user.external).to be_falsey
        end
      end
    end
813

814 815 816 817
    describe '#require_ssh_key?' do
      protocol_and_expectation = {
        'http' => false,
        'ssh' => true,
818
        '' => true
819 820 821 822 823 824 825 826 827
      }

      protocol_and_expectation.each do |protocol, expected|
        it "has correct require_ssh_key?" do
          stub_application_setting(enabled_git_access_protocol: protocol)
          user = build(:user)

          expect(user.require_ssh_key?).to eq(expected)
        end
828 829
      end
    end
830
  end
831

832
  describe '.find_by_any_email' do
833 834 835
    it 'finds by primary email' do
      user = create(:user, email: 'foo@example.com')

836
      expect(described_class.find_by_any_email(user.email)).to eq user
837 838 839 840 841 842
    end

    it 'finds by secondary email' do
      email = create(:email, email: 'foo@example.com')
      user  = email.user

843
      expect(described_class.find_by_any_email(email.email)).to eq user
844 845 846
    end

    it 'returns nil when nothing found' do
847
      expect(described_class.find_by_any_email('')).to be_nil
848 849 850
    end
  end

851
  describe '.search' do
852 853
    let!(:user) { create(:user, name: 'user', username: 'usern', email: 'email@gmail.com') }
    let!(:user2) { create(:user, name: 'user name', username: 'username', email: 'someemail@gmail.com') }
854
    let!(:user3) { create(:user, name: 'us', username: 'se', email: 'foo@gmail.com') }
855

856 857 858 859
    describe 'name matching' do
      it 'returns users with a matching name with exact match first' do
        expect(described_class.search(user.name)).to eq([user, user2])
      end
860

861
      it 'returns users with a partially matching name' do
862
        expect(described_class.search(user.name[0..2])).to eq([user, user2])
863
      end
864

865 866 867
      it 'returns users with a matching name regardless of the casing' do
        expect(described_class.search(user2.name.upcase)).to eq([user2])
      end
868 869 870 871 872 873 874 875

      it 'returns users with a exact matching name shorter than 3 chars' do
        expect(described_class.search(user3.name)).to eq([user3])
      end

      it 'returns users with a exact matching name shorter than 3 chars regardless of the casing' do
        expect(described_class.search(user3.name.upcase)).to eq([user3])
      end
876 877
    end

878 879 880 881
    describe 'email matching' do
      it 'returns users with a matching Email' do
        expect(described_class.search(user.email)).to eq([user, user2])
      end
882

883
      it 'returns users with a partially matching Email' do
884
        expect(described_class.search(user.email[0..2])).to eq([user, user2])
885
      end
886

887 888 889
      it 'returns users with a matching Email regardless of the casing' do
        expect(described_class.search(user2.email.upcase)).to eq([user2])
      end
890 891
    end

892 893 894 895
    describe 'username matching' do
      it 'returns users with a matching username' do
        expect(described_class.search(user.username)).to eq([user, user2])
      end
896

897
      it 'returns users with a partially matching username' do
898
        expect(described_class.search(user.username[0..2])).to eq([user, user2])
899
      end
900

901 902 903
      it 'returns users with a matching username regardless of the casing' do
        expect(described_class.search(user2.username.upcase)).to eq([user2])
      end
904 905 906 907 908 909 910 911

      it 'returns users with a exact matching username shorter than 3 chars' do
        expect(described_class.search(user3.username)).to eq([user3])
      end

      it 'returns users with a exact matching username shorter than 3 chars regardless of the casing' do
        expect(described_class.search(user3.username.upcase)).to eq([user3])
      end
M
Marin Jankovski 已提交
912
    end
913 914 915
  end

  describe '.search_with_secondary_emails' do
D
Douwe Maan 已提交
916
    delegate :search_with_secondary_emails, to: :described_class
917

918 919
    let!(:user) { create(:user, name: 'John Doe', username: 'john.doe', email: 'john.doe@example.com' ) }
    let!(:another_user) { create(:user, name: 'Albert Smith', username: 'albert.smith', email: 'albert.smith@example.com' ) }
920 921 922
    let!(:email) do
      create(:email, user: another_user, email: 'alias@example.com')
    end
923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987

    it 'returns users with a matching name' do
      expect(search_with_secondary_emails(user.name)).to eq([user])
    end

    it 'returns users with a partially matching name' do
      expect(search_with_secondary_emails(user.name[0..2])).to eq([user])
    end

    it 'returns users with a matching name regardless of the casing' do
      expect(search_with_secondary_emails(user.name.upcase)).to eq([user])
    end

    it 'returns users with a matching email' do
      expect(search_with_secondary_emails(user.email)).to eq([user])
    end

    it 'returns users with a partially matching email' do
      expect(search_with_secondary_emails(user.email[0..2])).to eq([user])
    end

    it 'returns users with a matching email regardless of the casing' do
      expect(search_with_secondary_emails(user.email.upcase)).to eq([user])
    end

    it 'returns users with a matching username' do
      expect(search_with_secondary_emails(user.username)).to eq([user])
    end

    it 'returns users with a partially matching username' do
      expect(search_with_secondary_emails(user.username[0..2])).to eq([user])
    end

    it 'returns users with a matching username regardless of the casing' do
      expect(search_with_secondary_emails(user.username.upcase)).to eq([user])
    end

    it 'returns users with a matching whole secondary email' do
      expect(search_with_secondary_emails(email.email)).to eq([email.user])
    end

    it 'returns users with a matching part of secondary email' do
      expect(search_with_secondary_emails(email.email[1..4])).to eq([email.user])
    end

    it 'return users with a matching part of secondary email regardless of case' do
      expect(search_with_secondary_emails(email.email[1..4].upcase)).to eq([email.user])
      expect(search_with_secondary_emails(email.email[1..4].downcase)).to eq([email.user])
      expect(search_with_secondary_emails(email.email[1..4].capitalize)).to eq([email.user])
    end

    it 'returns multiple users with matching secondary emails' do
      email1 = create(:email, email: '1_testemail@example.com')
      email2 = create(:email, email: '2_testemail@example.com')
      email3 = create(:email, email: 'other@email.com')
      email3.user.update_attributes!(email: 'another@mail.com')

      expect(
        search_with_secondary_emails('testemail@example.com').map(&:id)
      ).to include(email1.user.id, email2.user.id)

      expect(
        search_with_secondary_emails('testemail@example.com').map(&:id)
      ).not_to include(email3.user.id)
    end
M
Marin Jankovski 已提交
988 989
  end

Y
Yorick Peterse 已提交
990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006
  describe '.find_by_ssh_key_id' do
    context 'using an existing SSH key ID' do
      let(:user) { create(:user) }
      let(:key) { create(:key, user: user) }

      it 'returns the corresponding User' do
        expect(described_class.find_by_ssh_key_id(key.id)).to eq(user)
      end
    end

    context 'using an invalid SSH key ID' do
      it 'returns nil' do
        expect(described_class.find_by_ssh_key_id(-1)).to be_nil
      end
    end
  end

1007 1008 1009 1010
  describe '.by_login' do
    let(:username) { 'John' }
    let!(:user) { create(:user, username: username) }

1011
    it 'gets the correct user' do
1012 1013 1014 1015 1016 1017
      expect(described_class.by_login(user.email.upcase)).to eq user
      expect(described_class.by_login(user.email)).to eq user
      expect(described_class.by_login(username.downcase)).to eq user
      expect(described_class.by_login(username)).to eq user
      expect(described_class.by_login(nil)).to be_nil
      expect(described_class.by_login('')).to be_nil
1018 1019 1020
    end
  end

1021 1022 1023 1024 1025 1026 1027
  describe '.find_by_username' do
    it 'returns nil if not found' do
      expect(described_class.find_by_username('JohnDoe')).to be_nil
    end

    it 'is case-insensitive' do
      user = create(:user, username: 'JohnDoe')
1028

1029 1030 1031 1032
      expect(described_class.find_by_username('JOHNDOE')).to eq user
    end
  end

R
Robert Speicher 已提交
1033 1034
  describe '.find_by_username!' do
    it 'raises RecordNotFound' do
1035 1036
      expect { described_class.find_by_username!('JohnDoe') }
        .to raise_error(ActiveRecord::RecordNotFound)
R
Robert Speicher 已提交
1037 1038 1039 1040
    end

    it 'is case-insensitive' do
      user = create(:user, username: 'JohnDoe')
1041

R
Robert Speicher 已提交
1042 1043 1044 1045
      expect(described_class.find_by_username!('JOHNDOE')).to eq user
    end
  end

1046 1047 1048 1049 1050 1051 1052
  describe '.find_by_full_path' do
    let!(:user) { create(:user) }

    context 'with a route matching the given path' do
      let!(:route) { user.namespace.route }

      it 'returns the user' do
1053
        expect(described_class.find_by_full_path(route.path)).to eq(user)
1054 1055 1056
      end

      it 'is case-insensitive' do
1057 1058
        expect(described_class.find_by_full_path(route.path.upcase)).to eq(user)
        expect(described_class.find_by_full_path(route.path.downcase)).to eq(user)
1059 1060 1061 1062 1063 1064 1065 1066
      end
    end

    context 'with a redirect route matching the given path' do
      let!(:redirect_route) { user.namespace.redirect_routes.create(path: 'foo') }

      context 'without the follow_redirects option' do
        it 'returns nil' do
1067
          expect(described_class.find_by_full_path(redirect_route.path)).to eq(nil)
1068 1069 1070 1071 1072
        end
      end

      context 'with the follow_redirects option set to true' do
        it 'returns the user' do
1073
          expect(described_class.find_by_full_path(redirect_route.path, follow_redirects: true)).to eq(user)
1074 1075 1076
        end

        it 'is case-insensitive' do
1077 1078
          expect(described_class.find_by_full_path(redirect_route.path.upcase, follow_redirects: true)).to eq(user)
          expect(described_class.find_by_full_path(redirect_route.path.downcase, follow_redirects: true)).to eq(user)
1079 1080 1081 1082 1083 1084 1085
        end
      end
    end

    context 'without a route or a redirect route matching the given path' do
      context 'without the follow_redirects option' do
        it 'returns nil' do
1086
          expect(described_class.find_by_full_path('unknown')).to eq(nil)
1087 1088 1089 1090
        end
      end
      context 'with the follow_redirects option set to true' do
        it 'returns nil' do
1091
          expect(described_class.find_by_full_path('unknown', follow_redirects: true)).to eq(nil)
1092 1093 1094 1095 1096
        end
      end
    end

    context 'with a group route matching the given path' do
M
Michael Kozono 已提交
1097 1098
      context 'when the group namespace has an owner_id (legacy data)' do
        let!(:group) { create(:group, path: 'group_path', owner: user) }
1099

M
Michael Kozono 已提交
1100
        it 'returns nil' do
1101
          expect(described_class.find_by_full_path('group_path')).to eq(nil)
M
Michael Kozono 已提交
1102 1103 1104 1105 1106 1107 1108
        end
      end

      context 'when the group namespace does not have an owner_id' do
        let!(:group) { create(:group, path: 'group_path') }

        it 'returns nil' do
1109
          expect(described_class.find_by_full_path('group_path')).to eq(nil)
M
Michael Kozono 已提交
1110
        end
1111 1112 1113 1114
      end
    end
  end

G
GitLab 已提交
1115
  describe 'all_ssh_keys' do
1116
    it { is_expected.to have_many(:keys).dependent(:destroy) }
G
GitLab 已提交
1117

1118
    it "has all ssh keys" do
G
GitLab 已提交
1119 1120 1121
      user = create :user
      key = create :key, key: "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQD33bWLBxu48Sev9Fert1yzEO4WGcWglWF7K/AwblIUFselOt/QdOL9DSjpQGxLagO1s9wl53STIO8qGS4Ms0EJZyIXOEFMjFJ5xmjSy+S37By4sG7SsltQEHMxtbtFOaW5LV2wCrX+rUsRNqLMamZjgjcPO0/EgGCXIGMAYW4O7cwGZdXWYIhQ1Vwy+CsVMDdPkPgBXqK7nR/ey8KMs8ho5fMNgB5hBw/AL9fNGhRw3QTD6Q12Nkhl4VZES2EsZqlpNnJttnPdp847DUsT6yuLRlfiQfz5Cn9ysHFdXObMN5VYIiPFwHeYCZp1X2S4fDZooRE8uOLTfxWHPXwrhqSH", user_id: user.id

1122
      expect(user.all_ssh_keys).to include(a_string_starting_with(key.key))
G
GitLab 已提交
1123
    end
G
GitLab 已提交
1124
  end
1125

1126
  describe '#avatar_type' do
D
Dmitriy Zaporozhets 已提交
1127 1128
    let(:user) { create(:user) }

1129
    it 'is true if avatar is image' do
D
Dmitriy Zaporozhets 已提交
1130
      user.update_attribute(:avatar, 'uploads/avatar.png')
1131

1132
      expect(user.avatar_type).to be_truthy
D
Dmitriy Zaporozhets 已提交
1133 1134
    end

1135
    it 'is false if avatar is html page' do
D
Dmitriy Zaporozhets 已提交
1136
      user.update_attribute(:avatar, 'uploads/avatar.html')
1137

1138
      expect(user.avatar_type).to eq(['only images allowed'])
D
Dmitriy Zaporozhets 已提交
1139 1140
    end
  end
J
Jerome Dalbert 已提交
1141

1142 1143 1144 1145
  describe '#avatar_url' do
    let(:user) { create(:user, :with_avatar) }

    context 'when avatar file is uploaded' do
1146
      let(:gitlab_host) { "http://#{Gitlab.config.gitlab.host}" }
1147
      let(:avatar_path) { "/uploads/-/system/user/avatar/#{user.id}/dk.png" }
1148

1149 1150 1151 1152 1153 1154 1155 1156
      it 'shows correct avatar url' do
        expect(user.avatar_url).to eq(avatar_path)
        expect(user.avatar_url(only_path: false)).to eq([gitlab_host, avatar_path].join)

        allow(ActionController::Base).to receive(:asset_host).and_return(gitlab_host)

        expect(user.avatar_url).to eq([gitlab_host, avatar_path].join)
      end
1157 1158 1159
    end
  end

1160 1161 1162 1163 1164 1165 1166
  describe '#all_emails' do
    let(:user) { create(:user) }

    it 'returns all emails' do
      email_confirmed   = create :email, user: user, confirmed_at: Time.now
      email_unconfirmed = create :email, user: user
      user.reload
1167

1168
      expect(user.all_emails).to match_array([user.email, email_unconfirmed.email, email_confirmed.email])
1169 1170 1171
    end
  end

1172
  describe '#verified_emails' do
1173 1174 1175
    let(:user) { create(:user) }

    it 'returns only confirmed emails' do
B
Brett Walker 已提交
1176 1177
      email_confirmed = create :email, user: user, confirmed_at: Time.now
      create :email, user: user
1178
      user.reload
1179

1180
      expect(user.verified_emails).to match_array([user.email, email_confirmed.email])
1181 1182 1183 1184 1185 1186 1187
    end
  end

  describe '#verified_email?' do
    let(:user) { create(:user) }

    it 'returns true when the email is verified/confirmed' do
B
Brett Walker 已提交
1188 1189
      email_confirmed = create :email, user: user, confirmed_at: Time.now
      create :email, user: user
1190 1191 1192
      user.reload

      expect(user.verified_email?(user.email)).to be_truthy
1193
      expect(user.verified_email?(email_confirmed.email.titlecase)).to be_truthy
1194 1195 1196 1197 1198 1199 1200 1201 1202 1203
    end

    it 'returns false when the email is not verified/confirmed' do
      email_unconfirmed = create :email, user: user
      user.reload

      expect(user.verified_email?(email_unconfirmed.email)).to be_falsy
    end
  end

1204
  describe '#requires_ldap_check?' do
1205
    let(:user) { described_class.new }
1206

1207 1208
    it 'is false when LDAP is disabled' do
      # Create a condition which would otherwise cause 'true' to be returned
1209
      allow(user).to receive(:ldap_user?).and_return(true)
1210
      user.last_credential_check_at = nil
1211

1212
      expect(user.requires_ldap_check?).to be_falsey
1213 1214
    end

1215
    context 'when LDAP is enabled' do
1216 1217 1218
      before do
        allow(Gitlab.config.ldap).to receive(:enabled).and_return(true)
      end
1219

1220
      it 'is false for non-LDAP users' do
1221
        allow(user).to receive(:ldap_user?).and_return(false)
1222

1223
        expect(user.requires_ldap_check?).to be_falsey
1224 1225
      end

1226
      context 'and when the user is an LDAP user' do
1227 1228 1229
        before do
          allow(user).to receive(:ldap_user?).and_return(true)
        end
1230 1231 1232

        it 'is true when the user has never had an LDAP check before' do
          user.last_credential_check_at = nil
1233

1234
          expect(user.requires_ldap_check?).to be_truthy
1235 1236 1237 1238
        end

        it 'is true when the last LDAP check happened over 1 hour ago' do
          user.last_credential_check_at = 2.hours.ago
1239

1240
          expect(user.requires_ldap_check?).to be_truthy
1241
        end
1242 1243 1244 1245
      end
    end
  end

1246
  context 'ldap synchronized user' do
1247
    describe '#ldap_user?' do
1248 1249
      it 'is true if provider name starts with ldap' do
        user = create(:omniauth_user, provider: 'ldapmain')
1250

1251 1252
        expect(user.ldap_user?).to be_truthy
      end
1253

1254 1255
      it 'is false for other providers' do
        user = create(:omniauth_user, provider: 'other-provider')
1256

1257 1258 1259 1260 1261
        expect(user.ldap_user?).to be_falsey
      end

      it 'is false if no extern_uid is provided' do
        user = create(:omniauth_user, extern_uid: nil)
1262

1263 1264
        expect(user.ldap_user?).to be_falsey
      end
1265 1266
    end

1267
    describe '#ldap_identity' do
1268 1269
      it 'returns ldap identity' do
        user = create :omniauth_user
1270

1271 1272
        expect(user.ldap_identity.provider).not_to be_empty
      end
1273 1274
    end

1275 1276 1277 1278 1279
    describe '#ldap_block' do
      let(:user) { create(:omniauth_user, provider: 'ldapmain', name: 'John Smith') }

      it 'blocks user flaging the action caming from ldap' do
        user.ldap_block
1280

1281 1282 1283
        expect(user.blocked?).to be_truthy
        expect(user.ldap_blocked?).to be_truthy
      end
1284 1285 1286
    end
  end

J
Jerome Dalbert 已提交
1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325
  describe '#full_website_url' do
    let(:user) { create(:user) }

    it 'begins with http if website url omits it' do
      user.website_url = 'test.com'

      expect(user.full_website_url).to eq 'http://test.com'
    end

    it 'begins with http if website url begins with http' do
      user.website_url = 'http://test.com'

      expect(user.full_website_url).to eq 'http://test.com'
    end

    it 'begins with https if website url begins with https' do
      user.website_url = 'https://test.com'

      expect(user.full_website_url).to eq 'https://test.com'
    end
  end

  describe '#short_website_url' do
    let(:user) { create(:user) }

    it 'does not begin with http if website url omits it' do
      user.website_url = 'test.com'

      expect(user.short_website_url).to eq 'test.com'
    end

    it 'does not begin with http if website url begins with http' do
      user.website_url = 'http://test.com'

      expect(user.short_website_url).to eq 'test.com'
    end

    it 'does not begin with https if website url begins with https' do
      user.website_url = 'https://test.com'
1326

J
Jerome Dalbert 已提交
1327 1328
      expect(user.short_website_url).to eq 'test.com'
    end
G
GitLab 已提交
1329
  end
C
Ciro Santilli 已提交
1330

1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342
  describe '#sanitize_attrs' do
    let(:user) { build(:user, name: 'test & user', skype: 'test&user') }

    it 'encodes HTML entities in the Skype attribute' do
      expect { user.sanitize_attrs }.to change { user.skype }.to('test&amp;user')
    end

    it 'does not encode HTML entities in the name attribute' do
      expect { user.sanitize_attrs }.not_to change { user.name }
    end
  end

1343 1344
  describe '#starred?' do
    it 'determines if user starred a project' do
1345
      user = create :user
1346 1347
      project1 = create(:project, :public)
      project2 = create(:project, :public)
1348

1349 1350
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_falsey
1351 1352

      star1 = UsersStarProject.create!(project: project1, user: user)
1353

1354 1355
      expect(user.starred?(project1)).to be_truthy
      expect(user.starred?(project2)).to be_falsey
1356 1357

      star2 = UsersStarProject.create!(project: project2, user: user)
1358

1359 1360
      expect(user.starred?(project1)).to be_truthy
      expect(user.starred?(project2)).to be_truthy
1361 1362

      star1.destroy
1363

1364 1365
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_truthy
1366 1367

      star2.destroy
1368

1369 1370
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_falsey
1371 1372 1373
    end
  end

1374 1375
  describe '#toggle_star' do
    it 'toggles stars' do
C
Ciro Santilli 已提交
1376
      user = create :user
1377
      project = create(:project, :public)
C
Ciro Santilli 已提交
1378

1379
      expect(user.starred?(project)).to be_falsey
1380

C
Ciro Santilli 已提交
1381
      user.toggle_star(project)
1382

1383
      expect(user.starred?(project)).to be_truthy
1384

C
Ciro Santilli 已提交
1385
      user.toggle_star(project)
1386

1387
      expect(user.starred?(project)).to be_falsey
C
Ciro Santilli 已提交
1388 1389
    end
  end
V
Valery Sizov 已提交
1390

1391
  describe '#sort' do
V
Valery Sizov 已提交
1392
    before do
1393
      described_class.delete_all
V
Valery Sizov 已提交
1394 1395
      @user = create :user, created_at: Date.today, last_sign_in_at: Date.today, name: 'Alpha'
      @user1 = create :user, created_at: Date.today - 1, last_sign_in_at: Date.today - 1, name: 'Omega'
1396
      @user2 = create :user, created_at: Date.today - 2, last_sign_in_at: nil, name: 'Beta'
V
Valery Sizov 已提交
1397
    end
1398

1399 1400
    context 'when sort by recent_sign_in' do
      it 'sorts users by the recent sign-in time' do
1401
        expect(described_class.sort('recent_sign_in').first).to eq(@user)
1402 1403 1404
      end

      it 'pushes users who never signed in to the end' do
1405
        expect(described_class.sort('recent_sign_in').third).to eq(@user2)
1406
      end
V
Valery Sizov 已提交
1407 1408
    end

1409 1410
    context 'when sort by oldest_sign_in' do
      it 'sorts users by the oldest sign-in time' do
1411
        expect(described_class.sort('oldest_sign_in').first).to eq(@user1)
1412 1413 1414
      end

      it 'pushes users who never signed in to the end' do
1415
        expect(described_class.sort('oldest_sign_in').third).to eq(@user2)
1416
      end
V
Valery Sizov 已提交
1417 1418
    end

1419
    it 'sorts users in descending order by their creation time' do
1420
      expect(described_class.sort('created_desc').first).to eq(@user)
V
Valery Sizov 已提交
1421 1422
    end

1423
    it 'sorts users in ascending order by their creation time' do
1424
      expect(described_class.sort('created_asc').first).to eq(@user2)
V
Valery Sizov 已提交
1425 1426
    end

1427
    it 'sorts users by id in descending order when nil is passed' do
1428
      expect(described_class.sort(nil).first).to eq(@user2)
V
Valery Sizov 已提交
1429 1430
    end
  end
1431

1432
  describe "#contributed_projects" do
1433
    subject { create(:user) }
1434
    let!(:project1) { create(:project) }
B
Bob Van Landuyt 已提交
1435
    let!(:project2) { fork_project(project3) }
1436
    let!(:project3) { create(:project) }
1437
    let!(:merge_request) { create(:merge_request, source_project: project2, target_project: project3, author: subject) }
1438
    let!(:push_event) { create(:push_event, project: project1, author: subject) }
1439
    let!(:merge_event) { create(:event, :created, project: project3, target: merge_request, author: subject) }
1440 1441 1442 1443 1444 1445 1446

    before do
      project1.team << [subject, :master]
      project2.team << [subject, :master]
    end

    it "includes IDs for projects the user has pushed to" do
1447
      expect(subject.contributed_projects).to include(project1)
1448 1449 1450
    end

    it "includes IDs for projects the user has had merge requests merged into" do
1451
      expect(subject.contributed_projects).to include(project3)
1452 1453 1454
    end

    it "doesn't include IDs for unrelated projects" do
1455
      expect(subject.contributed_projects).not_to include(project2)
1456 1457
    end
  end
1458

1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475
  describe '#fork_of' do
    let(:user) { create(:user) }

    it "returns a user's fork of a project" do
      project = create(:project, :public)
      user_fork = fork_project(project, user, namespace: user.namespace)

      expect(user.fork_of(project)).to eq(user_fork)
    end

    it 'returns nil if the project does not have a fork network' do
      project = create(:project)

      expect(user.fork_of(project)).to be_nil
    end
  end

1476
  describe '#can_be_removed?' do
1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491
    subject { create(:user) }

    context 'no owned groups' do
      it { expect(subject.can_be_removed?).to be_truthy }
    end

    context 'has owned groups' do
      before do
        group = create(:group)
        group.add_owner(subject)
      end

      it { expect(subject.can_be_removed?).to be_falsey }
    end
  end
1492 1493

  describe "#recent_push" do
1494 1495 1496
    let(:user) { build(:user) }
    let(:project) { build(:project) }
    let(:event) { build(:push_event) }
1497

1498 1499 1500 1501
    it 'returns the last push event for the user' do
      expect_any_instance_of(Users::LastPushEventService)
        .to receive(:last_event_for_user)
        .and_return(event)
1502

1503
      expect(user.recent_push).to eq(event)
1504 1505
    end

1506 1507 1508 1509
    it 'returns the last push event for a project when one is given' do
      expect_any_instance_of(Users::LastPushEventService)
        .to receive(:last_event_for_project)
        .and_return(event)
1510

1511
      expect(user.recent_push(project)).to eq(event)
1512
    end
1513
  end
1514 1515 1516 1517 1518 1519 1520 1521 1522

  describe '#authorized_groups' do
    let!(:user) { create(:user) }
    let!(:private_group) { create(:group) }

    before do
      private_group.add_user(user, Gitlab::Access::MASTER)
    end

1523
    subject { user.authorized_groups }
1524

1525
    it { is_expected.to eq([private_group]) }
1526 1527
  end

1528
  describe '#authorized_projects', truncate: true do
1529 1530 1531
    context 'with a minimum access level' do
      it 'includes projects for which the user is an owner' do
        user = create(:user)
1532
        project = create(:project, :private, namespace: user.namespace)
1533

D
Douwe Maan 已提交
1534 1535
        expect(user.authorized_projects(Gitlab::Access::REPORTER))
          .to contain_exactly(project)
1536
      end
1537

1538 1539
      it 'includes projects for which the user is a master' do
        user = create(:user)
1540
        project = create(:project, :private)
1541 1542

        project.team << [user, Gitlab::Access::MASTER]
1543

D
Douwe Maan 已提交
1544 1545
        expect(user.authorized_projects(Gitlab::Access::REPORTER))
          .to contain_exactly(project)
1546 1547
      end
    end
1548 1549 1550

    it "includes user's personal projects" do
      user    = create(:user)
1551
      project = create(:project, :private, namespace: user.namespace)
1552 1553 1554 1555 1556 1557 1558

      expect(user.authorized_projects).to include(project)
    end

    it "includes personal projects user has been given access to" do
      user1   = create(:user)
      user2   = create(:user)
1559
      project = create(:project, :private, namespace: user1.namespace)
1560 1561 1562 1563 1564 1565 1566 1567

      project.team << [user2, Gitlab::Access::DEVELOPER]

      expect(user2.authorized_projects).to include(project)
    end

    it "includes projects of groups user has been added to" do
      group   = create(:group)
1568
      project = create(:project, group: group)
1569 1570 1571 1572 1573 1574 1575 1576 1577
      user    = create(:user)

      group.add_developer(user)

      expect(user.authorized_projects).to include(project)
    end

    it "does not include projects of groups user has been removed from" do
      group   = create(:group)
1578
      project = create(:project, group: group)
1579 1580 1581
      user    = create(:user)

      member = group.add_developer(user)
1582

1583 1584 1585
      expect(user.authorized_projects).to include(project)

      member.destroy
1586

1587 1588 1589 1590 1591
      expect(user.authorized_projects).not_to include(project)
    end

    it "includes projects shared with user's group" do
      user    = create(:user)
1592
      project = create(:project, :private)
1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603
      group   = create(:group)

      group.add_reporter(user)
      project.project_group_links.create(group: group)

      expect(user.authorized_projects).to include(project)
    end

    it "does not include destroyed projects user had access to" do
      user1   = create(:user)
      user2   = create(:user)
1604
      project = create(:project, :private, namespace: user1.namespace)
1605 1606

      project.team << [user2, Gitlab::Access::DEVELOPER]
1607

1608 1609 1610
      expect(user2.authorized_projects).to include(project)

      project.destroy
1611

1612 1613 1614 1615 1616
      expect(user2.authorized_projects).not_to include(project)
    end

    it "does not include projects of destroyed groups user had access to" do
      group   = create(:group)
1617
      project = create(:project, namespace: group)
1618 1619 1620
      user    = create(:user)

      group.add_developer(user)
1621

1622 1623 1624
      expect(user.authorized_projects).to include(project)

      group.destroy
1625

1626 1627
      expect(user.authorized_projects).not_to include(project)
    end
1628
  end
1629

1630 1631 1632 1633
  describe '#projects_where_can_admin_issues' do
    let(:user) { create(:user) }

    it 'includes projects for which the user access level is above or equal to reporter' do
1634 1635 1636
      reporter_project  = create(:project) { |p| p.add_reporter(user) }
      developer_project = create(:project) { |p| p.add_developer(user) }
      master_project    = create(:project) { |p| p.add_master(user) }
1637

1638
      expect(user.projects_where_can_admin_issues.to_a).to match_array([master_project, developer_project, reporter_project])
1639 1640 1641 1642 1643 1644
      expect(user.can?(:admin_issue, master_project)).to eq(true)
      expect(user.can?(:admin_issue, developer_project)).to eq(true)
      expect(user.can?(:admin_issue, reporter_project)).to eq(true)
    end

    it 'does not include for which the user access level is below reporter' do
1645 1646
      project = create(:project)
      guest_project = create(:project) { |p| p.add_guest(user) }
1647 1648 1649 1650 1651 1652 1653

      expect(user.projects_where_can_admin_issues.to_a).to be_empty
      expect(user.can?(:admin_issue, guest_project)).to eq(false)
      expect(user.can?(:admin_issue, project)).to eq(false)
    end

    it 'does not include archived projects' do
1654
      project = create(:project, :archived)
1655 1656 1657 1658 1659 1660

      expect(user.projects_where_can_admin_issues.to_a).to be_empty
      expect(user.can?(:admin_issue, project)).to eq(false)
    end

    it 'does not include projects for which issues are disabled' do
1661
      project = create(:project, :issues_disabled)
1662 1663 1664 1665 1666 1667

      expect(user.projects_where_can_admin_issues.to_a).to be_empty
      expect(user.can?(:admin_issue, project)).to eq(false)
    end
  end

1668 1669 1670 1671
  describe '#ci_authorized_runners' do
    let(:user) { create(:user) }
    let(:runner) { create(:ci_runner) }

1672 1673 1674
    before do
      project.runners << runner
    end
1675 1676

    context 'without any projects' do
1677
      let(:project) { create(:project) }
1678 1679

      it 'does not load' do
1680
        expect(user.ci_authorized_runners).to be_empty
1681 1682 1683 1684 1685
      end
    end

    context 'with personal projects runners' do
      let(:namespace) { create(:namespace, owner: user) }
1686
      let(:project) { create(:project, namespace: namespace) }
1687 1688

      it 'loads' do
1689
        expect(user.ci_authorized_runners).to contain_exactly(runner)
1690 1691 1692 1693
      end
    end

    shared_examples :member do
1694
      context 'when the user is a master' do
1695 1696 1697
        before do
          add_user(Gitlab::Access::MASTER)
        end
1698

1699 1700 1701
        it 'loads' do
          expect(user.ci_authorized_runners).to contain_exactly(runner)
        end
1702 1703
      end

1704
      context 'when the user is a developer' do
1705 1706 1707
        before do
          add_user(Gitlab::Access::DEVELOPER)
        end
1708

1709 1710 1711
        it 'does not load' do
          expect(user.ci_authorized_runners).to be_empty
        end
1712 1713 1714 1715 1716
      end
    end

    context 'with groups projects runners' do
      let(:group) { create(:group) }
1717
      let(:project) { create(:project, group: group) }
1718

L
Lin Jen-Shin 已提交
1719
      def add_user(access)
1720 1721 1722 1723 1724 1725 1726
        group.add_user(user, access)
      end

      it_behaves_like :member
    end

    context 'with other projects runners' do
1727
      let(:project) { create(:project) }
1728

L
Lin Jen-Shin 已提交
1729
      def add_user(access)
L
Lin Jen-Shin 已提交
1730
        project.team << [user, access]
1731 1732 1733 1734 1735 1736
      end

      it_behaves_like :member
    end
  end

1737
  describe '#projects_with_reporter_access_limited_to' do
1738 1739
    let(:project1) { create(:project) }
    let(:project2) { create(:project) }
1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759
    let(:user) { create(:user) }

    before do
      project1.team << [user, :reporter]
      project2.team << [user, :guest]
    end

    it 'returns the projects when using a single project ID' do
      projects = user.projects_with_reporter_access_limited_to(project1.id)

      expect(projects).to eq([project1])
    end

    it 'returns the projects when using an Array of project IDs' do
      projects = user.projects_with_reporter_access_limited_to([project1.id])

      expect(projects).to eq([project1])
    end

    it 'returns the projects when using an ActiveRecord relation' do
1760 1761
      projects = user
        .projects_with_reporter_access_limited_to(Project.select(:id))
1762 1763 1764 1765 1766 1767 1768 1769 1770 1771

      expect(projects).to eq([project1])
    end

    it 'does not return projects you do not have reporter access to' do
      projects = user.projects_with_reporter_access_limited_to(project2.id)

      expect(projects).to be_empty
    end
  end
1772

1773 1774
  describe '#all_expanded_groups' do
    # foo/bar would also match foo/barbaz instead of just foo/bar and foo/bar/baz
1775 1776
    let!(:user) { create(:user) }

1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792
    #                group
    #        _______ (foo) _______
    #       |                     |
    #       |                     |
    # nested_group_1        nested_group_2
    # (bar)                 (barbaz)
    #       |                     |
    #       |                     |
    # nested_group_1_1      nested_group_2_1
    # (baz)                 (baz)
    #
    let!(:group) { create :group }
    let!(:nested_group_1) { create :group, parent: group, name: 'bar' }
    let!(:nested_group_1_1) { create :group, parent: nested_group_1, name: 'baz' }
    let!(:nested_group_2) { create :group, parent: group, name: 'barbaz' }
    let!(:nested_group_2_1) { create :group, parent: nested_group_2, name: 'baz' }
1793

1794 1795 1796 1797 1798 1799
    subject { user.all_expanded_groups }

    context 'user is not a member of any group' do
      it 'returns an empty array' do
        is_expected.to eq([])
      end
1800 1801
    end

1802 1803 1804 1805 1806 1807 1808 1809
    context 'user is member of all groups' do
      before do
        group.add_owner(user)
        nested_group_1.add_owner(user)
        nested_group_1_1.add_owner(user)
        nested_group_2.add_owner(user)
        nested_group_2_1.add_owner(user)
      end
1810

1811 1812 1813 1814 1815 1816 1817 1818
      it 'returns all groups' do
        is_expected.to match_array [
          group,
          nested_group_1, nested_group_1_1,
          nested_group_2, nested_group_2_1
        ]
      end
    end
1819

1820
    context 'user is member of the top group' do
1821 1822 1823
      before do
        group.add_owner(user)
      end
1824

1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838
      if Group.supports_nested_groups?
        it 'returns all groups' do
          is_expected.to match_array [
            group,
            nested_group_1, nested_group_1_1,
            nested_group_2, nested_group_2_1
          ]
        end
      else
        it 'returns the top-level groups' do
          is_expected.to match_array [group]
        end
      end
    end
1839

1840
    context 'user is member of the first child (internal node), branch 1', :nested_groups do
1841 1842 1843
      before do
        nested_group_1.add_owner(user)
      end
1844

1845 1846 1847 1848 1849 1850 1851 1852 1853
      it 'returns the groups in the hierarchy' do
        is_expected.to match_array [
          group,
          nested_group_1, nested_group_1_1
        ]
      end
    end

    context 'user is member of the first child (internal node), branch 2', :nested_groups do
1854 1855 1856
      before do
        nested_group_2.add_owner(user)
      end
1857

1858 1859 1860 1861 1862 1863
      it 'returns the groups in the hierarchy' do
        is_expected.to match_array [
          group,
          nested_group_2, nested_group_2_1
        ]
      end
1864 1865
    end

1866
    context 'user is member of the last child (leaf node)', :nested_groups do
1867 1868 1869
      before do
        nested_group_1_1.add_owner(user)
      end
1870 1871 1872 1873 1874 1875 1876 1877

      it 'returns the groups in the hierarchy' do
        is_expected.to match_array [
          group,
          nested_group_1, nested_group_1_1
        ]
      end
    end
1878 1879
  end

1880
  describe '#refresh_authorized_projects', clean_gitlab_redis_shared_state: true do
1881 1882
    let(:project1) { create(:project) }
    let(:project2) { create(:project) }
1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901
    let(:user) { create(:user) }

    before do
      project1.team << [user, :reporter]
      project2.team << [user, :guest]

      user.project_authorizations.delete_all
      user.refresh_authorized_projects
    end

    it 'refreshes the list of authorized projects' do
      expect(user.project_authorizations.count).to eq(2)
    end

    it 'stores the correct access levels' do
      expect(user.project_authorizations.where(access_level: Gitlab::Access::GUEST).exists?).to eq(true)
      expect(user.project_authorizations.where(access_level: Gitlab::Access::REPORTER).exists?).to eq(true)
    end
  end
D
Douwe Maan 已提交
1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934

  describe '#access_level=' do
    let(:user) { build(:user) }

    it 'does nothing for an invalid access level' do
      user.access_level = :invalid_access_level

      expect(user.access_level).to eq(:regular)
      expect(user.admin).to be false
    end

    it "assigns the 'admin' access level" do
      user.access_level = :admin

      expect(user.access_level).to eq(:admin)
      expect(user.admin).to be true
    end

    it "doesn't clear existing access levels when an invalid access level is passed in" do
      user.access_level = :admin
      user.access_level = :invalid_access_level

      expect(user.access_level).to eq(:admin)
      expect(user.admin).to be true
    end

    it "accepts string values in addition to symbols" do
      user.access_level = 'admin'

      expect(user.access_level).to eq(:admin)
      expect(user.admin).to be true
    end
  end
1935

1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949
  describe '#full_private_access?' do
    it 'returns false for regular user' do
      user = build(:user)

      expect(user.full_private_access?).to be_falsy
    end

    it 'returns true for admin user' do
      user = build(:user, :admin)

      expect(user.full_private_access?).to be_truthy
    end
  end

1950 1951
  describe '.ghost' do
    it "creates a ghost user if one isn't already present" do
1952
      ghost = described_class.ghost
1953 1954 1955 1956 1957 1958 1959

      expect(ghost).to be_ghost
      expect(ghost).to be_persisted
    end

    it "does not create a second ghost user if one is already present" do
      expect do
1960 1961 1962 1963
        described_class.ghost
        described_class.ghost
      end.to change { described_class.count }.by(1)
      expect(described_class.ghost).to eq(described_class.ghost)
1964 1965 1966 1967 1968
    end

    context "when a regular user exists with the username 'ghost'" do
      it "creates a ghost user with a non-conflicting username" do
        create(:user, username: 'ghost')
1969
        ghost = described_class.ghost
1970 1971

        expect(ghost).to be_persisted
1972
        expect(ghost.username).to eq('ghost1')
1973 1974 1975 1976 1977 1978
      end
    end

    context "when a regular user exists with the email 'ghost@example.com'" do
      it "creates a ghost user with a non-conflicting email" do
        create(:user, email: 'ghost@example.com')
1979
        ghost = described_class.ghost
1980 1981

        expect(ghost).to be_persisted
1982
        expect(ghost.email).to eq('ghost1@example.com')
1983 1984
      end
    end
1985 1986 1987 1988 1989 1990 1991

    context 'when a domain whitelist is in place' do
      before do
        stub_application_setting(domain_whitelist: ['gitlab.com'])
      end

      it 'creates a ghost user' do
1992
        expect(described_class.ghost).to be_persisted
1993 1994
      end
    end
1995
  end
1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011

  describe '#update_two_factor_requirement' do
    let(:user) { create :user }

    context 'with 2FA requirement on groups' do
      let(:group1) { create :group, require_two_factor_authentication: true, two_factor_grace_period: 23 }
      let(:group2) { create :group, require_two_factor_authentication: true, two_factor_grace_period: 32 }

      before do
        group1.add_user(user, GroupMember::OWNER)
        group2.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'requires 2FA' do
2012
        expect(user.require_two_factor_authentication_from_group).to be true
2013 2014 2015 2016 2017 2018 2019
      end

      it 'uses the shortest grace period' do
        expect(user.two_factor_grace_period).to be 23
      end
    end

2020
    context 'with 2FA requirement on nested parent group', :nested_groups do
2021 2022 2023 2024 2025 2026 2027 2028 2029 2030
      let!(:group1) { create :group, require_two_factor_authentication: true }
      let!(:group1a) { create :group, require_two_factor_authentication: false, parent: group1 }

      before do
        group1a.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'requires 2FA' do
2031
        expect(user.require_two_factor_authentication_from_group).to be true
2032 2033 2034
      end
    end

2035
    context 'with 2FA requirement on nested child group', :nested_groups do
2036 2037 2038 2039 2040 2041 2042 2043 2044 2045
      let!(:group1) { create :group, require_two_factor_authentication: false }
      let!(:group1a) { create :group, require_two_factor_authentication: true, parent: group1 }

      before do
        group1.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'requires 2FA' do
2046
        expect(user.require_two_factor_authentication_from_group).to be true
2047 2048 2049
      end
    end

2050 2051 2052 2053 2054 2055 2056 2057 2058 2059
    context 'without 2FA requirement on groups' do
      let(:group) { create :group }

      before do
        group.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'does not require 2FA' do
2060
        expect(user.require_two_factor_authentication_from_group).to be false
2061 2062 2063 2064 2065 2066 2067
      end

      it 'falls back to the default grace period' do
        expect(user.two_factor_grace_period).to be 48
      end
    end
  end
J
James Lopez 已提交
2068 2069 2070

  context '.active' do
    before do
2071
      described_class.ghost
J
James Lopez 已提交
2072 2073 2074 2075 2076
      create(:user, name: 'user', state: 'active')
      create(:user, name: 'user', state: 'blocked')
    end

    it 'only counts active and non internal users' do
2077
      expect(described_class.active.count).to eq(1)
J
James Lopez 已提交
2078 2079
    end
  end
2080 2081 2082 2083 2084 2085 2086 2087

  describe 'preferred language' do
    it 'is English by default' do
      user = create(:user)

      expect(user.preferred_language).to eq('en')
    end
  end
2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115

  context '#invalidate_issue_cache_counts' do
    let(:user) { build_stubbed(:user) }

    it 'invalidates cache for issue counter' do
      cache_mock = double

      expect(cache_mock).to receive(:delete).with(['users', user.id, 'assigned_open_issues_count'])

      allow(Rails).to receive(:cache).and_return(cache_mock)

      user.invalidate_issue_cache_counts
    end
  end

  context '#invalidate_merge_request_cache_counts' do
    let(:user) { build_stubbed(:user) }

    it 'invalidates cache for Merge Request counter' do
      cache_mock = double

      expect(cache_mock).to receive(:delete).with(['users', user.id, 'assigned_open_merge_requests_count'])

      allow(Rails).to receive(:cache).and_return(cache_mock)

      user.invalidate_merge_request_cache_counts
    end
  end
2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137

  describe '#allow_password_authentication?' do
    context 'regular user' do
      let(:user) { build(:user) }

      it 'returns true when sign-in is enabled' do
        expect(user.allow_password_authentication?).to be_truthy
      end

      it 'returns false when sign-in is disabled' do
        stub_application_setting(password_authentication_enabled: false)

        expect(user.allow_password_authentication?).to be_falsey
      end
    end

    it 'returns false for ldap user' do
      user = create(:omniauth_user, provider: 'ldapmain')

      expect(user.allow_password_authentication?).to be_falsey
    end
  end
2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161

  describe '#personal_projects_count' do
    it 'returns the number of personal projects using a single query' do
      user = build(:user)
      projects = double(:projects, count: 1)

      expect(user).to receive(:personal_projects).once.and_return(projects)

      2.times do
        expect(user.personal_projects_count).to eq(1)
      end
    end
  end

  describe '#projects_limit_left' do
    it 'returns the number of projects that can be created by the user' do
      user = build(:user)

      allow(user).to receive(:projects_limit).and_return(10)
      allow(user).to receive(:personal_projects_count).and_return(5)

      expect(user.projects_limit_left).to eq(5)
    end
  end
2162 2163 2164 2165 2166 2167 2168

  describe '#ensure_namespace_correct' do
    context 'for a new user' do
      let(:user) { build(:user) }

      it 'creates the namespace' do
        expect(user.namespace).to be_nil
2169

2170
        user.save!
2171

2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191
        expect(user.namespace).not_to be_nil
      end
    end

    context 'for an existing user' do
      let(:username) { 'foo' }
      let(:user) { create(:user, username: username) }

      context 'when the user is updated' do
        context 'when the username is changed' do
          let(:new_username) { 'bar' }

          it 'changes the namespace (just to compare to when username is not changed)' do
            expect do
              user.update_attributes!(username: new_username)
            end.to change { user.namespace.updated_at }
          end

          it 'updates the namespace name' do
            user.update_attributes!(username: new_username)
2192

2193 2194 2195 2196 2197
            expect(user.namespace.name).to eq(new_username)
          end

          it 'updates the namespace path' do
            user.update_attributes!(username: new_username)
2198

2199 2200 2201 2202 2203 2204
            expect(user.namespace.path).to eq(new_username)
          end

          context 'when there is a validation error (namespace name taken) while updating namespace' do
            let!(:conflicting_namespace) { create(:group, name: new_username, path: 'quz') }

2205
            it 'causes the user save to fail' do
2206 2207 2208
              expect(user.update_attributes(username: new_username)).to be_falsey
              expect(user.namespace.errors.messages[:name].first).to eq('has already been taken')
            end
2209 2210 2211

            it 'adds the namespace errors to the user' do
              user.update_attributes(username: new_username)
2212

2213 2214
              expect(user.errors.full_messages.first).to eq('Namespace name has already been taken')
            end
2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227
          end
        end

        context 'when the username is not changed' do
          it 'does not change the namespace' do
            expect do
              user.update_attributes!(email: 'asdf@asdf.com')
            end.not_to change { user.namespace.updated_at }
          end
        end
      end
    end
  end
A
Alexis Reigel 已提交
2228

2229 2230 2231 2232 2233 2234
  describe '#sync_attribute?' do
    let(:user) { described_class.new }

    context 'oauth user' do
      it 'returns true if name can be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(name location))
2235

2236 2237 2238 2239 2240
        expect(user.sync_attribute?(:name)).to be_truthy
      end

      it 'returns true if email can be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(name email))
2241

2242 2243 2244 2245 2246
        expect(user.sync_attribute?(:email)).to be_truthy
      end

      it 'returns true if location can be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(location email))
2247

2248 2249 2250 2251 2252
        expect(user.sync_attribute?(:email)).to be_truthy
      end

      it 'returns false if name can not be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(location email))
2253

2254 2255 2256 2257 2258
        expect(user.sync_attribute?(:name)).to be_falsey
      end

      it 'returns false if email can not be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(location email))
2259

2260 2261 2262 2263 2264
        expect(user.sync_attribute?(:name)).to be_falsey
      end

      it 'returns false if location can not be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(location email))
2265

2266 2267 2268 2269 2270
        expect(user.sync_attribute?(:name)).to be_falsey
      end

      it 'returns true for all syncable attributes if all syncable attributes can be synced' do
        stub_omniauth_setting(sync_profile_attributes: true)
2271

2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286
        expect(user.sync_attribute?(:name)).to be_truthy
        expect(user.sync_attribute?(:email)).to be_truthy
        expect(user.sync_attribute?(:location)).to be_truthy
      end

      it 'returns false for all syncable attributes but email if no syncable attributes are declared' do
        expect(user.sync_attribute?(:name)).to be_falsey
        expect(user.sync_attribute?(:email)).to be_truthy
        expect(user.sync_attribute?(:location)).to be_falsey
      end
    end

    context 'ldap user' do
      it 'returns true for email if ldap user' do
        allow(user).to receive(:ldap_user?).and_return(true)
2287

2288 2289 2290 2291 2292 2293 2294 2295
        expect(user.sync_attribute?(:name)).to be_falsey
        expect(user.sync_attribute?(:email)).to be_truthy
        expect(user.sync_attribute?(:location)).to be_falsey
      end

      it 'returns true for email and location if ldap user and location declared as syncable' do
        allow(user).to receive(:ldap_user?).and_return(true)
        stub_omniauth_setting(sync_profile_attributes: %w(location))
2296

2297 2298 2299 2300 2301 2302
        expect(user.sync_attribute?(:name)).to be_falsey
        expect(user.sync_attribute?(:email)).to be_truthy
        expect(user.sync_attribute?(:location)).to be_truthy
      end
    end
  end
2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347

  describe '#confirm_deletion_with_password?' do
    where(
      password_automatically_set: [true, false],
      ldap_user: [true, false],
      password_authentication_disabled: [true, false]
    )

    with_them do
      let!(:user) { create(:user, password_automatically_set: password_automatically_set) }
      let!(:identity) { create(:identity, user: user) if ldap_user }

      # Only confirm deletion with password if all inputs are false
      let(:expected) { !(password_automatically_set || ldap_user || password_authentication_disabled) }

      before do
        stub_application_setting(password_authentication_enabled: !password_authentication_disabled)
      end

      it 'returns false unless all inputs are true' do
        expect(user.confirm_deletion_with_password?).to eq(expected)
      end
    end
  end

  describe '#delete_async' do
    let(:user) { create(:user) }
    let(:deleted_by) { create(:user) }

    it 'blocks the user then schedules them for deletion if a hard delete is specified' do
      expect(DeleteUserWorker).to receive(:perform_async).with(deleted_by.id, user.id, hard_delete: true)

      user.delete_async(deleted_by: deleted_by, params: { hard_delete: true })

      expect(user).to be_blocked
    end

    it 'schedules user for deletion without blocking them' do
      expect(DeleteUserWorker).to receive(:perform_async).with(deleted_by.id, user.id, {})

      user.delete_async(deleted_by: deleted_by)

      expect(user).not_to be_blocked
    end
  end
G
gitlabhq 已提交
2348
end