user_spec.rb 55.5 KB
Newer Older
G
gitlabhq 已提交
1 2
require 'spec_helper'

D
Douwe Maan 已提交
3
describe User, models: true do
4 5
  include Gitlab::CurrentSettings

6 7 8 9 10 11 12 13 14 15 16
  describe 'modules' do
    subject { described_class }

    it { is_expected.to include_module(Gitlab::ConfigHelper) }
    it { is_expected.to include_module(Gitlab::CurrentSettings) }
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
    it { is_expected.to include_module(TokenAuthenticatable) }
  end

  describe 'associations' do
17
    it { is_expected.to have_one(:namespace) }
18
    it { is_expected.to have_many(:snippets).dependent(:destroy) }
19 20 21
    it { is_expected.to have_many(:project_members).dependent(:destroy) }
    it { is_expected.to have_many(:groups) }
    it { is_expected.to have_many(:keys).dependent(:destroy) }
22
    it { is_expected.to have_many(:deploy_keys).dependent(:destroy) }
23
    it { is_expected.to have_many(:events).dependent(:destroy) }
24
    it { is_expected.to have_many(:recent_events).class_name('Event') }
25
    it { is_expected.to have_many(:issues).dependent(:restrict_with_exception) }
26 27 28
    it { is_expected.to have_many(:notes).dependent(:destroy) }
    it { is_expected.to have_many(:merge_requests).dependent(:destroy) }
    it { is_expected.to have_many(:identities).dependent(:destroy) }
29
    it { is_expected.to have_many(:spam_logs).dependent(:destroy) }
30
    it { is_expected.to have_many(:todos).dependent(:destroy) }
31
    it { is_expected.to have_many(:award_emoji).dependent(:destroy) }
K
Kamil Trzcinski 已提交
32
    it { is_expected.to have_many(:triggers).dependent(:destroy) }
33 34
    it { is_expected.to have_many(:builds).dependent(:nullify) }
    it { is_expected.to have_many(:pipelines).dependent(:nullify) }
K
Kamil Trzcinski 已提交
35
    it { is_expected.to have_many(:chat_names).dependent(:destroy) }
36
    it { is_expected.to have_many(:uploads).dependent(:destroy) }
37
    it { is_expected.to have_many(:reported_abuse_reports).dependent(:destroy).class_name('AbuseReport') }
38

39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64
    describe "#abuse_report" do
      let(:current_user) { create(:user) }
      let(:other_user) { create(:user) }

      it { is_expected.to have_one(:abuse_report) }

      it "refers to the abuse report whose user_id is the current user" do
        abuse_report = create(:abuse_report, reporter: other_user, user: current_user)

        expect(current_user.abuse_report).to eq(abuse_report)
      end

      it "does not refer to the abuse report whose reporter_id is the current user" do
        create(:abuse_report, reporter: current_user, user: other_user)

        expect(current_user.abuse_report).to be_nil
      end

      it "does not update the user_id of an abuse report when the user is updated" do
        abuse_report = create(:abuse_report, reporter: current_user, user: other_user)

        current_user.block

        expect(abuse_report.reload.user).to eq(other_user)
      end
    end
65 66 67 68

    describe '#group_members' do
      it 'does not include group memberships for which user is a requester' do
        user = create(:user)
69
        group = create(:group, :public, :access_requestable)
70 71 72 73 74 75 76 77 78
        group.request_access(user)

        expect(user.group_members).to be_empty
      end
    end

    describe '#project_members' do
      it 'does not include project memberships for which user is a requester' do
        user = create(:user)
79
        project = create(:empty_project, :public, :access_requestable)
80 81 82 83 84
        project.request_access(user)

        expect(user.project_members).to be_empty
      end
    end
85 86 87
  end

  describe 'validations' do
R
Robert Speicher 已提交
88 89 90 91 92 93 94 95 96 97 98 99
    describe 'username' do
      it 'validates presence' do
        expect(subject).to validate_presence_of(:username)
      end

      it 'rejects blacklisted names' do
        user = build(:user, username: 'dashboard')

        expect(user).not_to be_valid
        expect(user.errors.values).to eq [['dashboard is a reserved name']]
      end

100 101 102 103 104 105 106 107 108 109 110 111
      it 'allows child names' do
        user = build(:user, username: 'avatar')

        expect(user).to be_valid
      end

      it 'allows wildcard names' do
        user = build(:user, username: 'blob')

        expect(user).to be_valid
      end

R
Robert Speicher 已提交
112
      it 'validates uniqueness' do
113
        expect(subject).to validate_uniqueness_of(:username).case_insensitive
R
Robert Speicher 已提交
114 115 116
      end
    end

117 118 119 120
    it { is_expected.to validate_presence_of(:projects_limit) }
    it { is_expected.to validate_numericality_of(:projects_limit) }
    it { is_expected.to allow_value(0).for(:projects_limit) }
    it { is_expected.not_to allow_value(-1).for(:projects_limit) }
121
    it { is_expected.not_to allow_value(Gitlab::Database::MAX_INT_VALUE + 1).for(:projects_limit) }
122

123
    it { is_expected.to validate_length_of(:bio).is_at_most(255) }
124

125 126 127
    it_behaves_like 'an object with email-formated attributes', :email do
      subject { build(:user) }
    end
128

129 130 131
    it_behaves_like 'an object with email-formated attributes', :public_email, :notification_email do
      subject { build(:user).tap { |user| user.emails << build(:email, email: email_value) } }
    end
132

133
    describe 'email' do
134
      context 'when no signup domains whitelisted' do
135
        before do
136
          allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return([])
137
        end
138

139 140 141 142 143 144
        it 'accepts any email' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end
      end

145
      context 'when a signup domain is whitelisted and subdomains are allowed' do
146
        before do
147
          allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['example.com', '*.example.com'])
148
        end
149

150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165
        it 'accepts info@example.com' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end

        it 'accepts info@test.example.com' do
          user = build(:user, email: "info@test.example.com")
          expect(user).to be_valid
        end

        it 'rejects example@test.com' do
          user = build(:user, email: "example@test.com")
          expect(user).to be_invalid
        end
      end

166
      context 'when a signup domain is whitelisted and subdomains are not allowed' do
167
        before do
168
          allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['example.com'])
169
        end
170 171 172 173 174 175 176 177 178 179 180 181 182 183 184

        it 'accepts info@example.com' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end

        it 'rejects info@test.example.com' do
          user = build(:user, email: "info@test.example.com")
          expect(user).to be_invalid
        end

        it 'rejects example@test.com' do
          user = build(:user, email: "example@test.com")
          expect(user).to be_invalid
        end
185 186 187 188 189

        it 'accepts example@test.com when added by another user' do
          user = build(:user, email: "example@test.com", created_by_id: 1)
          expect(user).to be_valid
        end
190
      end
191

192 193 194 195 196 197
      context 'domain blacklist' do
        before do
          allow_any_instance_of(ApplicationSetting).to receive(:domain_blacklist_enabled?).and_return(true)
          allow_any_instance_of(ApplicationSetting).to receive(:domain_blacklist).and_return(['example.com'])
        end

198
        context 'when a signup domain is blacklisted' do
199 200 201 202 203 204 205 206 207
          it 'accepts info@test.com' do
            user = build(:user, email: 'info@test.com')
            expect(user).to be_valid
          end

          it 'rejects info@example.com' do
            user = build(:user, email: 'info@example.com')
            expect(user).not_to be_valid
          end
208 209 210 211 212

          it 'accepts info@example.com when added by another user' do
            user = build(:user, email: 'info@example.com', created_by_id: 1)
            expect(user).to be_valid
          end
213 214
        end

215
        context 'when a signup domain is blacklisted but a wildcard subdomain is allowed' do
216 217
          before do
            allow_any_instance_of(ApplicationSetting).to receive(:domain_blacklist).and_return(['test.example.com'])
218
            allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['*.example.com'])
219 220
          end

221
          it 'gives priority to whitelist and allow info@test.example.com' do
222 223 224 225 226 227 228
            user = build(:user, email: 'info@test.example.com')
            expect(user).to be_valid
          end
        end

        context 'with both lists containing a domain' do
          before do
229
            allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['test.com'])
230 231 232 233 234 235 236 237 238 239 240 241 242 243
          end

          it 'accepts info@test.com' do
            user = build(:user, email: 'info@test.com')
            expect(user).to be_valid
          end

          it 'rejects info@example.com' do
            user = build(:user, email: 'info@example.com')
            expect(user).not_to be_valid
          end
        end
      end

244 245 246 247 248 249
      context 'owns_notification_email' do
        it 'accepts temp_oauth_email emails' do
          user = build(:user, email: "temp-email-for-oauth@example.com")
          expect(user).to be_valid
        end
      end
250
    end
251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310
  end

  describe "scopes" do
    describe ".with_two_factor" do
      it "returns users with 2fa enabled via OTP" do
        user_with_2fa = create(:user, :two_factor_via_otp)
        user_without_2fa = create(:user)
        users_with_two_factor = User.with_two_factor.pluck(:id)

        expect(users_with_two_factor).to include(user_with_2fa.id)
        expect(users_with_two_factor).not_to include(user_without_2fa.id)
      end

      it "returns users with 2fa enabled via U2F" do
        user_with_2fa = create(:user, :two_factor_via_u2f)
        user_without_2fa = create(:user)
        users_with_two_factor = User.with_two_factor.pluck(:id)

        expect(users_with_two_factor).to include(user_with_2fa.id)
        expect(users_with_two_factor).not_to include(user_without_2fa.id)
      end

      it "returns users with 2fa enabled via OTP and U2F" do
        user_with_2fa = create(:user, :two_factor_via_otp, :two_factor_via_u2f)
        user_without_2fa = create(:user)
        users_with_two_factor = User.with_two_factor.pluck(:id)

        expect(users_with_two_factor).to eq([user_with_2fa.id])
        expect(users_with_two_factor).not_to include(user_without_2fa.id)
      end
    end

    describe ".without_two_factor" do
      it "excludes users with 2fa enabled via OTP" do
        user_with_2fa = create(:user, :two_factor_via_otp)
        user_without_2fa = create(:user)
        users_without_two_factor = User.without_two_factor.pluck(:id)

        expect(users_without_two_factor).to include(user_without_2fa.id)
        expect(users_without_two_factor).not_to include(user_with_2fa.id)
      end

      it "excludes users with 2fa enabled via U2F" do
        user_with_2fa = create(:user, :two_factor_via_u2f)
        user_without_2fa = create(:user)
        users_without_two_factor = User.without_two_factor.pluck(:id)

        expect(users_without_two_factor).to include(user_without_2fa.id)
        expect(users_without_two_factor).not_to include(user_with_2fa.id)
      end

      it "excludes users with 2fa enabled via OTP and U2F" do
        user_with_2fa = create(:user, :two_factor_via_otp, :two_factor_via_u2f)
        user_without_2fa = create(:user)
        users_without_two_factor = User.without_two_factor.pluck(:id)

        expect(users_without_two_factor).to include(user_without_2fa.id)
        expect(users_without_two_factor).not_to include(user_with_2fa.id)
      end
    end
V
Valery Sizov 已提交
311 312 313 314 315 316 317 318 319 320 321 322 323 324

    describe '.todo_authors' do
      it 'filters users' do
        create :user
        user_2 = create :user
        user_3 = create :user
        current_user = create :user
        create(:todo, user: current_user, author: user_2, state: :done)
        create(:todo, user: current_user, author: user_3, state: :pending)

        expect(User.todo_authors(current_user.id, 'pending')).to eq [user_3]
        expect(User.todo_authors(current_user.id, 'done')).to eq [user_2]
      end
    end
G
gitlabhq 已提交
325 326 327
  end

  describe "Respond to" do
B
blackst0ne 已提交
328
    it { is_expected.to respond_to(:admin?) }
329 330
    it { is_expected.to respond_to(:name) }
    it { is_expected.to respond_to(:private_token) }
Z
Zeger-Jan van de Weg 已提交
331 332 333 334 335 336 337 338 339 340 341 342 343 344
    it { is_expected.to respond_to(:external?) }
  end

  describe 'before save hook' do
    context 'when saving an external user' do
      let(:user)          { create(:user) }
      let(:external_user) { create(:user, external: true) }

      it "sets other properties aswell" do
        expect(external_user.can_create_team).to be_falsey
        expect(external_user.can_create_group).to be_falsey
        expect(external_user.projects_limit).to be 0
      end
    end
G
gitlabhq 已提交
345 346
  end

347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365
  describe '#update_tracked_fields!', :redis do
    let(:request) { OpenStruct.new(remote_ip: "127.0.0.1") }
    let(:user) { create(:user) }

    it 'writes trackable attributes' do
      expect do
        user.update_tracked_fields!(request)
      end.to change { user.reload.current_sign_in_at }
    end

    it 'does not write trackable attributes when called a second time within the hour' do
      user.update_tracked_fields!(request)

      expect do
        user.update_tracked_fields!(request)
      end.not_to change { user.current_sign_in_at }
    end
  end

366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393
  shared_context 'user keys' do
    let(:user) { create(:user) }
    let!(:key) { create(:key, user: user) }
    let!(:deploy_key) { create(:deploy_key, user: user) }
  end

  describe '#keys' do
    include_context 'user keys'

    context 'with key and deploy key stored' do
      it 'returns stored key, but not deploy_key' do
        expect(user.keys).to include key
        expect(user.keys).not_to include deploy_key
      end
    end
  end

  describe '#deploy_keys' do
    include_context 'user keys'

    context 'with key and deploy key stored' do
      it 'returns stored deploy key, but not normal key' do
        expect(user.deploy_keys).to include deploy_key
        expect(user.deploy_keys).not_to include key
      end
    end
  end

394
  describe '#confirm' do
395 396 397
    before do
      allow_any_instance_of(ApplicationSetting).to receive(:send_user_confirmation_email).and_return(true)
    end
398

399 400 401 402 403 404 405
    let(:user) { create(:user, confirmed_at: nil, unconfirmed_email: 'test@gitlab.com') }

    it 'returns unconfirmed' do
      expect(user.confirmed?).to be_falsey
    end

    it 'confirms a user' do
406
      user.confirm
407 408 409 410
      expect(user.confirmed?).to be_truthy
    end
  end

411 412 413 414 415 416 417 418
  describe '#to_reference' do
    let(:user) { create(:user) }

    it 'returns a String reference to the object' do
      expect(user.to_reference).to eq "@#{user.username}"
    end
  end

419
  describe '#generate_password' do
420
    it "does not generate password by default" do
421
      user = create(:user, password: 'abcdefghe')
422
      expect(user.password).to eq('abcdefghe')
423
    end
424 425
  end

426
  describe 'authentication token' do
427
    it "has authentication token" do
428
      user = create(:user)
429
      expect(user.authentication_token).not_to be_blank
430
    end
N
Nihad Abbasov 已提交
431
  end
432

433
  describe '#recently_sent_password_reset?' do
434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452
    it 'is false when reset_password_sent_at is nil' do
      user = build_stubbed(:user, reset_password_sent_at: nil)

      expect(user.recently_sent_password_reset?).to eq false
    end

    it 'is false when sent more than one minute ago' do
      user = build_stubbed(:user, reset_password_sent_at: 5.minutes.ago)

      expect(user.recently_sent_password_reset?).to eq false
    end

    it 'is true when sent less than one minute ago' do
      user = build_stubbed(:user, reset_password_sent_at: Time.now)

      expect(user.recently_sent_password_reset?).to eq true
    end
  end

R
Robert Speicher 已提交
453 454 455 456 457 458 459
  describe '#disable_two_factor!' do
    it 'clears all 2FA-related fields' do
      user = create(:user, :two_factor)

      expect(user).to be_two_factor_enabled
      expect(user.encrypted_otp_secret).not_to be_nil
      expect(user.otp_backup_codes).not_to be_nil
460
      expect(user.otp_grace_period_started_at).not_to be_nil
R
Robert Speicher 已提交
461 462 463 464 465 466 467 468

      user.disable_two_factor!

      expect(user).not_to be_two_factor_enabled
      expect(user.encrypted_otp_secret).to be_nil
      expect(user.encrypted_otp_secret_iv).to be_nil
      expect(user.encrypted_otp_secret_salt).to be_nil
      expect(user.otp_backup_codes).to be_nil
469
      expect(user.otp_grace_period_started_at).to be_nil
R
Robert Speicher 已提交
470 471 472
    end
  end

473 474
  describe 'projects' do
    before do
475
      @user = create(:user)
476

477 478 479 480 481 482 483
      @project = create(:empty_project, namespace: @user.namespace)
      @project_2 = create(:empty_project, group: create(:group)) do |project|
        project.add_master(@user)
      end
      @project_3 = create(:empty_project, group: create(:group)) do |project|
        project.add_developer(@user)
      end
484 485
    end

486 487 488 489 490 491 492 493 494
    it { expect(@user.authorized_projects).to include(@project) }
    it { expect(@user.authorized_projects).to include(@project_2) }
    it { expect(@user.authorized_projects).to include(@project_3) }
    it { expect(@user.owned_projects).to include(@project) }
    it { expect(@user.owned_projects).not_to include(@project_2) }
    it { expect(@user.owned_projects).not_to include(@project_3) }
    it { expect(@user.personal_projects).to include(@project) }
    it { expect(@user.personal_projects).not_to include(@project_2) }
    it { expect(@user.personal_projects).not_to include(@project_3) }
495 496 497 498 499
  end

  describe 'groups' do
    before do
      @user = create :user
500 501
      @group = create :group
      @group.add_owner(@user)
502 503
    end

504 505 506
    it { expect(@user.several_namespaces?).to be_truthy }
    it { expect(@user.authorized_groups).to eq([@group]) }
    it { expect(@user.owned_groups).to eq([@group]) }
507
    it { expect(@user.namespaces).to match_array([@user.namespace, @group]) }
508 509
  end

510 511 512 513
  describe 'group multiple owners' do
    before do
      @user = create :user
      @user2 = create :user
514 515
      @group = create :group
      @group.add_owner(@user)
516

517
      @group.add_user(@user2, GroupMember::OWNER)
518 519
    end

520
    it { expect(@user2.several_namespaces?).to be_truthy }
521 522
  end

523 524 525
  describe 'namespaced' do
    before do
      @user = create :user
526
      @project = create(:empty_project, namespace: @user.namespace)
527 528
    end

529
    it { expect(@user.several_namespaces?).to be_falsey }
530
    it { expect(@user.namespaces).to eq([@user.namespace]) }
531 532 533 534 535
  end

  describe 'blocking user' do
    let(:user) { create(:user, name: 'John Smith') }

536
    it "blocks user" do
537
      user.block
538
      expect(user.blocked?).to be_truthy
539 540 541
    end
  end

542 543 544 545 546 547 548
  describe '.filter' do
    let(:user) { double }

    it 'filters by active users by default' do
      expect(User).to receive(:active).and_return([user])

      expect(User.filter(nil)).to include user
549 550
    end

551 552 553 554
    it 'filters by admins' do
      expect(User).to receive(:admins).and_return([user])

      expect(User.filter('admins')).to include user
555 556
    end

557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579
    it 'filters by blocked' do
      expect(User).to receive(:blocked).and_return([user])

      expect(User.filter('blocked')).to include user
    end

    it 'filters by two_factor_disabled' do
      expect(User).to receive(:without_two_factor).and_return([user])

      expect(User.filter('two_factor_disabled')).to include user
    end

    it 'filters by two_factor_enabled' do
      expect(User).to receive(:with_two_factor).and_return([user])

      expect(User.filter('two_factor_enabled')).to include user
    end

    it 'filters by wop' do
      expect(User).to receive(:without_projects).and_return([user])

      expect(User.filter('wop')).to include user
    end
580 581
  end

B
Ben Bodenmiller 已提交
582
  describe '.without_projects' do
583
    let!(:project) { create(:empty_project, :public, :access_requestable) }
B
Ben Bodenmiller 已提交
584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603
    let!(:user) { create(:user) }
    let!(:user_without_project) { create(:user) }
    let!(:user_without_project2) { create(:user) }

    before do
      # add user to project
      project.team << [user, :master]

      # create invite to projet
      create(:project_member, :developer, project: project, invite_token: '1234', invite_email: 'inviteduser1@example.com')

      # create request to join project
      project.request_access(user_without_project2)
    end

    it { expect(User.without_projects).not_to include user }
    it { expect(User.without_projects).to include user_without_project }
    it { expect(User.without_projects).to include user_without_project2 }
  end

604
  describe '.not_in_project' do
605
    before do
606
      User.delete_all
607
      @user = create :user
608
      @project = create(:empty_project)
609 610
    end

611
    it { expect(User.not_in_project(@project)).to include(@user, @project.owner) }
612
  end
D
Dmitriy Zaporozhets 已提交
613

614 615 616
  describe 'user creation' do
    describe 'normal user' do
      let(:user) { create(:user, name: 'John Smith') }
D
Dmitriy Zaporozhets 已提交
617

B
blackst0ne 已提交
618
      it { expect(user.admin?).to be_falsey }
619 620 621 622
      it { expect(user.require_ssh_key?).to be_truthy }
      it { expect(user.can_create_group?).to be_truthy }
      it { expect(user.can_create_project?).to be_truthy }
      it { expect(user.first_name).to eq('John') }
623
      it { expect(user.external).to be_falsey }
624
    end
625

D
Dmitriy Zaporozhets 已提交
626
    describe 'with defaults' do
627
      let(:user) { User.new }
D
Dmitriy Zaporozhets 已提交
628

629
      it "applies defaults to user" do
630 631
        expect(user.projects_limit).to eq(Gitlab.config.gitlab.default_projects_limit)
        expect(user.can_create_group).to eq(Gitlab.config.gitlab.default_can_create_group)
Z
Zeger-Jan van de Weg 已提交
632
        expect(user.external).to be_falsey
633 634 635
      end
    end

D
Dmitriy Zaporozhets 已提交
636
    describe 'with default overrides' do
637
      let(:user) { User.new(projects_limit: 123, can_create_group: false, can_create_team: true) }
D
Dmitriy Zaporozhets 已提交
638

639
      it "applies defaults to user" do
640 641
        expect(user.projects_limit).to eq(123)
        expect(user.can_create_group).to be_falsey
642
      end
643
    end
644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663

    context 'when current_application_settings.user_default_external is true' do
      before do
        stub_application_setting(user_default_external: true)
      end

      it "creates external user by default" do
        user = build(:user)

        expect(user.external).to be_truthy
      end

      describe 'with default overrides' do
        it "creates a non-external user" do
          user = build(:user, external: false)

          expect(user.external).to be_falsey
        end
      end
    end
664

665 666 667 668 669 670 671 672 673 674 675 676 677 678
    describe '#require_ssh_key?' do
      protocol_and_expectation = {
        'http' => false,
        'ssh' => true,
        '' => true,
      }

      protocol_and_expectation.each do |protocol, expected|
        it "has correct require_ssh_key?" do
          stub_application_setting(enabled_git_access_protocol: protocol)
          user = build(:user)

          expect(user.require_ssh_key?).to eq(expected)
        end
679 680
      end
    end
681
  end
682

683
  describe '.find_by_any_email' do
684 685 686
    it 'finds by primary email' do
      user = create(:user, email: 'foo@example.com')

687
      expect(User.find_by_any_email(user.email)).to eq user
688 689 690 691 692 693
    end

    it 'finds by secondary email' do
      email = create(:email, email: 'foo@example.com')
      user  = email.user

694
      expect(User.find_by_any_email(email.email)).to eq user
695 696 697
    end

    it 'returns nil when nothing found' do
698
      expect(User.find_by_any_email('')).to be_nil
699 700 701
    end
  end

702 703 704 705 706 707 708 709 710 711 712
  describe '.search' do
    let(:user) { create(:user) }

    it 'returns users with a matching name' do
      expect(described_class.search(user.name)).to eq([user])
    end

    it 'returns users with a partially matching name' do
      expect(described_class.search(user.name[0..2])).to eq([user])
    end

Y
Yorick Peterse 已提交
713
    it 'returns users with a matching name regardless of the casing' do
714 715 716 717 718 719 720 721 722 723 724
      expect(described_class.search(user.name.upcase)).to eq([user])
    end

    it 'returns users with a matching Email' do
      expect(described_class.search(user.email)).to eq([user])
    end

    it 'returns users with a partially matching Email' do
      expect(described_class.search(user.email[0..2])).to eq([user])
    end

Y
Yorick Peterse 已提交
725
    it 'returns users with a matching Email regardless of the casing' do
726 727 728 729 730 731 732 733 734 735 736
      expect(described_class.search(user.email.upcase)).to eq([user])
    end

    it 'returns users with a matching username' do
      expect(described_class.search(user.username)).to eq([user])
    end

    it 'returns users with a partially matching username' do
      expect(described_class.search(user.username[0..2])).to eq([user])
    end

Y
Yorick Peterse 已提交
737
    it 'returns users with a matching username regardless of the casing' do
738
      expect(described_class.search(user.username.upcase)).to eq([user])
M
Marin Jankovski 已提交
739
    end
740 741 742
  end

  describe '.search_with_secondary_emails' do
D
Douwe Maan 已提交
743
    delegate :search_with_secondary_emails, to: :described_class
744

745 746
    let!(:user) { create(:user, name: 'John Doe', username: 'john.doe', email: 'john.doe@example.com' ) }
    let!(:another_user) { create(:user, name: 'Albert Smith', username: 'albert.smith', email: 'albert.smith@example.com' ) }
747 748 749
    let!(:email) do
      create(:email, user: another_user, email: 'alias@example.com')
    end
750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814

    it 'returns users with a matching name' do
      expect(search_with_secondary_emails(user.name)).to eq([user])
    end

    it 'returns users with a partially matching name' do
      expect(search_with_secondary_emails(user.name[0..2])).to eq([user])
    end

    it 'returns users with a matching name regardless of the casing' do
      expect(search_with_secondary_emails(user.name.upcase)).to eq([user])
    end

    it 'returns users with a matching email' do
      expect(search_with_secondary_emails(user.email)).to eq([user])
    end

    it 'returns users with a partially matching email' do
      expect(search_with_secondary_emails(user.email[0..2])).to eq([user])
    end

    it 'returns users with a matching email regardless of the casing' do
      expect(search_with_secondary_emails(user.email.upcase)).to eq([user])
    end

    it 'returns users with a matching username' do
      expect(search_with_secondary_emails(user.username)).to eq([user])
    end

    it 'returns users with a partially matching username' do
      expect(search_with_secondary_emails(user.username[0..2])).to eq([user])
    end

    it 'returns users with a matching username regardless of the casing' do
      expect(search_with_secondary_emails(user.username.upcase)).to eq([user])
    end

    it 'returns users with a matching whole secondary email' do
      expect(search_with_secondary_emails(email.email)).to eq([email.user])
    end

    it 'returns users with a matching part of secondary email' do
      expect(search_with_secondary_emails(email.email[1..4])).to eq([email.user])
    end

    it 'return users with a matching part of secondary email regardless of case' do
      expect(search_with_secondary_emails(email.email[1..4].upcase)).to eq([email.user])
      expect(search_with_secondary_emails(email.email[1..4].downcase)).to eq([email.user])
      expect(search_with_secondary_emails(email.email[1..4].capitalize)).to eq([email.user])
    end

    it 'returns multiple users with matching secondary emails' do
      email1 = create(:email, email: '1_testemail@example.com')
      email2 = create(:email, email: '2_testemail@example.com')
      email3 = create(:email, email: 'other@email.com')
      email3.user.update_attributes!(email: 'another@mail.com')

      expect(
        search_with_secondary_emails('testemail@example.com').map(&:id)
      ).to include(email1.user.id, email2.user.id)

      expect(
        search_with_secondary_emails('testemail@example.com').map(&:id)
      ).not_to include(email3.user.id)
    end
M
Marin Jankovski 已提交
815 816
  end

Y
Yorick Peterse 已提交
817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833
  describe '.find_by_ssh_key_id' do
    context 'using an existing SSH key ID' do
      let(:user) { create(:user) }
      let(:key) { create(:key, user: user) }

      it 'returns the corresponding User' do
        expect(described_class.find_by_ssh_key_id(key.id)).to eq(user)
      end
    end

    context 'using an invalid SSH key ID' do
      it 'returns nil' do
        expect(described_class.find_by_ssh_key_id(-1)).to be_nil
      end
    end
  end

834 835 836 837
  describe '.by_login' do
    let(:username) { 'John' }
    let!(:user) { create(:user, username: username) }

838
    it 'gets the correct user' do
839 840 841 842 843 844 845 846 847
      expect(User.by_login(user.email.upcase)).to eq user
      expect(User.by_login(user.email)).to eq user
      expect(User.by_login(username.downcase)).to eq user
      expect(User.by_login(username)).to eq user
      expect(User.by_login(nil)).to be_nil
      expect(User.by_login('')).to be_nil
    end
  end

848 849 850 851 852 853 854 855 856 857 858
  describe '.find_by_username' do
    it 'returns nil if not found' do
      expect(described_class.find_by_username('JohnDoe')).to be_nil
    end

    it 'is case-insensitive' do
      user = create(:user, username: 'JohnDoe')
      expect(described_class.find_by_username('JOHNDOE')).to eq user
    end
  end

R
Robert Speicher 已提交
859 860
  describe '.find_by_username!' do
    it 'raises RecordNotFound' do
861 862
      expect { described_class.find_by_username!('JohnDoe') }.
        to raise_error(ActiveRecord::RecordNotFound)
R
Robert Speicher 已提交
863 864 865 866 867 868 869 870
    end

    it 'is case-insensitive' do
      user = create(:user, username: 'JohnDoe')
      expect(described_class.find_by_username!('JOHNDOE')).to eq user
    end
  end

871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929
  describe '.find_by_full_path' do
    let!(:user) { create(:user) }

    context 'with a route matching the given path' do
      let!(:route) { user.namespace.route }

      it 'returns the user' do
        expect(User.find_by_full_path(route.path)).to eq(user)
      end

      it 'is case-insensitive' do
        expect(User.find_by_full_path(route.path.upcase)).to eq(user)
        expect(User.find_by_full_path(route.path.downcase)).to eq(user)
      end
    end

    context 'with a redirect route matching the given path' do
      let!(:redirect_route) { user.namespace.redirect_routes.create(path: 'foo') }

      context 'without the follow_redirects option' do
        it 'returns nil' do
          expect(User.find_by_full_path(redirect_route.path)).to eq(nil)
        end
      end

      context 'with the follow_redirects option set to true' do
        it 'returns the user' do
          expect(User.find_by_full_path(redirect_route.path, follow_redirects: true)).to eq(user)
        end

        it 'is case-insensitive' do
          expect(User.find_by_full_path(redirect_route.path.upcase, follow_redirects: true)).to eq(user)
          expect(User.find_by_full_path(redirect_route.path.downcase, follow_redirects: true)).to eq(user)
        end
      end
    end

    context 'without a route or a redirect route matching the given path' do
      context 'without the follow_redirects option' do
        it 'returns nil' do
          expect(User.find_by_full_path('unknown')).to eq(nil)
        end
      end
      context 'with the follow_redirects option set to true' do
        it 'returns nil' do
          expect(User.find_by_full_path('unknown', follow_redirects: true)).to eq(nil)
        end
      end
    end

    context 'with a group route matching the given path' do
      let!(:group) { create(:group, path: 'group_path') }

      it 'returns nil' do
        expect(User.find_by_full_path('group_path')).to eq(nil)
      end
    end
  end

G
GitLab 已提交
930
  describe 'all_ssh_keys' do
931
    it { is_expected.to have_many(:keys).dependent(:destroy) }
G
GitLab 已提交
932

933
    it "has all ssh keys" do
G
GitLab 已提交
934 935 936
      user = create :user
      key = create :key, key: "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQD33bWLBxu48Sev9Fert1yzEO4WGcWglWF7K/AwblIUFselOt/QdOL9DSjpQGxLagO1s9wl53STIO8qGS4Ms0EJZyIXOEFMjFJ5xmjSy+S37By4sG7SsltQEHMxtbtFOaW5LV2wCrX+rUsRNqLMamZjgjcPO0/EgGCXIGMAYW4O7cwGZdXWYIhQ1Vwy+CsVMDdPkPgBXqK7nR/ey8KMs8ho5fMNgB5hBw/AL9fNGhRw3QTD6Q12Nkhl4VZES2EsZqlpNnJttnPdp847DUsT6yuLRlfiQfz5Cn9ysHFdXObMN5VYIiPFwHeYCZp1X2S4fDZooRE8uOLTfxWHPXwrhqSH", user_id: user.id

937
      expect(user.all_ssh_keys).to include(a_string_starting_with(key.key))
G
GitLab 已提交
938
    end
G
GitLab 已提交
939
  end
940

941
  describe '#avatar_type' do
D
Dmitriy Zaporozhets 已提交
942 943
    let(:user) { create(:user) }

944
    it 'is true if avatar is image' do
D
Dmitriy Zaporozhets 已提交
945
      user.update_attribute(:avatar, 'uploads/avatar.png')
946
      expect(user.avatar_type).to be_truthy
D
Dmitriy Zaporozhets 已提交
947 948
    end

949
    it 'is false if avatar is html page' do
D
Dmitriy Zaporozhets 已提交
950
      user.update_attribute(:avatar, 'uploads/avatar.html')
951
      expect(user.avatar_type).to eq(['only images allowed'])
D
Dmitriy Zaporozhets 已提交
952 953
    end
  end
J
Jerome Dalbert 已提交
954

955 956 957 958 959 960 961 962 963 964 965
  describe '#avatar_url' do
    let(:user) { create(:user, :with_avatar) }
    subject { user.avatar_url }

    context 'when avatar file is uploaded' do
      let(:avatar_path) { "/uploads/user/avatar/#{user.id}/dk.png" }

      it { should eq "http://#{Gitlab.config.gitlab.host}#{avatar_path}" }
    end
  end

966
  describe '#requires_ldap_check?' do
967 968
    let(:user) { User.new }

969 970
    it 'is false when LDAP is disabled' do
      # Create a condition which would otherwise cause 'true' to be returned
971
      allow(user).to receive(:ldap_user?).and_return(true)
972
      user.last_credential_check_at = nil
973
      expect(user.requires_ldap_check?).to be_falsey
974 975
    end

976
    context 'when LDAP is enabled' do
977 978 979
      before do
        allow(Gitlab.config.ldap).to receive(:enabled).and_return(true)
      end
980

981
      it 'is false for non-LDAP users' do
982
        allow(user).to receive(:ldap_user?).and_return(false)
983
        expect(user.requires_ldap_check?).to be_falsey
984 985
      end

986
      context 'and when the user is an LDAP user' do
987 988 989
        before do
          allow(user).to receive(:ldap_user?).and_return(true)
        end
990 991 992

        it 'is true when the user has never had an LDAP check before' do
          user.last_credential_check_at = nil
993
          expect(user.requires_ldap_check?).to be_truthy
994 995 996 997
        end

        it 'is true when the last LDAP check happened over 1 hour ago' do
          user.last_credential_check_at = 2.hours.ago
998
          expect(user.requires_ldap_check?).to be_truthy
999
        end
1000 1001 1002 1003
      end
    end
  end

1004
  context 'ldap synchronized user' do
1005
    describe '#ldap_user?' do
1006 1007 1008 1009
      it 'is true if provider name starts with ldap' do
        user = create(:omniauth_user, provider: 'ldapmain')
        expect(user.ldap_user?).to be_truthy
      end
1010

1011 1012 1013 1014 1015 1016 1017 1018 1019
      it 'is false for other providers' do
        user = create(:omniauth_user, provider: 'other-provider')
        expect(user.ldap_user?).to be_falsey
      end

      it 'is false if no extern_uid is provided' do
        user = create(:omniauth_user, extern_uid: nil)
        expect(user.ldap_user?).to be_falsey
      end
1020 1021
    end

1022
    describe '#ldap_identity' do
1023 1024 1025 1026
      it 'returns ldap identity' do
        user = create :omniauth_user
        expect(user.ldap_identity.provider).not_to be_empty
      end
1027 1028
    end

1029 1030 1031 1032 1033 1034 1035 1036
    describe '#ldap_block' do
      let(:user) { create(:omniauth_user, provider: 'ldapmain', name: 'John Smith') }

      it 'blocks user flaging the action caming from ldap' do
        user.ldap_block
        expect(user.blocked?).to be_truthy
        expect(user.ldap_blocked?).to be_truthy
      end
1037 1038 1039
    end
  end

J
Jerome Dalbert 已提交
1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078
  describe '#full_website_url' do
    let(:user) { create(:user) }

    it 'begins with http if website url omits it' do
      user.website_url = 'test.com'

      expect(user.full_website_url).to eq 'http://test.com'
    end

    it 'begins with http if website url begins with http' do
      user.website_url = 'http://test.com'

      expect(user.full_website_url).to eq 'http://test.com'
    end

    it 'begins with https if website url begins with https' do
      user.website_url = 'https://test.com'

      expect(user.full_website_url).to eq 'https://test.com'
    end
  end

  describe '#short_website_url' do
    let(:user) { create(:user) }

    it 'does not begin with http if website url omits it' do
      user.website_url = 'test.com'

      expect(user.short_website_url).to eq 'test.com'
    end

    it 'does not begin with http if website url begins with http' do
      user.website_url = 'http://test.com'

      expect(user.short_website_url).to eq 'test.com'
    end

    it 'does not begin with https if website url begins with https' do
      user.website_url = 'https://test.com'
1079

J
Jerome Dalbert 已提交
1080 1081
      expect(user.short_website_url).to eq 'test.com'
    end
G
GitLab 已提交
1082
  end
C
Ciro Santilli 已提交
1083

1084 1085
  describe '#starred?' do
    it 'determines if user starred a project' do
1086
      user = create :user
1087 1088
      project1 = create(:empty_project, :public)
      project2 = create(:empty_project, :public)
1089

1090 1091
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_falsey
1092 1093

      star1 = UsersStarProject.create!(project: project1, user: user)
1094 1095
      expect(user.starred?(project1)).to be_truthy
      expect(user.starred?(project2)).to be_falsey
1096 1097

      star2 = UsersStarProject.create!(project: project2, user: user)
1098 1099
      expect(user.starred?(project1)).to be_truthy
      expect(user.starred?(project2)).to be_truthy
1100 1101

      star1.destroy
1102 1103
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_truthy
1104 1105

      star2.destroy
1106 1107
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_falsey
1108 1109 1110
    end
  end

1111 1112
  describe '#toggle_star' do
    it 'toggles stars' do
C
Ciro Santilli 已提交
1113
      user = create :user
1114
      project = create(:empty_project, :public)
C
Ciro Santilli 已提交
1115

1116
      expect(user.starred?(project)).to be_falsey
C
Ciro Santilli 已提交
1117
      user.toggle_star(project)
1118
      expect(user.starred?(project)).to be_truthy
C
Ciro Santilli 已提交
1119
      user.toggle_star(project)
1120
      expect(user.starred?(project)).to be_falsey
C
Ciro Santilli 已提交
1121 1122
    end
  end
V
Valery Sizov 已提交
1123

1124
  describe '#sort' do
V
Valery Sizov 已提交
1125 1126 1127 1128
    before do
      User.delete_all
      @user = create :user, created_at: Date.today, last_sign_in_at: Date.today, name: 'Alpha'
      @user1 = create :user, created_at: Date.today - 1, last_sign_in_at: Date.today - 1, name: 'Omega'
1129
      @user2 = create :user, created_at: Date.today - 2, last_sign_in_at: nil, name: 'Beta'
V
Valery Sizov 已提交
1130
    end
1131

1132 1133 1134 1135 1136 1137 1138 1139
    context 'when sort by recent_sign_in' do
      it 'sorts users by the recent sign-in time' do
        expect(User.sort('recent_sign_in').first).to eq(@user)
      end

      it 'pushes users who never signed in to the end' do
        expect(User.sort('recent_sign_in').third).to eq(@user2)
      end
V
Valery Sizov 已提交
1140 1141
    end

1142 1143 1144 1145 1146 1147 1148 1149
    context 'when sort by oldest_sign_in' do
      it 'sorts users by the oldest sign-in time' do
        expect(User.sort('oldest_sign_in').first).to eq(@user1)
      end

      it 'pushes users who never signed in to the end' do
        expect(User.sort('oldest_sign_in').third).to eq(@user2)
      end
V
Valery Sizov 已提交
1150 1151
    end

1152
    it 'sorts users in descending order by their creation time' do
1153
      expect(User.sort('created_desc').first).to eq(@user)
V
Valery Sizov 已提交
1154 1155
    end

1156 1157
    it 'sorts users in ascending order by their creation time' do
      expect(User.sort('created_asc').first).to eq(@user2)
V
Valery Sizov 已提交
1158 1159
    end

1160 1161
    it 'sorts users by id in descending order when nil is passed' do
      expect(User.sort(nil).first).to eq(@user2)
V
Valery Sizov 已提交
1162 1163
    end
  end
1164

1165
  describe "#contributed_projects" do
1166
    subject { create(:user) }
1167 1168 1169
    let!(:project1) { create(:empty_project) }
    let!(:project2) { create(:empty_project, forked_from_project: project3) }
    let!(:project3) { create(:empty_project) }
1170
    let!(:merge_request) { create(:merge_request, source_project: project2, target_project: project3, author: subject) }
1171 1172
    let!(:push_event) { create(:event, :pushed, project: project1, target: project1, author: subject) }
    let!(:merge_event) { create(:event, :created, project: project3, target: merge_request, author: subject) }
1173 1174 1175 1176 1177 1178 1179

    before do
      project1.team << [subject, :master]
      project2.team << [subject, :master]
    end

    it "includes IDs for projects the user has pushed to" do
1180
      expect(subject.contributed_projects).to include(project1)
1181 1182 1183
    end

    it "includes IDs for projects the user has had merge requests merged into" do
1184
      expect(subject.contributed_projects).to include(project3)
1185 1186 1187
    end

    it "doesn't include IDs for unrelated projects" do
1188
      expect(subject.contributed_projects).not_to include(project2)
1189 1190
    end
  end
1191

1192
  describe '#can_be_removed?' do
1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207
    subject { create(:user) }

    context 'no owned groups' do
      it { expect(subject.can_be_removed?).to be_truthy }
    end

    context 'has owned groups' do
      before do
        group = create(:group)
        group.add_owner(subject)
      end

      it { expect(subject.can_be_removed?).to be_falsey }
    end
  end
1208 1209 1210

  describe "#recent_push" do
    subject { create(:user) }
1211 1212
    let!(:project1) { create(:project, :repository) }
    let!(:project2) { create(:project, :repository, forked_from_project: project1) }
1213
    let!(:push_data) do
1214
      Gitlab::DataBuilder::Push.build_sample(project2, subject)
1215
    end
1216
    let!(:push_event) { create(:event, :pushed, project: project2, target: project1, author: subject, data: push_data) }
1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237

    before do
      project1.team << [subject, :master]
      project2.team << [subject, :master]
    end

    it "includes push event" do
      expect(subject.recent_push).to eq(push_event)
    end

    it "excludes push event if branch has been deleted" do
      allow_any_instance_of(Repository).to receive(:branch_names).and_return(['foo'])

      expect(subject.recent_push).to eq(nil)
    end

    it "excludes push event if MR is opened for it" do
      create(:merge_request, source_project: project2, target_project: project1, source_branch: project2.default_branch, target_branch: 'fix', author: subject)

      expect(subject.recent_push).to eq(nil)
    end
1238 1239 1240 1241 1242 1243

    it "includes push events on any of the provided projects" do
      expect(subject.recent_push(project1)).to eq(nil)
      expect(subject.recent_push(project2)).to eq(push_event)

      push_data1 = Gitlab::DataBuilder::Push.build_sample(project1, subject)
1244
      push_event1 = create(:event, :pushed, project: project1, target: project1, author: subject, data: push_data1)
1245 1246 1247

      expect(subject.recent_push([project1, project2])).to eq(push_event1) # Newest
    end
1248
  end
1249 1250 1251 1252 1253 1254 1255 1256 1257

  describe '#authorized_groups' do
    let!(:user) { create(:user) }
    let!(:private_group) { create(:group) }

    before do
      private_group.add_user(user, Gitlab::Access::MASTER)
    end

1258
    subject { user.authorized_groups }
1259

1260
    it { is_expected.to eq([private_group]) }
1261 1262
  end

1263
  describe '#authorized_projects', truncate: true do
1264 1265 1266 1267
    context 'with a minimum access level' do
      it 'includes projects for which the user is an owner' do
        user = create(:user)
        project = create(:empty_project, :private, namespace: user.namespace)
1268

D
Douwe Maan 已提交
1269 1270
        expect(user.authorized_projects(Gitlab::Access::REPORTER))
          .to contain_exactly(project)
1271
      end
1272

1273 1274 1275 1276 1277
      it 'includes projects for which the user is a master' do
        user = create(:user)
        project = create(:empty_project, :private)

        project.team << [user, Gitlab::Access::MASTER]
1278

D
Douwe Maan 已提交
1279 1280
        expect(user.authorized_projects(Gitlab::Access::REPORTER))
          .to contain_exactly(project)
1281 1282
      end
    end
1283 1284 1285

    it "includes user's personal projects" do
      user    = create(:user)
1286
      project = create(:empty_project, :private, namespace: user.namespace)
1287 1288 1289 1290 1291 1292 1293

      expect(user.authorized_projects).to include(project)
    end

    it "includes personal projects user has been given access to" do
      user1   = create(:user)
      user2   = create(:user)
1294
      project = create(:empty_project, :private, namespace: user1.namespace)
1295 1296 1297 1298 1299 1300 1301 1302

      project.team << [user2, Gitlab::Access::DEVELOPER]

      expect(user2.authorized_projects).to include(project)
    end

    it "includes projects of groups user has been added to" do
      group   = create(:group)
1303
      project = create(:empty_project, group: group)
1304 1305 1306 1307 1308 1309 1310 1311 1312
      user    = create(:user)

      group.add_developer(user)

      expect(user.authorized_projects).to include(project)
    end

    it "does not include projects of groups user has been removed from" do
      group   = create(:group)
1313
      project = create(:empty_project, group: group)
1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324
      user    = create(:user)

      member = group.add_developer(user)
      expect(user.authorized_projects).to include(project)

      member.destroy
      expect(user.authorized_projects).not_to include(project)
    end

    it "includes projects shared with user's group" do
      user    = create(:user)
1325
      project = create(:empty_project, :private)
1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336
      group   = create(:group)

      group.add_reporter(user)
      project.project_group_links.create(group: group)

      expect(user.authorized_projects).to include(project)
    end

    it "does not include destroyed projects user had access to" do
      user1   = create(:user)
      user2   = create(:user)
1337
      project = create(:empty_project, :private, namespace: user1.namespace)
1338 1339 1340 1341 1342 1343 1344 1345 1346 1347

      project.team << [user2, Gitlab::Access::DEVELOPER]
      expect(user2.authorized_projects).to include(project)

      project.destroy
      expect(user2.authorized_projects).not_to include(project)
    end

    it "does not include projects of destroyed groups user had access to" do
      group   = create(:group)
1348
      project = create(:empty_project, namespace: group)
1349 1350 1351 1352 1353 1354 1355 1356
      user    = create(:user)

      group.add_developer(user)
      expect(user.authorized_projects).to include(project)

      group.destroy
      expect(user.authorized_projects).not_to include(project)
    end
1357
  end
1358

1359 1360 1361 1362
  describe '#projects_where_can_admin_issues' do
    let(:user) { create(:user) }

    it 'includes projects for which the user access level is above or equal to reporter' do
1363 1364 1365
      reporter_project  = create(:empty_project) { |p| p.add_reporter(user) }
      developer_project = create(:empty_project) { |p| p.add_developer(user) }
      master_project    = create(:empty_project) { |p| p.add_master(user) }
1366 1367 1368 1369 1370 1371 1372 1373

      expect(user.projects_where_can_admin_issues.to_a).to eq([master_project, developer_project, reporter_project])
      expect(user.can?(:admin_issue, master_project)).to eq(true)
      expect(user.can?(:admin_issue, developer_project)).to eq(true)
      expect(user.can?(:admin_issue, reporter_project)).to eq(true)
    end

    it 'does not include for which the user access level is below reporter' do
1374 1375
      project = create(:empty_project)
      guest_project = create(:empty_project) { |p| p.add_guest(user) }
1376 1377 1378 1379 1380 1381 1382

      expect(user.projects_where_can_admin_issues.to_a).to be_empty
      expect(user.can?(:admin_issue, guest_project)).to eq(false)
      expect(user.can?(:admin_issue, project)).to eq(false)
    end

    it 'does not include archived projects' do
1383
      project = create(:empty_project, :archived)
1384 1385 1386 1387 1388 1389

      expect(user.projects_where_can_admin_issues.to_a).to be_empty
      expect(user.can?(:admin_issue, project)).to eq(false)
    end

    it 'does not include projects for which issues are disabled' do
1390
      project = create(:empty_project, :issues_disabled)
1391 1392 1393 1394 1395 1396

      expect(user.projects_where_can_admin_issues.to_a).to be_empty
      expect(user.can?(:admin_issue, project)).to eq(false)
    end
  end

1397 1398 1399 1400
  describe '#ci_authorized_runners' do
    let(:user) { create(:user) }
    let(:runner) { create(:ci_runner) }

1401 1402 1403
    before do
      project.runners << runner
    end
1404 1405

    context 'without any projects' do
1406
      let(:project) { create(:empty_project) }
1407 1408

      it 'does not load' do
1409
        expect(user.ci_authorized_runners).to be_empty
1410 1411 1412 1413 1414
      end
    end

    context 'with personal projects runners' do
      let(:namespace) { create(:namespace, owner: user) }
1415
      let(:project) { create(:empty_project, namespace: namespace) }
1416 1417

      it 'loads' do
1418
        expect(user.ci_authorized_runners).to contain_exactly(runner)
1419 1420 1421 1422
      end
    end

    shared_examples :member do
1423
      context 'when the user is a master' do
1424 1425 1426
        before do
          add_user(Gitlab::Access::MASTER)
        end
1427

1428 1429 1430
        it 'loads' do
          expect(user.ci_authorized_runners).to contain_exactly(runner)
        end
1431 1432
      end

1433
      context 'when the user is a developer' do
1434 1435 1436
        before do
          add_user(Gitlab::Access::DEVELOPER)
        end
1437

1438 1439 1440
        it 'does not load' do
          expect(user.ci_authorized_runners).to be_empty
        end
1441 1442 1443 1444 1445
      end
    end

    context 'with groups projects runners' do
      let(:group) { create(:group) }
1446
      let(:project) { create(:empty_project, group: group) }
1447

L
Lin Jen-Shin 已提交
1448
      def add_user(access)
1449 1450 1451 1452 1453 1454 1455
        group.add_user(user, access)
      end

      it_behaves_like :member
    end

    context 'with other projects runners' do
1456
      let(:project) { create(:empty_project) }
1457

L
Lin Jen-Shin 已提交
1458
      def add_user(access)
L
Lin Jen-Shin 已提交
1459
        project.team << [user, access]
1460 1461 1462 1463 1464 1465
      end

      it_behaves_like :member
    end
  end

1466 1467
  describe '#viewable_starred_projects' do
    let(:user) { create(:user) }
S
Sean McGivern 已提交
1468 1469 1470
    let(:public_project) { create(:empty_project, :public) }
    let(:private_project) { create(:empty_project, :private) }
    let(:private_viewable_project) { create(:empty_project, :private) }
1471 1472 1473 1474

    before do
      private_viewable_project.team << [user, Gitlab::Access::MASTER]

S
Sean McGivern 已提交
1475 1476 1477
      [public_project, private_project, private_viewable_project].each do |project|
        user.toggle_star(project)
      end
1478 1479
    end

S
Sean McGivern 已提交
1480 1481
    it 'returns only starred projects the user can view' do
      expect(user.viewable_starred_projects).not_to include(private_project)
1482 1483
    end
  end
1484 1485

  describe '#projects_with_reporter_access_limited_to' do
1486 1487
    let(:project1) { create(:empty_project) }
    let(:project2) { create(:empty_project) }
1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507
    let(:user) { create(:user) }

    before do
      project1.team << [user, :reporter]
      project2.team << [user, :guest]
    end

    it 'returns the projects when using a single project ID' do
      projects = user.projects_with_reporter_access_limited_to(project1.id)

      expect(projects).to eq([project1])
    end

    it 'returns the projects when using an Array of project IDs' do
      projects = user.projects_with_reporter_access_limited_to([project1.id])

      expect(projects).to eq([project1])
    end

    it 'returns the projects when using an ActiveRecord relation' do
1508 1509
      projects = user.
        projects_with_reporter_access_limited_to(Project.select(:id))
1510 1511 1512 1513 1514 1515 1516 1517 1518 1519

      expect(projects).to eq([project1])
    end

    it 'does not return projects you do not have reporter access to' do
      projects = user.projects_with_reporter_access_limited_to(project2.id)

      expect(projects).to be_empty
    end
  end
1520

1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535
  describe '#nested_groups' do
    let!(:user) { create(:user) }
    let!(:group) { create(:group) }
    let!(:nested_group) { create(:group, parent: group) }

    before do
      group.add_owner(user)

      # Add more data to ensure method does not include wrong groups
      create(:group).add_owner(create(:user))
    end

    it { expect(user.nested_groups).to eq([nested_group]) }
  end

1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546
  describe '#all_expanded_groups' do
    let!(:user) { create(:user) }
    let!(:group) { create(:group) }
    let!(:nested_group_1) { create(:group, parent: group) }
    let!(:nested_group_2) { create(:group, parent: group) }

    before { nested_group_1.add_owner(user) }

    it { expect(user.all_expanded_groups).to match_array [group, nested_group_1] }
  end

1547
  describe '#nested_groups_projects' do
1548 1549 1550
    let!(:user) { create(:user) }
    let!(:group) { create(:group) }
    let!(:nested_group) { create(:group, parent: group) }
1551 1552
    let!(:project) { create(:empty_project, namespace: group) }
    let!(:nested_project) { create(:empty_project, namespace: nested_group) }
1553 1554 1555 1556 1557

    before do
      group.add_owner(user)

      # Add more data to ensure method does not include wrong projects
1558
      other_project = create(:empty_project, namespace: create(:group, :nested))
1559 1560 1561
      other_project.add_developer(create(:user))
    end

1562
    it { expect(user.nested_groups_projects).to eq([nested_project]) }
1563 1564
  end

1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590
  describe '#refresh_authorized_projects', redis: true do
    let(:project1) { create(:empty_project) }
    let(:project2) { create(:empty_project) }
    let(:user) { create(:user) }

    before do
      project1.team << [user, :reporter]
      project2.team << [user, :guest]

      user.project_authorizations.delete_all
      user.refresh_authorized_projects
    end

    it 'refreshes the list of authorized projects' do
      expect(user.project_authorizations.count).to eq(2)
    end

    it 'sets the authorized_projects_populated column' do
      expect(user.authorized_projects_populated).to eq(true)
    end

    it 'stores the correct access levels' do
      expect(user.project_authorizations.where(access_level: Gitlab::Access::GUEST).exists?).to eq(true)
      expect(user.project_authorizations.where(access_level: Gitlab::Access::REPORTER).exists?).to eq(true)
    end
  end
D
Douwe Maan 已提交
1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623

  describe '#access_level=' do
    let(:user) { build(:user) }

    it 'does nothing for an invalid access level' do
      user.access_level = :invalid_access_level

      expect(user.access_level).to eq(:regular)
      expect(user.admin).to be false
    end

    it "assigns the 'admin' access level" do
      user.access_level = :admin

      expect(user.access_level).to eq(:admin)
      expect(user.admin).to be true
    end

    it "doesn't clear existing access levels when an invalid access level is passed in" do
      user.access_level = :admin
      user.access_level = :invalid_access_level

      expect(user.access_level).to eq(:admin)
      expect(user.admin).to be true
    end

    it "accepts string values in addition to symbols" do
      user.access_level = 'admin'

      expect(user.access_level).to eq(:admin)
      expect(user.admin).to be true
    end
  end
1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646

  describe '.ghost' do
    it "creates a ghost user if one isn't already present" do
      ghost = User.ghost

      expect(ghost).to be_ghost
      expect(ghost).to be_persisted
    end

    it "does not create a second ghost user if one is already present" do
      expect do
        User.ghost
        User.ghost
      end.to change { User.count }.by(1)
      expect(User.ghost).to eq(User.ghost)
    end

    context "when a regular user exists with the username 'ghost'" do
      it "creates a ghost user with a non-conflicting username" do
        create(:user, username: 'ghost')
        ghost = User.ghost

        expect(ghost).to be_persisted
1647
        expect(ghost.username).to eq('ghost1')
1648 1649 1650 1651 1652 1653 1654 1655 1656
      end
    end

    context "when a regular user exists with the email 'ghost@example.com'" do
      it "creates a ghost user with a non-conflicting email" do
        create(:user, email: 'ghost@example.com')
        ghost = User.ghost

        expect(ghost).to be_persisted
1657
        expect(ghost.email).to eq('ghost1@example.com')
1658 1659
      end
    end
1660 1661 1662 1663 1664 1665 1666 1667 1668 1669

    context 'when a domain whitelist is in place' do
      before do
        stub_application_setting(domain_whitelist: ['gitlab.com'])
      end

      it 'creates a ghost user' do
        expect(User.ghost).to be_persisted
      end
    end
1670
  end
1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686

  describe '#update_two_factor_requirement' do
    let(:user) { create :user }

    context 'with 2FA requirement on groups' do
      let(:group1) { create :group, require_two_factor_authentication: true, two_factor_grace_period: 23 }
      let(:group2) { create :group, require_two_factor_authentication: true, two_factor_grace_period: 32 }

      before do
        group1.add_user(user, GroupMember::OWNER)
        group2.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'requires 2FA' do
1687
        expect(user.require_two_factor_authentication_from_group).to be true
1688 1689 1690 1691 1692 1693 1694
      end

      it 'uses the shortest grace period' do
        expect(user.two_factor_grace_period).to be 23
      end
    end

1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705
    context 'with 2FA requirement on nested parent group' do
      let!(:group1) { create :group, require_two_factor_authentication: true }
      let!(:group1a) { create :group, require_two_factor_authentication: false, parent: group1 }

      before do
        group1a.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'requires 2FA' do
1706
        expect(user.require_two_factor_authentication_from_group).to be true
1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720
      end
    end

    context 'with 2FA requirement on nested child group' do
      let!(:group1) { create :group, require_two_factor_authentication: false }
      let!(:group1a) { create :group, require_two_factor_authentication: true, parent: group1 }

      before do
        group1.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'requires 2FA' do
1721
        expect(user.require_two_factor_authentication_from_group).to be true
1722 1723 1724
      end
    end

1725 1726 1727 1728 1729 1730 1731 1732 1733 1734
    context 'without 2FA requirement on groups' do
      let(:group) { create :group }

      before do
        group.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'does not require 2FA' do
1735
        expect(user.require_two_factor_authentication_from_group).to be false
1736 1737 1738 1739 1740 1741 1742
      end

      it 'falls back to the default grace period' do
        expect(user.two_factor_grace_period).to be 48
      end
    end
  end
J
James Lopez 已提交
1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754

  context '.active' do
    before do
      User.ghost
      create(:user, name: 'user', state: 'active')
      create(:user, name: 'user', state: 'blocked')
    end

    it 'only counts active and non internal users' do
      expect(User.active.count).to eq(1)
    end
  end
1755 1756 1757 1758 1759 1760 1761 1762

  describe 'preferred language' do
    it 'is English by default' do
      user = create(:user)

      expect(user.preferred_language).to eq('en')
    end
  end
G
gitlabhq 已提交
1763
end