project_spec.rb 145.3 KB
Newer Older
G
gitlabhq 已提交
1 2
require 'spec_helper'

3
describe Project do
4
  include ProjectForksHelper
5
  include GitHelpers
6

S
Shinya Maeda 已提交
7
  it_behaves_like 'having unique enum values'
S
Shinya Maeda 已提交
8

9
  describe 'associations' do
10 11 12
    it { is_expected.to belong_to(:group) }
    it { is_expected.to belong_to(:namespace) }
    it { is_expected.to belong_to(:creator).class_name('User') }
13
    it { is_expected.to belong_to(:pool_repository) }
14
    it { is_expected.to have_many(:users) }
U
ubudzisz 已提交
15
    it { is_expected.to have_many(:services) }
16 17 18 19 20
    it { is_expected.to have_many(:events) }
    it { is_expected.to have_many(:merge_requests) }
    it { is_expected.to have_many(:issues) }
    it { is_expected.to have_many(:milestones) }
    it { is_expected.to have_many(:project_members).dependent(:delete_all) }
21
    it { is_expected.to have_many(:users).through(:project_members) }
22 23 24 25
    it { is_expected.to have_many(:requesters).dependent(:delete_all) }
    it { is_expected.to have_many(:notes) }
    it { is_expected.to have_many(:snippets).class_name('ProjectSnippet') }
    it { is_expected.to have_many(:deploy_keys_projects) }
26
    it { is_expected.to have_many(:deploy_keys) }
27 28 29 30 31
    it { is_expected.to have_many(:hooks) }
    it { is_expected.to have_many(:protected_branches) }
    it { is_expected.to have_one(:slack_service) }
    it { is_expected.to have_one(:microsoft_teams_service) }
    it { is_expected.to have_one(:mattermost_service) }
32
    it { is_expected.to have_one(:hangouts_chat_service) }
M
Matt Coleman 已提交
33
    it { is_expected.to have_one(:packagist_service) }
34 35 36 37
    it { is_expected.to have_one(:pushover_service) }
    it { is_expected.to have_one(:asana_service) }
    it { is_expected.to have_many(:boards) }
    it { is_expected.to have_one(:campfire_service) }
B
blackst0ne 已提交
38
    it { is_expected.to have_one(:discord_service) }
39 40 41 42 43 44 45 46 47 48 49 50 51 52
    it { is_expected.to have_one(:drone_ci_service) }
    it { is_expected.to have_one(:emails_on_push_service) }
    it { is_expected.to have_one(:pipelines_email_service) }
    it { is_expected.to have_one(:irker_service) }
    it { is_expected.to have_one(:pivotaltracker_service) }
    it { is_expected.to have_one(:flowdock_service) }
    it { is_expected.to have_one(:assembla_service) }
    it { is_expected.to have_one(:slack_slash_commands_service) }
    it { is_expected.to have_one(:mattermost_slash_commands_service) }
    it { is_expected.to have_one(:buildkite_service) }
    it { is_expected.to have_one(:bamboo_service) }
    it { is_expected.to have_one(:teamcity_service) }
    it { is_expected.to have_one(:jira_service) }
    it { is_expected.to have_one(:redmine_service) }
53
    it { is_expected.to have_one(:youtrack_service) }
54 55 56 57 58
    it { is_expected.to have_one(:custom_issue_tracker_service) }
    it { is_expected.to have_one(:bugzilla_service) }
    it { is_expected.to have_one(:gitlab_issue_tracker_service) }
    it { is_expected.to have_one(:external_wiki_service) }
    it { is_expected.to have_one(:project_feature) }
59
    it { is_expected.to have_one(:project_repository) }
60 61
    it { is_expected.to have_one(:statistics).class_name('ProjectStatistics') }
    it { is_expected.to have_one(:import_data).class_name('ProjectImportData') }
U
ubudzisz 已提交
62
    it { is_expected.to have_one(:last_event).class_name('Event') }
63
    it { is_expected.to have_one(:forked_from_project).through(:fork_network_member) }
Z
Zeger-Jan van de Weg 已提交
64
    it { is_expected.to have_one(:auto_devops).class_name('ProjectAutoDevops') }
65
    it { is_expected.to have_one(:error_tracking_setting).class_name('ErrorTracking::ProjectErrorTrackingSetting') }
K
Kamil Trzcinski 已提交
66
    it { is_expected.to have_many(:commit_statuses) }
67
    it { is_expected.to have_many(:ci_pipelines) }
68
    it { is_expected.to have_many(:builds) }
69
    it { is_expected.to have_many(:build_trace_section_names)}
70 71 72 73
    it { is_expected.to have_many(:runner_projects) }
    it { is_expected.to have_many(:runners) }
    it { is_expected.to have_many(:variables) }
    it { is_expected.to have_many(:triggers) }
K
Kamil Trzcinski 已提交
74
    it { is_expected.to have_many(:pages_domains) }
75 76
    it { is_expected.to have_many(:labels).class_name('ProjectLabel') }
    it { is_expected.to have_many(:users_star_projects) }
77
    it { is_expected.to have_many(:repository_languages) }
78 79 80 81 82 83 84
    it { is_expected.to have_many(:environments) }
    it { is_expected.to have_many(:deployments) }
    it { is_expected.to have_many(:todos) }
    it { is_expected.to have_many(:releases) }
    it { is_expected.to have_many(:lfs_objects_projects) }
    it { is_expected.to have_many(:project_group_links) }
    it { is_expected.to have_many(:notification_settings).dependent(:delete_all) }
85 86
    it { is_expected.to have_many(:forked_to_members).class_name('ForkNetworkMember') }
    it { is_expected.to have_many(:forks).through(:forked_to_members) }
J
Jan Provaznik 已提交
87
    it { is_expected.to have_many(:uploads) }
88
    it { is_expected.to have_many(:pipeline_schedules) }
89
    it { is_expected.to have_many(:members_and_requesters) }
M
Matija Čupić 已提交
90
    it { is_expected.to have_many(:clusters) }
91
    it { is_expected.to have_many(:kubernetes_namespaces) }
92
    it { is_expected.to have_many(:custom_attributes).class_name('ProjectCustomAttribute') }
93
    it { is_expected.to have_many(:project_badges).class_name('ProjectBadge') }
94
    it { is_expected.to have_many(:lfs_file_locks) }
M
Mayra Cabrera 已提交
95 96
    it { is_expected.to have_many(:project_deploy_tokens) }
    it { is_expected.to have_many(:deploy_tokens).through(:project_deploy_tokens) }
97

98 99 100 101
    it 'has an inverse relationship with merge requests' do
      expect(described_class.reflect_on_association(:merge_requests).has_inverse?).to eq(:target_project)
    end

F
Felipe Artur 已提交
102 103
    context 'after initialized' do
      it "has a project_feature" do
104
        expect(described_class.new.project_feature).to be_present
105 106 107
      end
    end

108 109 110 111 112 113 114 115 116
    context 'when creating a new project' do
      it 'automatically creates a CI/CD settings row' do
        project = create(:project)

        expect(project.ci_cd_settings).to be_an_instance_of(ProjectCiCdSetting)
        expect(project.ci_cd_settings).to be_persisted
      end
    end

117 118 119 120
    context 'updating cd_cd_settings' do
      it 'does not raise an error' do
        project = create(:project)

J
James Lopez 已提交
121
        expect { project.update(ci_cd_settings: nil) }.not_to raise_exception
122 123 124
      end
    end

125
    describe '#members & #requesters' do
126
      let(:project) { create(:project, :public, :access_requestable) }
127 128 129 130
      let(:requester) { create(:user) }
      let(:developer) { create(:user) }
      before do
        project.request_access(requester)
131
        project.add_developer(developer)
132 133
      end

134 135
      it_behaves_like 'members and requesters associations' do
        let(:namespace) { project }
136 137
      end
    end
138

139
    describe 'ci_pipelines association' do
140 141
      it 'returns only pipelines from ci_sources' do
        expect(Ci::Pipeline).to receive(:ci_sources).and_call_original
142

143
        subject.ci_pipelines
144 145
      end
    end
G
gitlabhq 已提交
146 147
  end

148 149 150 151 152 153 154 155
  describe 'modules' do
    subject { described_class }

    it { is_expected.to include_module(Gitlab::ConfigHelper) }
    it { is_expected.to include_module(Gitlab::ShellAdapter) }
    it { is_expected.to include_module(Gitlab::VisibilityLevel) }
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
156 157
  end

158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175
  describe '.missing_kubernetes_namespace' do
    let!(:project) { create(:project) }
    let!(:cluster) { create(:cluster, :provided_by_user, :group) }
    let(:kubernetes_namespaces) { project.kubernetes_namespaces }

    subject { described_class.missing_kubernetes_namespace(kubernetes_namespaces) }

    it { is_expected.to contain_exactly(project) }

    context 'kubernetes namespace exists' do
      before do
        create(:cluster_kubernetes_namespace, project: project, cluster: cluster)
      end

      it { is_expected.to be_empty }
    end
  end

176
  describe 'validation' do
177
    let!(:project) { create(:project) }
178

179 180
    it { is_expected.to validate_presence_of(:name) }
    it { is_expected.to validate_uniqueness_of(:name).scoped_to(:namespace_id) }
181
    it { is_expected.to validate_length_of(:name).is_at_most(255) }
182
    it { is_expected.to validate_presence_of(:path) }
183 184
    it { is_expected.to validate_length_of(:path).is_at_most(255) }
    it { is_expected.to validate_length_of(:description).is_at_most(2000) }
185 186 187
    it { is_expected.to validate_length_of(:ci_config_path).is_at_most(255) }
    it { is_expected.to allow_value('').for(:ci_config_path) }
    it { is_expected.not_to allow_value('test/../foo').for(:ci_config_path) }
188
    it { is_expected.not_to allow_value('/test/foo').for(:ci_config_path) }
189 190
    it { is_expected.to validate_presence_of(:creator) }
    it { is_expected.to validate_presence_of(:namespace) }
191
    it { is_expected.to validate_presence_of(:repository_storage) }
192

193 194 195 196 197 198 199 200
    it 'validates build timeout constraints' do
      is_expected.to validate_numericality_of(:build_timeout)
        .only_integer
        .is_greater_than_or_equal_to(10.minutes)
        .is_less_than(1.month)
        .with_message('needs to be beetween 10 minutes and 1 month')
    end

201
    it 'does not allow new projects beyond user limits' do
202
      project2 = build(:project)
203 204 205 206 207 208 209

      allow(project2)
        .to receive(:creator)
        .and_return(
          double(can_create_project?: false, projects_limit: 0).as_null_object
        )

210
      expect(project2).not_to be_valid
211
    end
212 213 214

    describe 'wiki path conflict' do
      context "when the new path has been used by the wiki of other Project" do
215
        it 'has an error on the name attribute' do
216
          new_project = build_stubbed(:project, namespace_id: project.namespace_id, path: "#{project.path}.wiki")
217 218 219 220 221 222 223

          expect(new_project).not_to be_valid
          expect(new_project.errors[:name].first).to eq('has already been taken')
        end
      end

      context "when the new wiki path has been used by the path of other Project" do
224
        it 'has an error on the name attribute' do
225 226
          project_with_wiki_suffix = create(:project, path: 'foo.wiki')
          new_project = build_stubbed(:project, namespace_id: project_with_wiki_suffix.namespace_id, path: 'foo')
227 228 229 230 231 232

          expect(new_project).not_to be_valid
          expect(new_project.errors[:name].first).to eq('has already been taken')
        end
      end
    end
233

234
    context 'repository storages inclusion' do
235
      let(:project2) { build(:project, repository_storage: 'missing') }
236 237

      before do
238
        storages = { 'custom' => { 'path' => 'tmp/tests/custom_repositories' } }
239 240 241
        allow(Gitlab.config.repositories).to receive(:storages).and_return(storages)
      end

242
      it "does not allow repository storages that don't match a label in the configuration" do
243 244 245 246
        expect(project2).not_to be_valid
        expect(project2.errors[:repository_storage].first).to match(/is not included in the list/)
      end
    end
247

248 249 250
    describe 'import_url' do
      it 'does not allow an invalid URI as import_url' do
        project = build(:project, import_url: 'invalid://')
J
James Lopez 已提交
251

252 253
        expect(project).not_to be_valid
      end
254

255 256 257
      it 'does allow a SSH URI as import_url for persisted projects' do
        project = create(:project)
        project.import_url = 'ssh://test@gitlab.com/project.git'
258

259 260
        expect(project).to be_valid
      end
261

262 263
      it 'does not allow a SSH URI as import_url for new projects' do
        project = build(:project, import_url: 'ssh://test@gitlab.com/project.git')
264

265 266
        expect(project).not_to be_valid
      end
J
James Lopez 已提交
267

268 269
      it 'does allow a valid URI as import_url' do
        project = build(:project, import_url: 'http://gitlab.com/project.git')
J
James Lopez 已提交
270

271 272
        expect(project).to be_valid
      end
273

274 275
      it 'allows an empty URI' do
        project = build(:project, import_url: '')
276

277 278
        expect(project).to be_valid
      end
279

280 281
      it 'does not produce import data on an empty URI' do
        project = build(:project, import_url: '')
282

283 284
        expect(project.import_data).to be_nil
      end
285

286 287
      it 'does not produce import data on an invalid URI' do
        project = build(:project, import_url: 'test://')
288

289 290
        expect(project.import_data).to be_nil
      end
291

292 293
      it "does not allow import_url pointing to localhost" do
        project = build(:project, import_url: 'http://localhost:9000/t.git')
294

295 296 297
        expect(project).to be_invalid
        expect(project.errors[:import_url].first).to include('Requests to localhost are not allowed')
      end
298

299 300 301 302 303 304 305
      it 'does not allow import_url pointing to the local network' do
        project = build(:project, import_url: 'https://192.168.1.1')

        expect(project).to be_invalid
        expect(project.errors[:import_url].first).to include('Requests to the local network are not allowed')
      end

306 307
      it "does not allow import_url with invalid ports for new projects" do
        project = build(:project, import_url: 'http://github.com:25/t.git')
D
Douwe Maan 已提交
308

309 310 311
        expect(project).to be_invalid
        expect(project.errors[:import_url].first).to include('Only allowed ports are 80, 443')
      end
D
Douwe Maan 已提交
312

313 314 315
      it "does not allow import_url with invalid ports for persisted projects" do
        project = create(:project)
        project.import_url = 'http://github.com:25/t.git'
D
Douwe Maan 已提交
316

317 318 319
        expect(project).to be_invalid
        expect(project.errors[:import_url].first).to include('Only allowed ports are 22, 80, 443')
      end
D
Douwe Maan 已提交
320

321 322
      it "does not allow import_url with invalid user" do
        project = build(:project, import_url: 'http://$user:password@github.com/t.git')
323

324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341
        expect(project).to be_invalid
        expect(project.errors[:import_url].first).to include('Username needs to start with an alphanumeric character')
      end

      include_context 'invalid urls'

      it 'does not allow urls with CR or LF characters' do
        project = build(:project)

        aggregate_failures do
          urls_with_CRLF.each do |url|
            project.import_url = url

            expect(project).not_to be_valid
            expect(project.errors.full_messages.first).to match(/is blocked: URI is invalid/)
          end
        end
      end
342 343
    end

344 345
    describe 'project pending deletion' do
      let!(:project_pending_deletion) do
346
        create(:project,
347 348 349
               pending_delete: true)
      end
      let(:new_project) do
350
        build(:project,
351 352 353 354 355 356 357 358 359 360 361 362
              name: project_pending_deletion.name,
              namespace: project_pending_deletion.namespace)
      end

      before do
        new_project.validate
      end

      it 'contains errors related to the project being deleted' do
        expect(new_project.errors.full_messages.first).to eq('The project is still being deleted. Please try again later.')
      end
    end
363 364 365

    describe 'path validation' do
      it 'allows paths reserved on the root namespace' do
366
        project = build(:project, path: 'api')
367 368 369 370 371

        expect(project).to be_valid
      end

      it 'rejects paths reserved on another level' do
372
        project = build(:project, path: 'tree')
373 374 375

        expect(project).not_to be_valid
      end
376 377 378

      it 'rejects nested paths' do
        parent = create(:group, :nested, path: 'environments')
379
        project = build(:project, path: 'folders', namespace: parent)
380 381 382

        expect(project).not_to be_valid
      end
383 384 385

      it 'allows a reserved group name' do
        parent = create(:group)
386
        project = build(:project, path: 'avatar', namespace: parent)
387 388 389

        expect(project).to be_valid
      end
390 391 392 393 394 395

      it 'allows a path ending in a period' do
        project = build(:project, path: 'foo.')

        expect(project).to be_valid
      end
396
    end
G
gitlabhq 已提交
397
  end
398

399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422
  describe '#all_pipelines' do
    let(:project) { create(:project) }

    before do
      create(:ci_pipeline, project: project, ref: 'master', source: :web)
      create(:ci_pipeline, project: project, ref: 'master', source: :external)
    end

    it 'has all pipelines' do
      expect(project.all_pipelines.size).to eq(2)
    end

    context 'when builds are disabled' do
      before do
        project.project_feature.update_attribute(:builds_access_level, ProjectFeature::DISABLED)
      end

      it 'should return .external pipelines' do
        expect(project.all_pipelines).to all(have_attributes(source: 'external'))
        expect(project.all_pipelines.size).to eq(1)
      end
    end
  end

423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446
  describe '#ci_pipelines' do
    let(:project) { create(:project) }

    before do
      create(:ci_pipeline, project: project, ref: 'master', source: :web)
      create(:ci_pipeline, project: project, ref: 'master', source: :external)
    end

    it 'has ci pipelines' do
      expect(project.ci_pipelines.size).to eq(2)
    end

    context 'when builds are disabled' do
      before do
        project.project_feature.update_attribute(:builds_access_level, ProjectFeature::DISABLED)
      end

      it 'should return .external pipelines' do
        expect(project.ci_pipelines).to all(have_attributes(source: 'external'))
        expect(project.ci_pipelines.size).to eq(1)
      end
    end
  end

K
Kamil Trzcinski 已提交
447
  describe 'project token' do
448
    it 'sets an random token if none provided' do
449
      project = FactoryBot.create(:project, runners_token: '')
K
Kamil Trzcinski 已提交
450
      expect(project.runners_token).not_to eq('')
K
Kamil Trzcinski 已提交
451 452
    end

U
ubudzisz 已提交
453
    it 'does not set an random token if one provided' do
454
      project = FactoryBot.create(:project, runners_token: 'my-token')
K
Kamil Trzcinski 已提交
455
      expect(project.runners_token).to eq('my-token')
K
Kamil Trzcinski 已提交
456 457
    end
  end
G
gitlabhq 已提交
458

459
  describe 'Respond to' do
460 461 462 463 464
    it { is_expected.to respond_to(:url_to_repo) }
    it { is_expected.to respond_to(:repo_exists?) }
    it { is_expected.to respond_to(:execute_hooks) }
    it { is_expected.to respond_to(:owner) }
    it { is_expected.to respond_to(:path_with_namespace) }
465
    it { is_expected.to respond_to(:full_path) }
G
gitlabhq 已提交
466 467
  end

468
  describe 'delegation' do
469
    [:add_guest, :add_reporter, :add_developer, :add_maintainer, :add_user, :add_users].each do |method|
470 471 472 473 474
      it { is_expected.to delegate_method(method).to(:team) }
    end

    it { is_expected.to delegate_method(:members).to(:team).with_prefix(true) }
    it { is_expected.to delegate_method(:name).to(:owner).with_prefix(true).with_arguments(allow_nil: true) }
475 476
    it { is_expected.to delegate_method(:group_clusters_enabled?).to(:group).with_arguments(allow_nil: true) }
    it { is_expected.to delegate_method(:root_ancestor).to(:namespace).with_arguments(allow_nil: true) }
477
    it { is_expected.to delegate_method(:last_pipeline).to(:commit).with_arguments(allow_nil: true) }
478 479
  end

480 481 482 483 484 485 486 487 488
  describe '#to_reference_with_postfix' do
    it 'returns the full path with reference_postfix' do
      namespace = create(:namespace, path: 'sample-namespace')
      project = create(:project, path: 'sample-project', namespace: namespace)

      expect(project.to_reference_with_postfix).to eq 'sample-namespace/sample-project>'
    end
  end

489
  describe '#to_reference' do
490
    let(:owner)     { create(:user, name: 'Gitlab') }
491
    let(:namespace) { create(:namespace, path: 'sample-namespace', owner: owner) }
492
    let(:project)   { create(:project, path: 'sample-project', namespace: namespace) }
493
    let(:group)     { create(:group, name: 'Group', path: 'sample-group') }
494

495
    context 'when nil argument' do
496 497 498 499 500
      it 'returns nil' do
        expect(project.to_reference).to be_nil
      end
    end

501
    context 'when full is true' do
502
      it 'returns complete path to the project' do
503 504 505
        expect(project.to_reference(full: true)).to          eq 'sample-namespace/sample-project'
        expect(project.to_reference(project, full: true)).to eq 'sample-namespace/sample-project'
        expect(project.to_reference(group, full: true)).to   eq 'sample-namespace/sample-project'
506 507 508 509 510 511 512 513 514 515
      end
    end

    context 'when same project argument' do
      it 'returns nil' do
        expect(project.to_reference(project)).to be_nil
      end
    end

    context 'when cross namespace project argument' do
516
      let(:another_namespace_project) { create(:project, name: 'another-project') }
517 518 519 520 521 522 523

      it 'returns complete path to the project' do
        expect(project.to_reference(another_namespace_project)).to eq 'sample-namespace/sample-project'
      end
    end

    context 'when same namespace / cross-project argument' do
524
      let(:another_project) { create(:project, namespace: namespace) }
525

526
      it 'returns path to the project' do
527 528 529
        expect(project.to_reference(another_project)).to eq 'sample-project'
      end
    end
530

531 532
    context 'when different namespace / cross-project argument' do
      let(:another_namespace) { create(:namespace, path: 'another-namespace', owner: owner) }
533
      let(:another_project)   { create(:project, path: 'another-project', namespace: another_namespace) }
534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550

      it 'returns full path to the project' do
        expect(project.to_reference(another_project)).to eq 'sample-namespace/sample-project'
      end
    end

    context 'when argument is a namespace' do
      context 'with same project path' do
        it 'returns path to the project' do
          expect(project.to_reference(namespace)).to eq 'sample-project'
        end
      end

      context 'with different project path' do
        it 'returns full path to the project' do
          expect(project.to_reference(group)).to eq 'sample-namespace/sample-project'
        end
551 552
      end
    end
553 554 555 556 557
  end

  describe '#to_human_reference' do
    let(:owner) { create(:user, name: 'Gitlab') }
    let(:namespace) { create(:namespace, name: 'Sample namespace', owner: owner) }
558
    let(:project) { create(:project, name: 'Sample project', namespace: namespace) }
559 560 561 562 563 564 565 566 567 568 569 570 571 572

    context 'when nil argument' do
      it 'returns nil' do
        expect(project.to_human_reference).to be_nil
      end
    end

    context 'when same project argument' do
      it 'returns nil' do
        expect(project.to_human_reference(project)).to be_nil
      end
    end

    context 'when cross namespace project argument' do
573
      let(:another_namespace_project) { create(:project, name: 'another-project') }
574 575 576 577 578 579 580

      it 'returns complete name with namespace of the project' do
        expect(project.to_human_reference(another_namespace_project)).to eq 'Gitlab / Sample project'
      end
    end

    context 'when same namespace / cross-project argument' do
581
      let(:another_project) { create(:project, namespace: namespace) }
582 583 584 585

      it 'returns name of the project' do
        expect(project.to_human_reference(another_project)).to eq 'Sample project'
      end
586 587 588
    end
  end

V
Valery Sizov 已提交
589
  describe '#merge_method' do
590 591 592 593 594 595 596
    using RSpec::Parameterized::TableSyntax

    where(:ff, :rebase, :method) do
      true  | true  | :ff
      true  | false | :ff
      false | true  | :rebase_merge
      false | false | :merge
V
Valery Sizov 已提交
597 598
    end

599 600 601 602 603 604
    with_them do
      let(:project) { build(:project, merge_requests_rebase_enabled: rebase, merge_requests_ff_only_enabled: ff) }

      subject { project.merge_method }

      it { is_expected.to eq(method) }
V
Valery Sizov 已提交
605 606 607
    end
  end

608
  it 'returns valid url to repo' do
609
    project = described_class.new(path: 'somewhere')
610
    expect(project.url_to_repo).to eq(Gitlab.config.gitlab_shell.ssh_path_prefix + 'somewhere.git')
G
gitlabhq 已提交
611 612
  end

D
Douwe Maan 已提交
613
  describe "#web_url" do
614
    let(:project) { create(:project, path: "somewhere") }
D
Douwe Maan 已提交
615 616

    it 'returns the full web URL for this repo' do
617
      expect(project.web_url).to eq("#{Gitlab.config.gitlab.url}/#{project.namespace.full_path}/somewhere")
D
Douwe Maan 已提交
618
    end
A
Ariejan de Vroom 已提交
619 620
  end

I
Imre Farkas 已提交
621 622
  describe "#readme_url" do
    context 'with a non-existing repository' do
623
      let(:project) { create(:project) }
I
Imre Farkas 已提交
624

625
      it 'returns nil' do
I
Imre Farkas 已提交
626 627 628 629 630 631
        expect(project.readme_url).to be_nil
      end
    end

    context 'with an existing repository' do
      context 'when no README exists' do
632
        let(:project) { create(:project, :empty_repo) }
I
Imre Farkas 已提交
633

634
        it 'returns nil' do
I
Imre Farkas 已提交
635 636 637 638 639
          expect(project.readme_url).to be_nil
        end
      end

      context 'when a README exists' do
640 641
        let(:project) { create(:project, :repository) }

I
Imre Farkas 已提交
642
        it 'returns the README' do
643
          expect(project.readme_url).to eq("#{project.web_url}/blob/master/README.md")
I
Imre Farkas 已提交
644 645 646 647 648
        end
      end
    end
  end

J
Jan Provaznik 已提交
649
  describe "#new_issuable_address" do
650
    let(:project) { create(:project, path: "somewhere") }
651 652
    let(:user) { create(:user) }

653 654 655 656 657 658
    context 'incoming email enabled' do
      before do
        stub_incoming_email_setting(enabled: true, address: "p+%{key}@gl.ab")
      end

      it 'returns the address to create a new issue' do
659
        address = "p+#{project.full_path_slug}-#{project.project_id}-#{user.incoming_email_token}-issue@gl.ab"
660

J
Jan Provaznik 已提交
661 662 663 664
        expect(project.new_issuable_address(user, 'issue')).to eq(address)
      end

      it 'returns the address to create a new merge request' do
665
        address = "p+#{project.full_path_slug}-#{project.project_id}-#{user.incoming_email_token}-merge-request@gl.ab"
J
Jan Provaznik 已提交
666 667

        expect(project.new_issuable_address(user, 'merge_request')).to eq(address)
668
      end
669 670 671 672

      it 'returns nil with invalid address type' do
        expect(project.new_issuable_address(user, 'invalid_param')).to be_nil
      end
673 674 675 676 677 678
    end

    context 'incoming email disabled' do
      before do
        stub_incoming_email_setting(enabled: false)
      end
679

680
      it 'returns nil' do
J
Jan Provaznik 已提交
681 682 683 684 685
        expect(project.new_issuable_address(user, 'issue')).to be_nil
      end

      it 'returns nil' do
        expect(project.new_issuable_address(user, 'merge_request')).to be_nil
686
      end
687 688 689
    end
  end

690
  describe 'last_activity methods' do
S
Stan Hu 已提交
691 692
    let(:timestamp) { 2.hours.ago }
    # last_activity_at gets set to created_at upon creation
693
    let(:project) { create(:project, created_at: timestamp, updated_at: timestamp) }
G
gitlabhq 已提交
694

695
    describe 'last_activity' do
696
      it 'alias last_activity to last_event' do
697
        last_event = create(:event, :closed, project: project)
698

699
        expect(project.last_activity).to eq(last_event)
700
      end
G
gitlabhq 已提交
701 702
    end

703 704
    describe 'last_activity_date' do
      it 'returns the creation date of the project\'s last event if present' do
705
        new_event = create(:event, :closed, project: project, created_at: Time.now)
706

S
Stan Hu 已提交
707
        project.reload
708
        expect(project.last_activity_at.to_i).to eq(new_event.created_at.to_i)
709
      end
710

711
      it 'returns the project\'s last update date if it has no events' do
712
        expect(project.last_activity_date).to eq(project.updated_at)
713
      end
714 715

      it 'returns the most recent timestamp' do
L
Lin Jen-Shin 已提交
716 717 718
        project.update(updated_at: nil,
                       last_activity_at: timestamp,
                       last_repository_updated_at: timestamp - 1.hour)
719

720
        expect(project.last_activity_date).to be_like_time(timestamp)
721

L
Lin Jen-Shin 已提交
722 723 724
        project.update(updated_at: timestamp,
                       last_activity_at: timestamp - 1.hour,
                       last_repository_updated_at: nil)
725

726
        expect(project.last_activity_date).to be_like_time(timestamp)
727
      end
728 729
    end
  end
730

731
  describe '#get_issue' do
732
    let(:project) { create(:project) }
S
Stan Hu 已提交
733
    let!(:issue)  { create(:issue, project: project) }
734 735 736
    let(:user)    { create(:user) }

    before do
737
      project.add_developer(user)
738
    end
739 740 741

    context 'with default issues tracker' do
      it 'returns an issue' do
742
        expect(project.get_issue(issue.iid, user)).to eq issue
743 744
      end

S
Stan Hu 已提交
745 746 747 748
      it 'returns count of open issues' do
        expect(project.open_issues_count).to eq(1)
      end

749
      it 'returns nil when no issue found' do
750 751 752 753 754 755
        expect(project.get_issue(999, user)).to be_nil
      end

      it "returns nil when user doesn't have access" do
        user = create(:user)
        expect(project.get_issue(issue.iid, user)).to eq nil
756 757 758 759
      end
    end

    context 'with external issues tracker' do
760
      let!(:internal_issue) { create(:issue, project: project) }
761
      before do
762
        allow(project).to receive(:external_issue_tracker).and_return(true)
763 764
      end

765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801
      context 'when internal issues are enabled' do
        it 'returns interlan issue' do
          issue = project.get_issue(internal_issue.iid, user)

          expect(issue).to be_kind_of(Issue)
          expect(issue.iid).to eq(internal_issue.iid)
          expect(issue.project).to eq(project)
        end

        it 'returns an ExternalIssue when internal issue does not exists' do
          issue = project.get_issue('FOO-1234', user)

          expect(issue).to be_kind_of(ExternalIssue)
          expect(issue.iid).to eq('FOO-1234')
          expect(issue.project).to eq(project)
        end
      end

      context 'when internal issues are disabled' do
        before do
          project.issues_enabled = false
          project.save!
        end

        it 'returns always an External issues' do
          issue = project.get_issue(internal_issue.iid, user)
          expect(issue).to be_kind_of(ExternalIssue)
          expect(issue.iid).to eq(internal_issue.iid.to_s)
          expect(issue.project).to eq(project)
        end

        it 'returns an ExternalIssue when internal issue does not exists' do
          issue = project.get_issue('FOO-1234', user)
          expect(issue).to be_kind_of(ExternalIssue)
          expect(issue.iid).to eq('FOO-1234')
          expect(issue.project).to eq(project)
        end
802 803 804 805 806
      end
    end
  end

  describe '#issue_exists?' do
807
    let(:project) { create(:project) }
808 809 810 811 812 813 814 815 816 817 818 819

    it 'is truthy when issue exists' do
      expect(project).to receive(:get_issue).and_return(double)
      expect(project.issue_exists?(1)).to be_truthy
    end

    it 'is falsey when issue does not exist' do
      expect(project).to receive(:get_issue).and_return(nil)
      expect(project.issue_exists?(1)).to be_falsey
    end
  end

L
Lin Jen-Shin 已提交
820
  describe '#to_param' do
821 822
    context 'with namespace' do
      before do
823
        @group = create(:group, name: 'gitlab')
824
        @project = create(:project, name: 'gitlabhq', namespace: @group)
825 826
      end

V
Vinnie Okada 已提交
827
      it { expect(@project.to_param).to eq('gitlabhq') }
828
    end
829 830 831

    context 'with invalid path' do
      it 'returns previous path to keep project suitable for use in URLs when persisted' do
832
        project = create(:project, path: 'gitlab')
833 834 835 836 837 838 839
        project.path = 'foo&bar'

        expect(project).not_to be_valid
        expect(project.to_param).to eq 'gitlab'
      end

      it 'returns current path when new record' do
840
        project = build(:project, path: 'gitlab')
841 842 843 844 845 846
        project.path = 'foo&bar'

        expect(project).not_to be_valid
        expect(project.to_param).to eq 'foo&bar'
      end
    end
847
  end
D
Dmitriy Zaporozhets 已提交
848

L
Lin Jen-Shin 已提交
849
  describe '#repository' do
850
    let(:project) { create(:project, :repository) }
D
Dmitriy Zaporozhets 已提交
851

852
    it 'returns valid repo' do
853
      expect(project.repository).to be_kind_of(Repository)
D
Dmitriy Zaporozhets 已提交
854 855
    end
  end
856

L
Lin Jen-Shin 已提交
857
  describe '#default_issues_tracker?' do
858
    it "is true if used internal tracker" do
859
      project = build(:project)
860

861
      expect(project.default_issues_tracker?).to be_truthy
862 863
    end

864
    it "is false if used other tracker" do
865 866 867 868
      # NOTE: The current nature of this factory requires persistence
      project = create(:redmine_project)

      expect(project.default_issues_tracker?).to be_falsey
869 870 871
    end
  end

872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889
  describe '#empty_repo?' do
    context 'when the repo does not exist' do
      let(:project) { build_stubbed(:project) }

      it 'returns true' do
        expect(project.empty_repo?).to be(true)
      end
    end

    context 'when the repo exists' do
      let(:project) { create(:project, :repository) }
      let(:empty_project) { create(:project, :empty_repo) }

      it { expect(empty_project.empty_repo?).to be(true) }
      it { expect(project.empty_repo?).to be(false) }
    end
  end

L
Lin Jen-Shin 已提交
890
  describe '#external_issue_tracker' do
891
    let(:project) { create(:project) }
892 893 894
    let(:ext_project) { create(:redmine_project) }

    context 'on existing projects with no value for has_external_issue_tracker' do
895
      before do
896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924
        project.update_column(:has_external_issue_tracker, nil)
        ext_project.update_column(:has_external_issue_tracker, nil)
      end

      it 'updates the has_external_issue_tracker boolean' do
        expect do
          project.external_issue_tracker
        end.to change { project.reload.has_external_issue_tracker }.to(false)

        expect do
          ext_project.external_issue_tracker
        end.to change { ext_project.reload.has_external_issue_tracker }.to(true)
      end
    end

    it 'returns nil and does not query services when there is no external issue tracker' do
      expect(project).not_to receive(:services)

      expect(project.external_issue_tracker).to eq(nil)
    end

    it 'retrieves external_issue_tracker querying services and cache it when there is external issue tracker' do
      ext_project.reload # Factory returns a project with changed attributes
      expect(ext_project).to receive(:services).once.and_call_original

      2.times { expect(ext_project.external_issue_tracker).to be_a_kind_of(RedmineService) }
    end
  end

L
Lin Jen-Shin 已提交
925
  describe '#cache_has_external_issue_tracker' do
926
    let(:project) { create(:project, has_external_issue_tracker: nil) }
927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944

    it 'stores true if there is any external_issue_tracker' do
      services = double(:service, external_issue_trackers: [RedmineService.new])
      expect(project).to receive(:services).and_return(services)

      expect do
        project.cache_has_external_issue_tracker
      end.to change { project.has_external_issue_tracker}.to(true)
    end

    it 'stores false if there is no external_issue_tracker' do
      services = double(:service, external_issue_trackers: [])
      expect(project).to receive(:services).and_return(services)

      expect do
        project.cache_has_external_issue_tracker
      end.to change { project.has_external_issue_tracker}.to(false)
    end
T
Toon Claes 已提交
945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982

    it 'does not cache data when in a read-only GitLab instance' do
      allow(Gitlab::Database).to receive(:read_only?) { true }

      expect do
        project.cache_has_external_issue_tracker
      end.not_to change { project.has_external_issue_tracker }
    end
  end

  describe '#cache_has_external_wiki' do
    let(:project) { create(:project, has_external_wiki: nil) }

    it 'stores true if there is any external_wikis' do
      services = double(:service, external_wikis: [ExternalWikiService.new])
      expect(project).to receive(:services).and_return(services)

      expect do
        project.cache_has_external_wiki
      end.to change { project.has_external_wiki}.to(true)
    end

    it 'stores false if there is no external_wikis' do
      services = double(:service, external_wikis: [])
      expect(project).to receive(:services).and_return(services)

      expect do
        project.cache_has_external_wiki
      end.to change { project.has_external_wiki}.to(false)
    end

    it 'does not cache data when in a read-only GitLab instance' do
      allow(Gitlab::Database).to receive(:read_only?) { true }

      expect do
        project.cache_has_external_wiki
      end.not_to change { project.has_external_wiki }
    end
983 984
  end

985
  describe '#has_wiki?' do
986 987 988
    let(:no_wiki_project)       { create(:project, :wiki_disabled, has_external_wiki: false) }
    let(:wiki_enabled_project)  { create(:project) }
    let(:external_wiki_project) { create(:project, has_external_wiki: true) }
989 990 991 992 993 994 995 996

    it 'returns true if project is wiki enabled or has external wiki' do
      expect(wiki_enabled_project).to have_wiki
      expect(external_wiki_project).to have_wiki
      expect(no_wiki_project).not_to have_wiki
    end
  end

997
  describe '#external_wiki' do
998
    let(:project) { create(:project) }
999

1000 1001 1002 1003 1004
    context 'with an active external wiki' do
      before do
        create(:service, project: project, type: 'ExternalWikiService', active: true)
        project.external_wiki
      end
1005

1006 1007 1008
      it 'sets :has_external_wiki as true' do
        expect(project.has_external_wiki).to be(true)
      end
1009

1010 1011
      it 'sets :has_external_wiki as false if an external wiki service is destroyed later' do
        expect(project.has_external_wiki).to be(true)
1012

1013 1014 1015 1016
        project.services.external_wikis.first.destroy

        expect(project.has_external_wiki).to be(false)
      end
1017 1018
    end

1019 1020 1021 1022
    context 'with an inactive external wiki' do
      before do
        create(:service, project: project, type: 'ExternalWikiService', active: false)
      end
1023

1024 1025 1026
      it 'sets :has_external_wiki as false' do
        expect(project.has_external_wiki).to be(false)
      end
1027 1028
    end

1029 1030 1031 1032
    context 'with no external wiki' do
      before do
        project.external_wiki
      end
1033

1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044
      it 'sets :has_external_wiki as false' do
        expect(project.has_external_wiki).to be(false)
      end

      it 'sets :has_external_wiki as true if an external wiki service is created later' do
        expect(project.has_external_wiki).to be(false)

        create(:service, project: project, type: 'ExternalWikiService', active: true)

        expect(project.has_external_wiki).to be(true)
      end
1045 1046 1047
    end
  end

1048 1049
  describe '#star_count' do
    it 'counts stars from multiple users' do
1050 1051
      user1 = create(:user)
      user2 = create(:user)
1052
      project = create(:project, :public)
C
Ciro Santilli 已提交
1053 1054

      expect(project.star_count).to eq(0)
1055

C
Ciro Santilli 已提交
1056
      user1.toggle_star(project)
1057 1058
      expect(project.reload.star_count).to eq(1)

C
Ciro Santilli 已提交
1059
      user2.toggle_star(project)
1060 1061 1062
      project.reload
      expect(project.reload.star_count).to eq(2)

C
Ciro Santilli 已提交
1063
      user1.toggle_star(project)
1064 1065 1066
      project.reload
      expect(project.reload.star_count).to eq(1)

C
Ciro Santilli 已提交
1067
      user2.toggle_star(project)
1068 1069 1070 1071
      project.reload
      expect(project.reload.star_count).to eq(0)
    end

1072
    it 'counts stars on the right project' do
1073
      user = create(:user)
1074 1075
      project1 = create(:project, :public)
      project2 = create(:project, :public)
1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102

      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project1)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(1)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project1)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project2)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(1)

      user.toggle_star(project2)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)
C
Ciro Santilli 已提交
1103 1104
    end
  end
1105

L
Lin Jen-Shin 已提交
1106
  describe '#avatar_type' do
1107
    let(:project) { create(:project) }
1108

1109
    it 'is true if avatar is image' do
1110
      project.update_attribute(:avatar, 'uploads/avatar.png')
1111
      expect(project.avatar_type).to be_truthy
1112 1113
    end

1114
    it 'is false if avatar is html page' do
1115
      project.update_attribute(:avatar, 'uploads/avatar.html')
1116
      expect(project.avatar_type).to eq(['file format is not supported. Please try one of the following supported formats: png, jpg, jpeg, gif, bmp, tiff, ico'])
1117 1118
    end
  end
S
sue445 已提交
1119

L
Lin Jen-Shin 已提交
1120
  describe '#avatar_url' do
S
sue445 已提交
1121 1122
    subject { project.avatar_url }

1123
    let(:project) { create(:project) }
S
sue445 已提交
1124

1125
    context 'when avatar file is uploaded' do
T
Tim Zallmann 已提交
1126
      let(:project) { create(:project, :public, :with_avatar) }
S
sue445 已提交
1127

1128
      it 'shows correct url' do
1129 1130
        expect(project.avatar_url).to eq(project.avatar.url)
        expect(project.avatar_url(only_path: false)).to eq([Gitlab.config.gitlab.url, project.avatar.url].join)
1131
      end
S
sue445 已提交
1132 1133
    end

1134
    context 'when avatar file in git' do
S
sue445 已提交
1135 1136 1137 1138
      before do
        allow(project).to receive(:avatar_in_git) { true }
      end

1139
      let(:avatar_path) { "/#{project.full_path}/avatar" }
S
sue445 已提交
1140

1141
      it { is_expected.to eq "http://#{Gitlab.config.gitlab.host}#{avatar_path}" }
S
sue445 已提交
1142
    end
1143 1144

    context 'when git repo is empty' do
1145
      let(:project) { create(:project) }
1146

1147
      it { is_expected.to eq nil }
1148
    end
S
sue445 已提交
1149
  end
1150

1151
  describe '#pipeline_for' do
1152
    let(:project) { create(:project, :repository) }
1153
    let!(:pipeline) { create_pipeline(project) }
K
Kamil Trzcinski 已提交
1154

1155 1156
    shared_examples 'giving the correct pipeline' do
      it { is_expected.to eq(pipeline) }
K
Kamil Trzcinski 已提交
1157

1158
      context 'return latest' do
1159
        let!(:pipeline2) { create_pipeline(project) }
K
Kamil Trzcinski 已提交
1160

1161
        it { is_expected.to eq(pipeline2) }
K
Kamil Trzcinski 已提交
1162
      end
1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175
    end

    context 'with explicit sha' do
      subject { project.pipeline_for('master', pipeline.sha) }

      it_behaves_like 'giving the correct pipeline'
    end

    context 'with implicit sha' do
      subject { project.pipeline_for('master') }

      it_behaves_like 'giving the correct pipeline'
    end
1176
  end
1177

L
Lin Jen-Shin 已提交
1178
  describe '#builds_enabled' do
1179
    let(:project) { create(:project) }
1180

1181 1182 1183
    subject { project.builds_enabled }

    it { expect(project.builds_enabled?).to be_truthy }
1184
  end
Y
Yorick Peterse 已提交
1185

1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197
  describe '.sort_by_attribute' do
    it 'reorders the input relation by start count desc' do
      project1 = create(:project, star_count: 2)
      project2 = create(:project, star_count: 1)
      project3 = create(:project)

      projects = described_class.sort_by_attribute(:stars_desc)

      expect(projects).to eq([project1, project2, project3])
    end
  end

1198
  describe '.with_shared_runners' do
1199
    subject { described_class.with_shared_runners }
1200 1201

    context 'when shared runners are enabled for project' do
1202
      let!(:project) { create(:project, shared_runners_enabled: true) }
1203 1204 1205 1206 1207 1208 1209

      it "returns a project" do
        is_expected.to eq([project])
      end
    end

    context 'when shared runners are disabled for project' do
1210
      let!(:project) { create(:project, shared_runners_enabled: false) }
1211 1212 1213 1214 1215 1216 1217

      it "returns an empty array" do
        is_expected.to be_empty
      end
    end
  end

1218
  describe '.cached_count', :use_clean_rails_memory_store_caching do
1219
    let(:group)     { create(:group, :public) }
1220 1221
    let!(:project1) { create(:project, :public, group: group) }
    let!(:project2) { create(:project, :public, group: group) }
1222 1223

    it 'returns total project count' do
1224
      expect(described_class).to receive(:count).once.and_call_original
1225 1226

      3.times do
1227
        expect(described_class.cached_count).to eq(2)
1228 1229 1230 1231
      end
    end
  end

Y
Yorick Peterse 已提交
1232
  describe '.trending' do
F
Felipe Artur 已提交
1233
    let(:group)    { create(:group, :public) }
1234 1235
    let(:project1) { create(:project, :public, group: group) }
    let(:project2) { create(:project, :public, group: group) }
Y
Yorick Peterse 已提交
1236 1237 1238 1239 1240 1241 1242 1243

    before do
      2.times do
        create(:note_on_commit, project: project1)
      end

      create(:note_on_commit, project: project2)

Y
Yorick Peterse 已提交
1244
      TrendingProject.refresh!
Y
Yorick Peterse 已提交
1245 1246
    end

Y
Yorick Peterse 已提交
1247
    subject { described_class.trending.to_a }
Y
Yorick Peterse 已提交
1248

Y
Yorick Peterse 已提交
1249 1250
    it 'sorts projects by the amount of notes in descending order' do
      expect(subject).to eq([project1, project2])
Y
Yorick Peterse 已提交
1251
    end
1252 1253 1254 1255 1256 1257 1258 1259

    it 'does not take system notes into account' do
      10.times do
        create(:note_on_commit, project: project2, system: true)
      end

      expect(described_class.trending.to_a).to eq([project1, project2])
    end
Y
Yorick Peterse 已提交
1260
  end
Y
Yorick Peterse 已提交
1261

T
Toon Claes 已提交
1262 1263 1264 1265
  describe '.starred_by' do
    it 'returns only projects starred by the given user' do
      user1 = create(:user)
      user2 = create(:user)
1266 1267 1268
      project1 = create(:project)
      project2 = create(:project)
      create(:project)
T
Toon Claes 已提交
1269 1270 1271
      user1.toggle_star(project1)
      user2.toggle_star(project2)

1272
      expect(described_class.starred_by(user1)).to contain_exactly(project1)
T
Toon Claes 已提交
1273 1274 1275
    end
  end

Y
Yorick Peterse 已提交
1276
  describe '.visible_to_user' do
1277
    let!(:project) { create(:project, :private) }
Y
Yorick Peterse 已提交
1278 1279 1280 1281 1282 1283
    let!(:user)    { create(:user) }

    subject { described_class.visible_to_user(user) }

    describe 'when a user has access to a project' do
      before do
1284
        project.add_user(user, Gitlab::Access::MAINTAINER)
Y
Yorick Peterse 已提交
1285 1286 1287 1288 1289 1290 1291 1292 1293
      end

      it { is_expected.to eq([project]) }
    end

    describe 'when a user does not have access to any projects' do
      it { is_expected.to eq([]) }
    end
  end
K
Kamil Trzcinski 已提交
1294

1295
  context 'repository storage by default' do
1296
    let(:project) { build(:project) }
1297 1298

    before do
1299
      storages = {
1300 1301
        'default' => Gitlab::GitalyClient::StorageSettings.new('path' => 'tmp/tests/repositories'),
        'picked'  => Gitlab::GitalyClient::StorageSettings.new('path' => 'tmp/tests/repositories')
1302
      }
1303 1304 1305
      allow(Gitlab.config.repositories).to receive(:storages).and_return(storages)
    end

1306 1307 1308 1309 1310
    it 'picks storage from ApplicationSetting' do
      expect_any_instance_of(ApplicationSetting).to receive(:pick_repository_storage).and_return('picked')

      expect(project.repository_storage).to eq('picked')
    end
1311 1312
  end

K
Kamil Trzcinski 已提交
1313
  context 'shared runners by default' do
1314
    let(:project) { create(:project) }
K
Kamil Trzcinski 已提交
1315 1316 1317 1318

    subject { project.shared_runners_enabled }

    context 'are enabled' do
1319 1320 1321
      before do
        stub_application_setting(shared_runners_enabled: true)
      end
K
Kamil Trzcinski 已提交
1322 1323 1324 1325 1326

      it { is_expected.to be_truthy }
    end

    context 'are disabled' do
1327 1328 1329
      before do
        stub_application_setting(shared_runners_enabled: false)
      end
K
Kamil Trzcinski 已提交
1330 1331 1332 1333 1334

      it { is_expected.to be_falsey }
    end
  end

1335
  describe '#any_runners?' do
1336
    context 'shared runners' do
1337
      let(:project) { create(:project, shared_runners_enabled: shared_runners_enabled) }
1338 1339
      let(:specific_runner) { create(:ci_runner, :project, projects: [project]) }
      let(:shared_runner) { create(:ci_runner, :instance) }
K
Kamil Trzcinski 已提交
1340

1341 1342
      context 'for shared runners disabled' do
        let(:shared_runners_enabled) { false }
1343

1344 1345 1346
        it 'has no runners available' do
          expect(project.any_runners?).to be_falsey
        end
1347

1348
        it 'has a specific runner' do
1349
          specific_runner
1350

1351 1352 1353 1354 1355
          expect(project.any_runners?).to be_truthy
        end

        it 'has a shared runner, but they are prohibited to use' do
          shared_runner
1356

1357 1358
          expect(project.any_runners?).to be_falsey
        end
1359

1360
        it 'checks the presence of specific runner' do
1361
          specific_runner
1362

1363 1364
          expect(project.any_runners? { |runner| runner == specific_runner }).to be_truthy
        end
1365 1366

        it 'returns false if match cannot be found' do
1367
          specific_runner
1368

1369 1370
          expect(project.any_runners? { false }).to be_falsey
        end
K
Kamil Trzcinski 已提交
1371
      end
1372

1373 1374 1375 1376 1377
      context 'for shared runners enabled' do
        let(:shared_runners_enabled) { true }

        it 'has a shared runner' do
          shared_runner
1378

1379 1380 1381 1382 1383
          expect(project.any_runners?).to be_truthy
        end

        it 'checks the presence of shared runner' do
          shared_runner
1384

1385 1386
          expect(project.any_runners? { |runner| runner == shared_runner }).to be_truthy
        end
1387 1388 1389

        it 'returns false if match cannot be found' do
          shared_runner
1390

1391 1392
          expect(project.any_runners? { false }).to be_falsey
        end
K
Kamil Trzcinski 已提交
1393 1394
      end
    end
1395

1396
    context 'group runners' do
1397 1398
      let(:project) { create(:project, group_runners_enabled: group_runners_enabled) }
      let(:group) { create(:group, projects: [project]) }
1399
      let(:group_runner) { create(:ci_runner, :group, groups: [group]) }
1400 1401 1402

      context 'for group runners disabled' do
        let(:group_runners_enabled) { false }
1403

1404 1405 1406 1407 1408 1409
        it 'has no runners available' do
          expect(project.any_runners?).to be_falsey
        end

        it 'has a group runner, but they are prohibited to use' do
          group_runner
1410

1411 1412
          expect(project.any_runners?).to be_falsey
        end
K
Kamil Trzcinski 已提交
1413 1414
      end

1415 1416 1417 1418 1419
      context 'for group runners enabled' do
        let(:group_runners_enabled) { true }

        it 'has a group runner' do
          group_runner
1420

1421 1422 1423 1424 1425
          expect(project.any_runners?).to be_truthy
        end

        it 'checks the presence of group runner' do
          group_runner
1426

1427 1428
          expect(project.any_runners? { |runner| runner == group_runner }).to be_truthy
        end
1429 1430 1431

        it 'returns false if match cannot be found' do
          group_runner
1432

1433 1434
          expect(project.any_runners? { false }).to be_falsey
        end
K
Kamil Trzcinski 已提交
1435 1436 1437
      end
    end
  end
1438

1439
  describe '#shared_runners' do
1440
    let!(:runner) { create(:ci_runner, :instance) }
1441 1442 1443 1444

    subject { project.shared_runners }

    context 'when shared runners are enabled for project' do
1445
      let!(:project) { create(:project, shared_runners_enabled: true) }
1446 1447 1448 1449 1450 1451 1452

      it "returns a list of shared runners" do
        is_expected.to eq([runner])
      end
    end

    context 'when shared runners are disabled for project' do
1453
      let!(:project) { create(:project, shared_runners_enabled: false) }
1454 1455 1456 1457 1458 1459 1460

      it "returns a empty list" do
        is_expected.to be_empty
      end
    end
  end

1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478
  describe '#visibility_level' do
    let(:project) { build(:project) }

    subject { project.visibility_level }

    context 'by default' do
      it { is_expected.to eq(Gitlab::VisibilityLevel::PRIVATE) }
    end

    context 'when set to INTERNAL in application settings' do
      before do
        stub_application_setting(default_project_visibility: Gitlab::VisibilityLevel::INTERNAL)
      end

      it { is_expected.to eq(Gitlab::VisibilityLevel::INTERNAL) }
    end
  end

1479
  describe '#visibility_level_allowed?' do
1480
    let(:project) { create(:project, :internal) }
1481 1482 1483 1484 1485 1486 1487 1488

    context 'when checking on non-forked project' do
      it { expect(project.visibility_level_allowed?(Gitlab::VisibilityLevel::PRIVATE)).to be_truthy }
      it { expect(project.visibility_level_allowed?(Gitlab::VisibilityLevel::INTERNAL)).to be_truthy }
      it { expect(project.visibility_level_allowed?(Gitlab::VisibilityLevel::PUBLIC)).to be_truthy }
    end

    context 'when checking on forked project' do
1489
      let(:project)        { create(:project, :internal) }
1490
      let(:forked_project) { fork_project(project) }
1491 1492 1493 1494 1495

      it { expect(forked_project.visibility_level_allowed?(Gitlab::VisibilityLevel::PRIVATE)).to be_truthy }
      it { expect(forked_project.visibility_level_allowed?(Gitlab::VisibilityLevel::INTERNAL)).to be_truthy }
      it { expect(forked_project.visibility_level_allowed?(Gitlab::VisibilityLevel::PUBLIC)).to be_falsey }
    end
1496
  end
1497

1498
  describe '#pages_deployed?' do
1499
    let(:project) { create(:project) }
1500 1501 1502 1503

    subject { project.pages_deployed? }

    context 'if public folder does exist' do
1504 1505 1506
      before do
        allow(Dir).to receive(:exist?).with(project.public_pages_path).and_return(true)
      end
1507 1508 1509 1510 1511 1512 1513 1514 1515

      it { is_expected.to be_truthy }
    end

    context "if public folder doesn't exist" do
      it { is_expected.to be_falsey }
    end
  end

1516
  describe '#pages_url' do
1517 1518
    let(:group) { create(:group, name: group_name) }
    let(:project) { create(:project, namespace: group, name: project_name) }
1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539
    let(:domain) { 'Example.com' }

    subject { project.pages_url }

    before do
      allow(Settings.pages).to receive(:host).and_return(domain)
      allow(Gitlab.config.pages).to receive(:url).and_return('http://example.com')
    end

    context 'group page' do
      let(:group_name) { 'Group' }
      let(:project_name) { 'group.example.com' }

      it { is_expected.to eq("http://group.example.com") }
    end

    context 'project page' do
      let(:group_name) { 'Group' }
      let(:project_name) { 'Project' }

      it { is_expected.to eq("http://group.example.com/project") }
1540 1541 1542 1543
    end
  end

  describe '#pages_group_url' do
1544 1545
    let(:group) { create(:group, name: group_name) }
    let(:project) { create(:project, namespace: group, name: project_name) }
1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567
    let(:domain) { 'Example.com' }
    let(:port) { 1234 }

    subject { project.pages_group_url }

    before do
      allow(Settings.pages).to receive(:host).and_return(domain)
      allow(Gitlab.config.pages).to receive(:url).and_return("http://example.com:#{port}")
    end

    context 'group page' do
      let(:group_name) { 'Group' }
      let(:project_name) { 'group.example.com' }

      it { is_expected.to eq("http://group.example.com:#{port}") }
    end

    context 'project page' do
      let(:group_name) { 'Group' }
      let(:project_name) { 'Project' }

      it { is_expected.to eq("http://group.example.com:#{port}") }
1568 1569 1570
    end
  end

1571
  describe '.search' do
1572
    let(:project) { create(:project, description: 'kitten mittens') }
1573

1574 1575 1576
    it 'returns projects with a matching name' do
      expect(described_class.search(project.name)).to eq([project])
    end
1577

1578 1579 1580
    it 'returns projects with a partially matching name' do
      expect(described_class.search(project.name[0..2])).to eq([project])
    end
1581

1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609
    it 'returns projects with a matching name regardless of the casing' do
      expect(described_class.search(project.name.upcase)).to eq([project])
    end

    it 'returns projects with a matching description' do
      expect(described_class.search(project.description)).to eq([project])
    end

    it 'returns projects with a partially matching description' do
      expect(described_class.search('kitten')).to eq([project])
    end

    it 'returns projects with a matching description regardless of the casing' do
      expect(described_class.search('KITTEN')).to eq([project])
    end

    it 'returns projects with a matching path' do
      expect(described_class.search(project.path)).to eq([project])
    end

    it 'returns projects with a partially matching path' do
      expect(described_class.search(project.path[0..2])).to eq([project])
    end

    it 'returns projects with a matching path regardless of the casing' do
      expect(described_class.search(project.path.upcase)).to eq([project])
    end

1610
    describe 'with pending_delete project' do
1611
      let(:pending_delete_project) { create(:project, pending_delete: true) }
1612 1613 1614 1615 1616 1617 1618

      it 'shows pending deletion project' do
        search_result = described_class.search(pending_delete_project.name)

        expect(search_result).to eq([pending_delete_project])
      end
    end
1619
  end
1620

Y
Yorick Peterse 已提交
1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667
  describe '.optionally_search' do
    let(:project) { create(:project) }

    it 'searches for projects matching the query if one is given' do
      relation = described_class.optionally_search(project.name)

      expect(relation).to eq([project])
    end

    it 'returns the current relation if no search query is given' do
      relation = described_class.where(id: project.id)

      expect(relation.optionally_search).to eq(relation)
    end
  end

  describe '.paginate_in_descending_order_using_id' do
    let!(:project1) { create(:project) }
    let!(:project2) { create(:project) }

    it 'orders the relation in descending order' do
      expect(described_class.paginate_in_descending_order_using_id)
        .to eq([project2, project1])
    end

    it 'applies a limit to the relation' do
      expect(described_class.paginate_in_descending_order_using_id(limit: 1))
        .to eq([project2])
    end

    it 'limits projects by and ID when given' do
      expect(described_class.paginate_in_descending_order_using_id(before: project2.id))
        .to eq([project1])
    end
  end

  describe '.including_namespace_and_owner' do
    it 'eager loads the namespace and namespace owner' do
      create(:project)

      row = described_class.eager_load_namespace_and_owner.to_a.first
      recorder = ActiveRecord::QueryRecorder.new { row.namespace.owner }

      expect(recorder.count).to be_zero
    end
  end

1668
  describe '#expire_caches_before_rename' do
1669
    let(:project) { create(:project, :repository) }
1670 1671 1672 1673
    let(:repo)    { double(:repo, exists?: true) }
    let(:wiki)    { double(:wiki, exists?: true) }

    it 'expires the caches of the repository and wiki' do
1674 1675 1676
      allow(Repository).to receive(:new)
        .with('foo', project)
        .and_return(repo)
1677

1678 1679 1680
      allow(Repository).to receive(:new)
        .with('foo.wiki', project)
        .and_return(wiki)
1681

1682 1683
      expect(repo).to receive(:before_delete)
      expect(wiki).to receive(:before_delete)
1684 1685 1686 1687

      project.expire_caches_before_rename('foo')
    end
  end
1688 1689

  describe '.search_by_title' do
1690
    let(:project) { create(:project, name: 'kittens') }
1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703

    it 'returns projects with a matching name' do
      expect(described_class.search_by_title(project.name)).to eq([project])
    end

    it 'returns projects with a partially matching name' do
      expect(described_class.search_by_title('kitten')).to eq([project])
    end

    it 'returns projects with a matching name regardless of the casing' do
      expect(described_class.search_by_title('KITTENS')).to eq([project])
    end
  end
1704 1705 1706 1707 1708

  context 'when checking projects from groups' do
    let(:private_group)    { create(:group, visibility_level: 0)  }
    let(:internal_group)   { create(:group, visibility_level: 10) }

1709 1710
    let(:private_project)  { create(:project, :private, group: private_group) }
    let(:internal_project) { create(:project, :internal, group: internal_group) }
1711 1712 1713 1714 1715 1716 1717 1718 1719

    context 'when group is private project can not be internal' do
      it { expect(private_project.visibility_level_allowed?(Gitlab::VisibilityLevel::INTERNAL)).to be_falsey }
    end

    context 'when group is internal project can not be public' do
      it { expect(internal_project.visibility_level_allowed?(Gitlab::VisibilityLevel::PUBLIC)).to be_falsey }
    end
  end
1720

1721
  describe '#track_project_repository' do
1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736
    shared_examples 'tracks storage location' do
      context 'when a project repository entry does not exist' do
        it 'creates a new entry' do
          expect { project.track_project_repository }.to change(project, :project_repository)
        end

        it 'tracks the project storage location' do
          project.track_project_repository

          expect(project.project_repository).to have_attributes(
            disk_path: project.disk_path,
            shard_name: project.repository_storage
          )
        end
      end
1737

1738 1739 1740 1741 1742 1743 1744
      context 'when a tracking entry exists' do
        let!(:project_repository) { create(:project_repository, project: project) }
        let!(:shard) { create(:shard, name: 'foo') }

        it 'does not create a new entry in the database' do
          expect { project.track_project_repository }.not_to change(project, :project_repository)
        end
1745

1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757
        it 'updates the project storage location' do
          allow(project).to receive(:disk_path).and_return('fancy/new/path')
          allow(project).to receive(:repository_storage).and_return('foo')

          project.track_project_repository

          expect(project.project_repository).to have_attributes(
            disk_path: 'fancy/new/path',
            shard_name: 'foo'
          )
        end
      end
1758 1759
    end

1760 1761
    context 'with projects on legacy storage' do
      let(:project) { create(:project, :repository, :legacy_storage) }
1762

1763 1764
      it_behaves_like 'tracks storage location'
    end
1765

1766 1767
    context 'with projects on hashed storage' do
      let(:project) { create(:project, :repository) }
1768

1769
      it_behaves_like 'tracks storage location'
1770 1771 1772
    end
  end

1773
  describe '#create_repository' do
1774
    let(:project) { create(:project, :repository) }
1775 1776 1777 1778 1779 1780 1781 1782
    let(:shell) { Gitlab::Shell.new }

    before do
      allow(project).to receive(:gitlab_shell).and_return(shell)
    end

    context 'using a regular repository' do
      it 'creates the repository' do
1783
        expect(shell).to receive(:create_repository)
1784
          .with(project.repository_storage, project.disk_path, project.full_path)
1785
          .and_return(true)
1786 1787 1788 1789 1790 1791 1792

        expect(project.repository).to receive(:after_create)

        expect(project.create_repository).to eq(true)
      end

      it 'adds an error if the repository could not be created' do
1793
        expect(shell).to receive(:create_repository)
1794
          .with(project.repository_storage, project.disk_path, project.full_path)
1795
          .and_return(false)
1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806

        expect(project.repository).not_to receive(:after_create)

        expect(project.create_repository).to eq(false)
        expect(project.errors).not_to be_empty
      end
    end

    context 'using a forked repository' do
      it 'does nothing' do
        expect(project).to receive(:forked?).and_return(true)
1807
        expect(shell).not_to receive(:create_repository)
1808 1809 1810 1811 1812

        project.create_repository
      end
    end
  end
1813

1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825
  describe '#ensure_repository' do
    let(:project) { create(:project, :repository) }
    let(:shell) { Gitlab::Shell.new }

    before do
      allow(project).to receive(:gitlab_shell).and_return(shell)
    end

    it 'creates the repository if it not exist' do
      allow(project).to receive(:repository_exists?)
        .and_return(false)

1826
      allow(shell).to receive(:create_repository)
1827
        .with(project.repository_storage, project.disk_path, project.full_path)
1828 1829
        .and_return(true)

1830
      expect(project).to receive(:create_repository).with(force: true)
1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842

      project.ensure_repository
    end

    it 'does not create the repository if it exists' do
      allow(project).to receive(:repository_exists?)
        .and_return(true)

      expect(project).not_to receive(:create_repository)

      project.ensure_repository
    end
1843 1844 1845 1846 1847 1848 1849

    it 'creates the repository if it is a fork' do
      expect(project).to receive(:forked?).and_return(true)

      allow(project).to receive(:repository_exists?)
        .and_return(false)

1850
      expect(shell).to receive(:create_repository)
1851
        .with(project.repository_storage, project.disk_path, project.full_path)
1852 1853 1854 1855
        .and_return(true)

      project.ensure_repository
    end
1856 1857
  end

1858 1859 1860 1861 1862 1863 1864 1865 1866 1867
  describe 'handling import URL' do
    it 'returns the sanitized URL' do
      project = create(:project, :import_started, import_url: 'http://user:pass@test.com')

      project.import_state.finish

      expect(project.reload.import_url).to eq('http://test.com')
    end
  end

A
Andre Guedes 已提交
1868
  describe '#container_registry_url' do
1869
    let(:project) { create(:project) }
K
Kamil Trzcinski 已提交
1870

A
Andre Guedes 已提交
1871
    subject { project.container_registry_url }
K
Kamil Trzcinski 已提交
1872

1873 1874 1875
    before do
      stub_container_registry_config(**registry_settings)
    end
K
Kamil Trzcinski 已提交
1876 1877 1878

    context 'for enabled registry' do
      let(:registry_settings) do
1879 1880
        { enabled: true,
          host_port: 'example.com' }
K
Kamil Trzcinski 已提交
1881 1882
      end

1883
      it { is_expected.not_to be_nil }
K
Kamil Trzcinski 已提交
1884 1885 1886 1887
    end

    context 'for disabled registry' do
      let(:registry_settings) do
1888
        { enabled: false }
K
Kamil Trzcinski 已提交
1889 1890 1891 1892 1893 1894
      end

      it { is_expected.to be_nil }
    end
  end

1895
  describe '#has_container_registry_tags?' do
1896
    let(:project) { create(:project) }
1897 1898

    context 'when container registry is enabled' do
1899 1900 1901
      before do
        stub_container_registry_config(enabled: true)
      end
1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938

      context 'when tags are present for multi-level registries' do
        before do
          create(:container_repository, project: project, name: 'image')

          stub_container_registry_tags(repository: /image/,
                                       tags: %w[latest rc1])
        end

        it 'should have image tags' do
          expect(project).to have_container_registry_tags
        end
      end

      context 'when tags are present for root repository' do
        before do
          stub_container_registry_tags(repository: project.full_path,
                                       tags: %w[latest rc1 pre1])
        end

        it 'should have image tags' do
          expect(project).to have_container_registry_tags
        end
      end

      context 'when there are no tags at all' do
        before do
          stub_container_registry_tags(repository: :any, tags: [])
        end

        it 'should not have image tags' do
          expect(project).not_to have_container_registry_tags
        end
      end
    end

    context 'when container registry is disabled' do
1939 1940 1941
      before do
        stub_container_registry_config(enabled: false)
      end
1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958

      it 'should not have image tags' do
        expect(project).not_to have_container_registry_tags
      end

      it 'should not check root repository tags' do
        expect(project).not_to receive(:full_path)
        expect(project).not_to have_container_registry_tags
      end

      it 'should iterate through container repositories' do
        expect(project).to receive(:container_repositories)
        expect(project).not_to have_container_registry_tags
      end
    end
  end

1959
  describe '#ci_config_path=' do
1960
    let(:project) { create(:project) }
1961 1962

    it 'sets nil' do
1963
      project.update!(ci_config_path: nil)
1964

1965
      expect(project.ci_config_path).to be_nil
1966 1967 1968
    end

    it 'sets a string' do
1969
      project.update!(ci_config_path: 'foo/.gitlab_ci.yml')
1970

1971
      expect(project.ci_config_path).to eq('foo/.gitlab_ci.yml')
1972 1973
    end

1974 1975
    it 'sets a string but removes all null characters' do
      project.update!(ci_config_path: "f\0oo/\0/.gitlab_ci.yml")
1976

1977
      expect(project.ci_config_path).to eq('foo//.gitlab_ci.yml')
1978 1979 1980
    end
  end

1981
  describe '#latest_successful_build_for' do
1982
    let(:project) { create(:project, :repository) }
1983
    let(:pipeline) { create_pipeline(project) }
L
Lin Jen-Shin 已提交
1984 1985

    context 'with many builds' do
1986
      it 'gives the latest builds from latest pipeline' do
1987 1988
        pipeline1 = create_pipeline(project)
        pipeline2 = create_pipeline(project)
1989 1990
        create_build(pipeline1, 'test')
        create_build(pipeline1, 'test2')
1991
        build1_p2 = create_build(pipeline2, 'test')
1992
        create_build(pipeline2, 'test2')
L
Lin Jen-Shin 已提交
1993

1994 1995
        expect(project.latest_successful_build_for(build1_p2.name))
          .to eq(build1_p2)
L
Lin Jen-Shin 已提交
1996 1997
      end
    end
L
Lin Jen-Shin 已提交
1998

L
Lin Jen-Shin 已提交
1999
    context 'with succeeded pipeline' do
L
Lin Jen-Shin 已提交
2000
      let!(:build) { create_build }
2001

L
Lin Jen-Shin 已提交
2002
      context 'standalone pipeline' do
2003
        it 'returns builds for ref for default_branch' do
2004 2005 2006
          expect(project.latest_successful_build_for(build.name))
            .to eq(build)
        end
2007

2008 2009 2010
        it 'returns empty relation if the build cannot be found' do
          expect(project.latest_successful_build_for('TAIL'))
            .to be_nil
2011
        end
2012
      end
2013

2014 2015 2016 2017
      context 'with some pending pipeline' do
        before do
          create_build(create_pipeline(project, 'pending'))
        end
2018

2019 2020 2021
        it 'gives the latest build from latest pipeline' do
          expect(project.latest_successful_build_for(build.name))
            .to eq(build)
2022
        end
2023 2024
      end
    end
2025

2026 2027 2028 2029
    context 'with pending pipeline' do
      it 'returns empty relation' do
        pipeline.update(status: 'pending')
        pending_build = create_build(pipeline)
2030

2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065
        expect(project.latest_successful_build_for(pending_build.name)).to be_nil
      end
    end
  end

  describe '#latest_successful_build_for!' do
    let(:project) { create(:project, :repository) }
    let(:pipeline) { create_pipeline(project) }

    context 'with many builds' do
      it 'gives the latest builds from latest pipeline' do
        pipeline1 = create_pipeline(project)
        pipeline2 = create_pipeline(project)
        create_build(pipeline1, 'test')
        create_build(pipeline1, 'test2')
        build1_p2 = create_build(pipeline2, 'test')
        create_build(pipeline2, 'test2')

        expect(project.latest_successful_build_for(build1_p2.name))
          .to eq(build1_p2)
      end
    end

    context 'with succeeded pipeline' do
      let!(:build) { create_build }

      context 'standalone pipeline' do
        it 'returns builds for ref for default_branch' do
          expect(project.latest_successful_build_for!(build.name))
            .to eq(build)
        end

        it 'returns exception if the build cannot be found' do
          expect { project.latest_successful_build_for!(build.name, 'TAIL') }
            .to raise_error(ActiveRecord::RecordNotFound)
2066
        end
2067 2068
      end

L
Lin Jen-Shin 已提交
2069
      context 'with some pending pipeline' do
2070
        before do
2071
          create_build(create_pipeline(project, 'pending'))
2072 2073
        end

L
Lin Jen-Shin 已提交
2074
        it 'gives the latest build from latest pipeline' do
2075 2076
          expect(project.latest_successful_build_for!(build.name))
            .to eq(build)
2077
        end
2078 2079 2080 2081
      end
    end

    context 'with pending pipeline' do
2082
      it 'returns empty relation' do
2083
        pipeline.update(status: 'pending')
2084
        pending_build = create_build(pipeline)
2085

2086 2087
        expect { project.latest_successful_build_for!(pending_build.name) }
          .to raise_error(ActiveRecord::RecordNotFound)
2088 2089 2090 2091
      end
    end
  end

2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127
  describe '#import_status' do
    context 'with import_state' do
      it 'returns the right status' do
        project = create(:project, :import_started)

        expect(project.import_status).to eq("started")
      end
    end

    context 'without import_state' do
      it 'returns none' do
        project = create(:project)

        expect(project.import_status).to eq('none')
      end
    end
  end

  describe '#human_import_status_name' do
    context 'with import_state' do
      it 'returns the right human import status' do
        project = create(:project, :import_started)

        expect(project.human_import_status_name).to eq('started')
      end
    end

    context 'without import_state' do
      it 'returns none' do
        project = create(:project)

        expect(project.human_import_status_name).to eq('none')
      end
    end
  end

2128
  describe '#add_import_job' do
2129 2130
    let(:import_jid) { '123' }

2131
    context 'forked' do
2132 2133 2134 2135 2136 2137
      let(:forked_from_project) { create(:project, :repository) }
      let(:project) { create(:project) }

      before do
        fork_project(forked_from_project, nil, target_project: project)
      end
2138 2139

      it 'schedules a RepositoryForkWorker job' do
2140
        expect(RepositoryForkWorker).to receive(:perform_async).with(project.id).and_return(import_jid)
2141

2142
        expect(project.add_import_job).to eq(import_jid)
2143 2144 2145 2146 2147
      end
    end

    context 'not forked' do
      it 'schedules a RepositoryImportWorker job' do
2148
        project = create(:project, import_url: generate(:url))
2149

2150 2151
        expect(RepositoryImportWorker).to receive(:perform_async).with(project.id).and_return(import_jid)
        expect(project.add_import_job).to eq(import_jid)
2152 2153 2154 2155
      end
    end
  end

R
Rémy Coutable 已提交
2156
  describe '#gitlab_project_import?' do
2157
    subject(:project) { build(:project, import_type: 'gitlab_project') }
R
Rémy Coutable 已提交
2158 2159 2160 2161 2162

    it { expect(project.gitlab_project_import?).to be true }
  end

  describe '#gitea_import?' do
2163
    subject(:project) { build(:project, import_type: 'gitea') }
R
Rémy Coutable 已提交
2164 2165 2166 2167

    it { expect(project.gitea_import?).to be true }
  end

2168
  describe '#has_remote_mirror?' do
2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180
    let(:project) { create(:project, :remote_mirror, :import_started) }
    subject { project.has_remote_mirror? }

    before do
      allow_any_instance_of(RemoteMirror).to receive(:refresh_remote)
    end

    it 'returns true when a remote mirror is enabled' do
      is_expected.to be_truthy
    end

    it 'returns false when remote mirror is disabled' do
L
Lin Jen-Shin 已提交
2181
      project.remote_mirrors.first.update(enabled: false)
2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210

      is_expected.to be_falsy
    end
  end

  describe '#update_remote_mirrors' do
    let(:project) { create(:project, :remote_mirror, :import_started) }
    delegate :update_remote_mirrors, to: :project

    before do
      allow_any_instance_of(RemoteMirror).to receive(:refresh_remote)
    end

    it 'syncs enabled remote mirror' do
      expect_any_instance_of(RemoteMirror).to receive(:sync)

      update_remote_mirrors
    end

    it 'does nothing when remote mirror is disabled globally and not overridden' do
      stub_application_setting(mirror_available: false)
      project.remote_mirror_available_overridden = false

      expect_any_instance_of(RemoteMirror).not_to receive(:sync)

      update_remote_mirrors
    end

    it 'does not sync disabled remote mirrors' do
L
Lin Jen-Shin 已提交
2211
      project.remote_mirrors.first.update(enabled: false)
2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244

      expect_any_instance_of(RemoteMirror).not_to receive(:sync)

      update_remote_mirrors
    end
  end

  describe '#remote_mirror_available?' do
    let(:project) { create(:project) }

    context 'when remote mirror global setting is enabled' do
      it 'returns true' do
        expect(project.remote_mirror_available?).to be(true)
      end
    end

    context 'when remote mirror global setting is disabled' do
      before do
        stub_application_setting(mirror_available: false)
      end

      it 'returns true when overridden' do
        project.remote_mirror_available_overridden = true

        expect(project.remote_mirror_available?).to be(true)
      end

      it 'returns false when not overridden' do
        expect(project.remote_mirror_available?).to be(false)
      end
    end
  end

2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257
  describe '#ancestors_upto', :nested_groups do
    let(:parent) { create(:group) }
    let(:child) { create(:group, parent: parent) }
    let(:child2) { create(:group, parent: child) }
    let(:project) { create(:project, namespace: child2) }

    it 'returns all ancestors when no namespace is given' do
      expect(project.ancestors_upto).to contain_exactly(child2, child, parent)
    end

    it 'includes ancestors upto but excluding the given ancestor' do
      expect(project.ancestors_upto(parent)).to contain_exactly(child2, child)
    end
2258 2259 2260 2261 2262 2263 2264 2265 2266 2267

    describe 'with hierarchy_order' do
      it 'returns ancestors ordered by descending hierarchy' do
        expect(project.ancestors_upto(hierarchy_order: :desc)).to eq([parent, child, child2])
      end

      it 'can be used with upto option' do
        expect(project.ancestors_upto(parent, hierarchy_order: :desc)).to eq([child, child2])
      end
    end
2268 2269
  end

2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290
  describe '#root_ancestor' do
    let(:project) { create(:project) }

    subject { project.root_ancestor }

    it { is_expected.to eq(project.namespace) }

    context 'in a group' do
      let(:group) { create(:group) }
      let(:project) { create(:project, group: group) }

      it { is_expected.to eq(group) }
    end

    context 'in a nested group', :nested_groups do
      let(:root) { create(:group) }
      let(:child) { create(:group, parent: root) }
      let(:project) { create(:project, group: child) }

      it { is_expected.to eq(root) }
    end
2291 2292
  end

2293
  describe '#lfs_enabled?' do
2294
    let(:project) { create(:project) }
2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347 2348 2349 2350 2351 2352 2353 2354

    shared_examples 'project overrides group' do
      it 'returns true when enabled in project' do
        project.update_attribute(:lfs_enabled, true)

        expect(project.lfs_enabled?).to be_truthy
      end

      it 'returns false when disabled in project' do
        project.update_attribute(:lfs_enabled, false)

        expect(project.lfs_enabled?).to be_falsey
      end

      it 'returns the value from the namespace, when no value is set in project' do
        expect(project.lfs_enabled?).to eq(project.namespace.lfs_enabled?)
      end
    end

    context 'LFS disabled in group' do
      before do
        project.namespace.update_attribute(:lfs_enabled, false)
        enable_lfs
      end

      it_behaves_like 'project overrides group'
    end

    context 'LFS enabled in group' do
      before do
        project.namespace.update_attribute(:lfs_enabled, true)
        enable_lfs
      end

      it_behaves_like 'project overrides group'
    end

    describe 'LFS disabled globally' do
      shared_examples 'it always returns false' do
        it do
          expect(project.lfs_enabled?).to be_falsey
          expect(project.namespace.lfs_enabled?).to be_falsey
        end
      end

      context 'when no values are set' do
        it_behaves_like 'it always returns false'
      end

      context 'when all values are set to true' do
        before do
          project.namespace.update_attribute(:lfs_enabled, true)
          project.update_attribute(:lfs_enabled, true)
        end

        it_behaves_like 'it always returns false'
      end
    end
  end

J
Jacopo 已提交
2355 2356 2357 2358 2359 2360 2361 2362 2363 2364 2365 2366
  describe '#daily_statistics_enabled?' do
    it { is_expected.to be_daily_statistics_enabled }

    context 'when :project_daily_statistics is disabled for the project' do
      before do
        stub_feature_flags(project_daily_statistics: { thing: subject, enabled: false })
      end

      it { is_expected.not_to be_daily_statistics_enabled }
    end
  end

2367
  describe '#change_head' do
2368
    let(:project) { create(:project, :repository) }
2369

2370 2371 2372 2373 2374
    it 'returns error if branch does not exist' do
      expect(project.change_head('unexisted-branch')).to be false
      expect(project.errors.size).to eq(1)
    end

2375
    it 'calls the before_change_head and after_change_head methods' do
2376
      expect(project.repository).to receive(:before_change_head)
2377 2378
      expect(project.repository).to receive(:after_change_head)

2379 2380 2381
      project.change_head(project.default_branch)
    end

2382 2383 2384 2385 2386 2387
    it 'updates commit count' do
      expect(ProjectCacheWorker).to receive(:perform_async).with(project.id, [], [:commit_count])

      project.change_head(project.default_branch)
    end

2388 2389 2390 2391 2392 2393 2394 2395 2396 2397
    it 'copies the gitattributes' do
      expect(project.repository).to receive(:copy_gitattributes).with(project.default_branch)
      project.change_head(project.default_branch)
    end

    it 'reloads the default branch' do
      expect(project).to receive(:reload_default_branch)
      project.change_head(project.default_branch)
    end
  end
Y
Yorick Peterse 已提交
2398

2399
  context 'forks' do
B
Bob Van Landuyt 已提交
2400 2401
    include ProjectForksHelper

2402 2403 2404 2405 2406
    let(:project) { create(:project, :public) }
    let!(:forked_project) { fork_project(project) }

    describe '#fork_network' do
      it 'includes a fork of the project' do
B
Bob Van Landuyt 已提交
2407
        expect(project.fork_network.projects).to include(forked_project)
2408 2409 2410 2411 2412
      end

      it 'includes a fork of a fork' do
        other_fork = fork_project(forked_project)

B
Bob Van Landuyt 已提交
2413
        expect(project.fork_network.projects).to include(other_fork)
2414 2415 2416 2417 2418
      end

      it 'includes sibling forks' do
        other_fork = fork_project(project)

B
Bob Van Landuyt 已提交
2419
        expect(forked_project.fork_network.projects).to include(other_fork)
2420 2421 2422
      end

      it 'includes the base project' do
B
Bob Van Landuyt 已提交
2423
        expect(forked_project.fork_network.projects).to include(project.reload)
2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449
      end
    end

    describe '#in_fork_network_of?' do
      it 'is true for a real fork' do
        expect(forked_project.in_fork_network_of?(project)).to be_truthy
      end

      it 'is true for a fork of a fork', :postgresql do
        other_fork = fork_project(forked_project)

        expect(other_fork.in_fork_network_of?(project)).to be_truthy
      end

      it 'is true for sibling forks' do
        sibling = fork_project(project)

        expect(sibling.in_fork_network_of?(forked_project)).to be_truthy
      end

      it 'is false when another project is given' do
        other_project = build_stubbed(:project)

        expect(forked_project.in_fork_network_of?(other_project)).to be_falsy
      end
    end
2450 2451 2452 2453 2454 2455 2456 2457 2458 2459 2460 2461 2462

    describe '#fork_source' do
      let!(:second_fork) { fork_project(forked_project) }

      it 'returns the direct source if it exists' do
        expect(second_fork.fork_source).to eq(forked_project)
      end

      it 'returns the root of the fork network when the directs source was deleted' do
        forked_project.destroy

        expect(second_fork.fork_source).to eq(project)
      end
2463 2464 2465 2466

      it 'returns nil if it is the root of the fork network' do
        expect(project.fork_source).to be_nil
      end
2467
    end
2468

2469 2470 2471 2472 2473 2474
    describe '#forks' do
      it 'includes direct forks of the project' do
        expect(project.forks).to contain_exactly(forked_project)
      end
    end

2475 2476 2477 2478 2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489 2490 2491
    describe '#lfs_storage_project' do
      it 'returns self for non-forks' do
        expect(project.lfs_storage_project).to eq project
      end

      it 'returns the fork network root for forks' do
        second_fork = fork_project(forked_project)

        expect(second_fork.lfs_storage_project).to eq project
      end

      it 'returns self when fork_source is nil' do
        expect(forked_project).to receive(:fork_source).and_return(nil)

        expect(forked_project.lfs_storage_project).to eq forked_project
      end
    end
2492 2493 2494 2495 2496 2497 2498 2499 2500 2501 2502 2503 2504 2505 2506 2507

    describe '#all_lfs_objects' do
      let(:lfs_object) { create(:lfs_object) }

      before do
        project.lfs_objects << lfs_object
      end

      it 'returns the lfs object for a project' do
        expect(project.all_lfs_objects).to contain_exactly(lfs_object)
      end

      it 'returns the lfs object for a fork' do
        expect(forked_project.all_lfs_objects).to contain_exactly(lfs_object)
      end
    end
2508 2509
  end

2510 2511 2512 2513 2514 2515 2516 2517 2518 2519 2520 2521 2522 2523
  describe '#set_repository_read_only!' do
    let(:project) { create(:project) }

    it 'returns true when there is no existing git transfer in progress' do
      expect(project.set_repository_read_only!).to be_truthy
    end

    it 'returns false when there is an existing git transfer in progress' do
      allow(project).to receive(:git_transfer_in_progress?) { true }

      expect(project.set_repository_read_only!).to be_falsey
    end
  end

J
John Cai 已提交
2524 2525 2526 2527 2528 2529 2530 2531 2532 2533
  describe '#set_repository_writable!' do
    it 'sets repository_read_only to false' do
      project = create(:project, :read_only)

      expect { project.set_repository_writable! }
        .to change(project, :repository_read_only)
        .from(true).to(false)
    end
  end

Y
Yorick Peterse 已提交
2534
  describe '#pushes_since_gc' do
2535
    let(:project) { create(:project) }
Y
Yorick Peterse 已提交
2536 2537 2538 2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555 2556

    after do
      project.reset_pushes_since_gc
    end

    context 'without any pushes' do
      it 'returns 0' do
        expect(project.pushes_since_gc).to eq(0)
      end
    end

    context 'with a number of pushes' do
      it 'returns the number of pushes' do
        3.times { project.increment_pushes_since_gc }

        expect(project.pushes_since_gc).to eq(3)
      end
    end
  end

  describe '#increment_pushes_since_gc' do
2557
    let(:project) { create(:project) }
Y
Yorick Peterse 已提交
2558 2559 2560 2561 2562 2563 2564 2565 2566 2567 2568 2569 2570

    after do
      project.reset_pushes_since_gc
    end

    it 'increments the number of pushes since the last GC' do
      3.times { project.increment_pushes_since_gc }

      expect(project.pushes_since_gc).to eq(3)
    end
  end

  describe '#reset_pushes_since_gc' do
2571
    let(:project) { create(:project) }
Y
Yorick Peterse 已提交
2572 2573 2574 2575 2576 2577 2578 2579 2580 2581 2582 2583 2584

    after do
      project.reset_pushes_since_gc
    end

    it 'resets the number of pushes since the last GC' do
      3.times { project.increment_pushes_since_gc }

      project.reset_pushes_since_gc

      expect(project.pushes_since_gc).to eq(0)
    end
  end
2585

2586 2587
  describe '#deployment_variables' do
    context 'when project has no deployment service' do
2588
      let(:project) { create(:project) }
2589 2590 2591 2592 2593 2594

      it 'returns an empty array' do
        expect(project.deployment_variables).to eq []
      end
    end

2595 2596 2597 2598 2599 2600 2601 2602
    context 'when project uses mock deployment service' do
      let(:project) { create(:mock_deployment_project) }

      it 'returns an empty array' do
        expect(project.deployment_variables).to eq []
      end
    end

2603
    context 'when project has a deployment service' do
2604
      shared_examples 'same behavior between KubernetesService and Platform::Kubernetes' do
2605 2606
        it 'returns variables from this service' do
          expect(project.deployment_variables).to include(
2607
            { key: 'KUBE_TOKEN', value: project.deployment_platform.token, public: false, masked: true }
2608 2609 2610 2611 2612 2613 2614
          )
        end
      end

      context 'when user configured kubernetes from Integration > Kubernetes' do
        let(:project) { create(:kubernetes_project) }

2615
        it_behaves_like 'same behavior between KubernetesService and Platform::Kubernetes'
2616 2617
      end

2618
      context 'when user configured kubernetes from CI/CD > Clusters and KubernetesNamespace migration has not been executed' do
2619 2620
        let!(:cluster) { create(:cluster, :project, :provided_by_gcp) }
        let(:project) { cluster.project }
2621

2622
        it_behaves_like 'same behavior between KubernetesService and Platform::Kubernetes'
2623
      end
2624 2625

      context 'when user configured kubernetes from CI/CD > Clusters and KubernetesNamespace migration has been executed' do
T
Thong Kuah 已提交
2626
        let!(:kubernetes_namespace) { create(:cluster_kubernetes_namespace, :with_token) }
2627 2628 2629 2630 2631
        let!(:cluster) { kubernetes_namespace.cluster }
        let(:project) { kubernetes_namespace.project }

        it 'should return token from kubernetes namespace' do
          expect(project.deployment_variables).to include(
2632
            { key: 'KUBE_TOKEN', value: kubernetes_namespace.service_account_token, public: false, masked: true }
2633 2634 2635
          )
        end
      end
2636 2637 2638
    end
  end

2639 2640 2641 2642 2643 2644 2645 2646 2647 2648 2649 2650 2651 2652 2653 2654 2655 2656 2657 2658 2659 2660
  describe '#default_environment' do
    let(:project) { create(:project) }

    it 'returns production environment when it exists' do
      production = create(:environment, name: "production", project: project)
      create(:environment, name: 'staging', project: project)

      expect(project.default_environment).to eq(production)
    end

    it 'returns first environment when no production environment exists' do
      create(:environment, name: 'staging', project: project)
      create(:environment, name: 'foo', project: project)

      expect(project.default_environment).to eq(project.environments.first)
    end

    it 'returns nil when no available environment exists' do
      expect(project.default_environment).to be_nil
    end
  end

2661
  describe '#ci_variables_for' do
2662
    let(:project) { create(:project) }
2663

2664
    let!(:ci_variable) do
2665 2666 2667 2668 2669 2670 2671
      create(:ci_variable, value: 'secret', project: project)
    end

    let!(:protected_variable) do
      create(:ci_variable, :protected, value: 'protected', project: project)
    end

2672
    subject { project.reload.ci_variables_for(ref: 'ref') }
L
Lin Jen-Shin 已提交
2673 2674 2675 2676 2677

    before do
      stub_application_setting(
        default_branch_protection: Gitlab::Access::PROTECTION_NONE)
    end
2678 2679 2680

    shared_examples 'ref is protected' do
      it 'contains all the variables' do
2681
        is_expected.to contain_exactly(ci_variable, protected_variable)
2682 2683 2684 2685
      end
    end

    context 'when the ref is not protected' do
2686 2687 2688 2689
      before do
        allow(project).to receive(:protected_for?).with('ref').and_return(false)
      end

2690 2691
      it 'contains only the CI variables' do
        is_expected.to contain_exactly(ci_variable)
2692 2693 2694
      end
    end

2695 2696
    context 'when the ref is a protected branch' do
      before do
2697
        allow(project).to receive(:protected_for?).with('ref').and_return(true)
2698
      end
2699 2700 2701 2702 2703 2704

      it_behaves_like 'ref is protected'
    end

    context 'when the ref is a protected tag' do
      before do
2705
        allow(project).to receive(:protected_for?).with('ref').and_return(true)
2706 2707 2708
      end

      it_behaves_like 'ref is protected'
2709 2710 2711
    end
  end

2712 2713 2714 2715 2716 2717 2718 2719 2720 2721 2722 2723 2724 2725 2726 2727
  describe '#any_lfs_file_locks?', :request_store do
    set(:project) { create(:project) }

    it 'returns false when there are no LFS file locks' do
      expect(project.any_lfs_file_locks?).to be_falsey
    end

    it 'returns a cached true when there are LFS file locks' do
      create(:lfs_file_lock, project: project)

      expect(project.lfs_file_locks).to receive(:any?).once.and_call_original

      2.times { expect(project.any_lfs_file_locks?).to be_truthy }
    end
  end

2728
  describe '#protected_for?' do
2729
    let(:project) { create(:project, :repository) }
2730

2731
    subject { project.protected_for?(ref) }
2732

2733
    shared_examples 'ref is not protected' do
2734 2735 2736 2737 2738 2739
      before do
        stub_application_setting(
          default_branch_protection: Gitlab::Access::PROTECTION_NONE)
      end

      it 'returns false' do
2740
        is_expected.to be false
2741 2742 2743
      end
    end

2744
    shared_examples 'ref is protected branch' do
2745
      before do
2746
        create(:protected_branch, name: 'master', project: project)
2747 2748 2749
      end

      it 'returns true' do
2750
        is_expected.to be true
2751 2752 2753
      end
    end

2754
    shared_examples 'ref is protected tag' do
2755
      before do
2756
        create(:protected_tag, name: 'v1.0.0', project: project)
2757 2758 2759
      end

      it 'returns true' do
2760
        is_expected.to be true
2761 2762
      end
    end
2763

2764 2765
    context 'when ref is nil' do
      let(:ref) { nil }
2766

2767
      it 'returns false' do
2768
        is_expected.to be false
2769
      end
2770 2771 2772 2773 2774
    end

    context 'when ref is ref name' do
      context 'when ref is ambiguous' do
        let(:ref) { 'ref' }
2775 2776

        before do
2777 2778
          project.repository.add_branch(project.creator, 'ref', 'master')
          project.repository.add_tag(project.creator, 'ref', 'master')
2779 2780
        end

2781 2782
        it 'raises an error' do
          expect { subject }.to raise_error(Repository::AmbiguousRefError)
2783 2784
        end
      end
2785 2786 2787 2788 2789 2790 2791 2792 2793 2794 2795 2796 2797 2798 2799 2800 2801 2802

      context 'when the ref is not protected' do
        let(:ref) { 'master' }

        it_behaves_like 'ref is not protected'
      end

      context 'when the ref is a protected branch' do
        let(:ref) { 'master' }

        it_behaves_like 'ref is protected branch'
      end

      context 'when the ref is a protected tag' do
        let(:ref) { 'v1.0.0' }

        it_behaves_like 'ref is protected tag'
      end
2803 2804 2805 2806 2807 2808 2809 2810

      context 'when ref does not exist' do
        let(:ref) { 'something' }

        it 'returns false' do
          is_expected.to be false
        end
      end
2811 2812
    end

2813 2814 2815
    context 'when ref is full ref' do
      context 'when the ref is not protected' do
        let(:ref) { 'refs/heads/master' }
2816

2817
        it_behaves_like 'ref is not protected'
2818 2819
      end

2820 2821 2822 2823 2824 2825 2826 2827 2828 2829
      context 'when the ref is a protected branch' do
        let(:ref) { 'refs/heads/master' }

        it_behaves_like 'ref is protected branch'
      end

      context 'when the ref is a protected tag' do
        let(:ref) { 'refs/tags/v1.0.0' }

        it_behaves_like 'ref is protected tag'
2830 2831
      end

2832 2833 2834
      context 'when branch ref name is a full tag ref' do
        let(:ref) { 'refs/tags/something' }

2835
        before do
2836
          project.repository.add_branch(project.creator, ref, 'master')
2837 2838
        end

2839 2840
        context 'when ref is not protected' do
          it 'returns false' do
2841
            is_expected.to be false
2842 2843 2844 2845 2846 2847 2848 2849 2850
          end
        end

        context 'when ref is a protected branch' do
          before do
            create(:protected_branch, name: 'refs/tags/something', project: project)
          end

          it 'returns true' do
2851
            is_expected.to be true
2852
          end
2853 2854
        end
      end
2855 2856 2857 2858 2859 2860 2861

      context 'when ref does not exist' do
        let(:ref) { 'refs/heads/something' }

        it 'returns false' do
          is_expected.to be false
        end
2862 2863 2864 2865
      end
    end
  end

M
Markus Koller 已提交
2866
  describe '#update_project_statistics' do
2867
    let(:project) { create(:project) }
M
Markus Koller 已提交
2868 2869 2870 2871 2872 2873 2874 2875 2876 2877 2878 2879 2880 2881 2882 2883 2884 2885

    it "is called after creation" do
      expect(project.statistics).to be_a ProjectStatistics
      expect(project.statistics).to be_persisted
    end

    it "copies the namespace_id" do
      expect(project.statistics.namespace_id).to eq project.namespace_id
    end

    it "updates the namespace_id when changed" do
      namespace = create(:namespace)
      project.update(namespace: namespace)

      expect(project.statistics.namespace_id).to eq namespace.id
    end
  end

2886
  describe 'inside_path' do
2887 2888 2889
    let!(:project1) { create(:project, namespace: create(:namespace, path: 'name_pace')) }
    let!(:project2) { create(:project) }
    let!(:project3) { create(:project, namespace: create(:namespace, path: 'namespace')) }
2890
    let!(:path) { project1.namespace.full_path }
2891

2892
    it 'returns correct project' do
2893
      expect(described_class.inside_path(path)).to eq([project1])
2894
    end
2895 2896
  end

D
Douwe Maan 已提交
2897
  describe '#route_map_for' do
2898
    let(:project) { create(:project, :repository) }
D
Douwe Maan 已提交
2899 2900 2901 2902 2903 2904 2905 2906
    let(:route_map) do
      <<-MAP.strip_heredoc
      - source: /source/(.*)/
        public: '\\1'
      MAP
    end

    before do
2907
      project.repository.create_file(User.last, '.gitlab/route-map.yml', route_map, message: 'Add .gitlab/route-map.yml', branch_name: 'master')
D
Douwe Maan 已提交
2908 2909 2910 2911 2912 2913 2914 2915 2916 2917 2918 2919 2920 2921 2922 2923 2924 2925 2926 2927 2928 2929 2930 2931 2932 2933 2934
    end

    context 'when there is a .gitlab/route-map.yml at the commit' do
      context 'when the route map is valid' do
        it 'returns a route map' do
          map = project.route_map_for(project.commit.sha)
          expect(map).to be_a_kind_of(Gitlab::RouteMap)
        end
      end

      context 'when the route map is invalid' do
        let(:route_map) { 'INVALID' }

        it 'returns nil' do
          expect(project.route_map_for(project.commit.sha)).to be_nil
        end
      end
    end

    context 'when there is no .gitlab/route-map.yml at the commit' do
      it 'returns nil' do
        expect(project.route_map_for(project.commit.parent.sha)).to be_nil
      end
    end
  end

  describe '#public_path_for_source_path' do
2935
    let(:project) { create(:project, :repository) }
D
Douwe Maan 已提交
2936 2937 2938 2939 2940 2941 2942 2943 2944 2945 2946 2947 2948 2949 2950 2951 2952 2953 2954 2955 2956 2957 2958 2959 2960 2961 2962 2963 2964 2965 2966 2967 2968 2969 2970 2971 2972
    let(:route_map) do
      Gitlab::RouteMap.new(<<-MAP.strip_heredoc)
        - source: /source/(.*)/
          public: '\\1'
      MAP
    end
    let(:sha) { project.commit.id }

    context 'when there is a route map' do
      before do
        allow(project).to receive(:route_map_for).with(sha).and_return(route_map)
      end

      context 'when the source path is mapped' do
        it 'returns the public path' do
          expect(project.public_path_for_source_path('source/file.html', sha)).to eq('file.html')
        end
      end

      context 'when the source path is not mapped' do
        it 'returns nil' do
          expect(project.public_path_for_source_path('file.html', sha)).to be_nil
        end
      end
    end

    context 'when there is no route map' do
      before do
        allow(project).to receive(:route_map_for).with(sha).and_return(nil)
      end

      it 'returns nil' do
        expect(project.public_path_for_source_path('source/file.html', sha)).to be_nil
      end
    end
  end

2973
  describe '#parent' do
2974
    let(:project) { create(:project) }
2975 2976 2977 2978

    it { expect(project.parent).to eq(project.namespace) }
  end

2979 2980 2981 2982 2983 2984
  describe '#parent_id' do
    let(:project) { create(:project) }

    it { expect(project.parent_id).to eq(project.namespace_id) }
  end

2985
  describe '#parent_changed?' do
2986
    let(:project) { create(:project) }
2987

2988 2989 2990
    before do
      project.namespace_id = 7
    end
2991 2992 2993 2994

    it { expect(project.parent_changed?).to be_truthy }
  end

2995 2996 2997
  def enable_lfs
    allow(Gitlab.config.lfs).to receive(:enabled).and_return(true)
  end
K
Kamil Trzcinski 已提交
2998

2999
  describe '#pages_url' do
3000 3001
    let(:group) { create(:group, name: 'Group') }
    let(:nested_group) { create(:group, parent: group) }
K
Kamil Trzcinski 已提交
3002 3003 3004 3005 3006 3007 3008 3009 3010
    let(:domain) { 'Example.com' }

    subject { project.pages_url }

    before do
      allow(Settings.pages).to receive(:host).and_return(domain)
      allow(Gitlab.config.pages).to receive(:url).and_return('http://example.com')
    end

3011
    context 'top-level group' do
3012
      let(:project) { create(:project, namespace: group, name: project_name) }
K
Kamil Trzcinski 已提交
3013

3014 3015 3016 3017 3018 3019 3020 3021 3022 3023 3024
      context 'group page' do
        let(:project_name) { 'group.example.com' }

        it { is_expected.to eq("http://group.example.com") }
      end

      context 'project page' do
        let(:project_name) { 'Project' }

        it { is_expected.to eq("http://group.example.com/project") }
      end
K
Kamil Trzcinski 已提交
3025 3026
    end

3027
    context 'nested group' do
3028
      let(:project) { create(:project, namespace: nested_group, name: project_name) }
3029
      let(:expected_url) { "http://group.example.com/#{nested_group.path}/#{project.path}" }
K
Kamil Trzcinski 已提交
3030

3031 3032 3033 3034 3035 3036 3037 3038 3039 3040 3041
      context 'group page' do
        let(:project_name) { 'group.example.com' }

        it { is_expected.to eq(expected_url) }
      end

      context 'project page' do
        let(:project_name) { 'Project' }

        it { is_expected.to eq(expected_url) }
      end
K
Kamil Trzcinski 已提交
3042 3043
    end
  end
3044 3045

  describe '#http_url_to_repo' do
3046
    let(:project) { create(:project) }
3047

3048 3049 3050
    it 'returns the url to the repo without a username' do
      expect(project.http_url_to_repo).to eq("#{project.web_url}.git")
      expect(project.http_url_to_repo).not_to include('@')
3051 3052
    end
  end
3053

3054 3055 3056 3057 3058 3059 3060 3061 3062 3063 3064
  describe '#lfs_http_url_to_repo' do
    let(:project) { create(:project) }

    it 'returns the url to the repo without a username' do
      lfs_http_url_to_repo = project.lfs_http_url_to_repo('operation_that_doesnt_matter')

      expect(lfs_http_url_to_repo).to eq("#{project.web_url}.git")
      expect(lfs_http_url_to_repo).not_to include('@')
    end
  end

3065
  describe '#pipeline_status' do
3066
    let(:project) { create(:project, :repository) }
3067
    it 'builds a pipeline status' do
3068
      expect(project.pipeline_status).to be_a(Gitlab::Cache::Ci::ProjectPipelineStatus)
3069 3070 3071 3072 3073 3074
    end

    it 'hase a loaded pipeline status' do
      expect(project.pipeline_status).to be_loaded
    end
  end
3075 3076

  describe '#append_or_update_attribute' do
3077
    let(:project) { create(:project) }
3078 3079 3080

    it 'shows full error updating an invalid MR' do
      error_message = 'Failed to replace merge_requests because one or more of the new records could not be saved.'\
3081
        ' Validate fork Source project is not a fork of the target project'
3082

3083 3084
      expect { project.append_or_update_attribute(:merge_requests, [create(:merge_request)]) }
        .to raise_error(ActiveRecord::RecordNotSaved, error_message)
3085 3086
    end

G
George Tsiolis 已提交
3087
    it 'updates the project successfully' do
3088 3089
      merge_request = create(:merge_request, target_project: project, source_project: project)

3090 3091
      expect { project.append_or_update_attribute(:merge_requests, [merge_request]) }
        .not_to raise_error
3092 3093
    end
  end
3094

3095 3096 3097 3098 3099 3100 3101 3102 3103 3104 3105 3106 3107 3108 3109 3110 3111 3112
  describe '#update' do
    let(:project) { create(:project) }

    it 'validates the visibility' do
      expect(project).to receive(:visibility_level_allowed_as_fork).and_call_original
      expect(project).to receive(:visibility_level_allowed_by_group).and_call_original

      project.update(visibility_level: Gitlab::VisibilityLevel::INTERNAL)
    end

    it 'does not validate the visibility' do
      expect(project).not_to receive(:visibility_level_allowed_as_fork).and_call_original
      expect(project).not_to receive(:visibility_level_allowed_by_group).and_call_original

      project.update(updated_at: Time.now)
    end
  end

3113 3114
  describe '#last_repository_updated_at' do
    it 'sets to created_at upon creation' do
3115
      project = create(:project, created_at: 2.hours.ago)
3116 3117 3118 3119

      expect(project.last_repository_updated_at.to_i).to eq(project.created_at.to_i)
    end
  end
3120 3121 3122 3123 3124

  describe '.public_or_visible_to_user' do
    let!(:user) { create(:user) }

    let!(:private_project) do
3125
      create(:project, :private, creator: user, namespace: user.namespace)
3126 3127
    end

3128
    let!(:public_project) { create(:project, :public) }
3129 3130 3131

    context 'with a user' do
      let(:projects) do
3132
        described_class.all.public_or_visible_to_user(user)
3133 3134 3135 3136 3137 3138 3139 3140 3141 3142 3143 3144 3145
      end

      it 'includes projects the user has access to' do
        expect(projects).to include(private_project)
      end

      it 'includes projects the user can see' do
        expect(projects).to include(public_project)
      end
    end

    context 'without a user' do
      it 'only includes public projects' do
3146
        projects = described_class.all.public_or_visible_to_user
3147 3148 3149 3150 3151

        expect(projects).to eq([public_project])
      end
    end
  end
3152

3153 3154 3155 3156 3157 3158 3159 3160 3161 3162 3163 3164 3165 3166 3167 3168 3169 3170 3171 3172 3173 3174 3175 3176 3177 3178 3179 3180 3181 3182 3183 3184 3185 3186 3187 3188 3189 3190 3191 3192 3193 3194 3195 3196 3197 3198 3199 3200 3201 3202 3203 3204 3205 3206 3207 3208 3209 3210 3211 3212
  describe '.with_feature_available_for_user' do
    let!(:user) { create(:user) }
    let!(:feature) { MergeRequest }
    let!(:project) { create(:project, :public, :merge_requests_enabled) }

    subject { described_class.with_feature_available_for_user(feature, user) }

    context 'when user has access to project' do
      subject { described_class.with_feature_available_for_user(feature, user) }

      before do
        project.add_guest(user)
      end

      context 'when public project' do
        context 'when feature is public' do
          it 'returns project' do
            is_expected.to include(project)
          end
        end

        context 'when feature is private' do
          let!(:project) { create(:project, :public, :merge_requests_private) }

          it 'returns project when user has access to the feature' do
            project.add_maintainer(user)

            is_expected.to include(project)
          end

          it 'does not return project when user does not have the minimum access level required' do
            is_expected.not_to include(project)
          end
        end
      end

      context 'when private project' do
        let!(:project) { create(:project) }

        it 'returns project when user has access to the feature' do
          project.add_maintainer(user)

          is_expected.to include(project)
        end

        it 'does not return project when user does not have the minimum access level required' do
          is_expected.not_to include(project)
        end
      end
    end

    context 'when user does not have access to project' do
      let!(:project) { create(:project) }

      it 'does not return project when user cant access project' do
        is_expected.not_to include(project)
      end
    end
  end

3213 3214 3215 3216 3217 3218 3219 3220 3221 3222 3223 3224 3225 3226 3227 3228 3229 3230
  describe '#pages_available?' do
    let(:project) { create(:project, group: group) }

    subject { project.pages_available? }

    before do
      allow(Gitlab.config.pages).to receive(:enabled).and_return(true)
    end

    context 'when the project is in a top level namespace' do
      let(:group) { create(:group) }

      it { is_expected.to be(true) }
    end

    context 'when the project is in a subgroup' do
      let(:group) { create(:group, :nested) }

3231
      it { is_expected.to be(true) }
3232 3233 3234
    end
  end

3235
  describe '#remove_private_deploy_keys' do
3236
    let!(:project) { create(:project) }
3237 3238 3239 3240 3241 3242 3243 3244 3245 3246 3247 3248 3249 3250 3251

    context 'for a private deploy key' do
      let!(:key) { create(:deploy_key, public: false) }
      let!(:deploy_keys_project) { create(:deploy_keys_project, deploy_key: key, project: project) }

      context 'when the key is not linked to another project' do
        it 'removes the key' do
          project.remove_private_deploy_keys

          expect(project.deploy_keys).not_to include(key)
        end
      end

      context 'when the key is linked to another project' do
        before do
3252
          another_project = create(:project)
3253 3254
          create(:deploy_keys_project, deploy_key: key, project: another_project)
        end
3255

3256 3257
        it 'does not remove the key' do
          project.remove_private_deploy_keys
3258

3259 3260 3261 3262 3263 3264 3265 3266
          expect(project.deploy_keys).to include(key)
        end
      end
    end

    context 'for a public deploy key' do
      let!(:key) { create(:deploy_key, public: true) }
      let!(:deploy_keys_project) { create(:deploy_keys_project, deploy_key: key, project: project) }
3267

3268 3269
      it 'does not remove the key' do
        project.remove_private_deploy_keys
3270

3271 3272
        expect(project.deploy_keys).to include(key)
      end
3273 3274
    end
  end
3275

3276 3277
  describe '#remove_pages' do
    let(:project) { create(:project) }
3278
    let(:namespace) { project.namespace }
3279 3280 3281 3282 3283 3284 3285 3286 3287 3288 3289
    let(:pages_path) { project.pages_path }

    around do |example|
      FileUtils.mkdir_p(pages_path)
      begin
        example.run
      ensure
        FileUtils.rm_rf(pages_path)
      end
    end

3290 3291 3292 3293 3294 3295 3296 3297
    it 'removes the pages directory' do
      expect_any_instance_of(Projects::UpdatePagesConfigurationService).to receive(:execute)
      expect_any_instance_of(Gitlab::PagesTransfer).to receive(:rename_project).and_return(true)
      expect(PagesWorker).to receive(:perform_in).with(5.minutes, :remove, namespace.full_path, anything)

      project.remove_pages
    end

3298
    it 'is a no-op when there is no namespace' do
3299 3300
      project.namespace.delete
      project.reload
3301 3302 3303 3304 3305 3306

      expect_any_instance_of(Projects::UpdatePagesConfigurationService).not_to receive(:execute)
      expect_any_instance_of(Gitlab::PagesTransfer).not_to receive(:rename_project)

      project.remove_pages
    end
3307 3308 3309 3310 3311 3312

    it 'is run when the project is destroyed' do
      expect(project).to receive(:remove_pages).and_call_original

      project.destroy
    end
3313 3314
  end

3315
  describe '#remove_export' do
3316 3317
    let(:project) { create(:project, :with_export) }

3318
    it 'removes the export' do
3319 3320
      project.remove_exports

J
James Lopez 已提交
3321
      expect(project.export_file_exists?).to be_falsey
3322 3323 3324
    end
  end

3325 3326 3327 3328
  describe '#forks_count' do
    it 'returns the number of forks' do
      project = build(:project)

F
Francisco Lopez 已提交
3329
      expect_any_instance_of(Projects::ForksCountService).to receive(:count).and_return(1)
3330 3331 3332 3333

      expect(project.forks_count).to eq(1)
    end
  end
3334

3335 3336 3337 3338 3339 3340 3341 3342 3343 3344 3345 3346 3347 3348 3349 3350 3351 3352 3353 3354 3355 3356 3357 3358 3359 3360 3361
  describe '#git_transfer_in_progress?' do
    let(:project) { build(:project) }

    subject { project.git_transfer_in_progress? }

    it 'returns false when repo_reference_count and wiki_reference_count are 0' do
      allow(project).to receive(:repo_reference_count) { 0 }
      allow(project).to receive(:wiki_reference_count) { 0 }

      expect(subject).to be_falsey
    end

    it 'returns true when repo_reference_count is > 0' do
      allow(project).to receive(:repo_reference_count) { 2 }
      allow(project).to receive(:wiki_reference_count) { 0 }

      expect(subject).to be_truthy
    end

    it 'returns true when wiki_reference_count is > 0' do
      allow(project).to receive(:repo_reference_count) { 0 }
      allow(project).to receive(:wiki_reference_count) { 2 }

      expect(subject).to be_truthy
    end
  end

3362
  context 'legacy storage' do
G
Gabriel Mazetto 已提交
3363
    set(:project) { create(:project, :repository, :legacy_storage) }
3364
    let(:gitlab_shell) { Gitlab::Shell.new }
3365
    let(:project_storage) { project.send(:storage) }
3366

3367 3368 3369 3370
    before do
      allow(project).to receive(:gitlab_shell).and_return(gitlab_shell)
    end

3371 3372 3373 3374 3375 3376 3377 3378 3379 3380 3381 3382
    describe '#base_dir' do
      it 'returns base_dir based on namespace only' do
        expect(project.base_dir).to eq(project.namespace.full_path)
      end
    end

    describe '#disk_path' do
      it 'returns disk_path based on namespace and project path' do
        expect(project.disk_path).to eq("#{project.namespace.full_path}/#{project.path}")
      end
    end

3383
    describe '#ensure_storage_path_exists' do
3384
      it 'delegates to gitlab_shell to ensure namespace is created' do
3385
        expect(gitlab_shell).to receive(:add_namespace).with(project.repository_storage, project.base_dir)
3386

3387
        project.ensure_storage_path_exists
3388 3389 3390
      end
    end

3391 3392
    describe '#legacy_storage?' do
      it 'returns true when storage_version is nil' do
3393
        project = build(:project, storage_version: nil)
3394 3395 3396

        expect(project.legacy_storage?).to be_truthy
      end
3397 3398 3399 3400 3401 3402 3403 3404 3405 3406

      it 'returns true when the storage_version is 0' do
        project = build(:project, storage_version: 0)

        expect(project.legacy_storage?).to be_truthy
      end
    end

    describe '#hashed_storage?' do
      it 'returns false' do
3407
        expect(project.hashed_storage?(:repository)).to be_falsey
3408
      end
3409 3410
    end

3411 3412 3413 3414 3415
    describe '#pages_path' do
      it 'returns a path where pages are stored' do
        expect(project.pages_path).to eq(File.join(Settings.pages.path, project.namespace.full_path, project.path))
      end
    end
3416 3417

    describe '#migrate_to_hashed_storage!' do
G
Gabriel Mazetto 已提交
3418 3419
      let(:project) { create(:project, :empty_repo, :legacy_storage) }

3420 3421 3422 3423
      it 'returns true' do
        expect(project.migrate_to_hashed_storage!).to be_truthy
      end

G
Gabriel Mazetto 已提交
3424 3425
      it 'does not run validation' do
        expect(project).not_to receive(:valid?)
3426 3427 3428 3429

        project.migrate_to_hashed_storage!
      end

3430
      it 'schedules HashedStorage::ProjectMigrateWorker with delayed start when the project repo is in use' do
3431 3432
        Gitlab::ReferenceCounter.new(project.gl_repository(is_wiki: false)).increase

3433
        expect(HashedStorage::ProjectMigrateWorker).to receive(:perform_in)
3434 3435 3436 3437

        project.migrate_to_hashed_storage!
      end

3438
      it 'schedules HashedStorage::ProjectMigrateWorker with delayed start when the wiki repo is in use' do
3439 3440
        Gitlab::ReferenceCounter.new(project.gl_repository(is_wiki: true)).increase

3441
        expect(HashedStorage::ProjectMigrateWorker).to receive(:perform_in)
3442 3443 3444 3445

        project.migrate_to_hashed_storage!
      end

3446 3447
      it 'schedules HashedStorage::ProjectMigrateWorker' do
        expect(HashedStorage::ProjectMigrateWorker).to receive(:perform_async).with(project.id)
3448 3449 3450 3451

        project.migrate_to_hashed_storage!
      end
    end
3452 3453 3454 3455 3456 3457 3458 3459 3460 3461 3462 3463 3464 3465

    describe '#rollback_to_legacy_storage!' do
      let(:project) { create(:project, :empty_repo, :legacy_storage) }

      it 'returns nil' do
        expect(project.rollback_to_legacy_storage!).to be_nil
      end

      it 'does not run validations' do
        expect(project).not_to receive(:valid?)

        project.rollback_to_legacy_storage!
      end
    end
3466 3467 3468
  end

  context 'hashed storage' do
G
Gabriel Mazetto 已提交
3469
    set(:project) { create(:project, :repository, skip_disk_validation: true) }
3470
    let(:gitlab_shell) { Gitlab::Shell.new }
3471
    let(:hash) { Digest::SHA2.hexdigest(project.id.to_s) }
N
Nick Thomas 已提交
3472 3473
    let(:hashed_prefix) { File.join('@hashed', hash[0..1], hash[2..3]) }
    let(:hashed_path) { File.join(hashed_prefix, hash) }
3474 3475

    before do
3476
      stub_application_setting(hashed_storage_enabled: true)
3477 3478
    end

3479 3480 3481 3482 3483 3484 3485
    describe '#legacy_storage?' do
      it 'returns false' do
        expect(project.legacy_storage?).to be_falsey
      end
    end

    describe '#hashed_storage?' do
3486 3487
      it 'returns true if rolled out' do
        expect(project.hashed_storage?(:attachments)).to be_truthy
3488 3489
      end

3490 3491
      it 'returns false when not rolled out yet' do
        project.storage_version = 1
3492

3493
        expect(project.hashed_storage?(:attachments)).to be_falsey
3494 3495 3496
      end
    end

3497 3498
    describe '#base_dir' do
      it 'returns base_dir based on hash of project id' do
N
Nick Thomas 已提交
3499
        expect(project.base_dir).to eq(hashed_prefix)
3500 3501 3502 3503
      end
    end

    describe '#disk_path' do
3504
      it 'returns disk_path based on hash of project id' do
3505 3506 3507 3508
        expect(project.disk_path).to eq(hashed_path)
      end
    end

3509
    describe '#ensure_storage_path_exists' do
3510
      it 'delegates to gitlab_shell to ensure namespace is created' do
3511 3512
        allow(project).to receive(:gitlab_shell).and_return(gitlab_shell)

3513
        expect(gitlab_shell).to receive(:add_namespace).with(project.repository_storage, hashed_prefix)
3514

3515
        project.ensure_storage_path_exists
3516 3517 3518
      end
    end

3519 3520 3521 3522 3523
    describe '#pages_path' do
      it 'returns a path where pages are stored' do
        expect(project.pages_path).to eq(File.join(Settings.pages.path, project.namespace.full_path, project.path))
      end
    end
3524 3525

    describe '#migrate_to_hashed_storage!' do
G
Gabriel Mazetto 已提交
3526 3527
      let(:project) { create(:project, :repository, skip_disk_validation: true) }

3528 3529 3530 3531
      it 'returns nil' do
        expect(project.migrate_to_hashed_storage!).to be_nil
      end

T
Toon Claes 已提交
3532
      it 'does not flag as read-only' do
3533 3534
        expect { project.migrate_to_hashed_storage! }.not_to change { project.repository_read_only }
      end
3535 3536

      context 'when partially migrated' do
G
Gabriel Mazetto 已提交
3537
        it 'enqueues a job' do
3538 3539
          project = create(:project, storage_version: 1, skip_disk_validation: true)

G
Gabriel Mazetto 已提交
3540
          Sidekiq::Testing.fake! do
3541
            expect { project.migrate_to_hashed_storage! }.to change(HashedStorage::ProjectMigrateWorker.jobs, :size).by(1)
G
Gabriel Mazetto 已提交
3542
          end
3543 3544
        end
      end
3545
    end
3546 3547 3548 3549 3550 3551 3552 3553 3554 3555 3556 3557 3558 3559 3560 3561 3562 3563 3564 3565

    describe '#rollback_to_legacy_storage!' do
      let(:project) { create(:project, :repository, skip_disk_validation: true) }

      it 'returns true' do
        expect(project.rollback_to_legacy_storage!).to be_truthy
      end

      it 'does not run validations' do
        expect(project).not_to receive(:valid?)

        project.rollback_to_legacy_storage!
      end

      it 'does not flag as read-only' do
        expect { project.rollback_to_legacy_storage! }.not_to change { project.repository_read_only }
      end

      it 'enqueues a job' do
        Sidekiq::Testing.fake! do
3566
          expect { project.rollback_to_legacy_storage! }.to change(HashedStorage::ProjectRollbackWorker.jobs, :size).by(1)
3567 3568 3569
        end
      end
    end
3570 3571 3572 3573 3574 3575 3576 3577 3578 3579
  end

  describe '#gl_repository' do
    let(:project) { create(:project) }

    it 'delegates to Gitlab::GlRepository.gl_repository' do
      expect(Gitlab::GlRepository).to receive(:gl_repository).with(project, true)

      project.gl_repository(is_wiki: true)
    end
3580
  end
3581 3582 3583 3584 3585 3586 3587 3588 3589 3590 3591 3592 3593 3594 3595 3596 3597 3598 3599 3600 3601 3602 3603 3604

  describe '#has_ci?' do
    set(:project) { create(:project) }
    let(:repository) { double }

    before do
      expect(project).to receive(:repository) { repository }
    end

    context 'when has .gitlab-ci.yml' do
      before do
        expect(repository).to receive(:gitlab_ci_yml) { 'content' }
      end

      it "CI is available" do
        expect(project).to have_ci
      end
    end

    context 'when there is no .gitlab-ci.yml' do
      before do
        expect(repository).to receive(:gitlab_ci_yml) { nil }
      end

3605 3606
      it "CI is available" do
        expect(project).to have_ci
3607 3608
      end

3609
      context 'when auto devops is disabled' do
3610
        before do
3611
          stub_application_setting(auto_devops_enabled: false)
3612 3613
        end

3614 3615
        it "CI is not available" do
          expect(project).not_to have_ci
3616 3617 3618 3619 3620 3621
        end
      end
    end
  end

  describe '#auto_devops_enabled?' do
3622 3623 3624 3625 3626
    before do
      allow(Feature).to receive(:enabled?).and_call_original
      Feature.get(:force_autodevops_on_by_default).enable_percentage_of_actors(0)
    end

3627 3628 3629 3630
    set(:project) { create(:project) }

    subject { project.auto_devops_enabled? }

3631 3632 3633 3634 3635 3636 3637 3638 3639 3640 3641 3642 3643 3644 3645 3646
    context 'when explicitly enabled' do
      before do
        create(:project_auto_devops, project: project)
      end

      it { is_expected.to be_truthy }
    end

    context 'when explicitly disabled' do
      before do
        create(:project_auto_devops, project: project, enabled: false)
      end

      it { is_expected.to be_falsey }
    end

3647 3648 3649 3650 3651
    context 'when enabled in settings' do
      before do
        stub_application_setting(auto_devops_enabled: true)
      end

3652
      it { is_expected.to be_truthy }
3653 3654 3655 3656 3657 3658 3659 3660
    end

    context 'when disabled in settings' do
      before do
        stub_application_setting(auto_devops_enabled: false)
      end

      it { is_expected.to be_falsey }
3661 3662 3663 3664 3665 3666

      context 'when explicitly enabled' do
        before do
          create(:project_auto_devops, project: project)
        end

3667
        it { is_expected.to be_truthy }
3668 3669 3670 3671
      end

      context 'when explicitly disabled' do
        before do
3672
          create(:project_auto_devops, :disabled, project: project)
3673 3674
        end

3675
        it { is_expected.to be_falsey }
3676 3677 3678
      end
    end

3679 3680 3681 3682 3683 3684 3685
    context 'when force_autodevops_on_by_default is enabled for the project' do
      it { is_expected.to be_truthy }
    end

    context 'with group parents' do
      let(:instance_enabled) { true }

3686
      before do
3687 3688
        stub_application_setting(auto_devops_enabled: instance_enabled)
        project.update!(namespace: parent_group)
3689 3690
      end

3691 3692
      context 'when enabled on parent' do
        let(:parent_group) { create(:group, :auto_devops_enabled) }
3693

3694 3695
        context 'when auto devops instance enabled' do
          it { is_expected.to be_truthy }
3696 3697
        end

3698 3699 3700 3701 3702
        context 'when auto devops instance disabled' do
          let(:instance_disabled) { false }

          it { is_expected.to be_truthy }
        end
3703 3704
      end

3705 3706 3707 3708 3709
      context 'when disabled on parent' do
        let(:parent_group) { create(:group, :auto_devops_disabled) }

        context 'when auto devops instance enabled' do
          it { is_expected.to be_falsy }
3710
        end
3711

3712 3713 3714 3715 3716 3717 3718 3719 3720 3721 3722 3723 3724 3725 3726 3727 3728 3729 3730 3731 3732 3733 3734 3735 3736 3737 3738 3739 3740 3741 3742 3743 3744 3745 3746 3747 3748 3749 3750 3751 3752 3753 3754 3755 3756
        context 'when auto devops instance disabled' do
          let(:instance_disabled) { false }

          it { is_expected.to be_falsy }
        end
      end

      context 'when enabled on root parent', :nested_groups do
        let(:parent_group) { create(:group, parent: create(:group, :auto_devops_enabled)) }

        context 'when auto devops instance enabled' do
          it { is_expected.to be_truthy }
        end

        context 'when auto devops instance disabled' do
          let(:instance_disabled) { false }

          it { is_expected.to be_truthy }
        end

        context 'when explicitly disabled on parent' do
          let(:parent_group) { create(:group, :auto_devops_disabled, parent: create(:group, :auto_devops_enabled)) }

          it { is_expected.to be_falsy }
        end
      end

      context 'when disabled on root parent', :nested_groups do
        let(:parent_group) { create(:group, parent: create(:group, :auto_devops_disabled)) }

        context 'when auto devops instance enabled' do
          it { is_expected.to be_falsy }
        end

        context 'when auto devops instance disabled' do
          let(:instance_disabled) { false }

          it { is_expected.to be_falsy }
        end

        context 'when explicitly disabled on parent' do
          let(:parent_group) { create(:group, :auto_devops_disabled, parent: create(:group, :auto_devops_enabled)) }

          it { is_expected.to be_falsy }
        end
3757 3758 3759 3760
      end
    end
  end

3761 3762 3763 3764 3765 3766 3767 3768 3769 3770 3771 3772 3773 3774 3775 3776 3777 3778 3779 3780 3781 3782 3783 3784 3785 3786 3787 3788 3789 3790 3791 3792 3793 3794 3795 3796 3797 3798 3799 3800 3801 3802
  describe '#has_auto_devops_implicitly_enabled?' do
    set(:project) { create(:project) }

    context 'when disabled in settings' do
      before do
        stub_application_setting(auto_devops_enabled: false)
      end

      it 'does not have auto devops implicitly disabled' do
        expect(project).not_to have_auto_devops_implicitly_enabled
      end
    end

    context 'when enabled in settings' do
      before do
        stub_application_setting(auto_devops_enabled: true)
      end

      it 'auto devops is implicitly disabled' do
        expect(project).to have_auto_devops_implicitly_enabled
      end

      context 'when explicitly disabled' do
        before do
          create(:project_auto_devops, project: project, enabled: false)
        end

        it 'does not have auto devops implicitly disabled' do
          expect(project).not_to have_auto_devops_implicitly_enabled
        end
      end

      context 'when explicitly enabled' do
        before do
          create(:project_auto_devops, project: project, enabled: true)
        end

        it 'does not have auto devops implicitly disabled' do
          expect(project).not_to have_auto_devops_implicitly_enabled
        end
      end
    end
3803 3804 3805 3806 3807 3808 3809 3810 3811 3812 3813 3814 3815 3816 3817 3818 3819

    context 'when enabled on group' do
      it 'has auto devops implicitly enabled' do
        project.update(namespace: create(:group, :auto_devops_enabled))

        expect(project).to have_auto_devops_implicitly_enabled
      end
    end

    context 'when enabled on parent group' do
      it 'has auto devops implicitly enabled' do
        subgroup = create(:group, parent: create(:group, :auto_devops_enabled))
        project.update(namespace: subgroup)

        expect(project).to have_auto_devops_implicitly_enabled
      end
    end
3820 3821
  end

3822
  describe '#has_auto_devops_implicitly_disabled?' do
3823 3824
    set(:project) { create(:project) }

3825 3826 3827 3828 3829
    before do
      allow(Feature).to receive(:enabled?).and_call_original
      Feature.get(:force_autodevops_on_by_default).enable_percentage_of_actors(0)
    end

3830 3831 3832 3833 3834 3835 3836 3837 3838 3839 3840 3841 3842 3843 3844 3845 3846 3847 3848
    context 'when explicitly disabled' do
      before do
        create(:project_auto_devops, project: project, enabled: false)
      end

      it 'does not have auto devops implicitly disabled' do
        expect(project).not_to have_auto_devops_implicitly_disabled
      end
    end

    context 'when explicitly enabled' do
      before do
        create(:project_auto_devops, project: project, enabled: true)
      end

      it 'does not have auto devops implicitly disabled' do
        expect(project).not_to have_auto_devops_implicitly_disabled
      end
    end
3849 3850 3851 3852 3853 3854 3855 3856 3857 3858 3859 3860 3861 3862 3863 3864 3865 3866 3867 3868

    context 'when enabled in settings' do
      before do
        stub_application_setting(auto_devops_enabled: true)
      end

      it 'does not have auto devops implicitly disabled' do
        expect(project).not_to have_auto_devops_implicitly_disabled
      end
    end

    context 'when disabled in settings' do
      before do
        stub_application_setting(auto_devops_enabled: false)
      end

      it 'auto devops is implicitly disabled' do
        expect(project).to have_auto_devops_implicitly_disabled
      end

3869 3870
      context 'when force_autodevops_on_by_default is enabled for the project' do
        before do
3871 3872
          create(:project_auto_devops, project: project, enabled: false)

3873 3874 3875 3876 3877 3878 3879 3880
          Feature.get(:force_autodevops_on_by_default).enable_percentage_of_actors(100)
        end

        it 'does not have auto devops implicitly disabled' do
          expect(project).not_to have_auto_devops_implicitly_disabled
        end
      end

3881 3882 3883
      context 'when disabled on group' do
        it 'has auto devops implicitly disabled' do
          project.update!(namespace: create(:group, :auto_devops_disabled))
3884

3885
          expect(project).to have_auto_devops_implicitly_disabled
3886 3887 3888
        end
      end

3889 3890 3891 3892
      context 'when disabled on parent group' do
        it 'has auto devops implicitly disabled' do
          subgroup = create(:group, parent: create(:group, :auto_devops_disabled))
          project.update!(namespace: subgroup)
3893

3894
          expect(project).to have_auto_devops_implicitly_disabled
3895 3896 3897 3898 3899
        end
      end
    end
  end

3900 3901 3902 3903 3904 3905 3906 3907
  describe '#api_variables' do
    set(:project) { create(:project) }

    it 'exposes API v4 URL' do
      expect(project.api_variables.first[:key]).to eq 'CI_API_V4_URL'
      expect(project.api_variables.first[:value]).to include '/api/v4'
    end

3908
    it 'contains a URL variable for every supported API version' do
3909 3910 3911
      # Ensure future API versions have proper variables defined. We're not doing this for v3.
      supported_versions = API::API.versions - ['v3']
      supported_versions = supported_versions.select do |version|
3912 3913 3914 3915 3916 3917 3918 3919 3920 3921 3922 3923 3924
        API::API.routes.select { |route| route.version == version }.many?
      end

      required_variables = supported_versions.map do |version|
        "CI_API_#{version.upcase}_URL"
      end

      expect(project.api_variables.map { |variable| variable[:key] })
        .to contain_exactly(*required_variables)
    end
  end

  describe '#auto_devops_variables' do
3925 3926 3927 3928
    set(:project) { create(:project) }

    subject { project.auto_devops_variables }

3929
    context 'when enabled in instance settings' do
3930 3931 3932 3933
      before do
        stub_application_setting(auto_devops_enabled: true)
      end

3934 3935 3936 3937 3938 3939 3940 3941 3942 3943 3944 3945 3946 3947 3948 3949 3950 3951 3952 3953 3954
      context 'when domain is empty' do
        before do
          stub_application_setting(auto_devops_domain: nil)
        end

        it 'variables does not include AUTO_DEVOPS_DOMAIN' do
          is_expected.not_to include(domain_variable)
        end
      end

      context 'when domain is configured' do
        before do
          stub_application_setting(auto_devops_domain: 'example.com')
        end

        it 'variables includes AUTO_DEVOPS_DOMAIN' do
          is_expected.to include(domain_variable)
        end
      end
    end

G
George Tsiolis 已提交
3955
    context 'when explicitly enabled' do
3956 3957 3958 3959 3960
      context 'when domain is empty' do
        before do
          create(:project_auto_devops, project: project, domain: nil)
        end

3961 3962
        it 'variables does not include AUTO_DEVOPS_DOMAIN' do
          is_expected.not_to include(domain_variable)
3963 3964 3965 3966 3967 3968 3969 3970
        end
      end

      context 'when domain is configured' do
        before do
          create(:project_auto_devops, project: project, domain: 'example.com')
        end

3971 3972
        it 'variables includes AUTO_DEVOPS_DOMAIN' do
          is_expected.to include(domain_variable)
3973 3974 3975
        end
      end
    end
3976 3977 3978 3979

    def domain_variable
      { key: 'AUTO_DEVOPS_DOMAIN', value: 'example.com', public: true }
    end
3980
  end
3981 3982 3983 3984 3985 3986 3987 3988 3989 3990 3991 3992 3993 3994 3995 3996 3997 3998 3999 4000 4001 4002 4003 4004 4005 4006 4007 4008

  describe '#latest_successful_builds_for' do
    let(:project) { build(:project) }

    before do
      allow(project).to receive(:default_branch).and_return('master')
    end

    context 'without a ref' do
      it 'returns a pipeline for the default branch' do
        expect(project)
          .to receive(:latest_successful_pipeline_for_default_branch)

        project.latest_successful_pipeline_for
      end
    end

    context 'with the ref set to the default branch' do
      it 'returns a pipeline for the default branch' do
        expect(project)
          .to receive(:latest_successful_pipeline_for_default_branch)

        project.latest_successful_pipeline_for(project.default_branch)
      end
    end

    context 'with a ref that is not the default branch' do
      it 'returns the latest successful pipeline for the given ref' do
4009
        expect(project.ci_pipelines).to receive(:latest_successful_for).with('foo')
4010 4011 4012 4013 4014 4015

        project.latest_successful_pipeline_for('foo')
      end
    end
  end

S
Stan Hu 已提交
4016 4017 4018 4019 4020 4021 4022 4023 4024 4025 4026
  describe '#check_repository_path_availability' do
    let(:project) { build(:project) }

    it 'skips gitlab-shell exists?' do
      project.skip_disk_validation = true

      expect(project.gitlab_shell).not_to receive(:exists?)
      expect(project.check_repository_path_availability).to be_truthy
    end
  end

4027 4028 4029 4030 4031 4032 4033 4034 4035 4036
  describe '#latest_successful_pipeline_for_default_branch' do
    let(:project) { build(:project) }

    before do
      allow(project).to receive(:default_branch).and_return('master')
    end

    it 'memoizes and returns the latest successful pipeline for the default branch' do
      pipeline = double(:pipeline)

4037
      expect(project.ci_pipelines).to receive(:latest_successful_for)
4038 4039 4040 4041 4042 4043 4044 4045 4046 4047
        .with(project.default_branch)
        .and_return(pipeline)
        .once

      2.times do
        expect(project.latest_successful_pipeline_for_default_branch)
          .to eq(pipeline)
      end
    end
  end
4048 4049

  describe '#after_import' do
4050
    let(:project) { create(:project) }
4051
    let(:import_state) { create(:import_state, project: project) }
4052 4053 4054

    it 'runs the correct hooks' do
      expect(project.repository).to receive(:after_import)
4055
      expect(project.wiki.repository).to receive(:after_import)
4056
      expect(import_state).to receive(:finish)
4057
      expect(project).to receive(:update_project_counter_caches)
4058
      expect(import_state).to receive(:remove_jid)
4059
      expect(project).to receive(:after_create_default_branch)
4060
      expect(project).to receive(:refresh_markdown_cache!)
4061
      expect(InternalId).to receive(:flush_records!).with(project: project)
4062 4063 4064

      project.after_import
    end
4065 4066 4067 4068

    context 'branch protection' do
      let(:project) { create(:project, :repository) }

4069 4070 4071 4072
      before do
        create(:import_state, :started, project: project)
      end

4073 4074 4075 4076 4077 4078 4079 4080 4081 4082 4083 4084 4085 4086 4087 4088 4089 4090 4091 4092 4093 4094 4095 4096 4097 4098 4099 4100 4101 4102 4103 4104 4105
      it 'does not protect when branch protection is disabled' do
        stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_NONE)

        project.after_import

        expect(project.protected_branches).to be_empty
      end

      it "gives developer access to push when branch protection is set to 'developers can push'" do
        stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_DEV_CAN_PUSH)

        project.after_import

        expect(project.protected_branches).not_to be_empty
        expect(project.default_branch).to eq(project.protected_branches.first.name)
        expect(project.protected_branches.first.push_access_levels.map(&:access_level)).to eq([Gitlab::Access::DEVELOPER])
      end

      it "gives developer access to merge when branch protection is set to 'developers can merge'" do
        stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_DEV_CAN_MERGE)

        project.after_import

        expect(project.protected_branches).not_to be_empty
        expect(project.default_branch).to eq(project.protected_branches.first.name)
        expect(project.protected_branches.first.merge_access_levels.map(&:access_level)).to eq([Gitlab::Access::DEVELOPER])
      end

      it 'protects default branch' do
        project.after_import

        expect(project.protected_branches).not_to be_empty
        expect(project.default_branch).to eq(project.protected_branches.first.name)
4106 4107
        expect(project.protected_branches.first.push_access_levels.map(&:access_level)).to eq([Gitlab::Access::MAINTAINER])
        expect(project.protected_branches.first.merge_access_levels.map(&:access_level)).to eq([Gitlab::Access::MAINTAINER])
4108 4109
      end
    end
4110 4111 4112 4113 4114 4115 4116 4117 4118 4119 4120 4121 4122 4123 4124 4125 4126 4127 4128 4129 4130 4131 4132 4133 4134 4135 4136 4137 4138 4139 4140
  end

  describe '#update_project_counter_caches' do
    let(:project) { create(:project) }

    it 'updates all project counter caches' do
      expect_any_instance_of(Projects::OpenIssuesCountService)
        .to receive(:refresh_cache)
        .and_call_original

      expect_any_instance_of(Projects::OpenMergeRequestsCountService)
        .to receive(:refresh_cache)
        .and_call_original

      project.update_project_counter_caches
    end
  end

  describe '#wiki_repository_exists?' do
    it 'returns true when the wiki repository exists' do
      project = create(:project, :wiki_repo)

      expect(project.wiki_repository_exists?).to eq(true)
    end

    it 'returns false when the wiki repository does not exist' do
      project = create(:project)

      expect(project.wiki_repository_exists?).to eq(false)
    end
  end
4141

4142 4143 4144 4145 4146 4147
  describe '#write_repository_config' do
    set(:project) { create(:project, :repository) }

    it 'writes full path in .git/config when key is missing' do
      project.write_repository_config

4148
      expect(rugged_config['gitlab.fullpath']).to eq project.full_path
4149 4150 4151 4152 4153
    end

    it 'updates full path in .git/config when key is present' do
      project.write_repository_config(gl_full_path: 'old/path')

4154
      expect { project.write_repository_config }.to change { rugged_config['gitlab.fullpath'] }.from('old/path').to(project.full_path)
4155 4156 4157 4158 4159 4160 4161 4162
    end

    it 'does not raise an error with an empty repository' do
      project = create(:project_empty_repo)

      expect { project.write_repository_config }.not_to raise_error
    end
  end
4163 4164

  describe '#execute_hooks' do
4165
    let(:data) { { ref: 'refs/heads/master', data: 'data' } }
D
Duana Saskia 已提交
4166
    it 'executes active projects hooks with the specified scope' do
4167 4168 4169 4170
      hook = create(:project_hook, merge_requests_events: false, push_events: true)
      expect(ProjectHook).to receive(:select_active)
        .with(:push_hooks, data)
        .and_return([hook])
4171
      project = create(:project, hooks: [hook])
4172 4173 4174

      expect_any_instance_of(ProjectHook).to receive(:async_execute).once

4175
      project.execute_hooks(data, :push_hooks)
4176 4177 4178
    end

    it 'does not execute project hooks that dont match the specified scope' do
4179
      hook = create(:project_hook, merge_requests_events: true, push_events: false)
4180 4181 4182 4183
      project = create(:project, hooks: [hook])

      expect_any_instance_of(ProjectHook).not_to receive(:async_execute).once

4184
      project.execute_hooks(data, :push_hooks)
4185 4186
    end

D
Duana Saskia 已提交
4187
    it 'does not execute project hooks which are not active' do
4188 4189 4190 4191
      hook = create(:project_hook, push_events: true)
      expect(ProjectHook).to receive(:select_active)
        .with(:push_hooks, data)
        .and_return([])
D
Duana Saskia 已提交
4192 4193 4194 4195
      project = create(:project, hooks: [hook])

      expect_any_instance_of(ProjectHook).not_to receive(:async_execute).once

4196
      project.execute_hooks(data, :push_hooks)
4197 4198 4199
    end

    it 'executes the system hooks with the specified scope' do
4200
      expect_any_instance_of(SystemHooksService).to receive(:execute_hooks).with(data, :merge_request_hooks)
4201

4202
      project = build(:project)
4203
      project.execute_hooks(data, :merge_request_hooks)
4204
    end
4205 4206 4207 4208 4209 4210 4211 4212 4213 4214 4215 4216 4217

    it 'executes the system hooks when inside a transaction' do
      allow_any_instance_of(WebHookService).to receive(:execute)

      create(:system_hook, merge_requests_events: true)

      project = build(:project)

      # Ideally, we'd test that `WebHookWorker.jobs.size` increased by 1,
      # but since the entire spec run takes place in a transaction, we never
      # actually get to the `after_commit` hook that queues these jobs.
      expect do
        project.transaction do
4218
          project.execute_hooks(data, :merge_request_hooks)
4219 4220 4221
        end
      end.not_to raise_error # Sidekiq::Worker::EnqueueFromTransactionError
    end
4222
  end
4223 4224 4225

  describe '#badges' do
    let(:project_group) { create(:group) }
4226
    let(:project) { create(:project, path: 'avatar', namespace: project_group) }
4227 4228 4229 4230 4231 4232 4233 4234 4235 4236 4237 4238 4239

    before do
      create_list(:project_badge, 2, project: project)
      create(:group_badge, group: project_group)
    end

    it 'returns the project and the project group badges' do
      create(:group_badge, group: create(:group))

      expect(Badge.count).to eq 4
      expect(project.badges.count).to eq 3
    end

4240
    if Group.supports_nested_objects?
4241 4242 4243 4244 4245 4246 4247 4248 4249 4250 4251 4252 4253 4254
      context 'with nested_groups' do
        let(:parent_group) { create(:group) }

        before do
          create_list(:group_badge, 2, group: project_group)
          project_group.update(parent: parent_group)
        end

        it 'returns the project and the project nested groups badges' do
          expect(project.badges.count).to eq 5
        end
      end
    end
  end
4255

4256 4257
  context 'with cross project merge requests' do
    let(:user) { create(:user) }
4258 4259
    let(:target_project) { create(:project, :repository) }
    let(:project) { fork_project(target_project, nil, repository: true) }
4260 4261 4262 4263 4264 4265 4266 4267 4268 4269
    let!(:local_merge_request) do
      create(
        :merge_request,
        target_project: project,
        target_branch: 'target-branch',
        source_project: project,
        source_branch: 'awesome-feature-1',
        allow_collaboration: true
      )
    end
4270 4271 4272 4273
    let!(:merge_request) do
      create(
        :merge_request,
        target_project: target_project,
4274
        target_branch: 'target-branch',
4275 4276
        source_project: project,
        source_branch: 'awesome-feature-1',
4277
        allow_collaboration: true
4278 4279 4280 4281
      )
    end

    before do
4282
      target_project.add_developer(user)
4283 4284
    end

4285 4286 4287 4288
    describe '#merge_requests_allowing_push_to_user' do
      it 'returns open merge requests for which the user has developer access to the target project' do
        expect(project.merge_requests_allowing_push_to_user(user)).to include(merge_request)
      end
4289

4290 4291
      it 'does not include closed merge requests' do
        merge_request.close
4292

4293 4294 4295 4296 4297 4298
        expect(project.merge_requests_allowing_push_to_user(user)).to be_empty
      end

      it 'does not include merge requests for guest users' do
        guest = create(:user)
        target_project.add_guest(guest)
4299

4300 4301 4302 4303 4304 4305 4306 4307 4308 4309 4310 4311
        expect(project.merge_requests_allowing_push_to_user(guest)).to be_empty
      end

      it 'does not include the merge request for other users' do
        other_user = create(:user)

        expect(project.merge_requests_allowing_push_to_user(other_user)).to be_empty
      end

      it 'is empty when no user is passed' do
        expect(project.merge_requests_allowing_push_to_user(nil)).to be_empty
      end
4312 4313
    end

4314 4315 4316
    describe '#any_branch_allows_collaboration?' do
      it 'allows access when there are merge requests open allowing collaboration' do
        expect(project.any_branch_allows_collaboration?(user))
4317 4318 4319
          .to be_truthy
      end

4320 4321 4322 4323 4324 4325 4326 4327 4328 4329 4330
      it 'does not allow access when there are no merge requests open allowing collaboration' do
        merge_request.close!

        expect(project.any_branch_allows_collaboration?(user))
          .to be_falsey
      end
    end

    describe '#branch_allows_collaboration?' do
      it 'allows access if the user can merge the merge request' do
        expect(project.branch_allows_collaboration?(user, 'awesome-feature-1'))
4331 4332 4333
          .to be_truthy
      end

4334 4335 4336 4337
      it 'does not allow guest users access' do
        guest = create(:user)
        target_project.add_guest(guest)

4338
        expect(project.branch_allows_collaboration?(guest, 'awesome-feature-1'))
4339 4340 4341
          .to be_falsy
      end

4342
      it 'does not allow access to branches for which the merge request was closed' do
4343 4344
        create(:merge_request, :closed,
               target_project: target_project,
4345
               target_branch: 'target-branch',
4346 4347
               source_project: project,
               source_branch: 'rejected-feature-1',
4348
               allow_collaboration: true)
4349

4350
        expect(project.branch_allows_collaboration?(user, 'rejected-feature-1'))
4351 4352 4353
          .to be_falsy
      end

4354
      it 'does not allow access if the user cannot merge the merge request' do
4355
        create(:protected_branch, :maintainers_can_push, project: target_project, name: 'target-branch')
4356

4357
        expect(project.branch_allows_collaboration?(user, 'awesome-feature-1'))
4358 4359 4360
          .to be_falsy
      end

4361
      context 'when the requeststore is active', :request_store do
4362
        it 'only queries per project across instances' do
4363
          control = ActiveRecord::QueryRecorder.new { project.branch_allows_collaboration?(user, 'awesome-feature-1') }
4364

4365
          expect { 2.times { described_class.find(project.id).branch_allows_collaboration?(user, 'awesome-feature-1') } }
4366
            .not_to exceed_query_limit(control).with_threshold(2)
4367
        end
4368 4369 4370
      end
    end
  end
R
Rob Watson 已提交
4371 4372 4373 4374 4375 4376 4377 4378 4379 4380 4381 4382 4383 4384 4385 4386 4387 4388 4389 4390 4391 4392 4393 4394 4395 4396 4397 4398 4399 4400 4401 4402 4403 4404 4405 4406 4407 4408 4409 4410 4411 4412 4413 4414 4415

  describe "#pages_https_only?" do
    subject { build(:project) }

    context "when HTTPS pages are disabled" do
      it { is_expected.not_to be_pages_https_only }
    end

    context "when HTTPS pages are enabled", :https_pages_enabled do
      it { is_expected.to be_pages_https_only }
    end
  end

  describe "#pages_https_only? validation", :https_pages_enabled do
    subject(:project) do
      # set-up dirty object:
      create(:project, pages_https_only: false).tap do |p|
        p.pages_https_only = true
      end
    end

    context "when no domains are associated" do
      it { is_expected.to be_valid }
    end

    context "when domains including keys and certificates are associated" do
      before do
        allow(project)
          .to receive(:pages_domains)
          .and_return([instance_double(PagesDomain, https?: true)])
      end

      it { is_expected.to be_valid }
    end

    context "when domains including no keys or certificates are associated" do
      before do
        allow(project)
          .to receive(:pages_domains)
          .and_return([instance_double(PagesDomain, https?: false)])
      end

      it { is_expected.not_to be_valid }
    end
  end
4416

4417
  describe '#toggle_ci_cd_settings!' do
4418
    it 'toggles the value on #settings' do
4419
      project = create(:project, group_runners_enabled: false)
4420 4421 4422

      expect(project.group_runners_enabled).to be false

4423
      project.toggle_ci_cd_settings!(:group_runners_enabled)
4424 4425 4426 4427

      expect(project.group_runners_enabled).to be true
    end
  end
4428

4429 4430 4431 4432 4433 4434 4435 4436 4437 4438 4439 4440 4441 4442 4443 4444 4445 4446 4447 4448
  describe '#gitlab_deploy_token' do
    let(:project) { create(:project) }

    subject { project.gitlab_deploy_token }

    context 'when there is a gitlab deploy token associated' do
      let!(:deploy_token) { create(:deploy_token, :gitlab_deploy_token, projects: [project]) }

      it { is_expected.to eq(deploy_token) }
    end

    context 'when there is no a gitlab deploy token associated' do
      it { is_expected.to be_nil }
    end

    context 'when there is a gitlab deploy token associated but is has been revoked' do
      let!(:deploy_token) { create(:deploy_token, :gitlab_deploy_token, :revoked, projects: [project]) }
      it { is_expected.to be_nil }
    end

4449
    context 'when there is a gitlab deploy token associated but it is expired' do
4450 4451 4452 4453
      let!(:deploy_token) { create(:deploy_token, :gitlab_deploy_token, :expired, projects: [project]) }

      it { is_expected.to be_nil }
    end
4454

4455
    context 'when there is a deploy token associated with a different name' do
4456 4457 4458 4459
      let!(:deploy_token) { create(:deploy_token, projects: [project]) }

      it { is_expected.to be_nil }
    end
4460 4461 4462 4463 4464 4465 4466

    context 'when there is a deploy token associated to a different project' do
      let(:project_2) { create(:project) }
      let!(:deploy_token) { create(:deploy_token, projects: [project_2]) }

      it { is_expected.to be_nil }
    end
4467
  end
J
Jan Provaznik 已提交
4468 4469

  context 'with uploads' do
4470
    it_behaves_like 'model with uploads', true do
J
Jan Provaznik 已提交
4471 4472 4473 4474 4475
      let(:model_object) { create(:project, :with_avatar) }
      let(:upload_attribute) { :avatar }
      let(:uploader_class) { AttachmentUploader }
    end
  end
4476

4477 4478 4479 4480 4481 4482 4483 4484 4485 4486
  context '#commits_by' do
    let(:project) { create(:project, :repository) }
    let(:commits) { project.repository.commits('HEAD', limit: 3).commits }
    let(:commit_shas) { commits.map(&:id) }

    it 'retrieves several commits from the repository by oid' do
      expect(project.commits_by(oids: commit_shas)).to eq commits
    end
  end

4487 4488 4489 4490 4491 4492 4493 4494 4495 4496 4497 4498 4499 4500 4501 4502 4503 4504 4505 4506 4507 4508 4509 4510 4511 4512 4513 4514 4515 4516 4517 4518 4519 4520 4521 4522 4523 4524 4525 4526 4527
  context '#members_among' do
    let(:users) { create_list(:user, 3) }
    set(:group) { create(:group) }
    set(:project) { create(:project, namespace: group) }

    before do
      project.add_guest(users.first)
      project.group.add_maintainer(users.last)
    end

    context 'when users is an Array' do
      it 'returns project members among the users' do
        expect(project.members_among(users)).to eq([users.first, users.last])
      end

      it 'maintains input order' do
        expect(project.members_among(users.reverse)).to eq([users.last, users.first])
      end

      it 'returns empty array if users is empty' do
        result = project.members_among([])

        expect(result).to be_empty
      end
    end

    context 'when users is a relation' do
      it 'returns project members among the users' do
        result = project.members_among(User.where(id: users.map(&:id)))

        expect(result).to be_a(ActiveRecord::Relation)
        expect(result).to eq([users.first, users.last])
      end

      it 'returns empty relation if users is empty' do
        result = project.members_among(User.none)

        expect(result).to be_a(ActiveRecord::Relation)
        expect(result).to be_empty
      end
    end
4528
  end
4529

4530 4531
  describe "#find_or_initialize_services" do
    subject { build(:project) }
4532

4533 4534 4535
    it 'returns only enabled services' do
      allow(Service).to receive(:available_services_names).and_return(%w(prometheus pushover))
      allow(subject).to receive(:disabled_services).and_return(%w(prometheus))
4536

4537
      services = subject.find_or_initialize_services
4538

4539 4540 4541 4542
      expect(services.count).to eq 1
      expect(services).to include(PushoverService)
    end
  end
4543

4544 4545 4546 4547 4548 4549 4550 4551 4552 4553 4554 4555 4556 4557 4558 4559 4560
  describe "#find_or_initialize_service" do
    subject { build(:project) }

    it 'avoids N+1 database queries' do
      allow(Service).to receive(:available_services_names).and_return(%w(prometheus pushover))

      control_count = ActiveRecord::QueryRecorder.new { subject.find_or_initialize_service('prometheus') }.count

      allow(Service).to receive(:available_services_names).and_call_original

      expect { subject.find_or_initialize_service('prometheus') }.not_to exceed_query_limit(control_count)
    end

    it 'returns nil if service is disabled' do
      allow(subject).to receive(:disabled_services).and_return(%w(prometheus))

      expect(subject.find_or_initialize_service('prometheus')).to be_nil
4561
    end
4562 4563
  end

4564 4565 4566 4567 4568 4569 4570 4571 4572 4573 4574 4575 4576 4577 4578 4579 4580 4581 4582 4583 4584 4585 4586
  describe '.find_without_deleted' do
    it 'returns nil if the project is about to be removed' do
      project = create(:project, pending_delete: true)

      expect(described_class.find_without_deleted(project.id)).to be_nil
    end

    it 'returns a project when it is not about to be removed' do
      project = create(:project)

      expect(described_class.find_without_deleted(project.id)).to eq(project)
    end
  end

  describe '.for_group' do
    it 'returns the projects for a given group' do
      group = create(:group)
      project = create(:project, namespace: group)

      expect(described_class.for_group(group)).to eq([project])
    end
  end

S
Shinya Maeda 已提交
4587 4588 4589 4590 4591 4592 4593 4594 4595 4596 4597 4598 4599 4600 4601 4602 4603 4604 4605 4606 4607 4608 4609 4610 4611 4612 4613 4614 4615 4616 4617 4618 4619 4620
  describe '.deployments' do
    subject { project.deployments }

    let(:project) { create(:project) }

    before do
      allow_any_instance_of(Deployment).to receive(:create_ref)
    end

    context 'when there is a deployment record with created status' do
      let(:deployment) { create(:deployment, :created, project: project) }

      it 'does not return the record' do
        is_expected.to be_empty
      end
    end

    context 'when there is a deployment record with running status' do
      let(:deployment) { create(:deployment, :running, project: project) }

      it 'does not return the record' do
        is_expected.to be_empty
      end
    end

    context 'when there is a deployment record with success status' do
      let(:deployment) { create(:deployment, :success, project: project) }

      it 'returns the record' do
        is_expected.to eq([deployment])
      end
    end
  end

4621 4622 4623 4624 4625 4626 4627 4628 4629 4630 4631 4632 4633 4634 4635 4636 4637 4638 4639 4640 4641 4642
  describe '#snippets_visible?' do
    it 'returns true when a logged in user can read snippets' do
      project = create(:project, :public)
      user = create(:user)

      expect(project.snippets_visible?(user)).to eq(true)
    end

    it 'returns true when an anonymous user can read snippets' do
      project = create(:project, :public)

      expect(project.snippets_visible?).to eq(true)
    end

    it 'returns false when a user can not read snippets' do
      project = create(:project, :private)
      user = create(:user)

      expect(project.snippets_visible?(user)).to eq(false)
    end
  end

T
Thong Kuah 已提交
4643 4644 4645 4646 4647 4648 4649 4650 4651 4652 4653 4654 4655 4656 4657 4658 4659 4660 4661 4662 4663
  describe '#all_clusters' do
    let(:project) { create(:project) }
    let(:cluster) { create(:cluster, cluster_type: :project_type, projects: [project]) }

    subject { project.all_clusters }

    it 'returns project level cluster' do
      expect(subject).to eq([cluster])
    end

    context 'project belongs to a group' do
      let(:group_cluster) { create(:cluster, :group) }
      let(:group) { group_cluster.group }
      let(:project) { create(:project, group: group) }

      it 'returns clusters for groups of this project' do
        expect(subject).to contain_exactly(cluster, group_cluster)
      end
    end
  end

4664 4665 4666 4667 4668 4669 4670 4671 4672 4673 4674 4675 4676 4677 4678 4679 4680 4681 4682 4683 4684 4685 4686
  describe '#object_pool_params' do
    let(:project) { create(:project, :repository, :public) }

    subject { project.object_pool_params }

    before do
      stub_application_setting(hashed_storage_enabled: true)
    end

    context 'when the objects cannot be pooled' do
      let(:project) { create(:project, :repository, :private) }

      it { is_expected.to be_empty }
    end

    context 'when a pool is created' do
      it 'returns that pool repository' do
        expect(subject).not_to be_empty
        expect(subject[:pool_repository]).to be_persisted
      end
    end
  end

4687 4688 4689 4690 4691 4692 4693 4694 4695 4696 4697 4698 4699 4700 4701 4702 4703 4704 4705 4706 4707 4708 4709 4710 4711 4712 4713 4714 4715 4716 4717 4718 4719 4720 4721 4722 4723 4724
  describe '#git_objects_poolable?' do
    subject { project }

    context 'when the feature flag is turned off' do
      before do
        stub_feature_flags(object_pools: false)
      end

      let(:project) { create(:project, :repository, :public) }

      it { is_expected.not_to be_git_objects_poolable }
    end

    context 'when the feature flag is enabled' do
      context 'when not using hashed storage' do
        let(:project) { create(:project, :legacy_storage, :public, :repository) }

        it { is_expected.not_to be_git_objects_poolable }
      end

      context 'when the project is not public' do
        let(:project) { create(:project, :private) }

        it { is_expected.not_to be_git_objects_poolable }
      end

      context 'when objects are poolable' do
        let(:project) { create(:project, :repository, :public) }

        before do
          stub_application_setting(hashed_storage_enabled: true)
        end

        it { is_expected.to be_git_objects_poolable }
      end
    end
  end

4725 4726 4727 4728 4729 4730 4731 4732 4733 4734 4735
  describe '#leave_pool_repository' do
    let(:pool) { create(:pool_repository) }
    let(:project) { create(:project, :repository, pool_repository: pool) }

    it 'removes the membership' do
      project.leave_pool_repository

      expect(pool.member_projects.reload).not_to include(project)
    end
  end

4736 4737 4738 4739 4740 4741 4742 4743 4744 4745 4746 4747 4748 4749 4750 4751 4752 4753 4754 4755 4756 4757 4758 4759 4760 4761 4762 4763 4764 4765 4766 4767 4768 4769 4770 4771 4772 4773 4774 4775 4776 4777 4778 4779 4780 4781 4782 4783 4784 4785 4786 4787 4788 4789 4790 4791 4792 4793 4794 4795 4796 4797 4798 4799 4800 4801 4802 4803 4804
  describe '#check_personal_projects_limit' do
    context 'when creating a project for a group' do
      it 'does nothing' do
        creator = build(:user)
        project = build(:project, namespace: build(:group), creator: creator)

        allow(creator)
          .to receive(:can_create_project?)
          .and_return(false)

        project.check_personal_projects_limit

        expect(project.errors).to be_empty
      end
    end

    context 'when the user is not allowed to create a personal project' do
      let(:user) { build(:user) }
      let(:project) { build(:project, creator: user) }

      before do
        allow(user)
          .to receive(:can_create_project?)
          .and_return(false)
      end

      context 'when the project limit is zero' do
        it 'adds a validation error' do
          allow(user)
            .to receive(:projects_limit)
            .and_return(0)

          project.check_personal_projects_limit

          expect(project.errors[:limit_reached].first)
            .to match(/Personal project creation is not allowed/)
        end
      end

      context 'when the project limit is greater than zero' do
        it 'adds a validation error' do
          allow(user)
            .to receive(:projects_limit)
            .and_return(5)

          project.check_personal_projects_limit

          expect(project.errors[:limit_reached].first)
            .to match(/Your project limit is 5 projects/)
        end
      end
    end

    context 'when the user is allowed to create personal projects' do
      it 'does nothing' do
        user = build(:user)
        project = build(:project, creator: user)

        allow(user)
          .to receive(:can_create_project?)
          .and_return(true)

        project.check_personal_projects_limit

        expect(project.errors).to be_empty
      end
    end
  end

4805 4806 4807 4808 4809 4810 4811 4812 4813 4814 4815 4816 4817 4818 4819
  describe '#has_pool_repsitory?' do
    it 'returns false when it does not have a pool repository' do
      subject = create(:project, :repository)

      expect(subject.has_pool_repository?).to be false
    end

    it 'returns true when it has a pool repository' do
      pool    = create(:pool_repository, :ready)
      subject = create(:project, :repository, pool_repository: pool)

      expect(subject.has_pool_repository?).to be true
    end
  end

4820
  def rugged_config
4821
    rugged_repo(project.repository).config
4822
  end
4823 4824 4825 4826 4827 4828 4829 4830 4831 4832 4833 4834 4835 4836

  def create_pipeline(project, status = 'success')
    create(:ci_pipeline, project: project,
                         sha: project.commit.sha,
                         ref: project.default_branch,
                         status: status)
  end

  def create_build(new_pipeline = pipeline, name = 'test')
    create(:ci_build, :success, :artifacts,
           pipeline: new_pipeline,
           status: new_pipeline.status,
           name: name)
  end
G
gitlabhq 已提交
4837
end