project_spec.rb 109.7 KB
Newer Older
G
gitlabhq 已提交
1 2
require 'spec_helper'

3
describe Project do
4 5
  include ProjectForksHelper

6
  describe 'associations' do
7 8 9 10
    it { is_expected.to belong_to(:group) }
    it { is_expected.to belong_to(:namespace) }
    it { is_expected.to belong_to(:creator).class_name('User') }
    it { is_expected.to have_many(:users) }
U
ubudzisz 已提交
11
    it { is_expected.to have_many(:services) }
12 13 14 15 16
    it { is_expected.to have_many(:events) }
    it { is_expected.to have_many(:merge_requests) }
    it { is_expected.to have_many(:issues) }
    it { is_expected.to have_many(:milestones) }
    it { is_expected.to have_many(:project_members).dependent(:delete_all) }
17
    it { is_expected.to have_many(:users).through(:project_members) }
18 19 20 21
    it { is_expected.to have_many(:requesters).dependent(:delete_all) }
    it { is_expected.to have_many(:notes) }
    it { is_expected.to have_many(:snippets).class_name('ProjectSnippet') }
    it { is_expected.to have_many(:deploy_keys_projects) }
22
    it { is_expected.to have_many(:deploy_keys) }
23 24 25 26 27 28
    it { is_expected.to have_many(:hooks) }
    it { is_expected.to have_many(:protected_branches) }
    it { is_expected.to have_one(:forked_project_link) }
    it { is_expected.to have_one(:slack_service) }
    it { is_expected.to have_one(:microsoft_teams_service) }
    it { is_expected.to have_one(:mattermost_service) }
M
Matt Coleman 已提交
29
    it { is_expected.to have_one(:packagist_service) }
30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56
    it { is_expected.to have_one(:pushover_service) }
    it { is_expected.to have_one(:asana_service) }
    it { is_expected.to have_many(:boards) }
    it { is_expected.to have_one(:campfire_service) }
    it { is_expected.to have_one(:drone_ci_service) }
    it { is_expected.to have_one(:emails_on_push_service) }
    it { is_expected.to have_one(:pipelines_email_service) }
    it { is_expected.to have_one(:irker_service) }
    it { is_expected.to have_one(:pivotaltracker_service) }
    it { is_expected.to have_one(:hipchat_service) }
    it { is_expected.to have_one(:flowdock_service) }
    it { is_expected.to have_one(:assembla_service) }
    it { is_expected.to have_one(:slack_slash_commands_service) }
    it { is_expected.to have_one(:mattermost_slash_commands_service) }
    it { is_expected.to have_one(:gemnasium_service) }
    it { is_expected.to have_one(:buildkite_service) }
    it { is_expected.to have_one(:bamboo_service) }
    it { is_expected.to have_one(:teamcity_service) }
    it { is_expected.to have_one(:jira_service) }
    it { is_expected.to have_one(:redmine_service) }
    it { is_expected.to have_one(:custom_issue_tracker_service) }
    it { is_expected.to have_one(:bugzilla_service) }
    it { is_expected.to have_one(:gitlab_issue_tracker_service) }
    it { is_expected.to have_one(:external_wiki_service) }
    it { is_expected.to have_one(:project_feature) }
    it { is_expected.to have_one(:statistics).class_name('ProjectStatistics') }
    it { is_expected.to have_one(:import_data).class_name('ProjectImportData') }
U
ubudzisz 已提交
57 58
    it { is_expected.to have_one(:last_event).class_name('Event') }
    it { is_expected.to have_one(:forked_from_project).through(:forked_project_link) }
Z
Zeger-Jan van de Weg 已提交
59
    it { is_expected.to have_one(:auto_devops).class_name('ProjectAutoDevops') }
K
Kamil Trzcinski 已提交
60
    it { is_expected.to have_many(:commit_statuses) }
61
    it { is_expected.to have_many(:pipelines) }
62
    it { is_expected.to have_many(:builds) }
63
    it { is_expected.to have_many(:build_trace_section_names)}
64 65
    it { is_expected.to have_many(:runner_projects) }
    it { is_expected.to have_many(:runners) }
K
Kamil Trzcinski 已提交
66
    it { is_expected.to have_many(:active_runners) }
67 68
    it { is_expected.to have_many(:variables) }
    it { is_expected.to have_many(:triggers) }
K
Kamil Trzcinski 已提交
69
    it { is_expected.to have_many(:pages_domains) }
70 71 72 73 74 75 76 77 78
    it { is_expected.to have_many(:labels).class_name('ProjectLabel') }
    it { is_expected.to have_many(:users_star_projects) }
    it { is_expected.to have_many(:environments) }
    it { is_expected.to have_many(:deployments) }
    it { is_expected.to have_many(:todos) }
    it { is_expected.to have_many(:releases) }
    it { is_expected.to have_many(:lfs_objects_projects) }
    it { is_expected.to have_many(:project_group_links) }
    it { is_expected.to have_many(:notification_settings).dependent(:delete_all) }
U
ubudzisz 已提交
79
    it { is_expected.to have_many(:forks).through(:forked_project_links) }
80
    it { is_expected.to have_many(:uploads).dependent(:destroy) }
81
    it { is_expected.to have_many(:pipeline_schedules) }
82
    it { is_expected.to have_many(:members_and_requesters) }
M
Matija Čupić 已提交
83
    it { is_expected.to have_many(:clusters) }
84
    it { is_expected.to have_many(:custom_attributes).class_name('ProjectCustomAttribute') }
85
    it { is_expected.to have_many(:project_badges).class_name('ProjectBadge') }
86
    it { is_expected.to have_many(:lfs_file_locks) }
M
Mayra Cabrera 已提交
87 88
    it { is_expected.to have_many(:project_deploy_tokens) }
    it { is_expected.to have_many(:deploy_tokens).through(:project_deploy_tokens) }
89

F
Felipe Artur 已提交
90 91
    context 'after initialized' do
      it "has a project_feature" do
92
        expect(described_class.new.project_feature).to be_present
93 94 95
      end
    end

96
    describe '#members & #requesters' do
97
      let(:project) { create(:project, :public, :access_requestable) }
98 99 100 101
      let(:requester) { create(:user) }
      let(:developer) { create(:user) }
      before do
        project.request_access(requester)
102
        project.add_developer(developer)
103 104
      end

105 106
      it_behaves_like 'members and requesters associations' do
        let(:namespace) { project }
107 108
      end
    end
109 110 111 112 113

    describe '#boards' do
      it 'raises an error when attempting to add more than one board to the project' do
        subject.boards.build

114
        expect { subject.boards.build }.to raise_error(Project::BoardLimitExceeded, 'Number of permitted boards exceeded')
115 116 117
        expect(subject.boards.size).to eq 1
      end
    end
G
gitlabhq 已提交
118 119
  end

120 121 122 123 124 125 126 127
  describe 'modules' do
    subject { described_class }

    it { is_expected.to include_module(Gitlab::ConfigHelper) }
    it { is_expected.to include_module(Gitlab::ShellAdapter) }
    it { is_expected.to include_module(Gitlab::VisibilityLevel) }
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
128 129
  end

130
  describe 'validation' do
131
    let!(:project) { create(:project) }
132

133 134
    it { is_expected.to validate_presence_of(:name) }
    it { is_expected.to validate_uniqueness_of(:name).scoped_to(:namespace_id) }
135
    it { is_expected.to validate_length_of(:name).is_at_most(255) }
136

137
    it { is_expected.to validate_presence_of(:path) }
138 139 140 141
    it { is_expected.to validate_length_of(:path).is_at_most(255) }

    it { is_expected.to validate_length_of(:description).is_at_most(2000) }

142 143 144
    it { is_expected.to validate_length_of(:ci_config_path).is_at_most(255) }
    it { is_expected.to allow_value('').for(:ci_config_path) }
    it { is_expected.not_to allow_value('test/../foo').for(:ci_config_path) }
145
    it { is_expected.not_to allow_value('/test/foo').for(:ci_config_path) }
146

147
    it { is_expected.to validate_presence_of(:creator) }
148

149
    it { is_expected.to validate_presence_of(:namespace) }
150

151
    it { is_expected.to validate_presence_of(:repository_storage) }
152

153
    it 'does not allow new projects beyond user limits' do
154
      project2 = build(:project)
155 156
      allow(project2).to receive(:creator).and_return(double(can_create_project?: false, projects_limit: 0).as_null_object)
      expect(project2).not_to be_valid
P
Phil Hughes 已提交
157
      expect(project2.errors[:limit_reached].first).to match(/Personal project creation is not allowed/)
158
    end
159 160 161

    describe 'wiki path conflict' do
      context "when the new path has been used by the wiki of other Project" do
162
        it 'has an error on the name attribute' do
163
          new_project = build_stubbed(:project, namespace_id: project.namespace_id, path: "#{project.path}.wiki")
164 165 166 167 168 169 170

          expect(new_project).not_to be_valid
          expect(new_project.errors[:name].first).to eq('has already been taken')
        end
      end

      context "when the new wiki path has been used by the path of other Project" do
171
        it 'has an error on the name attribute' do
172 173
          project_with_wiki_suffix = create(:project, path: 'foo.wiki')
          new_project = build_stubbed(:project, namespace_id: project_with_wiki_suffix.namespace_id, path: 'foo')
174 175 176 177 178 179

          expect(new_project).not_to be_valid
          expect(new_project.errors[:name].first).to eq('has already been taken')
        end
      end
    end
180

181
    context 'repository storages inclusion' do
182
      let(:project2) { build(:project, repository_storage: 'missing') }
183 184

      before do
185
        storages = { 'custom' => { 'path' => 'tmp/tests/custom_repositories' } }
186 187 188
        allow(Gitlab.config.repositories).to receive(:storages).and_return(storages)
      end

189
      it "does not allow repository storages that don't match a label in the configuration" do
190 191 192 193
        expect(project2).not_to be_valid
        expect(project2.errors[:repository_storage].first).to match(/is not included in the list/)
      end
    end
194

195
    it 'does not allow an invalid URI as import_url' do
196
      project2 = build(:project, import_url: 'invalid://')
J
James Lopez 已提交
197 198 199 200

      expect(project2).not_to be_valid
    end

201
    it 'does allow a valid URI as import_url' do
202
      project2 = build(:project, import_url: 'ssh://test@gitlab.com/project.git')
J
James Lopez 已提交
203

204 205
      expect(project2).to be_valid
    end
206

207
    it 'allows an empty URI' do
208
      project2 = build(:project, import_url: '')
209

210
      expect(project2).to be_valid
211 212 213
    end

    it 'does not produce import data on an empty URI' do
214
      project2 = build(:project, import_url: '')
215 216 217 218 219

      expect(project2.import_data).to be_nil
    end

    it 'does not produce import data on an invalid URI' do
220
      project2 = build(:project, import_url: 'test://')
221 222 223

      expect(project2.import_data).to be_nil
    end
224

D
Douwe Maan 已提交
225
    it "does not allow blocked import_url localhost" do
226
      project2 = build(:project, import_url: 'http://localhost:9000/t.git')
D
Douwe Maan 已提交
227 228

      expect(project2).to be_invalid
229
      expect(project2.errors[:import_url].first).to include('Requests to localhost are not allowed')
D
Douwe Maan 已提交
230 231 232
    end

    it "does not allow blocked import_url port" do
233
      project2 = build(:project, import_url: 'http://github.com:25/t.git')
D
Douwe Maan 已提交
234 235

      expect(project2).to be_invalid
236
      expect(project2.errors[:import_url].first).to include('Only allowed ports are 22, 80, 443')
D
Douwe Maan 已提交
237 238
    end

239 240
    describe 'project pending deletion' do
      let!(:project_pending_deletion) do
241
        create(:project,
242 243 244
               pending_delete: true)
      end
      let(:new_project) do
245
        build(:project,
246 247 248 249 250 251 252 253 254 255 256 257
              name: project_pending_deletion.name,
              namespace: project_pending_deletion.namespace)
      end

      before do
        new_project.validate
      end

      it 'contains errors related to the project being deleted' do
        expect(new_project.errors.full_messages.first).to eq('The project is still being deleted. Please try again later.')
      end
    end
258 259 260

    describe 'path validation' do
      it 'allows paths reserved on the root namespace' do
261
        project = build(:project, path: 'api')
262 263 264 265 266

        expect(project).to be_valid
      end

      it 'rejects paths reserved on another level' do
267
        project = build(:project, path: 'tree')
268 269 270

        expect(project).not_to be_valid
      end
271 272 273

      it 'rejects nested paths' do
        parent = create(:group, :nested, path: 'environments')
274
        project = build(:project, path: 'folders', namespace: parent)
275 276 277

        expect(project).not_to be_valid
      end
278 279 280

      it 'allows a reserved group name' do
        parent = create(:group)
281
        project = build(:project, path: 'avatar', namespace: parent)
282 283 284

        expect(project).to be_valid
      end
285 286 287 288 289 290

      it 'allows a path ending in a period' do
        project = build(:project, path: 'foo.')

        expect(project).to be_valid
      end
291
    end
G
gitlabhq 已提交
292
  end
293

K
Kamil Trzcinski 已提交
294
  describe 'project token' do
295
    it 'sets an random token if none provided' do
296
      project = FactoryBot.create :project, runners_token: ''
K
Kamil Trzcinski 已提交
297
      expect(project.runners_token).not_to eq('')
K
Kamil Trzcinski 已提交
298 299
    end

U
ubudzisz 已提交
300
    it 'does not set an random token if one provided' do
301
      project = FactoryBot.create :project, runners_token: 'my-token'
K
Kamil Trzcinski 已提交
302
      expect(project.runners_token).to eq('my-token')
K
Kamil Trzcinski 已提交
303 304
    end
  end
G
gitlabhq 已提交
305

306
  describe 'Respond to' do
307 308 309 310 311
    it { is_expected.to respond_to(:url_to_repo) }
    it { is_expected.to respond_to(:repo_exists?) }
    it { is_expected.to respond_to(:execute_hooks) }
    it { is_expected.to respond_to(:owner) }
    it { is_expected.to respond_to(:path_with_namespace) }
312
    it { is_expected.to respond_to(:full_path) }
G
gitlabhq 已提交
313 314
  end

315
  describe 'delegation' do
316 317 318 319 320 321
    [:add_guest, :add_reporter, :add_developer, :add_master, :add_user, :add_users].each do |method|
      it { is_expected.to delegate_method(method).to(:team) }
    end

    it { is_expected.to delegate_method(:members).to(:team).with_prefix(true) }
    it { is_expected.to delegate_method(:name).to(:owner).with_prefix(true).with_arguments(allow_nil: true) }
322 323
  end

324
  describe '#to_reference' do
325
    let(:owner)     { create(:user, name: 'Gitlab') }
326
    let(:namespace) { create(:namespace, path: 'sample-namespace', owner: owner) }
327
    let(:project)   { create(:project, path: 'sample-project', namespace: namespace) }
328
    let(:group)     { create(:group, name: 'Group', path: 'sample-group', owner: owner) }
329

330
    context 'when nil argument' do
331 332 333 334 335
      it 'returns nil' do
        expect(project.to_reference).to be_nil
      end
    end

336
    context 'when full is true' do
337
      it 'returns complete path to the project' do
338 339 340
        expect(project.to_reference(full: true)).to          eq 'sample-namespace/sample-project'
        expect(project.to_reference(project, full: true)).to eq 'sample-namespace/sample-project'
        expect(project.to_reference(group, full: true)).to   eq 'sample-namespace/sample-project'
341 342 343 344 345 346 347 348 349 350
      end
    end

    context 'when same project argument' do
      it 'returns nil' do
        expect(project.to_reference(project)).to be_nil
      end
    end

    context 'when cross namespace project argument' do
351
      let(:another_namespace_project) { create(:project, name: 'another-project') }
352 353 354 355 356 357 358

      it 'returns complete path to the project' do
        expect(project.to_reference(another_namespace_project)).to eq 'sample-namespace/sample-project'
      end
    end

    context 'when same namespace / cross-project argument' do
359
      let(:another_project) { create(:project, namespace: namespace) }
360

361
      it 'returns path to the project' do
362 363 364
        expect(project.to_reference(another_project)).to eq 'sample-project'
      end
    end
365

366 367
    context 'when different namespace / cross-project argument' do
      let(:another_namespace) { create(:namespace, path: 'another-namespace', owner: owner) }
368
      let(:another_project)   { create(:project, path: 'another-project', namespace: another_namespace) }
369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385

      it 'returns full path to the project' do
        expect(project.to_reference(another_project)).to eq 'sample-namespace/sample-project'
      end
    end

    context 'when argument is a namespace' do
      context 'with same project path' do
        it 'returns path to the project' do
          expect(project.to_reference(namespace)).to eq 'sample-project'
        end
      end

      context 'with different project path' do
        it 'returns full path to the project' do
          expect(project.to_reference(group)).to eq 'sample-namespace/sample-project'
        end
386 387
      end
    end
388 389 390 391 392
  end

  describe '#to_human_reference' do
    let(:owner) { create(:user, name: 'Gitlab') }
    let(:namespace) { create(:namespace, name: 'Sample namespace', owner: owner) }
393
    let(:project) { create(:project, name: 'Sample project', namespace: namespace) }
394 395 396 397 398 399 400 401 402 403 404 405 406 407

    context 'when nil argument' do
      it 'returns nil' do
        expect(project.to_human_reference).to be_nil
      end
    end

    context 'when same project argument' do
      it 'returns nil' do
        expect(project.to_human_reference(project)).to be_nil
      end
    end

    context 'when cross namespace project argument' do
408
      let(:another_namespace_project) { create(:project, name: 'another-project') }
409 410 411 412 413 414 415

      it 'returns complete name with namespace of the project' do
        expect(project.to_human_reference(another_namespace_project)).to eq 'Gitlab / Sample project'
      end
    end

    context 'when same namespace / cross-project argument' do
416
      let(:another_project) { create(:project, namespace: namespace) }
417 418 419 420

      it 'returns name of the project' do
        expect(project.to_human_reference(another_project)).to eq 'Sample project'
      end
421 422 423
    end
  end

V
Valery Sizov 已提交
424
  describe '#merge_method' do
425 426 427 428 429 430 431
    using RSpec::Parameterized::TableSyntax

    where(:ff, :rebase, :method) do
      true  | true  | :ff
      true  | false | :ff
      false | true  | :rebase_merge
      false | false | :merge
V
Valery Sizov 已提交
432 433
    end

434 435 436 437 438 439
    with_them do
      let(:project) { build(:project, merge_requests_rebase_enabled: rebase, merge_requests_ff_only_enabled: ff) }

      subject { project.merge_method }

      it { is_expected.to eq(method) }
V
Valery Sizov 已提交
440 441 442
    end
  end

443
  describe '#repository_storage_path' do
444
    let(:project) { create(:project) }
445 446

    it 'returns the repository storage path' do
447
      expect(Dir.exist?(project.repository_storage_path)).to be(true)
448 449 450
    end
  end

451
  it 'returns valid url to repo' do
452
    project = described_class.new(path: 'somewhere')
453
    expect(project.url_to_repo).to eq(Gitlab.config.gitlab_shell.ssh_path_prefix + 'somewhere.git')
G
gitlabhq 已提交
454 455
  end

D
Douwe Maan 已提交
456
  describe "#web_url" do
457
    let(:project) { create(:project, path: "somewhere") }
D
Douwe Maan 已提交
458 459

    it 'returns the full web URL for this repo' do
460
      expect(project.web_url).to eq("#{Gitlab.config.gitlab.url}/#{project.namespace.full_path}/somewhere")
D
Douwe Maan 已提交
461
    end
A
Ariejan de Vroom 已提交
462 463
  end

J
Jan Provaznik 已提交
464
  describe "#new_issuable_address" do
465
    let(:project) { create(:project, path: "somewhere") }
466 467
    let(:user) { create(:user) }

468 469 470 471 472 473
    context 'incoming email enabled' do
      before do
        stub_incoming_email_setting(enabled: true, address: "p+%{key}@gl.ab")
      end

      it 'returns the address to create a new issue' do
474
        address = "p+#{project.full_path}+#{user.incoming_email_token}@gl.ab"
475

J
Jan Provaznik 已提交
476 477 478 479 480 481 482
        expect(project.new_issuable_address(user, 'issue')).to eq(address)
      end

      it 'returns the address to create a new merge request' do
        address = "p+#{project.full_path}+merge-request+#{user.incoming_email_token}@gl.ab"

        expect(project.new_issuable_address(user, 'merge_request')).to eq(address)
483 484 485 486 487 488 489
      end
    end

    context 'incoming email disabled' do
      before do
        stub_incoming_email_setting(enabled: false)
      end
490

491
      it 'returns nil' do
J
Jan Provaznik 已提交
492 493 494 495 496
        expect(project.new_issuable_address(user, 'issue')).to be_nil
      end

      it 'returns nil' do
        expect(project.new_issuable_address(user, 'merge_request')).to be_nil
497
      end
498 499 500
    end
  end

501
  describe 'last_activity methods' do
S
Stan Hu 已提交
502 503
    let(:timestamp) { 2.hours.ago }
    # last_activity_at gets set to created_at upon creation
504
    let(:project) { create(:project, created_at: timestamp, updated_at: timestamp) }
G
gitlabhq 已提交
505

506
    describe 'last_activity' do
507
      it 'alias last_activity to last_event' do
508
        last_event = create(:event, :closed, project: project)
509

510
        expect(project.last_activity).to eq(last_event)
511
      end
G
gitlabhq 已提交
512 513
    end

514 515
    describe 'last_activity_date' do
      it 'returns the creation date of the project\'s last event if present' do
516
        new_event = create(:event, :closed, project: project, created_at: Time.now)
517

S
Stan Hu 已提交
518
        project.reload
519
        expect(project.last_activity_at.to_i).to eq(new_event.created_at.to_i)
520
      end
521

522
      it 'returns the project\'s last update date if it has no events' do
523
        expect(project.last_activity_date).to eq(project.updated_at)
524
      end
525 526 527 528 529 530 531 532 533 534 535 536 537 538

      it 'returns the most recent timestamp' do
        project.update_attributes(updated_at: nil,
                                  last_activity_at: timestamp,
                                  last_repository_updated_at: timestamp - 1.hour)

        expect(project.last_activity_date).to eq(timestamp)

        project.update_attributes(updated_at: timestamp,
                                  last_activity_at: timestamp - 1.hour,
                                  last_repository_updated_at: nil)

        expect(project.last_activity_date).to eq(timestamp)
      end
539 540
    end
  end
541

542
  describe '#get_issue' do
543
    let(:project) { create(:project) }
S
Stan Hu 已提交
544
    let!(:issue)  { create(:issue, project: project) }
545 546 547
    let(:user)    { create(:user) }

    before do
548
      project.add_developer(user)
549
    end
550 551 552

    context 'with default issues tracker' do
      it 'returns an issue' do
553
        expect(project.get_issue(issue.iid, user)).to eq issue
554 555
      end

S
Stan Hu 已提交
556 557 558 559
      it 'returns count of open issues' do
        expect(project.open_issues_count).to eq(1)
      end

560
      it 'returns nil when no issue found' do
561 562 563 564 565 566
        expect(project.get_issue(999, user)).to be_nil
      end

      it "returns nil when user doesn't have access" do
        user = create(:user)
        expect(project.get_issue(issue.iid, user)).to eq nil
567 568 569 570
      end
    end

    context 'with external issues tracker' do
571
      let!(:internal_issue) { create(:issue, project: project) }
572
      before do
573
        allow(project).to receive(:external_issue_tracker).and_return(true)
574 575
      end

576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612
      context 'when internal issues are enabled' do
        it 'returns interlan issue' do
          issue = project.get_issue(internal_issue.iid, user)

          expect(issue).to be_kind_of(Issue)
          expect(issue.iid).to eq(internal_issue.iid)
          expect(issue.project).to eq(project)
        end

        it 'returns an ExternalIssue when internal issue does not exists' do
          issue = project.get_issue('FOO-1234', user)

          expect(issue).to be_kind_of(ExternalIssue)
          expect(issue.iid).to eq('FOO-1234')
          expect(issue.project).to eq(project)
        end
      end

      context 'when internal issues are disabled' do
        before do
          project.issues_enabled = false
          project.save!
        end

        it 'returns always an External issues' do
          issue = project.get_issue(internal_issue.iid, user)
          expect(issue).to be_kind_of(ExternalIssue)
          expect(issue.iid).to eq(internal_issue.iid.to_s)
          expect(issue.project).to eq(project)
        end

        it 'returns an ExternalIssue when internal issue does not exists' do
          issue = project.get_issue('FOO-1234', user)
          expect(issue).to be_kind_of(ExternalIssue)
          expect(issue.iid).to eq('FOO-1234')
          expect(issue.project).to eq(project)
        end
613 614 615 616 617
      end
    end
  end

  describe '#issue_exists?' do
618
    let(:project) { create(:project) }
619 620 621 622 623 624 625 626 627 628 629 630

    it 'is truthy when issue exists' do
      expect(project).to receive(:get_issue).and_return(double)
      expect(project.issue_exists?(1)).to be_truthy
    end

    it 'is falsey when issue does not exist' do
      expect(project).to receive(:get_issue).and_return(nil)
      expect(project.issue_exists?(1)).to be_falsey
    end
  end

L
Lin Jen-Shin 已提交
631
  describe '#to_param' do
632 633 634
    context 'with namespace' do
      before do
        @group = create :group, name: 'gitlab'
635
        @project = create(:project, name: 'gitlabhq', namespace: @group)
636 637
      end

V
Vinnie Okada 已提交
638
      it { expect(@project.to_param).to eq('gitlabhq') }
639
    end
640 641 642

    context 'with invalid path' do
      it 'returns previous path to keep project suitable for use in URLs when persisted' do
643
        project = create(:project, path: 'gitlab')
644 645 646 647 648 649 650
        project.path = 'foo&bar'

        expect(project).not_to be_valid
        expect(project.to_param).to eq 'gitlab'
      end

      it 'returns current path when new record' do
651
        project = build(:project, path: 'gitlab')
652 653 654 655 656 657
        project.path = 'foo&bar'

        expect(project).not_to be_valid
        expect(project.to_param).to eq 'foo&bar'
      end
    end
658
  end
D
Dmitriy Zaporozhets 已提交
659

L
Lin Jen-Shin 已提交
660
  describe '#repository' do
661
    let(:project) { create(:project, :repository) }
D
Dmitriy Zaporozhets 已提交
662

663
    it 'returns valid repo' do
664
      expect(project.repository).to be_kind_of(Repository)
D
Dmitriy Zaporozhets 已提交
665 666
    end
  end
667

L
Lin Jen-Shin 已提交
668
  describe '#default_issues_tracker?' do
669
    it "is true if used internal tracker" do
670
      project = build(:project)
671

672
      expect(project.default_issues_tracker?).to be_truthy
673 674
    end

675
    it "is false if used other tracker" do
676 677 678 679
      # NOTE: The current nature of this factory requires persistence
      project = create(:redmine_project)

      expect(project.default_issues_tracker?).to be_falsey
680 681 682
    end
  end

683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700
  describe '#empty_repo?' do
    context 'when the repo does not exist' do
      let(:project) { build_stubbed(:project) }

      it 'returns true' do
        expect(project.empty_repo?).to be(true)
      end
    end

    context 'when the repo exists' do
      let(:project) { create(:project, :repository) }
      let(:empty_project) { create(:project, :empty_repo) }

      it { expect(empty_project.empty_repo?).to be(true) }
      it { expect(project.empty_repo?).to be(false) }
    end
  end

L
Lin Jen-Shin 已提交
701
  describe '#external_issue_tracker' do
702
    let(:project) { create(:project) }
703 704 705
    let(:ext_project) { create(:redmine_project) }

    context 'on existing projects with no value for has_external_issue_tracker' do
706
      before do
707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735
        project.update_column(:has_external_issue_tracker, nil)
        ext_project.update_column(:has_external_issue_tracker, nil)
      end

      it 'updates the has_external_issue_tracker boolean' do
        expect do
          project.external_issue_tracker
        end.to change { project.reload.has_external_issue_tracker }.to(false)

        expect do
          ext_project.external_issue_tracker
        end.to change { ext_project.reload.has_external_issue_tracker }.to(true)
      end
    end

    it 'returns nil and does not query services when there is no external issue tracker' do
      expect(project).not_to receive(:services)

      expect(project.external_issue_tracker).to eq(nil)
    end

    it 'retrieves external_issue_tracker querying services and cache it when there is external issue tracker' do
      ext_project.reload # Factory returns a project with changed attributes
      expect(ext_project).to receive(:services).once.and_call_original

      2.times { expect(ext_project.external_issue_tracker).to be_a_kind_of(RedmineService) }
    end
  end

L
Lin Jen-Shin 已提交
736
  describe '#cache_has_external_issue_tracker' do
737
    let(:project) { create(:project, has_external_issue_tracker: nil) }
738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755

    it 'stores true if there is any external_issue_tracker' do
      services = double(:service, external_issue_trackers: [RedmineService.new])
      expect(project).to receive(:services).and_return(services)

      expect do
        project.cache_has_external_issue_tracker
      end.to change { project.has_external_issue_tracker}.to(true)
    end

    it 'stores false if there is no external_issue_tracker' do
      services = double(:service, external_issue_trackers: [])
      expect(project).to receive(:services).and_return(services)

      expect do
        project.cache_has_external_issue_tracker
      end.to change { project.has_external_issue_tracker}.to(false)
    end
T
Toon Claes 已提交
756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793

    it 'does not cache data when in a read-only GitLab instance' do
      allow(Gitlab::Database).to receive(:read_only?) { true }

      expect do
        project.cache_has_external_issue_tracker
      end.not_to change { project.has_external_issue_tracker }
    end
  end

  describe '#cache_has_external_wiki' do
    let(:project) { create(:project, has_external_wiki: nil) }

    it 'stores true if there is any external_wikis' do
      services = double(:service, external_wikis: [ExternalWikiService.new])
      expect(project).to receive(:services).and_return(services)

      expect do
        project.cache_has_external_wiki
      end.to change { project.has_external_wiki}.to(true)
    end

    it 'stores false if there is no external_wikis' do
      services = double(:service, external_wikis: [])
      expect(project).to receive(:services).and_return(services)

      expect do
        project.cache_has_external_wiki
      end.to change { project.has_external_wiki}.to(false)
    end

    it 'does not cache data when in a read-only GitLab instance' do
      allow(Gitlab::Database).to receive(:read_only?) { true }

      expect do
        project.cache_has_external_wiki
      end.not_to change { project.has_external_wiki }
    end
794 795
  end

796
  describe '#has_wiki?' do
797 798 799
    let(:no_wiki_project)       { create(:project, :wiki_disabled, has_external_wiki: false) }
    let(:wiki_enabled_project)  { create(:project) }
    let(:external_wiki_project) { create(:project, has_external_wiki: true) }
800 801 802 803 804 805 806 807

    it 'returns true if project is wiki enabled or has external wiki' do
      expect(wiki_enabled_project).to have_wiki
      expect(external_wiki_project).to have_wiki
      expect(no_wiki_project).not_to have_wiki
    end
  end

808
  describe '#external_wiki' do
809
    let(:project) { create(:project) }
810

811 812 813 814 815
    context 'with an active external wiki' do
      before do
        create(:service, project: project, type: 'ExternalWikiService', active: true)
        project.external_wiki
      end
816

817 818 819
      it 'sets :has_external_wiki as true' do
        expect(project.has_external_wiki).to be(true)
      end
820

821 822
      it 'sets :has_external_wiki as false if an external wiki service is destroyed later' do
        expect(project.has_external_wiki).to be(true)
823

824 825 826 827
        project.services.external_wikis.first.destroy

        expect(project.has_external_wiki).to be(false)
      end
828 829
    end

830 831 832 833
    context 'with an inactive external wiki' do
      before do
        create(:service, project: project, type: 'ExternalWikiService', active: false)
      end
834

835 836 837
      it 'sets :has_external_wiki as false' do
        expect(project.has_external_wiki).to be(false)
      end
838 839
    end

840 841 842 843
    context 'with no external wiki' do
      before do
        project.external_wiki
      end
844

845 846 847 848 849 850 851 852 853 854 855
      it 'sets :has_external_wiki as false' do
        expect(project.has_external_wiki).to be(false)
      end

      it 'sets :has_external_wiki as true if an external wiki service is created later' do
        expect(project.has_external_wiki).to be(false)

        create(:service, project: project, type: 'ExternalWikiService', active: true)

        expect(project.has_external_wiki).to be(true)
      end
856 857 858
    end
  end

859 860
  describe '#star_count' do
    it 'counts stars from multiple users' do
C
Ciro Santilli 已提交
861 862
      user1 = create :user
      user2 = create :user
863
      project = create(:project, :public)
C
Ciro Santilli 已提交
864 865

      expect(project.star_count).to eq(0)
866

C
Ciro Santilli 已提交
867
      user1.toggle_star(project)
868 869
      expect(project.reload.star_count).to eq(1)

C
Ciro Santilli 已提交
870
      user2.toggle_star(project)
871 872 873
      project.reload
      expect(project.reload.star_count).to eq(2)

C
Ciro Santilli 已提交
874
      user1.toggle_star(project)
875 876 877
      project.reload
      expect(project.reload.star_count).to eq(1)

C
Ciro Santilli 已提交
878
      user2.toggle_star(project)
879 880 881 882
      project.reload
      expect(project.reload.star_count).to eq(0)
    end

883
    it 'counts stars on the right project' do
884
      user = create :user
885 886
      project1 = create(:project, :public)
      project2 = create(:project, :public)
887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913

      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project1)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(1)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project1)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project2)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(1)

      user.toggle_star(project2)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)
C
Ciro Santilli 已提交
914 915
    end
  end
916

L
Lin Jen-Shin 已提交
917
  describe '#avatar_type' do
918
    let(:project) { create(:project) }
919

920
    it 'is true if avatar is image' do
921
      project.update_attribute(:avatar, 'uploads/avatar.png')
922
      expect(project.avatar_type).to be_truthy
923 924
    end

925
    it 'is false if avatar is html page' do
926
      project.update_attribute(:avatar, 'uploads/avatar.html')
927
      expect(project.avatar_type).to eq(['file format is not supported. Please try one of the following supported formats: png, jpg, jpeg, gif, bmp, tiff'])
928 929
    end
  end
S
sue445 已提交
930

L
Lin Jen-Shin 已提交
931
  describe '#avatar_url' do
S
sue445 已提交
932 933
    subject { project.avatar_url }

934
    let(:project) { create(:project) }
S
sue445 已提交
935

936
    context 'when avatar file is uploaded' do
T
Tim Zallmann 已提交
937
      let(:project) { create(:project, :public, :with_avatar) }
S
sue445 已提交
938

939
      it 'shows correct url' do
940 941
        expect(project.avatar_url).to eq(project.avatar.url)
        expect(project.avatar_url(only_path: false)).to eq([Gitlab.config.gitlab.url, project.avatar.url].join)
942
      end
S
sue445 已提交
943 944
    end

945
    context 'when avatar file in git' do
S
sue445 已提交
946 947 948 949
      before do
        allow(project).to receive(:avatar_in_git) { true }
      end

950
      let(:avatar_path) { "/#{project.full_path}/avatar" }
S
sue445 已提交
951

952
      it { is_expected.to eq "http://#{Gitlab.config.gitlab.host}#{avatar_path}" }
S
sue445 已提交
953
    end
954 955

    context 'when git repo is empty' do
956
      let(:project) { create(:project) }
957

958
      it { is_expected.to eq nil }
959
    end
S
sue445 已提交
960
  end
961

962
  describe '#pipeline_for' do
963
    let(:project) { create(:project, :repository) }
964
    let!(:pipeline) { create_pipeline }
K
Kamil Trzcinski 已提交
965

966 967
    shared_examples 'giving the correct pipeline' do
      it { is_expected.to eq(pipeline) }
K
Kamil Trzcinski 已提交
968

969 970
      context 'return latest' do
        let!(:pipeline2) { create_pipeline }
K
Kamil Trzcinski 已提交
971

972
        it { is_expected.to eq(pipeline2) }
K
Kamil Trzcinski 已提交
973
      end
974 975 976 977 978 979 980 981 982 983 984 985 986
    end

    context 'with explicit sha' do
      subject { project.pipeline_for('master', pipeline.sha) }

      it_behaves_like 'giving the correct pipeline'
    end

    context 'with implicit sha' do
      subject { project.pipeline_for('master') }

      it_behaves_like 'giving the correct pipeline'
    end
K
Kamil Trzcinski 已提交
987

988 989 990 991 992
    def create_pipeline
      create(:ci_pipeline,
             project: project,
             ref: 'master',
             sha: project.commit('master').sha)
K
Kamil Trzcinski 已提交
993
    end
994
  end
995

L
Lin Jen-Shin 已提交
996
  describe '#builds_enabled' do
997
    let(:project) { create(:project) }
998

999 1000 1001
    subject { project.builds_enabled }

    it { expect(project.builds_enabled?).to be_truthy }
1002
  end
Y
Yorick Peterse 已提交
1003

1004
  describe '.with_shared_runners' do
1005
    subject { described_class.with_shared_runners }
1006 1007

    context 'when shared runners are enabled for project' do
1008
      let!(:project) { create(:project, shared_runners_enabled: true) }
1009 1010 1011 1012 1013 1014 1015

      it "returns a project" do
        is_expected.to eq([project])
      end
    end

    context 'when shared runners are disabled for project' do
1016
      let!(:project) { create(:project, shared_runners_enabled: false) }
1017 1018 1019 1020 1021 1022 1023

      it "returns an empty array" do
        is_expected.to be_empty
      end
    end
  end

1024
  describe '.cached_count', :use_clean_rails_memory_store_caching do
1025
    let(:group)     { create(:group, :public) }
1026 1027
    let!(:project1) { create(:project, :public, group: group) }
    let!(:project2) { create(:project, :public, group: group) }
1028 1029

    it 'returns total project count' do
1030
      expect(described_class).to receive(:count).once.and_call_original
1031 1032

      3.times do
1033
        expect(described_class.cached_count).to eq(2)
1034 1035 1036 1037
      end
    end
  end

Y
Yorick Peterse 已提交
1038
  describe '.trending' do
F
Felipe Artur 已提交
1039
    let(:group)    { create(:group, :public) }
1040 1041
    let(:project1) { create(:project, :public, group: group) }
    let(:project2) { create(:project, :public, group: group) }
Y
Yorick Peterse 已提交
1042 1043 1044 1045 1046 1047 1048 1049

    before do
      2.times do
        create(:note_on_commit, project: project1)
      end

      create(:note_on_commit, project: project2)

Y
Yorick Peterse 已提交
1050
      TrendingProject.refresh!
Y
Yorick Peterse 已提交
1051 1052
    end

Y
Yorick Peterse 已提交
1053
    subject { described_class.trending.to_a }
Y
Yorick Peterse 已提交
1054

Y
Yorick Peterse 已提交
1055 1056
    it 'sorts projects by the amount of notes in descending order' do
      expect(subject).to eq([project1, project2])
Y
Yorick Peterse 已提交
1057
    end
1058 1059 1060 1061 1062 1063 1064 1065

    it 'does not take system notes into account' do
      10.times do
        create(:note_on_commit, project: project2, system: true)
      end

      expect(described_class.trending.to_a).to eq([project1, project2])
    end
Y
Yorick Peterse 已提交
1066
  end
Y
Yorick Peterse 已提交
1067

T
Toon Claes 已提交
1068 1069 1070 1071
  describe '.starred_by' do
    it 'returns only projects starred by the given user' do
      user1 = create(:user)
      user2 = create(:user)
1072 1073 1074
      project1 = create(:project)
      project2 = create(:project)
      create(:project)
T
Toon Claes 已提交
1075 1076 1077
      user1.toggle_star(project1)
      user2.toggle_star(project2)

1078
      expect(described_class.starred_by(user1)).to contain_exactly(project1)
T
Toon Claes 已提交
1079 1080 1081
    end
  end

Y
Yorick Peterse 已提交
1082
  describe '.visible_to_user' do
1083
    let!(:project) { create(:project, :private) }
Y
Yorick Peterse 已提交
1084 1085 1086 1087 1088 1089
    let!(:user)    { create(:user) }

    subject { described_class.visible_to_user(user) }

    describe 'when a user has access to a project' do
      before do
1090
        project.add_user(user, Gitlab::Access::MASTER)
Y
Yorick Peterse 已提交
1091 1092 1093 1094 1095 1096 1097 1098 1099
      end

      it { is_expected.to eq([project]) }
    end

    describe 'when a user does not have access to any projects' do
      it { is_expected.to eq([]) }
    end
  end
K
Kamil Trzcinski 已提交
1100

1101
  context 'repository storage by default' do
1102
    let(:project) { create(:project) }
1103 1104

    before do
1105
      storages = {
1106 1107
        'default' => Gitlab::GitalyClient::StorageSettings.new('path' => 'tmp/tests/repositories'),
        'picked'  => Gitlab::GitalyClient::StorageSettings.new('path' => 'tmp/tests/repositories')
1108
      }
1109 1110 1111
      allow(Gitlab.config.repositories).to receive(:storages).and_return(storages)
    end

1112 1113 1114 1115 1116
    it 'picks storage from ApplicationSetting' do
      expect_any_instance_of(ApplicationSetting).to receive(:pick_repository_storage).and_return('picked')

      expect(project.repository_storage).to eq('picked')
    end
1117 1118
  end

K
Kamil Trzcinski 已提交
1119
  context 'shared runners by default' do
1120
    let(:project) { create(:project) }
K
Kamil Trzcinski 已提交
1121 1122 1123 1124

    subject { project.shared_runners_enabled }

    context 'are enabled' do
1125 1126 1127
      before do
        stub_application_setting(shared_runners_enabled: true)
      end
K
Kamil Trzcinski 已提交
1128 1129 1130 1131 1132

      it { is_expected.to be_truthy }
    end

    context 'are disabled' do
1133 1134 1135
      before do
        stub_application_setting(shared_runners_enabled: false)
      end
K
Kamil Trzcinski 已提交
1136 1137 1138 1139 1140

      it { is_expected.to be_falsey }
    end
  end

L
Lin Jen-Shin 已提交
1141
  describe '#any_runners' do
1142
    let(:project) { create(:project, shared_runners_enabled: shared_runners_enabled) }
1143 1144
    let(:specific_runner) { create(:ci_runner) }
    let(:shared_runner) { create(:ci_runner, :shared) }
K
Kamil Trzcinski 已提交
1145 1146 1147

    context 'for shared runners disabled' do
      let(:shared_runners_enabled) { false }
1148

1149
      it 'has no runners available' do
K
Kamil Trzcinski 已提交
1150 1151
        expect(project.any_runners?).to be_falsey
      end
1152

1153
      it 'has a specific runner' do
1154
        project.runners << specific_runner
K
Kamil Trzcinski 已提交
1155 1156
        expect(project.any_runners?).to be_truthy
      end
1157

1158
      it 'has a shared runner, but they are prohibited to use' do
K
Kamil Trzcinski 已提交
1159 1160 1161
        shared_runner
        expect(project.any_runners?).to be_falsey
      end
1162

K
Kamil Trzcinski 已提交
1163
      it 'checks the presence of specific runner' do
1164
        project.runners << specific_runner
K
Kamil Trzcinski 已提交
1165 1166 1167
        expect(project.any_runners? { |runner| runner == specific_runner }).to be_truthy
      end
    end
1168

K
Kamil Trzcinski 已提交
1169 1170
    context 'for shared runners enabled' do
      let(:shared_runners_enabled) { true }
1171

1172
      it 'has a shared runner' do
K
Kamil Trzcinski 已提交
1173 1174 1175 1176 1177 1178 1179 1180 1181 1182
        shared_runner
        expect(project.any_runners?).to be_truthy
      end

      it 'checks the presence of shared runner' do
        shared_runner
        expect(project.any_runners? { |runner| runner == shared_runner }).to be_truthy
      end
    end
  end
1183

1184 1185 1186 1187 1188 1189
  describe '#shared_runners' do
    let!(:runner) { create(:ci_runner, :shared) }

    subject { project.shared_runners }

    context 'when shared runners are enabled for project' do
1190
      let!(:project) { create(:project, shared_runners_enabled: true) }
1191 1192 1193 1194 1195 1196 1197

      it "returns a list of shared runners" do
        is_expected.to eq([runner])
      end
    end

    context 'when shared runners are disabled for project' do
1198
      let!(:project) { create(:project, shared_runners_enabled: false) }
1199 1200 1201 1202 1203 1204 1205

      it "returns a empty list" do
        is_expected.to be_empty
      end
    end
  end

1206
  describe '#visibility_level_allowed?' do
1207
    let(:project) { create(:project, :internal) }
1208 1209 1210 1211 1212 1213 1214 1215

    context 'when checking on non-forked project' do
      it { expect(project.visibility_level_allowed?(Gitlab::VisibilityLevel::PRIVATE)).to be_truthy }
      it { expect(project.visibility_level_allowed?(Gitlab::VisibilityLevel::INTERNAL)).to be_truthy }
      it { expect(project.visibility_level_allowed?(Gitlab::VisibilityLevel::PUBLIC)).to be_truthy }
    end

    context 'when checking on forked project' do
1216 1217
      let(:project)        { create(:project, :internal) }
      let(:forked_project) { create(:project, forked_from_project: project) }
1218 1219 1220 1221 1222

      it { expect(forked_project.visibility_level_allowed?(Gitlab::VisibilityLevel::PRIVATE)).to be_truthy }
      it { expect(forked_project.visibility_level_allowed?(Gitlab::VisibilityLevel::INTERNAL)).to be_truthy }
      it { expect(forked_project.visibility_level_allowed?(Gitlab::VisibilityLevel::PUBLIC)).to be_falsey }
    end
1223
  end
1224

1225
  describe '#pages_deployed?' do
1226
    let(:project) { create :project }
1227 1228 1229 1230

    subject { project.pages_deployed? }

    context 'if public folder does exist' do
1231 1232 1233
      before do
        allow(Dir).to receive(:exist?).with(project.public_pages_path).and_return(true)
      end
1234 1235 1236 1237 1238 1239 1240 1241 1242

      it { is_expected.to be_truthy }
    end

    context "if public folder doesn't exist" do
      it { is_expected.to be_falsey }
    end
  end

1243 1244
  describe '#pages_url' do
    let(:group) { create :group, name: group_name }
1245
    let(:project) { create :project, namespace: group, name: project_name }
1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266
    let(:domain) { 'Example.com' }

    subject { project.pages_url }

    before do
      allow(Settings.pages).to receive(:host).and_return(domain)
      allow(Gitlab.config.pages).to receive(:url).and_return('http://example.com')
    end

    context 'group page' do
      let(:group_name) { 'Group' }
      let(:project_name) { 'group.example.com' }

      it { is_expected.to eq("http://group.example.com") }
    end

    context 'project page' do
      let(:group_name) { 'Group' }
      let(:project_name) { 'Project' }

      it { is_expected.to eq("http://group.example.com/project") }
1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294
    end
  end

  describe '#pages_group_url' do
    let(:group) { create :group, name: group_name }
    let(:project) { create :project, namespace: group, name: project_name }
    let(:domain) { 'Example.com' }
    let(:port) { 1234 }

    subject { project.pages_group_url }

    before do
      allow(Settings.pages).to receive(:host).and_return(domain)
      allow(Gitlab.config.pages).to receive(:url).and_return("http://example.com:#{port}")
    end

    context 'group page' do
      let(:group_name) { 'Group' }
      let(:project_name) { 'group.example.com' }

      it { is_expected.to eq("http://group.example.com:#{port}") }
    end

    context 'project page' do
      let(:group_name) { 'Group' }
      let(:project_name) { 'Project' }

      it { is_expected.to eq("http://group.example.com:#{port}") }
1295 1296 1297
    end
  end

1298
  describe '.search' do
1299
    let(:project) { create(:project, description: 'kitten mittens') }
1300

1301 1302 1303
    it 'returns projects with a matching name' do
      expect(described_class.search(project.name)).to eq([project])
    end
1304

1305 1306 1307
    it 'returns projects with a partially matching name' do
      expect(described_class.search(project.name[0..2])).to eq([project])
    end
1308

1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336
    it 'returns projects with a matching name regardless of the casing' do
      expect(described_class.search(project.name.upcase)).to eq([project])
    end

    it 'returns projects with a matching description' do
      expect(described_class.search(project.description)).to eq([project])
    end

    it 'returns projects with a partially matching description' do
      expect(described_class.search('kitten')).to eq([project])
    end

    it 'returns projects with a matching description regardless of the casing' do
      expect(described_class.search('KITTEN')).to eq([project])
    end

    it 'returns projects with a matching path' do
      expect(described_class.search(project.path)).to eq([project])
    end

    it 'returns projects with a partially matching path' do
      expect(described_class.search(project.path[0..2])).to eq([project])
    end

    it 'returns projects with a matching path regardless of the casing' do
      expect(described_class.search(project.path.upcase)).to eq([project])
    end

1337
    describe 'with pending_delete project' do
1338
      let(:pending_delete_project) { create(:project, pending_delete: true) }
1339 1340 1341 1342 1343 1344 1345

      it 'shows pending deletion project' do
        search_result = described_class.search(pending_delete_project.name)

        expect(search_result).to eq([pending_delete_project])
      end
    end
1346
  end
1347 1348

  describe '#expire_caches_before_rename' do
1349
    let(:project) { create(:project, :repository) }
1350 1351 1352 1353
    let(:repo)    { double(:repo, exists?: true) }
    let(:wiki)    { double(:wiki, exists?: true) }

    it 'expires the caches of the repository and wiki' do
1354 1355 1356
      allow(Repository).to receive(:new)
        .with('foo', project)
        .and_return(repo)
1357

1358 1359 1360
      allow(Repository).to receive(:new)
        .with('foo.wiki', project)
        .and_return(wiki)
1361

1362 1363
      expect(repo).to receive(:before_delete)
      expect(wiki).to receive(:before_delete)
1364 1365 1366 1367

      project.expire_caches_before_rename('foo')
    end
  end
1368 1369

  describe '.search_by_title' do
1370
    let(:project) { create(:project, name: 'kittens') }
1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383

    it 'returns projects with a matching name' do
      expect(described_class.search_by_title(project.name)).to eq([project])
    end

    it 'returns projects with a partially matching name' do
      expect(described_class.search_by_title('kitten')).to eq([project])
    end

    it 'returns projects with a matching name regardless of the casing' do
      expect(described_class.search_by_title('KITTENS')).to eq([project])
    end
  end
1384 1385 1386 1387 1388

  context 'when checking projects from groups' do
    let(:private_group)    { create(:group, visibility_level: 0)  }
    let(:internal_group)   { create(:group, visibility_level: 10) }

1389 1390
    let(:private_project)  { create :project, :private, group: private_group }
    let(:internal_project) { create :project, :internal, group: internal_group }
1391 1392 1393 1394 1395 1396 1397 1398 1399

    context 'when group is private project can not be internal' do
      it { expect(private_project.visibility_level_allowed?(Gitlab::VisibilityLevel::INTERNAL)).to be_falsey }
    end

    context 'when group is internal project can not be public' do
      it { expect(internal_project.visibility_level_allowed?(Gitlab::VisibilityLevel::PUBLIC)).to be_falsey }
    end
  end
1400

1401
  describe '#create_repository' do
1402
    let(:project) { create(:project, :repository) }
1403 1404 1405 1406 1407 1408 1409 1410
    let(:shell) { Gitlab::Shell.new }

    before do
      allow(project).to receive(:gitlab_shell).and_return(shell)
    end

    context 'using a regular repository' do
      it 'creates the repository' do
1411
        expect(shell).to receive(:create_repository)
J
Jacob Vosmaer 已提交
1412
          .with(project.repository_storage, project.disk_path)
1413
          .and_return(true)
1414 1415 1416 1417 1418 1419 1420

        expect(project.repository).to receive(:after_create)

        expect(project.create_repository).to eq(true)
      end

      it 'adds an error if the repository could not be created' do
1421
        expect(shell).to receive(:create_repository)
J
Jacob Vosmaer 已提交
1422
          .with(project.repository_storage, project.disk_path)
1423
          .and_return(false)
1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434

        expect(project.repository).not_to receive(:after_create)

        expect(project.create_repository).to eq(false)
        expect(project.errors).not_to be_empty
      end
    end

    context 'using a forked repository' do
      it 'does nothing' do
        expect(project).to receive(:forked?).and_return(true)
1435
        expect(shell).not_to receive(:create_repository)
1436 1437 1438 1439 1440

        project.create_repository
      end
    end
  end
1441

1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453
  describe '#ensure_repository' do
    let(:project) { create(:project, :repository) }
    let(:shell) { Gitlab::Shell.new }

    before do
      allow(project).to receive(:gitlab_shell).and_return(shell)
    end

    it 'creates the repository if it not exist' do
      allow(project).to receive(:repository_exists?)
        .and_return(false)

1454
      allow(shell).to receive(:create_repository)
1455
        .with(project.repository_storage_path, project.disk_path)
1456 1457
        .and_return(true)

1458
      expect(project).to receive(:create_repository).with(force: true)
1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470

      project.ensure_repository
    end

    it 'does not create the repository if it exists' do
      allow(project).to receive(:repository_exists?)
        .and_return(true)

      expect(project).not_to receive(:create_repository)

      project.ensure_repository
    end
1471 1472 1473 1474 1475 1476 1477

    it 'creates the repository if it is a fork' do
      expect(project).to receive(:forked?).and_return(true)

      allow(project).to receive(:repository_exists?)
        .and_return(false)

1478
      expect(shell).to receive(:create_repository)
J
Jacob Vosmaer 已提交
1479
        .with(project.repository_storage, project.disk_path)
1480 1481 1482 1483
        .and_return(true)

      project.ensure_repository
    end
1484 1485
  end

1486
  describe '#user_can_push_to_empty_repo?' do
1487
    let(:project) { create(:project) }
1488
    let(:user)    { create(:user) }
1489

1490
    it 'returns false when default_branch_protection is in full protection and user is developer' do
1491
      project.add_developer(user)
1492
      stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_FULL)
1493

1494
      expect(project.user_can_push_to_empty_repo?(user)).to be_falsey
1495 1496
    end

1497
    it 'returns false when default_branch_protection only lets devs merge and user is dev' do
1498
      project.add_developer(user)
1499
      stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_DEV_CAN_MERGE)
1500

1501
      expect(project.user_can_push_to_empty_repo?(user)).to be_falsey
1502 1503
    end

1504
    it 'returns true when default_branch_protection lets devs push and user is developer' do
1505
      project.add_developer(user)
1506
      stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_DEV_CAN_PUSH)
1507

1508 1509
      expect(project.user_can_push_to_empty_repo?(user)).to be_truthy
    end
1510

1511
    it 'returns true when default_branch_protection is unprotected and user is developer' do
1512
      project.add_developer(user)
1513
      stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_NONE)
1514

1515
      expect(project.user_can_push_to_empty_repo?(user)).to be_truthy
1516
    end
1517

1518
    it 'returns true when user is master' do
1519
      project.add_master(user)
1520

1521
      expect(project.user_can_push_to_empty_repo?(user)).to be_truthy
1522
    end
1523 1524 1525 1526 1527 1528 1529

    it 'returns false when the repo is not empty' do
      project.add_master(user)
      expect(project).to receive(:empty_repo?).and_return(false)

      expect(project.user_can_push_to_empty_repo?(user)).to be_falsey
    end
1530 1531
  end

A
Andre Guedes 已提交
1532
  describe '#container_registry_url' do
1533
    let(:project) { create(:project) }
K
Kamil Trzcinski 已提交
1534

A
Andre Guedes 已提交
1535
    subject { project.container_registry_url }
K
Kamil Trzcinski 已提交
1536

1537 1538 1539
    before do
      stub_container_registry_config(**registry_settings)
    end
K
Kamil Trzcinski 已提交
1540 1541 1542

    context 'for enabled registry' do
      let(:registry_settings) do
1543 1544
        { enabled: true,
          host_port: 'example.com' }
K
Kamil Trzcinski 已提交
1545 1546
      end

1547
      it { is_expected.not_to be_nil }
K
Kamil Trzcinski 已提交
1548 1549 1550 1551
    end

    context 'for disabled registry' do
      let(:registry_settings) do
1552
        { enabled: false }
K
Kamil Trzcinski 已提交
1553 1554 1555 1556 1557 1558
      end

      it { is_expected.to be_nil }
    end
  end

1559
  describe '#has_container_registry_tags?' do
1560
    let(:project) { create(:project) }
1561 1562

    context 'when container registry is enabled' do
1563 1564 1565
      before do
        stub_container_registry_config(enabled: true)
      end
1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602

      context 'when tags are present for multi-level registries' do
        before do
          create(:container_repository, project: project, name: 'image')

          stub_container_registry_tags(repository: /image/,
                                       tags: %w[latest rc1])
        end

        it 'should have image tags' do
          expect(project).to have_container_registry_tags
        end
      end

      context 'when tags are present for root repository' do
        before do
          stub_container_registry_tags(repository: project.full_path,
                                       tags: %w[latest rc1 pre1])
        end

        it 'should have image tags' do
          expect(project).to have_container_registry_tags
        end
      end

      context 'when there are no tags at all' do
        before do
          stub_container_registry_tags(repository: :any, tags: [])
        end

        it 'should not have image tags' do
          expect(project).not_to have_container_registry_tags
        end
      end
    end

    context 'when container registry is disabled' do
1603 1604 1605
      before do
        stub_container_registry_config(enabled: false)
      end
1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622

      it 'should not have image tags' do
        expect(project).not_to have_container_registry_tags
      end

      it 'should not check root repository tags' do
        expect(project).not_to receive(:full_path)
        expect(project).not_to have_container_registry_tags
      end

      it 'should iterate through container repositories' do
        expect(project).to receive(:container_repositories)
        expect(project).not_to have_container_registry_tags
      end
    end
  end

1623
  describe '#ci_config_path=' do
1624
    let(:project) { create(:project) }
1625 1626

    it 'sets nil' do
1627
      project.update!(ci_config_path: nil)
1628

1629
      expect(project.ci_config_path).to be_nil
1630 1631 1632
    end

    it 'sets a string' do
1633
      project.update!(ci_config_path: 'foo/.gitlab_ci.yml')
1634

1635
      expect(project.ci_config_path).to eq('foo/.gitlab_ci.yml')
1636 1637
    end

1638 1639
    it 'sets a string but removes all null characters' do
      project.update!(ci_config_path: "f\0oo/\0/.gitlab_ci.yml")
1640

1641
      expect(project.ci_config_path).to eq('foo//.gitlab_ci.yml')
1642 1643 1644
    end
  end

1645
  describe 'Project import job' do
1646
    let(:project) { create(:project, import_url: generate(:url)) }
1647 1648

    before do
S
Stan Hu 已提交
1649
      allow_any_instance_of(Gitlab::Shell).to receive(:import_repository)
1650
        .with(project.repository_storage, project.disk_path, project.import_url)
S
Stan Hu 已提交
1651 1652 1653 1654
        .and_return(true)

      expect_any_instance_of(Repository).to receive(:after_import)
        .and_call_original
1655 1656 1657 1658 1659
    end

    it 'imports a project' do
      expect_any_instance_of(RepositoryImportWorker).to receive(:perform).and_call_original

1660
      expect { project.import_schedule }.to change { project.import_jid }
1661 1662 1663 1664
      expect(project.reload.import_status).to eq('finished')
    end
  end

1665 1666
  describe 'project import state transitions' do
    context 'state transition: [:started] => [:finished]' do
L
Lin Jen-Shin 已提交
1667
      let(:after_import_service) { spy(:after_import_service) }
L
Lin Jen-Shin 已提交
1668
      let(:housekeeping_service) { spy(:housekeeping_service) }
1669 1670

      before do
L
Lin Jen-Shin 已提交
1671 1672
        allow(Projects::AfterImportService)
          .to receive(:new) { after_import_service }
L
Lin Jen-Shin 已提交
1673

L
Lin Jen-Shin 已提交
1674
        allow(after_import_service)
L
Lin Jen-Shin 已提交
1675 1676 1677 1678
          .to receive(:execute) { housekeeping_service.execute }

        allow(Projects::HousekeepingService)
          .to receive(:new) { housekeeping_service }
1679 1680
      end

1681 1682 1683 1684 1685 1686 1687
      it 'resets project import_error' do
        error_message = 'Some error'
        mirror = create(:project_empty_repo, :import_started, import_error: error_message)

        expect { mirror.import_finish }.to change { mirror.import_error }.from(error_message).to(nil)
      end

1688 1689 1690 1691 1692
      it 'performs housekeeping when an import of a fresh project is completed' do
        project = create(:project_empty_repo, :import_started, import_type: :github)

        project.import_finish

L
Lin Jen-Shin 已提交
1693
        expect(after_import_service).to have_received(:execute)
1694 1695 1696 1697
        expect(housekeeping_service).to have_received(:execute)
      end

      it 'does not perform housekeeping when project repository does not exist' do
1698
        project = create(:project, :import_started, import_type: :github)
1699 1700 1701 1702 1703 1704 1705

        project.import_finish

        expect(housekeeping_service).not_to have_received(:execute)
      end

      it 'does not perform housekeeping when project does not have a valid import type' do
1706
        project = create(:project, :import_started, import_type: nil)
1707 1708 1709 1710 1711 1712 1713 1714

        project.import_finish

        expect(housekeeping_service).not_to have_received(:execute)
      end
    end
  end

1715
  describe '#latest_successful_builds_for' do
L
Lin Jen-Shin 已提交
1716
    def create_pipeline(status = 'success')
1717
      create(:ci_pipeline, project: project,
L
Lin Jen-Shin 已提交
1718
                           sha: project.commit.sha,
1719
                           ref: project.default_branch,
L
Lin Jen-Shin 已提交
1720
                           status: status)
1721 1722
    end

L
Lin Jen-Shin 已提交
1723 1724 1725
    def create_build(new_pipeline = pipeline, name = 'test')
      create(:ci_build, :success, :artifacts,
             pipeline: new_pipeline,
L
Lin Jen-Shin 已提交
1726
             status: new_pipeline.status,
L
Lin Jen-Shin 已提交
1727
             name: name)
1728 1729
    end

1730
    let(:project) { create(:project, :repository) }
L
Lin Jen-Shin 已提交
1731
    let(:pipeline) { create_pipeline }
L
Lin Jen-Shin 已提交
1732 1733

    context 'with many builds' do
1734
      it 'gives the latest builds from latest pipeline' do
1735 1736
        pipeline1 = create_pipeline
        pipeline2 = create_pipeline
1737
        build1_p2 = create_build(pipeline2, 'test')
1738 1739
        create_build(pipeline1, 'test')
        create_build(pipeline1, 'test2')
1740
        build2_p2 = create_build(pipeline2, 'test2')
L
Lin Jen-Shin 已提交
1741 1742 1743

        latest_builds = project.latest_successful_builds_for

1744
        expect(latest_builds).to contain_exactly(build2_p2, build1_p2)
L
Lin Jen-Shin 已提交
1745 1746
      end
    end
L
Lin Jen-Shin 已提交
1747

L
Lin Jen-Shin 已提交
1748
    context 'with succeeded pipeline' do
L
Lin Jen-Shin 已提交
1749
      let!(:build) { create_build }
1750

L
Lin Jen-Shin 已提交
1751
      context 'standalone pipeline' do
1752 1753 1754 1755 1756 1757 1758 1759
        it 'returns builds for ref for default_branch' do
          builds = project.latest_successful_builds_for

          expect(builds).to contain_exactly(build)
        end

        it 'returns empty relation if the build cannot be found' do
          builds = project.latest_successful_builds_for('TAIL')
1760

1761 1762 1763
          expect(builds).to be_kind_of(ActiveRecord::Relation)
          expect(builds).to be_empty
        end
1764 1765
      end

L
Lin Jen-Shin 已提交
1766
      context 'with some pending pipeline' do
1767
        before do
L
Lin Jen-Shin 已提交
1768
          create_build(create_pipeline('pending'))
1769 1770
        end

L
Lin Jen-Shin 已提交
1771 1772
        it 'gives the latest build from latest pipeline' do
          latest_build = project.latest_successful_builds_for
1773

L
Lin Jen-Shin 已提交
1774
          expect(latest_build).to contain_exactly(build)
1775
        end
1776 1777 1778 1779 1780 1781
      end
    end

    context 'with pending pipeline' do
      before do
        pipeline.update(status: 'pending')
L
Lin Jen-Shin 已提交
1782
        create_build(pipeline)
1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793
      end

      it 'returns empty relation' do
        builds = project.latest_successful_builds_for

        expect(builds).to be_kind_of(ActiveRecord::Relation)
        expect(builds).to be_empty
      end
    end
  end

1794
  describe '#add_import_job' do
1795 1796
    let(:import_jid) { '123' }

1797
    context 'forked' do
1798
      let(:forked_project_link) { create(:forked_project_link, :forked_to_empty_project) }
1799 1800 1801 1802
      let(:forked_from_project) { forked_project_link.forked_from_project }
      let(:project) { forked_project_link.forked_to_project }

      it 'schedules a RepositoryForkWorker job' do
1803
        expect(RepositoryForkWorker).to receive(:perform_async).with(project.id).and_return(import_jid)
1804

1805
        expect(project.add_import_job).to eq(import_jid)
1806 1807 1808 1809 1810
      end
    end

    context 'not forked' do
      it 'schedules a RepositoryImportWorker job' do
1811
        project = create(:project, import_url: generate(:url))
1812

1813 1814
        expect(RepositoryImportWorker).to receive(:perform_async).with(project.id).and_return(import_jid)
        expect(project.add_import_job).to eq(import_jid)
1815 1816 1817 1818
      end
    end
  end

R
Rémy Coutable 已提交
1819
  describe '#gitlab_project_import?' do
1820
    subject(:project) { build(:project, import_type: 'gitlab_project') }
R
Rémy Coutable 已提交
1821 1822 1823 1824 1825

    it { expect(project.gitlab_project_import?).to be true }
  end

  describe '#gitea_import?' do
1826
    subject(:project) { build(:project, import_type: 'gitea') }
R
Rémy Coutable 已提交
1827 1828 1829 1830

    it { expect(project.gitea_import?).to be true }
  end

1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845
  describe '#ancestors_upto', :nested_groups do
    let(:parent) { create(:group) }
    let(:child) { create(:group, parent: parent) }
    let(:child2) { create(:group, parent: child) }
    let(:project) { create(:project, namespace: child2) }

    it 'returns all ancestors when no namespace is given' do
      expect(project.ancestors_upto).to contain_exactly(child2, child, parent)
    end

    it 'includes ancestors upto but excluding the given ancestor' do
      expect(project.ancestors_upto(parent)).to contain_exactly(child2, child)
    end
  end

1846
  describe '#lfs_enabled?' do
1847
    let(:project) { create(:project) }
1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907

    shared_examples 'project overrides group' do
      it 'returns true when enabled in project' do
        project.update_attribute(:lfs_enabled, true)

        expect(project.lfs_enabled?).to be_truthy
      end

      it 'returns false when disabled in project' do
        project.update_attribute(:lfs_enabled, false)

        expect(project.lfs_enabled?).to be_falsey
      end

      it 'returns the value from the namespace, when no value is set in project' do
        expect(project.lfs_enabled?).to eq(project.namespace.lfs_enabled?)
      end
    end

    context 'LFS disabled in group' do
      before do
        project.namespace.update_attribute(:lfs_enabled, false)
        enable_lfs
      end

      it_behaves_like 'project overrides group'
    end

    context 'LFS enabled in group' do
      before do
        project.namespace.update_attribute(:lfs_enabled, true)
        enable_lfs
      end

      it_behaves_like 'project overrides group'
    end

    describe 'LFS disabled globally' do
      shared_examples 'it always returns false' do
        it do
          expect(project.lfs_enabled?).to be_falsey
          expect(project.namespace.lfs_enabled?).to be_falsey
        end
      end

      context 'when no values are set' do
        it_behaves_like 'it always returns false'
      end

      context 'when all values are set to true' do
        before do
          project.namespace.update_attribute(:lfs_enabled, true)
          project.update_attribute(:lfs_enabled, true)
        end

        it_behaves_like 'it always returns false'
      end
    end
  end

1908
  describe '#change_head' do
1909
    let(:project) { create(:project, :repository) }
1910

1911 1912 1913 1914 1915
    it 'returns error if branch does not exist' do
      expect(project.change_head('unexisted-branch')).to be false
      expect(project.errors.size).to eq(1)
    end

1916
    it 'calls the before_change_head and after_change_head methods' do
1917
      expect(project.repository).to receive(:before_change_head)
1918 1919
      expect(project.repository).to receive(:after_change_head)

1920 1921 1922
      project.change_head(project.default_branch)
    end

1923
    it 'creates the new reference with rugged' do
1924 1925
      expect(project.repository.raw_repository).to receive(:write_ref).with('HEAD', "refs/heads/#{project.default_branch}", shell: false)

1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938
      project.change_head(project.default_branch)
    end

    it 'copies the gitattributes' do
      expect(project.repository).to receive(:copy_gitattributes).with(project.default_branch)
      project.change_head(project.default_branch)
    end

    it 'reloads the default branch' do
      expect(project).to receive(:reload_default_branch)
      project.change_head(project.default_branch)
    end
  end
Y
Yorick Peterse 已提交
1939

1940
  context 'forks' do
B
Bob Van Landuyt 已提交
1941 1942
    include ProjectForksHelper

1943 1944 1945 1946 1947
    let(:project) { create(:project, :public) }
    let!(:forked_project) { fork_project(project) }

    describe '#fork_network' do
      it 'includes a fork of the project' do
B
Bob Van Landuyt 已提交
1948
        expect(project.fork_network.projects).to include(forked_project)
1949 1950 1951 1952 1953
      end

      it 'includes a fork of a fork' do
        other_fork = fork_project(forked_project)

B
Bob Van Landuyt 已提交
1954
        expect(project.fork_network.projects).to include(other_fork)
1955 1956 1957 1958 1959
      end

      it 'includes sibling forks' do
        other_fork = fork_project(project)

B
Bob Van Landuyt 已提交
1960
        expect(forked_project.fork_network.projects).to include(other_fork)
1961 1962 1963
      end

      it 'includes the base project' do
B
Bob Van Landuyt 已提交
1964
        expect(forked_project.fork_network.projects).to include(project.reload)
1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990
      end
    end

    describe '#in_fork_network_of?' do
      it 'is true for a real fork' do
        expect(forked_project.in_fork_network_of?(project)).to be_truthy
      end

      it 'is true for a fork of a fork', :postgresql do
        other_fork = fork_project(forked_project)

        expect(other_fork.in_fork_network_of?(project)).to be_truthy
      end

      it 'is true for sibling forks' do
        sibling = fork_project(project)

        expect(sibling.in_fork_network_of?(forked_project)).to be_truthy
      end

      it 'is false when another project is given' do
        other_project = build_stubbed(:project)

        expect(forked_project.in_fork_network_of?(other_project)).to be_falsy
      end
    end
1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003

    describe '#fork_source' do
      let!(:second_fork) { fork_project(forked_project) }

      it 'returns the direct source if it exists' do
        expect(second_fork.fork_source).to eq(forked_project)
      end

      it 'returns the root of the fork network when the directs source was deleted' do
        forked_project.destroy

        expect(second_fork.fork_source).to eq(project)
      end
2004 2005 2006 2007

      it 'returns nil if it is the root of the fork network' do
        expect(project.fork_source).to be_nil
      end
2008
    end
2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026

    describe '#lfs_storage_project' do
      it 'returns self for non-forks' do
        expect(project.lfs_storage_project).to eq project
      end

      it 'returns the fork network root for forks' do
        second_fork = fork_project(forked_project)

        expect(second_fork.lfs_storage_project).to eq project
      end

      it 'returns self when fork_source is nil' do
        expect(forked_project).to receive(:fork_source).and_return(nil)

        expect(forked_project.lfs_storage_project).to eq forked_project
      end
    end
2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042

    describe '#all_lfs_objects' do
      let(:lfs_object) { create(:lfs_object) }

      before do
        project.lfs_objects << lfs_object
      end

      it 'returns the lfs object for a project' do
        expect(project.all_lfs_objects).to contain_exactly(lfs_object)
      end

      it 'returns the lfs object for a fork' do
        expect(forked_project.all_lfs_objects).to contain_exactly(lfs_object)
      end
    end
2043 2044
  end

Y
Yorick Peterse 已提交
2045
  describe '#pushes_since_gc' do
2046
    let(:project) { create(:project) }
Y
Yorick Peterse 已提交
2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067

    after do
      project.reset_pushes_since_gc
    end

    context 'without any pushes' do
      it 'returns 0' do
        expect(project.pushes_since_gc).to eq(0)
      end
    end

    context 'with a number of pushes' do
      it 'returns the number of pushes' do
        3.times { project.increment_pushes_since_gc }

        expect(project.pushes_since_gc).to eq(3)
      end
    end
  end

  describe '#increment_pushes_since_gc' do
2068
    let(:project) { create(:project) }
Y
Yorick Peterse 已提交
2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081

    after do
      project.reset_pushes_since_gc
    end

    it 'increments the number of pushes since the last GC' do
      3.times { project.increment_pushes_since_gc }

      expect(project.pushes_since_gc).to eq(3)
    end
  end

  describe '#reset_pushes_since_gc' do
2082
    let(:project) { create(:project) }
Y
Yorick Peterse 已提交
2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095

    after do
      project.reset_pushes_since_gc
    end

    it 'resets the number of pushes since the last GC' do
      3.times { project.increment_pushes_since_gc }

      project.reset_pushes_since_gc

      expect(project.pushes_since_gc).to eq(0)
    end
  end
2096

2097 2098
  describe '#deployment_variables' do
    context 'when project has no deployment service' do
2099
      let(:project) { create(:project) }
2100 2101 2102 2103 2104 2105 2106

      it 'returns an empty array' do
        expect(project.deployment_variables).to eq []
      end
    end

    context 'when project has a deployment service' do
2107
      shared_examples 'same behavior between KubernetesService and Platform::Kubernetes' do
2108 2109
        it 'returns variables from this service' do
          expect(project.deployment_variables).to include(
2110
            { key: 'KUBE_TOKEN', value: project.deployment_platform.token, public: false }
2111 2112 2113 2114 2115 2116 2117
          )
        end
      end

      context 'when user configured kubernetes from Integration > Kubernetes' do
        let(:project) { create(:kubernetes_project) }

2118
        it_behaves_like 'same behavior between KubernetesService and Platform::Kubernetes'
2119 2120 2121 2122 2123
      end

      context 'when user configured kubernetes from CI/CD > Clusters' do
        let!(:cluster) { create(:cluster, :project, :provided_by_gcp) }
        let(:project) { cluster.project }
2124

2125
        it_behaves_like 'same behavior between KubernetesService and Platform::Kubernetes'
2126 2127 2128 2129
      end
    end
  end

2130
  describe '#secret_variables_for' do
2131
    let(:project) { create(:project) }
2132 2133 2134 2135 2136 2137 2138 2139 2140

    let!(:secret_variable) do
      create(:ci_variable, value: 'secret', project: project)
    end

    let!(:protected_variable) do
      create(:ci_variable, :protected, value: 'protected', project: project)
    end

2141
    subject { project.reload.secret_variables_for(ref: 'ref') }
L
Lin Jen-Shin 已提交
2142 2143 2144 2145 2146

    before do
      stub_application_setting(
        default_branch_protection: Gitlab::Access::PROTECTION_NONE)
    end
2147 2148 2149

    shared_examples 'ref is protected' do
      it 'contains all the variables' do
2150
        is_expected.to contain_exactly(secret_variable, protected_variable)
2151 2152 2153 2154
      end
    end

    context 'when the ref is not protected' do
2155
      it 'contains only the secret variables' do
2156
        is_expected.to contain_exactly(secret_variable)
2157 2158 2159
      end
    end

2160 2161
    context 'when the ref is a protected branch' do
      before do
2162
        allow(project).to receive(:protected_for?).with('ref').and_return(true)
2163
      end
2164 2165 2166 2167 2168 2169

      it_behaves_like 'ref is protected'
    end

    context 'when the ref is a protected tag' do
      before do
2170
        allow(project).to receive(:protected_for?).with('ref').and_return(true)
2171 2172 2173
      end

      it_behaves_like 'ref is protected'
2174 2175 2176
    end
  end

2177
  describe '#protected_for?' do
2178
    let(:project) { create(:project) }
2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194

    subject { project.protected_for?('ref') }

    context 'when the ref is not protected' do
      before do
        stub_application_setting(
          default_branch_protection: Gitlab::Access::PROTECTION_NONE)
      end

      it 'returns false' do
        is_expected.to be_falsey
      end
    end

    context 'when the ref is a protected branch' do
      before do
2195 2196
        allow(project).to receive(:repository).and_call_original
        allow(project).to receive_message_chain(:repository, :branch_exists?).and_return(true)
2197 2198 2199 2200 2201 2202 2203 2204 2205 2206
        create(:protected_branch, name: 'ref', project: project)
      end

      it 'returns true' do
        is_expected.to be_truthy
      end
    end

    context 'when the ref is a protected tag' do
      before do
2207 2208
        allow(project).to receive_message_chain(:repository, :branch_exists?).and_return(false)
        allow(project).to receive_message_chain(:repository, :tag_exists?).and_return(true)
2209 2210 2211 2212 2213 2214 2215 2216 2217
        create(:protected_tag, name: 'ref', project: project)
      end

      it 'returns true' do
        is_expected.to be_truthy
      end
    end
  end

M
Markus Koller 已提交
2218
  describe '#update_project_statistics' do
2219
    let(:project) { create(:project) }
M
Markus Koller 已提交
2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237

    it "is called after creation" do
      expect(project.statistics).to be_a ProjectStatistics
      expect(project.statistics).to be_persisted
    end

    it "copies the namespace_id" do
      expect(project.statistics.namespace_id).to eq project.namespace_id
    end

    it "updates the namespace_id when changed" do
      namespace = create(:namespace)
      project.update(namespace: namespace)

      expect(project.statistics.namespace_id).to eq namespace.id
    end
  end

2238
  describe 'inside_path' do
2239 2240 2241
    let!(:project1) { create(:project, namespace: create(:namespace, path: 'name_pace')) }
    let!(:project2) { create(:project) }
    let!(:project3) { create(:project, namespace: create(:namespace, path: 'namespace')) }
2242
    let!(:path) { project1.namespace.full_path }
2243

2244
    it 'returns correct project' do
2245
      expect(described_class.inside_path(path)).to eq([project1])
2246
    end
2247 2248
  end

D
Douwe Maan 已提交
2249
  describe '#route_map_for' do
2250
    let(:project) { create(:project, :repository) }
D
Douwe Maan 已提交
2251 2252 2253 2254 2255 2256 2257 2258
    let(:route_map) do
      <<-MAP.strip_heredoc
      - source: /source/(.*)/
        public: '\\1'
      MAP
    end

    before do
2259
      project.repository.create_file(User.last, '.gitlab/route-map.yml', route_map, message: 'Add .gitlab/route-map.yml', branch_name: 'master')
D
Douwe Maan 已提交
2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286
    end

    context 'when there is a .gitlab/route-map.yml at the commit' do
      context 'when the route map is valid' do
        it 'returns a route map' do
          map = project.route_map_for(project.commit.sha)
          expect(map).to be_a_kind_of(Gitlab::RouteMap)
        end
      end

      context 'when the route map is invalid' do
        let(:route_map) { 'INVALID' }

        it 'returns nil' do
          expect(project.route_map_for(project.commit.sha)).to be_nil
        end
      end
    end

    context 'when there is no .gitlab/route-map.yml at the commit' do
      it 'returns nil' do
        expect(project.route_map_for(project.commit.parent.sha)).to be_nil
      end
    end
  end

  describe '#public_path_for_source_path' do
2287
    let(:project) { create(:project, :repository) }
D
Douwe Maan 已提交
2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324
    let(:route_map) do
      Gitlab::RouteMap.new(<<-MAP.strip_heredoc)
        - source: /source/(.*)/
          public: '\\1'
      MAP
    end
    let(:sha) { project.commit.id }

    context 'when there is a route map' do
      before do
        allow(project).to receive(:route_map_for).with(sha).and_return(route_map)
      end

      context 'when the source path is mapped' do
        it 'returns the public path' do
          expect(project.public_path_for_source_path('source/file.html', sha)).to eq('file.html')
        end
      end

      context 'when the source path is not mapped' do
        it 'returns nil' do
          expect(project.public_path_for_source_path('file.html', sha)).to be_nil
        end
      end
    end

    context 'when there is no route map' do
      before do
        allow(project).to receive(:route_map_for).with(sha).and_return(nil)
      end

      it 'returns nil' do
        expect(project.public_path_for_source_path('source/file.html', sha)).to be_nil
      end
    end
  end

2325
  describe '#parent' do
2326
    let(:project) { create(:project) }
2327 2328 2329 2330

    it { expect(project.parent).to eq(project.namespace) }
  end

2331 2332 2333 2334 2335 2336
  describe '#parent_id' do
    let(:project) { create(:project) }

    it { expect(project.parent_id).to eq(project.namespace_id) }
  end

2337
  describe '#parent_changed?' do
2338
    let(:project) { create(:project) }
2339

2340 2341 2342
    before do
      project.namespace_id = 7
    end
2343 2344 2345 2346

    it { expect(project.parent_changed?).to be_truthy }
  end

2347 2348 2349
  def enable_lfs
    allow(Gitlab.config.lfs).to receive(:enabled).and_return(true)
  end
K
Kamil Trzcinski 已提交
2350

2351
  describe '#pages_url' do
2352 2353
    let(:group) { create :group, name: 'Group' }
    let(:nested_group) { create :group, parent: group }
K
Kamil Trzcinski 已提交
2354 2355 2356 2357 2358 2359 2360 2361 2362
    let(:domain) { 'Example.com' }

    subject { project.pages_url }

    before do
      allow(Settings.pages).to receive(:host).and_return(domain)
      allow(Gitlab.config.pages).to receive(:url).and_return('http://example.com')
    end

2363
    context 'top-level group' do
2364
      let(:project) { create :project, namespace: group, name: project_name }
K
Kamil Trzcinski 已提交
2365

2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376
      context 'group page' do
        let(:project_name) { 'group.example.com' }

        it { is_expected.to eq("http://group.example.com") }
      end

      context 'project page' do
        let(:project_name) { 'Project' }

        it { is_expected.to eq("http://group.example.com/project") }
      end
K
Kamil Trzcinski 已提交
2377 2378
    end

2379
    context 'nested group' do
2380
      let(:project) { create :project, namespace: nested_group, name: project_name }
2381
      let(:expected_url) { "http://group.example.com/#{nested_group.path}/#{project.path}" }
K
Kamil Trzcinski 已提交
2382

2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393
      context 'group page' do
        let(:project_name) { 'group.example.com' }

        it { is_expected.to eq(expected_url) }
      end

      context 'project page' do
        let(:project_name) { 'Project' }

        it { is_expected.to eq(expected_url) }
      end
K
Kamil Trzcinski 已提交
2394 2395
    end
  end
2396 2397

  describe '#http_url_to_repo' do
2398
    let(:project) { create :project }
2399

2400 2401 2402
    it 'returns the url to the repo without a username' do
      expect(project.http_url_to_repo).to eq("#{project.web_url}.git")
      expect(project.http_url_to_repo).not_to include('@')
2403 2404
    end
  end
2405 2406

  describe '#pipeline_status' do
2407
    let(:project) { create(:project, :repository) }
2408
    it 'builds a pipeline status' do
2409
      expect(project.pipeline_status).to be_a(Gitlab::Cache::Ci::ProjectPipelineStatus)
2410 2411 2412 2413 2414 2415
    end

    it 'hase a loaded pipeline status' do
      expect(project.pipeline_status).to be_loaded
    end
  end
2416 2417

  describe '#append_or_update_attribute' do
2418
    let(:project) { create(:project) }
2419 2420 2421 2422 2423

    it 'shows full error updating an invalid MR' do
      error_message = 'Failed to replace merge_requests because one or more of the new records could not be saved.'\
                      ' Validate fork Source project is not a fork of the target project'

2424 2425
      expect { project.append_or_update_attribute(:merge_requests, [create(:merge_request)]) }
        .to raise_error(ActiveRecord::RecordNotSaved, error_message)
2426 2427 2428 2429 2430
    end

    it 'updates the project succesfully' do
      merge_request = create(:merge_request, target_project: project, source_project: project)

2431 2432
      expect { project.append_or_update_attribute(:merge_requests, [merge_request]) }
        .not_to raise_error
2433 2434
    end
  end
2435 2436 2437

  describe '#last_repository_updated_at' do
    it 'sets to created_at upon creation' do
2438
      project = create(:project, created_at: 2.hours.ago)
2439 2440 2441 2442

      expect(project.last_repository_updated_at.to_i).to eq(project.created_at.to_i)
    end
  end
2443 2444 2445 2446 2447

  describe '.public_or_visible_to_user' do
    let!(:user) { create(:user) }

    let!(:private_project) do
2448
      create(:project, :private, creator: user, namespace: user.namespace)
2449 2450
    end

2451
    let!(:public_project) { create(:project, :public) }
2452 2453 2454

    context 'with a user' do
      let(:projects) do
2455
        described_class.all.public_or_visible_to_user(user)
2456 2457 2458 2459 2460 2461 2462 2463 2464 2465 2466 2467 2468
      end

      it 'includes projects the user has access to' do
        expect(projects).to include(private_project)
      end

      it 'includes projects the user can see' do
        expect(projects).to include(public_project)
      end
    end

    context 'without a user' do
      it 'only includes public projects' do
2469
        projects = described_class.all.public_or_visible_to_user
2470 2471 2472 2473 2474

        expect(projects).to eq([public_project])
      end
    end
  end
2475

2476 2477 2478 2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489 2490 2491 2492 2493 2494 2495 2496 2497
  describe '#pages_available?' do
    let(:project) { create(:project, group: group) }

    subject { project.pages_available? }

    before do
      allow(Gitlab.config.pages).to receive(:enabled).and_return(true)
    end

    context 'when the project is in a top level namespace' do
      let(:group) { create(:group) }

      it { is_expected.to be(true) }
    end

    context 'when the project is in a subgroup' do
      let(:group) { create(:group, :nested) }

      it { is_expected.to be(false) }
    end
  end

2498
  describe '#remove_private_deploy_keys' do
2499
    let!(:project) { create(:project) }
2500 2501 2502 2503 2504 2505 2506 2507 2508 2509 2510 2511 2512 2513 2514

    context 'for a private deploy key' do
      let!(:key) { create(:deploy_key, public: false) }
      let!(:deploy_keys_project) { create(:deploy_keys_project, deploy_key: key, project: project) }

      context 'when the key is not linked to another project' do
        it 'removes the key' do
          project.remove_private_deploy_keys

          expect(project.deploy_keys).not_to include(key)
        end
      end

      context 'when the key is linked to another project' do
        before do
2515
          another_project = create(:project)
2516 2517
          create(:deploy_keys_project, deploy_key: key, project: another_project)
        end
2518

2519 2520
        it 'does not remove the key' do
          project.remove_private_deploy_keys
2521

2522 2523 2524 2525 2526 2527 2528 2529
          expect(project.deploy_keys).to include(key)
        end
      end
    end

    context 'for a public deploy key' do
      let!(:key) { create(:deploy_key, public: true) }
      let!(:deploy_keys_project) { create(:deploy_keys_project, deploy_key: key, project: project) }
2530

2531 2532
      it 'does not remove the key' do
        project.remove_private_deploy_keys
2533

2534 2535
        expect(project.deploy_keys).to include(key)
      end
2536 2537
    end
  end
2538

2539 2540
  describe '#remove_pages' do
    let(:project) { create(:project) }
2541
    let(:namespace) { project.namespace }
2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552
    let(:pages_path) { project.pages_path }

    around do |example|
      FileUtils.mkdir_p(pages_path)
      begin
        example.run
      ensure
        FileUtils.rm_rf(pages_path)
      end
    end

2553 2554 2555 2556 2557 2558 2559 2560
    it 'removes the pages directory' do
      expect_any_instance_of(Projects::UpdatePagesConfigurationService).to receive(:execute)
      expect_any_instance_of(Gitlab::PagesTransfer).to receive(:rename_project).and_return(true)
      expect(PagesWorker).to receive(:perform_in).with(5.minutes, :remove, namespace.full_path, anything)

      project.remove_pages
    end

2561
    it 'is a no-op when there is no namespace' do
2562 2563
      project.namespace.delete
      project.reload
2564 2565 2566 2567 2568 2569

      expect_any_instance_of(Projects::UpdatePagesConfigurationService).not_to receive(:execute)
      expect_any_instance_of(Gitlab::PagesTransfer).not_to receive(:rename_project)

      project.remove_pages
    end
2570 2571 2572 2573 2574 2575

    it 'is run when the project is destroyed' do
      expect(project).to receive(:remove_pages).and_call_original

      project.destroy
    end
2576 2577
  end

2578
  describe '#remove_export' do
N
Nick Thomas 已提交
2579
    let(:legacy_project) { create(:project, :legacy_storage, :with_export) }
2580 2581 2582 2583 2584 2585 2586 2587 2588 2589 2590 2591
    let(:project) { create(:project, :with_export) }

    it 'removes the exports directory for the project' do
      expect(File.exist?(project.export_path)).to be_truthy

      allow(FileUtils).to receive(:rm_rf).and_call_original
      expect(FileUtils).to receive(:rm_rf).with(project.export_path).and_call_original
      project.remove_exports

      expect(File.exist?(project.export_path)).to be_falsy
    end

N
Nick Thomas 已提交
2592 2593 2594
    it 'is a no-op on legacy projects when there is no namespace' do
      export_path = legacy_project.export_path

2595 2596
      legacy_project.namespace.delete
      legacy_project.reload
N
Nick Thomas 已提交
2597 2598 2599 2600 2601 2602 2603 2604 2605

      expect(FileUtils).not_to receive(:rm_rf).with(export_path)

      legacy_project.remove_exports

      expect(File.exist?(export_path)).to be_truthy
    end

    it 'runs on hashed storage projects when there is no namespace' do
2606
      export_path = project.export_path
N
Nick Thomas 已提交
2607

2608 2609
      project.namespace.delete
      legacy_project.reload
2610

N
Nick Thomas 已提交
2611 2612
      allow(FileUtils).to receive(:rm_rf).and_call_original
      expect(FileUtils).to receive(:rm_rf).with(export_path).and_call_original
2613 2614 2615

      project.remove_exports

N
Nick Thomas 已提交
2616
      expect(File.exist?(export_path)).to be_falsy
2617 2618 2619 2620 2621 2622 2623 2624 2625
    end

    it 'is run when the project is destroyed' do
      expect(project).to receive(:remove_exports).and_call_original

      project.destroy
    end
  end

2626 2627 2628 2629 2630 2631 2632 2633 2634 2635 2636 2637 2638 2639 2640 2641 2642
  describe '#remove_exported_project_file' do
    let(:project) { create(:project, :with_export) }

    it 'removes the exported project file' do
      exported_file = project.export_project_path

      expect(File.exist?(exported_file)).to be_truthy

      allow(FileUtils).to receive(:rm_f).and_call_original
      expect(FileUtils).to receive(:rm_f).with(exported_file).and_call_original

      project.remove_exported_project_file

      expect(File.exist?(exported_file)).to be_falsy
    end
  end

2643 2644 2645 2646
  describe '#forks_count' do
    it 'returns the number of forks' do
      project = build(:project)

F
Francisco Lopez 已提交
2647
      expect_any_instance_of(Projects::ForksCountService).to receive(:count).and_return(1)
2648 2649 2650 2651

      expect(project.forks_count).to eq(1)
    end
  end
2652 2653

  context 'legacy storage' do
N
Nick Thomas 已提交
2654
    let(:project) { create(:project, :repository, :legacy_storage) }
2655
    let(:gitlab_shell) { Gitlab::Shell.new }
2656
    let(:project_storage) { project.send(:storage) }
2657

2658 2659 2660 2661
    before do
      allow(project).to receive(:gitlab_shell).and_return(gitlab_shell)
    end

2662 2663 2664 2665 2666 2667 2668 2669 2670 2671 2672 2673
    describe '#base_dir' do
      it 'returns base_dir based on namespace only' do
        expect(project.base_dir).to eq(project.namespace.full_path)
      end
    end

    describe '#disk_path' do
      it 'returns disk_path based on namespace and project path' do
        expect(project.disk_path).to eq("#{project.namespace.full_path}/#{project.path}")
      end
    end

2674
    describe '#ensure_storage_path_exists' do
2675 2676 2677
      it 'delegates to gitlab_shell to ensure namespace is created' do
        expect(gitlab_shell).to receive(:add_namespace).with(project.repository_storage_path, project.base_dir)

2678
        project.ensure_storage_path_exists
2679 2680 2681
      end
    end

2682 2683
    describe '#legacy_storage?' do
      it 'returns true when storage_version is nil' do
2684
        project = build(:project, storage_version: nil)
2685 2686 2687

        expect(project.legacy_storage?).to be_truthy
      end
2688 2689 2690 2691 2692 2693 2694 2695 2696 2697

      it 'returns true when the storage_version is 0' do
        project = build(:project, storage_version: 0)

        expect(project.legacy_storage?).to be_truthy
      end
    end

    describe '#hashed_storage?' do
      it 'returns false' do
2698
        expect(project.hashed_storage?(:repository)).to be_falsey
2699
      end
2700 2701
    end

2702 2703 2704 2705 2706 2707 2708 2709 2710 2711 2712 2713 2714 2715 2716 2717 2718 2719 2720 2721 2722 2723 2724 2725 2726 2727 2728 2729 2730 2731 2732 2733 2734 2735 2736 2737 2738 2739 2740 2741 2742 2743 2744 2745 2746 2747 2748
    describe '#rename_repo' do
      before do
        # Project#gitlab_shell returns a new instance of Gitlab::Shell on every
        # call. This makes testing a bit easier.
        allow(project).to receive(:gitlab_shell).and_return(gitlab_shell)
        allow(project).to receive(:previous_changes).and_return('path' => ['foo'])
      end

      it 'renames a repository' do
        stub_container_registry_config(enabled: false)

        expect(gitlab_shell).to receive(:mv_repository)
          .ordered
          .with(project.repository_storage_path, "#{project.namespace.full_path}/foo", "#{project.full_path}")
          .and_return(true)

        expect(gitlab_shell).to receive(:mv_repository)
          .ordered
          .with(project.repository_storage_path, "#{project.namespace.full_path}/foo.wiki", "#{project.full_path}.wiki")
          .and_return(true)

        expect_any_instance_of(SystemHooksService)
          .to receive(:execute_hooks_for)
            .with(project, :rename)

        expect_any_instance_of(Gitlab::UploadsTransfer)
          .to receive(:rename_project)
            .with('foo', project.path, project.namespace.full_path)

        expect(project).to receive(:expire_caches_before_rename)

        expect(project).to receive(:expires_full_path_cache)

        project.rename_repo
      end

      context 'container registry with images' do
        let(:container_repository) { create(:container_repository) }

        before do
          stub_container_registry_config(enabled: true)
          stub_container_registry_tags(repository: :any, tags: ['tag'])
          project.container_repositories << container_repository
        end

        subject { project.rename_repo }

2749
        it { expect { subject }.to raise_error(StandardError) }
2750
      end
2751 2752 2753 2754 2755 2756 2757 2758 2759 2760 2761 2762 2763 2764 2765 2766 2767 2768 2769 2770 2771 2772 2773 2774

      context 'gitlab pages' do
        before do
          expect(project_storage).to receive(:rename_repo) { true }
        end

        it 'moves pages folder to new location' do
          expect_any_instance_of(Gitlab::PagesTransfer).to receive(:rename_project)

          project.rename_repo
        end
      end

      context 'attachments' do
        before do
          expect(project_storage).to receive(:rename_repo) { true }
        end

        it 'moves uploads folder to new location' do
          expect_any_instance_of(Gitlab::UploadsTransfer).to receive(:rename_project)

          project.rename_repo
        end
      end
2775 2776 2777 2778 2779

      it 'updates project full path in .git/config' do
        allow(project_storage).to receive(:rename_repo).and_return(true)

        project.rename_repo
2780

J
Jacob Vosmaer 已提交
2781
        expect(project.repository.rugged.config['gitlab.fullpath']).to eq(project.full_path)
2782
      end
2783
    end
2784 2785 2786 2787 2788 2789

    describe '#pages_path' do
      it 'returns a path where pages are stored' do
        expect(project.pages_path).to eq(File.join(Settings.pages.path, project.namespace.full_path, project.path))
      end
    end
2790 2791 2792 2793 2794 2795

    describe '#migrate_to_hashed_storage!' do
      it 'returns true' do
        expect(project.migrate_to_hashed_storage!).to be_truthy
      end

T
Toon Claes 已提交
2796
      it 'flags as read-only' do
2797 2798 2799 2800 2801 2802 2803 2804 2805 2806 2807 2808 2809 2810 2811 2812 2813 2814 2815 2816 2817 2818 2819 2820 2821
        expect { project.migrate_to_hashed_storage! }.to change { project.repository_read_only }.to(true)
      end

      it 'schedules ProjectMigrateHashedStorageWorker with delayed start when the project repo is in use' do
        Gitlab::ReferenceCounter.new(project.gl_repository(is_wiki: false)).increase

        expect(ProjectMigrateHashedStorageWorker).to receive(:perform_in)

        project.migrate_to_hashed_storage!
      end

      it 'schedules ProjectMigrateHashedStorageWorker with delayed start when the wiki repo is in use' do
        Gitlab::ReferenceCounter.new(project.gl_repository(is_wiki: true)).increase

        expect(ProjectMigrateHashedStorageWorker).to receive(:perform_in)

        project.migrate_to_hashed_storage!
      end

      it 'schedules ProjectMigrateHashedStorageWorker' do
        expect(ProjectMigrateHashedStorageWorker).to receive(:perform_async).with(project.id)

        project.migrate_to_hashed_storage!
      end
    end
2822 2823 2824
  end

  context 'hashed storage' do
2825
    let(:project) { create(:project, :repository, skip_disk_validation: true) }
2826
    let(:gitlab_shell) { Gitlab::Shell.new }
2827
    let(:hash) { Digest::SHA2.hexdigest(project.id.to_s) }
N
Nick Thomas 已提交
2828 2829
    let(:hashed_prefix) { File.join('@hashed', hash[0..1], hash[2..3]) }
    let(:hashed_path) { File.join(hashed_prefix, hash) }
2830 2831

    before do
2832
      stub_application_setting(hashed_storage_enabled: true)
2833 2834
    end

2835 2836 2837 2838 2839 2840 2841
    describe '#legacy_storage?' do
      it 'returns false' do
        expect(project.legacy_storage?).to be_falsey
      end
    end

    describe '#hashed_storage?' do
2842 2843
      it 'returns true if rolled out' do
        expect(project.hashed_storage?(:attachments)).to be_truthy
2844 2845
      end

2846 2847
      it 'returns false when not rolled out yet' do
        project.storage_version = 1
2848

2849
        expect(project.hashed_storage?(:attachments)).to be_falsey
2850 2851 2852
      end
    end

2853 2854
    describe '#base_dir' do
      it 'returns base_dir based on hash of project id' do
N
Nick Thomas 已提交
2855
        expect(project.base_dir).to eq(hashed_prefix)
2856 2857 2858 2859
      end
    end

    describe '#disk_path' do
2860
      it 'returns disk_path based on hash of project id' do
2861 2862 2863 2864
        expect(project.disk_path).to eq(hashed_path)
      end
    end

2865
    describe '#ensure_storage_path_exists' do
2866
      it 'delegates to gitlab_shell to ensure namespace is created' do
2867 2868
        allow(project).to receive(:gitlab_shell).and_return(gitlab_shell)

N
Nick Thomas 已提交
2869
        expect(gitlab_shell).to receive(:add_namespace).with(project.repository_storage_path, hashed_prefix)
2870

2871
        project.ensure_storage_path_exists
2872 2873 2874 2875 2876 2877 2878 2879 2880 2881 2882 2883 2884 2885 2886 2887 2888 2889 2890 2891 2892 2893 2894 2895 2896 2897 2898 2899 2900 2901 2902 2903 2904 2905 2906 2907 2908 2909
      end
    end

    describe '#rename_repo' do
      before do
        # Project#gitlab_shell returns a new instance of Gitlab::Shell on every
        # call. This makes testing a bit easier.
        allow(project).to receive(:gitlab_shell).and_return(gitlab_shell)
        allow(project).to receive(:previous_changes).and_return('path' => ['foo'])
      end

      it 'renames a repository' do
        stub_container_registry_config(enabled: false)

        expect(gitlab_shell).not_to receive(:mv_repository)

        expect_any_instance_of(SystemHooksService)
          .to receive(:execute_hooks_for)
            .with(project, :rename)

        expect(project).to receive(:expire_caches_before_rename)

        expect(project).to receive(:expires_full_path_cache)

        project.rename_repo
      end

      context 'container registry with images' do
        let(:container_repository) { create(:container_repository) }

        before do
          stub_container_registry_config(enabled: true)
          stub_container_registry_tags(repository: :any, tags: ['tag'])
          project.container_repositories << container_repository
        end

        subject { project.rename_repo }

2910
        it { expect { subject }.to raise_error(StandardError) }
2911
      end
2912 2913 2914 2915 2916 2917 2918 2919 2920 2921 2922 2923 2924 2925 2926 2927 2928

      context 'gitlab pages' do
        it 'moves pages folder to new location' do
          expect_any_instance_of(Gitlab::PagesTransfer).to receive(:rename_project)

          project.rename_repo
        end
      end

      context 'attachments' do
        it 'keeps uploads folder location unchanged' do
          expect_any_instance_of(Gitlab::UploadsTransfer).not_to receive(:rename_project)

          project.rename_repo
        end

        context 'when not rolled out' do
2929
          let(:project) { create(:project, :repository, storage_version: 1, skip_disk_validation: true) }
2930 2931 2932 2933 2934 2935 2936 2937

          it 'moves pages folder to new location' do
            expect_any_instance_of(Gitlab::UploadsTransfer).to receive(:rename_project)

            project.rename_repo
          end
        end
      end
2938 2939 2940

      it 'updates project full path in .git/config' do
        project.rename_repo
2941

J
Jacob Vosmaer 已提交
2942
        expect(project.repository.rugged.config['gitlab.fullpath']).to eq(project.full_path)
2943
      end
2944
    end
2945 2946 2947 2948 2949 2950

    describe '#pages_path' do
      it 'returns a path where pages are stored' do
        expect(project.pages_path).to eq(File.join(Settings.pages.path, project.namespace.full_path, project.path))
      end
    end
2951 2952 2953 2954 2955 2956

    describe '#migrate_to_hashed_storage!' do
      it 'returns nil' do
        expect(project.migrate_to_hashed_storage!).to be_nil
      end

T
Toon Claes 已提交
2957
      it 'does not flag as read-only' do
2958 2959 2960 2961 2962 2963 2964 2965 2966 2967 2968 2969 2970
        expect { project.migrate_to_hashed_storage! }.not_to change { project.repository_read_only }
      end
    end
  end

  describe '#gl_repository' do
    let(:project) { create(:project) }

    it 'delegates to Gitlab::GlRepository.gl_repository' do
      expect(Gitlab::GlRepository).to receive(:gl_repository).with(project, true)

      project.gl_repository(is_wiki: true)
    end
2971
  end
2972 2973 2974 2975 2976 2977 2978 2979 2980 2981 2982 2983 2984 2985 2986 2987 2988 2989 2990 2991 2992 2993 2994 2995 2996 2997 2998 2999 3000 3001 3002 3003 3004 3005 3006 3007 3008 3009 3010 3011 3012 3013 3014 3015 3016 3017 3018 3019 3020 3021 3022 3023 3024 3025 3026 3027 3028 3029 3030 3031 3032 3033 3034 3035 3036 3037 3038 3039 3040 3041 3042 3043 3044 3045 3046 3047 3048 3049 3050 3051 3052 3053 3054 3055 3056 3057 3058 3059 3060 3061 3062 3063 3064 3065 3066 3067 3068 3069

  describe '#has_ci?' do
    set(:project) { create(:project) }
    let(:repository) { double }

    before do
      expect(project).to receive(:repository) { repository }
    end

    context 'when has .gitlab-ci.yml' do
      before do
        expect(repository).to receive(:gitlab_ci_yml) { 'content' }
      end

      it "CI is available" do
        expect(project).to have_ci
      end
    end

    context 'when there is no .gitlab-ci.yml' do
      before do
        expect(repository).to receive(:gitlab_ci_yml) { nil }
      end

      it "CI is not available" do
        expect(project).not_to have_ci
      end

      context 'when auto devops is enabled' do
        before do
          stub_application_setting(auto_devops_enabled: true)
        end

        it "CI is available" do
          expect(project).to have_ci
        end
      end
    end
  end

  describe '#auto_devops_enabled?' do
    set(:project) { create(:project) }

    subject { project.auto_devops_enabled? }

    context 'when enabled in settings' do
      before do
        stub_application_setting(auto_devops_enabled: true)
      end

      it 'auto devops is implicitly enabled' do
        expect(project.auto_devops).to be_nil
        expect(project).to be_auto_devops_enabled
      end

      context 'when explicitly enabled' do
        before do
          create(:project_auto_devops, project: project)
        end

        it "auto devops is enabled" do
          expect(project).to be_auto_devops_enabled
        end
      end

      context 'when explicitly disabled' do
        before do
          create(:project_auto_devops, project: project, enabled: false)
        end

        it "auto devops is disabled" do
          expect(project).not_to be_auto_devops_enabled
        end
      end
    end

    context 'when disabled in settings' do
      before do
        stub_application_setting(auto_devops_enabled: false)
      end

      it 'auto devops is implicitly disabled' do
        expect(project.auto_devops).to be_nil
        expect(project).not_to be_auto_devops_enabled
      end

      context 'when explicitly enabled' do
        before do
          create(:project_auto_devops, project: project)
        end

        it "auto devops is enabled" do
          expect(project).to be_auto_devops_enabled
        end
      end
    end
  end

3070 3071 3072 3073 3074 3075 3076 3077 3078 3079 3080 3081 3082 3083 3084 3085 3086 3087 3088 3089 3090 3091 3092 3093 3094 3095 3096 3097 3098 3099 3100 3101 3102 3103 3104 3105 3106 3107 3108 3109 3110 3111 3112 3113
  describe '#has_auto_devops_implicitly_disabled?' do
    set(:project) { create(:project) }

    context 'when enabled in settings' do
      before do
        stub_application_setting(auto_devops_enabled: true)
      end

      it 'does not have auto devops implicitly disabled' do
        expect(project).not_to have_auto_devops_implicitly_disabled
      end
    end

    context 'when disabled in settings' do
      before do
        stub_application_setting(auto_devops_enabled: false)
      end

      it 'auto devops is implicitly disabled' do
        expect(project).to have_auto_devops_implicitly_disabled
      end

      context 'when explicitly disabled' do
        before do
          create(:project_auto_devops, project: project, enabled: false)
        end

        it 'does not have auto devops implicitly disabled' do
          expect(project).not_to have_auto_devops_implicitly_disabled
        end
      end

      context 'when explicitly enabled' do
        before do
          create(:project_auto_devops, project: project)
        end

        it 'does not have auto devops implicitly disabled' do
          expect(project).not_to have_auto_devops_implicitly_disabled
        end
      end
    end
  end

3114 3115 3116 3117 3118
  context '#auto_devops_variables' do
    set(:project) { create(:project) }

    subject { project.auto_devops_variables }

3119
    context 'when enabled in instance settings' do
3120 3121 3122 3123
      before do
        stub_application_setting(auto_devops_enabled: true)
      end

3124 3125 3126 3127 3128 3129 3130 3131 3132 3133 3134 3135 3136 3137 3138 3139 3140 3141 3142 3143 3144 3145
      context 'when domain is empty' do
        before do
          stub_application_setting(auto_devops_domain: nil)
        end

        it 'variables does not include AUTO_DEVOPS_DOMAIN' do
          is_expected.not_to include(domain_variable)
        end
      end

      context 'when domain is configured' do
        before do
          stub_application_setting(auto_devops_domain: 'example.com')
        end

        it 'variables includes AUTO_DEVOPS_DOMAIN' do
          is_expected.to include(domain_variable)
        end
      end
    end

    context 'when explicitely enabled' do
3146 3147 3148 3149 3150
      context 'when domain is empty' do
        before do
          create(:project_auto_devops, project: project, domain: nil)
        end

3151 3152
        it 'variables does not include AUTO_DEVOPS_DOMAIN' do
          is_expected.not_to include(domain_variable)
3153 3154 3155 3156 3157 3158 3159 3160
        end
      end

      context 'when domain is configured' do
        before do
          create(:project_auto_devops, project: project, domain: 'example.com')
        end

3161 3162
        it 'variables includes AUTO_DEVOPS_DOMAIN' do
          is_expected.to include(domain_variable)
3163 3164 3165
        end
      end
    end
3166 3167 3168 3169

    def domain_variable
      { key: 'AUTO_DEVOPS_DOMAIN', value: 'example.com', public: true }
    end
3170
  end
3171 3172 3173 3174 3175 3176 3177 3178 3179 3180 3181 3182 3183 3184 3185 3186 3187 3188 3189 3190 3191 3192 3193 3194 3195 3196 3197 3198 3199 3200 3201 3202 3203 3204 3205

  describe '#latest_successful_builds_for' do
    let(:project) { build(:project) }

    before do
      allow(project).to receive(:default_branch).and_return('master')
    end

    context 'without a ref' do
      it 'returns a pipeline for the default branch' do
        expect(project)
          .to receive(:latest_successful_pipeline_for_default_branch)

        project.latest_successful_pipeline_for
      end
    end

    context 'with the ref set to the default branch' do
      it 'returns a pipeline for the default branch' do
        expect(project)
          .to receive(:latest_successful_pipeline_for_default_branch)

        project.latest_successful_pipeline_for(project.default_branch)
      end
    end

    context 'with a ref that is not the default branch' do
      it 'returns the latest successful pipeline for the given ref' do
        expect(project.pipelines).to receive(:latest_successful_for).with('foo')

        project.latest_successful_pipeline_for('foo')
      end
    end
  end

S
Stan Hu 已提交
3206 3207 3208 3209 3210 3211 3212 3213 3214 3215 3216
  describe '#check_repository_path_availability' do
    let(:project) { build(:project) }

    it 'skips gitlab-shell exists?' do
      project.skip_disk_validation = true

      expect(project.gitlab_shell).not_to receive(:exists?)
      expect(project.check_repository_path_availability).to be_truthy
    end
  end

3217 3218 3219 3220 3221 3222 3223 3224 3225 3226 3227 3228 3229 3230 3231 3232 3233 3234 3235 3236 3237
  describe '#latest_successful_pipeline_for_default_branch' do
    let(:project) { build(:project) }

    before do
      allow(project).to receive(:default_branch).and_return('master')
    end

    it 'memoizes and returns the latest successful pipeline for the default branch' do
      pipeline = double(:pipeline)

      expect(project.pipelines).to receive(:latest_successful_for)
        .with(project.default_branch)
        .and_return(pipeline)
        .once

      2.times do
        expect(project.latest_successful_pipeline_for_default_branch)
          .to eq(pipeline)
      end
    end
  end
3238 3239 3240 3241 3242 3243 3244 3245 3246

  describe '#after_import' do
    let(:project) { build(:project) }

    it 'runs the correct hooks' do
      expect(project.repository).to receive(:after_import)
      expect(project).to receive(:import_finish)
      expect(project).to receive(:update_project_counter_caches)
      expect(project).to receive(:remove_import_jid)
3247
      expect(project).to receive(:after_create_default_branch)
3248
      expect(project).to receive(:refresh_markdown_cache!)
3249 3250 3251

      project.after_import
    end
3252 3253 3254 3255 3256 3257 3258 3259 3260 3261 3262 3263 3264 3265 3266 3267 3268 3269 3270 3271 3272 3273 3274 3275 3276 3277 3278 3279 3280 3281 3282 3283 3284 3285 3286 3287 3288 3289 3290 3291 3292

    context 'branch protection' do
      let(:project) { create(:project, :repository) }

      it 'does not protect when branch protection is disabled' do
        stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_NONE)

        project.after_import

        expect(project.protected_branches).to be_empty
      end

      it "gives developer access to push when branch protection is set to 'developers can push'" do
        stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_DEV_CAN_PUSH)

        project.after_import

        expect(project.protected_branches).not_to be_empty
        expect(project.default_branch).to eq(project.protected_branches.first.name)
        expect(project.protected_branches.first.push_access_levels.map(&:access_level)).to eq([Gitlab::Access::DEVELOPER])
      end

      it "gives developer access to merge when branch protection is set to 'developers can merge'" do
        stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_DEV_CAN_MERGE)

        project.after_import

        expect(project.protected_branches).not_to be_empty
        expect(project.default_branch).to eq(project.protected_branches.first.name)
        expect(project.protected_branches.first.merge_access_levels.map(&:access_level)).to eq([Gitlab::Access::DEVELOPER])
      end

      it 'protects default branch' do
        project.after_import

        expect(project.protected_branches).not_to be_empty
        expect(project.default_branch).to eq(project.protected_branches.first.name)
        expect(project.protected_branches.first.push_access_levels.map(&:access_level)).to eq([Gitlab::Access::MASTER])
        expect(project.protected_branches.first.merge_access_levels.map(&:access_level)).to eq([Gitlab::Access::MASTER])
      end
    end
3293 3294 3295 3296 3297 3298 3299 3300 3301 3302 3303 3304 3305 3306 3307 3308 3309 3310 3311 3312 3313 3314 3315 3316 3317 3318 3319 3320 3321 3322 3323 3324 3325 3326 3327 3328 3329 3330 3331 3332 3333 3334 3335 3336 3337 3338 3339 3340 3341 3342 3343 3344 3345 3346 3347 3348 3349 3350 3351 3352 3353
  end

  describe '#update_project_counter_caches' do
    let(:project) { create(:project) }

    it 'updates all project counter caches' do
      expect_any_instance_of(Projects::OpenIssuesCountService)
        .to receive(:refresh_cache)
        .and_call_original

      expect_any_instance_of(Projects::OpenMergeRequestsCountService)
        .to receive(:refresh_cache)
        .and_call_original

      project.update_project_counter_caches
    end
  end

  describe '#remove_import_jid', :clean_gitlab_redis_cache do
    let(:project) {  }

    context 'without an import JID' do
      it 'does nothing' do
        project = create(:project)

        expect(Gitlab::SidekiqStatus)
          .not_to receive(:unset)

        project.remove_import_jid
      end
    end

    context 'with an import JID' do
      it 'unsets the import JID' do
        project = create(:project, import_jid: '123')

        expect(Gitlab::SidekiqStatus)
          .to receive(:unset)
          .with('123')
          .and_call_original

        project.remove_import_jid

        expect(project.import_jid).to be_nil
      end
    end
  end

  describe '#wiki_repository_exists?' do
    it 'returns true when the wiki repository exists' do
      project = create(:project, :wiki_repo)

      expect(project.wiki_repository_exists?).to eq(true)
    end

    it 'returns false when the wiki repository does not exist' do
      project = create(:project)

      expect(project.wiki_repository_exists?).to eq(false)
    end
  end
3354

3355 3356 3357 3358 3359 3360
  describe '#write_repository_config' do
    set(:project) { create(:project, :repository) }

    it 'writes full path in .git/config when key is missing' do
      project.write_repository_config

J
Jacob Vosmaer 已提交
3361
      expect(project.repository.rugged.config['gitlab.fullpath']).to eq project.full_path
3362 3363 3364 3365 3366
    end

    it 'updates full path in .git/config when key is present' do
      project.write_repository_config(gl_full_path: 'old/path')

J
Jacob Vosmaer 已提交
3367
      expect { project.write_repository_config }.to change { project.repository.rugged.config['gitlab.fullpath'] }.from('old/path').to(project.full_path)
3368 3369 3370 3371 3372 3373 3374 3375
    end

    it 'does not raise an error with an empty repository' do
      project = create(:project_empty_repo)

      expect { project.write_repository_config }.not_to raise_error
    end
  end
3376 3377 3378 3379 3380 3381 3382 3383 3384 3385 3386 3387 3388

  describe '#execute_hooks' do
    it 'executes the projects hooks with the specified scope' do
      hook1 = create(:project_hook, merge_requests_events: true, tag_push_events: false)
      hook2 = create(:project_hook, merge_requests_events: false, tag_push_events: true)
      project = create(:project, hooks: [hook1, hook2])

      expect_any_instance_of(ProjectHook).to receive(:async_execute).once

      project.execute_hooks({}, :tag_push_hooks)
    end

    it 'executes the system hooks with the specified scope' do
3389
      expect_any_instance_of(SystemHooksService).to receive(:execute_hooks).with({ data: 'data' }, :merge_request_hooks)
3390

3391 3392
      project = build(:project)
      project.execute_hooks({ data: 'data' }, :merge_request_hooks)
3393
    end
3394 3395 3396 3397 3398 3399 3400 3401 3402 3403 3404 3405 3406 3407 3408 3409 3410

    it 'executes the system hooks when inside a transaction' do
      allow_any_instance_of(WebHookService).to receive(:execute)

      create(:system_hook, merge_requests_events: true)

      project = build(:project)

      # Ideally, we'd test that `WebHookWorker.jobs.size` increased by 1,
      # but since the entire spec run takes place in a transaction, we never
      # actually get to the `after_commit` hook that queues these jobs.
      expect do
        project.transaction do
          project.execute_hooks({ data: 'data' }, :merge_request_hooks)
        end
      end.not_to raise_error # Sidekiq::Worker::EnqueueFromTransactionError
    end
3411
  end
3412 3413 3414 3415 3416 3417 3418 3419 3420 3421 3422 3423 3424 3425 3426 3427 3428 3429 3430 3431 3432 3433 3434 3435 3436 3437 3438 3439 3440 3441 3442 3443

  describe '#badges' do
    let(:project_group) { create(:group) }
    let(:project) {  create(:project, path: 'avatar', namespace: project_group) }

    before do
      create_list(:project_badge, 2, project: project)
      create(:group_badge, group: project_group)
    end

    it 'returns the project and the project group badges' do
      create(:group_badge, group: create(:group))

      expect(Badge.count).to eq 4
      expect(project.badges.count).to eq 3
    end

    if Group.supports_nested_groups?
      context 'with nested_groups' do
        let(:parent_group) { create(:group) }

        before do
          create_list(:group_badge, 2, group: project_group)
          project_group.update(parent: parent_group)
        end

        it 'returns the project and the project nested groups badges' do
          expect(project.badges.count).to eq 5
        end
      end
    end
  end
3444

3445 3446
  context 'with cross project merge requests' do
    let(:user) { create(:user) }
3447 3448
    let(:target_project) { create(:project, :repository) }
    let(:project) { fork_project(target_project, nil, repository: true) }
3449 3450 3451 3452
    let!(:merge_request) do
      create(
        :merge_request,
        target_project: target_project,
3453
        target_branch: 'target-branch',
3454 3455 3456 3457 3458 3459 3460
        source_project: project,
        source_branch: 'awesome-feature-1',
        allow_maintainer_to_push: true
      )
    end

    before do
3461
      target_project.add_developer(user)
3462 3463
    end

3464 3465 3466 3467
    describe '#merge_requests_allowing_push_to_user' do
      it 'returns open merge requests for which the user has developer access to the target project' do
        expect(project.merge_requests_allowing_push_to_user(user)).to include(merge_request)
      end
3468

3469 3470
      it 'does not include closed merge requests' do
        merge_request.close
3471

3472 3473 3474 3475 3476 3477
        expect(project.merge_requests_allowing_push_to_user(user)).to be_empty
      end

      it 'does not include merge requests for guest users' do
        guest = create(:user)
        target_project.add_guest(guest)
3478

3479 3480 3481 3482 3483 3484 3485 3486 3487 3488 3489 3490
        expect(project.merge_requests_allowing_push_to_user(guest)).to be_empty
      end

      it 'does not include the merge request for other users' do
        other_user = create(:user)

        expect(project.merge_requests_allowing_push_to_user(other_user)).to be_empty
      end

      it 'is empty when no user is passed' do
        expect(project.merge_requests_allowing_push_to_user(nil)).to be_empty
      end
3491 3492
    end

3493
    describe '#branch_allows_maintainer_push?' do
3494
      it 'allows access if the user can merge the merge request' do
3495 3496 3497 3498 3499 3500 3501 3502 3503 3504 3505 3506
        expect(project.branch_allows_maintainer_push?(user, 'awesome-feature-1'))
          .to be_truthy
      end

      it 'does not allow guest users access' do
        guest = create(:user)
        target_project.add_guest(guest)

        expect(project.branch_allows_maintainer_push?(guest, 'awesome-feature-1'))
          .to be_falsy
      end

3507
      it 'does not allow access to branches for which the merge request was closed' do
3508 3509
        create(:merge_request, :closed,
               target_project: target_project,
3510
               target_branch: 'target-branch',
3511 3512 3513 3514 3515 3516 3517 3518
               source_project: project,
               source_branch: 'rejected-feature-1',
               allow_maintainer_to_push: true)

        expect(project.branch_allows_maintainer_push?(user, 'rejected-feature-1'))
          .to be_falsy
      end

3519 3520 3521 3522 3523 3524 3525 3526 3527 3528
      it 'does not allow access if the user cannot merge the merge request' do
        create(:protected_branch, :masters_can_push, project: target_project, name: 'target-branch')

        expect(project.branch_allows_maintainer_push?(user, 'awesome-feature-1'))
          .to be_falsy
      end

      it 'caches the result' do
        control = ActiveRecord::QueryRecorder.new { project.branch_allows_maintainer_push?(user, 'awesome-feature-1') }

3529
        expect { 3.times { project.branch_allows_maintainer_push?(user, 'awesome-feature-1') } }
3530
          .not_to exceed_query_limit(control)
3531 3532 3533
      end

      context 'when the requeststore is active', :request_store do
3534 3535 3536
        it 'only queries per project across instances' do
          control = ActiveRecord::QueryRecorder.new { project.branch_allows_maintainer_push?(user, 'awesome-feature-1') }

3537
          expect { 2.times { described_class.find(project.id).branch_allows_maintainer_push?(user, 'awesome-feature-1') } }
3538
            .not_to exceed_query_limit(control).with_threshold(2)
3539
        end
3540 3541 3542
      end
    end
  end
R
Rob Watson 已提交
3543 3544 3545 3546 3547 3548 3549 3550 3551 3552 3553 3554 3555 3556 3557 3558 3559 3560 3561 3562 3563 3564 3565 3566 3567 3568 3569 3570 3571 3572 3573 3574 3575 3576 3577 3578 3579 3580 3581 3582 3583 3584 3585 3586 3587

  describe "#pages_https_only?" do
    subject { build(:project) }

    context "when HTTPS pages are disabled" do
      it { is_expected.not_to be_pages_https_only }
    end

    context "when HTTPS pages are enabled", :https_pages_enabled do
      it { is_expected.to be_pages_https_only }
    end
  end

  describe "#pages_https_only? validation", :https_pages_enabled do
    subject(:project) do
      # set-up dirty object:
      create(:project, pages_https_only: false).tap do |p|
        p.pages_https_only = true
      end
    end

    context "when no domains are associated" do
      it { is_expected.to be_valid }
    end

    context "when domains including keys and certificates are associated" do
      before do
        allow(project)
          .to receive(:pages_domains)
          .and_return([instance_double(PagesDomain, https?: true)])
      end

      it { is_expected.to be_valid }
    end

    context "when domains including no keys or certificates are associated" do
      before do
        allow(project)
          .to receive(:pages_domains)
          .and_return([instance_double(PagesDomain, https?: false)])
      end

      it { is_expected.not_to be_valid }
    end
  end
G
gitlabhq 已提交
3588
end