project_spec.rb 98.0 KB
Newer Older
G
gitlabhq 已提交
1 2
require 'spec_helper'

3
describe Project do
4
  describe 'associations' do
5 6 7 8
    it { is_expected.to belong_to(:group) }
    it { is_expected.to belong_to(:namespace) }
    it { is_expected.to belong_to(:creator).class_name('User') }
    it { is_expected.to have_many(:users) }
U
ubudzisz 已提交
9
    it { is_expected.to have_many(:services) }
10 11 12 13 14
    it { is_expected.to have_many(:events) }
    it { is_expected.to have_many(:merge_requests) }
    it { is_expected.to have_many(:issues) }
    it { is_expected.to have_many(:milestones) }
    it { is_expected.to have_many(:project_members).dependent(:delete_all) }
15
    it { is_expected.to have_many(:users).through(:project_members) }
16 17 18 19
    it { is_expected.to have_many(:requesters).dependent(:delete_all) }
    it { is_expected.to have_many(:notes) }
    it { is_expected.to have_many(:snippets).class_name('ProjectSnippet') }
    it { is_expected.to have_many(:deploy_keys_projects) }
20
    it { is_expected.to have_many(:deploy_keys) }
21 22 23 24 25 26
    it { is_expected.to have_many(:hooks) }
    it { is_expected.to have_many(:protected_branches) }
    it { is_expected.to have_one(:forked_project_link) }
    it { is_expected.to have_one(:slack_service) }
    it { is_expected.to have_one(:microsoft_teams_service) }
    it { is_expected.to have_one(:mattermost_service) }
M
Matt Coleman 已提交
27
    it { is_expected.to have_one(:packagist_service) }
28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54
    it { is_expected.to have_one(:pushover_service) }
    it { is_expected.to have_one(:asana_service) }
    it { is_expected.to have_many(:boards) }
    it { is_expected.to have_one(:campfire_service) }
    it { is_expected.to have_one(:drone_ci_service) }
    it { is_expected.to have_one(:emails_on_push_service) }
    it { is_expected.to have_one(:pipelines_email_service) }
    it { is_expected.to have_one(:irker_service) }
    it { is_expected.to have_one(:pivotaltracker_service) }
    it { is_expected.to have_one(:hipchat_service) }
    it { is_expected.to have_one(:flowdock_service) }
    it { is_expected.to have_one(:assembla_service) }
    it { is_expected.to have_one(:slack_slash_commands_service) }
    it { is_expected.to have_one(:mattermost_slash_commands_service) }
    it { is_expected.to have_one(:gemnasium_service) }
    it { is_expected.to have_one(:buildkite_service) }
    it { is_expected.to have_one(:bamboo_service) }
    it { is_expected.to have_one(:teamcity_service) }
    it { is_expected.to have_one(:jira_service) }
    it { is_expected.to have_one(:redmine_service) }
    it { is_expected.to have_one(:custom_issue_tracker_service) }
    it { is_expected.to have_one(:bugzilla_service) }
    it { is_expected.to have_one(:gitlab_issue_tracker_service) }
    it { is_expected.to have_one(:external_wiki_service) }
    it { is_expected.to have_one(:project_feature) }
    it { is_expected.to have_one(:statistics).class_name('ProjectStatistics') }
    it { is_expected.to have_one(:import_data).class_name('ProjectImportData') }
U
ubudzisz 已提交
55 56
    it { is_expected.to have_one(:last_event).class_name('Event') }
    it { is_expected.to have_one(:forked_from_project).through(:forked_project_link) }
Z
Zeger-Jan van de Weg 已提交
57
    it { is_expected.to have_one(:auto_devops).class_name('ProjectAutoDevops') }
K
Kamil Trzcinski 已提交
58
    it { is_expected.to have_many(:commit_statuses) }
59
    it { is_expected.to have_many(:pipelines) }
60
    it { is_expected.to have_many(:builds) }
61
    it { is_expected.to have_many(:build_trace_section_names)}
62 63
    it { is_expected.to have_many(:runner_projects) }
    it { is_expected.to have_many(:runners) }
K
Kamil Trzcinski 已提交
64
    it { is_expected.to have_many(:active_runners) }
65 66
    it { is_expected.to have_many(:variables) }
    it { is_expected.to have_many(:triggers) }
K
Kamil Trzcinski 已提交
67
    it { is_expected.to have_many(:pages_domains) }
68 69 70 71 72 73 74 75 76
    it { is_expected.to have_many(:labels).class_name('ProjectLabel') }
    it { is_expected.to have_many(:users_star_projects) }
    it { is_expected.to have_many(:environments) }
    it { is_expected.to have_many(:deployments) }
    it { is_expected.to have_many(:todos) }
    it { is_expected.to have_many(:releases) }
    it { is_expected.to have_many(:lfs_objects_projects) }
    it { is_expected.to have_many(:project_group_links) }
    it { is_expected.to have_many(:notification_settings).dependent(:delete_all) }
U
ubudzisz 已提交
77
    it { is_expected.to have_many(:forks).through(:forked_project_links) }
78
    it { is_expected.to have_many(:uploads).dependent(:destroy) }
79
    it { is_expected.to have_many(:pipeline_schedules) }
80
    it { is_expected.to have_many(:members_and_requesters) }
M
Matija Čupić 已提交
81
    it { is_expected.to have_many(:clusters) }
82
    it { is_expected.to have_many(:custom_attributes).class_name('ProjectCustomAttribute') }
83

F
Felipe Artur 已提交
84 85
    context 'after initialized' do
      it "has a project_feature" do
86
        expect(described_class.new.project_feature).to be_present
87 88 89
      end
    end

90
    describe '#members & #requesters' do
91
      let(:project) { create(:project, :public, :access_requestable) }
92 93 94 95
      let(:requester) { create(:user) }
      let(:developer) { create(:user) }
      before do
        project.request_access(requester)
96
        project.add_developer(developer)
97 98
      end

99 100
      it_behaves_like 'members and requesters associations' do
        let(:namespace) { project }
101 102
      end
    end
103 104 105 106 107

    describe '#boards' do
      it 'raises an error when attempting to add more than one board to the project' do
        subject.boards.build

108
        expect { subject.boards.build }.to raise_error(Project::BoardLimitExceeded, 'Number of permitted boards exceeded')
109 110 111
        expect(subject.boards.size).to eq 1
      end
    end
G
gitlabhq 已提交
112 113
  end

114 115 116 117 118 119
  describe 'modules' do
    subject { described_class }

    it { is_expected.to include_module(Gitlab::ConfigHelper) }
    it { is_expected.to include_module(Gitlab::ShellAdapter) }
    it { is_expected.to include_module(Gitlab::VisibilityLevel) }
120
    it { is_expected.to include_module(Gitlab::CurrentSettings) }
121 122
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
123 124
  end

125
  describe 'validation' do
126
    let!(:project) { create(:project) }
127

128 129
    it { is_expected.to validate_presence_of(:name) }
    it { is_expected.to validate_uniqueness_of(:name).scoped_to(:namespace_id) }
130
    it { is_expected.to validate_length_of(:name).is_at_most(255) }
131

132 133
    it { is_expected.to validate_presence_of(:path) }
    it { is_expected.to validate_uniqueness_of(:path).scoped_to(:namespace_id) }
134 135 136 137
    it { is_expected.to validate_length_of(:path).is_at_most(255) }

    it { is_expected.to validate_length_of(:description).is_at_most(2000) }

138 139 140
    it { is_expected.to validate_length_of(:ci_config_path).is_at_most(255) }
    it { is_expected.to allow_value('').for(:ci_config_path) }
    it { is_expected.not_to allow_value('test/../foo').for(:ci_config_path) }
141
    it { is_expected.not_to allow_value('/test/foo').for(:ci_config_path) }
142

143
    it { is_expected.to validate_presence_of(:creator) }
144

145
    it { is_expected.to validate_presence_of(:namespace) }
146

147
    it { is_expected.to validate_presence_of(:repository_storage) }
148

149
    it 'does not allow new projects beyond user limits' do
150
      project2 = build(:project)
151 152
      allow(project2).to receive(:creator).and_return(double(can_create_project?: false, projects_limit: 0).as_null_object)
      expect(project2).not_to be_valid
P
Phil Hughes 已提交
153
      expect(project2.errors[:limit_reached].first).to match(/Personal project creation is not allowed/)
154
    end
155 156 157

    describe 'wiki path conflict' do
      context "when the new path has been used by the wiki of other Project" do
158
        it 'has an error on the name attribute' do
159
          new_project = build_stubbed(:project, namespace_id: project.namespace_id, path: "#{project.path}.wiki")
160 161 162 163 164 165 166

          expect(new_project).not_to be_valid
          expect(new_project.errors[:name].first).to eq('has already been taken')
        end
      end

      context "when the new wiki path has been used by the path of other Project" do
167
        it 'has an error on the name attribute' do
168 169
          project_with_wiki_suffix = create(:project, path: 'foo.wiki')
          new_project = build_stubbed(:project, namespace_id: project_with_wiki_suffix.namespace_id, path: 'foo')
170 171 172 173 174 175

          expect(new_project).not_to be_valid
          expect(new_project.errors[:name].first).to eq('has already been taken')
        end
      end
    end
176

177
    context 'repository storages inclusion' do
178
      let(:project2) { build(:project, repository_storage: 'missing') }
179 180

      before do
181
        storages = { 'custom' => { 'path' => 'tmp/tests/custom_repositories' } }
182 183 184
        allow(Gitlab.config.repositories).to receive(:storages).and_return(storages)
      end

185
      it "does not allow repository storages that don't match a label in the configuration" do
186 187 188 189
        expect(project2).not_to be_valid
        expect(project2.errors[:repository_storage].first).to match(/is not included in the list/)
      end
    end
190

191
    it 'does not allow an invalid URI as import_url' do
192
      project2 = build(:project, import_url: 'invalid://')
J
James Lopez 已提交
193 194 195 196

      expect(project2).not_to be_valid
    end

197
    it 'does allow a valid URI as import_url' do
198
      project2 = build(:project, import_url: 'ssh://test@gitlab.com/project.git')
J
James Lopez 已提交
199

200 201
      expect(project2).to be_valid
    end
202

203
    it 'allows an empty URI' do
204
      project2 = build(:project, import_url: '')
205

206
      expect(project2).to be_valid
207 208 209
    end

    it 'does not produce import data on an empty URI' do
210
      project2 = build(:project, import_url: '')
211 212 213 214 215

      expect(project2.import_data).to be_nil
    end

    it 'does not produce import data on an invalid URI' do
216
      project2 = build(:project, import_url: 'test://')
217 218 219

      expect(project2.import_data).to be_nil
    end
220

D
Douwe Maan 已提交
221
    it "does not allow blocked import_url localhost" do
222
      project2 = build(:project, import_url: 'http://localhost:9000/t.git')
D
Douwe Maan 已提交
223 224 225 226 227 228

      expect(project2).to be_invalid
      expect(project2.errors[:import_url]).to include('imports are not allowed from that URL')
    end

    it "does not allow blocked import_url port" do
229
      project2 = build(:project, import_url: 'http://github.com:25/t.git')
D
Douwe Maan 已提交
230 231 232 233 234

      expect(project2).to be_invalid
      expect(project2.errors[:import_url]).to include('imports are not allowed from that URL')
    end

235 236
    describe 'project pending deletion' do
      let!(:project_pending_deletion) do
237
        create(:project,
238 239 240
               pending_delete: true)
      end
      let(:new_project) do
241
        build(:project,
242 243 244 245 246 247 248 249 250 251 252 253
              name: project_pending_deletion.name,
              namespace: project_pending_deletion.namespace)
      end

      before do
        new_project.validate
      end

      it 'contains errors related to the project being deleted' do
        expect(new_project.errors.full_messages.first).to eq('The project is still being deleted. Please try again later.')
      end
    end
254 255 256

    describe 'path validation' do
      it 'allows paths reserved on the root namespace' do
257
        project = build(:project, path: 'api')
258 259 260 261 262

        expect(project).to be_valid
      end

      it 'rejects paths reserved on another level' do
263
        project = build(:project, path: 'tree')
264 265 266

        expect(project).not_to be_valid
      end
267 268 269

      it 'rejects nested paths' do
        parent = create(:group, :nested, path: 'environments')
270
        project = build(:project, path: 'folders', namespace: parent)
271 272 273

        expect(project).not_to be_valid
      end
274 275 276

      it 'allows a reserved group name' do
        parent = create(:group)
277
        project = build(:project, path: 'avatar', namespace: parent)
278 279 280

        expect(project).to be_valid
      end
281 282 283 284 285 286

      it 'allows a path ending in a period' do
        project = build(:project, path: 'foo.')

        expect(project).to be_valid
      end
287
    end
G
gitlabhq 已提交
288
  end
289

K
Kamil Trzcinski 已提交
290
  describe 'project token' do
291
    it 'sets an random token if none provided' do
292
      project = FactoryBot.create :project, runners_token: ''
K
Kamil Trzcinski 已提交
293
      expect(project.runners_token).not_to eq('')
K
Kamil Trzcinski 已提交
294 295
    end

U
ubudzisz 已提交
296
    it 'does not set an random token if one provided' do
297
      project = FactoryBot.create :project, runners_token: 'my-token'
K
Kamil Trzcinski 已提交
298
      expect(project.runners_token).to eq('my-token')
K
Kamil Trzcinski 已提交
299 300
    end
  end
G
gitlabhq 已提交
301

302
  describe 'Respond to' do
303 304 305 306 307
    it { is_expected.to respond_to(:url_to_repo) }
    it { is_expected.to respond_to(:repo_exists?) }
    it { is_expected.to respond_to(:execute_hooks) }
    it { is_expected.to respond_to(:owner) }
    it { is_expected.to respond_to(:path_with_namespace) }
308
    it { is_expected.to respond_to(:full_path) }
G
gitlabhq 已提交
309 310
  end

311
  describe 'delegation' do
312 313 314 315 316 317
    [:add_guest, :add_reporter, :add_developer, :add_master, :add_user, :add_users].each do |method|
      it { is_expected.to delegate_method(method).to(:team) }
    end

    it { is_expected.to delegate_method(:members).to(:team).with_prefix(true) }
    it { is_expected.to delegate_method(:name).to(:owner).with_prefix(true).with_arguments(allow_nil: true) }
318 319
  end

320
  describe '#to_reference' do
321
    let(:owner)     { create(:user, name: 'Gitlab') }
322
    let(:namespace) { create(:namespace, path: 'sample-namespace', owner: owner) }
323
    let(:project)   { create(:project, path: 'sample-project', namespace: namespace) }
324
    let(:group)     { create(:group, name: 'Group', path: 'sample-group', owner: owner) }
325

326
    context 'when nil argument' do
327 328 329 330 331
      it 'returns nil' do
        expect(project.to_reference).to be_nil
      end
    end

332
    context 'when full is true' do
333
      it 'returns complete path to the project' do
334 335 336
        expect(project.to_reference(full: true)).to          eq 'sample-namespace/sample-project'
        expect(project.to_reference(project, full: true)).to eq 'sample-namespace/sample-project'
        expect(project.to_reference(group, full: true)).to   eq 'sample-namespace/sample-project'
337 338 339 340 341 342 343 344 345 346
      end
    end

    context 'when same project argument' do
      it 'returns nil' do
        expect(project.to_reference(project)).to be_nil
      end
    end

    context 'when cross namespace project argument' do
347
      let(:another_namespace_project) { create(:project, name: 'another-project') }
348 349 350 351 352 353 354

      it 'returns complete path to the project' do
        expect(project.to_reference(another_namespace_project)).to eq 'sample-namespace/sample-project'
      end
    end

    context 'when same namespace / cross-project argument' do
355
      let(:another_project) { create(:project, namespace: namespace) }
356

357
      it 'returns path to the project' do
358 359 360
        expect(project.to_reference(another_project)).to eq 'sample-project'
      end
    end
361

362 363
    context 'when different namespace / cross-project argument' do
      let(:another_namespace) { create(:namespace, path: 'another-namespace', owner: owner) }
364
      let(:another_project)   { create(:project, path: 'another-project', namespace: another_namespace) }
365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381

      it 'returns full path to the project' do
        expect(project.to_reference(another_project)).to eq 'sample-namespace/sample-project'
      end
    end

    context 'when argument is a namespace' do
      context 'with same project path' do
        it 'returns path to the project' do
          expect(project.to_reference(namespace)).to eq 'sample-project'
        end
      end

      context 'with different project path' do
        it 'returns full path to the project' do
          expect(project.to_reference(group)).to eq 'sample-namespace/sample-project'
        end
382 383
      end
    end
384 385 386 387 388
  end

  describe '#to_human_reference' do
    let(:owner) { create(:user, name: 'Gitlab') }
    let(:namespace) { create(:namespace, name: 'Sample namespace', owner: owner) }
389
    let(:project) { create(:project, name: 'Sample project', namespace: namespace) }
390 391 392 393 394 395 396 397 398 399 400 401 402 403

    context 'when nil argument' do
      it 'returns nil' do
        expect(project.to_human_reference).to be_nil
      end
    end

    context 'when same project argument' do
      it 'returns nil' do
        expect(project.to_human_reference(project)).to be_nil
      end
    end

    context 'when cross namespace project argument' do
404
      let(:another_namespace_project) { create(:project, name: 'another-project') }
405 406 407 408 409 410 411

      it 'returns complete name with namespace of the project' do
        expect(project.to_human_reference(another_namespace_project)).to eq 'Gitlab / Sample project'
      end
    end

    context 'when same namespace / cross-project argument' do
412
      let(:another_project) { create(:project, namespace: namespace) }
413 414 415 416

      it 'returns name of the project' do
        expect(project.to_human_reference(another_project)).to eq 'Sample project'
      end
417 418 419
    end
  end

V
Valery Sizov 已提交
420
  describe '#merge_method' do
421 422 423 424 425 426 427
    using RSpec::Parameterized::TableSyntax

    where(:ff, :rebase, :method) do
      true  | true  | :ff
      true  | false | :ff
      false | true  | :rebase_merge
      false | false | :merge
V
Valery Sizov 已提交
428 429
    end

430 431 432 433 434 435
    with_them do
      let(:project) { build(:project, merge_requests_rebase_enabled: rebase, merge_requests_ff_only_enabled: ff) }

      subject { project.merge_method }

      it { is_expected.to eq(method) }
V
Valery Sizov 已提交
436 437 438
    end
  end

439
  describe '#repository_storage_path' do
440
    let(:project) { create(:project) }
441 442

    it 'returns the repository storage path' do
443
      expect(Dir.exist?(project.repository_storage_path)).to be(true)
444 445 446
    end
  end

447
  it 'returns valid url to repo' do
448
    project = described_class.new(path: 'somewhere')
449
    expect(project.url_to_repo).to eq(Gitlab.config.gitlab_shell.ssh_path_prefix + 'somewhere.git')
G
gitlabhq 已提交
450 451
  end

D
Douwe Maan 已提交
452
  describe "#web_url" do
453
    let(:project) { create(:project, path: "somewhere") }
D
Douwe Maan 已提交
454 455

    it 'returns the full web URL for this repo' do
456
      expect(project.web_url).to eq("#{Gitlab.config.gitlab.url}/#{project.namespace.full_path}/somewhere")
D
Douwe Maan 已提交
457
    end
A
Ariejan de Vroom 已提交
458 459
  end

J
Jan Provaznik 已提交
460
  describe "#new_issuable_address" do
461
    let(:project) { create(:project, path: "somewhere") }
462 463
    let(:user) { create(:user) }

464 465 466 467 468 469
    context 'incoming email enabled' do
      before do
        stub_incoming_email_setting(enabled: true, address: "p+%{key}@gl.ab")
      end

      it 'returns the address to create a new issue' do
470
        address = "p+#{project.full_path}+#{user.incoming_email_token}@gl.ab"
471

J
Jan Provaznik 已提交
472 473 474 475 476 477 478
        expect(project.new_issuable_address(user, 'issue')).to eq(address)
      end

      it 'returns the address to create a new merge request' do
        address = "p+#{project.full_path}+merge-request+#{user.incoming_email_token}@gl.ab"

        expect(project.new_issuable_address(user, 'merge_request')).to eq(address)
479 480 481 482 483 484 485
      end
    end

    context 'incoming email disabled' do
      before do
        stub_incoming_email_setting(enabled: false)
      end
486

487
      it 'returns nil' do
J
Jan Provaznik 已提交
488 489 490 491 492
        expect(project.new_issuable_address(user, 'issue')).to be_nil
      end

      it 'returns nil' do
        expect(project.new_issuable_address(user, 'merge_request')).to be_nil
493
      end
494 495 496
    end
  end

497
  describe 'last_activity methods' do
S
Stan Hu 已提交
498 499
    let(:timestamp) { 2.hours.ago }
    # last_activity_at gets set to created_at upon creation
500
    let(:project) { create(:project, created_at: timestamp, updated_at: timestamp) }
G
gitlabhq 已提交
501

502
    describe 'last_activity' do
503
      it 'alias last_activity to last_event' do
504
        last_event = create(:event, :closed, project: project)
505

506
        expect(project.last_activity).to eq(last_event)
507
      end
G
gitlabhq 已提交
508 509
    end

510 511
    describe 'last_activity_date' do
      it 'returns the creation date of the project\'s last event if present' do
512
        new_event = create(:event, :closed, project: project, created_at: Time.now)
513

S
Stan Hu 已提交
514
        project.reload
515
        expect(project.last_activity_at.to_i).to eq(new_event.created_at.to_i)
516
      end
517

518
      it 'returns the project\'s last update date if it has no events' do
519
        expect(project.last_activity_date).to eq(project.updated_at)
520
      end
521 522
    end
  end
523

524
  describe '#get_issue' do
525
    let(:project) { create(:project) }
S
Stan Hu 已提交
526
    let!(:issue)  { create(:issue, project: project) }
527 528 529
    let(:user)    { create(:user) }

    before do
530
      project.add_developer(user)
531
    end
532 533 534

    context 'with default issues tracker' do
      it 'returns an issue' do
535
        expect(project.get_issue(issue.iid, user)).to eq issue
536 537
      end

S
Stan Hu 已提交
538 539 540 541
      it 'returns count of open issues' do
        expect(project.open_issues_count).to eq(1)
      end

542
      it 'returns nil when no issue found' do
543 544 545 546 547 548
        expect(project.get_issue(999, user)).to be_nil
      end

      it "returns nil when user doesn't have access" do
        user = create(:user)
        expect(project.get_issue(issue.iid, user)).to eq nil
549 550 551 552
      end
    end

    context 'with external issues tracker' do
553
      let!(:internal_issue) { create(:issue, project: project) }
554
      before do
555
        allow(project).to receive(:external_issue_tracker).and_return(true)
556 557
      end

558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594
      context 'when internal issues are enabled' do
        it 'returns interlan issue' do
          issue = project.get_issue(internal_issue.iid, user)

          expect(issue).to be_kind_of(Issue)
          expect(issue.iid).to eq(internal_issue.iid)
          expect(issue.project).to eq(project)
        end

        it 'returns an ExternalIssue when internal issue does not exists' do
          issue = project.get_issue('FOO-1234', user)

          expect(issue).to be_kind_of(ExternalIssue)
          expect(issue.iid).to eq('FOO-1234')
          expect(issue.project).to eq(project)
        end
      end

      context 'when internal issues are disabled' do
        before do
          project.issues_enabled = false
          project.save!
        end

        it 'returns always an External issues' do
          issue = project.get_issue(internal_issue.iid, user)
          expect(issue).to be_kind_of(ExternalIssue)
          expect(issue.iid).to eq(internal_issue.iid.to_s)
          expect(issue.project).to eq(project)
        end

        it 'returns an ExternalIssue when internal issue does not exists' do
          issue = project.get_issue('FOO-1234', user)
          expect(issue).to be_kind_of(ExternalIssue)
          expect(issue.iid).to eq('FOO-1234')
          expect(issue.project).to eq(project)
        end
595 596 597 598 599
      end
    end
  end

  describe '#issue_exists?' do
600
    let(:project) { create(:project) }
601 602 603 604 605 606 607 608 609 610 611 612

    it 'is truthy when issue exists' do
      expect(project).to receive(:get_issue).and_return(double)
      expect(project.issue_exists?(1)).to be_truthy
    end

    it 'is falsey when issue does not exist' do
      expect(project).to receive(:get_issue).and_return(nil)
      expect(project.issue_exists?(1)).to be_falsey
    end
  end

L
Lin Jen-Shin 已提交
613
  describe '#to_param' do
614 615 616
    context 'with namespace' do
      before do
        @group = create :group, name: 'gitlab'
617
        @project = create(:project, name: 'gitlabhq', namespace: @group)
618 619
      end

V
Vinnie Okada 已提交
620
      it { expect(@project.to_param).to eq('gitlabhq') }
621
    end
622 623 624

    context 'with invalid path' do
      it 'returns previous path to keep project suitable for use in URLs when persisted' do
625
        project = create(:project, path: 'gitlab')
626 627 628 629 630 631 632
        project.path = 'foo&bar'

        expect(project).not_to be_valid
        expect(project.to_param).to eq 'gitlab'
      end

      it 'returns current path when new record' do
633
        project = build(:project, path: 'gitlab')
634 635 636 637 638 639
        project.path = 'foo&bar'

        expect(project).not_to be_valid
        expect(project.to_param).to eq 'foo&bar'
      end
    end
640
  end
D
Dmitriy Zaporozhets 已提交
641

L
Lin Jen-Shin 已提交
642
  describe '#repository' do
643
    let(:project) { create(:project, :repository) }
D
Dmitriy Zaporozhets 已提交
644

645
    it 'returns valid repo' do
646
      expect(project.repository).to be_kind_of(Repository)
D
Dmitriy Zaporozhets 已提交
647 648
    end
  end
649

L
Lin Jen-Shin 已提交
650
  describe '#default_issues_tracker?' do
651
    it "is true if used internal tracker" do
652
      project = build(:project)
653

654
      expect(project.default_issues_tracker?).to be_truthy
655 656
    end

657
    it "is false if used other tracker" do
658 659 660 661
      # NOTE: The current nature of this factory requires persistence
      project = create(:redmine_project)

      expect(project.default_issues_tracker?).to be_falsey
662 663 664
    end
  end

665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682
  describe '#empty_repo?' do
    context 'when the repo does not exist' do
      let(:project) { build_stubbed(:project) }

      it 'returns true' do
        expect(project.empty_repo?).to be(true)
      end
    end

    context 'when the repo exists' do
      let(:project) { create(:project, :repository) }
      let(:empty_project) { create(:project, :empty_repo) }

      it { expect(empty_project.empty_repo?).to be(true) }
      it { expect(project.empty_repo?).to be(false) }
    end
  end

L
Lin Jen-Shin 已提交
683
  describe '#external_issue_tracker' do
684
    let(:project) { create(:project) }
685 686 687
    let(:ext_project) { create(:redmine_project) }

    context 'on existing projects with no value for has_external_issue_tracker' do
688
      before do
689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717
        project.update_column(:has_external_issue_tracker, nil)
        ext_project.update_column(:has_external_issue_tracker, nil)
      end

      it 'updates the has_external_issue_tracker boolean' do
        expect do
          project.external_issue_tracker
        end.to change { project.reload.has_external_issue_tracker }.to(false)

        expect do
          ext_project.external_issue_tracker
        end.to change { ext_project.reload.has_external_issue_tracker }.to(true)
      end
    end

    it 'returns nil and does not query services when there is no external issue tracker' do
      expect(project).not_to receive(:services)

      expect(project.external_issue_tracker).to eq(nil)
    end

    it 'retrieves external_issue_tracker querying services and cache it when there is external issue tracker' do
      ext_project.reload # Factory returns a project with changed attributes
      expect(ext_project).to receive(:services).once.and_call_original

      2.times { expect(ext_project.external_issue_tracker).to be_a_kind_of(RedmineService) }
    end
  end

L
Lin Jen-Shin 已提交
718
  describe '#cache_has_external_issue_tracker' do
719
    let(:project) { create(:project, has_external_issue_tracker: nil) }
720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737

    it 'stores true if there is any external_issue_tracker' do
      services = double(:service, external_issue_trackers: [RedmineService.new])
      expect(project).to receive(:services).and_return(services)

      expect do
        project.cache_has_external_issue_tracker
      end.to change { project.has_external_issue_tracker}.to(true)
    end

    it 'stores false if there is no external_issue_tracker' do
      services = double(:service, external_issue_trackers: [])
      expect(project).to receive(:services).and_return(services)

      expect do
        project.cache_has_external_issue_tracker
      end.to change { project.has_external_issue_tracker}.to(false)
    end
T
Toon Claes 已提交
738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775

    it 'does not cache data when in a read-only GitLab instance' do
      allow(Gitlab::Database).to receive(:read_only?) { true }

      expect do
        project.cache_has_external_issue_tracker
      end.not_to change { project.has_external_issue_tracker }
    end
  end

  describe '#cache_has_external_wiki' do
    let(:project) { create(:project, has_external_wiki: nil) }

    it 'stores true if there is any external_wikis' do
      services = double(:service, external_wikis: [ExternalWikiService.new])
      expect(project).to receive(:services).and_return(services)

      expect do
        project.cache_has_external_wiki
      end.to change { project.has_external_wiki}.to(true)
    end

    it 'stores false if there is no external_wikis' do
      services = double(:service, external_wikis: [])
      expect(project).to receive(:services).and_return(services)

      expect do
        project.cache_has_external_wiki
      end.to change { project.has_external_wiki}.to(false)
    end

    it 'does not cache data when in a read-only GitLab instance' do
      allow(Gitlab::Database).to receive(:read_only?) { true }

      expect do
        project.cache_has_external_wiki
      end.not_to change { project.has_external_wiki }
    end
776 777
  end

778
  describe '#has_wiki?' do
779 780 781
    let(:no_wiki_project)       { create(:project, :wiki_disabled, has_external_wiki: false) }
    let(:wiki_enabled_project)  { create(:project) }
    let(:external_wiki_project) { create(:project, has_external_wiki: true) }
782 783 784 785 786 787 788 789

    it 'returns true if project is wiki enabled or has external wiki' do
      expect(wiki_enabled_project).to have_wiki
      expect(external_wiki_project).to have_wiki
      expect(no_wiki_project).not_to have_wiki
    end
  end

790
  describe '#external_wiki' do
791
    let(:project) { create(:project) }
792

793 794 795 796 797
    context 'with an active external wiki' do
      before do
        create(:service, project: project, type: 'ExternalWikiService', active: true)
        project.external_wiki
      end
798

799 800 801
      it 'sets :has_external_wiki as true' do
        expect(project.has_external_wiki).to be(true)
      end
802

803 804
      it 'sets :has_external_wiki as false if an external wiki service is destroyed later' do
        expect(project.has_external_wiki).to be(true)
805

806 807 808 809
        project.services.external_wikis.first.destroy

        expect(project.has_external_wiki).to be(false)
      end
810 811
    end

812 813 814 815
    context 'with an inactive external wiki' do
      before do
        create(:service, project: project, type: 'ExternalWikiService', active: false)
      end
816

817 818 819
      it 'sets :has_external_wiki as false' do
        expect(project.has_external_wiki).to be(false)
      end
820 821
    end

822 823 824 825
    context 'with no external wiki' do
      before do
        project.external_wiki
      end
826

827 828 829 830 831 832 833 834 835 836 837
      it 'sets :has_external_wiki as false' do
        expect(project.has_external_wiki).to be(false)
      end

      it 'sets :has_external_wiki as true if an external wiki service is created later' do
        expect(project.has_external_wiki).to be(false)

        create(:service, project: project, type: 'ExternalWikiService', active: true)

        expect(project.has_external_wiki).to be(true)
      end
838 839 840
    end
  end

841 842
  describe '#star_count' do
    it 'counts stars from multiple users' do
C
Ciro Santilli 已提交
843 844
      user1 = create :user
      user2 = create :user
845
      project = create(:project, :public)
C
Ciro Santilli 已提交
846 847

      expect(project.star_count).to eq(0)
848

C
Ciro Santilli 已提交
849
      user1.toggle_star(project)
850 851
      expect(project.reload.star_count).to eq(1)

C
Ciro Santilli 已提交
852
      user2.toggle_star(project)
853 854 855
      project.reload
      expect(project.reload.star_count).to eq(2)

C
Ciro Santilli 已提交
856
      user1.toggle_star(project)
857 858 859
      project.reload
      expect(project.reload.star_count).to eq(1)

C
Ciro Santilli 已提交
860
      user2.toggle_star(project)
861 862 863 864
      project.reload
      expect(project.reload.star_count).to eq(0)
    end

865
    it 'counts stars on the right project' do
866
      user = create :user
867 868
      project1 = create(:project, :public)
      project2 = create(:project, :public)
869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895

      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project1)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(1)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project1)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project2)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(1)

      user.toggle_star(project2)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)
C
Ciro Santilli 已提交
896 897
    end
  end
898

L
Lin Jen-Shin 已提交
899
  describe '#avatar_type' do
900
    let(:project) { create(:project) }
901

902
    it 'is true if avatar is image' do
903
      project.update_attribute(:avatar, 'uploads/avatar.png')
904
      expect(project.avatar_type).to be_truthy
905 906
    end

907
    it 'is false if avatar is html page' do
908
      project.update_attribute(:avatar, 'uploads/avatar.html')
909
      expect(project.avatar_type).to eq(['only images allowed'])
910 911
    end
  end
S
sue445 已提交
912

L
Lin Jen-Shin 已提交
913
  describe '#avatar_url' do
S
sue445 已提交
914 915
    subject { project.avatar_url }

916
    let(:project) { create(:project) }
S
sue445 已提交
917

918
    context 'when avatar file is uploaded' do
T
Tim Zallmann 已提交
919
      let(:project) { create(:project, :public, :with_avatar) }
S
sue445 已提交
920

921
      it 'shows correct url' do
922 923
        expect(project.avatar_url).to eq(project.avatar.url)
        expect(project.avatar_url(only_path: false)).to eq([Gitlab.config.gitlab.url, project.avatar.url].join)
924
      end
S
sue445 已提交
925 926
    end

927
    context 'when avatar file in git' do
S
sue445 已提交
928 929 930 931
      before do
        allow(project).to receive(:avatar_in_git) { true }
      end

932
      let(:avatar_path) { "/#{project.full_path}/avatar" }
S
sue445 已提交
933

934
      it { is_expected.to eq "http://#{Gitlab.config.gitlab.host}#{avatar_path}" }
S
sue445 已提交
935
    end
936 937

    context 'when git repo is empty' do
938
      let(:project) { create(:project) }
939

940
      it { is_expected.to eq nil }
941
    end
S
sue445 已提交
942
  end
943

944
  describe '#pipeline_for' do
945
    let(:project) { create(:project, :repository) }
946
    let!(:pipeline) { create_pipeline }
K
Kamil Trzcinski 已提交
947

948 949
    shared_examples 'giving the correct pipeline' do
      it { is_expected.to eq(pipeline) }
K
Kamil Trzcinski 已提交
950

951 952
      context 'return latest' do
        let!(:pipeline2) { create_pipeline }
K
Kamil Trzcinski 已提交
953

954
        it { is_expected.to eq(pipeline2) }
K
Kamil Trzcinski 已提交
955
      end
956 957 958 959 960 961 962 963 964 965 966 967 968
    end

    context 'with explicit sha' do
      subject { project.pipeline_for('master', pipeline.sha) }

      it_behaves_like 'giving the correct pipeline'
    end

    context 'with implicit sha' do
      subject { project.pipeline_for('master') }

      it_behaves_like 'giving the correct pipeline'
    end
K
Kamil Trzcinski 已提交
969

970 971 972 973 974
    def create_pipeline
      create(:ci_pipeline,
             project: project,
             ref: 'master',
             sha: project.commit('master').sha)
K
Kamil Trzcinski 已提交
975
    end
976
  end
977

L
Lin Jen-Shin 已提交
978
  describe '#builds_enabled' do
979
    let(:project) { create(:project) }
980

981 982 983
    subject { project.builds_enabled }

    it { expect(project.builds_enabled?).to be_truthy }
984
  end
Y
Yorick Peterse 已提交
985

986
  describe '.with_shared_runners' do
987
    subject { described_class.with_shared_runners }
988 989

    context 'when shared runners are enabled for project' do
990
      let!(:project) { create(:project, shared_runners_enabled: true) }
991 992 993 994 995 996 997

      it "returns a project" do
        is_expected.to eq([project])
      end
    end

    context 'when shared runners are disabled for project' do
998
      let!(:project) { create(:project, shared_runners_enabled: false) }
999 1000 1001 1002 1003 1004 1005

      it "returns an empty array" do
        is_expected.to be_empty
      end
    end
  end

1006
  describe '.cached_count', :use_clean_rails_memory_store_caching do
1007
    let(:group)     { create(:group, :public) }
1008 1009
    let!(:project1) { create(:project, :public, group: group) }
    let!(:project2) { create(:project, :public, group: group) }
1010 1011

    it 'returns total project count' do
1012
      expect(described_class).to receive(:count).once.and_call_original
1013 1014

      3.times do
1015
        expect(described_class.cached_count).to eq(2)
1016 1017 1018 1019
      end
    end
  end

Y
Yorick Peterse 已提交
1020
  describe '.trending' do
F
Felipe Artur 已提交
1021
    let(:group)    { create(:group, :public) }
1022 1023
    let(:project1) { create(:project, :public, group: group) }
    let(:project2) { create(:project, :public, group: group) }
Y
Yorick Peterse 已提交
1024 1025 1026 1027 1028 1029 1030 1031

    before do
      2.times do
        create(:note_on_commit, project: project1)
      end

      create(:note_on_commit, project: project2)

Y
Yorick Peterse 已提交
1032
      TrendingProject.refresh!
Y
Yorick Peterse 已提交
1033 1034
    end

Y
Yorick Peterse 已提交
1035
    subject { described_class.trending.to_a }
Y
Yorick Peterse 已提交
1036

Y
Yorick Peterse 已提交
1037 1038
    it 'sorts projects by the amount of notes in descending order' do
      expect(subject).to eq([project1, project2])
Y
Yorick Peterse 已提交
1039
    end
1040 1041 1042 1043 1044 1045 1046 1047

    it 'does not take system notes into account' do
      10.times do
        create(:note_on_commit, project: project2, system: true)
      end

      expect(described_class.trending.to_a).to eq([project1, project2])
    end
Y
Yorick Peterse 已提交
1048
  end
Y
Yorick Peterse 已提交
1049

T
Toon Claes 已提交
1050 1051 1052 1053
  describe '.starred_by' do
    it 'returns only projects starred by the given user' do
      user1 = create(:user)
      user2 = create(:user)
1054 1055 1056
      project1 = create(:project)
      project2 = create(:project)
      create(:project)
T
Toon Claes 已提交
1057 1058 1059
      user1.toggle_star(project1)
      user2.toggle_star(project2)

1060
      expect(described_class.starred_by(user1)).to contain_exactly(project1)
T
Toon Claes 已提交
1061 1062 1063
    end
  end

Y
Yorick Peterse 已提交
1064
  describe '.visible_to_user' do
1065
    let!(:project) { create(:project, :private) }
Y
Yorick Peterse 已提交
1066 1067 1068 1069 1070 1071
    let!(:user)    { create(:user) }

    subject { described_class.visible_to_user(user) }

    describe 'when a user has access to a project' do
      before do
1072
        project.add_user(user, Gitlab::Access::MASTER)
Y
Yorick Peterse 已提交
1073 1074 1075 1076 1077 1078 1079 1080 1081
      end

      it { is_expected.to eq([project]) }
    end

    describe 'when a user does not have access to any projects' do
      it { is_expected.to eq([]) }
    end
  end
K
Kamil Trzcinski 已提交
1082

1083
  context 'repository storage by default' do
1084
    let(:project) { create(:project) }
1085 1086

    before do
1087
      storages = {
1088
        'default' => { 'path' => 'tmp/tests/repositories' },
1089
        'picked'  => { 'path' => 'tmp/tests/repositories' }
1090
      }
1091 1092 1093
      allow(Gitlab.config.repositories).to receive(:storages).and_return(storages)
    end

1094 1095 1096 1097 1098
    it 'picks storage from ApplicationSetting' do
      expect_any_instance_of(ApplicationSetting).to receive(:pick_repository_storage).and_return('picked')

      expect(project.repository_storage).to eq('picked')
    end
1099 1100
  end

K
Kamil Trzcinski 已提交
1101
  context 'shared runners by default' do
1102
    let(:project) { create(:project) }
K
Kamil Trzcinski 已提交
1103 1104 1105 1106

    subject { project.shared_runners_enabled }

    context 'are enabled' do
1107 1108 1109
      before do
        stub_application_setting(shared_runners_enabled: true)
      end
K
Kamil Trzcinski 已提交
1110 1111 1112 1113 1114

      it { is_expected.to be_truthy }
    end

    context 'are disabled' do
1115 1116 1117
      before do
        stub_application_setting(shared_runners_enabled: false)
      end
K
Kamil Trzcinski 已提交
1118 1119 1120 1121 1122

      it { is_expected.to be_falsey }
    end
  end

L
Lin Jen-Shin 已提交
1123
  describe '#any_runners' do
1124
    let(:project) { create(:project, shared_runners_enabled: shared_runners_enabled) }
1125 1126
    let(:specific_runner) { create(:ci_runner) }
    let(:shared_runner) { create(:ci_runner, :shared) }
K
Kamil Trzcinski 已提交
1127 1128 1129

    context 'for shared runners disabled' do
      let(:shared_runners_enabled) { false }
1130

1131
      it 'has no runners available' do
K
Kamil Trzcinski 已提交
1132 1133
        expect(project.any_runners?).to be_falsey
      end
1134

1135
      it 'has a specific runner' do
1136
        project.runners << specific_runner
K
Kamil Trzcinski 已提交
1137 1138
        expect(project.any_runners?).to be_truthy
      end
1139

1140
      it 'has a shared runner, but they are prohibited to use' do
K
Kamil Trzcinski 已提交
1141 1142 1143
        shared_runner
        expect(project.any_runners?).to be_falsey
      end
1144

K
Kamil Trzcinski 已提交
1145
      it 'checks the presence of specific runner' do
1146
        project.runners << specific_runner
K
Kamil Trzcinski 已提交
1147 1148 1149
        expect(project.any_runners? { |runner| runner == specific_runner }).to be_truthy
      end
    end
1150

K
Kamil Trzcinski 已提交
1151 1152
    context 'for shared runners enabled' do
      let(:shared_runners_enabled) { true }
1153

1154
      it 'has a shared runner' do
K
Kamil Trzcinski 已提交
1155 1156 1157 1158 1159 1160 1161 1162 1163 1164
        shared_runner
        expect(project.any_runners?).to be_truthy
      end

      it 'checks the presence of shared runner' do
        shared_runner
        expect(project.any_runners? { |runner| runner == shared_runner }).to be_truthy
      end
    end
  end
1165

1166 1167 1168 1169 1170 1171
  describe '#shared_runners' do
    let!(:runner) { create(:ci_runner, :shared) }

    subject { project.shared_runners }

    context 'when shared runners are enabled for project' do
1172
      let!(:project) { create(:project, shared_runners_enabled: true) }
1173 1174 1175 1176 1177 1178 1179

      it "returns a list of shared runners" do
        is_expected.to eq([runner])
      end
    end

    context 'when shared runners are disabled for project' do
1180
      let!(:project) { create(:project, shared_runners_enabled: false) }
1181 1182 1183 1184 1185 1186 1187

      it "returns a empty list" do
        is_expected.to be_empty
      end
    end
  end

1188
  describe '#visibility_level_allowed?' do
1189
    let(:project) { create(:project, :internal) }
1190 1191 1192 1193 1194 1195 1196 1197

    context 'when checking on non-forked project' do
      it { expect(project.visibility_level_allowed?(Gitlab::VisibilityLevel::PRIVATE)).to be_truthy }
      it { expect(project.visibility_level_allowed?(Gitlab::VisibilityLevel::INTERNAL)).to be_truthy }
      it { expect(project.visibility_level_allowed?(Gitlab::VisibilityLevel::PUBLIC)).to be_truthy }
    end

    context 'when checking on forked project' do
1198 1199
      let(:project)        { create(:project, :internal) }
      let(:forked_project) { create(:project, forked_from_project: project) }
1200 1201 1202 1203 1204

      it { expect(forked_project.visibility_level_allowed?(Gitlab::VisibilityLevel::PRIVATE)).to be_truthy }
      it { expect(forked_project.visibility_level_allowed?(Gitlab::VisibilityLevel::INTERNAL)).to be_truthy }
      it { expect(forked_project.visibility_level_allowed?(Gitlab::VisibilityLevel::PUBLIC)).to be_falsey }
    end
1205
  end
1206

1207
  describe '#pages_deployed?' do
1208
    let(:project) { create :project }
1209 1210 1211 1212

    subject { project.pages_deployed? }

    context 'if public folder does exist' do
1213 1214 1215
      before do
        allow(Dir).to receive(:exist?).with(project.public_pages_path).and_return(true)
      end
1216 1217 1218 1219 1220 1221 1222 1223 1224

      it { is_expected.to be_truthy }
    end

    context "if public folder doesn't exist" do
      it { is_expected.to be_falsey }
    end
  end

1225 1226
  describe '#pages_url' do
    let(:group) { create :group, name: group_name }
1227
    let(:project) { create :project, namespace: group, name: project_name }
1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251
    let(:domain) { 'Example.com' }

    subject { project.pages_url }

    before do
      allow(Settings.pages).to receive(:host).and_return(domain)
      allow(Gitlab.config.pages).to receive(:url).and_return('http://example.com')
    end

    context 'group page' do
      let(:group_name) { 'Group' }
      let(:project_name) { 'group.example.com' }

      it { is_expected.to eq("http://group.example.com") }
    end

    context 'project page' do
      let(:group_name) { 'Group' }
      let(:project_name) { 'Project' }

      it { is_expected.to eq("http://group.example.com/project") }
    end
  end

1252
  describe '.search' do
1253
    let(:project) { create(:project, description: 'kitten mittens') }
1254

1255 1256 1257
    it 'returns projects with a matching name' do
      expect(described_class.search(project.name)).to eq([project])
    end
1258

1259 1260 1261
    it 'returns projects with a partially matching name' do
      expect(described_class.search(project.name[0..2])).to eq([project])
    end
1262

1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290
    it 'returns projects with a matching name regardless of the casing' do
      expect(described_class.search(project.name.upcase)).to eq([project])
    end

    it 'returns projects with a matching description' do
      expect(described_class.search(project.description)).to eq([project])
    end

    it 'returns projects with a partially matching description' do
      expect(described_class.search('kitten')).to eq([project])
    end

    it 'returns projects with a matching description regardless of the casing' do
      expect(described_class.search('KITTEN')).to eq([project])
    end

    it 'returns projects with a matching path' do
      expect(described_class.search(project.path)).to eq([project])
    end

    it 'returns projects with a partially matching path' do
      expect(described_class.search(project.path[0..2])).to eq([project])
    end

    it 'returns projects with a matching path regardless of the casing' do
      expect(described_class.search(project.path.upcase)).to eq([project])
    end

1291
    describe 'with pending_delete project' do
1292
      let(:pending_delete_project) { create(:project, pending_delete: true) }
1293 1294 1295 1296 1297 1298 1299

      it 'shows pending deletion project' do
        search_result = described_class.search(pending_delete_project.name)

        expect(search_result).to eq([pending_delete_project])
      end
    end
1300
  end
1301 1302

  describe '#expire_caches_before_rename' do
1303
    let(:project) { create(:project, :repository) }
1304 1305 1306 1307
    let(:repo)    { double(:repo, exists?: true) }
    let(:wiki)    { double(:wiki, exists?: true) }

    it 'expires the caches of the repository and wiki' do
1308 1309 1310
      allow(Repository).to receive(:new)
        .with('foo', project)
        .and_return(repo)
1311

1312 1313 1314
      allow(Repository).to receive(:new)
        .with('foo.wiki', project)
        .and_return(wiki)
1315

1316 1317
      expect(repo).to receive(:before_delete)
      expect(wiki).to receive(:before_delete)
1318 1319 1320 1321

      project.expire_caches_before_rename('foo')
    end
  end
1322 1323

  describe '.search_by_title' do
1324
    let(:project) { create(:project, name: 'kittens') }
1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337

    it 'returns projects with a matching name' do
      expect(described_class.search_by_title(project.name)).to eq([project])
    end

    it 'returns projects with a partially matching name' do
      expect(described_class.search_by_title('kitten')).to eq([project])
    end

    it 'returns projects with a matching name regardless of the casing' do
      expect(described_class.search_by_title('KITTENS')).to eq([project])
    end
  end
1338 1339 1340 1341 1342

  context 'when checking projects from groups' do
    let(:private_group)    { create(:group, visibility_level: 0)  }
    let(:internal_group)   { create(:group, visibility_level: 10) }

1343 1344
    let(:private_project)  { create :project, :private, group: private_group }
    let(:internal_project) { create :project, :internal, group: internal_group }
1345 1346 1347 1348 1349 1350 1351 1352 1353

    context 'when group is private project can not be internal' do
      it { expect(private_project.visibility_level_allowed?(Gitlab::VisibilityLevel::INTERNAL)).to be_falsey }
    end

    context 'when group is internal project can not be public' do
      it { expect(internal_project.visibility_level_allowed?(Gitlab::VisibilityLevel::PUBLIC)).to be_falsey }
    end
  end
1354

1355
  describe '#create_repository' do
1356
    let(:project) { create(:project, :repository) }
1357 1358 1359 1360 1361 1362 1363 1364
    let(:shell) { Gitlab::Shell.new }

    before do
      allow(project).to receive(:gitlab_shell).and_return(shell)
    end

    context 'using a regular repository' do
      it 'creates the repository' do
1365
        expect(shell).to receive(:add_repository)
J
Jacob Vosmaer 已提交
1366
          .with(project.repository_storage, project.disk_path)
1367
          .and_return(true)
1368 1369 1370 1371 1372 1373 1374

        expect(project.repository).to receive(:after_create)

        expect(project.create_repository).to eq(true)
      end

      it 'adds an error if the repository could not be created' do
1375
        expect(shell).to receive(:add_repository)
J
Jacob Vosmaer 已提交
1376
          .with(project.repository_storage, project.disk_path)
1377
          .and_return(false)
1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394

        expect(project.repository).not_to receive(:after_create)

        expect(project.create_repository).to eq(false)
        expect(project.errors).not_to be_empty
      end
    end

    context 'using a forked repository' do
      it 'does nothing' do
        expect(project).to receive(:forked?).and_return(true)
        expect(shell).not_to receive(:add_repository)

        project.create_repository
      end
    end
  end
1395

1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408
  describe '#ensure_repository' do
    let(:project) { create(:project, :repository) }
    let(:shell) { Gitlab::Shell.new }

    before do
      allow(project).to receive(:gitlab_shell).and_return(shell)
    end

    it 'creates the repository if it not exist' do
      allow(project).to receive(:repository_exists?)
        .and_return(false)

      allow(shell).to receive(:add_repository)
1409
        .with(project.repository_storage_path, project.disk_path)
1410 1411
        .and_return(true)

1412
      expect(project).to receive(:create_repository).with(force: true)
1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424

      project.ensure_repository
    end

    it 'does not create the repository if it exists' do
      allow(project).to receive(:repository_exists?)
        .and_return(true)

      expect(project).not_to receive(:create_repository)

      project.ensure_repository
    end
1425 1426 1427 1428 1429 1430 1431 1432

    it 'creates the repository if it is a fork' do
      expect(project).to receive(:forked?).and_return(true)

      allow(project).to receive(:repository_exists?)
        .and_return(false)

      expect(shell).to receive(:add_repository)
J
Jacob Vosmaer 已提交
1433
        .with(project.repository_storage, project.disk_path)
1434 1435 1436 1437
        .and_return(true)

      project.ensure_repository
    end
1438 1439
  end

1440
  describe '#user_can_push_to_empty_repo?' do
1441
    let(:project) { create(:project) }
1442
    let(:user)    { create(:user) }
1443

1444
    it 'returns false when default_branch_protection is in full protection and user is developer' do
1445
      project.add_developer(user)
1446
      stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_FULL)
1447

1448
      expect(project.user_can_push_to_empty_repo?(user)).to be_falsey
1449 1450
    end

1451
    it 'returns false when default_branch_protection only lets devs merge and user is dev' do
1452
      project.add_developer(user)
1453
      stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_DEV_CAN_MERGE)
1454

1455
      expect(project.user_can_push_to_empty_repo?(user)).to be_falsey
1456 1457
    end

1458
    it 'returns true when default_branch_protection lets devs push and user is developer' do
1459
      project.add_developer(user)
1460
      stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_DEV_CAN_PUSH)
1461

1462 1463
      expect(project.user_can_push_to_empty_repo?(user)).to be_truthy
    end
1464

1465
    it 'returns true when default_branch_protection is unprotected and user is developer' do
1466
      project.add_developer(user)
1467
      stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_NONE)
1468

1469
      expect(project.user_can_push_to_empty_repo?(user)).to be_truthy
1470
    end
1471

1472
    it 'returns true when user is master' do
1473
      project.add_master(user)
1474

1475
      expect(project.user_can_push_to_empty_repo?(user)).to be_truthy
1476 1477 1478
    end
  end

A
Andre Guedes 已提交
1479
  describe '#container_registry_url' do
1480
    let(:project) { create(:project) }
K
Kamil Trzcinski 已提交
1481

A
Andre Guedes 已提交
1482
    subject { project.container_registry_url }
K
Kamil Trzcinski 已提交
1483

1484 1485 1486
    before do
      stub_container_registry_config(**registry_settings)
    end
K
Kamil Trzcinski 已提交
1487 1488 1489

    context 'for enabled registry' do
      let(:registry_settings) do
1490 1491
        { enabled: true,
          host_port: 'example.com' }
K
Kamil Trzcinski 已提交
1492 1493
      end

1494
      it { is_expected.not_to be_nil }
K
Kamil Trzcinski 已提交
1495 1496 1497 1498
    end

    context 'for disabled registry' do
      let(:registry_settings) do
1499
        { enabled: false }
K
Kamil Trzcinski 已提交
1500 1501 1502 1503 1504 1505
      end

      it { is_expected.to be_nil }
    end
  end

1506
  describe '#has_container_registry_tags?' do
1507
    let(:project) { create(:project) }
1508 1509

    context 'when container registry is enabled' do
1510 1511 1512
      before do
        stub_container_registry_config(enabled: true)
      end
1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549

      context 'when tags are present for multi-level registries' do
        before do
          create(:container_repository, project: project, name: 'image')

          stub_container_registry_tags(repository: /image/,
                                       tags: %w[latest rc1])
        end

        it 'should have image tags' do
          expect(project).to have_container_registry_tags
        end
      end

      context 'when tags are present for root repository' do
        before do
          stub_container_registry_tags(repository: project.full_path,
                                       tags: %w[latest rc1 pre1])
        end

        it 'should have image tags' do
          expect(project).to have_container_registry_tags
        end
      end

      context 'when there are no tags at all' do
        before do
          stub_container_registry_tags(repository: :any, tags: [])
        end

        it 'should not have image tags' do
          expect(project).not_to have_container_registry_tags
        end
      end
    end

    context 'when container registry is disabled' do
1550 1551 1552
      before do
        stub_container_registry_config(enabled: false)
      end
1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569

      it 'should not have image tags' do
        expect(project).not_to have_container_registry_tags
      end

      it 'should not check root repository tags' do
        expect(project).not_to receive(:full_path)
        expect(project).not_to have_container_registry_tags
      end

      it 'should iterate through container repositories' do
        expect(project).to receive(:container_repositories)
        expect(project).not_to have_container_registry_tags
      end
    end
  end

1570
  describe '#ci_config_path=' do
1571
    let(:project) { create(:project) }
1572 1573

    it 'sets nil' do
1574
      project.update!(ci_config_path: nil)
1575

1576
      expect(project.ci_config_path).to be_nil
1577 1578 1579
    end

    it 'sets a string' do
1580
      project.update!(ci_config_path: 'foo/.gitlab_ci.yml')
1581

1582
      expect(project.ci_config_path).to eq('foo/.gitlab_ci.yml')
1583 1584
    end

1585 1586
    it 'sets a string but removes all null characters' do
      project.update!(ci_config_path: "f\0oo/\0/.gitlab_ci.yml")
1587

1588
      expect(project.ci_config_path).to eq('foo//.gitlab_ci.yml')
1589 1590 1591
    end
  end

1592
  describe 'Project import job' do
1593
    let(:project) { create(:project, import_url: generate(:url)) }
1594 1595

    before do
S
Stan Hu 已提交
1596
      allow_any_instance_of(Gitlab::Shell).to receive(:import_repository)
1597
        .with(project.repository_storage_path, project.disk_path, project.import_url)
S
Stan Hu 已提交
1598 1599 1600 1601
        .and_return(true)

      expect_any_instance_of(Repository).to receive(:after_import)
        .and_call_original
1602 1603 1604 1605 1606
    end

    it 'imports a project' do
      expect_any_instance_of(RepositoryImportWorker).to receive(:perform).and_call_original

1607
      expect { project.import_schedule }.to change { project.import_jid }
1608 1609 1610 1611
      expect(project.reload.import_status).to eq('finished')
    end
  end

1612 1613
  describe 'project import state transitions' do
    context 'state transition: [:started] => [:finished]' do
L
Lin Jen-Shin 已提交
1614
      let(:after_import_service) { spy(:after_import_service) }
L
Lin Jen-Shin 已提交
1615
      let(:housekeeping_service) { spy(:housekeeping_service) }
1616 1617

      before do
L
Lin Jen-Shin 已提交
1618 1619
        allow(Projects::AfterImportService)
          .to receive(:new) { after_import_service }
L
Lin Jen-Shin 已提交
1620

L
Lin Jen-Shin 已提交
1621
        allow(after_import_service)
L
Lin Jen-Shin 已提交
1622 1623 1624 1625
          .to receive(:execute) { housekeeping_service.execute }

        allow(Projects::HousekeepingService)
          .to receive(:new) { housekeeping_service }
1626 1627
      end

1628 1629 1630 1631 1632 1633 1634
      it 'resets project import_error' do
        error_message = 'Some error'
        mirror = create(:project_empty_repo, :import_started, import_error: error_message)

        expect { mirror.import_finish }.to change { mirror.import_error }.from(error_message).to(nil)
      end

1635 1636 1637 1638 1639
      it 'performs housekeeping when an import of a fresh project is completed' do
        project = create(:project_empty_repo, :import_started, import_type: :github)

        project.import_finish

L
Lin Jen-Shin 已提交
1640
        expect(after_import_service).to have_received(:execute)
1641 1642 1643 1644
        expect(housekeeping_service).to have_received(:execute)
      end

      it 'does not perform housekeeping when project repository does not exist' do
1645
        project = create(:project, :import_started, import_type: :github)
1646 1647 1648 1649 1650 1651 1652

        project.import_finish

        expect(housekeeping_service).not_to have_received(:execute)
      end

      it 'does not perform housekeeping when project does not have a valid import type' do
1653
        project = create(:project, :import_started, import_type: nil)
1654 1655 1656 1657 1658 1659 1660 1661

        project.import_finish

        expect(housekeeping_service).not_to have_received(:execute)
      end
    end
  end

1662
  describe '#latest_successful_builds_for' do
L
Lin Jen-Shin 已提交
1663
    def create_pipeline(status = 'success')
1664
      create(:ci_pipeline, project: project,
L
Lin Jen-Shin 已提交
1665
                           sha: project.commit.sha,
1666
                           ref: project.default_branch,
L
Lin Jen-Shin 已提交
1667
                           status: status)
1668 1669
    end

L
Lin Jen-Shin 已提交
1670 1671 1672
    def create_build(new_pipeline = pipeline, name = 'test')
      create(:ci_build, :success, :artifacts,
             pipeline: new_pipeline,
L
Lin Jen-Shin 已提交
1673
             status: new_pipeline.status,
L
Lin Jen-Shin 已提交
1674
             name: name)
1675 1676
    end

1677
    let(:project) { create(:project, :repository) }
L
Lin Jen-Shin 已提交
1678
    let(:pipeline) { create_pipeline }
L
Lin Jen-Shin 已提交
1679 1680

    context 'with many builds' do
1681
      it 'gives the latest builds from latest pipeline' do
1682 1683
        pipeline1 = create_pipeline
        pipeline2 = create_pipeline
1684
        build1_p2 = create_build(pipeline2, 'test')
1685 1686
        create_build(pipeline1, 'test')
        create_build(pipeline1, 'test2')
1687
        build2_p2 = create_build(pipeline2, 'test2')
L
Lin Jen-Shin 已提交
1688 1689 1690

        latest_builds = project.latest_successful_builds_for

1691
        expect(latest_builds).to contain_exactly(build2_p2, build1_p2)
L
Lin Jen-Shin 已提交
1692 1693
      end
    end
L
Lin Jen-Shin 已提交
1694

L
Lin Jen-Shin 已提交
1695
    context 'with succeeded pipeline' do
L
Lin Jen-Shin 已提交
1696
      let!(:build) { create_build }
1697

L
Lin Jen-Shin 已提交
1698
      context 'standalone pipeline' do
1699 1700 1701 1702 1703 1704 1705 1706
        it 'returns builds for ref for default_branch' do
          builds = project.latest_successful_builds_for

          expect(builds).to contain_exactly(build)
        end

        it 'returns empty relation if the build cannot be found' do
          builds = project.latest_successful_builds_for('TAIL')
1707

1708 1709 1710
          expect(builds).to be_kind_of(ActiveRecord::Relation)
          expect(builds).to be_empty
        end
1711 1712
      end

L
Lin Jen-Shin 已提交
1713
      context 'with some pending pipeline' do
1714
        before do
L
Lin Jen-Shin 已提交
1715
          create_build(create_pipeline('pending'))
1716 1717
        end

L
Lin Jen-Shin 已提交
1718 1719
        it 'gives the latest build from latest pipeline' do
          latest_build = project.latest_successful_builds_for
1720

L
Lin Jen-Shin 已提交
1721
          expect(latest_build).to contain_exactly(build)
1722
        end
1723 1724 1725 1726 1727 1728
      end
    end

    context 'with pending pipeline' do
      before do
        pipeline.update(status: 'pending')
L
Lin Jen-Shin 已提交
1729
        create_build(pipeline)
1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740
      end

      it 'returns empty relation' do
        builds = project.latest_successful_builds_for

        expect(builds).to be_kind_of(ActiveRecord::Relation)
        expect(builds).to be_empty
      end
    end
  end

1741
  describe '#add_import_job' do
1742 1743
    let(:import_jid) { '123' }

1744
    context 'forked' do
1745
      let(:forked_project_link) { create(:forked_project_link, :forked_to_empty_project) }
1746 1747 1748 1749
      let(:forked_from_project) { forked_project_link.forked_from_project }
      let(:project) { forked_project_link.forked_to_project }

      it 'schedules a RepositoryForkWorker job' do
1750 1751 1752
        expect(RepositoryForkWorker).to receive(:perform_async).with(
          project.id,
          forked_from_project.repository_storage_path,
1753
          forked_from_project.disk_path).and_return(import_jid)
1754

1755
        expect(project.add_import_job).to eq(import_jid)
1756 1757 1758 1759 1760
      end
    end

    context 'not forked' do
      it 'schedules a RepositoryImportWorker job' do
1761
        project = create(:project, import_url: generate(:url))
1762

1763 1764
        expect(RepositoryImportWorker).to receive(:perform_async).with(project.id).and_return(import_jid)
        expect(project.add_import_job).to eq(import_jid)
1765 1766 1767 1768
      end
    end
  end

R
Rémy Coutable 已提交
1769
  describe '#gitlab_project_import?' do
1770
    subject(:project) { build(:project, import_type: 'gitlab_project') }
R
Rémy Coutable 已提交
1771 1772 1773 1774 1775

    it { expect(project.gitlab_project_import?).to be true }
  end

  describe '#gitea_import?' do
1776
    subject(:project) { build(:project, import_type: 'gitea') }
R
Rémy Coutable 已提交
1777 1778 1779 1780

    it { expect(project.gitea_import?).to be true }
  end

1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795
  describe '#ancestors_upto', :nested_groups do
    let(:parent) { create(:group) }
    let(:child) { create(:group, parent: parent) }
    let(:child2) { create(:group, parent: child) }
    let(:project) { create(:project, namespace: child2) }

    it 'returns all ancestors when no namespace is given' do
      expect(project.ancestors_upto).to contain_exactly(child2, child, parent)
    end

    it 'includes ancestors upto but excluding the given ancestor' do
      expect(project.ancestors_upto(parent)).to contain_exactly(child2, child)
    end
  end

1796
  describe '#lfs_enabled?' do
1797
    let(:project) { create(:project) }
1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857

    shared_examples 'project overrides group' do
      it 'returns true when enabled in project' do
        project.update_attribute(:lfs_enabled, true)

        expect(project.lfs_enabled?).to be_truthy
      end

      it 'returns false when disabled in project' do
        project.update_attribute(:lfs_enabled, false)

        expect(project.lfs_enabled?).to be_falsey
      end

      it 'returns the value from the namespace, when no value is set in project' do
        expect(project.lfs_enabled?).to eq(project.namespace.lfs_enabled?)
      end
    end

    context 'LFS disabled in group' do
      before do
        project.namespace.update_attribute(:lfs_enabled, false)
        enable_lfs
      end

      it_behaves_like 'project overrides group'
    end

    context 'LFS enabled in group' do
      before do
        project.namespace.update_attribute(:lfs_enabled, true)
        enable_lfs
      end

      it_behaves_like 'project overrides group'
    end

    describe 'LFS disabled globally' do
      shared_examples 'it always returns false' do
        it do
          expect(project.lfs_enabled?).to be_falsey
          expect(project.namespace.lfs_enabled?).to be_falsey
        end
      end

      context 'when no values are set' do
        it_behaves_like 'it always returns false'
      end

      context 'when all values are set to true' do
        before do
          project.namespace.update_attribute(:lfs_enabled, true)
          project.update_attribute(:lfs_enabled, true)
        end

        it_behaves_like 'it always returns false'
      end
    end
  end

1858
  describe '#change_head' do
1859
    let(:project) { create(:project, :repository) }
1860

1861 1862 1863 1864 1865
    it 'returns error if branch does not exist' do
      expect(project.change_head('unexisted-branch')).to be false
      expect(project.errors.size).to eq(1)
    end

1866
    it 'calls the before_change_head and after_change_head methods' do
1867
      expect(project.repository).to receive(:before_change_head)
1868 1869
      expect(project.repository).to receive(:after_change_head)

1870 1871 1872
      project.change_head(project.default_branch)
    end

1873
    it 'creates the new reference with rugged' do
1874 1875
      expect(project.repository.raw_repository).to receive(:write_ref).with('HEAD', "refs/heads/#{project.default_branch}", shell: false)

1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888
      project.change_head(project.default_branch)
    end

    it 'copies the gitattributes' do
      expect(project.repository).to receive(:copy_gitattributes).with(project.default_branch)
      project.change_head(project.default_branch)
    end

    it 'reloads the default branch' do
      expect(project).to receive(:reload_default_branch)
      project.change_head(project.default_branch)
    end
  end
Y
Yorick Peterse 已提交
1889

1890
  context 'forks' do
B
Bob Van Landuyt 已提交
1891 1892
    include ProjectForksHelper

1893 1894 1895 1896 1897
    let(:project) { create(:project, :public) }
    let!(:forked_project) { fork_project(project) }

    describe '#fork_network' do
      it 'includes a fork of the project' do
B
Bob Van Landuyt 已提交
1898
        expect(project.fork_network.projects).to include(forked_project)
1899 1900 1901 1902 1903
      end

      it 'includes a fork of a fork' do
        other_fork = fork_project(forked_project)

B
Bob Van Landuyt 已提交
1904
        expect(project.fork_network.projects).to include(other_fork)
1905 1906 1907 1908 1909
      end

      it 'includes sibling forks' do
        other_fork = fork_project(project)

B
Bob Van Landuyt 已提交
1910
        expect(forked_project.fork_network.projects).to include(other_fork)
1911 1912 1913
      end

      it 'includes the base project' do
B
Bob Van Landuyt 已提交
1914
        expect(forked_project.fork_network.projects).to include(project.reload)
1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940
      end
    end

    describe '#in_fork_network_of?' do
      it 'is true for a real fork' do
        expect(forked_project.in_fork_network_of?(project)).to be_truthy
      end

      it 'is true for a fork of a fork', :postgresql do
        other_fork = fork_project(forked_project)

        expect(other_fork.in_fork_network_of?(project)).to be_truthy
      end

      it 'is true for sibling forks' do
        sibling = fork_project(project)

        expect(sibling.in_fork_network_of?(forked_project)).to be_truthy
      end

      it 'is false when another project is given' do
        other_project = build_stubbed(:project)

        expect(forked_project.in_fork_network_of?(other_project)).to be_falsy
      end
    end
1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954

    describe '#fork_source' do
      let!(:second_fork) { fork_project(forked_project) }

      it 'returns the direct source if it exists' do
        expect(second_fork.fork_source).to eq(forked_project)
      end

      it 'returns the root of the fork network when the directs source was deleted' do
        forked_project.destroy

        expect(second_fork.fork_source).to eq(project)
      end
    end
1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972

    describe '#lfs_storage_project' do
      it 'returns self for non-forks' do
        expect(project.lfs_storage_project).to eq project
      end

      it 'returns the fork network root for forks' do
        second_fork = fork_project(forked_project)

        expect(second_fork.lfs_storage_project).to eq project
      end

      it 'returns self when fork_source is nil' do
        expect(forked_project).to receive(:fork_source).and_return(nil)

        expect(forked_project.lfs_storage_project).to eq forked_project
      end
    end
1973 1974
  end

Y
Yorick Peterse 已提交
1975
  describe '#pushes_since_gc' do
1976
    let(:project) { create(:project) }
Y
Yorick Peterse 已提交
1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997

    after do
      project.reset_pushes_since_gc
    end

    context 'without any pushes' do
      it 'returns 0' do
        expect(project.pushes_since_gc).to eq(0)
      end
    end

    context 'with a number of pushes' do
      it 'returns the number of pushes' do
        3.times { project.increment_pushes_since_gc }

        expect(project.pushes_since_gc).to eq(3)
      end
    end
  end

  describe '#increment_pushes_since_gc' do
1998
    let(:project) { create(:project) }
Y
Yorick Peterse 已提交
1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011

    after do
      project.reset_pushes_since_gc
    end

    it 'increments the number of pushes since the last GC' do
      3.times { project.increment_pushes_since_gc }

      expect(project.pushes_since_gc).to eq(3)
    end
  end

  describe '#reset_pushes_since_gc' do
2012
    let(:project) { create(:project) }
Y
Yorick Peterse 已提交
2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025

    after do
      project.reset_pushes_since_gc
    end

    it 'resets the number of pushes since the last GC' do
      3.times { project.increment_pushes_since_gc }

      project.reset_pushes_since_gc

      expect(project.pushes_since_gc).to eq(0)
    end
  end
2026

2027 2028
  describe '#deployment_variables' do
    context 'when project has no deployment service' do
2029
      let(:project) { create(:project) }
2030 2031 2032 2033 2034 2035 2036

      it 'returns an empty array' do
        expect(project.deployment_variables).to eq []
      end
    end

    context 'when project has a deployment service' do
2037
      shared_examples 'same behavior between KubernetesService and Platform::Kubernetes' do
2038 2039
        it 'returns variables from this service' do
          expect(project.deployment_variables).to include(
2040
            { key: 'KUBE_TOKEN', value: project.deployment_platform.token, public: false }
2041 2042 2043 2044 2045 2046 2047
          )
        end
      end

      context 'when user configured kubernetes from Integration > Kubernetes' do
        let(:project) { create(:kubernetes_project) }

2048
        it_behaves_like 'same behavior between KubernetesService and Platform::Kubernetes'
2049 2050 2051 2052 2053
      end

      context 'when user configured kubernetes from CI/CD > Clusters' do
        let!(:cluster) { create(:cluster, :project, :provided_by_gcp) }
        let(:project) { cluster.project }
2054

2055
        it_behaves_like 'same behavior between KubernetesService and Platform::Kubernetes'
2056 2057 2058 2059
      end
    end
  end

2060
  describe '#secret_variables_for' do
2061
    let(:project) { create(:project) }
2062 2063 2064 2065 2066 2067 2068 2069 2070

    let!(:secret_variable) do
      create(:ci_variable, value: 'secret', project: project)
    end

    let!(:protected_variable) do
      create(:ci_variable, :protected, value: 'protected', project: project)
    end

L
Lin Jen-Shin 已提交
2071 2072 2073 2074 2075 2076
    subject { project.secret_variables_for(ref: 'ref') }

    before do
      stub_application_setting(
        default_branch_protection: Gitlab::Access::PROTECTION_NONE)
    end
2077 2078 2079

    shared_examples 'ref is protected' do
      it 'contains all the variables' do
2080
        is_expected.to contain_exactly(secret_variable, protected_variable)
2081 2082 2083 2084
      end
    end

    context 'when the ref is not protected' do
2085
      it 'contains only the secret variables' do
2086
        is_expected.to contain_exactly(secret_variable)
2087 2088 2089
      end
    end

2090 2091 2092
    context 'when the ref is a protected branch' do
      before do
        create(:protected_branch, name: 'ref', project: project)
2093
      end
2094 2095 2096 2097 2098 2099 2100 2101 2102 2103

      it_behaves_like 'ref is protected'
    end

    context 'when the ref is a protected tag' do
      before do
        create(:protected_tag, name: 'ref', project: project)
      end

      it_behaves_like 'ref is protected'
2104 2105 2106
    end
  end

2107
  describe '#protected_for?' do
2108
    let(:project) { create(:project) }
2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143

    subject { project.protected_for?('ref') }

    context 'when the ref is not protected' do
      before do
        stub_application_setting(
          default_branch_protection: Gitlab::Access::PROTECTION_NONE)
      end

      it 'returns false' do
        is_expected.to be_falsey
      end
    end

    context 'when the ref is a protected branch' do
      before do
        create(:protected_branch, name: 'ref', project: project)
      end

      it 'returns true' do
        is_expected.to be_truthy
      end
    end

    context 'when the ref is a protected tag' do
      before do
        create(:protected_tag, name: 'ref', project: project)
      end

      it 'returns true' do
        is_expected.to be_truthy
      end
    end
  end

M
Markus Koller 已提交
2144
  describe '#update_project_statistics' do
2145
    let(:project) { create(:project) }
M
Markus Koller 已提交
2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163

    it "is called after creation" do
      expect(project.statistics).to be_a ProjectStatistics
      expect(project.statistics).to be_persisted
    end

    it "copies the namespace_id" do
      expect(project.statistics.namespace_id).to eq project.namespace_id
    end

    it "updates the namespace_id when changed" do
      namespace = create(:namespace)
      project.update(namespace: namespace)

      expect(project.statistics.namespace_id).to eq namespace.id
    end
  end

2164
  describe 'inside_path' do
2165 2166 2167
    let!(:project1) { create(:project, namespace: create(:namespace, path: 'name_pace')) }
    let!(:project2) { create(:project) }
    let!(:project3) { create(:project, namespace: create(:namespace, path: 'namespace')) }
2168
    let!(:path) { project1.namespace.full_path }
2169

2170
    it 'returns correct project' do
2171
      expect(described_class.inside_path(path)).to eq([project1])
2172
    end
2173 2174
  end

D
Douwe Maan 已提交
2175
  describe '#route_map_for' do
2176
    let(:project) { create(:project, :repository) }
D
Douwe Maan 已提交
2177 2178 2179 2180 2181 2182 2183 2184
    let(:route_map) do
      <<-MAP.strip_heredoc
      - source: /source/(.*)/
        public: '\\1'
      MAP
    end

    before do
2185
      project.repository.create_file(User.last, '.gitlab/route-map.yml', route_map, message: 'Add .gitlab/route-map.yml', branch_name: 'master')
D
Douwe Maan 已提交
2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212
    end

    context 'when there is a .gitlab/route-map.yml at the commit' do
      context 'when the route map is valid' do
        it 'returns a route map' do
          map = project.route_map_for(project.commit.sha)
          expect(map).to be_a_kind_of(Gitlab::RouteMap)
        end
      end

      context 'when the route map is invalid' do
        let(:route_map) { 'INVALID' }

        it 'returns nil' do
          expect(project.route_map_for(project.commit.sha)).to be_nil
        end
      end
    end

    context 'when there is no .gitlab/route-map.yml at the commit' do
      it 'returns nil' do
        expect(project.route_map_for(project.commit.parent.sha)).to be_nil
      end
    end
  end

  describe '#public_path_for_source_path' do
2213
    let(:project) { create(:project, :repository) }
D
Douwe Maan 已提交
2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250
    let(:route_map) do
      Gitlab::RouteMap.new(<<-MAP.strip_heredoc)
        - source: /source/(.*)/
          public: '\\1'
      MAP
    end
    let(:sha) { project.commit.id }

    context 'when there is a route map' do
      before do
        allow(project).to receive(:route_map_for).with(sha).and_return(route_map)
      end

      context 'when the source path is mapped' do
        it 'returns the public path' do
          expect(project.public_path_for_source_path('source/file.html', sha)).to eq('file.html')
        end
      end

      context 'when the source path is not mapped' do
        it 'returns nil' do
          expect(project.public_path_for_source_path('file.html', sha)).to be_nil
        end
      end
    end

    context 'when there is no route map' do
      before do
        allow(project).to receive(:route_map_for).with(sha).and_return(nil)
      end

      it 'returns nil' do
        expect(project.public_path_for_source_path('source/file.html', sha)).to be_nil
      end
    end
  end

2251
  describe '#parent' do
2252
    let(:project) { create(:project) }
2253 2254 2255 2256

    it { expect(project.parent).to eq(project.namespace) }
  end

2257 2258 2259 2260 2261 2262
  describe '#parent_id' do
    let(:project) { create(:project) }

    it { expect(project.parent_id).to eq(project.namespace_id) }
  end

2263
  describe '#parent_changed?' do
2264
    let(:project) { create(:project) }
2265

2266 2267 2268
    before do
      project.namespace_id = 7
    end
2269 2270 2271 2272

    it { expect(project.parent_changed?).to be_truthy }
  end

2273 2274 2275
  def enable_lfs
    allow(Gitlab.config.lfs).to receive(:enabled).and_return(true)
  end
K
Kamil Trzcinski 已提交
2276

2277
  describe '#pages_url' do
2278 2279
    let(:group) { create :group, name: 'Group' }
    let(:nested_group) { create :group, parent: group }
K
Kamil Trzcinski 已提交
2280 2281 2282 2283 2284 2285 2286 2287 2288
    let(:domain) { 'Example.com' }

    subject { project.pages_url }

    before do
      allow(Settings.pages).to receive(:host).and_return(domain)
      allow(Gitlab.config.pages).to receive(:url).and_return('http://example.com')
    end

2289
    context 'top-level group' do
2290
      let(:project) { create :project, namespace: group, name: project_name }
K
Kamil Trzcinski 已提交
2291

2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302
      context 'group page' do
        let(:project_name) { 'group.example.com' }

        it { is_expected.to eq("http://group.example.com") }
      end

      context 'project page' do
        let(:project_name) { 'Project' }

        it { is_expected.to eq("http://group.example.com/project") }
      end
K
Kamil Trzcinski 已提交
2303 2304
    end

2305
    context 'nested group' do
2306
      let(:project) { create :project, namespace: nested_group, name: project_name }
2307
      let(:expected_url) { "http://group.example.com/#{nested_group.path}/#{project.path}" }
K
Kamil Trzcinski 已提交
2308

2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319
      context 'group page' do
        let(:project_name) { 'group.example.com' }

        it { is_expected.to eq(expected_url) }
      end

      context 'project page' do
        let(:project_name) { 'Project' }

        it { is_expected.to eq(expected_url) }
      end
K
Kamil Trzcinski 已提交
2320 2321
    end
  end
2322 2323

  describe '#http_url_to_repo' do
2324
    let(:project) { create :project }
2325

2326 2327 2328
    it 'returns the url to the repo without a username' do
      expect(project.http_url_to_repo).to eq("#{project.web_url}.git")
      expect(project.http_url_to_repo).not_to include('@')
2329 2330
    end
  end
2331 2332

  describe '#pipeline_status' do
2333
    let(:project) { create(:project, :repository) }
2334
    it 'builds a pipeline status' do
2335
      expect(project.pipeline_status).to be_a(Gitlab::Cache::Ci::ProjectPipelineStatus)
2336 2337 2338 2339 2340 2341
    end

    it 'hase a loaded pipeline status' do
      expect(project.pipeline_status).to be_loaded
    end
  end
2342 2343

  describe '#append_or_update_attribute' do
2344
    let(:project) { create(:project) }
2345 2346 2347 2348 2349

    it 'shows full error updating an invalid MR' do
      error_message = 'Failed to replace merge_requests because one or more of the new records could not be saved.'\
                      ' Validate fork Source project is not a fork of the target project'

2350 2351
      expect { project.append_or_update_attribute(:merge_requests, [create(:merge_request)]) }
        .to raise_error(ActiveRecord::RecordNotSaved, error_message)
2352 2353 2354 2355 2356
    end

    it 'updates the project succesfully' do
      merge_request = create(:merge_request, target_project: project, source_project: project)

2357 2358
      expect { project.append_or_update_attribute(:merge_requests, [merge_request]) }
        .not_to raise_error
2359 2360
    end
  end
2361 2362 2363

  describe '#last_repository_updated_at' do
    it 'sets to created_at upon creation' do
2364
      project = create(:project, created_at: 2.hours.ago)
2365 2366 2367 2368

      expect(project.last_repository_updated_at.to_i).to eq(project.created_at.to_i)
    end
  end
2369 2370 2371 2372 2373

  describe '.public_or_visible_to_user' do
    let!(:user) { create(:user) }

    let!(:private_project) do
2374
      create(:project, :private, creator: user, namespace: user.namespace)
2375 2376
    end

2377
    let!(:public_project) { create(:project, :public) }
2378 2379 2380

    context 'with a user' do
      let(:projects) do
2381
        described_class.all.public_or_visible_to_user(user)
2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394
      end

      it 'includes projects the user has access to' do
        expect(projects).to include(private_project)
      end

      it 'includes projects the user can see' do
        expect(projects).to include(public_project)
      end
    end

    context 'without a user' do
      it 'only includes public projects' do
2395
        projects = described_class.all.public_or_visible_to_user
2396 2397 2398 2399 2400

        expect(projects).to eq([public_project])
      end
    end
  end
2401

2402 2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423
  describe '#pages_available?' do
    let(:project) { create(:project, group: group) }

    subject { project.pages_available? }

    before do
      allow(Gitlab.config.pages).to receive(:enabled).and_return(true)
    end

    context 'when the project is in a top level namespace' do
      let(:group) { create(:group) }

      it { is_expected.to be(true) }
    end

    context 'when the project is in a subgroup' do
      let(:group) { create(:group, :nested) }

      it { is_expected.to be(false) }
    end
  end

2424
  describe '#remove_private_deploy_keys' do
2425
    let!(:project) { create(:project) }
2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439 2440

    context 'for a private deploy key' do
      let!(:key) { create(:deploy_key, public: false) }
      let!(:deploy_keys_project) { create(:deploy_keys_project, deploy_key: key, project: project) }

      context 'when the key is not linked to another project' do
        it 'removes the key' do
          project.remove_private_deploy_keys

          expect(project.deploy_keys).not_to include(key)
        end
      end

      context 'when the key is linked to another project' do
        before do
2441
          another_project = create(:project)
2442 2443
          create(:deploy_keys_project, deploy_key: key, project: another_project)
        end
2444

2445 2446
        it 'does not remove the key' do
          project.remove_private_deploy_keys
2447

2448 2449 2450 2451 2452 2453 2454 2455
          expect(project.deploy_keys).to include(key)
        end
      end
    end

    context 'for a public deploy key' do
      let!(:key) { create(:deploy_key, public: true) }
      let!(:deploy_keys_project) { create(:deploy_keys_project, deploy_key: key, project: project) }
2456

2457 2458
      it 'does not remove the key' do
        project.remove_private_deploy_keys
2459

2460 2461
        expect(project.deploy_keys).to include(key)
      end
2462 2463
    end
  end
2464

2465 2466
  describe '#remove_pages' do
    let(:project) { create(:project) }
2467
    let(:namespace) { project.namespace }
2468 2469 2470 2471 2472 2473 2474 2475 2476 2477 2478
    let(:pages_path) { project.pages_path }

    around do |example|
      FileUtils.mkdir_p(pages_path)
      begin
        example.run
      ensure
        FileUtils.rm_rf(pages_path)
      end
    end

2479 2480 2481 2482 2483 2484 2485 2486
    it 'removes the pages directory' do
      expect_any_instance_of(Projects::UpdatePagesConfigurationService).to receive(:execute)
      expect_any_instance_of(Gitlab::PagesTransfer).to receive(:rename_project).and_return(true)
      expect(PagesWorker).to receive(:perform_in).with(5.minutes, :remove, namespace.full_path, anything)

      project.remove_pages
    end

2487 2488 2489 2490 2491 2492 2493 2494
    it 'is a no-op when there is no namespace' do
      project.update_column(:namespace_id, nil)

      expect_any_instance_of(Projects::UpdatePagesConfigurationService).not_to receive(:execute)
      expect_any_instance_of(Gitlab::PagesTransfer).not_to receive(:rename_project)

      project.remove_pages
    end
2495 2496 2497 2498 2499 2500

    it 'is run when the project is destroyed' do
      expect(project).to receive(:remove_pages).and_call_original

      project.destroy
    end
2501 2502
  end

2503 2504 2505 2506
  describe '#forks_count' do
    it 'returns the number of forks' do
      project = build(:project)

F
Francisco Lopez 已提交
2507
      expect_any_instance_of(Projects::ForksCountService).to receive(:count).and_return(1)
2508 2509 2510 2511

      expect(project.forks_count).to eq(1)
    end
  end
2512 2513 2514 2515

  context 'legacy storage' do
    let(:project) { create(:project, :repository) }
    let(:gitlab_shell) { Gitlab::Shell.new }
2516
    let(:project_storage) { project.send(:storage) }
2517

2518 2519 2520 2521
    before do
      allow(project).to receive(:gitlab_shell).and_return(gitlab_shell)
    end

2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533
    describe '#base_dir' do
      it 'returns base_dir based on namespace only' do
        expect(project.base_dir).to eq(project.namespace.full_path)
      end
    end

    describe '#disk_path' do
      it 'returns disk_path based on namespace and project path' do
        expect(project.disk_path).to eq("#{project.namespace.full_path}/#{project.path}")
      end
    end

2534
    describe '#ensure_storage_path_exists' do
2535 2536 2537
      it 'delegates to gitlab_shell to ensure namespace is created' do
        expect(gitlab_shell).to receive(:add_namespace).with(project.repository_storage_path, project.base_dir)

2538
        project.ensure_storage_path_exists
2539 2540 2541
      end
    end

2542 2543
    describe '#legacy_storage?' do
      it 'returns true when storage_version is nil' do
2544
        project = build(:project, storage_version: nil)
2545 2546 2547

        expect(project.legacy_storage?).to be_truthy
      end
2548 2549 2550 2551 2552 2553 2554 2555 2556 2557

      it 'returns true when the storage_version is 0' do
        project = build(:project, storage_version: 0)

        expect(project.legacy_storage?).to be_truthy
      end
    end

    describe '#hashed_storage?' do
      it 'returns false' do
2558
        expect(project.hashed_storage?(:repository)).to be_falsey
2559
      end
2560 2561
    end

2562 2563 2564 2565 2566 2567 2568 2569 2570 2571 2572 2573 2574 2575 2576 2577 2578 2579 2580 2581 2582 2583 2584 2585 2586 2587 2588 2589 2590 2591 2592 2593 2594 2595 2596 2597 2598 2599 2600 2601 2602 2603 2604 2605 2606 2607 2608
    describe '#rename_repo' do
      before do
        # Project#gitlab_shell returns a new instance of Gitlab::Shell on every
        # call. This makes testing a bit easier.
        allow(project).to receive(:gitlab_shell).and_return(gitlab_shell)
        allow(project).to receive(:previous_changes).and_return('path' => ['foo'])
      end

      it 'renames a repository' do
        stub_container_registry_config(enabled: false)

        expect(gitlab_shell).to receive(:mv_repository)
          .ordered
          .with(project.repository_storage_path, "#{project.namespace.full_path}/foo", "#{project.full_path}")
          .and_return(true)

        expect(gitlab_shell).to receive(:mv_repository)
          .ordered
          .with(project.repository_storage_path, "#{project.namespace.full_path}/foo.wiki", "#{project.full_path}.wiki")
          .and_return(true)

        expect_any_instance_of(SystemHooksService)
          .to receive(:execute_hooks_for)
            .with(project, :rename)

        expect_any_instance_of(Gitlab::UploadsTransfer)
          .to receive(:rename_project)
            .with('foo', project.path, project.namespace.full_path)

        expect(project).to receive(:expire_caches_before_rename)

        expect(project).to receive(:expires_full_path_cache)

        project.rename_repo
      end

      context 'container registry with images' do
        let(:container_repository) { create(:container_repository) }

        before do
          stub_container_registry_config(enabled: true)
          stub_container_registry_tags(repository: :any, tags: ['tag'])
          project.container_repositories << container_repository
        end

        subject { project.rename_repo }

2609
        it { expect { subject }.to raise_error(StandardError) }
2610
      end
2611 2612 2613 2614 2615 2616 2617 2618 2619 2620 2621 2622 2623 2624 2625 2626 2627 2628 2629 2630 2631 2632 2633 2634

      context 'gitlab pages' do
        before do
          expect(project_storage).to receive(:rename_repo) { true }
        end

        it 'moves pages folder to new location' do
          expect_any_instance_of(Gitlab::PagesTransfer).to receive(:rename_project)

          project.rename_repo
        end
      end

      context 'attachments' do
        before do
          expect(project_storage).to receive(:rename_repo) { true }
        end

        it 'moves uploads folder to new location' do
          expect_any_instance_of(Gitlab::UploadsTransfer).to receive(:rename_project)

          project.rename_repo
        end
      end
2635 2636 2637 2638 2639

      it 'updates project full path in .git/config' do
        allow(project_storage).to receive(:rename_repo).and_return(true)

        project.rename_repo
2640

J
Jacob Vosmaer 已提交
2641
        expect(project.repository.rugged.config['gitlab.fullpath']).to eq(project.full_path)
2642
      end
2643
    end
2644 2645 2646 2647 2648 2649

    describe '#pages_path' do
      it 'returns a path where pages are stored' do
        expect(project.pages_path).to eq(File.join(Settings.pages.path, project.namespace.full_path, project.path))
      end
    end
2650 2651 2652 2653 2654 2655

    describe '#migrate_to_hashed_storage!' do
      it 'returns true' do
        expect(project.migrate_to_hashed_storage!).to be_truthy
      end

T
Toon Claes 已提交
2656
      it 'flags as read-only' do
2657 2658 2659 2660 2661 2662 2663 2664 2665 2666 2667 2668 2669 2670 2671 2672 2673 2674 2675 2676 2677 2678 2679 2680 2681
        expect { project.migrate_to_hashed_storage! }.to change { project.repository_read_only }.to(true)
      end

      it 'schedules ProjectMigrateHashedStorageWorker with delayed start when the project repo is in use' do
        Gitlab::ReferenceCounter.new(project.gl_repository(is_wiki: false)).increase

        expect(ProjectMigrateHashedStorageWorker).to receive(:perform_in)

        project.migrate_to_hashed_storage!
      end

      it 'schedules ProjectMigrateHashedStorageWorker with delayed start when the wiki repo is in use' do
        Gitlab::ReferenceCounter.new(project.gl_repository(is_wiki: true)).increase

        expect(ProjectMigrateHashedStorageWorker).to receive(:perform_in)

        project.migrate_to_hashed_storage!
      end

      it 'schedules ProjectMigrateHashedStorageWorker' do
        expect(ProjectMigrateHashedStorageWorker).to receive(:perform_async).with(project.id)

        project.migrate_to_hashed_storage!
      end
    end
2682 2683 2684
  end

  context 'hashed storage' do
2685
    let(:project) { create(:project, :repository, skip_disk_validation: true) }
2686
    let(:gitlab_shell) { Gitlab::Shell.new }
2687
    let(:hash) { Digest::SHA2.hexdigest(project.id.to_s) }
2688 2689

    before do
2690
      stub_application_setting(hashed_storage_enabled: true)
2691 2692
    end

2693 2694 2695 2696 2697 2698 2699
    describe '#legacy_storage?' do
      it 'returns false' do
        expect(project.legacy_storage?).to be_falsey
      end
    end

    describe '#hashed_storage?' do
2700 2701
      it 'returns true if rolled out' do
        expect(project.hashed_storage?(:attachments)).to be_truthy
2702 2703
      end

2704 2705
      it 'returns false when not rolled out yet' do
        project.storage_version = 1
2706

2707
        expect(project.hashed_storage?(:attachments)).to be_falsey
2708 2709 2710
      end
    end

2711 2712
    describe '#base_dir' do
      it 'returns base_dir based on hash of project id' do
2713
        expect(project.base_dir).to eq("@hashed/#{hash[0..1]}/#{hash[2..3]}")
2714 2715 2716 2717
      end
    end

    describe '#disk_path' do
2718
      it 'returns disk_path based on hash of project id' do
2719
        hashed_path = "@hashed/#{hash[0..1]}/#{hash[2..3]}/#{hash}"
2720 2721 2722 2723 2724

        expect(project.disk_path).to eq(hashed_path)
      end
    end

2725
    describe '#ensure_storage_path_exists' do
2726
      it 'delegates to gitlab_shell to ensure namespace is created' do
2727 2728 2729
        allow(project).to receive(:gitlab_shell).and_return(gitlab_shell)

        expect(gitlab_shell).to receive(:add_namespace).with(project.repository_storage_path, "@hashed/#{hash[0..1]}/#{hash[2..3]}")
2730

2731
        project.ensure_storage_path_exists
2732 2733 2734 2735 2736 2737 2738 2739 2740 2741 2742 2743 2744 2745 2746 2747 2748 2749 2750 2751 2752 2753 2754 2755 2756 2757 2758 2759 2760 2761 2762 2763 2764 2765 2766 2767 2768 2769
      end
    end

    describe '#rename_repo' do
      before do
        # Project#gitlab_shell returns a new instance of Gitlab::Shell on every
        # call. This makes testing a bit easier.
        allow(project).to receive(:gitlab_shell).and_return(gitlab_shell)
        allow(project).to receive(:previous_changes).and_return('path' => ['foo'])
      end

      it 'renames a repository' do
        stub_container_registry_config(enabled: false)

        expect(gitlab_shell).not_to receive(:mv_repository)

        expect_any_instance_of(SystemHooksService)
          .to receive(:execute_hooks_for)
            .with(project, :rename)

        expect(project).to receive(:expire_caches_before_rename)

        expect(project).to receive(:expires_full_path_cache)

        project.rename_repo
      end

      context 'container registry with images' do
        let(:container_repository) { create(:container_repository) }

        before do
          stub_container_registry_config(enabled: true)
          stub_container_registry_tags(repository: :any, tags: ['tag'])
          project.container_repositories << container_repository
        end

        subject { project.rename_repo }

2770
        it { expect { subject }.to raise_error(StandardError) }
2771
      end
2772 2773 2774 2775 2776 2777 2778 2779 2780 2781 2782 2783 2784 2785 2786 2787 2788

      context 'gitlab pages' do
        it 'moves pages folder to new location' do
          expect_any_instance_of(Gitlab::PagesTransfer).to receive(:rename_project)

          project.rename_repo
        end
      end

      context 'attachments' do
        it 'keeps uploads folder location unchanged' do
          expect_any_instance_of(Gitlab::UploadsTransfer).not_to receive(:rename_project)

          project.rename_repo
        end

        context 'when not rolled out' do
2789
          let(:project) { create(:project, :repository, storage_version: 1, skip_disk_validation: true) }
2790 2791 2792 2793 2794 2795 2796 2797

          it 'moves pages folder to new location' do
            expect_any_instance_of(Gitlab::UploadsTransfer).to receive(:rename_project)

            project.rename_repo
          end
        end
      end
2798 2799 2800

      it 'updates project full path in .git/config' do
        project.rename_repo
2801

J
Jacob Vosmaer 已提交
2802
        expect(project.repository.rugged.config['gitlab.fullpath']).to eq(project.full_path)
2803
      end
2804
    end
2805 2806 2807 2808 2809 2810

    describe '#pages_path' do
      it 'returns a path where pages are stored' do
        expect(project.pages_path).to eq(File.join(Settings.pages.path, project.namespace.full_path, project.path))
      end
    end
2811 2812 2813 2814 2815 2816

    describe '#migrate_to_hashed_storage!' do
      it 'returns nil' do
        expect(project.migrate_to_hashed_storage!).to be_nil
      end

T
Toon Claes 已提交
2817
      it 'does not flag as read-only' do
2818 2819 2820 2821 2822 2823 2824 2825 2826 2827 2828 2829 2830
        expect { project.migrate_to_hashed_storage! }.not_to change { project.repository_read_only }
      end
    end
  end

  describe '#gl_repository' do
    let(:project) { create(:project) }

    it 'delegates to Gitlab::GlRepository.gl_repository' do
      expect(Gitlab::GlRepository).to receive(:gl_repository).with(project, true)

      project.gl_repository(is_wiki: true)
    end
2831
  end
2832 2833 2834 2835 2836 2837 2838 2839 2840 2841 2842 2843 2844 2845 2846 2847 2848 2849 2850 2851 2852 2853 2854 2855 2856 2857 2858 2859 2860 2861 2862 2863 2864 2865 2866 2867 2868 2869 2870 2871 2872 2873 2874 2875 2876 2877 2878 2879 2880 2881 2882 2883 2884 2885 2886 2887 2888 2889 2890 2891 2892 2893 2894 2895 2896 2897 2898 2899 2900 2901 2902 2903 2904 2905 2906 2907 2908 2909 2910 2911 2912 2913 2914 2915 2916 2917 2918 2919 2920 2921 2922 2923 2924 2925 2926 2927 2928 2929

  describe '#has_ci?' do
    set(:project) { create(:project) }
    let(:repository) { double }

    before do
      expect(project).to receive(:repository) { repository }
    end

    context 'when has .gitlab-ci.yml' do
      before do
        expect(repository).to receive(:gitlab_ci_yml) { 'content' }
      end

      it "CI is available" do
        expect(project).to have_ci
      end
    end

    context 'when there is no .gitlab-ci.yml' do
      before do
        expect(repository).to receive(:gitlab_ci_yml) { nil }
      end

      it "CI is not available" do
        expect(project).not_to have_ci
      end

      context 'when auto devops is enabled' do
        before do
          stub_application_setting(auto_devops_enabled: true)
        end

        it "CI is available" do
          expect(project).to have_ci
        end
      end
    end
  end

  describe '#auto_devops_enabled?' do
    set(:project) { create(:project) }

    subject { project.auto_devops_enabled? }

    context 'when enabled in settings' do
      before do
        stub_application_setting(auto_devops_enabled: true)
      end

      it 'auto devops is implicitly enabled' do
        expect(project.auto_devops).to be_nil
        expect(project).to be_auto_devops_enabled
      end

      context 'when explicitly enabled' do
        before do
          create(:project_auto_devops, project: project)
        end

        it "auto devops is enabled" do
          expect(project).to be_auto_devops_enabled
        end
      end

      context 'when explicitly disabled' do
        before do
          create(:project_auto_devops, project: project, enabled: false)
        end

        it "auto devops is disabled" do
          expect(project).not_to be_auto_devops_enabled
        end
      end
    end

    context 'when disabled in settings' do
      before do
        stub_application_setting(auto_devops_enabled: false)
      end

      it 'auto devops is implicitly disabled' do
        expect(project.auto_devops).to be_nil
        expect(project).not_to be_auto_devops_enabled
      end

      context 'when explicitly enabled' do
        before do
          create(:project_auto_devops, project: project)
        end

        it "auto devops is enabled" do
          expect(project).to be_auto_devops_enabled
        end
      end
    end
  end

2930 2931 2932 2933 2934 2935 2936 2937 2938 2939 2940 2941 2942 2943 2944 2945 2946 2947 2948 2949 2950 2951 2952 2953 2954 2955 2956 2957 2958 2959 2960 2961 2962 2963 2964 2965 2966 2967 2968 2969 2970 2971 2972 2973
  describe '#has_auto_devops_implicitly_disabled?' do
    set(:project) { create(:project) }

    context 'when enabled in settings' do
      before do
        stub_application_setting(auto_devops_enabled: true)
      end

      it 'does not have auto devops implicitly disabled' do
        expect(project).not_to have_auto_devops_implicitly_disabled
      end
    end

    context 'when disabled in settings' do
      before do
        stub_application_setting(auto_devops_enabled: false)
      end

      it 'auto devops is implicitly disabled' do
        expect(project).to have_auto_devops_implicitly_disabled
      end

      context 'when explicitly disabled' do
        before do
          create(:project_auto_devops, project: project, enabled: false)
        end

        it 'does not have auto devops implicitly disabled' do
          expect(project).not_to have_auto_devops_implicitly_disabled
        end
      end

      context 'when explicitly enabled' do
        before do
          create(:project_auto_devops, project: project)
        end

        it 'does not have auto devops implicitly disabled' do
          expect(project).not_to have_auto_devops_implicitly_disabled
        end
      end
    end
  end

2974 2975 2976 2977 2978 2979 2980 2981 2982 2983 2984 2985 2986 2987 2988 2989 2990 2991 2992 2993 2994 2995 2996 2997 2998 2999 3000 3001 3002 3003 3004
  context '#auto_devops_variables' do
    set(:project) { create(:project) }

    subject { project.auto_devops_variables }

    context 'when enabled in settings' do
      before do
        stub_application_setting(auto_devops_enabled: true)
      end

      context 'when domain is empty' do
        before do
          create(:project_auto_devops, project: project, domain: nil)
        end

        it 'variables are empty' do
          is_expected.to be_empty
        end
      end

      context 'when domain is configured' do
        before do
          create(:project_auto_devops, project: project, domain: 'example.com')
        end

        it "variables are not empty" do
          is_expected.not_to be_empty
        end
      end
    end
  end
3005 3006 3007 3008 3009 3010 3011 3012 3013 3014 3015 3016 3017 3018 3019 3020 3021 3022 3023 3024 3025 3026 3027 3028 3029 3030 3031 3032 3033 3034 3035 3036 3037 3038 3039

  describe '#latest_successful_builds_for' do
    let(:project) { build(:project) }

    before do
      allow(project).to receive(:default_branch).and_return('master')
    end

    context 'without a ref' do
      it 'returns a pipeline for the default branch' do
        expect(project)
          .to receive(:latest_successful_pipeline_for_default_branch)

        project.latest_successful_pipeline_for
      end
    end

    context 'with the ref set to the default branch' do
      it 'returns a pipeline for the default branch' do
        expect(project)
          .to receive(:latest_successful_pipeline_for_default_branch)

        project.latest_successful_pipeline_for(project.default_branch)
      end
    end

    context 'with a ref that is not the default branch' do
      it 'returns the latest successful pipeline for the given ref' do
        expect(project.pipelines).to receive(:latest_successful_for).with('foo')

        project.latest_successful_pipeline_for('foo')
      end
    end
  end

S
Stan Hu 已提交
3040 3041 3042 3043 3044 3045 3046 3047 3048 3049 3050
  describe '#check_repository_path_availability' do
    let(:project) { build(:project) }

    it 'skips gitlab-shell exists?' do
      project.skip_disk_validation = true

      expect(project.gitlab_shell).not_to receive(:exists?)
      expect(project.check_repository_path_availability).to be_truthy
    end
  end

3051 3052 3053 3054 3055 3056 3057 3058 3059 3060 3061 3062 3063 3064 3065 3066 3067 3068 3069 3070 3071
  describe '#latest_successful_pipeline_for_default_branch' do
    let(:project) { build(:project) }

    before do
      allow(project).to receive(:default_branch).and_return('master')
    end

    it 'memoizes and returns the latest successful pipeline for the default branch' do
      pipeline = double(:pipeline)

      expect(project.pipelines).to receive(:latest_successful_for)
        .with(project.default_branch)
        .and_return(pipeline)
        .once

      2.times do
        expect(project.latest_successful_pipeline_for_default_branch)
          .to eq(pipeline)
      end
    end
  end
3072 3073 3074 3075 3076 3077 3078 3079 3080

  describe '#after_import' do
    let(:project) { build(:project) }

    it 'runs the correct hooks' do
      expect(project.repository).to receive(:after_import)
      expect(project).to receive(:import_finish)
      expect(project).to receive(:update_project_counter_caches)
      expect(project).to receive(:remove_import_jid)
3081
      expect(project).to receive(:after_create_default_branch)
3082 3083 3084

      project.after_import
    end
3085 3086 3087 3088 3089 3090 3091 3092 3093 3094 3095 3096 3097 3098 3099 3100 3101 3102 3103 3104 3105 3106 3107 3108 3109 3110 3111 3112 3113 3114 3115 3116 3117 3118 3119 3120 3121 3122 3123 3124 3125

    context 'branch protection' do
      let(:project) { create(:project, :repository) }

      it 'does not protect when branch protection is disabled' do
        stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_NONE)

        project.after_import

        expect(project.protected_branches).to be_empty
      end

      it "gives developer access to push when branch protection is set to 'developers can push'" do
        stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_DEV_CAN_PUSH)

        project.after_import

        expect(project.protected_branches).not_to be_empty
        expect(project.default_branch).to eq(project.protected_branches.first.name)
        expect(project.protected_branches.first.push_access_levels.map(&:access_level)).to eq([Gitlab::Access::DEVELOPER])
      end

      it "gives developer access to merge when branch protection is set to 'developers can merge'" do
        stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_DEV_CAN_MERGE)

        project.after_import

        expect(project.protected_branches).not_to be_empty
        expect(project.default_branch).to eq(project.protected_branches.first.name)
        expect(project.protected_branches.first.merge_access_levels.map(&:access_level)).to eq([Gitlab::Access::DEVELOPER])
      end

      it 'protects default branch' do
        project.after_import

        expect(project.protected_branches).not_to be_empty
        expect(project.default_branch).to eq(project.protected_branches.first.name)
        expect(project.protected_branches.first.push_access_levels.map(&:access_level)).to eq([Gitlab::Access::MASTER])
        expect(project.protected_branches.first.merge_access_levels.map(&:access_level)).to eq([Gitlab::Access::MASTER])
      end
    end
3126 3127 3128 3129 3130 3131 3132 3133 3134 3135 3136 3137 3138 3139 3140 3141 3142 3143 3144 3145 3146 3147 3148 3149 3150 3151 3152 3153 3154 3155 3156 3157 3158 3159 3160 3161 3162 3163 3164 3165 3166 3167 3168 3169 3170 3171 3172 3173 3174 3175 3176 3177 3178 3179 3180 3181 3182 3183 3184 3185 3186
  end

  describe '#update_project_counter_caches' do
    let(:project) { create(:project) }

    it 'updates all project counter caches' do
      expect_any_instance_of(Projects::OpenIssuesCountService)
        .to receive(:refresh_cache)
        .and_call_original

      expect_any_instance_of(Projects::OpenMergeRequestsCountService)
        .to receive(:refresh_cache)
        .and_call_original

      project.update_project_counter_caches
    end
  end

  describe '#remove_import_jid', :clean_gitlab_redis_cache do
    let(:project) {  }

    context 'without an import JID' do
      it 'does nothing' do
        project = create(:project)

        expect(Gitlab::SidekiqStatus)
          .not_to receive(:unset)

        project.remove_import_jid
      end
    end

    context 'with an import JID' do
      it 'unsets the import JID' do
        project = create(:project, import_jid: '123')

        expect(Gitlab::SidekiqStatus)
          .to receive(:unset)
          .with('123')
          .and_call_original

        project.remove_import_jid

        expect(project.import_jid).to be_nil
      end
    end
  end

  describe '#wiki_repository_exists?' do
    it 'returns true when the wiki repository exists' do
      project = create(:project, :wiki_repo)

      expect(project.wiki_repository_exists?).to eq(true)
    end

    it 'returns false when the wiki repository does not exist' do
      project = create(:project)

      expect(project.wiki_repository_exists?).to eq(false)
    end
  end
3187

3188 3189 3190 3191 3192 3193
  describe '#write_repository_config' do
    set(:project) { create(:project, :repository) }

    it 'writes full path in .git/config when key is missing' do
      project.write_repository_config

J
Jacob Vosmaer 已提交
3194
      expect(project.repository.rugged.config['gitlab.fullpath']).to eq project.full_path
3195 3196 3197 3198 3199
    end

    it 'updates full path in .git/config when key is present' do
      project.write_repository_config(gl_full_path: 'old/path')

J
Jacob Vosmaer 已提交
3200
      expect { project.write_repository_config }.to change { project.repository.rugged.config['gitlab.fullpath'] }.from('old/path').to(project.full_path)
3201 3202 3203 3204 3205 3206 3207 3208
    end

    it 'does not raise an error with an empty repository' do
      project = create(:project_empty_repo)

      expect { project.write_repository_config }.not_to raise_error
    end
  end
3209 3210 3211 3212 3213 3214 3215 3216 3217 3218 3219 3220 3221

  describe '#execute_hooks' do
    it 'executes the projects hooks with the specified scope' do
      hook1 = create(:project_hook, merge_requests_events: true, tag_push_events: false)
      hook2 = create(:project_hook, merge_requests_events: false, tag_push_events: true)
      project = create(:project, hooks: [hook1, hook2])

      expect_any_instance_of(ProjectHook).to receive(:async_execute).once

      project.execute_hooks({}, :tag_push_hooks)
    end

    it 'executes the system hooks with the specified scope' do
3222
      expect_any_instance_of(SystemHooksService).to receive(:execute_hooks).with({ data: 'data' }, :merge_request_hooks)
3223

3224 3225
      project = build(:project)
      project.execute_hooks({ data: 'data' }, :merge_request_hooks)
3226 3227
    end
  end
G
gitlabhq 已提交
3228
end