project_spec.rb 36.6 KB
Newer Older
G
gitlabhq 已提交
1 2
require 'spec_helper'

D
Douwe Maan 已提交
3
describe Project, models: true do
4
  describe 'associations' do
5 6 7 8 9 10 11 12 13
    it { is_expected.to belong_to(:group) }
    it { is_expected.to belong_to(:namespace) }
    it { is_expected.to belong_to(:creator).class_name('User') }
    it { is_expected.to have_many(:users) }
    it { is_expected.to have_many(:events).dependent(:destroy) }
    it { is_expected.to have_many(:merge_requests).dependent(:destroy) }
    it { is_expected.to have_many(:issues).dependent(:destroy) }
    it { is_expected.to have_many(:milestones).dependent(:destroy) }
    it { is_expected.to have_many(:project_members).dependent(:destroy) }
14 15
    it { is_expected.to have_many(:users).through(:project_members) }
    it { is_expected.to have_many(:requesters).dependent(:destroy) }
16 17 18 19 20 21 22 23 24 25
    it { is_expected.to have_many(:notes).dependent(:destroy) }
    it { is_expected.to have_many(:snippets).class_name('ProjectSnippet').dependent(:destroy) }
    it { is_expected.to have_many(:deploy_keys_projects).dependent(:destroy) }
    it { is_expected.to have_many(:deploy_keys) }
    it { is_expected.to have_many(:hooks).dependent(:destroy) }
    it { is_expected.to have_many(:protected_branches).dependent(:destroy) }
    it { is_expected.to have_one(:forked_project_link).dependent(:destroy) }
    it { is_expected.to have_one(:slack_service).dependent(:destroy) }
    it { is_expected.to have_one(:pushover_service).dependent(:destroy) }
    it { is_expected.to have_one(:asana_service).dependent(:destroy) }
K
Kamil Trzcinski 已提交
26
    it { is_expected.to have_many(:commit_statuses) }
27
    it { is_expected.to have_many(:pipelines) }
28 29 30 31 32
    it { is_expected.to have_many(:builds) }
    it { is_expected.to have_many(:runner_projects) }
    it { is_expected.to have_many(:runners) }
    it { is_expected.to have_many(:variables) }
    it { is_expected.to have_many(:triggers) }
33 34
    it { is_expected.to have_many(:environments).dependent(:destroy) }
    it { is_expected.to have_many(:deployments).dependent(:destroy) }
35
    it { is_expected.to have_many(:todos).dependent(:destroy) }
36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63

    describe '#members & #requesters' do
      let(:project) { create(:project) }
      let(:requester) { create(:user) }
      let(:developer) { create(:user) }
      before do
        project.request_access(requester)
        project.team << [developer, :developer]
      end

      describe '#members' do
        it 'includes members and exclude requesters' do
          member_user_ids = project.members.pluck(:user_id)

          expect(member_user_ids).to include(developer.id)
          expect(member_user_ids).not_to include(requester.id)
        end
      end

      describe '#requesters' do
        it 'does not include requesters' do
          requester_user_ids = project.requesters.pluck(:user_id)

          expect(requester_user_ids).to include(requester.id)
          expect(requester_user_ids).not_to include(developer.id)
        end
      end
    end
G
gitlabhq 已提交
64 65
  end

66 67 68 69 70 71 72 73
  describe 'modules' do
    subject { described_class }

    it { is_expected.to include_module(Gitlab::ConfigHelper) }
    it { is_expected.to include_module(Gitlab::ShellAdapter) }
    it { is_expected.to include_module(Gitlab::VisibilityLevel) }
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
74 75
  end

76
  describe 'validation' do
77 78
    let!(:project) { create(:project) }

79 80
    it { is_expected.to validate_presence_of(:name) }
    it { is_expected.to validate_uniqueness_of(:name).scoped_to(:namespace_id) }
81
    it { is_expected.to validate_length_of(:name).is_within(0..255) }
82

83 84
    it { is_expected.to validate_presence_of(:path) }
    it { is_expected.to validate_uniqueness_of(:path).scoped_to(:namespace_id) }
85 86
    it { is_expected.to validate_length_of(:path).is_within(0..255) }
    it { is_expected.to validate_length_of(:description).is_within(0..2000) }
87 88
    it { is_expected.to validate_presence_of(:creator) }
    it { is_expected.to validate_presence_of(:namespace) }
89
    it { is_expected.to validate_presence_of(:repository_storage) }
90

91
    it 'should not allow new projects beyond user limits' do
92
      project2 = build(:project)
93 94
      allow(project2).to receive(:creator).and_return(double(can_create_project?: false, projects_limit: 0).as_null_object)
      expect(project2).not_to be_valid
P
Phil Hughes 已提交
95
      expect(project2.errors[:limit_reached].first).to match(/Personal project creation is not allowed/)
96
    end
97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117

    describe 'wiki path conflict' do
      context "when the new path has been used by the wiki of other Project" do
        it 'should have an error on the name attribute' do
          new_project = build_stubbed(:project, namespace_id: project.namespace_id, path: "#{project.path}.wiki")

          expect(new_project).not_to be_valid
          expect(new_project.errors[:name].first).to eq('has already been taken')
        end
      end

      context "when the new wiki path has been used by the path of other Project" do
        it 'should have an error on the name attribute' do
          project_with_wiki_suffix = create(:project, path: 'foo.wiki')
          new_project = build_stubbed(:project, namespace_id: project_with_wiki_suffix.namespace_id, path: 'foo')

          expect(new_project).not_to be_valid
          expect(new_project.errors[:name].first).to eq('has already been taken')
        end
      end
    end
118 119 120 121 122 123 124 125 126 127 128 129 130 131

    context 'repository storages inclussion' do
      let(:project2) { build(:project, repository_storage: 'missing') }

      before do
        storages = { 'custom' => 'tmp/tests/custom_repositories' }
        allow(Gitlab.config.repositories).to receive(:storages).and_return(storages)
      end

      it "should not allow repository storages that don't match a label in the configuration" do
        expect(project2).not_to be_valid
        expect(project2.errors[:repository_storage].first).to match(/is not included in the list/)
      end
    end
132

133
    it 'should not allow an invalid URI as import_url' do
J
James Lopez 已提交
134 135 136 137 138 139 140 141
      project2 = build(:project, import_url: 'invalid://')

      expect(project2).not_to be_valid
    end

    it 'should allow a valid URI as import_url' do
      project2 = build(:project, import_url: 'ssh://test@gitlab.com/project.git')

142 143
      expect(project2).to be_valid
    end
G
gitlabhq 已提交
144
  end
145

146 147 148 149 150 151 152 153 154
  describe 'default_scope' do
    it 'excludes projects pending deletion from the results' do
      project = create(:empty_project)
      create(:empty_project, pending_delete: true)

      expect(Project.all).to eq [project]
    end
  end

K
Kamil Trzcinski 已提交
155 156
  describe 'project token' do
    it 'should set an random token if none provided' do
K
Kamil Trzcinski 已提交
157 158
      project = FactoryGirl.create :empty_project, runners_token: ''
      expect(project.runners_token).not_to eq('')
K
Kamil Trzcinski 已提交
159 160 161
    end

    it 'should not set an random toke if one provided' do
K
Kamil Trzcinski 已提交
162 163
      project = FactoryGirl.create :empty_project, runners_token: 'my-token'
      expect(project.runners_token).to eq('my-token')
K
Kamil Trzcinski 已提交
164 165
    end
  end
G
gitlabhq 已提交
166

167
  describe 'Respond to' do
168 169 170 171 172 173
    it { is_expected.to respond_to(:url_to_repo) }
    it { is_expected.to respond_to(:repo_exists?) }
    it { is_expected.to respond_to(:update_merge_requests) }
    it { is_expected.to respond_to(:execute_hooks) }
    it { is_expected.to respond_to(:owner) }
    it { is_expected.to respond_to(:path_with_namespace) }
G
gitlabhq 已提交
174 175
  end

R
Rémy Coutable 已提交
176 177 178 179 180 181 182
  describe '#name_with_namespace' do
    let(:project) { build_stubbed(:empty_project) }

    it { expect(project.name_with_namespace).to eq "#{project.namespace.human_name} / #{project.name}" }
    it { expect(project.human_name).to eq project.name_with_namespace }
  end

183 184 185 186 187 188 189 190
  describe '#to_reference' do
    let(:project) { create(:empty_project) }

    it 'returns a String reference to the object' do
      expect(project.to_reference).to eq project.path_with_namespace
    end
  end

191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208
  describe '#repository_storage_path' do
    let(:project) { create(:project, repository_storage: 'custom') }

    before do
      FileUtils.mkdir('tmp/tests/custom_repositories')
      storages = { 'custom' => 'tmp/tests/custom_repositories' }
      allow(Gitlab.config.repositories).to receive(:storages).and_return(storages)
    end

    after do
      FileUtils.rm_rf('tmp/tests/custom_repositories')
    end

    it 'returns the repository storage path' do
      expect(project.repository_storage_path).to eq('tmp/tests/custom_repositories')
    end
  end

209 210
  it 'should return valid url to repo' do
    project = Project.new(path: 'somewhere')
211
    expect(project.url_to_repo).to eq(Gitlab.config.gitlab_shell.ssh_path_prefix + 'somewhere.git')
G
gitlabhq 已提交
212 213
  end

D
Douwe Maan 已提交
214 215 216 217 218 219
  describe "#web_url" do
    let(:project) { create(:empty_project, path: "somewhere") }

    it 'returns the full web URL for this repo' do
      expect(project.web_url).to eq("#{Gitlab.config.gitlab.url}/#{project.namespace.path}/somewhere")
    end
A
Ariejan de Vroom 已提交
220 221
  end

D
Douwe Maan 已提交
222 223 224 225 226 227
  describe "#web_url_without_protocol" do
    let(:project) { create(:empty_project, path: "somewhere") }

    it 'returns the web URL without the protocol for this repo' do
      expect(project.web_url_without_protocol).to eq("#{Gitlab.config.gitlab.url.split('://')[1]}/#{project.namespace.path}/somewhere")
    end
228 229
  end

230
  describe 'last_activity methods' do
I
Izaak Alpert 已提交
231
    let(:project) { create(:project) }
232
    let(:last_event) { double(created_at: Time.now) }
G
gitlabhq 已提交
233

234 235
    describe 'last_activity' do
      it 'should alias last_activity to last_event' do
236
        allow(project).to receive(:last_event).and_return(last_event)
237
        expect(project.last_activity).to eq(last_event)
238
      end
G
gitlabhq 已提交
239 240
    end

241 242
    describe 'last_activity_date' do
      it 'returns the creation date of the project\'s last event if present' do
243
        create(:event, project: project)
244
        expect(project.last_activity_at.to_i).to eq(last_event.created_at.to_i)
245
      end
246

247
      it 'returns the project\'s last update date if it has no events' do
248
        expect(project.last_activity_date).to eq(project.updated_at)
249
      end
250 251
    end
  end
252

253 254
  describe '#get_issue' do
    let(:project) { create(:empty_project) }
S
Stan Hu 已提交
255
    let!(:issue)  { create(:issue, project: project) }
256 257 258 259 260 261

    context 'with default issues tracker' do
      it 'returns an issue' do
        expect(project.get_issue(issue.iid)).to eq issue
      end

S
Stan Hu 已提交
262 263 264 265
      it 'returns count of open issues' do
        expect(project.open_issues_count).to eq(1)
      end

266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298
      it 'returns nil when no issue found' do
        expect(project.get_issue(999)).to be_nil
      end
    end

    context 'with external issues tracker' do
      before do
        allow(project).to receive(:default_issues_tracker?).and_return(false)
      end

      it 'returns an ExternalIssue' do
        issue = project.get_issue('FOO-1234')
        expect(issue).to be_kind_of(ExternalIssue)
        expect(issue.iid).to eq 'FOO-1234'
        expect(issue.project).to eq project
      end
    end
  end

  describe '#issue_exists?' do
    let(:project) { create(:empty_project) }

    it 'is truthy when issue exists' do
      expect(project).to receive(:get_issue).and_return(double)
      expect(project.issue_exists?(1)).to be_truthy
    end

    it 'is falsey when issue does not exist' do
      expect(project).to receive(:get_issue).and_return(nil)
      expect(project.issue_exists?(1)).to be_falsey
    end
  end

299
  describe :update_merge_requests do
D
Dmitriy Zaporozhets 已提交
300
    let(:project) { create(:project) }
301 302 303 304
    let(:merge_request) { create(:merge_request, source_project: project, target_project: project) }
    let(:key) { create(:key, user_id: project.owner.id) }
    let(:prev_commit_id) { merge_request.commits.last.id }
    let(:commit_id) { merge_request.commits.first.id }
305

306
    it 'should close merge request if last commit from source branch was pushed to target branch' do
307 308
      project.update_merge_requests(prev_commit_id, commit_id, "refs/heads/#{merge_request.target_branch}", key.user)
      merge_request.reload
309
      expect(merge_request.merged?).to be_truthy
310 311
    end

312
    it 'should update merge request commits with new one if pushed to source branch' do
313 314
      project.update_merge_requests(prev_commit_id, commit_id, "refs/heads/#{merge_request.source_branch}", key.user)
      merge_request.reload
315
      expect(merge_request.diff_head_sha).to eq(commit_id)
316 317
    end
  end
318

319
  describe '.find_with_namespace' do
320 321 322
    context 'with namespace' do
      before do
        @group = create :group, name: 'gitlab'
D
Dmitriy Zaporozhets 已提交
323
        @project = create(:project, name: 'gitlabhq', namespace: @group)
324 325
      end

326
      it { expect(Project.find_with_namespace('gitlab/gitlabhq')).to eq(@project) }
327
      it { expect(Project.find_with_namespace('GitLab/GitlabHQ')).to eq(@project) }
328
      it { expect(Project.find_with_namespace('gitlab-ci')).to be_nil }
329
    end
330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345

    context 'when multiple projects using a similar name exist' do
      let(:group) { create(:group, name: 'gitlab') }

      let!(:project1) do
        create(:empty_project, name: 'gitlab1', path: 'gitlab', namespace: group)
      end

      let!(:project2) do
        create(:empty_project, name: 'gitlab2', path: 'GITLAB', namespace: group)
      end

      it 'returns the row where the path matches literally' do
        expect(Project.find_with_namespace('gitlab/GITLAB')).to eq(project2)
      end
    end
346 347 348 349 350 351
  end

  describe :to_param do
    context 'with namespace' do
      before do
        @group = create :group, name: 'gitlab'
D
Dmitriy Zaporozhets 已提交
352
        @project = create(:project, name: 'gitlabhq', namespace: @group)
353 354
      end

V
Vinnie Okada 已提交
355
      it { expect(@project.to_param).to eq('gitlabhq') }
356 357
    end
  end
D
Dmitriy Zaporozhets 已提交
358

359
  describe :repository do
D
Dmitriy Zaporozhets 已提交
360 361
    let(:project) { create(:project) }

362
    it 'should return valid repo' do
363
      expect(project.repository).to be_kind_of(Repository)
D
Dmitriy Zaporozhets 已提交
364 365
    end
  end
366

367
  describe :default_issues_tracker? do
368 369 370 371
    let(:project) { create(:project) }
    let(:ext_project) { create(:redmine_project) }

    it "should be true if used internal tracker" do
372
      expect(project.default_issues_tracker?).to be_truthy
373 374 375
    end

    it "should be false if used other tracker" do
376
      expect(ext_project.default_issues_tracker?).to be_falsey
377 378 379
    end
  end

380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442
  describe :external_issue_tracker do
    let(:project) { create(:project) }
    let(:ext_project) { create(:redmine_project) }

    context 'on existing projects with no value for has_external_issue_tracker' do
      before(:each) do
        project.update_column(:has_external_issue_tracker, nil)
        ext_project.update_column(:has_external_issue_tracker, nil)
      end

      it 'updates the has_external_issue_tracker boolean' do
        expect do
          project.external_issue_tracker
        end.to change { project.reload.has_external_issue_tracker }.to(false)

        expect do
          ext_project.external_issue_tracker
        end.to change { ext_project.reload.has_external_issue_tracker }.to(true)
      end
    end

    it 'returns nil and does not query services when there is no external issue tracker' do
      project.build_missing_services
      project.reload

      expect(project).not_to receive(:services)

      expect(project.external_issue_tracker).to eq(nil)
    end

    it 'retrieves external_issue_tracker querying services and cache it when there is external issue tracker' do
      ext_project.reload # Factory returns a project with changed attributes
      ext_project.build_missing_services
      ext_project.reload

      expect(ext_project).to receive(:services).once.and_call_original

      2.times { expect(ext_project.external_issue_tracker).to be_a_kind_of(RedmineService) }
    end
  end

  describe :cache_has_external_issue_tracker do
    let(:project) { create(:project) }

    it 'stores true if there is any external_issue_tracker' do
      services = double(:service, external_issue_trackers: [RedmineService.new])
      expect(project).to receive(:services).and_return(services)

      expect do
        project.cache_has_external_issue_tracker
      end.to change { project.has_external_issue_tracker}.to(true)
    end

    it 'stores false if there is no external_issue_tracker' do
      services = double(:service, external_issue_trackers: [])
      expect(project).to receive(:services).and_return(services)

      expect do
        project.cache_has_external_issue_tracker
      end.to change { project.has_external_issue_tracker}.to(false)
    end
  end

443
  describe :open_branches do
D
Dmitriy Zaporozhets 已提交
444
    let(:project) { create(:project) }
445 446 447 448 449

    before do
      project.protected_branches.create(name: 'master')
    end

450 451
    it { expect(project.open_branches.map(&:name)).to include('feature') }
    it { expect(project.open_branches.map(&:name)).not_to include('master') }
452

453
    it "includes branches matching a protected branch wildcard" do
454 455 456 457
      expect(project.open_branches.map(&:name)).to include('feature')

      create(:protected_branch, name: 'feat*', project: project)

458
      expect(Project.find(project.id).open_branches.map(&:name)).to include('feature')
459
    end
460
  end
C
Ciro Santilli 已提交
461

462 463
  describe '#star_count' do
    it 'counts stars from multiple users' do
C
Ciro Santilli 已提交
464 465 466 467 468
      user1 = create :user
      user2 = create :user
      project = create :project, :public

      expect(project.star_count).to eq(0)
469

C
Ciro Santilli 已提交
470
      user1.toggle_star(project)
471 472
      expect(project.reload.star_count).to eq(1)

C
Ciro Santilli 已提交
473
      user2.toggle_star(project)
474 475 476
      project.reload
      expect(project.reload.star_count).to eq(2)

C
Ciro Santilli 已提交
477
      user1.toggle_star(project)
478 479 480
      project.reload
      expect(project.reload.star_count).to eq(1)

C
Ciro Santilli 已提交
481
      user2.toggle_star(project)
482 483 484 485
      project.reload
      expect(project.reload.star_count).to eq(0)
    end

486
    it 'counts stars on the right project' do
487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516
      user = create :user
      project1 = create :project, :public
      project2 = create :project, :public

      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project1)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(1)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project1)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project2)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(1)

      user.toggle_star(project2)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)
C
Ciro Santilli 已提交
517 518
    end
  end
519 520 521 522 523 524

  describe :avatar_type do
    let(:project) { create(:project) }

    it 'should be true if avatar is image' do
      project.update_attribute(:avatar, 'uploads/avatar.png')
525
      expect(project.avatar_type).to be_truthy
526 527 528 529
    end

    it 'should be false if avatar is html page' do
      project.update_attribute(:avatar, 'uploads/avatar.html')
530
      expect(project.avatar_type).to eq(['only images allowed'])
531 532
    end
  end
S
sue445 已提交
533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562

  describe :avatar_url do
    subject { project.avatar_url }

    let(:project) { create(:project) }

    context 'When avatar file is uploaded' do
      before do
        project.update_columns(avatar: 'uploads/avatar.png')
        allow(project.avatar).to receive(:present?) { true }
      end

      let(:avatar_path) do
        "/uploads/project/avatar/#{project.id}/uploads/avatar.png"
      end

      it { should eq "http://localhost#{avatar_path}" }
    end

    context 'When avatar file in git' do
      before do
        allow(project).to receive(:avatar_in_git) { true }
      end

      let(:avatar_path) do
        "/#{project.namespace.name}/#{project.path}/avatar"
      end

      it { should eq "http://localhost#{avatar_path}" }
    end
563 564 565 566 567 568

    context 'when git repo is empty' do
      let(:project) { create(:empty_project) }

      it { should eq nil }
    end
S
sue445 已提交
569
  end
570

571
  describe :pipeline do
572
    let(:project) { create :project }
K
Kamil Trzcinski 已提交
573
    let(:pipeline) { create :ci_pipeline, project: project, ref: 'master' }
574

575
    subject { project.pipeline(pipeline.sha, 'master') }
K
Kamil Trzcinski 已提交
576

577
    it { is_expected.to eq(pipeline) }
K
Kamil Trzcinski 已提交
578 579

    context 'return latest' do
K
Kamil Trzcinski 已提交
580
      let(:pipeline2) { create :ci_pipeline, project: project, ref: 'master' }
K
Kamil Trzcinski 已提交
581 582

      before do
583 584
        pipeline
        pipeline2
K
Kamil Trzcinski 已提交
585 586
      end

587
      it { is_expected.to eq(pipeline2) }
K
Kamil Trzcinski 已提交
588
    end
589
  end
590

591
  describe :builds_enabled do
592 593
    let(:project) { create :project }

594
    before { project.builds_enabled = true }
595

596 597 598
    subject { project.builds_enabled }

    it { expect(project.builds_enabled?).to be_truthy }
599
  end
Y
Yorick Peterse 已提交
600 601

  describe '.trending' do
F
Felipe Artur 已提交
602
    let(:group)    { create(:group, :public) }
Y
Yorick Peterse 已提交
603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628
    let(:project1) { create(:empty_project, :public, group: group) }
    let(:project2) { create(:empty_project, :public, group: group) }

    before do
      2.times do
        create(:note_on_commit, project: project1)
      end

      create(:note_on_commit, project: project2)
    end

    describe 'without an explicit start date' do
      subject { described_class.trending.to_a }

      it 'sorts Projects by the amount of notes in descending order' do
        expect(subject).to eq([project1, project2])
      end
    end

    describe 'with an explicit start date' do
      let(:date) { 2.months.ago }

      subject { described_class.trending(date).to_a }

      before do
        2.times do
629 630 631
          # Little fix for special issue related to Fractional Seconds support for MySQL.
          # See: https://github.com/rails/rails/pull/14359/files
          create(:note_on_commit, project: project2, created_at: date + 1)
Y
Yorick Peterse 已提交
632 633 634 635 636 637 638 639
        end
      end

      it 'sorts Projects by the amount of notes in descending order' do
        expect(subject).to eq([project2, project1])
      end
    end
  end
Y
Yorick Peterse 已提交
640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658

  describe '.visible_to_user' do
    let!(:project) { create(:project, :private) }
    let!(:user)    { create(:user) }

    subject { described_class.visible_to_user(user) }

    describe 'when a user has access to a project' do
      before do
        project.team.add_user(user, Gitlab::Access::MASTER)
      end

      it { is_expected.to eq([project]) }
    end

    describe 'when a user does not have access to any projects' do
      it { is_expected.to eq([]) }
    end
  end
K
Kamil Trzcinski 已提交
659

660 661 662 663 664 665 666 667 668 669 670 671 672 673 674
  context 'repository storage by default' do
    let(:project) { create(:empty_project) }

    subject { project.repository_storage }

    before do
      storages = { 'alternative_storage' => '/some/path' }
      allow(Gitlab.config.repositories).to receive(:storages).and_return(storages)
      stub_application_setting(repository_storage: 'alternative_storage')
      allow_any_instance_of(Project).to receive(:ensure_dir_exist).and_return(true)
    end

    it { is_expected.to eq('alternative_storage') }
  end

K
Kamil Trzcinski 已提交
675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694
  context 'shared runners by default' do
    let(:project) { create(:empty_project) }

    subject { project.shared_runners_enabled }

    context 'are enabled' do
      before { stub_application_setting(shared_runners_enabled: true) }

      it { is_expected.to be_truthy }
    end

    context 'are disabled' do
      before { stub_application_setting(shared_runners_enabled: false) }

      it { is_expected.to be_falsey }
    end
  end

  describe :any_runners do
    let(:project) { create(:empty_project, shared_runners_enabled: shared_runners_enabled) }
695 696
    let(:specific_runner) { create(:ci_runner) }
    let(:shared_runner) { create(:ci_runner, :shared) }
K
Kamil Trzcinski 已提交
697 698 699

    context 'for shared runners disabled' do
      let(:shared_runners_enabled) { false }
700

K
Kamil Trzcinski 已提交
701 702 703
      it 'there are no runners available' do
        expect(project.any_runners?).to be_falsey
      end
704

K
Kamil Trzcinski 已提交
705
      it 'there is a specific runner' do
706
        project.runners << specific_runner
K
Kamil Trzcinski 已提交
707 708
        expect(project.any_runners?).to be_truthy
      end
709

K
Kamil Trzcinski 已提交
710 711 712 713
      it 'there is a shared runner, but they are prohibited to use' do
        shared_runner
        expect(project.any_runners?).to be_falsey
      end
714

K
Kamil Trzcinski 已提交
715
      it 'checks the presence of specific runner' do
716
        project.runners << specific_runner
K
Kamil Trzcinski 已提交
717 718 719
        expect(project.any_runners? { |runner| runner == specific_runner }).to be_truthy
      end
    end
720

K
Kamil Trzcinski 已提交
721 722
    context 'for shared runners enabled' do
      let(:shared_runners_enabled) { true }
723

K
Kamil Trzcinski 已提交
724 725 726 727 728 729 730 731 732 733 734
      it 'there is a shared runner' do
        shared_runner
        expect(project.any_runners?).to be_truthy
      end

      it 'checks the presence of shared runner' do
        shared_runner
        expect(project.any_runners? { |runner| runner == shared_runner }).to be_truthy
      end
    end
  end
735 736

  describe '#visibility_level_allowed?' do
737
    let(:project) { create(:project, :internal) }
738 739 740 741 742 743 744 745

    context 'when checking on non-forked project' do
      it { expect(project.visibility_level_allowed?(Gitlab::VisibilityLevel::PRIVATE)).to be_truthy }
      it { expect(project.visibility_level_allowed?(Gitlab::VisibilityLevel::INTERNAL)).to be_truthy }
      it { expect(project.visibility_level_allowed?(Gitlab::VisibilityLevel::PUBLIC)).to be_truthy }
    end

    context 'when checking on forked project' do
746 747
      let(:project)        { create(:project, :internal) }
      let(:forked_project) { create(:project, forked_from_project: project) }
748 749 750 751 752

      it { expect(forked_project.visibility_level_allowed?(Gitlab::VisibilityLevel::PRIVATE)).to be_truthy }
      it { expect(forked_project.visibility_level_allowed?(Gitlab::VisibilityLevel::INTERNAL)).to be_truthy }
      it { expect(forked_project.visibility_level_allowed?(Gitlab::VisibilityLevel::PUBLIC)).to be_falsey }
    end
753
  end
754

755 756
  describe '.search' do
    let(:project) { create(:project, description: 'kitten mittens') }
757

758 759 760
    it 'returns projects with a matching name' do
      expect(described_class.search(project.name)).to eq([project])
    end
761

762 763 764
    it 'returns projects with a partially matching name' do
      expect(described_class.search(project.name[0..2])).to eq([project])
    end
765

766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804
    it 'returns projects with a matching name regardless of the casing' do
      expect(described_class.search(project.name.upcase)).to eq([project])
    end

    it 'returns projects with a matching description' do
      expect(described_class.search(project.description)).to eq([project])
    end

    it 'returns projects with a partially matching description' do
      expect(described_class.search('kitten')).to eq([project])
    end

    it 'returns projects with a matching description regardless of the casing' do
      expect(described_class.search('KITTEN')).to eq([project])
    end

    it 'returns projects with a matching path' do
      expect(described_class.search(project.path)).to eq([project])
    end

    it 'returns projects with a partially matching path' do
      expect(described_class.search(project.path[0..2])).to eq([project])
    end

    it 'returns projects with a matching path regardless of the casing' do
      expect(described_class.search(project.path.upcase)).to eq([project])
    end

    it 'returns projects with a matching namespace name' do
      expect(described_class.search(project.namespace.name)).to eq([project])
    end

    it 'returns projects with a partially matching namespace name' do
      expect(described_class.search(project.namespace.name[0..2])).to eq([project])
    end

    it 'returns projects with a matching namespace name regardless of the casing' do
      expect(described_class.search(project.namespace.name.upcase)).to eq([project])
    end
805 806 807 808 809

    it 'returns projects when eager loading namespaces' do
      relation = described_class.all.includes(:namespace)

      expect(relation.search(project.namespace.name)).to eq([project])
810
    end
811
  end
812 813 814 815 816 817 818 819 820 821 822

  describe '#rename_repo' do
    let(:project) { create(:project) }
    let(:gitlab_shell) { Gitlab::Shell.new }

    before do
      # Project#gitlab_shell returns a new instance of Gitlab::Shell on every
      # call. This makes testing a bit easier.
      allow(project).to receive(:gitlab_shell).and_return(gitlab_shell)

      allow(project).to receive(:previous_changes).and_return('path' => ['foo'])
K
Kamil Trzcinski 已提交
823
    end
824

K
Kamil Trzcinski 已提交
825
    it 'renames a repository' do
826 827 828 829
      ns = project.namespace_dir

      expect(gitlab_shell).to receive(:mv_repository).
        ordered.
830
        with(project.repository_storage_path, "#{ns}/foo", "#{ns}/#{project.path}").
831 832 833 834
        and_return(true)

      expect(gitlab_shell).to receive(:mv_repository).
        ordered.
835
        with(project.repository_storage_path, "#{ns}/foo.wiki", "#{ns}/#{project.path}.wiki").
836 837 838 839 840 841 842 843 844 845 846 847 848 849
        and_return(true)

      expect_any_instance_of(SystemHooksService).
        to receive(:execute_hooks_for).
        with(project, :rename)

      expect_any_instance_of(Gitlab::UploadsTransfer).
        to receive(:rename_project).
        with('foo', project.path, ns)

      expect(project).to receive(:expire_caches_before_rename)

      project.rename_repo
    end
K
Kamil Trzcinski 已提交
850 851 852 853 854 855 856 857 858 859 860

    context 'container registry with tags' do
      before do
        stub_container_registry_config(enabled: true)
        stub_container_registry_tags('tag')
      end

      subject { project.rename_repo }

      it { expect{subject}.to raise_error(Exception) }
    end
861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876
  end

  describe '#expire_caches_before_rename' do
    let(:project) { create(:project) }
    let(:repo)    { double(:repo, exists?: true) }
    let(:wiki)    { double(:wiki, exists?: true) }

    it 'expires the caches of the repository and wiki' do
      allow(Repository).to receive(:new).
        with('foo', project).
        and_return(repo)

      allow(Repository).to receive(:new).
        with('foo.wiki', project).
        and_return(wiki)

877 878
      expect(repo).to receive(:before_delete)
      expect(wiki).to receive(:before_delete)
879 880 881 882

      project.expire_caches_before_rename('foo')
    end
  end
883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898

  describe '.search_by_title' do
    let(:project) { create(:project, name: 'kittens') }

    it 'returns projects with a matching name' do
      expect(described_class.search_by_title(project.name)).to eq([project])
    end

    it 'returns projects with a partially matching name' do
      expect(described_class.search_by_title('kitten')).to eq([project])
    end

    it 'returns projects with a matching name regardless of the casing' do
      expect(described_class.search_by_title('KITTENS')).to eq([project])
    end
  end
899 900 901 902 903

  context 'when checking projects from groups' do
    let(:private_group)    { create(:group, visibility_level: 0)  }
    let(:internal_group)   { create(:group, visibility_level: 10) }

D
Douwe Maan 已提交
904 905
    let(:private_project)  { create :project, :private, group: private_group }
    let(:internal_project) { create :project, :internal, group: internal_group }
906 907 908 909 910 911 912 913 914

    context 'when group is private project can not be internal' do
      it { expect(private_project.visibility_level_allowed?(Gitlab::VisibilityLevel::INTERNAL)).to be_falsey }
    end

    context 'when group is internal project can not be public' do
      it { expect(internal_project.visibility_level_allowed?(Gitlab::VisibilityLevel::PUBLIC)).to be_falsey }
    end
  end
915

916 917 918 919 920 921 922 923 924 925 926
  describe '#create_repository' do
    let(:project) { create(:project) }
    let(:shell) { Gitlab::Shell.new }

    before do
      allow(project).to receive(:gitlab_shell).and_return(shell)
    end

    context 'using a regular repository' do
      it 'creates the repository' do
        expect(shell).to receive(:add_repository).
927
          with(project.repository_storage_path, project.path_with_namespace).
928 929 930 931 932 933 934 935 936
          and_return(true)

        expect(project.repository).to receive(:after_create)

        expect(project.create_repository).to eq(true)
      end

      it 'adds an error if the repository could not be created' do
        expect(shell).to receive(:add_repository).
937
          with(project.repository_storage_path, project.path_with_namespace).
938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955
          and_return(false)

        expect(project.repository).not_to receive(:after_create)

        expect(project.create_repository).to eq(false)
        expect(project.errors).not_to be_empty
      end
    end

    context 'using a forked repository' do
      it 'does nothing' do
        expect(project).to receive(:forked?).and_return(true)
        expect(shell).not_to receive(:add_repository)

        project.create_repository
      end
    end
  end
956 957 958 959

  describe '#protected_branch?' do
    let(:project) { create(:empty_project) }

960
    it 'returns true when the branch matches a protected branch via direct match' do
961 962 963 964 965
      project.protected_branches.create!(name: 'foo')

      expect(project.protected_branch?('foo')).to eq(true)
    end

966 967 968 969 970 971 972
    it 'returns true when the branch matches a protected branch via wildcard match' do
      project.protected_branches.create!(name: 'production/*')

      expect(project.protected_branch?('production/some-branch')).to eq(true)
    end

    it 'returns false when the branch does not match a protected branch via direct match' do
973 974
      expect(project.protected_branch?('foo')).to eq(false)
    end
975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020

    it 'returns false when the branch does not match a protected branch via wildcard match' do
      project.protected_branches.create!(name: 'production/*')

      expect(project.protected_branch?('staging/some-branch')).to eq(false)
    end
  end

  describe "#developers_can_push_to_protected_branch?" do
    let(:project) { create(:empty_project) }

    context "when the branch matches a protected branch via direct match" do
      it "returns true if 'Developers can Push' is turned on" do
        create(:protected_branch, name: "production", project: project, developers_can_push: true)

        expect(project.developers_can_push_to_protected_branch?('production')).to be true
      end

      it "returns false if 'Developers can Push' is turned off" do
        create(:protected_branch, name: "production", project: project, developers_can_push: false)

        expect(project.developers_can_push_to_protected_branch?('production')).to be false
      end
    end

    context "when the branch matches a protected branch via wilcard match" do
      it "returns true if 'Developers can Push' is turned on" do
        create(:protected_branch, name: "production/*", project: project, developers_can_push: true)

        expect(project.developers_can_push_to_protected_branch?('production/some-branch')).to be true
      end

      it "returns false if 'Developers can Push' is turned off" do
        create(:protected_branch, name: "production/*", project: project, developers_can_push: false)

        expect(project.developers_can_push_to_protected_branch?('production/some-branch')).to be false
      end
    end

    context "when the branch does not match a protected branch" do
      it "returns false" do
        create(:protected_branch, name: "production/*", project: project, developers_can_push: true)

        expect(project.developers_can_push_to_protected_branch?('staging/some-branch')).to be false
      end
    end
1021
  end
K
Kamil Trzcinski 已提交
1022

1023 1024 1025 1026 1027 1028 1029 1030 1031
  describe '#container_registry_path_with_namespace' do
    let(:project) { create(:empty_project, path: 'PROJECT') }

    subject { project.container_registry_path_with_namespace }

    it { is_expected.not_to eq(project.path_with_namespace) }
    it { is_expected.to eq(project.path_with_namespace.downcase) }
  end

K
Kamil Trzcinski 已提交
1032 1033 1034
  describe '#container_registry_repository' do
    let(:project) { create(:empty_project) }

K
Kamil Trzcinski 已提交
1035 1036
    before { stub_container_registry_config(enabled: true) }

K
Kamil Trzcinski 已提交
1037 1038
    subject { project.container_registry_repository }

1039
    it { is_expected.not_to be_nil }
K
Kamil Trzcinski 已提交
1040 1041 1042 1043 1044 1045 1046
  end

  describe '#container_registry_repository_url' do
    let(:project) { create(:empty_project) }

    subject { project.container_registry_repository_url }

1047
    before { stub_container_registry_config(**registry_settings) }
K
Kamil Trzcinski 已提交
1048 1049 1050 1051 1052 1053 1054 1055 1056

    context 'for enabled registry' do
      let(:registry_settings) do
        {
          enabled: true,
          host_port: 'example.com',
        }
      end

1057
      it { is_expected.not_to be_nil }
K
Kamil Trzcinski 已提交
1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076
    end

    context 'for disabled registry' do
      let(:registry_settings) do
        {
          enabled: false
        }
      end

      it { is_expected.to be_nil }
    end
  end

  describe '#has_container_registry_tags?' do
    let(:project) { create(:empty_project) }

    subject { project.has_container_registry_tags? }

    context 'for enabled registry' do
1077
      before { stub_container_registry_config(enabled: true) }
K
Kamil Trzcinski 已提交
1078 1079

      context 'with tags' do
K
Kamil Trzcinski 已提交
1080
        before { stub_container_registry_tags('test', 'test2') }
K
Kamil Trzcinski 已提交
1081 1082 1083 1084 1085

        it { is_expected.to be_truthy }
      end

      context 'when no tags' do
K
Kamil Trzcinski 已提交
1086
        before { stub_container_registry_tags }
K
Kamil Trzcinski 已提交
1087 1088 1089 1090 1091 1092

        it { is_expected.to be_falsey }
      end
    end

    context 'for disabled registry' do
1093
      before { stub_container_registry_config(enabled: false) }
K
Kamil Trzcinski 已提交
1094 1095 1096 1097

      it { is_expected.to be_falsey }
    end
  end
Y
Yorick Peterse 已提交
1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130

  describe '.where_paths_in' do
    context 'without any paths' do
      it 'returns an empty relation' do
        expect(Project.where_paths_in([])).to eq([])
      end
    end

    context 'without any valid paths' do
      it 'returns an empty relation' do
        expect(Project.where_paths_in(%w[foo])).to eq([])
      end
    end

    context 'with valid paths' do
      let!(:project1) { create(:project) }
      let!(:project2) { create(:project) }

      it 'returns the projects matching the paths' do
        projects = Project.where_paths_in([project1.path_with_namespace,
                                           project2.path_with_namespace])

        expect(projects).to contain_exactly(project1, project2)
      end

      it 'returns projects regardless of the casing of paths' do
        projects = Project.where_paths_in([project1.path_with_namespace.upcase,
                                           project2.path_with_namespace.upcase])

        expect(projects).to contain_exactly(project1, project2)
      end
    end
  end
G
gitlabhq 已提交
1131
end