project_spec.rb 54.1 KB
Newer Older
G
gitlabhq 已提交
1 2
require 'spec_helper'

D
Douwe Maan 已提交
3
describe Project, models: true do
4
  describe 'associations' do
5 6 7 8
    it { is_expected.to belong_to(:group) }
    it { is_expected.to belong_to(:namespace) }
    it { is_expected.to belong_to(:creator).class_name('User') }
    it { is_expected.to have_many(:users) }
U
ubudzisz 已提交
9
    it { is_expected.to have_many(:services) }
10 11 12 13 14
    it { is_expected.to have_many(:events).dependent(:destroy) }
    it { is_expected.to have_many(:merge_requests).dependent(:destroy) }
    it { is_expected.to have_many(:issues).dependent(:destroy) }
    it { is_expected.to have_many(:milestones).dependent(:destroy) }
    it { is_expected.to have_many(:project_members).dependent(:destroy) }
15 16
    it { is_expected.to have_many(:users).through(:project_members) }
    it { is_expected.to have_many(:requesters).dependent(:destroy) }
17 18 19 20 21 22 23 24 25 26
    it { is_expected.to have_many(:notes).dependent(:destroy) }
    it { is_expected.to have_many(:snippets).class_name('ProjectSnippet').dependent(:destroy) }
    it { is_expected.to have_many(:deploy_keys_projects).dependent(:destroy) }
    it { is_expected.to have_many(:deploy_keys) }
    it { is_expected.to have_many(:hooks).dependent(:destroy) }
    it { is_expected.to have_many(:protected_branches).dependent(:destroy) }
    it { is_expected.to have_one(:forked_project_link).dependent(:destroy) }
    it { is_expected.to have_one(:slack_service).dependent(:destroy) }
    it { is_expected.to have_one(:pushover_service).dependent(:destroy) }
    it { is_expected.to have_one(:asana_service).dependent(:destroy) }
27
    it { is_expected.to have_many(:boards).dependent(:destroy) }
U
ubudzisz 已提交
28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51
    it { is_expected.to have_one(:campfire_service).dependent(:destroy) }
    it { is_expected.to have_one(:drone_ci_service).dependent(:destroy) }
    it { is_expected.to have_one(:emails_on_push_service).dependent(:destroy) }
    it { is_expected.to have_one(:builds_email_service).dependent(:destroy) }
    it { is_expected.to have_one(:emails_on_push_service).dependent(:destroy) }
    it { is_expected.to have_one(:irker_service).dependent(:destroy) }
    it { is_expected.to have_one(:pivotaltracker_service).dependent(:destroy) }
    it { is_expected.to have_one(:hipchat_service).dependent(:destroy) }
    it { is_expected.to have_one(:flowdock_service).dependent(:destroy) }
    it { is_expected.to have_one(:assembla_service).dependent(:destroy) }
    it { is_expected.to have_one(:gemnasium_service).dependent(:destroy) }
    it { is_expected.to have_one(:buildkite_service).dependent(:destroy) }
    it { is_expected.to have_one(:bamboo_service).dependent(:destroy) }
    it { is_expected.to have_one(:teamcity_service).dependent(:destroy) }
    it { is_expected.to have_one(:jira_service).dependent(:destroy) }
    it { is_expected.to have_one(:redmine_service).dependent(:destroy) }
    it { is_expected.to have_one(:custom_issue_tracker_service).dependent(:destroy) }
    it { is_expected.to have_one(:bugzilla_service).dependent(:destroy) }
    it { is_expected.to have_one(:gitlab_issue_tracker_service).dependent(:destroy) }
    it { is_expected.to have_one(:external_wiki_service).dependent(:destroy) }
    it { is_expected.to have_one(:project_feature).dependent(:destroy) }
    it { is_expected.to have_one(:import_data).class_name('ProjectImportData').dependent(:destroy) }
    it { is_expected.to have_one(:last_event).class_name('Event') }
    it { is_expected.to have_one(:forked_from_project).through(:forked_project_link) }
K
Kamil Trzcinski 已提交
52
    it { is_expected.to have_many(:commit_statuses) }
53
    it { is_expected.to have_many(:pipelines) }
54 55 56 57 58
    it { is_expected.to have_many(:builds) }
    it { is_expected.to have_many(:runner_projects) }
    it { is_expected.to have_many(:runners) }
    it { is_expected.to have_many(:variables) }
    it { is_expected.to have_many(:triggers) }
D
Douglas Barbosa Alexandre 已提交
59
    it { is_expected.to have_many(:labels).class_name('ProjectLabel').dependent(:destroy) }
U
ubudzisz 已提交
60
    it { is_expected.to have_many(:users_star_projects).dependent(:destroy) }
61 62
    it { is_expected.to have_many(:environments).dependent(:destroy) }
    it { is_expected.to have_many(:deployments).dependent(:destroy) }
63
    it { is_expected.to have_many(:todos).dependent(:destroy) }
U
ubudzisz 已提交
64 65 66 67 68
    it { is_expected.to have_many(:releases).dependent(:destroy) }
    it { is_expected.to have_many(:lfs_objects_projects).dependent(:destroy) }
    it { is_expected.to have_many(:project_group_links).dependent(:destroy) }
    it { is_expected.to have_many(:notification_settings).dependent(:destroy) }
    it { is_expected.to have_many(:forks).through(:forked_project_links) }
69 70

    describe '#members & #requesters' do
71
      let(:project) { create(:project, :public) }
72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96
      let(:requester) { create(:user) }
      let(:developer) { create(:user) }
      before do
        project.request_access(requester)
        project.team << [developer, :developer]
      end

      describe '#members' do
        it 'includes members and exclude requesters' do
          member_user_ids = project.members.pluck(:user_id)

          expect(member_user_ids).to include(developer.id)
          expect(member_user_ids).not_to include(requester.id)
        end
      end

      describe '#requesters' do
        it 'does not include requesters' do
          requester_user_ids = project.requesters.pluck(:user_id)

          expect(requester_user_ids).to include(requester.id)
          expect(requester_user_ids).not_to include(developer.id)
        end
      end
    end
97 98 99 100 101

    describe '#boards' do
      it 'raises an error when attempting to add more than one board to the project' do
        subject.boards.build

102
        expect { subject.boards.build }.to raise_error(Project::BoardLimitExceeded, 'Number of permitted boards exceeded')
103 104 105
        expect(subject.boards.size).to eq 1
      end
    end
G
gitlabhq 已提交
106 107
  end

108 109 110 111 112 113
  describe 'modules' do
    subject { described_class }

    it { is_expected.to include_module(Gitlab::ConfigHelper) }
    it { is_expected.to include_module(Gitlab::ShellAdapter) }
    it { is_expected.to include_module(Gitlab::VisibilityLevel) }
114
    it { is_expected.to include_module(Gitlab::CurrentSettings) }
115 116
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
117 118
  end

119
  describe 'validation' do
120 121
    let!(:project) { create(:project) }

122 123
    it { is_expected.to validate_presence_of(:name) }
    it { is_expected.to validate_uniqueness_of(:name).scoped_to(:namespace_id) }
124
    it { is_expected.to validate_length_of(:name).is_within(0..255) }
125

126 127
    it { is_expected.to validate_presence_of(:path) }
    it { is_expected.to validate_uniqueness_of(:path).scoped_to(:namespace_id) }
128 129
    it { is_expected.to validate_length_of(:path).is_within(0..255) }
    it { is_expected.to validate_length_of(:description).is_within(0..2000) }
130 131
    it { is_expected.to validate_presence_of(:creator) }
    it { is_expected.to validate_presence_of(:namespace) }
132
    it { is_expected.to validate_presence_of(:repository_storage) }
133

134
    it 'does not allow new projects beyond user limits' do
135
      project2 = build(:project)
136 137
      allow(project2).to receive(:creator).and_return(double(can_create_project?: false, projects_limit: 0).as_null_object)
      expect(project2).not_to be_valid
P
Phil Hughes 已提交
138
      expect(project2.errors[:limit_reached].first).to match(/Personal project creation is not allowed/)
139
    end
140 141 142

    describe 'wiki path conflict' do
      context "when the new path has been used by the wiki of other Project" do
143
        it 'has an error on the name attribute' do
144 145 146 147 148 149 150 151
          new_project = build_stubbed(:project, namespace_id: project.namespace_id, path: "#{project.path}.wiki")

          expect(new_project).not_to be_valid
          expect(new_project.errors[:name].first).to eq('has already been taken')
        end
      end

      context "when the new wiki path has been used by the path of other Project" do
152
        it 'has an error on the name attribute' do
153 154 155 156 157 158 159 160
          project_with_wiki_suffix = create(:project, path: 'foo.wiki')
          new_project = build_stubbed(:project, namespace_id: project_with_wiki_suffix.namespace_id, path: 'foo')

          expect(new_project).not_to be_valid
          expect(new_project.errors[:name].first).to eq('has already been taken')
        end
      end
    end
161 162 163 164 165 166 167 168 169

    context 'repository storages inclussion' do
      let(:project2) { build(:project, repository_storage: 'missing') }

      before do
        storages = { 'custom' => 'tmp/tests/custom_repositories' }
        allow(Gitlab.config.repositories).to receive(:storages).and_return(storages)
      end

170
      it "does not allow repository storages that don't match a label in the configuration" do
171 172 173 174
        expect(project2).not_to be_valid
        expect(project2.errors[:repository_storage].first).to match(/is not included in the list/)
      end
    end
175

176
    it 'does not allow an invalid URI as import_url' do
J
James Lopez 已提交
177 178 179 180 181
      project2 = build(:project, import_url: 'invalid://')

      expect(project2).not_to be_valid
    end

182
    it 'does allow a valid URI as import_url' do
J
James Lopez 已提交
183 184
      project2 = build(:project, import_url: 'ssh://test@gitlab.com/project.git')

185 186
      expect(project2).to be_valid
    end
187

188
    it 'allows an empty URI' do
189 190
      project2 = build(:project, import_url: '')

191
      expect(project2).to be_valid
192 193 194 195 196 197 198 199 200 201 202 203 204
    end

    it 'does not produce import data on an empty URI' do
      project2 = build(:project, import_url: '')

      expect(project2.import_data).to be_nil
    end

    it 'does not produce import data on an invalid URI' do
      project2 = build(:project, import_url: 'test://')

      expect(project2.import_data).to be_nil
    end
G
gitlabhq 已提交
205
  end
206

207 208 209 210 211 212 213 214 215
  describe 'default_scope' do
    it 'excludes projects pending deletion from the results' do
      project = create(:empty_project)
      create(:empty_project, pending_delete: true)

      expect(Project.all).to eq [project]
    end
  end

K
Kamil Trzcinski 已提交
216
  describe 'project token' do
217
    it 'sets an random token if none provided' do
K
Kamil Trzcinski 已提交
218 219
      project = FactoryGirl.create :empty_project, runners_token: ''
      expect(project.runners_token).not_to eq('')
K
Kamil Trzcinski 已提交
220 221
    end

U
ubudzisz 已提交
222
    it 'does not set an random token if one provided' do
K
Kamil Trzcinski 已提交
223 224
      project = FactoryGirl.create :empty_project, runners_token: 'my-token'
      expect(project.runners_token).to eq('my-token')
K
Kamil Trzcinski 已提交
225 226
    end
  end
G
gitlabhq 已提交
227

228
  describe 'Respond to' do
229 230 231 232 233
    it { is_expected.to respond_to(:url_to_repo) }
    it { is_expected.to respond_to(:repo_exists?) }
    it { is_expected.to respond_to(:execute_hooks) }
    it { is_expected.to respond_to(:owner) }
    it { is_expected.to respond_to(:path_with_namespace) }
G
gitlabhq 已提交
234 235
  end

R
Rémy Coutable 已提交
236 237 238 239 240 241 242
  describe '#name_with_namespace' do
    let(:project) { build_stubbed(:empty_project) }

    it { expect(project.name_with_namespace).to eq "#{project.namespace.human_name} / #{project.name}" }
    it { expect(project.human_name).to eq project.name_with_namespace }
  end

243 244 245 246 247 248 249 250
  describe '#to_reference' do
    let(:project) { create(:empty_project) }

    it 'returns a String reference to the object' do
      expect(project.to_reference).to eq project.path_with_namespace
    end
  end

251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268
  describe '#repository_storage_path' do
    let(:project) { create(:project, repository_storage: 'custom') }

    before do
      FileUtils.mkdir('tmp/tests/custom_repositories')
      storages = { 'custom' => 'tmp/tests/custom_repositories' }
      allow(Gitlab.config.repositories).to receive(:storages).and_return(storages)
    end

    after do
      FileUtils.rm_rf('tmp/tests/custom_repositories')
    end

    it 'returns the repository storage path' do
      expect(project.repository_storage_path).to eq('tmp/tests/custom_repositories')
    end
  end

269
  it 'returns valid url to repo' do
270
    project = Project.new(path: 'somewhere')
271
    expect(project.url_to_repo).to eq(Gitlab.config.gitlab_shell.ssh_path_prefix + 'somewhere.git')
G
gitlabhq 已提交
272 273
  end

D
Douwe Maan 已提交
274 275 276 277 278 279
  describe "#web_url" do
    let(:project) { create(:empty_project, path: "somewhere") }

    it 'returns the full web URL for this repo' do
      expect(project.web_url).to eq("#{Gitlab.config.gitlab.url}/#{project.namespace.path}/somewhere")
    end
A
Ariejan de Vroom 已提交
280 281
  end

D
Douwe Maan 已提交
282 283 284 285 286 287
  describe "#web_url_without_protocol" do
    let(:project) { create(:empty_project, path: "somewhere") }

    it 'returns the web URL without the protocol for this repo' do
      expect(project.web_url_without_protocol).to eq("#{Gitlab.config.gitlab.url.split('://')[1]}/#{project.namespace.path}/somewhere")
    end
288 289
  end

290
  xdescribe "#new_issue_address" do
291 292 293
    let(:project) { create(:empty_project, path: "somewhere") }
    let(:user) { create(:user) }

294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310
    context 'incoming email enabled' do
      before do
        stub_incoming_email_setting(enabled: true, address: "p+%{key}@gl.ab")
      end

      it 'returns the address to create a new issue' do
        token = user.authentication_token
        address = "p+#{project.namespace.path}/#{project.path}+#{token}@gl.ab"

        expect(project.new_issue_address(user)).to eq(address)
      end
    end

    context 'incoming email disabled' do
      before do
        stub_incoming_email_setting(enabled: false)
      end
311

312 313 314
      it 'returns nil' do
        expect(project.new_issue_address(user)).to be_nil
      end
315 316 317
    end
  end

318
  describe 'last_activity methods' do
S
Stan Hu 已提交
319 320 321
    let(:timestamp) { 2.hours.ago }
    # last_activity_at gets set to created_at upon creation
    let(:project) { create(:project, created_at: timestamp, updated_at: timestamp) }
G
gitlabhq 已提交
322

323
    describe 'last_activity' do
324
      it 'alias last_activity to last_event' do
325 326
        last_event = create(:event, project: project)

327
        expect(project.last_activity).to eq(last_event)
328
      end
G
gitlabhq 已提交
329 330
    end

331 332
    describe 'last_activity_date' do
      it 'returns the creation date of the project\'s last event if present' do
333 334
        new_event = create(:event, project: project, created_at: Time.now)

S
Stan Hu 已提交
335
        project.reload
336
        expect(project.last_activity_at.to_i).to eq(new_event.created_at.to_i)
337
      end
338

339
      it 'returns the project\'s last update date if it has no events' do
340
        expect(project.last_activity_date).to eq(project.updated_at)
341
      end
342 343
    end
  end
344

345 346
  describe '#get_issue' do
    let(:project) { create(:empty_project) }
S
Stan Hu 已提交
347
    let!(:issue)  { create(:issue, project: project) }
348 349 350 351 352 353

    context 'with default issues tracker' do
      it 'returns an issue' do
        expect(project.get_issue(issue.iid)).to eq issue
      end

S
Stan Hu 已提交
354 355 356 357
      it 'returns count of open issues' do
        expect(project.open_issues_count).to eq(1)
      end

358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390
      it 'returns nil when no issue found' do
        expect(project.get_issue(999)).to be_nil
      end
    end

    context 'with external issues tracker' do
      before do
        allow(project).to receive(:default_issues_tracker?).and_return(false)
      end

      it 'returns an ExternalIssue' do
        issue = project.get_issue('FOO-1234')
        expect(issue).to be_kind_of(ExternalIssue)
        expect(issue.iid).to eq 'FOO-1234'
        expect(issue.project).to eq project
      end
    end
  end

  describe '#issue_exists?' do
    let(:project) { create(:empty_project) }

    it 'is truthy when issue exists' do
      expect(project).to receive(:get_issue).and_return(double)
      expect(project.issue_exists?(1)).to be_truthy
    end

    it 'is falsey when issue does not exist' do
      expect(project).to receive(:get_issue).and_return(nil)
      expect(project.issue_exists?(1)).to be_falsey
    end
  end

391
  describe '.find_with_namespace' do
392 393 394
    context 'with namespace' do
      before do
        @group = create :group, name: 'gitlab'
D
Dmitriy Zaporozhets 已提交
395
        @project = create(:project, name: 'gitlabhq', namespace: @group)
396 397
      end

398
      it { expect(Project.find_with_namespace('gitlab/gitlabhq')).to eq(@project) }
399
      it { expect(Project.find_with_namespace('GitLab/GitlabHQ')).to eq(@project) }
400
      it { expect(Project.find_with_namespace('gitlab-ci')).to be_nil }
401
    end
402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417

    context 'when multiple projects using a similar name exist' do
      let(:group) { create(:group, name: 'gitlab') }

      let!(:project1) do
        create(:empty_project, name: 'gitlab1', path: 'gitlab', namespace: group)
      end

      let!(:project2) do
        create(:empty_project, name: 'gitlab2', path: 'GITLAB', namespace: group)
      end

      it 'returns the row where the path matches literally' do
        expect(Project.find_with_namespace('gitlab/GITLAB')).to eq(project2)
      end
    end
418 419
  end

L
Lin Jen-Shin 已提交
420
  describe '#to_param' do
421 422 423
    context 'with namespace' do
      before do
        @group = create :group, name: 'gitlab'
D
Dmitriy Zaporozhets 已提交
424
        @project = create(:project, name: 'gitlabhq', namespace: @group)
425 426
      end

V
Vinnie Okada 已提交
427
      it { expect(@project.to_param).to eq('gitlabhq') }
428
    end
429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446

    context 'with invalid path' do
      it 'returns previous path to keep project suitable for use in URLs when persisted' do
        project = create(:empty_project, path: 'gitlab')
        project.path = 'foo&bar'

        expect(project).not_to be_valid
        expect(project.to_param).to eq 'gitlab'
      end

      it 'returns current path when new record' do
        project = build(:empty_project, path: 'gitlab')
        project.path = 'foo&bar'

        expect(project).not_to be_valid
        expect(project.to_param).to eq 'foo&bar'
      end
    end
447
  end
D
Dmitriy Zaporozhets 已提交
448

L
Lin Jen-Shin 已提交
449
  describe '#repository' do
D
Dmitriy Zaporozhets 已提交
450 451
    let(:project) { create(:project) }

452
    it 'returns valid repo' do
453
      expect(project.repository).to be_kind_of(Repository)
D
Dmitriy Zaporozhets 已提交
454 455
    end
  end
456

L
Lin Jen-Shin 已提交
457
  describe '#default_issues_tracker?' do
458 459 460
    let(:project) { create(:project) }
    let(:ext_project) { create(:redmine_project) }

461
    it "is true if used internal tracker" do
462
      expect(project.default_issues_tracker?).to be_truthy
463 464
    end

465
    it "is false if used other tracker" do
466
      expect(ext_project.default_issues_tracker?).to be_falsey
467 468 469
    end
  end

L
Lin Jen-Shin 已提交
470
  describe '#external_issue_tracker' do
471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510
    let(:project) { create(:project) }
    let(:ext_project) { create(:redmine_project) }

    context 'on existing projects with no value for has_external_issue_tracker' do
      before(:each) do
        project.update_column(:has_external_issue_tracker, nil)
        ext_project.update_column(:has_external_issue_tracker, nil)
      end

      it 'updates the has_external_issue_tracker boolean' do
        expect do
          project.external_issue_tracker
        end.to change { project.reload.has_external_issue_tracker }.to(false)

        expect do
          ext_project.external_issue_tracker
        end.to change { ext_project.reload.has_external_issue_tracker }.to(true)
      end
    end

    it 'returns nil and does not query services when there is no external issue tracker' do
      project.build_missing_services
      project.reload

      expect(project).not_to receive(:services)

      expect(project.external_issue_tracker).to eq(nil)
    end

    it 'retrieves external_issue_tracker querying services and cache it when there is external issue tracker' do
      ext_project.reload # Factory returns a project with changed attributes
      ext_project.build_missing_services
      ext_project.reload

      expect(ext_project).to receive(:services).once.and_call_original

      2.times { expect(ext_project.external_issue_tracker).to be_a_kind_of(RedmineService) }
    end
  end

L
Lin Jen-Shin 已提交
511
  describe '#cache_has_external_issue_tracker' do
512
    let(:project) { create(:project, has_external_issue_tracker: nil) }
513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532

    it 'stores true if there is any external_issue_tracker' do
      services = double(:service, external_issue_trackers: [RedmineService.new])
      expect(project).to receive(:services).and_return(services)

      expect do
        project.cache_has_external_issue_tracker
      end.to change { project.has_external_issue_tracker}.to(true)
    end

    it 'stores false if there is no external_issue_tracker' do
      services = double(:service, external_issue_trackers: [])
      expect(project).to receive(:services).and_return(services)

      expect do
        project.cache_has_external_issue_tracker
      end.to change { project.has_external_issue_tracker}.to(false)
    end
  end

533 534
  describe '#has_wiki?' do
    let(:no_wiki_project) { build(:project, wiki_enabled: false, has_external_wiki: false) }
F
Felipe Artur 已提交
535
    let(:wiki_enabled_project) { build(:project) }
536 537 538 539 540 541 542 543 544
    let(:external_wiki_project) { build(:project, has_external_wiki: true) }

    it 'returns true if project is wiki enabled or has external wiki' do
      expect(wiki_enabled_project).to have_wiki
      expect(external_wiki_project).to have_wiki
      expect(no_wiki_project).not_to have_wiki
    end
  end

545
  describe '#external_wiki' do
546 547
    let(:project) { create(:project) }

548 549 550 551 552
    context 'with an active external wiki' do
      before do
        create(:service, project: project, type: 'ExternalWikiService', active: true)
        project.external_wiki
      end
553

554 555 556
      it 'sets :has_external_wiki as true' do
        expect(project.has_external_wiki).to be(true)
      end
557

558 559
      it 'sets :has_external_wiki as false if an external wiki service is destroyed later' do
        expect(project.has_external_wiki).to be(true)
560

561 562 563 564
        project.services.external_wikis.first.destroy

        expect(project.has_external_wiki).to be(false)
      end
565 566
    end

567 568 569 570
    context 'with an inactive external wiki' do
      before do
        create(:service, project: project, type: 'ExternalWikiService', active: false)
      end
571

572 573 574
      it 'sets :has_external_wiki as false' do
        expect(project.has_external_wiki).to be(false)
      end
575 576
    end

577 578 579 580
    context 'with no external wiki' do
      before do
        project.external_wiki
      end
581

582 583 584 585 586 587 588 589 590 591 592
      it 'sets :has_external_wiki as false' do
        expect(project.has_external_wiki).to be(false)
      end

      it 'sets :has_external_wiki as true if an external wiki service is created later' do
        expect(project.has_external_wiki).to be(false)

        create(:service, project: project, type: 'ExternalWikiService', active: true)

        expect(project.has_external_wiki).to be(true)
      end
593 594 595
    end
  end

L
Lin Jen-Shin 已提交
596
  describe '#open_branches' do
D
Dmitriy Zaporozhets 已提交
597
    let(:project) { create(:project) }
598 599 600 601 602

    before do
      project.protected_branches.create(name: 'master')
    end

603 604
    it { expect(project.open_branches.map(&:name)).to include('feature') }
    it { expect(project.open_branches.map(&:name)).not_to include('master') }
605

606
    it "includes branches matching a protected branch wildcard" do
607 608 609 610
      expect(project.open_branches.map(&:name)).to include('feature')

      create(:protected_branch, name: 'feat*', project: project)

611
      expect(Project.find(project.id).open_branches.map(&:name)).to include('feature')
612
    end
613
  end
C
Ciro Santilli 已提交
614

615 616
  describe '#star_count' do
    it 'counts stars from multiple users' do
C
Ciro Santilli 已提交
617 618 619 620 621
      user1 = create :user
      user2 = create :user
      project = create :project, :public

      expect(project.star_count).to eq(0)
622

C
Ciro Santilli 已提交
623
      user1.toggle_star(project)
624 625
      expect(project.reload.star_count).to eq(1)

C
Ciro Santilli 已提交
626
      user2.toggle_star(project)
627 628 629
      project.reload
      expect(project.reload.star_count).to eq(2)

C
Ciro Santilli 已提交
630
      user1.toggle_star(project)
631 632 633
      project.reload
      expect(project.reload.star_count).to eq(1)

C
Ciro Santilli 已提交
634
      user2.toggle_star(project)
635 636 637 638
      project.reload
      expect(project.reload.star_count).to eq(0)
    end

639
    it 'counts stars on the right project' do
640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669
      user = create :user
      project1 = create :project, :public
      project2 = create :project, :public

      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project1)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(1)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project1)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project2)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(1)

      user.toggle_star(project2)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)
C
Ciro Santilli 已提交
670 671
    end
  end
672

L
Lin Jen-Shin 已提交
673
  describe '#avatar_type' do
674 675
    let(:project) { create(:project) }

676
    it 'is true if avatar is image' do
677
      project.update_attribute(:avatar, 'uploads/avatar.png')
678
      expect(project.avatar_type).to be_truthy
679 680
    end

681
    it 'is false if avatar is html page' do
682
      project.update_attribute(:avatar, 'uploads/avatar.html')
683
      expect(project.avatar_type).to eq(['only images allowed'])
684 685
    end
  end
S
sue445 已提交
686

L
Lin Jen-Shin 已提交
687
  describe '#avatar_url' do
S
sue445 已提交
688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715
    subject { project.avatar_url }

    let(:project) { create(:project) }

    context 'When avatar file is uploaded' do
      before do
        project.update_columns(avatar: 'uploads/avatar.png')
        allow(project.avatar).to receive(:present?) { true }
      end

      let(:avatar_path) do
        "/uploads/project/avatar/#{project.id}/uploads/avatar.png"
      end

      it { should eq "http://localhost#{avatar_path}" }
    end

    context 'When avatar file in git' do
      before do
        allow(project).to receive(:avatar_in_git) { true }
      end

      let(:avatar_path) do
        "/#{project.namespace.name}/#{project.path}/avatar"
      end

      it { should eq "http://localhost#{avatar_path}" }
    end
716 717 718 719 720 721

    context 'when git repo is empty' do
      let(:project) { create(:empty_project) }

      it { should eq nil }
    end
S
sue445 已提交
722
  end
723

724 725 726
  describe '#pipeline_for' do
    let(:project) { create(:project) }
    let!(:pipeline) { create_pipeline }
K
Kamil Trzcinski 已提交
727

728 729
    shared_examples 'giving the correct pipeline' do
      it { is_expected.to eq(pipeline) }
K
Kamil Trzcinski 已提交
730

731 732
      context 'return latest' do
        let!(:pipeline2) { create_pipeline }
K
Kamil Trzcinski 已提交
733

734
        it { is_expected.to eq(pipeline2) }
K
Kamil Trzcinski 已提交
735
      end
736 737 738 739 740 741 742 743 744 745 746 747 748
    end

    context 'with explicit sha' do
      subject { project.pipeline_for('master', pipeline.sha) }

      it_behaves_like 'giving the correct pipeline'
    end

    context 'with implicit sha' do
      subject { project.pipeline_for('master') }

      it_behaves_like 'giving the correct pipeline'
    end
K
Kamil Trzcinski 已提交
749

750 751 752 753 754
    def create_pipeline
      create(:ci_pipeline,
             project: project,
             ref: 'master',
             sha: project.commit('master').sha)
K
Kamil Trzcinski 已提交
755
    end
756
  end
757

L
Lin Jen-Shin 已提交
758
  describe '#builds_enabled' do
759 760
    let(:project) { create :project }

761 762 763
    subject { project.builds_enabled }

    it { expect(project.builds_enabled?).to be_truthy }
764
  end
Y
Yorick Peterse 已提交
765

766 767 768 769 770 771 772 773 774 775 776 777 778 779
  describe '.cached_count', caching: true do
    let(:group)     { create(:group, :public) }
    let!(:project1) { create(:empty_project, :public, group: group) }
    let!(:project2) { create(:empty_project, :public, group: group) }

    it 'returns total project count' do
      expect(Project).to receive(:count).once.and_call_original

      3.times do
        expect(Project.cached_count).to eq(2)
      end
    end
  end

Y
Yorick Peterse 已提交
780
  describe '.trending' do
F
Felipe Artur 已提交
781
    let(:group)    { create(:group, :public) }
Y
Yorick Peterse 已提交
782 783 784 785 786 787 788 789 790 791
    let(:project1) { create(:empty_project, :public, group: group) }
    let(:project2) { create(:empty_project, :public, group: group) }

    before do
      2.times do
        create(:note_on_commit, project: project1)
      end

      create(:note_on_commit, project: project2)

Y
Yorick Peterse 已提交
792
      TrendingProject.refresh!
Y
Yorick Peterse 已提交
793 794
    end

Y
Yorick Peterse 已提交
795
    subject { described_class.trending.to_a }
Y
Yorick Peterse 已提交
796

Y
Yorick Peterse 已提交
797 798
    it 'sorts projects by the amount of notes in descending order' do
      expect(subject).to eq([project1, project2])
Y
Yorick Peterse 已提交
799
    end
800 801 802 803 804 805 806 807

    it 'does not take system notes into account' do
      10.times do
        create(:note_on_commit, project: project2, system: true)
      end

      expect(described_class.trending.to_a).to eq([project1, project2])
    end
Y
Yorick Peterse 已提交
808
  end
Y
Yorick Peterse 已提交
809 810 811 812 813 814 815 816 817

  describe '.visible_to_user' do
    let!(:project) { create(:project, :private) }
    let!(:user)    { create(:user) }

    subject { described_class.visible_to_user(user) }

    describe 'when a user has access to a project' do
      before do
818
        project.add_user(user, Gitlab::Access::MASTER)
Y
Yorick Peterse 已提交
819 820 821 822 823 824 825 826 827
      end

      it { is_expected.to eq([project]) }
    end

    describe 'when a user does not have access to any projects' do
      it { is_expected.to eq([]) }
    end
  end
K
Kamil Trzcinski 已提交
828

829 830 831 832 833 834 835 836 837 838 839 840 841 842 843
  context 'repository storage by default' do
    let(:project) { create(:empty_project) }

    subject { project.repository_storage }

    before do
      storages = { 'alternative_storage' => '/some/path' }
      allow(Gitlab.config.repositories).to receive(:storages).and_return(storages)
      stub_application_setting(repository_storage: 'alternative_storage')
      allow_any_instance_of(Project).to receive(:ensure_dir_exist).and_return(true)
    end

    it { is_expected.to eq('alternative_storage') }
  end

K
Kamil Trzcinski 已提交
844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861
  context 'shared runners by default' do
    let(:project) { create(:empty_project) }

    subject { project.shared_runners_enabled }

    context 'are enabled' do
      before { stub_application_setting(shared_runners_enabled: true) }

      it { is_expected.to be_truthy }
    end

    context 'are disabled' do
      before { stub_application_setting(shared_runners_enabled: false) }

      it { is_expected.to be_falsey }
    end
  end

L
Lin Jen-Shin 已提交
862
  describe '#any_runners' do
K
Kamil Trzcinski 已提交
863
    let(:project) { create(:empty_project, shared_runners_enabled: shared_runners_enabled) }
864 865
    let(:specific_runner) { create(:ci_runner) }
    let(:shared_runner) { create(:ci_runner, :shared) }
K
Kamil Trzcinski 已提交
866 867 868

    context 'for shared runners disabled' do
      let(:shared_runners_enabled) { false }
869

870
      it 'has no runners available' do
K
Kamil Trzcinski 已提交
871 872
        expect(project.any_runners?).to be_falsey
      end
873

874
      it 'has a specific runner' do
875
        project.runners << specific_runner
K
Kamil Trzcinski 已提交
876 877
        expect(project.any_runners?).to be_truthy
      end
878

879
      it 'has a shared runner, but they are prohibited to use' do
K
Kamil Trzcinski 已提交
880 881 882
        shared_runner
        expect(project.any_runners?).to be_falsey
      end
883

K
Kamil Trzcinski 已提交
884
      it 'checks the presence of specific runner' do
885
        project.runners << specific_runner
K
Kamil Trzcinski 已提交
886 887 888
        expect(project.any_runners? { |runner| runner == specific_runner }).to be_truthy
      end
    end
889

K
Kamil Trzcinski 已提交
890 891
    context 'for shared runners enabled' do
      let(:shared_runners_enabled) { true }
892

893
      it 'has a shared runner' do
K
Kamil Trzcinski 已提交
894 895 896 897 898 899 900 901 902 903
        shared_runner
        expect(project.any_runners?).to be_truthy
      end

      it 'checks the presence of shared runner' do
        shared_runner
        expect(project.any_runners? { |runner| runner == shared_runner }).to be_truthy
      end
    end
  end
904 905

  describe '#visibility_level_allowed?' do
906
    let(:project) { create(:project, :internal) }
907 908 909 910 911 912 913 914

    context 'when checking on non-forked project' do
      it { expect(project.visibility_level_allowed?(Gitlab::VisibilityLevel::PRIVATE)).to be_truthy }
      it { expect(project.visibility_level_allowed?(Gitlab::VisibilityLevel::INTERNAL)).to be_truthy }
      it { expect(project.visibility_level_allowed?(Gitlab::VisibilityLevel::PUBLIC)).to be_truthy }
    end

    context 'when checking on forked project' do
915 916
      let(:project)        { create(:project, :internal) }
      let(:forked_project) { create(:project, forked_from_project: project) }
917 918 919 920 921

      it { expect(forked_project.visibility_level_allowed?(Gitlab::VisibilityLevel::PRIVATE)).to be_truthy }
      it { expect(forked_project.visibility_level_allowed?(Gitlab::VisibilityLevel::INTERNAL)).to be_truthy }
      it { expect(forked_project.visibility_level_allowed?(Gitlab::VisibilityLevel::PUBLIC)).to be_falsey }
    end
922
  end
923

924 925
  describe '.search' do
    let(:project) { create(:project, description: 'kitten mittens') }
926

927 928 929
    it 'returns projects with a matching name' do
      expect(described_class.search(project.name)).to eq([project])
    end
930

931 932 933
    it 'returns projects with a partially matching name' do
      expect(described_class.search(project.name[0..2])).to eq([project])
    end
934

935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973
    it 'returns projects with a matching name regardless of the casing' do
      expect(described_class.search(project.name.upcase)).to eq([project])
    end

    it 'returns projects with a matching description' do
      expect(described_class.search(project.description)).to eq([project])
    end

    it 'returns projects with a partially matching description' do
      expect(described_class.search('kitten')).to eq([project])
    end

    it 'returns projects with a matching description regardless of the casing' do
      expect(described_class.search('KITTEN')).to eq([project])
    end

    it 'returns projects with a matching path' do
      expect(described_class.search(project.path)).to eq([project])
    end

    it 'returns projects with a partially matching path' do
      expect(described_class.search(project.path[0..2])).to eq([project])
    end

    it 'returns projects with a matching path regardless of the casing' do
      expect(described_class.search(project.path.upcase)).to eq([project])
    end

    it 'returns projects with a matching namespace name' do
      expect(described_class.search(project.namespace.name)).to eq([project])
    end

    it 'returns projects with a partially matching namespace name' do
      expect(described_class.search(project.namespace.name[0..2])).to eq([project])
    end

    it 'returns projects with a matching namespace name regardless of the casing' do
      expect(described_class.search(project.namespace.name.upcase)).to eq([project])
    end
974 975 976 977 978

    it 'returns projects when eager loading namespaces' do
      relation = described_class.all.includes(:namespace)

      expect(relation.search(project.namespace.name)).to eq([project])
979
    end
980
  end
981 982 983 984 985 986 987 988 989 990 991

  describe '#rename_repo' do
    let(:project) { create(:project) }
    let(:gitlab_shell) { Gitlab::Shell.new }

    before do
      # Project#gitlab_shell returns a new instance of Gitlab::Shell on every
      # call. This makes testing a bit easier.
      allow(project).to receive(:gitlab_shell).and_return(gitlab_shell)

      allow(project).to receive(:previous_changes).and_return('path' => ['foo'])
K
Kamil Trzcinski 已提交
992
    end
993

K
Kamil Trzcinski 已提交
994
    it 'renames a repository' do
995 996 997 998
      ns = project.namespace_dir

      expect(gitlab_shell).to receive(:mv_repository).
        ordered.
999
        with(project.repository_storage_path, "#{ns}/foo", "#{ns}/#{project.path}").
1000 1001 1002 1003
        and_return(true)

      expect(gitlab_shell).to receive(:mv_repository).
        ordered.
1004
        with(project.repository_storage_path, "#{ns}/foo.wiki", "#{ns}/#{project.path}.wiki").
1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018
        and_return(true)

      expect_any_instance_of(SystemHooksService).
        to receive(:execute_hooks_for).
        with(project, :rename)

      expect_any_instance_of(Gitlab::UploadsTransfer).
        to receive(:rename_project).
        with('foo', project.path, ns)

      expect(project).to receive(:expire_caches_before_rename)

      project.rename_repo
    end
K
Kamil Trzcinski 已提交
1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029

    context 'container registry with tags' do
      before do
        stub_container_registry_config(enabled: true)
        stub_container_registry_tags('tag')
      end

      subject { project.rename_repo }

      it { expect{subject}.to raise_error(Exception) }
    end
1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045
  end

  describe '#expire_caches_before_rename' do
    let(:project) { create(:project) }
    let(:repo)    { double(:repo, exists?: true) }
    let(:wiki)    { double(:wiki, exists?: true) }

    it 'expires the caches of the repository and wiki' do
      allow(Repository).to receive(:new).
        with('foo', project).
        and_return(repo)

      allow(Repository).to receive(:new).
        with('foo.wiki', project).
        and_return(wiki)

1046 1047
      expect(repo).to receive(:before_delete)
      expect(wiki).to receive(:before_delete)
1048 1049 1050 1051

      project.expire_caches_before_rename('foo')
    end
  end
1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067

  describe '.search_by_title' do
    let(:project) { create(:project, name: 'kittens') }

    it 'returns projects with a matching name' do
      expect(described_class.search_by_title(project.name)).to eq([project])
    end

    it 'returns projects with a partially matching name' do
      expect(described_class.search_by_title('kitten')).to eq([project])
    end

    it 'returns projects with a matching name regardless of the casing' do
      expect(described_class.search_by_title('KITTENS')).to eq([project])
    end
  end
1068 1069 1070 1071 1072

  context 'when checking projects from groups' do
    let(:private_group)    { create(:group, visibility_level: 0)  }
    let(:internal_group)   { create(:group, visibility_level: 10) }

D
Douwe Maan 已提交
1073 1074
    let(:private_project)  { create :project, :private, group: private_group }
    let(:internal_project) { create :project, :internal, group: internal_group }
1075 1076 1077 1078 1079 1080 1081 1082 1083

    context 'when group is private project can not be internal' do
      it { expect(private_project.visibility_level_allowed?(Gitlab::VisibilityLevel::INTERNAL)).to be_falsey }
    end

    context 'when group is internal project can not be public' do
      it { expect(internal_project.visibility_level_allowed?(Gitlab::VisibilityLevel::PUBLIC)).to be_falsey }
    end
  end
1084

1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095
  describe '#create_repository' do
    let(:project) { create(:project) }
    let(:shell) { Gitlab::Shell.new }

    before do
      allow(project).to receive(:gitlab_shell).and_return(shell)
    end

    context 'using a regular repository' do
      it 'creates the repository' do
        expect(shell).to receive(:add_repository).
1096
          with(project.repository_storage_path, project.path_with_namespace).
1097 1098 1099 1100 1101 1102 1103 1104 1105
          and_return(true)

        expect(project.repository).to receive(:after_create)

        expect(project.create_repository).to eq(true)
      end

      it 'adds an error if the repository could not be created' do
        expect(shell).to receive(:add_repository).
1106
          with(project.repository_storage_path, project.path_with_namespace).
1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124
          and_return(false)

        expect(project.repository).not_to receive(:after_create)

        expect(project.create_repository).to eq(false)
        expect(project.errors).not_to be_empty
      end
    end

    context 'using a forked repository' do
      it 'does nothing' do
        expect(project).to receive(:forked?).and_return(true)
        expect(shell).not_to receive(:add_repository)

        project.create_repository
      end
    end
  end
1125 1126

  describe '#protected_branch?' do
1127 1128 1129 1130
    context 'existing project' do
      let(:project) { create(:project) }

      it 'returns true when the branch matches a protected branch via direct match' do
1131
        create(:protected_branch, project: project, name: "foo")
1132 1133 1134 1135 1136

        expect(project.protected_branch?('foo')).to eq(true)
      end

      it 'returns true when the branch matches a protected branch via wildcard match' do
1137
        create(:protected_branch, project: project, name: "production/*")
1138 1139 1140 1141 1142 1143 1144 1145 1146

        expect(project.protected_branch?('production/some-branch')).to eq(true)
      end

      it 'returns false when the branch does not match a protected branch via direct match' do
        expect(project.protected_branch?('foo')).to eq(false)
      end

      it 'returns false when the branch does not match a protected branch via wildcard match' do
1147
        create(:protected_branch, project: project, name: "production/*")
1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181

        expect(project.protected_branch?('staging/some-branch')).to eq(false)
      end
    end

    context "new project" do
      let(:project) { create(:empty_project) }

      it 'returns false when default_protected_branch is unprotected' do
        stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_NONE)

        expect(project.protected_branch?('master')).to be false
      end

      it 'returns false when default_protected_branch lets developers push' do
        stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_DEV_CAN_PUSH)

        expect(project.protected_branch?('master')).to be false
      end

      it 'returns true when default_branch_protection does not let developers push but let developer merge branches' do
        stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_DEV_CAN_MERGE)

        expect(project.protected_branch?('master')).to be true
      end

      it 'returns true when default_branch_protection is in full protection' do
        stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_FULL)

        expect(project.protected_branch?('master')).to be true
      end
    end
  end

1182
  describe '#user_can_push_to_empty_repo?' do
1183
    let(:project) { create(:empty_project) }
1184
    let(:user)    { create(:user) }
1185

1186 1187 1188
    it 'returns false when default_branch_protection is in full protection and user is developer' do
      project.team << [user, :developer]
      stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_FULL)
1189

1190
      expect(project.user_can_push_to_empty_repo?(user)).to be_falsey
1191 1192
    end

1193 1194 1195
    it 'returns false when default_branch_protection only lets devs merge and user is dev' do
      project.team << [user, :developer]
      stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_DEV_CAN_MERGE)
1196

1197
      expect(project.user_can_push_to_empty_repo?(user)).to be_falsey
1198 1199
    end

1200 1201 1202
    it 'returns true when default_branch_protection lets devs push and user is developer' do
      project.team << [user, :developer]
      stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_DEV_CAN_PUSH)
1203

1204 1205
      expect(project.user_can_push_to_empty_repo?(user)).to be_truthy
    end
1206

1207 1208 1209
    it 'returns true when default_branch_protection is unprotected and user is developer' do
      project.team << [user, :developer]
      stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_NONE)
1210

1211
      expect(project.user_can_push_to_empty_repo?(user)).to be_truthy
1212
    end
1213

1214 1215
    it 'returns true when user is master' do
      project.team << [user, :master]
1216

1217
      expect(project.user_can_push_to_empty_repo?(user)).to be_truthy
1218 1219 1220
    end
  end

1221 1222 1223 1224 1225 1226 1227 1228 1229
  describe '#container_registry_path_with_namespace' do
    let(:project) { create(:empty_project, path: 'PROJECT') }

    subject { project.container_registry_path_with_namespace }

    it { is_expected.not_to eq(project.path_with_namespace) }
    it { is_expected.to eq(project.path_with_namespace.downcase) }
  end

K
Kamil Trzcinski 已提交
1230 1231 1232
  describe '#container_registry_repository' do
    let(:project) { create(:empty_project) }

K
Kamil Trzcinski 已提交
1233 1234
    before { stub_container_registry_config(enabled: true) }

K
Kamil Trzcinski 已提交
1235 1236
    subject { project.container_registry_repository }

1237
    it { is_expected.not_to be_nil }
K
Kamil Trzcinski 已提交
1238 1239 1240 1241 1242 1243 1244
  end

  describe '#container_registry_repository_url' do
    let(:project) { create(:empty_project) }

    subject { project.container_registry_repository_url }

1245
    before { stub_container_registry_config(**registry_settings) }
K
Kamil Trzcinski 已提交
1246 1247 1248 1249 1250 1251 1252 1253 1254

    context 'for enabled registry' do
      let(:registry_settings) do
        {
          enabled: true,
          host_port: 'example.com',
        }
      end

1255
      it { is_expected.not_to be_nil }
K
Kamil Trzcinski 已提交
1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274
    end

    context 'for disabled registry' do
      let(:registry_settings) do
        {
          enabled: false
        }
      end

      it { is_expected.to be_nil }
    end
  end

  describe '#has_container_registry_tags?' do
    let(:project) { create(:empty_project) }

    subject { project.has_container_registry_tags? }

    context 'for enabled registry' do
1275
      before { stub_container_registry_config(enabled: true) }
K
Kamil Trzcinski 已提交
1276 1277

      context 'with tags' do
K
Kamil Trzcinski 已提交
1278
        before { stub_container_registry_tags('test', 'test2') }
K
Kamil Trzcinski 已提交
1279 1280 1281 1282 1283

        it { is_expected.to be_truthy }
      end

      context 'when no tags' do
K
Kamil Trzcinski 已提交
1284
        before { stub_container_registry_tags }
K
Kamil Trzcinski 已提交
1285 1286 1287 1288 1289 1290

        it { is_expected.to be_falsey }
      end
    end

    context 'for disabled registry' do
1291
      before { stub_container_registry_config(enabled: false) }
K
Kamil Trzcinski 已提交
1292 1293 1294 1295

      it { is_expected.to be_falsey }
    end
  end
Y
Yorick Peterse 已提交
1296

1297
  describe '#latest_successful_builds_for' do
L
Lin Jen-Shin 已提交
1298
    def create_pipeline(status = 'success')
1299
      create(:ci_pipeline, project: project,
L
Lin Jen-Shin 已提交
1300
                           sha: project.commit.sha,
1301
                           ref: project.default_branch,
L
Lin Jen-Shin 已提交
1302
                           status: status)
1303 1304
    end

L
Lin Jen-Shin 已提交
1305 1306 1307
    def create_build(new_pipeline = pipeline, name = 'test')
      create(:ci_build, :success, :artifacts,
             pipeline: new_pipeline,
L
Lin Jen-Shin 已提交
1308
             status: new_pipeline.status,
L
Lin Jen-Shin 已提交
1309
             name: name)
1310 1311
    end

L
Lin Jen-Shin 已提交
1312 1313
    let(:project) { create(:project) }
    let(:pipeline) { create_pipeline }
L
Lin Jen-Shin 已提交
1314 1315

    context 'with many builds' do
1316
      it 'gives the latest builds from latest pipeline' do
1317 1318
        pipeline1 = create_pipeline
        pipeline2 = create_pipeline
1319
        build1_p2 = create_build(pipeline2, 'test')
1320 1321
        create_build(pipeline1, 'test')
        create_build(pipeline1, 'test2')
1322
        build2_p2 = create_build(pipeline2, 'test2')
L
Lin Jen-Shin 已提交
1323 1324 1325

        latest_builds = project.latest_successful_builds_for

1326
        expect(latest_builds).to contain_exactly(build2_p2, build1_p2)
L
Lin Jen-Shin 已提交
1327 1328
      end
    end
L
Lin Jen-Shin 已提交
1329

L
Lin Jen-Shin 已提交
1330
    context 'with succeeded pipeline' do
L
Lin Jen-Shin 已提交
1331
      let!(:build) { create_build }
1332

L
Lin Jen-Shin 已提交
1333
      context 'standalone pipeline' do
1334 1335 1336 1337 1338 1339 1340 1341
        it 'returns builds for ref for default_branch' do
          builds = project.latest_successful_builds_for

          expect(builds).to contain_exactly(build)
        end

        it 'returns empty relation if the build cannot be found' do
          builds = project.latest_successful_builds_for('TAIL')
1342

1343 1344 1345
          expect(builds).to be_kind_of(ActiveRecord::Relation)
          expect(builds).to be_empty
        end
1346 1347
      end

L
Lin Jen-Shin 已提交
1348
      context 'with some pending pipeline' do
1349
        before do
L
Lin Jen-Shin 已提交
1350
          create_build(create_pipeline('pending'))
1351 1352
        end

L
Lin Jen-Shin 已提交
1353 1354
        it 'gives the latest build from latest pipeline' do
          latest_build = project.latest_successful_builds_for
1355

L
Lin Jen-Shin 已提交
1356
          expect(latest_build).to contain_exactly(build)
1357
        end
1358 1359 1360 1361 1362 1363
      end
    end

    context 'with pending pipeline' do
      before do
        pipeline.update(status: 'pending')
L
Lin Jen-Shin 已提交
1364
        create_build(pipeline)
1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375
      end

      it 'returns empty relation' do
        builds = project.latest_successful_builds_for

        expect(builds).to be_kind_of(ActiveRecord::Relation)
        expect(builds).to be_empty
      end
    end
  end

1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401
  describe '#add_import_job' do
    context 'forked' do
      let(:forked_project_link) { create(:forked_project_link) }
      let(:forked_from_project) { forked_project_link.forked_from_project }
      let(:project) { forked_project_link.forked_to_project }

      it 'schedules a RepositoryForkWorker job' do
        expect(RepositoryForkWorker).to receive(:perform_async).
          with(project.id, forked_from_project.repository_storage_path,
              forked_from_project.path_with_namespace, project.namespace.path)

        project.add_import_job
      end
    end

    context 'not forked' do
      let(:project) { create(:project) }

      it 'schedules a RepositoryImportWorker job' do
        expect(RepositoryImportWorker).to receive(:perform_async).with(project.id)

        project.add_import_job
      end
    end
  end

1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463
  describe '#lfs_enabled?' do
    let(:project) { create(:project) }

    shared_examples 'project overrides group' do
      it 'returns true when enabled in project' do
        project.update_attribute(:lfs_enabled, true)

        expect(project.lfs_enabled?).to be_truthy
      end

      it 'returns false when disabled in project' do
        project.update_attribute(:lfs_enabled, false)

        expect(project.lfs_enabled?).to be_falsey
      end

      it 'returns the value from the namespace, when no value is set in project' do
        expect(project.lfs_enabled?).to eq(project.namespace.lfs_enabled?)
      end
    end

    context 'LFS disabled in group' do
      before do
        project.namespace.update_attribute(:lfs_enabled, false)
        enable_lfs
      end

      it_behaves_like 'project overrides group'
    end

    context 'LFS enabled in group' do
      before do
        project.namespace.update_attribute(:lfs_enabled, true)
        enable_lfs
      end

      it_behaves_like 'project overrides group'
    end

    describe 'LFS disabled globally' do
      shared_examples 'it always returns false' do
        it do
          expect(project.lfs_enabled?).to be_falsey
          expect(project.namespace.lfs_enabled?).to be_falsey
        end
      end

      context 'when no values are set' do
        it_behaves_like 'it always returns false'
      end

      context 'when all values are set to true' do
        before do
          project.namespace.update_attribute(:lfs_enabled, true)
          project.update_attribute(:lfs_enabled, true)
        end

        it_behaves_like 'it always returns false'
      end
    end
  end

Y
Yorick Peterse 已提交
1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495
  describe '.where_paths_in' do
    context 'without any paths' do
      it 'returns an empty relation' do
        expect(Project.where_paths_in([])).to eq([])
      end
    end

    context 'without any valid paths' do
      it 'returns an empty relation' do
        expect(Project.where_paths_in(%w[foo])).to eq([])
      end
    end

    context 'with valid paths' do
      let!(:project1) { create(:project) }
      let!(:project2) { create(:project) }

      it 'returns the projects matching the paths' do
        projects = Project.where_paths_in([project1.path_with_namespace,
                                           project2.path_with_namespace])

        expect(projects).to contain_exactly(project1, project2)
      end

      it 'returns projects regardless of the casing of paths' do
        projects = Project.where_paths_in([project1.path_with_namespace.upcase,
                                           project2.path_with_namespace.upcase])

        expect(projects).to contain_exactly(project1, project2)
      end
    end
  end
1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544

  describe 'authorized_for_user' do
    let(:group) { create(:group) }
    let(:developer) { create(:user) }
    let(:master) { create(:user) }
    let(:personal_project) { create(:project, namespace: developer.namespace) }
    let(:group_project) { create(:project, namespace: group) }
    let(:members_project) { create(:project) }
    let(:shared_project) { create(:project) }

    before do
      group.add_master(master)
      group.add_developer(developer)

      members_project.team << [developer, :developer]
      members_project.team << [master, :master]

      create(:project_group_link, project: shared_project, group: group)
    end

    it 'returns false for no user' do
      expect(personal_project.authorized_for_user?(nil)).to be(false)
    end

    it 'returns true for personal projects of the user' do
      expect(personal_project.authorized_for_user?(developer)).to be(true)
    end

    it 'returns true for projects of groups the user is a member of' do
      expect(group_project.authorized_for_user?(developer)).to be(true)
    end

    it 'returns true for projects for which the user is a member of' do
      expect(members_project.authorized_for_user?(developer)).to be(true)
    end

    it 'returns true for projects shared on a group the user is a member of' do
      expect(shared_project.authorized_for_user?(developer)).to be(true)
    end

    it 'checks for the correct minimum level access' do
      expect(group_project.authorized_for_user?(developer, Gitlab::Access::MASTER)).to be(false)
      expect(group_project.authorized_for_user?(master, Gitlab::Access::MASTER)).to be(true)
      expect(members_project.authorized_for_user?(developer, Gitlab::Access::MASTER)).to be(false)
      expect(members_project.authorized_for_user?(master, Gitlab::Access::MASTER)).to be(true)
      expect(shared_project.authorized_for_user?(developer, Gitlab::Access::MASTER)).to be(false)
      expect(shared_project.authorized_for_user?(master, Gitlab::Access::MASTER)).to be(true)
    end
  end
1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575

  describe 'change_head' do
    let(:project) { create(:project) }

    it 'calls the before_change_head method' do
      expect(project.repository).to receive(:before_change_head)
      project.change_head(project.default_branch)
    end

    it 'creates the new reference with rugged' do
      expect(project.repository.rugged.references).to receive(:create).with('HEAD',
                                                                            "refs/heads/#{project.default_branch}",
                                                                            force: true)
      project.change_head(project.default_branch)
    end

    it 'copies the gitattributes' do
      expect(project.repository).to receive(:copy_gitattributes).with(project.default_branch)
      project.change_head(project.default_branch)
    end

    it 'expires the avatar cache' do
      expect(project.repository).to receive(:expire_avatar_cache).with(project.default_branch)
      project.change_head(project.default_branch)
    end

    it 'reloads the default branch' do
      expect(project).to receive(:reload_default_branch)
      project.change_head(project.default_branch)
    end
  end
Y
Yorick Peterse 已提交
1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627

  describe '#pushes_since_gc' do
    let(:project) { create(:project) }

    after do
      project.reset_pushes_since_gc
    end

    context 'without any pushes' do
      it 'returns 0' do
        expect(project.pushes_since_gc).to eq(0)
      end
    end

    context 'with a number of pushes' do
      it 'returns the number of pushes' do
        3.times { project.increment_pushes_since_gc }

        expect(project.pushes_since_gc).to eq(3)
      end
    end
  end

  describe '#increment_pushes_since_gc' do
    let(:project) { create(:project) }

    after do
      project.reset_pushes_since_gc
    end

    it 'increments the number of pushes since the last GC' do
      3.times { project.increment_pushes_since_gc }

      expect(project.pushes_since_gc).to eq(3)
    end
  end

  describe '#reset_pushes_since_gc' do
    let(:project) { create(:project) }

    after do
      project.reset_pushes_since_gc
    end

    it 'resets the number of pushes since the last GC' do
      3.times { project.increment_pushes_since_gc }

      project.reset_pushes_since_gc

      expect(project.pushes_since_gc).to eq(0)
    end
  end
1628

1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642
  describe '#environments_for' do
    let(:project) { create(:project) }
    let(:environment) { create(:environment, project: project) }

    context 'tagged deployment' do
      before do
        create(:deployment, environment: environment, ref: '1.0', tag: true, sha: project.commit.id)
      end

      it 'returns environment when with_tags is set' do
        expect(project.environments_for('master', project.commit, with_tags: true)).to contain_exactly(environment)
      end

      it 'does not return environment when no with_tags is set' do
K
Kamil Trzcinski 已提交
1643
        expect(project.environments_for('master', project.commit)).to be_empty
1644 1645 1646
      end

      it 'does not return environment when commit is not part of deployment' do
K
Kamil Trzcinski 已提交
1647
        expect(project.environments_for('master', project.commit('feature'))).to be_empty
1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660
      end
    end

    context 'branch deployment' do
      before do
        create(:deployment, environment: environment, ref: 'master', sha: project.commit.id)
      end

      it 'returns environment when ref is set' do
        expect(project.environments_for('master', project.commit)).to contain_exactly(environment)
      end

      it 'does not environment when ref is different' do
K
Kamil Trzcinski 已提交
1661
        expect(project.environments_for('feature', project.commit)).to be_empty
1662 1663 1664
      end

      it 'does not return environment when commit is not part of deployment' do
K
Kamil Trzcinski 已提交
1665
        expect(project.environments_for('master', project.commit('feature'))).to be_empty
1666 1667 1668 1669
      end
    end
  end

1670 1671 1672
  def enable_lfs
    allow(Gitlab.config.lfs).to receive(:enabled).and_return(true)
  end
G
gitlabhq 已提交
1673
end