project_spec.rb 17.8 KB
Newer Older
1 2 3 4
# == Schema Information
#
# Table name: projects
#
D
Dmitriy Zaporozhets 已提交
5
#  id                     :integer          not null, primary key
6 7 8
#  name                   :string(255)
#  path                   :string(255)
#  description            :text
D
Dmitriy Zaporozhets 已提交
9 10
#  created_at             :datetime
#  updated_at             :datetime
D
Dmitriy Zaporozhets 已提交
11
#  creator_id             :integer
D
Dmitriy Zaporozhets 已提交
12 13 14 15
#  issues_enabled         :boolean          default(TRUE), not null
#  wall_enabled           :boolean          default(TRUE), not null
#  merge_requests_enabled :boolean          default(TRUE), not null
#  wiki_enabled           :boolean          default(TRUE), not null
D
Dmitriy Zaporozhets 已提交
16
#  namespace_id           :integer
D
Dmitriy Zaporozhets 已提交
17
#  issues_tracker         :string(255)      default("gitlab"), not null
D
Dmitriy Zaporozhets 已提交
18
#  issues_tracker_id      :string(255)
D
Dmitriy Zaporozhets 已提交
19
#  snippets_enabled       :boolean          default(TRUE), not null
20
#  last_activity_at       :datetime
D
Dmitriy Zaporozhets 已提交
21
#  import_url             :string(255)
22
#  visibility_level       :integer          default(0), not null
23
#  archived               :boolean          default(FALSE), not null
A
Atsushi Ishida 已提交
24
#  avatar                 :string(255)
D
Dmitriy Zaporozhets 已提交
25
#  import_status          :string(255)
D
Dmitriy Zaporozhets 已提交
26 27
#  repository_size        :float            default(0.0)
#  star_count             :integer          default(0), not null
D
Dmitriy Zaporozhets 已提交
28 29
#  import_type            :string(255)
#  import_source          :string(255)
A
Atsushi Ishida 已提交
30
#  commit_count           :integer          default(0)
S
Stan Hu 已提交
31
#  import_error           :text
32 33
#

G
gitlabhq 已提交
34 35
require 'spec_helper'

D
Douwe Maan 已提交
36
describe Project, models: true do
37
  describe 'associations' do
38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56
    it { is_expected.to belong_to(:group) }
    it { is_expected.to belong_to(:namespace) }
    it { is_expected.to belong_to(:creator).class_name('User') }
    it { is_expected.to have_many(:users) }
    it { is_expected.to have_many(:events).dependent(:destroy) }
    it { is_expected.to have_many(:merge_requests).dependent(:destroy) }
    it { is_expected.to have_many(:issues).dependent(:destroy) }
    it { is_expected.to have_many(:milestones).dependent(:destroy) }
    it { is_expected.to have_many(:project_members).dependent(:destroy) }
    it { is_expected.to have_many(:notes).dependent(:destroy) }
    it { is_expected.to have_many(:snippets).class_name('ProjectSnippet').dependent(:destroy) }
    it { is_expected.to have_many(:deploy_keys_projects).dependent(:destroy) }
    it { is_expected.to have_many(:deploy_keys) }
    it { is_expected.to have_many(:hooks).dependent(:destroy) }
    it { is_expected.to have_many(:protected_branches).dependent(:destroy) }
    it { is_expected.to have_one(:forked_project_link).dependent(:destroy) }
    it { is_expected.to have_one(:slack_service).dependent(:destroy) }
    it { is_expected.to have_one(:pushover_service).dependent(:destroy) }
    it { is_expected.to have_one(:asana_service).dependent(:destroy) }
K
Kamil Trzcinski 已提交
57 58 59 60 61 62 63
    it { is_expected.to have_many(:ci_commits) }
    it { is_expected.to have_many(:ci_statuses) }
    it { is_expected.to have_many(:ci_builds) }
    it { is_expected.to have_many(:ci_runner_projects) }
    it { is_expected.to have_many(:ci_runners) }
    it { is_expected.to have_many(:ci_variables) }
    it { is_expected.to have_many(:ci_triggers) }
G
gitlabhq 已提交
64 65
  end

66 67 68 69 70 71 72 73
  describe 'modules' do
    subject { described_class }

    it { is_expected.to include_module(Gitlab::ConfigHelper) }
    it { is_expected.to include_module(Gitlab::ShellAdapter) }
    it { is_expected.to include_module(Gitlab::VisibilityLevel) }
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
74 75
  end

76
  describe 'validation' do
77 78
    let!(:project) { create(:project) }

79 80
    it { is_expected.to validate_presence_of(:name) }
    it { is_expected.to validate_uniqueness_of(:name).scoped_to(:namespace_id) }
81
    it { is_expected.to validate_length_of(:name).is_within(0..255) }
82

83 84
    it { is_expected.to validate_presence_of(:path) }
    it { is_expected.to validate_uniqueness_of(:path).scoped_to(:namespace_id) }
85 86
    it { is_expected.to validate_length_of(:path).is_within(0..255) }
    it { is_expected.to validate_length_of(:description).is_within(0..2000) }
87
    it { is_expected.to validate_presence_of(:creator) }
88
    it { is_expected.to validate_length_of(:issues_tracker_id).is_within(0..255) }
89
    it { is_expected.to validate_presence_of(:namespace) }
90

91
    it 'should not allow new projects beyond user limits' do
92
      project2 = build(:project)
93 94 95
      allow(project2).to receive(:creator).and_return(double(can_create_project?: false, projects_limit: 0).as_null_object)
      expect(project2).not_to be_valid
      expect(project2.errors[:limit_reached].first).to match(/Your project limit is 0/)
96
    end
G
gitlabhq 已提交
97
  end
K
Kamil Trzcinski 已提交
98 99 100 101 102 103 104 105 106 107 108 109
  
  describe 'project token' do
    it 'should set an random token if none provided' do
      project = FactoryGirl.create :empty_project, token: ''
      expect(project.token).not_to eq('')
    end

    it 'should not set an random toke if one provided' do
      project = FactoryGirl.create :empty_project, token: 'my-token'
      expect(project.token).to eq('my-token')
    end
  end
G
gitlabhq 已提交
110

111
  describe 'Respond to' do
112 113 114 115 116 117 118
    it { is_expected.to respond_to(:url_to_repo) }
    it { is_expected.to respond_to(:repo_exists?) }
    it { is_expected.to respond_to(:update_merge_requests) }
    it { is_expected.to respond_to(:execute_hooks) }
    it { is_expected.to respond_to(:name_with_namespace) }
    it { is_expected.to respond_to(:owner) }
    it { is_expected.to respond_to(:path_with_namespace) }
G
gitlabhq 已提交
119 120
  end

121 122 123 124 125 126 127 128
  describe '#to_reference' do
    let(:project) { create(:empty_project) }

    it 'returns a String reference to the object' do
      expect(project.to_reference).to eq project.path_with_namespace
    end
  end

129 130
  it 'should return valid url to repo' do
    project = Project.new(path: 'somewhere')
131
    expect(project.url_to_repo).to eq(Gitlab.config.gitlab_shell.ssh_path_prefix + 'somewhere.git')
G
gitlabhq 已提交
132 133
  end

D
Douwe Maan 已提交
134 135 136 137 138 139
  describe "#web_url" do
    let(:project) { create(:empty_project, path: "somewhere") }

    it 'returns the full web URL for this repo' do
      expect(project.web_url).to eq("#{Gitlab.config.gitlab.url}/#{project.namespace.path}/somewhere")
    end
A
Ariejan de Vroom 已提交
140 141
  end

D
Douwe Maan 已提交
142 143 144 145 146 147
  describe "#web_url_without_protocol" do
    let(:project) { create(:empty_project, path: "somewhere") }

    it 'returns the web URL without the protocol for this repo' do
      expect(project.web_url_without_protocol).to eq("#{Gitlab.config.gitlab.url.split('://')[1]}/#{project.namespace.path}/somewhere")
    end
148 149
  end

150
  describe 'last_activity methods' do
I
Izaak Alpert 已提交
151
    let(:project) { create(:project) }
152
    let(:last_event) { double(created_at: Time.now) }
G
gitlabhq 已提交
153

154 155
    describe 'last_activity' do
      it 'should alias last_activity to last_event' do
156
        allow(project).to receive(:last_event).and_return(last_event)
157
        expect(project.last_activity).to eq(last_event)
158
      end
G
gitlabhq 已提交
159 160
    end

161 162
    describe 'last_activity_date' do
      it 'returns the creation date of the project\'s last event if present' do
163
        create(:event, project: project)
164
        expect(project.last_activity_at.to_i).to eq(last_event.created_at.to_i)
165
      end
166

167
      it 'returns the project\'s last update date if it has no events' do
168
        expect(project.last_activity_date).to eq(project.updated_at)
169
      end
170 171
    end
  end
172

173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214
  describe '#get_issue' do
    let(:project) { create(:empty_project) }
    let(:issue)   { create(:issue, project: project) }

    context 'with default issues tracker' do
      it 'returns an issue' do
        expect(project.get_issue(issue.iid)).to eq issue
      end

      it 'returns nil when no issue found' do
        expect(project.get_issue(999)).to be_nil
      end
    end

    context 'with external issues tracker' do
      before do
        allow(project).to receive(:default_issues_tracker?).and_return(false)
      end

      it 'returns an ExternalIssue' do
        issue = project.get_issue('FOO-1234')
        expect(issue).to be_kind_of(ExternalIssue)
        expect(issue.iid).to eq 'FOO-1234'
        expect(issue.project).to eq project
      end
    end
  end

  describe '#issue_exists?' do
    let(:project) { create(:empty_project) }

    it 'is truthy when issue exists' do
      expect(project).to receive(:get_issue).and_return(double)
      expect(project.issue_exists?(1)).to be_truthy
    end

    it 'is falsey when issue does not exist' do
      expect(project).to receive(:get_issue).and_return(nil)
      expect(project.issue_exists?(1)).to be_falsey
    end
  end

215
  describe :update_merge_requests do
D
Dmitriy Zaporozhets 已提交
216
    let(:project) { create(:project) }
217 218 219 220
    let(:merge_request) { create(:merge_request, source_project: project, target_project: project) }
    let(:key) { create(:key, user_id: project.owner.id) }
    let(:prev_commit_id) { merge_request.commits.last.id }
    let(:commit_id) { merge_request.commits.first.id }
221

222
    it 'should close merge request if last commit from source branch was pushed to target branch' do
223 224
      project.update_merge_requests(prev_commit_id, commit_id, "refs/heads/#{merge_request.target_branch}", key.user)
      merge_request.reload
225
      expect(merge_request.merged?).to be_truthy
226 227
    end

228
    it 'should update merge request commits with new one if pushed to source branch' do
229 230
      project.update_merge_requests(prev_commit_id, commit_id, "refs/heads/#{merge_request.source_branch}", key.user)
      merge_request.reload
231
      expect(merge_request.last_commit.id).to eq(commit_id)
232 233
    end
  end
234 235 236 237 238

  describe :find_with_namespace do
    context 'with namespace' do
      before do
        @group = create :group, name: 'gitlab'
D
Dmitriy Zaporozhets 已提交
239
        @project = create(:project, name: 'gitlabhq', namespace: @group)
240 241
      end

242
      it { expect(Project.find_with_namespace('gitlab/gitlabhq')).to eq(@project) }
243
      it { expect(Project.find_with_namespace('GitLab/GitlabHQ')).to eq(@project) }
244
      it { expect(Project.find_with_namespace('gitlab-ci')).to be_nil }
245 246 247 248 249 250 251
    end
  end

  describe :to_param do
    context 'with namespace' do
      before do
        @group = create :group, name: 'gitlab'
D
Dmitriy Zaporozhets 已提交
252
        @project = create(:project, name: 'gitlabhq', namespace: @group)
253 254
      end

V
Vinnie Okada 已提交
255
      it { expect(@project.to_param).to eq('gitlabhq') }
256 257
    end
  end
D
Dmitriy Zaporozhets 已提交
258

259
  describe :repository do
D
Dmitriy Zaporozhets 已提交
260 261
    let(:project) { create(:project) }

262
    it 'should return valid repo' do
263
      expect(project.repository).to be_kind_of(Repository)
D
Dmitriy Zaporozhets 已提交
264 265
    end
  end
266

267
  describe :default_issues_tracker? do
268 269 270 271
    let(:project) { create(:project) }
    let(:ext_project) { create(:redmine_project) }

    it "should be true if used internal tracker" do
272
      expect(project.default_issues_tracker?).to be_truthy
273 274 275
    end

    it "should be false if used other tracker" do
276
      expect(ext_project.default_issues_tracker?).to be_falsey
277 278 279
    end
  end

A
Andrew8xx8 已提交
280 281 282 283
  describe :can_have_issues_tracker_id? do
    let(:project) { create(:project) }
    let(:ext_project) { create(:redmine_project) }

284
    it 'should be true for projects with external issues tracker if issues enabled' do
285
      expect(ext_project.can_have_issues_tracker_id?).to be_truthy
286
    end
A
Andrew8xx8 已提交
287

288
    it 'should be false for projects with internal issue tracker if issues enabled' do
289
      expect(project.can_have_issues_tracker_id?).to be_falsey
A
Andrew8xx8 已提交
290 291
    end

292
    it 'should be always false if issues disabled' do
A
Andrew8xx8 已提交
293 294 295
      project.issues_enabled = false
      ext_project.issues_enabled = false

296 297
      expect(project.can_have_issues_tracker_id?).to be_falsey
      expect(ext_project.can_have_issues_tracker_id?).to be_falsey
A
Andrew8xx8 已提交
298 299
    end
  end
300 301

  describe :open_branches do
D
Dmitriy Zaporozhets 已提交
302
    let(:project) { create(:project) }
303 304 305 306 307

    before do
      project.protected_branches.create(name: 'master')
    end

308 309
    it { expect(project.open_branches.map(&:name)).to include('feature') }
    it { expect(project.open_branches.map(&:name)).not_to include('master') }
310
  end
C
Ciro Santilli 已提交
311

312 313
  describe '#star_count' do
    it 'counts stars from multiple users' do
C
Ciro Santilli 已提交
314 315 316 317 318
      user1 = create :user
      user2 = create :user
      project = create :project, :public

      expect(project.star_count).to eq(0)
319

C
Ciro Santilli 已提交
320
      user1.toggle_star(project)
321 322
      expect(project.reload.star_count).to eq(1)

C
Ciro Santilli 已提交
323
      user2.toggle_star(project)
324 325 326
      project.reload
      expect(project.reload.star_count).to eq(2)

C
Ciro Santilli 已提交
327
      user1.toggle_star(project)
328 329 330
      project.reload
      expect(project.reload.star_count).to eq(1)

C
Ciro Santilli 已提交
331
      user2.toggle_star(project)
332 333 334 335
      project.reload
      expect(project.reload.star_count).to eq(0)
    end

336
    it 'counts stars on the right project' do
337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366
      user = create :user
      project1 = create :project, :public
      project2 = create :project, :public

      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project1)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(1)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project1)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project2)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(1)

      user.toggle_star(project2)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)
C
Ciro Santilli 已提交
367 368
    end
  end
369 370 371 372 373 374

  describe :avatar_type do
    let(:project) { create(:project) }

    it 'should be true if avatar is image' do
      project.update_attribute(:avatar, 'uploads/avatar.png')
375
      expect(project.avatar_type).to be_truthy
376 377 378 379
    end

    it 'should be false if avatar is html page' do
      project.update_attribute(:avatar, 'uploads/avatar.html')
380
      expect(project.avatar_type).to eq(['only images allowed'])
381 382
    end
  end
S
sue445 已提交
383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413

  describe :avatar_url do
    subject { project.avatar_url }

    let(:project) { create(:project) }

    context 'When avatar file is uploaded' do
      before do
        project.update_columns(avatar: 'uploads/avatar.png')
        allow(project.avatar).to receive(:present?) { true }
      end

      let(:avatar_path) do
        "/uploads/project/avatar/#{project.id}/uploads/avatar.png"
      end

      it { should eq "http://localhost#{avatar_path}" }
    end

    context 'When avatar file in git' do
      before do
        allow(project).to receive(:avatar_in_git) { true }
      end

      let(:avatar_path) do
        "/#{project.namespace.name}/#{project.path}/avatar"
      end

      it { should eq "http://localhost#{avatar_path}" }
    end
  end
414 415 416

  describe :ci_commit do
    let(:project) { create :project }
K
Kamil Trzcinski 已提交
417
    let(:commit) { create :ci_commit, project: project }
418 419 420

    it { expect(project.ci_commit(commit.sha)).to eq(commit) }
  end
421

422
  describe :builds_enabled do
423 424
    let(:project) { create :project }

425
    before { project.builds_enabled = true }
426

427 428 429
    subject { project.builds_enabled }

    it { expect(project.builds_enabled?).to be_truthy }
430
  end
Y
Yorick Peterse 已提交
431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459

  describe '.trending' do
    let(:group)    { create(:group) }
    let(:project1) { create(:empty_project, :public, group: group) }
    let(:project2) { create(:empty_project, :public, group: group) }

    before do
      2.times do
        create(:note_on_commit, project: project1)
      end

      create(:note_on_commit, project: project2)
    end

    describe 'without an explicit start date' do
      subject { described_class.trending.to_a }

      it 'sorts Projects by the amount of notes in descending order' do
        expect(subject).to eq([project1, project2])
      end
    end

    describe 'with an explicit start date' do
      let(:date) { 2.months.ago }

      subject { described_class.trending(date).to_a }

      before do
        2.times do
460 461 462
          # Little fix for special issue related to Fractional Seconds support for MySQL.
          # See: https://github.com/rails/rails/pull/14359/files
          create(:note_on_commit, project: project2, created_at: date + 1)
Y
Yorick Peterse 已提交
463 464 465 466 467 468 469 470
        end
      end

      it 'sorts Projects by the amount of notes in descending order' do
        expect(subject).to eq([project2, project1])
      end
    end
  end
Y
Yorick Peterse 已提交
471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489

  describe '.visible_to_user' do
    let!(:project) { create(:project, :private) }
    let!(:user)    { create(:user) }

    subject { described_class.visible_to_user(user) }

    describe 'when a user has access to a project' do
      before do
        project.team.add_user(user, Gitlab::Access::MASTER)
      end

      it { is_expected.to eq([project]) }
    end

    describe 'when a user does not have access to any projects' do
      it { is_expected.to eq([]) }
    end
  end
K
Kamil Trzcinski 已提交
490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550

  context 'shared runners by default' do
    let(:project) { create(:empty_project) }

    subject { project.shared_runners_enabled }

    context 'are enabled' do
      before { stub_application_setting(shared_runners_enabled: true) }

      it { is_expected.to be_truthy }
    end

    context 'are disabled' do
      before { stub_application_setting(shared_runners_enabled: false) }

      it { is_expected.to be_falsey }
    end
  end

  describe :any_runners do
    let(:project) { create(:empty_project, shared_runners_enabled: shared_runners_enabled) }
    let(:specific_runner) { create(:ci_specific_runner) }
    let(:shared_runner) { create(:ci_shared_runner) }

    context 'for shared runners disabled' do
      let(:shared_runners_enabled) { false }
      
      it 'there are no runners available' do
        expect(project.any_runners?).to be_falsey
      end
  
      it 'there is a specific runner' do
        project.ci_runners << specific_runner
        expect(project.any_runners?).to be_truthy
      end
  
      it 'there is a shared runner, but they are prohibited to use' do
        shared_runner
        expect(project.any_runners?).to be_falsey
      end
  
      it 'checks the presence of specific runner' do
        project.ci_runners << specific_runner
        expect(project.any_runners? { |runner| runner == specific_runner }).to be_truthy
      end
    end
    
    context 'for shared runners enabled' do
      let(:shared_runners_enabled) { true }
      
      it 'there is a shared runner' do
        shared_runner
        expect(project.any_runners?).to be_truthy
      end

      it 'checks the presence of shared runner' do
        shared_runner
        expect(project.any_runners? { |runner| runner == shared_runner }).to be_truthy
      end
    end
  end
G
gitlabhq 已提交
551
end