project_spec.rb 59.6 KB
Newer Older
G
gitlabhq 已提交
1 2
require 'spec_helper'

D
Douwe Maan 已提交
3
describe Project, models: true do
4
  describe 'associations' do
5 6 7 8
    it { is_expected.to belong_to(:group) }
    it { is_expected.to belong_to(:namespace) }
    it { is_expected.to belong_to(:creator).class_name('User') }
    it { is_expected.to have_many(:users) }
U
ubudzisz 已提交
9
    it { is_expected.to have_many(:services) }
10 11 12 13 14
    it { is_expected.to have_many(:events).dependent(:destroy) }
    it { is_expected.to have_many(:merge_requests).dependent(:destroy) }
    it { is_expected.to have_many(:issues).dependent(:destroy) }
    it { is_expected.to have_many(:milestones).dependent(:destroy) }
    it { is_expected.to have_many(:project_members).dependent(:destroy) }
15 16
    it { is_expected.to have_many(:users).through(:project_members) }
    it { is_expected.to have_many(:requesters).dependent(:destroy) }
17 18 19 20 21 22 23
    it { is_expected.to have_many(:notes).dependent(:destroy) }
    it { is_expected.to have_many(:snippets).class_name('ProjectSnippet').dependent(:destroy) }
    it { is_expected.to have_many(:deploy_keys_projects).dependent(:destroy) }
    it { is_expected.to have_many(:deploy_keys) }
    it { is_expected.to have_many(:hooks).dependent(:destroy) }
    it { is_expected.to have_many(:protected_branches).dependent(:destroy) }
    it { is_expected.to have_one(:forked_project_link).dependent(:destroy) }
24
    it { is_expected.to have_one(:slack_service).dependent(:destroy) }
25
    it { is_expected.to have_one(:mattermost_service).dependent(:destroy) }
26 27
    it { is_expected.to have_one(:pushover_service).dependent(:destroy) }
    it { is_expected.to have_one(:asana_service).dependent(:destroy) }
28
    it { is_expected.to have_many(:boards).dependent(:destroy) }
U
ubudzisz 已提交
29 30 31 32 33 34 35 36 37 38
    it { is_expected.to have_one(:campfire_service).dependent(:destroy) }
    it { is_expected.to have_one(:drone_ci_service).dependent(:destroy) }
    it { is_expected.to have_one(:emails_on_push_service).dependent(:destroy) }
    it { is_expected.to have_one(:builds_email_service).dependent(:destroy) }
    it { is_expected.to have_one(:emails_on_push_service).dependent(:destroy) }
    it { is_expected.to have_one(:irker_service).dependent(:destroy) }
    it { is_expected.to have_one(:pivotaltracker_service).dependent(:destroy) }
    it { is_expected.to have_one(:hipchat_service).dependent(:destroy) }
    it { is_expected.to have_one(:flowdock_service).dependent(:destroy) }
    it { is_expected.to have_one(:assembla_service).dependent(:destroy) }
K
Kamil Trzcinski 已提交
39
    it { is_expected.to have_one(:slack_slash_commands_service).dependent(:destroy) }
40
    it { is_expected.to have_one(:mattermost_slash_commands_service).dependent(:destroy) }
U
ubudzisz 已提交
41 42 43 44 45 46 47 48 49 50 51
    it { is_expected.to have_one(:gemnasium_service).dependent(:destroy) }
    it { is_expected.to have_one(:buildkite_service).dependent(:destroy) }
    it { is_expected.to have_one(:bamboo_service).dependent(:destroy) }
    it { is_expected.to have_one(:teamcity_service).dependent(:destroy) }
    it { is_expected.to have_one(:jira_service).dependent(:destroy) }
    it { is_expected.to have_one(:redmine_service).dependent(:destroy) }
    it { is_expected.to have_one(:custom_issue_tracker_service).dependent(:destroy) }
    it { is_expected.to have_one(:bugzilla_service).dependent(:destroy) }
    it { is_expected.to have_one(:gitlab_issue_tracker_service).dependent(:destroy) }
    it { is_expected.to have_one(:external_wiki_service).dependent(:destroy) }
    it { is_expected.to have_one(:project_feature).dependent(:destroy) }
M
Markus Koller 已提交
52
    it { is_expected.to have_one(:statistics).class_name('ProjectStatistics').dependent(:delete) }
U
ubudzisz 已提交
53 54 55
    it { is_expected.to have_one(:import_data).class_name('ProjectImportData').dependent(:destroy) }
    it { is_expected.to have_one(:last_event).class_name('Event') }
    it { is_expected.to have_one(:forked_from_project).through(:forked_project_link) }
K
Kamil Trzcinski 已提交
56
    it { is_expected.to have_many(:commit_statuses) }
57
    it { is_expected.to have_many(:pipelines) }
58 59 60 61 62
    it { is_expected.to have_many(:builds) }
    it { is_expected.to have_many(:runner_projects) }
    it { is_expected.to have_many(:runners) }
    it { is_expected.to have_many(:variables) }
    it { is_expected.to have_many(:triggers) }
D
Douglas Barbosa Alexandre 已提交
63
    it { is_expected.to have_many(:labels).class_name('ProjectLabel').dependent(:destroy) }
U
ubudzisz 已提交
64
    it { is_expected.to have_many(:users_star_projects).dependent(:destroy) }
65 66
    it { is_expected.to have_many(:environments).dependent(:destroy) }
    it { is_expected.to have_many(:deployments).dependent(:destroy) }
67
    it { is_expected.to have_many(:todos).dependent(:destroy) }
U
ubudzisz 已提交
68 69 70 71 72
    it { is_expected.to have_many(:releases).dependent(:destroy) }
    it { is_expected.to have_many(:lfs_objects_projects).dependent(:destroy) }
    it { is_expected.to have_many(:project_group_links).dependent(:destroy) }
    it { is_expected.to have_many(:notification_settings).dependent(:destroy) }
    it { is_expected.to have_many(:forks).through(:forked_project_links) }
73

F
Felipe Artur 已提交
74 75
    context 'after initialized' do
      it "has a project_feature" do
76
        expect(Project.new.project_feature).to be_present
77 78 79
      end
    end

80
    describe '#members & #requesters' do
81
      let(:project) { create(:empty_project, :public, :access_requestable) }
82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106
      let(:requester) { create(:user) }
      let(:developer) { create(:user) }
      before do
        project.request_access(requester)
        project.team << [developer, :developer]
      end

      describe '#members' do
        it 'includes members and exclude requesters' do
          member_user_ids = project.members.pluck(:user_id)

          expect(member_user_ids).to include(developer.id)
          expect(member_user_ids).not_to include(requester.id)
        end
      end

      describe '#requesters' do
        it 'does not include requesters' do
          requester_user_ids = project.requesters.pluck(:user_id)

          expect(requester_user_ids).to include(requester.id)
          expect(requester_user_ids).not_to include(developer.id)
        end
      end
    end
107 108 109 110 111

    describe '#boards' do
      it 'raises an error when attempting to add more than one board to the project' do
        subject.boards.build

112
        expect { subject.boards.build }.to raise_error(Project::BoardLimitExceeded, 'Number of permitted boards exceeded')
113 114 115
        expect(subject.boards.size).to eq 1
      end
    end
G
gitlabhq 已提交
116 117
  end

118 119 120 121 122 123
  describe 'modules' do
    subject { described_class }

    it { is_expected.to include_module(Gitlab::ConfigHelper) }
    it { is_expected.to include_module(Gitlab::ShellAdapter) }
    it { is_expected.to include_module(Gitlab::VisibilityLevel) }
124
    it { is_expected.to include_module(Gitlab::CurrentSettings) }
125 126
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
127 128
  end

129
  describe 'validation' do
130
    let!(:project) { create(:empty_project) }
131

132 133
    it { is_expected.to validate_presence_of(:name) }
    it { is_expected.to validate_uniqueness_of(:name).scoped_to(:namespace_id) }
134
    it { is_expected.to validate_length_of(:name).is_at_most(255) }
135

136 137
    it { is_expected.to validate_presence_of(:path) }
    it { is_expected.to validate_uniqueness_of(:path).scoped_to(:namespace_id) }
138 139 140 141
    it { is_expected.to validate_length_of(:path).is_at_most(255) }

    it { is_expected.to validate_length_of(:description).is_at_most(2000) }

142
    it { is_expected.to validate_presence_of(:creator) }
143

144
    it { is_expected.to validate_presence_of(:namespace) }
145

146
    it { is_expected.to validate_presence_of(:repository_storage) }
147

148
    it 'does not allow new projects beyond user limits' do
149
      project2 = build(:empty_project)
150 151
      allow(project2).to receive(:creator).and_return(double(can_create_project?: false, projects_limit: 0).as_null_object)
      expect(project2).not_to be_valid
P
Phil Hughes 已提交
152
      expect(project2.errors[:limit_reached].first).to match(/Personal project creation is not allowed/)
153
    end
154 155 156

    describe 'wiki path conflict' do
      context "when the new path has been used by the wiki of other Project" do
157
        it 'has an error on the name attribute' do
158
          new_project = build_stubbed(:empty_project, namespace_id: project.namespace_id, path: "#{project.path}.wiki")
159 160 161 162 163 164 165

          expect(new_project).not_to be_valid
          expect(new_project.errors[:name].first).to eq('has already been taken')
        end
      end

      context "when the new wiki path has been used by the path of other Project" do
166
        it 'has an error on the name attribute' do
167 168
          project_with_wiki_suffix = create(:empty_project, path: 'foo.wiki')
          new_project = build_stubbed(:empty_project, namespace_id: project_with_wiki_suffix.namespace_id, path: 'foo')
169 170 171 172 173 174

          expect(new_project).not_to be_valid
          expect(new_project.errors[:name].first).to eq('has already been taken')
        end
      end
    end
175 176

    context 'repository storages inclussion' do
177
      let(:project2) { build(:empty_project, repository_storage: 'missing') }
178 179 180 181 182 183

      before do
        storages = { 'custom' => 'tmp/tests/custom_repositories' }
        allow(Gitlab.config.repositories).to receive(:storages).and_return(storages)
      end

184
      it "does not allow repository storages that don't match a label in the configuration" do
185 186 187 188
        expect(project2).not_to be_valid
        expect(project2.errors[:repository_storage].first).to match(/is not included in the list/)
      end
    end
189

190
    it 'does not allow an invalid URI as import_url' do
191
      project2 = build(:empty_project, import_url: 'invalid://')
J
James Lopez 已提交
192 193 194 195

      expect(project2).not_to be_valid
    end

196
    it 'does allow a valid URI as import_url' do
197
      project2 = build(:empty_project, import_url: 'ssh://test@gitlab.com/project.git')
J
James Lopez 已提交
198

199 200
      expect(project2).to be_valid
    end
201

202
    it 'allows an empty URI' do
203
      project2 = build(:empty_project, import_url: '')
204

205
      expect(project2).to be_valid
206 207 208
    end

    it 'does not produce import data on an empty URI' do
209
      project2 = build(:empty_project, import_url: '')
210 211 212 213 214

      expect(project2.import_data).to be_nil
    end

    it 'does not produce import data on an invalid URI' do
215
      project2 = build(:empty_project, import_url: 'test://')
216 217 218

      expect(project2.import_data).to be_nil
    end
219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238

    describe 'project pending deletion' do
      let!(:project_pending_deletion) do
        create(:empty_project,
               pending_delete: true)
      end
      let(:new_project) do
        build(:empty_project,
              name: project_pending_deletion.name,
              namespace: project_pending_deletion.namespace)
      end

      before do
        new_project.validate
      end

      it 'contains errors related to the project being deleted' do
        expect(new_project.errors.full_messages.first).to eq('The project is still being deleted. Please try again later.')
      end
    end
G
gitlabhq 已提交
239
  end
240

241 242 243 244 245 246 247 248 249
  describe 'default_scope' do
    it 'excludes projects pending deletion from the results' do
      project = create(:empty_project)
      create(:empty_project, pending_delete: true)

      expect(Project.all).to eq [project]
    end
  end

K
Kamil Trzcinski 已提交
250
  describe 'project token' do
251
    it 'sets an random token if none provided' do
K
Kamil Trzcinski 已提交
252 253
      project = FactoryGirl.create :empty_project, runners_token: ''
      expect(project.runners_token).not_to eq('')
K
Kamil Trzcinski 已提交
254 255
    end

U
ubudzisz 已提交
256
    it 'does not set an random token if one provided' do
K
Kamil Trzcinski 已提交
257 258
      project = FactoryGirl.create :empty_project, runners_token: 'my-token'
      expect(project.runners_token).to eq('my-token')
K
Kamil Trzcinski 已提交
259 260
    end
  end
G
gitlabhq 已提交
261

262
  describe 'Respond to' do
263 264 265 266 267
    it { is_expected.to respond_to(:url_to_repo) }
    it { is_expected.to respond_to(:repo_exists?) }
    it { is_expected.to respond_to(:execute_hooks) }
    it { is_expected.to respond_to(:owner) }
    it { is_expected.to respond_to(:path_with_namespace) }
G
gitlabhq 已提交
268 269
  end

270 271 272 273 274 275 276
  describe 'delegation' do
    it { is_expected.to delegate_method(:add_guest).to(:team) }
    it { is_expected.to delegate_method(:add_reporter).to(:team) }
    it { is_expected.to delegate_method(:add_developer).to(:team) }
    it { is_expected.to delegate_method(:add_master).to(:team) }
  end

R
Rémy Coutable 已提交
277 278 279 280 281 282 283
  describe '#name_with_namespace' do
    let(:project) { build_stubbed(:empty_project) }

    it { expect(project.name_with_namespace).to eq "#{project.namespace.human_name} / #{project.name}" }
    it { expect(project.human_name).to eq project.name_with_namespace }
  end

284
  describe '#to_reference' do
285
    let(:owner)     { create(:user, name: 'Gitlab') }
286
    let(:namespace) { create(:namespace, path: 'sample-namespace', owner: owner) }
287 288
    let(:project)   { create(:empty_project, path: 'sample-project', namespace: namespace) }
    let(:group)     { create(:group, name: 'Group', path: 'sample-group', owner: owner) }
289

290
    context 'when nil argument' do
291 292 293 294 295
      it 'returns nil' do
        expect(project.to_reference).to be_nil
      end
    end

296
    context 'when full is true' do
297
      it 'returns complete path to the project' do
298 299 300
        expect(project.to_reference(full: true)).to          eq 'sample-namespace/sample-project'
        expect(project.to_reference(project, full: true)).to eq 'sample-namespace/sample-project'
        expect(project.to_reference(group, full: true)).to   eq 'sample-namespace/sample-project'
301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320
      end
    end

    context 'when same project argument' do
      it 'returns nil' do
        expect(project.to_reference(project)).to be_nil
      end
    end

    context 'when cross namespace project argument' do
      let(:another_namespace_project) { create(:empty_project, name: 'another-project') }

      it 'returns complete path to the project' do
        expect(project.to_reference(another_namespace_project)).to eq 'sample-namespace/sample-project'
      end
    end

    context 'when same namespace / cross-project argument' do
      let(:another_project) { create(:empty_project, namespace: namespace) }

321
      it 'returns path to the project' do
322 323 324
        expect(project.to_reference(another_project)).to eq 'sample-project'
      end
    end
325

326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345
    context 'when different namespace / cross-project argument' do
      let(:another_namespace) { create(:namespace, path: 'another-namespace', owner: owner) }
      let(:another_project)   { create(:empty_project, path: 'another-project', namespace: another_namespace) }

      it 'returns full path to the project' do
        expect(project.to_reference(another_project)).to eq 'sample-namespace/sample-project'
      end
    end

    context 'when argument is a namespace' do
      context 'with same project path' do
        it 'returns path to the project' do
          expect(project.to_reference(namespace)).to eq 'sample-project'
        end
      end

      context 'with different project path' do
        it 'returns full path to the project' do
          expect(project.to_reference(group)).to eq 'sample-namespace/sample-project'
        end
346 347
      end
    end
348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380
  end

  describe '#to_human_reference' do
    let(:owner) { create(:user, name: 'Gitlab') }
    let(:namespace) { create(:namespace, name: 'Sample namespace', owner: owner) }
    let(:project) { create(:empty_project, name: 'Sample project', namespace: namespace) }

    context 'when nil argument' do
      it 'returns nil' do
        expect(project.to_human_reference).to be_nil
      end
    end

    context 'when same project argument' do
      it 'returns nil' do
        expect(project.to_human_reference(project)).to be_nil
      end
    end

    context 'when cross namespace project argument' do
      let(:another_namespace_project) { create(:empty_project, name: 'another-project') }

      it 'returns complete name with namespace of the project' do
        expect(project.to_human_reference(another_namespace_project)).to eq 'Gitlab / Sample project'
      end
    end

    context 'when same namespace / cross-project argument' do
      let(:another_project) { create(:empty_project, namespace: namespace) }

      it 'returns name of the project' do
        expect(project.to_human_reference(another_project)).to eq 'Sample project'
      end
381 382 383
    end
  end

384
  describe '#repository_storage_path' do
385
    let(:project) { create(:empty_project, repository_storage: 'custom') }
386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401

    before do
      FileUtils.mkdir('tmp/tests/custom_repositories')
      storages = { 'custom' => 'tmp/tests/custom_repositories' }
      allow(Gitlab.config.repositories).to receive(:storages).and_return(storages)
    end

    after do
      FileUtils.rm_rf('tmp/tests/custom_repositories')
    end

    it 'returns the repository storage path' do
      expect(project.repository_storage_path).to eq('tmp/tests/custom_repositories')
    end
  end

402
  it 'returns valid url to repo' do
403
    project = Project.new(path: 'somewhere')
404
    expect(project.url_to_repo).to eq(Gitlab.config.gitlab_shell.ssh_path_prefix + 'somewhere.git')
G
gitlabhq 已提交
405 406
  end

D
Douwe Maan 已提交
407 408 409 410 411 412
  describe "#web_url" do
    let(:project) { create(:empty_project, path: "somewhere") }

    it 'returns the full web URL for this repo' do
      expect(project.web_url).to eq("#{Gitlab.config.gitlab.url}/#{project.namespace.path}/somewhere")
    end
A
Ariejan de Vroom 已提交
413 414
  end

415
  describe "#new_issue_address" do
416 417 418
    let(:project) { create(:empty_project, path: "somewhere") }
    let(:user) { create(:user) }

419 420 421 422 423 424
    context 'incoming email enabled' do
      before do
        stub_incoming_email_setting(enabled: true, address: "p+%{key}@gl.ab")
      end

      it 'returns the address to create a new issue' do
425
        address = "p+#{project.path_with_namespace}+#{user.incoming_email_token}@gl.ab"
426 427 428 429 430 431 432 433 434

        expect(project.new_issue_address(user)).to eq(address)
      end
    end

    context 'incoming email disabled' do
      before do
        stub_incoming_email_setting(enabled: false)
      end
435

436 437 438
      it 'returns nil' do
        expect(project.new_issue_address(user)).to be_nil
      end
439 440 441
    end
  end

442
  describe 'last_activity methods' do
S
Stan Hu 已提交
443 444
    let(:timestamp) { 2.hours.ago }
    # last_activity_at gets set to created_at upon creation
445
    let(:project) { create(:empty_project, created_at: timestamp, updated_at: timestamp) }
G
gitlabhq 已提交
446

447
    describe 'last_activity' do
448
      it 'alias last_activity to last_event' do
449 450
        last_event = create(:event, project: project)

451
        expect(project.last_activity).to eq(last_event)
452
      end
G
gitlabhq 已提交
453 454
    end

455 456
    describe 'last_activity_date' do
      it 'returns the creation date of the project\'s last event if present' do
457 458
        new_event = create(:event, project: project, created_at: Time.now)

S
Stan Hu 已提交
459
        project.reload
460
        expect(project.last_activity_at.to_i).to eq(new_event.created_at.to_i)
461
      end
462

463
      it 'returns the project\'s last update date if it has no events' do
464
        expect(project.last_activity_date).to eq(project.updated_at)
465
      end
466 467
    end
  end
468

469 470
  describe '#get_issue' do
    let(:project) { create(:empty_project) }
S
Stan Hu 已提交
471
    let!(:issue)  { create(:issue, project: project) }
472 473 474 475 476
    let(:user)    { create(:user) }

    before do
      project.team << [user, :developer]
    end
477 478 479

    context 'with default issues tracker' do
      it 'returns an issue' do
480
        expect(project.get_issue(issue.iid, user)).to eq issue
481 482
      end

S
Stan Hu 已提交
483 484 485 486
      it 'returns count of open issues' do
        expect(project.open_issues_count).to eq(1)
      end

487
      it 'returns nil when no issue found' do
488 489 490 491 492 493
        expect(project.get_issue(999, user)).to be_nil
      end

      it "returns nil when user doesn't have access" do
        user = create(:user)
        expect(project.get_issue(issue.iid, user)).to eq nil
494 495 496 497 498 499 500 501 502
      end
    end

    context 'with external issues tracker' do
      before do
        allow(project).to receive(:default_issues_tracker?).and_return(false)
      end

      it 'returns an ExternalIssue' do
503
        issue = project.get_issue('FOO-1234', user)
504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524
        expect(issue).to be_kind_of(ExternalIssue)
        expect(issue.iid).to eq 'FOO-1234'
        expect(issue.project).to eq project
      end
    end
  end

  describe '#issue_exists?' do
    let(:project) { create(:empty_project) }

    it 'is truthy when issue exists' do
      expect(project).to receive(:get_issue).and_return(double)
      expect(project.issue_exists?(1)).to be_truthy
    end

    it 'is falsey when issue does not exist' do
      expect(project).to receive(:get_issue).and_return(nil)
      expect(project.issue_exists?(1)).to be_falsey
    end
  end

L
Lin Jen-Shin 已提交
525
  describe '#to_param' do
526 527 528
    context 'with namespace' do
      before do
        @group = create :group, name: 'gitlab'
529
        @project = create(:empty_project, name: 'gitlabhq', namespace: @group)
530 531
      end

V
Vinnie Okada 已提交
532
      it { expect(@project.to_param).to eq('gitlabhq') }
533
    end
534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551

    context 'with invalid path' do
      it 'returns previous path to keep project suitable for use in URLs when persisted' do
        project = create(:empty_project, path: 'gitlab')
        project.path = 'foo&bar'

        expect(project).not_to be_valid
        expect(project.to_param).to eq 'gitlab'
      end

      it 'returns current path when new record' do
        project = build(:empty_project, path: 'gitlab')
        project.path = 'foo&bar'

        expect(project).not_to be_valid
        expect(project.to_param).to eq 'foo&bar'
      end
    end
552
  end
D
Dmitriy Zaporozhets 已提交
553

L
Lin Jen-Shin 已提交
554
  describe '#repository' do
555
    let(:project) { create(:project, :repository) }
D
Dmitriy Zaporozhets 已提交
556

557
    it 'returns valid repo' do
558
      expect(project.repository).to be_kind_of(Repository)
D
Dmitriy Zaporozhets 已提交
559 560
    end
  end
561

L
Lin Jen-Shin 已提交
562
  describe '#default_issues_tracker?' do
563
    it "is true if used internal tracker" do
564 565
      project = build(:empty_project)

566
      expect(project.default_issues_tracker?).to be_truthy
567 568
    end

569
    it "is false if used other tracker" do
570 571 572 573
      # NOTE: The current nature of this factory requires persistence
      project = create(:redmine_project)

      expect(project.default_issues_tracker?).to be_falsey
574 575 576
    end
  end

L
Lin Jen-Shin 已提交
577
  describe '#external_issue_tracker' do
578
    let(:project) { create(:empty_project) }
579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611
    let(:ext_project) { create(:redmine_project) }

    context 'on existing projects with no value for has_external_issue_tracker' do
      before(:each) do
        project.update_column(:has_external_issue_tracker, nil)
        ext_project.update_column(:has_external_issue_tracker, nil)
      end

      it 'updates the has_external_issue_tracker boolean' do
        expect do
          project.external_issue_tracker
        end.to change { project.reload.has_external_issue_tracker }.to(false)

        expect do
          ext_project.external_issue_tracker
        end.to change { ext_project.reload.has_external_issue_tracker }.to(true)
      end
    end

    it 'returns nil and does not query services when there is no external issue tracker' do
      expect(project).not_to receive(:services)

      expect(project.external_issue_tracker).to eq(nil)
    end

    it 'retrieves external_issue_tracker querying services and cache it when there is external issue tracker' do
      ext_project.reload # Factory returns a project with changed attributes
      expect(ext_project).to receive(:services).once.and_call_original

      2.times { expect(ext_project.external_issue_tracker).to be_a_kind_of(RedmineService) }
    end
  end

L
Lin Jen-Shin 已提交
612
  describe '#cache_has_external_issue_tracker' do
613
    let(:project) { create(:empty_project, has_external_issue_tracker: nil) }
614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633

    it 'stores true if there is any external_issue_tracker' do
      services = double(:service, external_issue_trackers: [RedmineService.new])
      expect(project).to receive(:services).and_return(services)

      expect do
        project.cache_has_external_issue_tracker
      end.to change { project.has_external_issue_tracker}.to(true)
    end

    it 'stores false if there is no external_issue_tracker' do
      services = double(:service, external_issue_trackers: [])
      expect(project).to receive(:services).and_return(services)

      expect do
        project.cache_has_external_issue_tracker
      end.to change { project.has_external_issue_tracker}.to(false)
    end
  end

634
  describe '#has_wiki?' do
635 636 637
    let(:no_wiki_project)       { create(:empty_project, wiki_access_level: ProjectFeature::DISABLED, has_external_wiki: false) }
    let(:wiki_enabled_project)  { create(:empty_project) }
    let(:external_wiki_project) { create(:empty_project, has_external_wiki: true) }
638 639 640 641 642 643 644 645

    it 'returns true if project is wiki enabled or has external wiki' do
      expect(wiki_enabled_project).to have_wiki
      expect(external_wiki_project).to have_wiki
      expect(no_wiki_project).not_to have_wiki
    end
  end

646
  describe '#external_wiki' do
647
    let(:project) { create(:empty_project) }
648

649 650 651 652 653
    context 'with an active external wiki' do
      before do
        create(:service, project: project, type: 'ExternalWikiService', active: true)
        project.external_wiki
      end
654

655 656 657
      it 'sets :has_external_wiki as true' do
        expect(project.has_external_wiki).to be(true)
      end
658

659 660
      it 'sets :has_external_wiki as false if an external wiki service is destroyed later' do
        expect(project.has_external_wiki).to be(true)
661

662 663 664 665
        project.services.external_wikis.first.destroy

        expect(project.has_external_wiki).to be(false)
      end
666 667
    end

668 669 670 671
    context 'with an inactive external wiki' do
      before do
        create(:service, project: project, type: 'ExternalWikiService', active: false)
      end
672

673 674 675
      it 'sets :has_external_wiki as false' do
        expect(project.has_external_wiki).to be(false)
      end
676 677
    end

678 679 680 681
    context 'with no external wiki' do
      before do
        project.external_wiki
      end
682

683 684 685 686 687 688 689 690 691 692 693
      it 'sets :has_external_wiki as false' do
        expect(project.has_external_wiki).to be(false)
      end

      it 'sets :has_external_wiki as true if an external wiki service is created later' do
        expect(project.has_external_wiki).to be(false)

        create(:service, project: project, type: 'ExternalWikiService', active: true)

        expect(project.has_external_wiki).to be(true)
      end
694 695 696
    end
  end

L
Lin Jen-Shin 已提交
697
  describe '#open_branches' do
698
    let(:project) { create(:project, :repository) }
699 700 701 702 703

    before do
      project.protected_branches.create(name: 'master')
    end

704 705
    it { expect(project.open_branches.map(&:name)).to include('feature') }
    it { expect(project.open_branches.map(&:name)).not_to include('master') }
706

707
    it "includes branches matching a protected branch wildcard" do
708 709 710 711
      expect(project.open_branches.map(&:name)).to include('feature')

      create(:protected_branch, name: 'feat*', project: project)

712
      expect(Project.find(project.id).open_branches.map(&:name)).to include('feature')
713
    end
714
  end
C
Ciro Santilli 已提交
715

716 717
  describe '#star_count' do
    it 'counts stars from multiple users' do
C
Ciro Santilli 已提交
718 719
      user1 = create :user
      user2 = create :user
720
      project = create(:empty_project, :public)
C
Ciro Santilli 已提交
721 722

      expect(project.star_count).to eq(0)
723

C
Ciro Santilli 已提交
724
      user1.toggle_star(project)
725 726
      expect(project.reload.star_count).to eq(1)

C
Ciro Santilli 已提交
727
      user2.toggle_star(project)
728 729 730
      project.reload
      expect(project.reload.star_count).to eq(2)

C
Ciro Santilli 已提交
731
      user1.toggle_star(project)
732 733 734
      project.reload
      expect(project.reload.star_count).to eq(1)

C
Ciro Santilli 已提交
735
      user2.toggle_star(project)
736 737 738 739
      project.reload
      expect(project.reload.star_count).to eq(0)
    end

740
    it 'counts stars on the right project' do
741
      user = create :user
742 743
      project1 = create(:empty_project, :public)
      project2 = create(:empty_project, :public)
744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770

      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project1)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(1)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project1)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project2)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(1)

      user.toggle_star(project2)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)
C
Ciro Santilli 已提交
771 772
    end
  end
773

L
Lin Jen-Shin 已提交
774
  describe '#avatar_type' do
775
    let(:project) { create(:empty_project) }
776

777
    it 'is true if avatar is image' do
778
      project.update_attribute(:avatar, 'uploads/avatar.png')
779
      expect(project.avatar_type).to be_truthy
780 781
    end

782
    it 'is false if avatar is html page' do
783
      project.update_attribute(:avatar, 'uploads/avatar.html')
784
      expect(project.avatar_type).to eq(['only images allowed'])
785 786
    end
  end
S
sue445 已提交
787

L
Lin Jen-Shin 已提交
788
  describe '#avatar_url' do
S
sue445 已提交
789 790
    subject { project.avatar_url }

791
    let(:project) { create(:empty_project) }
S
sue445 已提交
792 793 794 795 796 797 798 799 800 801 802

    context 'When avatar file is uploaded' do
      before do
        project.update_columns(avatar: 'uploads/avatar.png')
        allow(project.avatar).to receive(:present?) { true }
      end

      let(:avatar_path) do
        "/uploads/project/avatar/#{project.id}/uploads/avatar.png"
      end

803
      it { should eq "http://#{Gitlab.config.gitlab.host}#{avatar_path}" }
S
sue445 已提交
804 805 806 807 808 809 810 811 812 813 814
    end

    context 'When avatar file in git' do
      before do
        allow(project).to receive(:avatar_in_git) { true }
      end

      let(:avatar_path) do
        "/#{project.namespace.name}/#{project.path}/avatar"
      end

815
      it { should eq "http://#{Gitlab.config.gitlab.host}#{avatar_path}" }
S
sue445 已提交
816
    end
817 818 819 820 821 822

    context 'when git repo is empty' do
      let(:project) { create(:empty_project) }

      it { should eq nil }
    end
S
sue445 已提交
823
  end
824

825
  describe '#pipeline_for' do
826
    let(:project) { create(:project, :repository) }
827
    let!(:pipeline) { create_pipeline }
K
Kamil Trzcinski 已提交
828

829 830
    shared_examples 'giving the correct pipeline' do
      it { is_expected.to eq(pipeline) }
K
Kamil Trzcinski 已提交
831

832 833
      context 'return latest' do
        let!(:pipeline2) { create_pipeline }
K
Kamil Trzcinski 已提交
834

835
        it { is_expected.to eq(pipeline2) }
K
Kamil Trzcinski 已提交
836
      end
837 838 839 840 841 842 843 844 845 846 847 848 849
    end

    context 'with explicit sha' do
      subject { project.pipeline_for('master', pipeline.sha) }

      it_behaves_like 'giving the correct pipeline'
    end

    context 'with implicit sha' do
      subject { project.pipeline_for('master') }

      it_behaves_like 'giving the correct pipeline'
    end
K
Kamil Trzcinski 已提交
850

851 852 853 854 855
    def create_pipeline
      create(:ci_pipeline,
             project: project,
             ref: 'master',
             sha: project.commit('master').sha)
K
Kamil Trzcinski 已提交
856
    end
857
  end
858

L
Lin Jen-Shin 已提交
859
  describe '#builds_enabled' do
860
    let(:project) { create(:empty_project) }
861

862 863 864
    subject { project.builds_enabled }

    it { expect(project.builds_enabled?).to be_truthy }
865
  end
Y
Yorick Peterse 已提交
866

867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886
  describe '.with_shared_runners' do
    subject { Project.with_shared_runners }

    context 'when shared runners are enabled for project' do
      let!(:project) { create(:empty_project, shared_runners_enabled: true) }

      it "returns a project" do
        is_expected.to eq([project])
      end
    end

    context 'when shared runners are disabled for project' do
      let!(:project) { create(:empty_project, shared_runners_enabled: false) }

      it "returns an empty array" do
        is_expected.to be_empty
      end
    end
  end

887 888 889 890 891 892 893 894 895 896 897 898 899 900
  describe '.cached_count', caching: true do
    let(:group)     { create(:group, :public) }
    let!(:project1) { create(:empty_project, :public, group: group) }
    let!(:project2) { create(:empty_project, :public, group: group) }

    it 'returns total project count' do
      expect(Project).to receive(:count).once.and_call_original

      3.times do
        expect(Project.cached_count).to eq(2)
      end
    end
  end

Y
Yorick Peterse 已提交
901
  describe '.trending' do
F
Felipe Artur 已提交
902
    let(:group)    { create(:group, :public) }
Y
Yorick Peterse 已提交
903 904 905 906 907 908 909 910 911 912
    let(:project1) { create(:empty_project, :public, group: group) }
    let(:project2) { create(:empty_project, :public, group: group) }

    before do
      2.times do
        create(:note_on_commit, project: project1)
      end

      create(:note_on_commit, project: project2)

Y
Yorick Peterse 已提交
913
      TrendingProject.refresh!
Y
Yorick Peterse 已提交
914 915
    end

Y
Yorick Peterse 已提交
916
    subject { described_class.trending.to_a }
Y
Yorick Peterse 已提交
917

Y
Yorick Peterse 已提交
918 919
    it 'sorts projects by the amount of notes in descending order' do
      expect(subject).to eq([project1, project2])
Y
Yorick Peterse 已提交
920
    end
921 922 923 924 925 926 927 928

    it 'does not take system notes into account' do
      10.times do
        create(:note_on_commit, project: project2, system: true)
      end

      expect(described_class.trending.to_a).to eq([project1, project2])
    end
Y
Yorick Peterse 已提交
929
  end
Y
Yorick Peterse 已提交
930 931

  describe '.visible_to_user' do
932
    let!(:project) { create(:empty_project, :private) }
Y
Yorick Peterse 已提交
933 934 935 936 937 938
    let!(:user)    { create(:user) }

    subject { described_class.visible_to_user(user) }

    describe 'when a user has access to a project' do
      before do
939
        project.add_user(user, Gitlab::Access::MASTER)
Y
Yorick Peterse 已提交
940 941 942 943 944 945 946 947 948
      end

      it { is_expected.to eq([project]) }
    end

    describe 'when a user does not have access to any projects' do
      it { is_expected.to eq([]) }
    end
  end
K
Kamil Trzcinski 已提交
949

950 951 952 953
  context 'repository storage by default' do
    let(:project) { create(:empty_project) }

    before do
954 955 956 957
      storages = {
        'default' => 'tmp/tests/repositories',
        'picked'  => 'tmp/tests/repositories',
      }
958 959 960
      allow(Gitlab.config.repositories).to receive(:storages).and_return(storages)
    end

961 962 963 964 965
    it 'picks storage from ApplicationSetting' do
      expect_any_instance_of(ApplicationSetting).to receive(:pick_repository_storage).and_return('picked')

      expect(project.repository_storage).to eq('picked')
    end
966 967
  end

K
Kamil Trzcinski 已提交
968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985
  context 'shared runners by default' do
    let(:project) { create(:empty_project) }

    subject { project.shared_runners_enabled }

    context 'are enabled' do
      before { stub_application_setting(shared_runners_enabled: true) }

      it { is_expected.to be_truthy }
    end

    context 'are disabled' do
      before { stub_application_setting(shared_runners_enabled: false) }

      it { is_expected.to be_falsey }
    end
  end

L
Lin Jen-Shin 已提交
986
  describe '#any_runners' do
K
Kamil Trzcinski 已提交
987
    let(:project) { create(:empty_project, shared_runners_enabled: shared_runners_enabled) }
988 989
    let(:specific_runner) { create(:ci_runner) }
    let(:shared_runner) { create(:ci_runner, :shared) }
K
Kamil Trzcinski 已提交
990 991 992

    context 'for shared runners disabled' do
      let(:shared_runners_enabled) { false }
993

994
      it 'has no runners available' do
K
Kamil Trzcinski 已提交
995 996
        expect(project.any_runners?).to be_falsey
      end
997

998
      it 'has a specific runner' do
999
        project.runners << specific_runner
K
Kamil Trzcinski 已提交
1000 1001
        expect(project.any_runners?).to be_truthy
      end
1002

1003
      it 'has a shared runner, but they are prohibited to use' do
K
Kamil Trzcinski 已提交
1004 1005 1006
        shared_runner
        expect(project.any_runners?).to be_falsey
      end
1007

K
Kamil Trzcinski 已提交
1008
      it 'checks the presence of specific runner' do
1009
        project.runners << specific_runner
K
Kamil Trzcinski 已提交
1010 1011 1012
        expect(project.any_runners? { |runner| runner == specific_runner }).to be_truthy
      end
    end
1013

K
Kamil Trzcinski 已提交
1014 1015
    context 'for shared runners enabled' do
      let(:shared_runners_enabled) { true }
1016

1017
      it 'has a shared runner' do
K
Kamil Trzcinski 已提交
1018 1019 1020 1021 1022 1023 1024 1025 1026 1027
        shared_runner
        expect(project.any_runners?).to be_truthy
      end

      it 'checks the presence of shared runner' do
        shared_runner
        expect(project.any_runners? { |runner| runner == shared_runner }).to be_truthy
      end
    end
  end
1028

1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050
  describe '#shared_runners' do
    let!(:runner) { create(:ci_runner, :shared) }

    subject { project.shared_runners }

    context 'when shared runners are enabled for project' do
      let!(:project) { create(:empty_project, shared_runners_enabled: true) }

      it "returns a list of shared runners" do
        is_expected.to eq([runner])
      end
    end

    context 'when shared runners are disabled for project' do
      let!(:project) { create(:empty_project, shared_runners_enabled: false) }

      it "returns a empty list" do
        is_expected.to be_empty
      end
    end
  end

1051
  describe '#visibility_level_allowed?' do
1052
    let(:project) { create(:empty_project, :internal) }
1053 1054 1055 1056 1057 1058 1059 1060

    context 'when checking on non-forked project' do
      it { expect(project.visibility_level_allowed?(Gitlab::VisibilityLevel::PRIVATE)).to be_truthy }
      it { expect(project.visibility_level_allowed?(Gitlab::VisibilityLevel::INTERNAL)).to be_truthy }
      it { expect(project.visibility_level_allowed?(Gitlab::VisibilityLevel::PUBLIC)).to be_truthy }
    end

    context 'when checking on forked project' do
1061 1062
      let(:project)        { create(:empty_project, :internal) }
      let(:forked_project) { create(:empty_project, forked_from_project: project) }
1063 1064 1065 1066 1067

      it { expect(forked_project.visibility_level_allowed?(Gitlab::VisibilityLevel::PRIVATE)).to be_truthy }
      it { expect(forked_project.visibility_level_allowed?(Gitlab::VisibilityLevel::INTERNAL)).to be_truthy }
      it { expect(forked_project.visibility_level_allowed?(Gitlab::VisibilityLevel::PUBLIC)).to be_falsey }
    end
1068
  end
1069

1070
  describe '.search' do
1071
    let(:project) { create(:empty_project, description: 'kitten mittens') }
1072

1073 1074 1075
    it 'returns projects with a matching name' do
      expect(described_class.search(project.name)).to eq([project])
    end
1076

1077 1078 1079
    it 'returns projects with a partially matching name' do
      expect(described_class.search(project.name[0..2])).to eq([project])
    end
1080

1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119
    it 'returns projects with a matching name regardless of the casing' do
      expect(described_class.search(project.name.upcase)).to eq([project])
    end

    it 'returns projects with a matching description' do
      expect(described_class.search(project.description)).to eq([project])
    end

    it 'returns projects with a partially matching description' do
      expect(described_class.search('kitten')).to eq([project])
    end

    it 'returns projects with a matching description regardless of the casing' do
      expect(described_class.search('KITTEN')).to eq([project])
    end

    it 'returns projects with a matching path' do
      expect(described_class.search(project.path)).to eq([project])
    end

    it 'returns projects with a partially matching path' do
      expect(described_class.search(project.path[0..2])).to eq([project])
    end

    it 'returns projects with a matching path regardless of the casing' do
      expect(described_class.search(project.path.upcase)).to eq([project])
    end

    it 'returns projects with a matching namespace name' do
      expect(described_class.search(project.namespace.name)).to eq([project])
    end

    it 'returns projects with a partially matching namespace name' do
      expect(described_class.search(project.namespace.name[0..2])).to eq([project])
    end

    it 'returns projects with a matching namespace name regardless of the casing' do
      expect(described_class.search(project.namespace.name.upcase)).to eq([project])
    end
1120 1121 1122 1123 1124

    it 'returns projects when eager loading namespaces' do
      relation = described_class.all.includes(:namespace)

      expect(relation.search(project.namespace.name)).to eq([project])
1125
    end
1126
  end
1127 1128

  describe '#rename_repo' do
1129
    let(:project) { create(:project, :repository) }
1130 1131 1132 1133 1134 1135 1136 1137
    let(:gitlab_shell) { Gitlab::Shell.new }

    before do
      # Project#gitlab_shell returns a new instance of Gitlab::Shell on every
      # call. This makes testing a bit easier.
      allow(project).to receive(:gitlab_shell).and_return(gitlab_shell)

      allow(project).to receive(:previous_changes).and_return('path' => ['foo'])
K
Kamil Trzcinski 已提交
1138
    end
1139

K
Kamil Trzcinski 已提交
1140
    it 'renames a repository' do
1141 1142 1143 1144
      ns = project.namespace_dir

      expect(gitlab_shell).to receive(:mv_repository).
        ordered.
1145
        with(project.repository_storage_path, "#{ns}/foo", "#{ns}/#{project.path}").
1146 1147 1148 1149
        and_return(true)

      expect(gitlab_shell).to receive(:mv_repository).
        ordered.
1150
        with(project.repository_storage_path, "#{ns}/foo.wiki", "#{ns}/#{project.path}.wiki").
1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164
        and_return(true)

      expect_any_instance_of(SystemHooksService).
        to receive(:execute_hooks_for).
        with(project, :rename)

      expect_any_instance_of(Gitlab::UploadsTransfer).
        to receive(:rename_project).
        with('foo', project.path, ns)

      expect(project).to receive(:expire_caches_before_rename)

      project.rename_repo
    end
K
Kamil Trzcinski 已提交
1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175

    context 'container registry with tags' do
      before do
        stub_container_registry_config(enabled: true)
        stub_container_registry_tags('tag')
      end

      subject { project.rename_repo }

      it { expect{subject}.to raise_error(Exception) }
    end
1176 1177 1178
  end

  describe '#expire_caches_before_rename' do
1179
    let(:project) { create(:project, :repository) }
1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191
    let(:repo)    { double(:repo, exists?: true) }
    let(:wiki)    { double(:wiki, exists?: true) }

    it 'expires the caches of the repository and wiki' do
      allow(Repository).to receive(:new).
        with('foo', project).
        and_return(repo)

      allow(Repository).to receive(:new).
        with('foo.wiki', project).
        and_return(wiki)

1192 1193
      expect(repo).to receive(:before_delete)
      expect(wiki).to receive(:before_delete)
1194 1195 1196 1197

      project.expire_caches_before_rename('foo')
    end
  end
1198 1199

  describe '.search_by_title' do
1200
    let(:project) { create(:empty_project, name: 'kittens') }
1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213

    it 'returns projects with a matching name' do
      expect(described_class.search_by_title(project.name)).to eq([project])
    end

    it 'returns projects with a partially matching name' do
      expect(described_class.search_by_title('kitten')).to eq([project])
    end

    it 'returns projects with a matching name regardless of the casing' do
      expect(described_class.search_by_title('KITTENS')).to eq([project])
    end
  end
1214 1215 1216 1217 1218

  context 'when checking projects from groups' do
    let(:private_group)    { create(:group, visibility_level: 0)  }
    let(:internal_group)   { create(:group, visibility_level: 10) }

1219 1220
    let(:private_project)  { create :empty_project, :private, group: private_group }
    let(:internal_project) { create :empty_project, :internal, group: internal_group }
1221 1222 1223 1224 1225 1226 1227 1228 1229

    context 'when group is private project can not be internal' do
      it { expect(private_project.visibility_level_allowed?(Gitlab::VisibilityLevel::INTERNAL)).to be_falsey }
    end

    context 'when group is internal project can not be public' do
      it { expect(internal_project.visibility_level_allowed?(Gitlab::VisibilityLevel::PUBLIC)).to be_falsey }
    end
  end
1230

1231
  describe '#create_repository' do
1232
    let(:project) { create(:project, :repository) }
1233 1234 1235 1236 1237 1238 1239 1240 1241
    let(:shell) { Gitlab::Shell.new }

    before do
      allow(project).to receive(:gitlab_shell).and_return(shell)
    end

    context 'using a regular repository' do
      it 'creates the repository' do
        expect(shell).to receive(:add_repository).
1242
          with(project.repository_storage_path, project.path_with_namespace).
1243 1244 1245 1246 1247 1248 1249 1250 1251
          and_return(true)

        expect(project.repository).to receive(:after_create)

        expect(project.create_repository).to eq(true)
      end

      it 'adds an error if the repository could not be created' do
        expect(shell).to receive(:add_repository).
1252
          with(project.repository_storage_path, project.path_with_namespace).
1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270
          and_return(false)

        expect(project.repository).not_to receive(:after_create)

        expect(project.create_repository).to eq(false)
        expect(project.errors).not_to be_empty
      end
    end

    context 'using a forked repository' do
      it 'does nothing' do
        expect(project).to receive(:forked?).and_return(true)
        expect(shell).not_to receive(:add_repository)

        project.create_repository
      end
    end
  end
1271 1272

  describe '#protected_branch?' do
1273
    context 'existing project' do
1274
      let(:project) { create(:project, :repository) }
1275 1276

      it 'returns true when the branch matches a protected branch via direct match' do
1277
        create(:protected_branch, project: project, name: "foo")
1278 1279 1280 1281 1282

        expect(project.protected_branch?('foo')).to eq(true)
      end

      it 'returns true when the branch matches a protected branch via wildcard match' do
1283
        create(:protected_branch, project: project, name: "production/*")
1284 1285 1286 1287 1288 1289 1290 1291 1292

        expect(project.protected_branch?('production/some-branch')).to eq(true)
      end

      it 'returns false when the branch does not match a protected branch via direct match' do
        expect(project.protected_branch?('foo')).to eq(false)
      end

      it 'returns false when the branch does not match a protected branch via wildcard match' do
1293
        create(:protected_branch, project: project, name: "production/*")
1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327

        expect(project.protected_branch?('staging/some-branch')).to eq(false)
      end
    end

    context "new project" do
      let(:project) { create(:empty_project) }

      it 'returns false when default_protected_branch is unprotected' do
        stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_NONE)

        expect(project.protected_branch?('master')).to be false
      end

      it 'returns false when default_protected_branch lets developers push' do
        stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_DEV_CAN_PUSH)

        expect(project.protected_branch?('master')).to be false
      end

      it 'returns true when default_branch_protection does not let developers push but let developer merge branches' do
        stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_DEV_CAN_MERGE)

        expect(project.protected_branch?('master')).to be true
      end

      it 'returns true when default_branch_protection is in full protection' do
        stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_FULL)

        expect(project.protected_branch?('master')).to be true
      end
    end
  end

1328
  describe '#user_can_push_to_empty_repo?' do
1329
    let(:project) { create(:empty_project) }
1330
    let(:user)    { create(:user) }
1331

1332 1333 1334
    it 'returns false when default_branch_protection is in full protection and user is developer' do
      project.team << [user, :developer]
      stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_FULL)
1335

1336
      expect(project.user_can_push_to_empty_repo?(user)).to be_falsey
1337 1338
    end

1339 1340 1341
    it 'returns false when default_branch_protection only lets devs merge and user is dev' do
      project.team << [user, :developer]
      stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_DEV_CAN_MERGE)
1342

1343
      expect(project.user_can_push_to_empty_repo?(user)).to be_falsey
1344 1345
    end

1346 1347 1348
    it 'returns true when default_branch_protection lets devs push and user is developer' do
      project.team << [user, :developer]
      stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_DEV_CAN_PUSH)
1349

1350 1351
      expect(project.user_can_push_to_empty_repo?(user)).to be_truthy
    end
1352

1353 1354 1355
    it 'returns true when default_branch_protection is unprotected and user is developer' do
      project.team << [user, :developer]
      stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_NONE)
1356

1357
      expect(project.user_can_push_to_empty_repo?(user)).to be_truthy
1358
    end
1359

1360 1361
    it 'returns true when user is master' do
      project.team << [user, :master]
1362

1363
      expect(project.user_can_push_to_empty_repo?(user)).to be_truthy
1364 1365 1366
    end
  end

1367 1368 1369 1370 1371 1372 1373 1374 1375
  describe '#container_registry_path_with_namespace' do
    let(:project) { create(:empty_project, path: 'PROJECT') }

    subject { project.container_registry_path_with_namespace }

    it { is_expected.not_to eq(project.path_with_namespace) }
    it { is_expected.to eq(project.path_with_namespace.downcase) }
  end

K
Kamil Trzcinski 已提交
1376 1377 1378
  describe '#container_registry_repository' do
    let(:project) { create(:empty_project) }

K
Kamil Trzcinski 已提交
1379 1380
    before { stub_container_registry_config(enabled: true) }

K
Kamil Trzcinski 已提交
1381 1382
    subject { project.container_registry_repository }

1383
    it { is_expected.not_to be_nil }
K
Kamil Trzcinski 已提交
1384 1385 1386 1387 1388 1389 1390
  end

  describe '#container_registry_repository_url' do
    let(:project) { create(:empty_project) }

    subject { project.container_registry_repository_url }

1391
    before { stub_container_registry_config(**registry_settings) }
K
Kamil Trzcinski 已提交
1392 1393 1394 1395 1396 1397 1398 1399 1400

    context 'for enabled registry' do
      let(:registry_settings) do
        {
          enabled: true,
          host_port: 'example.com',
        }
      end

1401
      it { is_expected.not_to be_nil }
K
Kamil Trzcinski 已提交
1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420
    end

    context 'for disabled registry' do
      let(:registry_settings) do
        {
          enabled: false
        }
      end

      it { is_expected.to be_nil }
    end
  end

  describe '#has_container_registry_tags?' do
    let(:project) { create(:empty_project) }

    subject { project.has_container_registry_tags? }

    context 'for enabled registry' do
1421
      before { stub_container_registry_config(enabled: true) }
K
Kamil Trzcinski 已提交
1422 1423

      context 'with tags' do
K
Kamil Trzcinski 已提交
1424
        before { stub_container_registry_tags('test', 'test2') }
K
Kamil Trzcinski 已提交
1425 1426 1427 1428 1429

        it { is_expected.to be_truthy }
      end

      context 'when no tags' do
K
Kamil Trzcinski 已提交
1430
        before { stub_container_registry_tags }
K
Kamil Trzcinski 已提交
1431 1432 1433 1434 1435 1436

        it { is_expected.to be_falsey }
      end
    end

    context 'for disabled registry' do
1437
      before { stub_container_registry_config(enabled: false) }
K
Kamil Trzcinski 已提交
1438 1439 1440 1441

      it { is_expected.to be_falsey }
    end
  end
Y
Yorick Peterse 已提交
1442

1443
  describe '#latest_successful_builds_for' do
L
Lin Jen-Shin 已提交
1444
    def create_pipeline(status = 'success')
1445
      create(:ci_pipeline, project: project,
L
Lin Jen-Shin 已提交
1446
                           sha: project.commit.sha,
1447
                           ref: project.default_branch,
L
Lin Jen-Shin 已提交
1448
                           status: status)
1449 1450
    end

L
Lin Jen-Shin 已提交
1451 1452 1453
    def create_build(new_pipeline = pipeline, name = 'test')
      create(:ci_build, :success, :artifacts,
             pipeline: new_pipeline,
L
Lin Jen-Shin 已提交
1454
             status: new_pipeline.status,
L
Lin Jen-Shin 已提交
1455
             name: name)
1456 1457
    end

1458
    let(:project) { create(:project, :repository) }
L
Lin Jen-Shin 已提交
1459
    let(:pipeline) { create_pipeline }
L
Lin Jen-Shin 已提交
1460 1461

    context 'with many builds' do
1462
      it 'gives the latest builds from latest pipeline' do
1463 1464
        pipeline1 = create_pipeline
        pipeline2 = create_pipeline
1465
        build1_p2 = create_build(pipeline2, 'test')
1466 1467
        create_build(pipeline1, 'test')
        create_build(pipeline1, 'test2')
1468
        build2_p2 = create_build(pipeline2, 'test2')
L
Lin Jen-Shin 已提交
1469 1470 1471

        latest_builds = project.latest_successful_builds_for

1472
        expect(latest_builds).to contain_exactly(build2_p2, build1_p2)
L
Lin Jen-Shin 已提交
1473 1474
      end
    end
L
Lin Jen-Shin 已提交
1475

L
Lin Jen-Shin 已提交
1476
    context 'with succeeded pipeline' do
L
Lin Jen-Shin 已提交
1477
      let!(:build) { create_build }
1478

L
Lin Jen-Shin 已提交
1479
      context 'standalone pipeline' do
1480 1481 1482 1483 1484 1485 1486 1487
        it 'returns builds for ref for default_branch' do
          builds = project.latest_successful_builds_for

          expect(builds).to contain_exactly(build)
        end

        it 'returns empty relation if the build cannot be found' do
          builds = project.latest_successful_builds_for('TAIL')
1488

1489 1490 1491
          expect(builds).to be_kind_of(ActiveRecord::Relation)
          expect(builds).to be_empty
        end
1492 1493
      end

L
Lin Jen-Shin 已提交
1494
      context 'with some pending pipeline' do
1495
        before do
L
Lin Jen-Shin 已提交
1496
          create_build(create_pipeline('pending'))
1497 1498
        end

L
Lin Jen-Shin 已提交
1499 1500
        it 'gives the latest build from latest pipeline' do
          latest_build = project.latest_successful_builds_for
1501

L
Lin Jen-Shin 已提交
1502
          expect(latest_build).to contain_exactly(build)
1503
        end
1504 1505 1506 1507 1508 1509
      end
    end

    context 'with pending pipeline' do
      before do
        pipeline.update(status: 'pending')
L
Lin Jen-Shin 已提交
1510
        create_build(pipeline)
1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521
      end

      it 'returns empty relation' do
        builds = project.latest_successful_builds_for

        expect(builds).to be_kind_of(ActiveRecord::Relation)
        expect(builds).to be_empty
      end
    end
  end

1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537
  describe '#add_import_job' do
    context 'forked' do
      let(:forked_project_link) { create(:forked_project_link) }
      let(:forked_from_project) { forked_project_link.forked_from_project }
      let(:project) { forked_project_link.forked_to_project }

      it 'schedules a RepositoryForkWorker job' do
        expect(RepositoryForkWorker).to receive(:perform_async).
          with(project.id, forked_from_project.repository_storage_path,
              forked_from_project.path_with_namespace, project.namespace.path)

        project.add_import_job
      end
    end

    context 'not forked' do
1538
      let(:project) { create(:empty_project) }
1539 1540 1541 1542 1543 1544 1545 1546 1547

      it 'schedules a RepositoryImportWorker job' do
        expect(RepositoryImportWorker).to receive(:perform_async).with(project.id)

        project.add_import_job
      end
    end
  end

R
Rémy Coutable 已提交
1548
  describe '#gitlab_project_import?' do
1549
    subject(:project) { build(:empty_project, import_type: 'gitlab_project') }
R
Rémy Coutable 已提交
1550 1551 1552 1553 1554

    it { expect(project.gitlab_project_import?).to be true }
  end

  describe '#gitea_import?' do
1555
    subject(:project) { build(:empty_project, import_type: 'gitea') }
R
Rémy Coutable 已提交
1556 1557 1558 1559

    it { expect(project.gitea_import?).to be true }
  end

1560
  describe '#lfs_enabled?' do
1561
    let(:project) { create(:empty_project) }
1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621

    shared_examples 'project overrides group' do
      it 'returns true when enabled in project' do
        project.update_attribute(:lfs_enabled, true)

        expect(project.lfs_enabled?).to be_truthy
      end

      it 'returns false when disabled in project' do
        project.update_attribute(:lfs_enabled, false)

        expect(project.lfs_enabled?).to be_falsey
      end

      it 'returns the value from the namespace, when no value is set in project' do
        expect(project.lfs_enabled?).to eq(project.namespace.lfs_enabled?)
      end
    end

    context 'LFS disabled in group' do
      before do
        project.namespace.update_attribute(:lfs_enabled, false)
        enable_lfs
      end

      it_behaves_like 'project overrides group'
    end

    context 'LFS enabled in group' do
      before do
        project.namespace.update_attribute(:lfs_enabled, true)
        enable_lfs
      end

      it_behaves_like 'project overrides group'
    end

    describe 'LFS disabled globally' do
      shared_examples 'it always returns false' do
        it do
          expect(project.lfs_enabled?).to be_falsey
          expect(project.namespace.lfs_enabled?).to be_falsey
        end
      end

      context 'when no values are set' do
        it_behaves_like 'it always returns false'
      end

      context 'when all values are set to true' do
        before do
          project.namespace.update_attribute(:lfs_enabled, true)
          project.update_attribute(:lfs_enabled, true)
        end

        it_behaves_like 'it always returns false'
      end
    end
  end

1622
  describe '#change_head' do
1623
    let(:project) { create(:project, :repository) }
1624

1625
    it 'calls the before_change_head and after_change_head methods' do
1626
      expect(project.repository).to receive(:before_change_head)
1627 1628
      expect(project.repository).to receive(:after_change_head)

1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648
      project.change_head(project.default_branch)
    end

    it 'creates the new reference with rugged' do
      expect(project.repository.rugged.references).to receive(:create).with('HEAD',
                                                                            "refs/heads/#{project.default_branch}",
                                                                            force: true)
      project.change_head(project.default_branch)
    end

    it 'copies the gitattributes' do
      expect(project.repository).to receive(:copy_gitattributes).with(project.default_branch)
      project.change_head(project.default_branch)
    end

    it 'reloads the default branch' do
      expect(project).to receive(:reload_default_branch)
      project.change_head(project.default_branch)
    end
  end
Y
Yorick Peterse 已提交
1649 1650

  describe '#pushes_since_gc' do
1651
    let(:project) { create(:empty_project) }
Y
Yorick Peterse 已提交
1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672

    after do
      project.reset_pushes_since_gc
    end

    context 'without any pushes' do
      it 'returns 0' do
        expect(project.pushes_since_gc).to eq(0)
      end
    end

    context 'with a number of pushes' do
      it 'returns the number of pushes' do
        3.times { project.increment_pushes_since_gc }

        expect(project.pushes_since_gc).to eq(3)
      end
    end
  end

  describe '#increment_pushes_since_gc' do
1673
    let(:project) { create(:empty_project) }
Y
Yorick Peterse 已提交
1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686

    after do
      project.reset_pushes_since_gc
    end

    it 'increments the number of pushes since the last GC' do
      3.times { project.increment_pushes_since_gc }

      expect(project.pushes_since_gc).to eq(3)
    end
  end

  describe '#reset_pushes_since_gc' do
1687
    let(:project) { create(:empty_project) }
Y
Yorick Peterse 已提交
1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700

    after do
      project.reset_pushes_since_gc
    end

    it 'resets the number of pushes since the last GC' do
      3.times { project.increment_pushes_since_gc }

      project.reset_pushes_since_gc

      expect(project.pushes_since_gc).to eq(0)
    end
  end
1701

1702
  describe '#environments_for' do
1703
    let(:project) { create(:project, :repository) }
1704 1705 1706 1707 1708 1709 1710 1711
    let(:environment) { create(:environment, project: project) }

    context 'tagged deployment' do
      before do
        create(:deployment, environment: environment, ref: '1.0', tag: true, sha: project.commit.id)
      end

      it 'returns environment when with_tags is set' do
1712 1713
        expect(project.environments_for('master', commit: project.commit, with_tags: true))
          .to contain_exactly(environment)
1714 1715 1716
      end

      it 'does not return environment when no with_tags is set' do
1717 1718
        expect(project.environments_for('master', commit: project.commit))
          .to be_empty
1719 1720 1721
      end

      it 'does not return environment when commit is not part of deployment' do
1722 1723
        expect(project.environments_for('master', commit: project.commit('feature')))
          .to be_empty
1724 1725 1726 1727 1728 1729 1730 1731 1732
      end
    end

    context 'branch deployment' do
      before do
        create(:deployment, environment: environment, ref: 'master', sha: project.commit.id)
      end

      it 'returns environment when ref is set' do
1733 1734
        expect(project.environments_for('master', commit: project.commit))
          .to contain_exactly(environment)
1735 1736 1737
      end

      it 'does not environment when ref is different' do
1738 1739
        expect(project.environments_for('feature', commit: project.commit))
          .to be_empty
1740 1741 1742
      end

      it 'does not return environment when commit is not part of deployment' do
1743 1744 1745 1746 1747 1748 1749
        expect(project.environments_for('master', commit: project.commit('feature')))
          .to be_empty
      end

      it 'returns environment when commit constraint is not set' do
        expect(project.environments_for('master'))
          .to contain_exactly(environment)
1750 1751 1752 1753
      end
    end
  end

1754
  describe '#environments_recently_updated_on_branch' do
1755
    let(:project) { create(:project, :repository) }
1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791
    let(:environment) { create(:environment, project: project) }

    context 'when last deployment to environment is the most recent one' do
      before do
        create(:deployment, environment: environment, ref: 'feature')
      end

      it 'finds recently updated environment' do
        expect(project.environments_recently_updated_on_branch('feature'))
          .to contain_exactly(environment)
      end
    end

    context 'when last deployment to environment is not the most recent' do
      before do
        create(:deployment, environment: environment, ref: 'feature')
        create(:deployment, environment: environment, ref: 'master')
      end

      it 'does not find environment' do
        expect(project.environments_recently_updated_on_branch('feature'))
          .to be_empty
      end
    end

    context 'when there are two environments that deploy to the same branch' do
      let(:second_environment) { create(:environment, project: project) }

      before do
        create(:deployment, environment: environment, ref: 'feature')
        create(:deployment, environment: second_environment, ref: 'feature')
      end

      it 'finds both environments' do
        expect(project.environments_recently_updated_on_branch('feature'))
          .to contain_exactly(environment, second_environment)
1792 1793 1794 1795
      end
    end
  end

1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815
  describe '#deployment_variables' do
    context 'when project has no deployment service' do
      let(:project) { create(:empty_project) }

      it 'returns an empty array' do
        expect(project.deployment_variables).to eq []
      end
    end

    context 'when project has a deployment service' do
      let(:project) { create(:kubernetes_project) }

      it 'returns variables from this service' do
        expect(project.deployment_variables).to include(
          { key: 'KUBE_TOKEN', value: project.kubernetes_service.token, public: false }
        )
      end
    end
  end

M
Markus Koller 已提交
1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835
  describe '#update_project_statistics' do
    let(:project) { create(:empty_project) }

    it "is called after creation" do
      expect(project.statistics).to be_a ProjectStatistics
      expect(project.statistics).to be_persisted
    end

    it "copies the namespace_id" do
      expect(project.statistics.namespace_id).to eq project.namespace_id
    end

    it "updates the namespace_id when changed" do
      namespace = create(:namespace)
      project.update(namespace: namespace)

      expect(project.statistics.namespace_id).to eq namespace.id
    end
  end

1836 1837 1838 1839 1840 1841 1842 1843
  describe 'inside_path' do
    let!(:project1) { create(:empty_project) }
    let!(:project2) { create(:empty_project) }
    let!(:path) { project1.namespace.path }

    it { expect(Project.inside_path(path)).to eq([project1]) }
  end

1844 1845 1846
  def enable_lfs
    allow(Gitlab.config.lfs).to receive(:enabled).and_return(true)
  end
G
gitlabhq 已提交
1847
end