project_spec.rb 83.3 KB
Newer Older
G
gitlabhq 已提交
1 2
require 'spec_helper'

3
describe Project do
4
  describe 'associations' do
5 6 7 8
    it { is_expected.to belong_to(:group) }
    it { is_expected.to belong_to(:namespace) }
    it { is_expected.to belong_to(:creator).class_name('User') }
    it { is_expected.to have_many(:users) }
U
ubudzisz 已提交
9
    it { is_expected.to have_many(:services) }
10 11 12 13 14
    it { is_expected.to have_many(:events) }
    it { is_expected.to have_many(:merge_requests) }
    it { is_expected.to have_many(:issues) }
    it { is_expected.to have_many(:milestones) }
    it { is_expected.to have_many(:project_members).dependent(:delete_all) }
15
    it { is_expected.to have_many(:users).through(:project_members) }
16 17 18 19
    it { is_expected.to have_many(:requesters).dependent(:delete_all) }
    it { is_expected.to have_many(:notes) }
    it { is_expected.to have_many(:snippets).class_name('ProjectSnippet') }
    it { is_expected.to have_many(:deploy_keys_projects) }
20
    it { is_expected.to have_many(:deploy_keys) }
21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53
    it { is_expected.to have_many(:hooks) }
    it { is_expected.to have_many(:protected_branches) }
    it { is_expected.to have_one(:forked_project_link) }
    it { is_expected.to have_one(:slack_service) }
    it { is_expected.to have_one(:microsoft_teams_service) }
    it { is_expected.to have_one(:mattermost_service) }
    it { is_expected.to have_one(:pushover_service) }
    it { is_expected.to have_one(:asana_service) }
    it { is_expected.to have_many(:boards) }
    it { is_expected.to have_one(:campfire_service) }
    it { is_expected.to have_one(:drone_ci_service) }
    it { is_expected.to have_one(:emails_on_push_service) }
    it { is_expected.to have_one(:pipelines_email_service) }
    it { is_expected.to have_one(:irker_service) }
    it { is_expected.to have_one(:pivotaltracker_service) }
    it { is_expected.to have_one(:hipchat_service) }
    it { is_expected.to have_one(:flowdock_service) }
    it { is_expected.to have_one(:assembla_service) }
    it { is_expected.to have_one(:slack_slash_commands_service) }
    it { is_expected.to have_one(:mattermost_slash_commands_service) }
    it { is_expected.to have_one(:gemnasium_service) }
    it { is_expected.to have_one(:buildkite_service) }
    it { is_expected.to have_one(:bamboo_service) }
    it { is_expected.to have_one(:teamcity_service) }
    it { is_expected.to have_one(:jira_service) }
    it { is_expected.to have_one(:redmine_service) }
    it { is_expected.to have_one(:custom_issue_tracker_service) }
    it { is_expected.to have_one(:bugzilla_service) }
    it { is_expected.to have_one(:gitlab_issue_tracker_service) }
    it { is_expected.to have_one(:external_wiki_service) }
    it { is_expected.to have_one(:project_feature) }
    it { is_expected.to have_one(:statistics).class_name('ProjectStatistics') }
    it { is_expected.to have_one(:import_data).class_name('ProjectImportData') }
U
ubudzisz 已提交
54 55
    it { is_expected.to have_one(:last_event).class_name('Event') }
    it { is_expected.to have_one(:forked_from_project).through(:forked_project_link) }
Z
Zeger-Jan van de Weg 已提交
56
    it { is_expected.to have_one(:auto_devops).class_name('ProjectAutoDevops') }
K
Kamil Trzcinski 已提交
57
    it { is_expected.to have_many(:commit_statuses) }
58
    it { is_expected.to have_many(:pipelines) }
59 60 61
    it { is_expected.to have_many(:builds) }
    it { is_expected.to have_many(:runner_projects) }
    it { is_expected.to have_many(:runners) }
K
Kamil Trzcinski 已提交
62
    it { is_expected.to have_many(:active_runners) }
63 64
    it { is_expected.to have_many(:variables) }
    it { is_expected.to have_many(:triggers) }
K
Kamil Trzcinski 已提交
65
    it { is_expected.to have_many(:pages_domains) }
66 67 68 69 70 71 72 73 74
    it { is_expected.to have_many(:labels).class_name('ProjectLabel') }
    it { is_expected.to have_many(:users_star_projects) }
    it { is_expected.to have_many(:environments) }
    it { is_expected.to have_many(:deployments) }
    it { is_expected.to have_many(:todos) }
    it { is_expected.to have_many(:releases) }
    it { is_expected.to have_many(:lfs_objects_projects) }
    it { is_expected.to have_many(:project_group_links) }
    it { is_expected.to have_many(:notification_settings).dependent(:delete_all) }
U
ubudzisz 已提交
75
    it { is_expected.to have_many(:forks).through(:forked_project_links) }
76
    it { is_expected.to have_many(:uploads).dependent(:destroy) }
77
    it { is_expected.to have_many(:pipeline_schedules) }
78
    it { is_expected.to have_many(:members_and_requesters) }
79

F
Felipe Artur 已提交
80 81
    context 'after initialized' do
      it "has a project_feature" do
82
        expect(described_class.new.project_feature).to be_present
83 84 85
      end
    end

86
    describe '#members & #requesters' do
87
      let(:project) { create(:project, :public, :access_requestable) }
88 89 90 91 92 93 94
      let(:requester) { create(:user) }
      let(:developer) { create(:user) }
      before do
        project.request_access(requester)
        project.team << [developer, :developer]
      end

95 96
      it_behaves_like 'members and requesters associations' do
        let(:namespace) { project }
97 98
      end
    end
99 100 101 102 103

    describe '#boards' do
      it 'raises an error when attempting to add more than one board to the project' do
        subject.boards.build

104
        expect { subject.boards.build }.to raise_error(Project::BoardLimitExceeded, 'Number of permitted boards exceeded')
105 106 107
        expect(subject.boards.size).to eq 1
      end
    end
G
gitlabhq 已提交
108 109
  end

110 111 112 113 114 115
  describe 'modules' do
    subject { described_class }

    it { is_expected.to include_module(Gitlab::ConfigHelper) }
    it { is_expected.to include_module(Gitlab::ShellAdapter) }
    it { is_expected.to include_module(Gitlab::VisibilityLevel) }
116
    it { is_expected.to include_module(Gitlab::CurrentSettings) }
117 118
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
119 120
  end

121
  describe 'validation' do
122
    let!(:project) { create(:project) }
123

124 125
    it { is_expected.to validate_presence_of(:name) }
    it { is_expected.to validate_uniqueness_of(:name).scoped_to(:namespace_id) }
126
    it { is_expected.to validate_length_of(:name).is_at_most(255) }
127

128 129
    it { is_expected.to validate_presence_of(:path) }
    it { is_expected.to validate_uniqueness_of(:path).scoped_to(:namespace_id) }
130 131 132 133
    it { is_expected.to validate_length_of(:path).is_at_most(255) }

    it { is_expected.to validate_length_of(:description).is_at_most(2000) }

134 135 136
    it { is_expected.to validate_length_of(:ci_config_path).is_at_most(255) }
    it { is_expected.to allow_value('').for(:ci_config_path) }
    it { is_expected.not_to allow_value('test/../foo').for(:ci_config_path) }
137

138
    it { is_expected.to validate_presence_of(:creator) }
139

140
    it { is_expected.to validate_presence_of(:namespace) }
141

142
    it { is_expected.to validate_presence_of(:repository_storage) }
143

144
    it 'does not allow new projects beyond user limits' do
145
      project2 = build(:project)
146 147
      allow(project2).to receive(:creator).and_return(double(can_create_project?: false, projects_limit: 0).as_null_object)
      expect(project2).not_to be_valid
P
Phil Hughes 已提交
148
      expect(project2.errors[:limit_reached].first).to match(/Personal project creation is not allowed/)
149
    end
150 151 152

    describe 'wiki path conflict' do
      context "when the new path has been used by the wiki of other Project" do
153
        it 'has an error on the name attribute' do
154
          new_project = build_stubbed(:project, namespace_id: project.namespace_id, path: "#{project.path}.wiki")
155 156 157 158 159 160 161

          expect(new_project).not_to be_valid
          expect(new_project.errors[:name].first).to eq('has already been taken')
        end
      end

      context "when the new wiki path has been used by the path of other Project" do
162
        it 'has an error on the name attribute' do
163 164
          project_with_wiki_suffix = create(:project, path: 'foo.wiki')
          new_project = build_stubbed(:project, namespace_id: project_with_wiki_suffix.namespace_id, path: 'foo')
165 166 167 168 169 170

          expect(new_project).not_to be_valid
          expect(new_project.errors[:name].first).to eq('has already been taken')
        end
      end
    end
171

172
    context 'repository storages inclusion' do
173
      let(:project2) { build(:project, repository_storage: 'missing') }
174 175

      before do
176
        storages = { 'custom' => { 'path' => 'tmp/tests/custom_repositories' } }
177 178 179
        allow(Gitlab.config.repositories).to receive(:storages).and_return(storages)
      end

180
      it "does not allow repository storages that don't match a label in the configuration" do
181 182 183 184
        expect(project2).not_to be_valid
        expect(project2.errors[:repository_storage].first).to match(/is not included in the list/)
      end
    end
185

186
    it 'does not allow an invalid URI as import_url' do
187
      project2 = build(:project, import_url: 'invalid://')
J
James Lopez 已提交
188 189 190 191

      expect(project2).not_to be_valid
    end

192
    it 'does allow a valid URI as import_url' do
193
      project2 = build(:project, import_url: 'ssh://test@gitlab.com/project.git')
J
James Lopez 已提交
194

195 196
      expect(project2).to be_valid
    end
197

198
    it 'allows an empty URI' do
199
      project2 = build(:project, import_url: '')
200

201
      expect(project2).to be_valid
202 203 204
    end

    it 'does not produce import data on an empty URI' do
205
      project2 = build(:project, import_url: '')
206 207 208 209 210

      expect(project2.import_data).to be_nil
    end

    it 'does not produce import data on an invalid URI' do
211
      project2 = build(:project, import_url: 'test://')
212 213 214

      expect(project2.import_data).to be_nil
    end
215

D
Douwe Maan 已提交
216
    it "does not allow blocked import_url localhost" do
217
      project2 = build(:project, import_url: 'http://localhost:9000/t.git')
D
Douwe Maan 已提交
218 219 220 221 222 223

      expect(project2).to be_invalid
      expect(project2.errors[:import_url]).to include('imports are not allowed from that URL')
    end

    it "does not allow blocked import_url port" do
224
      project2 = build(:project, import_url: 'http://github.com:25/t.git')
D
Douwe Maan 已提交
225 226 227 228 229

      expect(project2).to be_invalid
      expect(project2.errors[:import_url]).to include('imports are not allowed from that URL')
    end

230 231
    describe 'project pending deletion' do
      let!(:project_pending_deletion) do
232
        create(:project,
233 234 235
               pending_delete: true)
      end
      let(:new_project) do
236
        build(:project,
237 238 239 240 241 242 243 244 245 246 247 248
              name: project_pending_deletion.name,
              namespace: project_pending_deletion.namespace)
      end

      before do
        new_project.validate
      end

      it 'contains errors related to the project being deleted' do
        expect(new_project.errors.full_messages.first).to eq('The project is still being deleted. Please try again later.')
      end
    end
249 250 251

    describe 'path validation' do
      it 'allows paths reserved on the root namespace' do
252
        project = build(:project, path: 'api')
253 254 255 256 257

        expect(project).to be_valid
      end

      it 'rejects paths reserved on another level' do
258
        project = build(:project, path: 'tree')
259 260 261

        expect(project).not_to be_valid
      end
262 263 264

      it 'rejects nested paths' do
        parent = create(:group, :nested, path: 'environments')
265
        project = build(:project, path: 'folders', namespace: parent)
266 267 268

        expect(project).not_to be_valid
      end
269 270 271

      it 'allows a reserved group name' do
        parent = create(:group)
272
        project = build(:project, path: 'avatar', namespace: parent)
273 274 275

        expect(project).to be_valid
      end
276
    end
G
gitlabhq 已提交
277
  end
278

K
Kamil Trzcinski 已提交
279
  describe 'project token' do
280
    it 'sets an random token if none provided' do
281
      project = FactoryGirl.create :project, runners_token: ''
K
Kamil Trzcinski 已提交
282
      expect(project.runners_token).not_to eq('')
K
Kamil Trzcinski 已提交
283 284
    end

U
ubudzisz 已提交
285
    it 'does not set an random token if one provided' do
286
      project = FactoryGirl.create :project, runners_token: 'my-token'
K
Kamil Trzcinski 已提交
287
      expect(project.runners_token).to eq('my-token')
K
Kamil Trzcinski 已提交
288 289
    end
  end
G
gitlabhq 已提交
290

291
  describe 'Respond to' do
292 293 294 295 296
    it { is_expected.to respond_to(:url_to_repo) }
    it { is_expected.to respond_to(:repo_exists?) }
    it { is_expected.to respond_to(:execute_hooks) }
    it { is_expected.to respond_to(:owner) }
    it { is_expected.to respond_to(:path_with_namespace) }
297
    it { is_expected.to respond_to(:full_path) }
G
gitlabhq 已提交
298 299
  end

300
  describe 'delegation' do
301 302 303 304 305 306 307 308
    [:add_guest, :add_reporter, :add_developer, :add_master, :add_user, :add_users].each do |method|
      it { is_expected.to delegate_method(method).to(:team) }
    end

    it { is_expected.to delegate_method(:empty_repo?).to(:repository) }
    it { is_expected.to delegate_method(:members).to(:team).with_prefix(true) }
    it { is_expected.to delegate_method(:count).to(:forks).with_prefix(true) }
    it { is_expected.to delegate_method(:name).to(:owner).with_prefix(true).with_arguments(allow_nil: true) }
309 310
  end

311
  describe '#to_reference' do
312
    let(:owner)     { create(:user, name: 'Gitlab') }
313
    let(:namespace) { create(:namespace, path: 'sample-namespace', owner: owner) }
314
    let(:project)   { create(:project, path: 'sample-project', namespace: namespace) }
315
    let(:group)     { create(:group, name: 'Group', path: 'sample-group', owner: owner) }
316

317
    context 'when nil argument' do
318 319 320 321 322
      it 'returns nil' do
        expect(project.to_reference).to be_nil
      end
    end

323
    context 'when full is true' do
324
      it 'returns complete path to the project' do
325 326 327
        expect(project.to_reference(full: true)).to          eq 'sample-namespace/sample-project'
        expect(project.to_reference(project, full: true)).to eq 'sample-namespace/sample-project'
        expect(project.to_reference(group, full: true)).to   eq 'sample-namespace/sample-project'
328 329 330 331 332 333 334 335 336 337
      end
    end

    context 'when same project argument' do
      it 'returns nil' do
        expect(project.to_reference(project)).to be_nil
      end
    end

    context 'when cross namespace project argument' do
338
      let(:another_namespace_project) { create(:project, name: 'another-project') }
339 340 341 342 343 344 345

      it 'returns complete path to the project' do
        expect(project.to_reference(another_namespace_project)).to eq 'sample-namespace/sample-project'
      end
    end

    context 'when same namespace / cross-project argument' do
346
      let(:another_project) { create(:project, namespace: namespace) }
347

348
      it 'returns path to the project' do
349 350 351
        expect(project.to_reference(another_project)).to eq 'sample-project'
      end
    end
352

353 354
    context 'when different namespace / cross-project argument' do
      let(:another_namespace) { create(:namespace, path: 'another-namespace', owner: owner) }
355
      let(:another_project)   { create(:project, path: 'another-project', namespace: another_namespace) }
356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372

      it 'returns full path to the project' do
        expect(project.to_reference(another_project)).to eq 'sample-namespace/sample-project'
      end
    end

    context 'when argument is a namespace' do
      context 'with same project path' do
        it 'returns path to the project' do
          expect(project.to_reference(namespace)).to eq 'sample-project'
        end
      end

      context 'with different project path' do
        it 'returns full path to the project' do
          expect(project.to_reference(group)).to eq 'sample-namespace/sample-project'
        end
373 374
      end
    end
375 376 377 378 379
  end

  describe '#to_human_reference' do
    let(:owner) { create(:user, name: 'Gitlab') }
    let(:namespace) { create(:namespace, name: 'Sample namespace', owner: owner) }
380
    let(:project) { create(:project, name: 'Sample project', namespace: namespace) }
381 382 383 384 385 386 387 388 389 390 391 392 393 394

    context 'when nil argument' do
      it 'returns nil' do
        expect(project.to_human_reference).to be_nil
      end
    end

    context 'when same project argument' do
      it 'returns nil' do
        expect(project.to_human_reference(project)).to be_nil
      end
    end

    context 'when cross namespace project argument' do
395
      let(:another_namespace_project) { create(:project, name: 'another-project') }
396 397 398 399 400 401 402

      it 'returns complete name with namespace of the project' do
        expect(project.to_human_reference(another_namespace_project)).to eq 'Gitlab / Sample project'
      end
    end

    context 'when same namespace / cross-project argument' do
403
      let(:another_project) { create(:project, namespace: namespace) }
404 405 406 407

      it 'returns name of the project' do
        expect(project.to_human_reference(another_project)).to eq 'Sample project'
      end
408 409 410
    end
  end

411
  describe '#repository_storage_path' do
412
    let(:project) { create(:project, repository_storage: 'custom') }
413 414 415

    before do
      FileUtils.mkdir('tmp/tests/custom_repositories')
416
      storages = { 'custom' => { 'path' => 'tmp/tests/custom_repositories' } }
417 418 419 420 421 422 423 424 425 426 427 428
      allow(Gitlab.config.repositories).to receive(:storages).and_return(storages)
    end

    after do
      FileUtils.rm_rf('tmp/tests/custom_repositories')
    end

    it 'returns the repository storage path' do
      expect(project.repository_storage_path).to eq('tmp/tests/custom_repositories')
    end
  end

429
  it 'returns valid url to repo' do
430
    project = described_class.new(path: 'somewhere')
431
    expect(project.url_to_repo).to eq(Gitlab.config.gitlab_shell.ssh_path_prefix + 'somewhere.git')
G
gitlabhq 已提交
432 433
  end

D
Douwe Maan 已提交
434
  describe "#web_url" do
435
    let(:project) { create(:project, path: "somewhere") }
D
Douwe Maan 已提交
436 437

    it 'returns the full web URL for this repo' do
438
      expect(project.web_url).to eq("#{Gitlab.config.gitlab.url}/#{project.namespace.full_path}/somewhere")
D
Douwe Maan 已提交
439
    end
A
Ariejan de Vroom 已提交
440 441
  end

442
  describe "#new_issue_address" do
443
    let(:project) { create(:project, path: "somewhere") }
444 445
    let(:user) { create(:user) }

446 447 448 449 450 451
    context 'incoming email enabled' do
      before do
        stub_incoming_email_setting(enabled: true, address: "p+%{key}@gl.ab")
      end

      it 'returns the address to create a new issue' do
452
        address = "p+#{project.full_path}+#{user.incoming_email_token}@gl.ab"
453 454 455 456 457 458 459 460 461

        expect(project.new_issue_address(user)).to eq(address)
      end
    end

    context 'incoming email disabled' do
      before do
        stub_incoming_email_setting(enabled: false)
      end
462

463 464 465
      it 'returns nil' do
        expect(project.new_issue_address(user)).to be_nil
      end
466 467 468
    end
  end

469
  describe 'last_activity methods' do
S
Stan Hu 已提交
470 471
    let(:timestamp) { 2.hours.ago }
    # last_activity_at gets set to created_at upon creation
472
    let(:project) { create(:project, created_at: timestamp, updated_at: timestamp) }
G
gitlabhq 已提交
473

474
    describe 'last_activity' do
475
      it 'alias last_activity to last_event' do
476
        last_event = create(:event, :closed, project: project)
477

478
        expect(project.last_activity).to eq(last_event)
479
      end
G
gitlabhq 已提交
480 481
    end

482 483
    describe 'last_activity_date' do
      it 'returns the creation date of the project\'s last event if present' do
484
        new_event = create(:event, :closed, project: project, created_at: Time.now)
485

S
Stan Hu 已提交
486
        project.reload
487
        expect(project.last_activity_at.to_i).to eq(new_event.created_at.to_i)
488
      end
489

490
      it 'returns the project\'s last update date if it has no events' do
491
        expect(project.last_activity_date).to eq(project.updated_at)
492
      end
493 494
    end
  end
495

496
  describe '#get_issue' do
497
    let(:project) { create(:project) }
S
Stan Hu 已提交
498
    let!(:issue)  { create(:issue, project: project) }
499 500 501 502 503
    let(:user)    { create(:user) }

    before do
      project.team << [user, :developer]
    end
504 505 506

    context 'with default issues tracker' do
      it 'returns an issue' do
507
        expect(project.get_issue(issue.iid, user)).to eq issue
508 509
      end

S
Stan Hu 已提交
510 511 512 513
      it 'returns count of open issues' do
        expect(project.open_issues_count).to eq(1)
      end

514
      it 'returns nil when no issue found' do
515 516 517 518 519 520
        expect(project.get_issue(999, user)).to be_nil
      end

      it "returns nil when user doesn't have access" do
        user = create(:user)
        expect(project.get_issue(issue.iid, user)).to eq nil
521 522 523 524
      end
    end

    context 'with external issues tracker' do
525
      let!(:internal_issue) { create(:issue, project: project) }
526
      before do
527
        allow(project).to receive(:external_issue_tracker).and_return(true)
528 529
      end

530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566
      context 'when internal issues are enabled' do
        it 'returns interlan issue' do
          issue = project.get_issue(internal_issue.iid, user)

          expect(issue).to be_kind_of(Issue)
          expect(issue.iid).to eq(internal_issue.iid)
          expect(issue.project).to eq(project)
        end

        it 'returns an ExternalIssue when internal issue does not exists' do
          issue = project.get_issue('FOO-1234', user)

          expect(issue).to be_kind_of(ExternalIssue)
          expect(issue.iid).to eq('FOO-1234')
          expect(issue.project).to eq(project)
        end
      end

      context 'when internal issues are disabled' do
        before do
          project.issues_enabled = false
          project.save!
        end

        it 'returns always an External issues' do
          issue = project.get_issue(internal_issue.iid, user)
          expect(issue).to be_kind_of(ExternalIssue)
          expect(issue.iid).to eq(internal_issue.iid.to_s)
          expect(issue.project).to eq(project)
        end

        it 'returns an ExternalIssue when internal issue does not exists' do
          issue = project.get_issue('FOO-1234', user)
          expect(issue).to be_kind_of(ExternalIssue)
          expect(issue.iid).to eq('FOO-1234')
          expect(issue.project).to eq(project)
        end
567 568 569 570 571
      end
    end
  end

  describe '#issue_exists?' do
572
    let(:project) { create(:project) }
573 574 575 576 577 578 579 580 581 582 583 584

    it 'is truthy when issue exists' do
      expect(project).to receive(:get_issue).and_return(double)
      expect(project.issue_exists?(1)).to be_truthy
    end

    it 'is falsey when issue does not exist' do
      expect(project).to receive(:get_issue).and_return(nil)
      expect(project.issue_exists?(1)).to be_falsey
    end
  end

L
Lin Jen-Shin 已提交
585
  describe '#to_param' do
586 587 588
    context 'with namespace' do
      before do
        @group = create :group, name: 'gitlab'
589
        @project = create(:project, name: 'gitlabhq', namespace: @group)
590 591
      end

V
Vinnie Okada 已提交
592
      it { expect(@project.to_param).to eq('gitlabhq') }
593
    end
594 595 596

    context 'with invalid path' do
      it 'returns previous path to keep project suitable for use in URLs when persisted' do
597
        project = create(:project, path: 'gitlab')
598 599 600 601 602 603 604
        project.path = 'foo&bar'

        expect(project).not_to be_valid
        expect(project.to_param).to eq 'gitlab'
      end

      it 'returns current path when new record' do
605
        project = build(:project, path: 'gitlab')
606 607 608 609 610 611
        project.path = 'foo&bar'

        expect(project).not_to be_valid
        expect(project.to_param).to eq 'foo&bar'
      end
    end
612
  end
D
Dmitriy Zaporozhets 已提交
613

L
Lin Jen-Shin 已提交
614
  describe '#repository' do
615
    let(:project) { create(:project, :repository) }
D
Dmitriy Zaporozhets 已提交
616

617
    it 'returns valid repo' do
618
      expect(project.repository).to be_kind_of(Repository)
D
Dmitriy Zaporozhets 已提交
619 620
    end
  end
621

L
Lin Jen-Shin 已提交
622
  describe '#default_issues_tracker?' do
623
    it "is true if used internal tracker" do
624
      project = build(:project)
625

626
      expect(project.default_issues_tracker?).to be_truthy
627 628
    end

629
    it "is false if used other tracker" do
630 631 632 633
      # NOTE: The current nature of this factory requires persistence
      project = create(:redmine_project)

      expect(project.default_issues_tracker?).to be_falsey
634 635 636
    end
  end

L
Lin Jen-Shin 已提交
637
  describe '#external_issue_tracker' do
638
    let(:project) { create(:project) }
639 640 641
    let(:ext_project) { create(:redmine_project) }

    context 'on existing projects with no value for has_external_issue_tracker' do
642
      before do
643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671
        project.update_column(:has_external_issue_tracker, nil)
        ext_project.update_column(:has_external_issue_tracker, nil)
      end

      it 'updates the has_external_issue_tracker boolean' do
        expect do
          project.external_issue_tracker
        end.to change { project.reload.has_external_issue_tracker }.to(false)

        expect do
          ext_project.external_issue_tracker
        end.to change { ext_project.reload.has_external_issue_tracker }.to(true)
      end
    end

    it 'returns nil and does not query services when there is no external issue tracker' do
      expect(project).not_to receive(:services)

      expect(project.external_issue_tracker).to eq(nil)
    end

    it 'retrieves external_issue_tracker querying services and cache it when there is external issue tracker' do
      ext_project.reload # Factory returns a project with changed attributes
      expect(ext_project).to receive(:services).once.and_call_original

      2.times { expect(ext_project.external_issue_tracker).to be_a_kind_of(RedmineService) }
    end
  end

L
Lin Jen-Shin 已提交
672
  describe '#cache_has_external_issue_tracker' do
673
    let(:project) { create(:project, has_external_issue_tracker: nil) }
674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693

    it 'stores true if there is any external_issue_tracker' do
      services = double(:service, external_issue_trackers: [RedmineService.new])
      expect(project).to receive(:services).and_return(services)

      expect do
        project.cache_has_external_issue_tracker
      end.to change { project.has_external_issue_tracker}.to(true)
    end

    it 'stores false if there is no external_issue_tracker' do
      services = double(:service, external_issue_trackers: [])
      expect(project).to receive(:services).and_return(services)

      expect do
        project.cache_has_external_issue_tracker
      end.to change { project.has_external_issue_tracker}.to(false)
    end
  end

694
  describe '#has_wiki?' do
695 696 697
    let(:no_wiki_project)       { create(:project, :wiki_disabled, has_external_wiki: false) }
    let(:wiki_enabled_project)  { create(:project) }
    let(:external_wiki_project) { create(:project, has_external_wiki: true) }
698 699 700 701 702 703 704 705

    it 'returns true if project is wiki enabled or has external wiki' do
      expect(wiki_enabled_project).to have_wiki
      expect(external_wiki_project).to have_wiki
      expect(no_wiki_project).not_to have_wiki
    end
  end

706
  describe '#external_wiki' do
707
    let(:project) { create(:project) }
708

709 710 711 712 713
    context 'with an active external wiki' do
      before do
        create(:service, project: project, type: 'ExternalWikiService', active: true)
        project.external_wiki
      end
714

715 716 717
      it 'sets :has_external_wiki as true' do
        expect(project.has_external_wiki).to be(true)
      end
718

719 720
      it 'sets :has_external_wiki as false if an external wiki service is destroyed later' do
        expect(project.has_external_wiki).to be(true)
721

722 723 724 725
        project.services.external_wikis.first.destroy

        expect(project.has_external_wiki).to be(false)
      end
726 727
    end

728 729 730 731
    context 'with an inactive external wiki' do
      before do
        create(:service, project: project, type: 'ExternalWikiService', active: false)
      end
732

733 734 735
      it 'sets :has_external_wiki as false' do
        expect(project.has_external_wiki).to be(false)
      end
736 737
    end

738 739 740 741
    context 'with no external wiki' do
      before do
        project.external_wiki
      end
742

743 744 745 746 747 748 749 750 751 752 753
      it 'sets :has_external_wiki as false' do
        expect(project.has_external_wiki).to be(false)
      end

      it 'sets :has_external_wiki as true if an external wiki service is created later' do
        expect(project.has_external_wiki).to be(false)

        create(:service, project: project, type: 'ExternalWikiService', active: true)

        expect(project.has_external_wiki).to be(true)
      end
754 755 756
    end
  end

757 758
  describe '#star_count' do
    it 'counts stars from multiple users' do
C
Ciro Santilli 已提交
759 760
      user1 = create :user
      user2 = create :user
761
      project = create(:project, :public)
C
Ciro Santilli 已提交
762 763

      expect(project.star_count).to eq(0)
764

C
Ciro Santilli 已提交
765
      user1.toggle_star(project)
766 767
      expect(project.reload.star_count).to eq(1)

C
Ciro Santilli 已提交
768
      user2.toggle_star(project)
769 770 771
      project.reload
      expect(project.reload.star_count).to eq(2)

C
Ciro Santilli 已提交
772
      user1.toggle_star(project)
773 774 775
      project.reload
      expect(project.reload.star_count).to eq(1)

C
Ciro Santilli 已提交
776
      user2.toggle_star(project)
777 778 779 780
      project.reload
      expect(project.reload.star_count).to eq(0)
    end

781
    it 'counts stars on the right project' do
782
      user = create :user
783 784
      project1 = create(:project, :public)
      project2 = create(:project, :public)
785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811

      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project1)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(1)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project1)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project2)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(1)

      user.toggle_star(project2)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)
C
Ciro Santilli 已提交
812 813
    end
  end
814

L
Lin Jen-Shin 已提交
815
  describe '#avatar_type' do
816
    let(:project) { create(:project) }
817

818
    it 'is true if avatar is image' do
819
      project.update_attribute(:avatar, 'uploads/avatar.png')
820
      expect(project.avatar_type).to be_truthy
821 822
    end

823
    it 'is false if avatar is html page' do
824
      project.update_attribute(:avatar, 'uploads/avatar.html')
825
      expect(project.avatar_type).to eq(['only images allowed'])
826 827
    end
  end
S
sue445 已提交
828

L
Lin Jen-Shin 已提交
829
  describe '#avatar_url' do
S
sue445 已提交
830 831
    subject { project.avatar_url }

832
    let(:project) { create(:project) }
S
sue445 已提交
833

834
    context 'when avatar file is uploaded' do
835
      let(:project) { create(:project, :with_avatar) }
836
      let(:avatar_path) { "/uploads/-/system/project/avatar/#{project.id}/dk.png" }
837
      let(:gitlab_host) { "http://#{Gitlab.config.gitlab.host}" }
S
sue445 已提交
838

839 840 841 842 843 844 845 846
      it 'shows correct url' do
        expect(project.avatar_url).to eq(avatar_path)
        expect(project.avatar_url(only_path: false)).to eq([gitlab_host, avatar_path].join)

        allow(ActionController::Base).to receive(:asset_host).and_return(gitlab_host)

        expect(project.avatar_url).to eq([gitlab_host, avatar_path].join)
      end
S
sue445 已提交
847 848 849 850 851 852 853
    end

    context 'When avatar file in git' do
      before do
        allow(project).to receive(:avatar_in_git) { true }
      end

854
      let(:avatar_path) { "/#{project.full_path}/avatar" }
S
sue445 已提交
855

856
      it { is_expected.to eq "http://#{Gitlab.config.gitlab.host}#{avatar_path}" }
S
sue445 已提交
857
    end
858 859

    context 'when git repo is empty' do
860
      let(:project) { create(:project) }
861

862
      it { is_expected.to eq nil }
863
    end
S
sue445 已提交
864
  end
865

866
  describe '#pipeline_for' do
867
    let(:project) { create(:project, :repository) }
868
    let!(:pipeline) { create_pipeline }
K
Kamil Trzcinski 已提交
869

870 871
    shared_examples 'giving the correct pipeline' do
      it { is_expected.to eq(pipeline) }
K
Kamil Trzcinski 已提交
872

873 874
      context 'return latest' do
        let!(:pipeline2) { create_pipeline }
K
Kamil Trzcinski 已提交
875

876
        it { is_expected.to eq(pipeline2) }
K
Kamil Trzcinski 已提交
877
      end
878 879 880 881 882 883 884 885 886 887 888 889 890
    end

    context 'with explicit sha' do
      subject { project.pipeline_for('master', pipeline.sha) }

      it_behaves_like 'giving the correct pipeline'
    end

    context 'with implicit sha' do
      subject { project.pipeline_for('master') }

      it_behaves_like 'giving the correct pipeline'
    end
K
Kamil Trzcinski 已提交
891

892 893 894 895 896
    def create_pipeline
      create(:ci_pipeline,
             project: project,
             ref: 'master',
             sha: project.commit('master').sha)
K
Kamil Trzcinski 已提交
897
    end
898
  end
899

L
Lin Jen-Shin 已提交
900
  describe '#builds_enabled' do
901
    let(:project) { create(:project) }
902

903 904 905
    subject { project.builds_enabled }

    it { expect(project.builds_enabled?).to be_truthy }
906
  end
Y
Yorick Peterse 已提交
907

908
  describe '.with_shared_runners' do
909
    subject { described_class.with_shared_runners }
910 911

    context 'when shared runners are enabled for project' do
912
      let!(:project) { create(:project, shared_runners_enabled: true) }
913 914 915 916 917 918 919

      it "returns a project" do
        is_expected.to eq([project])
      end
    end

    context 'when shared runners are disabled for project' do
920
      let!(:project) { create(:project, shared_runners_enabled: false) }
921 922 923 924 925 926 927

      it "returns an empty array" do
        is_expected.to be_empty
      end
    end
  end

928
  describe '.cached_count', :use_clean_rails_memory_store_caching do
929
    let(:group)     { create(:group, :public) }
930 931
    let!(:project1) { create(:project, :public, group: group) }
    let!(:project2) { create(:project, :public, group: group) }
932 933

    it 'returns total project count' do
934
      expect(described_class).to receive(:count).once.and_call_original
935 936

      3.times do
937
        expect(described_class.cached_count).to eq(2)
938 939 940 941
      end
    end
  end

Y
Yorick Peterse 已提交
942
  describe '.trending' do
F
Felipe Artur 已提交
943
    let(:group)    { create(:group, :public) }
944 945
    let(:project1) { create(:project, :public, group: group) }
    let(:project2) { create(:project, :public, group: group) }
Y
Yorick Peterse 已提交
946 947 948 949 950 951 952 953

    before do
      2.times do
        create(:note_on_commit, project: project1)
      end

      create(:note_on_commit, project: project2)

Y
Yorick Peterse 已提交
954
      TrendingProject.refresh!
Y
Yorick Peterse 已提交
955 956
    end

Y
Yorick Peterse 已提交
957
    subject { described_class.trending.to_a }
Y
Yorick Peterse 已提交
958

Y
Yorick Peterse 已提交
959 960
    it 'sorts projects by the amount of notes in descending order' do
      expect(subject).to eq([project1, project2])
Y
Yorick Peterse 已提交
961
    end
962 963 964 965 966 967 968 969

    it 'does not take system notes into account' do
      10.times do
        create(:note_on_commit, project: project2, system: true)
      end

      expect(described_class.trending.to_a).to eq([project1, project2])
    end
Y
Yorick Peterse 已提交
970
  end
Y
Yorick Peterse 已提交
971

T
Toon Claes 已提交
972 973 974 975
  describe '.starred_by' do
    it 'returns only projects starred by the given user' do
      user1 = create(:user)
      user2 = create(:user)
976 977 978
      project1 = create(:project)
      project2 = create(:project)
      create(:project)
T
Toon Claes 已提交
979 980 981
      user1.toggle_star(project1)
      user2.toggle_star(project2)

982
      expect(described_class.starred_by(user1)).to contain_exactly(project1)
T
Toon Claes 已提交
983 984 985
    end
  end

Y
Yorick Peterse 已提交
986
  describe '.visible_to_user' do
987
    let!(:project) { create(:project, :private) }
Y
Yorick Peterse 已提交
988 989 990 991 992 993
    let!(:user)    { create(:user) }

    subject { described_class.visible_to_user(user) }

    describe 'when a user has access to a project' do
      before do
994
        project.add_user(user, Gitlab::Access::MASTER)
Y
Yorick Peterse 已提交
995 996 997 998 999 1000 1001 1002 1003
      end

      it { is_expected.to eq([project]) }
    end

    describe 'when a user does not have access to any projects' do
      it { is_expected.to eq([]) }
    end
  end
K
Kamil Trzcinski 已提交
1004

1005
  context 'repository storage by default' do
1006
    let(:project) { create(:project) }
1007 1008

    before do
1009
      storages = {
1010
        'default' => { 'path' => 'tmp/tests/repositories' },
1011
        'picked'  => { 'path' => 'tmp/tests/repositories' }
1012
      }
1013 1014 1015
      allow(Gitlab.config.repositories).to receive(:storages).and_return(storages)
    end

1016 1017 1018 1019 1020
    it 'picks storage from ApplicationSetting' do
      expect_any_instance_of(ApplicationSetting).to receive(:pick_repository_storage).and_return('picked')

      expect(project.repository_storage).to eq('picked')
    end
1021 1022
  end

K
Kamil Trzcinski 已提交
1023
  context 'shared runners by default' do
1024
    let(:project) { create(:project) }
K
Kamil Trzcinski 已提交
1025 1026 1027 1028

    subject { project.shared_runners_enabled }

    context 'are enabled' do
1029 1030 1031
      before do
        stub_application_setting(shared_runners_enabled: true)
      end
K
Kamil Trzcinski 已提交
1032 1033 1034 1035 1036

      it { is_expected.to be_truthy }
    end

    context 'are disabled' do
1037 1038 1039
      before do
        stub_application_setting(shared_runners_enabled: false)
      end
K
Kamil Trzcinski 已提交
1040 1041 1042 1043 1044

      it { is_expected.to be_falsey }
    end
  end

L
Lin Jen-Shin 已提交
1045
  describe '#any_runners' do
1046
    let(:project) { create(:project, shared_runners_enabled: shared_runners_enabled) }
1047 1048
    let(:specific_runner) { create(:ci_runner) }
    let(:shared_runner) { create(:ci_runner, :shared) }
K
Kamil Trzcinski 已提交
1049 1050 1051

    context 'for shared runners disabled' do
      let(:shared_runners_enabled) { false }
1052

1053
      it 'has no runners available' do
K
Kamil Trzcinski 已提交
1054 1055
        expect(project.any_runners?).to be_falsey
      end
1056

1057
      it 'has a specific runner' do
1058
        project.runners << specific_runner
K
Kamil Trzcinski 已提交
1059 1060
        expect(project.any_runners?).to be_truthy
      end
1061

1062
      it 'has a shared runner, but they are prohibited to use' do
K
Kamil Trzcinski 已提交
1063 1064 1065
        shared_runner
        expect(project.any_runners?).to be_falsey
      end
1066

K
Kamil Trzcinski 已提交
1067
      it 'checks the presence of specific runner' do
1068
        project.runners << specific_runner
K
Kamil Trzcinski 已提交
1069 1070 1071
        expect(project.any_runners? { |runner| runner == specific_runner }).to be_truthy
      end
    end
1072

K
Kamil Trzcinski 已提交
1073 1074
    context 'for shared runners enabled' do
      let(:shared_runners_enabled) { true }
1075

1076
      it 'has a shared runner' do
K
Kamil Trzcinski 已提交
1077 1078 1079 1080 1081 1082 1083 1084 1085 1086
        shared_runner
        expect(project.any_runners?).to be_truthy
      end

      it 'checks the presence of shared runner' do
        shared_runner
        expect(project.any_runners? { |runner| runner == shared_runner }).to be_truthy
      end
    end
  end
1087

1088 1089 1090 1091 1092 1093
  describe '#shared_runners' do
    let!(:runner) { create(:ci_runner, :shared) }

    subject { project.shared_runners }

    context 'when shared runners are enabled for project' do
1094
      let!(:project) { create(:project, shared_runners_enabled: true) }
1095 1096 1097 1098 1099 1100 1101

      it "returns a list of shared runners" do
        is_expected.to eq([runner])
      end
    end

    context 'when shared runners are disabled for project' do
1102
      let!(:project) { create(:project, shared_runners_enabled: false) }
1103 1104 1105 1106 1107 1108 1109

      it "returns a empty list" do
        is_expected.to be_empty
      end
    end
  end

1110
  describe '#visibility_level_allowed?' do
1111
    let(:project) { create(:project, :internal) }
1112 1113 1114 1115 1116 1117 1118 1119

    context 'when checking on non-forked project' do
      it { expect(project.visibility_level_allowed?(Gitlab::VisibilityLevel::PRIVATE)).to be_truthy }
      it { expect(project.visibility_level_allowed?(Gitlab::VisibilityLevel::INTERNAL)).to be_truthy }
      it { expect(project.visibility_level_allowed?(Gitlab::VisibilityLevel::PUBLIC)).to be_truthy }
    end

    context 'when checking on forked project' do
1120 1121
      let(:project)        { create(:project, :internal) }
      let(:forked_project) { create(:project, forked_from_project: project) }
1122 1123 1124 1125 1126

      it { expect(forked_project.visibility_level_allowed?(Gitlab::VisibilityLevel::PRIVATE)).to be_truthy }
      it { expect(forked_project.visibility_level_allowed?(Gitlab::VisibilityLevel::INTERNAL)).to be_truthy }
      it { expect(forked_project.visibility_level_allowed?(Gitlab::VisibilityLevel::PUBLIC)).to be_falsey }
    end
1127
  end
1128

1129
  describe '#pages_deployed?' do
1130
    let(:project) { create :project }
1131 1132 1133 1134

    subject { project.pages_deployed? }

    context 'if public folder does exist' do
1135 1136 1137
      before do
        allow(Dir).to receive(:exist?).with(project.public_pages_path).and_return(true)
      end
1138 1139 1140 1141 1142 1143 1144 1145 1146

      it { is_expected.to be_truthy }
    end

    context "if public folder doesn't exist" do
      it { is_expected.to be_falsey }
    end
  end

1147 1148
  describe '#pages_url' do
    let(:group) { create :group, name: group_name }
1149
    let(:project) { create :project, namespace: group, name: project_name }
1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173
    let(:domain) { 'Example.com' }

    subject { project.pages_url }

    before do
      allow(Settings.pages).to receive(:host).and_return(domain)
      allow(Gitlab.config.pages).to receive(:url).and_return('http://example.com')
    end

    context 'group page' do
      let(:group_name) { 'Group' }
      let(:project_name) { 'group.example.com' }

      it { is_expected.to eq("http://group.example.com") }
    end

    context 'project page' do
      let(:group_name) { 'Group' }
      let(:project_name) { 'Project' }

      it { is_expected.to eq("http://group.example.com/project") }
    end
  end

1174
  describe '.search' do
1175
    let(:project) { create(:project, description: 'kitten mittens') }
1176

1177 1178 1179
    it 'returns projects with a matching name' do
      expect(described_class.search(project.name)).to eq([project])
    end
1180

1181 1182 1183
    it 'returns projects with a partially matching name' do
      expect(described_class.search(project.name[0..2])).to eq([project])
    end
1184

1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223
    it 'returns projects with a matching name regardless of the casing' do
      expect(described_class.search(project.name.upcase)).to eq([project])
    end

    it 'returns projects with a matching description' do
      expect(described_class.search(project.description)).to eq([project])
    end

    it 'returns projects with a partially matching description' do
      expect(described_class.search('kitten')).to eq([project])
    end

    it 'returns projects with a matching description regardless of the casing' do
      expect(described_class.search('KITTEN')).to eq([project])
    end

    it 'returns projects with a matching path' do
      expect(described_class.search(project.path)).to eq([project])
    end

    it 'returns projects with a partially matching path' do
      expect(described_class.search(project.path[0..2])).to eq([project])
    end

    it 'returns projects with a matching path regardless of the casing' do
      expect(described_class.search(project.path.upcase)).to eq([project])
    end

    it 'returns projects with a matching namespace name' do
      expect(described_class.search(project.namespace.name)).to eq([project])
    end

    it 'returns projects with a partially matching namespace name' do
      expect(described_class.search(project.namespace.name[0..2])).to eq([project])
    end

    it 'returns projects with a matching namespace name regardless of the casing' do
      expect(described_class.search(project.namespace.name.upcase)).to eq([project])
    end
1224 1225 1226 1227 1228

    it 'returns projects when eager loading namespaces' do
      relation = described_class.all.includes(:namespace)

      expect(relation.search(project.namespace.name)).to eq([project])
1229
    end
1230 1231

    describe 'with pending_delete project' do
1232
      let(:pending_delete_project) { create(:project, pending_delete: true) }
1233 1234 1235 1236 1237 1238 1239

      it 'shows pending deletion project' do
        search_result = described_class.search(pending_delete_project.name)

        expect(search_result).to eq([pending_delete_project])
      end
    end
1240
  end
1241 1242

  describe '#expire_caches_before_rename' do
1243
    let(:project) { create(:project, :repository) }
1244 1245 1246 1247
    let(:repo)    { double(:repo, exists?: true) }
    let(:wiki)    { double(:wiki, exists?: true) }

    it 'expires the caches of the repository and wiki' do
1248 1249 1250
      allow(Repository).to receive(:new)
        .with('foo', project)
        .and_return(repo)
1251

1252 1253 1254
      allow(Repository).to receive(:new)
        .with('foo.wiki', project)
        .and_return(wiki)
1255

1256 1257
      expect(repo).to receive(:before_delete)
      expect(wiki).to receive(:before_delete)
1258 1259 1260 1261

      project.expire_caches_before_rename('foo')
    end
  end
1262 1263

  describe '.search_by_title' do
1264
    let(:project) { create(:project, name: 'kittens') }
1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277

    it 'returns projects with a matching name' do
      expect(described_class.search_by_title(project.name)).to eq([project])
    end

    it 'returns projects with a partially matching name' do
      expect(described_class.search_by_title('kitten')).to eq([project])
    end

    it 'returns projects with a matching name regardless of the casing' do
      expect(described_class.search_by_title('KITTENS')).to eq([project])
    end
  end
1278 1279 1280 1281 1282

  context 'when checking projects from groups' do
    let(:private_group)    { create(:group, visibility_level: 0)  }
    let(:internal_group)   { create(:group, visibility_level: 10) }

1283 1284
    let(:private_project)  { create :project, :private, group: private_group }
    let(:internal_project) { create :project, :internal, group: internal_group }
1285 1286 1287 1288 1289 1290 1291 1292 1293

    context 'when group is private project can not be internal' do
      it { expect(private_project.visibility_level_allowed?(Gitlab::VisibilityLevel::INTERNAL)).to be_falsey }
    end

    context 'when group is internal project can not be public' do
      it { expect(internal_project.visibility_level_allowed?(Gitlab::VisibilityLevel::PUBLIC)).to be_falsey }
    end
  end
1294

1295
  describe '#create_repository' do
1296
    let(:project) { create(:project, :repository) }
1297 1298 1299 1300 1301 1302 1303 1304
    let(:shell) { Gitlab::Shell.new }

    before do
      allow(project).to receive(:gitlab_shell).and_return(shell)
    end

    context 'using a regular repository' do
      it 'creates the repository' do
1305
        expect(shell).to receive(:add_repository)
1306
          .with(project.repository_storage_path, project.disk_path)
1307
          .and_return(true)
1308 1309 1310 1311 1312 1313 1314

        expect(project.repository).to receive(:after_create)

        expect(project.create_repository).to eq(true)
      end

      it 'adds an error if the repository could not be created' do
1315
        expect(shell).to receive(:add_repository)
1316
          .with(project.repository_storage_path, project.disk_path)
1317
          .and_return(false)
1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334

        expect(project.repository).not_to receive(:after_create)

        expect(project.create_repository).to eq(false)
        expect(project.errors).not_to be_empty
      end
    end

    context 'using a forked repository' do
      it 'does nothing' do
        expect(project).to receive(:forked?).and_return(true)
        expect(shell).not_to receive(:add_repository)

        project.create_repository
      end
    end
  end
1335

1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348
  describe '#ensure_repository' do
    let(:project) { create(:project, :repository) }
    let(:shell) { Gitlab::Shell.new }

    before do
      allow(project).to receive(:gitlab_shell).and_return(shell)
    end

    it 'creates the repository if it not exist' do
      allow(project).to receive(:repository_exists?)
        .and_return(false)

      allow(shell).to receive(:add_repository)
1349
        .with(project.repository_storage_path, project.disk_path)
1350 1351
        .and_return(true)

1352
      expect(project).to receive(:create_repository).with(force: true)
1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364

      project.ensure_repository
    end

    it 'does not create the repository if it exists' do
      allow(project).to receive(:repository_exists?)
        .and_return(true)

      expect(project).not_to receive(:create_repository)

      project.ensure_repository
    end
1365 1366 1367 1368 1369 1370 1371 1372

    it 'creates the repository if it is a fork' do
      expect(project).to receive(:forked?).and_return(true)

      allow(project).to receive(:repository_exists?)
        .and_return(false)

      expect(shell).to receive(:add_repository)
1373
        .with(project.repository_storage_path, project.disk_path)
1374 1375 1376 1377
        .and_return(true)

      project.ensure_repository
    end
1378 1379
  end

1380
  describe '#user_can_push_to_empty_repo?' do
1381
    let(:project) { create(:project) }
1382
    let(:user)    { create(:user) }
1383

1384 1385 1386
    it 'returns false when default_branch_protection is in full protection and user is developer' do
      project.team << [user, :developer]
      stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_FULL)
1387

1388
      expect(project.user_can_push_to_empty_repo?(user)).to be_falsey
1389 1390
    end

1391 1392 1393
    it 'returns false when default_branch_protection only lets devs merge and user is dev' do
      project.team << [user, :developer]
      stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_DEV_CAN_MERGE)
1394

1395
      expect(project.user_can_push_to_empty_repo?(user)).to be_falsey
1396 1397
    end

1398 1399 1400
    it 'returns true when default_branch_protection lets devs push and user is developer' do
      project.team << [user, :developer]
      stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_DEV_CAN_PUSH)
1401

1402 1403
      expect(project.user_can_push_to_empty_repo?(user)).to be_truthy
    end
1404

1405 1406 1407
    it 'returns true when default_branch_protection is unprotected and user is developer' do
      project.team << [user, :developer]
      stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_NONE)
1408

1409
      expect(project.user_can_push_to_empty_repo?(user)).to be_truthy
1410
    end
1411

1412 1413
    it 'returns true when user is master' do
      project.team << [user, :master]
1414

1415
      expect(project.user_can_push_to_empty_repo?(user)).to be_truthy
1416 1417 1418
    end
  end

A
Andre Guedes 已提交
1419
  describe '#container_registry_url' do
1420
    let(:project) { create(:project) }
K
Kamil Trzcinski 已提交
1421

A
Andre Guedes 已提交
1422
    subject { project.container_registry_url }
K
Kamil Trzcinski 已提交
1423

1424 1425 1426
    before do
      stub_container_registry_config(**registry_settings)
    end
K
Kamil Trzcinski 已提交
1427 1428 1429

    context 'for enabled registry' do
      let(:registry_settings) do
1430 1431
        { enabled: true,
          host_port: 'example.com' }
K
Kamil Trzcinski 已提交
1432 1433
      end

1434
      it { is_expected.not_to be_nil }
K
Kamil Trzcinski 已提交
1435 1436 1437 1438
    end

    context 'for disabled registry' do
      let(:registry_settings) do
1439
        { enabled: false }
K
Kamil Trzcinski 已提交
1440 1441 1442 1443 1444 1445
      end

      it { is_expected.to be_nil }
    end
  end

1446
  describe '#has_container_registry_tags?' do
1447
    let(:project) { create(:project) }
1448 1449

    context 'when container registry is enabled' do
1450 1451 1452
      before do
        stub_container_registry_config(enabled: true)
      end
1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489

      context 'when tags are present for multi-level registries' do
        before do
          create(:container_repository, project: project, name: 'image')

          stub_container_registry_tags(repository: /image/,
                                       tags: %w[latest rc1])
        end

        it 'should have image tags' do
          expect(project).to have_container_registry_tags
        end
      end

      context 'when tags are present for root repository' do
        before do
          stub_container_registry_tags(repository: project.full_path,
                                       tags: %w[latest rc1 pre1])
        end

        it 'should have image tags' do
          expect(project).to have_container_registry_tags
        end
      end

      context 'when there are no tags at all' do
        before do
          stub_container_registry_tags(repository: :any, tags: [])
        end

        it 'should not have image tags' do
          expect(project).not_to have_container_registry_tags
        end
      end
    end

    context 'when container registry is disabled' do
1490 1491 1492
      before do
        stub_container_registry_config(enabled: false)
      end
1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509

      it 'should not have image tags' do
        expect(project).not_to have_container_registry_tags
      end

      it 'should not check root repository tags' do
        expect(project).not_to receive(:full_path)
        expect(project).not_to have_container_registry_tags
      end

      it 'should iterate through container repositories' do
        expect(project).to receive(:container_repositories)
        expect(project).not_to have_container_registry_tags
      end
    end
  end

1510
  describe '#ci_config_path=' do
1511
    let(:project) { create(:project) }
1512 1513

    it 'sets nil' do
1514
      project.update!(ci_config_path: nil)
1515

1516
      expect(project.ci_config_path).to be_nil
1517 1518 1519
    end

    it 'sets a string' do
1520
      project.update!(ci_config_path: 'foo/.gitlab_ci.yml')
1521

1522
      expect(project.ci_config_path).to eq('foo/.gitlab_ci.yml')
1523 1524
    end

1525
    it 'sets a string but removes all leading slashes and null characters' do
1526
      project.update!(ci_config_path: "///f\0oo/\0/.gitlab_ci.yml")
1527

1528
      expect(project.ci_config_path).to eq('foo//.gitlab_ci.yml')
1529 1530 1531
    end
  end

1532
  describe 'Project import job' do
1533
    let(:project) { create(:project, import_url: generate(:url)) }
1534 1535

    before do
S
Stan Hu 已提交
1536
      allow_any_instance_of(Gitlab::Shell).to receive(:import_repository)
1537
        .with(project.repository_storage_path, project.disk_path, project.import_url)
S
Stan Hu 已提交
1538 1539 1540 1541
        .and_return(true)

      expect_any_instance_of(Repository).to receive(:after_import)
        .and_call_original
1542 1543 1544 1545 1546
    end

    it 'imports a project' do
      expect_any_instance_of(RepositoryImportWorker).to receive(:perform).and_call_original

1547
      expect { project.import_schedule }.to change { project.import_jid }
1548 1549 1550 1551
      expect(project.reload.import_status).to eq('finished')
    end
  end

1552 1553
  describe 'project import state transitions' do
    context 'state transition: [:started] => [:finished]' do
L
Lin Jen-Shin 已提交
1554
      let(:after_import_service) { spy(:after_import_service) }
L
Lin Jen-Shin 已提交
1555
      let(:housekeeping_service) { spy(:housekeeping_service) }
1556 1557

      before do
L
Lin Jen-Shin 已提交
1558 1559
        allow(Projects::AfterImportService)
          .to receive(:new) { after_import_service }
L
Lin Jen-Shin 已提交
1560

L
Lin Jen-Shin 已提交
1561
        allow(after_import_service)
L
Lin Jen-Shin 已提交
1562 1563 1564 1565
          .to receive(:execute) { housekeeping_service.execute }

        allow(Projects::HousekeepingService)
          .to receive(:new) { housekeeping_service }
1566 1567
      end

1568 1569 1570 1571 1572 1573 1574
      it 'resets project import_error' do
        error_message = 'Some error'
        mirror = create(:project_empty_repo, :import_started, import_error: error_message)

        expect { mirror.import_finish }.to change { mirror.import_error }.from(error_message).to(nil)
      end

1575 1576 1577 1578 1579
      it 'performs housekeeping when an import of a fresh project is completed' do
        project = create(:project_empty_repo, :import_started, import_type: :github)

        project.import_finish

L
Lin Jen-Shin 已提交
1580
        expect(after_import_service).to have_received(:execute)
1581 1582 1583 1584
        expect(housekeeping_service).to have_received(:execute)
      end

      it 'does not perform housekeeping when project repository does not exist' do
1585
        project = create(:project, :import_started, import_type: :github)
1586 1587 1588 1589 1590 1591 1592

        project.import_finish

        expect(housekeeping_service).not_to have_received(:execute)
      end

      it 'does not perform housekeeping when project does not have a valid import type' do
1593
        project = create(:project, :import_started, import_type: nil)
1594 1595 1596 1597 1598 1599 1600 1601

        project.import_finish

        expect(housekeeping_service).not_to have_received(:execute)
      end
    end
  end

1602
  describe '#latest_successful_builds_for' do
L
Lin Jen-Shin 已提交
1603
    def create_pipeline(status = 'success')
1604
      create(:ci_pipeline, project: project,
L
Lin Jen-Shin 已提交
1605
                           sha: project.commit.sha,
1606
                           ref: project.default_branch,
L
Lin Jen-Shin 已提交
1607
                           status: status)
1608 1609
    end

L
Lin Jen-Shin 已提交
1610 1611 1612
    def create_build(new_pipeline = pipeline, name = 'test')
      create(:ci_build, :success, :artifacts,
             pipeline: new_pipeline,
L
Lin Jen-Shin 已提交
1613
             status: new_pipeline.status,
L
Lin Jen-Shin 已提交
1614
             name: name)
1615 1616
    end

1617
    let(:project) { create(:project, :repository) }
L
Lin Jen-Shin 已提交
1618
    let(:pipeline) { create_pipeline }
L
Lin Jen-Shin 已提交
1619 1620

    context 'with many builds' do
1621
      it 'gives the latest builds from latest pipeline' do
1622 1623
        pipeline1 = create_pipeline
        pipeline2 = create_pipeline
1624
        build1_p2 = create_build(pipeline2, 'test')
1625 1626
        create_build(pipeline1, 'test')
        create_build(pipeline1, 'test2')
1627
        build2_p2 = create_build(pipeline2, 'test2')
L
Lin Jen-Shin 已提交
1628 1629 1630

        latest_builds = project.latest_successful_builds_for

1631
        expect(latest_builds).to contain_exactly(build2_p2, build1_p2)
L
Lin Jen-Shin 已提交
1632 1633
      end
    end
L
Lin Jen-Shin 已提交
1634

L
Lin Jen-Shin 已提交
1635
    context 'with succeeded pipeline' do
L
Lin Jen-Shin 已提交
1636
      let!(:build) { create_build }
1637

L
Lin Jen-Shin 已提交
1638
      context 'standalone pipeline' do
1639 1640 1641 1642 1643 1644 1645 1646
        it 'returns builds for ref for default_branch' do
          builds = project.latest_successful_builds_for

          expect(builds).to contain_exactly(build)
        end

        it 'returns empty relation if the build cannot be found' do
          builds = project.latest_successful_builds_for('TAIL')
1647

1648 1649 1650
          expect(builds).to be_kind_of(ActiveRecord::Relation)
          expect(builds).to be_empty
        end
1651 1652
      end

L
Lin Jen-Shin 已提交
1653
      context 'with some pending pipeline' do
1654
        before do
L
Lin Jen-Shin 已提交
1655
          create_build(create_pipeline('pending'))
1656 1657
        end

L
Lin Jen-Shin 已提交
1658 1659
        it 'gives the latest build from latest pipeline' do
          latest_build = project.latest_successful_builds_for
1660

L
Lin Jen-Shin 已提交
1661
          expect(latest_build).to contain_exactly(build)
1662
        end
1663 1664 1665 1666 1667 1668
      end
    end

    context 'with pending pipeline' do
      before do
        pipeline.update(status: 'pending')
L
Lin Jen-Shin 已提交
1669
        create_build(pipeline)
1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680
      end

      it 'returns empty relation' do
        builds = project.latest_successful_builds_for

        expect(builds).to be_kind_of(ActiveRecord::Relation)
        expect(builds).to be_empty
      end
    end
  end

1681
  describe '#add_import_job' do
1682 1683
    let(:import_jid) { '123' }

1684
    context 'forked' do
1685
      let(:forked_project_link) { create(:forked_project_link, :forked_to_empty_project) }
1686 1687 1688 1689
      let(:forked_from_project) { forked_project_link.forked_from_project }
      let(:project) { forked_project_link.forked_to_project }

      it 'schedules a RepositoryForkWorker job' do
1690 1691 1692 1693 1694
        expect(RepositoryForkWorker).to receive(:perform_async).with(
          project.id,
          forked_from_project.repository_storage_path,
          forked_from_project.disk_path,
          project.namespace.full_path).and_return(import_jid)
1695

1696
        expect(project.add_import_job).to eq(import_jid)
1697 1698 1699 1700 1701
      end
    end

    context 'not forked' do
      it 'schedules a RepositoryImportWorker job' do
1702
        project = create(:project, import_url: generate(:url))
1703

1704 1705
        expect(RepositoryImportWorker).to receive(:perform_async).with(project.id).and_return(import_jid)
        expect(project.add_import_job).to eq(import_jid)
1706 1707 1708 1709
      end
    end
  end

R
Rémy Coutable 已提交
1710
  describe '#gitlab_project_import?' do
1711
    subject(:project) { build(:project, import_type: 'gitlab_project') }
R
Rémy Coutable 已提交
1712 1713 1714 1715 1716

    it { expect(project.gitlab_project_import?).to be true }
  end

  describe '#gitea_import?' do
1717
    subject(:project) { build(:project, import_type: 'gitea') }
R
Rémy Coutable 已提交
1718 1719 1720 1721

    it { expect(project.gitea_import?).to be true }
  end

1722
  describe '#lfs_enabled?' do
1723
    let(:project) { create(:project) }
1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783

    shared_examples 'project overrides group' do
      it 'returns true when enabled in project' do
        project.update_attribute(:lfs_enabled, true)

        expect(project.lfs_enabled?).to be_truthy
      end

      it 'returns false when disabled in project' do
        project.update_attribute(:lfs_enabled, false)

        expect(project.lfs_enabled?).to be_falsey
      end

      it 'returns the value from the namespace, when no value is set in project' do
        expect(project.lfs_enabled?).to eq(project.namespace.lfs_enabled?)
      end
    end

    context 'LFS disabled in group' do
      before do
        project.namespace.update_attribute(:lfs_enabled, false)
        enable_lfs
      end

      it_behaves_like 'project overrides group'
    end

    context 'LFS enabled in group' do
      before do
        project.namespace.update_attribute(:lfs_enabled, true)
        enable_lfs
      end

      it_behaves_like 'project overrides group'
    end

    describe 'LFS disabled globally' do
      shared_examples 'it always returns false' do
        it do
          expect(project.lfs_enabled?).to be_falsey
          expect(project.namespace.lfs_enabled?).to be_falsey
        end
      end

      context 'when no values are set' do
        it_behaves_like 'it always returns false'
      end

      context 'when all values are set to true' do
        before do
          project.namespace.update_attribute(:lfs_enabled, true)
          project.update_attribute(:lfs_enabled, true)
        end

        it_behaves_like 'it always returns false'
      end
    end
  end

1784
  describe '#change_head' do
1785
    let(:project) { create(:project, :repository) }
1786

1787 1788 1789 1790 1791
    it 'returns error if branch does not exist' do
      expect(project.change_head('unexisted-branch')).to be false
      expect(project.errors.size).to eq(1)
    end

1792
    it 'calls the before_change_head and after_change_head methods' do
1793
      expect(project.repository).to receive(:before_change_head)
1794 1795
      expect(project.repository).to receive(:after_change_head)

1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815
      project.change_head(project.default_branch)
    end

    it 'creates the new reference with rugged' do
      expect(project.repository.rugged.references).to receive(:create).with('HEAD',
                                                                            "refs/heads/#{project.default_branch}",
                                                                            force: true)
      project.change_head(project.default_branch)
    end

    it 'copies the gitattributes' do
      expect(project.repository).to receive(:copy_gitattributes).with(project.default_branch)
      project.change_head(project.default_branch)
    end

    it 'reloads the default branch' do
      expect(project).to receive(:reload_default_branch)
      project.change_head(project.default_branch)
    end
  end
Y
Yorick Peterse 已提交
1816 1817

  describe '#pushes_since_gc' do
1818
    let(:project) { create(:project) }
Y
Yorick Peterse 已提交
1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839

    after do
      project.reset_pushes_since_gc
    end

    context 'without any pushes' do
      it 'returns 0' do
        expect(project.pushes_since_gc).to eq(0)
      end
    end

    context 'with a number of pushes' do
      it 'returns the number of pushes' do
        3.times { project.increment_pushes_since_gc }

        expect(project.pushes_since_gc).to eq(3)
      end
    end
  end

  describe '#increment_pushes_since_gc' do
1840
    let(:project) { create(:project) }
Y
Yorick Peterse 已提交
1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853

    after do
      project.reset_pushes_since_gc
    end

    it 'increments the number of pushes since the last GC' do
      3.times { project.increment_pushes_since_gc }

      expect(project.pushes_since_gc).to eq(3)
    end
  end

  describe '#reset_pushes_since_gc' do
1854
    let(:project) { create(:project) }
Y
Yorick Peterse 已提交
1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867

    after do
      project.reset_pushes_since_gc
    end

    it 'resets the number of pushes since the last GC' do
      3.times { project.increment_pushes_since_gc }

      project.reset_pushes_since_gc

      expect(project.pushes_since_gc).to eq(0)
    end
  end
1868

1869 1870
  describe '#deployment_variables' do
    context 'when project has no deployment service' do
1871
      let(:project) { create(:project) }
1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888

      it 'returns an empty array' do
        expect(project.deployment_variables).to eq []
      end
    end

    context 'when project has a deployment service' do
      let(:project) { create(:kubernetes_project) }

      it 'returns variables from this service' do
        expect(project.deployment_variables).to include(
          { key: 'KUBE_TOKEN', value: project.kubernetes_service.token, public: false }
        )
      end
    end
  end

1889
  describe '#secret_variables_for' do
1890
    let(:project) { create(:project) }
1891 1892 1893 1894 1895 1896 1897 1898 1899

    let!(:secret_variable) do
      create(:ci_variable, value: 'secret', project: project)
    end

    let!(:protected_variable) do
      create(:ci_variable, :protected, value: 'protected', project: project)
    end

L
Lin Jen-Shin 已提交
1900 1901 1902 1903 1904 1905
    subject { project.secret_variables_for(ref: 'ref') }

    before do
      stub_application_setting(
        default_branch_protection: Gitlab::Access::PROTECTION_NONE)
    end
1906 1907 1908

    shared_examples 'ref is protected' do
      it 'contains all the variables' do
1909
        is_expected.to contain_exactly(secret_variable, protected_variable)
1910 1911 1912 1913
      end
    end

    context 'when the ref is not protected' do
1914
      it 'contains only the secret variables' do
1915
        is_expected.to contain_exactly(secret_variable)
1916 1917 1918
      end
    end

1919 1920 1921
    context 'when the ref is a protected branch' do
      before do
        create(:protected_branch, name: 'ref', project: project)
1922
      end
1923 1924 1925 1926 1927 1928 1929 1930 1931 1932

      it_behaves_like 'ref is protected'
    end

    context 'when the ref is a protected tag' do
      before do
        create(:protected_tag, name: 'ref', project: project)
      end

      it_behaves_like 'ref is protected'
1933 1934 1935
    end
  end

1936
  describe '#protected_for?' do
1937
    let(:project) { create(:project) }
1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972

    subject { project.protected_for?('ref') }

    context 'when the ref is not protected' do
      before do
        stub_application_setting(
          default_branch_protection: Gitlab::Access::PROTECTION_NONE)
      end

      it 'returns false' do
        is_expected.to be_falsey
      end
    end

    context 'when the ref is a protected branch' do
      before do
        create(:protected_branch, name: 'ref', project: project)
      end

      it 'returns true' do
        is_expected.to be_truthy
      end
    end

    context 'when the ref is a protected tag' do
      before do
        create(:protected_tag, name: 'ref', project: project)
      end

      it 'returns true' do
        is_expected.to be_truthy
      end
    end
  end

M
Markus Koller 已提交
1973
  describe '#update_project_statistics' do
1974
    let(:project) { create(:project) }
M
Markus Koller 已提交
1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992

    it "is called after creation" do
      expect(project.statistics).to be_a ProjectStatistics
      expect(project.statistics).to be_persisted
    end

    it "copies the namespace_id" do
      expect(project.statistics.namespace_id).to eq project.namespace_id
    end

    it "updates the namespace_id when changed" do
      namespace = create(:namespace)
      project.update(namespace: namespace)

      expect(project.statistics.namespace_id).to eq namespace.id
    end
  end

1993
  describe 'inside_path' do
1994 1995 1996
    let!(:project1) { create(:project, namespace: create(:namespace, path: 'name_pace')) }
    let!(:project2) { create(:project) }
    let!(:project3) { create(:project, namespace: create(:namespace, path: 'namespace')) }
1997
    let!(:path) { project1.namespace.full_path }
1998

1999
    it 'returns correct project' do
2000
      expect(described_class.inside_path(path)).to eq([project1])
2001
    end
2002 2003
  end

D
Douwe Maan 已提交
2004
  describe '#route_map_for' do
2005
    let(:project) { create(:project, :repository) }
D
Douwe Maan 已提交
2006 2007 2008 2009 2010 2011 2012 2013
    let(:route_map) do
      <<-MAP.strip_heredoc
      - source: /source/(.*)/
        public: '\\1'
      MAP
    end

    before do
2014
      project.repository.create_file(User.last, '.gitlab/route-map.yml', route_map, message: 'Add .gitlab/route-map.yml', branch_name: 'master')
D
Douwe Maan 已提交
2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041
    end

    context 'when there is a .gitlab/route-map.yml at the commit' do
      context 'when the route map is valid' do
        it 'returns a route map' do
          map = project.route_map_for(project.commit.sha)
          expect(map).to be_a_kind_of(Gitlab::RouteMap)
        end
      end

      context 'when the route map is invalid' do
        let(:route_map) { 'INVALID' }

        it 'returns nil' do
          expect(project.route_map_for(project.commit.sha)).to be_nil
        end
      end
    end

    context 'when there is no .gitlab/route-map.yml at the commit' do
      it 'returns nil' do
        expect(project.route_map_for(project.commit.parent.sha)).to be_nil
      end
    end
  end

  describe '#public_path_for_source_path' do
2042
    let(:project) { create(:project, :repository) }
D
Douwe Maan 已提交
2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079
    let(:route_map) do
      Gitlab::RouteMap.new(<<-MAP.strip_heredoc)
        - source: /source/(.*)/
          public: '\\1'
      MAP
    end
    let(:sha) { project.commit.id }

    context 'when there is a route map' do
      before do
        allow(project).to receive(:route_map_for).with(sha).and_return(route_map)
      end

      context 'when the source path is mapped' do
        it 'returns the public path' do
          expect(project.public_path_for_source_path('source/file.html', sha)).to eq('file.html')
        end
      end

      context 'when the source path is not mapped' do
        it 'returns nil' do
          expect(project.public_path_for_source_path('file.html', sha)).to be_nil
        end
      end
    end

    context 'when there is no route map' do
      before do
        allow(project).to receive(:route_map_for).with(sha).and_return(nil)
      end

      it 'returns nil' do
        expect(project.public_path_for_source_path('source/file.html', sha)).to be_nil
      end
    end
  end

2080
  describe '#parent' do
2081
    let(:project) { create(:project) }
2082 2083 2084 2085 2086

    it { expect(project.parent).to eq(project.namespace) }
  end

  describe '#parent_changed?' do
2087
    let(:project) { create(:project) }
2088

2089 2090 2091
    before do
      project.namespace_id = 7
    end
2092 2093 2094 2095

    it { expect(project.parent_changed?).to be_truthy }
  end

2096 2097 2098
  def enable_lfs
    allow(Gitlab.config.lfs).to receive(:enabled).and_return(true)
  end
K
Kamil Trzcinski 已提交
2099

2100
  describe '#pages_url' do
2101 2102
    let(:group) { create :group, name: 'Group' }
    let(:nested_group) { create :group, parent: group }
K
Kamil Trzcinski 已提交
2103 2104 2105 2106 2107 2108 2109 2110 2111
    let(:domain) { 'Example.com' }

    subject { project.pages_url }

    before do
      allow(Settings.pages).to receive(:host).and_return(domain)
      allow(Gitlab.config.pages).to receive(:url).and_return('http://example.com')
    end

2112
    context 'top-level group' do
2113
      let(:project) { create :project, namespace: group, name: project_name }
K
Kamil Trzcinski 已提交
2114

2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125
      context 'group page' do
        let(:project_name) { 'group.example.com' }

        it { is_expected.to eq("http://group.example.com") }
      end

      context 'project page' do
        let(:project_name) { 'Project' }

        it { is_expected.to eq("http://group.example.com/project") }
      end
K
Kamil Trzcinski 已提交
2126 2127
    end

2128
    context 'nested group' do
2129
      let(:project) { create :project, namespace: nested_group, name: project_name }
2130
      let(:expected_url) { "http://group.example.com/#{nested_group.path}/#{project.path}" }
K
Kamil Trzcinski 已提交
2131

2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142
      context 'group page' do
        let(:project_name) { 'group.example.com' }

        it { is_expected.to eq(expected_url) }
      end

      context 'project page' do
        let(:project_name) { 'Project' }

        it { is_expected.to eq(expected_url) }
      end
K
Kamil Trzcinski 已提交
2143 2144
    end
  end
2145 2146

  describe '#http_url_to_repo' do
2147
    let(:project) { create :project }
2148

2149 2150 2151
    it 'returns the url to the repo without a username' do
      expect(project.http_url_to_repo).to eq("#{project.web_url}.git")
      expect(project.http_url_to_repo).not_to include('@')
2152 2153
    end
  end
2154 2155

  describe '#pipeline_status' do
2156
    let(:project) { create(:project, :repository) }
2157
    it 'builds a pipeline status' do
2158
      expect(project.pipeline_status).to be_a(Gitlab::Cache::Ci::ProjectPipelineStatus)
2159 2160 2161 2162 2163 2164
    end

    it 'hase a loaded pipeline status' do
      expect(project.pipeline_status).to be_loaded
    end
  end
2165 2166

  describe '#append_or_update_attribute' do
2167
    let(:project) { create(:project) }
2168 2169 2170 2171 2172

    it 'shows full error updating an invalid MR' do
      error_message = 'Failed to replace merge_requests because one or more of the new records could not be saved.'\
                      ' Validate fork Source project is not a fork of the target project'

2173 2174
      expect { project.append_or_update_attribute(:merge_requests, [create(:merge_request)]) }
        .to raise_error(ActiveRecord::RecordNotSaved, error_message)
2175 2176 2177 2178 2179
    end

    it 'updates the project succesfully' do
      merge_request = create(:merge_request, target_project: project, source_project: project)

2180 2181
      expect { project.append_or_update_attribute(:merge_requests, [merge_request]) }
        .not_to raise_error
2182 2183
    end
  end
2184 2185 2186

  describe '#last_repository_updated_at' do
    it 'sets to created_at upon creation' do
2187
      project = create(:project, created_at: 2.hours.ago)
2188 2189 2190 2191

      expect(project.last_repository_updated_at.to_i).to eq(project.created_at.to_i)
    end
  end
2192 2193 2194 2195 2196

  describe '.public_or_visible_to_user' do
    let!(:user) { create(:user) }

    let!(:private_project) do
2197
      create(:project, :private, creator: user, namespace: user.namespace)
2198 2199
    end

2200
    let!(:public_project) { create(:project, :public) }
2201 2202 2203

    context 'with a user' do
      let(:projects) do
2204
        described_class.all.public_or_visible_to_user(user)
2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217
      end

      it 'includes projects the user has access to' do
        expect(projects).to include(private_project)
      end

      it 'includes projects the user can see' do
        expect(projects).to include(public_project)
      end
    end

    context 'without a user' do
      it 'only includes public projects' do
2218
        projects = described_class.all.public_or_visible_to_user
2219 2220 2221 2222 2223

        expect(projects).to eq([public_project])
      end
    end
  end
2224

2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246
  describe '#pages_available?' do
    let(:project) { create(:project, group: group) }

    subject { project.pages_available? }

    before do
      allow(Gitlab.config.pages).to receive(:enabled).and_return(true)
    end

    context 'when the project is in a top level namespace' do
      let(:group) { create(:group) }

      it { is_expected.to be(true) }
    end

    context 'when the project is in a subgroup' do
      let(:group) { create(:group, :nested) }

      it { is_expected.to be(false) }
    end
  end

2247
  describe '#remove_private_deploy_keys' do
2248
    let!(:project) { create(:project) }
2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263

    context 'for a private deploy key' do
      let!(:key) { create(:deploy_key, public: false) }
      let!(:deploy_keys_project) { create(:deploy_keys_project, deploy_key: key, project: project) }

      context 'when the key is not linked to another project' do
        it 'removes the key' do
          project.remove_private_deploy_keys

          expect(project.deploy_keys).not_to include(key)
        end
      end

      context 'when the key is linked to another project' do
        before do
2264
          another_project = create(:project)
2265 2266
          create(:deploy_keys_project, deploy_key: key, project: another_project)
        end
2267

2268 2269
        it 'does not remove the key' do
          project.remove_private_deploy_keys
2270

2271 2272 2273 2274 2275 2276 2277 2278
          expect(project.deploy_keys).to include(key)
        end
      end
    end

    context 'for a public deploy key' do
      let!(:key) { create(:deploy_key, public: true) }
      let!(:deploy_keys_project) { create(:deploy_keys_project, deploy_key: key, project: project) }
2279

2280 2281
      it 'does not remove the key' do
        project.remove_private_deploy_keys
2282

2283 2284
        expect(project.deploy_keys).to include(key)
      end
2285 2286
    end
  end
2287

2288 2289
  describe '#remove_pages' do
    let(:project) { create(:project) }
2290
    let(:namespace) { project.namespace }
2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301
    let(:pages_path) { project.pages_path }

    around do |example|
      FileUtils.mkdir_p(pages_path)
      begin
        example.run
      ensure
        FileUtils.rm_rf(pages_path)
      end
    end

2302 2303 2304 2305 2306 2307 2308 2309
    it 'removes the pages directory' do
      expect_any_instance_of(Projects::UpdatePagesConfigurationService).to receive(:execute)
      expect_any_instance_of(Gitlab::PagesTransfer).to receive(:rename_project).and_return(true)
      expect(PagesWorker).to receive(:perform_in).with(5.minutes, :remove, namespace.full_path, anything)

      project.remove_pages
    end

2310 2311 2312 2313 2314 2315 2316 2317
    it 'is a no-op when there is no namespace' do
      project.update_column(:namespace_id, nil)

      expect_any_instance_of(Projects::UpdatePagesConfigurationService).not_to receive(:execute)
      expect_any_instance_of(Gitlab::PagesTransfer).not_to receive(:rename_project)

      project.remove_pages
    end
2318 2319 2320 2321 2322 2323

    it 'is run when the project is destroyed' do
      expect(project).to receive(:remove_pages).and_call_original

      project.destroy
    end
2324 2325
  end

2326 2327 2328 2329 2330 2331 2332 2333 2334
  describe '#forks_count' do
    it 'returns the number of forks' do
      project = build(:project)

      allow(project.forks).to receive(:count).and_return(1)

      expect(project.forks_count).to eq(1)
    end
  end
2335 2336 2337 2338 2339

  context 'legacy storage' do
    let(:project) { create(:project, :repository) }
    let(:gitlab_shell) { Gitlab::Shell.new }

2340 2341 2342 2343
    before do
      allow(project).to receive(:gitlab_shell).and_return(gitlab_shell)
    end

2344 2345 2346 2347 2348 2349 2350 2351 2352 2353 2354 2355
    describe '#base_dir' do
      it 'returns base_dir based on namespace only' do
        expect(project.base_dir).to eq(project.namespace.full_path)
      end
    end

    describe '#disk_path' do
      it 'returns disk_path based on namespace and project path' do
        expect(project.disk_path).to eq("#{project.namespace.full_path}/#{project.path}")
      end
    end

2356
    describe '#ensure_storage_path_exists' do
2357 2358 2359
      it 'delegates to gitlab_shell to ensure namespace is created' do
        expect(gitlab_shell).to receive(:add_namespace).with(project.repository_storage_path, project.base_dir)

2360
        project.ensure_storage_path_exists
2361 2362 2363
      end
    end

2364 2365 2366 2367 2368 2369 2370 2371
    describe '#legacy_storage?' do
      it 'returns true when storage_version is nil' do
        project = build(:project)

        expect(project.legacy_storage?).to be_truthy
      end
    end

2372 2373 2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402 2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418
    describe '#rename_repo' do
      before do
        # Project#gitlab_shell returns a new instance of Gitlab::Shell on every
        # call. This makes testing a bit easier.
        allow(project).to receive(:gitlab_shell).and_return(gitlab_shell)
        allow(project).to receive(:previous_changes).and_return('path' => ['foo'])
      end

      it 'renames a repository' do
        stub_container_registry_config(enabled: false)

        expect(gitlab_shell).to receive(:mv_repository)
          .ordered
          .with(project.repository_storage_path, "#{project.namespace.full_path}/foo", "#{project.full_path}")
          .and_return(true)

        expect(gitlab_shell).to receive(:mv_repository)
          .ordered
          .with(project.repository_storage_path, "#{project.namespace.full_path}/foo.wiki", "#{project.full_path}.wiki")
          .and_return(true)

        expect_any_instance_of(SystemHooksService)
          .to receive(:execute_hooks_for)
            .with(project, :rename)

        expect_any_instance_of(Gitlab::UploadsTransfer)
          .to receive(:rename_project)
            .with('foo', project.path, project.namespace.full_path)

        expect(project).to receive(:expire_caches_before_rename)

        expect(project).to receive(:expires_full_path_cache)

        project.rename_repo
      end

      context 'container registry with images' do
        let(:container_repository) { create(:container_repository) }

        before do
          stub_container_registry_config(enabled: true)
          stub_container_registry_tags(repository: :any, tags: ['tag'])
          project.container_repositories << container_repository
        end

        subject { project.rename_repo }

2419
        it { expect { subject }.to raise_error(StandardError) }
2420 2421
      end
    end
2422 2423 2424 2425 2426 2427

    describe '#pages_path' do
      it 'returns a path where pages are stored' do
        expect(project.pages_path).to eq(File.join(Settings.pages.path, project.namespace.full_path, project.path))
      end
    end
2428 2429 2430
  end

  context 'hashed storage' do
2431
    let(:project) { create(:project, :repository) }
2432 2433 2434 2435
    let(:gitlab_shell) { Gitlab::Shell.new }
    let(:hash) { '6b86b273ff34fce19d6b804eff5a3f5747ada4eaa22f1d49c01e52ddb7875b4b' }

    before do
2436
      stub_application_setting(hashed_storage_enabled: true)
2437
      allow(Digest::SHA2).to receive(:hexdigest) { hash }
2438
      allow(project).to receive(:gitlab_shell).and_return(gitlab_shell)
2439 2440 2441 2442
    end

    describe '#base_dir' do
      it 'returns base_dir based on hash of project id' do
2443
        expect(project.base_dir).to eq('@hashed/6b/86')
2444 2445 2446 2447
      end
    end

    describe '#disk_path' do
2448
      it 'returns disk_path based on hash of project id' do
2449
        hashed_path = '@hashed/6b/86/6b86b273ff34fce19d6b804eff5a3f5747ada4eaa22f1d49c01e52ddb7875b4b'
2450 2451 2452 2453 2454

        expect(project.disk_path).to eq(hashed_path)
      end
    end

2455
    describe '#ensure_storage_path_exists' do
2456
      it 'delegates to gitlab_shell to ensure namespace is created' do
2457
        expect(gitlab_shell).to receive(:add_namespace).with(project.repository_storage_path, '@hashed/6b/86')
2458

2459
        project.ensure_storage_path_exists
2460 2461 2462 2463 2464 2465 2466 2467 2468 2469 2470 2471 2472 2473 2474 2475 2476 2477 2478 2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489 2490 2491 2492 2493 2494 2495 2496 2497 2498 2499 2500 2501
      end
    end

    describe '#rename_repo' do
      before do
        # Project#gitlab_shell returns a new instance of Gitlab::Shell on every
        # call. This makes testing a bit easier.
        allow(project).to receive(:gitlab_shell).and_return(gitlab_shell)
        allow(project).to receive(:previous_changes).and_return('path' => ['foo'])
      end

      it 'renames a repository' do
        stub_container_registry_config(enabled: false)

        expect(gitlab_shell).not_to receive(:mv_repository)

        expect_any_instance_of(SystemHooksService)
          .to receive(:execute_hooks_for)
            .with(project, :rename)

        expect_any_instance_of(Gitlab::UploadsTransfer)
          .to receive(:rename_project)
            .with('foo', project.path, project.namespace.full_path)

        expect(project).to receive(:expire_caches_before_rename)

        expect(project).to receive(:expires_full_path_cache)

        project.rename_repo
      end

      context 'container registry with images' do
        let(:container_repository) { create(:container_repository) }

        before do
          stub_container_registry_config(enabled: true)
          stub_container_registry_tags(repository: :any, tags: ['tag'])
          project.container_repositories << container_repository
        end

        subject { project.rename_repo }

2502
        it { expect { subject }.to raise_error(StandardError) }
2503 2504
      end
    end
2505 2506 2507 2508 2509 2510

    describe '#pages_path' do
      it 'returns a path where pages are stored' do
        expect(project.pages_path).to eq(File.join(Settings.pages.path, project.namespace.full_path, project.path))
      end
    end
2511
  end
2512 2513 2514 2515 2516 2517 2518 2519 2520 2521 2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537 2538 2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555 2556 2557 2558 2559 2560 2561 2562 2563 2564 2565 2566 2567 2568 2569 2570 2571 2572 2573 2574 2575 2576 2577 2578 2579 2580 2581 2582 2583 2584 2585 2586 2587 2588 2589 2590 2591 2592 2593 2594 2595 2596 2597 2598 2599 2600 2601 2602 2603 2604 2605 2606 2607 2608 2609

  describe '#has_ci?' do
    set(:project) { create(:project) }
    let(:repository) { double }

    before do
      expect(project).to receive(:repository) { repository }
    end

    context 'when has .gitlab-ci.yml' do
      before do
        expect(repository).to receive(:gitlab_ci_yml) { 'content' }
      end

      it "CI is available" do
        expect(project).to have_ci
      end
    end

    context 'when there is no .gitlab-ci.yml' do
      before do
        expect(repository).to receive(:gitlab_ci_yml) { nil }
      end

      it "CI is not available" do
        expect(project).not_to have_ci
      end

      context 'when auto devops is enabled' do
        before do
          stub_application_setting(auto_devops_enabled: true)
        end

        it "CI is available" do
          expect(project).to have_ci
        end
      end
    end
  end

  describe '#auto_devops_enabled?' do
    set(:project) { create(:project) }

    subject { project.auto_devops_enabled? }

    context 'when enabled in settings' do
      before do
        stub_application_setting(auto_devops_enabled: true)
      end

      it 'auto devops is implicitly enabled' do
        expect(project.auto_devops).to be_nil
        expect(project).to be_auto_devops_enabled
      end

      context 'when explicitly enabled' do
        before do
          create(:project_auto_devops, project: project)
        end

        it "auto devops is enabled" do
          expect(project).to be_auto_devops_enabled
        end
      end

      context 'when explicitly disabled' do
        before do
          create(:project_auto_devops, project: project, enabled: false)
        end

        it "auto devops is disabled" do
          expect(project).not_to be_auto_devops_enabled
        end
      end
    end

    context 'when disabled in settings' do
      before do
        stub_application_setting(auto_devops_enabled: false)
      end

      it 'auto devops is implicitly disabled' do
        expect(project.auto_devops).to be_nil
        expect(project).not_to be_auto_devops_enabled
      end

      context 'when explicitly enabled' do
        before do
          create(:project_auto_devops, project: project)
        end

        it "auto devops is enabled" do
          expect(project).to be_auto_devops_enabled
        end
      end
    end
  end

2610 2611 2612 2613 2614 2615 2616 2617 2618 2619 2620 2621 2622 2623 2624 2625 2626 2627 2628 2629 2630 2631 2632 2633 2634 2635 2636 2637 2638 2639 2640 2641 2642 2643 2644 2645 2646 2647 2648 2649 2650 2651 2652 2653
  describe '#has_auto_devops_implicitly_disabled?' do
    set(:project) { create(:project) }

    context 'when enabled in settings' do
      before do
        stub_application_setting(auto_devops_enabled: true)
      end

      it 'does not have auto devops implicitly disabled' do
        expect(project).not_to have_auto_devops_implicitly_disabled
      end
    end

    context 'when disabled in settings' do
      before do
        stub_application_setting(auto_devops_enabled: false)
      end

      it 'auto devops is implicitly disabled' do
        expect(project).to have_auto_devops_implicitly_disabled
      end

      context 'when explicitly disabled' do
        before do
          create(:project_auto_devops, project: project, enabled: false)
        end

        it 'does not have auto devops implicitly disabled' do
          expect(project).not_to have_auto_devops_implicitly_disabled
        end
      end

      context 'when explicitly enabled' do
        before do
          create(:project_auto_devops, project: project)
        end

        it 'does not have auto devops implicitly disabled' do
          expect(project).not_to have_auto_devops_implicitly_disabled
        end
      end
    end
  end

2654 2655 2656 2657 2658 2659 2660 2661 2662 2663 2664 2665 2666 2667 2668 2669 2670 2671 2672 2673 2674 2675 2676 2677 2678 2679 2680 2681 2682 2683 2684
  context '#auto_devops_variables' do
    set(:project) { create(:project) }

    subject { project.auto_devops_variables }

    context 'when enabled in settings' do
      before do
        stub_application_setting(auto_devops_enabled: true)
      end

      context 'when domain is empty' do
        before do
          create(:project_auto_devops, project: project, domain: nil)
        end

        it 'variables are empty' do
          is_expected.to be_empty
        end
      end

      context 'when domain is configured' do
        before do
          create(:project_auto_devops, project: project, domain: 'example.com')
        end

        it "variables are not empty" do
          is_expected.not_to be_empty
        end
      end
    end
  end
2685 2686 2687 2688 2689 2690 2691 2692 2693 2694 2695 2696 2697 2698 2699 2700 2701 2702 2703 2704 2705 2706 2707 2708 2709 2710 2711 2712 2713 2714 2715 2716 2717 2718 2719 2720 2721 2722 2723 2724 2725 2726 2727 2728 2729 2730 2731 2732 2733 2734 2735 2736 2737 2738 2739 2740

  describe '#latest_successful_builds_for' do
    let(:project) { build(:project) }

    before do
      allow(project).to receive(:default_branch).and_return('master')
    end

    context 'without a ref' do
      it 'returns a pipeline for the default branch' do
        expect(project)
          .to receive(:latest_successful_pipeline_for_default_branch)

        project.latest_successful_pipeline_for
      end
    end

    context 'with the ref set to the default branch' do
      it 'returns a pipeline for the default branch' do
        expect(project)
          .to receive(:latest_successful_pipeline_for_default_branch)

        project.latest_successful_pipeline_for(project.default_branch)
      end
    end

    context 'with a ref that is not the default branch' do
      it 'returns the latest successful pipeline for the given ref' do
        expect(project.pipelines).to receive(:latest_successful_for).with('foo')

        project.latest_successful_pipeline_for('foo')
      end
    end
  end

  describe '#latest_successful_pipeline_for_default_branch' do
    let(:project) { build(:project) }

    before do
      allow(project).to receive(:default_branch).and_return('master')
    end

    it 'memoizes and returns the latest successful pipeline for the default branch' do
      pipeline = double(:pipeline)

      expect(project.pipelines).to receive(:latest_successful_for)
        .with(project.default_branch)
        .and_return(pipeline)
        .once

      2.times do
        expect(project.latest_successful_pipeline_for_default_branch)
          .to eq(pipeline)
      end
    end
  end
G
gitlabhq 已提交
2741
end