project_spec.rb 106.5 KB
Newer Older
G
gitlabhq 已提交
1 2
require 'spec_helper'

3
describe Project do
4 5
  include ProjectForksHelper

6
  describe 'associations' do
7 8 9 10
    it { is_expected.to belong_to(:group) }
    it { is_expected.to belong_to(:namespace) }
    it { is_expected.to belong_to(:creator).class_name('User') }
    it { is_expected.to have_many(:users) }
U
ubudzisz 已提交
11
    it { is_expected.to have_many(:services) }
12 13 14 15 16
    it { is_expected.to have_many(:events) }
    it { is_expected.to have_many(:merge_requests) }
    it { is_expected.to have_many(:issues) }
    it { is_expected.to have_many(:milestones) }
    it { is_expected.to have_many(:project_members).dependent(:delete_all) }
17
    it { is_expected.to have_many(:users).through(:project_members) }
18 19 20 21
    it { is_expected.to have_many(:requesters).dependent(:delete_all) }
    it { is_expected.to have_many(:notes) }
    it { is_expected.to have_many(:snippets).class_name('ProjectSnippet') }
    it { is_expected.to have_many(:deploy_keys_projects) }
22
    it { is_expected.to have_many(:deploy_keys) }
23 24 25 26 27 28
    it { is_expected.to have_many(:hooks) }
    it { is_expected.to have_many(:protected_branches) }
    it { is_expected.to have_one(:forked_project_link) }
    it { is_expected.to have_one(:slack_service) }
    it { is_expected.to have_one(:microsoft_teams_service) }
    it { is_expected.to have_one(:mattermost_service) }
M
Matt Coleman 已提交
29
    it { is_expected.to have_one(:packagist_service) }
30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56
    it { is_expected.to have_one(:pushover_service) }
    it { is_expected.to have_one(:asana_service) }
    it { is_expected.to have_many(:boards) }
    it { is_expected.to have_one(:campfire_service) }
    it { is_expected.to have_one(:drone_ci_service) }
    it { is_expected.to have_one(:emails_on_push_service) }
    it { is_expected.to have_one(:pipelines_email_service) }
    it { is_expected.to have_one(:irker_service) }
    it { is_expected.to have_one(:pivotaltracker_service) }
    it { is_expected.to have_one(:hipchat_service) }
    it { is_expected.to have_one(:flowdock_service) }
    it { is_expected.to have_one(:assembla_service) }
    it { is_expected.to have_one(:slack_slash_commands_service) }
    it { is_expected.to have_one(:mattermost_slash_commands_service) }
    it { is_expected.to have_one(:gemnasium_service) }
    it { is_expected.to have_one(:buildkite_service) }
    it { is_expected.to have_one(:bamboo_service) }
    it { is_expected.to have_one(:teamcity_service) }
    it { is_expected.to have_one(:jira_service) }
    it { is_expected.to have_one(:redmine_service) }
    it { is_expected.to have_one(:custom_issue_tracker_service) }
    it { is_expected.to have_one(:bugzilla_service) }
    it { is_expected.to have_one(:gitlab_issue_tracker_service) }
    it { is_expected.to have_one(:external_wiki_service) }
    it { is_expected.to have_one(:project_feature) }
    it { is_expected.to have_one(:statistics).class_name('ProjectStatistics') }
    it { is_expected.to have_one(:import_data).class_name('ProjectImportData') }
U
ubudzisz 已提交
57 58
    it { is_expected.to have_one(:last_event).class_name('Event') }
    it { is_expected.to have_one(:forked_from_project).through(:forked_project_link) }
Z
Zeger-Jan van de Weg 已提交
59
    it { is_expected.to have_one(:auto_devops).class_name('ProjectAutoDevops') }
K
Kamil Trzcinski 已提交
60
    it { is_expected.to have_many(:commit_statuses) }
61
    it { is_expected.to have_many(:pipelines) }
62
    it { is_expected.to have_many(:builds) }
63
    it { is_expected.to have_many(:build_trace_section_names)}
64 65
    it { is_expected.to have_many(:runner_projects) }
    it { is_expected.to have_many(:runners) }
K
Kamil Trzcinski 已提交
66
    it { is_expected.to have_many(:active_runners) }
67 68
    it { is_expected.to have_many(:variables) }
    it { is_expected.to have_many(:triggers) }
K
Kamil Trzcinski 已提交
69
    it { is_expected.to have_many(:pages_domains) }
70 71 72 73 74 75 76 77 78
    it { is_expected.to have_many(:labels).class_name('ProjectLabel') }
    it { is_expected.to have_many(:users_star_projects) }
    it { is_expected.to have_many(:environments) }
    it { is_expected.to have_many(:deployments) }
    it { is_expected.to have_many(:todos) }
    it { is_expected.to have_many(:releases) }
    it { is_expected.to have_many(:lfs_objects_projects) }
    it { is_expected.to have_many(:project_group_links) }
    it { is_expected.to have_many(:notification_settings).dependent(:delete_all) }
U
ubudzisz 已提交
79
    it { is_expected.to have_many(:forks).through(:forked_project_links) }
80
    it { is_expected.to have_many(:uploads).dependent(:destroy) }
81
    it { is_expected.to have_many(:pipeline_schedules) }
82
    it { is_expected.to have_many(:members_and_requesters) }
M
Matija Čupić 已提交
83
    it { is_expected.to have_many(:clusters) }
84
    it { is_expected.to have_many(:custom_attributes).class_name('ProjectCustomAttribute') }
85
    it { is_expected.to have_many(:project_badges).class_name('ProjectBadge') }
86
    it { is_expected.to have_many(:lfs_file_locks) }
87

F
Felipe Artur 已提交
88 89
    context 'after initialized' do
      it "has a project_feature" do
90
        expect(described_class.new.project_feature).to be_present
91 92 93
      end
    end

94
    describe '#members & #requesters' do
95
      let(:project) { create(:project, :public, :access_requestable) }
96 97 98 99
      let(:requester) { create(:user) }
      let(:developer) { create(:user) }
      before do
        project.request_access(requester)
100
        project.add_developer(developer)
101 102
      end

103 104
      it_behaves_like 'members and requesters associations' do
        let(:namespace) { project }
105 106
      end
    end
107 108 109 110 111

    describe '#boards' do
      it 'raises an error when attempting to add more than one board to the project' do
        subject.boards.build

112
        expect { subject.boards.build }.to raise_error(Project::BoardLimitExceeded, 'Number of permitted boards exceeded')
113 114 115
        expect(subject.boards.size).to eq 1
      end
    end
G
gitlabhq 已提交
116 117
  end

118 119 120 121 122 123 124 125
  describe 'modules' do
    subject { described_class }

    it { is_expected.to include_module(Gitlab::ConfigHelper) }
    it { is_expected.to include_module(Gitlab::ShellAdapter) }
    it { is_expected.to include_module(Gitlab::VisibilityLevel) }
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
126 127
  end

128
  describe 'validation' do
129
    let!(:project) { create(:project) }
130

131 132
    it { is_expected.to validate_presence_of(:name) }
    it { is_expected.to validate_uniqueness_of(:name).scoped_to(:namespace_id) }
133
    it { is_expected.to validate_length_of(:name).is_at_most(255) }
134

135
    it { is_expected.to validate_presence_of(:path) }
136 137 138 139
    it { is_expected.to validate_length_of(:path).is_at_most(255) }

    it { is_expected.to validate_length_of(:description).is_at_most(2000) }

140 141 142
    it { is_expected.to validate_length_of(:ci_config_path).is_at_most(255) }
    it { is_expected.to allow_value('').for(:ci_config_path) }
    it { is_expected.not_to allow_value('test/../foo').for(:ci_config_path) }
143
    it { is_expected.not_to allow_value('/test/foo').for(:ci_config_path) }
144

145
    it { is_expected.to validate_presence_of(:creator) }
146

147
    it { is_expected.to validate_presence_of(:namespace) }
148

149
    it { is_expected.to validate_presence_of(:repository_storage) }
150

151
    it 'does not allow new projects beyond user limits' do
152
      project2 = build(:project)
153 154
      allow(project2).to receive(:creator).and_return(double(can_create_project?: false, projects_limit: 0).as_null_object)
      expect(project2).not_to be_valid
P
Phil Hughes 已提交
155
      expect(project2.errors[:limit_reached].first).to match(/Personal project creation is not allowed/)
156
    end
157 158 159

    describe 'wiki path conflict' do
      context "when the new path has been used by the wiki of other Project" do
160
        it 'has an error on the name attribute' do
161
          new_project = build_stubbed(:project, namespace_id: project.namespace_id, path: "#{project.path}.wiki")
162 163 164 165 166 167 168

          expect(new_project).not_to be_valid
          expect(new_project.errors[:name].first).to eq('has already been taken')
        end
      end

      context "when the new wiki path has been used by the path of other Project" do
169
        it 'has an error on the name attribute' do
170 171
          project_with_wiki_suffix = create(:project, path: 'foo.wiki')
          new_project = build_stubbed(:project, namespace_id: project_with_wiki_suffix.namespace_id, path: 'foo')
172 173 174 175 176 177

          expect(new_project).not_to be_valid
          expect(new_project.errors[:name].first).to eq('has already been taken')
        end
      end
    end
178

179
    context 'repository storages inclusion' do
180
      let(:project2) { build(:project, repository_storage: 'missing') }
181 182

      before do
183
        storages = { 'custom' => { 'path' => 'tmp/tests/custom_repositories' } }
184 185 186
        allow(Gitlab.config.repositories).to receive(:storages).and_return(storages)
      end

187
      it "does not allow repository storages that don't match a label in the configuration" do
188 189 190 191
        expect(project2).not_to be_valid
        expect(project2.errors[:repository_storage].first).to match(/is not included in the list/)
      end
    end
192

193
    it 'does not allow an invalid URI as import_url' do
194
      project2 = build(:project, import_url: 'invalid://')
J
James Lopez 已提交
195 196 197 198

      expect(project2).not_to be_valid
    end

199
    it 'does allow a valid URI as import_url' do
200
      project2 = build(:project, import_url: 'ssh://test@gitlab.com/project.git')
J
James Lopez 已提交
201

202 203
      expect(project2).to be_valid
    end
204

205
    it 'allows an empty URI' do
206
      project2 = build(:project, import_url: '')
207

208
      expect(project2).to be_valid
209 210 211
    end

    it 'does not produce import data on an empty URI' do
212
      project2 = build(:project, import_url: '')
213 214 215 216 217

      expect(project2.import_data).to be_nil
    end

    it 'does not produce import data on an invalid URI' do
218
      project2 = build(:project, import_url: 'test://')
219 220 221

      expect(project2.import_data).to be_nil
    end
222

D
Douwe Maan 已提交
223
    it "does not allow blocked import_url localhost" do
224
      project2 = build(:project, import_url: 'http://localhost:9000/t.git')
D
Douwe Maan 已提交
225 226 227 228 229 230

      expect(project2).to be_invalid
      expect(project2.errors[:import_url]).to include('imports are not allowed from that URL')
    end

    it "does not allow blocked import_url port" do
231
      project2 = build(:project, import_url: 'http://github.com:25/t.git')
D
Douwe Maan 已提交
232 233 234 235 236

      expect(project2).to be_invalid
      expect(project2.errors[:import_url]).to include('imports are not allowed from that URL')
    end

237 238
    describe 'project pending deletion' do
      let!(:project_pending_deletion) do
239
        create(:project,
240 241 242
               pending_delete: true)
      end
      let(:new_project) do
243
        build(:project,
244 245 246 247 248 249 250 251 252 253 254 255
              name: project_pending_deletion.name,
              namespace: project_pending_deletion.namespace)
      end

      before do
        new_project.validate
      end

      it 'contains errors related to the project being deleted' do
        expect(new_project.errors.full_messages.first).to eq('The project is still being deleted. Please try again later.')
      end
    end
256 257 258

    describe 'path validation' do
      it 'allows paths reserved on the root namespace' do
259
        project = build(:project, path: 'api')
260 261 262 263 264

        expect(project).to be_valid
      end

      it 'rejects paths reserved on another level' do
265
        project = build(:project, path: 'tree')
266 267 268

        expect(project).not_to be_valid
      end
269 270 271

      it 'rejects nested paths' do
        parent = create(:group, :nested, path: 'environments')
272
        project = build(:project, path: 'folders', namespace: parent)
273 274 275

        expect(project).not_to be_valid
      end
276 277 278

      it 'allows a reserved group name' do
        parent = create(:group)
279
        project = build(:project, path: 'avatar', namespace: parent)
280 281 282

        expect(project).to be_valid
      end
283 284 285 286 287 288

      it 'allows a path ending in a period' do
        project = build(:project, path: 'foo.')

        expect(project).to be_valid
      end
289
    end
G
gitlabhq 已提交
290
  end
291

K
Kamil Trzcinski 已提交
292
  describe 'project token' do
293
    it 'sets an random token if none provided' do
294
      project = FactoryBot.create :project, runners_token: ''
K
Kamil Trzcinski 已提交
295
      expect(project.runners_token).not_to eq('')
K
Kamil Trzcinski 已提交
296 297
    end

U
ubudzisz 已提交
298
    it 'does not set an random token if one provided' do
299
      project = FactoryBot.create :project, runners_token: 'my-token'
K
Kamil Trzcinski 已提交
300
      expect(project.runners_token).to eq('my-token')
K
Kamil Trzcinski 已提交
301 302
    end
  end
G
gitlabhq 已提交
303

304
  describe 'Respond to' do
305 306 307 308 309
    it { is_expected.to respond_to(:url_to_repo) }
    it { is_expected.to respond_to(:repo_exists?) }
    it { is_expected.to respond_to(:execute_hooks) }
    it { is_expected.to respond_to(:owner) }
    it { is_expected.to respond_to(:path_with_namespace) }
310
    it { is_expected.to respond_to(:full_path) }
G
gitlabhq 已提交
311 312
  end

313
  describe 'delegation' do
314 315 316 317 318 319
    [:add_guest, :add_reporter, :add_developer, :add_master, :add_user, :add_users].each do |method|
      it { is_expected.to delegate_method(method).to(:team) }
    end

    it { is_expected.to delegate_method(:members).to(:team).with_prefix(true) }
    it { is_expected.to delegate_method(:name).to(:owner).with_prefix(true).with_arguments(allow_nil: true) }
320 321
  end

322
  describe '#to_reference' do
323
    let(:owner)     { create(:user, name: 'Gitlab') }
324
    let(:namespace) { create(:namespace, path: 'sample-namespace', owner: owner) }
325
    let(:project)   { create(:project, path: 'sample-project', namespace: namespace) }
326
    let(:group)     { create(:group, name: 'Group', path: 'sample-group', owner: owner) }
327

328
    context 'when nil argument' do
329 330 331 332 333
      it 'returns nil' do
        expect(project.to_reference).to be_nil
      end
    end

334
    context 'when full is true' do
335
      it 'returns complete path to the project' do
336 337 338
        expect(project.to_reference(full: true)).to          eq 'sample-namespace/sample-project'
        expect(project.to_reference(project, full: true)).to eq 'sample-namespace/sample-project'
        expect(project.to_reference(group, full: true)).to   eq 'sample-namespace/sample-project'
339 340 341 342 343 344 345 346 347 348
      end
    end

    context 'when same project argument' do
      it 'returns nil' do
        expect(project.to_reference(project)).to be_nil
      end
    end

    context 'when cross namespace project argument' do
349
      let(:another_namespace_project) { create(:project, name: 'another-project') }
350 351 352 353 354 355 356

      it 'returns complete path to the project' do
        expect(project.to_reference(another_namespace_project)).to eq 'sample-namespace/sample-project'
      end
    end

    context 'when same namespace / cross-project argument' do
357
      let(:another_project) { create(:project, namespace: namespace) }
358

359
      it 'returns path to the project' do
360 361 362
        expect(project.to_reference(another_project)).to eq 'sample-project'
      end
    end
363

364 365
    context 'when different namespace / cross-project argument' do
      let(:another_namespace) { create(:namespace, path: 'another-namespace', owner: owner) }
366
      let(:another_project)   { create(:project, path: 'another-project', namespace: another_namespace) }
367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383

      it 'returns full path to the project' do
        expect(project.to_reference(another_project)).to eq 'sample-namespace/sample-project'
      end
    end

    context 'when argument is a namespace' do
      context 'with same project path' do
        it 'returns path to the project' do
          expect(project.to_reference(namespace)).to eq 'sample-project'
        end
      end

      context 'with different project path' do
        it 'returns full path to the project' do
          expect(project.to_reference(group)).to eq 'sample-namespace/sample-project'
        end
384 385
      end
    end
386 387 388 389 390
  end

  describe '#to_human_reference' do
    let(:owner) { create(:user, name: 'Gitlab') }
    let(:namespace) { create(:namespace, name: 'Sample namespace', owner: owner) }
391
    let(:project) { create(:project, name: 'Sample project', namespace: namespace) }
392 393 394 395 396 397 398 399 400 401 402 403 404 405

    context 'when nil argument' do
      it 'returns nil' do
        expect(project.to_human_reference).to be_nil
      end
    end

    context 'when same project argument' do
      it 'returns nil' do
        expect(project.to_human_reference(project)).to be_nil
      end
    end

    context 'when cross namespace project argument' do
406
      let(:another_namespace_project) { create(:project, name: 'another-project') }
407 408 409 410 411 412 413

      it 'returns complete name with namespace of the project' do
        expect(project.to_human_reference(another_namespace_project)).to eq 'Gitlab / Sample project'
      end
    end

    context 'when same namespace / cross-project argument' do
414
      let(:another_project) { create(:project, namespace: namespace) }
415 416 417 418

      it 'returns name of the project' do
        expect(project.to_human_reference(another_project)).to eq 'Sample project'
      end
419 420 421
    end
  end

V
Valery Sizov 已提交
422
  describe '#merge_method' do
423 424 425 426 427 428 429
    using RSpec::Parameterized::TableSyntax

    where(:ff, :rebase, :method) do
      true  | true  | :ff
      true  | false | :ff
      false | true  | :rebase_merge
      false | false | :merge
V
Valery Sizov 已提交
430 431
    end

432 433 434 435 436 437
    with_them do
      let(:project) { build(:project, merge_requests_rebase_enabled: rebase, merge_requests_ff_only_enabled: ff) }

      subject { project.merge_method }

      it { is_expected.to eq(method) }
V
Valery Sizov 已提交
438 439 440
    end
  end

441
  describe '#repository_storage_path' do
442
    let(:project) { create(:project) }
443 444

    it 'returns the repository storage path' do
445
      expect(Dir.exist?(project.repository_storage_path)).to be(true)
446 447 448
    end
  end

449
  it 'returns valid url to repo' do
450
    project = described_class.new(path: 'somewhere')
451
    expect(project.url_to_repo).to eq(Gitlab.config.gitlab_shell.ssh_path_prefix + 'somewhere.git')
G
gitlabhq 已提交
452 453
  end

D
Douwe Maan 已提交
454
  describe "#web_url" do
455
    let(:project) { create(:project, path: "somewhere") }
D
Douwe Maan 已提交
456 457

    it 'returns the full web URL for this repo' do
458
      expect(project.web_url).to eq("#{Gitlab.config.gitlab.url}/#{project.namespace.full_path}/somewhere")
D
Douwe Maan 已提交
459
    end
A
Ariejan de Vroom 已提交
460 461
  end

J
Jan Provaznik 已提交
462
  describe "#new_issuable_address" do
463
    let(:project) { create(:project, path: "somewhere") }
464 465
    let(:user) { create(:user) }

466 467 468 469 470 471
    context 'incoming email enabled' do
      before do
        stub_incoming_email_setting(enabled: true, address: "p+%{key}@gl.ab")
      end

      it 'returns the address to create a new issue' do
472
        address = "p+#{project.full_path}+#{user.incoming_email_token}@gl.ab"
473

J
Jan Provaznik 已提交
474 475 476 477 478 479 480
        expect(project.new_issuable_address(user, 'issue')).to eq(address)
      end

      it 'returns the address to create a new merge request' do
        address = "p+#{project.full_path}+merge-request+#{user.incoming_email_token}@gl.ab"

        expect(project.new_issuable_address(user, 'merge_request')).to eq(address)
481 482 483 484 485 486 487
      end
    end

    context 'incoming email disabled' do
      before do
        stub_incoming_email_setting(enabled: false)
      end
488

489
      it 'returns nil' do
J
Jan Provaznik 已提交
490 491 492 493 494
        expect(project.new_issuable_address(user, 'issue')).to be_nil
      end

      it 'returns nil' do
        expect(project.new_issuable_address(user, 'merge_request')).to be_nil
495
      end
496 497 498
    end
  end

499
  describe 'last_activity methods' do
S
Stan Hu 已提交
500 501
    let(:timestamp) { 2.hours.ago }
    # last_activity_at gets set to created_at upon creation
502
    let(:project) { create(:project, created_at: timestamp, updated_at: timestamp) }
G
gitlabhq 已提交
503

504
    describe 'last_activity' do
505
      it 'alias last_activity to last_event' do
506
        last_event = create(:event, :closed, project: project)
507

508
        expect(project.last_activity).to eq(last_event)
509
      end
G
gitlabhq 已提交
510 511
    end

512 513
    describe 'last_activity_date' do
      it 'returns the creation date of the project\'s last event if present' do
514
        new_event = create(:event, :closed, project: project, created_at: Time.now)
515

S
Stan Hu 已提交
516
        project.reload
517
        expect(project.last_activity_at.to_i).to eq(new_event.created_at.to_i)
518
      end
519

520
      it 'returns the project\'s last update date if it has no events' do
521
        expect(project.last_activity_date).to eq(project.updated_at)
522
      end
523 524 525 526 527 528 529 530 531 532 533 534 535 536

      it 'returns the most recent timestamp' do
        project.update_attributes(updated_at: nil,
                                  last_activity_at: timestamp,
                                  last_repository_updated_at: timestamp - 1.hour)

        expect(project.last_activity_date).to eq(timestamp)

        project.update_attributes(updated_at: timestamp,
                                  last_activity_at: timestamp - 1.hour,
                                  last_repository_updated_at: nil)

        expect(project.last_activity_date).to eq(timestamp)
      end
537 538
    end
  end
539

540
  describe '#get_issue' do
541
    let(:project) { create(:project) }
S
Stan Hu 已提交
542
    let!(:issue)  { create(:issue, project: project) }
543 544 545
    let(:user)    { create(:user) }

    before do
546
      project.add_developer(user)
547
    end
548 549 550

    context 'with default issues tracker' do
      it 'returns an issue' do
551
        expect(project.get_issue(issue.iid, user)).to eq issue
552 553
      end

S
Stan Hu 已提交
554 555 556 557
      it 'returns count of open issues' do
        expect(project.open_issues_count).to eq(1)
      end

558
      it 'returns nil when no issue found' do
559 560 561 562 563 564
        expect(project.get_issue(999, user)).to be_nil
      end

      it "returns nil when user doesn't have access" do
        user = create(:user)
        expect(project.get_issue(issue.iid, user)).to eq nil
565 566 567 568
      end
    end

    context 'with external issues tracker' do
569
      let!(:internal_issue) { create(:issue, project: project) }
570
      before do
571
        allow(project).to receive(:external_issue_tracker).and_return(true)
572 573
      end

574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610
      context 'when internal issues are enabled' do
        it 'returns interlan issue' do
          issue = project.get_issue(internal_issue.iid, user)

          expect(issue).to be_kind_of(Issue)
          expect(issue.iid).to eq(internal_issue.iid)
          expect(issue.project).to eq(project)
        end

        it 'returns an ExternalIssue when internal issue does not exists' do
          issue = project.get_issue('FOO-1234', user)

          expect(issue).to be_kind_of(ExternalIssue)
          expect(issue.iid).to eq('FOO-1234')
          expect(issue.project).to eq(project)
        end
      end

      context 'when internal issues are disabled' do
        before do
          project.issues_enabled = false
          project.save!
        end

        it 'returns always an External issues' do
          issue = project.get_issue(internal_issue.iid, user)
          expect(issue).to be_kind_of(ExternalIssue)
          expect(issue.iid).to eq(internal_issue.iid.to_s)
          expect(issue.project).to eq(project)
        end

        it 'returns an ExternalIssue when internal issue does not exists' do
          issue = project.get_issue('FOO-1234', user)
          expect(issue).to be_kind_of(ExternalIssue)
          expect(issue.iid).to eq('FOO-1234')
          expect(issue.project).to eq(project)
        end
611 612 613 614 615
      end
    end
  end

  describe '#issue_exists?' do
616
    let(:project) { create(:project) }
617 618 619 620 621 622 623 624 625 626 627 628

    it 'is truthy when issue exists' do
      expect(project).to receive(:get_issue).and_return(double)
      expect(project.issue_exists?(1)).to be_truthy
    end

    it 'is falsey when issue does not exist' do
      expect(project).to receive(:get_issue).and_return(nil)
      expect(project.issue_exists?(1)).to be_falsey
    end
  end

L
Lin Jen-Shin 已提交
629
  describe '#to_param' do
630 631 632
    context 'with namespace' do
      before do
        @group = create :group, name: 'gitlab'
633
        @project = create(:project, name: 'gitlabhq', namespace: @group)
634 635
      end

V
Vinnie Okada 已提交
636
      it { expect(@project.to_param).to eq('gitlabhq') }
637
    end
638 639 640

    context 'with invalid path' do
      it 'returns previous path to keep project suitable for use in URLs when persisted' do
641
        project = create(:project, path: 'gitlab')
642 643 644 645 646 647 648
        project.path = 'foo&bar'

        expect(project).not_to be_valid
        expect(project.to_param).to eq 'gitlab'
      end

      it 'returns current path when new record' do
649
        project = build(:project, path: 'gitlab')
650 651 652 653 654 655
        project.path = 'foo&bar'

        expect(project).not_to be_valid
        expect(project.to_param).to eq 'foo&bar'
      end
    end
656
  end
D
Dmitriy Zaporozhets 已提交
657

L
Lin Jen-Shin 已提交
658
  describe '#repository' do
659
    let(:project) { create(:project, :repository) }
D
Dmitriy Zaporozhets 已提交
660

661
    it 'returns valid repo' do
662
      expect(project.repository).to be_kind_of(Repository)
D
Dmitriy Zaporozhets 已提交
663 664
    end
  end
665

L
Lin Jen-Shin 已提交
666
  describe '#default_issues_tracker?' do
667
    it "is true if used internal tracker" do
668
      project = build(:project)
669

670
      expect(project.default_issues_tracker?).to be_truthy
671 672
    end

673
    it "is false if used other tracker" do
674 675 676 677
      # NOTE: The current nature of this factory requires persistence
      project = create(:redmine_project)

      expect(project.default_issues_tracker?).to be_falsey
678 679 680
    end
  end

681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698
  describe '#empty_repo?' do
    context 'when the repo does not exist' do
      let(:project) { build_stubbed(:project) }

      it 'returns true' do
        expect(project.empty_repo?).to be(true)
      end
    end

    context 'when the repo exists' do
      let(:project) { create(:project, :repository) }
      let(:empty_project) { create(:project, :empty_repo) }

      it { expect(empty_project.empty_repo?).to be(true) }
      it { expect(project.empty_repo?).to be(false) }
    end
  end

L
Lin Jen-Shin 已提交
699
  describe '#external_issue_tracker' do
700
    let(:project) { create(:project) }
701 702 703
    let(:ext_project) { create(:redmine_project) }

    context 'on existing projects with no value for has_external_issue_tracker' do
704
      before do
705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733
        project.update_column(:has_external_issue_tracker, nil)
        ext_project.update_column(:has_external_issue_tracker, nil)
      end

      it 'updates the has_external_issue_tracker boolean' do
        expect do
          project.external_issue_tracker
        end.to change { project.reload.has_external_issue_tracker }.to(false)

        expect do
          ext_project.external_issue_tracker
        end.to change { ext_project.reload.has_external_issue_tracker }.to(true)
      end
    end

    it 'returns nil and does not query services when there is no external issue tracker' do
      expect(project).not_to receive(:services)

      expect(project.external_issue_tracker).to eq(nil)
    end

    it 'retrieves external_issue_tracker querying services and cache it when there is external issue tracker' do
      ext_project.reload # Factory returns a project with changed attributes
      expect(ext_project).to receive(:services).once.and_call_original

      2.times { expect(ext_project.external_issue_tracker).to be_a_kind_of(RedmineService) }
    end
  end

L
Lin Jen-Shin 已提交
734
  describe '#cache_has_external_issue_tracker' do
735
    let(:project) { create(:project, has_external_issue_tracker: nil) }
736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753

    it 'stores true if there is any external_issue_tracker' do
      services = double(:service, external_issue_trackers: [RedmineService.new])
      expect(project).to receive(:services).and_return(services)

      expect do
        project.cache_has_external_issue_tracker
      end.to change { project.has_external_issue_tracker}.to(true)
    end

    it 'stores false if there is no external_issue_tracker' do
      services = double(:service, external_issue_trackers: [])
      expect(project).to receive(:services).and_return(services)

      expect do
        project.cache_has_external_issue_tracker
      end.to change { project.has_external_issue_tracker}.to(false)
    end
T
Toon Claes 已提交
754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791

    it 'does not cache data when in a read-only GitLab instance' do
      allow(Gitlab::Database).to receive(:read_only?) { true }

      expect do
        project.cache_has_external_issue_tracker
      end.not_to change { project.has_external_issue_tracker }
    end
  end

  describe '#cache_has_external_wiki' do
    let(:project) { create(:project, has_external_wiki: nil) }

    it 'stores true if there is any external_wikis' do
      services = double(:service, external_wikis: [ExternalWikiService.new])
      expect(project).to receive(:services).and_return(services)

      expect do
        project.cache_has_external_wiki
      end.to change { project.has_external_wiki}.to(true)
    end

    it 'stores false if there is no external_wikis' do
      services = double(:service, external_wikis: [])
      expect(project).to receive(:services).and_return(services)

      expect do
        project.cache_has_external_wiki
      end.to change { project.has_external_wiki}.to(false)
    end

    it 'does not cache data when in a read-only GitLab instance' do
      allow(Gitlab::Database).to receive(:read_only?) { true }

      expect do
        project.cache_has_external_wiki
      end.not_to change { project.has_external_wiki }
    end
792 793
  end

794
  describe '#has_wiki?' do
795 796 797
    let(:no_wiki_project)       { create(:project, :wiki_disabled, has_external_wiki: false) }
    let(:wiki_enabled_project)  { create(:project) }
    let(:external_wiki_project) { create(:project, has_external_wiki: true) }
798 799 800 801 802 803 804 805

    it 'returns true if project is wiki enabled or has external wiki' do
      expect(wiki_enabled_project).to have_wiki
      expect(external_wiki_project).to have_wiki
      expect(no_wiki_project).not_to have_wiki
    end
  end

806
  describe '#external_wiki' do
807
    let(:project) { create(:project) }
808

809 810 811 812 813
    context 'with an active external wiki' do
      before do
        create(:service, project: project, type: 'ExternalWikiService', active: true)
        project.external_wiki
      end
814

815 816 817
      it 'sets :has_external_wiki as true' do
        expect(project.has_external_wiki).to be(true)
      end
818

819 820
      it 'sets :has_external_wiki as false if an external wiki service is destroyed later' do
        expect(project.has_external_wiki).to be(true)
821

822 823 824 825
        project.services.external_wikis.first.destroy

        expect(project.has_external_wiki).to be(false)
      end
826 827
    end

828 829 830 831
    context 'with an inactive external wiki' do
      before do
        create(:service, project: project, type: 'ExternalWikiService', active: false)
      end
832

833 834 835
      it 'sets :has_external_wiki as false' do
        expect(project.has_external_wiki).to be(false)
      end
836 837
    end

838 839 840 841
    context 'with no external wiki' do
      before do
        project.external_wiki
      end
842

843 844 845 846 847 848 849 850 851 852 853
      it 'sets :has_external_wiki as false' do
        expect(project.has_external_wiki).to be(false)
      end

      it 'sets :has_external_wiki as true if an external wiki service is created later' do
        expect(project.has_external_wiki).to be(false)

        create(:service, project: project, type: 'ExternalWikiService', active: true)

        expect(project.has_external_wiki).to be(true)
      end
854 855 856
    end
  end

857 858
  describe '#star_count' do
    it 'counts stars from multiple users' do
C
Ciro Santilli 已提交
859 860
      user1 = create :user
      user2 = create :user
861
      project = create(:project, :public)
C
Ciro Santilli 已提交
862 863

      expect(project.star_count).to eq(0)
864

C
Ciro Santilli 已提交
865
      user1.toggle_star(project)
866 867
      expect(project.reload.star_count).to eq(1)

C
Ciro Santilli 已提交
868
      user2.toggle_star(project)
869 870 871
      project.reload
      expect(project.reload.star_count).to eq(2)

C
Ciro Santilli 已提交
872
      user1.toggle_star(project)
873 874 875
      project.reload
      expect(project.reload.star_count).to eq(1)

C
Ciro Santilli 已提交
876
      user2.toggle_star(project)
877 878 879 880
      project.reload
      expect(project.reload.star_count).to eq(0)
    end

881
    it 'counts stars on the right project' do
882
      user = create :user
883 884
      project1 = create(:project, :public)
      project2 = create(:project, :public)
885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911

      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project1)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(1)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project1)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project2)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(1)

      user.toggle_star(project2)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)
C
Ciro Santilli 已提交
912 913
    end
  end
914

L
Lin Jen-Shin 已提交
915
  describe '#avatar_type' do
916
    let(:project) { create(:project) }
917

918
    it 'is true if avatar is image' do
919
      project.update_attribute(:avatar, 'uploads/avatar.png')
920
      expect(project.avatar_type).to be_truthy
921 922
    end

923
    it 'is false if avatar is html page' do
924
      project.update_attribute(:avatar, 'uploads/avatar.html')
925
      expect(project.avatar_type).to eq(['only images allowed'])
926 927
    end
  end
S
sue445 已提交
928

L
Lin Jen-Shin 已提交
929
  describe '#avatar_url' do
S
sue445 已提交
930 931
    subject { project.avatar_url }

932
    let(:project) { create(:project) }
S
sue445 已提交
933

934
    context 'when avatar file is uploaded' do
T
Tim Zallmann 已提交
935
      let(:project) { create(:project, :public, :with_avatar) }
S
sue445 已提交
936

937
      it 'shows correct url' do
938 939
        expect(project.avatar_url).to eq(project.avatar.url)
        expect(project.avatar_url(only_path: false)).to eq([Gitlab.config.gitlab.url, project.avatar.url].join)
940
      end
S
sue445 已提交
941 942
    end

943
    context 'when avatar file in git' do
S
sue445 已提交
944 945 946 947
      before do
        allow(project).to receive(:avatar_in_git) { true }
      end

948
      let(:avatar_path) { "/#{project.full_path}/avatar" }
S
sue445 已提交
949

950
      it { is_expected.to eq "http://#{Gitlab.config.gitlab.host}#{avatar_path}" }
S
sue445 已提交
951
    end
952 953

    context 'when git repo is empty' do
954
      let(:project) { create(:project) }
955

956
      it { is_expected.to eq nil }
957
    end
S
sue445 已提交
958
  end
959

960
  describe '#pipeline_for' do
961
    let(:project) { create(:project, :repository) }
962
    let!(:pipeline) { create_pipeline }
K
Kamil Trzcinski 已提交
963

964 965
    shared_examples 'giving the correct pipeline' do
      it { is_expected.to eq(pipeline) }
K
Kamil Trzcinski 已提交
966

967 968
      context 'return latest' do
        let!(:pipeline2) { create_pipeline }
K
Kamil Trzcinski 已提交
969

970
        it { is_expected.to eq(pipeline2) }
K
Kamil Trzcinski 已提交
971
      end
972 973 974 975 976 977 978 979 980 981 982 983 984
    end

    context 'with explicit sha' do
      subject { project.pipeline_for('master', pipeline.sha) }

      it_behaves_like 'giving the correct pipeline'
    end

    context 'with implicit sha' do
      subject { project.pipeline_for('master') }

      it_behaves_like 'giving the correct pipeline'
    end
K
Kamil Trzcinski 已提交
985

986 987 988 989 990
    def create_pipeline
      create(:ci_pipeline,
             project: project,
             ref: 'master',
             sha: project.commit('master').sha)
K
Kamil Trzcinski 已提交
991
    end
992
  end
993

L
Lin Jen-Shin 已提交
994
  describe '#builds_enabled' do
995
    let(:project) { create(:project) }
996

997 998 999
    subject { project.builds_enabled }

    it { expect(project.builds_enabled?).to be_truthy }
1000
  end
Y
Yorick Peterse 已提交
1001

1002
  describe '.with_shared_runners' do
1003
    subject { described_class.with_shared_runners }
1004 1005

    context 'when shared runners are enabled for project' do
1006
      let!(:project) { create(:project, shared_runners_enabled: true) }
1007 1008 1009 1010 1011 1012 1013

      it "returns a project" do
        is_expected.to eq([project])
      end
    end

    context 'when shared runners are disabled for project' do
1014
      let!(:project) { create(:project, shared_runners_enabled: false) }
1015 1016 1017 1018 1019 1020 1021

      it "returns an empty array" do
        is_expected.to be_empty
      end
    end
  end

1022
  describe '.cached_count', :use_clean_rails_memory_store_caching do
1023
    let(:group)     { create(:group, :public) }
1024 1025
    let!(:project1) { create(:project, :public, group: group) }
    let!(:project2) { create(:project, :public, group: group) }
1026 1027

    it 'returns total project count' do
1028
      expect(described_class).to receive(:count).once.and_call_original
1029 1030

      3.times do
1031
        expect(described_class.cached_count).to eq(2)
1032 1033 1034 1035
      end
    end
  end

Y
Yorick Peterse 已提交
1036
  describe '.trending' do
F
Felipe Artur 已提交
1037
    let(:group)    { create(:group, :public) }
1038 1039
    let(:project1) { create(:project, :public, group: group) }
    let(:project2) { create(:project, :public, group: group) }
Y
Yorick Peterse 已提交
1040 1041 1042 1043 1044 1045 1046 1047

    before do
      2.times do
        create(:note_on_commit, project: project1)
      end

      create(:note_on_commit, project: project2)

Y
Yorick Peterse 已提交
1048
      TrendingProject.refresh!
Y
Yorick Peterse 已提交
1049 1050
    end

Y
Yorick Peterse 已提交
1051
    subject { described_class.trending.to_a }
Y
Yorick Peterse 已提交
1052

Y
Yorick Peterse 已提交
1053 1054
    it 'sorts projects by the amount of notes in descending order' do
      expect(subject).to eq([project1, project2])
Y
Yorick Peterse 已提交
1055
    end
1056 1057 1058 1059 1060 1061 1062 1063

    it 'does not take system notes into account' do
      10.times do
        create(:note_on_commit, project: project2, system: true)
      end

      expect(described_class.trending.to_a).to eq([project1, project2])
    end
Y
Yorick Peterse 已提交
1064
  end
Y
Yorick Peterse 已提交
1065

T
Toon Claes 已提交
1066 1067 1068 1069
  describe '.starred_by' do
    it 'returns only projects starred by the given user' do
      user1 = create(:user)
      user2 = create(:user)
1070 1071 1072
      project1 = create(:project)
      project2 = create(:project)
      create(:project)
T
Toon Claes 已提交
1073 1074 1075
      user1.toggle_star(project1)
      user2.toggle_star(project2)

1076
      expect(described_class.starred_by(user1)).to contain_exactly(project1)
T
Toon Claes 已提交
1077 1078 1079
    end
  end

Y
Yorick Peterse 已提交
1080
  describe '.visible_to_user' do
1081
    let!(:project) { create(:project, :private) }
Y
Yorick Peterse 已提交
1082 1083 1084 1085 1086 1087
    let!(:user)    { create(:user) }

    subject { described_class.visible_to_user(user) }

    describe 'when a user has access to a project' do
      before do
1088
        project.add_user(user, Gitlab::Access::MASTER)
Y
Yorick Peterse 已提交
1089 1090 1091 1092 1093 1094 1095 1096 1097
      end

      it { is_expected.to eq([project]) }
    end

    describe 'when a user does not have access to any projects' do
      it { is_expected.to eq([]) }
    end
  end
K
Kamil Trzcinski 已提交
1098

1099
  context 'repository storage by default' do
1100
    let(:project) { create(:project) }
1101 1102

    before do
1103
      storages = {
1104
        'default' => { 'path' => 'tmp/tests/repositories' },
1105
        'picked'  => { 'path' => 'tmp/tests/repositories' }
1106
      }
1107 1108 1109
      allow(Gitlab.config.repositories).to receive(:storages).and_return(storages)
    end

1110 1111 1112 1113 1114
    it 'picks storage from ApplicationSetting' do
      expect_any_instance_of(ApplicationSetting).to receive(:pick_repository_storage).and_return('picked')

      expect(project.repository_storage).to eq('picked')
    end
1115 1116
  end

K
Kamil Trzcinski 已提交
1117
  context 'shared runners by default' do
1118
    let(:project) { create(:project) }
K
Kamil Trzcinski 已提交
1119 1120 1121 1122

    subject { project.shared_runners_enabled }

    context 'are enabled' do
1123 1124 1125
      before do
        stub_application_setting(shared_runners_enabled: true)
      end
K
Kamil Trzcinski 已提交
1126 1127 1128 1129 1130

      it { is_expected.to be_truthy }
    end

    context 'are disabled' do
1131 1132 1133
      before do
        stub_application_setting(shared_runners_enabled: false)
      end
K
Kamil Trzcinski 已提交
1134 1135 1136 1137 1138

      it { is_expected.to be_falsey }
    end
  end

L
Lin Jen-Shin 已提交
1139
  describe '#any_runners' do
1140
    let(:project) { create(:project, shared_runners_enabled: shared_runners_enabled) }
1141 1142
    let(:specific_runner) { create(:ci_runner) }
    let(:shared_runner) { create(:ci_runner, :shared) }
K
Kamil Trzcinski 已提交
1143 1144 1145

    context 'for shared runners disabled' do
      let(:shared_runners_enabled) { false }
1146

1147
      it 'has no runners available' do
K
Kamil Trzcinski 已提交
1148 1149
        expect(project.any_runners?).to be_falsey
      end
1150

1151
      it 'has a specific runner' do
1152
        project.runners << specific_runner
K
Kamil Trzcinski 已提交
1153 1154
        expect(project.any_runners?).to be_truthy
      end
1155

1156
      it 'has a shared runner, but they are prohibited to use' do
K
Kamil Trzcinski 已提交
1157 1158 1159
        shared_runner
        expect(project.any_runners?).to be_falsey
      end
1160

K
Kamil Trzcinski 已提交
1161
      it 'checks the presence of specific runner' do
1162
        project.runners << specific_runner
K
Kamil Trzcinski 已提交
1163 1164 1165
        expect(project.any_runners? { |runner| runner == specific_runner }).to be_truthy
      end
    end
1166

K
Kamil Trzcinski 已提交
1167 1168
    context 'for shared runners enabled' do
      let(:shared_runners_enabled) { true }
1169

1170
      it 'has a shared runner' do
K
Kamil Trzcinski 已提交
1171 1172 1173 1174 1175 1176 1177 1178 1179 1180
        shared_runner
        expect(project.any_runners?).to be_truthy
      end

      it 'checks the presence of shared runner' do
        shared_runner
        expect(project.any_runners? { |runner| runner == shared_runner }).to be_truthy
      end
    end
  end
1181

1182 1183 1184 1185 1186 1187
  describe '#shared_runners' do
    let!(:runner) { create(:ci_runner, :shared) }

    subject { project.shared_runners }

    context 'when shared runners are enabled for project' do
1188
      let!(:project) { create(:project, shared_runners_enabled: true) }
1189 1190 1191 1192 1193 1194 1195

      it "returns a list of shared runners" do
        is_expected.to eq([runner])
      end
    end

    context 'when shared runners are disabled for project' do
1196
      let!(:project) { create(:project, shared_runners_enabled: false) }
1197 1198 1199 1200 1201 1202 1203

      it "returns a empty list" do
        is_expected.to be_empty
      end
    end
  end

1204
  describe '#visibility_level_allowed?' do
1205
    let(:project) { create(:project, :internal) }
1206 1207 1208 1209 1210 1211 1212 1213

    context 'when checking on non-forked project' do
      it { expect(project.visibility_level_allowed?(Gitlab::VisibilityLevel::PRIVATE)).to be_truthy }
      it { expect(project.visibility_level_allowed?(Gitlab::VisibilityLevel::INTERNAL)).to be_truthy }
      it { expect(project.visibility_level_allowed?(Gitlab::VisibilityLevel::PUBLIC)).to be_truthy }
    end

    context 'when checking on forked project' do
1214 1215
      let(:project)        { create(:project, :internal) }
      let(:forked_project) { create(:project, forked_from_project: project) }
1216 1217 1218 1219 1220

      it { expect(forked_project.visibility_level_allowed?(Gitlab::VisibilityLevel::PRIVATE)).to be_truthy }
      it { expect(forked_project.visibility_level_allowed?(Gitlab::VisibilityLevel::INTERNAL)).to be_truthy }
      it { expect(forked_project.visibility_level_allowed?(Gitlab::VisibilityLevel::PUBLIC)).to be_falsey }
    end
1221
  end
1222

1223
  describe '#pages_deployed?' do
1224
    let(:project) { create :project }
1225 1226 1227 1228

    subject { project.pages_deployed? }

    context 'if public folder does exist' do
1229 1230 1231
      before do
        allow(Dir).to receive(:exist?).with(project.public_pages_path).and_return(true)
      end
1232 1233 1234 1235 1236 1237 1238 1239 1240

      it { is_expected.to be_truthy }
    end

    context "if public folder doesn't exist" do
      it { is_expected.to be_falsey }
    end
  end

1241 1242
  describe '#pages_url' do
    let(:group) { create :group, name: group_name }
1243
    let(:project) { create :project, namespace: group, name: project_name }
1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267
    let(:domain) { 'Example.com' }

    subject { project.pages_url }

    before do
      allow(Settings.pages).to receive(:host).and_return(domain)
      allow(Gitlab.config.pages).to receive(:url).and_return('http://example.com')
    end

    context 'group page' do
      let(:group_name) { 'Group' }
      let(:project_name) { 'group.example.com' }

      it { is_expected.to eq("http://group.example.com") }
    end

    context 'project page' do
      let(:group_name) { 'Group' }
      let(:project_name) { 'Project' }

      it { is_expected.to eq("http://group.example.com/project") }
    end
  end

1268
  describe '.search' do
1269
    let(:project) { create(:project, description: 'kitten mittens') }
1270

1271 1272 1273
    it 'returns projects with a matching name' do
      expect(described_class.search(project.name)).to eq([project])
    end
1274

1275 1276 1277
    it 'returns projects with a partially matching name' do
      expect(described_class.search(project.name[0..2])).to eq([project])
    end
1278

1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306
    it 'returns projects with a matching name regardless of the casing' do
      expect(described_class.search(project.name.upcase)).to eq([project])
    end

    it 'returns projects with a matching description' do
      expect(described_class.search(project.description)).to eq([project])
    end

    it 'returns projects with a partially matching description' do
      expect(described_class.search('kitten')).to eq([project])
    end

    it 'returns projects with a matching description regardless of the casing' do
      expect(described_class.search('KITTEN')).to eq([project])
    end

    it 'returns projects with a matching path' do
      expect(described_class.search(project.path)).to eq([project])
    end

    it 'returns projects with a partially matching path' do
      expect(described_class.search(project.path[0..2])).to eq([project])
    end

    it 'returns projects with a matching path regardless of the casing' do
      expect(described_class.search(project.path.upcase)).to eq([project])
    end

1307
    describe 'with pending_delete project' do
1308
      let(:pending_delete_project) { create(:project, pending_delete: true) }
1309 1310 1311 1312 1313 1314 1315

      it 'shows pending deletion project' do
        search_result = described_class.search(pending_delete_project.name)

        expect(search_result).to eq([pending_delete_project])
      end
    end
1316
  end
1317 1318

  describe '#expire_caches_before_rename' do
1319
    let(:project) { create(:project, :repository) }
1320 1321 1322 1323
    let(:repo)    { double(:repo, exists?: true) }
    let(:wiki)    { double(:wiki, exists?: true) }

    it 'expires the caches of the repository and wiki' do
1324 1325 1326
      allow(Repository).to receive(:new)
        .with('foo', project)
        .and_return(repo)
1327

1328 1329 1330
      allow(Repository).to receive(:new)
        .with('foo.wiki', project)
        .and_return(wiki)
1331

1332 1333
      expect(repo).to receive(:before_delete)
      expect(wiki).to receive(:before_delete)
1334 1335 1336 1337

      project.expire_caches_before_rename('foo')
    end
  end
1338 1339

  describe '.search_by_title' do
1340
    let(:project) { create(:project, name: 'kittens') }
1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353

    it 'returns projects with a matching name' do
      expect(described_class.search_by_title(project.name)).to eq([project])
    end

    it 'returns projects with a partially matching name' do
      expect(described_class.search_by_title('kitten')).to eq([project])
    end

    it 'returns projects with a matching name regardless of the casing' do
      expect(described_class.search_by_title('KITTENS')).to eq([project])
    end
  end
1354 1355 1356 1357 1358

  context 'when checking projects from groups' do
    let(:private_group)    { create(:group, visibility_level: 0)  }
    let(:internal_group)   { create(:group, visibility_level: 10) }

1359 1360
    let(:private_project)  { create :project, :private, group: private_group }
    let(:internal_project) { create :project, :internal, group: internal_group }
1361 1362 1363 1364 1365 1366 1367 1368 1369

    context 'when group is private project can not be internal' do
      it { expect(private_project.visibility_level_allowed?(Gitlab::VisibilityLevel::INTERNAL)).to be_falsey }
    end

    context 'when group is internal project can not be public' do
      it { expect(internal_project.visibility_level_allowed?(Gitlab::VisibilityLevel::PUBLIC)).to be_falsey }
    end
  end
1370

1371
  describe '#create_repository' do
1372
    let(:project) { create(:project, :repository) }
1373 1374 1375 1376 1377 1378 1379 1380
    let(:shell) { Gitlab::Shell.new }

    before do
      allow(project).to receive(:gitlab_shell).and_return(shell)
    end

    context 'using a regular repository' do
      it 'creates the repository' do
1381
        expect(shell).to receive(:add_repository)
J
Jacob Vosmaer 已提交
1382
          .with(project.repository_storage, project.disk_path)
1383
          .and_return(true)
1384 1385 1386 1387 1388 1389 1390

        expect(project.repository).to receive(:after_create)

        expect(project.create_repository).to eq(true)
      end

      it 'adds an error if the repository could not be created' do
1391
        expect(shell).to receive(:add_repository)
J
Jacob Vosmaer 已提交
1392
          .with(project.repository_storage, project.disk_path)
1393
          .and_return(false)
1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410

        expect(project.repository).not_to receive(:after_create)

        expect(project.create_repository).to eq(false)
        expect(project.errors).not_to be_empty
      end
    end

    context 'using a forked repository' do
      it 'does nothing' do
        expect(project).to receive(:forked?).and_return(true)
        expect(shell).not_to receive(:add_repository)

        project.create_repository
      end
    end
  end
1411

1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424
  describe '#ensure_repository' do
    let(:project) { create(:project, :repository) }
    let(:shell) { Gitlab::Shell.new }

    before do
      allow(project).to receive(:gitlab_shell).and_return(shell)
    end

    it 'creates the repository if it not exist' do
      allow(project).to receive(:repository_exists?)
        .and_return(false)

      allow(shell).to receive(:add_repository)
1425
        .with(project.repository_storage_path, project.disk_path)
1426 1427
        .and_return(true)

1428
      expect(project).to receive(:create_repository).with(force: true)
1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440

      project.ensure_repository
    end

    it 'does not create the repository if it exists' do
      allow(project).to receive(:repository_exists?)
        .and_return(true)

      expect(project).not_to receive(:create_repository)

      project.ensure_repository
    end
1441 1442 1443 1444 1445 1446 1447 1448

    it 'creates the repository if it is a fork' do
      expect(project).to receive(:forked?).and_return(true)

      allow(project).to receive(:repository_exists?)
        .and_return(false)

      expect(shell).to receive(:add_repository)
J
Jacob Vosmaer 已提交
1449
        .with(project.repository_storage, project.disk_path)
1450 1451 1452 1453
        .and_return(true)

      project.ensure_repository
    end
1454 1455
  end

1456
  describe '#user_can_push_to_empty_repo?' do
1457
    let(:project) { create(:project) }
1458
    let(:user)    { create(:user) }
1459

1460
    it 'returns false when default_branch_protection is in full protection and user is developer' do
1461
      project.add_developer(user)
1462
      stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_FULL)
1463

1464
      expect(project.user_can_push_to_empty_repo?(user)).to be_falsey
1465 1466
    end

1467
    it 'returns false when default_branch_protection only lets devs merge and user is dev' do
1468
      project.add_developer(user)
1469
      stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_DEV_CAN_MERGE)
1470

1471
      expect(project.user_can_push_to_empty_repo?(user)).to be_falsey
1472 1473
    end

1474
    it 'returns true when default_branch_protection lets devs push and user is developer' do
1475
      project.add_developer(user)
1476
      stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_DEV_CAN_PUSH)
1477

1478 1479
      expect(project.user_can_push_to_empty_repo?(user)).to be_truthy
    end
1480

1481
    it 'returns true when default_branch_protection is unprotected and user is developer' do
1482
      project.add_developer(user)
1483
      stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_NONE)
1484

1485
      expect(project.user_can_push_to_empty_repo?(user)).to be_truthy
1486
    end
1487

1488
    it 'returns true when user is master' do
1489
      project.add_master(user)
1490

1491
      expect(project.user_can_push_to_empty_repo?(user)).to be_truthy
1492
    end
1493 1494 1495 1496 1497 1498 1499

    it 'returns false when the repo is not empty' do
      project.add_master(user)
      expect(project).to receive(:empty_repo?).and_return(false)

      expect(project.user_can_push_to_empty_repo?(user)).to be_falsey
    end
1500 1501
  end

A
Andre Guedes 已提交
1502
  describe '#container_registry_url' do
1503
    let(:project) { create(:project) }
K
Kamil Trzcinski 已提交
1504

A
Andre Guedes 已提交
1505
    subject { project.container_registry_url }
K
Kamil Trzcinski 已提交
1506

1507 1508 1509
    before do
      stub_container_registry_config(**registry_settings)
    end
K
Kamil Trzcinski 已提交
1510 1511 1512

    context 'for enabled registry' do
      let(:registry_settings) do
1513 1514
        { enabled: true,
          host_port: 'example.com' }
K
Kamil Trzcinski 已提交
1515 1516
      end

1517
      it { is_expected.not_to be_nil }
K
Kamil Trzcinski 已提交
1518 1519 1520 1521
    end

    context 'for disabled registry' do
      let(:registry_settings) do
1522
        { enabled: false }
K
Kamil Trzcinski 已提交
1523 1524 1525 1526 1527 1528
      end

      it { is_expected.to be_nil }
    end
  end

1529
  describe '#has_container_registry_tags?' do
1530
    let(:project) { create(:project) }
1531 1532

    context 'when container registry is enabled' do
1533 1534 1535
      before do
        stub_container_registry_config(enabled: true)
      end
1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572

      context 'when tags are present for multi-level registries' do
        before do
          create(:container_repository, project: project, name: 'image')

          stub_container_registry_tags(repository: /image/,
                                       tags: %w[latest rc1])
        end

        it 'should have image tags' do
          expect(project).to have_container_registry_tags
        end
      end

      context 'when tags are present for root repository' do
        before do
          stub_container_registry_tags(repository: project.full_path,
                                       tags: %w[latest rc1 pre1])
        end

        it 'should have image tags' do
          expect(project).to have_container_registry_tags
        end
      end

      context 'when there are no tags at all' do
        before do
          stub_container_registry_tags(repository: :any, tags: [])
        end

        it 'should not have image tags' do
          expect(project).not_to have_container_registry_tags
        end
      end
    end

    context 'when container registry is disabled' do
1573 1574 1575
      before do
        stub_container_registry_config(enabled: false)
      end
1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592

      it 'should not have image tags' do
        expect(project).not_to have_container_registry_tags
      end

      it 'should not check root repository tags' do
        expect(project).not_to receive(:full_path)
        expect(project).not_to have_container_registry_tags
      end

      it 'should iterate through container repositories' do
        expect(project).to receive(:container_repositories)
        expect(project).not_to have_container_registry_tags
      end
    end
  end

1593
  describe '#ci_config_path=' do
1594
    let(:project) { create(:project) }
1595 1596

    it 'sets nil' do
1597
      project.update!(ci_config_path: nil)
1598

1599
      expect(project.ci_config_path).to be_nil
1600 1601 1602
    end

    it 'sets a string' do
1603
      project.update!(ci_config_path: 'foo/.gitlab_ci.yml')
1604

1605
      expect(project.ci_config_path).to eq('foo/.gitlab_ci.yml')
1606 1607
    end

1608 1609
    it 'sets a string but removes all null characters' do
      project.update!(ci_config_path: "f\0oo/\0/.gitlab_ci.yml")
1610

1611
      expect(project.ci_config_path).to eq('foo//.gitlab_ci.yml')
1612 1613 1614
    end
  end

1615
  describe 'Project import job' do
1616
    let(:project) { create(:project, import_url: generate(:url)) }
1617 1618

    before do
S
Stan Hu 已提交
1619
      allow_any_instance_of(Gitlab::Shell).to receive(:import_repository)
1620
        .with(project.repository_storage_path, project.disk_path, project.import_url)
S
Stan Hu 已提交
1621 1622 1623 1624
        .and_return(true)

      expect_any_instance_of(Repository).to receive(:after_import)
        .and_call_original
1625 1626 1627 1628 1629
    end

    it 'imports a project' do
      expect_any_instance_of(RepositoryImportWorker).to receive(:perform).and_call_original

1630
      expect { project.import_schedule }.to change { project.import_jid }
1631 1632 1633 1634
      expect(project.reload.import_status).to eq('finished')
    end
  end

1635 1636
  describe 'project import state transitions' do
    context 'state transition: [:started] => [:finished]' do
L
Lin Jen-Shin 已提交
1637
      let(:after_import_service) { spy(:after_import_service) }
L
Lin Jen-Shin 已提交
1638
      let(:housekeeping_service) { spy(:housekeeping_service) }
1639 1640

      before do
L
Lin Jen-Shin 已提交
1641 1642
        allow(Projects::AfterImportService)
          .to receive(:new) { after_import_service }
L
Lin Jen-Shin 已提交
1643

L
Lin Jen-Shin 已提交
1644
        allow(after_import_service)
L
Lin Jen-Shin 已提交
1645 1646 1647 1648
          .to receive(:execute) { housekeeping_service.execute }

        allow(Projects::HousekeepingService)
          .to receive(:new) { housekeeping_service }
1649 1650
      end

1651 1652 1653 1654 1655 1656 1657
      it 'resets project import_error' do
        error_message = 'Some error'
        mirror = create(:project_empty_repo, :import_started, import_error: error_message)

        expect { mirror.import_finish }.to change { mirror.import_error }.from(error_message).to(nil)
      end

1658 1659 1660 1661 1662
      it 'performs housekeeping when an import of a fresh project is completed' do
        project = create(:project_empty_repo, :import_started, import_type: :github)

        project.import_finish

L
Lin Jen-Shin 已提交
1663
        expect(after_import_service).to have_received(:execute)
1664 1665 1666 1667
        expect(housekeeping_service).to have_received(:execute)
      end

      it 'does not perform housekeeping when project repository does not exist' do
1668
        project = create(:project, :import_started, import_type: :github)
1669 1670 1671 1672 1673 1674 1675

        project.import_finish

        expect(housekeeping_service).not_to have_received(:execute)
      end

      it 'does not perform housekeeping when project does not have a valid import type' do
1676
        project = create(:project, :import_started, import_type: nil)
1677 1678 1679 1680 1681 1682 1683 1684

        project.import_finish

        expect(housekeeping_service).not_to have_received(:execute)
      end
    end
  end

1685
  describe '#latest_successful_builds_for' do
L
Lin Jen-Shin 已提交
1686
    def create_pipeline(status = 'success')
1687
      create(:ci_pipeline, project: project,
L
Lin Jen-Shin 已提交
1688
                           sha: project.commit.sha,
1689
                           ref: project.default_branch,
L
Lin Jen-Shin 已提交
1690
                           status: status)
1691 1692
    end

L
Lin Jen-Shin 已提交
1693 1694 1695
    def create_build(new_pipeline = pipeline, name = 'test')
      create(:ci_build, :success, :artifacts,
             pipeline: new_pipeline,
L
Lin Jen-Shin 已提交
1696
             status: new_pipeline.status,
L
Lin Jen-Shin 已提交
1697
             name: name)
1698 1699
    end

1700
    let(:project) { create(:project, :repository) }
L
Lin Jen-Shin 已提交
1701
    let(:pipeline) { create_pipeline }
L
Lin Jen-Shin 已提交
1702 1703

    context 'with many builds' do
1704
      it 'gives the latest builds from latest pipeline' do
1705 1706
        pipeline1 = create_pipeline
        pipeline2 = create_pipeline
1707
        build1_p2 = create_build(pipeline2, 'test')
1708 1709
        create_build(pipeline1, 'test')
        create_build(pipeline1, 'test2')
1710
        build2_p2 = create_build(pipeline2, 'test2')
L
Lin Jen-Shin 已提交
1711 1712 1713

        latest_builds = project.latest_successful_builds_for

1714
        expect(latest_builds).to contain_exactly(build2_p2, build1_p2)
L
Lin Jen-Shin 已提交
1715 1716
      end
    end
L
Lin Jen-Shin 已提交
1717

L
Lin Jen-Shin 已提交
1718
    context 'with succeeded pipeline' do
L
Lin Jen-Shin 已提交
1719
      let!(:build) { create_build }
1720

L
Lin Jen-Shin 已提交
1721
      context 'standalone pipeline' do
1722 1723 1724 1725 1726 1727 1728 1729
        it 'returns builds for ref for default_branch' do
          builds = project.latest_successful_builds_for

          expect(builds).to contain_exactly(build)
        end

        it 'returns empty relation if the build cannot be found' do
          builds = project.latest_successful_builds_for('TAIL')
1730

1731 1732 1733
          expect(builds).to be_kind_of(ActiveRecord::Relation)
          expect(builds).to be_empty
        end
1734 1735
      end

L
Lin Jen-Shin 已提交
1736
      context 'with some pending pipeline' do
1737
        before do
L
Lin Jen-Shin 已提交
1738
          create_build(create_pipeline('pending'))
1739 1740
        end

L
Lin Jen-Shin 已提交
1741 1742
        it 'gives the latest build from latest pipeline' do
          latest_build = project.latest_successful_builds_for
1743

L
Lin Jen-Shin 已提交
1744
          expect(latest_build).to contain_exactly(build)
1745
        end
1746 1747 1748 1749 1750 1751
      end
    end

    context 'with pending pipeline' do
      before do
        pipeline.update(status: 'pending')
L
Lin Jen-Shin 已提交
1752
        create_build(pipeline)
1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763
      end

      it 'returns empty relation' do
        builds = project.latest_successful_builds_for

        expect(builds).to be_kind_of(ActiveRecord::Relation)
        expect(builds).to be_empty
      end
    end
  end

1764
  describe '#add_import_job' do
1765 1766
    let(:import_jid) { '123' }

1767
    context 'forked' do
1768
      let(:forked_project_link) { create(:forked_project_link, :forked_to_empty_project) }
1769 1770 1771 1772
      let(:forked_from_project) { forked_project_link.forked_from_project }
      let(:project) { forked_project_link.forked_to_project }

      it 'schedules a RepositoryForkWorker job' do
1773 1774 1775
        expect(RepositoryForkWorker).to receive(:perform_async).with(
          project.id,
          forked_from_project.repository_storage_path,
1776
          forked_from_project.disk_path).and_return(import_jid)
1777

1778
        expect(project.add_import_job).to eq(import_jid)
1779 1780 1781 1782 1783
      end
    end

    context 'not forked' do
      it 'schedules a RepositoryImportWorker job' do
1784
        project = create(:project, import_url: generate(:url))
1785

1786 1787
        expect(RepositoryImportWorker).to receive(:perform_async).with(project.id).and_return(import_jid)
        expect(project.add_import_job).to eq(import_jid)
1788 1789 1790 1791
      end
    end
  end

R
Rémy Coutable 已提交
1792
  describe '#gitlab_project_import?' do
1793
    subject(:project) { build(:project, import_type: 'gitlab_project') }
R
Rémy Coutable 已提交
1794 1795 1796 1797 1798

    it { expect(project.gitlab_project_import?).to be true }
  end

  describe '#gitea_import?' do
1799
    subject(:project) { build(:project, import_type: 'gitea') }
R
Rémy Coutable 已提交
1800 1801 1802 1803

    it { expect(project.gitea_import?).to be true }
  end

1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818
  describe '#ancestors_upto', :nested_groups do
    let(:parent) { create(:group) }
    let(:child) { create(:group, parent: parent) }
    let(:child2) { create(:group, parent: child) }
    let(:project) { create(:project, namespace: child2) }

    it 'returns all ancestors when no namespace is given' do
      expect(project.ancestors_upto).to contain_exactly(child2, child, parent)
    end

    it 'includes ancestors upto but excluding the given ancestor' do
      expect(project.ancestors_upto(parent)).to contain_exactly(child2, child)
    end
  end

1819
  describe '#lfs_enabled?' do
1820
    let(:project) { create(:project) }
1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880

    shared_examples 'project overrides group' do
      it 'returns true when enabled in project' do
        project.update_attribute(:lfs_enabled, true)

        expect(project.lfs_enabled?).to be_truthy
      end

      it 'returns false when disabled in project' do
        project.update_attribute(:lfs_enabled, false)

        expect(project.lfs_enabled?).to be_falsey
      end

      it 'returns the value from the namespace, when no value is set in project' do
        expect(project.lfs_enabled?).to eq(project.namespace.lfs_enabled?)
      end
    end

    context 'LFS disabled in group' do
      before do
        project.namespace.update_attribute(:lfs_enabled, false)
        enable_lfs
      end

      it_behaves_like 'project overrides group'
    end

    context 'LFS enabled in group' do
      before do
        project.namespace.update_attribute(:lfs_enabled, true)
        enable_lfs
      end

      it_behaves_like 'project overrides group'
    end

    describe 'LFS disabled globally' do
      shared_examples 'it always returns false' do
        it do
          expect(project.lfs_enabled?).to be_falsey
          expect(project.namespace.lfs_enabled?).to be_falsey
        end
      end

      context 'when no values are set' do
        it_behaves_like 'it always returns false'
      end

      context 'when all values are set to true' do
        before do
          project.namespace.update_attribute(:lfs_enabled, true)
          project.update_attribute(:lfs_enabled, true)
        end

        it_behaves_like 'it always returns false'
      end
    end
  end

1881
  describe '#change_head' do
1882
    let(:project) { create(:project, :repository) }
1883

1884 1885 1886 1887 1888
    it 'returns error if branch does not exist' do
      expect(project.change_head('unexisted-branch')).to be false
      expect(project.errors.size).to eq(1)
    end

1889
    it 'calls the before_change_head and after_change_head methods' do
1890
      expect(project.repository).to receive(:before_change_head)
1891 1892
      expect(project.repository).to receive(:after_change_head)

1893 1894 1895
      project.change_head(project.default_branch)
    end

1896
    it 'creates the new reference with rugged' do
1897 1898
      expect(project.repository.raw_repository).to receive(:write_ref).with('HEAD', "refs/heads/#{project.default_branch}", shell: false)

1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911
      project.change_head(project.default_branch)
    end

    it 'copies the gitattributes' do
      expect(project.repository).to receive(:copy_gitattributes).with(project.default_branch)
      project.change_head(project.default_branch)
    end

    it 'reloads the default branch' do
      expect(project).to receive(:reload_default_branch)
      project.change_head(project.default_branch)
    end
  end
Y
Yorick Peterse 已提交
1912

1913
  context 'forks' do
B
Bob Van Landuyt 已提交
1914 1915
    include ProjectForksHelper

1916 1917 1918 1919 1920
    let(:project) { create(:project, :public) }
    let!(:forked_project) { fork_project(project) }

    describe '#fork_network' do
      it 'includes a fork of the project' do
B
Bob Van Landuyt 已提交
1921
        expect(project.fork_network.projects).to include(forked_project)
1922 1923 1924 1925 1926
      end

      it 'includes a fork of a fork' do
        other_fork = fork_project(forked_project)

B
Bob Van Landuyt 已提交
1927
        expect(project.fork_network.projects).to include(other_fork)
1928 1929 1930 1931 1932
      end

      it 'includes sibling forks' do
        other_fork = fork_project(project)

B
Bob Van Landuyt 已提交
1933
        expect(forked_project.fork_network.projects).to include(other_fork)
1934 1935 1936
      end

      it 'includes the base project' do
B
Bob Van Landuyt 已提交
1937
        expect(forked_project.fork_network.projects).to include(project.reload)
1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963
      end
    end

    describe '#in_fork_network_of?' do
      it 'is true for a real fork' do
        expect(forked_project.in_fork_network_of?(project)).to be_truthy
      end

      it 'is true for a fork of a fork', :postgresql do
        other_fork = fork_project(forked_project)

        expect(other_fork.in_fork_network_of?(project)).to be_truthy
      end

      it 'is true for sibling forks' do
        sibling = fork_project(project)

        expect(sibling.in_fork_network_of?(forked_project)).to be_truthy
      end

      it 'is false when another project is given' do
        other_project = build_stubbed(:project)

        expect(forked_project.in_fork_network_of?(other_project)).to be_falsy
      end
    end
1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976

    describe '#fork_source' do
      let!(:second_fork) { fork_project(forked_project) }

      it 'returns the direct source if it exists' do
        expect(second_fork.fork_source).to eq(forked_project)
      end

      it 'returns the root of the fork network when the directs source was deleted' do
        forked_project.destroy

        expect(second_fork.fork_source).to eq(project)
      end
1977 1978 1979 1980

      it 'returns nil if it is the root of the fork network' do
        expect(project.fork_source).to be_nil
      end
1981
    end
1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999

    describe '#lfs_storage_project' do
      it 'returns self for non-forks' do
        expect(project.lfs_storage_project).to eq project
      end

      it 'returns the fork network root for forks' do
        second_fork = fork_project(forked_project)

        expect(second_fork.lfs_storage_project).to eq project
      end

      it 'returns self when fork_source is nil' do
        expect(forked_project).to receive(:fork_source).and_return(nil)

        expect(forked_project.lfs_storage_project).to eq forked_project
      end
    end
2000 2001
  end

Y
Yorick Peterse 已提交
2002
  describe '#pushes_since_gc' do
2003
    let(:project) { create(:project) }
Y
Yorick Peterse 已提交
2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024

    after do
      project.reset_pushes_since_gc
    end

    context 'without any pushes' do
      it 'returns 0' do
        expect(project.pushes_since_gc).to eq(0)
      end
    end

    context 'with a number of pushes' do
      it 'returns the number of pushes' do
        3.times { project.increment_pushes_since_gc }

        expect(project.pushes_since_gc).to eq(3)
      end
    end
  end

  describe '#increment_pushes_since_gc' do
2025
    let(:project) { create(:project) }
Y
Yorick Peterse 已提交
2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038

    after do
      project.reset_pushes_since_gc
    end

    it 'increments the number of pushes since the last GC' do
      3.times { project.increment_pushes_since_gc }

      expect(project.pushes_since_gc).to eq(3)
    end
  end

  describe '#reset_pushes_since_gc' do
2039
    let(:project) { create(:project) }
Y
Yorick Peterse 已提交
2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052

    after do
      project.reset_pushes_since_gc
    end

    it 'resets the number of pushes since the last GC' do
      3.times { project.increment_pushes_since_gc }

      project.reset_pushes_since_gc

      expect(project.pushes_since_gc).to eq(0)
    end
  end
2053

2054 2055
  describe '#deployment_variables' do
    context 'when project has no deployment service' do
2056
      let(:project) { create(:project) }
2057 2058 2059 2060 2061 2062 2063

      it 'returns an empty array' do
        expect(project.deployment_variables).to eq []
      end
    end

    context 'when project has a deployment service' do
2064
      shared_examples 'same behavior between KubernetesService and Platform::Kubernetes' do
2065 2066
        it 'returns variables from this service' do
          expect(project.deployment_variables).to include(
2067
            { key: 'KUBE_TOKEN', value: project.deployment_platform.token, public: false }
2068 2069 2070 2071 2072 2073 2074
          )
        end
      end

      context 'when user configured kubernetes from Integration > Kubernetes' do
        let(:project) { create(:kubernetes_project) }

2075
        it_behaves_like 'same behavior between KubernetesService and Platform::Kubernetes'
2076 2077 2078 2079 2080
      end

      context 'when user configured kubernetes from CI/CD > Clusters' do
        let!(:cluster) { create(:cluster, :project, :provided_by_gcp) }
        let(:project) { cluster.project }
2081

2082
        it_behaves_like 'same behavior between KubernetesService and Platform::Kubernetes'
2083 2084 2085 2086
      end
    end
  end

2087
  describe '#secret_variables_for' do
2088
    let(:project) { create(:project) }
2089 2090 2091 2092 2093 2094 2095 2096 2097

    let!(:secret_variable) do
      create(:ci_variable, value: 'secret', project: project)
    end

    let!(:protected_variable) do
      create(:ci_variable, :protected, value: 'protected', project: project)
    end

2098
    subject { project.reload.secret_variables_for(ref: 'ref') }
L
Lin Jen-Shin 已提交
2099 2100 2101 2102 2103

    before do
      stub_application_setting(
        default_branch_protection: Gitlab::Access::PROTECTION_NONE)
    end
2104 2105 2106

    shared_examples 'ref is protected' do
      it 'contains all the variables' do
2107
        is_expected.to contain_exactly(secret_variable, protected_variable)
2108 2109 2110 2111
      end
    end

    context 'when the ref is not protected' do
2112
      it 'contains only the secret variables' do
2113
        is_expected.to contain_exactly(secret_variable)
2114 2115 2116
      end
    end

2117 2118
    context 'when the ref is a protected branch' do
      before do
2119
        allow(project).to receive(:protected_for?).with('ref').and_return(true)
2120
      end
2121 2122 2123 2124 2125 2126

      it_behaves_like 'ref is protected'
    end

    context 'when the ref is a protected tag' do
      before do
2127
        allow(project).to receive(:protected_for?).with('ref').and_return(true)
2128 2129 2130
      end

      it_behaves_like 'ref is protected'
2131 2132 2133
    end
  end

2134
  describe '#protected_for?' do
2135
    let(:project) { create(:project) }
2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151

    subject { project.protected_for?('ref') }

    context 'when the ref is not protected' do
      before do
        stub_application_setting(
          default_branch_protection: Gitlab::Access::PROTECTION_NONE)
      end

      it 'returns false' do
        is_expected.to be_falsey
      end
    end

    context 'when the ref is a protected branch' do
      before do
2152 2153
        allow(project).to receive(:repository).and_call_original
        allow(project).to receive_message_chain(:repository, :branch_exists?).and_return(true)
2154 2155 2156 2157 2158 2159 2160 2161 2162 2163
        create(:protected_branch, name: 'ref', project: project)
      end

      it 'returns true' do
        is_expected.to be_truthy
      end
    end

    context 'when the ref is a protected tag' do
      before do
2164 2165
        allow(project).to receive_message_chain(:repository, :branch_exists?).and_return(false)
        allow(project).to receive_message_chain(:repository, :tag_exists?).and_return(true)
2166 2167 2168 2169 2170 2171 2172 2173 2174
        create(:protected_tag, name: 'ref', project: project)
      end

      it 'returns true' do
        is_expected.to be_truthy
      end
    end
  end

M
Markus Koller 已提交
2175
  describe '#update_project_statistics' do
2176
    let(:project) { create(:project) }
M
Markus Koller 已提交
2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194

    it "is called after creation" do
      expect(project.statistics).to be_a ProjectStatistics
      expect(project.statistics).to be_persisted
    end

    it "copies the namespace_id" do
      expect(project.statistics.namespace_id).to eq project.namespace_id
    end

    it "updates the namespace_id when changed" do
      namespace = create(:namespace)
      project.update(namespace: namespace)

      expect(project.statistics.namespace_id).to eq namespace.id
    end
  end

2195
  describe 'inside_path' do
2196 2197 2198
    let!(:project1) { create(:project, namespace: create(:namespace, path: 'name_pace')) }
    let!(:project2) { create(:project) }
    let!(:project3) { create(:project, namespace: create(:namespace, path: 'namespace')) }
2199
    let!(:path) { project1.namespace.full_path }
2200

2201
    it 'returns correct project' do
2202
      expect(described_class.inside_path(path)).to eq([project1])
2203
    end
2204 2205
  end

D
Douwe Maan 已提交
2206
  describe '#route_map_for' do
2207
    let(:project) { create(:project, :repository) }
D
Douwe Maan 已提交
2208 2209 2210 2211 2212 2213 2214 2215
    let(:route_map) do
      <<-MAP.strip_heredoc
      - source: /source/(.*)/
        public: '\\1'
      MAP
    end

    before do
2216
      project.repository.create_file(User.last, '.gitlab/route-map.yml', route_map, message: 'Add .gitlab/route-map.yml', branch_name: 'master')
D
Douwe Maan 已提交
2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243
    end

    context 'when there is a .gitlab/route-map.yml at the commit' do
      context 'when the route map is valid' do
        it 'returns a route map' do
          map = project.route_map_for(project.commit.sha)
          expect(map).to be_a_kind_of(Gitlab::RouteMap)
        end
      end

      context 'when the route map is invalid' do
        let(:route_map) { 'INVALID' }

        it 'returns nil' do
          expect(project.route_map_for(project.commit.sha)).to be_nil
        end
      end
    end

    context 'when there is no .gitlab/route-map.yml at the commit' do
      it 'returns nil' do
        expect(project.route_map_for(project.commit.parent.sha)).to be_nil
      end
    end
  end

  describe '#public_path_for_source_path' do
2244
    let(:project) { create(:project, :repository) }
D
Douwe Maan 已提交
2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281
    let(:route_map) do
      Gitlab::RouteMap.new(<<-MAP.strip_heredoc)
        - source: /source/(.*)/
          public: '\\1'
      MAP
    end
    let(:sha) { project.commit.id }

    context 'when there is a route map' do
      before do
        allow(project).to receive(:route_map_for).with(sha).and_return(route_map)
      end

      context 'when the source path is mapped' do
        it 'returns the public path' do
          expect(project.public_path_for_source_path('source/file.html', sha)).to eq('file.html')
        end
      end

      context 'when the source path is not mapped' do
        it 'returns nil' do
          expect(project.public_path_for_source_path('file.html', sha)).to be_nil
        end
      end
    end

    context 'when there is no route map' do
      before do
        allow(project).to receive(:route_map_for).with(sha).and_return(nil)
      end

      it 'returns nil' do
        expect(project.public_path_for_source_path('source/file.html', sha)).to be_nil
      end
    end
  end

2282
  describe '#parent' do
2283
    let(:project) { create(:project) }
2284 2285 2286 2287

    it { expect(project.parent).to eq(project.namespace) }
  end

2288 2289 2290 2291 2292 2293
  describe '#parent_id' do
    let(:project) { create(:project) }

    it { expect(project.parent_id).to eq(project.namespace_id) }
  end

2294
  describe '#parent_changed?' do
2295
    let(:project) { create(:project) }
2296

2297 2298 2299
    before do
      project.namespace_id = 7
    end
2300 2301 2302 2303

    it { expect(project.parent_changed?).to be_truthy }
  end

2304 2305 2306
  def enable_lfs
    allow(Gitlab.config.lfs).to receive(:enabled).and_return(true)
  end
K
Kamil Trzcinski 已提交
2307

2308
  describe '#pages_url' do
2309 2310
    let(:group) { create :group, name: 'Group' }
    let(:nested_group) { create :group, parent: group }
K
Kamil Trzcinski 已提交
2311 2312 2313 2314 2315 2316 2317 2318 2319
    let(:domain) { 'Example.com' }

    subject { project.pages_url }

    before do
      allow(Settings.pages).to receive(:host).and_return(domain)
      allow(Gitlab.config.pages).to receive(:url).and_return('http://example.com')
    end

2320
    context 'top-level group' do
2321
      let(:project) { create :project, namespace: group, name: project_name }
K
Kamil Trzcinski 已提交
2322

2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333
      context 'group page' do
        let(:project_name) { 'group.example.com' }

        it { is_expected.to eq("http://group.example.com") }
      end

      context 'project page' do
        let(:project_name) { 'Project' }

        it { is_expected.to eq("http://group.example.com/project") }
      end
K
Kamil Trzcinski 已提交
2334 2335
    end

2336
    context 'nested group' do
2337
      let(:project) { create :project, namespace: nested_group, name: project_name }
2338
      let(:expected_url) { "http://group.example.com/#{nested_group.path}/#{project.path}" }
K
Kamil Trzcinski 已提交
2339

2340 2341 2342 2343 2344 2345 2346 2347 2348 2349 2350
      context 'group page' do
        let(:project_name) { 'group.example.com' }

        it { is_expected.to eq(expected_url) }
      end

      context 'project page' do
        let(:project_name) { 'Project' }

        it { is_expected.to eq(expected_url) }
      end
K
Kamil Trzcinski 已提交
2351 2352
    end
  end
2353 2354

  describe '#http_url_to_repo' do
2355
    let(:project) { create :project }
2356

2357 2358 2359
    it 'returns the url to the repo without a username' do
      expect(project.http_url_to_repo).to eq("#{project.web_url}.git")
      expect(project.http_url_to_repo).not_to include('@')
2360 2361
    end
  end
2362 2363

  describe '#pipeline_status' do
2364
    let(:project) { create(:project, :repository) }
2365
    it 'builds a pipeline status' do
2366
      expect(project.pipeline_status).to be_a(Gitlab::Cache::Ci::ProjectPipelineStatus)
2367 2368 2369 2370 2371 2372
    end

    it 'hase a loaded pipeline status' do
      expect(project.pipeline_status).to be_loaded
    end
  end
2373 2374

  describe '#append_or_update_attribute' do
2375
    let(:project) { create(:project) }
2376 2377 2378 2379 2380

    it 'shows full error updating an invalid MR' do
      error_message = 'Failed to replace merge_requests because one or more of the new records could not be saved.'\
                      ' Validate fork Source project is not a fork of the target project'

2381 2382
      expect { project.append_or_update_attribute(:merge_requests, [create(:merge_request)]) }
        .to raise_error(ActiveRecord::RecordNotSaved, error_message)
2383 2384 2385 2386 2387
    end

    it 'updates the project succesfully' do
      merge_request = create(:merge_request, target_project: project, source_project: project)

2388 2389
      expect { project.append_or_update_attribute(:merge_requests, [merge_request]) }
        .not_to raise_error
2390 2391
    end
  end
2392 2393 2394

  describe '#last_repository_updated_at' do
    it 'sets to created_at upon creation' do
2395
      project = create(:project, created_at: 2.hours.ago)
2396 2397 2398 2399

      expect(project.last_repository_updated_at.to_i).to eq(project.created_at.to_i)
    end
  end
2400 2401 2402 2403 2404

  describe '.public_or_visible_to_user' do
    let!(:user) { create(:user) }

    let!(:private_project) do
2405
      create(:project, :private, creator: user, namespace: user.namespace)
2406 2407
    end

2408
    let!(:public_project) { create(:project, :public) }
2409 2410 2411

    context 'with a user' do
      let(:projects) do
2412
        described_class.all.public_or_visible_to_user(user)
2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425
      end

      it 'includes projects the user has access to' do
        expect(projects).to include(private_project)
      end

      it 'includes projects the user can see' do
        expect(projects).to include(public_project)
      end
    end

    context 'without a user' do
      it 'only includes public projects' do
2426
        projects = described_class.all.public_or_visible_to_user
2427 2428 2429 2430 2431

        expect(projects).to eq([public_project])
      end
    end
  end
2432

2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453 2454
  describe '#pages_available?' do
    let(:project) { create(:project, group: group) }

    subject { project.pages_available? }

    before do
      allow(Gitlab.config.pages).to receive(:enabled).and_return(true)
    end

    context 'when the project is in a top level namespace' do
      let(:group) { create(:group) }

      it { is_expected.to be(true) }
    end

    context 'when the project is in a subgroup' do
      let(:group) { create(:group, :nested) }

      it { is_expected.to be(false) }
    end
  end

2455
  describe '#remove_private_deploy_keys' do
2456
    let!(:project) { create(:project) }
2457 2458 2459 2460 2461 2462 2463 2464 2465 2466 2467 2468 2469 2470 2471

    context 'for a private deploy key' do
      let!(:key) { create(:deploy_key, public: false) }
      let!(:deploy_keys_project) { create(:deploy_keys_project, deploy_key: key, project: project) }

      context 'when the key is not linked to another project' do
        it 'removes the key' do
          project.remove_private_deploy_keys

          expect(project.deploy_keys).not_to include(key)
        end
      end

      context 'when the key is linked to another project' do
        before do
2472
          another_project = create(:project)
2473 2474
          create(:deploy_keys_project, deploy_key: key, project: another_project)
        end
2475

2476 2477
        it 'does not remove the key' do
          project.remove_private_deploy_keys
2478

2479 2480 2481 2482 2483 2484 2485 2486
          expect(project.deploy_keys).to include(key)
        end
      end
    end

    context 'for a public deploy key' do
      let!(:key) { create(:deploy_key, public: true) }
      let!(:deploy_keys_project) { create(:deploy_keys_project, deploy_key: key, project: project) }
2487

2488 2489
      it 'does not remove the key' do
        project.remove_private_deploy_keys
2490

2491 2492
        expect(project.deploy_keys).to include(key)
      end
2493 2494
    end
  end
2495

2496 2497
  describe '#remove_pages' do
    let(:project) { create(:project) }
2498
    let(:namespace) { project.namespace }
2499 2500 2501 2502 2503 2504 2505 2506 2507 2508 2509
    let(:pages_path) { project.pages_path }

    around do |example|
      FileUtils.mkdir_p(pages_path)
      begin
        example.run
      ensure
        FileUtils.rm_rf(pages_path)
      end
    end

2510 2511 2512 2513 2514 2515 2516 2517
    it 'removes the pages directory' do
      expect_any_instance_of(Projects::UpdatePagesConfigurationService).to receive(:execute)
      expect_any_instance_of(Gitlab::PagesTransfer).to receive(:rename_project).and_return(true)
      expect(PagesWorker).to receive(:perform_in).with(5.minutes, :remove, namespace.full_path, anything)

      project.remove_pages
    end

2518
    it 'is a no-op when there is no namespace' do
2519 2520
      project.namespace.delete
      project.reload
2521 2522 2523 2524 2525 2526

      expect_any_instance_of(Projects::UpdatePagesConfigurationService).not_to receive(:execute)
      expect_any_instance_of(Gitlab::PagesTransfer).not_to receive(:rename_project)

      project.remove_pages
    end
2527 2528 2529 2530 2531 2532

    it 'is run when the project is destroyed' do
      expect(project).to receive(:remove_pages).and_call_original

      project.destroy
    end
2533 2534
  end

2535
  describe '#remove_exports' do
N
Nick Thomas 已提交
2536
    let(:legacy_project) { create(:project, :legacy_storage, :with_export) }
2537 2538 2539 2540 2541 2542 2543 2544 2545 2546 2547 2548
    let(:project) { create(:project, :with_export) }

    it 'removes the exports directory for the project' do
      expect(File.exist?(project.export_path)).to be_truthy

      allow(FileUtils).to receive(:rm_rf).and_call_original
      expect(FileUtils).to receive(:rm_rf).with(project.export_path).and_call_original
      project.remove_exports

      expect(File.exist?(project.export_path)).to be_falsy
    end

N
Nick Thomas 已提交
2549 2550 2551
    it 'is a no-op on legacy projects when there is no namespace' do
      export_path = legacy_project.export_path

2552 2553
      legacy_project.namespace.delete
      legacy_project.reload
N
Nick Thomas 已提交
2554 2555 2556 2557 2558 2559 2560 2561 2562

      expect(FileUtils).not_to receive(:rm_rf).with(export_path)

      legacy_project.remove_exports

      expect(File.exist?(export_path)).to be_truthy
    end

    it 'runs on hashed storage projects when there is no namespace' do
2563
      export_path = project.export_path
N
Nick Thomas 已提交
2564

2565 2566
      project.namespace.delete
      legacy_project.reload
2567

N
Nick Thomas 已提交
2568 2569
      allow(FileUtils).to receive(:rm_rf).and_call_original
      expect(FileUtils).to receive(:rm_rf).with(export_path).and_call_original
2570 2571 2572

      project.remove_exports

N
Nick Thomas 已提交
2573
      expect(File.exist?(export_path)).to be_falsy
2574 2575 2576 2577 2578 2579 2580 2581 2582
    end

    it 'is run when the project is destroyed' do
      expect(project).to receive(:remove_exports).and_call_original

      project.destroy
    end
  end

2583 2584 2585 2586
  describe '#forks_count' do
    it 'returns the number of forks' do
      project = build(:project)

F
Francisco Lopez 已提交
2587
      expect_any_instance_of(Projects::ForksCountService).to receive(:count).and_return(1)
2588 2589 2590 2591

      expect(project.forks_count).to eq(1)
    end
  end
2592 2593

  context 'legacy storage' do
N
Nick Thomas 已提交
2594
    let(:project) { create(:project, :repository, :legacy_storage) }
2595
    let(:gitlab_shell) { Gitlab::Shell.new }
2596
    let(:project_storage) { project.send(:storage) }
2597

2598 2599 2600 2601
    before do
      allow(project).to receive(:gitlab_shell).and_return(gitlab_shell)
    end

2602 2603 2604 2605 2606 2607 2608 2609 2610 2611 2612 2613
    describe '#base_dir' do
      it 'returns base_dir based on namespace only' do
        expect(project.base_dir).to eq(project.namespace.full_path)
      end
    end

    describe '#disk_path' do
      it 'returns disk_path based on namespace and project path' do
        expect(project.disk_path).to eq("#{project.namespace.full_path}/#{project.path}")
      end
    end

2614
    describe '#ensure_storage_path_exists' do
2615 2616 2617
      it 'delegates to gitlab_shell to ensure namespace is created' do
        expect(gitlab_shell).to receive(:add_namespace).with(project.repository_storage_path, project.base_dir)

2618
        project.ensure_storage_path_exists
2619 2620 2621
      end
    end

2622 2623
    describe '#legacy_storage?' do
      it 'returns true when storage_version is nil' do
2624
        project = build(:project, storage_version: nil)
2625 2626 2627

        expect(project.legacy_storage?).to be_truthy
      end
2628 2629 2630 2631 2632 2633 2634 2635 2636 2637

      it 'returns true when the storage_version is 0' do
        project = build(:project, storage_version: 0)

        expect(project.legacy_storage?).to be_truthy
      end
    end

    describe '#hashed_storage?' do
      it 'returns false' do
2638
        expect(project.hashed_storage?(:repository)).to be_falsey
2639
      end
2640 2641
    end

2642 2643 2644 2645 2646 2647 2648 2649 2650 2651 2652 2653 2654 2655 2656 2657 2658 2659 2660 2661 2662 2663 2664 2665 2666 2667 2668 2669 2670 2671 2672 2673 2674 2675 2676 2677 2678 2679 2680 2681 2682 2683 2684 2685 2686 2687 2688
    describe '#rename_repo' do
      before do
        # Project#gitlab_shell returns a new instance of Gitlab::Shell on every
        # call. This makes testing a bit easier.
        allow(project).to receive(:gitlab_shell).and_return(gitlab_shell)
        allow(project).to receive(:previous_changes).and_return('path' => ['foo'])
      end

      it 'renames a repository' do
        stub_container_registry_config(enabled: false)

        expect(gitlab_shell).to receive(:mv_repository)
          .ordered
          .with(project.repository_storage_path, "#{project.namespace.full_path}/foo", "#{project.full_path}")
          .and_return(true)

        expect(gitlab_shell).to receive(:mv_repository)
          .ordered
          .with(project.repository_storage_path, "#{project.namespace.full_path}/foo.wiki", "#{project.full_path}.wiki")
          .and_return(true)

        expect_any_instance_of(SystemHooksService)
          .to receive(:execute_hooks_for)
            .with(project, :rename)

        expect_any_instance_of(Gitlab::UploadsTransfer)
          .to receive(:rename_project)
            .with('foo', project.path, project.namespace.full_path)

        expect(project).to receive(:expire_caches_before_rename)

        expect(project).to receive(:expires_full_path_cache)

        project.rename_repo
      end

      context 'container registry with images' do
        let(:container_repository) { create(:container_repository) }

        before do
          stub_container_registry_config(enabled: true)
          stub_container_registry_tags(repository: :any, tags: ['tag'])
          project.container_repositories << container_repository
        end

        subject { project.rename_repo }

2689
        it { expect { subject }.to raise_error(StandardError) }
2690
      end
2691 2692 2693 2694 2695 2696 2697 2698 2699 2700 2701 2702 2703 2704 2705 2706 2707 2708 2709 2710 2711 2712 2713 2714

      context 'gitlab pages' do
        before do
          expect(project_storage).to receive(:rename_repo) { true }
        end

        it 'moves pages folder to new location' do
          expect_any_instance_of(Gitlab::PagesTransfer).to receive(:rename_project)

          project.rename_repo
        end
      end

      context 'attachments' do
        before do
          expect(project_storage).to receive(:rename_repo) { true }
        end

        it 'moves uploads folder to new location' do
          expect_any_instance_of(Gitlab::UploadsTransfer).to receive(:rename_project)

          project.rename_repo
        end
      end
2715 2716 2717 2718 2719

      it 'updates project full path in .git/config' do
        allow(project_storage).to receive(:rename_repo).and_return(true)

        project.rename_repo
2720

J
Jacob Vosmaer 已提交
2721
        expect(project.repository.rugged.config['gitlab.fullpath']).to eq(project.full_path)
2722
      end
2723
    end
2724 2725 2726 2727 2728 2729

    describe '#pages_path' do
      it 'returns a path where pages are stored' do
        expect(project.pages_path).to eq(File.join(Settings.pages.path, project.namespace.full_path, project.path))
      end
    end
2730 2731 2732 2733 2734 2735

    describe '#migrate_to_hashed_storage!' do
      it 'returns true' do
        expect(project.migrate_to_hashed_storage!).to be_truthy
      end

T
Toon Claes 已提交
2736
      it 'flags as read-only' do
2737 2738 2739 2740 2741 2742 2743 2744 2745 2746 2747 2748 2749 2750 2751 2752 2753 2754 2755 2756 2757 2758 2759 2760 2761
        expect { project.migrate_to_hashed_storage! }.to change { project.repository_read_only }.to(true)
      end

      it 'schedules ProjectMigrateHashedStorageWorker with delayed start when the project repo is in use' do
        Gitlab::ReferenceCounter.new(project.gl_repository(is_wiki: false)).increase

        expect(ProjectMigrateHashedStorageWorker).to receive(:perform_in)

        project.migrate_to_hashed_storage!
      end

      it 'schedules ProjectMigrateHashedStorageWorker with delayed start when the wiki repo is in use' do
        Gitlab::ReferenceCounter.new(project.gl_repository(is_wiki: true)).increase

        expect(ProjectMigrateHashedStorageWorker).to receive(:perform_in)

        project.migrate_to_hashed_storage!
      end

      it 'schedules ProjectMigrateHashedStorageWorker' do
        expect(ProjectMigrateHashedStorageWorker).to receive(:perform_async).with(project.id)

        project.migrate_to_hashed_storage!
      end
    end
2762 2763 2764
  end

  context 'hashed storage' do
2765
    let(:project) { create(:project, :repository, skip_disk_validation: true) }
2766
    let(:gitlab_shell) { Gitlab::Shell.new }
2767
    let(:hash) { Digest::SHA2.hexdigest(project.id.to_s) }
N
Nick Thomas 已提交
2768 2769
    let(:hashed_prefix) { File.join('@hashed', hash[0..1], hash[2..3]) }
    let(:hashed_path) { File.join(hashed_prefix, hash) }
2770 2771

    before do
2772
      stub_application_setting(hashed_storage_enabled: true)
2773 2774
    end

2775 2776 2777 2778 2779 2780 2781
    describe '#legacy_storage?' do
      it 'returns false' do
        expect(project.legacy_storage?).to be_falsey
      end
    end

    describe '#hashed_storage?' do
2782 2783
      it 'returns true if rolled out' do
        expect(project.hashed_storage?(:attachments)).to be_truthy
2784 2785
      end

2786 2787
      it 'returns false when not rolled out yet' do
        project.storage_version = 1
2788

2789
        expect(project.hashed_storage?(:attachments)).to be_falsey
2790 2791 2792
      end
    end

2793 2794
    describe '#base_dir' do
      it 'returns base_dir based on hash of project id' do
N
Nick Thomas 已提交
2795
        expect(project.base_dir).to eq(hashed_prefix)
2796 2797 2798 2799
      end
    end

    describe '#disk_path' do
2800
      it 'returns disk_path based on hash of project id' do
2801 2802 2803 2804
        expect(project.disk_path).to eq(hashed_path)
      end
    end

2805
    describe '#ensure_storage_path_exists' do
2806
      it 'delegates to gitlab_shell to ensure namespace is created' do
2807 2808
        allow(project).to receive(:gitlab_shell).and_return(gitlab_shell)

N
Nick Thomas 已提交
2809
        expect(gitlab_shell).to receive(:add_namespace).with(project.repository_storage_path, hashed_prefix)
2810

2811
        project.ensure_storage_path_exists
2812 2813 2814 2815 2816 2817 2818 2819 2820 2821 2822 2823 2824 2825 2826 2827 2828 2829 2830 2831 2832 2833 2834 2835 2836 2837 2838 2839 2840 2841 2842 2843 2844 2845 2846 2847 2848 2849
      end
    end

    describe '#rename_repo' do
      before do
        # Project#gitlab_shell returns a new instance of Gitlab::Shell on every
        # call. This makes testing a bit easier.
        allow(project).to receive(:gitlab_shell).and_return(gitlab_shell)
        allow(project).to receive(:previous_changes).and_return('path' => ['foo'])
      end

      it 'renames a repository' do
        stub_container_registry_config(enabled: false)

        expect(gitlab_shell).not_to receive(:mv_repository)

        expect_any_instance_of(SystemHooksService)
          .to receive(:execute_hooks_for)
            .with(project, :rename)

        expect(project).to receive(:expire_caches_before_rename)

        expect(project).to receive(:expires_full_path_cache)

        project.rename_repo
      end

      context 'container registry with images' do
        let(:container_repository) { create(:container_repository) }

        before do
          stub_container_registry_config(enabled: true)
          stub_container_registry_tags(repository: :any, tags: ['tag'])
          project.container_repositories << container_repository
        end

        subject { project.rename_repo }

2850
        it { expect { subject }.to raise_error(StandardError) }
2851
      end
2852 2853 2854 2855 2856 2857 2858 2859 2860 2861 2862 2863 2864 2865 2866 2867 2868

      context 'gitlab pages' do
        it 'moves pages folder to new location' do
          expect_any_instance_of(Gitlab::PagesTransfer).to receive(:rename_project)

          project.rename_repo
        end
      end

      context 'attachments' do
        it 'keeps uploads folder location unchanged' do
          expect_any_instance_of(Gitlab::UploadsTransfer).not_to receive(:rename_project)

          project.rename_repo
        end

        context 'when not rolled out' do
2869
          let(:project) { create(:project, :repository, storage_version: 1, skip_disk_validation: true) }
2870 2871 2872 2873 2874 2875 2876 2877

          it 'moves pages folder to new location' do
            expect_any_instance_of(Gitlab::UploadsTransfer).to receive(:rename_project)

            project.rename_repo
          end
        end
      end
2878 2879 2880

      it 'updates project full path in .git/config' do
        project.rename_repo
2881

J
Jacob Vosmaer 已提交
2882
        expect(project.repository.rugged.config['gitlab.fullpath']).to eq(project.full_path)
2883
      end
2884
    end
2885 2886 2887 2888 2889 2890

    describe '#pages_path' do
      it 'returns a path where pages are stored' do
        expect(project.pages_path).to eq(File.join(Settings.pages.path, project.namespace.full_path, project.path))
      end
    end
2891 2892 2893 2894 2895 2896

    describe '#migrate_to_hashed_storage!' do
      it 'returns nil' do
        expect(project.migrate_to_hashed_storage!).to be_nil
      end

T
Toon Claes 已提交
2897
      it 'does not flag as read-only' do
2898 2899 2900 2901 2902 2903 2904 2905 2906 2907 2908 2909 2910
        expect { project.migrate_to_hashed_storage! }.not_to change { project.repository_read_only }
      end
    end
  end

  describe '#gl_repository' do
    let(:project) { create(:project) }

    it 'delegates to Gitlab::GlRepository.gl_repository' do
      expect(Gitlab::GlRepository).to receive(:gl_repository).with(project, true)

      project.gl_repository(is_wiki: true)
    end
2911
  end
2912 2913 2914 2915 2916 2917 2918 2919 2920 2921 2922 2923 2924 2925 2926 2927 2928 2929 2930 2931 2932 2933 2934 2935 2936 2937 2938 2939 2940 2941 2942 2943 2944 2945 2946 2947 2948 2949 2950 2951 2952 2953 2954 2955 2956 2957 2958 2959 2960 2961 2962 2963 2964 2965 2966 2967 2968 2969 2970 2971 2972 2973 2974 2975 2976 2977 2978 2979 2980 2981 2982 2983 2984 2985 2986 2987 2988 2989 2990 2991 2992 2993 2994 2995 2996 2997 2998 2999 3000 3001 3002 3003 3004 3005 3006 3007 3008 3009

  describe '#has_ci?' do
    set(:project) { create(:project) }
    let(:repository) { double }

    before do
      expect(project).to receive(:repository) { repository }
    end

    context 'when has .gitlab-ci.yml' do
      before do
        expect(repository).to receive(:gitlab_ci_yml) { 'content' }
      end

      it "CI is available" do
        expect(project).to have_ci
      end
    end

    context 'when there is no .gitlab-ci.yml' do
      before do
        expect(repository).to receive(:gitlab_ci_yml) { nil }
      end

      it "CI is not available" do
        expect(project).not_to have_ci
      end

      context 'when auto devops is enabled' do
        before do
          stub_application_setting(auto_devops_enabled: true)
        end

        it "CI is available" do
          expect(project).to have_ci
        end
      end
    end
  end

  describe '#auto_devops_enabled?' do
    set(:project) { create(:project) }

    subject { project.auto_devops_enabled? }

    context 'when enabled in settings' do
      before do
        stub_application_setting(auto_devops_enabled: true)
      end

      it 'auto devops is implicitly enabled' do
        expect(project.auto_devops).to be_nil
        expect(project).to be_auto_devops_enabled
      end

      context 'when explicitly enabled' do
        before do
          create(:project_auto_devops, project: project)
        end

        it "auto devops is enabled" do
          expect(project).to be_auto_devops_enabled
        end
      end

      context 'when explicitly disabled' do
        before do
          create(:project_auto_devops, project: project, enabled: false)
        end

        it "auto devops is disabled" do
          expect(project).not_to be_auto_devops_enabled
        end
      end
    end

    context 'when disabled in settings' do
      before do
        stub_application_setting(auto_devops_enabled: false)
      end

      it 'auto devops is implicitly disabled' do
        expect(project.auto_devops).to be_nil
        expect(project).not_to be_auto_devops_enabled
      end

      context 'when explicitly enabled' do
        before do
          create(:project_auto_devops, project: project)
        end

        it "auto devops is enabled" do
          expect(project).to be_auto_devops_enabled
        end
      end
    end
  end

3010 3011 3012 3013 3014 3015 3016 3017 3018 3019 3020 3021 3022 3023 3024 3025 3026 3027 3028 3029 3030 3031 3032 3033 3034 3035 3036 3037 3038 3039 3040 3041 3042 3043 3044 3045 3046 3047 3048 3049 3050 3051 3052 3053
  describe '#has_auto_devops_implicitly_disabled?' do
    set(:project) { create(:project) }

    context 'when enabled in settings' do
      before do
        stub_application_setting(auto_devops_enabled: true)
      end

      it 'does not have auto devops implicitly disabled' do
        expect(project).not_to have_auto_devops_implicitly_disabled
      end
    end

    context 'when disabled in settings' do
      before do
        stub_application_setting(auto_devops_enabled: false)
      end

      it 'auto devops is implicitly disabled' do
        expect(project).to have_auto_devops_implicitly_disabled
      end

      context 'when explicitly disabled' do
        before do
          create(:project_auto_devops, project: project, enabled: false)
        end

        it 'does not have auto devops implicitly disabled' do
          expect(project).not_to have_auto_devops_implicitly_disabled
        end
      end

      context 'when explicitly enabled' do
        before do
          create(:project_auto_devops, project: project)
        end

        it 'does not have auto devops implicitly disabled' do
          expect(project).not_to have_auto_devops_implicitly_disabled
        end
      end
    end
  end

3054 3055 3056 3057 3058
  context '#auto_devops_variables' do
    set(:project) { create(:project) }

    subject { project.auto_devops_variables }

3059
    context 'when enabled in instance settings' do
3060 3061 3062 3063
      before do
        stub_application_setting(auto_devops_enabled: true)
      end

3064 3065 3066 3067 3068 3069 3070 3071 3072 3073 3074 3075 3076 3077 3078 3079 3080 3081 3082 3083 3084 3085
      context 'when domain is empty' do
        before do
          stub_application_setting(auto_devops_domain: nil)
        end

        it 'variables does not include AUTO_DEVOPS_DOMAIN' do
          is_expected.not_to include(domain_variable)
        end
      end

      context 'when domain is configured' do
        before do
          stub_application_setting(auto_devops_domain: 'example.com')
        end

        it 'variables includes AUTO_DEVOPS_DOMAIN' do
          is_expected.to include(domain_variable)
        end
      end
    end

    context 'when explicitely enabled' do
3086 3087 3088 3089 3090
      context 'when domain is empty' do
        before do
          create(:project_auto_devops, project: project, domain: nil)
        end

3091 3092
        it 'variables does not include AUTO_DEVOPS_DOMAIN' do
          is_expected.not_to include(domain_variable)
3093 3094 3095 3096 3097 3098 3099 3100
        end
      end

      context 'when domain is configured' do
        before do
          create(:project_auto_devops, project: project, domain: 'example.com')
        end

3101 3102
        it 'variables includes AUTO_DEVOPS_DOMAIN' do
          is_expected.to include(domain_variable)
3103 3104 3105
        end
      end
    end
3106 3107 3108 3109

    def domain_variable
      { key: 'AUTO_DEVOPS_DOMAIN', value: 'example.com', public: true }
    end
3110
  end
3111 3112 3113 3114 3115 3116 3117 3118 3119 3120 3121 3122 3123 3124 3125 3126 3127 3128 3129 3130 3131 3132 3133 3134 3135 3136 3137 3138 3139 3140 3141 3142 3143 3144 3145

  describe '#latest_successful_builds_for' do
    let(:project) { build(:project) }

    before do
      allow(project).to receive(:default_branch).and_return('master')
    end

    context 'without a ref' do
      it 'returns a pipeline for the default branch' do
        expect(project)
          .to receive(:latest_successful_pipeline_for_default_branch)

        project.latest_successful_pipeline_for
      end
    end

    context 'with the ref set to the default branch' do
      it 'returns a pipeline for the default branch' do
        expect(project)
          .to receive(:latest_successful_pipeline_for_default_branch)

        project.latest_successful_pipeline_for(project.default_branch)
      end
    end

    context 'with a ref that is not the default branch' do
      it 'returns the latest successful pipeline for the given ref' do
        expect(project.pipelines).to receive(:latest_successful_for).with('foo')

        project.latest_successful_pipeline_for('foo')
      end
    end
  end

S
Stan Hu 已提交
3146 3147 3148 3149 3150 3151 3152 3153 3154 3155 3156
  describe '#check_repository_path_availability' do
    let(:project) { build(:project) }

    it 'skips gitlab-shell exists?' do
      project.skip_disk_validation = true

      expect(project.gitlab_shell).not_to receive(:exists?)
      expect(project.check_repository_path_availability).to be_truthy
    end
  end

3157 3158 3159 3160 3161 3162 3163 3164 3165 3166 3167 3168 3169 3170 3171 3172 3173 3174 3175 3176 3177
  describe '#latest_successful_pipeline_for_default_branch' do
    let(:project) { build(:project) }

    before do
      allow(project).to receive(:default_branch).and_return('master')
    end

    it 'memoizes and returns the latest successful pipeline for the default branch' do
      pipeline = double(:pipeline)

      expect(project.pipelines).to receive(:latest_successful_for)
        .with(project.default_branch)
        .and_return(pipeline)
        .once

      2.times do
        expect(project.latest_successful_pipeline_for_default_branch)
          .to eq(pipeline)
      end
    end
  end
3178 3179 3180 3181 3182 3183 3184 3185 3186

  describe '#after_import' do
    let(:project) { build(:project) }

    it 'runs the correct hooks' do
      expect(project.repository).to receive(:after_import)
      expect(project).to receive(:import_finish)
      expect(project).to receive(:update_project_counter_caches)
      expect(project).to receive(:remove_import_jid)
3187
      expect(project).to receive(:after_create_default_branch)
3188 3189 3190

      project.after_import
    end
3191 3192 3193 3194 3195 3196 3197 3198 3199 3200 3201 3202 3203 3204 3205 3206 3207 3208 3209 3210 3211 3212 3213 3214 3215 3216 3217 3218 3219 3220 3221 3222 3223 3224 3225 3226 3227 3228 3229 3230 3231

    context 'branch protection' do
      let(:project) { create(:project, :repository) }

      it 'does not protect when branch protection is disabled' do
        stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_NONE)

        project.after_import

        expect(project.protected_branches).to be_empty
      end

      it "gives developer access to push when branch protection is set to 'developers can push'" do
        stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_DEV_CAN_PUSH)

        project.after_import

        expect(project.protected_branches).not_to be_empty
        expect(project.default_branch).to eq(project.protected_branches.first.name)
        expect(project.protected_branches.first.push_access_levels.map(&:access_level)).to eq([Gitlab::Access::DEVELOPER])
      end

      it "gives developer access to merge when branch protection is set to 'developers can merge'" do
        stub_application_setting(default_branch_protection: Gitlab::Access::PROTECTION_DEV_CAN_MERGE)

        project.after_import

        expect(project.protected_branches).not_to be_empty
        expect(project.default_branch).to eq(project.protected_branches.first.name)
        expect(project.protected_branches.first.merge_access_levels.map(&:access_level)).to eq([Gitlab::Access::DEVELOPER])
      end

      it 'protects default branch' do
        project.after_import

        expect(project.protected_branches).not_to be_empty
        expect(project.default_branch).to eq(project.protected_branches.first.name)
        expect(project.protected_branches.first.push_access_levels.map(&:access_level)).to eq([Gitlab::Access::MASTER])
        expect(project.protected_branches.first.merge_access_levels.map(&:access_level)).to eq([Gitlab::Access::MASTER])
      end
    end
3232 3233 3234 3235 3236 3237 3238 3239 3240 3241 3242 3243 3244 3245 3246 3247 3248 3249 3250 3251 3252 3253 3254 3255 3256 3257 3258 3259 3260 3261 3262 3263 3264 3265 3266 3267 3268 3269 3270 3271 3272 3273 3274 3275 3276 3277 3278 3279 3280 3281 3282 3283 3284 3285 3286 3287 3288 3289 3290 3291 3292
  end

  describe '#update_project_counter_caches' do
    let(:project) { create(:project) }

    it 'updates all project counter caches' do
      expect_any_instance_of(Projects::OpenIssuesCountService)
        .to receive(:refresh_cache)
        .and_call_original

      expect_any_instance_of(Projects::OpenMergeRequestsCountService)
        .to receive(:refresh_cache)
        .and_call_original

      project.update_project_counter_caches
    end
  end

  describe '#remove_import_jid', :clean_gitlab_redis_cache do
    let(:project) {  }

    context 'without an import JID' do
      it 'does nothing' do
        project = create(:project)

        expect(Gitlab::SidekiqStatus)
          .not_to receive(:unset)

        project.remove_import_jid
      end
    end

    context 'with an import JID' do
      it 'unsets the import JID' do
        project = create(:project, import_jid: '123')

        expect(Gitlab::SidekiqStatus)
          .to receive(:unset)
          .with('123')
          .and_call_original

        project.remove_import_jid

        expect(project.import_jid).to be_nil
      end
    end
  end

  describe '#wiki_repository_exists?' do
    it 'returns true when the wiki repository exists' do
      project = create(:project, :wiki_repo)

      expect(project.wiki_repository_exists?).to eq(true)
    end

    it 'returns false when the wiki repository does not exist' do
      project = create(:project)

      expect(project.wiki_repository_exists?).to eq(false)
    end
  end
3293

3294 3295 3296 3297 3298 3299
  describe '#write_repository_config' do
    set(:project) { create(:project, :repository) }

    it 'writes full path in .git/config when key is missing' do
      project.write_repository_config

J
Jacob Vosmaer 已提交
3300
      expect(project.repository.rugged.config['gitlab.fullpath']).to eq project.full_path
3301 3302 3303 3304 3305
    end

    it 'updates full path in .git/config when key is present' do
      project.write_repository_config(gl_full_path: 'old/path')

J
Jacob Vosmaer 已提交
3306
      expect { project.write_repository_config }.to change { project.repository.rugged.config['gitlab.fullpath'] }.from('old/path').to(project.full_path)
3307 3308 3309 3310 3311 3312 3313 3314
    end

    it 'does not raise an error with an empty repository' do
      project = create(:project_empty_repo)

      expect { project.write_repository_config }.not_to raise_error
    end
  end
3315 3316 3317 3318 3319 3320 3321 3322 3323 3324 3325 3326 3327

  describe '#execute_hooks' do
    it 'executes the projects hooks with the specified scope' do
      hook1 = create(:project_hook, merge_requests_events: true, tag_push_events: false)
      hook2 = create(:project_hook, merge_requests_events: false, tag_push_events: true)
      project = create(:project, hooks: [hook1, hook2])

      expect_any_instance_of(ProjectHook).to receive(:async_execute).once

      project.execute_hooks({}, :tag_push_hooks)
    end

    it 'executes the system hooks with the specified scope' do
3328
      expect_any_instance_of(SystemHooksService).to receive(:execute_hooks).with({ data: 'data' }, :merge_request_hooks)
3329

3330 3331
      project = build(:project)
      project.execute_hooks({ data: 'data' }, :merge_request_hooks)
3332
    end
3333 3334 3335 3336 3337 3338 3339 3340 3341 3342 3343 3344 3345 3346 3347 3348 3349

    it 'executes the system hooks when inside a transaction' do
      allow_any_instance_of(WebHookService).to receive(:execute)

      create(:system_hook, merge_requests_events: true)

      project = build(:project)

      # Ideally, we'd test that `WebHookWorker.jobs.size` increased by 1,
      # but since the entire spec run takes place in a transaction, we never
      # actually get to the `after_commit` hook that queues these jobs.
      expect do
        project.transaction do
          project.execute_hooks({ data: 'data' }, :merge_request_hooks)
        end
      end.not_to raise_error # Sidekiq::Worker::EnqueueFromTransactionError
    end
3350
  end
3351 3352 3353 3354 3355 3356 3357 3358 3359 3360 3361 3362 3363 3364 3365 3366 3367 3368 3369 3370 3371 3372 3373 3374 3375 3376 3377 3378 3379 3380 3381 3382

  describe '#badges' do
    let(:project_group) { create(:group) }
    let(:project) {  create(:project, path: 'avatar', namespace: project_group) }

    before do
      create_list(:project_badge, 2, project: project)
      create(:group_badge, group: project_group)
    end

    it 'returns the project and the project group badges' do
      create(:group_badge, group: create(:group))

      expect(Badge.count).to eq 4
      expect(project.badges.count).to eq 3
    end

    if Group.supports_nested_groups?
      context 'with nested_groups' do
        let(:parent_group) { create(:group) }

        before do
          create_list(:group_badge, 2, group: project_group)
          project_group.update(parent: parent_group)
        end

        it 'returns the project and the project nested groups badges' do
          expect(project.badges.count).to eq 5
        end
      end
    end
  end
3383

3384 3385
  context 'with cross project merge requests' do
    let(:user) { create(:user) }
3386 3387
    let(:target_project) { create(:project, :repository) }
    let(:project) { fork_project(target_project, nil, repository: true) }
3388 3389 3390 3391
    let!(:merge_request) do
      create(
        :merge_request,
        target_project: target_project,
3392
        target_branch: 'target-branch',
3393 3394 3395 3396 3397 3398 3399
        source_project: project,
        source_branch: 'awesome-feature-1',
        allow_maintainer_to_push: true
      )
    end

    before do
3400
      target_project.add_developer(user)
3401 3402
    end

3403 3404 3405 3406
    describe '#merge_requests_allowing_push_to_user' do
      it 'returns open merge requests for which the user has developer access to the target project' do
        expect(project.merge_requests_allowing_push_to_user(user)).to include(merge_request)
      end
3407

3408 3409
      it 'does not include closed merge requests' do
        merge_request.close
3410

3411 3412 3413 3414 3415 3416
        expect(project.merge_requests_allowing_push_to_user(user)).to be_empty
      end

      it 'does not include merge requests for guest users' do
        guest = create(:user)
        target_project.add_guest(guest)
3417

3418 3419 3420 3421 3422 3423 3424 3425 3426 3427 3428 3429
        expect(project.merge_requests_allowing_push_to_user(guest)).to be_empty
      end

      it 'does not include the merge request for other users' do
        other_user = create(:user)

        expect(project.merge_requests_allowing_push_to_user(other_user)).to be_empty
      end

      it 'is empty when no user is passed' do
        expect(project.merge_requests_allowing_push_to_user(nil)).to be_empty
      end
3430 3431
    end

3432
    describe '#branch_allows_maintainer_push?' do
3433
      it 'allows access if the user can merge the merge request' do
3434 3435 3436 3437 3438 3439 3440 3441 3442 3443 3444 3445
        expect(project.branch_allows_maintainer_push?(user, 'awesome-feature-1'))
          .to be_truthy
      end

      it 'does not allow guest users access' do
        guest = create(:user)
        target_project.add_guest(guest)

        expect(project.branch_allows_maintainer_push?(guest, 'awesome-feature-1'))
          .to be_falsy
      end

3446
      it 'does not allow access to branches for which the merge request was closed' do
3447 3448
        create(:merge_request, :closed,
               target_project: target_project,
3449
               target_branch: 'target-branch',
3450 3451 3452 3453 3454 3455 3456 3457
               source_project: project,
               source_branch: 'rejected-feature-1',
               allow_maintainer_to_push: true)

        expect(project.branch_allows_maintainer_push?(user, 'rejected-feature-1'))
          .to be_falsy
      end

3458 3459 3460 3461 3462 3463 3464 3465 3466 3467
      it 'does not allow access if the user cannot merge the merge request' do
        create(:protected_branch, :masters_can_push, project: target_project, name: 'target-branch')

        expect(project.branch_allows_maintainer_push?(user, 'awesome-feature-1'))
          .to be_falsy
      end

      it 'caches the result' do
        control = ActiveRecord::QueryRecorder.new { project.branch_allows_maintainer_push?(user, 'awesome-feature-1') }

3468
        expect { 3.times { project.branch_allows_maintainer_push?(user, 'awesome-feature-1') } }
3469
          .not_to exceed_query_limit(control)
3470 3471 3472
      end

      context 'when the requeststore is active', :request_store do
3473 3474 3475
        it 'only queries per project across instances' do
          control = ActiveRecord::QueryRecorder.new { project.branch_allows_maintainer_push?(user, 'awesome-feature-1') }

3476
          expect { 2.times { described_class.find(project.id).branch_allows_maintainer_push?(user, 'awesome-feature-1') } }
3477
            .not_to exceed_query_limit(control).with_threshold(2)
3478
        end
3479 3480 3481
      end
    end
  end
G
gitlabhq 已提交
3482
end