user_spec.rb 91.7 KB
Newer Older
G
gitlabhq 已提交
1 2
require 'spec_helper'

3
describe User do
B
Bob Van Landuyt 已提交
4
  include ProjectForksHelper
5
  include TermsHelper
6

7 8 9 10 11 12 13
  describe 'modules' do
    subject { described_class }

    it { is_expected.to include_module(Gitlab::ConfigHelper) }
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
    it { is_expected.to include_module(TokenAuthenticatable) }
14
    it { is_expected.to include_module(BlocksJsonSerialization) }
15 16
  end

17 18 19 20
  describe 'delegations' do
    it { is_expected.to delegate_method(:path).to(:namespace).with_prefix }
  end

21
  describe 'associations' do
22
    it { is_expected.to have_one(:namespace) }
23
    it { is_expected.to have_many(:snippets).dependent(:destroy) }
24 25 26
    it { is_expected.to have_many(:members) }
    it { is_expected.to have_many(:project_members) }
    it { is_expected.to have_many(:group_members) }
27 28
    it { is_expected.to have_many(:groups) }
    it { is_expected.to have_many(:keys).dependent(:destroy) }
29
    it { is_expected.to have_many(:deploy_keys).dependent(:nullify) }
30
    it { is_expected.to have_many(:events).dependent(:destroy) }
31
    it { is_expected.to have_many(:issues).dependent(:destroy) }
32 33 34
    it { is_expected.to have_many(:notes).dependent(:destroy) }
    it { is_expected.to have_many(:merge_requests).dependent(:destroy) }
    it { is_expected.to have_many(:identities).dependent(:destroy) }
35
    it { is_expected.to have_many(:spam_logs).dependent(:destroy) }
36
    it { is_expected.to have_many(:todos) }
37
    it { is_expected.to have_many(:award_emoji).dependent(:destroy) }
K
Kamil Trzcinski 已提交
38
    it { is_expected.to have_many(:triggers).dependent(:destroy) }
39 40
    it { is_expected.to have_many(:builds).dependent(:nullify) }
    it { is_expected.to have_many(:pipelines).dependent(:nullify) }
K
Kamil Trzcinski 已提交
41
    it { is_expected.to have_many(:chat_names).dependent(:destroy) }
J
Jan Provaznik 已提交
42
    it { is_expected.to have_many(:uploads) }
43
    it { is_expected.to have_many(:reported_abuse_reports).dependent(:destroy).class_name('AbuseReport') }
44
    it { is_expected.to have_many(:custom_attributes).class_name('UserCustomAttribute') }
45

46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71
    describe "#abuse_report" do
      let(:current_user) { create(:user) }
      let(:other_user) { create(:user) }

      it { is_expected.to have_one(:abuse_report) }

      it "refers to the abuse report whose user_id is the current user" do
        abuse_report = create(:abuse_report, reporter: other_user, user: current_user)

        expect(current_user.abuse_report).to eq(abuse_report)
      end

      it "does not refer to the abuse report whose reporter_id is the current user" do
        create(:abuse_report, reporter: current_user, user: other_user)

        expect(current_user.abuse_report).to be_nil
      end

      it "does not update the user_id of an abuse report when the user is updated" do
        abuse_report = create(:abuse_report, reporter: current_user, user: other_user)

        current_user.block

        expect(abuse_report.reload.user).to eq(other_user)
      end
    end
72 73 74 75

    describe '#group_members' do
      it 'does not include group memberships for which user is a requester' do
        user = create(:user)
76
        group = create(:group, :public, :access_requestable)
77 78 79 80 81 82 83 84 85
        group.request_access(user)

        expect(user.group_members).to be_empty
      end
    end

    describe '#project_members' do
      it 'does not include project memberships for which user is a requester' do
        user = create(:user)
86
        project = create(:project, :public, :access_requestable)
87 88 89 90 91
        project.request_access(user)

        expect(user.project_members).to be_empty
      end
    end
92 93 94
  end

  describe 'validations' do
R
Robert Speicher 已提交
95 96 97 98 99 100 101 102 103
    describe 'username' do
      it 'validates presence' do
        expect(subject).to validate_presence_of(:username)
      end

      it 'rejects blacklisted names' do
        user = build(:user, username: 'dashboard')

        expect(user).not_to be_valid
104
        expect(user.errors.messages[:username]).to eq ['dashboard is a reserved name']
R
Robert Speicher 已提交
105 106
      end

107 108 109 110 111 112 113 114 115 116 117 118
      it 'allows child names' do
        user = build(:user, username: 'avatar')

        expect(user).to be_valid
      end

      it 'allows wildcard names' do
        user = build(:user, username: 'blob')

        expect(user).to be_valid
      end

119 120 121 122 123 124 125 126 127 128
      context 'when username is changed' do
        let(:user) { build_stubbed(:user, username: 'old_path', namespace: build_stubbed(:namespace)) }

        it 'validates move_dir is allowed for the namespace' do
          expect(user.namespace).to receive(:any_project_has_container_registry_tags?).and_return(true)
          user.username = 'new_path'
          expect(user).to be_invalid
          expect(user.errors.messages[:username].first).to match('cannot be changed if a personal project has container registry tags')
        end
      end
129

130 131 132 133 134 135 136 137 138
      context 'when the username is in use by another user' do
        let(:username) { 'foo' }
        let!(:other_user) { create(:user, username: username) }

        it 'is invalid' do
          user = build(:user, username: username)

          expect(user).not_to be_valid
          expect(user.errors.full_messages).to eq(['Username has already been taken'])
139 140
        end
      end
R
Robert Speicher 已提交
141 142
    end

143 144 145 146 147 148 149 150 151 152
    it 'has a DB-level NOT NULL constraint on projects_limit' do
      user = create(:user)

      expect(user.persisted?).to eq(true)

      expect do
        user.update_columns(projects_limit: nil)
      end.to raise_error(ActiveRecord::StatementInvalid)
    end

153 154 155 156
    it { is_expected.to validate_presence_of(:projects_limit) }
    it { is_expected.to validate_numericality_of(:projects_limit) }
    it { is_expected.to allow_value(0).for(:projects_limit) }
    it { is_expected.not_to allow_value(-1).for(:projects_limit) }
157
    it { is_expected.not_to allow_value(Gitlab::Database::MAX_INT_VALUE + 1).for(:projects_limit) }
158

159
    it { is_expected.to validate_length_of(:bio).is_at_most(255) }
160

161 162 163
    it_behaves_like 'an object with email-formated attributes', :email do
      subject { build(:user) }
    end
164

165 166 167
    it_behaves_like 'an object with email-formated attributes', :public_email, :notification_email do
      subject { build(:user).tap { |user| user.emails << build(:email, email: email_value) } }
    end
168

169
    describe 'email' do
170
      context 'when no signup domains whitelisted' do
171
        before do
172
          allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return([])
173
        end
174

175 176 177 178 179 180
        it 'accepts any email' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end
      end

181
      context 'when a signup domain is whitelisted and subdomains are allowed' do
182
        before do
183
          allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['example.com', '*.example.com'])
184
        end
185

186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201
        it 'accepts info@example.com' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end

        it 'accepts info@test.example.com' do
          user = build(:user, email: "info@test.example.com")
          expect(user).to be_valid
        end

        it 'rejects example@test.com' do
          user = build(:user, email: "example@test.com")
          expect(user).to be_invalid
        end
      end

202
      context 'when a signup domain is whitelisted and subdomains are not allowed' do
203
        before do
204
          allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['example.com'])
205
        end
206 207 208 209 210 211 212 213 214 215 216 217 218 219 220

        it 'accepts info@example.com' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end

        it 'rejects info@test.example.com' do
          user = build(:user, email: "info@test.example.com")
          expect(user).to be_invalid
        end

        it 'rejects example@test.com' do
          user = build(:user, email: "example@test.com")
          expect(user).to be_invalid
        end
221 222 223 224 225

        it 'accepts example@test.com when added by another user' do
          user = build(:user, email: "example@test.com", created_by_id: 1)
          expect(user).to be_valid
        end
226
      end
227

228 229 230 231 232 233
      context 'domain blacklist' do
        before do
          allow_any_instance_of(ApplicationSetting).to receive(:domain_blacklist_enabled?).and_return(true)
          allow_any_instance_of(ApplicationSetting).to receive(:domain_blacklist).and_return(['example.com'])
        end

234
        context 'when a signup domain is blacklisted' do
235 236 237 238 239 240 241 242 243
          it 'accepts info@test.com' do
            user = build(:user, email: 'info@test.com')
            expect(user).to be_valid
          end

          it 'rejects info@example.com' do
            user = build(:user, email: 'info@example.com')
            expect(user).not_to be_valid
          end
244 245 246 247 248

          it 'accepts info@example.com when added by another user' do
            user = build(:user, email: 'info@example.com', created_by_id: 1)
            expect(user).to be_valid
          end
249 250
        end

251
        context 'when a signup domain is blacklisted but a wildcard subdomain is allowed' do
252 253
          before do
            allow_any_instance_of(ApplicationSetting).to receive(:domain_blacklist).and_return(['test.example.com'])
254
            allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['*.example.com'])
255 256
          end

257
          it 'gives priority to whitelist and allow info@test.example.com' do
258 259 260 261 262 263 264
            user = build(:user, email: 'info@test.example.com')
            expect(user).to be_valid
          end
        end

        context 'with both lists containing a domain' do
          before do
265
            allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['test.com'])
266 267 268 269 270 271 272 273 274 275 276 277 278 279
          end

          it 'accepts info@test.com' do
            user = build(:user, email: 'info@test.com')
            expect(user).to be_valid
          end

          it 'rejects info@example.com' do
            user = build(:user, email: 'info@example.com')
            expect(user).not_to be_valid
          end
        end
      end

280 281 282 283 284 285
      context 'owns_notification_email' do
        it 'accepts temp_oauth_email emails' do
          user = build(:user, email: "temp-email-for-oauth@example.com")
          expect(user).to be_valid
        end
      end
286
    end
287 288 289 290 291 292 293
  end

  describe "scopes" do
    describe ".with_two_factor" do
      it "returns users with 2fa enabled via OTP" do
        user_with_2fa = create(:user, :two_factor_via_otp)
        user_without_2fa = create(:user)
294
        users_with_two_factor = described_class.with_two_factor.pluck(:id)
295 296 297 298 299 300 301 302

        expect(users_with_two_factor).to include(user_with_2fa.id)
        expect(users_with_two_factor).not_to include(user_without_2fa.id)
      end

      it "returns users with 2fa enabled via U2F" do
        user_with_2fa = create(:user, :two_factor_via_u2f)
        user_without_2fa = create(:user)
303
        users_with_two_factor = described_class.with_two_factor.pluck(:id)
304 305 306 307 308 309 310 311

        expect(users_with_two_factor).to include(user_with_2fa.id)
        expect(users_with_two_factor).not_to include(user_without_2fa.id)
      end

      it "returns users with 2fa enabled via OTP and U2F" do
        user_with_2fa = create(:user, :two_factor_via_otp, :two_factor_via_u2f)
        user_without_2fa = create(:user)
312
        users_with_two_factor = described_class.with_two_factor.pluck(:id)
313 314 315 316 317 318 319 320 321 322

        expect(users_with_two_factor).to eq([user_with_2fa.id])
        expect(users_with_two_factor).not_to include(user_without_2fa.id)
      end
    end

    describe ".without_two_factor" do
      it "excludes users with 2fa enabled via OTP" do
        user_with_2fa = create(:user, :two_factor_via_otp)
        user_without_2fa = create(:user)
323
        users_without_two_factor = described_class.without_two_factor.pluck(:id)
324 325 326 327 328 329 330 331

        expect(users_without_two_factor).to include(user_without_2fa.id)
        expect(users_without_two_factor).not_to include(user_with_2fa.id)
      end

      it "excludes users with 2fa enabled via U2F" do
        user_with_2fa = create(:user, :two_factor_via_u2f)
        user_without_2fa = create(:user)
332
        users_without_two_factor = described_class.without_two_factor.pluck(:id)
333 334 335 336 337 338 339 340

        expect(users_without_two_factor).to include(user_without_2fa.id)
        expect(users_without_two_factor).not_to include(user_with_2fa.id)
      end

      it "excludes users with 2fa enabled via OTP and U2F" do
        user_with_2fa = create(:user, :two_factor_via_otp, :two_factor_via_u2f)
        user_without_2fa = create(:user)
341
        users_without_two_factor = described_class.without_two_factor.pluck(:id)
342 343 344 345 346

        expect(users_without_two_factor).to include(user_without_2fa.id)
        expect(users_without_two_factor).not_to include(user_with_2fa.id)
      end
    end
V
Valery Sizov 已提交
347 348 349 350 351 352 353 354 355 356

    describe '.todo_authors' do
      it 'filters users' do
        create :user
        user_2 = create :user
        user_3 = create :user
        current_user = create :user
        create(:todo, user: current_user, author: user_2, state: :done)
        create(:todo, user: current_user, author: user_3, state: :pending)

357 358
        expect(described_class.todo_authors(current_user.id, 'pending')).to eq [user_3]
        expect(described_class.todo_authors(current_user.id, 'done')).to eq [user_2]
V
Valery Sizov 已提交
359 360
      end
    end
G
gitlabhq 已提交
361 362 363
  end

  describe "Respond to" do
B
blackst0ne 已提交
364
    it { is_expected.to respond_to(:admin?) }
365
    it { is_expected.to respond_to(:name) }
Z
Zeger-Jan van de Weg 已提交
366 367 368 369 370 371 372 373 374 375 376 377 378 379
    it { is_expected.to respond_to(:external?) }
  end

  describe 'before save hook' do
    context 'when saving an external user' do
      let(:user)          { create(:user) }
      let(:external_user) { create(:user, external: true) }

      it "sets other properties aswell" do
        expect(external_user.can_create_team).to be_falsey
        expect(external_user.can_create_group).to be_falsey
        expect(external_user.projects_limit).to be 0
      end
    end
380

381 382
    describe '#check_for_verified_email' do
      let(:user)      { create(:user) }
383 384
      let(:secondary) { create(:email, :confirmed, email: 'secondary@example.com', user: user) }

385
      it 'allows a verfied secondary email to be used as the primary without needing reconfirmation' do
L
Lin Jen-Shin 已提交
386
        user.update!(email: secondary.email)
387 388 389 390 391 392
        user.reload
        expect(user.email).to eq secondary.email
        expect(user.unconfirmed_email).to eq nil
        expect(user.confirmed?).to be_truthy
      end
    end
G
gitlabhq 已提交
393 394
  end

395
  describe 'after commit hook' do
396 397 398 399 400 401 402 403 404 405 406
    describe '#update_emails_with_primary_email' do
      before do
        @user = create(:user, email: 'primary@example.com').tap do |user|
          user.skip_reconfirmation!
        end
        @secondary = create :email, email: 'secondary@example.com', user: @user
        @user.reload
      end

      it 'gets called when email updated' do
        expect(@user).to receive(:update_emails_with_primary_email)
407

L
Lin Jen-Shin 已提交
408
        @user.update!(email: 'new_primary@example.com')
409 410
      end

411
      it 'adds old primary to secondary emails when secondary is a new email ' do
L
Lin Jen-Shin 已提交
412
        @user.update!(email: 'new_primary@example.com')
413
        @user.reload
414

415 416
        expect(@user.emails.count).to eq 2
        expect(@user.emails.pluck(:email)).to match_array([@secondary.email, 'primary@example.com'])
417 418 419
      end

      it 'adds old primary to secondary emails if secondary is becoming a primary' do
L
Lin Jen-Shin 已提交
420
        @user.update!(email: @secondary.email)
421
        @user.reload
422

423 424 425 426 427
        expect(@user.emails.count).to eq 1
        expect(@user.emails.first.email).to eq 'primary@example.com'
      end

      it 'transfers old confirmation values into new secondary' do
L
Lin Jen-Shin 已提交
428
        @user.update!(email: @secondary.email)
429
        @user.reload
430

431 432 433 434
        expect(@user.emails.count).to eq 1
        expect(@user.emails.first.confirmed_at).not_to eq nil
      end
    end
435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496

    describe '#update_notification_email' do
      # Regression: https://gitlab.com/gitlab-org/gitlab-ce/issues/22846
      context 'when changing :email' do
        let(:user) { create(:user) }
        let(:new_email) { 'new-email@example.com' }

        it 'sets :unconfirmed_email' do
          expect do
            user.tap { |u| u.update!(email: new_email) }.reload
          end.to change(user, :unconfirmed_email).to(new_email)
        end

        it 'does not change :notification_email' do
          expect do
            user.tap { |u| u.update!(email: new_email) }.reload
          end.not_to change(user, :notification_email)
        end

        it 'updates :notification_email to the new email once confirmed' do
          user.update!(email: new_email)

          expect do
            user.tap(&:confirm).reload
          end.to change(user, :notification_email).to eq(new_email)
        end

        context 'and :notification_email is set to a secondary email' do
          let!(:email_attrs) { attributes_for(:email, :confirmed, user: user) }
          let(:secondary) { create(:email, :confirmed, email: 'secondary@example.com', user: user) }

          before do
            user.emails.create(email_attrs)
            user.tap { |u| u.update!(notification_email: email_attrs[:email]) }.reload
          end

          it 'does not change :notification_email to :email' do
            expect do
              user.tap { |u| u.update!(email: new_email) }.reload
            end.not_to change(user, :notification_email)
          end

          it 'does not change :notification_email to :email once confirmed' do
            user.update!(email: new_email)

            expect do
              user.tap(&:confirm).reload
            end.not_to change(user, :notification_email)
          end
        end
      end
    end

    describe '#update_invalid_gpg_signatures' do
      let(:user) do
        create(:user, email: 'tula.torphy@abshire.ca').tap do |user|
          user.skip_reconfirmation!
        end
      end

      it 'does nothing when the name is updated' do
        expect(user).not_to receive(:update_invalid_gpg_signatures)
L
Lin Jen-Shin 已提交
497
        user.update!(name: 'Bette')
498 499 500 501
      end

      it 'synchronizes the gpg keys when the email is updated' do
        expect(user).to receive(:update_invalid_gpg_signatures).at_most(:twice)
L
Lin Jen-Shin 已提交
502
        user.update!(email: 'shawnee.ritchie@denesik.com')
503 504
      end
    end
505 506
  end

507
  describe '#update_tracked_fields!', :clean_gitlab_redis_shared_state do
508 509 510 511 512 513 514 515 516 517 518 519 520 521
    let(:request) { OpenStruct.new(remote_ip: "127.0.0.1") }
    let(:user) { create(:user) }

    it 'writes trackable attributes' do
      expect do
        user.update_tracked_fields!(request)
      end.to change { user.reload.current_sign_in_at }
    end

    it 'does not write trackable attributes when called a second time within the hour' do
      user.update_tracked_fields!(request)

      expect do
        user.update_tracked_fields!(request)
522 523 524 525 526 527 528 529 530 531 532
      end.not_to change { user.reload.current_sign_in_at }
    end

    it 'writes trackable attributes for a different user' do
      user2 = create(:user)

      user.update_tracked_fields!(request)

      expect do
        user2.update_tracked_fields!(request)
      end.to change { user2.reload.current_sign_in_at }
533
    end
534 535 536 537 538 539 540 541

    it 'does not write if the DB is in read-only mode' do
      expect(Gitlab::Database).to receive(:read_only?).and_return(true)

      expect do
        user.update_tracked_fields!(request)
      end.not_to change { user.reload.current_sign_in_at }
    end
542 543
  end

544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571
  shared_context 'user keys' do
    let(:user) { create(:user) }
    let!(:key) { create(:key, user: user) }
    let!(:deploy_key) { create(:deploy_key, user: user) }
  end

  describe '#keys' do
    include_context 'user keys'

    context 'with key and deploy key stored' do
      it 'returns stored key, but not deploy_key' do
        expect(user.keys).to include key
        expect(user.keys).not_to include deploy_key
      end
    end
  end

  describe '#deploy_keys' do
    include_context 'user keys'

    context 'with key and deploy key stored' do
      it 'returns stored deploy key, but not normal key' do
        expect(user.deploy_keys).to include deploy_key
        expect(user.deploy_keys).not_to include key
      end
    end
  end

572
  describe '#confirm' do
573 574 575
    before do
      allow_any_instance_of(ApplicationSetting).to receive(:send_user_confirmation_email).and_return(true)
    end
576

577 578 579 580 581 582 583
    let(:user) { create(:user, confirmed_at: nil, unconfirmed_email: 'test@gitlab.com') }

    it 'returns unconfirmed' do
      expect(user.confirmed?).to be_falsey
    end

    it 'confirms a user' do
584
      user.confirm
585 586 587 588
      expect(user.confirmed?).to be_truthy
    end
  end

589 590 591 592 593 594 595 596
  describe '#to_reference' do
    let(:user) { create(:user) }

    it 'returns a String reference to the object' do
      expect(user.to_reference).to eq "@#{user.username}"
    end
  end

597
  describe '#generate_password' do
598
    it "does not generate password by default" do
599
      user = create(:user, password: 'abcdefghe')
600

601
      expect(user.password).to eq('abcdefghe')
602
    end
603 604
  end

605 606 607
  describe 'ensure incoming email token' do
    it 'has incoming email token' do
      user = create(:user)
608

609 610 611 612
      expect(user.incoming_email_token).not_to be_blank
    end
  end

613 614 615 616 617 618 619
  describe '#ensure_user_rights_and_limits' do
    describe 'with external user' do
      let(:user) { create(:user, external: true) }

      it 'receives callback when external changes' do
        expect(user).to receive(:ensure_user_rights_and_limits)

L
Lin Jen-Shin 已提交
620
        user.update(external: false)
621 622 623
      end

      it 'ensures correct rights and limits for user' do
T
Tiago Botelho 已提交
624 625
        stub_config_setting(default_can_create_group: true)

L
Lin Jen-Shin 已提交
626
        expect { user.update(external: false) }.to change { user.can_create_group }.to(true)
627
          .and change { user.projects_limit }.to(Gitlab::CurrentSettings.default_projects_limit)
628 629 630 631 632 633 634 635 636
      end
    end

    describe 'without external user' do
      let(:user) { create(:user, external: false) }

      it 'receives callback when external changes' do
        expect(user).to receive(:ensure_user_rights_and_limits)

L
Lin Jen-Shin 已提交
637
        user.update(external: true)
638 639 640
      end

      it 'ensures correct rights and limits for user' do
L
Lin Jen-Shin 已提交
641
        expect { user.update(external: true) }.to change { user.can_create_group }.to(false)
642 643 644 645 646
          .and change { user.projects_limit }.to(0)
      end
    end
  end

647 648 649 650
  describe 'feed token' do
    it 'ensures a feed token on read' do
      user = create(:user, feed_token: nil)
      feed_token = user.feed_token
651

652 653
      expect(feed_token).not_to be_blank
      expect(user.reload.feed_token).to eq feed_token
654 655 656
    end
  end

657
  describe '#recently_sent_password_reset?' do
658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676
    it 'is false when reset_password_sent_at is nil' do
      user = build_stubbed(:user, reset_password_sent_at: nil)

      expect(user.recently_sent_password_reset?).to eq false
    end

    it 'is false when sent more than one minute ago' do
      user = build_stubbed(:user, reset_password_sent_at: 5.minutes.ago)

      expect(user.recently_sent_password_reset?).to eq false
    end

    it 'is true when sent less than one minute ago' do
      user = build_stubbed(:user, reset_password_sent_at: Time.now)

      expect(user.recently_sent_password_reset?).to eq true
    end
  end

R
Robert Speicher 已提交
677 678 679 680 681 682 683
  describe '#disable_two_factor!' do
    it 'clears all 2FA-related fields' do
      user = create(:user, :two_factor)

      expect(user).to be_two_factor_enabled
      expect(user.encrypted_otp_secret).not_to be_nil
      expect(user.otp_backup_codes).not_to be_nil
684
      expect(user.otp_grace_period_started_at).not_to be_nil
R
Robert Speicher 已提交
685 686 687 688 689 690 691 692

      user.disable_two_factor!

      expect(user).not_to be_two_factor_enabled
      expect(user.encrypted_otp_secret).to be_nil
      expect(user.encrypted_otp_secret_iv).to be_nil
      expect(user.encrypted_otp_secret_salt).to be_nil
      expect(user.otp_backup_codes).to be_nil
693
      expect(user.otp_grace_period_started_at).to be_nil
R
Robert Speicher 已提交
694 695 696
    end
  end

697 698
  describe 'projects' do
    before do
699
      @user = create(:user)
700

701 702
      @project = create(:project, namespace: @user.namespace)
      @project_2 = create(:project, group: create(:group)) do |project|
703
        project.add_maintainer(@user)
704
      end
705
      @project_3 = create(:project, group: create(:group)) do |project|
706 707
        project.add_developer(@user)
      end
708 709
    end

710 711 712 713 714 715 716 717 718
    it { expect(@user.authorized_projects).to include(@project) }
    it { expect(@user.authorized_projects).to include(@project_2) }
    it { expect(@user.authorized_projects).to include(@project_3) }
    it { expect(@user.owned_projects).to include(@project) }
    it { expect(@user.owned_projects).not_to include(@project_2) }
    it { expect(@user.owned_projects).not_to include(@project_3) }
    it { expect(@user.personal_projects).to include(@project) }
    it { expect(@user.personal_projects).not_to include(@project_2) }
    it { expect(@user.personal_projects).not_to include(@project_3) }
719 720 721
  end

  describe 'groups' do
722 723 724
    let(:user) { create(:user) }
    let(:group) { create(:group) }

725
    before do
726
      group.add_owner(user)
727 728
    end

729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755
    it { expect(user.several_namespaces?).to be_truthy }
    it { expect(user.authorized_groups).to eq([group]) }
    it { expect(user.owned_groups).to eq([group]) }
    it { expect(user.namespaces).to contain_exactly(user.namespace, group) }
    it { expect(user.manageable_namespaces).to contain_exactly(user.namespace, group) }

    context 'with child groups', :nested_groups do
      let!(:subgroup) { create(:group, parent: group) }

      describe '#manageable_namespaces' do
        it 'includes all the namespaces the user can manage' do
          expect(user.manageable_namespaces).to contain_exactly(user.namespace, group, subgroup)
        end
      end

      describe '#manageable_groups' do
        it 'includes all the namespaces the user can manage' do
          expect(user.manageable_groups).to contain_exactly(group, subgroup)
        end

        it 'does not include duplicates if a membership was added for the subgroup' do
          subgroup.add_owner(user)

          expect(user.manageable_groups).to contain_exactly(group, subgroup)
        end
      end
    end
756 757
  end

758 759 760 761
  describe 'group multiple owners' do
    before do
      @user = create :user
      @user2 = create :user
762 763
      @group = create :group
      @group.add_owner(@user)
764

765
      @group.add_user(@user2, GroupMember::OWNER)
766 767
    end

768
    it { expect(@user2.several_namespaces?).to be_truthy }
769 770
  end

771 772 773
  describe 'namespaced' do
    before do
      @user = create :user
774
      @project = create(:project, namespace: @user.namespace)
775 776
    end

777
    it { expect(@user.several_namespaces?).to be_falsey }
778
    it { expect(@user.namespaces).to eq([@user.namespace]) }
779 780 781 782 783
  end

  describe 'blocking user' do
    let(:user) { create(:user, name: 'John Smith') }

784
    it "blocks user" do
785
      user.block
786

787
      expect(user.blocked?).to be_truthy
788 789 790
    end
  end

791 792 793 794
  describe '.filter' do
    let(:user) { double }

    it 'filters by active users by default' do
795
      expect(described_class).to receive(:active).and_return([user])
796

797
      expect(described_class.filter(nil)).to include user
798 799
    end

800
    it 'filters by admins' do
801
      expect(described_class).to receive(:admins).and_return([user])
802

803
      expect(described_class.filter('admins')).to include user
804 805
    end

806
    it 'filters by blocked' do
807
      expect(described_class).to receive(:blocked).and_return([user])
808

809
      expect(described_class.filter('blocked')).to include user
810 811 812
    end

    it 'filters by two_factor_disabled' do
813
      expect(described_class).to receive(:without_two_factor).and_return([user])
814

815
      expect(described_class.filter('two_factor_disabled')).to include user
816 817 818
    end

    it 'filters by two_factor_enabled' do
819
      expect(described_class).to receive(:with_two_factor).and_return([user])
820

821
      expect(described_class.filter('two_factor_enabled')).to include user
822 823 824
    end

    it 'filters by wop' do
825
      expect(described_class).to receive(:without_projects).and_return([user])
826

827
      expect(described_class.filter('wop')).to include user
828
    end
829 830
  end

B
Ben Bodenmiller 已提交
831
  describe '.without_projects' do
832
    let!(:project) { create(:project, :public, :access_requestable) }
B
Ben Bodenmiller 已提交
833 834 835 836 837 838
    let!(:user) { create(:user) }
    let!(:user_without_project) { create(:user) }
    let!(:user_without_project2) { create(:user) }

    before do
      # add user to project
839
      project.add_maintainer(user)
B
Ben Bodenmiller 已提交
840 841 842 843 844 845 846 847

      # create invite to projet
      create(:project_member, :developer, project: project, invite_token: '1234', invite_email: 'inviteduser1@example.com')

      # create request to join project
      project.request_access(user_without_project2)
    end

848 849 850
    it { expect(described_class.without_projects).not_to include user }
    it { expect(described_class.without_projects).to include user_without_project }
    it { expect(described_class.without_projects).to include user_without_project2 }
B
Ben Bodenmiller 已提交
851 852
  end

853 854 855
  describe 'user creation' do
    describe 'normal user' do
      let(:user) { create(:user, name: 'John Smith') }
D
Dmitriy Zaporozhets 已提交
856

B
blackst0ne 已提交
857
      it { expect(user.admin?).to be_falsey }
858 859 860 861
      it { expect(user.require_ssh_key?).to be_truthy }
      it { expect(user.can_create_group?).to be_truthy }
      it { expect(user.can_create_project?).to be_truthy }
      it { expect(user.first_name).to eq('John') }
862
      it { expect(user.external).to be_falsey }
863
    end
864

D
Dmitriy Zaporozhets 已提交
865
    describe 'with defaults' do
866
      let(:user) { described_class.new }
D
Dmitriy Zaporozhets 已提交
867

868
      it "applies defaults to user" do
869 870
        expect(user.projects_limit).to eq(Gitlab.config.gitlab.default_projects_limit)
        expect(user.can_create_group).to eq(Gitlab.config.gitlab.default_can_create_group)
871
        expect(user.theme_id).to eq(Gitlab.config.gitlab.default_theme)
Z
Zeger-Jan van de Weg 已提交
872
        expect(user.external).to be_falsey
873 874 875
      end
    end

D
Dmitriy Zaporozhets 已提交
876
    describe 'with default overrides' do
877
      let(:user) { described_class.new(projects_limit: 123, can_create_group: false, can_create_team: true) }
D
Dmitriy Zaporozhets 已提交
878

879
      it "applies defaults to user" do
880 881
        expect(user.projects_limit).to eq(123)
        expect(user.can_create_group).to be_falsey
882
        expect(user.theme_id).to eq(1)
883
      end
884 885 886 887 888 889 890

      it 'does not undo projects_limit setting if it matches old DB default of 10' do
        # If the real default project limit is 10 then this test is worthless
        expect(Gitlab.config.gitlab.default_projects_limit).not_to eq(10)
        user = described_class.new(projects_limit: 10)
        expect(user.projects_limit).to eq(10)
      end
891
    end
892

893
    context 'when Gitlab::CurrentSettings.user_default_external is true' do
894 895 896 897 898
      before do
        stub_application_setting(user_default_external: true)
      end

      it "creates external user by default" do
899
        user = create(:user)
900 901

        expect(user.external).to be_truthy
902 903
        expect(user.can_create_group).to be_falsey
        expect(user.projects_limit).to be 0
904 905 906 907
      end

      describe 'with default overrides' do
        it "creates a non-external user" do
908
          user = create(:user, external: false)
909 910 911 912 913

          expect(user.external).to be_falsey
        end
      end
    end
914

Y
Yorick Peterse 已提交
915
    describe '#require_ssh_key?', :use_clean_rails_memory_store_caching do
916 917 918
      protocol_and_expectation = {
        'http' => false,
        'ssh' => true,
919
        '' => true
920 921 922 923 924 925 926 927 928
      }

      protocol_and_expectation.each do |protocol, expected|
        it "has correct require_ssh_key?" do
          stub_application_setting(enabled_git_access_protocol: protocol)
          user = build(:user)

          expect(user.require_ssh_key?).to eq(expected)
        end
929
      end
Y
Yorick Peterse 已提交
930 931 932 933 934 935

      it 'returns false when the user has 1 or more SSH keys' do
        key = create(:personal_key)

        expect(key.user.require_ssh_key?).to eq(false)
      end
936
    end
937
  end
938

939 940 941 942 943 944 945 946
  describe '.find_for_database_authentication' do
    it 'strips whitespace from login' do
      user = create(:user)

      expect(described_class.find_for_database_authentication({ login: " #{user.username} " })).to eq user
    end
  end

947
  describe '.find_by_any_email' do
948 949 950
    it 'finds by primary email' do
      user = create(:user, email: 'foo@example.com')

951
      expect(described_class.find_by_any_email(user.email)).to eq user
952
      expect(described_class.find_by_any_email(user.email, confirmed: true)).to eq user
953 954 955 956 957 958
    end

    it 'finds by secondary email' do
      email = create(:email, email: 'foo@example.com')
      user  = email.user

959
      expect(described_class.find_by_any_email(email.email)).to eq user
960
      expect(described_class.find_by_any_email(email.email, confirmed: true)).to eq user
961 962 963
    end

    it 'returns nil when nothing found' do
964
      expect(described_class.find_by_any_email('')).to be_nil
965
    end
966 967 968 969 970 971 972

    it 'returns nil when user is not confirmed' do
      user = create(:user, email: 'foo@example.com', confirmed_at: nil)

      expect(described_class.find_by_any_email(user.email, confirmed: false)).to eq(user)
      expect(described_class.find_by_any_email(user.email, confirmed: true)).to be_nil
    end
973 974
  end

Y
Yorick Peterse 已提交
975 976 977 978 979 980 981 982 983 984 985
  describe '.by_any_email' do
    it 'returns an ActiveRecord::Relation' do
      expect(described_class.by_any_email('foo@example.com'))
        .to be_a_kind_of(ActiveRecord::Relation)
    end

    it 'returns a relation of users' do
      user = create(:user)

      expect(described_class.by_any_email(user.email)).to eq([user])
    end
986 987 988 989 990 991

    it 'returns a relation of users for confirmed users' do
      user = create(:user)

      expect(described_class.by_any_email(user.email, confirmed: true)).to eq([user])
    end
Y
Yorick Peterse 已提交
992 993
  end

994
  describe '.search' do
995 996
    let!(:user) { create(:user, name: 'user', username: 'usern', email: 'email@gmail.com') }
    let!(:user2) { create(:user, name: 'user name', username: 'username', email: 'someemail@gmail.com') }
997
    let!(:user3) { create(:user, name: 'us', username: 'se', email: 'foo@gmail.com') }
998

999 1000 1001 1002
    describe 'name matching' do
      it 'returns users with a matching name with exact match first' do
        expect(described_class.search(user.name)).to eq([user, user2])
      end
1003

1004
      it 'returns users with a partially matching name' do
1005
        expect(described_class.search(user.name[0..2])).to eq([user, user2])
1006
      end
1007

1008 1009 1010
      it 'returns users with a matching name regardless of the casing' do
        expect(described_class.search(user2.name.upcase)).to eq([user2])
      end
1011 1012 1013 1014 1015 1016 1017 1018

      it 'returns users with a exact matching name shorter than 3 chars' do
        expect(described_class.search(user3.name)).to eq([user3])
      end

      it 'returns users with a exact matching name shorter than 3 chars regardless of the casing' do
        expect(described_class.search(user3.name.upcase)).to eq([user3])
      end
1019 1020
    end

1021 1022
    describe 'email matching' do
      it 'returns users with a matching Email' do
1023
        expect(described_class.search(user.email)).to eq([user])
1024
      end
1025

1026 1027
      it 'does not return users with a partially matching Email' do
        expect(described_class.search(user.email[0..2])).not_to include(user, user2)
1028
      end
1029

1030 1031 1032
      it 'returns users with a matching Email regardless of the casing' do
        expect(described_class.search(user2.email.upcase)).to eq([user2])
      end
1033 1034
    end

1035 1036 1037 1038
    describe 'username matching' do
      it 'returns users with a matching username' do
        expect(described_class.search(user.username)).to eq([user, user2])
      end
1039

1040
      it 'returns users with a partially matching username' do
1041
        expect(described_class.search(user.username[0..2])).to eq([user, user2])
1042
      end
1043

1044 1045 1046
      it 'returns users with a matching username regardless of the casing' do
        expect(described_class.search(user2.username.upcase)).to eq([user2])
      end
1047 1048 1049 1050 1051 1052 1053 1054

      it 'returns users with a exact matching username shorter than 3 chars' do
        expect(described_class.search(user3.username)).to eq([user3])
      end

      it 'returns users with a exact matching username shorter than 3 chars regardless of the casing' do
        expect(described_class.search(user3.username.upcase)).to eq([user3])
      end
M
Marin Jankovski 已提交
1055
    end
1056 1057 1058 1059 1060 1061 1062 1063

    it 'returns no matches for an empty string' do
      expect(described_class.search('')).to be_empty
    end

    it 'returns no matches for nil' do
      expect(described_class.search(nil)).to be_empty
    end
1064 1065 1066
  end

  describe '.search_with_secondary_emails' do
D
Douwe Maan 已提交
1067
    delegate :search_with_secondary_emails, to: :described_class
1068

1069 1070
    let!(:user) { create(:user, name: 'John Doe', username: 'john.doe', email: 'john.doe@example.com' ) }
    let!(:another_user) { create(:user, name: 'Albert Smith', username: 'albert.smith', email: 'albert.smith@example.com' ) }
1071 1072 1073
    let!(:email) do
      create(:email, user: another_user, email: 'alias@example.com')
    end
1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090

    it 'returns users with a matching name' do
      expect(search_with_secondary_emails(user.name)).to eq([user])
    end

    it 'returns users with a partially matching name' do
      expect(search_with_secondary_emails(user.name[0..2])).to eq([user])
    end

    it 'returns users with a matching name regardless of the casing' do
      expect(search_with_secondary_emails(user.name.upcase)).to eq([user])
    end

    it 'returns users with a matching email' do
      expect(search_with_secondary_emails(user.email)).to eq([user])
    end

1091 1092
    it 'does not return users with a partially matching email' do
      expect(search_with_secondary_emails(user.email[0..2])).not_to include([user])
1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114
    end

    it 'returns users with a matching email regardless of the casing' do
      expect(search_with_secondary_emails(user.email.upcase)).to eq([user])
    end

    it 'returns users with a matching username' do
      expect(search_with_secondary_emails(user.username)).to eq([user])
    end

    it 'returns users with a partially matching username' do
      expect(search_with_secondary_emails(user.username[0..2])).to eq([user])
    end

    it 'returns users with a matching username regardless of the casing' do
      expect(search_with_secondary_emails(user.username.upcase)).to eq([user])
    end

    it 'returns users with a matching whole secondary email' do
      expect(search_with_secondary_emails(email.email)).to eq([email.user])
    end

1115 1116
    it 'does not return users with a matching part of secondary email' do
      expect(search_with_secondary_emails(email.email[1..4])).not_to include([email.user])
1117
    end
1118 1119 1120 1121 1122 1123 1124 1125

    it 'returns no matches for an empty string' do
      expect(search_with_secondary_emails('')).to be_empty
    end

    it 'returns no matches for nil' do
      expect(search_with_secondary_emails(nil)).to be_empty
    end
M
Marin Jankovski 已提交
1126 1127
  end

Y
Yorick Peterse 已提交
1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144
  describe '.find_by_ssh_key_id' do
    context 'using an existing SSH key ID' do
      let(:user) { create(:user) }
      let(:key) { create(:key, user: user) }

      it 'returns the corresponding User' do
        expect(described_class.find_by_ssh_key_id(key.id)).to eq(user)
      end
    end

    context 'using an invalid SSH key ID' do
      it 'returns nil' do
        expect(described_class.find_by_ssh_key_id(-1)).to be_nil
      end
    end
  end

1145 1146 1147 1148
  describe '.by_login' do
    let(:username) { 'John' }
    let!(:user) { create(:user, username: username) }

1149
    it 'gets the correct user' do
1150 1151 1152 1153 1154 1155
      expect(described_class.by_login(user.email.upcase)).to eq user
      expect(described_class.by_login(user.email)).to eq user
      expect(described_class.by_login(username.downcase)).to eq user
      expect(described_class.by_login(username)).to eq user
      expect(described_class.by_login(nil)).to be_nil
      expect(described_class.by_login('')).to be_nil
1156 1157 1158
    end
  end

1159 1160 1161 1162 1163 1164 1165
  describe '.find_by_username' do
    it 'returns nil if not found' do
      expect(described_class.find_by_username('JohnDoe')).to be_nil
    end

    it 'is case-insensitive' do
      user = create(:user, username: 'JohnDoe')
1166

1167 1168 1169 1170
      expect(described_class.find_by_username('JOHNDOE')).to eq user
    end
  end

R
Robert Speicher 已提交
1171 1172
  describe '.find_by_username!' do
    it 'raises RecordNotFound' do
1173 1174
      expect { described_class.find_by_username!('JohnDoe') }
        .to raise_error(ActiveRecord::RecordNotFound)
R
Robert Speicher 已提交
1175 1176 1177 1178
    end

    it 'is case-insensitive' do
      user = create(:user, username: 'JohnDoe')
1179

R
Robert Speicher 已提交
1180 1181 1182 1183
      expect(described_class.find_by_username!('JOHNDOE')).to eq user
    end
  end

1184 1185 1186 1187 1188 1189 1190
  describe '.find_by_full_path' do
    let!(:user) { create(:user) }

    context 'with a route matching the given path' do
      let!(:route) { user.namespace.route }

      it 'returns the user' do
1191
        expect(described_class.find_by_full_path(route.path)).to eq(user)
1192 1193 1194
      end

      it 'is case-insensitive' do
1195 1196
        expect(described_class.find_by_full_path(route.path.upcase)).to eq(user)
        expect(described_class.find_by_full_path(route.path.downcase)).to eq(user)
1197 1198 1199 1200 1201 1202 1203 1204
      end
    end

    context 'with a redirect route matching the given path' do
      let!(:redirect_route) { user.namespace.redirect_routes.create(path: 'foo') }

      context 'without the follow_redirects option' do
        it 'returns nil' do
1205
          expect(described_class.find_by_full_path(redirect_route.path)).to eq(nil)
1206 1207 1208 1209 1210
        end
      end

      context 'with the follow_redirects option set to true' do
        it 'returns the user' do
1211
          expect(described_class.find_by_full_path(redirect_route.path, follow_redirects: true)).to eq(user)
1212 1213 1214
        end

        it 'is case-insensitive' do
1215 1216
          expect(described_class.find_by_full_path(redirect_route.path.upcase, follow_redirects: true)).to eq(user)
          expect(described_class.find_by_full_path(redirect_route.path.downcase, follow_redirects: true)).to eq(user)
1217 1218 1219 1220 1221 1222 1223
        end
      end
    end

    context 'without a route or a redirect route matching the given path' do
      context 'without the follow_redirects option' do
        it 'returns nil' do
1224
          expect(described_class.find_by_full_path('unknown')).to eq(nil)
1225 1226 1227 1228
        end
      end
      context 'with the follow_redirects option set to true' do
        it 'returns nil' do
1229
          expect(described_class.find_by_full_path('unknown', follow_redirects: true)).to eq(nil)
1230 1231 1232 1233 1234
        end
      end
    end

    context 'with a group route matching the given path' do
1235 1236
      let!(:group) { create(:group, path: 'group_path') }

M
Michael Kozono 已提交
1237
      context 'when the group namespace has an owner_id (legacy data)' do
1238 1239 1240
        before do
          group.update!(owner_id: user.id)
        end
1241

M
Michael Kozono 已提交
1242
        it 'returns nil' do
1243
          expect(described_class.find_by_full_path('group_path')).to eq(nil)
M
Michael Kozono 已提交
1244 1245 1246 1247 1248
        end
      end

      context 'when the group namespace does not have an owner_id' do
        it 'returns nil' do
1249
          expect(described_class.find_by_full_path('group_path')).to eq(nil)
M
Michael Kozono 已提交
1250
        end
1251 1252 1253 1254
      end
    end
  end

G
GitLab 已提交
1255
  describe 'all_ssh_keys' do
1256
    it { is_expected.to have_many(:keys).dependent(:destroy) }
G
GitLab 已提交
1257

1258
    it "has all ssh keys" do
G
GitLab 已提交
1259 1260 1261
      user = create :user
      key = create :key, key: "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQD33bWLBxu48Sev9Fert1yzEO4WGcWglWF7K/AwblIUFselOt/QdOL9DSjpQGxLagO1s9wl53STIO8qGS4Ms0EJZyIXOEFMjFJ5xmjSy+S37By4sG7SsltQEHMxtbtFOaW5LV2wCrX+rUsRNqLMamZjgjcPO0/EgGCXIGMAYW4O7cwGZdXWYIhQ1Vwy+CsVMDdPkPgBXqK7nR/ey8KMs8ho5fMNgB5hBw/AL9fNGhRw3QTD6Q12Nkhl4VZES2EsZqlpNnJttnPdp847DUsT6yuLRlfiQfz5Cn9ysHFdXObMN5VYIiPFwHeYCZp1X2S4fDZooRE8uOLTfxWHPXwrhqSH", user_id: user.id

1262
      expect(user.all_ssh_keys).to include(a_string_starting_with(key.key))
G
GitLab 已提交
1263
    end
G
GitLab 已提交
1264
  end
1265

1266
  describe '#avatar_type' do
D
Dmitriy Zaporozhets 已提交
1267 1268
    let(:user) { create(:user) }

1269
    it 'is true if avatar is image' do
D
Dmitriy Zaporozhets 已提交
1270
      user.update_attribute(:avatar, 'uploads/avatar.png')
1271

1272
      expect(user.avatar_type).to be_truthy
D
Dmitriy Zaporozhets 已提交
1273 1274
    end

1275
    it 'is false if avatar is html page' do
D
Dmitriy Zaporozhets 已提交
1276
      user.update_attribute(:avatar, 'uploads/avatar.html')
1277

1278
      expect(user.avatar_type).to eq(['file format is not supported. Please try one of the following supported formats: png, jpg, jpeg, gif, bmp, tiff, ico'])
D
Dmitriy Zaporozhets 已提交
1279 1280
    end
  end
J
Jerome Dalbert 已提交
1281

1282 1283 1284 1285
  describe '#avatar_url' do
    let(:user) { create(:user, :with_avatar) }

    context 'when avatar file is uploaded' do
1286
      it 'shows correct avatar url' do
1287 1288
        expect(user.avatar_url).to eq(user.avatar.url)
        expect(user.avatar_url(only_path: false)).to eq([Gitlab.config.gitlab.url, user.avatar.url].join)
1289
      end
1290 1291 1292
    end
  end

1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310
  describe '#accept_pending_invitations!' do
    let(:user) { create(:user, email: 'user@email.com') }
    let!(:project_member_invite) { create(:project_member, :invited, invite_email: user.email) }
    let!(:group_member_invite) { create(:group_member, :invited, invite_email: user.email) }
    let!(:external_project_member_invite) { create(:project_member, :invited, invite_email: 'external@email.com') }
    let!(:external_group_member_invite) { create(:group_member, :invited, invite_email: 'external@email.com') }

    it 'accepts all the user members pending invitations and returns the accepted_members' do
      accepted_members = user.accept_pending_invitations!

      expect(accepted_members).to match_array([project_member_invite, group_member_invite])
      expect(group_member_invite.reload).not_to be_invite
      expect(project_member_invite.reload).not_to be_invite
      expect(external_project_member_invite.reload).to be_invite
      expect(external_group_member_invite.reload).to be_invite
    end
  end

1311 1312 1313 1314 1315 1316 1317
  describe '#all_emails' do
    let(:user) { create(:user) }

    it 'returns all emails' do
      email_confirmed   = create :email, user: user, confirmed_at: Time.now
      email_unconfirmed = create :email, user: user
      user.reload
1318

1319
      expect(user.all_emails).to match_array([user.email, email_unconfirmed.email, email_confirmed.email])
1320 1321 1322
    end
  end

1323
  describe '#verified_emails' do
1324 1325 1326
    let(:user) { create(:user) }

    it 'returns only confirmed emails' do
B
Brett Walker 已提交
1327 1328
      email_confirmed = create :email, user: user, confirmed_at: Time.now
      create :email, user: user
1329
      user.reload
1330

1331
      expect(user.verified_emails).to match_array([user.email, email_confirmed.email])
1332 1333 1334 1335 1336 1337 1338
    end
  end

  describe '#verified_email?' do
    let(:user) { create(:user) }

    it 'returns true when the email is verified/confirmed' do
B
Brett Walker 已提交
1339 1340
      email_confirmed = create :email, user: user, confirmed_at: Time.now
      create :email, user: user
1341 1342 1343
      user.reload

      expect(user.verified_email?(user.email)).to be_truthy
1344
      expect(user.verified_email?(email_confirmed.email.titlecase)).to be_truthy
1345 1346 1347 1348 1349 1350 1351 1352 1353 1354
    end

    it 'returns false when the email is not verified/confirmed' do
      email_unconfirmed = create :email, user: user
      user.reload

      expect(user.verified_email?(email_unconfirmed.email)).to be_falsy
    end
  end

1355
  describe '#requires_ldap_check?' do
1356
    let(:user) { described_class.new }
1357

1358 1359
    it 'is false when LDAP is disabled' do
      # Create a condition which would otherwise cause 'true' to be returned
1360
      allow(user).to receive(:ldap_user?).and_return(true)
1361
      user.last_credential_check_at = nil
1362

1363
      expect(user.requires_ldap_check?).to be_falsey
1364 1365
    end

1366
    context 'when LDAP is enabled' do
1367 1368 1369
      before do
        allow(Gitlab.config.ldap).to receive(:enabled).and_return(true)
      end
1370

1371
      it 'is false for non-LDAP users' do
1372
        allow(user).to receive(:ldap_user?).and_return(false)
1373

1374
        expect(user.requires_ldap_check?).to be_falsey
1375 1376
      end

1377
      context 'and when the user is an LDAP user' do
1378 1379 1380
        before do
          allow(user).to receive(:ldap_user?).and_return(true)
        end
1381 1382 1383

        it 'is true when the user has never had an LDAP check before' do
          user.last_credential_check_at = nil
1384

1385
          expect(user.requires_ldap_check?).to be_truthy
1386 1387 1388 1389
        end

        it 'is true when the last LDAP check happened over 1 hour ago' do
          user.last_credential_check_at = 2.hours.ago
1390

1391
          expect(user.requires_ldap_check?).to be_truthy
1392
        end
1393 1394 1395 1396
      end
    end
  end

1397
  context 'ldap synchronized user' do
1398
    describe '#ldap_user?' do
1399 1400
      it 'is true if provider name starts with ldap' do
        user = create(:omniauth_user, provider: 'ldapmain')
1401

1402 1403
        expect(user.ldap_user?).to be_truthy
      end
1404

1405 1406
      it 'is false for other providers' do
        user = create(:omniauth_user, provider: 'other-provider')
1407

1408 1409 1410 1411 1412
        expect(user.ldap_user?).to be_falsey
      end

      it 'is false if no extern_uid is provided' do
        user = create(:omniauth_user, extern_uid: nil)
1413

1414 1415
        expect(user.ldap_user?).to be_falsey
      end
1416 1417
    end

1418
    describe '#ldap_identity' do
1419 1420
      it 'returns ldap identity' do
        user = create :omniauth_user
1421

1422 1423
        expect(user.ldap_identity.provider).not_to be_empty
      end
1424 1425
    end

1426 1427 1428 1429 1430
    describe '#ldap_block' do
      let(:user) { create(:omniauth_user, provider: 'ldapmain', name: 'John Smith') }

      it 'blocks user flaging the action caming from ldap' do
        user.ldap_block
1431

1432 1433 1434
        expect(user.blocked?).to be_truthy
        expect(user.ldap_blocked?).to be_truthy
      end
1435 1436 1437
    end
  end

J
Jerome Dalbert 已提交
1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476
  describe '#full_website_url' do
    let(:user) { create(:user) }

    it 'begins with http if website url omits it' do
      user.website_url = 'test.com'

      expect(user.full_website_url).to eq 'http://test.com'
    end

    it 'begins with http if website url begins with http' do
      user.website_url = 'http://test.com'

      expect(user.full_website_url).to eq 'http://test.com'
    end

    it 'begins with https if website url begins with https' do
      user.website_url = 'https://test.com'

      expect(user.full_website_url).to eq 'https://test.com'
    end
  end

  describe '#short_website_url' do
    let(:user) { create(:user) }

    it 'does not begin with http if website url omits it' do
      user.website_url = 'test.com'

      expect(user.short_website_url).to eq 'test.com'
    end

    it 'does not begin with http if website url begins with http' do
      user.website_url = 'http://test.com'

      expect(user.short_website_url).to eq 'test.com'
    end

    it 'does not begin with https if website url begins with https' do
      user.website_url = 'https://test.com'
1477

J
Jerome Dalbert 已提交
1478 1479
      expect(user.short_website_url).to eq 'test.com'
    end
G
GitLab 已提交
1480
  end
C
Ciro Santilli 已提交
1481

1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493
  describe '#sanitize_attrs' do
    let(:user) { build(:user, name: 'test & user', skype: 'test&user') }

    it 'encodes HTML entities in the Skype attribute' do
      expect { user.sanitize_attrs }.to change { user.skype }.to('test&amp;user')
    end

    it 'does not encode HTML entities in the name attribute' do
      expect { user.sanitize_attrs }.not_to change { user.name }
    end
  end

1494 1495
  describe '#starred?' do
    it 'determines if user starred a project' do
1496
      user = create :user
1497 1498
      project1 = create(:project, :public)
      project2 = create(:project, :public)
1499

1500 1501
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_falsey
1502 1503

      star1 = UsersStarProject.create!(project: project1, user: user)
1504

1505 1506
      expect(user.starred?(project1)).to be_truthy
      expect(user.starred?(project2)).to be_falsey
1507 1508

      star2 = UsersStarProject.create!(project: project2, user: user)
1509

1510 1511
      expect(user.starred?(project1)).to be_truthy
      expect(user.starred?(project2)).to be_truthy
1512 1513

      star1.destroy
1514

1515 1516
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_truthy
1517 1518

      star2.destroy
1519

1520 1521
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_falsey
1522 1523 1524
    end
  end

1525 1526
  describe '#toggle_star' do
    it 'toggles stars' do
C
Ciro Santilli 已提交
1527
      user = create :user
1528
      project = create(:project, :public)
C
Ciro Santilli 已提交
1529

1530
      expect(user.starred?(project)).to be_falsey
1531

C
Ciro Santilli 已提交
1532
      user.toggle_star(project)
1533

1534
      expect(user.starred?(project)).to be_truthy
1535

C
Ciro Santilli 已提交
1536
      user.toggle_star(project)
1537

1538
      expect(user.starred?(project)).to be_falsey
C
Ciro Santilli 已提交
1539 1540
    end
  end
V
Valery Sizov 已提交
1541

1542
  describe '#sort_by_attribute' do
V
Valery Sizov 已提交
1543
    before do
1544
      described_class.delete_all
1545 1546 1547
      @user = create :user, created_at: Date.today, current_sign_in_at: Date.today, name: 'Alpha'
      @user1 = create :user, created_at: Date.today - 1, current_sign_in_at: Date.today - 1, name: 'Omega'
      @user2 = create :user, created_at: Date.today - 2, name: 'Beta'
V
Valery Sizov 已提交
1548
    end
1549

1550
    context 'when sort by recent_sign_in' do
1551
      let(:users) { described_class.sort_by_attribute('recent_sign_in') }
1552 1553 1554 1555

      it 'sorts users by recent sign-in time' do
        expect(users.first).to eq(@user)
        expect(users.second).to eq(@user1)
1556 1557 1558
      end

      it 'pushes users who never signed in to the end' do
1559
        expect(users.third).to eq(@user2)
1560
      end
V
Valery Sizov 已提交
1561 1562
    end

1563
    context 'when sort by oldest_sign_in' do
1564
      let(:users) { described_class.sort_by_attribute('oldest_sign_in') }
1565

1566
      it 'sorts users by the oldest sign-in time' do
1567 1568
        expect(users.first).to eq(@user1)
        expect(users.second).to eq(@user)
1569 1570 1571
      end

      it 'pushes users who never signed in to the end' do
1572
        expect(users.third).to eq(@user2)
1573
      end
V
Valery Sizov 已提交
1574 1575
    end

1576
    it 'sorts users in descending order by their creation time' do
1577
      expect(described_class.sort_by_attribute('created_desc').first).to eq(@user)
V
Valery Sizov 已提交
1578 1579
    end

1580
    it 'sorts users in ascending order by their creation time' do
1581
      expect(described_class.sort_by_attribute('created_asc').first).to eq(@user2)
V
Valery Sizov 已提交
1582 1583
    end

1584
    it 'sorts users by id in descending order when nil is passed' do
1585
      expect(described_class.sort_by_attribute(nil).first).to eq(@user2)
V
Valery Sizov 已提交
1586 1587
    end
  end
1588

1589
  describe "#contributed_projects" do
1590
    subject { create(:user) }
1591
    let!(:project1) { create(:project) }
B
Bob Van Landuyt 已提交
1592
    let!(:project2) { fork_project(project3) }
1593
    let!(:project3) { create(:project) }
1594
    let!(:merge_request) { create(:merge_request, source_project: project2, target_project: project3, author: subject) }
1595
    let!(:push_event) { create(:push_event, project: project1, author: subject) }
1596
    let!(:merge_event) { create(:event, :created, project: project3, target: merge_request, author: subject) }
1597 1598

    before do
1599 1600
      project1.add_maintainer(subject)
      project2.add_maintainer(subject)
1601 1602 1603
    end

    it "includes IDs for projects the user has pushed to" do
1604
      expect(subject.contributed_projects).to include(project1)
1605 1606 1607
    end

    it "includes IDs for projects the user has had merge requests merged into" do
1608
      expect(subject.contributed_projects).to include(project3)
1609 1610 1611
    end

    it "doesn't include IDs for unrelated projects" do
1612
      expect(subject.contributed_projects).not_to include(project2)
1613 1614
    end
  end
1615

1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632
  describe '#fork_of' do
    let(:user) { create(:user) }

    it "returns a user's fork of a project" do
      project = create(:project, :public)
      user_fork = fork_project(project, user, namespace: user.namespace)

      expect(user.fork_of(project)).to eq(user_fork)
    end

    it 'returns nil if the project does not have a fork network' do
      project = create(:project)

      expect(user.fork_of(project)).to be_nil
    end
  end

1633
  describe '#can_be_removed?' do
1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648
    subject { create(:user) }

    context 'no owned groups' do
      it { expect(subject.can_be_removed?).to be_truthy }
    end

    context 'has owned groups' do
      before do
        group = create(:group)
        group.add_owner(subject)
      end

      it { expect(subject.can_be_removed?).to be_falsey }
    end
  end
1649 1650

  describe "#recent_push" do
1651 1652 1653
    let(:user) { build(:user) }
    let(:project) { build(:project) }
    let(:event) { build(:push_event) }
1654

1655 1656 1657 1658
    it 'returns the last push event for the user' do
      expect_any_instance_of(Users::LastPushEventService)
        .to receive(:last_event_for_user)
        .and_return(event)
1659

1660
      expect(user.recent_push).to eq(event)
1661 1662
    end

1663 1664 1665 1666
    it 'returns the last push event for a project when one is given' do
      expect_any_instance_of(Users::LastPushEventService)
        .to receive(:last_event_for_project)
        .and_return(event)
1667

1668
      expect(user.recent_push(project)).to eq(event)
1669
    end
1670
  end
1671 1672 1673 1674

  describe '#authorized_groups' do
    let!(:user) { create(:user) }
    let!(:private_group) { create(:group) }
1675 1676 1677 1678
    let!(:child_group) { create(:group, parent: private_group) }

    let!(:project_group) { create(:group) }
    let!(:project) { create(:project, group: project_group) }
1679 1680

    before do
1681 1682
      private_group.add_user(user, Gitlab::Access::MAINTAINER)
      project.add_maintainer(user)
1683 1684
    end

1685
    subject { user.authorized_groups }
1686

1687 1688 1689 1690 1691 1692 1693 1694 1695
    it { is_expected.to contain_exactly private_group, project_group }
  end

  describe '#membership_groups' do
    let!(:user) { create(:user) }
    let!(:parent_group) { create(:group) }
    let!(:child_group) { create(:group, parent: parent_group) }

    before do
1696
      parent_group.add_user(user, Gitlab::Access::MAINTAINER)
1697 1698 1699 1700 1701 1702 1703 1704 1705
    end

    subject { user.membership_groups }

    if Group.supports_nested_groups?
      it { is_expected.to contain_exactly parent_group, child_group }
    else
      it { is_expected.to contain_exactly parent_group }
    end
1706 1707
  end

1708 1709 1710 1711 1712 1713
  describe '#authorizations_for_projects' do
    let!(:user) { create(:user) }
    subject { Project.where("EXISTS (?)", user.authorizations_for_projects) }

    it 'includes projects that belong to a user, but no other projects' do
      owned = create(:project, :private, namespace: user.namespace)
1714
      member = create(:project, :private).tap { |p| p.add_maintainer(user) }
1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733
      other = create(:project)

      expect(subject).to include(owned)
      expect(subject).to include(member)
      expect(subject).not_to include(other)
    end

    it 'includes projects a user has access to, but no other projects' do
      other_user = create(:user)
      accessible = create(:project, :private, namespace: other_user.namespace) do |project|
        project.add_developer(user)
      end
      other = create(:project)

      expect(subject).to include(accessible)
      expect(subject).not_to include(other)
    end
  end

1734
  describe '#authorized_projects', :delete do
1735 1736 1737
    context 'with a minimum access level' do
      it 'includes projects for which the user is an owner' do
        user = create(:user)
1738
        project = create(:project, :private, namespace: user.namespace)
1739

D
Douwe Maan 已提交
1740 1741
        expect(user.authorized_projects(Gitlab::Access::REPORTER))
          .to contain_exactly(project)
1742
      end
1743

1744
      it 'includes projects for which the user is a maintainer' do
1745
        user = create(:user)
1746
        project = create(:project, :private)
1747

1748
        project.add_maintainer(user)
1749

D
Douwe Maan 已提交
1750 1751
        expect(user.authorized_projects(Gitlab::Access::REPORTER))
          .to contain_exactly(project)
1752 1753
      end
    end
1754 1755 1756

    it "includes user's personal projects" do
      user    = create(:user)
1757
      project = create(:project, :private, namespace: user.namespace)
1758 1759 1760 1761 1762 1763 1764

      expect(user.authorized_projects).to include(project)
    end

    it "includes personal projects user has been given access to" do
      user1   = create(:user)
      user2   = create(:user)
1765
      project = create(:project, :private, namespace: user1.namespace)
1766

1767
      project.add_developer(user2)
1768 1769 1770 1771 1772 1773

      expect(user2.authorized_projects).to include(project)
    end

    it "includes projects of groups user has been added to" do
      group   = create(:group)
1774
      project = create(:project, group: group)
1775 1776 1777 1778 1779 1780 1781 1782 1783
      user    = create(:user)

      group.add_developer(user)

      expect(user.authorized_projects).to include(project)
    end

    it "does not include projects of groups user has been removed from" do
      group   = create(:group)
1784
      project = create(:project, group: group)
1785 1786 1787
      user    = create(:user)

      member = group.add_developer(user)
1788

1789 1790 1791
      expect(user.authorized_projects).to include(project)

      member.destroy
1792

1793 1794 1795 1796 1797
      expect(user.authorized_projects).not_to include(project)
    end

    it "includes projects shared with user's group" do
      user    = create(:user)
1798
      project = create(:project, :private)
1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809
      group   = create(:group)

      group.add_reporter(user)
      project.project_group_links.create(group: group)

      expect(user.authorized_projects).to include(project)
    end

    it "does not include destroyed projects user had access to" do
      user1   = create(:user)
      user2   = create(:user)
1810
      project = create(:project, :private, namespace: user1.namespace)
1811

1812
      project.add_developer(user2)
1813

1814 1815 1816
      expect(user2.authorized_projects).to include(project)

      project.destroy
1817

1818 1819 1820 1821 1822
      expect(user2.authorized_projects).not_to include(project)
    end

    it "does not include projects of destroyed groups user had access to" do
      group   = create(:group)
1823
      project = create(:project, namespace: group)
1824 1825 1826
      user    = create(:user)

      group.add_developer(user)
1827

1828 1829 1830
      expect(user.authorized_projects).to include(project)

      group.destroy
1831

1832 1833
      expect(user.authorized_projects).not_to include(project)
    end
1834
  end
1835

1836 1837 1838 1839
  describe '#projects_where_can_admin_issues' do
    let(:user) { create(:user) }

    it 'includes projects for which the user access level is above or equal to reporter' do
1840 1841
      reporter_project  = create(:project) { |p| p.add_reporter(user) }
      developer_project = create(:project) { |p| p.add_developer(user) }
1842
      maintainer_project = create(:project) { |p| p.add_maintainer(user) }
1843

1844 1845
      expect(user.projects_where_can_admin_issues.to_a).to match_array([maintainer_project, developer_project, reporter_project])
      expect(user.can?(:admin_issue, maintainer_project)).to eq(true)
1846 1847 1848 1849 1850
      expect(user.can?(:admin_issue, developer_project)).to eq(true)
      expect(user.can?(:admin_issue, reporter_project)).to eq(true)
    end

    it 'does not include for which the user access level is below reporter' do
1851 1852
      project = create(:project)
      guest_project = create(:project) { |p| p.add_guest(user) }
1853 1854 1855 1856 1857 1858 1859

      expect(user.projects_where_can_admin_issues.to_a).to be_empty
      expect(user.can?(:admin_issue, guest_project)).to eq(false)
      expect(user.can?(:admin_issue, project)).to eq(false)
    end

    it 'does not include archived projects' do
1860
      project = create(:project, :archived)
1861 1862 1863 1864 1865 1866

      expect(user.projects_where_can_admin_issues.to_a).to be_empty
      expect(user.can?(:admin_issue, project)).to eq(false)
    end

    it 'does not include projects for which issues are disabled' do
1867
      project = create(:project, :issues_disabled)
1868 1869 1870 1871 1872 1873

      expect(user.projects_where_can_admin_issues.to_a).to be_empty
      expect(user.can?(:admin_issue, project)).to eq(false)
    end
  end

1874
  describe '#ci_owned_runners' do
1875
    let(:user) { create(:user) }
1876
    let!(:project) { create(:project) }
1877
    let(:runner) { create(:ci_runner, :project, projects: [project]) }
1878

1879
    context 'without any projects nor groups' do
1880
      it 'does not load' do
1881
        expect(user.ci_owned_runners).to be_empty
1882 1883 1884 1885 1886
      end
    end

    context 'with personal projects runners' do
      let(:namespace) { create(:namespace, owner: user) }
1887
      let!(:project) { create(:project, namespace: namespace) }
1888 1889

      it 'loads' do
1890
        expect(user.ci_owned_runners).to contain_exactly(runner)
1891 1892 1893 1894
      end
    end

    context 'with personal group runner' do
1895 1896
      let!(:project) { create(:project) }
      let(:group_runner) { create(:ci_runner, :group, groups: [group]) }
1897
      let!(:group) do
1898
        create(:group).tap do |group|
1899 1900 1901 1902 1903
          group.add_owner(user)
        end
      end

      it 'loads' do
1904
        expect(user.ci_owned_runners).to contain_exactly(group_runner)
1905 1906 1907 1908 1909
      end
    end

    context 'with personal project and group runner' do
      let(:namespace) { create(:namespace, owner: user) }
1910 1911
      let!(:project) { create(:project, namespace: namespace) }
      let!(:group_runner) { create(:ci_runner, :group, groups: [group]) }
1912 1913

      let!(:group) do
1914
        create(:group).tap do |group|
1915 1916 1917 1918 1919
          group.add_owner(user)
        end
      end

      it 'loads' do
1920
        expect(user.ci_owned_runners).to contain_exactly(runner, group_runner)
1921 1922 1923 1924
      end
    end

    shared_examples :member do
1925
      context 'when the user is a maintainer' do
1926
        before do
1927
          add_user(:maintainer)
1928
        end
1929

1930
        it 'loads' do
1931
          expect(user.ci_owned_runners).to contain_exactly(runner)
1932
        end
1933 1934
      end

1935
      context 'when the user is a developer' do
1936
        before do
1937
          add_user(:developer)
1938
        end
1939

1940
        it 'does not load' do
1941
          expect(user.ci_owned_runners).to be_empty
1942
        end
1943 1944 1945 1946 1947
      end
    end

    context 'with groups projects runners' do
      let(:group) { create(:group) }
1948
      let!(:project) { create(:project, group: group) }
1949 1950 1951 1952 1953 1954 1955 1956 1957

      def add_user(access)
        group.add_user(user, access)
      end

      it_behaves_like :member
    end

    context 'with groups runners' do
1958 1959
      let!(:runner) { create(:ci_runner, :group, groups: [group]) }
      let!(:group) { create(:group) }
1960

L
Lin Jen-Shin 已提交
1961
      def add_user(access)
1962 1963 1964 1965 1966 1967 1968
        group.add_user(user, access)
      end

      it_behaves_like :member
    end

    context 'with other projects runners' do
1969
      let!(:project) { create(:project) }
1970

L
Lin Jen-Shin 已提交
1971
      def add_user(access)
1972
        project.add_role(user, access)
1973 1974 1975 1976
      end

      it_behaves_like :member
    end
1977 1978 1979 1980 1981

    context 'with subgroup with different owner for project runner', :nested_groups do
      let(:group) { create(:group) }
      let(:another_user) { create(:user) }
      let(:subgroup) { create(:group, parent: group) }
1982
      let!(:project) { create(:project, group: subgroup) }
1983 1984 1985 1986 1987 1988 1989 1990 1991

      def add_user(access)
        group.add_user(user, access)
        group.add_user(another_user, :owner)
        subgroup.add_user(another_user, :owner)
      end

      it_behaves_like :member
    end
1992 1993
  end

1994
  describe '#projects_with_reporter_access_limited_to' do
1995 1996
    let(:project1) { create(:project) }
    let(:project2) { create(:project) }
1997 1998 1999
    let(:user) { create(:user) }

    before do
2000 2001
      project1.add_reporter(user)
      project2.add_guest(user)
2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016
    end

    it 'returns the projects when using a single project ID' do
      projects = user.projects_with_reporter_access_limited_to(project1.id)

      expect(projects).to eq([project1])
    end

    it 'returns the projects when using an Array of project IDs' do
      projects = user.projects_with_reporter_access_limited_to([project1.id])

      expect(projects).to eq([project1])
    end

    it 'returns the projects when using an ActiveRecord relation' do
2017 2018
      projects = user
        .projects_with_reporter_access_limited_to(Project.select(:id))
2019 2020 2021 2022 2023 2024 2025 2026 2027 2028

      expect(projects).to eq([project1])
    end

    it 'does not return projects you do not have reporter access to' do
      projects = user.projects_with_reporter_access_limited_to(project2.id)

      expect(projects).to be_empty
    end
  end
2029

2030 2031
  describe '#all_expanded_groups' do
    # foo/bar would also match foo/barbaz instead of just foo/bar and foo/bar/baz
2032 2033
    let!(:user) { create(:user) }

2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049
    #                group
    #        _______ (foo) _______
    #       |                     |
    #       |                     |
    # nested_group_1        nested_group_2
    # (bar)                 (barbaz)
    #       |                     |
    #       |                     |
    # nested_group_1_1      nested_group_2_1
    # (baz)                 (baz)
    #
    let!(:group) { create :group }
    let!(:nested_group_1) { create :group, parent: group, name: 'bar' }
    let!(:nested_group_1_1) { create :group, parent: nested_group_1, name: 'baz' }
    let!(:nested_group_2) { create :group, parent: group, name: 'barbaz' }
    let!(:nested_group_2_1) { create :group, parent: nested_group_2, name: 'baz' }
2050

2051 2052 2053 2054 2055 2056
    subject { user.all_expanded_groups }

    context 'user is not a member of any group' do
      it 'returns an empty array' do
        is_expected.to eq([])
      end
2057 2058
    end

2059 2060 2061 2062 2063 2064 2065 2066
    context 'user is member of all groups' do
      before do
        group.add_owner(user)
        nested_group_1.add_owner(user)
        nested_group_1_1.add_owner(user)
        nested_group_2.add_owner(user)
        nested_group_2_1.add_owner(user)
      end
2067

2068 2069 2070 2071 2072 2073 2074 2075
      it 'returns all groups' do
        is_expected.to match_array [
          group,
          nested_group_1, nested_group_1_1,
          nested_group_2, nested_group_2_1
        ]
      end
    end
2076

2077
    context 'user is member of the top group' do
2078 2079 2080
      before do
        group.add_owner(user)
      end
2081

2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095
      if Group.supports_nested_groups?
        it 'returns all groups' do
          is_expected.to match_array [
            group,
            nested_group_1, nested_group_1_1,
            nested_group_2, nested_group_2_1
          ]
        end
      else
        it 'returns the top-level groups' do
          is_expected.to match_array [group]
        end
      end
    end
2096

2097
    context 'user is member of the first child (internal node), branch 1', :nested_groups do
2098 2099 2100
      before do
        nested_group_1.add_owner(user)
      end
2101

2102 2103 2104 2105 2106 2107 2108 2109 2110
      it 'returns the groups in the hierarchy' do
        is_expected.to match_array [
          group,
          nested_group_1, nested_group_1_1
        ]
      end
    end

    context 'user is member of the first child (internal node), branch 2', :nested_groups do
2111 2112 2113
      before do
        nested_group_2.add_owner(user)
      end
2114

2115 2116 2117 2118 2119 2120
      it 'returns the groups in the hierarchy' do
        is_expected.to match_array [
          group,
          nested_group_2, nested_group_2_1
        ]
      end
2121 2122
    end

2123
    context 'user is member of the last child (leaf node)', :nested_groups do
2124 2125 2126
      before do
        nested_group_1_1.add_owner(user)
      end
2127 2128 2129 2130 2131 2132 2133 2134

      it 'returns the groups in the hierarchy' do
        is_expected.to match_array [
          group,
          nested_group_1, nested_group_1_1
        ]
      end
    end
2135 2136
  end

2137
  describe '#refresh_authorized_projects', :clean_gitlab_redis_shared_state do
2138 2139
    let(:project1) { create(:project) }
    let(:project2) { create(:project) }
2140 2141 2142
    let(:user) { create(:user) }

    before do
2143 2144
      project1.add_reporter(user)
      project2.add_guest(user)
2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158

      user.project_authorizations.delete_all
      user.refresh_authorized_projects
    end

    it 'refreshes the list of authorized projects' do
      expect(user.project_authorizations.count).to eq(2)
    end

    it 'stores the correct access levels' do
      expect(user.project_authorizations.where(access_level: Gitlab::Access::GUEST).exists?).to eq(true)
      expect(user.project_authorizations.where(access_level: Gitlab::Access::REPORTER).exists?).to eq(true)
    end
  end
D
Douwe Maan 已提交
2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191

  describe '#access_level=' do
    let(:user) { build(:user) }

    it 'does nothing for an invalid access level' do
      user.access_level = :invalid_access_level

      expect(user.access_level).to eq(:regular)
      expect(user.admin).to be false
    end

    it "assigns the 'admin' access level" do
      user.access_level = :admin

      expect(user.access_level).to eq(:admin)
      expect(user.admin).to be true
    end

    it "doesn't clear existing access levels when an invalid access level is passed in" do
      user.access_level = :admin
      user.access_level = :invalid_access_level

      expect(user.access_level).to eq(:admin)
      expect(user.admin).to be true
    end

    it "accepts string values in addition to symbols" do
      user.access_level = 'admin'

      expect(user.access_level).to eq(:admin)
      expect(user.admin).to be true
    end
  end
2192

2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206
  describe '#full_private_access?' do
    it 'returns false for regular user' do
      user = build(:user)

      expect(user.full_private_access?).to be_falsy
    end

    it 'returns true for admin user' do
      user = build(:user, :admin)

      expect(user.full_private_access?).to be_truthy
    end
  end

2207 2208
  describe '.ghost' do
    it "creates a ghost user if one isn't already present" do
2209
      ghost = described_class.ghost
2210 2211 2212

      expect(ghost).to be_ghost
      expect(ghost).to be_persisted
2213 2214
      expect(ghost.namespace).not_to be_nil
      expect(ghost.namespace).to be_persisted
2215 2216 2217 2218
    end

    it "does not create a second ghost user if one is already present" do
      expect do
2219 2220 2221 2222
        described_class.ghost
        described_class.ghost
      end.to change { described_class.count }.by(1)
      expect(described_class.ghost).to eq(described_class.ghost)
2223 2224 2225 2226 2227
    end

    context "when a regular user exists with the username 'ghost'" do
      it "creates a ghost user with a non-conflicting username" do
        create(:user, username: 'ghost')
2228
        ghost = described_class.ghost
2229 2230

        expect(ghost).to be_persisted
2231
        expect(ghost.username).to eq('ghost1')
2232 2233 2234 2235 2236 2237
      end
    end

    context "when a regular user exists with the email 'ghost@example.com'" do
      it "creates a ghost user with a non-conflicting email" do
        create(:user, email: 'ghost@example.com')
2238
        ghost = described_class.ghost
2239 2240

        expect(ghost).to be_persisted
2241
        expect(ghost.email).to eq('ghost1@example.com')
2242 2243
      end
    end
2244 2245 2246 2247 2248 2249 2250

    context 'when a domain whitelist is in place' do
      before do
        stub_application_setting(domain_whitelist: ['gitlab.com'])
      end

      it 'creates a ghost user' do
2251
        expect(described_class.ghost).to be_persisted
2252 2253
      end
    end
2254
  end
2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270

  describe '#update_two_factor_requirement' do
    let(:user) { create :user }

    context 'with 2FA requirement on groups' do
      let(:group1) { create :group, require_two_factor_authentication: true, two_factor_grace_period: 23 }
      let(:group2) { create :group, require_two_factor_authentication: true, two_factor_grace_period: 32 }

      before do
        group1.add_user(user, GroupMember::OWNER)
        group2.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'requires 2FA' do
2271
        expect(user.require_two_factor_authentication_from_group).to be true
2272 2273 2274 2275 2276 2277 2278
      end

      it 'uses the shortest grace period' do
        expect(user.two_factor_grace_period).to be 23
      end
    end

2279
    context 'with 2FA requirement on nested parent group', :nested_groups do
2280 2281 2282 2283 2284 2285 2286 2287 2288 2289
      let!(:group1) { create :group, require_two_factor_authentication: true }
      let!(:group1a) { create :group, require_two_factor_authentication: false, parent: group1 }

      before do
        group1a.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'requires 2FA' do
2290
        expect(user.require_two_factor_authentication_from_group).to be true
2291 2292 2293
      end
    end

2294
    context 'with 2FA requirement on nested child group', :nested_groups do
2295 2296 2297 2298 2299 2300 2301 2302 2303 2304
      let!(:group1) { create :group, require_two_factor_authentication: false }
      let!(:group1a) { create :group, require_two_factor_authentication: true, parent: group1 }

      before do
        group1.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'requires 2FA' do
2305
        expect(user.require_two_factor_authentication_from_group).to be true
2306 2307 2308
      end
    end

2309 2310 2311 2312 2313 2314 2315 2316 2317 2318
    context 'without 2FA requirement on groups' do
      let(:group) { create :group }

      before do
        group.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'does not require 2FA' do
2319
        expect(user.require_two_factor_authentication_from_group).to be false
2320 2321 2322 2323 2324 2325 2326
      end

      it 'falls back to the default grace period' do
        expect(user.two_factor_grace_period).to be 48
      end
    end
  end
J
James Lopez 已提交
2327 2328 2329

  context '.active' do
    before do
2330
      described_class.ghost
J
James Lopez 已提交
2331 2332 2333 2334 2335
      create(:user, name: 'user', state: 'active')
      create(:user, name: 'user', state: 'blocked')
    end

    it 'only counts active and non internal users' do
2336
      expect(described_class.active.count).to eq(1)
J
James Lopez 已提交
2337 2338
    end
  end
2339 2340 2341 2342 2343 2344 2345 2346

  describe 'preferred language' do
    it 'is English by default' do
      user = create(:user)

      expect(user.preferred_language).to eq('en')
    end
  end
2347 2348 2349 2350 2351 2352 2353 2354 2355 2356 2357 2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374

  context '#invalidate_issue_cache_counts' do
    let(:user) { build_stubbed(:user) }

    it 'invalidates cache for issue counter' do
      cache_mock = double

      expect(cache_mock).to receive(:delete).with(['users', user.id, 'assigned_open_issues_count'])

      allow(Rails).to receive(:cache).and_return(cache_mock)

      user.invalidate_issue_cache_counts
    end
  end

  context '#invalidate_merge_request_cache_counts' do
    let(:user) { build_stubbed(:user) }

    it 'invalidates cache for Merge Request counter' do
      cache_mock = double

      expect(cache_mock).to receive(:delete).with(['users', user.id, 'assigned_open_merge_requests_count'])

      allow(Rails).to receive(:cache).and_return(cache_mock)

      user.invalidate_merge_request_cache_counts
    end
  end
2375

A
Andreas Brandl 已提交
2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389
  context '#invalidate_personal_projects_count' do
    let(:user) { build_stubbed(:user) }

    it 'invalidates cache for personal projects counter' do
      cache_mock = double

      expect(cache_mock).to receive(:delete).with(['users', user.id, 'personal_projects_count'])

      allow(Rails).to receive(:cache).and_return(cache_mock)

      user.invalidate_personal_projects_count
    end
  end

2390
  describe '#allow_password_authentication_for_web?' do
2391 2392 2393
    context 'regular user' do
      let(:user) { build(:user) }

2394 2395
      it 'returns true when password authentication is enabled for the web interface' do
        expect(user.allow_password_authentication_for_web?).to be_truthy
2396 2397
      end

2398 2399
      it 'returns false when password authentication is disabled for the web interface' do
        stub_application_setting(password_authentication_enabled_for_web: false)
2400

2401
        expect(user.allow_password_authentication_for_web?).to be_falsey
2402 2403 2404 2405 2406 2407
      end
    end

    it 'returns false for ldap user' do
      user = create(:omniauth_user, provider: 'ldapmain')

2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430
      expect(user.allow_password_authentication_for_web?).to be_falsey
    end
  end

  describe '#allow_password_authentication_for_git?' do
    context 'regular user' do
      let(:user) { build(:user) }

      it 'returns true when password authentication is enabled for Git' do
        expect(user.allow_password_authentication_for_git?).to be_truthy
      end

      it 'returns false when password authentication is disabled Git' do
        stub_application_setting(password_authentication_enabled_for_git: false)

        expect(user.allow_password_authentication_for_git?).to be_falsey
      end
    end

    it 'returns false for ldap user' do
      user = create(:omniauth_user, provider: 'ldapmain')

      expect(user.allow_password_authentication_for_git?).to be_falsey
2431 2432
    end
  end
2433 2434 2435 2436 2437 2438

  describe '#personal_projects_count' do
    it 'returns the number of personal projects using a single query' do
      user = build(:user)
      projects = double(:projects, count: 1)

A
Andreas Brandl 已提交
2439
      expect(user).to receive(:personal_projects).and_return(projects)
2440

A
Andreas Brandl 已提交
2441
      expect(user.personal_projects_count).to eq(1)
2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453 2454
    end
  end

  describe '#projects_limit_left' do
    it 'returns the number of projects that can be created by the user' do
      user = build(:user)

      allow(user).to receive(:projects_limit).and_return(10)
      allow(user).to receive(:personal_projects_count).and_return(5)

      expect(user.projects_limit_left).to eq(5)
    end
  end
2455 2456 2457 2458 2459 2460 2461

  describe '#ensure_namespace_correct' do
    context 'for a new user' do
      let(:user) { build(:user) }

      it 'creates the namespace' do
        expect(user.namespace).to be_nil
2462

2463
        user.save!
2464

2465 2466 2467 2468 2469 2470 2471 2472 2473 2474 2475 2476 2477 2478
        expect(user.namespace).not_to be_nil
      end
    end

    context 'for an existing user' do
      let(:username) { 'foo' }
      let(:user) { create(:user, username: username) }

      context 'when the user is updated' do
        context 'when the username is changed' do
          let(:new_username) { 'bar' }

          it 'changes the namespace (just to compare to when username is not changed)' do
            expect do
2479
              Timecop.freeze(1.second.from_now) do
S
Sean McGivern 已提交
2480
                user.update!(username: new_username)
2481
              end
2482 2483 2484 2485
            end.to change { user.namespace.updated_at }
          end

          it 'updates the namespace name' do
L
Lin Jen-Shin 已提交
2486
            user.update!(username: new_username)
2487

2488 2489 2490 2491
            expect(user.namespace.name).to eq(new_username)
          end

          it 'updates the namespace path' do
L
Lin Jen-Shin 已提交
2492
            user.update!(username: new_username)
2493

2494 2495 2496 2497
            expect(user.namespace.path).to eq(new_username)
          end

          context 'when there is a validation error (namespace name taken) while updating namespace' do
2498
            let!(:conflicting_namespace) { create(:group, path: new_username) }
2499

2500
            it 'causes the user save to fail' do
L
Lin Jen-Shin 已提交
2501
              expect(user.update(username: new_username)).to be_falsey
2502
              expect(user.namespace.errors.messages[:path].first).to eq('has already been taken')
2503
            end
2504 2505

            it 'adds the namespace errors to the user' do
L
Lin Jen-Shin 已提交
2506
              user.update(username: new_username)
2507

2508
              expect(user.errors.full_messages.first).to eq('Username has already been taken')
2509
            end
2510 2511 2512 2513 2514 2515
          end
        end

        context 'when the username is not changed' do
          it 'does not change the namespace' do
            expect do
L
Lin Jen-Shin 已提交
2516
              user.update!(email: 'asdf@asdf.com')
2517 2518 2519 2520 2521 2522
            end.not_to change { user.namespace.updated_at }
          end
        end
      end
    end
  end
A
Alexis Reigel 已提交
2523

2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537 2538 2539 2540 2541 2542 2543 2544 2545
  describe '#username_changed_hook' do
    context 'for a new user' do
      let(:user) { build(:user) }

      it 'does not trigger system hook' do
        expect(user).not_to receive(:system_hook_service)

        user.save!
      end
    end

    context 'for an existing user' do
      let(:user) { create(:user, username: 'old-username') }

      context 'when the username is changed' do
        let(:new_username) { 'very-new-name' }

        it 'triggers the rename system hook' do
          system_hook_service = SystemHooksService.new
          expect(system_hook_service).to receive(:execute_hooks_for).with(user, :rename)
          expect(user).to receive(:system_hook_service).and_return(system_hook_service)

L
Lin Jen-Shin 已提交
2546
          user.update!(username: new_username)
2547 2548 2549 2550 2551 2552 2553
        end
      end

      context 'when the username is not changed' do
        it 'does not trigger system hook' do
          expect(user).not_to receive(:system_hook_service)

L
Lin Jen-Shin 已提交
2554
          user.update!(email: 'asdf@asdf.com')
2555 2556 2557 2558 2559
        end
      end
    end
  end

2560 2561 2562 2563 2564 2565
  describe '#sync_attribute?' do
    let(:user) { described_class.new }

    context 'oauth user' do
      it 'returns true if name can be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(name location))
2566

2567 2568 2569 2570 2571
        expect(user.sync_attribute?(:name)).to be_truthy
      end

      it 'returns true if email can be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(name email))
2572

2573 2574 2575 2576 2577
        expect(user.sync_attribute?(:email)).to be_truthy
      end

      it 'returns true if location can be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(location email))
2578

2579 2580 2581 2582 2583
        expect(user.sync_attribute?(:email)).to be_truthy
      end

      it 'returns false if name can not be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(location email))
2584

2585 2586 2587 2588 2589
        expect(user.sync_attribute?(:name)).to be_falsey
      end

      it 'returns false if email can not be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(location email))
2590

2591 2592 2593 2594 2595
        expect(user.sync_attribute?(:name)).to be_falsey
      end

      it 'returns false if location can not be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(location email))
2596

2597 2598 2599 2600 2601
        expect(user.sync_attribute?(:name)).to be_falsey
      end

      it 'returns true for all syncable attributes if all syncable attributes can be synced' do
        stub_omniauth_setting(sync_profile_attributes: true)
2602

2603 2604 2605 2606 2607 2608 2609 2610 2611 2612 2613 2614 2615 2616 2617
        expect(user.sync_attribute?(:name)).to be_truthy
        expect(user.sync_attribute?(:email)).to be_truthy
        expect(user.sync_attribute?(:location)).to be_truthy
      end

      it 'returns false for all syncable attributes but email if no syncable attributes are declared' do
        expect(user.sync_attribute?(:name)).to be_falsey
        expect(user.sync_attribute?(:email)).to be_truthy
        expect(user.sync_attribute?(:location)).to be_falsey
      end
    end

    context 'ldap user' do
      it 'returns true for email if ldap user' do
        allow(user).to receive(:ldap_user?).and_return(true)
2618

2619 2620 2621 2622 2623 2624 2625 2626
        expect(user.sync_attribute?(:name)).to be_falsey
        expect(user.sync_attribute?(:email)).to be_truthy
        expect(user.sync_attribute?(:location)).to be_falsey
      end

      it 'returns true for email and location if ldap user and location declared as syncable' do
        allow(user).to receive(:ldap_user?).and_return(true)
        stub_omniauth_setting(sync_profile_attributes: %w(location))
2627

2628 2629 2630 2631 2632 2633
        expect(user.sync_attribute?(:name)).to be_falsey
        expect(user.sync_attribute?(:email)).to be_truthy
        expect(user.sync_attribute?(:location)).to be_truthy
      end
    end
  end
2634 2635 2636 2637 2638 2639 2640 2641 2642 2643 2644 2645 2646 2647 2648 2649

  describe '#confirm_deletion_with_password?' do
    where(
      password_automatically_set: [true, false],
      ldap_user: [true, false],
      password_authentication_disabled: [true, false]
    )

    with_them do
      let!(:user) { create(:user, password_automatically_set: password_automatically_set) }
      let!(:identity) { create(:identity, user: user) if ldap_user }

      # Only confirm deletion with password if all inputs are false
      let(:expected) { !(password_automatically_set || ldap_user || password_authentication_disabled) }

      before do
2650 2651
        stub_application_setting(password_authentication_enabled_for_web: !password_authentication_disabled)
        stub_application_setting(password_authentication_enabled_for_git: !password_authentication_disabled)
2652 2653 2654 2655 2656 2657 2658 2659 2660 2661 2662 2663 2664 2665 2666 2667 2668 2669 2670 2671 2672 2673 2674 2675 2676 2677 2678 2679
      end

      it 'returns false unless all inputs are true' do
        expect(user.confirm_deletion_with_password?).to eq(expected)
      end
    end
  end

  describe '#delete_async' do
    let(:user) { create(:user) }
    let(:deleted_by) { create(:user) }

    it 'blocks the user then schedules them for deletion if a hard delete is specified' do
      expect(DeleteUserWorker).to receive(:perform_async).with(deleted_by.id, user.id, hard_delete: true)

      user.delete_async(deleted_by: deleted_by, params: { hard_delete: true })

      expect(user).to be_blocked
    end

    it 'schedules user for deletion without blocking them' do
      expect(DeleteUserWorker).to receive(:perform_async).with(deleted_by.id, user.id, {})

      user.delete_async(deleted_by: deleted_by)

      expect(user).not_to be_blocked
    end
  end
2680 2681 2682 2683 2684 2685

  describe '#max_member_access_for_project_ids' do
    shared_examples 'max member access for projects' do
      let(:user) { create(:user) }
      let(:group) { create(:group) }
      let(:owner_project) { create(:project, group: group) }
2686
      let(:maintainer_project) { create(:project) }
2687 2688 2689 2690 2691 2692
      let(:reporter_project) { create(:project) }
      let(:developer_project) { create(:project) }
      let(:guest_project) { create(:project) }
      let(:no_access_project) { create(:project) }

      let(:projects) do
2693
        [owner_project, maintainer_project, reporter_project, developer_project, guest_project, no_access_project].map(&:id)
2694 2695 2696 2697 2698
      end

      let(:expected) do
        {
          owner_project.id => Gitlab::Access::OWNER,
2699
          maintainer_project.id => Gitlab::Access::MAINTAINER,
2700 2701 2702 2703 2704 2705 2706 2707 2708
          reporter_project.id => Gitlab::Access::REPORTER,
          developer_project.id => Gitlab::Access::DEVELOPER,
          guest_project.id => Gitlab::Access::GUEST,
          no_access_project.id => Gitlab::Access::NO_ACCESS
        }
      end

      before do
        create(:group_member, user: user, group: group)
2709
        maintainer_project.add_maintainer(user)
2710 2711 2712 2713 2714 2715 2716 2717 2718 2719 2720 2721 2722 2723 2724 2725 2726 2727 2728 2729 2730 2731 2732 2733 2734 2735
        reporter_project.add_reporter(user)
        developer_project.add_developer(user)
        guest_project.add_guest(user)
      end

      it 'returns correct roles for different projects' do
        expect(user.max_member_access_for_project_ids(projects)).to eq(expected)
      end
    end

    context 'with RequestStore enabled', :request_store do
      include_examples 'max member access for projects'

      def access_levels(projects)
        user.max_member_access_for_project_ids(projects)
      end

      it 'does not perform extra queries when asked for projects who have already been found' do
        access_levels(projects)

        expect { access_levels(projects) }.not_to exceed_query_limit(0)

        expect(access_levels(projects)).to eq(expected)
      end

      it 'only requests the extra projects when uncached projects are passed' do
2736
        second_maintainer_project = create(:project)
2737
        second_developer_project = create(:project)
2738
        second_maintainer_project.add_maintainer(user)
2739 2740
        second_developer_project.add_developer(user)

2741
        all_projects = projects + [second_maintainer_project.id, second_developer_project.id]
2742

2743
        expected_all = expected.merge(second_maintainer_project.id => Gitlab::Access::MAINTAINER,
2744 2745 2746 2747 2748 2749 2750
                                      second_developer_project.id => Gitlab::Access::DEVELOPER)

        access_levels(projects)

        queries = ActiveRecord::QueryRecorder.new { access_levels(all_projects) }

        expect(queries.count).to eq(1)
2751
        expect(queries.log_message).to match(/\W(#{second_maintainer_project.id}, #{second_developer_project.id})\W/)
2752 2753 2754 2755 2756 2757 2758 2759 2760 2761 2762 2763 2764
        expect(access_levels(all_projects)).to eq(expected_all)
      end
    end

    context 'with RequestStore disabled' do
      include_examples 'max member access for projects'
    end
  end

  describe '#max_member_access_for_group_ids' do
    shared_examples 'max member access for groups' do
      let(:user) { create(:user) }
      let(:owner_group) { create(:group) }
2765
      let(:maintainer_group) { create(:group) }
2766 2767 2768 2769 2770 2771
      let(:reporter_group) { create(:group) }
      let(:developer_group) { create(:group) }
      let(:guest_group) { create(:group) }
      let(:no_access_group) { create(:group) }

      let(:groups) do
2772
        [owner_group, maintainer_group, reporter_group, developer_group, guest_group, no_access_group].map(&:id)
2773 2774 2775 2776 2777
      end

      let(:expected) do
        {
          owner_group.id => Gitlab::Access::OWNER,
2778
          maintainer_group.id => Gitlab::Access::MAINTAINER,
2779 2780 2781 2782 2783 2784 2785 2786 2787
          reporter_group.id => Gitlab::Access::REPORTER,
          developer_group.id => Gitlab::Access::DEVELOPER,
          guest_group.id => Gitlab::Access::GUEST,
          no_access_group.id => Gitlab::Access::NO_ACCESS
        }
      end

      before do
        owner_group.add_owner(user)
2788
        maintainer_group.add_maintainer(user)
2789 2790 2791 2792 2793 2794 2795 2796 2797 2798 2799 2800 2801 2802 2803 2804 2805 2806 2807 2808 2809 2810 2811 2812 2813 2814
        reporter_group.add_reporter(user)
        developer_group.add_developer(user)
        guest_group.add_guest(user)
      end

      it 'returns correct roles for different groups' do
        expect(user.max_member_access_for_group_ids(groups)).to eq(expected)
      end
    end

    context 'with RequestStore enabled', :request_store do
      include_examples 'max member access for groups'

      def access_levels(groups)
        user.max_member_access_for_group_ids(groups)
      end

      it 'does not perform extra queries when asked for groups who have already been found' do
        access_levels(groups)

        expect { access_levels(groups) }.not_to exceed_query_limit(0)

        expect(access_levels(groups)).to eq(expected)
      end

      it 'only requests the extra groups when uncached groups are passed' do
2815
        second_maintainer_group = create(:group)
2816
        second_developer_group = create(:group)
2817
        second_maintainer_group.add_maintainer(user)
2818 2819
        second_developer_group.add_developer(user)

2820
        all_groups = groups + [second_maintainer_group.id, second_developer_group.id]
2821

2822
        expected_all = expected.merge(second_maintainer_group.id => Gitlab::Access::MAINTAINER,
2823 2824 2825 2826 2827 2828 2829
                                      second_developer_group.id => Gitlab::Access::DEVELOPER)

        access_levels(groups)

        queries = ActiveRecord::QueryRecorder.new { access_levels(all_groups) }

        expect(queries.count).to eq(1)
2830
        expect(queries.log_message).to match(/\W(#{second_maintainer_group.id}, #{second_developer_group.id})\W/)
2831 2832 2833 2834 2835 2836 2837 2838
        expect(access_levels(all_groups)).to eq(expected_all)
      end
    end

    context 'with RequestStore disabled' do
      include_examples 'max member access for groups'
    end
  end
2839

B
Bob Van Landuyt 已提交
2840 2841
  context 'changing a username' do
    let(:user) { create(:user, username: 'foo') }
2842

B
Bob Van Landuyt 已提交
2843 2844 2845
    it 'creates a redirect route' do
      expect { user.update!(username: 'bar') }
        .to change { RedirectRoute.where(path: 'foo').count }.by(1)
2846 2847
    end

B
Bob Van Landuyt 已提交
2848 2849 2850 2851 2852
    it 'deletes the redirect when a user with the old username was created' do
      user.update!(username: 'bar')

      expect { create(:user, username: 'foo') }
        .to change { RedirectRoute.where(path: 'foo').count }.by(-1)
2853 2854
    end
  end
2855 2856 2857 2858 2859 2860 2861 2862 2863 2864 2865 2866 2867 2868 2869 2870 2871 2872 2873 2874 2875 2876 2877 2878 2879 2880

  describe '#required_terms_not_accepted?' do
    let(:user) { build(:user) }
    subject { user.required_terms_not_accepted? }

    context "when terms are not enforced" do
      it { is_expected.to be_falsy }
    end

    context "when terms are enforced and accepted by the user" do
      before do
        enforce_terms
        accept_terms(user)
      end

      it { is_expected.to be_falsy }
    end

    context "when terms are enforced but the user has not accepted" do
      before do
        enforce_terms
      end

      it { is_expected.to be_truthy }
    end
  end
2881 2882 2883 2884 2885 2886 2887 2888 2889 2890 2891 2892 2893 2894

  describe '#increment_failed_attempts!' do
    subject(:user) { create(:user, failed_attempts: 0) }

    it 'logs failed sign-in attempts' do
      expect { user.increment_failed_attempts! }.to change(user, :failed_attempts).from(0).to(1)
    end

    it 'does not log failed sign-in attempts when in a GitLab read-only instance' do
      allow(Gitlab::Database).to receive(:read_only?) { true }

      expect { user.increment_failed_attempts! }.not_to change(user, :failed_attempts)
    end
  end
J
Jan Provaznik 已提交
2895 2896 2897 2898 2899 2900 2901 2902

  context 'with uploads' do
    it_behaves_like 'model with mounted uploader', false do
      let(:model_object) { create(:user, :with_avatar) }
      let(:upload_attribute) { :avatar }
      let(:uploader_class) { AttachmentUploader }
    end
  end
G
gitlabhq 已提交
2903
end