dsa2.c 16.1 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15
/*
 * net/dsa/dsa2.c - Hardware switch handling, binding version 2
 * Copyright (c) 2008-2009 Marvell Semiconductor
 * Copyright (c) 2013 Florian Fainelli <florian@openwrt.org>
 * Copyright (c) 2016 Andrew Lunn <andrew@lunn.ch>
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 */

#include <linux/device.h>
#include <linux/err.h>
#include <linux/list.h>
16
#include <linux/netdevice.h>
17 18 19 20
#include <linux/slab.h>
#include <linux/rtnetlink.h>
#include <linux/of.h>
#include <linux/of_net.h>
21

22 23
#include "dsa_priv.h"

24
static LIST_HEAD(dsa_tree_list);
25 26
static DEFINE_MUTEX(dsa2_mutex);

27 28 29
static const struct devlink_ops dsa_devlink_ops = {
};

30
static struct dsa_switch_tree *dsa_tree_find(int index)
31 32 33
{
	struct dsa_switch_tree *dst;

34
	list_for_each_entry(dst, &dsa_tree_list, list)
35
		if (dst->index == index)
36
			return dst;
37

38 39 40
	return NULL;
}

41
static struct dsa_switch_tree *dsa_tree_alloc(int index)
42 43 44 45 46 47
{
	struct dsa_switch_tree *dst;

	dst = kzalloc(sizeof(*dst), GFP_KERNEL);
	if (!dst)
		return NULL;
48

49
	dst->index = index;
50

51
	INIT_LIST_HEAD(&dst->list);
52
	list_add_tail(&dsa_tree_list, &dst->list);
53

54 55 56 57 58
	kref_init(&dst->refcount);

	return dst;
}

59 60 61 62 63 64
static void dsa_tree_free(struct dsa_switch_tree *dst)
{
	list_del(&dst->list);
	kfree(dst);
}

65
static struct dsa_switch_tree *dsa_tree_get(struct dsa_switch_tree *dst)
66
{
67 68
	if (dst)
		kref_get(&dst->refcount);
69 70 71 72

	return dst;
}

73
static struct dsa_switch_tree *dsa_tree_touch(int index)
74
{
75 76 77 78 79 80 81
	struct dsa_switch_tree *dst;

	dst = dsa_tree_find(index);
	if (dst)
		return dsa_tree_get(dst);
	else
		return dsa_tree_alloc(index);
82 83 84 85 86 87 88 89 90 91 92 93 94
}

static void dsa_tree_release(struct kref *ref)
{
	struct dsa_switch_tree *dst;

	dst = container_of(ref, struct dsa_switch_tree, refcount);

	dsa_tree_free(dst);
}

static void dsa_tree_put(struct dsa_switch_tree *dst)
{
95 96
	if (dst)
		kref_put(&dst->refcount, dsa_tree_release);
97 98
}

99
static bool dsa_port_is_dsa(struct dsa_port *port)
100
{
101
	return port->type == DSA_PORT_TYPE_DSA;
102 103 104 105
}

static bool dsa_port_is_cpu(struct dsa_port *port)
{
106
	return port->type == DSA_PORT_TYPE_CPU;
107 108
}

109 110 111 112 113
static bool dsa_port_is_user(struct dsa_port *dp)
{
	return dp->type == DSA_PORT_TYPE_USER;
}

114 115
static struct dsa_port *dsa_tree_find_port_by_node(struct dsa_switch_tree *dst,
						   struct device_node *dn)
116 117
{
	struct dsa_switch *ds;
118 119
	struct dsa_port *dp;
	int device, port;
120

121 122
	for (device = 0; device < DSA_MAX_SWITCHES; device++) {
		ds = dst->ds[device];
123 124 125
		if (!ds)
			continue;

126 127 128 129 130 131
		for (port = 0; port < ds->num_ports; port++) {
			dp = &ds->ports[port];

			if (dp->dn == dn)
				return dp;
		}
132 133 134 135 136
	}

	return NULL;
}

V
Vivien Didelot 已提交
137
static bool dsa_port_setup_routing_table(struct dsa_port *dp)
138
{
V
Vivien Didelot 已提交
139 140 141
	struct dsa_switch *ds = dp->ds;
	struct dsa_switch_tree *dst = ds->dst;
	struct device_node *dn = dp->dn;
V
Vivien Didelot 已提交
142
	struct of_phandle_iterator it;
143
	struct dsa_port *link_dp;
V
Vivien Didelot 已提交
144
	int err;
145

V
Vivien Didelot 已提交
146 147 148 149
	of_for_each_phandle(&it, err, dn, "link", NULL, 0) {
		link_dp = dsa_tree_find_port_by_node(dst, it.node);
		if (!link_dp) {
			of_node_put(it.node);
V
Vivien Didelot 已提交
150
			return false;
V
Vivien Didelot 已提交
151
		}
152

V
Vivien Didelot 已提交
153
		ds->rtable[link_dp->ds->index] = dp->index;
154 155
	}

V
Vivien Didelot 已提交
156
	return true;
157 158
}

V
Vivien Didelot 已提交
159
static bool dsa_switch_setup_routing_table(struct dsa_switch *ds)
160
{
V
Vivien Didelot 已提交
161 162 163
	bool complete = true;
	struct dsa_port *dp;
	int i;
164

V
Vivien Didelot 已提交
165 166
	for (i = 0; i < DSA_MAX_SWITCHES; i++)
		ds->rtable[i] = DSA_RTABLE_NONE;
167

V
Vivien Didelot 已提交
168 169
	for (i = 0; i < ds->num_ports; i++) {
		dp = &ds->ports[i];
170

V
Vivien Didelot 已提交
171 172 173 174 175
		if (dsa_port_is_dsa(dp)) {
			complete = dsa_port_setup_routing_table(dp);
			if (!complete)
				break;
		}
176 177
	}

V
Vivien Didelot 已提交
178
	return complete;
179 180
}

V
Vivien Didelot 已提交
181
static bool dsa_tree_setup_routing_table(struct dsa_switch_tree *dst)
182 183
{
	struct dsa_switch *ds;
V
Vivien Didelot 已提交
184 185
	bool complete = true;
	int device;
186

V
Vivien Didelot 已提交
187 188
	for (device = 0; device < DSA_MAX_SWITCHES; device++) {
		ds = dst->ds[device];
189 190 191
		if (!ds)
			continue;

V
Vivien Didelot 已提交
192 193 194
		complete = dsa_switch_setup_routing_table(ds);
		if (!complete)
			break;
195 196
	}

V
Vivien Didelot 已提交
197
	return complete;
198 199
}

200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243
static struct dsa_port *dsa_tree_find_first_cpu(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
	struct dsa_port *dp;
	int device, port;

	for (device = 0; device < DSA_MAX_SWITCHES; device++) {
		ds = dst->ds[device];
		if (!ds)
			continue;

		for (port = 0; port < ds->num_ports; port++) {
			dp = &ds->ports[port];

			if (dsa_port_is_cpu(dp))
				return dp;
		}
	}

	return NULL;
}

static int dsa_tree_setup_default_cpu(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
	struct dsa_port *dp;
	int device, port;

	/* DSA currently only supports a single CPU port */
	dst->cpu_dp = dsa_tree_find_first_cpu(dst);
	if (!dst->cpu_dp) {
		pr_warn("Tree has no master device\n");
		return -EINVAL;
	}

	/* Assign the default CPU port to all ports of the fabric */
	for (device = 0; device < DSA_MAX_SWITCHES; device++) {
		ds = dst->ds[device];
		if (!ds)
			continue;

		for (port = 0; port < ds->num_ports; port++) {
			dp = &ds->ports[port];

244
			if (dsa_port_is_user(dp) || dsa_port_is_dsa(dp))
245 246 247 248 249 250 251 252 253 254 255 256 257
				dp->cpu_dp = dst->cpu_dp;
		}
	}

	return 0;
}

static void dsa_tree_teardown_default_cpu(struct dsa_switch_tree *dst)
{
	/* DSA currently only supports a single CPU port */
	dst->cpu_dp = NULL;
}

258
static int dsa_port_setup(struct dsa_port *dp)
259
{
260
	struct dsa_switch *ds = dp->ds;
261
	int err = 0;
262

263
	memset(&dp->devlink_port, 0, sizeof(dp->devlink_port));
264

265 266 267
	if (dp->type != DSA_PORT_TYPE_UNUSED)
		err = devlink_port_register(ds->devlink, &dp->devlink_port,
					    dp->index);
268
	if (err)
269 270
		return err;

271 272 273 274
	switch (dp->type) {
	case DSA_PORT_TYPE_UNUSED:
		break;
	case DSA_PORT_TYPE_CPU:
275 276 277 278 279 280 281 282 283 284 285 286 287 288
		/* dp->index is used now as port_number. However
		 * CPU ports should have separate numbering
		 * independent from front panel port numbers.
		 */
		devlink_port_attrs_set(&dp->devlink_port,
				       DEVLINK_PORT_FLAVOUR_CPU,
				       dp->index, false, 0);
		err = dsa_port_link_register_of(dp);
		if (err) {
			dev_err(ds->dev, "failed to setup link for port %d.%d\n",
				ds->index, dp->index);
			return err;
		}
		break;
289
	case DSA_PORT_TYPE_DSA:
290 291 292 293 294 295 296
		/* dp->index is used now as port_number. However
		 * DSA ports should have separate numbering
		 * independent from front panel port numbers.
		 */
		devlink_port_attrs_set(&dp->devlink_port,
				       DEVLINK_PORT_FLAVOUR_DSA,
				       dp->index, false, 0);
297
		err = dsa_port_link_register_of(dp);
298
		if (err) {
299
			dev_err(ds->dev, "failed to setup link for port %d.%d\n",
300 301 302 303 304
				ds->index, dp->index);
			return err;
		}
		break;
	case DSA_PORT_TYPE_USER:
305 306 307
		devlink_port_attrs_set(&dp->devlink_port,
				       DEVLINK_PORT_FLAVOUR_PHYSICAL,
				       dp->index, false, 0);
308 309 310 311 312 313 314
		err = dsa_slave_create(dp);
		if (err)
			dev_err(ds->dev, "failed to create slave for port %d.%d\n",
				ds->index, dp->index);
		else
			devlink_port_type_eth_set(&dp->devlink_port, dp->slave);
		break;
315 316 317 318 319
	}

	return 0;
}

320
static void dsa_port_teardown(struct dsa_port *dp)
321
{
322 323
	if (dp->type != DSA_PORT_TYPE_UNUSED)
		devlink_port_unregister(&dp->devlink_port);
324 325 326 327 328 329

	switch (dp->type) {
	case DSA_PORT_TYPE_UNUSED:
		break;
	case DSA_PORT_TYPE_CPU:
	case DSA_PORT_TYPE_DSA:
330
		dsa_port_link_unregister_of(dp);
331 332 333 334 335 336 337
		break;
	case DSA_PORT_TYPE_USER:
		if (dp->slave) {
			dsa_slave_destroy(dp->slave);
			dp->slave = NULL;
		}
		break;
338 339 340
	}
}

341
static int dsa_switch_setup(struct dsa_switch *ds)
342 343 344
{
	int err;

345
	/* Initialize ds->phys_mii_mask before registering the slave MDIO bus
346
	 * driver and before ops->setup() has run, since the switch drivers and
347 348 349
	 * the slave MDIO bus driver rely on these values for probing PHY
	 * devices or not
	 */
350
	ds->phys_mii_mask |= dsa_user_ports(ds);
351

352 353 354 355 356 357 358 359 360 361 362
	/* Add the switch to devlink before calling setup, so that setup can
	 * add dpipe tables
	 */
	ds->devlink = devlink_alloc(&dsa_devlink_ops, 0);
	if (!ds->devlink)
		return -ENOMEM;

	err = devlink_register(ds->devlink, ds->dev);
	if (err)
		return err;

363
	err = ds->ops->setup(ds);
364 365 366
	if (err < 0)
		return err;

V
Vivien Didelot 已提交
367 368 369 370
	err = dsa_switch_register_notifier(ds);
	if (err)
		return err;

371
	if (!ds->slave_mii_bus && ds->ops->phy_read) {
372 373 374 375 376 377 378 379 380 381 382
		ds->slave_mii_bus = devm_mdiobus_alloc(ds->dev);
		if (!ds->slave_mii_bus)
			return -ENOMEM;

		dsa_slave_mii_bus_init(ds);

		err = mdiobus_register(ds->slave_mii_bus);
		if (err < 0)
			return err;
	}

383 384 385
	return 0;
}

386
static void dsa_switch_teardown(struct dsa_switch *ds)
387
{
388
	if (ds->slave_mii_bus && ds->ops->phy_read)
389
		mdiobus_unregister(ds->slave_mii_bus);
V
Vivien Didelot 已提交
390 391

	dsa_switch_unregister_notifier(ds);
392 393 394 395 396 397 398

	if (ds->devlink) {
		devlink_unregister(ds->devlink);
		devlink_free(ds->devlink);
		ds->devlink = NULL;
	}

399 400
}

401 402 403
static int dsa_tree_setup_switches(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
404 405
	struct dsa_port *dp;
	int device, port;
406 407 408 409 410 411 412 413 414 415
	int err;

	for (device = 0; device < DSA_MAX_SWITCHES; device++) {
		ds = dst->ds[device];
		if (!ds)
			continue;

		err = dsa_switch_setup(ds);
		if (err)
			return err;
416 417 418 419 420 421 422 423

		for (port = 0; port < ds->num_ports; port++) {
			dp = &ds->ports[port];

			err = dsa_port_setup(dp);
			if (err)
				return err;
		}
424 425 426 427 428 429 430 431
	}

	return 0;
}

static void dsa_tree_teardown_switches(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
432 433
	struct dsa_port *dp;
	int device, port;
434 435 436 437 438 439

	for (device = 0; device < DSA_MAX_SWITCHES; device++) {
		ds = dst->ds[device];
		if (!ds)
			continue;

440 441 442 443 444 445
		for (port = 0; port < ds->num_ports; port++) {
			dp = &ds->ports[port];

			dsa_port_teardown(dp);
		}

446 447 448 449
		dsa_switch_teardown(ds);
	}
}

450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466
static int dsa_tree_setup_master(struct dsa_switch_tree *dst)
{
	struct dsa_port *cpu_dp = dst->cpu_dp;
	struct net_device *master = cpu_dp->master;

	/* DSA currently supports a single pair of CPU port and master device */
	return dsa_master_setup(master, cpu_dp);
}

static void dsa_tree_teardown_master(struct dsa_switch_tree *dst)
{
	struct dsa_port *cpu_dp = dst->cpu_dp;
	struct net_device *master = cpu_dp->master;

	return dsa_master_teardown(master);
}

V
Vivien Didelot 已提交
467
static int dsa_tree_setup(struct dsa_switch_tree *dst)
468
{
V
Vivien Didelot 已提交
469
	bool complete;
470 471
	int err;

V
Vivien Didelot 已提交
472 473 474 475 476 477
	if (dst->setup) {
		pr_err("DSA: tree %d already setup! Disjoint trees?\n",
		       dst->index);
		return -EEXIST;
	}

V
Vivien Didelot 已提交
478 479 480 481
	complete = dsa_tree_setup_routing_table(dst);
	if (!complete)
		return 0;

482 483 484 485
	err = dsa_tree_setup_default_cpu(dst);
	if (err)
		return err;

486 487 488
	err = dsa_tree_setup_switches(dst);
	if (err)
		return err;
489

490
	err = dsa_tree_setup_master(dst);
491 492 493
	if (err)
		return err;

V
Vivien Didelot 已提交
494 495 496
	dst->setup = true;

	pr_info("DSA: tree %d setup\n", dst->index);
497 498 499 500

	return 0;
}

V
Vivien Didelot 已提交
501
static void dsa_tree_teardown(struct dsa_switch_tree *dst)
502
{
V
Vivien Didelot 已提交
503
	if (!dst->setup)
504 505
		return;

506
	dsa_tree_teardown_master(dst);
507

508
	dsa_tree_teardown_switches(dst);
509

510
	dsa_tree_teardown_default_cpu(dst);
511

V
Vivien Didelot 已提交
512 513 514
	pr_info("DSA: tree %d torn down\n", dst->index);

	dst->setup = false;
515 516
}

517 518 519
static void dsa_tree_remove_switch(struct dsa_switch_tree *dst,
				   unsigned int index)
{
520 521
	dsa_tree_teardown(dst);

522 523 524 525 526 527 528 529
	dst->ds[index] = NULL;
	dsa_tree_put(dst);
}

static int dsa_tree_add_switch(struct dsa_switch_tree *dst,
			       struct dsa_switch *ds)
{
	unsigned int index = ds->index;
530
	int err;
531 532 533 534 535 536 537

	if (dst->ds[index])
		return -EBUSY;

	dsa_tree_get(dst);
	dst->ds[index] = ds;

538 539 540 541 542
	err = dsa_tree_setup(dst);
	if (err)
		dsa_tree_remove_switch(dst, index);

	return err;
543 544
}

545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564
static int dsa_port_parse_user(struct dsa_port *dp, const char *name)
{
	if (!name)
		name = "eth%d";

	dp->type = DSA_PORT_TYPE_USER;
	dp->name = name;

	return 0;
}

static int dsa_port_parse_dsa(struct dsa_port *dp)
{
	dp->type = DSA_PORT_TYPE_DSA;

	return 0;
}

static int dsa_port_parse_cpu(struct dsa_port *dp, struct net_device *master)
{
565 566 567 568 569
	struct dsa_switch *ds = dp->ds;
	struct dsa_switch_tree *dst = ds->dst;
	const struct dsa_device_ops *tag_ops;
	enum dsa_tag_protocol tag_protocol;

570
	tag_protocol = ds->ops->get_tag_protocol(ds, dp->index);
571 572 573 574 575 576
	tag_ops = dsa_resolve_tag_protocol(tag_protocol);
	if (IS_ERR(tag_ops)) {
		dev_warn(ds->dev, "No tagger for this switch\n");
		return PTR_ERR(tag_ops);
	}

577
	dp->type = DSA_PORT_TYPE_CPU;
578 579
	dp->rcv = tag_ops->rcv;
	dp->tag_ops = tag_ops;
580
	dp->master = master;
581
	dp->dst = dst;
582 583 584 585

	return 0;
}

586 587
static int dsa_port_parse_of(struct dsa_port *dp, struct device_node *dn)
{
588
	struct device_node *ethernet = of_parse_phandle(dn, "ethernet", 0);
589
	const char *name = of_get_property(dn, "label", NULL);
590
	bool link = of_property_read_bool(dn, "link");
591

592 593
	dp->dn = dn;

594
	if (ethernet) {
595 596 597 598 599 600
		struct net_device *master;

		master = of_find_net_device_by_node(ethernet);
		if (!master)
			return -EPROBE_DEFER;

601
		return dsa_port_parse_cpu(dp, master);
602 603
	}

604 605
	if (link)
		return dsa_port_parse_dsa(dp);
606

607
	return dsa_port_parse_user(dp, name);
608 609
}

V
Vivien Didelot 已提交
610 611
static int dsa_switch_parse_ports_of(struct dsa_switch *ds,
				     struct device_node *dn)
612
{
613
	struct device_node *ports, *port;
614
	struct dsa_port *dp;
615
	u32 reg;
616 617 618 619 620 621 622
	int err;

	ports = of_get_child_by_name(dn, "ports");
	if (!ports) {
		dev_err(ds->dev, "no ports child node found\n");
		return -EINVAL;
	}
623 624 625 626 627 628

	for_each_available_child_of_node(ports, port) {
		err = of_property_read_u32(port, "reg", &reg);
		if (err)
			return err;

629
		if (reg >= ds->num_ports)
630 631
			return -EINVAL;

632 633 634 635 636
		dp = &ds->ports[reg];

		err = dsa_port_parse_of(dp, port);
		if (err)
			return err;
637 638 639 640 641
	}

	return 0;
}

V
Vivien Didelot 已提交
642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674
static int dsa_switch_parse_member_of(struct dsa_switch *ds,
				      struct device_node *dn)
{
	u32 m[2] = { 0, 0 };
	int sz;

	/* Don't error out if this optional property isn't found */
	sz = of_property_read_variable_u32_array(dn, "dsa,member", m, 2, 2);
	if (sz < 0 && sz != -EINVAL)
		return sz;

	ds->index = m[1];
	if (ds->index >= DSA_MAX_SWITCHES)
		return -EINVAL;

	ds->dst = dsa_tree_touch(m[0]);
	if (!ds->dst)
		return -ENOMEM;

	return 0;
}

static int dsa_switch_parse_of(struct dsa_switch *ds, struct device_node *dn)
{
	int err;

	err = dsa_switch_parse_member_of(ds, dn);
	if (err)
		return err;

	return dsa_switch_parse_ports_of(ds, dn);
}

675 676 677
static int dsa_port_parse(struct dsa_port *dp, const char *name,
			  struct device *dev)
{
678
	if (!strcmp(name, "cpu")) {
679 680 681 682 683 684 685 686
		struct net_device *master;

		master = dsa_dev_to_net_device(dev);
		if (!master)
			return -EPROBE_DEFER;

		dev_put(master);

687
		return dsa_port_parse_cpu(dp, master);
688 689
	}

690 691
	if (!strcmp(name, "dsa"))
		return dsa_port_parse_dsa(dp);
692

693
	return dsa_port_parse_user(dp, name);
694 695
}

V
Vivien Didelot 已提交
696 697
static int dsa_switch_parse_ports(struct dsa_switch *ds,
				  struct dsa_chip_data *cd)
698 699
{
	bool valid_name_found = false;
700 701 702
	struct dsa_port *dp;
	struct device *dev;
	const char *name;
703
	unsigned int i;
704
	int err;
705 706

	for (i = 0; i < DSA_MAX_PORTS; i++) {
707 708 709 710 711
		name = cd->port_names[i];
		dev = cd->netdev[i];
		dp = &ds->ports[i];

		if (!name)
712 713
			continue;

714 715 716 717
		err = dsa_port_parse(dp, name, dev);
		if (err)
			return err;

718 719 720 721 722 723 724 725 726
		valid_name_found = true;
	}

	if (!valid_name_found && i == DSA_MAX_PORTS)
		return -EINVAL;

	return 0;
}

V
Vivien Didelot 已提交
727
static int dsa_switch_parse(struct dsa_switch *ds, struct dsa_chip_data *cd)
728
{
V
Vivien Didelot 已提交
729
	ds->cd = cd;
730

V
Vivien Didelot 已提交
731 732 733 734 735 736 737
	/* We don't support interconnected switches nor multiple trees via
	 * platform data, so this is the unique switch of the tree.
	 */
	ds->index = 0;
	ds->dst = dsa_tree_touch(0);
	if (!ds->dst)
		return -ENOMEM;
738

V
Vivien Didelot 已提交
739
	return dsa_switch_parse_ports(ds, cd);
740 741
}

742 743 744 745 746 747 748
static int dsa_switch_add(struct dsa_switch *ds)
{
	struct dsa_switch_tree *dst = ds->dst;

	return dsa_tree_add_switch(dst, ds);
}

749
static int dsa_switch_probe(struct dsa_switch *ds)
750
{
751 752
	struct dsa_chip_data *pdata = ds->dev->platform_data;
	struct device_node *np = ds->dev->of_node;
V
Vivien Didelot 已提交
753
	int err;
754

V
Vivien Didelot 已提交
755 756 757 758 759 760
	if (np)
		err = dsa_switch_parse_of(ds, np);
	else if (pdata)
		err = dsa_switch_parse(ds, pdata);
	else
		err = -ENODEV;
761

V
Vivien Didelot 已提交
762 763
	if (err)
		return err;
764

765
	return dsa_switch_add(ds);
766 767
}

768 769 770 771
struct dsa_switch *dsa_switch_alloc(struct device *dev, size_t n)
{
	size_t size = sizeof(struct dsa_switch) + n * sizeof(struct dsa_port);
	struct dsa_switch *ds;
772
	int i;
773 774 775 776 777 778 779 780

	ds = devm_kzalloc(dev, size, GFP_KERNEL);
	if (!ds)
		return NULL;

	ds->dev = dev;
	ds->num_ports = n;

781 782 783 784 785
	for (i = 0; i < ds->num_ports; ++i) {
		ds->ports[i].index = i;
		ds->ports[i].ds = ds;
	}

786 787 788 789
	return ds;
}
EXPORT_SYMBOL_GPL(dsa_switch_alloc);

790
int dsa_register_switch(struct dsa_switch *ds)
791 792 793 794
{
	int err;

	mutex_lock(&dsa2_mutex);
795
	err = dsa_switch_probe(ds);
796
	dsa_tree_put(ds->dst);
797 798 799 800 801 802
	mutex_unlock(&dsa2_mutex);

	return err;
}
EXPORT_SYMBOL_GPL(dsa_register_switch);

803
static void dsa_switch_remove(struct dsa_switch *ds)
804 805
{
	struct dsa_switch_tree *dst = ds->dst;
806
	unsigned int index = ds->index;
807

808
	dsa_tree_remove_switch(dst, index);
809 810 811 812 813
}

void dsa_unregister_switch(struct dsa_switch *ds)
{
	mutex_lock(&dsa2_mutex);
814
	dsa_switch_remove(ds);
815 816 817
	mutex_unlock(&dsa2_mutex);
}
EXPORT_SYMBOL_GPL(dsa_unregister_switch);