dsa2.c 16.7 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15
/*
 * net/dsa/dsa2.c - Hardware switch handling, binding version 2
 * Copyright (c) 2008-2009 Marvell Semiconductor
 * Copyright (c) 2013 Florian Fainelli <florian@openwrt.org>
 * Copyright (c) 2016 Andrew Lunn <andrew@lunn.ch>
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 */

#include <linux/device.h>
#include <linux/err.h>
#include <linux/list.h>
16
#include <linux/netdevice.h>
17 18 19 20
#include <linux/slab.h>
#include <linux/rtnetlink.h>
#include <linux/of.h>
#include <linux/of_net.h>
21

22 23
#include "dsa_priv.h"

24
static LIST_HEAD(dsa_tree_list);
25 26
static DEFINE_MUTEX(dsa2_mutex);

27 28 29
static const struct devlink_ops dsa_devlink_ops = {
};

30
static struct dsa_switch_tree *dsa_tree_find(int index)
31 32 33
{
	struct dsa_switch_tree *dst;

34
	list_for_each_entry(dst, &dsa_tree_list, list)
35
		if (dst->index == index)
36
			return dst;
37

38 39 40
	return NULL;
}

41
static struct dsa_switch_tree *dsa_tree_alloc(int index)
42 43 44 45 46 47
{
	struct dsa_switch_tree *dst;

	dst = kzalloc(sizeof(*dst), GFP_KERNEL);
	if (!dst)
		return NULL;
48

49
	dst->index = index;
50

51
	INIT_LIST_HEAD(&dst->list);
52
	list_add_tail(&dsa_tree_list, &dst->list);
53 54

	/* Initialize the reference counter to the number of switches, not 1 */
55
	kref_init(&dst->refcount);
56
	refcount_set(&dst->refcount.refcount, 0);
57 58 59 60

	return dst;
}

61 62 63 64 65 66
static void dsa_tree_free(struct dsa_switch_tree *dst)
{
	list_del(&dst->list);
	kfree(dst);
}

67 68 69 70 71 72 73 74 75 76 77
static struct dsa_switch_tree *dsa_tree_touch(int index)
{
	struct dsa_switch_tree *dst;

	dst = dsa_tree_find(index);
	if (!dst)
		dst = dsa_tree_alloc(index);

	return dst;
}

78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96
static void dsa_tree_get(struct dsa_switch_tree *dst)
{
	kref_get(&dst->refcount);
}

static void dsa_tree_release(struct kref *ref)
{
	struct dsa_switch_tree *dst;

	dst = container_of(ref, struct dsa_switch_tree, refcount);

	dsa_tree_free(dst);
}

static void dsa_tree_put(struct dsa_switch_tree *dst)
{
	kref_put(&dst->refcount, dsa_tree_release);
}

97 98 99
static void dsa_dst_add_ds(struct dsa_switch_tree *dst,
			   struct dsa_switch *ds, u32 index)
{
100
	dsa_tree_get(dst);
101 102 103 104 105 106 107
	dst->ds[index] = ds;
}

static void dsa_dst_del_ds(struct dsa_switch_tree *dst,
			   struct dsa_switch *ds, u32 index)
{
	dst->ds[index] = NULL;
108
	dsa_tree_put(dst);
109 110
}

111 112 113
/* For platform data configurations, we need to have a valid name argument to
 * differentiate a disabled port from an enabled one
 */
114
static bool dsa_port_is_valid(struct dsa_port *port)
115
{
116
	return port->type != DSA_PORT_TYPE_UNUSED;
117 118
}

119
static bool dsa_port_is_dsa(struct dsa_port *port)
120
{
121
	return port->type == DSA_PORT_TYPE_DSA;
122 123 124 125
}

static bool dsa_port_is_cpu(struct dsa_port *port)
{
126
	return port->type == DSA_PORT_TYPE_CPU;
127 128
}

129 130
static bool dsa_ds_find_port_dn(struct dsa_switch *ds,
				struct device_node *port)
131 132 133
{
	u32 index;

134
	for (index = 0; index < ds->num_ports; index++)
135 136 137 138 139
		if (ds->ports[index].dn == port)
			return true;
	return false;
}

140 141
static struct dsa_switch *dsa_dst_find_port_dn(struct dsa_switch_tree *dst,
					       struct device_node *port)
142 143 144 145 146 147 148 149 150
{
	struct dsa_switch *ds;
	u32 index;

	for (index = 0; index < DSA_MAX_SWITCHES; index++) {
		ds = dst->ds[index];
		if (!ds)
			continue;

151
		if (dsa_ds_find_port_dn(ds, port))
152 153 154 155 156 157 158 159
			return ds;
	}

	return NULL;
}

static int dsa_port_complete(struct dsa_switch_tree *dst,
			     struct dsa_switch *src_ds,
160
			     struct dsa_port *port,
161 162 163 164 165 166 167
			     u32 src_port)
{
	struct device_node *link;
	int index;
	struct dsa_switch *dst_ds;

	for (index = 0;; index++) {
168
		link = of_parse_phandle(port->dn, "link", index);
169 170 171
		if (!link)
			break;

172
		dst_ds = dsa_dst_find_port_dn(dst, link);
173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190
		of_node_put(link);

		if (!dst_ds)
			return 1;

		src_ds->rtable[dst_ds->index] = src_port;
	}

	return 0;
}

/* A switch is complete if all the DSA ports phandles point to ports
 * known in the tree. A return value of 1 means the tree is not
 * complete. This is not an error condition. A value of 0 is
 * success.
 */
static int dsa_ds_complete(struct dsa_switch_tree *dst, struct dsa_switch *ds)
{
191
	struct dsa_port *port;
192 193 194
	u32 index;
	int err;

195
	for (index = 0; index < ds->num_ports; index++) {
196 197
		port = &ds->ports[index];
		if (!dsa_port_is_valid(port))
198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234
			continue;

		if (!dsa_port_is_dsa(port))
			continue;

		err = dsa_port_complete(dst, ds, port, index);
		if (err != 0)
			return err;
	}

	return 0;
}

/* A tree is complete if all the DSA ports phandles point to ports
 * known in the tree. A return value of 1 means the tree is not
 * complete. This is not an error condition. A value of 0 is
 * success.
 */
static int dsa_dst_complete(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
	u32 index;
	int err;

	for (index = 0; index < DSA_MAX_SWITCHES; index++) {
		ds = dst->ds[index];
		if (!ds)
			continue;

		err = dsa_ds_complete(dst, ds);
		if (err != 0)
			return err;
	}

	return 0;
}

235
static int dsa_dsa_port_apply(struct dsa_port *port)
236
{
237
	struct dsa_switch *ds = port->ds;
238 239
	int err;

240
	err = dsa_port_fixed_link_register_of(port);
241 242
	if (err) {
		dev_warn(ds->dev, "Failed to setup dsa port %d: %d\n",
243
			 port->index, err);
244 245 246
		return err;
	}

247
	memset(&port->devlink_port, 0, sizeof(port->devlink_port));
248

249 250
	return devlink_port_register(ds->devlink, &port->devlink_port,
				     port->index);
251 252
}

253
static void dsa_dsa_port_unapply(struct dsa_port *port)
254
{
255
	devlink_port_unregister(&port->devlink_port);
256
	dsa_port_fixed_link_unregister_of(port);
257 258
}

259
static int dsa_cpu_port_apply(struct dsa_port *port)
260
{
261
	struct dsa_switch *ds = port->ds;
262 263
	int err;

264
	err = dsa_port_fixed_link_register_of(port);
265 266
	if (err) {
		dev_warn(ds->dev, "Failed to setup cpu port %d: %d\n",
267
			 port->index, err);
268 269 270
		return err;
	}

271 272 273
	memset(&port->devlink_port, 0, sizeof(port->devlink_port));
	err = devlink_port_register(ds->devlink, &port->devlink_port,
				    port->index);
274
	return err;
275 276
}

277
static void dsa_cpu_port_unapply(struct dsa_port *port)
278
{
279
	devlink_port_unregister(&port->devlink_port);
280
	dsa_port_fixed_link_unregister_of(port);
281 282
}

283
static int dsa_user_port_apply(struct dsa_port *port)
284
{
285
	struct dsa_switch *ds = port->ds;
286 287
	int err;

288
	err = dsa_slave_create(port);
289 290
	if (err) {
		dev_warn(ds->dev, "Failed to create slave %d: %d\n",
291
			 port->index, err);
292
		port->slave = NULL;
293 294 295
		return err;
	}

296 297 298
	memset(&port->devlink_port, 0, sizeof(port->devlink_port));
	err = devlink_port_register(ds->devlink, &port->devlink_port,
				    port->index);
299 300 301
	if (err)
		return err;

302
	devlink_port_type_eth_set(&port->devlink_port, port->slave);
303

304 305 306
	return 0;
}

307
static void dsa_user_port_unapply(struct dsa_port *port)
308
{
309
	devlink_port_unregister(&port->devlink_port);
310 311 312
	if (port->slave) {
		dsa_slave_destroy(port->slave);
		port->slave = NULL;
313 314 315 316 317
	}
}

static int dsa_ds_apply(struct dsa_switch_tree *dst, struct dsa_switch *ds)
{
318
	struct dsa_port *port;
319 320 321
	u32 index;
	int err;

322
	/* Initialize ds->phys_mii_mask before registering the slave MDIO bus
323
	 * driver and before ops->setup() has run, since the switch drivers and
324 325 326
	 * the slave MDIO bus driver rely on these values for probing PHY
	 * devices or not
	 */
327
	ds->phys_mii_mask |= dsa_user_ports(ds);
328

329 330 331 332 333 334 335 336 337 338 339
	/* Add the switch to devlink before calling setup, so that setup can
	 * add dpipe tables
	 */
	ds->devlink = devlink_alloc(&dsa_devlink_ops, 0);
	if (!ds->devlink)
		return -ENOMEM;

	err = devlink_register(ds->devlink, ds->dev);
	if (err)
		return err;

340
	err = ds->ops->setup(ds);
341 342 343
	if (err < 0)
		return err;

V
Vivien Didelot 已提交
344 345 346 347
	err = dsa_switch_register_notifier(ds);
	if (err)
		return err;

348
	if (!ds->slave_mii_bus && ds->ops->phy_read) {
349 350 351 352 353 354 355 356 357 358 359
		ds->slave_mii_bus = devm_mdiobus_alloc(ds->dev);
		if (!ds->slave_mii_bus)
			return -ENOMEM;

		dsa_slave_mii_bus_init(ds);

		err = mdiobus_register(ds->slave_mii_bus);
		if (err < 0)
			return err;
	}

360
	for (index = 0; index < ds->num_ports; index++) {
361 362
		port = &ds->ports[index];
		if (!dsa_port_is_valid(port))
363 364 365
			continue;

		if (dsa_port_is_dsa(port)) {
366
			err = dsa_dsa_port_apply(port);
367 368 369 370 371 372
			if (err)
				return err;
			continue;
		}

		if (dsa_port_is_cpu(port)) {
373
			err = dsa_cpu_port_apply(port);
374 375 376 377 378
			if (err)
				return err;
			continue;
		}

379
		err = dsa_user_port_apply(port);
380 381 382 383 384 385 386 387 388
		if (err)
			continue;
	}

	return 0;
}

static void dsa_ds_unapply(struct dsa_switch_tree *dst, struct dsa_switch *ds)
{
389
	struct dsa_port *port;
390 391
	u32 index;

392
	for (index = 0; index < ds->num_ports; index++) {
393 394
		port = &ds->ports[index];
		if (!dsa_port_is_valid(port))
395 396 397
			continue;

		if (dsa_port_is_dsa(port)) {
398
			dsa_dsa_port_unapply(port);
399 400 401 402
			continue;
		}

		if (dsa_port_is_cpu(port)) {
403
			dsa_cpu_port_unapply(port);
404 405 406
			continue;
		}

407
		dsa_user_port_unapply(port);
408
	}
409

410
	if (ds->slave_mii_bus && ds->ops->phy_read)
411
		mdiobus_unregister(ds->slave_mii_bus);
V
Vivien Didelot 已提交
412 413

	dsa_switch_unregister_notifier(ds);
414 415 416 417 418 419 420

	if (ds->devlink) {
		devlink_unregister(ds->devlink);
		devlink_free(ds->devlink);
		ds->devlink = NULL;
	}

421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443
}

static int dsa_dst_apply(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
	u32 index;
	int err;

	for (index = 0; index < DSA_MAX_SWITCHES; index++) {
		ds = dst->ds[index];
		if (!ds)
			continue;

		err = dsa_ds_apply(dst, ds);
		if (err)
			return err;
	}

	/* If we use a tagging format that doesn't have an ethertype
	 * field, make sure that all packets from this point on get
	 * sent to the tag format's receive function.
	 */
	wmb();
444
	dst->cpu_dp->master->dsa_ptr = dst->cpu_dp;
445

446
	err = dsa_master_ethtool_setup(dst->cpu_dp->master);
447 448 449
	if (err)
		return err;

450 451 452 453 454 455 456 457 458 459 460 461 462
	dst->applied = true;

	return 0;
}

static void dsa_dst_unapply(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
	u32 index;

	if (!dst->applied)
		return;

463
	dsa_master_ethtool_restore(dst->cpu_dp->master);
464

465
	dst->cpu_dp->master->dsa_ptr = NULL;
466 467 468 469 470 471 472 473 474 475 476 477 478 479 480

	/* If we used a tagging format that doesn't have an ethertype
	 * field, make sure that all packets from this point get sent
	 * without the tag and go through the regular receive path.
	 */
	wmb();

	for (index = 0; index < DSA_MAX_SWITCHES; index++) {
		ds = dst->ds[index];
		if (!ds)
			continue;

		dsa_ds_unapply(dst, ds);
	}

481
	dst->cpu_dp = NULL;
482

483
	pr_info("DSA: tree %d unapplied\n", dst->index);
484 485 486
	dst->applied = false;
}

487
static int dsa_cpu_parse(struct dsa_port *port, u32 index,
488 489 490
			 struct dsa_switch_tree *dst,
			 struct dsa_switch *ds)
{
491
	const struct dsa_device_ops *tag_ops;
492
	enum dsa_tag_protocol tag_protocol;
493

494
	if (!dst->cpu_dp)
495
		dst->cpu_dp = port;
496

497
	tag_protocol = ds->ops->get_tag_protocol(ds);
498 499
	tag_ops = dsa_resolve_tag_protocol(tag_protocol);
	if (IS_ERR(tag_ops)) {
500
		dev_warn(ds->dev, "No tagger for this switch\n");
501
		return PTR_ERR(tag_ops);
502 503
	}

V
Vivien Didelot 已提交
504
	dst->cpu_dp->tag_ops = tag_ops;
505 506 507 508

	/* Make a few copies for faster access in master receive hot path */
	dst->cpu_dp->rcv = dst->cpu_dp->tag_ops->rcv;
	dst->cpu_dp->dst = dst;
509 510 511 512 513 514

	return 0;
}

static int dsa_ds_parse(struct dsa_switch_tree *dst, struct dsa_switch *ds)
{
515
	struct dsa_port *port;
516 517 518
	u32 index;
	int err;

519
	for (index = 0; index < ds->num_ports; index++) {
520
		port = &ds->ports[index];
521 522
		if (!dsa_port_is_valid(port) ||
		    dsa_port_is_dsa(port))
523 524 525 526 527 528 529
			continue;

		if (dsa_port_is_cpu(port)) {
			err = dsa_cpu_parse(port, index, dst, ds);
			if (err)
				return err;
		}
530

531 532
	}

533
	pr_info("DSA: switch %d %d parsed\n", dst->index, ds->index);
534 535 536 537 538 539 540

	return 0;
}

static int dsa_dst_parse(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
541
	struct dsa_port *dp;
542
	u32 index;
543
	int port;
544 545 546 547 548 549 550 551 552 553 554 555
	int err;

	for (index = 0; index < DSA_MAX_SWITCHES; index++) {
		ds = dst->ds[index];
		if (!ds)
			continue;

		err = dsa_ds_parse(dst, ds);
		if (err)
			return err;
	}

556
	if (!dst->cpu_dp) {
557 558 559 560
		pr_warn("Tree has no master device\n");
		return -EINVAL;
	}

561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577
	/* Assign the default CPU port to all ports of the fabric */
	for (index = 0; index < DSA_MAX_SWITCHES; index++) {
		ds = dst->ds[index];
		if (!ds)
			continue;

		for (port = 0; port < ds->num_ports; port++) {
			dp = &ds->ports[port];
			if (!dsa_port_is_valid(dp) ||
			    dsa_port_is_dsa(dp) ||
			    dsa_port_is_cpu(dp))
				continue;

			dp->cpu_dp = dst->cpu_dp;
		}
	}

578
	pr_info("DSA: tree %d parsed\n", dst->index);
579 580 581 582

	return 0;
}

583 584
static int dsa_port_parse_of(struct dsa_port *dp, struct device_node *dn)
{
585 586
	struct device_node *ethernet = of_parse_phandle(dn, "ethernet", 0);
	struct device_node *link = of_parse_phandle(dn, "link", 0);
587
	const char *name = of_get_property(dn, "label", NULL);
588 589

	if (ethernet) {
590 591 592 593 594 595
		struct net_device *master;

		master = of_find_net_device_by_node(ethernet);
		if (!master)
			return -EPROBE_DEFER;

596
		dp->type = DSA_PORT_TYPE_CPU;
597
		dp->master = master;
598 599 600
	} else if (link) {
		dp->type = DSA_PORT_TYPE_DSA;
	} else {
601 602 603
		if (!name)
			name = "eth%d";

604
		dp->type = DSA_PORT_TYPE_USER;
605
		dp->name = name;
606 607
	}

608 609 610 611 612
	dp->dn = dn;

	return 0;
}

613
static int dsa_parse_ports_of(struct device_node *dn, struct dsa_switch *ds)
614
{
615
	struct device_node *ports, *port;
616
	struct dsa_port *dp;
617
	u32 reg;
618 619 620 621 622 623 624
	int err;

	ports = of_get_child_by_name(dn, "ports");
	if (!ports) {
		dev_err(ds->dev, "no ports child node found\n");
		return -EINVAL;
	}
625 626 627 628 629 630

	for_each_available_child_of_node(ports, port) {
		err = of_property_read_u32(port, "reg", &reg);
		if (err)
			return err;

631
		if (reg >= ds->num_ports)
632 633
			return -EINVAL;

634 635 636 637 638
		dp = &ds->ports[reg];

		err = dsa_port_parse_of(dp, port);
		if (err)
			return err;
639 640 641 642 643
	}

	return 0;
}

644 645 646
static int dsa_port_parse(struct dsa_port *dp, const char *name,
			  struct device *dev)
{
647
	if (!strcmp(name, "cpu")) {
648 649 650 651 652 653 654 655
		struct net_device *master;

		master = dsa_dev_to_net_device(dev);
		if (!master)
			return -EPROBE_DEFER;

		dev_put(master);

656
		dp->type = DSA_PORT_TYPE_CPU;
657
		dp->master = master;
658 659 660 661 662 663
	} else if (!strcmp(name, "dsa")) {
		dp->type = DSA_PORT_TYPE_DSA;
	} else {
		dp->type = DSA_PORT_TYPE_USER;
	}

664 665 666 667 668
	dp->name = name;

	return 0;
}

669 670 671
static int dsa_parse_ports(struct dsa_chip_data *cd, struct dsa_switch *ds)
{
	bool valid_name_found = false;
672 673 674
	struct dsa_port *dp;
	struct device *dev;
	const char *name;
675
	unsigned int i;
676
	int err;
677 678

	for (i = 0; i < DSA_MAX_PORTS; i++) {
679 680 681 682 683
		name = cd->port_names[i];
		dev = cd->netdev[i];
		dp = &ds->ports[i];

		if (!name)
684 685
			continue;

686 687 688 689
		err = dsa_port_parse(dp, name, dev);
		if (err)
			return err;

690 691 692 693 694 695 696 697 698
		valid_name_found = true;
	}

	if (!valid_name_found && i == DSA_MAX_PORTS)
		return -EINVAL;

	return 0;
}

699
static int dsa_parse_member_dn(struct device_node *np, u32 *tree, u32 *index)
700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722
{
	int err;

	*tree = *index = 0;

	err = of_property_read_u32_index(np, "dsa,member", 0, tree);
	if (err) {
		/* Does not exist, but it is optional */
		if (err == -EINVAL)
			return 0;
		return err;
	}

	err = of_property_read_u32_index(np, "dsa,member", 1, index);
	if (err)
		return err;

	if (*index >= DSA_MAX_SWITCHES)
		return -EINVAL;

	return 0;
}

723 724 725 726 727 728 729 730 731 732 733 734
static int dsa_parse_member(struct dsa_chip_data *pd, u32 *tree, u32 *index)
{
	if (!pd)
		return -ENODEV;

	/* We do not support complex trees with dsa_chip_data */
	*tree = 0;
	*index = 0;

	return 0;
}

735
static int _dsa_register_switch(struct dsa_switch *ds)
736
{
737 738
	struct dsa_chip_data *pdata = ds->dev->platform_data;
	struct device_node *np = ds->dev->of_node;
739 740
	struct dsa_switch_tree *dst;
	u32 tree, index;
741
	int i, err;
742

743 744 745 746
	if (np) {
		err = dsa_parse_member_dn(np, &tree, &index);
		if (err)
			return err;
747

748
		err = dsa_parse_ports_of(np, ds);
749 750 751 752 753 754 755 756 757 758 759
		if (err)
			return err;
	} else {
		err = dsa_parse_member(pdata, &tree, &index);
		if (err)
			return err;

		err = dsa_parse_ports(pdata, ds);
		if (err)
			return err;
	}
760

761 762 763
	dst = dsa_tree_touch(tree);
	if (!dst)
		return -ENOMEM;
764

765 766
	if (dst->ds[index])
		return -EBUSY;
767 768 769

	ds->dst = dst;
	ds->index = index;
770
	ds->cd = pdata;
771 772 773 774 775

	/* Initialize the routing table */
	for (i = 0; i < DSA_MAX_SWITCHES; ++i)
		ds->rtable[i] = DSA_RTABLE_NONE;

776 777 778 779 780 781
	dsa_dst_add_ds(dst, ds, index);

	err = dsa_dst_complete(dst);
	if (err < 0)
		goto out_del_dst;

782 783 784
	/* Not all switches registered yet */
	if (err == 1)
		return 0;
785 786 787 788 789 790 791

	if (dst->applied) {
		pr_info("DSA: Disjoint trees?\n");
		return -EINVAL;
	}

	err = dsa_dst_parse(dst);
792
	if (err)
793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808
		goto out_del_dst;

	err = dsa_dst_apply(dst);
	if (err) {
		dsa_dst_unapply(dst);
		goto out_del_dst;
	}

	return 0;

out_del_dst:
	dsa_dst_del_ds(dst, ds, ds->index);

	return err;
}

809 810 811 812
struct dsa_switch *dsa_switch_alloc(struct device *dev, size_t n)
{
	size_t size = sizeof(struct dsa_switch) + n * sizeof(struct dsa_port);
	struct dsa_switch *ds;
813
	int i;
814 815 816 817 818 819 820 821

	ds = devm_kzalloc(dev, size, GFP_KERNEL);
	if (!ds)
		return NULL;

	ds->dev = dev;
	ds->num_ports = n;

822 823 824 825 826
	for (i = 0; i < ds->num_ports; ++i) {
		ds->ports[i].index = i;
		ds->ports[i].ds = ds;
	}

827 828 829 830
	return ds;
}
EXPORT_SYMBOL_GPL(dsa_switch_alloc);

831
int dsa_register_switch(struct dsa_switch *ds)
832 833 834 835
{
	int err;

	mutex_lock(&dsa2_mutex);
836
	err = _dsa_register_switch(ds);
837 838 839 840 841 842
	mutex_unlock(&dsa2_mutex);

	return err;
}
EXPORT_SYMBOL_GPL(dsa_register_switch);

843
static void _dsa_unregister_switch(struct dsa_switch *ds)
844 845 846 847 848 849 850 851 852 853 854 855 856 857 858
{
	struct dsa_switch_tree *dst = ds->dst;

	dsa_dst_unapply(dst);

	dsa_dst_del_ds(dst, ds, ds->index);
}

void dsa_unregister_switch(struct dsa_switch *ds)
{
	mutex_lock(&dsa2_mutex);
	_dsa_unregister_switch(ds);
	mutex_unlock(&dsa2_mutex);
}
EXPORT_SYMBOL_GPL(dsa_unregister_switch);