dsa2.c 17.0 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15
/*
 * net/dsa/dsa2.c - Hardware switch handling, binding version 2
 * Copyright (c) 2008-2009 Marvell Semiconductor
 * Copyright (c) 2013 Florian Fainelli <florian@openwrt.org>
 * Copyright (c) 2016 Andrew Lunn <andrew@lunn.ch>
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 */

#include <linux/device.h>
#include <linux/err.h>
#include <linux/list.h>
16
#include <linux/netdevice.h>
17 18 19 20
#include <linux/slab.h>
#include <linux/rtnetlink.h>
#include <linux/of.h>
#include <linux/of_net.h>
21

22 23
#include "dsa_priv.h"

24
static LIST_HEAD(dsa_tree_list);
25 26
static DEFINE_MUTEX(dsa2_mutex);

27 28 29
static const struct devlink_ops dsa_devlink_ops = {
};

30
static struct dsa_switch_tree *dsa_tree_find(int index)
31 32 33
{
	struct dsa_switch_tree *dst;

34
	list_for_each_entry(dst, &dsa_tree_list, list)
35
		if (dst->index == index)
36
			return dst;
37

38 39 40
	return NULL;
}

41
static struct dsa_switch_tree *dsa_tree_alloc(int index)
42 43 44 45 46 47
{
	struct dsa_switch_tree *dst;

	dst = kzalloc(sizeof(*dst), GFP_KERNEL);
	if (!dst)
		return NULL;
48

49
	dst->index = index;
50

51
	INIT_LIST_HEAD(&dst->list);
52
	list_add_tail(&dsa_tree_list, &dst->list);
53 54

	/* Initialize the reference counter to the number of switches, not 1 */
55
	kref_init(&dst->refcount);
56
	refcount_set(&dst->refcount.refcount, 0);
57 58 59 60

	return dst;
}

61 62 63 64 65 66
static void dsa_tree_free(struct dsa_switch_tree *dst)
{
	list_del(&dst->list);
	kfree(dst);
}

67 68 69 70 71 72 73 74 75 76 77
static struct dsa_switch_tree *dsa_tree_touch(int index)
{
	struct dsa_switch_tree *dst;

	dst = dsa_tree_find(index);
	if (!dst)
		dst = dsa_tree_alloc(index);

	return dst;
}

78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96
static void dsa_tree_get(struct dsa_switch_tree *dst)
{
	kref_get(&dst->refcount);
}

static void dsa_tree_release(struct kref *ref)
{
	struct dsa_switch_tree *dst;

	dst = container_of(ref, struct dsa_switch_tree, refcount);

	dsa_tree_free(dst);
}

static void dsa_tree_put(struct dsa_switch_tree *dst)
{
	kref_put(&dst->refcount, dsa_tree_release);
}

97 98 99
/* For platform data configurations, we need to have a valid name argument to
 * differentiate a disabled port from an enabled one
 */
100
static bool dsa_port_is_valid(struct dsa_port *port)
101
{
102
	return port->type != DSA_PORT_TYPE_UNUSED;
103 104
}

105
static bool dsa_port_is_dsa(struct dsa_port *port)
106
{
107
	return port->type == DSA_PORT_TYPE_DSA;
108 109 110 111
}

static bool dsa_port_is_cpu(struct dsa_port *port)
{
112
	return port->type == DSA_PORT_TYPE_CPU;
113 114
}

115 116 117 118 119
static bool dsa_port_is_user(struct dsa_port *dp)
{
	return dp->type == DSA_PORT_TYPE_USER;
}

120 121
static bool dsa_ds_find_port_dn(struct dsa_switch *ds,
				struct device_node *port)
122 123 124
{
	u32 index;

125
	for (index = 0; index < ds->num_ports; index++)
126 127 128 129 130
		if (ds->ports[index].dn == port)
			return true;
	return false;
}

131 132
static struct dsa_switch *dsa_dst_find_port_dn(struct dsa_switch_tree *dst,
					       struct device_node *port)
133 134 135 136 137 138 139 140 141
{
	struct dsa_switch *ds;
	u32 index;

	for (index = 0; index < DSA_MAX_SWITCHES; index++) {
		ds = dst->ds[index];
		if (!ds)
			continue;

142
		if (dsa_ds_find_port_dn(ds, port))
143 144 145 146 147 148 149 150
			return ds;
	}

	return NULL;
}

static int dsa_port_complete(struct dsa_switch_tree *dst,
			     struct dsa_switch *src_ds,
151
			     struct dsa_port *port,
152 153 154 155 156 157 158
			     u32 src_port)
{
	struct device_node *link;
	int index;
	struct dsa_switch *dst_ds;

	for (index = 0;; index++) {
159
		link = of_parse_phandle(port->dn, "link", index);
160 161 162
		if (!link)
			break;

163
		dst_ds = dsa_dst_find_port_dn(dst, link);
164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181
		of_node_put(link);

		if (!dst_ds)
			return 1;

		src_ds->rtable[dst_ds->index] = src_port;
	}

	return 0;
}

/* A switch is complete if all the DSA ports phandles point to ports
 * known in the tree. A return value of 1 means the tree is not
 * complete. This is not an error condition. A value of 0 is
 * success.
 */
static int dsa_ds_complete(struct dsa_switch_tree *dst, struct dsa_switch *ds)
{
182
	struct dsa_port *port;
183 184 185
	u32 index;
	int err;

186
	for (index = 0; index < ds->num_ports; index++) {
187 188
		port = &ds->ports[index];
		if (!dsa_port_is_valid(port))
189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225
			continue;

		if (!dsa_port_is_dsa(port))
			continue;

		err = dsa_port_complete(dst, ds, port, index);
		if (err != 0)
			return err;
	}

	return 0;
}

/* A tree is complete if all the DSA ports phandles point to ports
 * known in the tree. A return value of 1 means the tree is not
 * complete. This is not an error condition. A value of 0 is
 * success.
 */
static int dsa_dst_complete(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
	u32 index;
	int err;

	for (index = 0; index < DSA_MAX_SWITCHES; index++) {
		ds = dst->ds[index];
		if (!ds)
			continue;

		err = dsa_ds_complete(dst, ds);
		if (err != 0)
			return err;
	}

	return 0;
}

226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283
static struct dsa_port *dsa_tree_find_first_cpu(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
	struct dsa_port *dp;
	int device, port;

	for (device = 0; device < DSA_MAX_SWITCHES; device++) {
		ds = dst->ds[device];
		if (!ds)
			continue;

		for (port = 0; port < ds->num_ports; port++) {
			dp = &ds->ports[port];

			if (dsa_port_is_cpu(dp))
				return dp;
		}
	}

	return NULL;
}

static int dsa_tree_setup_default_cpu(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
	struct dsa_port *dp;
	int device, port;

	/* DSA currently only supports a single CPU port */
	dst->cpu_dp = dsa_tree_find_first_cpu(dst);
	if (!dst->cpu_dp) {
		pr_warn("Tree has no master device\n");
		return -EINVAL;
	}

	/* Assign the default CPU port to all ports of the fabric */
	for (device = 0; device < DSA_MAX_SWITCHES; device++) {
		ds = dst->ds[device];
		if (!ds)
			continue;

		for (port = 0; port < ds->num_ports; port++) {
			dp = &ds->ports[port];

			if (dsa_port_is_user(dp))
				dp->cpu_dp = dst->cpu_dp;
		}
	}

	return 0;
}

static void dsa_tree_teardown_default_cpu(struct dsa_switch_tree *dst)
{
	/* DSA currently only supports a single CPU port */
	dst->cpu_dp = NULL;
}

284
static int dsa_dsa_port_apply(struct dsa_port *port)
285
{
286
	struct dsa_switch *ds = port->ds;
287 288
	int err;

289
	err = dsa_port_fixed_link_register_of(port);
290 291
	if (err) {
		dev_warn(ds->dev, "Failed to setup dsa port %d: %d\n",
292
			 port->index, err);
293 294 295
		return err;
	}

296
	memset(&port->devlink_port, 0, sizeof(port->devlink_port));
297

298 299
	return devlink_port_register(ds->devlink, &port->devlink_port,
				     port->index);
300 301
}

302
static void dsa_dsa_port_unapply(struct dsa_port *port)
303
{
304
	devlink_port_unregister(&port->devlink_port);
305
	dsa_port_fixed_link_unregister_of(port);
306 307
}

308
static int dsa_cpu_port_apply(struct dsa_port *port)
309
{
310
	struct dsa_switch *ds = port->ds;
311 312
	int err;

313
	err = dsa_port_fixed_link_register_of(port);
314 315
	if (err) {
		dev_warn(ds->dev, "Failed to setup cpu port %d: %d\n",
316
			 port->index, err);
317 318 319
		return err;
	}

320 321 322
	memset(&port->devlink_port, 0, sizeof(port->devlink_port));
	err = devlink_port_register(ds->devlink, &port->devlink_port,
				    port->index);
323
	return err;
324 325
}

326
static void dsa_cpu_port_unapply(struct dsa_port *port)
327
{
328
	devlink_port_unregister(&port->devlink_port);
329
	dsa_port_fixed_link_unregister_of(port);
330 331
}

332
static int dsa_user_port_apply(struct dsa_port *port)
333
{
334
	struct dsa_switch *ds = port->ds;
335 336
	int err;

337
	err = dsa_slave_create(port);
338 339
	if (err) {
		dev_warn(ds->dev, "Failed to create slave %d: %d\n",
340
			 port->index, err);
341
		port->slave = NULL;
342 343 344
		return err;
	}

345 346 347
	memset(&port->devlink_port, 0, sizeof(port->devlink_port));
	err = devlink_port_register(ds->devlink, &port->devlink_port,
				    port->index);
348 349 350
	if (err)
		return err;

351
	devlink_port_type_eth_set(&port->devlink_port, port->slave);
352

353 354 355
	return 0;
}

356
static void dsa_user_port_unapply(struct dsa_port *port)
357
{
358
	devlink_port_unregister(&port->devlink_port);
359 360 361
	if (port->slave) {
		dsa_slave_destroy(port->slave);
		port->slave = NULL;
362 363 364 365 366
	}
}

static int dsa_ds_apply(struct dsa_switch_tree *dst, struct dsa_switch *ds)
{
367
	struct dsa_port *port;
368 369 370
	u32 index;
	int err;

371
	/* Initialize ds->phys_mii_mask before registering the slave MDIO bus
372
	 * driver and before ops->setup() has run, since the switch drivers and
373 374 375
	 * the slave MDIO bus driver rely on these values for probing PHY
	 * devices or not
	 */
376
	ds->phys_mii_mask |= dsa_user_ports(ds);
377

378 379 380 381 382 383 384 385 386 387 388
	/* Add the switch to devlink before calling setup, so that setup can
	 * add dpipe tables
	 */
	ds->devlink = devlink_alloc(&dsa_devlink_ops, 0);
	if (!ds->devlink)
		return -ENOMEM;

	err = devlink_register(ds->devlink, ds->dev);
	if (err)
		return err;

389
	err = ds->ops->setup(ds);
390 391 392
	if (err < 0)
		return err;

V
Vivien Didelot 已提交
393 394 395 396
	err = dsa_switch_register_notifier(ds);
	if (err)
		return err;

397
	if (!ds->slave_mii_bus && ds->ops->phy_read) {
398 399 400 401 402 403 404 405 406 407 408
		ds->slave_mii_bus = devm_mdiobus_alloc(ds->dev);
		if (!ds->slave_mii_bus)
			return -ENOMEM;

		dsa_slave_mii_bus_init(ds);

		err = mdiobus_register(ds->slave_mii_bus);
		if (err < 0)
			return err;
	}

409
	for (index = 0; index < ds->num_ports; index++) {
410 411
		port = &ds->ports[index];
		if (!dsa_port_is_valid(port))
412 413 414
			continue;

		if (dsa_port_is_dsa(port)) {
415
			err = dsa_dsa_port_apply(port);
416 417 418 419 420 421
			if (err)
				return err;
			continue;
		}

		if (dsa_port_is_cpu(port)) {
422
			err = dsa_cpu_port_apply(port);
423 424 425 426 427
			if (err)
				return err;
			continue;
		}

428
		err = dsa_user_port_apply(port);
429 430 431 432 433 434 435 436 437
		if (err)
			continue;
	}

	return 0;
}

static void dsa_ds_unapply(struct dsa_switch_tree *dst, struct dsa_switch *ds)
{
438
	struct dsa_port *port;
439 440
	u32 index;

441
	for (index = 0; index < ds->num_ports; index++) {
442 443
		port = &ds->ports[index];
		if (!dsa_port_is_valid(port))
444 445 446
			continue;

		if (dsa_port_is_dsa(port)) {
447
			dsa_dsa_port_unapply(port);
448 449 450 451
			continue;
		}

		if (dsa_port_is_cpu(port)) {
452
			dsa_cpu_port_unapply(port);
453 454 455
			continue;
		}

456
		dsa_user_port_unapply(port);
457
	}
458

459
	if (ds->slave_mii_bus && ds->ops->phy_read)
460
		mdiobus_unregister(ds->slave_mii_bus);
V
Vivien Didelot 已提交
461 462

	dsa_switch_unregister_notifier(ds);
463 464 465 466 467 468 469

	if (ds->devlink) {
		devlink_unregister(ds->devlink);
		devlink_free(ds->devlink);
		ds->devlink = NULL;
	}

470 471 472 473 474 475 476 477
}

static int dsa_dst_apply(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
	u32 index;
	int err;

478 479 480 481
	err = dsa_tree_setup_default_cpu(dst);
	if (err)
		return err;

482 483 484 485 486 487 488 489 490 491 492 493 494 495 496
	for (index = 0; index < DSA_MAX_SWITCHES; index++) {
		ds = dst->ds[index];
		if (!ds)
			continue;

		err = dsa_ds_apply(dst, ds);
		if (err)
			return err;
	}

	/* If we use a tagging format that doesn't have an ethertype
	 * field, make sure that all packets from this point on get
	 * sent to the tag format's receive function.
	 */
	wmb();
497
	dst->cpu_dp->master->dsa_ptr = dst->cpu_dp;
498

499
	err = dsa_master_ethtool_setup(dst->cpu_dp->master);
500 501 502
	if (err)
		return err;

503 504 505 506 507 508 509 510 511 512 513 514 515
	dst->applied = true;

	return 0;
}

static void dsa_dst_unapply(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
	u32 index;

	if (!dst->applied)
		return;

516
	dsa_master_ethtool_restore(dst->cpu_dp->master);
517

518
	dst->cpu_dp->master->dsa_ptr = NULL;
519 520 521 522 523 524 525 526 527 528 529 530 531 532 533

	/* If we used a tagging format that doesn't have an ethertype
	 * field, make sure that all packets from this point get sent
	 * without the tag and go through the regular receive path.
	 */
	wmb();

	for (index = 0; index < DSA_MAX_SWITCHES; index++) {
		ds = dst->ds[index];
		if (!ds)
			continue;

		dsa_ds_unapply(dst, ds);
	}

534
	dsa_tree_teardown_default_cpu(dst);
535

536
	pr_info("DSA: tree %d unapplied\n", dst->index);
537 538 539
	dst->applied = false;
}

540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560
static void dsa_tree_remove_switch(struct dsa_switch_tree *dst,
				   unsigned int index)
{
	dst->ds[index] = NULL;
	dsa_tree_put(dst);
}

static int dsa_tree_add_switch(struct dsa_switch_tree *dst,
			       struct dsa_switch *ds)
{
	unsigned int index = ds->index;

	if (dst->ds[index])
		return -EBUSY;

	dsa_tree_get(dst);
	dst->ds[index] = ds;

	return 0;
}

561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580
static int dsa_port_parse_user(struct dsa_port *dp, const char *name)
{
	if (!name)
		name = "eth%d";

	dp->type = DSA_PORT_TYPE_USER;
	dp->name = name;

	return 0;
}

static int dsa_port_parse_dsa(struct dsa_port *dp)
{
	dp->type = DSA_PORT_TYPE_DSA;

	return 0;
}

static int dsa_port_parse_cpu(struct dsa_port *dp, struct net_device *master)
{
581 582 583 584 585 586 587 588 589 590 591 592
	struct dsa_switch *ds = dp->ds;
	struct dsa_switch_tree *dst = ds->dst;
	const struct dsa_device_ops *tag_ops;
	enum dsa_tag_protocol tag_protocol;

	tag_protocol = ds->ops->get_tag_protocol(ds);
	tag_ops = dsa_resolve_tag_protocol(tag_protocol);
	if (IS_ERR(tag_ops)) {
		dev_warn(ds->dev, "No tagger for this switch\n");
		return PTR_ERR(tag_ops);
	}

593
	dp->type = DSA_PORT_TYPE_CPU;
594 595
	dp->rcv = tag_ops->rcv;
	dp->tag_ops = tag_ops;
596
	dp->master = master;
597
	dp->dst = dst;
598 599 600 601

	return 0;
}

602 603
static int dsa_port_parse_of(struct dsa_port *dp, struct device_node *dn)
{
604
	struct device_node *ethernet = of_parse_phandle(dn, "ethernet", 0);
605
	const char *name = of_get_property(dn, "label", NULL);
606
	bool link = of_property_read_bool(dn, "link");
607

608 609
	dp->dn = dn;

610
	if (ethernet) {
611 612 613 614 615 616
		struct net_device *master;

		master = of_find_net_device_by_node(ethernet);
		if (!master)
			return -EPROBE_DEFER;

617
		return dsa_port_parse_cpu(dp, master);
618 619
	}

620 621
	if (link)
		return dsa_port_parse_dsa(dp);
622

623
	return dsa_port_parse_user(dp, name);
624 625
}

V
Vivien Didelot 已提交
626 627
static int dsa_switch_parse_ports_of(struct dsa_switch *ds,
				     struct device_node *dn)
628
{
629
	struct device_node *ports, *port;
630
	struct dsa_port *dp;
631
	u32 reg;
632 633 634 635 636 637 638
	int err;

	ports = of_get_child_by_name(dn, "ports");
	if (!ports) {
		dev_err(ds->dev, "no ports child node found\n");
		return -EINVAL;
	}
639 640 641 642 643 644

	for_each_available_child_of_node(ports, port) {
		err = of_property_read_u32(port, "reg", &reg);
		if (err)
			return err;

645
		if (reg >= ds->num_ports)
646 647
			return -EINVAL;

648 649 650 651 652
		dp = &ds->ports[reg];

		err = dsa_port_parse_of(dp, port);
		if (err)
			return err;
653 654 655 656 657
	}

	return 0;
}

V
Vivien Didelot 已提交
658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690
static int dsa_switch_parse_member_of(struct dsa_switch *ds,
				      struct device_node *dn)
{
	u32 m[2] = { 0, 0 };
	int sz;

	/* Don't error out if this optional property isn't found */
	sz = of_property_read_variable_u32_array(dn, "dsa,member", m, 2, 2);
	if (sz < 0 && sz != -EINVAL)
		return sz;

	ds->index = m[1];
	if (ds->index >= DSA_MAX_SWITCHES)
		return -EINVAL;

	ds->dst = dsa_tree_touch(m[0]);
	if (!ds->dst)
		return -ENOMEM;

	return 0;
}

static int dsa_switch_parse_of(struct dsa_switch *ds, struct device_node *dn)
{
	int err;

	err = dsa_switch_parse_member_of(ds, dn);
	if (err)
		return err;

	return dsa_switch_parse_ports_of(ds, dn);
}

691 692 693
static int dsa_port_parse(struct dsa_port *dp, const char *name,
			  struct device *dev)
{
694
	if (!strcmp(name, "cpu")) {
695 696 697 698 699 700 701 702
		struct net_device *master;

		master = dsa_dev_to_net_device(dev);
		if (!master)
			return -EPROBE_DEFER;

		dev_put(master);

703
		return dsa_port_parse_cpu(dp, master);
704 705
	}

706 707
	if (!strcmp(name, "dsa"))
		return dsa_port_parse_dsa(dp);
708

709
	return dsa_port_parse_user(dp, name);
710 711
}

V
Vivien Didelot 已提交
712 713
static int dsa_switch_parse_ports(struct dsa_switch *ds,
				  struct dsa_chip_data *cd)
714 715
{
	bool valid_name_found = false;
716 717 718
	struct dsa_port *dp;
	struct device *dev;
	const char *name;
719
	unsigned int i;
720
	int err;
721 722

	for (i = 0; i < DSA_MAX_PORTS; i++) {
723 724 725 726 727
		name = cd->port_names[i];
		dev = cd->netdev[i];
		dp = &ds->ports[i];

		if (!name)
728 729
			continue;

730 731 732 733
		err = dsa_port_parse(dp, name, dev);
		if (err)
			return err;

734 735 736 737 738 739 740 741 742
		valid_name_found = true;
	}

	if (!valid_name_found && i == DSA_MAX_PORTS)
		return -EINVAL;

	return 0;
}

V
Vivien Didelot 已提交
743
static int dsa_switch_parse(struct dsa_switch *ds, struct dsa_chip_data *cd)
744
{
V
Vivien Didelot 已提交
745
	ds->cd = cd;
746

V
Vivien Didelot 已提交
747 748 749 750 751 752 753
	/* We don't support interconnected switches nor multiple trees via
	 * platform data, so this is the unique switch of the tree.
	 */
	ds->index = 0;
	ds->dst = dsa_tree_touch(0);
	if (!ds->dst)
		return -ENOMEM;
754

V
Vivien Didelot 已提交
755
	return dsa_switch_parse_ports(ds, cd);
756 757
}

758
static int _dsa_register_switch(struct dsa_switch *ds)
759
{
760 761
	struct dsa_chip_data *pdata = ds->dev->platform_data;
	struct device_node *np = ds->dev->of_node;
762
	struct dsa_switch_tree *dst;
V
Vivien Didelot 已提交
763
	unsigned int index;
764
	int i, err;
765

V
Vivien Didelot 已提交
766 767 768 769 770 771
	if (np)
		err = dsa_switch_parse_of(ds, np);
	else if (pdata)
		err = dsa_switch_parse(ds, pdata);
	else
		err = -ENODEV;
772

V
Vivien Didelot 已提交
773 774
	if (err)
		return err;
775

V
Vivien Didelot 已提交
776 777
	index = ds->index;
	dst = ds->dst;
778

779 780 781 782
	/* Initialize the routing table */
	for (i = 0; i < DSA_MAX_SWITCHES; ++i)
		ds->rtable[i] = DSA_RTABLE_NONE;

783 784 785
	err = dsa_tree_add_switch(dst, ds);
	if (err)
		return err;
786 787 788 789 790

	err = dsa_dst_complete(dst);
	if (err < 0)
		goto out_del_dst;

791 792 793
	/* Not all switches registered yet */
	if (err == 1)
		return 0;
794 795 796 797 798 799 800 801 802 803 804 805 806 807 808

	if (dst->applied) {
		pr_info("DSA: Disjoint trees?\n");
		return -EINVAL;
	}

	err = dsa_dst_apply(dst);
	if (err) {
		dsa_dst_unapply(dst);
		goto out_del_dst;
	}

	return 0;

out_del_dst:
809
	dsa_tree_remove_switch(dst, index);
810 811 812 813

	return err;
}

814 815 816 817
struct dsa_switch *dsa_switch_alloc(struct device *dev, size_t n)
{
	size_t size = sizeof(struct dsa_switch) + n * sizeof(struct dsa_port);
	struct dsa_switch *ds;
818
	int i;
819 820 821 822 823 824 825 826

	ds = devm_kzalloc(dev, size, GFP_KERNEL);
	if (!ds)
		return NULL;

	ds->dev = dev;
	ds->num_ports = n;

827 828 829 830 831
	for (i = 0; i < ds->num_ports; ++i) {
		ds->ports[i].index = i;
		ds->ports[i].ds = ds;
	}

832 833 834 835
	return ds;
}
EXPORT_SYMBOL_GPL(dsa_switch_alloc);

836
int dsa_register_switch(struct dsa_switch *ds)
837 838 839 840
{
	int err;

	mutex_lock(&dsa2_mutex);
841
	err = _dsa_register_switch(ds);
842 843 844 845 846 847
	mutex_unlock(&dsa2_mutex);

	return err;
}
EXPORT_SYMBOL_GPL(dsa_register_switch);

848
static void _dsa_unregister_switch(struct dsa_switch *ds)
849 850
{
	struct dsa_switch_tree *dst = ds->dst;
851
	unsigned int index = ds->index;
852 853 854

	dsa_dst_unapply(dst);

855
	dsa_tree_remove_switch(dst, index);
856 857 858 859 860 861 862 863 864
}

void dsa_unregister_switch(struct dsa_switch *ds)
{
	mutex_lock(&dsa2_mutex);
	_dsa_unregister_switch(ds);
	mutex_unlock(&dsa2_mutex);
}
EXPORT_SYMBOL_GPL(dsa_unregister_switch);