dsa2.c 17.3 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15
/*
 * net/dsa/dsa2.c - Hardware switch handling, binding version 2
 * Copyright (c) 2008-2009 Marvell Semiconductor
 * Copyright (c) 2013 Florian Fainelli <florian@openwrt.org>
 * Copyright (c) 2016 Andrew Lunn <andrew@lunn.ch>
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 */

#include <linux/device.h>
#include <linux/err.h>
#include <linux/list.h>
16
#include <linux/netdevice.h>
17 18 19 20
#include <linux/slab.h>
#include <linux/rtnetlink.h>
#include <linux/of.h>
#include <linux/of_net.h>
21

22 23
#include "dsa_priv.h"

24
static LIST_HEAD(dsa_tree_list);
25 26
static DEFINE_MUTEX(dsa2_mutex);

27 28 29
static const struct devlink_ops dsa_devlink_ops = {
};

30
static struct dsa_switch_tree *dsa_tree_find(int index)
31 32 33
{
	struct dsa_switch_tree *dst;

34
	list_for_each_entry(dst, &dsa_tree_list, list)
35
		if (dst->index == index)
36
			return dst;
37

38 39 40
	return NULL;
}

41
static struct dsa_switch_tree *dsa_tree_alloc(int index)
42 43 44 45 46 47
{
	struct dsa_switch_tree *dst;

	dst = kzalloc(sizeof(*dst), GFP_KERNEL);
	if (!dst)
		return NULL;
48

49
	dst->index = index;
50

51
	INIT_LIST_HEAD(&dst->list);
52
	list_add_tail(&dsa_tree_list, &dst->list);
53 54

	/* Initialize the reference counter to the number of switches, not 1 */
55
	kref_init(&dst->refcount);
56
	refcount_set(&dst->refcount.refcount, 0);
57 58 59 60

	return dst;
}

61 62 63 64 65 66
static void dsa_tree_free(struct dsa_switch_tree *dst)
{
	list_del(&dst->list);
	kfree(dst);
}

67 68 69 70 71 72 73 74 75 76 77
static struct dsa_switch_tree *dsa_tree_touch(int index)
{
	struct dsa_switch_tree *dst;

	dst = dsa_tree_find(index);
	if (!dst)
		dst = dsa_tree_alloc(index);

	return dst;
}

78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96
static void dsa_tree_get(struct dsa_switch_tree *dst)
{
	kref_get(&dst->refcount);
}

static void dsa_tree_release(struct kref *ref)
{
	struct dsa_switch_tree *dst;

	dst = container_of(ref, struct dsa_switch_tree, refcount);

	dsa_tree_free(dst);
}

static void dsa_tree_put(struct dsa_switch_tree *dst)
{
	kref_put(&dst->refcount, dsa_tree_release);
}

97 98 99
/* For platform data configurations, we need to have a valid name argument to
 * differentiate a disabled port from an enabled one
 */
100
static bool dsa_port_is_valid(struct dsa_port *port)
101
{
102
	return port->type != DSA_PORT_TYPE_UNUSED;
103 104
}

105
static bool dsa_port_is_dsa(struct dsa_port *port)
106
{
107
	return port->type == DSA_PORT_TYPE_DSA;
108 109 110 111
}

static bool dsa_port_is_cpu(struct dsa_port *port)
{
112
	return port->type == DSA_PORT_TYPE_CPU;
113 114
}

115 116
static bool dsa_ds_find_port_dn(struct dsa_switch *ds,
				struct device_node *port)
117 118 119
{
	u32 index;

120
	for (index = 0; index < ds->num_ports; index++)
121 122 123 124 125
		if (ds->ports[index].dn == port)
			return true;
	return false;
}

126 127
static struct dsa_switch *dsa_dst_find_port_dn(struct dsa_switch_tree *dst,
					       struct device_node *port)
128 129 130 131 132 133 134 135 136
{
	struct dsa_switch *ds;
	u32 index;

	for (index = 0; index < DSA_MAX_SWITCHES; index++) {
		ds = dst->ds[index];
		if (!ds)
			continue;

137
		if (dsa_ds_find_port_dn(ds, port))
138 139 140 141 142 143 144 145
			return ds;
	}

	return NULL;
}

static int dsa_port_complete(struct dsa_switch_tree *dst,
			     struct dsa_switch *src_ds,
146
			     struct dsa_port *port,
147 148 149 150 151 152 153
			     u32 src_port)
{
	struct device_node *link;
	int index;
	struct dsa_switch *dst_ds;

	for (index = 0;; index++) {
154
		link = of_parse_phandle(port->dn, "link", index);
155 156 157
		if (!link)
			break;

158
		dst_ds = dsa_dst_find_port_dn(dst, link);
159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176
		of_node_put(link);

		if (!dst_ds)
			return 1;

		src_ds->rtable[dst_ds->index] = src_port;
	}

	return 0;
}

/* A switch is complete if all the DSA ports phandles point to ports
 * known in the tree. A return value of 1 means the tree is not
 * complete. This is not an error condition. A value of 0 is
 * success.
 */
static int dsa_ds_complete(struct dsa_switch_tree *dst, struct dsa_switch *ds)
{
177
	struct dsa_port *port;
178 179 180
	u32 index;
	int err;

181
	for (index = 0; index < ds->num_ports; index++) {
182 183
		port = &ds->ports[index];
		if (!dsa_port_is_valid(port))
184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220
			continue;

		if (!dsa_port_is_dsa(port))
			continue;

		err = dsa_port_complete(dst, ds, port, index);
		if (err != 0)
			return err;
	}

	return 0;
}

/* A tree is complete if all the DSA ports phandles point to ports
 * known in the tree. A return value of 1 means the tree is not
 * complete. This is not an error condition. A value of 0 is
 * success.
 */
static int dsa_dst_complete(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
	u32 index;
	int err;

	for (index = 0; index < DSA_MAX_SWITCHES; index++) {
		ds = dst->ds[index];
		if (!ds)
			continue;

		err = dsa_ds_complete(dst, ds);
		if (err != 0)
			return err;
	}

	return 0;
}

221
static int dsa_dsa_port_apply(struct dsa_port *port)
222
{
223
	struct dsa_switch *ds = port->ds;
224 225
	int err;

226
	err = dsa_port_fixed_link_register_of(port);
227 228
	if (err) {
		dev_warn(ds->dev, "Failed to setup dsa port %d: %d\n",
229
			 port->index, err);
230 231 232
		return err;
	}

233
	memset(&port->devlink_port, 0, sizeof(port->devlink_port));
234

235 236
	return devlink_port_register(ds->devlink, &port->devlink_port,
				     port->index);
237 238
}

239
static void dsa_dsa_port_unapply(struct dsa_port *port)
240
{
241
	devlink_port_unregister(&port->devlink_port);
242
	dsa_port_fixed_link_unregister_of(port);
243 244
}

245
static int dsa_cpu_port_apply(struct dsa_port *port)
246
{
247
	struct dsa_switch *ds = port->ds;
248 249
	int err;

250
	err = dsa_port_fixed_link_register_of(port);
251 252
	if (err) {
		dev_warn(ds->dev, "Failed to setup cpu port %d: %d\n",
253
			 port->index, err);
254 255 256
		return err;
	}

257 258 259
	memset(&port->devlink_port, 0, sizeof(port->devlink_port));
	err = devlink_port_register(ds->devlink, &port->devlink_port,
				    port->index);
260
	return err;
261 262
}

263
static void dsa_cpu_port_unapply(struct dsa_port *port)
264
{
265
	devlink_port_unregister(&port->devlink_port);
266
	dsa_port_fixed_link_unregister_of(port);
267 268
}

269
static int dsa_user_port_apply(struct dsa_port *port)
270
{
271
	struct dsa_switch *ds = port->ds;
272 273
	int err;

274
	err = dsa_slave_create(port);
275 276
	if (err) {
		dev_warn(ds->dev, "Failed to create slave %d: %d\n",
277
			 port->index, err);
278
		port->slave = NULL;
279 280 281
		return err;
	}

282 283 284
	memset(&port->devlink_port, 0, sizeof(port->devlink_port));
	err = devlink_port_register(ds->devlink, &port->devlink_port,
				    port->index);
285 286 287
	if (err)
		return err;

288
	devlink_port_type_eth_set(&port->devlink_port, port->slave);
289

290 291 292
	return 0;
}

293
static void dsa_user_port_unapply(struct dsa_port *port)
294
{
295
	devlink_port_unregister(&port->devlink_port);
296 297 298
	if (port->slave) {
		dsa_slave_destroy(port->slave);
		port->slave = NULL;
299 300 301 302 303
	}
}

static int dsa_ds_apply(struct dsa_switch_tree *dst, struct dsa_switch *ds)
{
304
	struct dsa_port *port;
305 306 307
	u32 index;
	int err;

308
	/* Initialize ds->phys_mii_mask before registering the slave MDIO bus
309
	 * driver and before ops->setup() has run, since the switch drivers and
310 311 312
	 * the slave MDIO bus driver rely on these values for probing PHY
	 * devices or not
	 */
313
	ds->phys_mii_mask |= dsa_user_ports(ds);
314

315 316 317 318 319 320 321 322 323 324 325
	/* Add the switch to devlink before calling setup, so that setup can
	 * add dpipe tables
	 */
	ds->devlink = devlink_alloc(&dsa_devlink_ops, 0);
	if (!ds->devlink)
		return -ENOMEM;

	err = devlink_register(ds->devlink, ds->dev);
	if (err)
		return err;

326
	err = ds->ops->setup(ds);
327 328 329
	if (err < 0)
		return err;

V
Vivien Didelot 已提交
330 331 332 333
	err = dsa_switch_register_notifier(ds);
	if (err)
		return err;

334
	if (!ds->slave_mii_bus && ds->ops->phy_read) {
335 336 337 338 339 340 341 342 343 344 345
		ds->slave_mii_bus = devm_mdiobus_alloc(ds->dev);
		if (!ds->slave_mii_bus)
			return -ENOMEM;

		dsa_slave_mii_bus_init(ds);

		err = mdiobus_register(ds->slave_mii_bus);
		if (err < 0)
			return err;
	}

346
	for (index = 0; index < ds->num_ports; index++) {
347 348
		port = &ds->ports[index];
		if (!dsa_port_is_valid(port))
349 350 351
			continue;

		if (dsa_port_is_dsa(port)) {
352
			err = dsa_dsa_port_apply(port);
353 354 355 356 357 358
			if (err)
				return err;
			continue;
		}

		if (dsa_port_is_cpu(port)) {
359
			err = dsa_cpu_port_apply(port);
360 361 362 363 364
			if (err)
				return err;
			continue;
		}

365
		err = dsa_user_port_apply(port);
366 367 368 369 370 371 372 373 374
		if (err)
			continue;
	}

	return 0;
}

static void dsa_ds_unapply(struct dsa_switch_tree *dst, struct dsa_switch *ds)
{
375
	struct dsa_port *port;
376 377
	u32 index;

378
	for (index = 0; index < ds->num_ports; index++) {
379 380
		port = &ds->ports[index];
		if (!dsa_port_is_valid(port))
381 382 383
			continue;

		if (dsa_port_is_dsa(port)) {
384
			dsa_dsa_port_unapply(port);
385 386 387 388
			continue;
		}

		if (dsa_port_is_cpu(port)) {
389
			dsa_cpu_port_unapply(port);
390 391 392
			continue;
		}

393
		dsa_user_port_unapply(port);
394
	}
395

396
	if (ds->slave_mii_bus && ds->ops->phy_read)
397
		mdiobus_unregister(ds->slave_mii_bus);
V
Vivien Didelot 已提交
398 399

	dsa_switch_unregister_notifier(ds);
400 401 402 403 404 405 406

	if (ds->devlink) {
		devlink_unregister(ds->devlink);
		devlink_free(ds->devlink);
		ds->devlink = NULL;
	}

407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429
}

static int dsa_dst_apply(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
	u32 index;
	int err;

	for (index = 0; index < DSA_MAX_SWITCHES; index++) {
		ds = dst->ds[index];
		if (!ds)
			continue;

		err = dsa_ds_apply(dst, ds);
		if (err)
			return err;
	}

	/* If we use a tagging format that doesn't have an ethertype
	 * field, make sure that all packets from this point on get
	 * sent to the tag format's receive function.
	 */
	wmb();
430
	dst->cpu_dp->master->dsa_ptr = dst->cpu_dp;
431

432
	err = dsa_master_ethtool_setup(dst->cpu_dp->master);
433 434 435
	if (err)
		return err;

436 437 438 439 440 441 442 443 444 445 446 447 448
	dst->applied = true;

	return 0;
}

static void dsa_dst_unapply(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
	u32 index;

	if (!dst->applied)
		return;

449
	dsa_master_ethtool_restore(dst->cpu_dp->master);
450

451
	dst->cpu_dp->master->dsa_ptr = NULL;
452 453 454 455 456 457 458 459 460 461 462 463 464 465 466

	/* If we used a tagging format that doesn't have an ethertype
	 * field, make sure that all packets from this point get sent
	 * without the tag and go through the regular receive path.
	 */
	wmb();

	for (index = 0; index < DSA_MAX_SWITCHES; index++) {
		ds = dst->ds[index];
		if (!ds)
			continue;

		dsa_ds_unapply(dst, ds);
	}

467
	dst->cpu_dp = NULL;
468

469
	pr_info("DSA: tree %d unapplied\n", dst->index);
470 471 472
	dst->applied = false;
}

473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493
static void dsa_tree_remove_switch(struct dsa_switch_tree *dst,
				   unsigned int index)
{
	dst->ds[index] = NULL;
	dsa_tree_put(dst);
}

static int dsa_tree_add_switch(struct dsa_switch_tree *dst,
			       struct dsa_switch *ds)
{
	unsigned int index = ds->index;

	if (dst->ds[index])
		return -EBUSY;

	dsa_tree_get(dst);
	dst->ds[index] = ds;

	return 0;
}

494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519
static int dsa_port_parse_user(struct dsa_port *dp, const char *name)
{
	if (!name)
		name = "eth%d";

	dp->type = DSA_PORT_TYPE_USER;
	dp->name = name;

	return 0;
}

static int dsa_port_parse_dsa(struct dsa_port *dp)
{
	dp->type = DSA_PORT_TYPE_DSA;

	return 0;
}

static int dsa_port_parse_cpu(struct dsa_port *dp, struct net_device *master)
{
	dp->type = DSA_PORT_TYPE_CPU;
	dp->master = master;

	return 0;
}

520
static int dsa_cpu_parse(struct dsa_port *port, u32 index,
521 522 523
			 struct dsa_switch_tree *dst,
			 struct dsa_switch *ds)
{
524
	const struct dsa_device_ops *tag_ops;
525
	enum dsa_tag_protocol tag_protocol;
526

527
	if (!dst->cpu_dp)
528
		dst->cpu_dp = port;
529

530
	tag_protocol = ds->ops->get_tag_protocol(ds);
531 532
	tag_ops = dsa_resolve_tag_protocol(tag_protocol);
	if (IS_ERR(tag_ops)) {
533
		dev_warn(ds->dev, "No tagger for this switch\n");
534
		return PTR_ERR(tag_ops);
535 536
	}

V
Vivien Didelot 已提交
537
	dst->cpu_dp->tag_ops = tag_ops;
538 539 540 541

	/* Make a few copies for faster access in master receive hot path */
	dst->cpu_dp->rcv = dst->cpu_dp->tag_ops->rcv;
	dst->cpu_dp->dst = dst;
542 543 544 545 546 547

	return 0;
}

static int dsa_ds_parse(struct dsa_switch_tree *dst, struct dsa_switch *ds)
{
548
	struct dsa_port *port;
549 550 551
	u32 index;
	int err;

552
	for (index = 0; index < ds->num_ports; index++) {
553
		port = &ds->ports[index];
554 555
		if (!dsa_port_is_valid(port) ||
		    dsa_port_is_dsa(port))
556 557 558 559 560 561 562
			continue;

		if (dsa_port_is_cpu(port)) {
			err = dsa_cpu_parse(port, index, dst, ds);
			if (err)
				return err;
		}
563

564 565
	}

566
	pr_info("DSA: switch %d %d parsed\n", dst->index, ds->index);
567 568 569 570 571 572 573

	return 0;
}

static int dsa_dst_parse(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
574
	struct dsa_port *dp;
575
	u32 index;
576
	int port;
577 578 579 580 581 582 583 584 585 586 587 588
	int err;

	for (index = 0; index < DSA_MAX_SWITCHES; index++) {
		ds = dst->ds[index];
		if (!ds)
			continue;

		err = dsa_ds_parse(dst, ds);
		if (err)
			return err;
	}

589
	if (!dst->cpu_dp) {
590 591 592 593
		pr_warn("Tree has no master device\n");
		return -EINVAL;
	}

594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610
	/* Assign the default CPU port to all ports of the fabric */
	for (index = 0; index < DSA_MAX_SWITCHES; index++) {
		ds = dst->ds[index];
		if (!ds)
			continue;

		for (port = 0; port < ds->num_ports; port++) {
			dp = &ds->ports[port];
			if (!dsa_port_is_valid(dp) ||
			    dsa_port_is_dsa(dp) ||
			    dsa_port_is_cpu(dp))
				continue;

			dp->cpu_dp = dst->cpu_dp;
		}
	}

611
	pr_info("DSA: tree %d parsed\n", dst->index);
612 613 614 615

	return 0;
}

616 617
static int dsa_port_parse_of(struct dsa_port *dp, struct device_node *dn)
{
618
	struct device_node *ethernet = of_parse_phandle(dn, "ethernet", 0);
619
	const char *name = of_get_property(dn, "label", NULL);
620
	bool link = of_property_read_bool(dn, "link");
621

622 623
	dp->dn = dn;

624
	if (ethernet) {
625 626 627 628 629 630
		struct net_device *master;

		master = of_find_net_device_by_node(ethernet);
		if (!master)
			return -EPROBE_DEFER;

631
		return dsa_port_parse_cpu(dp, master);
632 633
	}

634 635
	if (link)
		return dsa_port_parse_dsa(dp);
636

637
	return dsa_port_parse_user(dp, name);
638 639
}

V
Vivien Didelot 已提交
640 641
static int dsa_switch_parse_ports_of(struct dsa_switch *ds,
				     struct device_node *dn)
642
{
643
	struct device_node *ports, *port;
644
	struct dsa_port *dp;
645
	u32 reg;
646 647 648 649 650 651 652
	int err;

	ports = of_get_child_by_name(dn, "ports");
	if (!ports) {
		dev_err(ds->dev, "no ports child node found\n");
		return -EINVAL;
	}
653 654 655 656 657 658

	for_each_available_child_of_node(ports, port) {
		err = of_property_read_u32(port, "reg", &reg);
		if (err)
			return err;

659
		if (reg >= ds->num_ports)
660 661
			return -EINVAL;

662 663 664 665 666
		dp = &ds->ports[reg];

		err = dsa_port_parse_of(dp, port);
		if (err)
			return err;
667 668 669 670 671
	}

	return 0;
}

V
Vivien Didelot 已提交
672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704
static int dsa_switch_parse_member_of(struct dsa_switch *ds,
				      struct device_node *dn)
{
	u32 m[2] = { 0, 0 };
	int sz;

	/* Don't error out if this optional property isn't found */
	sz = of_property_read_variable_u32_array(dn, "dsa,member", m, 2, 2);
	if (sz < 0 && sz != -EINVAL)
		return sz;

	ds->index = m[1];
	if (ds->index >= DSA_MAX_SWITCHES)
		return -EINVAL;

	ds->dst = dsa_tree_touch(m[0]);
	if (!ds->dst)
		return -ENOMEM;

	return 0;
}

static int dsa_switch_parse_of(struct dsa_switch *ds, struct device_node *dn)
{
	int err;

	err = dsa_switch_parse_member_of(ds, dn);
	if (err)
		return err;

	return dsa_switch_parse_ports_of(ds, dn);
}

705 706 707
static int dsa_port_parse(struct dsa_port *dp, const char *name,
			  struct device *dev)
{
708
	if (!strcmp(name, "cpu")) {
709 710 711 712 713 714 715 716
		struct net_device *master;

		master = dsa_dev_to_net_device(dev);
		if (!master)
			return -EPROBE_DEFER;

		dev_put(master);

717
		return dsa_port_parse_cpu(dp, master);
718 719
	}

720 721
	if (!strcmp(name, "dsa"))
		return dsa_port_parse_dsa(dp);
722

723
	return dsa_port_parse_user(dp, name);
724 725
}

V
Vivien Didelot 已提交
726 727
static int dsa_switch_parse_ports(struct dsa_switch *ds,
				  struct dsa_chip_data *cd)
728 729
{
	bool valid_name_found = false;
730 731 732
	struct dsa_port *dp;
	struct device *dev;
	const char *name;
733
	unsigned int i;
734
	int err;
735 736

	for (i = 0; i < DSA_MAX_PORTS; i++) {
737 738 739 740 741
		name = cd->port_names[i];
		dev = cd->netdev[i];
		dp = &ds->ports[i];

		if (!name)
742 743
			continue;

744 745 746 747
		err = dsa_port_parse(dp, name, dev);
		if (err)
			return err;

748 749 750 751 752 753 754 755 756
		valid_name_found = true;
	}

	if (!valid_name_found && i == DSA_MAX_PORTS)
		return -EINVAL;

	return 0;
}

V
Vivien Didelot 已提交
757
static int dsa_switch_parse(struct dsa_switch *ds, struct dsa_chip_data *cd)
758
{
V
Vivien Didelot 已提交
759
	ds->cd = cd;
760

V
Vivien Didelot 已提交
761 762 763 764 765 766 767
	/* We don't support interconnected switches nor multiple trees via
	 * platform data, so this is the unique switch of the tree.
	 */
	ds->index = 0;
	ds->dst = dsa_tree_touch(0);
	if (!ds->dst)
		return -ENOMEM;
768

V
Vivien Didelot 已提交
769
	return dsa_switch_parse_ports(ds, cd);
770 771
}

772
static int _dsa_register_switch(struct dsa_switch *ds)
773
{
774 775
	struct dsa_chip_data *pdata = ds->dev->platform_data;
	struct device_node *np = ds->dev->of_node;
776
	struct dsa_switch_tree *dst;
V
Vivien Didelot 已提交
777
	unsigned int index;
778
	int i, err;
779

V
Vivien Didelot 已提交
780 781 782 783 784 785
	if (np)
		err = dsa_switch_parse_of(ds, np);
	else if (pdata)
		err = dsa_switch_parse(ds, pdata);
	else
		err = -ENODEV;
786

V
Vivien Didelot 已提交
787 788
	if (err)
		return err;
789

V
Vivien Didelot 已提交
790 791
	index = ds->index;
	dst = ds->dst;
792

793 794 795 796
	/* Initialize the routing table */
	for (i = 0; i < DSA_MAX_SWITCHES; ++i)
		ds->rtable[i] = DSA_RTABLE_NONE;

797 798 799
	err = dsa_tree_add_switch(dst, ds);
	if (err)
		return err;
800 801 802 803 804

	err = dsa_dst_complete(dst);
	if (err < 0)
		goto out_del_dst;

805 806 807
	/* Not all switches registered yet */
	if (err == 1)
		return 0;
808 809 810 811 812 813 814

	if (dst->applied) {
		pr_info("DSA: Disjoint trees?\n");
		return -EINVAL;
	}

	err = dsa_dst_parse(dst);
815
	if (err)
816 817 818 819 820 821 822 823 824 825 826
		goto out_del_dst;

	err = dsa_dst_apply(dst);
	if (err) {
		dsa_dst_unapply(dst);
		goto out_del_dst;
	}

	return 0;

out_del_dst:
827
	dsa_tree_remove_switch(dst, index);
828 829 830 831

	return err;
}

832 833 834 835
struct dsa_switch *dsa_switch_alloc(struct device *dev, size_t n)
{
	size_t size = sizeof(struct dsa_switch) + n * sizeof(struct dsa_port);
	struct dsa_switch *ds;
836
	int i;
837 838 839 840 841 842 843 844

	ds = devm_kzalloc(dev, size, GFP_KERNEL);
	if (!ds)
		return NULL;

	ds->dev = dev;
	ds->num_ports = n;

845 846 847 848 849
	for (i = 0; i < ds->num_ports; ++i) {
		ds->ports[i].index = i;
		ds->ports[i].ds = ds;
	}

850 851 852 853
	return ds;
}
EXPORT_SYMBOL_GPL(dsa_switch_alloc);

854
int dsa_register_switch(struct dsa_switch *ds)
855 856 857 858
{
	int err;

	mutex_lock(&dsa2_mutex);
859
	err = _dsa_register_switch(ds);
860 861 862 863 864 865
	mutex_unlock(&dsa2_mutex);

	return err;
}
EXPORT_SYMBOL_GPL(dsa_register_switch);

866
static void _dsa_unregister_switch(struct dsa_switch *ds)
867 868
{
	struct dsa_switch_tree *dst = ds->dst;
869
	unsigned int index = ds->index;
870 871 872

	dsa_dst_unapply(dst);

873
	dsa_tree_remove_switch(dst, index);
874 875 876 877 878 879 880 881 882
}

void dsa_unregister_switch(struct dsa_switch *ds)
{
	mutex_lock(&dsa2_mutex);
	_dsa_unregister_switch(ds);
	mutex_unlock(&dsa2_mutex);
}
EXPORT_SYMBOL_GPL(dsa_unregister_switch);