dsa2.c 16.1 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15
/*
 * net/dsa/dsa2.c - Hardware switch handling, binding version 2
 * Copyright (c) 2008-2009 Marvell Semiconductor
 * Copyright (c) 2013 Florian Fainelli <florian@openwrt.org>
 * Copyright (c) 2016 Andrew Lunn <andrew@lunn.ch>
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 */

#include <linux/device.h>
#include <linux/err.h>
#include <linux/list.h>
16
#include <linux/netdevice.h>
17 18 19 20
#include <linux/slab.h>
#include <linux/rtnetlink.h>
#include <linux/of.h>
#include <linux/of_net.h>
21

22 23
#include "dsa_priv.h"

24
static LIST_HEAD(dsa_tree_list);
25 26
static DEFINE_MUTEX(dsa2_mutex);

27 28 29
static const struct devlink_ops dsa_devlink_ops = {
};

30
static struct dsa_switch_tree *dsa_tree_find(int index)
31 32 33
{
	struct dsa_switch_tree *dst;

34
	list_for_each_entry(dst, &dsa_tree_list, list)
35
		if (dst->index == index)
36
			return dst;
37

38 39 40
	return NULL;
}

41
static struct dsa_switch_tree *dsa_tree_alloc(int index)
42 43 44 45 46 47
{
	struct dsa_switch_tree *dst;

	dst = kzalloc(sizeof(*dst), GFP_KERNEL);
	if (!dst)
		return NULL;
48

49
	dst->index = index;
50

51
	INIT_LIST_HEAD(&dst->list);
52
	list_add_tail(&dsa_tree_list, &dst->list);
53 54

	/* Initialize the reference counter to the number of switches, not 1 */
55
	kref_init(&dst->refcount);
56
	refcount_set(&dst->refcount.refcount, 0);
57 58 59 60

	return dst;
}

61 62 63 64 65 66
static void dsa_tree_free(struct dsa_switch_tree *dst)
{
	list_del(&dst->list);
	kfree(dst);
}

67 68 69 70 71 72 73 74 75 76 77
static struct dsa_switch_tree *dsa_tree_touch(int index)
{
	struct dsa_switch_tree *dst;

	dst = dsa_tree_find(index);
	if (!dst)
		dst = dsa_tree_alloc(index);

	return dst;
}

78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96
static void dsa_tree_get(struct dsa_switch_tree *dst)
{
	kref_get(&dst->refcount);
}

static void dsa_tree_release(struct kref *ref)
{
	struct dsa_switch_tree *dst;

	dst = container_of(ref, struct dsa_switch_tree, refcount);

	dsa_tree_free(dst);
}

static void dsa_tree_put(struct dsa_switch_tree *dst)
{
	kref_put(&dst->refcount, dsa_tree_release);
}

97 98 99
/* For platform data configurations, we need to have a valid name argument to
 * differentiate a disabled port from an enabled one
 */
100
static bool dsa_port_is_valid(struct dsa_port *port)
101
{
102
	return port->type != DSA_PORT_TYPE_UNUSED;
103 104
}

105
static bool dsa_port_is_dsa(struct dsa_port *port)
106
{
107
	return port->type == DSA_PORT_TYPE_DSA;
108 109 110 111
}

static bool dsa_port_is_cpu(struct dsa_port *port)
{
112
	return port->type == DSA_PORT_TYPE_CPU;
113 114
}

115 116 117 118 119
static bool dsa_port_is_user(struct dsa_port *dp)
{
	return dp->type == DSA_PORT_TYPE_USER;
}

120 121
static struct dsa_port *dsa_tree_find_port_by_node(struct dsa_switch_tree *dst,
						   struct device_node *dn)
122 123
{
	struct dsa_switch *ds;
124 125
	struct dsa_port *dp;
	int device, port;
126

127 128
	for (device = 0; device < DSA_MAX_SWITCHES; device++) {
		ds = dst->ds[device];
129 130 131
		if (!ds)
			continue;

132 133 134 135 136 137
		for (port = 0; port < ds->num_ports; port++) {
			dp = &ds->ports[port];

			if (dp->dn == dn)
				return dp;
		}
138 139 140 141 142 143 144
	}

	return NULL;
}

static int dsa_port_complete(struct dsa_switch_tree *dst,
			     struct dsa_switch *src_ds,
145
			     struct dsa_port *port,
146 147
			     u32 src_port)
{
V
Vivien Didelot 已提交
148 149
	struct device_node *dn = port->dn;
	struct of_phandle_iterator it;
150
	struct dsa_switch *dst_ds;
151
	struct dsa_port *link_dp;
V
Vivien Didelot 已提交
152
	int err;
153

V
Vivien Didelot 已提交
154 155 156 157
	of_for_each_phandle(&it, err, dn, "link", NULL, 0) {
		link_dp = dsa_tree_find_port_by_node(dst, it.node);
		if (!link_dp) {
			of_node_put(it.node);
158
			return 1;
V
Vivien Didelot 已提交
159
		}
160

161 162
		dst_ds = link_dp->ds;

163 164 165 166 167 168 169 170 171 172 173 174 175
		src_ds->rtable[dst_ds->index] = src_port;
	}

	return 0;
}

/* A switch is complete if all the DSA ports phandles point to ports
 * known in the tree. A return value of 1 means the tree is not
 * complete. This is not an error condition. A value of 0 is
 * success.
 */
static int dsa_ds_complete(struct dsa_switch_tree *dst, struct dsa_switch *ds)
{
176
	struct dsa_port *port;
177 178 179
	u32 index;
	int err;

180
	for (index = 0; index < ds->num_ports; index++) {
181 182
		port = &ds->ports[index];
		if (!dsa_port_is_valid(port))
183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219
			continue;

		if (!dsa_port_is_dsa(port))
			continue;

		err = dsa_port_complete(dst, ds, port, index);
		if (err != 0)
			return err;
	}

	return 0;
}

/* A tree is complete if all the DSA ports phandles point to ports
 * known in the tree. A return value of 1 means the tree is not
 * complete. This is not an error condition. A value of 0 is
 * success.
 */
static int dsa_dst_complete(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
	u32 index;
	int err;

	for (index = 0; index < DSA_MAX_SWITCHES; index++) {
		ds = dst->ds[index];
		if (!ds)
			continue;

		err = dsa_ds_complete(dst, ds);
		if (err != 0)
			return err;
	}

	return 0;
}

220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277
static struct dsa_port *dsa_tree_find_first_cpu(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
	struct dsa_port *dp;
	int device, port;

	for (device = 0; device < DSA_MAX_SWITCHES; device++) {
		ds = dst->ds[device];
		if (!ds)
			continue;

		for (port = 0; port < ds->num_ports; port++) {
			dp = &ds->ports[port];

			if (dsa_port_is_cpu(dp))
				return dp;
		}
	}

	return NULL;
}

static int dsa_tree_setup_default_cpu(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
	struct dsa_port *dp;
	int device, port;

	/* DSA currently only supports a single CPU port */
	dst->cpu_dp = dsa_tree_find_first_cpu(dst);
	if (!dst->cpu_dp) {
		pr_warn("Tree has no master device\n");
		return -EINVAL;
	}

	/* Assign the default CPU port to all ports of the fabric */
	for (device = 0; device < DSA_MAX_SWITCHES; device++) {
		ds = dst->ds[device];
		if (!ds)
			continue;

		for (port = 0; port < ds->num_ports; port++) {
			dp = &ds->ports[port];

			if (dsa_port_is_user(dp))
				dp->cpu_dp = dst->cpu_dp;
		}
	}

	return 0;
}

static void dsa_tree_teardown_default_cpu(struct dsa_switch_tree *dst)
{
	/* DSA currently only supports a single CPU port */
	dst->cpu_dp = NULL;
}

278
static int dsa_port_setup(struct dsa_port *dp)
279
{
280
	struct dsa_switch *ds = dp->ds;
281 282
	int err;

283
	memset(&dp->devlink_port, 0, sizeof(dp->devlink_port));
284

285 286
	err = devlink_port_register(ds->devlink, &dp->devlink_port, dp->index);
	if (err)
287 288
		return err;

289 290 291 292 293 294 295 296 297 298 299
	switch (dp->type) {
	case DSA_PORT_TYPE_UNUSED:
		break;
	case DSA_PORT_TYPE_CPU:
	case DSA_PORT_TYPE_DSA:
		err = dsa_port_fixed_link_register_of(dp);
		if (err) {
			dev_err(ds->dev, "failed to register fixed link for port %d.%d\n",
				ds->index, dp->index);
			return err;
		}
300

301 302 303 304 305 306 307 308 309
		break;
	case DSA_PORT_TYPE_USER:
		err = dsa_slave_create(dp);
		if (err)
			dev_err(ds->dev, "failed to create slave for port %d.%d\n",
				ds->index, dp->index);
		else
			devlink_port_type_eth_set(&dp->devlink_port, dp->slave);
		break;
310 311 312 313 314
	}

	return 0;
}

315
static void dsa_port_teardown(struct dsa_port *dp)
316
{
317 318 319 320 321 322 323 324 325 326 327 328 329 330 331
	devlink_port_unregister(&dp->devlink_port);

	switch (dp->type) {
	case DSA_PORT_TYPE_UNUSED:
		break;
	case DSA_PORT_TYPE_CPU:
	case DSA_PORT_TYPE_DSA:
		dsa_port_fixed_link_unregister_of(dp);
		break;
	case DSA_PORT_TYPE_USER:
		if (dp->slave) {
			dsa_slave_destroy(dp->slave);
			dp->slave = NULL;
		}
		break;
332 333 334
	}
}

335
static int dsa_switch_setup(struct dsa_switch *ds)
336 337 338
{
	int err;

339
	/* Initialize ds->phys_mii_mask before registering the slave MDIO bus
340
	 * driver and before ops->setup() has run, since the switch drivers and
341 342 343
	 * the slave MDIO bus driver rely on these values for probing PHY
	 * devices or not
	 */
344
	ds->phys_mii_mask |= dsa_user_ports(ds);
345

346 347 348 349 350 351 352 353 354 355 356
	/* Add the switch to devlink before calling setup, so that setup can
	 * add dpipe tables
	 */
	ds->devlink = devlink_alloc(&dsa_devlink_ops, 0);
	if (!ds->devlink)
		return -ENOMEM;

	err = devlink_register(ds->devlink, ds->dev);
	if (err)
		return err;

357
	err = ds->ops->setup(ds);
358 359 360
	if (err < 0)
		return err;

V
Vivien Didelot 已提交
361 362 363 364
	err = dsa_switch_register_notifier(ds);
	if (err)
		return err;

365
	if (!ds->slave_mii_bus && ds->ops->phy_read) {
366 367 368 369 370 371 372 373 374 375 376
		ds->slave_mii_bus = devm_mdiobus_alloc(ds->dev);
		if (!ds->slave_mii_bus)
			return -ENOMEM;

		dsa_slave_mii_bus_init(ds);

		err = mdiobus_register(ds->slave_mii_bus);
		if (err < 0)
			return err;
	}

377 378 379
	return 0;
}

380
static void dsa_switch_teardown(struct dsa_switch *ds)
381
{
382
	if (ds->slave_mii_bus && ds->ops->phy_read)
383
		mdiobus_unregister(ds->slave_mii_bus);
V
Vivien Didelot 已提交
384 385

	dsa_switch_unregister_notifier(ds);
386 387 388 389 390 391 392

	if (ds->devlink) {
		devlink_unregister(ds->devlink);
		devlink_free(ds->devlink);
		ds->devlink = NULL;
	}

393 394
}

395 396 397
static int dsa_tree_setup_switches(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
398 399
	struct dsa_port *dp;
	int device, port;
400 401 402 403 404 405 406 407 408 409
	int err;

	for (device = 0; device < DSA_MAX_SWITCHES; device++) {
		ds = dst->ds[device];
		if (!ds)
			continue;

		err = dsa_switch_setup(ds);
		if (err)
			return err;
410 411 412 413 414 415 416 417

		for (port = 0; port < ds->num_ports; port++) {
			dp = &ds->ports[port];

			err = dsa_port_setup(dp);
			if (err)
				return err;
		}
418 419 420 421 422 423 424 425
	}

	return 0;
}

static void dsa_tree_teardown_switches(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
426 427
	struct dsa_port *dp;
	int device, port;
428 429 430 431 432 433

	for (device = 0; device < DSA_MAX_SWITCHES; device++) {
		ds = dst->ds[device];
		if (!ds)
			continue;

434 435 436 437 438 439
		for (port = 0; port < ds->num_ports; port++) {
			dp = &ds->ports[port];

			dsa_port_teardown(dp);
		}

440 441 442 443
		dsa_switch_teardown(ds);
	}
}

444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460
static int dsa_tree_setup_master(struct dsa_switch_tree *dst)
{
	struct dsa_port *cpu_dp = dst->cpu_dp;
	struct net_device *master = cpu_dp->master;

	/* DSA currently supports a single pair of CPU port and master device */
	return dsa_master_setup(master, cpu_dp);
}

static void dsa_tree_teardown_master(struct dsa_switch_tree *dst)
{
	struct dsa_port *cpu_dp = dst->cpu_dp;
	struct net_device *master = cpu_dp->master;

	return dsa_master_teardown(master);
}

V
Vivien Didelot 已提交
461
static int dsa_tree_setup(struct dsa_switch_tree *dst)
462 463 464
{
	int err;

V
Vivien Didelot 已提交
465 466 467 468 469 470
	if (dst->setup) {
		pr_err("DSA: tree %d already setup! Disjoint trees?\n",
		       dst->index);
		return -EEXIST;
	}

471 472 473 474
	err = dsa_tree_setup_default_cpu(dst);
	if (err)
		return err;

475 476 477
	err = dsa_tree_setup_switches(dst);
	if (err)
		return err;
478

479
	err = dsa_tree_setup_master(dst);
480 481 482
	if (err)
		return err;

V
Vivien Didelot 已提交
483 484 485
	dst->setup = true;

	pr_info("DSA: tree %d setup\n", dst->index);
486 487 488 489

	return 0;
}

V
Vivien Didelot 已提交
490
static void dsa_tree_teardown(struct dsa_switch_tree *dst)
491
{
V
Vivien Didelot 已提交
492
	if (!dst->setup)
493 494
		return;

495
	dsa_tree_teardown_master(dst);
496

497
	dsa_tree_teardown_switches(dst);
498

499
	dsa_tree_teardown_default_cpu(dst);
500

V
Vivien Didelot 已提交
501 502 503
	pr_info("DSA: tree %d torn down\n", dst->index);

	dst->setup = false;
504 505
}

506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526
static void dsa_tree_remove_switch(struct dsa_switch_tree *dst,
				   unsigned int index)
{
	dst->ds[index] = NULL;
	dsa_tree_put(dst);
}

static int dsa_tree_add_switch(struct dsa_switch_tree *dst,
			       struct dsa_switch *ds)
{
	unsigned int index = ds->index;

	if (dst->ds[index])
		return -EBUSY;

	dsa_tree_get(dst);
	dst->ds[index] = ds;

	return 0;
}

527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546
static int dsa_port_parse_user(struct dsa_port *dp, const char *name)
{
	if (!name)
		name = "eth%d";

	dp->type = DSA_PORT_TYPE_USER;
	dp->name = name;

	return 0;
}

static int dsa_port_parse_dsa(struct dsa_port *dp)
{
	dp->type = DSA_PORT_TYPE_DSA;

	return 0;
}

static int dsa_port_parse_cpu(struct dsa_port *dp, struct net_device *master)
{
547 548 549 550 551 552 553 554 555 556 557 558
	struct dsa_switch *ds = dp->ds;
	struct dsa_switch_tree *dst = ds->dst;
	const struct dsa_device_ops *tag_ops;
	enum dsa_tag_protocol tag_protocol;

	tag_protocol = ds->ops->get_tag_protocol(ds);
	tag_ops = dsa_resolve_tag_protocol(tag_protocol);
	if (IS_ERR(tag_ops)) {
		dev_warn(ds->dev, "No tagger for this switch\n");
		return PTR_ERR(tag_ops);
	}

559
	dp->type = DSA_PORT_TYPE_CPU;
560 561
	dp->rcv = tag_ops->rcv;
	dp->tag_ops = tag_ops;
562
	dp->master = master;
563
	dp->dst = dst;
564 565 566 567

	return 0;
}

568 569
static int dsa_port_parse_of(struct dsa_port *dp, struct device_node *dn)
{
570
	struct device_node *ethernet = of_parse_phandle(dn, "ethernet", 0);
571
	const char *name = of_get_property(dn, "label", NULL);
572
	bool link = of_property_read_bool(dn, "link");
573

574 575
	dp->dn = dn;

576
	if (ethernet) {
577 578 579 580 581 582
		struct net_device *master;

		master = of_find_net_device_by_node(ethernet);
		if (!master)
			return -EPROBE_DEFER;

583
		return dsa_port_parse_cpu(dp, master);
584 585
	}

586 587
	if (link)
		return dsa_port_parse_dsa(dp);
588

589
	return dsa_port_parse_user(dp, name);
590 591
}

V
Vivien Didelot 已提交
592 593
static int dsa_switch_parse_ports_of(struct dsa_switch *ds,
				     struct device_node *dn)
594
{
595
	struct device_node *ports, *port;
596
	struct dsa_port *dp;
597
	u32 reg;
598 599 600 601 602 603 604
	int err;

	ports = of_get_child_by_name(dn, "ports");
	if (!ports) {
		dev_err(ds->dev, "no ports child node found\n");
		return -EINVAL;
	}
605 606 607 608 609 610

	for_each_available_child_of_node(ports, port) {
		err = of_property_read_u32(port, "reg", &reg);
		if (err)
			return err;

611
		if (reg >= ds->num_ports)
612 613
			return -EINVAL;

614 615 616 617 618
		dp = &ds->ports[reg];

		err = dsa_port_parse_of(dp, port);
		if (err)
			return err;
619 620 621 622 623
	}

	return 0;
}

V
Vivien Didelot 已提交
624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656
static int dsa_switch_parse_member_of(struct dsa_switch *ds,
				      struct device_node *dn)
{
	u32 m[2] = { 0, 0 };
	int sz;

	/* Don't error out if this optional property isn't found */
	sz = of_property_read_variable_u32_array(dn, "dsa,member", m, 2, 2);
	if (sz < 0 && sz != -EINVAL)
		return sz;

	ds->index = m[1];
	if (ds->index >= DSA_MAX_SWITCHES)
		return -EINVAL;

	ds->dst = dsa_tree_touch(m[0]);
	if (!ds->dst)
		return -ENOMEM;

	return 0;
}

static int dsa_switch_parse_of(struct dsa_switch *ds, struct device_node *dn)
{
	int err;

	err = dsa_switch_parse_member_of(ds, dn);
	if (err)
		return err;

	return dsa_switch_parse_ports_of(ds, dn);
}

657 658 659
static int dsa_port_parse(struct dsa_port *dp, const char *name,
			  struct device *dev)
{
660
	if (!strcmp(name, "cpu")) {
661 662 663 664 665 666 667 668
		struct net_device *master;

		master = dsa_dev_to_net_device(dev);
		if (!master)
			return -EPROBE_DEFER;

		dev_put(master);

669
		return dsa_port_parse_cpu(dp, master);
670 671
	}

672 673
	if (!strcmp(name, "dsa"))
		return dsa_port_parse_dsa(dp);
674

675
	return dsa_port_parse_user(dp, name);
676 677
}

V
Vivien Didelot 已提交
678 679
static int dsa_switch_parse_ports(struct dsa_switch *ds,
				  struct dsa_chip_data *cd)
680 681
{
	bool valid_name_found = false;
682 683 684
	struct dsa_port *dp;
	struct device *dev;
	const char *name;
685
	unsigned int i;
686
	int err;
687 688

	for (i = 0; i < DSA_MAX_PORTS; i++) {
689 690 691 692 693
		name = cd->port_names[i];
		dev = cd->netdev[i];
		dp = &ds->ports[i];

		if (!name)
694 695
			continue;

696 697 698 699
		err = dsa_port_parse(dp, name, dev);
		if (err)
			return err;

700 701 702 703 704 705 706 707 708
		valid_name_found = true;
	}

	if (!valid_name_found && i == DSA_MAX_PORTS)
		return -EINVAL;

	return 0;
}

V
Vivien Didelot 已提交
709
static int dsa_switch_parse(struct dsa_switch *ds, struct dsa_chip_data *cd)
710
{
V
Vivien Didelot 已提交
711
	ds->cd = cd;
712

V
Vivien Didelot 已提交
713 714 715 716 717 718 719
	/* We don't support interconnected switches nor multiple trees via
	 * platform data, so this is the unique switch of the tree.
	 */
	ds->index = 0;
	ds->dst = dsa_tree_touch(0);
	if (!ds->dst)
		return -ENOMEM;
720

V
Vivien Didelot 已提交
721
	return dsa_switch_parse_ports(ds, cd);
722 723
}

724
static int _dsa_register_switch(struct dsa_switch *ds)
725
{
726 727
	struct dsa_chip_data *pdata = ds->dev->platform_data;
	struct device_node *np = ds->dev->of_node;
728
	struct dsa_switch_tree *dst;
V
Vivien Didelot 已提交
729
	unsigned int index;
730
	int i, err;
731

V
Vivien Didelot 已提交
732 733 734 735 736 737
	if (np)
		err = dsa_switch_parse_of(ds, np);
	else if (pdata)
		err = dsa_switch_parse(ds, pdata);
	else
		err = -ENODEV;
738

V
Vivien Didelot 已提交
739 740
	if (err)
		return err;
741

V
Vivien Didelot 已提交
742 743
	index = ds->index;
	dst = ds->dst;
744

745 746 747 748
	/* Initialize the routing table */
	for (i = 0; i < DSA_MAX_SWITCHES; ++i)
		ds->rtable[i] = DSA_RTABLE_NONE;

749 750 751
	err = dsa_tree_add_switch(dst, ds);
	if (err)
		return err;
752 753 754 755 756

	err = dsa_dst_complete(dst);
	if (err < 0)
		goto out_del_dst;

757 758 759
	/* Not all switches registered yet */
	if (err == 1)
		return 0;
760

V
Vivien Didelot 已提交
761
	err = dsa_tree_setup(dst);
762
	if (err) {
V
Vivien Didelot 已提交
763
		dsa_tree_teardown(dst);
764 765 766 767 768 769
		goto out_del_dst;
	}

	return 0;

out_del_dst:
770
	dsa_tree_remove_switch(dst, index);
771 772 773 774

	return err;
}

775 776 777 778
struct dsa_switch *dsa_switch_alloc(struct device *dev, size_t n)
{
	size_t size = sizeof(struct dsa_switch) + n * sizeof(struct dsa_port);
	struct dsa_switch *ds;
779
	int i;
780 781 782 783 784 785 786 787

	ds = devm_kzalloc(dev, size, GFP_KERNEL);
	if (!ds)
		return NULL;

	ds->dev = dev;
	ds->num_ports = n;

788 789 790 791 792
	for (i = 0; i < ds->num_ports; ++i) {
		ds->ports[i].index = i;
		ds->ports[i].ds = ds;
	}

793 794 795 796
	return ds;
}
EXPORT_SYMBOL_GPL(dsa_switch_alloc);

797
int dsa_register_switch(struct dsa_switch *ds)
798 799 800 801
{
	int err;

	mutex_lock(&dsa2_mutex);
802
	err = _dsa_register_switch(ds);
803 804 805 806 807 808
	mutex_unlock(&dsa2_mutex);

	return err;
}
EXPORT_SYMBOL_GPL(dsa_register_switch);

809
static void _dsa_unregister_switch(struct dsa_switch *ds)
810 811
{
	struct dsa_switch_tree *dst = ds->dst;
812
	unsigned int index = ds->index;
813

V
Vivien Didelot 已提交
814
	dsa_tree_teardown(dst);
815

816
	dsa_tree_remove_switch(dst, index);
817 818 819 820 821 822 823 824 825
}

void dsa_unregister_switch(struct dsa_switch *ds)
{
	mutex_lock(&dsa2_mutex);
	_dsa_unregister_switch(ds);
	mutex_unlock(&dsa2_mutex);
}
EXPORT_SYMBOL_GPL(dsa_unregister_switch);