dsa2.c 16.6 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15
/*
 * net/dsa/dsa2.c - Hardware switch handling, binding version 2
 * Copyright (c) 2008-2009 Marvell Semiconductor
 * Copyright (c) 2013 Florian Fainelli <florian@openwrt.org>
 * Copyright (c) 2016 Andrew Lunn <andrew@lunn.ch>
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 */

#include <linux/device.h>
#include <linux/err.h>
#include <linux/list.h>
16
#include <linux/netdevice.h>
17 18 19 20
#include <linux/slab.h>
#include <linux/rtnetlink.h>
#include <linux/of.h>
#include <linux/of_net.h>
21

22 23 24 25 26
#include "dsa_priv.h"

static LIST_HEAD(dsa_switch_trees);
static DEFINE_MUTEX(dsa2_mutex);

27 28 29
static const struct devlink_ops dsa_devlink_ops = {
};

30
static struct dsa_switch_tree *dsa_get_dst(unsigned int index)
31 32 33 34
{
	struct dsa_switch_tree *dst;

	list_for_each_entry(dst, &dsa_switch_trees, list)
35
		if (dst->index == index)
36
			return dst;
37

38 39 40
	return NULL;
}

41
static struct dsa_switch_tree *dsa_add_dst(unsigned int index)
42 43 44 45 46 47
{
	struct dsa_switch_tree *dst;

	dst = kzalloc(sizeof(*dst), GFP_KERNEL);
	if (!dst)
		return NULL;
48
	dst->index = index;
49 50
	INIT_LIST_HEAD(&dst->list);
	list_add_tail(&dsa_switch_trees, &dst->list);
51 52

	/* Initialize the reference counter to the number of switches, not 1 */
53
	kref_init(&dst->refcount);
54
	refcount_set(&dst->refcount.refcount, 0);
55 56 57 58

	return dst;
}

59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83
static void dsa_tree_free(struct dsa_switch_tree *dst)
{
	list_del(&dst->list);
	kfree(dst);
}

static void dsa_tree_get(struct dsa_switch_tree *dst)
{
	kref_get(&dst->refcount);
}

static void dsa_tree_release(struct kref *ref)
{
	struct dsa_switch_tree *dst;

	dst = container_of(ref, struct dsa_switch_tree, refcount);

	dsa_tree_free(dst);
}

static void dsa_tree_put(struct dsa_switch_tree *dst)
{
	kref_put(&dst->refcount, dsa_tree_release);
}

84 85 86
static void dsa_dst_add_ds(struct dsa_switch_tree *dst,
			   struct dsa_switch *ds, u32 index)
{
87
	dsa_tree_get(dst);
88 89 90 91 92 93 94
	dst->ds[index] = ds;
}

static void dsa_dst_del_ds(struct dsa_switch_tree *dst,
			   struct dsa_switch *ds, u32 index)
{
	dst->ds[index] = NULL;
95
	dsa_tree_put(dst);
96 97
}

98 99 100
/* For platform data configurations, we need to have a valid name argument to
 * differentiate a disabled port from an enabled one
 */
101
static bool dsa_port_is_valid(struct dsa_port *port)
102
{
103
	return port->type != DSA_PORT_TYPE_UNUSED;
104 105
}

106
static bool dsa_port_is_dsa(struct dsa_port *port)
107
{
108
	return port->type == DSA_PORT_TYPE_DSA;
109 110 111 112
}

static bool dsa_port_is_cpu(struct dsa_port *port)
{
113
	return port->type == DSA_PORT_TYPE_CPU;
114 115
}

116 117
static bool dsa_ds_find_port_dn(struct dsa_switch *ds,
				struct device_node *port)
118 119 120
{
	u32 index;

121
	for (index = 0; index < ds->num_ports; index++)
122 123 124 125 126
		if (ds->ports[index].dn == port)
			return true;
	return false;
}

127 128
static struct dsa_switch *dsa_dst_find_port_dn(struct dsa_switch_tree *dst,
					       struct device_node *port)
129 130 131 132 133 134 135 136 137
{
	struct dsa_switch *ds;
	u32 index;

	for (index = 0; index < DSA_MAX_SWITCHES; index++) {
		ds = dst->ds[index];
		if (!ds)
			continue;

138
		if (dsa_ds_find_port_dn(ds, port))
139 140 141 142 143 144 145 146
			return ds;
	}

	return NULL;
}

static int dsa_port_complete(struct dsa_switch_tree *dst,
			     struct dsa_switch *src_ds,
147
			     struct dsa_port *port,
148 149 150 151 152 153 154
			     u32 src_port)
{
	struct device_node *link;
	int index;
	struct dsa_switch *dst_ds;

	for (index = 0;; index++) {
155
		link = of_parse_phandle(port->dn, "link", index);
156 157 158
		if (!link)
			break;

159
		dst_ds = dsa_dst_find_port_dn(dst, link);
160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177
		of_node_put(link);

		if (!dst_ds)
			return 1;

		src_ds->rtable[dst_ds->index] = src_port;
	}

	return 0;
}

/* A switch is complete if all the DSA ports phandles point to ports
 * known in the tree. A return value of 1 means the tree is not
 * complete. This is not an error condition. A value of 0 is
 * success.
 */
static int dsa_ds_complete(struct dsa_switch_tree *dst, struct dsa_switch *ds)
{
178
	struct dsa_port *port;
179 180 181
	u32 index;
	int err;

182
	for (index = 0; index < ds->num_ports; index++) {
183 184
		port = &ds->ports[index];
		if (!dsa_port_is_valid(port))
185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221
			continue;

		if (!dsa_port_is_dsa(port))
			continue;

		err = dsa_port_complete(dst, ds, port, index);
		if (err != 0)
			return err;
	}

	return 0;
}

/* A tree is complete if all the DSA ports phandles point to ports
 * known in the tree. A return value of 1 means the tree is not
 * complete. This is not an error condition. A value of 0 is
 * success.
 */
static int dsa_dst_complete(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
	u32 index;
	int err;

	for (index = 0; index < DSA_MAX_SWITCHES; index++) {
		ds = dst->ds[index];
		if (!ds)
			continue;

		err = dsa_ds_complete(dst, ds);
		if (err != 0)
			return err;
	}

	return 0;
}

222
static int dsa_dsa_port_apply(struct dsa_port *port)
223
{
224
	struct dsa_switch *ds = port->ds;
225 226
	int err;

227
	err = dsa_port_fixed_link_register_of(port);
228 229
	if (err) {
		dev_warn(ds->dev, "Failed to setup dsa port %d: %d\n",
230
			 port->index, err);
231 232 233
		return err;
	}

234
	memset(&port->devlink_port, 0, sizeof(port->devlink_port));
235

236 237
	return devlink_port_register(ds->devlink, &port->devlink_port,
				     port->index);
238 239
}

240
static void dsa_dsa_port_unapply(struct dsa_port *port)
241
{
242
	devlink_port_unregister(&port->devlink_port);
243
	dsa_port_fixed_link_unregister_of(port);
244 245
}

246
static int dsa_cpu_port_apply(struct dsa_port *port)
247
{
248
	struct dsa_switch *ds = port->ds;
249 250
	int err;

251
	err = dsa_port_fixed_link_register_of(port);
252 253
	if (err) {
		dev_warn(ds->dev, "Failed to setup cpu port %d: %d\n",
254
			 port->index, err);
255 256 257
		return err;
	}

258 259 260
	memset(&port->devlink_port, 0, sizeof(port->devlink_port));
	err = devlink_port_register(ds->devlink, &port->devlink_port,
				    port->index);
261
	return err;
262 263
}

264
static void dsa_cpu_port_unapply(struct dsa_port *port)
265
{
266
	devlink_port_unregister(&port->devlink_port);
267
	dsa_port_fixed_link_unregister_of(port);
268 269
}

270
static int dsa_user_port_apply(struct dsa_port *port)
271
{
272
	struct dsa_switch *ds = port->ds;
273 274
	int err;

275
	err = dsa_slave_create(port);
276 277
	if (err) {
		dev_warn(ds->dev, "Failed to create slave %d: %d\n",
278
			 port->index, err);
279
		port->slave = NULL;
280 281 282
		return err;
	}

283 284 285
	memset(&port->devlink_port, 0, sizeof(port->devlink_port));
	err = devlink_port_register(ds->devlink, &port->devlink_port,
				    port->index);
286 287 288
	if (err)
		return err;

289
	devlink_port_type_eth_set(&port->devlink_port, port->slave);
290

291 292 293
	return 0;
}

294
static void dsa_user_port_unapply(struct dsa_port *port)
295
{
296
	devlink_port_unregister(&port->devlink_port);
297 298 299
	if (port->slave) {
		dsa_slave_destroy(port->slave);
		port->slave = NULL;
300 301 302 303 304
	}
}

static int dsa_ds_apply(struct dsa_switch_tree *dst, struct dsa_switch *ds)
{
305
	struct dsa_port *port;
306 307 308
	u32 index;
	int err;

309
	/* Initialize ds->phys_mii_mask before registering the slave MDIO bus
310
	 * driver and before ops->setup() has run, since the switch drivers and
311 312 313
	 * the slave MDIO bus driver rely on these values for probing PHY
	 * devices or not
	 */
314
	ds->phys_mii_mask |= dsa_user_ports(ds);
315

316 317 318 319 320 321 322 323 324 325 326
	/* Add the switch to devlink before calling setup, so that setup can
	 * add dpipe tables
	 */
	ds->devlink = devlink_alloc(&dsa_devlink_ops, 0);
	if (!ds->devlink)
		return -ENOMEM;

	err = devlink_register(ds->devlink, ds->dev);
	if (err)
		return err;

327
	err = ds->ops->setup(ds);
328 329 330
	if (err < 0)
		return err;

V
Vivien Didelot 已提交
331 332 333 334
	err = dsa_switch_register_notifier(ds);
	if (err)
		return err;

335
	if (!ds->slave_mii_bus && ds->ops->phy_read) {
336 337 338 339 340 341 342 343 344 345 346
		ds->slave_mii_bus = devm_mdiobus_alloc(ds->dev);
		if (!ds->slave_mii_bus)
			return -ENOMEM;

		dsa_slave_mii_bus_init(ds);

		err = mdiobus_register(ds->slave_mii_bus);
		if (err < 0)
			return err;
	}

347
	for (index = 0; index < ds->num_ports; index++) {
348 349
		port = &ds->ports[index];
		if (!dsa_port_is_valid(port))
350 351 352
			continue;

		if (dsa_port_is_dsa(port)) {
353
			err = dsa_dsa_port_apply(port);
354 355 356 357 358 359
			if (err)
				return err;
			continue;
		}

		if (dsa_port_is_cpu(port)) {
360
			err = dsa_cpu_port_apply(port);
361 362 363 364 365
			if (err)
				return err;
			continue;
		}

366
		err = dsa_user_port_apply(port);
367 368 369 370 371 372 373 374 375
		if (err)
			continue;
	}

	return 0;
}

static void dsa_ds_unapply(struct dsa_switch_tree *dst, struct dsa_switch *ds)
{
376
	struct dsa_port *port;
377 378
	u32 index;

379
	for (index = 0; index < ds->num_ports; index++) {
380 381
		port = &ds->ports[index];
		if (!dsa_port_is_valid(port))
382 383 384
			continue;

		if (dsa_port_is_dsa(port)) {
385
			dsa_dsa_port_unapply(port);
386 387 388 389
			continue;
		}

		if (dsa_port_is_cpu(port)) {
390
			dsa_cpu_port_unapply(port);
391 392 393
			continue;
		}

394
		dsa_user_port_unapply(port);
395
	}
396

397
	if (ds->slave_mii_bus && ds->ops->phy_read)
398
		mdiobus_unregister(ds->slave_mii_bus);
V
Vivien Didelot 已提交
399 400

	dsa_switch_unregister_notifier(ds);
401 402 403 404 405 406 407

	if (ds->devlink) {
		devlink_unregister(ds->devlink);
		devlink_free(ds->devlink);
		ds->devlink = NULL;
	}

408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430
}

static int dsa_dst_apply(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
	u32 index;
	int err;

	for (index = 0; index < DSA_MAX_SWITCHES; index++) {
		ds = dst->ds[index];
		if (!ds)
			continue;

		err = dsa_ds_apply(dst, ds);
		if (err)
			return err;
	}

	/* If we use a tagging format that doesn't have an ethertype
	 * field, make sure that all packets from this point on get
	 * sent to the tag format's receive function.
	 */
	wmb();
431
	dst->cpu_dp->master->dsa_ptr = dst->cpu_dp;
432

433
	err = dsa_master_ethtool_setup(dst->cpu_dp->master);
434 435 436
	if (err)
		return err;

437 438 439 440 441 442 443 444 445 446 447 448 449
	dst->applied = true;

	return 0;
}

static void dsa_dst_unapply(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
	u32 index;

	if (!dst->applied)
		return;

450
	dsa_master_ethtool_restore(dst->cpu_dp->master);
451

452
	dst->cpu_dp->master->dsa_ptr = NULL;
453 454 455 456 457 458 459 460 461 462 463 464 465 466 467

	/* If we used a tagging format that doesn't have an ethertype
	 * field, make sure that all packets from this point get sent
	 * without the tag and go through the regular receive path.
	 */
	wmb();

	for (index = 0; index < DSA_MAX_SWITCHES; index++) {
		ds = dst->ds[index];
		if (!ds)
			continue;

		dsa_ds_unapply(dst, ds);
	}

468
	dst->cpu_dp = NULL;
469

470
	pr_info("DSA: tree %d unapplied\n", dst->index);
471 472 473
	dst->applied = false;
}

474
static int dsa_cpu_parse(struct dsa_port *port, u32 index,
475 476 477
			 struct dsa_switch_tree *dst,
			 struct dsa_switch *ds)
{
478
	const struct dsa_device_ops *tag_ops;
479
	enum dsa_tag_protocol tag_protocol;
480

481
	if (!dst->cpu_dp)
482
		dst->cpu_dp = port;
483

484
	tag_protocol = ds->ops->get_tag_protocol(ds);
485 486
	tag_ops = dsa_resolve_tag_protocol(tag_protocol);
	if (IS_ERR(tag_ops)) {
487
		dev_warn(ds->dev, "No tagger for this switch\n");
488
		return PTR_ERR(tag_ops);
489 490
	}

V
Vivien Didelot 已提交
491
	dst->cpu_dp->tag_ops = tag_ops;
492 493 494 495

	/* Make a few copies for faster access in master receive hot path */
	dst->cpu_dp->rcv = dst->cpu_dp->tag_ops->rcv;
	dst->cpu_dp->dst = dst;
496 497 498 499 500 501

	return 0;
}

static int dsa_ds_parse(struct dsa_switch_tree *dst, struct dsa_switch *ds)
{
502
	struct dsa_port *port;
503 504 505
	u32 index;
	int err;

506
	for (index = 0; index < ds->num_ports; index++) {
507
		port = &ds->ports[index];
508 509
		if (!dsa_port_is_valid(port) ||
		    dsa_port_is_dsa(port))
510 511 512 513 514 515 516
			continue;

		if (dsa_port_is_cpu(port)) {
			err = dsa_cpu_parse(port, index, dst, ds);
			if (err)
				return err;
		}
517

518 519
	}

520
	pr_info("DSA: switch %d %d parsed\n", dst->index, ds->index);
521 522 523 524 525 526 527

	return 0;
}

static int dsa_dst_parse(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
528
	struct dsa_port *dp;
529
	u32 index;
530
	int port;
531 532 533 534 535 536 537 538 539 540 541 542
	int err;

	for (index = 0; index < DSA_MAX_SWITCHES; index++) {
		ds = dst->ds[index];
		if (!ds)
			continue;

		err = dsa_ds_parse(dst, ds);
		if (err)
			return err;
	}

543
	if (!dst->cpu_dp) {
544 545 546 547
		pr_warn("Tree has no master device\n");
		return -EINVAL;
	}

548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564
	/* Assign the default CPU port to all ports of the fabric */
	for (index = 0; index < DSA_MAX_SWITCHES; index++) {
		ds = dst->ds[index];
		if (!ds)
			continue;

		for (port = 0; port < ds->num_ports; port++) {
			dp = &ds->ports[port];
			if (!dsa_port_is_valid(dp) ||
			    dsa_port_is_dsa(dp) ||
			    dsa_port_is_cpu(dp))
				continue;

			dp->cpu_dp = dst->cpu_dp;
		}
	}

565
	pr_info("DSA: tree %d parsed\n", dst->index);
566 567 568 569

	return 0;
}

570 571
static int dsa_port_parse_of(struct dsa_port *dp, struct device_node *dn)
{
572 573
	struct device_node *ethernet = of_parse_phandle(dn, "ethernet", 0);
	struct device_node *link = of_parse_phandle(dn, "link", 0);
574
	const char *name = of_get_property(dn, "label", NULL);
575 576

	if (ethernet) {
577 578 579 580 581 582
		struct net_device *master;

		master = of_find_net_device_by_node(ethernet);
		if (!master)
			return -EPROBE_DEFER;

583
		dp->type = DSA_PORT_TYPE_CPU;
584
		dp->master = master;
585 586 587
	} else if (link) {
		dp->type = DSA_PORT_TYPE_DSA;
	} else {
588 589 590
		if (!name)
			name = "eth%d";

591
		dp->type = DSA_PORT_TYPE_USER;
592
		dp->name = name;
593 594
	}

595 596 597 598 599
	dp->dn = dn;

	return 0;
}

600
static int dsa_parse_ports_of(struct device_node *dn, struct dsa_switch *ds)
601
{
602
	struct device_node *ports, *port;
603
	struct dsa_port *dp;
604
	u32 reg;
605 606 607 608 609 610 611
	int err;

	ports = of_get_child_by_name(dn, "ports");
	if (!ports) {
		dev_err(ds->dev, "no ports child node found\n");
		return -EINVAL;
	}
612 613 614 615 616 617

	for_each_available_child_of_node(ports, port) {
		err = of_property_read_u32(port, "reg", &reg);
		if (err)
			return err;

618
		if (reg >= ds->num_ports)
619 620
			return -EINVAL;

621 622 623 624 625
		dp = &ds->ports[reg];

		err = dsa_port_parse_of(dp, port);
		if (err)
			return err;
626 627 628 629 630
	}

	return 0;
}

631 632 633
static int dsa_port_parse(struct dsa_port *dp, const char *name,
			  struct device *dev)
{
634
	if (!strcmp(name, "cpu")) {
635 636 637 638 639 640 641 642
		struct net_device *master;

		master = dsa_dev_to_net_device(dev);
		if (!master)
			return -EPROBE_DEFER;

		dev_put(master);

643
		dp->type = DSA_PORT_TYPE_CPU;
644
		dp->master = master;
645 646 647 648 649 650
	} else if (!strcmp(name, "dsa")) {
		dp->type = DSA_PORT_TYPE_DSA;
	} else {
		dp->type = DSA_PORT_TYPE_USER;
	}

651 652 653 654 655
	dp->name = name;

	return 0;
}

656 657 658
static int dsa_parse_ports(struct dsa_chip_data *cd, struct dsa_switch *ds)
{
	bool valid_name_found = false;
659 660 661
	struct dsa_port *dp;
	struct device *dev;
	const char *name;
662
	unsigned int i;
663
	int err;
664 665

	for (i = 0; i < DSA_MAX_PORTS; i++) {
666 667 668 669 670
		name = cd->port_names[i];
		dev = cd->netdev[i];
		dp = &ds->ports[i];

		if (!name)
671 672
			continue;

673 674 675 676
		err = dsa_port_parse(dp, name, dev);
		if (err)
			return err;

677 678 679 680 681 682 683 684 685
		valid_name_found = true;
	}

	if (!valid_name_found && i == DSA_MAX_PORTS)
		return -EINVAL;

	return 0;
}

686
static int dsa_parse_member_dn(struct device_node *np, u32 *tree, u32 *index)
687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709
{
	int err;

	*tree = *index = 0;

	err = of_property_read_u32_index(np, "dsa,member", 0, tree);
	if (err) {
		/* Does not exist, but it is optional */
		if (err == -EINVAL)
			return 0;
		return err;
	}

	err = of_property_read_u32_index(np, "dsa,member", 1, index);
	if (err)
		return err;

	if (*index >= DSA_MAX_SWITCHES)
		return -EINVAL;

	return 0;
}

710 711 712 713 714 715 716 717 718 719 720 721
static int dsa_parse_member(struct dsa_chip_data *pd, u32 *tree, u32 *index)
{
	if (!pd)
		return -ENODEV;

	/* We do not support complex trees with dsa_chip_data */
	*tree = 0;
	*index = 0;

	return 0;
}

722
static int _dsa_register_switch(struct dsa_switch *ds)
723
{
724 725
	struct dsa_chip_data *pdata = ds->dev->platform_data;
	struct device_node *np = ds->dev->of_node;
726 727
	struct dsa_switch_tree *dst;
	u32 tree, index;
728
	int i, err;
729

730 731 732 733
	if (np) {
		err = dsa_parse_member_dn(np, &tree, &index);
		if (err)
			return err;
734

735
		err = dsa_parse_ports_of(np, ds);
736 737 738 739 740 741 742 743 744 745 746
		if (err)
			return err;
	} else {
		err = dsa_parse_member(pdata, &tree, &index);
		if (err)
			return err;

		err = dsa_parse_ports(pdata, ds);
		if (err)
			return err;
	}
747 748 749 750 751 752 753 754

	dst = dsa_get_dst(tree);
	if (!dst) {
		dst = dsa_add_dst(tree);
		if (!dst)
			return -ENOMEM;
	}

755 756
	if (dst->ds[index])
		return -EBUSY;
757 758 759

	ds->dst = dst;
	ds->index = index;
760
	ds->cd = pdata;
761 762 763 764 765

	/* Initialize the routing table */
	for (i = 0; i < DSA_MAX_SWITCHES; ++i)
		ds->rtable[i] = DSA_RTABLE_NONE;

766 767 768 769 770 771
	dsa_dst_add_ds(dst, ds, index);

	err = dsa_dst_complete(dst);
	if (err < 0)
		goto out_del_dst;

772 773 774
	/* Not all switches registered yet */
	if (err == 1)
		return 0;
775 776 777 778 779 780 781

	if (dst->applied) {
		pr_info("DSA: Disjoint trees?\n");
		return -EINVAL;
	}

	err = dsa_dst_parse(dst);
782
	if (err)
783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798
		goto out_del_dst;

	err = dsa_dst_apply(dst);
	if (err) {
		dsa_dst_unapply(dst);
		goto out_del_dst;
	}

	return 0;

out_del_dst:
	dsa_dst_del_ds(dst, ds, ds->index);

	return err;
}

799 800 801 802
struct dsa_switch *dsa_switch_alloc(struct device *dev, size_t n)
{
	size_t size = sizeof(struct dsa_switch) + n * sizeof(struct dsa_port);
	struct dsa_switch *ds;
803
	int i;
804 805 806 807 808 809 810 811

	ds = devm_kzalloc(dev, size, GFP_KERNEL);
	if (!ds)
		return NULL;

	ds->dev = dev;
	ds->num_ports = n;

812 813 814 815 816
	for (i = 0; i < ds->num_ports; ++i) {
		ds->ports[i].index = i;
		ds->ports[i].ds = ds;
	}

817 818 819 820
	return ds;
}
EXPORT_SYMBOL_GPL(dsa_switch_alloc);

821
int dsa_register_switch(struct dsa_switch *ds)
822 823 824 825
{
	int err;

	mutex_lock(&dsa2_mutex);
826
	err = _dsa_register_switch(ds);
827 828 829 830 831 832
	mutex_unlock(&dsa2_mutex);

	return err;
}
EXPORT_SYMBOL_GPL(dsa_register_switch);

833
static void _dsa_unregister_switch(struct dsa_switch *ds)
834 835 836 837 838 839 840 841 842 843 844 845 846 847 848
{
	struct dsa_switch_tree *dst = ds->dst;

	dsa_dst_unapply(dst);

	dsa_dst_del_ds(dst, ds, ds->index);
}

void dsa_unregister_switch(struct dsa_switch *ds)
{
	mutex_lock(&dsa2_mutex);
	_dsa_unregister_switch(ds);
	mutex_unlock(&dsa2_mutex);
}
EXPORT_SYMBOL_GPL(dsa_unregister_switch);