dsa2.c 15.2 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15
/*
 * net/dsa/dsa2.c - Hardware switch handling, binding version 2
 * Copyright (c) 2008-2009 Marvell Semiconductor
 * Copyright (c) 2013 Florian Fainelli <florian@openwrt.org>
 * Copyright (c) 2016 Andrew Lunn <andrew@lunn.ch>
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 */

#include <linux/device.h>
#include <linux/err.h>
#include <linux/list.h>
16
#include <linux/netdevice.h>
17 18 19 20
#include <linux/slab.h>
#include <linux/rtnetlink.h>
#include <linux/of.h>
#include <linux/of_net.h>
21

22 23
#include "dsa_priv.h"

24
static LIST_HEAD(dsa_tree_list);
25 26
static DEFINE_MUTEX(dsa2_mutex);

27 28 29
static const struct devlink_ops dsa_devlink_ops = {
};

30
static struct dsa_switch_tree *dsa_tree_find(int index)
31 32 33
{
	struct dsa_switch_tree *dst;

34
	list_for_each_entry(dst, &dsa_tree_list, list)
35
		if (dst->index == index)
36
			return dst;
37

38 39 40
	return NULL;
}

41
static struct dsa_switch_tree *dsa_tree_alloc(int index)
42 43 44 45 46 47
{
	struct dsa_switch_tree *dst;

	dst = kzalloc(sizeof(*dst), GFP_KERNEL);
	if (!dst)
		return NULL;
48

49
	dst->index = index;
50

51
	INIT_LIST_HEAD(&dst->list);
52
	list_add_tail(&dsa_tree_list, &dst->list);
53

54 55 56 57 58
	kref_init(&dst->refcount);

	return dst;
}

59 60 61 62 63 64
static void dsa_tree_free(struct dsa_switch_tree *dst)
{
	list_del(&dst->list);
	kfree(dst);
}

65
static struct dsa_switch_tree *dsa_tree_get(struct dsa_switch_tree *dst)
66
{
67 68
	if (dst)
		kref_get(&dst->refcount);
69 70 71 72

	return dst;
}

73
static struct dsa_switch_tree *dsa_tree_touch(int index)
74
{
75 76 77 78 79 80 81
	struct dsa_switch_tree *dst;

	dst = dsa_tree_find(index);
	if (dst)
		return dsa_tree_get(dst);
	else
		return dsa_tree_alloc(index);
82 83 84 85 86 87 88 89 90 91 92 93 94
}

static void dsa_tree_release(struct kref *ref)
{
	struct dsa_switch_tree *dst;

	dst = container_of(ref, struct dsa_switch_tree, refcount);

	dsa_tree_free(dst);
}

static void dsa_tree_put(struct dsa_switch_tree *dst)
{
95 96
	if (dst)
		kref_put(&dst->refcount, dsa_tree_release);
97 98
}

99
static bool dsa_port_is_dsa(struct dsa_port *port)
100
{
101
	return port->type == DSA_PORT_TYPE_DSA;
102 103 104 105
}

static bool dsa_port_is_cpu(struct dsa_port *port)
{
106
	return port->type == DSA_PORT_TYPE_CPU;
107 108
}

109 110 111 112 113
static bool dsa_port_is_user(struct dsa_port *dp)
{
	return dp->type == DSA_PORT_TYPE_USER;
}

114 115
static struct dsa_port *dsa_tree_find_port_by_node(struct dsa_switch_tree *dst,
						   struct device_node *dn)
116 117
{
	struct dsa_switch *ds;
118 119
	struct dsa_port *dp;
	int device, port;
120

121 122
	for (device = 0; device < DSA_MAX_SWITCHES; device++) {
		ds = dst->ds[device];
123 124 125
		if (!ds)
			continue;

126 127 128 129 130 131
		for (port = 0; port < ds->num_ports; port++) {
			dp = &ds->ports[port];

			if (dp->dn == dn)
				return dp;
		}
132 133 134 135 136
	}

	return NULL;
}

V
Vivien Didelot 已提交
137
static bool dsa_port_setup_routing_table(struct dsa_port *dp)
138
{
V
Vivien Didelot 已提交
139 140 141
	struct dsa_switch *ds = dp->ds;
	struct dsa_switch_tree *dst = ds->dst;
	struct device_node *dn = dp->dn;
V
Vivien Didelot 已提交
142
	struct of_phandle_iterator it;
143
	struct dsa_port *link_dp;
V
Vivien Didelot 已提交
144
	int err;
145

V
Vivien Didelot 已提交
146 147 148 149
	of_for_each_phandle(&it, err, dn, "link", NULL, 0) {
		link_dp = dsa_tree_find_port_by_node(dst, it.node);
		if (!link_dp) {
			of_node_put(it.node);
V
Vivien Didelot 已提交
150
			return false;
V
Vivien Didelot 已提交
151
		}
152

V
Vivien Didelot 已提交
153
		ds->rtable[link_dp->ds->index] = dp->index;
154 155
	}

V
Vivien Didelot 已提交
156
	return true;
157 158
}

V
Vivien Didelot 已提交
159
static bool dsa_switch_setup_routing_table(struct dsa_switch *ds)
160
{
V
Vivien Didelot 已提交
161 162 163
	bool complete = true;
	struct dsa_port *dp;
	int i;
164

V
Vivien Didelot 已提交
165 166
	for (i = 0; i < DSA_MAX_SWITCHES; i++)
		ds->rtable[i] = DSA_RTABLE_NONE;
167

V
Vivien Didelot 已提交
168 169
	for (i = 0; i < ds->num_ports; i++) {
		dp = &ds->ports[i];
170

V
Vivien Didelot 已提交
171 172 173 174 175
		if (dsa_port_is_dsa(dp)) {
			complete = dsa_port_setup_routing_table(dp);
			if (!complete)
				break;
		}
176 177
	}

V
Vivien Didelot 已提交
178
	return complete;
179 180
}

V
Vivien Didelot 已提交
181
static bool dsa_tree_setup_routing_table(struct dsa_switch_tree *dst)
182 183
{
	struct dsa_switch *ds;
V
Vivien Didelot 已提交
184 185
	bool complete = true;
	int device;
186

V
Vivien Didelot 已提交
187 188
	for (device = 0; device < DSA_MAX_SWITCHES; device++) {
		ds = dst->ds[device];
189 190 191
		if (!ds)
			continue;

V
Vivien Didelot 已提交
192 193 194
		complete = dsa_switch_setup_routing_table(ds);
		if (!complete)
			break;
195 196
	}

V
Vivien Didelot 已提交
197
	return complete;
198 199
}

200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257
static struct dsa_port *dsa_tree_find_first_cpu(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
	struct dsa_port *dp;
	int device, port;

	for (device = 0; device < DSA_MAX_SWITCHES; device++) {
		ds = dst->ds[device];
		if (!ds)
			continue;

		for (port = 0; port < ds->num_ports; port++) {
			dp = &ds->ports[port];

			if (dsa_port_is_cpu(dp))
				return dp;
		}
	}

	return NULL;
}

static int dsa_tree_setup_default_cpu(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
	struct dsa_port *dp;
	int device, port;

	/* DSA currently only supports a single CPU port */
	dst->cpu_dp = dsa_tree_find_first_cpu(dst);
	if (!dst->cpu_dp) {
		pr_warn("Tree has no master device\n");
		return -EINVAL;
	}

	/* Assign the default CPU port to all ports of the fabric */
	for (device = 0; device < DSA_MAX_SWITCHES; device++) {
		ds = dst->ds[device];
		if (!ds)
			continue;

		for (port = 0; port < ds->num_ports; port++) {
			dp = &ds->ports[port];

			if (dsa_port_is_user(dp))
				dp->cpu_dp = dst->cpu_dp;
		}
	}

	return 0;
}

static void dsa_tree_teardown_default_cpu(struct dsa_switch_tree *dst)
{
	/* DSA currently only supports a single CPU port */
	dst->cpu_dp = NULL;
}

258
static int dsa_port_setup(struct dsa_port *dp)
259
{
260
	struct dsa_switch *ds = dp->ds;
261 262
	int err;

263
	memset(&dp->devlink_port, 0, sizeof(dp->devlink_port));
264

265 266
	err = devlink_port_register(ds->devlink, &dp->devlink_port, dp->index);
	if (err)
267 268
		return err;

269 270 271 272 273 274 275 276 277 278 279
	switch (dp->type) {
	case DSA_PORT_TYPE_UNUSED:
		break;
	case DSA_PORT_TYPE_CPU:
	case DSA_PORT_TYPE_DSA:
		err = dsa_port_fixed_link_register_of(dp);
		if (err) {
			dev_err(ds->dev, "failed to register fixed link for port %d.%d\n",
				ds->index, dp->index);
			return err;
		}
280

281 282 283 284 285 286 287 288 289
		break;
	case DSA_PORT_TYPE_USER:
		err = dsa_slave_create(dp);
		if (err)
			dev_err(ds->dev, "failed to create slave for port %d.%d\n",
				ds->index, dp->index);
		else
			devlink_port_type_eth_set(&dp->devlink_port, dp->slave);
		break;
290 291 292 293 294
	}

	return 0;
}

295
static void dsa_port_teardown(struct dsa_port *dp)
296
{
297 298 299 300 301 302 303 304 305 306 307 308 309 310 311
	devlink_port_unregister(&dp->devlink_port);

	switch (dp->type) {
	case DSA_PORT_TYPE_UNUSED:
		break;
	case DSA_PORT_TYPE_CPU:
	case DSA_PORT_TYPE_DSA:
		dsa_port_fixed_link_unregister_of(dp);
		break;
	case DSA_PORT_TYPE_USER:
		if (dp->slave) {
			dsa_slave_destroy(dp->slave);
			dp->slave = NULL;
		}
		break;
312 313 314
	}
}

315
static int dsa_switch_setup(struct dsa_switch *ds)
316 317 318
{
	int err;

319
	/* Initialize ds->phys_mii_mask before registering the slave MDIO bus
320
	 * driver and before ops->setup() has run, since the switch drivers and
321 322 323
	 * the slave MDIO bus driver rely on these values for probing PHY
	 * devices or not
	 */
324
	ds->phys_mii_mask |= dsa_user_ports(ds);
325

326 327 328 329 330 331 332 333 334 335 336
	/* Add the switch to devlink before calling setup, so that setup can
	 * add dpipe tables
	 */
	ds->devlink = devlink_alloc(&dsa_devlink_ops, 0);
	if (!ds->devlink)
		return -ENOMEM;

	err = devlink_register(ds->devlink, ds->dev);
	if (err)
		return err;

337
	err = ds->ops->setup(ds);
338 339 340
	if (err < 0)
		return err;

V
Vivien Didelot 已提交
341 342 343 344
	err = dsa_switch_register_notifier(ds);
	if (err)
		return err;

345
	if (!ds->slave_mii_bus && ds->ops->phy_read) {
346 347 348 349 350 351 352 353 354 355 356
		ds->slave_mii_bus = devm_mdiobus_alloc(ds->dev);
		if (!ds->slave_mii_bus)
			return -ENOMEM;

		dsa_slave_mii_bus_init(ds);

		err = mdiobus_register(ds->slave_mii_bus);
		if (err < 0)
			return err;
	}

357 358 359
	return 0;
}

360
static void dsa_switch_teardown(struct dsa_switch *ds)
361
{
362
	if (ds->slave_mii_bus && ds->ops->phy_read)
363
		mdiobus_unregister(ds->slave_mii_bus);
V
Vivien Didelot 已提交
364 365

	dsa_switch_unregister_notifier(ds);
366 367 368 369 370 371 372

	if (ds->devlink) {
		devlink_unregister(ds->devlink);
		devlink_free(ds->devlink);
		ds->devlink = NULL;
	}

373 374
}

375 376 377
static int dsa_tree_setup_switches(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
378 379
	struct dsa_port *dp;
	int device, port;
380 381 382 383 384 385 386 387 388 389
	int err;

	for (device = 0; device < DSA_MAX_SWITCHES; device++) {
		ds = dst->ds[device];
		if (!ds)
			continue;

		err = dsa_switch_setup(ds);
		if (err)
			return err;
390 391 392 393 394 395 396 397

		for (port = 0; port < ds->num_ports; port++) {
			dp = &ds->ports[port];

			err = dsa_port_setup(dp);
			if (err)
				return err;
		}
398 399 400 401 402 403 404 405
	}

	return 0;
}

static void dsa_tree_teardown_switches(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
406 407
	struct dsa_port *dp;
	int device, port;
408 409 410 411 412 413

	for (device = 0; device < DSA_MAX_SWITCHES; device++) {
		ds = dst->ds[device];
		if (!ds)
			continue;

414 415 416 417 418 419
		for (port = 0; port < ds->num_ports; port++) {
			dp = &ds->ports[port];

			dsa_port_teardown(dp);
		}

420 421 422 423
		dsa_switch_teardown(ds);
	}
}

424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440
static int dsa_tree_setup_master(struct dsa_switch_tree *dst)
{
	struct dsa_port *cpu_dp = dst->cpu_dp;
	struct net_device *master = cpu_dp->master;

	/* DSA currently supports a single pair of CPU port and master device */
	return dsa_master_setup(master, cpu_dp);
}

static void dsa_tree_teardown_master(struct dsa_switch_tree *dst)
{
	struct dsa_port *cpu_dp = dst->cpu_dp;
	struct net_device *master = cpu_dp->master;

	return dsa_master_teardown(master);
}

V
Vivien Didelot 已提交
441
static int dsa_tree_setup(struct dsa_switch_tree *dst)
442
{
V
Vivien Didelot 已提交
443
	bool complete;
444 445
	int err;

V
Vivien Didelot 已提交
446 447 448 449 450 451
	if (dst->setup) {
		pr_err("DSA: tree %d already setup! Disjoint trees?\n",
		       dst->index);
		return -EEXIST;
	}

V
Vivien Didelot 已提交
452 453 454 455
	complete = dsa_tree_setup_routing_table(dst);
	if (!complete)
		return 0;

456 457 458 459
	err = dsa_tree_setup_default_cpu(dst);
	if (err)
		return err;

460 461 462
	err = dsa_tree_setup_switches(dst);
	if (err)
		return err;
463

464
	err = dsa_tree_setup_master(dst);
465 466 467
	if (err)
		return err;

V
Vivien Didelot 已提交
468 469 470
	dst->setup = true;

	pr_info("DSA: tree %d setup\n", dst->index);
471 472 473 474

	return 0;
}

V
Vivien Didelot 已提交
475
static void dsa_tree_teardown(struct dsa_switch_tree *dst)
476
{
V
Vivien Didelot 已提交
477
	if (!dst->setup)
478 479
		return;

480
	dsa_tree_teardown_master(dst);
481

482
	dsa_tree_teardown_switches(dst);
483

484
	dsa_tree_teardown_default_cpu(dst);
485

V
Vivien Didelot 已提交
486 487 488
	pr_info("DSA: tree %d torn down\n", dst->index);

	dst->setup = false;
489 490
}

491 492 493
static void dsa_tree_remove_switch(struct dsa_switch_tree *dst,
				   unsigned int index)
{
494 495
	dsa_tree_teardown(dst);

496 497 498 499 500 501 502 503
	dst->ds[index] = NULL;
	dsa_tree_put(dst);
}

static int dsa_tree_add_switch(struct dsa_switch_tree *dst,
			       struct dsa_switch *ds)
{
	unsigned int index = ds->index;
504
	int err;
505 506 507 508 509 510 511

	if (dst->ds[index])
		return -EBUSY;

	dsa_tree_get(dst);
	dst->ds[index] = ds;

512 513 514 515 516
	err = dsa_tree_setup(dst);
	if (err)
		dsa_tree_remove_switch(dst, index);

	return err;
517 518
}

519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538
static int dsa_port_parse_user(struct dsa_port *dp, const char *name)
{
	if (!name)
		name = "eth%d";

	dp->type = DSA_PORT_TYPE_USER;
	dp->name = name;

	return 0;
}

static int dsa_port_parse_dsa(struct dsa_port *dp)
{
	dp->type = DSA_PORT_TYPE_DSA;

	return 0;
}

static int dsa_port_parse_cpu(struct dsa_port *dp, struct net_device *master)
{
539 540 541 542 543
	struct dsa_switch *ds = dp->ds;
	struct dsa_switch_tree *dst = ds->dst;
	const struct dsa_device_ops *tag_ops;
	enum dsa_tag_protocol tag_protocol;

544
	tag_protocol = ds->ops->get_tag_protocol(ds, dp->index);
545 546 547 548 549 550
	tag_ops = dsa_resolve_tag_protocol(tag_protocol);
	if (IS_ERR(tag_ops)) {
		dev_warn(ds->dev, "No tagger for this switch\n");
		return PTR_ERR(tag_ops);
	}

551
	dp->type = DSA_PORT_TYPE_CPU;
552 553
	dp->rcv = tag_ops->rcv;
	dp->tag_ops = tag_ops;
554
	dp->master = master;
555
	dp->dst = dst;
556 557 558 559

	return 0;
}

560 561
static int dsa_port_parse_of(struct dsa_port *dp, struct device_node *dn)
{
562
	struct device_node *ethernet = of_parse_phandle(dn, "ethernet", 0);
563
	const char *name = of_get_property(dn, "label", NULL);
564
	bool link = of_property_read_bool(dn, "link");
565

566 567
	dp->dn = dn;

568
	if (ethernet) {
569 570 571 572 573 574
		struct net_device *master;

		master = of_find_net_device_by_node(ethernet);
		if (!master)
			return -EPROBE_DEFER;

575
		return dsa_port_parse_cpu(dp, master);
576 577
	}

578 579
	if (link)
		return dsa_port_parse_dsa(dp);
580

581
	return dsa_port_parse_user(dp, name);
582 583
}

V
Vivien Didelot 已提交
584 585
static int dsa_switch_parse_ports_of(struct dsa_switch *ds,
				     struct device_node *dn)
586
{
587
	struct device_node *ports, *port;
588
	struct dsa_port *dp;
589
	u32 reg;
590 591 592 593 594 595 596
	int err;

	ports = of_get_child_by_name(dn, "ports");
	if (!ports) {
		dev_err(ds->dev, "no ports child node found\n");
		return -EINVAL;
	}
597 598 599 600 601 602

	for_each_available_child_of_node(ports, port) {
		err = of_property_read_u32(port, "reg", &reg);
		if (err)
			return err;

603
		if (reg >= ds->num_ports)
604 605
			return -EINVAL;

606 607 608 609 610
		dp = &ds->ports[reg];

		err = dsa_port_parse_of(dp, port);
		if (err)
			return err;
611 612 613 614 615
	}

	return 0;
}

V
Vivien Didelot 已提交
616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648
static int dsa_switch_parse_member_of(struct dsa_switch *ds,
				      struct device_node *dn)
{
	u32 m[2] = { 0, 0 };
	int sz;

	/* Don't error out if this optional property isn't found */
	sz = of_property_read_variable_u32_array(dn, "dsa,member", m, 2, 2);
	if (sz < 0 && sz != -EINVAL)
		return sz;

	ds->index = m[1];
	if (ds->index >= DSA_MAX_SWITCHES)
		return -EINVAL;

	ds->dst = dsa_tree_touch(m[0]);
	if (!ds->dst)
		return -ENOMEM;

	return 0;
}

static int dsa_switch_parse_of(struct dsa_switch *ds, struct device_node *dn)
{
	int err;

	err = dsa_switch_parse_member_of(ds, dn);
	if (err)
		return err;

	return dsa_switch_parse_ports_of(ds, dn);
}

649 650 651
static int dsa_port_parse(struct dsa_port *dp, const char *name,
			  struct device *dev)
{
652
	if (!strcmp(name, "cpu")) {
653 654 655 656 657 658 659 660
		struct net_device *master;

		master = dsa_dev_to_net_device(dev);
		if (!master)
			return -EPROBE_DEFER;

		dev_put(master);

661
		return dsa_port_parse_cpu(dp, master);
662 663
	}

664 665
	if (!strcmp(name, "dsa"))
		return dsa_port_parse_dsa(dp);
666

667
	return dsa_port_parse_user(dp, name);
668 669
}

V
Vivien Didelot 已提交
670 671
static int dsa_switch_parse_ports(struct dsa_switch *ds,
				  struct dsa_chip_data *cd)
672 673
{
	bool valid_name_found = false;
674 675 676
	struct dsa_port *dp;
	struct device *dev;
	const char *name;
677
	unsigned int i;
678
	int err;
679 680

	for (i = 0; i < DSA_MAX_PORTS; i++) {
681 682 683 684 685
		name = cd->port_names[i];
		dev = cd->netdev[i];
		dp = &ds->ports[i];

		if (!name)
686 687
			continue;

688 689 690 691
		err = dsa_port_parse(dp, name, dev);
		if (err)
			return err;

692 693 694 695 696 697 698 699 700
		valid_name_found = true;
	}

	if (!valid_name_found && i == DSA_MAX_PORTS)
		return -EINVAL;

	return 0;
}

V
Vivien Didelot 已提交
701
static int dsa_switch_parse(struct dsa_switch *ds, struct dsa_chip_data *cd)
702
{
V
Vivien Didelot 已提交
703
	ds->cd = cd;
704

V
Vivien Didelot 已提交
705 706 707 708 709 710 711
	/* We don't support interconnected switches nor multiple trees via
	 * platform data, so this is the unique switch of the tree.
	 */
	ds->index = 0;
	ds->dst = dsa_tree_touch(0);
	if (!ds->dst)
		return -ENOMEM;
712

V
Vivien Didelot 已提交
713
	return dsa_switch_parse_ports(ds, cd);
714 715
}

716 717 718 719 720 721 722
static int dsa_switch_add(struct dsa_switch *ds)
{
	struct dsa_switch_tree *dst = ds->dst;

	return dsa_tree_add_switch(dst, ds);
}

723
static int dsa_switch_probe(struct dsa_switch *ds)
724
{
725 726
	struct dsa_chip_data *pdata = ds->dev->platform_data;
	struct device_node *np = ds->dev->of_node;
V
Vivien Didelot 已提交
727
	int err;
728

V
Vivien Didelot 已提交
729 730 731 732 733 734
	if (np)
		err = dsa_switch_parse_of(ds, np);
	else if (pdata)
		err = dsa_switch_parse(ds, pdata);
	else
		err = -ENODEV;
735

V
Vivien Didelot 已提交
736 737
	if (err)
		return err;
738

739
	return dsa_switch_add(ds);
740 741
}

742 743 744 745
struct dsa_switch *dsa_switch_alloc(struct device *dev, size_t n)
{
	size_t size = sizeof(struct dsa_switch) + n * sizeof(struct dsa_port);
	struct dsa_switch *ds;
746
	int i;
747 748 749 750 751 752 753 754

	ds = devm_kzalloc(dev, size, GFP_KERNEL);
	if (!ds)
		return NULL;

	ds->dev = dev;
	ds->num_ports = n;

755 756 757 758 759
	for (i = 0; i < ds->num_ports; ++i) {
		ds->ports[i].index = i;
		ds->ports[i].ds = ds;
	}

760 761 762 763
	return ds;
}
EXPORT_SYMBOL_GPL(dsa_switch_alloc);

764
int dsa_register_switch(struct dsa_switch *ds)
765 766 767 768
{
	int err;

	mutex_lock(&dsa2_mutex);
769
	err = dsa_switch_probe(ds);
770
	dsa_tree_put(ds->dst);
771 772 773 774 775 776
	mutex_unlock(&dsa2_mutex);

	return err;
}
EXPORT_SYMBOL_GPL(dsa_register_switch);

777
static void dsa_switch_remove(struct dsa_switch *ds)
778 779
{
	struct dsa_switch_tree *dst = ds->dst;
780
	unsigned int index = ds->index;
781

782
	dsa_tree_remove_switch(dst, index);
783 784 785 786 787
}

void dsa_unregister_switch(struct dsa_switch *ds)
{
	mutex_lock(&dsa2_mutex);
788
	dsa_switch_remove(ds);
789 790 791
	mutex_unlock(&dsa2_mutex);
}
EXPORT_SYMBOL_GPL(dsa_unregister_switch);