dsa2.c 16.4 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15
/*
 * net/dsa/dsa2.c - Hardware switch handling, binding version 2
 * Copyright (c) 2008-2009 Marvell Semiconductor
 * Copyright (c) 2013 Florian Fainelli <florian@openwrt.org>
 * Copyright (c) 2016 Andrew Lunn <andrew@lunn.ch>
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 */

#include <linux/device.h>
#include <linux/err.h>
#include <linux/list.h>
16
#include <linux/netdevice.h>
17 18 19 20
#include <linux/slab.h>
#include <linux/rtnetlink.h>
#include <linux/of.h>
#include <linux/of_net.h>
21

22 23 24 25 26
#include "dsa_priv.h"

static LIST_HEAD(dsa_switch_trees);
static DEFINE_MUTEX(dsa2_mutex);

27 28 29
static const struct devlink_ops dsa_devlink_ops = {
};

30
static struct dsa_switch_tree *dsa_get_dst(unsigned int index)
31 32 33 34
{
	struct dsa_switch_tree *dst;

	list_for_each_entry(dst, &dsa_switch_trees, list)
35
		if (dst->index == index)
36
			return dst;
37

38 39 40 41 42 43 44 45 46 47 48 49
	return NULL;
}

static void dsa_free_dst(struct kref *ref)
{
	struct dsa_switch_tree *dst = container_of(ref, struct dsa_switch_tree,
						   refcount);

	list_del(&dst->list);
	kfree(dst);
}

50
static struct dsa_switch_tree *dsa_add_dst(unsigned int index)
51 52 53 54 55 56
{
	struct dsa_switch_tree *dst;

	dst = kzalloc(sizeof(*dst), GFP_KERNEL);
	if (!dst)
		return NULL;
57
	dst->index = index;
58 59
	INIT_LIST_HEAD(&dst->list);
	list_add_tail(&dsa_switch_trees, &dst->list);
60 61

	/* Initialize the reference counter to the number of switches, not 1 */
62
	kref_init(&dst->refcount);
63
	refcount_set(&dst->refcount.refcount, 0);
64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81

	return dst;
}

static void dsa_dst_add_ds(struct dsa_switch_tree *dst,
			   struct dsa_switch *ds, u32 index)
{
	kref_get(&dst->refcount);
	dst->ds[index] = ds;
}

static void dsa_dst_del_ds(struct dsa_switch_tree *dst,
			   struct dsa_switch *ds, u32 index)
{
	dst->ds[index] = NULL;
	kref_put(&dst->refcount, dsa_free_dst);
}

82 83 84
/* For platform data configurations, we need to have a valid name argument to
 * differentiate a disabled port from an enabled one
 */
85
static bool dsa_port_is_valid(struct dsa_port *port)
86
{
87
	return port->type != DSA_PORT_TYPE_UNUSED;
88 89
}

90
static bool dsa_port_is_dsa(struct dsa_port *port)
91
{
92
	return port->type == DSA_PORT_TYPE_DSA;
93 94 95 96
}

static bool dsa_port_is_cpu(struct dsa_port *port)
{
97
	return port->type == DSA_PORT_TYPE_CPU;
98 99
}

100 101
static bool dsa_ds_find_port_dn(struct dsa_switch *ds,
				struct device_node *port)
102 103 104
{
	u32 index;

105
	for (index = 0; index < ds->num_ports; index++)
106 107 108 109 110
		if (ds->ports[index].dn == port)
			return true;
	return false;
}

111 112
static struct dsa_switch *dsa_dst_find_port_dn(struct dsa_switch_tree *dst,
					       struct device_node *port)
113 114 115 116 117 118 119 120 121
{
	struct dsa_switch *ds;
	u32 index;

	for (index = 0; index < DSA_MAX_SWITCHES; index++) {
		ds = dst->ds[index];
		if (!ds)
			continue;

122
		if (dsa_ds_find_port_dn(ds, port))
123 124 125 126 127 128 129 130
			return ds;
	}

	return NULL;
}

static int dsa_port_complete(struct dsa_switch_tree *dst,
			     struct dsa_switch *src_ds,
131
			     struct dsa_port *port,
132 133 134 135 136 137 138
			     u32 src_port)
{
	struct device_node *link;
	int index;
	struct dsa_switch *dst_ds;

	for (index = 0;; index++) {
139
		link = of_parse_phandle(port->dn, "link", index);
140 141 142
		if (!link)
			break;

143
		dst_ds = dsa_dst_find_port_dn(dst, link);
144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161
		of_node_put(link);

		if (!dst_ds)
			return 1;

		src_ds->rtable[dst_ds->index] = src_port;
	}

	return 0;
}

/* A switch is complete if all the DSA ports phandles point to ports
 * known in the tree. A return value of 1 means the tree is not
 * complete. This is not an error condition. A value of 0 is
 * success.
 */
static int dsa_ds_complete(struct dsa_switch_tree *dst, struct dsa_switch *ds)
{
162
	struct dsa_port *port;
163 164 165
	u32 index;
	int err;

166
	for (index = 0; index < ds->num_ports; index++) {
167 168
		port = &ds->ports[index];
		if (!dsa_port_is_valid(port))
169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205
			continue;

		if (!dsa_port_is_dsa(port))
			continue;

		err = dsa_port_complete(dst, ds, port, index);
		if (err != 0)
			return err;
	}

	return 0;
}

/* A tree is complete if all the DSA ports phandles point to ports
 * known in the tree. A return value of 1 means the tree is not
 * complete. This is not an error condition. A value of 0 is
 * success.
 */
static int dsa_dst_complete(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
	u32 index;
	int err;

	for (index = 0; index < DSA_MAX_SWITCHES; index++) {
		ds = dst->ds[index];
		if (!ds)
			continue;

		err = dsa_ds_complete(dst, ds);
		if (err != 0)
			return err;
	}

	return 0;
}

206
static int dsa_dsa_port_apply(struct dsa_port *port)
207
{
208
	struct dsa_switch *ds = port->ds;
209 210
	int err;

211
	err = dsa_port_fixed_link_register_of(port);
212 213
	if (err) {
		dev_warn(ds->dev, "Failed to setup dsa port %d: %d\n",
214
			 port->index, err);
215 216 217
		return err;
	}

218
	memset(&port->devlink_port, 0, sizeof(port->devlink_port));
219

220 221
	return devlink_port_register(ds->devlink, &port->devlink_port,
				     port->index);
222 223
}

224
static void dsa_dsa_port_unapply(struct dsa_port *port)
225
{
226
	devlink_port_unregister(&port->devlink_port);
227
	dsa_port_fixed_link_unregister_of(port);
228 229
}

230
static int dsa_cpu_port_apply(struct dsa_port *port)
231
{
232
	struct dsa_switch *ds = port->ds;
233 234
	int err;

235
	err = dsa_port_fixed_link_register_of(port);
236 237
	if (err) {
		dev_warn(ds->dev, "Failed to setup cpu port %d: %d\n",
238
			 port->index, err);
239 240 241
		return err;
	}

242 243 244
	memset(&port->devlink_port, 0, sizeof(port->devlink_port));
	err = devlink_port_register(ds->devlink, &port->devlink_port,
				    port->index);
245
	return err;
246 247
}

248
static void dsa_cpu_port_unapply(struct dsa_port *port)
249
{
250
	devlink_port_unregister(&port->devlink_port);
251
	dsa_port_fixed_link_unregister_of(port);
252 253
}

254
static int dsa_user_port_apply(struct dsa_port *port)
255
{
256
	struct dsa_switch *ds = port->ds;
257 258
	int err;

259
	err = dsa_slave_create(port);
260 261
	if (err) {
		dev_warn(ds->dev, "Failed to create slave %d: %d\n",
262
			 port->index, err);
263
		port->slave = NULL;
264 265 266
		return err;
	}

267 268 269
	memset(&port->devlink_port, 0, sizeof(port->devlink_port));
	err = devlink_port_register(ds->devlink, &port->devlink_port,
				    port->index);
270 271 272
	if (err)
		return err;

273
	devlink_port_type_eth_set(&port->devlink_port, port->slave);
274

275 276 277
	return 0;
}

278
static void dsa_user_port_unapply(struct dsa_port *port)
279
{
280
	devlink_port_unregister(&port->devlink_port);
281 282 283
	if (port->slave) {
		dsa_slave_destroy(port->slave);
		port->slave = NULL;
284 285 286 287 288
	}
}

static int dsa_ds_apply(struct dsa_switch_tree *dst, struct dsa_switch *ds)
{
289
	struct dsa_port *port;
290 291 292
	u32 index;
	int err;

293
	/* Initialize ds->phys_mii_mask before registering the slave MDIO bus
294
	 * driver and before ops->setup() has run, since the switch drivers and
295 296 297
	 * the slave MDIO bus driver rely on these values for probing PHY
	 * devices or not
	 */
298
	ds->phys_mii_mask |= dsa_user_ports(ds);
299

300 301 302 303 304 305 306 307 308 309 310
	/* Add the switch to devlink before calling setup, so that setup can
	 * add dpipe tables
	 */
	ds->devlink = devlink_alloc(&dsa_devlink_ops, 0);
	if (!ds->devlink)
		return -ENOMEM;

	err = devlink_register(ds->devlink, ds->dev);
	if (err)
		return err;

311
	err = ds->ops->setup(ds);
312 313 314
	if (err < 0)
		return err;

V
Vivien Didelot 已提交
315 316 317 318
	err = dsa_switch_register_notifier(ds);
	if (err)
		return err;

319
	if (!ds->slave_mii_bus && ds->ops->phy_read) {
320 321 322 323 324 325 326 327 328 329 330
		ds->slave_mii_bus = devm_mdiobus_alloc(ds->dev);
		if (!ds->slave_mii_bus)
			return -ENOMEM;

		dsa_slave_mii_bus_init(ds);

		err = mdiobus_register(ds->slave_mii_bus);
		if (err < 0)
			return err;
	}

331
	for (index = 0; index < ds->num_ports; index++) {
332 333
		port = &ds->ports[index];
		if (!dsa_port_is_valid(port))
334 335 336
			continue;

		if (dsa_port_is_dsa(port)) {
337
			err = dsa_dsa_port_apply(port);
338 339 340 341 342 343
			if (err)
				return err;
			continue;
		}

		if (dsa_port_is_cpu(port)) {
344
			err = dsa_cpu_port_apply(port);
345 346 347 348 349
			if (err)
				return err;
			continue;
		}

350
		err = dsa_user_port_apply(port);
351 352 353 354 355 356 357 358 359
		if (err)
			continue;
	}

	return 0;
}

static void dsa_ds_unapply(struct dsa_switch_tree *dst, struct dsa_switch *ds)
{
360
	struct dsa_port *port;
361 362
	u32 index;

363
	for (index = 0; index < ds->num_ports; index++) {
364 365
		port = &ds->ports[index];
		if (!dsa_port_is_valid(port))
366 367 368
			continue;

		if (dsa_port_is_dsa(port)) {
369
			dsa_dsa_port_unapply(port);
370 371 372 373
			continue;
		}

		if (dsa_port_is_cpu(port)) {
374
			dsa_cpu_port_unapply(port);
375 376 377
			continue;
		}

378
		dsa_user_port_unapply(port);
379
	}
380

381
	if (ds->slave_mii_bus && ds->ops->phy_read)
382
		mdiobus_unregister(ds->slave_mii_bus);
V
Vivien Didelot 已提交
383 384

	dsa_switch_unregister_notifier(ds);
385 386 387 388 389 390 391

	if (ds->devlink) {
		devlink_unregister(ds->devlink);
		devlink_free(ds->devlink);
		ds->devlink = NULL;
	}

392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414
}

static int dsa_dst_apply(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
	u32 index;
	int err;

	for (index = 0; index < DSA_MAX_SWITCHES; index++) {
		ds = dst->ds[index];
		if (!ds)
			continue;

		err = dsa_ds_apply(dst, ds);
		if (err)
			return err;
	}

	/* If we use a tagging format that doesn't have an ethertype
	 * field, make sure that all packets from this point on get
	 * sent to the tag format's receive function.
	 */
	wmb();
415
	dst->cpu_dp->master->dsa_ptr = dst->cpu_dp;
416

417
	err = dsa_master_ethtool_setup(dst->cpu_dp->master);
418 419 420
	if (err)
		return err;

421 422 423 424 425 426 427 428 429 430 431 432 433
	dst->applied = true;

	return 0;
}

static void dsa_dst_unapply(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
	u32 index;

	if (!dst->applied)
		return;

434
	dsa_master_ethtool_restore(dst->cpu_dp->master);
435

436
	dst->cpu_dp->master->dsa_ptr = NULL;
437 438 439 440 441 442 443 444 445 446 447 448 449 450 451

	/* If we used a tagging format that doesn't have an ethertype
	 * field, make sure that all packets from this point get sent
	 * without the tag and go through the regular receive path.
	 */
	wmb();

	for (index = 0; index < DSA_MAX_SWITCHES; index++) {
		ds = dst->ds[index];
		if (!ds)
			continue;

		dsa_ds_unapply(dst, ds);
	}

452
	dst->cpu_dp = NULL;
453

454
	pr_info("DSA: tree %d unapplied\n", dst->index);
455 456 457
	dst->applied = false;
}

458
static int dsa_cpu_parse(struct dsa_port *port, u32 index,
459 460 461
			 struct dsa_switch_tree *dst,
			 struct dsa_switch *ds)
{
462
	const struct dsa_device_ops *tag_ops;
463
	enum dsa_tag_protocol tag_protocol;
464

465
	if (!dst->cpu_dp)
466
		dst->cpu_dp = port;
467

468
	tag_protocol = ds->ops->get_tag_protocol(ds);
469 470
	tag_ops = dsa_resolve_tag_protocol(tag_protocol);
	if (IS_ERR(tag_ops)) {
471
		dev_warn(ds->dev, "No tagger for this switch\n");
472
		return PTR_ERR(tag_ops);
473 474
	}

V
Vivien Didelot 已提交
475
	dst->cpu_dp->tag_ops = tag_ops;
476 477 478 479

	/* Make a few copies for faster access in master receive hot path */
	dst->cpu_dp->rcv = dst->cpu_dp->tag_ops->rcv;
	dst->cpu_dp->dst = dst;
480 481 482 483 484 485

	return 0;
}

static int dsa_ds_parse(struct dsa_switch_tree *dst, struct dsa_switch *ds)
{
486
	struct dsa_port *port;
487 488 489
	u32 index;
	int err;

490
	for (index = 0; index < ds->num_ports; index++) {
491
		port = &ds->ports[index];
492 493
		if (!dsa_port_is_valid(port) ||
		    dsa_port_is_dsa(port))
494 495 496 497 498 499 500
			continue;

		if (dsa_port_is_cpu(port)) {
			err = dsa_cpu_parse(port, index, dst, ds);
			if (err)
				return err;
		}
501

502 503
	}

504
	pr_info("DSA: switch %d %d parsed\n", dst->index, ds->index);
505 506 507 508 509 510 511

	return 0;
}

static int dsa_dst_parse(struct dsa_switch_tree *dst)
{
	struct dsa_switch *ds;
512
	struct dsa_port *dp;
513
	u32 index;
514
	int port;
515 516 517 518 519 520 521 522 523 524 525 526
	int err;

	for (index = 0; index < DSA_MAX_SWITCHES; index++) {
		ds = dst->ds[index];
		if (!ds)
			continue;

		err = dsa_ds_parse(dst, ds);
		if (err)
			return err;
	}

527
	if (!dst->cpu_dp) {
528 529 530 531
		pr_warn("Tree has no master device\n");
		return -EINVAL;
	}

532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548
	/* Assign the default CPU port to all ports of the fabric */
	for (index = 0; index < DSA_MAX_SWITCHES; index++) {
		ds = dst->ds[index];
		if (!ds)
			continue;

		for (port = 0; port < ds->num_ports; port++) {
			dp = &ds->ports[port];
			if (!dsa_port_is_valid(dp) ||
			    dsa_port_is_dsa(dp) ||
			    dsa_port_is_cpu(dp))
				continue;

			dp->cpu_dp = dst->cpu_dp;
		}
	}

549
	pr_info("DSA: tree %d parsed\n", dst->index);
550 551 552 553

	return 0;
}

554 555
static int dsa_port_parse_of(struct dsa_port *dp, struct device_node *dn)
{
556 557
	struct device_node *ethernet = of_parse_phandle(dn, "ethernet", 0);
	struct device_node *link = of_parse_phandle(dn, "link", 0);
558
	const char *name = of_get_property(dn, "label", NULL);
559 560

	if (ethernet) {
561 562 563 564 565 566
		struct net_device *master;

		master = of_find_net_device_by_node(ethernet);
		if (!master)
			return -EPROBE_DEFER;

567
		dp->type = DSA_PORT_TYPE_CPU;
568
		dp->master = master;
569 570 571
	} else if (link) {
		dp->type = DSA_PORT_TYPE_DSA;
	} else {
572 573 574
		if (!name)
			name = "eth%d";

575
		dp->type = DSA_PORT_TYPE_USER;
576
		dp->name = name;
577 578
	}

579 580 581 582 583
	dp->dn = dn;

	return 0;
}

584
static int dsa_parse_ports_of(struct device_node *dn, struct dsa_switch *ds)
585
{
586
	struct device_node *ports, *port;
587
	struct dsa_port *dp;
588
	u32 reg;
589 590 591 592 593 594 595
	int err;

	ports = of_get_child_by_name(dn, "ports");
	if (!ports) {
		dev_err(ds->dev, "no ports child node found\n");
		return -EINVAL;
	}
596 597 598 599 600 601

	for_each_available_child_of_node(ports, port) {
		err = of_property_read_u32(port, "reg", &reg);
		if (err)
			return err;

602
		if (reg >= ds->num_ports)
603 604
			return -EINVAL;

605 606 607 608 609
		dp = &ds->ports[reg];

		err = dsa_port_parse_of(dp, port);
		if (err)
			return err;
610 611 612 613 614
	}

	return 0;
}

615 616 617
static int dsa_port_parse(struct dsa_port *dp, const char *name,
			  struct device *dev)
{
618
	if (!strcmp(name, "cpu")) {
619 620 621 622 623 624 625 626
		struct net_device *master;

		master = dsa_dev_to_net_device(dev);
		if (!master)
			return -EPROBE_DEFER;

		dev_put(master);

627
		dp->type = DSA_PORT_TYPE_CPU;
628
		dp->master = master;
629 630 631 632 633 634
	} else if (!strcmp(name, "dsa")) {
		dp->type = DSA_PORT_TYPE_DSA;
	} else {
		dp->type = DSA_PORT_TYPE_USER;
	}

635 636 637 638 639
	dp->name = name;

	return 0;
}

640 641 642
static int dsa_parse_ports(struct dsa_chip_data *cd, struct dsa_switch *ds)
{
	bool valid_name_found = false;
643 644 645
	struct dsa_port *dp;
	struct device *dev;
	const char *name;
646
	unsigned int i;
647
	int err;
648 649

	for (i = 0; i < DSA_MAX_PORTS; i++) {
650 651 652 653 654
		name = cd->port_names[i];
		dev = cd->netdev[i];
		dp = &ds->ports[i];

		if (!name)
655 656
			continue;

657 658 659 660
		err = dsa_port_parse(dp, name, dev);
		if (err)
			return err;

661 662 663 664 665 666 667 668 669
		valid_name_found = true;
	}

	if (!valid_name_found && i == DSA_MAX_PORTS)
		return -EINVAL;

	return 0;
}

670
static int dsa_parse_member_dn(struct device_node *np, u32 *tree, u32 *index)
671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693
{
	int err;

	*tree = *index = 0;

	err = of_property_read_u32_index(np, "dsa,member", 0, tree);
	if (err) {
		/* Does not exist, but it is optional */
		if (err == -EINVAL)
			return 0;
		return err;
	}

	err = of_property_read_u32_index(np, "dsa,member", 1, index);
	if (err)
		return err;

	if (*index >= DSA_MAX_SWITCHES)
		return -EINVAL;

	return 0;
}

694 695 696 697 698 699 700 701 702 703 704 705
static int dsa_parse_member(struct dsa_chip_data *pd, u32 *tree, u32 *index)
{
	if (!pd)
		return -ENODEV;

	/* We do not support complex trees with dsa_chip_data */
	*tree = 0;
	*index = 0;

	return 0;
}

706
static int _dsa_register_switch(struct dsa_switch *ds)
707
{
708 709
	struct dsa_chip_data *pdata = ds->dev->platform_data;
	struct device_node *np = ds->dev->of_node;
710 711
	struct dsa_switch_tree *dst;
	u32 tree, index;
712
	int i, err;
713

714 715 716 717
	if (np) {
		err = dsa_parse_member_dn(np, &tree, &index);
		if (err)
			return err;
718

719
		err = dsa_parse_ports_of(np, ds);
720 721 722 723 724 725 726 727 728 729 730
		if (err)
			return err;
	} else {
		err = dsa_parse_member(pdata, &tree, &index);
		if (err)
			return err;

		err = dsa_parse_ports(pdata, ds);
		if (err)
			return err;
	}
731 732 733 734 735 736 737 738

	dst = dsa_get_dst(tree);
	if (!dst) {
		dst = dsa_add_dst(tree);
		if (!dst)
			return -ENOMEM;
	}

739 740
	if (dst->ds[index])
		return -EBUSY;
741 742 743

	ds->dst = dst;
	ds->index = index;
744
	ds->cd = pdata;
745 746 747 748 749

	/* Initialize the routing table */
	for (i = 0; i < DSA_MAX_SWITCHES; ++i)
		ds->rtable[i] = DSA_RTABLE_NONE;

750 751 752 753 754 755
	dsa_dst_add_ds(dst, ds, index);

	err = dsa_dst_complete(dst);
	if (err < 0)
		goto out_del_dst;

756 757 758
	/* Not all switches registered yet */
	if (err == 1)
		return 0;
759 760 761 762 763 764 765

	if (dst->applied) {
		pr_info("DSA: Disjoint trees?\n");
		return -EINVAL;
	}

	err = dsa_dst_parse(dst);
766
	if (err)
767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782
		goto out_del_dst;

	err = dsa_dst_apply(dst);
	if (err) {
		dsa_dst_unapply(dst);
		goto out_del_dst;
	}

	return 0;

out_del_dst:
	dsa_dst_del_ds(dst, ds, ds->index);

	return err;
}

783 784 785 786
struct dsa_switch *dsa_switch_alloc(struct device *dev, size_t n)
{
	size_t size = sizeof(struct dsa_switch) + n * sizeof(struct dsa_port);
	struct dsa_switch *ds;
787
	int i;
788 789 790 791 792 793 794 795

	ds = devm_kzalloc(dev, size, GFP_KERNEL);
	if (!ds)
		return NULL;

	ds->dev = dev;
	ds->num_ports = n;

796 797 798 799 800
	for (i = 0; i < ds->num_ports; ++i) {
		ds->ports[i].index = i;
		ds->ports[i].ds = ds;
	}

801 802 803 804
	return ds;
}
EXPORT_SYMBOL_GPL(dsa_switch_alloc);

805
int dsa_register_switch(struct dsa_switch *ds)
806 807 808 809
{
	int err;

	mutex_lock(&dsa2_mutex);
810
	err = _dsa_register_switch(ds);
811 812 813 814 815 816
	mutex_unlock(&dsa2_mutex);

	return err;
}
EXPORT_SYMBOL_GPL(dsa_register_switch);

817
static void _dsa_unregister_switch(struct dsa_switch *ds)
818 819 820 821 822 823 824 825 826 827 828 829 830 831 832
{
	struct dsa_switch_tree *dst = ds->dst;

	dsa_dst_unapply(dst);

	dsa_dst_del_ds(dst, ds, ds->index);
}

void dsa_unregister_switch(struct dsa_switch *ds)
{
	mutex_lock(&dsa2_mutex);
	_dsa_unregister_switch(ds);
	mutex_unlock(&dsa2_mutex);
}
EXPORT_SYMBOL_GPL(dsa_unregister_switch);