repository_spec.rb 77.9 KB
Newer Older
1 2
require 'spec_helper'

3
describe Repository do
4
  include RepoHelpers
D
Douwe Maan 已提交
5
  TestBlob = Struct.new(:path)
6

7
  let(:project) { create(:project, :repository) }
8
  let(:repository) { project.repository }
9
  let(:broken_repository) { create(:project, :broken_storage).repository }
10
  let(:user) { create(:user) }
11
  let(:git_user) { Gitlab::Git::User.from_gitlab(user) }
12

13
  let(:message) { 'Test message' }
14

R
Rubén Dávila 已提交
15
  let(:merge_commit) do
16
    merge_request = create(:merge_request, source_branch: 'feature', target_branch: 'master', source_project: project)
S
Sean McGivern 已提交
17 18 19 20

    merge_commit_id = repository.merge(user,
                                       merge_request.diff_head_sha,
                                       merge_request,
21
                                       message)
S
Sean McGivern 已提交
22

23
    repository.commit(merge_commit_id)
24
  end
25

26 27
  let(:author_email) { 'user@example.org' }
  let(:author_name) { 'John Doe' }
28

29 30
  def expect_to_raise_storage_error
    expect { yield }.to raise_error do |exception|
31
      storage_exceptions = [Gitlab::Git::Storage::Inaccessible, Gitlab::Git::CommandError, GRPC::Unavailable]
32 33 34
      known_exception = storage_exceptions.select { |e| exception.is_a?(e) }

      expect(known_exception).not_to be_nil
35 36 37
    end
  end

38
  describe '#branch_names_contains' do
39 40 41
    shared_examples '#branch_names_contains' do
      set(:project) { create(:project, :repository) }
      let(:repository) { project.repository }
42

43
      subject { repository.branch_names_contains(sample_commit.id) }
44

45 46 47 48
      it { is_expected.to include('master') }
      it { is_expected.not_to include('feature') }
      it { is_expected.not_to include('fix') }

49
      describe 'when storage is broken', :broken_storage do
50 51 52 53
        it 'should raise a storage error' do
          expect_to_raise_storage_error do
            broken_repository.branch_names_contains(sample_commit.id)
          end
54 55 56
        end
      end
    end
57 58 59 60 61 62 63 64

    context 'when gitaly is enabled' do
      it_behaves_like '#branch_names_contains'
    end

    context 'when gitaly is disabled', :skip_gitaly_mock do
      it_behaves_like '#branch_names_contains'
    end
65
  end
66

67
  describe '#tag_names_contains' do
68 69
    shared_examples '#tag_names_contains' do
      subject { repository.tag_names_contains(sample_commit.id) }
70

71 72 73 74 75 76 77 78 79 80 81
      it { is_expected.to include('v1.1.0') }
      it { is_expected.not_to include('v1.0.0') }
    end

    context 'when gitaly is enabled' do
      it_behaves_like '#tag_names_contains'
    end

    context 'when gitaly is enabled', :skip_gitaly_mock do
      it_behaves_like '#tag_names_contains'
    end
82 83
  end

84
  describe 'tags_sorted_by' do
H
haseeb 已提交
85 86
    context 'name_desc' do
      subject { repository.tags_sorted_by('name_desc').map(&:name) }
87 88 89 90

      it { is_expected.to eq(['v1.1.0', 'v1.0.0']) }
    end

H
haseeb 已提交
91 92 93 94 95 96
    context 'name_asc' do
      subject { repository.tags_sorted_by('name_asc').map(&:name) }

      it { is_expected.to eq(['v1.0.0', 'v1.1.0']) }
    end

97 98 99 100 101 102 103 104 105 106 107
    context 'updated' do
      let(:tag_a) { repository.find_tag('v1.0.0') }
      let(:tag_b) { repository.find_tag('v1.1.0') }

      context 'desc' do
        subject { repository.tags_sorted_by('updated_desc').map(&:name) }

        before do
          double_first = double(committed_date: Time.now)
          double_last = double(committed_date: Time.now - 1.second)

108 109
          allow(tag_a).to receive(:dereferenced_target).and_return(double_first)
          allow(tag_b).to receive(:dereferenced_target).and_return(double_last)
110
          allow(repository).to receive(:tags).and_return([tag_a, tag_b])
111 112 113 114 115 116 117 118 119 120 121 122
        end

        it { is_expected.to eq(['v1.0.0', 'v1.1.0']) }
      end

      context 'asc' do
        subject { repository.tags_sorted_by('updated_asc').map(&:name) }

        before do
          double_first = double(committed_date: Time.now - 1.second)
          double_last = double(committed_date: Time.now)

123 124
          allow(tag_a).to receive(:dereferenced_target).and_return(double_last)
          allow(tag_b).to receive(:dereferenced_target).and_return(double_first)
125
          allow(repository).to receive(:tags).and_return([tag_a, tag_b])
126 127 128 129
        end

        it { is_expected.to eq(['v1.1.0', 'v1.0.0']) }
      end
130 131 132 133 134 135 136 137 138

      context 'annotated tag pointing to a blob' do
        let(:annotated_tag_name) { 'annotated-tag' }

        subject { repository.tags_sorted_by('updated_asc').map(&:name) }

        before do
          options = { message: 'test tag message\n',
                      tagger: { name: 'John Smith', email: 'john@gmail.com' } }
139 140 141 142

          Gitlab::GitalyClient::StorageSettings.allow_disk_access do
            repository.rugged.tags.create(annotated_tag_name, 'a48e4fc218069f68ef2e769dd8dfea3991362175', options)
          end
143 144 145 146 147 148 149 150 151 152 153 154 155 156

          double_first = double(committed_date: Time.now - 1.second)
          double_last = double(committed_date: Time.now)

          allow(tag_a).to receive(:dereferenced_target).and_return(double_last)
          allow(tag_b).to receive(:dereferenced_target).and_return(double_first)
        end

        it { is_expected.to eq(['v1.1.0', 'v1.0.0', annotated_tag_name]) }

        after do
          repository.rugged.tags.delete(annotated_tag_name)
        end
      end
157 158 159
    end
  end

160
  describe '#ref_name_for_sha' do
161
    it 'returns the ref' do
162 163
      allow(repository.raw_repository).to receive(:ref_name_for_sha)
        .and_return('refs/environments/production/77')
164

165
      expect(repository.ref_name_for_sha('bla', '0' * 40)).to eq 'refs/environments/production/77'
166 167 168
    end
  end

169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188
  describe '#ref_exists?' do
    context 'when ref exists' do
      it 'returns true' do
        expect(repository.ref_exists?('refs/heads/master')).to be true
      end
    end

    context 'when ref does not exist' do
      it 'returns false' do
        expect(repository.ref_exists?('refs/heads/non-existent')).to be false
      end
    end

    context 'when ref format is incorrect' do
      it 'returns false' do
        expect(repository.ref_exists?('refs/heads/invalid:master')).to be false
      end
    end
  end

189
  describe '#last_commit_for_path' do
190 191
    shared_examples 'getting last commit for path' do
      subject { repository.last_commit_for_path(sample_commit.id, '.gitignore').id }
192

193
      it { is_expected.to eq('c1acaa58bbcbc3eafe538cb8274ba387047b69f8') }
194

195
      describe 'when storage is broken', :broken_storage do
196 197 198 199 200 201
        it 'should raise a storage error' do
          expect_to_raise_storage_error do
            broken_repository.last_commit_id_for_path(sample_commit.id, '.gitignore')
          end
        end
      end
202 203 204 205 206
    end

    context 'when Gitaly feature last_commit_for_path is enabled' do
      it_behaves_like 'getting last commit for path'
    end
207

208
    context 'when Gitaly feature last_commit_for_path is disabled', :skip_gitaly_mock do
209 210
      it_behaves_like 'getting last commit for path'
    end
211
  end
212

H
Hiroyuki Sato 已提交
213
  describe '#last_commit_id_for_path' do
214 215
    shared_examples 'getting last commit ID for path' do
      subject { repository.last_commit_id_for_path(sample_commit.id, '.gitignore') }
H
Hiroyuki Sato 已提交
216

217 218 219 220 221 222 223 224 225 226 227
      it "returns last commit id for a given path" do
        is_expected.to eq('c1acaa58bbcbc3eafe538cb8274ba387047b69f8')
      end

      it "caches last commit id for a given path" do
        cache = repository.send(:cache)
        key = "last_commit_id_for_path:#{sample_commit.id}:#{Digest::SHA1.hexdigest('.gitignore')}"

        expect(cache).to receive(:fetch).with(key).and_return('c1acaa5')
        is_expected.to eq('c1acaa5')
      end
228

229
      describe 'when storage is broken', :broken_storage do
230 231 232 233 234 235
        it 'should raise a storage error' do
          expect_to_raise_storage_error do
            broken_repository.last_commit_for_path(sample_commit.id, '.gitignore').id
          end
        end
      end
H
Hiroyuki Sato 已提交
236
    end
H
Hiroyuki Sato 已提交
237

238 239 240
    context 'when Gitaly feature last_commit_for_path is enabled' do
      it_behaves_like 'getting last commit ID for path'
    end
241

242
    context 'when Gitaly feature last_commit_for_path is disabled', :skip_gitaly_mock do
243
      it_behaves_like 'getting last commit ID for path'
H
Hiroyuki Sato 已提交
244 245 246
    end
  end

247
  describe '#commits' do
T
Tiago Botelho 已提交
248 249 250 251
    context 'when neither the all flag nor a ref are specified' do
      it 'returns every commit from default branch' do
        expect(repository.commits(limit: 60).size).to eq(37)
      end
252 253
    end

T
Tiago Botelho 已提交
254 255 256 257
    context 'when ref is passed' do
      it 'returns every commit from the specified ref' do
        expect(repository.commits('master', limit: 60).size).to eq(37)
      end
258

T
Tiago Botelho 已提交
259 260 261 262 263 264 265 266 267 268 269 270 271
      context 'when all' do
        it 'returns every commit from the repository' do
          expect(repository.commits('master', limit: 60, all: true).size).to eq(60)
        end
      end

      context 'with path' do
        it 'sets follow when it is a single path' do
          expect(Gitlab::Git::Commit).to receive(:where).with(a_hash_including(follow: true)).and_call_original.twice

          repository.commits('master', limit: 1, path: 'README.md')
          repository.commits('master', limit: 1, path: ['README.md'])
        end
272

T
Tiago Botelho 已提交
273 274
        it 'does not set follow when it is multiple paths' do
          expect(Gitlab::Git::Commit).to receive(:where).with(a_hash_including(follow: false)).and_call_original
275

T
Tiago Botelho 已提交
276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292
          repository.commits('master', limit: 1, path: ['README.md', 'CHANGELOG'])
        end
      end

      context 'without path' do
        it 'does not set follow' do
          expect(Gitlab::Git::Commit).to receive(:where).with(a_hash_including(follow: false)).and_call_original

          repository.commits('master', limit: 1)
        end
      end
    end

    context "when 'all' flag is set" do
      it 'returns every commit from the repository' do
        expect(repository.commits(all: true, limit: 60).size).to eq(60)
      end
293 294 295
    end
  end

296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317
  describe '#new_commits' do
    let(:new_refs) do
      double(:git_rev_list, new_refs: %w[
        c1acaa58bbcbc3eafe538cb8274ba387047b69f8
        5937ac0a7beb003549fc5fd26fc247adbce4a52e
      ])
    end

    it 'delegates to Gitlab::Git::RevList' do
      expect(Gitlab::Git::RevList).to receive(:new).with(
        repository.raw,
        newrev: 'aaaabbbbccccddddeeeeffffgggghhhhiiiijjjj').and_return(new_refs)

      commits = repository.new_commits('aaaabbbbccccddddeeeeffffgggghhhhiiiijjjj')

      expect(commits).to eq([
        repository.commit('c1acaa58bbcbc3eafe538cb8274ba387047b69f8'),
        repository.commit('5937ac0a7beb003549fc5fd26fc247adbce4a52e')
      ])
    end
  end

318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365
  describe '#commits_by' do
    set(:project) { create(:project, :repository) }

    shared_examples 'batch commits fetching' do
      let(:oids) { TestEnv::BRANCH_SHA.values }

      subject { project.repository.commits_by(oids: oids) }

      it 'finds each commit' do
        expect(subject).not_to include(nil)
        expect(subject.size).to eq(oids.size)
      end

      it 'returns only Commit instances' do
        expect(subject).to all( be_a(Commit) )
      end

      context 'when some commits are not found ' do
        let(:oids) do
          ['deadbeef'] + TestEnv::BRANCH_SHA.values.first(10)
        end

        it 'returns only found commits' do
          expect(subject).not_to include(nil)
          expect(subject.size).to eq(10)
        end
      end

      context 'when no oids are passed' do
        let(:oids) { [] }

        it 'does not call #batch_by_oid' do
          expect(Gitlab::Git::Commit).not_to receive(:batch_by_oid)

          subject
        end
      end
    end

    context 'when Gitaly list_commits_by_oid is enabled' do
      it_behaves_like 'batch commits fetching'
    end

    context 'when Gitaly list_commits_by_oid is enabled', :disable_gitaly do
      it_behaves_like 'batch commits fetching'
    end
  end

366
  describe '#find_commits_by_message' do
367 368 369 370 371 372 373 374 375 376 377 378 379 380
    shared_examples 'finding commits by message' do
      it 'returns commits with messages containing a given string' do
        commit_ids = repository.find_commits_by_message('submodule').map(&:id)

        expect(commit_ids).to include(
          '5937ac0a7beb003549fc5fd26fc247adbce4a52e',
          '6f6d7e7ed97bb5f0054f2b1df789b39ca89b6ff9',
          'cfe32cf61b73a0d5e9f13e774abde7ff789b1660'
        )
        expect(commit_ids).not_to include('913c66a37b4a45b9769037c55c2d238bd0942d2e')
      end

      it 'is case insensitive' do
        commit_ids = repository.find_commits_by_message('SUBMODULE').map(&:id)
381

382 383
        expect(commit_ids).to include('5937ac0a7beb003549fc5fd26fc247adbce4a52e')
      end
384 385
    end

386 387 388
    context 'when Gitaly commits_by_message feature is enabled' do
      it_behaves_like 'finding commits by message'
    end
389

390
    context 'when Gitaly commits_by_message feature is disabled', :skip_gitaly_mock do
391
      it_behaves_like 'finding commits by message'
392
    end
393

394
    describe 'when storage is broken', :broken_storage do
395 396 397 398
      it 'should raise a storage error' do
        expect_to_raise_storage_error { broken_repository.find_commits_by_message('s') }
      end
    end
399 400
  end

401
  describe '#blob_at' do
402 403 404 405 406 407
    context 'blank sha' do
      subject { repository.blob_at(Gitlab::Git::BLANK_SHA, '.gitignore') }

      it { is_expected.to be_nil }
    end
  end
408

409
  describe '#merged_to_root_ref?' do
410
    context 'merged branch without ff' do
411
      subject { repository.merged_to_root_ref?('branch-merged') }
F
Florent (HP) 已提交
412 413 414

      it { is_expected.to be_truthy }
    end
415

416 417
    # If the HEAD was ff then it will be false
    context 'merged with ff' do
F
Florent (HP) 已提交
418 419 420 421
      subject { repository.merged_to_root_ref?('improve/awesome') }

      it { is_expected.to be_truthy }
    end
422

423 424 425 426 427
    context 'not merged branch' do
      subject { repository.merged_to_root_ref?('not-merged-branch') }

      it { is_expected.to be_falsey }
    end
428 429 430 431 432 433

    context 'default branch' do
      subject { repository.merged_to_root_ref?('master') }

      it { is_expected.to be_falsey }
    end
434 435
  end

436
  describe '#can_be_merged?' do
437 438
    context 'mergeable branches' do
      subject { repository.can_be_merged?('0b4bc9a49b562e85de7cc9e834518ea6828729b9', 'master') }
439

440 441
      it { is_expected.to be_truthy }
    end
F
Florent (HP) 已提交
442

443 444
    context 'non-mergeable branches without conflict sides missing' do
      subject { repository.can_be_merged?('bb5206fee213d983da88c47f9cf4cc6caf9c66dc', 'feature') }
445

446 447
      it { is_expected.to be_falsey }
    end
448

449 450
    context 'non-mergeable branches with conflict sides missing' do
      subject { repository.can_be_merged?('conflict-missing-side', 'conflict-start') }
F
Florent (HP) 已提交
451

452 453
      it { is_expected.to be_falsey }
    end
454

455 456
    context 'non merged branch' do
      subject { repository.merged_to_root_ref?('fix') }
457

458
      it { is_expected.to be_falsey }
F
Florent (HP) 已提交
459 460
    end

461 462
    context 'non existent branch' do
      subject { repository.merged_to_root_ref?('non_existent_branch') }
F
Florent (HP) 已提交
463

464
      it { is_expected.to be_nil }
F
Florent (HP) 已提交
465
    end
466 467
  end

468 469 470
  describe '#commit' do
    context 'when ref exists' do
      it 'returns commit object' do
D
Douwe Maan 已提交
471 472
        expect(repository.commit('master'))
          .to be_an_instance_of Commit
473 474 475 476 477 478 479 480 481
      end
    end

    context 'when ref does not exist' do
      it 'returns nil' do
        expect(repository.commit('non-existent-ref')).to be_nil
      end
    end

482 483 484 485 486 487 488 489
    context 'when ref is not specified' do
      it 'is using a root ref' do
        expect(repository).to receive(:find_commit).with('master')

        repository.commit
      end
    end

490 491 492 493 494 495 496 497 498 499 500 501 502 503 504
    context 'when ref is not valid' do
      context 'when preceding tree element exists' do
        it 'returns nil' do
          expect(repository.commit('master:ref')).to be_nil
        end
      end

      context 'when preceding tree element does not exist' do
        it 'returns nil' do
          expect(repository.commit('non-existent:ref')).to be_nil
        end
      end
    end
  end

D
Douwe Maan 已提交
505
  describe "#create_dir" do
506 507
    it "commits a change that creates a new directory" do
      expect do
508
        repository.create_dir(user, 'newdir',
509
          message: 'Create newdir', branch_name: 'master')
510
      end.to change { repository.count_commits(ref: 'master') }.by(1)
511 512 513 514 515

      newdir = repository.tree('master', 'newdir')
      expect(newdir.path).to eq('newdir')
    end

516
    context "when committing to another project" do
517
      let(:forked_project) { create(:project, :repository) }
518 519 520

      it "creates a fork and commit to the forked project" do
        expect do
521
          repository.create_dir(user, 'newdir',
522
            message: 'Create newdir', branch_name: 'patch',
L
Lin Jen-Shin 已提交
523
            start_branch_name: 'master', start_project: forked_project)
524
        end.to change { repository.count_commits(ref: 'master') }.by(0)
525 526 527 528 529 530 531 532 533

        expect(repository.branch_exists?('patch')).to be_truthy
        expect(forked_project.repository.branch_exists?('patch')).to be_falsy

        newdir = repository.tree('patch', 'newdir')
        expect(newdir.path).to eq('newdir')
      end
    end

534 535 536
    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
        expect do
537
          repository.create_dir(user, 'newdir',
538 539 540
            message: 'Add newdir',
            branch_name: 'master',
            author_email: author_email, author_name: author_name)
541
        end.to change { repository.count_commits(ref: 'master') }.by(1)
542 543 544 545 546 547 548 549 550

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
  end

551 552
  describe "#create_file" do
    it 'commits new file successfully' do
553
      expect do
554 555 556
        repository.create_file(user, 'NEWCHANGELOG', 'Changelog!',
                               message: 'Create changelog',
                               branch_name: 'master')
557
      end.to change { repository.count_commits(ref: 'master') }.by(1)
558

559
      blob = repository.blob_at('master', 'NEWCHANGELOG')
560

561
      expect(blob.data).to eq('Changelog!')
562
    end
563

564
    it 'creates new file and dir when file_path has a forward slash' do
565
      expect do
566 567
        repository.create_file(user, 'new_dir/new_file.txt', 'File!',
                               message: 'Create new_file with new_dir',
568
                               branch_name: 'master')
569
      end.to change { repository.count_commits(ref: 'master') }.by(1)
570

571 572
      expect(repository.tree('master', 'new_dir').path).to eq('new_dir')
      expect(repository.blob_at('master', 'new_dir/new_file.txt').data).to eq('File!')
573 574
    end

575
    it 'respects the autocrlf setting' do
576
      repository.create_file(user, 'hello.txt', "Hello,\r\nWorld",
577
                             message: 'Add hello world',
578
                             branch_name: 'master')
579 580 581 582 583 584

      blob = repository.blob_at('master', 'hello.txt')

      expect(blob.data).to eq("Hello,\nWorld")
    end

585 586 587
    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
        expect do
588
          repository.create_file(user, 'NEWREADME', 'README!',
589 590 591 592
                                 message: 'Add README',
                                 branch_name: 'master',
                                 author_email: author_email,
                                 author_name: author_name)
593
        end.to change { repository.count_commits(ref: 'master') }.by(1)
594 595 596 597 598 599 600

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
601 602
  end

603
  describe "#update_file" do
604 605 606 607 608
    it 'updates file successfully' do
      expect do
        repository.update_file(user, 'CHANGELOG', 'Changelog!',
                               message: 'Update changelog',
                               branch_name: 'master')
609
      end.to change { repository.count_commits(ref: 'master') }.by(1)
610 611 612 613 614 615

      blob = repository.blob_at('master', 'CHANGELOG')

      expect(blob.data).to eq('Changelog!')
    end

T
tiagonbotelho 已提交
616
    it 'updates filename successfully' do
617 618
      expect do
        repository.update_file(user, 'NEWLICENSE', 'Copyright!',
619
                                     branch_name: 'master',
T
tiagonbotelho 已提交
620
                                     previous_path: 'LICENSE',
621
                                     message: 'Changes filename')
622
      end.to change { repository.count_commits(ref: 'master') }.by(1)
T
tiagonbotelho 已提交
623 624 625 626 627 628

      files = repository.ls_files('master')

      expect(files).not_to include('LICENSE')
      expect(files).to include('NEWLICENSE')
    end
629 630 631 632

    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
        expect do
633 634 635 636 637 638
          repository.update_file(user, 'README', 'Updated README!',
                                 branch_name: 'master',
                                 previous_path: 'README',
                                 message: 'Update README',
                                 author_email: author_email,
                                 author_name: author_name)
639
        end.to change { repository.count_commits(ref: 'master') }.by(1)
640 641 642 643 644 645 646 647 648

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
  end

D
Douwe Maan 已提交
649
  describe "#delete_file" do
650 651
    it 'removes file successfully' do
      expect do
652
        repository.delete_file(user, 'README',
653
          message: 'Remove README', branch_name: 'master')
654
      end.to change { repository.count_commits(ref: 'master') }.by(1)
655 656 657 658 659 660 661

      expect(repository.blob_at('master', 'README')).to be_nil
    end

    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
        expect do
662
          repository.delete_file(user, 'README',
663 664
            message: 'Remove README', branch_name: 'master',
            author_email: author_email, author_name: author_name)
665
        end.to change { repository.count_commits(ref: 'master') }.by(1)
666 667 668 669 670 671 672 673 674

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
  end

675
  describe "search_files_by_content" do
V
Valery Sizov 已提交
676
    let(:results) { repository.search_files_by_content('feature', 'master') }
677 678 679 680
    subject { results }

    it { is_expected.to be_an Array }

681
    it 'regex-escapes the query string' do
V
Valery Sizov 已提交
682
      results = repository.search_files_by_content("test\\", 'master')
683 684 685 686

      expect(results.first).not_to start_with('fatal:')
    end

687
    it 'properly handles an unmatched parenthesis' do
V
Valery Sizov 已提交
688
      results = repository.search_files_by_content("test(", 'master')
689 690 691 692

      expect(results.first).not_to start_with('fatal:')
    end

V
Valery Sizov 已提交
693
    it 'properly handles when query is not present' do
V
Valery Sizov 已提交
694
      results = repository.search_files_by_content('', 'master')
V
Valery Sizov 已提交
695 696 697 698 699

      expect(results).to match_array([])
    end

    it 'properly handles query when repo is empty' do
700
      repository = create(:project, :empty_repo).repository
V
Valery Sizov 已提交
701
      results = repository.search_files_by_content('test', 'master')
V
Valery Sizov 已提交
702 703 704 705

      expect(results).to match_array([])
    end

706
    describe 'when storage is broken', :broken_storage do
707 708 709 710 711 712 713
      it 'should raise a storage error' do
        expect_to_raise_storage_error do
          broken_repository.search_files_by_content('feature', 'master')
        end
      end
    end

714 715 716 717
    describe 'result' do
      subject { results.first }

      it { is_expected.to be_an String }
718
      it { expect(subject.lines[2]).to eq("master:CHANGELOG\x00190\x00  - Feature: Replace teams with group membership\n") }
719 720
    end
  end
Z
Zeger-Jan van de Weg 已提交
721

722
  describe "search_files_by_name" do
V
Valery Sizov 已提交
723 724 725 726 727 728
    let(:results) { repository.search_files_by_name('files', 'master') }

    it 'returns result' do
      expect(results.first).to eq('files/html/500.html')
    end

A
Andrew McCallum 已提交
729 730
    it 'ignores leading slashes' do
      results = repository.search_files_by_name('/files', 'master')
731

732 733 734
      expect(results.first).to eq('files/html/500.html')
    end

735
    it 'properly handles when query is only slashes' do
736
      results = repository.search_files_by_name('//', 'master')
737

738
      expect(results).to match_array([])
739 740
    end

V
Valery Sizov 已提交
741 742 743 744 745 746 747
    it 'properly handles when query is not present' do
      results = repository.search_files_by_name('', 'master')

      expect(results).to match_array([])
    end

    it 'properly handles query when repo is empty' do
748
      repository = create(:project, :empty_repo).repository
V
Valery Sizov 已提交
749 750 751 752 753

      results = repository.search_files_by_name('test', 'master')

      expect(results).to match_array([])
    end
754

755
    describe 'when storage is broken', :broken_storage do
756 757 758 759 760 761
      it 'should raise a storage error' do
        expect_to_raise_storage_error { broken_repository.search_files_by_name('files', 'master') }
      end
    end
  end

762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793
  describe '#async_remove_remote' do
    before do
      masterrev = repository.find_branch('master').dereferenced_target
      create_remote_branch('joe', 'remote_branch', masterrev)
    end

    context 'when worker is scheduled successfully' do
      before do
        masterrev = repository.find_branch('master').dereferenced_target
        create_remote_branch('remote_name', 'remote_branch', masterrev)

        allow(RepositoryRemoveRemoteWorker).to receive(:perform_async).and_return('1234')
      end

      it 'returns job_id' do
        expect(repository.async_remove_remote('joe')).to eq('1234')
      end
    end

    context 'when worker does not schedule successfully' do
      before do
        allow(RepositoryRemoveRemoteWorker).to receive(:perform_async).and_return(nil)
      end

      it 'returns nil' do
        expect(Rails.logger).to receive(:info).with("Remove remote job failed to create for #{project.id} with remote name joe.")

        expect(repository.async_remove_remote('joe')).to be_nil
      end
    end
  end

794
  describe '#fetch_ref' do
795
    let(:broken_repository) { create(:project, :broken_storage).repository }
796

797
    describe 'when storage is broken', :broken_storage do
798
      it 'should raise a storage error' do
799 800 801
        expect_to_raise_storage_error do
          broken_repository.fetch_ref(broken_repository, source_ref: '1', target_ref: '2')
        end
802 803
      end
    end
V
Valery Sizov 已提交
804 805
  end

806
  describe '#create_ref' do
807
    it 'redirects the call to write_ref' do
808 809
      ref, ref_path = '1', '2'

810
      expect(repository.raw_repository).to receive(:write_ref).with(ref_path, ref)
811 812 813 814 815

      repository.create_ref(ref, ref_path)
    end
  end

816
  describe "#changelog", :use_clean_rails_memory_store_caching do
817 818 819
    it 'accepts changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('changelog')])

D
Douwe Maan 已提交
820
      expect(repository.changelog.path).to eq('changelog')
821 822 823 824 825
    end

    it 'accepts news instead of changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('news')])

D
Douwe Maan 已提交
826
      expect(repository.changelog.path).to eq('news')
827 828 829 830 831
    end

    it 'accepts history instead of changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('history')])

D
Douwe Maan 已提交
832
      expect(repository.changelog.path).to eq('history')
833 834 835 836 837
    end

    it 'accepts changes instead of changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('changes')])

D
Douwe Maan 已提交
838
      expect(repository.changelog.path).to eq('changes')
839 840 841 842 843
    end

    it 'is case-insensitive' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('CHANGELOG')])

D
Douwe Maan 已提交
844
      expect(repository.changelog.path).to eq('CHANGELOG')
845 846 847
    end
  end

848
  describe "#license_blob", :use_clean_rails_memory_store_caching do
849
    before do
850
      repository.delete_file(
851
        user, 'LICENSE', message: 'Remove LICENSE', branch_name: 'master')
852 853
    end

854
    it 'handles when HEAD points to non-existent ref' do
855
      repository.create_file(
856
        user, 'LICENSE', 'Copyright!',
857
        message: 'Add LICENSE', branch_name: 'master')
858

859
      allow(repository).to receive(:root_ref).and_raise(Gitlab::Git::Repository::NoRepository)
860 861 862 863

      expect(repository.license_blob).to be_nil
    end

864
    it 'looks in the root_ref only' do
865
      repository.delete_file(user, 'LICENSE',
866
        message: 'Remove LICENSE', branch_name: 'markdown')
867
      repository.create_file(user, 'LICENSE',
868
        Licensee::License.new('mit').content,
869
        message: 'Add LICENSE', branch_name: 'markdown')
870 871 872 873

      expect(repository.license_blob).to be_nil
    end

874
    it 'detects license file with no recognizable open-source license content' do
875 876
      repository.create_file(user, 'LICENSE', 'Copyright!',
        message: 'Add LICENSE', branch_name: 'master')
877

D
Douwe Maan 已提交
878
      expect(repository.license_blob.path).to eq('LICENSE')
879 880
    end

881 882
    %w[LICENSE LICENCE LiCensE LICENSE.md LICENSE.foo COPYING COPYING.md].each do |filename|
      it "detects '#{filename}'" do
883
        repository.create_file(user, filename,
884
          Licensee::License.new('mit').content,
885
          message: "Add #{filename}", branch_name: 'master')
886

887 888
        expect(repository.license_blob.name).to eq(filename)
      end
889 890 891
    end
  end

892
  describe '#license_key', :use_clean_rails_memory_store_caching do
893
    before do
894
      repository.delete_file(user, 'LICENSE',
895
        message: 'Remove LICENSE', branch_name: 'master')
896
    end
Z
Zeger-Jan van de Weg 已提交
897

898
    it 'returns nil when no license is detected' do
899 900 901
      expect(repository.license_key).to be_nil
    end

902 903 904
    it 'returns nil when the repository does not exist' do
      expect(repository).to receive(:exists?).and_return(false)

905 906 907
      expect(repository.license_key).to be_nil
    end

D
Douwe Maan 已提交
908
    it 'returns nil when the content is not recognizable' do
909
      repository.create_file(user, 'LICENSE', 'Gitlab B.V.',
910
        message: 'Add LICENSE', branch_name: 'master')
911 912

      expect(repository.license_key).to be_nil
Z
Zeger-Jan van de Weg 已提交
913
    end
914

915 916 917 918 919 920
    it 'returns nil when the commit SHA does not exist' do
      allow(repository.head_commit).to receive(:sha).and_return('1' * 40)

      expect(repository.license_key).to be_nil
    end

921
    it 'returns nil when master does not exist' do
922 923
      repository.rm_branch(user, 'master')

924
      expect(repository.license_key).to be_nil
925 926
    end

927
    it 'returns the license key' do
928
      repository.create_file(user, 'LICENSE',
929
        Licensee::License.new('mit').content,
930
        message: 'Add LICENSE', branch_name: 'master')
931

932
      expect(repository.license_key).to eq('mit')
933
    end
Z
Zeger-Jan van de Weg 已提交
934
  end
935

D
Douwe Maan 已提交
936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952
  describe '#license' do
    before do
      repository.delete_file(user, 'LICENSE',
        message: 'Remove LICENSE', branch_name: 'master')
    end

    it 'returns nil when no license is detected' do
      expect(repository.license).to be_nil
    end

    it 'returns nil when the repository does not exist' do
      expect(repository).to receive(:exists?).and_return(false)

      expect(repository.license).to be_nil
    end

    it 'returns nil when the content is not recognizable' do
953
      repository.create_file(user, 'LICENSE', 'Gitlab B.V.',
D
Douwe Maan 已提交
954 955 956 957 958 959 960 961 962 963 964 965 966 967 968
        message: 'Add LICENSE', branch_name: 'master')

      expect(repository.license).to be_nil
    end

    it 'returns the license' do
      license = Licensee::License.new('mit')
      repository.create_file(user, 'LICENSE',
        license.content,
        message: 'Add LICENSE', branch_name: 'master')

      expect(repository.license).to eq(license)
    end
  end

969
  describe "#gitlab_ci_yml", :use_clean_rails_memory_store_caching do
970 971 972 973
    it 'returns valid file' do
      files = [TestBlob.new('file'), TestBlob.new('.gitlab-ci.yml'), TestBlob.new('copying')]
      expect(repository.tree).to receive(:blobs).and_return(files)

D
Douwe Maan 已提交
974
      expect(repository.gitlab_ci_yml.path).to eq('.gitlab-ci.yml')
975 976 977 978 979 980 981 982
    end

    it 'returns nil if not exists' do
      expect(repository.tree).to receive(:blobs).and_return([])
      expect(repository.gitlab_ci_yml).to be_nil
    end

    it 'returns nil for empty repository' do
983
      allow(repository).to receive(:root_ref).and_raise(Gitlab::Git::Repository::NoRepository)
984 985 986 987
      expect(repository.gitlab_ci_yml).to be_nil
    end
  end

988
  describe '#add_branch' do
989 990
    let(:branch_name) { 'new_feature' }
    let(:target) { 'master' }
991

992
    subject { repository.add_branch(user, branch_name, target) }
993

994 995 996 997
    it "calls Gitaly's OperationService" do
      expect_any_instance_of(Gitlab::GitalyClient::OperationService)
        .to receive(:user_create_branch).with(branch_name, user, target)
        .and_return(nil)
998

999
      subject
1000 1001
    end

1002 1003 1004 1005
    it 'creates_the_branch' do
      expect(subject.name).to eq(branch_name)
      expect(repository.find_branch(branch_name)).not_to be_nil
    end
1006

1007 1008
    context 'with a non-existing target' do
      let(:target) { 'fake-target' }
1009

1010 1011 1012
      it "returns false and doesn't create the branch" do
        expect(subject).to be(false)
        expect(repository.find_branch(branch_name)).to be_nil
1013 1014 1015 1016
      end
    end
  end

1017
  describe '#find_branch' do
1018 1019 1020
    context 'fresh_repo is true' do
      it 'delegates the call to raw_repository' do
        expect(repository.raw_repository).to receive(:find_branch).with('master', true)
1021

1022
        repository.find_branch('master', fresh_repo: true)
1023 1024 1025
      end
    end

1026 1027 1028
    context 'fresh_repo is false' do
      it 'delegates the call to raw_repository' do
        expect(repository.raw_repository).to receive(:find_branch).with('master', false)
1029

1030
        repository.find_branch('master', fresh_repo: false)
1031 1032 1033 1034
      end
    end
  end

1035
  describe '#update_branch_with_hooks' do
1036
    let(:old_rev) { '0b4bc9a49b562e85de7cc9e834518ea6828729b9' } # git rev-parse feature
1037
    let(:new_rev) { 'a74ae73c1ccde9b974a70e82b901588071dc142a' } # commit whose parent is old_rev
1038 1039 1040
    let(:updating_ref) { 'refs/heads/feature' }
    let(:target_project) { project }
    let(:target_repository) { target_project.repository }
1041

1042 1043 1044 1045 1046 1047 1048
    around do |example|
      # TODO Gitlab::Git::OperationService will be moved to gitaly-ruby and disappear from this repo
      Gitlab::GitalyClient::StorageSettings.allow_disk_access do
        example.run
      end
    end

1049
    context 'when pre hooks were successful' do
1050
      before do
1051 1052
        service = Gitlab::Git::HooksService.new
        expect(Gitlab::Git::HooksService).to receive(:new).and_return(service)
1053
        expect(service).to receive(:execute)
1054
          .with(git_user, target_repository.raw_repository, old_rev, new_rev, updating_ref)
1055
          .and_yield(service).and_return(true)
1056
      end
1057

1058
      it 'runs without errors' do
1059
        expect do
1060
          Gitlab::Git::OperationService.new(git_user, repository.raw_repository).with_branch('feature') do
1061 1062
            new_rev
          end
1063 1064
        end.not_to raise_error
      end
1065

1066
      it 'ensures the autocrlf Git option is set to :input' do
1067
        service = Gitlab::Git::OperationService.new(git_user, repository.raw_repository)
1068 1069

        expect(service).to receive(:update_autocrlf_option)
1070

1071
        service.with_branch('feature') { new_rev }
1072
      end
1073 1074 1075

      context "when the branch wasn't empty" do
        it 'updates the head' do
1076
          expect(repository.find_branch('feature').dereferenced_target.id).to eq(old_rev)
1077

1078
          Gitlab::Git::OperationService.new(git_user, repository.raw_repository).with_branch('feature') do
1079 1080 1081
            new_rev
          end

1082
          expect(repository.find_branch('feature').dereferenced_target.id).to eq(new_rev)
1083 1084
        end
      end
1085 1086 1087 1088 1089 1090 1091 1092

      context 'when target project does not have the commit' do
        let(:target_project) { create(:project, :empty_repo) }
        let(:old_rev) { Gitlab::Git::BLANK_SHA }
        let(:new_rev) { project.commit('feature').sha }
        let(:updating_ref) { 'refs/heads/master' }

        it 'fetch_ref and create the branch' do
1093
          expect(target_project.repository.raw_repository).to receive(:fetch_ref)
1094 1095
            .and_call_original

1096
          Gitlab::Git::OperationService.new(git_user, target_repository.raw_repository)
1097 1098
            .with_branch(
              'master',
1099
              start_repository: project.repository.raw_repository,
1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111
              start_branch_name: 'feature') { new_rev }

          expect(target_repository.branch_names).to contain_exactly('master')
        end
      end

      context 'when target project already has the commit' do
        let(:target_project) { create(:project, :repository) }

        it 'does not fetch_ref and just pass the commit' do
          expect(target_repository).not_to receive(:fetch_ref)

1112
          Gitlab::Git::OperationService.new(git_user, target_repository.raw_repository)
1113
            .with_branch('feature', start_repository: project.repository.raw_repository) { new_rev }
1114 1115
        end
      end
1116 1117
    end

1118 1119 1120 1121
    context 'when temporary ref failed to be created from other project' do
      let(:target_project) { create(:project, :empty_repo) }

      before do
1122
        expect(target_project.repository.raw_repository).to receive(:run_git)
1123 1124 1125 1126 1127 1128 1129 1130
      end

      it 'raises Rugged::ReferenceError' do
        raise_reference_error = raise_error(Rugged::ReferenceError) do |err|
          expect(err.cause).to be_nil
        end

        expect do
1131
          Gitlab::Git::OperationService.new(git_user, target_project.repository.raw_repository)
1132
            .with_branch('feature',
1133
                         start_repository: project.repository.raw_repository,
1134 1135 1136 1137 1138
                         &:itself)
        end.to raise_reference_error
      end
    end

1139
    context 'when the update adds more than one commit' do
1140
      let(:old_rev) { '33f3729a45c02fc67d00adb1b8bca394b0e761d9' }
1141

1142
      it 'runs without errors' do
1143
        # old_rev is an ancestor of new_rev
1144
        expect(repository.merge_base(old_rev, new_rev)).to eq(old_rev)
1145 1146 1147 1148

        # old_rev is not a direct ancestor (parent) of new_rev
        expect(repository.rugged.lookup(new_rev).parent_ids).not_to include(old_rev)

1149 1150 1151
        branch = 'feature-ff-target'
        repository.add_branch(user, branch, old_rev)

1152
        expect do
1153
          Gitlab::Git::OperationService.new(git_user, repository.raw_repository).with_branch(branch) do
1154 1155 1156
            new_rev
          end
        end.not_to raise_error
1157 1158 1159 1160
      end
    end

    context 'when the update would remove commits from the target branch' do
1161 1162
      let(:branch) { 'master' }
      let(:old_rev) { repository.find_branch(branch).dereferenced_target.sha }
1163

1164
      it 'raises an exception' do
1165
        # The 'master' branch is NOT an ancestor of new_rev.
1166
        expect(repository.merge_base(old_rev, new_rev)).not_to eq(old_rev)
1167 1168 1169 1170

        # Updating 'master' to new_rev would lose the commits on 'master' that
        # are not contained in new_rev. This should not be allowed.
        expect do
1171
          Gitlab::Git::OperationService.new(git_user, repository.raw_repository).with_branch(branch) do
1172 1173
            new_rev
          end
1174
        end.to raise_error(Gitlab::Git::CommitError)
1175 1176 1177
      end
    end

1178
    context 'when pre hooks failed' do
1179
      it 'gets an error' do
1180
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([false, ''])
1181 1182

        expect do
1183
          Gitlab::Git::OperationService.new(git_user, repository.raw_repository).with_branch('feature') do
1184 1185
            new_rev
          end
1186
        end.to raise_error(Gitlab::Git::PreReceiveError)
1187 1188
      end
    end
1189 1190 1191 1192 1193 1194

    context 'when target branch is different from source branch' do
      before do
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([true, ''])
      end

1195 1196
      subject do
        Gitlab::Git::OperationService.new(git_user, repository.raw_repository).with_branch('new-feature') do
J
Jacob Vosmaer 已提交
1197
          new_rev
J
Jacob Vosmaer 已提交
1198
        end
1199
      end
1200 1201 1202 1203 1204

      it 'returns branch_created as true' do
        expect(subject).not_to be_repo_created
        expect(subject).to     be_branch_created
      end
1205 1206 1207 1208 1209 1210 1211 1212
    end

    context 'when repository is empty' do
      before do
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([true, ''])
      end

      it 'expires creation and branch cache' do
1213
        empty_repository = create(:project, :empty_repo).repository
1214 1215 1216 1217 1218 1219

        expect(empty_repository).to receive(:expire_exists_cache)
        expect(empty_repository).to receive(:expire_root_ref_cache)
        expect(empty_repository).to receive(:expire_emptiness_caches)
        expect(empty_repository).to receive(:expire_branches_cache)

1220
        empty_repository.create_file(user, 'CHANGELOG', 'Changelog!',
1221
                                     message: 'Updates file content',
1222
                                     branch_name: 'master')
1223 1224
      end
    end
1225
  end
1226

1227
  describe '#exists?' do
1228
    it 'returns true when a repository exists' do
1229
      expect(repository.exists?).to be(true)
1230 1231
    end

1232
    it 'returns false if no full path can be constructed' do
1233
      allow(repository).to receive(:full_path).and_return(nil)
1234

1235
      expect(repository.exists?).to be(false)
1236
    end
1237

1238
    context 'with broken storage', :broken_storage do
1239 1240 1241 1242
      it 'should raise a storage error' do
        expect_to_raise_storage_error { broken_repository.exists? }
      end
    end
1243
  end
1244

1245
  describe '#has_visible_content?' do
1246 1247 1248 1249 1250 1251 1252
    before do
      # If raw_repository.has_visible_content? gets called more than once then
      # caching is broken. We don't want that.
      expect(repository.raw_repository).to receive(:has_visible_content?)
        .once
        .and_return(result)
    end
1253

1254 1255
    context 'when true' do
      let(:result) { true }
1256

1257 1258 1259 1260 1261
      it 'returns true and caches it' do
        expect(repository.has_visible_content?).to eq(true)
        # Second call hits the cache
        expect(repository.has_visible_content?).to eq(true)
      end
1262 1263
    end

1264 1265
    context 'when false' do
      let(:result) { false }
1266

1267 1268 1269 1270
      it 'returns false and caches it' do
        expect(repository.has_visible_content?).to eq(false)
        # Second call hits the cache
        expect(repository.has_visible_content?).to eq(false)
1271 1272 1273 1274
      end
    end
  end

1275 1276 1277 1278 1279 1280 1281 1282 1283
  describe '#branch_exists?' do
    it 'uses branch_names' do
      allow(repository).to receive(:branch_names).and_return(['foobar'])

      expect(repository.branch_exists?('foobar')).to eq(true)
      expect(repository.branch_exists?('master')).to eq(false)
    end
  end

1284 1285 1286 1287 1288 1289 1290 1291 1292
  describe '#tag_exists?' do
    it 'uses tag_names' do
      allow(repository).to receive(:tag_names).and_return(['foobar'])

      expect(repository.tag_exists?('foobar')).to eq(true)
      expect(repository.tag_exists?('master')).to eq(false)
    end
  end

1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308
  describe '#branch_names', :use_clean_rails_memory_store_caching do
    let(:fake_branch_names) { ['foobar'] }

    it 'gets cached across Repository instances' do
      allow(repository.raw_repository).to receive(:branch_names).once.and_return(fake_branch_names)

      expect(repository.branch_names).to eq(fake_branch_names)

      fresh_repository = Project.find(project.id).repository
      expect(fresh_repository.object_id).not_to eq(repository.object_id)

      expect(fresh_repository.raw_repository).not_to receive(:branch_names)
      expect(fresh_repository.branch_names).to eq(fake_branch_names)
    end
  end

1309
  describe '#update_autocrlf_option' do
1310 1311 1312 1313 1314 1315 1316
    around do |example|
      # TODO Gitlab::Git::OperationService will be moved to gitaly-ruby and disappear from this repo
      Gitlab::GitalyClient::StorageSettings.allow_disk_access do
        example.run
      end
    end

1317 1318 1319 1320 1321 1322
    describe 'when autocrlf is not already set to :input' do
      before do
        repository.raw_repository.autocrlf = true
      end

      it 'sets autocrlf to :input' do
1323
        Gitlab::Git::OperationService.new(nil, repository.raw_repository).send(:update_autocrlf_option)
1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334

        expect(repository.raw_repository.autocrlf).to eq(:input)
      end
    end

    describe 'when autocrlf is already set to :input' do
      before do
        repository.raw_repository.autocrlf = :input
      end

      it 'does nothing' do
1335 1336
        expect(repository.raw_repository).not_to receive(:autocrlf=)
          .with(:input)
1337

1338
        Gitlab::Git::OperationService.new(nil, repository.raw_repository).send(:update_autocrlf_option)
1339 1340 1341 1342
      end
    end
  end

1343 1344 1345 1346
  describe '#empty?' do
    let(:empty_repository) { create(:project_empty_repo).repository }

    it 'returns true for an empty repository' do
1347
      expect(empty_repository).to be_empty
1348 1349 1350
    end

    it 'returns false for a non-empty repository' do
1351
      expect(repository).not_to be_empty
1352 1353 1354
    end

    it 'caches the output' do
1355
      expect(repository.raw_repository).to receive(:has_visible_content?).once
1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367

      repository.empty?
      repository.empty?
    end
  end

  describe '#root_ref' do
    it 'returns a branch name' do
      expect(repository.root_ref).to be_an_instance_of(String)
    end

    it 'caches the output' do
1368 1369 1370
      expect(repository.raw_repository).to receive(:root_ref)
        .once
        .and_return('master')
1371 1372 1373 1374 1375 1376 1377 1378 1379 1380

      repository.root_ref
      repository.root_ref
    end
  end

  describe '#expire_root_ref_cache' do
    it 'expires the root reference cache' do
      repository.root_ref

1381 1382 1383
      expect(repository.raw_repository).to receive(:root_ref)
        .once
        .and_return('foo')
1384 1385 1386 1387 1388 1389 1390

      repository.expire_root_ref_cache

      expect(repository.root_ref).to eq('foo')
    end
  end

Y
Yorick Peterse 已提交
1391
  describe '#expire_branch_cache' do
1392 1393 1394 1395 1396
    # This method is private but we need it for testing purposes. Sadly there's
    # no other proper way of testing caching operations.
    let(:cache) { repository.send(:cache) }

    it 'expires the cache for all branches' do
1397 1398 1399
      expect(cache).to receive(:expire)
        .at_least(repository.branches.length * 2)
        .times
1400 1401 1402 1403 1404

      repository.expire_branch_cache
    end

    it 'expires the cache for all branches when the root branch is given' do
1405 1406 1407
      expect(cache).to receive(:expire)
        .at_least(repository.branches.length * 2)
        .times
1408 1409 1410 1411 1412

      repository.expire_branch_cache(repository.root_ref)
    end

    it 'expires the cache for a specific branch' do
1413
      expect(cache).to receive(:expire).twice
1414 1415 1416 1417

      repository.expire_branch_cache('foo')
    end
  end
1418

1419 1420 1421
  describe '#expire_emptiness_caches' do
    let(:cache) { repository.send(:cache) }

1422 1423 1424
    it 'expires the caches for an empty repository' do
      allow(repository).to receive(:empty?).and_return(true)

1425
      expect(cache).to receive(:expire).with(:has_visible_content?)
1426 1427 1428

      repository.expire_emptiness_caches
    end
1429 1430 1431 1432

    it 'does not expire the cache for a non-empty repository' do
      allow(repository).to receive(:empty?).and_return(false)

1433
      expect(cache).not_to receive(:expire).with(:has_visible_content?)
1434 1435 1436

      repository.expire_emptiness_caches
    end
1437 1438 1439 1440 1441 1442

    it 'expires the memoized repository cache' do
      allow(repository.raw_repository).to receive(:expire_has_local_branches_cache).and_call_original

      repository.expire_emptiness_caches
    end
1443 1444
  end

1445
  describe 'skip_merges option' do
1446
    subject { repository.commits(Gitlab::Git::BRANCH_REF_PREFIX + "'test'", limit: 100, skip_merges: true).map { |k| k.id } }
1447 1448 1449

    it { is_expected.not_to include('e56497bb5f03a90a51293fc6d516788730953899') }
  end
1450 1451

  describe '#merge' do
1452 1453
    let(:merge_request) { create(:merge_request, source_branch: 'feature', target_branch: 'master', source_project: project) }

1454
    let(:message) { 'Test \r\n\r\n message' }
1455

J
Jacob Vosmaer 已提交
1456 1457 1458 1459 1460 1461 1462 1463
    shared_examples '#merge' do
      it 'merges the code and returns the commit id' do
        expect(merge_commit).to be_present
        expect(repository.blob_at(merge_commit.id, 'files/ruby/feature.rb')).to be_present
      end

      it 'sets the `in_progress_merge_commit_sha` flag for the given merge request' do
        merge_commit_id = merge(repository, user, merge_request, message)
1464

J
Jacob Vosmaer 已提交
1465 1466 1467 1468 1469
        expect(merge_request.in_progress_merge_commit_sha).to eq(merge_commit_id)
      end

      it 'removes carriage returns from commit message' do
        merge_commit_id = merge(repository, user, merge_request, message)
1470

J
Jacob Vosmaer 已提交
1471 1472
        expect(repository.commit(merge_commit_id).message).to eq(message.delete("\r"))
      end
1473
    end
1474

J
Jacob Vosmaer 已提交
1475 1476 1477
    context 'with gitaly' do
      it_behaves_like '#merge'
    end
1478

J
Jacob Vosmaer 已提交
1479 1480
    context 'without gitaly', :skip_gitaly_mock do
      it_behaves_like '#merge'
1481 1482
    end

1483 1484
    def merge(repository, user, merge_request, message)
      repository.merge(user, merge_request.diff_head_sha, merge_request, message)
1485
    end
1486 1487
  end

1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515
  describe '#ff_merge' do
    before do
      repository.add_branch(user, 'ff-target', 'feature~5')
    end

    it 'merges the code and return the commit id' do
      merge_request = create(:merge_request, source_branch: 'feature', target_branch: 'ff-target', source_project: project)
      merge_commit_id = repository.ff_merge(user,
                                            merge_request.diff_head_sha,
                                            merge_request.target_branch,
                                            merge_request: merge_request)
      merge_commit = repository.commit(merge_commit_id)

      expect(merge_commit).to be_present
      expect(repository.blob_at(merge_commit.id, 'files/ruby/feature.rb')).to be_present
    end

    it 'sets the `in_progress_merge_commit_sha` flag for the given merge request' do
      merge_request = create(:merge_request, source_branch: 'feature', target_branch: 'ff-target', source_project: project)
      merge_commit_id = repository.ff_merge(user,
                                            merge_request.diff_head_sha,
                                            merge_request.target_branch,
                                            merge_request: merge_request)

      expect(merge_request.in_progress_merge_commit_sha).to eq(merge_commit_id)
    end
  end

1516
  describe '#revert' do
1517 1518 1519 1520 1521 1522 1523 1524 1525
    shared_examples 'reverting a commit' do
      let(:new_image_commit) { repository.commit('33f3729a45c02fc67d00adb1b8bca394b0e761d9') }
      let(:update_image_commit) { repository.commit('2f63565e7aac07bcdadb654e253078b727143ec4') }
      let(:message) { 'revert message' }

      context 'when there is a conflict' do
        it 'raises an error' do
          expect { repository.revert(user, new_image_commit, 'master', message) }.to raise_error(Gitlab::Git::Repository::CreateTreeError)
        end
1526 1527
      end

1528 1529 1530
      context 'when commit was already reverted' do
        it 'raises an error' do
          repository.revert(user, update_image_commit, 'master', message)
1531

1532 1533
          expect { repository.revert(user, update_image_commit, 'master', message) }.to raise_error(Gitlab::Git::Repository::CreateTreeError)
        end
1534 1535
      end

1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549
      context 'when commit can be reverted' do
        it 'reverts the changes' do
          expect(repository.revert(user, update_image_commit, 'master', message)).to be_truthy
        end
      end

      context 'reverting a merge commit' do
        it 'reverts the changes' do
          merge_commit
          expect(repository.blob_at_branch('master', 'files/ruby/feature.rb')).to be_present

          repository.revert(user, merge_commit, 'master', message)
          expect(repository.blob_at_branch('master', 'files/ruby/feature.rb')).not_to be_present
        end
1550 1551 1552
      end
    end

1553 1554 1555
    context 'when Gitaly revert feature is enabled' do
      it_behaves_like 'reverting a commit'
    end
1556

1557 1558
    context 'when Gitaly revert feature is disabled', :disable_gitaly do
      it_behaves_like 'reverting a commit'
1559 1560
    end
  end
1561

P
P.S.V.R 已提交
1562
  describe '#cherry_pick' do
1563 1564 1565 1566 1567 1568 1569 1570 1571 1572
    shared_examples 'cherry-picking a commit' do
      let(:conflict_commit) { repository.commit('c642fe9b8b9f28f9225d7ea953fe14e74748d53b') }
      let(:pickable_commit) { repository.commit('7d3b0f7cff5f37573aea97cebfd5692ea1689924') }
      let(:pickable_merge) { repository.commit('e56497bb5f03a90a51293fc6d516788730953899') }
      let(:message) { 'cherry-pick message' }

      context 'when there is a conflict' do
        it 'raises an error' do
          expect { repository.cherry_pick(user, conflict_commit, 'master', message) }.to raise_error(Gitlab::Git::Repository::CreateTreeError)
        end
P
P.S.V.R 已提交
1573 1574
      end

1575 1576 1577
      context 'when commit was already cherry-picked' do
        it 'raises an error' do
          repository.cherry_pick(user, pickable_commit, 'master', message)
P
P.S.V.R 已提交
1578

1579 1580
          expect { repository.cherry_pick(user, pickable_commit, 'master', message) }.to raise_error(Gitlab::Git::Repository::CreateTreeError)
        end
P
P.S.V.R 已提交
1581 1582
      end

1583 1584 1585 1586
      context 'when commit can be cherry-picked' do
        it 'cherry-picks the changes' do
          expect(repository.cherry_pick(user, pickable_commit, 'master', message)).to be_truthy
        end
P
P.S.V.R 已提交
1587 1588
      end

1589 1590 1591
      context 'cherry-picking a merge commit' do
        it 'cherry-picks the changes' do
          expect(repository.blob_at_branch('improve/awesome', 'foo/bar/.gitkeep')).to be_nil
P
P.S.V.R 已提交
1592

1593 1594
          cherry_pick_commit_sha = repository.cherry_pick(user, pickable_merge, 'improve/awesome', message)
          cherry_pick_commit_message = project.commit(cherry_pick_commit_sha).message
1595

1596 1597 1598
          expect(repository.blob_at_branch('improve/awesome', 'foo/bar/.gitkeep')).not_to be_nil
          expect(cherry_pick_commit_message).to eq(message)
        end
P
P.S.V.R 已提交
1599 1600
      end
    end
1601 1602 1603 1604 1605 1606 1607 1608

    context 'when Gitaly cherry_pick feature is enabled' do
      it_behaves_like 'cherry-picking a commit'
    end

    context 'when Gitaly cherry_pick feature is disabled', :disable_gitaly do
      it_behaves_like 'cherry-picking a commit'
    end
P
P.S.V.R 已提交
1609 1610
  end

1611 1612 1613 1614 1615 1616 1617
  describe '#before_delete' do
    describe 'when a repository does not exist' do
      before do
        allow(repository).to receive(:exists?).and_return(false)
      end

      it 'does not flush caches that depend on repository data' do
1618
        expect(repository).not_to receive(:expire_cache)
1619 1620 1621 1622

        repository.before_delete
      end

1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634
      it 'flushes the tags cache' do
        expect(repository).to receive(:expire_tags_cache)

        repository.before_delete
      end

      it 'flushes the branches cache' do
        expect(repository).to receive(:expire_branches_cache)

        repository.before_delete
      end

1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645
      it 'flushes the root ref cache' do
        expect(repository).to receive(:expire_root_ref_cache)

        repository.before_delete
      end

      it 'flushes the emptiness caches' do
        expect(repository).to receive(:expire_emptiness_caches)

        repository.before_delete
      end
1646 1647

      it 'flushes the exists cache' do
1648
        expect(repository).to receive(:expire_exists_cache).twice
1649 1650 1651

        repository.before_delete
      end
1652 1653 1654 1655 1656 1657 1658
    end

    describe 'when a repository exists' do
      before do
        allow(repository).to receive(:exists?).and_return(true)
      end

1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670
      it 'flushes the tags cache' do
        expect(repository).to receive(:expire_tags_cache)

        repository.before_delete
      end

      it 'flushes the branches cache' do
        expect(repository).to receive(:expire_branches_cache)

        repository.before_delete
      end

1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698
      it 'flushes the root ref cache' do
        expect(repository).to receive(:expire_root_ref_cache)

        repository.before_delete
      end

      it 'flushes the emptiness caches' do
        expect(repository).to receive(:expire_emptiness_caches)

        repository.before_delete
      end
    end
  end

  describe '#before_change_head' do
    it 'flushes the branch cache' do
      expect(repository).to receive(:expire_branch_cache)

      repository.before_change_head
    end

    it 'flushes the root ref cache' do
      expect(repository).to receive(:expire_root_ref_cache)

      repository.before_change_head
    end
  end

1699
  describe '#after_change_head' do
1700
    it 'flushes the method caches' do
1701
      expect(repository).to receive(:expire_method_caches).with([
1702 1703 1704 1705
        :size,
        :commit_count,
        :rendered_readme,
        :contribution_guide,
1706
        :changelog,
1707 1708
        :license_blob,
        :license_key,
1709
        :gitignore,
1710 1711 1712 1713 1714 1715
        :koding_yml,
        :gitlab_ci_yml,
        :branch_names,
        :tag_names,
        :branch_count,
        :tag_count,
S
Sean McGivern 已提交
1716
        :avatar,
1717 1718 1719 1720 1721 1722
        :exists?,
        :root_ref,
        :has_visible_content?,
        :issue_template_names,
        :merge_request_template_names,
        :xcode_project?
1723 1724 1725 1726 1727 1728
      ])

      repository.after_change_head
    end
  end

Y
Yorick Peterse 已提交
1729
  describe '#before_push_tag' do
1730
    it 'flushes the cache' do
1731 1732 1733
      expect(repository).to receive(:expire_statistics_caches)
      expect(repository).to receive(:expire_emptiness_caches)
      expect(repository).to receive(:expire_tags_cache)
1734

Y
Yorick Peterse 已提交
1735
      repository.before_push_tag
1736 1737 1738 1739
    end
  end

  describe '#after_import' do
1740 1741
    it 'flushes and builds the cache' do
      expect(repository).to receive(:expire_content_cache)
1742 1743 1744

      repository.after_import
    end
1745 1746 1747
  end

  describe '#after_push_commit' do
1748
    it 'expires statistics caches' do
1749 1750
      expect(repository).to receive(:expire_statistics_caches)
        .and_call_original
1751

1752 1753 1754
      expect(repository).to receive(:expire_branch_cache)
        .with('master')
        .and_call_original
1755

1756
      repository.after_push_commit('master')
1757 1758 1759 1760
    end
  end

  describe '#after_create_branch' do
1761
    it 'expires the branch caches' do
1762
      expect(repository).to receive(:expire_branches_cache)
1763 1764 1765 1766 1767 1768

      repository.after_create_branch
    end
  end

  describe '#after_remove_branch' do
1769
    it 'expires the branch caches' do
1770
      expect(repository).to receive(:expire_branches_cache)
1771 1772 1773 1774

      repository.after_remove_branch
    end
  end
1775

1776 1777 1778 1779 1780 1781
  describe '#after_create' do
    it 'flushes the exists cache' do
      expect(repository).to receive(:expire_exists_cache)

      repository.after_create
    end
1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793

    it 'flushes the root ref cache' do
      expect(repository).to receive(:expire_root_ref_cache)

      repository.after_create
    end

    it 'flushes the emptiness caches' do
      expect(repository).to receive(:expire_emptiness_caches)

      repository.after_create
    end
1794 1795
  end

1796 1797 1798 1799 1800 1801 1802 1803 1804 1805
  describe "#copy_gitattributes" do
    it 'returns true with a valid ref' do
      expect(repository.copy_gitattributes('master')).to be_truthy
    end

    it 'returns false with an invalid ref' do
      expect(repository.copy_gitattributes('invalid')).to be_falsey
    end
  end

Y
Yorick Peterse 已提交
1806 1807
  describe '#before_remove_tag' do
    it 'flushes the tag cache' do
1808 1809
      expect(repository).to receive(:expire_tags_cache).and_call_original
      expect(repository).to receive(:expire_statistics_caches).and_call_original
Y
Yorick Peterse 已提交
1810 1811 1812 1813 1814 1815 1816

      repository.before_remove_tag
    end
  end

  describe '#branch_count' do
    it 'returns the number of branches' do
D
Douwe Maan 已提交
1817
      expect(repository.branch_count).to be_an(Integer)
K
Cleanup  
Kim "BKC" Carlbäcker 已提交
1818 1819

      # NOTE: Until rugged goes away, make sure rugged and gitaly are in sync
1820 1821 1822
      rugged_count = Gitlab::GitalyClient::StorageSettings.allow_disk_access do
        repository.raw_repository.rugged.branches.count
      end
K
Cleanup  
Kim "BKC" Carlbäcker 已提交
1823

1824
      expect(repository.branch_count).to eq(rugged_count)
Y
Yorick Peterse 已提交
1825 1826 1827 1828 1829
    end
  end

  describe '#tag_count' do
    it 'returns the number of tags' do
D
Douwe Maan 已提交
1830
      expect(repository.tag_count).to be_an(Integer)
K
Cleanup  
Kim "BKC" Carlbäcker 已提交
1831

1832
      # NOTE: Until rugged goes away, make sure rugged and gitaly are in sync
1833 1834 1835
      rugged_count = Gitlab::GitalyClient::StorageSettings.allow_disk_access do
        repository.raw_repository.rugged.tags.count
      end
K
Cleanup  
Kim "BKC" Carlbäcker 已提交
1836

1837
      expect(repository.tag_count).to eq(rugged_count)
Y
Yorick Peterse 已提交
1838 1839 1840
    end
  end

1841
  describe '#expire_branches_cache' do
Y
Yorick Peterse 已提交
1842
    it 'expires the cache' do
1843
      expect(repository).to receive(:expire_method_caches)
1844
        .with(%i(branch_names branch_count has_visible_content?))
1845
        .and_call_original
Y
Yorick Peterse 已提交
1846

1847
      repository.expire_branches_cache
Y
Yorick Peterse 已提交
1848 1849 1850
    end
  end

1851
  describe '#expire_tags_cache' do
Y
Yorick Peterse 已提交
1852
    it 'expires the cache' do
1853 1854 1855
      expect(repository).to receive(:expire_method_caches)
        .with(%i(tag_names tag_count))
        .and_call_original
Y
Yorick Peterse 已提交
1856

1857
      repository.expire_tags_cache
Y
Yorick Peterse 已提交
1858 1859
    end
  end
1860

1861
  describe '#add_tag' do
1862
    let(:user) { build_stubbed(:user) }
1863

1864 1865 1866
    context 'with a valid target' do
      it 'creates the tag' do
        repository.add_tag(user, '8.5', 'master', 'foo')
1867

1868 1869 1870 1871
        tag = repository.find_tag('8.5')
        expect(tag).to be_present
        expect(tag.message).to eq('foo')
        expect(tag.dereferenced_target.id).to eq(repository.commit('master').id)
1872
      end
1873

1874
      it 'returns a Gitlab::Git::Tag object' do
1875 1876
        tag = repository.add_tag(user, '8.5', 'master', 'foo')

1877 1878 1879
        expect(tag).to be_a(Gitlab::Git::Tag)
      end
    end
1880

1881 1882 1883
    context 'with an invalid target' do
      it 'returns false' do
        expect(repository.add_tag(user, '8.5', 'bar', 'foo')).to be false
1884
      end
1885 1886 1887
    end
  end

1888
  describe '#rm_branch' do
1889 1890 1891
    it 'removes a branch' do
      expect(repository).to receive(:before_remove_branch)
      expect(repository).to receive(:after_remove_branch)
1892

1893
      repository.rm_branch(user, 'feature')
1894
    end
1895

1896 1897 1898 1899
    context 'when pre hooks failed' do
      before do
        allow_any_instance_of(Gitlab::GitalyClient::OperationService)
          .to receive(:user_delete_branch).and_raise(Gitlab::Git::PreReceiveError)
1900 1901
      end

1902 1903 1904 1905
      it 'gets an error and does not delete the branch' do
        expect do
          repository.rm_branch(user, 'feature')
        end.to raise_error(Gitlab::Git::PreReceiveError)
1906

1907
        expect(repository.find_branch('feature')).not_to be_nil
1908
      end
1909 1910
    end
  end
1911 1912

  describe '#rm_tag' do
1913 1914
    it 'removes a tag' do
      expect(repository).to receive(:before_remove_tag)
1915

1916
      repository.rm_tag(build_stubbed(:user), 'v1.1.0')
1917

1918
      expect(repository.find_tag('v1.1.0')).to be_nil
1919 1920
    end
  end
1921 1922

  describe '#avatar' do
1923
    it 'returns nil if repo does not exist' do
1924
      allow(repository).to receive(:root_ref).and_raise(Gitlab::Git::Repository::NoRepository)
1925 1926 1927 1928

      expect(repository.avatar).to eq(nil)
    end

1929
    it 'returns the first avatar file found in the repository' do
1930 1931 1932
      expect(repository).to receive(:file_on_head)
        .with(:avatar)
        .and_return(double(:tree, path: 'logo.png'))
1933 1934 1935 1936 1937

      expect(repository.avatar).to eq('logo.png')
    end

    it 'caches the output' do
1938 1939 1940 1941
      expect(repository).to receive(:file_on_head)
        .with(:avatar)
        .once
        .and_return(double(:tree, path: 'logo.png'))
1942

1943
      2.times { expect(repository.avatar).to eq('logo.png') }
1944 1945
    end
  end
1946

1947 1948 1949 1950 1951 1952 1953 1954 1955 1956
  describe '#expire_exists_cache' do
    let(:cache) { repository.send(:cache) }

    it 'expires the cache' do
      expect(cache).to receive(:expire).with(:exists?)

      repository.expire_exists_cache
    end
  end

1957 1958
  describe '#xcode_project?' do
    before do
1959
      allow(repository).to receive(:tree).with(:head).and_return(double(:tree, trees: [tree]))
1960 1961
    end

1962 1963
    context 'when the root contains a *.xcodeproj directory' do
      let(:tree) { double(:tree, path: 'Foo.xcodeproj') }
1964 1965 1966 1967 1968 1969

      it 'returns true' do
        expect(repository.xcode_project?).to be_truthy
      end
    end

1970 1971
    context 'when the root contains a *.xcworkspace directory' do
      let(:tree) { double(:tree, path: 'Foo.xcworkspace') }
1972 1973 1974 1975 1976 1977

      it 'returns true' do
        expect(repository.xcode_project?).to be_truthy
      end
    end

1978 1979
    context 'when the root contains no Xcode config directory' do
      let(:tree) { double(:tree, path: 'Foo') }
1980 1981 1982 1983 1984 1985 1986

      it 'returns false' do
        expect(repository.xcode_project?).to be_falsey
      end
    end
  end

1987
  describe "#keep_around" do
1988 1989 1990 1991
    it "does not fail if we attempt to reference bad commit" do
      expect(repository.kept_around?('abc1234')).to be_falsey
    end

1992 1993 1994 1995 1996
    it "stores a reference to the specified commit sha so it isn't garbage collected" do
      repository.keep_around(sample_commit.id)

      expect(repository.kept_around?(sample_commit.id)).to be_truthy
    end
1997 1998 1999 2000

    it "attempting to call keep_around on truncated ref does not fail" do
      repository.keep_around(sample_commit.id)
      ref = repository.send(:keep_around_ref_name, sample_commit.id)
2001 2002 2003 2004

      path = Gitlab::GitalyClient::StorageSettings.allow_disk_access do
        File.join(repository.path, ref)
      end
2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015
      # Corrupt the reference
      File.truncate(path, 0)

      expect(repository.kept_around?(sample_commit.id)).to be_falsey

      repository.keep_around(sample_commit.id)

      expect(repository.kept_around?(sample_commit.id)).to be_falsey

      File.delete(path)
    end
2016
  end
2017

2018
  describe '#update_ref' do
2019 2020 2021 2022 2023 2024 2025
    around do |example|
      # TODO Gitlab::Git::OperationService will be moved to gitaly-ruby and disappear from this repo
      Gitlab::GitalyClient::StorageSettings.allow_disk_access do
        example.run
      end
    end

2026
    it 'can create a ref' do
2027
      Gitlab::Git::OperationService.new(nil, repository.raw_repository).send(:update_ref, 'refs/heads/foobar', 'refs/heads/master', Gitlab::Git::BLANK_SHA)
2028 2029 2030 2031 2032 2033

      expect(repository.find_branch('foobar')).not_to be_nil
    end

    it 'raises CommitError when the ref update fails' do
      expect do
2034 2035
        Gitlab::Git::OperationService.new(nil, repository.raw_repository).send(:update_ref, 'refs/heads/master', 'refs/heads/master', Gitlab::Git::BLANK_SHA)
      end.to raise_error(Gitlab::Git::CommitError)
2036 2037
    end
  end
2038

2039
  describe '#contribution_guide', :use_clean_rails_memory_store_caching do
2040
    it 'returns and caches the output' do
2041 2042 2043 2044
      expect(repository).to receive(:file_on_head)
        .with(:contributing)
        .and_return(Gitlab::Git::Tree.new(path: 'CONTRIBUTING.md'))
        .once
2045 2046

      2.times do
2047 2048
        expect(repository.contribution_guide)
          .to be_an_instance_of(Gitlab::Git::Tree)
2049 2050 2051 2052
      end
    end
  end

2053
  describe '#gitignore', :use_clean_rails_memory_store_caching do
2054
    it 'returns and caches the output' do
2055 2056 2057 2058
      expect(repository).to receive(:file_on_head)
        .with(:gitignore)
        .and_return(Gitlab::Git::Tree.new(path: '.gitignore'))
        .once
2059 2060

      2.times do
2061
        expect(repository.gitignore).to be_an_instance_of(Gitlab::Git::Tree)
2062 2063 2064 2065
      end
    end
  end

2066
  describe '#koding_yml', :use_clean_rails_memory_store_caching do
2067
    it 'returns and caches the output' do
2068 2069 2070 2071
      expect(repository).to receive(:file_on_head)
        .with(:koding)
        .and_return(Gitlab::Git::Tree.new(path: '.koding.yml'))
        .once
2072 2073

      2.times do
2074
        expect(repository.koding_yml).to be_an_instance_of(Gitlab::Git::Tree)
2075 2076 2077 2078
      end
    end
  end

2079
  describe '#readme', :use_clean_rails_memory_store_caching do
2080 2081
    context 'with a non-existing repository' do
      it 'returns nil' do
2082
        allow(repository).to receive(:tree).with(:head).and_return(nil)
2083

2084 2085 2086
        expect(repository.readme).to be_nil
      end
    end
2087

2088
    context 'with an existing repository' do
2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100
      context 'when no README exists' do
        it 'returns nil' do
          allow_any_instance_of(Tree).to receive(:readme).and_return(nil)

          expect(repository.readme).to be_nil
        end
      end

      context 'when a README exists' do
        it 'returns the README' do
          expect(repository.readme).to be_an_instance_of(ReadmeBlob)
        end
2101 2102 2103 2104
      end
    end
  end

2105 2106
  describe '#expire_statistics_caches' do
    it 'expires the caches' do
2107 2108
      expect(repository).to receive(:expire_method_caches)
        .with(%i(size commit_count))
2109

2110 2111 2112 2113 2114 2115
      repository.expire_statistics_caches
    end
  end

  describe '#expire_all_method_caches' do
    it 'expires the caches of all methods' do
2116 2117
      expect(repository).to receive(:expire_method_caches)
        .with(Repository::CACHED_METHODS)
2118 2119 2120

      repository.expire_all_method_caches
    end
2121 2122 2123 2124 2125 2126 2127 2128 2129

    it 'all cache_method definitions are in the lists of method caches' do
      methods = repository.methods.map do |method|
        match = /^_uncached_(.*)/.match(method)
        match[1].to_sym if match
      end.compact

      expect(methods).to match_array(Repository::CACHED_METHODS + Repository::MEMOIZED_CACHED_METHODS)
    end
2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150
  end

  describe '#file_on_head' do
    context 'with a non-existing repository' do
      it 'returns nil' do
        expect(repository).to receive(:tree).with(:head).and_return(nil)

        expect(repository.file_on_head(:readme)).to be_nil
      end
    end

    context 'with a repository that has no blobs' do
      it 'returns nil' do
        expect_any_instance_of(Tree).to receive(:blobs).and_return([])

        expect(repository.file_on_head(:readme)).to be_nil
      end
    end

    context 'with an existing repository' do
      it 'returns a Gitlab::Git::Tree' do
2151 2152
        expect(repository.file_on_head(:readme))
          .to be_an_instance_of(Gitlab::Git::Tree)
2153 2154 2155 2156
      end
    end
  end

2157 2158 2159 2160 2161 2162
  describe '#head_tree' do
    context 'with an existing repository' do
      it 'returns a Tree' do
        expect(repository.head_tree).to be_an_instance_of(Tree)
      end
    end
2163

2164 2165 2166 2167 2168
    context 'with a non-existing repository' do
      it 'returns nil' do
        expect(repository).to receive(:head_commit).and_return(nil)

        expect(repository.head_tree).to be_nil
2169 2170 2171 2172
      end
    end
  end

2173 2174 2175 2176 2177
  describe '#tree' do
    context 'using a non-existing repository' do
      before do
        allow(repository).to receive(:head_commit).and_return(nil)
      end
2178

2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210
      it 'returns nil' do
        expect(repository.tree(:head)).to be_nil
      end

      it 'returns nil when using a path' do
        expect(repository.tree(:head, 'README.md')).to be_nil
      end
    end

    context 'using an existing repository' do
      it 'returns a Tree' do
        expect(repository.tree(:head)).to be_an_instance_of(Tree)
      end
    end
  end

  describe '#size' do
    context 'with a non-existing repository' do
      it 'returns 0' do
        expect(repository).to receive(:exists?).and_return(false)

        expect(repository.size).to eq(0.0)
      end
    end

    context 'with an existing repository' do
      it 'returns the repository size as a Float' do
        expect(repository.size).to be_an_instance_of(Float)
      end
    end
  end

2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232
  describe '#local_branches' do
    it 'returns the local branches' do
      masterrev = repository.find_branch('master').dereferenced_target
      create_remote_branch('joe', 'remote_branch', masterrev)
      repository.add_branch(user, 'local_branch', masterrev.id)

      expect(repository.local_branches.any? { |branch| branch.name == 'remote_branch' }).to eq(false)
      expect(repository.local_branches.any? { |branch| branch.name == 'local_branch' }).to eq(true)
    end
  end

  describe '#remote_branches' do
    it 'returns the remote branches' do
      masterrev = repository.find_branch('master').dereferenced_target
      create_remote_branch('joe', 'remote_branch', masterrev)
      repository.add_branch(user, 'local_branch', masterrev.id)

      expect(repository.remote_branches('joe').any? { |branch| branch.name == 'local_branch' }).to eq(false)
      expect(repository.remote_branches('joe').any? { |branch| branch.name == 'remote_branch' }).to eq(true)
    end
  end

2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243
  describe '#commit_count' do
    context 'with a non-existing repository' do
      it 'returns 0' do
        expect(repository).to receive(:root_ref).and_return(nil)

        expect(repository.commit_count).to eq(0)
      end
    end

    context 'with an existing repository' do
      it 'returns the commit count' do
D
Douwe Maan 已提交
2244
        expect(repository.commit_count).to be_an(Integer)
2245 2246 2247 2248
      end
    end
  end

2249
  describe '#commit_count_for_ref' do
2250
    let(:project) { create :project }
2251

2252 2253
    context 'with a non-existing repository' do
      it 'returns 0' do
2254 2255 2256 2257 2258 2259 2260 2261
        expect(project.repository.commit_count_for_ref('master')).to eq(0)
      end
    end

    context 'with empty repository' do
      it 'returns 0' do
        project.create_repository
        expect(project.repository.commit_count_for_ref('master')).to eq(0)
2262 2263 2264 2265 2266 2267 2268 2269 2270 2271
      end
    end

    context 'when searching for the root ref' do
      it 'returns the same count as #commit_count' do
        expect(repository.commit_count_for_ref(repository.root_ref)).to eq(repository.commit_count)
      end
    end
  end

2272 2273 2274 2275 2276 2277 2278 2279 2280
  describe '#diverging_commit_counts' do
    it 'returns the commit counts behind and ahead of default branch' do
      result = repository.diverging_commit_counts(
        repository.find_branch('fix'))

      expect(result).to eq(behind: 29, ahead: 2)
    end
  end

2281 2282
  describe '#refresh_method_caches' do
    it 'refreshes the caches of the given types' do
2283 2284
      expect(repository).to receive(:expire_method_caches)
        .with(%i(rendered_readme license_blob license_key license))
2285

2286
      expect(repository).to receive(:rendered_readme)
2287 2288
      expect(repository).to receive(:license_blob)
      expect(repository).to receive(:license_key)
2289
      expect(repository).to receive(:license)
2290 2291 2292

      repository.refresh_method_caches(%i(readme license))
    end
2293
  end
D
Douwe Maan 已提交
2294 2295 2296

  describe '#gitlab_ci_yml_for' do
    before do
2297
      repository.create_file(User.last, '.gitlab-ci.yml', 'CONTENT', message: 'Add .gitlab-ci.yml', branch_name: 'master')
D
Douwe Maan 已提交
2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314
    end

    context 'when there is a .gitlab-ci.yml at the commit' do
      it 'returns the content' do
        expect(repository.gitlab_ci_yml_for(repository.commit.sha)).to eq('CONTENT')
      end
    end

    context 'when there is no .gitlab-ci.yml at the commit' do
      it 'returns nil' do
        expect(repository.gitlab_ci_yml_for(repository.commit.parent.sha)).to be_nil
      end
    end
  end

  describe '#route_map_for' do
    before do
2315
      repository.create_file(User.last, '.gitlab/route-map.yml', 'CONTENT', message: 'Add .gitlab/route-map.yml', branch_name: 'master')
D
Douwe Maan 已提交
2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329
    end

    context 'when there is a .gitlab/route-map.yml at the commit' do
      it 'returns the content' do
        expect(repository.route_map_for(repository.commit.sha)).to eq('CONTENT')
      end
    end

    context 'when there is no .gitlab/route-map.yml at the commit' do
      it 'returns nil' do
        expect(repository.route_map_for(repository.commit.parent.sha)).to be_nil
      end
    end
  end
2330

2331
  def create_remote_branch(remote_name, branch_name, target)
2332 2333 2334
    rugged = Gitlab::GitalyClient::StorageSettings.allow_disk_access do
      repository.rugged
    end
2335 2336 2337
    rugged.references.create("refs/remotes/#{remote_name}/#{branch_name}", target.id)
  end

2338
  describe '#ancestor?' do
2339 2340
    let(:commit) { repository.commit }
    let(:ancestor) { commit.parents.first }
2341

2342
    shared_examples '#ancestor?' do
2343
      it 'it is an ancestor' do
2344
        expect(repository.ancestor?(ancestor.id, commit.id)).to eq(true)
2345 2346 2347
      end

      it 'it is not an ancestor' do
2348
        expect(repository.ancestor?(commit.id, ancestor.id)).to eq(false)
2349 2350 2351
      end

      it 'returns false on nil-values' do
2352 2353 2354
        expect(repository.ancestor?(nil, commit.id)).to eq(false)
        expect(repository.ancestor?(ancestor.id, nil)).to eq(false)
        expect(repository.ancestor?(nil, nil)).to eq(false)
2355
      end
2356

2357 2358 2359
      it 'returns false for invalid commit IDs' do
        expect(repository.ancestor?(commit.id, Gitlab::Git::BLANK_SHA)).to eq(false)
        expect(repository.ancestor?( Gitlab::Git::BLANK_SHA, commit.id)).to eq(false)
2360
      end
2361
    end
2362

2363 2364 2365
    context 'with Gitaly enabled' do
      it_behaves_like('#ancestor?')
    end
2366

2367 2368
    context 'with Gitaly disabled', :skip_gitaly_mock do
      it_behaves_like('#ancestor?')
2369 2370
    end
  end
2371

2372 2373 2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394 2395 2396 2397
  describe '#archive_metadata' do
    let(:ref) { 'master' }
    let(:storage_path) { '/tmp' }

    let(:prefix) { [project.path, ref].join('-') }
    let(:filename) { prefix + '.tar.gz' }

    subject(:result) { repository.archive_metadata(ref, storage_path, append_sha: false) }

    context 'with hashed storage disabled' do
      let(:project) { create(:project, :repository, :legacy_storage) }

      it 'uses the project path to generate the filename' do
        expect(result['ArchivePrefix']).to eq(prefix)
        expect(File.basename(result['ArchivePath'])).to eq(filename)
      end
    end

    context 'with hashed storage enabled' do
      it 'uses the project path to generate the filename' do
        expect(result['ArchivePrefix']).to eq(prefix)
        expect(File.basename(result['ArchivePath'])).to eq(filename)
      end
    end
  end

2398 2399 2400 2401 2402 2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416
  describe 'commit cache' do
    set(:project) { create(:project, :repository) }

    it 'caches based on SHA' do
      # Gets the commit oid, and warms the cache
      oid = project.commit.id

      expect(Gitlab::Git::Commit).not_to receive(:find).once

      project.commit_by(oid: oid)
    end

    it 'caches nil values' do
      expect(Gitlab::Git::Commit).to receive(:find).once

      project.commit_by(oid: '1' * 40)
      project.commit_by(oid: '1' * 40)
    end
  end
2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436

  describe '#raw_repository' do
    subject { repository.raw_repository }

    it 'returns a Gitlab::Git::Repository representation of the repository' do
      expect(subject).to be_a(Gitlab::Git::Repository)
      expect(subject.relative_path).to eq(project.disk_path + '.git')
      expect(subject.gl_repository).to eq("project-#{project.id}")
    end

    context 'with a wiki repository' do
      let(:repository) { project.wiki.repository }

      it 'creates a Gitlab::Git::Repository with the proper attributes' do
        expect(subject).to be_a(Gitlab::Git::Repository)
        expect(subject.relative_path).to eq(project.disk_path + '.wiki.git')
        expect(subject.gl_repository).to eq("wiki-#{project.id}")
      end
    end
  end
2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453 2454 2455 2456 2457 2458 2459 2460 2461 2462 2463 2464 2465 2466 2467 2468 2469 2470 2471 2472 2473 2474 2475 2476 2477 2478 2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489 2490 2491 2492 2493 2494 2495 2496 2497 2498 2499 2500 2501 2502 2503 2504 2505 2506 2507 2508 2509 2510 2511 2512 2513 2514 2515 2516 2517 2518 2519 2520 2521 2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537 2538 2539 2540 2541 2542 2543

  describe '#contributors' do
    let(:author_a) { build(:author, email: 'tiagonbotelho@hotmail.com', name: 'tiagonbotelho') }
    let(:author_b) { build(:author, email: 'gitlab@winniehell.de', name: 'Winnie') }
    let(:author_c) { build(:author, email: 'douwe@gitlab.com', name: 'Douwe Maan') }
    let(:stubbed_commits) do
      [build(:commit, author: author_a),
       build(:commit, author: author_a),
       build(:commit, author: author_b),
       build(:commit, author: author_c),
       build(:commit, author: author_c),
       build(:commit, author: author_c)]
    end
    let(:order_by) { nil }
    let(:sort) { nil }

    before do
      allow(repository).to receive(:commits).with(nil, limit: 2000, offset: 0, skip_merges: true).and_return(stubbed_commits)
    end

    subject { repository.contributors(order_by: order_by, sort: sort) }

    def expect_contributors(*contributors)
      expect(subject.map(&:email)).to eq(contributors.map(&:email))
    end

    it 'returns the array of Gitlab::Contributor for the repository' do
      expect_contributors(author_a, author_b, author_c)
    end

    context 'order_by email' do
      let(:order_by) { 'email' }

      context 'asc' do
        let(:sort) { 'asc' }

        it 'returns all the contributors ordered by email asc case insensitive' do
          expect_contributors(author_c, author_b, author_a)
        end
      end

      context 'desc' do
        let(:sort) { 'desc' }

        it 'returns all the contributors ordered by email desc case insensitive' do
          expect_contributors(author_a, author_b, author_c)
        end
      end
    end

    context 'order_by name' do
      let(:order_by) { 'name' }

      context 'asc' do
        let(:sort) { 'asc' }

        it 'returns all the contributors ordered by name asc case insensitive' do
          expect_contributors(author_c, author_a, author_b)
        end
      end

      context 'desc' do
        let(:sort) { 'desc' }

        it 'returns all the contributors ordered by name desc case insensitive' do
          expect_contributors(author_b, author_a, author_c)
        end
      end
    end

    context 'order_by commits' do
      let(:order_by) { 'commits' }

      context 'asc' do
        let(:sort) { 'asc' }

        it 'returns all the contributors ordered by commits asc' do
          expect_contributors(author_b, author_a, author_c)
        end
      end

      context 'desc' do
        let(:sort) { 'desc' }

        it 'returns all the contributors ordered by commits desc' do
          expect_contributors(author_c, author_a, author_b)
        end
      end
    end

    context 'invalid ordering' do
      let(:order_by) { 'unknown' }

      it 'returns the contributors unsorted' do
        expect_contributors(author_a, author_b, author_c)
      end
    end

    context 'invalid sorting' do
      let(:order_by) { 'name' }
      let(:sort) { 'unknown' }

      it 'returns the contributors unsorted' do
        expect_contributors(author_a, author_b, author_c)
      end
    end
  end
2544
end