repository_spec.rb 65.3 KB
Newer Older
1 2
require 'spec_helper'

3
describe Repository, models: true do
4
  include RepoHelpers
D
Douwe Maan 已提交
5
  TestBlob = Struct.new(:path)
6

7
  let(:project) { create(:project, :repository) }
8
  let(:repository) { project.repository }
9
  let(:broken_repository) { create(:project, :broken_storage).repository }
10
  let(:user) { create(:user) }
11
  let(:git_user) { Gitlab::Git::User.from_gitlab(user) }
12

13 14 15 16
  let(:commit_options) do
    author = repository.user_to_committer(user)
    { message: 'Test message', committer: author, author: author }
  end
17

R
Rubén Dávila 已提交
18
  let(:merge_commit) do
19
    merge_request = create(:merge_request, source_branch: 'feature', target_branch: 'master', source_project: project)
S
Sean McGivern 已提交
20 21 22 23 24 25

    merge_commit_id = repository.merge(user,
                                       merge_request.diff_head_sha,
                                       merge_request,
                                       commit_options)

26
    repository.commit(merge_commit_id)
27
  end
28

29 30
  let(:author_email) { 'user@example.org' }
  let(:author_name) { 'John Doe' }
31

32 33
  def expect_to_raise_storage_error
    expect { yield }.to raise_error do |exception|
34 35
      storage_exceptions = [Gitlab::Git::Storage::Inaccessible, Gitlab::Git::CommandError, GRPC::Unavailable]
      expect(exception.class).to be_in(storage_exceptions)
36 37 38
    end
  end

39
  describe '#branch_names_contains' do
40 41
    subject { repository.branch_names_contains(sample_commit.id) }

42 43 44
    it { is_expected.to include('master') }
    it { is_expected.not_to include('feature') }
    it { is_expected.not_to include('fix') }
45 46 47 48 49 50 51 52

    describe 'when storage is broken', broken_storage: true  do
      it 'should raise a storage error' do
        expect_to_raise_storage_error do
          broken_repository.branch_names_contains(sample_commit.id)
        end
      end
    end
53
  end
54

55
  describe '#tag_names_contains' do
D
Dmitriy Zaporozhets 已提交
56
    subject { repository.tag_names_contains(sample_commit.id) }
57

D
Dmitriy Zaporozhets 已提交
58 59
    it { is_expected.to include('v1.1.0') }
    it { is_expected.not_to include('v1.0.0') }
60 61
  end

62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79
  describe 'tags_sorted_by' do
    context 'name' do
      subject { repository.tags_sorted_by('name').map(&:name) }

      it { is_expected.to eq(['v1.1.0', 'v1.0.0']) }
    end

    context 'updated' do
      let(:tag_a) { repository.find_tag('v1.0.0') }
      let(:tag_b) { repository.find_tag('v1.1.0') }

      context 'desc' do
        subject { repository.tags_sorted_by('updated_desc').map(&:name) }

        before do
          double_first = double(committed_date: Time.now)
          double_last = double(committed_date: Time.now - 1.second)

80 81
          allow(tag_a).to receive(:dereferenced_target).and_return(double_first)
          allow(tag_b).to receive(:dereferenced_target).and_return(double_last)
82
          allow(repository).to receive(:tags).and_return([tag_a, tag_b])
83 84 85 86 87 88 89 90 91 92 93 94
        end

        it { is_expected.to eq(['v1.0.0', 'v1.1.0']) }
      end

      context 'asc' do
        subject { repository.tags_sorted_by('updated_asc').map(&:name) }

        before do
          double_first = double(committed_date: Time.now - 1.second)
          double_last = double(committed_date: Time.now)

95 96
          allow(tag_a).to receive(:dereferenced_target).and_return(double_last)
          allow(tag_b).to receive(:dereferenced_target).and_return(double_first)
97
          allow(repository).to receive(:tags).and_return([tag_a, tag_b])
98 99 100 101
        end

        it { is_expected.to eq(['v1.1.0', 'v1.0.0']) }
      end
102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125

      context 'annotated tag pointing to a blob' do
        let(:annotated_tag_name) { 'annotated-tag' }

        subject { repository.tags_sorted_by('updated_asc').map(&:name) }

        before do
          options = { message: 'test tag message\n',
                      tagger: { name: 'John Smith', email: 'john@gmail.com' } }
          repository.rugged.tags.create(annotated_tag_name, 'a48e4fc218069f68ef2e769dd8dfea3991362175', options)

          double_first = double(committed_date: Time.now - 1.second)
          double_last = double(committed_date: Time.now)

          allow(tag_a).to receive(:dereferenced_target).and_return(double_last)
          allow(tag_b).to receive(:dereferenced_target).and_return(double_first)
        end

        it { is_expected.to eq(['v1.1.0', 'v1.0.0', annotated_tag_name]) }

        after do
          repository.rugged.tags.delete(annotated_tag_name)
        end
      end
126 127 128
    end
  end

129
  describe '#ref_name_for_sha' do
130
    it 'returns the ref' do
131 132
      allow(repository.raw_repository).to receive(:ref_name_for_sha)
        .and_return('refs/environments/production/77')
133

134
      expect(repository.ref_name_for_sha('bla', '0' * 40)).to eq 'refs/environments/production/77'
135 136 137
    end
  end

138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157
  describe '#ref_exists?' do
    context 'when ref exists' do
      it 'returns true' do
        expect(repository.ref_exists?('refs/heads/master')).to be true
      end
    end

    context 'when ref does not exist' do
      it 'returns false' do
        expect(repository.ref_exists?('refs/heads/non-existent')).to be false
      end
    end

    context 'when ref format is incorrect' do
      it 'returns false' do
        expect(repository.ref_exists?('refs/heads/invalid:master')).to be false
      end
    end
  end

158
  describe '#last_commit_for_path' do
159 160
    shared_examples 'getting last commit for path' do
      subject { repository.last_commit_for_path(sample_commit.id, '.gitignore').id }
161

162
      it { is_expected.to eq('c1acaa58bbcbc3eafe538cb8274ba387047b69f8') }
163 164 165 166 167 168 169 170

      describe 'when storage is broken', broken_storage: true  do
        it 'should raise a storage error' do
          expect_to_raise_storage_error do
            broken_repository.last_commit_id_for_path(sample_commit.id, '.gitignore')
          end
        end
      end
171 172 173 174 175
    end

    context 'when Gitaly feature last_commit_for_path is enabled' do
      it_behaves_like 'getting last commit for path'
    end
176

177 178 179
    context 'when Gitaly feature last_commit_for_path is disabled', skip_gitaly_mock: true do
      it_behaves_like 'getting last commit for path'
    end
180
  end
181

H
Hiroyuki Sato 已提交
182
  describe '#last_commit_id_for_path' do
183 184
    shared_examples 'getting last commit ID for path' do
      subject { repository.last_commit_id_for_path(sample_commit.id, '.gitignore') }
H
Hiroyuki Sato 已提交
185

186 187 188 189 190 191 192 193 194 195 196
      it "returns last commit id for a given path" do
        is_expected.to eq('c1acaa58bbcbc3eafe538cb8274ba387047b69f8')
      end

      it "caches last commit id for a given path" do
        cache = repository.send(:cache)
        key = "last_commit_id_for_path:#{sample_commit.id}:#{Digest::SHA1.hexdigest('.gitignore')}"

        expect(cache).to receive(:fetch).with(key).and_return('c1acaa5')
        is_expected.to eq('c1acaa5')
      end
197 198 199 200 201 202 203 204

      describe 'when storage is broken', broken_storage: true  do
        it 'should raise a storage error' do
          expect_to_raise_storage_error do
            broken_repository.last_commit_for_path(sample_commit.id, '.gitignore').id
          end
        end
      end
H
Hiroyuki Sato 已提交
205
    end
H
Hiroyuki Sato 已提交
206

207 208 209
    context 'when Gitaly feature last_commit_for_path is enabled' do
      it_behaves_like 'getting last commit ID for path'
    end
210

211 212
    context 'when Gitaly feature last_commit_for_path is disabled', skip_gitaly_mock: true do
      it_behaves_like 'getting last commit ID for path'
H
Hiroyuki Sato 已提交
213 214 215
    end
  end

216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236
  describe '#commits' do
    it 'sets follow when path is a single path' do
      expect(Gitlab::Git::Commit).to receive(:where).with(a_hash_including(follow: true)).and_call_original.twice

      repository.commits('master', path: 'README.md')
      repository.commits('master', path: ['README.md'])
    end

    it 'does not set follow when path is multiple paths' do
      expect(Gitlab::Git::Commit).to receive(:where).with(a_hash_including(follow: false)).and_call_original

      repository.commits('master', path: ['README.md', 'CHANGELOG'])
    end

    it 'does not set follow when there are no paths' do
      expect(Gitlab::Git::Commit).to receive(:where).with(a_hash_including(follow: false)).and_call_original

      repository.commits('master')
    end
  end

237
  describe '#find_commits_by_message' do
238 239 240 241 242 243 244 245 246 247 248 249 250 251
    shared_examples 'finding commits by message' do
      it 'returns commits with messages containing a given string' do
        commit_ids = repository.find_commits_by_message('submodule').map(&:id)

        expect(commit_ids).to include(
          '5937ac0a7beb003549fc5fd26fc247adbce4a52e',
          '6f6d7e7ed97bb5f0054f2b1df789b39ca89b6ff9',
          'cfe32cf61b73a0d5e9f13e774abde7ff789b1660'
        )
        expect(commit_ids).not_to include('913c66a37b4a45b9769037c55c2d238bd0942d2e')
      end

      it 'is case insensitive' do
        commit_ids = repository.find_commits_by_message('SUBMODULE').map(&:id)
252

253 254
        expect(commit_ids).to include('5937ac0a7beb003549fc5fd26fc247adbce4a52e')
      end
255 256
    end

257 258 259
    context 'when Gitaly commits_by_message feature is enabled' do
      it_behaves_like 'finding commits by message'
    end
260

261 262
    context 'when Gitaly commits_by_message feature is disabled', skip_gitaly_mock: true do
      it_behaves_like 'finding commits by message'
263
    end
264 265 266 267 268 269

    describe 'when storage is broken', broken_storage: true  do
      it 'should raise a storage error' do
        expect_to_raise_storage_error { broken_repository.find_commits_by_message('s') }
      end
    end
270 271
  end

272
  describe '#blob_at' do
273 274 275 276 277 278
    context 'blank sha' do
      subject { repository.blob_at(Gitlab::Git::BLANK_SHA, '.gitignore') }

      it { is_expected.to be_nil }
    end
  end
279

280
  describe '#merged_to_root_ref?' do
281
    context 'merged branch without ff' do
282
      subject { repository.merged_to_root_ref?('branch-merged') }
F
Florent (HP) 已提交
283 284 285

      it { is_expected.to be_truthy }
    end
286

287 288
    # If the HEAD was ff then it will be false
    context 'merged with ff' do
F
Florent (HP) 已提交
289 290 291 292
      subject { repository.merged_to_root_ref?('improve/awesome') }

      it { is_expected.to be_truthy }
    end
293

294 295 296 297 298
    context 'not merged branch' do
      subject { repository.merged_to_root_ref?('not-merged-branch') }

      it { is_expected.to be_falsey }
    end
299 300 301 302 303 304

    context 'default branch' do
      subject { repository.merged_to_root_ref?('master') }

      it { is_expected.to be_falsey }
    end
305 306
  end

307
  describe '#can_be_merged?' do
308 309 310 311 312 313 314 315 316 317 318
    context 'mergeable branches' do
      subject { repository.can_be_merged?('0b4bc9a49b562e85de7cc9e834518ea6828729b9', 'master') }

      it { is_expected.to be_truthy }
    end

    context 'non-mergeable branches' do
      subject { repository.can_be_merged?('bb5206fee213d983da88c47f9cf4cc6caf9c66dc', 'feature') }

      it { is_expected.to be_falsey }
    end
F
Florent (HP) 已提交
319 320 321 322 323 324 325 326 327 328 329 330

    context 'non merged branch' do
      subject { repository.merged_to_root_ref?('fix') }

      it { is_expected.to be_falsey }
    end

    context 'non existent branch' do
      subject { repository.merged_to_root_ref?('non_existent_branch') }

      it { is_expected.to be_nil }
    end
331 332
  end

333 334 335
  describe '#commit' do
    context 'when ref exists' do
      it 'returns commit object' do
D
Douwe Maan 已提交
336 337
        expect(repository.commit('master'))
          .to be_an_instance_of Commit
338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361
      end
    end

    context 'when ref does not exist' do
      it 'returns nil' do
        expect(repository.commit('non-existent-ref')).to be_nil
      end
    end

    context 'when ref is not valid' do
      context 'when preceding tree element exists' do
        it 'returns nil' do
          expect(repository.commit('master:ref')).to be_nil
        end
      end

      context 'when preceding tree element does not exist' do
        it 'returns nil' do
          expect(repository.commit('non-existent:ref')).to be_nil
        end
      end
    end
  end

D
Douwe Maan 已提交
362
  describe "#create_dir" do
363 364
    it "commits a change that creates a new directory" do
      expect do
365
        repository.create_dir(user, 'newdir',
366
          message: 'Create newdir', branch_name: 'master')
367 368 369 370 371 372
      end.to change { repository.commits('master').count }.by(1)

      newdir = repository.tree('master', 'newdir')
      expect(newdir.path).to eq('newdir')
    end

373
    context "when committing to another project" do
374
      let(:forked_project) { create(:project, :repository) }
375 376 377

      it "creates a fork and commit to the forked project" do
        expect do
378
          repository.create_dir(user, 'newdir',
379
            message: 'Create newdir', branch_name: 'patch',
L
Lin Jen-Shin 已提交
380
            start_branch_name: 'master', start_project: forked_project)
381 382 383 384 385 386 387 388 389 390
        end.to change { repository.commits('master').count }.by(0)

        expect(repository.branch_exists?('patch')).to be_truthy
        expect(forked_project.repository.branch_exists?('patch')).to be_falsy

        newdir = repository.tree('patch', 'newdir')
        expect(newdir.path).to eq('newdir')
      end
    end

391 392 393
    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
        expect do
394
          repository.create_dir(user, 'newdir',
395 396 397
            message: 'Add newdir',
            branch_name: 'master',
            author_email: author_email, author_name: author_name)
398 399 400 401 402 403 404 405 406 407
        end.to change { repository.commits('master').count }.by(1)

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
  end

408 409
  describe "#create_file" do
    it 'commits new file successfully' do
410
      expect do
411 412 413
        repository.create_file(user, 'NEWCHANGELOG', 'Changelog!',
                               message: 'Create changelog',
                               branch_name: 'master')
414 415
      end.to change { repository.commits('master').count }.by(1)

416
      blob = repository.blob_at('master', 'NEWCHANGELOG')
417

418
      expect(blob.data).to eq('Changelog!')
419
    end
420

421
    it 'creates new file and dir when file_path has a forward slash' do
422
      expect do
423 424
        repository.create_file(user, 'new_dir/new_file.txt', 'File!',
                               message: 'Create new_file with new_dir',
425 426 427
                               branch_name: 'master')
      end.to change { repository.commits('master').count }.by(1)

428 429
      expect(repository.tree('master', 'new_dir').path).to eq('new_dir')
      expect(repository.blob_at('master', 'new_dir/new_file.txt').data).to eq('File!')
430 431
    end

432
    it 'respects the autocrlf setting' do
433
      repository.create_file(user, 'hello.txt', "Hello,\r\nWorld",
434
                             message: 'Add hello world',
435
                             branch_name: 'master')
436 437 438 439 440 441

      blob = repository.blob_at('master', 'hello.txt')

      expect(blob.data).to eq("Hello,\nWorld")
    end

442 443 444
    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
        expect do
445
          repository.create_file(user, 'NEWREADME', 'README!',
446 447 448 449
                                 message: 'Add README',
                                 branch_name: 'master',
                                 author_email: author_email,
                                 author_name: author_name)
450 451 452 453 454 455 456 457
        end.to change { repository.commits('master').count }.by(1)

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
458 459
  end

460
  describe "#update_file" do
461 462 463 464 465 466 467 468 469 470 471 472
    it 'updates file successfully' do
      expect do
        repository.update_file(user, 'CHANGELOG', 'Changelog!',
                               message: 'Update changelog',
                               branch_name: 'master')
      end.to change { repository.commits('master').count }.by(1)

      blob = repository.blob_at('master', 'CHANGELOG')

      expect(blob.data).to eq('Changelog!')
    end

T
tiagonbotelho 已提交
473
    it 'updates filename successfully' do
474 475
      expect do
        repository.update_file(user, 'NEWLICENSE', 'Copyright!',
476
                                     branch_name: 'master',
T
tiagonbotelho 已提交
477
                                     previous_path: 'LICENSE',
478 479
                                     message: 'Changes filename')
      end.to change { repository.commits('master').count }.by(1)
T
tiagonbotelho 已提交
480 481 482 483 484 485

      files = repository.ls_files('master')

      expect(files).not_to include('LICENSE')
      expect(files).to include('NEWLICENSE')
    end
486 487 488 489

    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
        expect do
490 491 492 493 494 495
          repository.update_file(user, 'README', 'Updated README!',
                                 branch_name: 'master',
                                 previous_path: 'README',
                                 message: 'Update README',
                                 author_email: author_email,
                                 author_name: author_name)
496 497 498 499 500 501 502 503 504 505
        end.to change { repository.commits('master').count }.by(1)

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
  end

D
Douwe Maan 已提交
506
  describe "#delete_file" do
507 508
    it 'removes file successfully' do
      expect do
509
        repository.delete_file(user, 'README',
510
          message: 'Remove README', branch_name: 'master')
511 512 513 514 515 516 517 518
      end.to change { repository.commits('master').count }.by(1)

      expect(repository.blob_at('master', 'README')).to be_nil
    end

    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
        expect do
519
          repository.delete_file(user, 'README',
520 521
            message: 'Remove README', branch_name: 'master',
            author_email: author_email, author_name: author_name)
522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561
        end.to change { repository.commits('master').count }.by(1)

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
  end

  describe '#get_committer_and_author' do
    it 'returns the committer and author data' do
      options = repository.get_committer_and_author(user)
      expect(options[:committer][:email]).to eq(user.email)
      expect(options[:author][:email]).to eq(user.email)
    end

    context 'when the email/name are given' do
      it 'returns an object containing the email/name' do
        options = repository.get_committer_and_author(user, email: author_email, name: author_name)
        expect(options[:author][:email]).to eq(author_email)
        expect(options[:author][:name]).to eq(author_name)
      end
    end

    context 'when the email is given but the name is not' do
      it 'returns the committer as the author' do
        options = repository.get_committer_and_author(user, email: author_email)
        expect(options[:author][:email]).to eq(user.email)
        expect(options[:author][:name]).to eq(user.name)
      end
    end

    context 'when the name is given but the email is not' do
      it 'returns nil' do
        options = repository.get_committer_and_author(user, name: author_name)
        expect(options[:author][:email]).to eq(user.email)
        expect(options[:author][:name]).to eq(user.name)
      end
    end
T
tiagonbotelho 已提交
562 563
  end

V
Valery Sizov 已提交
564 565
  describe "search_files_by_content" do
    let(:results) { repository.search_files_by_content('feature', 'master') }
566 567 568 569
    subject { results }

    it { is_expected.to be_an Array }

570
    it 'regex-escapes the query string' do
V
Valery Sizov 已提交
571
      results = repository.search_files_by_content("test\\", 'master')
572 573 574 575

      expect(results.first).not_to start_with('fatal:')
    end

576
    it 'properly handles an unmatched parenthesis' do
V
Valery Sizov 已提交
577
      results = repository.search_files_by_content("test(", 'master')
578 579 580 581

      expect(results.first).not_to start_with('fatal:')
    end

V
Valery Sizov 已提交
582
    it 'properly handles when query is not present' do
V
Valery Sizov 已提交
583
      results = repository.search_files_by_content('', 'master')
V
Valery Sizov 已提交
584 585 586 587 588

      expect(results).to match_array([])
    end

    it 'properly handles query when repo is empty' do
589
      repository = create(:project).repository
V
Valery Sizov 已提交
590
      results = repository.search_files_by_content('test', 'master')
V
Valery Sizov 已提交
591 592 593 594

      expect(results).to match_array([])
    end

595 596 597 598 599 600 601 602
    describe 'when storage is broken', broken_storage: true  do
      it 'should raise a storage error' do
        expect_to_raise_storage_error do
          broken_repository.search_files_by_content('feature', 'master')
        end
      end
    end

603 604 605 606
    describe 'result' do
      subject { results.first }

      it { is_expected.to be_an String }
607
      it { expect(subject.lines[2]).to eq("master:CHANGELOG:190:  - Feature: Replace teams with group membership\n") }
608 609
    end
  end
Z
Zeger-Jan van de Weg 已提交
610

V
Valery Sizov 已提交
611 612 613 614 615 616 617 618 619 620 621 622 623 624
  describe "search_files_by_name" do
    let(:results) { repository.search_files_by_name('files', 'master') }

    it 'returns result' do
      expect(results.first).to eq('files/html/500.html')
    end

    it 'properly handles when query is not present' do
      results = repository.search_files_by_name('', 'master')

      expect(results).to match_array([])
    end

    it 'properly handles query when repo is empty' do
625
      repository = create(:project).repository
V
Valery Sizov 已提交
626 627 628 629 630

      results = repository.search_files_by_name('test', 'master')

      expect(results).to match_array([])
    end
631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646

    describe 'when storage is broken', broken_storage: true  do
      it 'should raise a storage error' do
        expect_to_raise_storage_error { broken_repository.search_files_by_name('files', 'master') }
      end
    end
  end

  describe '#fetch_ref' do
    describe 'when storage is broken', broken_storage: true  do
      it 'should raise a storage error' do
        path = broken_repository.path_to_repo

        expect_to_raise_storage_error { broken_repository.fetch_ref(path, '1', '2') }
      end
    end
V
Valery Sizov 已提交
647 648
  end

649 650 651 652 653 654 655 656 657 658
  describe '#create_ref' do
    it 'redirects the call to fetch_ref' do
      ref, ref_path = '1', '2'

      expect(repository).to receive(:fetch_ref).with(repository.path_to_repo, ref, ref_path)

      repository.create_ref(ref, ref_path)
    end
  end

659
  describe "#changelog", :use_clean_rails_memory_store_caching do
660 661 662
    it 'accepts changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('changelog')])

D
Douwe Maan 已提交
663
      expect(repository.changelog.path).to eq('changelog')
664 665 666 667 668
    end

    it 'accepts news instead of changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('news')])

D
Douwe Maan 已提交
669
      expect(repository.changelog.path).to eq('news')
670 671 672 673 674
    end

    it 'accepts history instead of changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('history')])

D
Douwe Maan 已提交
675
      expect(repository.changelog.path).to eq('history')
676 677 678 679 680
    end

    it 'accepts changes instead of changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('changes')])

D
Douwe Maan 已提交
681
      expect(repository.changelog.path).to eq('changes')
682 683 684 685 686
    end

    it 'is case-insensitive' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('CHANGELOG')])

D
Douwe Maan 已提交
687
      expect(repository.changelog.path).to eq('CHANGELOG')
688 689 690
    end
  end

691
  describe "#license_blob", :use_clean_rails_memory_store_caching do
692
    before do
693
      repository.delete_file(
694
        user, 'LICENSE', message: 'Remove LICENSE', branch_name: 'master')
695 696
    end

697
    it 'handles when HEAD points to non-existent ref' do
698
      repository.create_file(
699
        user, 'LICENSE', 'Copyright!',
700
        message: 'Add LICENSE', branch_name: 'master')
701

702 703
      allow(repository).to receive(:file_on_head)
        .and_raise(Rugged::ReferenceError)
704 705 706 707

      expect(repository.license_blob).to be_nil
    end

708
    it 'looks in the root_ref only' do
709
      repository.delete_file(user, 'LICENSE',
710
        message: 'Remove LICENSE', branch_name: 'markdown')
711
      repository.create_file(user, 'LICENSE',
712
        Licensee::License.new('mit').content,
713
        message: 'Add LICENSE', branch_name: 'markdown')
714 715 716 717

      expect(repository.license_blob).to be_nil
    end

718
    it 'detects license file with no recognizable open-source license content' do
719 720
      repository.create_file(user, 'LICENSE', 'Copyright!',
        message: 'Add LICENSE', branch_name: 'master')
721

D
Douwe Maan 已提交
722
      expect(repository.license_blob.path).to eq('LICENSE')
723 724
    end

725 726
    %w[LICENSE LICENCE LiCensE LICENSE.md LICENSE.foo COPYING COPYING.md].each do |filename|
      it "detects '#{filename}'" do
727
        repository.create_file(user, filename,
728
          Licensee::License.new('mit').content,
729
          message: "Add #{filename}", branch_name: 'master')
730

731 732
        expect(repository.license_blob.name).to eq(filename)
      end
733 734 735
    end
  end

736
  describe '#license_key', :use_clean_rails_memory_store_caching do
737
    before do
738
      repository.delete_file(user, 'LICENSE',
739
        message: 'Remove LICENSE', branch_name: 'master')
740
    end
Z
Zeger-Jan van de Weg 已提交
741

742
    it 'returns nil when no license is detected' do
743 744 745
      expect(repository.license_key).to be_nil
    end

746 747 748
    it 'returns nil when the repository does not exist' do
      expect(repository).to receive(:exists?).and_return(false)

749 750 751
      expect(repository.license_key).to be_nil
    end

D
Douwe Maan 已提交
752
    it 'returns nil when the content is not recognizable' do
753 754
      repository.create_file(user, 'LICENSE', 'Copyright!',
        message: 'Add LICENSE', branch_name: 'master')
755 756

      expect(repository.license_key).to be_nil
Z
Zeger-Jan van de Weg 已提交
757
    end
758

759
    it 'returns the license key' do
760
      repository.create_file(user, 'LICENSE',
761
        Licensee::License.new('mit').content,
762
        message: 'Add LICENSE', branch_name: 'master')
763

764
      expect(repository.license_key).to eq('mit')
765
    end
Z
Zeger-Jan van de Weg 已提交
766
  end
767

D
Douwe Maan 已提交
768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800
  describe '#license' do
    before do
      repository.delete_file(user, 'LICENSE',
        message: 'Remove LICENSE', branch_name: 'master')
    end

    it 'returns nil when no license is detected' do
      expect(repository.license).to be_nil
    end

    it 'returns nil when the repository does not exist' do
      expect(repository).to receive(:exists?).and_return(false)

      expect(repository.license).to be_nil
    end

    it 'returns nil when the content is not recognizable' do
      repository.create_file(user, 'LICENSE', 'Copyright!',
        message: 'Add LICENSE', branch_name: 'master')

      expect(repository.license).to be_nil
    end

    it 'returns the license' do
      license = Licensee::License.new('mit')
      repository.create_file(user, 'LICENSE',
        license.content,
        message: 'Add LICENSE', branch_name: 'master')

      expect(repository.license).to eq(license)
    end
  end

801
  describe "#gitlab_ci_yml", :use_clean_rails_memory_store_caching do
802 803 804 805
    it 'returns valid file' do
      files = [TestBlob.new('file'), TestBlob.new('.gitlab-ci.yml'), TestBlob.new('copying')]
      expect(repository.tree).to receive(:blobs).and_return(files)

D
Douwe Maan 已提交
806
      expect(repository.gitlab_ci_yml.path).to eq('.gitlab-ci.yml')
807 808 809 810 811 812 813 814
    end

    it 'returns nil if not exists' do
      expect(repository.tree).to receive(:blobs).and_return([])
      expect(repository.gitlab_ci_yml).to be_nil
    end

    it 'returns nil for empty repository' do
815
      allow(repository).to receive(:file_on_head).and_raise(Rugged::ReferenceError)
816 817 818 819
      expect(repository.gitlab_ci_yml).to be_nil
    end
  end

820
  describe '#add_branch' do
821
    context 'when pre hooks were successful' do
822
      it 'runs without errors' do
823
        hook = double(trigger: [true, nil])
824
        expect(Gitlab::Git::Hook).to receive(:new).exactly(3).times.and_return(hook)
825 826 827 828

        expect { repository.add_branch(user, 'new_feature', 'master') }.not_to raise_error
      end

829
      it 'creates the branch' do
830
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([true, nil])
831 832 833 834 835

        branch = repository.add_branch(user, 'new_feature', 'master')

        expect(branch.name).to eq('new_feature')
      end
836 837 838 839 840 841

      it 'calls the after_create_branch hook' do
        expect(repository).to receive(:after_create_branch)

        repository.add_branch(user, 'new_feature', 'master')
      end
842 843 844
    end

    context 'when pre hooks failed' do
845
      it 'gets an error' do
846
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([false, ''])
847 848 849

        expect do
          repository.add_branch(user, 'new_feature', 'master')
850
        end.to raise_error(Gitlab::Git::HooksService::PreReceiveError)
851 852
      end

853
      it 'does not create the branch' do
854
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([false, ''])
855 856 857

        expect do
          repository.add_branch(user, 'new_feature', 'master')
858
        end.to raise_error(Gitlab::Git::HooksService::PreReceiveError)
859 860 861 862 863
        expect(repository.find_branch('new_feature')).to be_nil
      end
    end
  end

864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881
  describe '#find_branch' do
    it 'loads a branch with a fresh repo' do
      expect(Gitlab::Git::Repository).to receive(:new).twice.and_call_original

      2.times do
        expect(repository.find_branch('feature')).not_to be_nil
      end
    end

    it 'loads a branch with a cached repo' do
      expect(Gitlab::Git::Repository).to receive(:new).once.and_call_original

      2.times do
        expect(repository.find_branch('feature', fresh_repo: false)).not_to be_nil
      end
    end
  end

882
  describe '#rm_branch' do
883 884 885
    let(:old_rev) { '0b4bc9a49b562e85de7cc9e834518ea6828729b9' } # git rev-parse feature
    let(:blank_sha) { '0000000000000000000000000000000000000000' }

886
    context 'when pre hooks were successful' do
887
      it 'runs without errors' do
888
        expect_any_instance_of(Gitlab::Git::HooksService).to receive(:execute)
889
          .with(git_user, repository.raw_repository, old_rev, blank_sha, 'refs/heads/feature')
890 891 892 893

        expect { repository.rm_branch(user, 'feature') }.not_to raise_error
      end

894
      it 'deletes the branch' do
895
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([true, nil])
896 897 898 899 900 901 902 903

        expect { repository.rm_branch(user, 'feature') }.not_to raise_error

        expect(repository.find_branch('feature')).to be_nil
      end
    end

    context 'when pre hooks failed' do
904
      it 'gets an error' do
905
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([false, ''])
906 907

        expect do
908
          repository.rm_branch(user, 'feature')
909
        end.to raise_error(Gitlab::Git::HooksService::PreReceiveError)
910 911
      end

912
      it 'does not delete the branch' do
913
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([false, ''])
914 915 916

        expect do
          repository.rm_branch(user, 'feature')
917
        end.to raise_error(Gitlab::Git::HooksService::PreReceiveError)
918 919 920 921 922
        expect(repository.find_branch('feature')).not_to be_nil
      end
    end
  end

923
  describe '#update_branch_with_hooks' do
924
    let(:old_rev) { '0b4bc9a49b562e85de7cc9e834518ea6828729b9' } # git rev-parse feature
925
    let(:new_rev) { 'a74ae73c1ccde9b974a70e82b901588071dc142a' } # commit whose parent is old_rev
926 927 928
    let(:updating_ref) { 'refs/heads/feature' }
    let(:target_project) { project }
    let(:target_repository) { target_project.repository }
929

930
    context 'when pre hooks were successful' do
931
      before do
932 933
        service = Gitlab::Git::HooksService.new
        expect(Gitlab::Git::HooksService).to receive(:new).and_return(service)
934
        expect(service).to receive(:execute)
935
          .with(git_user, target_repository.raw_repository, old_rev, new_rev, updating_ref)
936
          .and_yield(service).and_return(true)
937
      end
938

939
      it 'runs without errors' do
940
        expect do
941
          Gitlab::Git::OperationService.new(git_user, repository.raw_repository).with_branch('feature') do
942 943
            new_rev
          end
944 945
        end.not_to raise_error
      end
946

947
      it 'ensures the autocrlf Git option is set to :input' do
948
        service = Gitlab::Git::OperationService.new(git_user, repository.raw_repository)
949 950

        expect(service).to receive(:update_autocrlf_option)
951

952
        service.with_branch('feature') { new_rev }
953
      end
954 955 956

      context "when the branch wasn't empty" do
        it 'updates the head' do
957
          expect(repository.find_branch('feature').dereferenced_target.id).to eq(old_rev)
958

959
          Gitlab::Git::OperationService.new(git_user, repository.raw_repository).with_branch('feature') do
960 961 962
            new_rev
          end

963
          expect(repository.find_branch('feature').dereferenced_target.id).to eq(new_rev)
964 965
        end
      end
966 967 968 969 970 971 972 973

      context 'when target project does not have the commit' do
        let(:target_project) { create(:project, :empty_repo) }
        let(:old_rev) { Gitlab::Git::BLANK_SHA }
        let(:new_rev) { project.commit('feature').sha }
        let(:updating_ref) { 'refs/heads/master' }

        it 'fetch_ref and create the branch' do
974
          expect(target_project.repository.raw_repository).to receive(:fetch_ref)
975 976
            .and_call_original

977
          Gitlab::Git::OperationService.new(git_user, target_repository.raw_repository)
978 979
            .with_branch(
              'master',
980
              start_repository: project.repository.raw_repository,
981 982 983 984 985 986 987 988 989 990 991 992
              start_branch_name: 'feature') { new_rev }

          expect(target_repository.branch_names).to contain_exactly('master')
        end
      end

      context 'when target project already has the commit' do
        let(:target_project) { create(:project, :repository) }

        it 'does not fetch_ref and just pass the commit' do
          expect(target_repository).not_to receive(:fetch_ref)

993
          Gitlab::Git::OperationService.new(git_user, target_repository.raw_repository)
994
            .with_branch('feature', start_repository: project.repository.raw_repository) { new_rev }
995 996
        end
      end
997 998
    end

999 1000 1001 1002
    context 'when temporary ref failed to be created from other project' do
      let(:target_project) { create(:project, :empty_repo) }

      before do
1003
        expect(target_project.repository.raw_repository).to receive(:run_git)
1004 1005 1006 1007 1008 1009 1010 1011
      end

      it 'raises Rugged::ReferenceError' do
        raise_reference_error = raise_error(Rugged::ReferenceError) do |err|
          expect(err.cause).to be_nil
        end

        expect do
1012
          Gitlab::Git::OperationService.new(git_user, target_project.repository.raw_repository)
1013
            .with_branch('feature',
1014
                         start_repository: project.repository.raw_repository,
1015 1016 1017 1018 1019
                         &:itself)
        end.to raise_reference_error
      end
    end

1020
    context 'when the update adds more than one commit' do
1021
      let(:old_rev) { '33f3729a45c02fc67d00adb1b8bca394b0e761d9' }
1022

1023
      it 'runs without errors' do
1024 1025 1026 1027 1028 1029
        # old_rev is an ancestor of new_rev
        expect(repository.rugged.merge_base(old_rev, new_rev)).to eq(old_rev)

        # old_rev is not a direct ancestor (parent) of new_rev
        expect(repository.rugged.lookup(new_rev).parent_ids).not_to include(old_rev)

1030 1031 1032
        branch = 'feature-ff-target'
        repository.add_branch(user, branch, old_rev)

1033
        expect do
1034
          Gitlab::Git::OperationService.new(git_user, repository.raw_repository).with_branch(branch) do
1035 1036 1037
            new_rev
          end
        end.not_to raise_error
1038 1039 1040 1041
      end
    end

    context 'when the update would remove commits from the target branch' do
1042 1043
      let(:branch) { 'master' }
      let(:old_rev) { repository.find_branch(branch).dereferenced_target.sha }
1044

1045
      it 'raises an exception' do
1046 1047 1048 1049 1050 1051
        # The 'master' branch is NOT an ancestor of new_rev.
        expect(repository.rugged.merge_base(old_rev, new_rev)).not_to eq(old_rev)

        # Updating 'master' to new_rev would lose the commits on 'master' that
        # are not contained in new_rev. This should not be allowed.
        expect do
1052
          Gitlab::Git::OperationService.new(git_user, repository.raw_repository).with_branch(branch) do
1053 1054
            new_rev
          end
1055
        end.to raise_error(Gitlab::Git::CommitError)
1056 1057 1058
      end
    end

1059
    context 'when pre hooks failed' do
1060
      it 'gets an error' do
1061
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([false, ''])
1062 1063

        expect do
1064
          Gitlab::Git::OperationService.new(git_user, repository.raw_repository).with_branch('feature') do
1065 1066
            new_rev
          end
1067
        end.to raise_error(Gitlab::Git::HooksService::PreReceiveError)
1068 1069
      end
    end
1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081

    context 'when target branch is different from source branch' do
      before do
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([true, ''])
      end

      it 'expires branch cache' do
        expect(repository).not_to receive(:expire_exists_cache)
        expect(repository).not_to receive(:expire_root_ref_cache)
        expect(repository).not_to receive(:expire_emptiness_caches)
        expect(repository).to     receive(:expire_branches_cache)

J
Jacob Vosmaer 已提交
1082
        repository.with_branch(user, 'new-feature') do
J
Jacob Vosmaer 已提交
1083
          new_rev
J
Jacob Vosmaer 已提交
1084
        end
1085 1086 1087 1088 1089 1090 1091 1092 1093
      end
    end

    context 'when repository is empty' do
      before do
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([true, ''])
      end

      it 'expires creation and branch cache' do
1094
        empty_repository = create(:project, :empty_repo).repository
1095 1096 1097 1098 1099 1100

        expect(empty_repository).to receive(:expire_exists_cache)
        expect(empty_repository).to receive(:expire_root_ref_cache)
        expect(empty_repository).to receive(:expire_emptiness_caches)
        expect(empty_repository).to receive(:expire_branches_cache)

1101
        empty_repository.create_file(user, 'CHANGELOG', 'Changelog!',
1102
                                     message: 'Updates file content',
1103
                                     branch_name: 'master')
1104 1105
      end
    end
1106
  end
1107

1108
  shared_examples 'repo exists check' do
1109 1110 1111 1112
    it 'returns true when a repository exists' do
      expect(repository.exists?).to eq(true)
    end

1113
    it 'returns false if no full path can be constructed' do
1114
      allow(repository).to receive(:full_path).and_return(nil)
1115 1116 1117

      expect(repository.exists?).to eq(false)
    end
1118 1119 1120 1121 1122 1123

    context 'with broken storage', broken_storage: true do
      it 'should raise a storage error' do
        expect_to_raise_storage_error { broken_repository.exists? }
      end
    end
1124
  end
1125

1126 1127 1128 1129
  describe '#exists?' do
    context 'when repository_exists is disabled' do
      it_behaves_like 'repo exists check'
    end
1130

1131 1132
    context 'when repository_exists is enabled', skip_gitaly_mock: true do
      it_behaves_like 'repo exists check'
1133
    end
1134 1135
  end

1136 1137 1138 1139 1140
  describe '#has_visible_content?' do
    subject { repository.has_visible_content? }

    describe 'when there are no branches' do
      before do
1141
        allow(repository.raw_repository).to receive(:branch_count).and_return(0)
1142 1143 1144 1145 1146 1147
      end

      it { is_expected.to eq(false) }
    end

    describe 'when there are branches' do
1148
      it 'returns true' do
1149
        expect(repository.raw_repository).to receive(:branch_count).and_return(3)
1150 1151 1152 1153 1154 1155

        expect(subject).to eq(true)
      end
    end
  end

1156 1157 1158 1159 1160 1161 1162
  describe '#update_autocrlf_option' do
    describe 'when autocrlf is not already set to :input' do
      before do
        repository.raw_repository.autocrlf = true
      end

      it 'sets autocrlf to :input' do
1163
        Gitlab::Git::OperationService.new(nil, repository.raw_repository).send(:update_autocrlf_option)
1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174

        expect(repository.raw_repository.autocrlf).to eq(:input)
      end
    end

    describe 'when autocrlf is already set to :input' do
      before do
        repository.raw_repository.autocrlf = :input
      end

      it 'does nothing' do
1175 1176
        expect(repository.raw_repository).not_to receive(:autocrlf=)
          .with(:input)
1177

1178
        Gitlab::Git::OperationService.new(nil, repository.raw_repository).send(:update_autocrlf_option)
1179 1180 1181 1182
      end
    end
  end

1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194
  describe '#empty?' do
    let(:empty_repository) { create(:project_empty_repo).repository }

    it 'returns true for an empty repository' do
      expect(empty_repository.empty?).to eq(true)
    end

    it 'returns false for a non-empty repository' do
      expect(repository.empty?).to eq(false)
    end

    it 'caches the output' do
1195 1196 1197
      expect(repository.raw_repository).to receive(:empty?)
        .once
        .and_return(false)
1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209

      repository.empty?
      repository.empty?
    end
  end

  describe '#root_ref' do
    it 'returns a branch name' do
      expect(repository.root_ref).to be_an_instance_of(String)
    end

    it 'caches the output' do
1210 1211 1212
      expect(repository.raw_repository).to receive(:root_ref)
        .once
        .and_return('master')
1213 1214 1215 1216 1217 1218 1219 1220 1221 1222

      repository.root_ref
      repository.root_ref
    end
  end

  describe '#expire_root_ref_cache' do
    it 'expires the root reference cache' do
      repository.root_ref

1223 1224 1225
      expect(repository.raw_repository).to receive(:root_ref)
        .once
        .and_return('foo')
1226 1227 1228 1229 1230 1231 1232

      repository.expire_root_ref_cache

      expect(repository.root_ref).to eq('foo')
    end
  end

Y
Yorick Peterse 已提交
1233
  describe '#expire_branch_cache' do
1234 1235 1236 1237 1238
    # This method is private but we need it for testing purposes. Sadly there's
    # no other proper way of testing caching operations.
    let(:cache) { repository.send(:cache) }

    it 'expires the cache for all branches' do
1239 1240 1241
      expect(cache).to receive(:expire)
        .at_least(repository.branches.length * 2)
        .times
1242 1243 1244 1245 1246

      repository.expire_branch_cache
    end

    it 'expires the cache for all branches when the root branch is given' do
1247 1248 1249
      expect(cache).to receive(:expire)
        .at_least(repository.branches.length * 2)
        .times
1250 1251 1252 1253 1254

      repository.expire_branch_cache(repository.root_ref)
    end

    it 'expires the cache for a specific branch' do
1255
      expect(cache).to receive(:expire).twice
1256 1257 1258 1259

      repository.expire_branch_cache('foo')
    end
  end
1260

1261 1262 1263
  describe '#expire_emptiness_caches' do
    let(:cache) { repository.send(:cache) }

1264 1265 1266
    it 'expires the caches for an empty repository' do
      allow(repository).to receive(:empty?).and_return(true)

1267 1268 1269 1270
      expect(cache).to receive(:expire).with(:empty?)

      repository.expire_emptiness_caches
    end
1271 1272 1273 1274 1275 1276 1277 1278

    it 'does not expire the cache for a non-empty repository' do
      allow(repository).to receive(:empty?).and_return(false)

      expect(cache).not_to receive(:expire).with(:empty?)

      repository.expire_emptiness_caches
    end
1279 1280
  end

1281
  describe 'skip_merges option' do
1282
    subject { repository.commits(Gitlab::Git::BRANCH_REF_PREFIX + "'test'", limit: 100, skip_merges: true).map { |k| k.id } }
1283 1284 1285

    it { is_expected.not_to include('e56497bb5f03a90a51293fc6d516788730953899') }
  end
1286 1287

  describe '#merge' do
1288 1289 1290 1291 1292 1293 1294 1295
    let(:merge_request) { create(:merge_request, source_branch: 'feature', target_branch: 'master', source_project: project) }

    let(:commit_options) do
      author = repository.user_to_committer(user)
      { message: 'Test \r\n\r\n message', committer: author, author: author }
    end

    it 'merges the code and returns the commit id' do
R
Rubén Dávila 已提交
1296 1297
      expect(merge_commit).to be_present
      expect(repository.blob_at(merge_commit.id, 'files/ruby/feature.rb')).to be_present
1298
    end
1299 1300

    it 'sets the `in_progress_merge_commit_sha` flag for the given merge request' do
1301
      merge_commit_id = merge(repository, user, merge_request, commit_options)
1302 1303 1304

      expect(merge_request.in_progress_merge_commit_sha).to eq(merge_commit_id)
    end
1305 1306 1307 1308 1309 1310 1311 1312 1313 1314

    it 'removes carriage returns from commit message' do
      merge_commit_id = merge(repository, user, merge_request, commit_options)

      expect(repository.commit(merge_commit_id).message).to eq(commit_options[:message].delete("\r"))
    end

    def merge(repository, user, merge_request, options = {})
      repository.merge(user, merge_request.diff_head_sha, merge_request, options)
    end
1315 1316
  end

1317 1318 1319
  describe '#revert' do
    let(:new_image_commit) { repository.commit('33f3729a45c02fc67d00adb1b8bca394b0e761d9') }
    let(:update_image_commit) { repository.commit('2f63565e7aac07bcdadb654e253078b727143ec4') }
1320

1321
    context 'when there is a conflict' do
1322 1323
      it 'raises an error' do
        expect { repository.revert(user, new_image_commit, 'master') }.to raise_error(/Failed to/)
1324 1325 1326 1327
      end
    end

    context 'when commit was already reverted' do
1328
      it 'raises an error' do
1329 1330
        repository.revert(user, update_image_commit, 'master')

1331
        expect { repository.revert(user, update_image_commit, 'master') }.to raise_error(/Failed to/)
1332 1333 1334 1335
      end
    end

    context 'when commit can be reverted' do
1336
      it 'reverts the changes' do
1337 1338 1339 1340 1341
        expect(repository.revert(user, update_image_commit, 'master')).to be_truthy
      end
    end

    context 'reverting a merge commit' do
1342
      it 'reverts the changes' do
1343 1344 1345 1346 1347 1348
        merge_commit
        expect(repository.blob_at_branch('master', 'files/ruby/feature.rb')).to be_present

        repository.revert(user, merge_commit, 'master')
        expect(repository.blob_at_branch('master', 'files/ruby/feature.rb')).not_to be_present
      end
1349 1350
    end
  end
1351

P
P.S.V.R 已提交
1352 1353 1354 1355 1356 1357
  describe '#cherry_pick' do
    let(:conflict_commit) { repository.commit('c642fe9b8b9f28f9225d7ea953fe14e74748d53b') }
    let(:pickable_commit) { repository.commit('7d3b0f7cff5f37573aea97cebfd5692ea1689924') }
    let(:pickable_merge) { repository.commit('e56497bb5f03a90a51293fc6d516788730953899') }

    context 'when there is a conflict' do
1358 1359
      it 'raises an error' do
        expect { repository.cherry_pick(user, conflict_commit, 'master') }.to raise_error(/Failed to/)
P
P.S.V.R 已提交
1360 1361 1362 1363
      end
    end

    context 'when commit was already cherry-picked' do
1364
      it 'raises an error' do
P
P.S.V.R 已提交
1365 1366
        repository.cherry_pick(user, pickable_commit, 'master')

1367
        expect { repository.cherry_pick(user, pickable_commit, 'master') }.to raise_error(/Failed to/)
P
P.S.V.R 已提交
1368 1369 1370 1371
      end
    end

    context 'when commit can be cherry-picked' do
1372
      it 'cherry-picks the changes' do
P
P.S.V.R 已提交
1373 1374 1375 1376 1377
        expect(repository.cherry_pick(user, pickable_commit, 'master')).to be_truthy
      end
    end

    context 'cherry-picking a merge commit' do
1378
      it 'cherry-picks the changes' do
1379
        expect(repository.blob_at_branch('improve/awesome', 'foo/bar/.gitkeep')).to be_nil
P
P.S.V.R 已提交
1380

1381 1382 1383
        cherry_pick_commit_sha = repository.cherry_pick(user, pickable_merge, 'improve/awesome')
        cherry_pick_commit_message = project.commit(cherry_pick_commit_sha).message

1384
        expect(repository.blob_at_branch('improve/awesome', 'foo/bar/.gitkeep')).not_to be_nil
1385
        expect(cherry_pick_commit_message).to include('cherry picked from')
P
P.S.V.R 已提交
1386 1387 1388 1389
      end
    end
  end

1390 1391 1392 1393 1394 1395 1396
  describe '#before_delete' do
    describe 'when a repository does not exist' do
      before do
        allow(repository).to receive(:exists?).and_return(false)
      end

      it 'does not flush caches that depend on repository data' do
1397
        expect(repository).not_to receive(:expire_cache)
1398 1399 1400 1401

        repository.before_delete
      end

1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413
      it 'flushes the tags cache' do
        expect(repository).to receive(:expire_tags_cache)

        repository.before_delete
      end

      it 'flushes the branches cache' do
        expect(repository).to receive(:expire_branches_cache)

        repository.before_delete
      end

1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424
      it 'flushes the root ref cache' do
        expect(repository).to receive(:expire_root_ref_cache)

        repository.before_delete
      end

      it 'flushes the emptiness caches' do
        expect(repository).to receive(:expire_emptiness_caches)

        repository.before_delete
      end
1425 1426

      it 'flushes the exists cache' do
1427
        expect(repository).to receive(:expire_exists_cache).twice
1428 1429 1430

        repository.before_delete
      end
1431 1432 1433 1434 1435 1436 1437
    end

    describe 'when a repository exists' do
      before do
        allow(repository).to receive(:exists?).and_return(true)
      end

1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449
      it 'flushes the tags cache' do
        expect(repository).to receive(:expire_tags_cache)

        repository.before_delete
      end

      it 'flushes the branches cache' do
        expect(repository).to receive(:expire_branches_cache)

        repository.before_delete
      end

1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477
      it 'flushes the root ref cache' do
        expect(repository).to receive(:expire_root_ref_cache)

        repository.before_delete
      end

      it 'flushes the emptiness caches' do
        expect(repository).to receive(:expire_emptiness_caches)

        repository.before_delete
      end
    end
  end

  describe '#before_change_head' do
    it 'flushes the branch cache' do
      expect(repository).to receive(:expire_branch_cache)

      repository.before_change_head
    end

    it 'flushes the root ref cache' do
      expect(repository).to receive(:expire_root_ref_cache)

      repository.before_change_head
    end
  end

1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494
  describe '#after_change_head' do
    it 'flushes the readme cache' do
      expect(repository).to receive(:expire_method_caches).with([
        :readme,
        :changelog,
        :license,
        :contributing,
        :gitignore,
        :koding,
        :gitlab_ci,
        :avatar
      ])

      repository.after_change_head
    end
  end

Y
Yorick Peterse 已提交
1495
  describe '#before_push_tag' do
1496
    it 'flushes the cache' do
1497 1498 1499
      expect(repository).to receive(:expire_statistics_caches)
      expect(repository).to receive(:expire_emptiness_caches)
      expect(repository).to receive(:expire_tags_cache)
1500

Y
Yorick Peterse 已提交
1501
      repository.before_push_tag
1502 1503 1504 1505
    end
  end

  describe '#after_import' do
1506 1507
    it 'flushes and builds the cache' do
      expect(repository).to receive(:expire_content_cache)
1508 1509 1510

      repository.after_import
    end
1511 1512 1513
  end

  describe '#after_push_commit' do
1514
    it 'expires statistics caches' do
1515 1516
      expect(repository).to receive(:expire_statistics_caches)
        .and_call_original
1517

1518 1519 1520
      expect(repository).to receive(:expire_branch_cache)
        .with('master')
        .and_call_original
1521

1522
      repository.after_push_commit('master')
1523 1524 1525 1526
    end
  end

  describe '#after_create_branch' do
1527
    it 'expires the branch caches' do
1528
      expect(repository).to receive(:expire_branches_cache)
1529 1530 1531 1532 1533 1534

      repository.after_create_branch
    end
  end

  describe '#after_remove_branch' do
1535
    it 'expires the branch caches' do
1536
      expect(repository).to receive(:expire_branches_cache)
1537 1538 1539 1540

      repository.after_remove_branch
    end
  end
1541

1542 1543 1544 1545 1546 1547
  describe '#after_create' do
    it 'flushes the exists cache' do
      expect(repository).to receive(:expire_exists_cache)

      repository.after_create
    end
1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559

    it 'flushes the root ref cache' do
      expect(repository).to receive(:expire_root_ref_cache)

      repository.after_create
    end

    it 'flushes the emptiness caches' do
      expect(repository).to receive(:expire_emptiness_caches)

      repository.after_create
    end
1560 1561
  end

1562 1563 1564 1565 1566 1567 1568 1569 1570 1571
  describe "#copy_gitattributes" do
    it 'returns true with a valid ref' do
      expect(repository.copy_gitattributes('master')).to be_truthy
    end

    it 'returns false with an invalid ref' do
      expect(repository.copy_gitattributes('invalid')).to be_falsey
    end
  end

Y
Yorick Peterse 已提交
1572 1573
  describe '#before_remove_tag' do
    it 'flushes the tag cache' do
1574 1575
      expect(repository).to receive(:expire_tags_cache).and_call_original
      expect(repository).to receive(:expire_statistics_caches).and_call_original
Y
Yorick Peterse 已提交
1576 1577 1578 1579 1580 1581 1582

      repository.before_remove_tag
    end
  end

  describe '#branch_count' do
    it 'returns the number of branches' do
D
Douwe Maan 已提交
1583
      expect(repository.branch_count).to be_an(Integer)
K
Cleanup  
Kim "BKC" Carlbäcker 已提交
1584 1585

      # NOTE: Until rugged goes away, make sure rugged and gitaly are in sync
1586
      rugged_count = repository.raw_repository.rugged.branches.count
K
Cleanup  
Kim "BKC" Carlbäcker 已提交
1587

1588
      expect(repository.branch_count).to eq(rugged_count)
Y
Yorick Peterse 已提交
1589 1590 1591 1592 1593
    end
  end

  describe '#tag_count' do
    it 'returns the number of tags' do
D
Douwe Maan 已提交
1594
      expect(repository.tag_count).to be_an(Integer)
K
Cleanup  
Kim "BKC" Carlbäcker 已提交
1595

1596 1597
      # NOTE: Until rugged goes away, make sure rugged and gitaly are in sync
      rugged_count = repository.raw_repository.rugged.tags.count
K
Cleanup  
Kim "BKC" Carlbäcker 已提交
1598

1599
      expect(repository.tag_count).to eq(rugged_count)
Y
Yorick Peterse 已提交
1600 1601 1602
    end
  end

1603
  describe '#expire_branches_cache' do
Y
Yorick Peterse 已提交
1604
    it 'expires the cache' do
1605 1606 1607
      expect(repository).to receive(:expire_method_caches)
        .with(%i(branch_names branch_count))
        .and_call_original
Y
Yorick Peterse 已提交
1608

1609
      repository.expire_branches_cache
Y
Yorick Peterse 已提交
1610 1611 1612
    end
  end

1613
  describe '#expire_tags_cache' do
Y
Yorick Peterse 已提交
1614
    it 'expires the cache' do
1615 1616 1617
      expect(repository).to receive(:expire_method_caches)
        .with(%i(tag_names tag_count))
        .and_call_original
Y
Yorick Peterse 已提交
1618

1619
      repository.expire_tags_cache
Y
Yorick Peterse 已提交
1620 1621
    end
  end
1622

1623
  describe '#add_tag' do
1624 1625
    context 'with a valid target' do
      let(:user) { build_stubbed(:user) }
1626

1627
      it 'creates the tag using rugged' do
1628 1629
        expect(repository.rugged.tags).to receive(:create)
          .with('8.5', repository.commit('master').id,
1630
            hash_including(message: 'foo',
1631 1632
                           tagger: hash_including(name: user.name, email: user.email)))
          .and_call_original
1633

1634 1635 1636 1637 1638 1639 1640 1641
        repository.add_tag(user, '8.5', 'master', 'foo')
      end

      it 'returns a Gitlab::Git::Tag object' do
        tag = repository.add_tag(user, '8.5', 'master', 'foo')

        expect(tag).to be_a(Gitlab::Git::Tag)
      end
1642 1643 1644

      it 'passes commit SHA to pre-receive and update hooks,\
        and tag SHA to post-receive hook' do
1645 1646 1647
        pre_receive_hook = Gitlab::Git::Hook.new('pre-receive', project)
        update_hook = Gitlab::Git::Hook.new('update', project)
        post_receive_hook = Gitlab::Git::Hook.new('post-receive', project)
1648

1649 1650
        allow(Gitlab::Git::Hook).to receive(:new)
          .and_return(pre_receive_hook, update_hook, post_receive_hook)
1651 1652 1653 1654 1655 1656 1657 1658 1659 1660

        allow(pre_receive_hook).to receive(:trigger).and_call_original
        allow(update_hook).to receive(:trigger).and_call_original
        allow(post_receive_hook).to receive(:trigger).and_call_original

        tag = repository.add_tag(user, '8.5', 'master', 'foo')

        commit_sha = repository.commit('master').id
        tag_sha = tag.target

1661 1662 1663 1664 1665 1666
        expect(pre_receive_hook).to have_received(:trigger)
          .with(anything, anything, commit_sha, anything)
        expect(update_hook).to have_received(:trigger)
          .with(anything, anything, commit_sha, anything)
        expect(post_receive_hook).to have_received(:trigger)
          .with(anything, anything, tag_sha, anything)
1667
      end
1668 1669 1670 1671 1672 1673
    end

    context 'with an invalid target' do
      it 'returns false' do
        expect(repository.add_tag(user, '8.5', 'bar', 'foo')).to be false
      end
1674 1675 1676
    end
  end

1677 1678 1679 1680 1681 1682 1683 1684 1685 1686
  describe '#rm_branch' do
    let(:user) { create(:user) }

    it 'removes a branch' do
      expect(repository).to receive(:before_remove_branch)
      expect(repository).to receive(:after_remove_branch)

      repository.rm_branch(user, 'feature')
    end
  end
1687 1688 1689 1690 1691

  describe '#rm_tag' do
    it 'removes a tag' do
      expect(repository).to receive(:before_remove_tag)

L
Lin Jen-Shin 已提交
1692 1693 1694
      repository.rm_tag(create(:user), 'v1.1.0')

      expect(repository.find_tag('v1.1.0')).to be_nil
1695 1696
    end
  end
1697 1698

  describe '#avatar' do
1699
    it 'returns nil if repo does not exist' do
1700 1701
      expect(repository).to receive(:file_on_head)
        .and_raise(Rugged::ReferenceError)
1702 1703 1704 1705

      expect(repository.avatar).to eq(nil)
    end

1706
    it 'returns the first avatar file found in the repository' do
1707 1708 1709
      expect(repository).to receive(:file_on_head)
        .with(:avatar)
        .and_return(double(:tree, path: 'logo.png'))
1710 1711 1712 1713 1714

      expect(repository.avatar).to eq('logo.png')
    end

    it 'caches the output' do
1715 1716 1717 1718
      expect(repository).to receive(:file_on_head)
        .with(:avatar)
        .once
        .and_return(double(:tree, path: 'logo.png'))
1719

1720
      2.times { expect(repository.avatar).to eq('logo.png') }
1721 1722
    end
  end
1723

1724 1725 1726 1727 1728 1729 1730 1731 1732 1733
  describe '#expire_exists_cache' do
    let(:cache) { repository.send(:cache) }

    it 'expires the cache' do
      expect(cache).to receive(:expire).with(:exists?)

      repository.expire_exists_cache
    end
  end

1734
  describe "#keep_around" do
1735 1736 1737 1738
    it "does not fail if we attempt to reference bad commit" do
      expect(repository.kept_around?('abc1234')).to be_falsey
    end

1739 1740 1741 1742 1743
    it "stores a reference to the specified commit sha so it isn't garbage collected" do
      repository.keep_around(sample_commit.id)

      expect(repository.kept_around?(sample_commit.id)).to be_truthy
    end
1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759

    it "attempting to call keep_around on truncated ref does not fail" do
      repository.keep_around(sample_commit.id)
      ref = repository.send(:keep_around_ref_name, sample_commit.id)
      path = File.join(repository.path, ref)
      # Corrupt the reference
      File.truncate(path, 0)

      expect(repository.kept_around?(sample_commit.id)).to be_falsey

      repository.keep_around(sample_commit.id)

      expect(repository.kept_around?(sample_commit.id)).to be_falsey

      File.delete(path)
    end
1760
  end
1761

1762
  describe '#update_ref' do
1763
    it 'can create a ref' do
1764
      Gitlab::Git::OperationService.new(nil, repository.raw_repository).send(:update_ref, 'refs/heads/foobar', 'refs/heads/master', Gitlab::Git::BLANK_SHA)
1765 1766 1767 1768 1769 1770

      expect(repository.find_branch('foobar')).not_to be_nil
    end

    it 'raises CommitError when the ref update fails' do
      expect do
1771 1772
        Gitlab::Git::OperationService.new(nil, repository.raw_repository).send(:update_ref, 'refs/heads/master', 'refs/heads/master', Gitlab::Git::BLANK_SHA)
      end.to raise_error(Gitlab::Git::CommitError)
1773 1774
    end
  end
1775

1776
  describe '#contribution_guide', :use_clean_rails_memory_store_caching do
1777
    it 'returns and caches the output' do
1778 1779 1780 1781
      expect(repository).to receive(:file_on_head)
        .with(:contributing)
        .and_return(Gitlab::Git::Tree.new(path: 'CONTRIBUTING.md'))
        .once
1782 1783

      2.times do
1784 1785
        expect(repository.contribution_guide)
          .to be_an_instance_of(Gitlab::Git::Tree)
1786 1787 1788 1789
      end
    end
  end

1790
  describe '#gitignore', :use_clean_rails_memory_store_caching do
1791
    it 'returns and caches the output' do
1792 1793 1794 1795
      expect(repository).to receive(:file_on_head)
        .with(:gitignore)
        .and_return(Gitlab::Git::Tree.new(path: '.gitignore'))
        .once
1796 1797

      2.times do
1798
        expect(repository.gitignore).to be_an_instance_of(Gitlab::Git::Tree)
1799 1800 1801 1802
      end
    end
  end

1803
  describe '#koding_yml', :use_clean_rails_memory_store_caching do
1804
    it 'returns and caches the output' do
1805 1806 1807 1808
      expect(repository).to receive(:file_on_head)
        .with(:koding)
        .and_return(Gitlab::Git::Tree.new(path: '.koding.yml'))
        .once
1809 1810

      2.times do
1811
        expect(repository.koding_yml).to be_an_instance_of(Gitlab::Git::Tree)
1812 1813 1814 1815
      end
    end
  end

1816
  describe '#readme', :use_clean_rails_memory_store_caching do
1817 1818
    context 'with a non-existing repository' do
      it 'returns nil' do
1819
        allow(repository).to receive(:tree).with(:head).and_return(nil)
1820

1821 1822 1823
        expect(repository.readme).to be_nil
      end
    end
1824

1825
    context 'with an existing repository' do
1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837
      context 'when no README exists' do
        it 'returns nil' do
          allow_any_instance_of(Tree).to receive(:readme).and_return(nil)

          expect(repository.readme).to be_nil
        end
      end

      context 'when a README exists' do
        it 'returns the README' do
          expect(repository.readme).to be_an_instance_of(ReadmeBlob)
        end
1838 1839 1840 1841
      end
    end
  end

1842 1843
  describe '#expire_statistics_caches' do
    it 'expires the caches' do
1844 1845
      expect(repository).to receive(:expire_method_caches)
        .with(%i(size commit_count))
1846

1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861
      repository.expire_statistics_caches
    end
  end

  describe '#expire_method_caches' do
    it 'expires the caches of the given methods' do
      expect_any_instance_of(RepositoryCache).to receive(:expire).with(:readme)
      expect_any_instance_of(RepositoryCache).to receive(:expire).with(:gitignore)

      repository.expire_method_caches(%i(readme gitignore))
    end
  end

  describe '#expire_all_method_caches' do
    it 'expires the caches of all methods' do
1862 1863
      expect(repository).to receive(:expire_method_caches)
        .with(Repository::CACHED_METHODS)
1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887

      repository.expire_all_method_caches
    end
  end

  describe '#file_on_head' do
    context 'with a non-existing repository' do
      it 'returns nil' do
        expect(repository).to receive(:tree).with(:head).and_return(nil)

        expect(repository.file_on_head(:readme)).to be_nil
      end
    end

    context 'with a repository that has no blobs' do
      it 'returns nil' do
        expect_any_instance_of(Tree).to receive(:blobs).and_return([])

        expect(repository.file_on_head(:readme)).to be_nil
      end
    end

    context 'with an existing repository' do
      it 'returns a Gitlab::Git::Tree' do
1888 1889
        expect(repository.file_on_head(:readme))
          .to be_an_instance_of(Gitlab::Git::Tree)
1890 1891 1892 1893
      end
    end
  end

1894 1895 1896 1897 1898 1899
  describe '#head_tree' do
    context 'with an existing repository' do
      it 'returns a Tree' do
        expect(repository.head_tree).to be_an_instance_of(Tree)
      end
    end
1900

1901 1902 1903 1904 1905
    context 'with a non-existing repository' do
      it 'returns nil' do
        expect(repository).to receive(:head_commit).and_return(nil)

        expect(repository.head_tree).to be_nil
1906 1907 1908 1909
      end
    end
  end

1910 1911 1912 1913 1914
  describe '#tree' do
    context 'using a non-existing repository' do
      before do
        allow(repository).to receive(:head_commit).and_return(nil)
      end
1915

1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958
      it 'returns nil' do
        expect(repository.tree(:head)).to be_nil
      end

      it 'returns nil when using a path' do
        expect(repository.tree(:head, 'README.md')).to be_nil
      end
    end

    context 'using an existing repository' do
      it 'returns a Tree' do
        expect(repository.tree(:head)).to be_an_instance_of(Tree)
      end
    end
  end

  describe '#size' do
    context 'with a non-existing repository' do
      it 'returns 0' do
        expect(repository).to receive(:exists?).and_return(false)

        expect(repository.size).to eq(0.0)
      end
    end

    context 'with an existing repository' do
      it 'returns the repository size as a Float' do
        expect(repository.size).to be_an_instance_of(Float)
      end
    end
  end

  describe '#commit_count' do
    context 'with a non-existing repository' do
      it 'returns 0' do
        expect(repository).to receive(:root_ref).and_return(nil)

        expect(repository.commit_count).to eq(0)
      end
    end

    context 'with an existing repository' do
      it 'returns the commit count' do
D
Douwe Maan 已提交
1959
        expect(repository.commit_count).to be_an(Integer)
1960 1961 1962 1963
      end
    end
  end

1964
  describe '#commit_count_for_ref' do
1965
    let(:project) { create :project }
1966

1967 1968
    context 'with a non-existing repository' do
      it 'returns 0' do
1969 1970 1971 1972 1973 1974 1975 1976
        expect(project.repository.commit_count_for_ref('master')).to eq(0)
      end
    end

    context 'with empty repository' do
      it 'returns 0' do
        project.create_repository
        expect(project.repository.commit_count_for_ref('master')).to eq(0)
1977 1978 1979 1980 1981 1982 1983 1984 1985 1986
      end
    end

    context 'when searching for the root ref' do
      it 'returns the same count as #commit_count' do
        expect(repository.commit_count_for_ref(repository.root_ref)).to eq(repository.commit_count)
      end
    end
  end

1987
  describe '#cache_method_output', :use_clean_rails_memory_store_caching do
1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003
    context 'with a non-existing repository' do
      let(:value) do
        repository.cache_method_output(:cats, fallback: 10) do
          raise Rugged::ReferenceError
        end
      end

      it 'returns a fallback value' do
        expect(value).to eq(10)
      end

      it 'does not cache the data' do
        value

        expect(repository.instance_variable_defined?(:@cats)).to eq(false)
        expect(repository.send(:cache).exist?(:cats)).to eq(false)
2004 2005
      end
    end
2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026

    context 'with an existing repository' do
      it 'caches the output' do
        object = double

        expect(object).to receive(:number).once.and_return(10)

        2.times do
          val = repository.cache_method_output(:cats) { object.number }

          expect(val).to eq(10)
        end

        expect(repository.send(:cache).exist?(:cats)).to eq(true)
        expect(repository.instance_variable_get(:@cats)).to eq(10)
      end
    end
  end

  describe '#refresh_method_caches' do
    it 'refreshes the caches of the given types' do
2027 2028
      expect(repository).to receive(:expire_method_caches)
        .with(%i(rendered_readme license_blob license_key license))
2029

2030
      expect(repository).to receive(:rendered_readme)
2031 2032
      expect(repository).to receive(:license_blob)
      expect(repository).to receive(:license_key)
2033
      expect(repository).to receive(:license)
2034 2035 2036

      repository.refresh_method_caches(%i(readme license))
    end
2037
  end
D
Douwe Maan 已提交
2038 2039 2040

  describe '#gitlab_ci_yml_for' do
    before do
2041
      repository.create_file(User.last, '.gitlab-ci.yml', 'CONTENT', message: 'Add .gitlab-ci.yml', branch_name: 'master')
D
Douwe Maan 已提交
2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058
    end

    context 'when there is a .gitlab-ci.yml at the commit' do
      it 'returns the content' do
        expect(repository.gitlab_ci_yml_for(repository.commit.sha)).to eq('CONTENT')
      end
    end

    context 'when there is no .gitlab-ci.yml at the commit' do
      it 'returns nil' do
        expect(repository.gitlab_ci_yml_for(repository.commit.parent.sha)).to be_nil
      end
    end
  end

  describe '#route_map_for' do
    before do
2059
      repository.create_file(User.last, '.gitlab/route-map.yml', 'CONTENT', message: 'Add .gitlab/route-map.yml', branch_name: 'master')
D
Douwe Maan 已提交
2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073
    end

    context 'when there is a .gitlab/route-map.yml at the commit' do
      it 'returns the content' do
        expect(repository.route_map_for(repository.commit.sha)).to eq('CONTENT')
      end
    end

    context 'when there is no .gitlab/route-map.yml at the commit' do
      it 'returns nil' do
        expect(repository.route_map_for(repository.commit.parent.sha)).to be_nil
      end
    end
  end
2074

2075
  describe '#ancestor?' do
2076 2077
    let(:commit) { repository.commit }
    let(:ancestor) { commit.parents.first }
2078

2079 2080
    context 'with Gitaly enabled' do
      it 'it is an ancestor' do
2081
        expect(repository.ancestor?(ancestor.id, commit.id)).to eq(true)
2082 2083 2084
      end

      it 'it is not an ancestor' do
2085
        expect(repository.ancestor?(commit.id, ancestor.id)).to eq(false)
2086 2087 2088
      end

      it 'returns false on nil-values' do
2089 2090 2091
        expect(repository.ancestor?(nil, commit.id)).to eq(false)
        expect(repository.ancestor?(ancestor.id, nil)).to eq(false)
        expect(repository.ancestor?(nil, nil)).to eq(false)
2092 2093 2094 2095
      end
    end

    context 'with Gitaly disabled' do
2096
      before do
2097 2098
        allow(Gitlab::GitalyClient).to receive(:enabled?).and_return(false)
        allow(Gitlab::GitalyClient).to receive(:feature_enabled?).with(:is_ancestor).and_return(false)
2099 2100
      end

2101
      it 'it is an ancestor' do
2102
        expect(repository.ancestor?(ancestor.id, commit.id)).to eq(true)
2103 2104 2105
      end

      it 'it is not an ancestor' do
2106
        expect(repository.ancestor?(commit.id, ancestor.id)).to eq(false)
2107
      end
2108

2109
      it 'returns false on nil-values' do
2110 2111 2112
        expect(repository.ancestor?(nil, commit.id)).to eq(false)
        expect(repository.ancestor?(ancestor.id, nil)).to eq(false)
        expect(repository.ancestor?(nil, nil)).to eq(false)
2113 2114 2115
      end
    end
  end
2116
end