repository_spec.rb 54.8 KB
Newer Older
1 2
require 'spec_helper'

D
Douwe Maan 已提交
3
describe Repository, models: true do
4
  include RepoHelpers
5
  TestBlob = Struct.new(:name)
6

7
  let(:project) { create(:project, :repository) }
8
  let(:repository) { project.repository }
9
  let(:user) { create(:user) }
10

11 12 13 14
  let(:commit_options) do
    author = repository.user_to_committer(user)
    { message: 'Test message', committer: author, author: author }
  end
15

R
Rubén Dávila 已提交
16
  let(:merge_commit) do
17
    merge_request = create(:merge_request, source_branch: 'feature', target_branch: 'master', source_project: project)
S
Sean McGivern 已提交
18 19 20 21 22 23

    merge_commit_id = repository.merge(user,
                                       merge_request.diff_head_sha,
                                       merge_request,
                                       commit_options)

24
    repository.commit(merge_commit_id)
25
  end
26

27 28 29 30 31 32 33 34 35 36 37 38 39 40 41
  let(:author_email) { FFaker::Internet.email }

  # I have to remove periods from the end of the name
  # This happened when the user's name had a suffix (i.e. "Sr.")
  # This seems to be what git does under the hood. For example, this commit:
  #
  # $ git commit --author='Foo Sr. <foo@example.com>' -m 'Where's my trailing period?'
  #
  # results in this:
  #
  # $ git show --pretty
  # ...
  # Author: Foo Sr <foo@example.com>
  # ...
  let(:author_name) { FFaker::Name.name.chomp("\.") }
42

43
  describe '#branch_names_contains' do
44 45
    subject { repository.branch_names_contains(sample_commit.id) }

46 47 48
    it { is_expected.to include('master') }
    it { is_expected.not_to include('feature') }
    it { is_expected.not_to include('fix') }
49
  end
50

51
  describe '#tag_names_contains' do
D
Dmitriy Zaporozhets 已提交
52
    subject { repository.tag_names_contains(sample_commit.id) }
53

D
Dmitriy Zaporozhets 已提交
54 55
    it { is_expected.to include('v1.1.0') }
    it { is_expected.not_to include('v1.0.0') }
56 57
  end

58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75
  describe 'tags_sorted_by' do
    context 'name' do
      subject { repository.tags_sorted_by('name').map(&:name) }

      it { is_expected.to eq(['v1.1.0', 'v1.0.0']) }
    end

    context 'updated' do
      let(:tag_a) { repository.find_tag('v1.0.0') }
      let(:tag_b) { repository.find_tag('v1.1.0') }

      context 'desc' do
        subject { repository.tags_sorted_by('updated_desc').map(&:name) }

        before do
          double_first = double(committed_date: Time.now)
          double_last = double(committed_date: Time.now - 1.second)

76 77
          allow(tag_a).to receive(:dereferenced_target).and_return(double_first)
          allow(tag_b).to receive(:dereferenced_target).and_return(double_last)
78
          allow(repository).to receive(:tags).and_return([tag_a, tag_b])
79 80 81 82 83 84 85 86 87 88 89 90
        end

        it { is_expected.to eq(['v1.0.0', 'v1.1.0']) }
      end

      context 'asc' do
        subject { repository.tags_sorted_by('updated_asc').map(&:name) }

        before do
          double_first = double(committed_date: Time.now - 1.second)
          double_last = double(committed_date: Time.now)

91 92
          allow(tag_a).to receive(:dereferenced_target).and_return(double_last)
          allow(tag_b).to receive(:dereferenced_target).and_return(double_first)
93
          allow(repository).to receive(:tags).and_return([tag_a, tag_b])
94 95 96 97
        end

        it { is_expected.to eq(['v1.1.0', 'v1.0.0']) }
      end
98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121

      context 'annotated tag pointing to a blob' do
        let(:annotated_tag_name) { 'annotated-tag' }

        subject { repository.tags_sorted_by('updated_asc').map(&:name) }

        before do
          options = { message: 'test tag message\n',
                      tagger: { name: 'John Smith', email: 'john@gmail.com' } }
          repository.rugged.tags.create(annotated_tag_name, 'a48e4fc218069f68ef2e769dd8dfea3991362175', options)

          double_first = double(committed_date: Time.now - 1.second)
          double_last = double(committed_date: Time.now)

          allow(tag_a).to receive(:dereferenced_target).and_return(double_last)
          allow(tag_b).to receive(:dereferenced_target).and_return(double_first)
        end

        it { is_expected.to eq(['v1.1.0', 'v1.0.0', annotated_tag_name]) }

        after do
          repository.rugged.tags.delete(annotated_tag_name)
        end
      end
122 123 124
    end
  end

125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144
  describe '#ref_name_for_sha' do
    context 'ref found' do
      it 'returns the ref' do
        allow_any_instance_of(Gitlab::Popen).to receive(:popen).
          and_return(["b8d95eb4969eefacb0a58f6a28f6803f8070e7b9 commit\trefs/environments/production/77\n", 0])

        expect(repository.ref_name_for_sha('bla', '0' * 40)).to eq 'refs/environments/production/77'
      end
    end

    context 'ref not found' do
      it 'returns nil' do
        allow_any_instance_of(Gitlab::Popen).to receive(:popen).
          and_return(["", 0])

        expect(repository.ref_name_for_sha('bla', '0' * 40)).to eq nil
      end
    end
  end

145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164
  describe '#ref_exists?' do
    context 'when ref exists' do
      it 'returns true' do
        expect(repository.ref_exists?('refs/heads/master')).to be true
      end
    end

    context 'when ref does not exist' do
      it 'returns false' do
        expect(repository.ref_exists?('refs/heads/non-existent')).to be false
      end
    end

    context 'when ref format is incorrect' do
      it 'returns false' do
        expect(repository.ref_exists?('refs/heads/invalid:master')).to be false
      end
    end
  end

165
  describe '#last_commit_for_path' do
D
Dmitriy Zaporozhets 已提交
166
    subject { repository.last_commit_for_path(sample_commit.id, '.gitignore').id }
167

D
Dmitriy Zaporozhets 已提交
168
    it { is_expected.to eq('c1acaa58bbcbc3eafe538cb8274ba387047b69f8') }
169
  end
170

H
Hiroyuki Sato 已提交
171 172 173
  describe '#last_commit_id_for_path' do
    subject { repository.last_commit_id_for_path(sample_commit.id, '.gitignore') }

H
Hiroyuki Sato 已提交
174 175 176
    it "returns last commit id for a given path" do
      is_expected.to eq('c1acaa58bbcbc3eafe538cb8274ba387047b69f8')
    end
H
Hiroyuki Sato 已提交
177

H
Hiroyuki Sato 已提交
178
    it "caches last commit id for a given path" do
H
Hiroyuki Sato 已提交
179 180
      cache = repository.send(:cache)
      key = "last_commit_id_for_path:#{sample_commit.id}:#{Digest::SHA1.hexdigest('.gitignore')}"
181

H
Hiroyuki Sato 已提交
182
      expect(cache).to receive(:fetch).with(key).and_return('c1acaa5')
H
Hiroyuki Sato 已提交
183
      is_expected.to eq('c1acaa5')
H
Hiroyuki Sato 已提交
184 185 186
    end
  end

187
  describe '#find_commits_by_message' do
188 189
    it 'returns commits with messages containing a given string' do
      commit_ids = repository.find_commits_by_message('submodule').map(&:id)
190

191 192 193 194 195 196 197 198 199 200 201
      expect(commit_ids).to include('5937ac0a7beb003549fc5fd26fc247adbce4a52e')
      expect(commit_ids).to include('6f6d7e7ed97bb5f0054f2b1df789b39ca89b6ff9')
      expect(commit_ids).to include('cfe32cf61b73a0d5e9f13e774abde7ff789b1660')
      expect(commit_ids).not_to include('913c66a37b4a45b9769037c55c2d238bd0942d2e')
    end

    it 'is case insensitive' do
      commit_ids = repository.find_commits_by_message('SUBMODULE').map(&:id)

      expect(commit_ids).to include('5937ac0a7beb003549fc5fd26fc247adbce4a52e')
    end
202 203
  end

204
  describe '#blob_at' do
205 206 207 208 209 210
    context 'blank sha' do
      subject { repository.blob_at(Gitlab::Git::BLANK_SHA, '.gitignore') }

      it { is_expected.to be_nil }
    end
  end
211

212
  describe '#merged_to_root_ref?' do
213
    context 'merged branch without ff' do
214
      subject { repository.merged_to_root_ref?('branch-merged') }
F
Florent (HP) 已提交
215 216 217

      it { is_expected.to be_truthy }
    end
218

219 220
    # If the HEAD was ff then it will be false
    context 'merged with ff' do
F
Florent (HP) 已提交
221 222 223 224
      subject { repository.merged_to_root_ref?('improve/awesome') }

      it { is_expected.to be_truthy }
    end
225

226 227 228 229 230
    context 'not merged branch' do
      subject { repository.merged_to_root_ref?('not-merged-branch') }

      it { is_expected.to be_falsey }
    end
231 232 233 234 235 236

    context 'default branch' do
      subject { repository.merged_to_root_ref?('master') }

      it { is_expected.to be_falsey }
    end
237 238
  end

239
  describe '#can_be_merged?' do
240 241 242 243 244 245 246 247 248 249 250
    context 'mergeable branches' do
      subject { repository.can_be_merged?('0b4bc9a49b562e85de7cc9e834518ea6828729b9', 'master') }

      it { is_expected.to be_truthy }
    end

    context 'non-mergeable branches' do
      subject { repository.can_be_merged?('bb5206fee213d983da88c47f9cf4cc6caf9c66dc', 'feature') }

      it { is_expected.to be_falsey }
    end
F
Florent (HP) 已提交
251 252 253 254 255 256 257 258 259 260 261 262

    context 'non merged branch' do
      subject { repository.merged_to_root_ref?('fix') }

      it { is_expected.to be_falsey }
    end

    context 'non existent branch' do
      subject { repository.merged_to_root_ref?('non_existent_branch') }

      it { is_expected.to be_nil }
    end
263 264
  end

265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293
  describe '#commit' do
    context 'when ref exists' do
      it 'returns commit object' do
        expect(repository.commit('master'))
          .to be_an_instance_of Commit
      end
    end

    context 'when ref does not exist' do
      it 'returns nil' do
        expect(repository.commit('non-existent-ref')).to be_nil
      end
    end

    context 'when ref is not valid' do
      context 'when preceding tree element exists' do
        it 'returns nil' do
          expect(repository.commit('master:ref')).to be_nil
        end
      end

      context 'when preceding tree element does not exist' do
        it 'returns nil' do
          expect(repository.commit('non-existent:ref')).to be_nil
        end
      end
    end
  end

294 295 296
  describe "#commit_dir" do
    it "commits a change that creates a new directory" do
      expect do
297 298
        repository.commit_dir(user, 'newdir',
          message: 'Create newdir', branch_name: 'master')
299 300 301 302 303 304
      end.to change { repository.commits('master').count }.by(1)

      newdir = repository.tree('master', 'newdir')
      expect(newdir.path).to eq('newdir')
    end

305 306 307 308 309 310 311
    context "when committing to another project" do
      let(:forked_project) { create(:project) }

      it "creates a fork and commit to the forked project" do
        expect do
          repository.commit_dir(user, 'newdir',
            message: 'Create newdir', branch_name: 'patch',
L
Lin Jen-Shin 已提交
312
            start_branch_name: 'master', start_project: forked_project)
313 314 315 316 317 318 319 320 321 322
        end.to change { repository.commits('master').count }.by(0)

        expect(repository.branch_exists?('patch')).to be_truthy
        expect(forked_project.repository.branch_exists?('patch')).to be_falsy

        newdir = repository.tree('patch', 'newdir')
        expect(newdir.path).to eq('newdir')
      end
    end

323 324 325
    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
        expect do
326 327 328 329
          repository.commit_dir(user, 'newdir',
            message: 'Add newdir',
            branch_name: 'master',
            author_email: author_email, author_name: author_name)
330 331 332 333 334 335 336 337 338 339 340
        end.to change { repository.commits('master').count }.by(1)

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
  end

  describe "#commit_file" do
341 342
    it 'commits change to a file successfully' do
      expect do
343
        repository.commit_file(user, 'CHANGELOG', 'Changelog!',
344 345 346
                               message: 'Updates file content',
                               branch_name: 'master',
                               update: true)
347 348
      end.to change { repository.commits('master').count }.by(1)

349
      blob = repository.blob_at('master', 'CHANGELOG')
350

351
      expect(blob.data).to eq('Changelog!')
352
    end
353 354 355 356

    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
        expect do
357 358 359 360 361 362
          repository.commit_file(user, 'README', 'README!',
                                 message: 'Add README',
                                 branch_name: 'master',
                                 update: true,
                                 author_email: author_email,
                                 author_name: author_name)
363 364 365 366 367 368 369 370
        end.to change { repository.commits('master').count }.by(1)

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
371 372
  end

373
  describe "#update_file" do
T
tiagonbotelho 已提交
374
    it 'updates filename successfully' do
375 376
      expect do
        repository.update_file(user, 'NEWLICENSE', 'Copyright!',
377
                                     branch_name: 'master',
T
tiagonbotelho 已提交
378
                                     previous_path: 'LICENSE',
379 380
                                     message: 'Changes filename')
      end.to change { repository.commits('master').count }.by(1)
T
tiagonbotelho 已提交
381 382 383 384 385 386

      files = repository.ls_files('master')

      expect(files).not_to include('LICENSE')
      expect(files).to include('NEWLICENSE')
    end
387 388 389

    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
390 391
        repository.commit_file(user, 'README', 'README!',
          message: 'Add README', branch_name: 'master', update: true)
392 393

        expect do
394 395 396 397 398 399
          repository.update_file(user, 'README', 'Updated README!',
                                 branch_name: 'master',
                                 previous_path: 'README',
                                 message: 'Update README',
                                 author_email: author_email,
                                 author_name: author_name)
400 401 402 403 404 405 406 407 408 409 410 411
        end.to change { repository.commits('master').count }.by(1)

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
  end

  describe "#remove_file" do
    it 'removes file successfully' do
412 413
      repository.commit_file(user, 'README', 'README!',
        message: 'Add README', branch_name: 'master', update: true)
414 415

      expect do
416 417
        repository.remove_file(user, 'README',
          message: 'Remove README', branch_name: 'master')
418 419 420 421 422 423 424
      end.to change { repository.commits('master').count }.by(1)

      expect(repository.blob_at('master', 'README')).to be_nil
    end

    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
425 426
        repository.commit_file(user, 'README', 'README!',
          message: 'Add README', branch_name: 'master', update: true)
427 428

        expect do
429 430 431
          repository.remove_file(user, 'README',
            message: 'Remove README', branch_name: 'master',
            author_email: author_email, author_name: author_name)
432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471
        end.to change { repository.commits('master').count }.by(1)

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
  end

  describe '#get_committer_and_author' do
    it 'returns the committer and author data' do
      options = repository.get_committer_and_author(user)
      expect(options[:committer][:email]).to eq(user.email)
      expect(options[:author][:email]).to eq(user.email)
    end

    context 'when the email/name are given' do
      it 'returns an object containing the email/name' do
        options = repository.get_committer_and_author(user, email: author_email, name: author_name)
        expect(options[:author][:email]).to eq(author_email)
        expect(options[:author][:name]).to eq(author_name)
      end
    end

    context 'when the email is given but the name is not' do
      it 'returns the committer as the author' do
        options = repository.get_committer_and_author(user, email: author_email)
        expect(options[:author][:email]).to eq(user.email)
        expect(options[:author][:name]).to eq(user.name)
      end
    end

    context 'when the name is given but the email is not' do
      it 'returns nil' do
        options = repository.get_committer_and_author(user, name: author_name)
        expect(options[:author][:email]).to eq(user.email)
        expect(options[:author][:name]).to eq(user.name)
      end
    end
T
tiagonbotelho 已提交
472 473
  end

V
Valery Sizov 已提交
474 475
  describe "search_files_by_content" do
    let(:results) { repository.search_files_by_content('feature', 'master') }
476 477 478 479
    subject { results }

    it { is_expected.to be_an Array }

480
    it 'regex-escapes the query string' do
V
Valery Sizov 已提交
481
      results = repository.search_files_by_content("test\\", 'master')
482 483 484 485

      expect(results.first).not_to start_with('fatal:')
    end

486
    it 'properly handles an unmatched parenthesis' do
V
Valery Sizov 已提交
487
      results = repository.search_files_by_content("test(", 'master')
488 489 490 491

      expect(results.first).not_to start_with('fatal:')
    end

V
Valery Sizov 已提交
492
    it 'properly handles when query is not present' do
V
Valery Sizov 已提交
493
      results = repository.search_files_by_content('', 'master')
V
Valery Sizov 已提交
494 495 496 497 498 499

      expect(results).to match_array([])
    end

    it 'properly handles query when repo is empty' do
      repository = create(:empty_project).repository
V
Valery Sizov 已提交
500
      results = repository.search_files_by_content('test', 'master')
V
Valery Sizov 已提交
501 502 503 504

      expect(results).to match_array([])
    end

505 506 507 508
    describe 'result' do
      subject { results.first }

      it { is_expected.to be_an String }
509
      it { expect(subject.lines[2]).to eq("master:CHANGELOG:190:  - Feature: Replace teams with group membership\n") }
510 511
    end
  end
Z
Zeger-Jan van de Weg 已提交
512

V
Valery Sizov 已提交
513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534
  describe "search_files_by_name" do
    let(:results) { repository.search_files_by_name('files', 'master') }

    it 'returns result' do
      expect(results.first).to eq('files/html/500.html')
    end

    it 'properly handles when query is not present' do
      results = repository.search_files_by_name('', 'master')

      expect(results).to match_array([])
    end

    it 'properly handles query when repo is empty' do
      repository = create(:empty_project).repository

      results = repository.search_files_by_name('test', 'master')

      expect(results).to match_array([])
    end
  end

535 536 537 538 539 540 541 542 543 544
  describe '#create_ref' do
    it 'redirects the call to fetch_ref' do
      ref, ref_path = '1', '2'

      expect(repository).to receive(:fetch_ref).with(repository.path_to_repo, ref, ref_path)

      repository.create_ref(ref, ref_path)
    end
  end

545
  describe "#changelog", caching: true do
546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576
    it 'accepts changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('changelog')])

      expect(repository.changelog.name).to eq('changelog')
    end

    it 'accepts news instead of changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('news')])

      expect(repository.changelog.name).to eq('news')
    end

    it 'accepts history instead of changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('history')])

      expect(repository.changelog.name).to eq('history')
    end

    it 'accepts changes instead of changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('changes')])

      expect(repository.changelog.name).to eq('changes')
    end

    it 'is case-insensitive' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('CHANGELOG')])

      expect(repository.changelog.name).to eq('CHANGELOG')
    end
  end

577
  describe "#license_blob", caching: true do
578
    before do
579 580
      repository.remove_file(
        user, 'LICENSE', message: 'Remove LICENSE', branch_name: 'master')
581 582
    end

583
    it 'handles when HEAD points to non-existent ref' do
584 585 586
      repository.commit_file(
        user, 'LICENSE', 'Copyright!',
        message: 'Add LICENSE', branch_name: 'master', update: false)
587 588 589

      allow(repository).to receive(:file_on_head).
        and_raise(Rugged::ReferenceError)
590 591 592 593

      expect(repository.license_blob).to be_nil
    end

594
    it 'looks in the root_ref only' do
595 596 597 598 599
      repository.remove_file(user, 'LICENSE',
        message: 'Remove LICENSE', branch_name: 'markdown')
      repository.commit_file(user, 'LICENSE',
        Licensee::License.new('mit').content,
        message: 'Add LICENSE', branch_name: 'markdown', update: false)
600 601 602 603

      expect(repository.license_blob).to be_nil
    end

604
    it 'detects license file with no recognizable open-source license content' do
605 606
      repository.commit_file(user, 'LICENSE', 'Copyright!',
        message: 'Add LICENSE', branch_name: 'master', update: false)
607 608 609 610

      expect(repository.license_blob.name).to eq('LICENSE')
    end

611 612
    %w[LICENSE LICENCE LiCensE LICENSE.md LICENSE.foo COPYING COPYING.md].each do |filename|
      it "detects '#{filename}'" do
613 614 615
        repository.commit_file(user, filename,
          Licensee::License.new('mit').content,
          message: "Add #{filename}", branch_name: 'master', update: false)
616

617 618
        expect(repository.license_blob.name).to eq(filename)
      end
619 620 621
    end
  end

622
  describe '#license_key', caching: true do
623
    before do
624 625
      repository.remove_file(user, 'LICENSE',
        message: 'Remove LICENSE', branch_name: 'master')
626
    end
Z
Zeger-Jan van de Weg 已提交
627

628
    it 'returns nil when no license is detected' do
629 630 631
      expect(repository.license_key).to be_nil
    end

632 633 634
    it 'returns nil when the repository does not exist' do
      expect(repository).to receive(:exists?).and_return(false)

635 636 637 638
      expect(repository.license_key).to be_nil
    end

    it 'detects license file with no recognizable open-source license content' do
639 640
      repository.commit_file(user, 'LICENSE', 'Copyright!',
        message: 'Add LICENSE', branch_name: 'master', update: false)
641 642

      expect(repository.license_key).to be_nil
Z
Zeger-Jan van de Weg 已提交
643
    end
644

645
    it 'returns the license key' do
646 647 648
      repository.commit_file(user, 'LICENSE',
        Licensee::License.new('mit').content,
        message: 'Add LICENSE', branch_name: 'master', update: false)
649

650
      expect(repository.license_key).to eq('mit')
651
    end
Z
Zeger-Jan van de Weg 已提交
652
  end
653

654
  describe "#gitlab_ci_yml", caching: true do
655 656 657 658 659 660 661 662 663 664 665 666 667
    it 'returns valid file' do
      files = [TestBlob.new('file'), TestBlob.new('.gitlab-ci.yml'), TestBlob.new('copying')]
      expect(repository.tree).to receive(:blobs).and_return(files)

      expect(repository.gitlab_ci_yml.name).to eq('.gitlab-ci.yml')
    end

    it 'returns nil if not exists' do
      expect(repository.tree).to receive(:blobs).and_return([])
      expect(repository.gitlab_ci_yml).to be_nil
    end

    it 'returns nil for empty repository' do
668
      allow(repository).to receive(:file_on_head).and_raise(Rugged::ReferenceError)
669 670 671 672
      expect(repository.gitlab_ci_yml).to be_nil
    end
  end

673
  describe '#add_branch' do
674
    context 'when pre hooks were successful' do
675
      it 'runs without errors' do
676
        hook = double(trigger: [true, nil])
677
        expect(Gitlab::Git::Hook).to receive(:new).exactly(3).times.and_return(hook)
678 679 680 681

        expect { repository.add_branch(user, 'new_feature', 'master') }.not_to raise_error
      end

682
      it 'creates the branch' do
683
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([true, nil])
684 685 686 687 688

        branch = repository.add_branch(user, 'new_feature', 'master')

        expect(branch.name).to eq('new_feature')
      end
689 690 691 692 693 694

      it 'calls the after_create_branch hook' do
        expect(repository).to receive(:after_create_branch)

        repository.add_branch(user, 'new_feature', 'master')
      end
695 696 697
    end

    context 'when pre hooks failed' do
698
      it 'gets an error' do
699
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([false, ''])
700 701 702 703 704 705

        expect do
          repository.add_branch(user, 'new_feature', 'master')
        end.to raise_error(GitHooksService::PreReceiveError)
      end

706
      it 'does not create the branch' do
707
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([false, ''])
708 709 710 711 712 713 714 715 716

        expect do
          repository.add_branch(user, 'new_feature', 'master')
        end.to raise_error(GitHooksService::PreReceiveError)
        expect(repository.find_branch('new_feature')).to be_nil
      end
    end
  end

717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734
  describe '#find_branch' do
    it 'loads a branch with a fresh repo' do
      expect(Gitlab::Git::Repository).to receive(:new).twice.and_call_original

      2.times do
        expect(repository.find_branch('feature')).not_to be_nil
      end
    end

    it 'loads a branch with a cached repo' do
      expect(Gitlab::Git::Repository).to receive(:new).once.and_call_original

      2.times do
        expect(repository.find_branch('feature', fresh_repo: false)).not_to be_nil
      end
    end
  end

735
  describe '#rm_branch' do
736 737 738
    let(:old_rev) { '0b4bc9a49b562e85de7cc9e834518ea6828729b9' } # git rev-parse feature
    let(:blank_sha) { '0000000000000000000000000000000000000000' }

739
    context 'when pre hooks were successful' do
740
      it 'runs without errors' do
741 742
        expect_any_instance_of(GitHooksService).to receive(:execute).
          with(user, project.repository.path_to_repo, old_rev, blank_sha, 'refs/heads/feature')
743 744 745 746

        expect { repository.rm_branch(user, 'feature') }.not_to raise_error
      end

747
      it 'deletes the branch' do
748
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([true, nil])
749 750 751 752 753 754 755 756

        expect { repository.rm_branch(user, 'feature') }.not_to raise_error

        expect(repository.find_branch('feature')).to be_nil
      end
    end

    context 'when pre hooks failed' do
757
      it 'gets an error' do
758
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([false, ''])
759 760

        expect do
761
          repository.rm_branch(user, 'feature')
762 763 764
        end.to raise_error(GitHooksService::PreReceiveError)
      end

765
      it 'does not delete the branch' do
766
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([false, ''])
767 768 769 770 771 772 773 774 775

        expect do
          repository.rm_branch(user, 'feature')
        end.to raise_error(GitHooksService::PreReceiveError)
        expect(repository.find_branch('feature')).not_to be_nil
      end
    end
  end

776
  describe '#update_branch_with_hooks' do
777
    let(:old_rev) { '0b4bc9a49b562e85de7cc9e834518ea6828729b9' } # git rev-parse feature
778
    let(:new_rev) { 'a74ae73c1ccde9b974a70e82b901588071dc142a' } # commit whose parent is old_rev
779

780
    context 'when pre hooks were successful' do
781
      before do
782 783 784 785 786 787 788
        service = GitHooksService.new
        expect(GitHooksService).to receive(:new).and_return(service)
        expect(service).to receive(:execute).
          with(
            user,
            repository.path_to_repo,
            old_rev,
789
            new_rev,
790 791
            'refs/heads/feature').
          and_yield(service).and_return(true)
792
      end
793

794
      it 'runs without errors' do
795
        expect do
796 797 798
          GitOperationService.new(user, repository).with_branch('feature') do
            new_rev
          end
799 800
        end.not_to raise_error
      end
801

802
      it 'ensures the autocrlf Git option is set to :input' do
803 804 805
        service = GitOperationService.new(user, repository)

        expect(service).to receive(:update_autocrlf_option)
806

807
        service.with_branch('feature') { new_rev }
808
      end
809 810 811

      context "when the branch wasn't empty" do
        it 'updates the head' do
812
          expect(repository.find_branch('feature').dereferenced_target.id).to eq(old_rev)
813 814 815 816 817

          GitOperationService.new(user, repository).with_branch('feature') do
            new_rev
          end

818
          expect(repository.find_branch('feature').dereferenced_target.id).to eq(new_rev)
819 820
        end
      end
821 822
    end

823
    context 'when the update adds more than one commit' do
824
      let(:old_rev) { '33f3729a45c02fc67d00adb1b8bca394b0e761d9' }
825

826
      it 'runs without errors' do
827 828 829 830 831 832
        # old_rev is an ancestor of new_rev
        expect(repository.rugged.merge_base(old_rev, new_rev)).to eq(old_rev)

        # old_rev is not a direct ancestor (parent) of new_rev
        expect(repository.rugged.lookup(new_rev).parent_ids).not_to include(old_rev)

833 834 835
        branch = 'feature-ff-target'
        repository.add_branch(user, branch, old_rev)

836 837 838 839 840
        expect do
          GitOperationService.new(user, repository).with_branch(branch) do
            new_rev
          end
        end.not_to raise_error
841 842 843 844
      end
    end

    context 'when the update would remove commits from the target branch' do
845 846
      let(:branch) { 'master' }
      let(:old_rev) { repository.find_branch(branch).dereferenced_target.sha }
847

848
      it 'raises an exception' do
849 850 851 852 853 854
        # The 'master' branch is NOT an ancestor of new_rev.
        expect(repository.rugged.merge_base(old_rev, new_rev)).not_to eq(old_rev)

        # Updating 'master' to new_rev would lose the commits on 'master' that
        # are not contained in new_rev. This should not be allowed.
        expect do
855 856 857
          GitOperationService.new(user, repository).with_branch(branch) do
            new_rev
          end
858
        end.to raise_error(Repository::CommitError)
859 860 861
      end
    end

862
    context 'when pre hooks failed' do
863
      it 'gets an error' do
864
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([false, ''])
865 866

        expect do
867 868 869
          GitOperationService.new(user, repository).with_branch('feature') do
            new_rev
          end
870 871 872
        end.to raise_error(GitHooksService::PreReceiveError)
      end
    end
873 874 875 876 877 878 879 880 881 882 883 884

    context 'when target branch is different from source branch' do
      before do
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([true, ''])
      end

      it 'expires branch cache' do
        expect(repository).not_to receive(:expire_exists_cache)
        expect(repository).not_to receive(:expire_root_ref_cache)
        expect(repository).not_to receive(:expire_emptiness_caches)
        expect(repository).to     receive(:expire_branches_cache)

885 886 887 888
        GitOperationService.new(user, repository).
          with_branch('new-feature') do
            new_rev
          end
889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905
      end
    end

    context 'when repository is empty' do
      before do
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([true, ''])
      end

      it 'expires creation and branch cache' do
        empty_repository = create(:empty_project, :empty_repo).repository

        expect(empty_repository).to receive(:expire_exists_cache)
        expect(empty_repository).to receive(:expire_root_ref_cache)
        expect(empty_repository).to receive(:expire_emptiness_caches)
        expect(empty_repository).to receive(:expire_branches_cache)

        empty_repository.commit_file(user, 'CHANGELOG', 'Changelog!',
906 907 908
                                     message: 'Updates file content',
                                     branch_name: 'master',
                                     update: false)
909 910
      end
    end
911
  end
912

913 914 915 916 917 918
  describe '#exists?' do
    it 'returns true when a repository exists' do
      expect(repository.exists?).to eq(true)
    end

    it 'returns false when a repository does not exist' do
919
      allow(repository).to receive(:refs_directory_exists?).and_return(false)
920 921 922

      expect(repository.exists?).to eq(false)
    end
923 924 925 926 927 928

    it 'returns false when there is no namespace' do
      allow(repository).to receive(:path_with_namespace).and_return(nil)

      expect(repository.exists?).to eq(false)
    end
929 930
  end

931 932 933 934 935
  describe '#has_visible_content?' do
    subject { repository.has_visible_content? }

    describe 'when there are no branches' do
      before do
936
        allow(repository).to receive(:branch_count).and_return(0)
937 938 939 940 941 942
      end

      it { is_expected.to eq(false) }
    end

    describe 'when there are branches' do
943
      it 'returns true' do
944
        expect(repository).to receive(:branch_count).and_return(3)
945 946 947 948 949 950

        expect(subject).to eq(true)
      end
    end
  end

951 952 953 954 955 956 957
  describe '#update_autocrlf_option' do
    describe 'when autocrlf is not already set to :input' do
      before do
        repository.raw_repository.autocrlf = true
      end

      it 'sets autocrlf to :input' do
958
        GitOperationService.new(nil, repository).send(:update_autocrlf_option)
959 960 961 962 963 964 965 966 967 968 969

        expect(repository.raw_repository.autocrlf).to eq(:input)
      end
    end

    describe 'when autocrlf is already set to :input' do
      before do
        repository.raw_repository.autocrlf = :input
      end

      it 'does nothing' do
970
        expect(repository.raw_repository).not_to receive(:autocrlf=).
971 972
          with(:input)

973
        GitOperationService.new(nil, repository).send(:update_autocrlf_option)
974 975 976 977
      end
    end
  end

978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027
  describe '#empty?' do
    let(:empty_repository) { create(:project_empty_repo).repository }

    it 'returns true for an empty repository' do
      expect(empty_repository.empty?).to eq(true)
    end

    it 'returns false for a non-empty repository' do
      expect(repository.empty?).to eq(false)
    end

    it 'caches the output' do
      expect(repository.raw_repository).to receive(:empty?).
        once.
        and_return(false)

      repository.empty?
      repository.empty?
    end
  end

  describe '#root_ref' do
    it 'returns a branch name' do
      expect(repository.root_ref).to be_an_instance_of(String)
    end

    it 'caches the output' do
      expect(repository.raw_repository).to receive(:root_ref).
        once.
        and_return('master')

      repository.root_ref
      repository.root_ref
    end
  end

  describe '#expire_root_ref_cache' do
    it 'expires the root reference cache' do
      repository.root_ref

      expect(repository.raw_repository).to receive(:root_ref).
        once.
        and_return('foo')

      repository.expire_root_ref_cache

      expect(repository.root_ref).to eq('foo')
    end
  end

Y
Yorick Peterse 已提交
1028
  describe '#expire_branch_cache' do
1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054
    # This method is private but we need it for testing purposes. Sadly there's
    # no other proper way of testing caching operations.
    let(:cache) { repository.send(:cache) }

    it 'expires the cache for all branches' do
      expect(cache).to receive(:expire).
        at_least(repository.branches.length).
        times

      repository.expire_branch_cache
    end

    it 'expires the cache for all branches when the root branch is given' do
      expect(cache).to receive(:expire).
        at_least(repository.branches.length).
        times

      repository.expire_branch_cache(repository.root_ref)
    end

    it 'expires the cache for a specific branch' do
      expect(cache).to receive(:expire).once

      repository.expire_branch_cache('foo')
    end
  end
1055

1056 1057 1058
  describe '#expire_emptiness_caches' do
    let(:cache) { repository.send(:cache) }

1059 1060 1061
    it 'expires the caches for an empty repository' do
      allow(repository).to receive(:empty?).and_return(true)

1062 1063 1064 1065
      expect(cache).to receive(:expire).with(:empty?)

      repository.expire_emptiness_caches
    end
1066 1067 1068 1069 1070 1071 1072 1073

    it 'does not expire the cache for a non-empty repository' do
      allow(repository).to receive(:empty?).and_return(false)

      expect(cache).not_to receive(:expire).with(:empty?)

      repository.expire_emptiness_caches
    end
1074 1075
  end

1076
  describe :skip_merged_commit do
1077
    subject { repository.commits(Gitlab::Git::BRANCH_REF_PREFIX + "'test'", limit: 100, skip_merges: true).map{ |k| k.id } }
1078 1079 1080

    it { is_expected.not_to include('e56497bb5f03a90a51293fc6d516788730953899') }
  end
1081 1082

  describe '#merge' do
1083
    it 'merges the code and return the commit id' do
R
Rubén Dávila 已提交
1084 1085
      expect(merge_commit).to be_present
      expect(repository.blob_at(merge_commit.id, 'files/ruby/feature.rb')).to be_present
1086
    end
1087 1088 1089

    it 'sets the `in_progress_merge_commit_sha` flag for the given merge request' do
      merge_request = create(:merge_request, source_branch: 'feature', target_branch: 'master', source_project: project)
S
Sean McGivern 已提交
1090 1091 1092 1093 1094

      merge_commit_id = repository.merge(user,
                                         merge_request.diff_head_sha,
                                         merge_request,
                                         commit_options)
1095 1096 1097

      expect(merge_request.in_progress_merge_commit_sha).to eq(merge_commit_id)
    end
1098 1099
  end

1100 1101 1102
  describe '#revert' do
    let(:new_image_commit) { repository.commit('33f3729a45c02fc67d00adb1b8bca394b0e761d9') }
    let(:update_image_commit) { repository.commit('2f63565e7aac07bcdadb654e253078b727143ec4') }
1103

1104
    context 'when there is a conflict' do
1105
      it 'aborts the operation' do
1106 1107 1108 1109 1110
        expect(repository.revert(user, new_image_commit, 'master')).to eq(false)
      end
    end

    context 'when commit was already reverted' do
1111
      it 'aborts the operation' do
1112 1113 1114 1115 1116 1117 1118
        repository.revert(user, update_image_commit, 'master')

        expect(repository.revert(user, update_image_commit, 'master')).to eq(false)
      end
    end

    context 'when commit can be reverted' do
1119
      it 'reverts the changes' do
1120 1121 1122 1123 1124
        expect(repository.revert(user, update_image_commit, 'master')).to be_truthy
      end
    end

    context 'reverting a merge commit' do
1125
      it 'reverts the changes' do
1126 1127 1128 1129 1130 1131
        merge_commit
        expect(repository.blob_at_branch('master', 'files/ruby/feature.rb')).to be_present

        repository.revert(user, merge_commit, 'master')
        expect(repository.blob_at_branch('master', 'files/ruby/feature.rb')).not_to be_present
      end
1132 1133
    end
  end
1134

P
P.S.V.R 已提交
1135 1136 1137 1138 1139 1140
  describe '#cherry_pick' do
    let(:conflict_commit) { repository.commit('c642fe9b8b9f28f9225d7ea953fe14e74748d53b') }
    let(:pickable_commit) { repository.commit('7d3b0f7cff5f37573aea97cebfd5692ea1689924') }
    let(:pickable_merge) { repository.commit('e56497bb5f03a90a51293fc6d516788730953899') }

    context 'when there is a conflict' do
1141
      it 'aborts the operation' do
P
P.S.V.R 已提交
1142 1143 1144 1145 1146
        expect(repository.cherry_pick(user, conflict_commit, 'master')).to eq(false)
      end
    end

    context 'when commit was already cherry-picked' do
1147
      it 'aborts the operation' do
P
P.S.V.R 已提交
1148 1149 1150 1151 1152 1153 1154
        repository.cherry_pick(user, pickable_commit, 'master')

        expect(repository.cherry_pick(user, pickable_commit, 'master')).to eq(false)
      end
    end

    context 'when commit can be cherry-picked' do
1155
      it 'cherry-picks the changes' do
P
P.S.V.R 已提交
1156 1157 1158 1159 1160
        expect(repository.cherry_pick(user, pickable_commit, 'master')).to be_truthy
      end
    end

    context 'cherry-picking a merge commit' do
1161
      it 'cherry-picks the changes' do
1162
        expect(repository.blob_at_branch('improve/awesome', 'foo/bar/.gitkeep')).to be_nil
P
P.S.V.R 已提交
1163

1164 1165
        repository.cherry_pick(user, pickable_merge, 'improve/awesome')
        expect(repository.blob_at_branch('improve/awesome', 'foo/bar/.gitkeep')).not_to be_nil
P
P.S.V.R 已提交
1166 1167 1168 1169
      end
    end
  end

1170 1171 1172 1173 1174 1175 1176
  describe '#before_delete' do
    describe 'when a repository does not exist' do
      before do
        allow(repository).to receive(:exists?).and_return(false)
      end

      it 'does not flush caches that depend on repository data' do
1177
        expect(repository).not_to receive(:expire_cache)
1178 1179 1180 1181

        repository.before_delete
      end

1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193
      it 'flushes the tags cache' do
        expect(repository).to receive(:expire_tags_cache)

        repository.before_delete
      end

      it 'flushes the branches cache' do
        expect(repository).to receive(:expire_branches_cache)

        repository.before_delete
      end

1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204
      it 'flushes the root ref cache' do
        expect(repository).to receive(:expire_root_ref_cache)

        repository.before_delete
      end

      it 'flushes the emptiness caches' do
        expect(repository).to receive(:expire_emptiness_caches)

        repository.before_delete
      end
1205 1206

      it 'flushes the exists cache' do
1207
        expect(repository).to receive(:expire_exists_cache).twice
1208 1209 1210

        repository.before_delete
      end
1211 1212 1213 1214 1215 1216 1217
    end

    describe 'when a repository exists' do
      before do
        allow(repository).to receive(:exists?).and_return(true)
      end

1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229
      it 'flushes the tags cache' do
        expect(repository).to receive(:expire_tags_cache)

        repository.before_delete
      end

      it 'flushes the branches cache' do
        expect(repository).to receive(:expire_branches_cache)

        repository.before_delete
      end

1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257
      it 'flushes the root ref cache' do
        expect(repository).to receive(:expire_root_ref_cache)

        repository.before_delete
      end

      it 'flushes the emptiness caches' do
        expect(repository).to receive(:expire_emptiness_caches)

        repository.before_delete
      end
    end
  end

  describe '#before_change_head' do
    it 'flushes the branch cache' do
      expect(repository).to receive(:expire_branch_cache)

      repository.before_change_head
    end

    it 'flushes the root ref cache' do
      expect(repository).to receive(:expire_root_ref_cache)

      repository.before_change_head
    end
  end

1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275
  describe '#after_change_head' do
    it 'flushes the readme cache' do
      expect(repository).to receive(:expire_method_caches).with([
        :readme,
        :changelog,
        :license,
        :contributing,
        :version,
        :gitignore,
        :koding,
        :gitlab_ci,
        :avatar
      ])

      repository.after_change_head
    end
  end

Y
Yorick Peterse 已提交
1276
  describe '#before_push_tag' do
1277
    it 'flushes the cache' do
1278 1279 1280
      expect(repository).to receive(:expire_statistics_caches)
      expect(repository).to receive(:expire_emptiness_caches)
      expect(repository).to receive(:expire_tags_cache)
1281

Y
Yorick Peterse 已提交
1282
      repository.before_push_tag
1283 1284 1285
    end
  end

1286
  describe '#before_import' do
1287 1288
    it 'flushes the repository caches' do
      expect(repository).to receive(:expire_content_cache)
1289 1290 1291 1292 1293

      repository.before_import
    end
  end

1294
  describe '#after_import' do
1295 1296
    it 'flushes and builds the cache' do
      expect(repository).to receive(:expire_content_cache)
1297 1298
      expect(repository).to receive(:expire_tags_cache)
      expect(repository).to receive(:expire_branches_cache)
1299 1300 1301

      repository.after_import
    end
1302 1303 1304
  end

  describe '#after_push_commit' do
1305 1306 1307 1308 1309 1310 1311
    it 'expires statistics caches' do
      expect(repository).to receive(:expire_statistics_caches).
        and_call_original

      expect(repository).to receive(:expire_branch_cache).
        with('master').
        and_call_original
1312

1313
      repository.after_push_commit('master')
1314 1315 1316 1317
    end
  end

  describe '#after_create_branch' do
1318
    it 'expires the branch caches' do
1319
      expect(repository).to receive(:expire_branches_cache)
1320 1321 1322 1323 1324 1325

      repository.after_create_branch
    end
  end

  describe '#after_remove_branch' do
1326
    it 'expires the branch caches' do
1327
      expect(repository).to receive(:expire_branches_cache)
1328 1329 1330 1331

      repository.after_remove_branch
    end
  end
1332

1333 1334 1335 1336 1337 1338
  describe '#after_create' do
    it 'flushes the exists cache' do
      expect(repository).to receive(:expire_exists_cache)

      repository.after_create
    end
1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350

    it 'flushes the root ref cache' do
      expect(repository).to receive(:expire_root_ref_cache)

      repository.after_create
    end

    it 'flushes the emptiness caches' do
      expect(repository).to receive(:expire_emptiness_caches)

      repository.after_create
    end
1351 1352
  end

1353 1354 1355 1356 1357 1358 1359 1360 1361 1362
  describe "#copy_gitattributes" do
    it 'returns true with a valid ref' do
      expect(repository.copy_gitattributes('master')).to be_truthy
    end

    it 'returns false with an invalid ref' do
      expect(repository.copy_gitattributes('invalid')).to be_falsey
    end
  end

Y
Yorick Peterse 已提交
1363 1364
  describe '#before_remove_tag' do
    it 'flushes the tag cache' do
1365 1366
      expect(repository).to receive(:expire_tags_cache).and_call_original
      expect(repository).to receive(:expire_statistics_caches).and_call_original
Y
Yorick Peterse 已提交
1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383

      repository.before_remove_tag
    end
  end

  describe '#branch_count' do
    it 'returns the number of branches' do
      expect(repository.branch_count).to be_an_instance_of(Fixnum)
    end
  end

  describe '#tag_count' do
    it 'returns the number of tags' do
      expect(repository.tag_count).to be_an_instance_of(Fixnum)
    end
  end

1384
  describe '#expire_branches_cache' do
Y
Yorick Peterse 已提交
1385
    it 'expires the cache' do
1386 1387 1388
      expect(repository).to receive(:expire_method_caches).
        with(%i(branch_names branch_count)).
        and_call_original
Y
Yorick Peterse 已提交
1389

1390
      repository.expire_branches_cache
Y
Yorick Peterse 已提交
1391 1392 1393
    end
  end

1394
  describe '#expire_tags_cache' do
Y
Yorick Peterse 已提交
1395
    it 'expires the cache' do
1396 1397 1398
      expect(repository).to receive(:expire_method_caches).
        with(%i(tag_names tag_count)).
        and_call_original
Y
Yorick Peterse 已提交
1399

1400
      repository.expire_tags_cache
Y
Yorick Peterse 已提交
1401 1402
    end
  end
1403

1404
  describe '#add_tag' do
1405 1406
    context 'with a valid target' do
      let(:user) { build_stubbed(:user) }
1407

1408 1409 1410 1411 1412 1413
      it 'creates the tag using rugged' do
        expect(repository.rugged.tags).to receive(:create).
          with('8.5', repository.commit('master').id,
            hash_including(message: 'foo',
                           tagger: hash_including(name: user.name, email: user.email))).
          and_call_original
1414

1415 1416 1417 1418 1419 1420 1421 1422
        repository.add_tag(user, '8.5', 'master', 'foo')
      end

      it 'returns a Gitlab::Git::Tag object' do
        tag = repository.add_tag(user, '8.5', 'master', 'foo')

        expect(tag).to be_a(Gitlab::Git::Tag)
      end
1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448

      it 'passes commit SHA to pre-receive and update hooks,\
        and tag SHA to post-receive hook' do
        pre_receive_hook = Gitlab::Git::Hook.new('pre-receive', repository.path_to_repo)
        update_hook = Gitlab::Git::Hook.new('update', repository.path_to_repo)
        post_receive_hook = Gitlab::Git::Hook.new('post-receive', repository.path_to_repo)

        allow(Gitlab::Git::Hook).to receive(:new).
          and_return(pre_receive_hook, update_hook, post_receive_hook)

        allow(pre_receive_hook).to receive(:trigger).and_call_original
        allow(update_hook).to receive(:trigger).and_call_original
        allow(post_receive_hook).to receive(:trigger).and_call_original

        tag = repository.add_tag(user, '8.5', 'master', 'foo')

        commit_sha = repository.commit('master').id
        tag_sha = tag.target

        expect(pre_receive_hook).to have_received(:trigger).
          with(anything, anything, commit_sha, anything)
        expect(update_hook).to have_received(:trigger).
          with(anything, anything, commit_sha, anything)
        expect(post_receive_hook).to have_received(:trigger).
          with(anything, anything, tag_sha, anything)
      end
1449 1450 1451 1452 1453 1454
    end

    context 'with an invalid target' do
      it 'returns false' do
        expect(repository.add_tag(user, '8.5', 'bar', 'foo')).to be false
      end
1455 1456 1457
    end
  end

1458 1459 1460 1461 1462 1463 1464 1465 1466 1467
  describe '#rm_branch' do
    let(:user) { create(:user) }

    it 'removes a branch' do
      expect(repository).to receive(:before_remove_branch)
      expect(repository).to receive(:after_remove_branch)

      repository.rm_branch(user, 'feature')
    end
  end
1468 1469 1470 1471 1472

  describe '#rm_tag' do
    it 'removes a tag' do
      expect(repository).to receive(:before_remove_tag)

L
Lin Jen-Shin 已提交
1473 1474 1475
      repository.rm_tag(create(:user), 'v1.1.0')

      expect(repository.find_tag('v1.1.0')).to be_nil
1476 1477
    end
  end
1478 1479

  describe '#avatar' do
1480
    it 'returns nil if repo does not exist' do
1481 1482
      expect(repository).to receive(:file_on_head).
        and_raise(Rugged::ReferenceError)
1483 1484 1485 1486

      expect(repository.avatar).to eq(nil)
    end

1487
    it 'returns the first avatar file found in the repository' do
1488 1489 1490
      expect(repository).to receive(:file_on_head).
        with(:avatar).
        and_return(double(:tree, path: 'logo.png'))
1491 1492 1493 1494 1495

      expect(repository.avatar).to eq('logo.png')
    end

    it 'caches the output' do
1496 1497 1498 1499
      expect(repository).to receive(:file_on_head).
        with(:avatar).
        once.
        and_return(double(:tree, path: 'logo.png'))
1500

1501
      2.times { expect(repository.avatar).to eq('logo.png') }
1502 1503
    end
  end
1504

1505 1506 1507 1508 1509 1510 1511 1512 1513 1514
  describe '#expire_exists_cache' do
    let(:cache) { repository.send(:cache) }

    it 'expires the cache' do
      expect(cache).to receive(:expire).with(:exists?)

      repository.expire_exists_cache
    end
  end

1515
  describe "#keep_around" do
1516 1517 1518 1519
    it "does not fail if we attempt to reference bad commit" do
      expect(repository.kept_around?('abc1234')).to be_falsey
    end

1520 1521 1522 1523 1524
    it "stores a reference to the specified commit sha so it isn't garbage collected" do
      repository.keep_around(sample_commit.id)

      expect(repository.kept_around?(sample_commit.id)).to be_truthy
    end
1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540

    it "attempting to call keep_around on truncated ref does not fail" do
      repository.keep_around(sample_commit.id)
      ref = repository.send(:keep_around_ref_name, sample_commit.id)
      path = File.join(repository.path, ref)
      # Corrupt the reference
      File.truncate(path, 0)

      expect(repository.kept_around?(sample_commit.id)).to be_falsey

      repository.keep_around(sample_commit.id)

      expect(repository.kept_around?(sample_commit.id)).to be_falsey

      File.delete(path)
    end
1541
  end
1542

1543
  describe '#update_ref' do
1544
    it 'can create a ref' do
1545
      GitOperationService.new(nil, repository).send(:update_ref, 'refs/heads/foobar', 'refs/heads/master', Gitlab::Git::BLANK_SHA)
1546 1547 1548 1549 1550 1551

      expect(repository.find_branch('foobar')).not_to be_nil
    end

    it 'raises CommitError when the ref update fails' do
      expect do
1552
        GitOperationService.new(nil, repository).send(:update_ref, 'refs/heads/master', 'refs/heads/master', Gitlab::Git::BLANK_SHA)
1553 1554 1555
      end.to raise_error(Repository::CommitError)
    end
  end
1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570

  describe '#contribution_guide', caching: true do
    it 'returns and caches the output' do
      expect(repository).to receive(:file_on_head).
        with(:contributing).
        and_return(Gitlab::Git::Tree.new(path: 'CONTRIBUTING.md')).
        once

      2.times do
        expect(repository.contribution_guide).
          to be_an_instance_of(Gitlab::Git::Tree)
      end
    end
  end

1571
  describe '#gitignore', caching: true do
1572 1573
    it 'returns and caches the output' do
      expect(repository).to receive(:file_on_head).
1574 1575
        with(:gitignore).
        and_return(Gitlab::Git::Tree.new(path: '.gitignore')).
1576 1577 1578
        once

      2.times do
1579
        expect(repository.gitignore).to be_an_instance_of(Gitlab::Git::Tree)
1580 1581 1582 1583
      end
    end
  end

1584
  describe '#koding_yml', caching: true do
1585 1586
    it 'returns and caches the output' do
      expect(repository).to receive(:file_on_head).
1587 1588
        with(:koding).
        and_return(Gitlab::Git::Tree.new(path: '.koding.yml')).
1589 1590 1591
        once

      2.times do
1592
        expect(repository.koding_yml).to be_an_instance_of(Gitlab::Git::Tree)
1593 1594 1595 1596
      end
    end
  end

1597 1598 1599 1600
  describe '#readme', caching: true do
    context 'with a non-existing repository' do
      it 'returns nil' do
        expect(repository).to receive(:tree).with(:head).and_return(nil)
1601

1602 1603 1604
        expect(repository.readme).to be_nil
      end
    end
1605

1606 1607 1608
    context 'with an existing repository' do
      it 'returns the README' do
        expect(repository.readme).to be_an_instance_of(Gitlab::Git::Blob)
1609 1610 1611 1612
      end
    end
  end

1613 1614 1615 1616
  describe '#expire_statistics_caches' do
    it 'expires the caches' do
      expect(repository).to receive(:expire_method_caches).
        with(%i(size commit_count))
1617

1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660
      repository.expire_statistics_caches
    end
  end

  describe '#expire_method_caches' do
    it 'expires the caches of the given methods' do
      expect_any_instance_of(RepositoryCache).to receive(:expire).with(:readme)
      expect_any_instance_of(RepositoryCache).to receive(:expire).with(:gitignore)

      repository.expire_method_caches(%i(readme gitignore))
    end
  end

  describe '#expire_all_method_caches' do
    it 'expires the caches of all methods' do
      expect(repository).to receive(:expire_method_caches).
        with(Repository::CACHED_METHODS)

      repository.expire_all_method_caches
    end
  end

  describe '#file_on_head' do
    context 'with a non-existing repository' do
      it 'returns nil' do
        expect(repository).to receive(:tree).with(:head).and_return(nil)

        expect(repository.file_on_head(:readme)).to be_nil
      end
    end

    context 'with a repository that has no blobs' do
      it 'returns nil' do
        expect_any_instance_of(Tree).to receive(:blobs).and_return([])

        expect(repository.file_on_head(:readme)).to be_nil
      end
    end

    context 'with an existing repository' do
      it 'returns a Gitlab::Git::Tree' do
        expect(repository.file_on_head(:readme)).
          to be_an_instance_of(Gitlab::Git::Tree)
1661 1662 1663 1664
      end
    end
  end

1665 1666 1667 1668 1669 1670
  describe '#head_tree' do
    context 'with an existing repository' do
      it 'returns a Tree' do
        expect(repository.head_tree).to be_an_instance_of(Tree)
      end
    end
1671

1672 1673 1674 1675 1676
    context 'with a non-existing repository' do
      it 'returns nil' do
        expect(repository).to receive(:head_commit).and_return(nil)

        expect(repository.head_tree).to be_nil
1677 1678 1679 1680
      end
    end
  end

1681 1682 1683 1684 1685
  describe '#tree' do
    context 'using a non-existing repository' do
      before do
        allow(repository).to receive(:head_commit).and_return(nil)
      end
1686

1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751
      it 'returns nil' do
        expect(repository.tree(:head)).to be_nil
      end

      it 'returns nil when using a path' do
        expect(repository.tree(:head, 'README.md')).to be_nil
      end
    end

    context 'using an existing repository' do
      it 'returns a Tree' do
        expect(repository.tree(:head)).to be_an_instance_of(Tree)
      end
    end
  end

  describe '#size' do
    context 'with a non-existing repository' do
      it 'returns 0' do
        expect(repository).to receive(:exists?).and_return(false)

        expect(repository.size).to eq(0.0)
      end
    end

    context 'with an existing repository' do
      it 'returns the repository size as a Float' do
        expect(repository.size).to be_an_instance_of(Float)
      end
    end
  end

  describe '#commit_count' do
    context 'with a non-existing repository' do
      it 'returns 0' do
        expect(repository).to receive(:root_ref).and_return(nil)

        expect(repository.commit_count).to eq(0)
      end
    end

    context 'with an existing repository' do
      it 'returns the commit count' do
        expect(repository.commit_count).to be_an_instance_of(Fixnum)
      end
    end
  end

  describe '#cache_method_output', caching: true do
    context 'with a non-existing repository' do
      let(:value) do
        repository.cache_method_output(:cats, fallback: 10) do
          raise Rugged::ReferenceError
        end
      end

      it 'returns a fallback value' do
        expect(value).to eq(10)
      end

      it 'does not cache the data' do
        value

        expect(repository.instance_variable_defined?(:@cats)).to eq(false)
        expect(repository.send(:cache).exist?(:cats)).to eq(false)
1752 1753
      end
    end
1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783

    context 'with an existing repository' do
      it 'caches the output' do
        object = double

        expect(object).to receive(:number).once.and_return(10)

        2.times do
          val = repository.cache_method_output(:cats) { object.number }

          expect(val).to eq(10)
        end

        expect(repository.send(:cache).exist?(:cats)).to eq(true)
        expect(repository.instance_variable_get(:@cats)).to eq(10)
      end
    end
  end

  describe '#refresh_method_caches' do
    it 'refreshes the caches of the given types' do
      expect(repository).to receive(:expire_method_caches).
        with(%i(readme license_blob license_key))

      expect(repository).to receive(:readme)
      expect(repository).to receive(:license_blob)
      expect(repository).to receive(:license_key)

      repository.refresh_method_caches(%i(readme license))
    end
1784
  end
D
Douwe Maan 已提交
1785 1786 1787

  describe '#gitlab_ci_yml_for' do
    before do
D
Douwe Maan 已提交
1788
      repository.commit_file(User.last, '.gitlab-ci.yml', 'CONTENT', message: 'Add .gitlab-ci.yml', branch_name: 'master', update: false)
D
Douwe Maan 已提交
1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805
    end

    context 'when there is a .gitlab-ci.yml at the commit' do
      it 'returns the content' do
        expect(repository.gitlab_ci_yml_for(repository.commit.sha)).to eq('CONTENT')
      end
    end

    context 'when there is no .gitlab-ci.yml at the commit' do
      it 'returns nil' do
        expect(repository.gitlab_ci_yml_for(repository.commit.parent.sha)).to be_nil
      end
    end
  end

  describe '#route_map_for' do
    before do
D
Douwe Maan 已提交
1806
      repository.commit_file(User.last, '.gitlab/route-map.yml', 'CONTENT', message: 'Add .gitlab/route-map.yml', branch_name: 'master', update: false)
D
Douwe Maan 已提交
1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820
    end

    context 'when there is a .gitlab/route-map.yml at the commit' do
      it 'returns the content' do
        expect(repository.route_map_for(repository.commit.sha)).to eq('CONTENT')
      end
    end

    context 'when there is no .gitlab/route-map.yml at the commit' do
      it 'returns nil' do
        expect(repository.route_map_for(repository.commit.parent.sha)).to be_nil
      end
    end
  end
1821
end