repository_spec.rb 57.9 KB
Newer Older
1 2
require 'spec_helper'

D
Douwe Maan 已提交
3
describe Repository, models: true do
4
  include RepoHelpers
D
Douwe Maan 已提交
5
  TestBlob = Struct.new(:path)
6

7
  let(:project) { create(:project, :repository) }
8
  let(:repository) { project.repository }
9
  let(:user) { create(:user) }
10

11 12 13 14
  let(:commit_options) do
    author = repository.user_to_committer(user)
    { message: 'Test message', committer: author, author: author }
  end
15

R
Rubén Dávila 已提交
16
  let(:merge_commit) do
17
    merge_request = create(:merge_request, source_branch: 'feature', target_branch: 'master', source_project: project)
S
Sean McGivern 已提交
18 19 20 21 22 23

    merge_commit_id = repository.merge(user,
                                       merge_request.diff_head_sha,
                                       merge_request,
                                       commit_options)

24
    repository.commit(merge_commit_id)
25
  end
26

27 28
  let(:author_email) { 'user@example.org' }
  let(:author_name) { 'John Doe' }
29

30
  describe '#branch_names_contains' do
31 32
    subject { repository.branch_names_contains(sample_commit.id) }

33 34 35
    it { is_expected.to include('master') }
    it { is_expected.not_to include('feature') }
    it { is_expected.not_to include('fix') }
36
  end
37

38
  describe '#tag_names_contains' do
D
Dmitriy Zaporozhets 已提交
39
    subject { repository.tag_names_contains(sample_commit.id) }
40

D
Dmitriy Zaporozhets 已提交
41 42
    it { is_expected.to include('v1.1.0') }
    it { is_expected.not_to include('v1.0.0') }
43 44
  end

45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62
  describe 'tags_sorted_by' do
    context 'name' do
      subject { repository.tags_sorted_by('name').map(&:name) }

      it { is_expected.to eq(['v1.1.0', 'v1.0.0']) }
    end

    context 'updated' do
      let(:tag_a) { repository.find_tag('v1.0.0') }
      let(:tag_b) { repository.find_tag('v1.1.0') }

      context 'desc' do
        subject { repository.tags_sorted_by('updated_desc').map(&:name) }

        before do
          double_first = double(committed_date: Time.now)
          double_last = double(committed_date: Time.now - 1.second)

63 64
          allow(tag_a).to receive(:dereferenced_target).and_return(double_first)
          allow(tag_b).to receive(:dereferenced_target).and_return(double_last)
65
          allow(repository).to receive(:tags).and_return([tag_a, tag_b])
66 67 68 69 70 71 72 73 74 75 76 77
        end

        it { is_expected.to eq(['v1.0.0', 'v1.1.0']) }
      end

      context 'asc' do
        subject { repository.tags_sorted_by('updated_asc').map(&:name) }

        before do
          double_first = double(committed_date: Time.now - 1.second)
          double_last = double(committed_date: Time.now)

78 79
          allow(tag_a).to receive(:dereferenced_target).and_return(double_last)
          allow(tag_b).to receive(:dereferenced_target).and_return(double_first)
80
          allow(repository).to receive(:tags).and_return([tag_a, tag_b])
81 82 83 84
        end

        it { is_expected.to eq(['v1.1.0', 'v1.0.0']) }
      end
85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108

      context 'annotated tag pointing to a blob' do
        let(:annotated_tag_name) { 'annotated-tag' }

        subject { repository.tags_sorted_by('updated_asc').map(&:name) }

        before do
          options = { message: 'test tag message\n',
                      tagger: { name: 'John Smith', email: 'john@gmail.com' } }
          repository.rugged.tags.create(annotated_tag_name, 'a48e4fc218069f68ef2e769dd8dfea3991362175', options)

          double_first = double(committed_date: Time.now - 1.second)
          double_last = double(committed_date: Time.now)

          allow(tag_a).to receive(:dereferenced_target).and_return(double_last)
          allow(tag_b).to receive(:dereferenced_target).and_return(double_first)
        end

        it { is_expected.to eq(['v1.1.0', 'v1.0.0', annotated_tag_name]) }

        after do
          repository.rugged.tags.delete(annotated_tag_name)
        end
      end
109 110 111
    end
  end

112
  describe '#ref_name_for_sha' do
113 114 115
    it 'returns the ref' do
      allow(repository.raw_repository).to receive(:ref_name_for_sha).
        and_return('refs/environments/production/77')
116

117
      expect(repository.ref_name_for_sha('bla', '0' * 40)).to eq 'refs/environments/production/77'
118 119 120
    end
  end

121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140
  describe '#ref_exists?' do
    context 'when ref exists' do
      it 'returns true' do
        expect(repository.ref_exists?('refs/heads/master')).to be true
      end
    end

    context 'when ref does not exist' do
      it 'returns false' do
        expect(repository.ref_exists?('refs/heads/non-existent')).to be false
      end
    end

    context 'when ref format is incorrect' do
      it 'returns false' do
        expect(repository.ref_exists?('refs/heads/invalid:master')).to be false
      end
    end
  end

141
  describe '#last_commit_for_path' do
D
Dmitriy Zaporozhets 已提交
142
    subject { repository.last_commit_for_path(sample_commit.id, '.gitignore').id }
143

D
Dmitriy Zaporozhets 已提交
144
    it { is_expected.to eq('c1acaa58bbcbc3eafe538cb8274ba387047b69f8') }
145
  end
146

H
Hiroyuki Sato 已提交
147 148 149
  describe '#last_commit_id_for_path' do
    subject { repository.last_commit_id_for_path(sample_commit.id, '.gitignore') }

H
Hiroyuki Sato 已提交
150 151 152
    it "returns last commit id for a given path" do
      is_expected.to eq('c1acaa58bbcbc3eafe538cb8274ba387047b69f8')
    end
H
Hiroyuki Sato 已提交
153

H
Hiroyuki Sato 已提交
154
    it "caches last commit id for a given path" do
H
Hiroyuki Sato 已提交
155 156
      cache = repository.send(:cache)
      key = "last_commit_id_for_path:#{sample_commit.id}:#{Digest::SHA1.hexdigest('.gitignore')}"
157

H
Hiroyuki Sato 已提交
158
      expect(cache).to receive(:fetch).with(key).and_return('c1acaa5')
H
Hiroyuki Sato 已提交
159
      is_expected.to eq('c1acaa5')
H
Hiroyuki Sato 已提交
160 161 162
    end
  end

163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183
  describe '#commits' do
    it 'sets follow when path is a single path' do
      expect(Gitlab::Git::Commit).to receive(:where).with(a_hash_including(follow: true)).and_call_original.twice

      repository.commits('master', path: 'README.md')
      repository.commits('master', path: ['README.md'])
    end

    it 'does not set follow when path is multiple paths' do
      expect(Gitlab::Git::Commit).to receive(:where).with(a_hash_including(follow: false)).and_call_original

      repository.commits('master', path: ['README.md', 'CHANGELOG'])
    end

    it 'does not set follow when there are no paths' do
      expect(Gitlab::Git::Commit).to receive(:where).with(a_hash_including(follow: false)).and_call_original

      repository.commits('master')
    end
  end

184
  describe '#find_commits_by_message' do
185 186
    it 'returns commits with messages containing a given string' do
      commit_ids = repository.find_commits_by_message('submodule').map(&:id)
187

188 189 190 191 192 193 194 195 196 197 198
      expect(commit_ids).to include('5937ac0a7beb003549fc5fd26fc247adbce4a52e')
      expect(commit_ids).to include('6f6d7e7ed97bb5f0054f2b1df789b39ca89b6ff9')
      expect(commit_ids).to include('cfe32cf61b73a0d5e9f13e774abde7ff789b1660')
      expect(commit_ids).not_to include('913c66a37b4a45b9769037c55c2d238bd0942d2e')
    end

    it 'is case insensitive' do
      commit_ids = repository.find_commits_by_message('SUBMODULE').map(&:id)

      expect(commit_ids).to include('5937ac0a7beb003549fc5fd26fc247adbce4a52e')
    end
199 200
  end

201
  describe '#blob_at' do
202 203 204 205 206 207
    context 'blank sha' do
      subject { repository.blob_at(Gitlab::Git::BLANK_SHA, '.gitignore') }

      it { is_expected.to be_nil }
    end
  end
208

209
  describe '#merged_to_root_ref?' do
210
    context 'merged branch without ff' do
211
      subject { repository.merged_to_root_ref?('branch-merged') }
F
Florent (HP) 已提交
212 213 214

      it { is_expected.to be_truthy }
    end
215

216 217
    # If the HEAD was ff then it will be false
    context 'merged with ff' do
F
Florent (HP) 已提交
218 219 220 221
      subject { repository.merged_to_root_ref?('improve/awesome') }

      it { is_expected.to be_truthy }
    end
222

223 224 225 226 227
    context 'not merged branch' do
      subject { repository.merged_to_root_ref?('not-merged-branch') }

      it { is_expected.to be_falsey }
    end
228 229 230 231 232 233

    context 'default branch' do
      subject { repository.merged_to_root_ref?('master') }

      it { is_expected.to be_falsey }
    end
234 235
  end

236
  describe '#can_be_merged?' do
237 238 239 240 241 242 243 244 245 246 247
    context 'mergeable branches' do
      subject { repository.can_be_merged?('0b4bc9a49b562e85de7cc9e834518ea6828729b9', 'master') }

      it { is_expected.to be_truthy }
    end

    context 'non-mergeable branches' do
      subject { repository.can_be_merged?('bb5206fee213d983da88c47f9cf4cc6caf9c66dc', 'feature') }

      it { is_expected.to be_falsey }
    end
F
Florent (HP) 已提交
248 249 250 251 252 253 254 255 256 257 258 259

    context 'non merged branch' do
      subject { repository.merged_to_root_ref?('fix') }

      it { is_expected.to be_falsey }
    end

    context 'non existent branch' do
      subject { repository.merged_to_root_ref?('non_existent_branch') }

      it { is_expected.to be_nil }
    end
260 261
  end

262 263 264
  describe '#commit' do
    context 'when ref exists' do
      it 'returns commit object' do
D
Douwe Maan 已提交
265 266
        expect(repository.commit('master'))
          .to be_an_instance_of Commit
267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290
      end
    end

    context 'when ref does not exist' do
      it 'returns nil' do
        expect(repository.commit('non-existent-ref')).to be_nil
      end
    end

    context 'when ref is not valid' do
      context 'when preceding tree element exists' do
        it 'returns nil' do
          expect(repository.commit('master:ref')).to be_nil
        end
      end

      context 'when preceding tree element does not exist' do
        it 'returns nil' do
          expect(repository.commit('non-existent:ref')).to be_nil
        end
      end
    end
  end

D
Douwe Maan 已提交
291
  describe "#create_dir" do
292 293
    it "commits a change that creates a new directory" do
      expect do
294
        repository.create_dir(user, 'newdir',
295
          message: 'Create newdir', branch_name: 'master')
296 297 298 299 300 301
      end.to change { repository.commits('master').count }.by(1)

      newdir = repository.tree('master', 'newdir')
      expect(newdir.path).to eq('newdir')
    end

302 303 304 305 306
    context "when committing to another project" do
      let(:forked_project) { create(:project) }

      it "creates a fork and commit to the forked project" do
        expect do
307
          repository.create_dir(user, 'newdir',
308
            message: 'Create newdir', branch_name: 'patch',
L
Lin Jen-Shin 已提交
309
            start_branch_name: 'master', start_project: forked_project)
310 311 312 313 314 315 316 317 318 319
        end.to change { repository.commits('master').count }.by(0)

        expect(repository.branch_exists?('patch')).to be_truthy
        expect(forked_project.repository.branch_exists?('patch')).to be_falsy

        newdir = repository.tree('patch', 'newdir')
        expect(newdir.path).to eq('newdir')
      end
    end

320 321 322
    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
        expect do
323
          repository.create_dir(user, 'newdir',
324 325 326
            message: 'Add newdir',
            branch_name: 'master',
            author_email: author_email, author_name: author_name)
327 328 329 330 331 332 333 334 335 336
        end.to change { repository.commits('master').count }.by(1)

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
  end

337 338
  describe "#create_file" do
    it 'commits new file successfully' do
339
      expect do
340 341 342
        repository.create_file(user, 'NEWCHANGELOG', 'Changelog!',
                               message: 'Create changelog',
                               branch_name: 'master')
343 344
      end.to change { repository.commits('master').count }.by(1)

345
      blob = repository.blob_at('master', 'NEWCHANGELOG')
346

347
      expect(blob.data).to eq('Changelog!')
348
    end
349

350
    it 'respects the autocrlf setting' do
351
      repository.create_file(user, 'hello.txt', "Hello,\r\nWorld",
352
                             message: 'Add hello world',
353
                             branch_name: 'master')
354 355 356 357 358 359

      blob = repository.blob_at('master', 'hello.txt')

      expect(blob.data).to eq("Hello,\nWorld")
    end

360 361 362
    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
        expect do
363
          repository.create_file(user, 'NEWREADME', 'README!',
364 365 366 367
                                 message: 'Add README',
                                 branch_name: 'master',
                                 author_email: author_email,
                                 author_name: author_name)
368 369 370 371 372 373 374 375
        end.to change { repository.commits('master').count }.by(1)

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
376 377
  end

378
  describe "#update_file" do
379 380 381 382 383 384 385 386 387 388 389 390
    it 'updates file successfully' do
      expect do
        repository.update_file(user, 'CHANGELOG', 'Changelog!',
                               message: 'Update changelog',
                               branch_name: 'master')
      end.to change { repository.commits('master').count }.by(1)

      blob = repository.blob_at('master', 'CHANGELOG')

      expect(blob.data).to eq('Changelog!')
    end

T
tiagonbotelho 已提交
391
    it 'updates filename successfully' do
392 393
      expect do
        repository.update_file(user, 'NEWLICENSE', 'Copyright!',
394
                                     branch_name: 'master',
T
tiagonbotelho 已提交
395
                                     previous_path: 'LICENSE',
396 397
                                     message: 'Changes filename')
      end.to change { repository.commits('master').count }.by(1)
T
tiagonbotelho 已提交
398 399 400 401 402 403

      files = repository.ls_files('master')

      expect(files).not_to include('LICENSE')
      expect(files).to include('NEWLICENSE')
    end
404 405 406 407

    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
        expect do
408 409 410 411 412 413
          repository.update_file(user, 'README', 'Updated README!',
                                 branch_name: 'master',
                                 previous_path: 'README',
                                 message: 'Update README',
                                 author_email: author_email,
                                 author_name: author_name)
414 415 416 417 418 419 420 421 422 423
        end.to change { repository.commits('master').count }.by(1)

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
  end

D
Douwe Maan 已提交
424
  describe "#delete_file" do
425 426
    it 'removes file successfully' do
      expect do
427
        repository.delete_file(user, 'README',
428
          message: 'Remove README', branch_name: 'master')
429 430 431 432 433 434 435 436
      end.to change { repository.commits('master').count }.by(1)

      expect(repository.blob_at('master', 'README')).to be_nil
    end

    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
        expect do
437
          repository.delete_file(user, 'README',
438 439
            message: 'Remove README', branch_name: 'master',
            author_email: author_email, author_name: author_name)
440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479
        end.to change { repository.commits('master').count }.by(1)

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
  end

  describe '#get_committer_and_author' do
    it 'returns the committer and author data' do
      options = repository.get_committer_and_author(user)
      expect(options[:committer][:email]).to eq(user.email)
      expect(options[:author][:email]).to eq(user.email)
    end

    context 'when the email/name are given' do
      it 'returns an object containing the email/name' do
        options = repository.get_committer_and_author(user, email: author_email, name: author_name)
        expect(options[:author][:email]).to eq(author_email)
        expect(options[:author][:name]).to eq(author_name)
      end
    end

    context 'when the email is given but the name is not' do
      it 'returns the committer as the author' do
        options = repository.get_committer_and_author(user, email: author_email)
        expect(options[:author][:email]).to eq(user.email)
        expect(options[:author][:name]).to eq(user.name)
      end
    end

    context 'when the name is given but the email is not' do
      it 'returns nil' do
        options = repository.get_committer_and_author(user, name: author_name)
        expect(options[:author][:email]).to eq(user.email)
        expect(options[:author][:name]).to eq(user.name)
      end
    end
T
tiagonbotelho 已提交
480 481
  end

V
Valery Sizov 已提交
482 483
  describe "search_files_by_content" do
    let(:results) { repository.search_files_by_content('feature', 'master') }
484 485 486 487
    subject { results }

    it { is_expected.to be_an Array }

488
    it 'regex-escapes the query string' do
V
Valery Sizov 已提交
489
      results = repository.search_files_by_content("test\\", 'master')
490 491 492 493

      expect(results.first).not_to start_with('fatal:')
    end

494
    it 'properly handles an unmatched parenthesis' do
V
Valery Sizov 已提交
495
      results = repository.search_files_by_content("test(", 'master')
496 497 498 499

      expect(results.first).not_to start_with('fatal:')
    end

V
Valery Sizov 已提交
500
    it 'properly handles when query is not present' do
V
Valery Sizov 已提交
501
      results = repository.search_files_by_content('', 'master')
V
Valery Sizov 已提交
502 503 504 505 506 507

      expect(results).to match_array([])
    end

    it 'properly handles query when repo is empty' do
      repository = create(:empty_project).repository
V
Valery Sizov 已提交
508
      results = repository.search_files_by_content('test', 'master')
V
Valery Sizov 已提交
509 510 511 512

      expect(results).to match_array([])
    end

513 514 515 516
    describe 'result' do
      subject { results.first }

      it { is_expected.to be_an String }
517
      it { expect(subject.lines[2]).to eq("master:CHANGELOG:190:  - Feature: Replace teams with group membership\n") }
518 519
    end
  end
Z
Zeger-Jan van de Weg 已提交
520

V
Valery Sizov 已提交
521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542
  describe "search_files_by_name" do
    let(:results) { repository.search_files_by_name('files', 'master') }

    it 'returns result' do
      expect(results.first).to eq('files/html/500.html')
    end

    it 'properly handles when query is not present' do
      results = repository.search_files_by_name('', 'master')

      expect(results).to match_array([])
    end

    it 'properly handles query when repo is empty' do
      repository = create(:empty_project).repository

      results = repository.search_files_by_name('test', 'master')

      expect(results).to match_array([])
    end
  end

543 544 545 546 547 548 549 550 551 552
  describe '#create_ref' do
    it 'redirects the call to fetch_ref' do
      ref, ref_path = '1', '2'

      expect(repository).to receive(:fetch_ref).with(repository.path_to_repo, ref, ref_path)

      repository.create_ref(ref, ref_path)
    end
  end

553
  describe "#changelog", caching: true do
554 555 556
    it 'accepts changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('changelog')])

D
Douwe Maan 已提交
557
      expect(repository.changelog.path).to eq('changelog')
558 559 560 561 562
    end

    it 'accepts news instead of changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('news')])

D
Douwe Maan 已提交
563
      expect(repository.changelog.path).to eq('news')
564 565 566 567 568
    end

    it 'accepts history instead of changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('history')])

D
Douwe Maan 已提交
569
      expect(repository.changelog.path).to eq('history')
570 571 572 573 574
    end

    it 'accepts changes instead of changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('changes')])

D
Douwe Maan 已提交
575
      expect(repository.changelog.path).to eq('changes')
576 577 578 579 580
    end

    it 'is case-insensitive' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('CHANGELOG')])

D
Douwe Maan 已提交
581
      expect(repository.changelog.path).to eq('CHANGELOG')
582 583 584
    end
  end

585
  describe "#license_blob", caching: true do
586
    before do
587
      repository.delete_file(
588
        user, 'LICENSE', message: 'Remove LICENSE', branch_name: 'master')
589 590
    end

591
    it 'handles when HEAD points to non-existent ref' do
592
      repository.create_file(
593
        user, 'LICENSE', 'Copyright!',
594
        message: 'Add LICENSE', branch_name: 'master')
595

596 597
      allow(repository).to receive(:file_on_head).
        and_raise(Rugged::ReferenceError)
598 599 600 601

      expect(repository.license_blob).to be_nil
    end

602
    it 'looks in the root_ref only' do
603
      repository.delete_file(user, 'LICENSE',
604
        message: 'Remove LICENSE', branch_name: 'markdown')
605
      repository.create_file(user, 'LICENSE',
606
        Licensee::License.new('mit').content,
607
        message: 'Add LICENSE', branch_name: 'markdown')
608 609 610 611

      expect(repository.license_blob).to be_nil
    end

612
    it 'detects license file with no recognizable open-source license content' do
613 614
      repository.create_file(user, 'LICENSE', 'Copyright!',
        message: 'Add LICENSE', branch_name: 'master')
615

D
Douwe Maan 已提交
616
      expect(repository.license_blob.path).to eq('LICENSE')
617 618
    end

619 620
    %w[LICENSE LICENCE LiCensE LICENSE.md LICENSE.foo COPYING COPYING.md].each do |filename|
      it "detects '#{filename}'" do
621
        repository.create_file(user, filename,
622
          Licensee::License.new('mit').content,
623
          message: "Add #{filename}", branch_name: 'master')
624

625 626
        expect(repository.license_blob.name).to eq(filename)
      end
627 628 629
    end
  end

630
  describe '#license_key', caching: true do
631
    before do
632
      repository.delete_file(user, 'LICENSE',
633
        message: 'Remove LICENSE', branch_name: 'master')
634
    end
Z
Zeger-Jan van de Weg 已提交
635

636
    it 'returns nil when no license is detected' do
637 638 639
      expect(repository.license_key).to be_nil
    end

640 641 642
    it 'returns nil when the repository does not exist' do
      expect(repository).to receive(:exists?).and_return(false)

643 644 645
      expect(repository.license_key).to be_nil
    end

D
Douwe Maan 已提交
646
    it 'returns nil when the content is not recognizable' do
647 648
      repository.create_file(user, 'LICENSE', 'Copyright!',
        message: 'Add LICENSE', branch_name: 'master')
649 650

      expect(repository.license_key).to be_nil
Z
Zeger-Jan van de Weg 已提交
651
    end
652

653
    it 'returns the license key' do
654
      repository.create_file(user, 'LICENSE',
655
        Licensee::License.new('mit').content,
656
        message: 'Add LICENSE', branch_name: 'master')
657

658
      expect(repository.license_key).to eq('mit')
659
    end
Z
Zeger-Jan van de Weg 已提交
660
  end
661

D
Douwe Maan 已提交
662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694
  describe '#license' do
    before do
      repository.delete_file(user, 'LICENSE',
        message: 'Remove LICENSE', branch_name: 'master')
    end

    it 'returns nil when no license is detected' do
      expect(repository.license).to be_nil
    end

    it 'returns nil when the repository does not exist' do
      expect(repository).to receive(:exists?).and_return(false)

      expect(repository.license).to be_nil
    end

    it 'returns nil when the content is not recognizable' do
      repository.create_file(user, 'LICENSE', 'Copyright!',
        message: 'Add LICENSE', branch_name: 'master')

      expect(repository.license).to be_nil
    end

    it 'returns the license' do
      license = Licensee::License.new('mit')
      repository.create_file(user, 'LICENSE',
        license.content,
        message: 'Add LICENSE', branch_name: 'master')

      expect(repository.license).to eq(license)
    end
  end

695
  describe "#gitlab_ci_yml", caching: true do
696 697 698 699
    it 'returns valid file' do
      files = [TestBlob.new('file'), TestBlob.new('.gitlab-ci.yml'), TestBlob.new('copying')]
      expect(repository.tree).to receive(:blobs).and_return(files)

D
Douwe Maan 已提交
700
      expect(repository.gitlab_ci_yml.path).to eq('.gitlab-ci.yml')
701 702 703 704 705 706 707 708
    end

    it 'returns nil if not exists' do
      expect(repository.tree).to receive(:blobs).and_return([])
      expect(repository.gitlab_ci_yml).to be_nil
    end

    it 'returns nil for empty repository' do
709
      allow(repository).to receive(:file_on_head).and_raise(Rugged::ReferenceError)
710 711 712 713
      expect(repository.gitlab_ci_yml).to be_nil
    end
  end

714
  describe '#add_branch' do
715
    context 'when pre hooks were successful' do
716
      it 'runs without errors' do
717
        hook = double(trigger: [true, nil])
718
        expect(Gitlab::Git::Hook).to receive(:new).exactly(3).times.and_return(hook)
719 720 721 722

        expect { repository.add_branch(user, 'new_feature', 'master') }.not_to raise_error
      end

723
      it 'creates the branch' do
724
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([true, nil])
725 726 727 728 729

        branch = repository.add_branch(user, 'new_feature', 'master')

        expect(branch.name).to eq('new_feature')
      end
730 731 732 733 734 735

      it 'calls the after_create_branch hook' do
        expect(repository).to receive(:after_create_branch)

        repository.add_branch(user, 'new_feature', 'master')
      end
736 737 738
    end

    context 'when pre hooks failed' do
739
      it 'gets an error' do
740
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([false, ''])
741 742 743 744 745 746

        expect do
          repository.add_branch(user, 'new_feature', 'master')
        end.to raise_error(GitHooksService::PreReceiveError)
      end

747
      it 'does not create the branch' do
748
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([false, ''])
749 750 751 752 753 754 755 756 757

        expect do
          repository.add_branch(user, 'new_feature', 'master')
        end.to raise_error(GitHooksService::PreReceiveError)
        expect(repository.find_branch('new_feature')).to be_nil
      end
    end
  end

758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775
  describe '#find_branch' do
    it 'loads a branch with a fresh repo' do
      expect(Gitlab::Git::Repository).to receive(:new).twice.and_call_original

      2.times do
        expect(repository.find_branch('feature')).not_to be_nil
      end
    end

    it 'loads a branch with a cached repo' do
      expect(Gitlab::Git::Repository).to receive(:new).once.and_call_original

      2.times do
        expect(repository.find_branch('feature', fresh_repo: false)).not_to be_nil
      end
    end
  end

776
  describe '#rm_branch' do
777 778 779
    let(:old_rev) { '0b4bc9a49b562e85de7cc9e834518ea6828729b9' } # git rev-parse feature
    let(:blank_sha) { '0000000000000000000000000000000000000000' }

780
    context 'when pre hooks were successful' do
781
      it 'runs without errors' do
782 783
        expect_any_instance_of(GitHooksService).to receive(:execute).
          with(user, project.repository.path_to_repo, old_rev, blank_sha, 'refs/heads/feature')
784 785 786 787

        expect { repository.rm_branch(user, 'feature') }.not_to raise_error
      end

788
      it 'deletes the branch' do
789
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([true, nil])
790 791 792 793 794 795 796 797

        expect { repository.rm_branch(user, 'feature') }.not_to raise_error

        expect(repository.find_branch('feature')).to be_nil
      end
    end

    context 'when pre hooks failed' do
798
      it 'gets an error' do
799
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([false, ''])
800 801

        expect do
802
          repository.rm_branch(user, 'feature')
803 804 805
        end.to raise_error(GitHooksService::PreReceiveError)
      end

806
      it 'does not delete the branch' do
807
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([false, ''])
808 809 810 811 812 813 814 815 816

        expect do
          repository.rm_branch(user, 'feature')
        end.to raise_error(GitHooksService::PreReceiveError)
        expect(repository.find_branch('feature')).not_to be_nil
      end
    end
  end

817
  describe '#update_branch_with_hooks' do
818
    let(:old_rev) { '0b4bc9a49b562e85de7cc9e834518ea6828729b9' } # git rev-parse feature
819
    let(:new_rev) { 'a74ae73c1ccde9b974a70e82b901588071dc142a' } # commit whose parent is old_rev
820

821
    context 'when pre hooks were successful' do
822
      before do
823 824
        service = GitHooksService.new
        expect(GitHooksService).to receive(:new).and_return(service)
825 826
        expect(service).to receive(:execute).
          with(
827 828 829
            user,
            repository.path_to_repo,
            old_rev,
830
            new_rev,
831 832
            'refs/heads/feature').
          and_yield(service).and_return(true)
833
      end
834

835
      it 'runs without errors' do
836
        expect do
837 838 839
          GitOperationService.new(user, repository).with_branch('feature') do
            new_rev
          end
840 841
        end.not_to raise_error
      end
842

843
      it 'ensures the autocrlf Git option is set to :input' do
844 845 846
        service = GitOperationService.new(user, repository)

        expect(service).to receive(:update_autocrlf_option)
847

848
        service.with_branch('feature') { new_rev }
849
      end
850 851 852

      context "when the branch wasn't empty" do
        it 'updates the head' do
853
          expect(repository.find_branch('feature').dereferenced_target.id).to eq(old_rev)
854 855 856 857 858

          GitOperationService.new(user, repository).with_branch('feature') do
            new_rev
          end

859
          expect(repository.find_branch('feature').dereferenced_target.id).to eq(new_rev)
860 861
        end
      end
862 863
    end

864
    context 'when the update adds more than one commit' do
865
      let(:old_rev) { '33f3729a45c02fc67d00adb1b8bca394b0e761d9' }
866

867
      it 'runs without errors' do
868 869 870 871 872 873
        # old_rev is an ancestor of new_rev
        expect(repository.rugged.merge_base(old_rev, new_rev)).to eq(old_rev)

        # old_rev is not a direct ancestor (parent) of new_rev
        expect(repository.rugged.lookup(new_rev).parent_ids).not_to include(old_rev)

874 875 876
        branch = 'feature-ff-target'
        repository.add_branch(user, branch, old_rev)

877 878 879 880 881
        expect do
          GitOperationService.new(user, repository).with_branch(branch) do
            new_rev
          end
        end.not_to raise_error
882 883 884 885
      end
    end

    context 'when the update would remove commits from the target branch' do
886 887
      let(:branch) { 'master' }
      let(:old_rev) { repository.find_branch(branch).dereferenced_target.sha }
888

889
      it 'raises an exception' do
890 891 892 893 894 895
        # The 'master' branch is NOT an ancestor of new_rev.
        expect(repository.rugged.merge_base(old_rev, new_rev)).not_to eq(old_rev)

        # Updating 'master' to new_rev would lose the commits on 'master' that
        # are not contained in new_rev. This should not be allowed.
        expect do
896 897 898
          GitOperationService.new(user, repository).with_branch(branch) do
            new_rev
          end
899
        end.to raise_error(Repository::CommitError)
900 901 902
      end
    end

903
    context 'when pre hooks failed' do
904
      it 'gets an error' do
905
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([false, ''])
906 907

        expect do
908 909 910
          GitOperationService.new(user, repository).with_branch('feature') do
            new_rev
          end
911 912 913
        end.to raise_error(GitHooksService::PreReceiveError)
      end
    end
914 915 916 917 918 919 920 921 922 923 924 925

    context 'when target branch is different from source branch' do
      before do
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([true, ''])
      end

      it 'expires branch cache' do
        expect(repository).not_to receive(:expire_exists_cache)
        expect(repository).not_to receive(:expire_root_ref_cache)
        expect(repository).not_to receive(:expire_emptiness_caches)
        expect(repository).to     receive(:expire_branches_cache)

926 927
        GitOperationService.new(user, repository).
          with_branch('new-feature') do
928 929
            new_rev
          end
930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945
      end
    end

    context 'when repository is empty' do
      before do
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([true, ''])
      end

      it 'expires creation and branch cache' do
        empty_repository = create(:empty_project, :empty_repo).repository

        expect(empty_repository).to receive(:expire_exists_cache)
        expect(empty_repository).to receive(:expire_root_ref_cache)
        expect(empty_repository).to receive(:expire_emptiness_caches)
        expect(empty_repository).to receive(:expire_branches_cache)

946
        empty_repository.create_file(user, 'CHANGELOG', 'Changelog!',
947
                                     message: 'Updates file content',
948
                                     branch_name: 'master')
949 950
      end
    end
951
  end
952

953 954 955 956 957 958
  describe '#exists?' do
    it 'returns true when a repository exists' do
      expect(repository.exists?).to eq(true)
    end

    it 'returns false when a repository does not exist' do
959
      allow(repository).to receive(:refs_directory_exists?).and_return(false)
960 961 962

      expect(repository.exists?).to eq(false)
    end
963 964 965 966 967 968

    it 'returns false when there is no namespace' do
      allow(repository).to receive(:path_with_namespace).and_return(nil)

      expect(repository.exists?).to eq(false)
    end
969 970
  end

971 972 973 974 975
  describe '#has_visible_content?' do
    subject { repository.has_visible_content? }

    describe 'when there are no branches' do
      before do
976
        allow(repository).to receive(:branch_count).and_return(0)
977 978 979 980 981 982
      end

      it { is_expected.to eq(false) }
    end

    describe 'when there are branches' do
983
      it 'returns true' do
984
        expect(repository).to receive(:branch_count).and_return(3)
985 986 987 988 989 990

        expect(subject).to eq(true)
      end
    end
  end

991 992 993 994 995 996 997
  describe '#update_autocrlf_option' do
    describe 'when autocrlf is not already set to :input' do
      before do
        repository.raw_repository.autocrlf = true
      end

      it 'sets autocrlf to :input' do
998
        GitOperationService.new(nil, repository).send(:update_autocrlf_option)
999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009

        expect(repository.raw_repository.autocrlf).to eq(:input)
      end
    end

    describe 'when autocrlf is already set to :input' do
      before do
        repository.raw_repository.autocrlf = :input
      end

      it 'does nothing' do
1010 1011
        expect(repository.raw_repository).not_to receive(:autocrlf=).
          with(:input)
1012

1013
        GitOperationService.new(nil, repository).send(:update_autocrlf_option)
1014 1015 1016 1017
      end
    end
  end

1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029
  describe '#empty?' do
    let(:empty_repository) { create(:project_empty_repo).repository }

    it 'returns true for an empty repository' do
      expect(empty_repository.empty?).to eq(true)
    end

    it 'returns false for a non-empty repository' do
      expect(repository.empty?).to eq(false)
    end

    it 'caches the output' do
1030 1031 1032
      expect(repository.raw_repository).to receive(:empty?).
        once.
        and_return(false)
1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044

      repository.empty?
      repository.empty?
    end
  end

  describe '#root_ref' do
    it 'returns a branch name' do
      expect(repository.root_ref).to be_an_instance_of(String)
    end

    it 'caches the output' do
1045 1046 1047
      expect(repository.raw_repository).to receive(:root_ref).
        once.
        and_return('master')
1048 1049 1050 1051 1052 1053 1054 1055 1056 1057

      repository.root_ref
      repository.root_ref
    end
  end

  describe '#expire_root_ref_cache' do
    it 'expires the root reference cache' do
      repository.root_ref

1058 1059 1060
      expect(repository.raw_repository).to receive(:root_ref).
        once.
        and_return('foo')
1061 1062 1063 1064 1065 1066 1067

      repository.expire_root_ref_cache

      expect(repository.root_ref).to eq('foo')
    end
  end

Y
Yorick Peterse 已提交
1068
  describe '#expire_branch_cache' do
1069 1070 1071 1072 1073
    # This method is private but we need it for testing purposes. Sadly there's
    # no other proper way of testing caching operations.
    let(:cache) { repository.send(:cache) }

    it 'expires the cache for all branches' do
1074
      expect(cache).to receive(:expire).
1075
        at_least(repository.branches.length * 2).
1076
        times
1077 1078 1079 1080 1081

      repository.expire_branch_cache
    end

    it 'expires the cache for all branches when the root branch is given' do
1082
      expect(cache).to receive(:expire).
1083
        at_least(repository.branches.length * 2).
1084
        times
1085 1086 1087 1088 1089

      repository.expire_branch_cache(repository.root_ref)
    end

    it 'expires the cache for a specific branch' do
1090
      expect(cache).to receive(:expire).twice
1091 1092 1093 1094

      repository.expire_branch_cache('foo')
    end
  end
1095

1096 1097 1098
  describe '#expire_emptiness_caches' do
    let(:cache) { repository.send(:cache) }

1099 1100 1101
    it 'expires the caches for an empty repository' do
      allow(repository).to receive(:empty?).and_return(true)

1102 1103 1104 1105
      expect(cache).to receive(:expire).with(:empty?)

      repository.expire_emptiness_caches
    end
1106 1107 1108 1109 1110 1111 1112 1113

    it 'does not expire the cache for a non-empty repository' do
      allow(repository).to receive(:empty?).and_return(false)

      expect(cache).not_to receive(:expire).with(:empty?)

      repository.expire_emptiness_caches
    end
1114 1115
  end

1116
  describe 'skip_merges option' do
1117
    subject { repository.commits(Gitlab::Git::BRANCH_REF_PREFIX + "'test'", limit: 100, skip_merges: true).map{ |k| k.id } }
1118 1119 1120

    it { is_expected.not_to include('e56497bb5f03a90a51293fc6d516788730953899') }
  end
1121 1122

  describe '#merge' do
1123 1124 1125 1126 1127 1128 1129 1130
    let(:merge_request) { create(:merge_request, source_branch: 'feature', target_branch: 'master', source_project: project) }

    let(:commit_options) do
      author = repository.user_to_committer(user)
      { message: 'Test \r\n\r\n message', committer: author, author: author }
    end

    it 'merges the code and returns the commit id' do
R
Rubén Dávila 已提交
1131 1132
      expect(merge_commit).to be_present
      expect(repository.blob_at(merge_commit.id, 'files/ruby/feature.rb')).to be_present
1133
    end
1134 1135

    it 'sets the `in_progress_merge_commit_sha` flag for the given merge request' do
1136
      merge_commit_id = merge(repository, user, merge_request, commit_options)
1137 1138 1139

      expect(merge_request.in_progress_merge_commit_sha).to eq(merge_commit_id)
    end
1140 1141 1142 1143 1144 1145 1146 1147 1148 1149

    it 'removes carriage returns from commit message' do
      merge_commit_id = merge(repository, user, merge_request, commit_options)

      expect(repository.commit(merge_commit_id).message).to eq(commit_options[:message].delete("\r"))
    end

    def merge(repository, user, merge_request, options = {})
      repository.merge(user, merge_request.diff_head_sha, merge_request, options)
    end
1150 1151
  end

1152 1153 1154
  describe '#revert' do
    let(:new_image_commit) { repository.commit('33f3729a45c02fc67d00adb1b8bca394b0e761d9') }
    let(:update_image_commit) { repository.commit('2f63565e7aac07bcdadb654e253078b727143ec4') }
1155

1156
    context 'when there is a conflict' do
1157 1158
      it 'raises an error' do
        expect { repository.revert(user, new_image_commit, 'master') }.to raise_error(/Failed to/)
1159 1160 1161 1162
      end
    end

    context 'when commit was already reverted' do
1163
      it 'raises an error' do
1164 1165
        repository.revert(user, update_image_commit, 'master')

1166
        expect { repository.revert(user, update_image_commit, 'master') }.to raise_error(/Failed to/)
1167 1168 1169 1170
      end
    end

    context 'when commit can be reverted' do
1171
      it 'reverts the changes' do
1172 1173 1174 1175 1176
        expect(repository.revert(user, update_image_commit, 'master')).to be_truthy
      end
    end

    context 'reverting a merge commit' do
1177
      it 'reverts the changes' do
1178 1179 1180 1181 1182 1183
        merge_commit
        expect(repository.blob_at_branch('master', 'files/ruby/feature.rb')).to be_present

        repository.revert(user, merge_commit, 'master')
        expect(repository.blob_at_branch('master', 'files/ruby/feature.rb')).not_to be_present
      end
1184 1185
    end
  end
1186

P
P.S.V.R 已提交
1187 1188 1189 1190 1191 1192
  describe '#cherry_pick' do
    let(:conflict_commit) { repository.commit('c642fe9b8b9f28f9225d7ea953fe14e74748d53b') }
    let(:pickable_commit) { repository.commit('7d3b0f7cff5f37573aea97cebfd5692ea1689924') }
    let(:pickable_merge) { repository.commit('e56497bb5f03a90a51293fc6d516788730953899') }

    context 'when there is a conflict' do
1193 1194
      it 'raises an error' do
        expect { repository.cherry_pick(user, conflict_commit, 'master') }.to raise_error(/Failed to/)
P
P.S.V.R 已提交
1195 1196 1197 1198
      end
    end

    context 'when commit was already cherry-picked' do
1199
      it 'raises an error' do
P
P.S.V.R 已提交
1200 1201
        repository.cherry_pick(user, pickable_commit, 'master')

1202
        expect { repository.cherry_pick(user, pickable_commit, 'master') }.to raise_error(/Failed to/)
P
P.S.V.R 已提交
1203 1204 1205 1206
      end
    end

    context 'when commit can be cherry-picked' do
1207
      it 'cherry-picks the changes' do
P
P.S.V.R 已提交
1208 1209 1210 1211 1212
        expect(repository.cherry_pick(user, pickable_commit, 'master')).to be_truthy
      end
    end

    context 'cherry-picking a merge commit' do
1213
      it 'cherry-picks the changes' do
1214
        expect(repository.blob_at_branch('improve/awesome', 'foo/bar/.gitkeep')).to be_nil
P
P.S.V.R 已提交
1215

1216 1217
        repository.cherry_pick(user, pickable_merge, 'improve/awesome')
        expect(repository.blob_at_branch('improve/awesome', 'foo/bar/.gitkeep')).not_to be_nil
P
P.S.V.R 已提交
1218 1219 1220 1221
      end
    end
  end

1222 1223 1224 1225 1226 1227 1228
  describe '#before_delete' do
    describe 'when a repository does not exist' do
      before do
        allow(repository).to receive(:exists?).and_return(false)
      end

      it 'does not flush caches that depend on repository data' do
1229
        expect(repository).not_to receive(:expire_cache)
1230 1231 1232 1233

        repository.before_delete
      end

1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245
      it 'flushes the tags cache' do
        expect(repository).to receive(:expire_tags_cache)

        repository.before_delete
      end

      it 'flushes the branches cache' do
        expect(repository).to receive(:expire_branches_cache)

        repository.before_delete
      end

1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256
      it 'flushes the root ref cache' do
        expect(repository).to receive(:expire_root_ref_cache)

        repository.before_delete
      end

      it 'flushes the emptiness caches' do
        expect(repository).to receive(:expire_emptiness_caches)

        repository.before_delete
      end
1257 1258

      it 'flushes the exists cache' do
1259
        expect(repository).to receive(:expire_exists_cache).twice
1260 1261 1262

        repository.before_delete
      end
1263 1264 1265 1266 1267 1268 1269
    end

    describe 'when a repository exists' do
      before do
        allow(repository).to receive(:exists?).and_return(true)
      end

1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281
      it 'flushes the tags cache' do
        expect(repository).to receive(:expire_tags_cache)

        repository.before_delete
      end

      it 'flushes the branches cache' do
        expect(repository).to receive(:expire_branches_cache)

        repository.before_delete
      end

1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309
      it 'flushes the root ref cache' do
        expect(repository).to receive(:expire_root_ref_cache)

        repository.before_delete
      end

      it 'flushes the emptiness caches' do
        expect(repository).to receive(:expire_emptiness_caches)

        repository.before_delete
      end
    end
  end

  describe '#before_change_head' do
    it 'flushes the branch cache' do
      expect(repository).to receive(:expire_branch_cache)

      repository.before_change_head
    end

    it 'flushes the root ref cache' do
      expect(repository).to receive(:expire_root_ref_cache)

      repository.before_change_head
    end
  end

1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326
  describe '#after_change_head' do
    it 'flushes the readme cache' do
      expect(repository).to receive(:expire_method_caches).with([
        :readme,
        :changelog,
        :license,
        :contributing,
        :gitignore,
        :koding,
        :gitlab_ci,
        :avatar
      ])

      repository.after_change_head
    end
  end

Y
Yorick Peterse 已提交
1327
  describe '#before_push_tag' do
1328
    it 'flushes the cache' do
1329 1330 1331
      expect(repository).to receive(:expire_statistics_caches)
      expect(repository).to receive(:expire_emptiness_caches)
      expect(repository).to receive(:expire_tags_cache)
1332

Y
Yorick Peterse 已提交
1333
      repository.before_push_tag
1334 1335 1336 1337
    end
  end

  describe '#after_import' do
1338 1339
    it 'flushes and builds the cache' do
      expect(repository).to receive(:expire_content_cache)
1340 1341 1342

      repository.after_import
    end
1343 1344 1345
  end

  describe '#after_push_commit' do
1346
    it 'expires statistics caches' do
1347 1348
      expect(repository).to receive(:expire_statistics_caches).
        and_call_original
1349

1350 1351 1352
      expect(repository).to receive(:expire_branch_cache).
        with('master').
        and_call_original
1353

1354
      repository.after_push_commit('master')
1355 1356 1357 1358
    end
  end

  describe '#after_create_branch' do
1359
    it 'expires the branch caches' do
1360
      expect(repository).to receive(:expire_branches_cache)
1361 1362 1363 1364 1365 1366

      repository.after_create_branch
    end
  end

  describe '#after_remove_branch' do
1367
    it 'expires the branch caches' do
1368
      expect(repository).to receive(:expire_branches_cache)
1369 1370 1371 1372

      repository.after_remove_branch
    end
  end
1373

1374 1375 1376 1377 1378 1379
  describe '#after_create' do
    it 'flushes the exists cache' do
      expect(repository).to receive(:expire_exists_cache)

      repository.after_create
    end
1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391

    it 'flushes the root ref cache' do
      expect(repository).to receive(:expire_root_ref_cache)

      repository.after_create
    end

    it 'flushes the emptiness caches' do
      expect(repository).to receive(:expire_emptiness_caches)

      repository.after_create
    end
1392 1393
  end

1394 1395 1396 1397 1398 1399 1400 1401 1402 1403
  describe "#copy_gitattributes" do
    it 'returns true with a valid ref' do
      expect(repository.copy_gitattributes('master')).to be_truthy
    end

    it 'returns false with an invalid ref' do
      expect(repository.copy_gitattributes('invalid')).to be_falsey
    end
  end

Y
Yorick Peterse 已提交
1404 1405
  describe '#before_remove_tag' do
    it 'flushes the tag cache' do
1406 1407
      expect(repository).to receive(:expire_tags_cache).and_call_original
      expect(repository).to receive(:expire_statistics_caches).and_call_original
Y
Yorick Peterse 已提交
1408 1409 1410 1411 1412 1413 1414

      repository.before_remove_tag
    end
  end

  describe '#branch_count' do
    it 'returns the number of branches' do
D
Douwe Maan 已提交
1415
      expect(repository.branch_count).to be_an(Integer)
K
Cleanup  
Kim "BKC" Carlbäcker 已提交
1416 1417

      # NOTE: Until rugged goes away, make sure rugged and gitaly are in sync
1418
      rugged_count = repository.raw_repository.rugged.branches.count
K
Cleanup  
Kim "BKC" Carlbäcker 已提交
1419

1420
      expect(repository.branch_count).to eq(rugged_count)
Y
Yorick Peterse 已提交
1421 1422 1423 1424 1425
    end
  end

  describe '#tag_count' do
    it 'returns the number of tags' do
D
Douwe Maan 已提交
1426
      expect(repository.tag_count).to be_an(Integer)
K
Cleanup  
Kim "BKC" Carlbäcker 已提交
1427

1428 1429
      # NOTE: Until rugged goes away, make sure rugged and gitaly are in sync
      rugged_count = repository.raw_repository.rugged.tags.count
K
Cleanup  
Kim "BKC" Carlbäcker 已提交
1430

1431
      expect(repository.tag_count).to eq(rugged_count)
Y
Yorick Peterse 已提交
1432 1433 1434
    end
  end

1435
  describe '#expire_branches_cache' do
Y
Yorick Peterse 已提交
1436
    it 'expires the cache' do
1437 1438 1439
      expect(repository).to receive(:expire_method_caches).
        with(%i(branch_names branch_count)).
        and_call_original
Y
Yorick Peterse 已提交
1440

1441
      repository.expire_branches_cache
Y
Yorick Peterse 已提交
1442 1443 1444
    end
  end

1445
  describe '#expire_tags_cache' do
Y
Yorick Peterse 已提交
1446
    it 'expires the cache' do
1447 1448 1449
      expect(repository).to receive(:expire_method_caches).
        with(%i(tag_names tag_count)).
        and_call_original
Y
Yorick Peterse 已提交
1450

1451
      repository.expire_tags_cache
Y
Yorick Peterse 已提交
1452 1453
    end
  end
1454

1455
  describe '#add_tag' do
1456 1457
    context 'with a valid target' do
      let(:user) { build_stubbed(:user) }
1458

1459
      it 'creates the tag using rugged' do
1460 1461
        expect(repository.rugged.tags).to receive(:create).
          with('8.5', repository.commit('master').id,
1462
            hash_including(message: 'foo',
1463 1464
                           tagger: hash_including(name: user.name, email: user.email))).
          and_call_original
1465

1466 1467 1468 1469 1470 1471 1472 1473
        repository.add_tag(user, '8.5', 'master', 'foo')
      end

      it 'returns a Gitlab::Git::Tag object' do
        tag = repository.add_tag(user, '8.5', 'master', 'foo')

        expect(tag).to be_a(Gitlab::Git::Tag)
      end
1474 1475 1476 1477 1478 1479 1480

      it 'passes commit SHA to pre-receive and update hooks,\
        and tag SHA to post-receive hook' do
        pre_receive_hook = Gitlab::Git::Hook.new('pre-receive', repository.path_to_repo)
        update_hook = Gitlab::Git::Hook.new('update', repository.path_to_repo)
        post_receive_hook = Gitlab::Git::Hook.new('post-receive', repository.path_to_repo)

1481 1482
        allow(Gitlab::Git::Hook).to receive(:new).
          and_return(pre_receive_hook, update_hook, post_receive_hook)
1483 1484 1485 1486 1487 1488 1489 1490 1491 1492

        allow(pre_receive_hook).to receive(:trigger).and_call_original
        allow(update_hook).to receive(:trigger).and_call_original
        allow(post_receive_hook).to receive(:trigger).and_call_original

        tag = repository.add_tag(user, '8.5', 'master', 'foo')

        commit_sha = repository.commit('master').id
        tag_sha = tag.target

1493 1494 1495 1496 1497 1498
        expect(pre_receive_hook).to have_received(:trigger).
          with(anything, anything, commit_sha, anything)
        expect(update_hook).to have_received(:trigger).
          with(anything, anything, commit_sha, anything)
        expect(post_receive_hook).to have_received(:trigger).
          with(anything, anything, tag_sha, anything)
1499
      end
1500 1501 1502 1503 1504 1505
    end

    context 'with an invalid target' do
      it 'returns false' do
        expect(repository.add_tag(user, '8.5', 'bar', 'foo')).to be false
      end
1506 1507 1508
    end
  end

1509 1510 1511 1512 1513 1514 1515 1516 1517 1518
  describe '#rm_branch' do
    let(:user) { create(:user) }

    it 'removes a branch' do
      expect(repository).to receive(:before_remove_branch)
      expect(repository).to receive(:after_remove_branch)

      repository.rm_branch(user, 'feature')
    end
  end
1519 1520 1521 1522 1523

  describe '#rm_tag' do
    it 'removes a tag' do
      expect(repository).to receive(:before_remove_tag)

L
Lin Jen-Shin 已提交
1524 1525 1526
      repository.rm_tag(create(:user), 'v1.1.0')

      expect(repository.find_tag('v1.1.0')).to be_nil
1527 1528
    end
  end
1529 1530

  describe '#avatar' do
1531
    it 'returns nil if repo does not exist' do
1532 1533
      expect(repository).to receive(:file_on_head).
        and_raise(Rugged::ReferenceError)
1534 1535 1536 1537

      expect(repository.avatar).to eq(nil)
    end

1538
    it 'returns the first avatar file found in the repository' do
1539 1540 1541
      expect(repository).to receive(:file_on_head).
        with(:avatar).
        and_return(double(:tree, path: 'logo.png'))
1542 1543 1544 1545 1546

      expect(repository.avatar).to eq('logo.png')
    end

    it 'caches the output' do
1547 1548 1549 1550
      expect(repository).to receive(:file_on_head).
        with(:avatar).
        once.
        and_return(double(:tree, path: 'logo.png'))
1551

1552
      2.times { expect(repository.avatar).to eq('logo.png') }
1553 1554
    end
  end
1555

1556 1557 1558 1559 1560 1561 1562 1563 1564 1565
  describe '#expire_exists_cache' do
    let(:cache) { repository.send(:cache) }

    it 'expires the cache' do
      expect(cache).to receive(:expire).with(:exists?)

      repository.expire_exists_cache
    end
  end

1566
  describe "#keep_around" do
1567 1568 1569 1570
    it "does not fail if we attempt to reference bad commit" do
      expect(repository.kept_around?('abc1234')).to be_falsey
    end

1571 1572 1573 1574 1575
    it "stores a reference to the specified commit sha so it isn't garbage collected" do
      repository.keep_around(sample_commit.id)

      expect(repository.kept_around?(sample_commit.id)).to be_truthy
    end
1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591

    it "attempting to call keep_around on truncated ref does not fail" do
      repository.keep_around(sample_commit.id)
      ref = repository.send(:keep_around_ref_name, sample_commit.id)
      path = File.join(repository.path, ref)
      # Corrupt the reference
      File.truncate(path, 0)

      expect(repository.kept_around?(sample_commit.id)).to be_falsey

      repository.keep_around(sample_commit.id)

      expect(repository.kept_around?(sample_commit.id)).to be_falsey

      File.delete(path)
    end
1592
  end
1593

1594
  describe '#update_ref' do
1595
    it 'can create a ref' do
1596
      GitOperationService.new(nil, repository).send(:update_ref, 'refs/heads/foobar', 'refs/heads/master', Gitlab::Git::BLANK_SHA)
1597 1598 1599 1600 1601 1602

      expect(repository.find_branch('foobar')).not_to be_nil
    end

    it 'raises CommitError when the ref update fails' do
      expect do
1603
        GitOperationService.new(nil, repository).send(:update_ref, 'refs/heads/master', 'refs/heads/master', Gitlab::Git::BLANK_SHA)
1604 1605 1606
      end.to raise_error(Repository::CommitError)
    end
  end
1607 1608 1609

  describe '#contribution_guide', caching: true do
    it 'returns and caches the output' do
1610 1611 1612 1613
      expect(repository).to receive(:file_on_head).
        with(:contributing).
        and_return(Gitlab::Git::Tree.new(path: 'CONTRIBUTING.md')).
        once
1614 1615

      2.times do
1616 1617
        expect(repository.contribution_guide).
          to be_an_instance_of(Gitlab::Git::Tree)
1618 1619 1620 1621
      end
    end
  end

1622
  describe '#gitignore', caching: true do
1623
    it 'returns and caches the output' do
1624 1625 1626 1627
      expect(repository).to receive(:file_on_head).
        with(:gitignore).
        and_return(Gitlab::Git::Tree.new(path: '.gitignore')).
        once
1628 1629

      2.times do
1630
        expect(repository.gitignore).to be_an_instance_of(Gitlab::Git::Tree)
1631 1632 1633 1634
      end
    end
  end

1635
  describe '#koding_yml', caching: true do
1636
    it 'returns and caches the output' do
1637 1638 1639 1640
      expect(repository).to receive(:file_on_head).
        with(:koding).
        and_return(Gitlab::Git::Tree.new(path: '.koding.yml')).
        once
1641 1642

      2.times do
1643
        expect(repository.koding_yml).to be_an_instance_of(Gitlab::Git::Tree)
1644 1645 1646 1647
      end
    end
  end

1648 1649 1650
  describe '#readme', caching: true do
    context 'with a non-existing repository' do
      it 'returns nil' do
1651
        allow(repository).to receive(:tree).with(:head).and_return(nil)
1652

1653 1654 1655
        expect(repository.readme).to be_nil
      end
    end
1656

1657
    context 'with an existing repository' do
1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669
      context 'when no README exists' do
        it 'returns nil' do
          allow_any_instance_of(Tree).to receive(:readme).and_return(nil)

          expect(repository.readme).to be_nil
        end
      end

      context 'when a README exists' do
        it 'returns the README' do
          expect(repository.readme).to be_an_instance_of(ReadmeBlob)
        end
1670 1671 1672 1673
      end
    end
  end

1674 1675
  describe '#expire_statistics_caches' do
    it 'expires the caches' do
1676 1677
      expect(repository).to receive(:expire_method_caches).
        with(%i(size commit_count))
1678

1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693
      repository.expire_statistics_caches
    end
  end

  describe '#expire_method_caches' do
    it 'expires the caches of the given methods' do
      expect_any_instance_of(RepositoryCache).to receive(:expire).with(:readme)
      expect_any_instance_of(RepositoryCache).to receive(:expire).with(:gitignore)

      repository.expire_method_caches(%i(readme gitignore))
    end
  end

  describe '#expire_all_method_caches' do
    it 'expires the caches of all methods' do
1694 1695
      expect(repository).to receive(:expire_method_caches).
        with(Repository::CACHED_METHODS)
1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719

      repository.expire_all_method_caches
    end
  end

  describe '#file_on_head' do
    context 'with a non-existing repository' do
      it 'returns nil' do
        expect(repository).to receive(:tree).with(:head).and_return(nil)

        expect(repository.file_on_head(:readme)).to be_nil
      end
    end

    context 'with a repository that has no blobs' do
      it 'returns nil' do
        expect_any_instance_of(Tree).to receive(:blobs).and_return([])

        expect(repository.file_on_head(:readme)).to be_nil
      end
    end

    context 'with an existing repository' do
      it 'returns a Gitlab::Git::Tree' do
1720 1721
        expect(repository.file_on_head(:readme)).
          to be_an_instance_of(Gitlab::Git::Tree)
1722 1723 1724 1725
      end
    end
  end

1726 1727 1728 1729 1730 1731
  describe '#head_tree' do
    context 'with an existing repository' do
      it 'returns a Tree' do
        expect(repository.head_tree).to be_an_instance_of(Tree)
      end
    end
1732

1733 1734 1735 1736 1737
    context 'with a non-existing repository' do
      it 'returns nil' do
        expect(repository).to receive(:head_commit).and_return(nil)

        expect(repository.head_tree).to be_nil
1738 1739 1740 1741
      end
    end
  end

1742 1743 1744 1745 1746
  describe '#tree' do
    context 'using a non-existing repository' do
      before do
        allow(repository).to receive(:head_commit).and_return(nil)
      end
1747

1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790
      it 'returns nil' do
        expect(repository.tree(:head)).to be_nil
      end

      it 'returns nil when using a path' do
        expect(repository.tree(:head, 'README.md')).to be_nil
      end
    end

    context 'using an existing repository' do
      it 'returns a Tree' do
        expect(repository.tree(:head)).to be_an_instance_of(Tree)
      end
    end
  end

  describe '#size' do
    context 'with a non-existing repository' do
      it 'returns 0' do
        expect(repository).to receive(:exists?).and_return(false)

        expect(repository.size).to eq(0.0)
      end
    end

    context 'with an existing repository' do
      it 'returns the repository size as a Float' do
        expect(repository.size).to be_an_instance_of(Float)
      end
    end
  end

  describe '#commit_count' do
    context 'with a non-existing repository' do
      it 'returns 0' do
        expect(repository).to receive(:root_ref).and_return(nil)

        expect(repository.commit_count).to eq(0)
      end
    end

    context 'with an existing repository' do
      it 'returns the commit count' do
D
Douwe Maan 已提交
1791
        expect(repository.commit_count).to be_an(Integer)
1792 1793 1794 1795
      end
    end
  end

1796
  describe '#commit_count_for_ref' do
1797 1798
    let(:project) { create :empty_project }

1799 1800
    context 'with a non-existing repository' do
      it 'returns 0' do
1801 1802 1803 1804 1805 1806 1807 1808
        expect(project.repository.commit_count_for_ref('master')).to eq(0)
      end
    end

    context 'with empty repository' do
      it 'returns 0' do
        project.create_repository
        expect(project.repository.commit_count_for_ref('master')).to eq(0)
1809 1810 1811 1812 1813 1814 1815 1816 1817 1818
      end
    end

    context 'when searching for the root ref' do
      it 'returns the same count as #commit_count' do
        expect(repository.commit_count_for_ref(repository.root_ref)).to eq(repository.commit_count)
      end
    end
  end

1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835
  describe '#cache_method_output', caching: true do
    context 'with a non-existing repository' do
      let(:value) do
        repository.cache_method_output(:cats, fallback: 10) do
          raise Rugged::ReferenceError
        end
      end

      it 'returns a fallback value' do
        expect(value).to eq(10)
      end

      it 'does not cache the data' do
        value

        expect(repository.instance_variable_defined?(:@cats)).to eq(false)
        expect(repository.send(:cache).exist?(:cats)).to eq(false)
1836 1837
      end
    end
1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858

    context 'with an existing repository' do
      it 'caches the output' do
        object = double

        expect(object).to receive(:number).once.and_return(10)

        2.times do
          val = repository.cache_method_output(:cats) { object.number }

          expect(val).to eq(10)
        end

        expect(repository.send(:cache).exist?(:cats)).to eq(true)
        expect(repository.instance_variable_get(:@cats)).to eq(10)
      end
    end
  end

  describe '#refresh_method_caches' do
    it 'refreshes the caches of the given types' do
1859
      expect(repository).to receive(:expire_method_caches).
1860
        with(%i(rendered_readme license_blob license_key license))
1861

1862
      expect(repository).to receive(:rendered_readme)
1863 1864
      expect(repository).to receive(:license_blob)
      expect(repository).to receive(:license_key)
1865
      expect(repository).to receive(:license)
1866 1867 1868

      repository.refresh_method_caches(%i(readme license))
    end
1869
  end
D
Douwe Maan 已提交
1870 1871 1872

  describe '#gitlab_ci_yml_for' do
    before do
1873
      repository.create_file(User.last, '.gitlab-ci.yml', 'CONTENT', message: 'Add .gitlab-ci.yml', branch_name: 'master')
D
Douwe Maan 已提交
1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890
    end

    context 'when there is a .gitlab-ci.yml at the commit' do
      it 'returns the content' do
        expect(repository.gitlab_ci_yml_for(repository.commit.sha)).to eq('CONTENT')
      end
    end

    context 'when there is no .gitlab-ci.yml at the commit' do
      it 'returns nil' do
        expect(repository.gitlab_ci_yml_for(repository.commit.parent.sha)).to be_nil
      end
    end
  end

  describe '#route_map_for' do
    before do
1891
      repository.create_file(User.last, '.gitlab/route-map.yml', 'CONTENT', message: 'Add .gitlab/route-map.yml', branch_name: 'master')
D
Douwe Maan 已提交
1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905
    end

    context 'when there is a .gitlab/route-map.yml at the commit' do
      it 'returns the content' do
        expect(repository.route_map_for(repository.commit.sha)).to eq('CONTENT')
      end
    end

    context 'when there is no .gitlab/route-map.yml at the commit' do
      it 'returns nil' do
        expect(repository.route_map_for(repository.commit.parent.sha)).to be_nil
      end
    end
  end
1906

1907 1908
  describe '#is_ancestor?' do
    context 'Gitaly is_ancestor feature enabled' do
1909 1910 1911 1912 1913
      let(:commit) { repository.commit }
      let(:ancestor) { commit.parents.first }

      before do
        allow(Gitlab::GitalyClient).to receive(:enabled?).and_return(true)
1914
        allow(Gitlab::GitalyClient).to receive(:feature_enabled?).with(:is_ancestor).and_return(true)
1915 1916 1917 1918
      end

      it "asks Gitaly server if it's an ancestor" do
        expect_any_instance_of(Gitlab::GitalyClient::Commit).to receive(:is_ancestor).with(ancestor.id, commit.id)
1919

1920
        repository.is_ancestor?(ancestor.id, commit.id)
1921 1922 1923
      end
    end
  end
1924
end