Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
dec6b31c
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
dec6b31c
编写于
5月 14, 2016
作者:
S
Stan Hu
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Fix Error 500 when attempting to retrieve project license when HEAD points to non-existent ref
Closes #17537
上级
c3f68b10
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
27 addition
and
4 deletion
+27
-4
CHANGELOG
CHANGELOG
+1
-0
app/models/repository.rb
app/models/repository.rb
+8
-4
spec/models/repository_spec.rb
spec/models/repository_spec.rb
+18
-0
未找到文件。
CHANGELOG
浏览文件 @
dec6b31c
...
...
@@ -3,6 +3,7 @@ Please view this file on the master branch, on stable branches it's out of date.
v 8.8.0 (unreleased)
- Snippets tab under user profile. !4001 (Long Nguyen)
- Fix error when using link to uploads in global snippets
- Fix Error 500 when attempting to retrieve project license when HEAD points to non-existent ref
- Assign labels and milestone to target project when moving issue. !3934 (Long Nguyen)
- Use a case-insensitive comparison in sanitizing URI schemes
- Project#open_branches has been cleaned up and no longer loads entire records into memory.
...
...
app/models/repository.rb
浏览文件 @
dec6b31c
...
...
@@ -475,7 +475,7 @@ class Repository
end
def
license_blob
return
nil
if
!
exists?
||
empty
?
return
nil
unless
head_exists
?
cache
.
fetch
(
:license_blob
)
do
tree
(
:head
).
blobs
.
find
do
|
file
|
...
...
@@ -485,7 +485,7 @@ class Repository
end
def
license_key
return
nil
if
!
exists?
||
empty
?
return
nil
unless
head_exists
?
cache
.
fetch
(
:license_key
)
do
Licensee
.
license
(
path
).
try
(
:key
)
...
...
@@ -493,7 +493,7 @@ class Repository
end
def
gitlab_ci_yml
return
nil
if
!
exists?
||
empty
?
return
nil
unless
head_exists
?
@gitlab_ci_yml
||=
tree
(
:head
).
blobs
.
find
do
|
file
|
file
.
name
==
'.gitlab-ci.yml'
...
...
@@ -961,7 +961,7 @@ class Repository
end
def
main_language
return
if
empty?
||
rugged
.
head_unborn
?
return
unless
head_exists
?
Linguist
::
Repository
.
new
(
rugged
,
rugged
.
head
.
target_id
).
language
end
...
...
@@ -981,4 +981,8 @@ class Repository
def
cache
@cache
||=
RepositoryCache
.
new
(
path_with_namespace
)
end
def
head_exists?
exists?
&&
!
empty?
&&
!
rugged
.
head_unborn?
end
end
spec/models/repository_spec.rb
浏览文件 @
dec6b31c
...
...
@@ -176,6 +176,15 @@ describe Repository, models: true do
repository
.
remove_file
(
user
,
'LICENSE'
,
'Remove LICENSE'
,
'master'
)
end
it
'handles when HEAD points to non-existent ref'
do
repository
.
commit_file
(
user
,
'LICENSE'
,
'Copyright!'
,
'Add LICENSE'
,
'master'
,
false
)
rugged
=
double
(
'rugged'
)
expect
(
rugged
).
to
receive
(
:head_unborn?
).
and_return
(
true
)
expect
(
repository
).
to
receive
(
:rugged
).
and_return
(
rugged
)
expect
(
repository
.
license_blob
).
to
be_nil
end
it
'looks in the root_ref only'
do
repository
.
remove_file
(
user
,
'LICENSE'
,
'Remove LICENSE'
,
'markdown'
)
repository
.
commit_file
(
user
,
'LICENSE'
,
Licensee
::
License
.
new
(
'mit'
).
content
,
'Add LICENSE'
,
'markdown'
,
false
)
...
...
@@ -204,6 +213,15 @@ describe Repository, models: true do
repository
.
remove_file
(
user
,
'LICENSE'
,
'Remove LICENSE'
,
'master'
)
end
it
'handles when HEAD points to non-existent ref'
do
repository
.
commit_file
(
user
,
'LICENSE'
,
'Copyright!'
,
'Add LICENSE'
,
'master'
,
false
)
rugged
=
double
(
'rugged'
)
expect
(
rugged
).
to
receive
(
:head_unborn?
).
and_return
(
true
)
expect
(
repository
).
to
receive
(
:rugged
).
and_return
(
rugged
)
expect
(
repository
.
license_key
).
to
be_nil
end
it
'returns nil when no license is detected'
do
expect
(
repository
.
license_key
).
to
be_nil
end
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录