repository_spec.rb 50.2 KB
Newer Older
1 2
require 'spec_helper'

D
Douwe Maan 已提交
3
describe Repository, models: true do
4
  include RepoHelpers
5
  TestBlob = Struct.new(:name)
6

7 8
  let(:project) { create(:project) }
  let(:repository) { project.repository }
9
  let(:user) { create(:user) }
10

11 12 13 14
  let(:commit_options) do
    author = repository.user_to_committer(user)
    { message: 'Test message', committer: author, author: author }
  end
15

R
Rubén Dávila 已提交
16
  let(:merge_commit) do
17 18 19
    merge_request = create(:merge_request, source_branch: 'feature', target_branch: 'master', source_project: project)
    merge_commit_id = repository.merge(user, merge_request, commit_options)
    repository.commit(merge_commit_id)
20
  end
21

22 23 24 25 26 27 28 29 30 31 32 33 34 35 36
  let(:author_email) { FFaker::Internet.email }

  # I have to remove periods from the end of the name
  # This happened when the user's name had a suffix (i.e. "Sr.")
  # This seems to be what git does under the hood. For example, this commit:
  #
  # $ git commit --author='Foo Sr. <foo@example.com>' -m 'Where's my trailing period?'
  #
  # results in this:
  #
  # $ git show --pretty
  # ...
  # Author: Foo Sr <foo@example.com>
  # ...
  let(:author_name) { FFaker::Name.name.chomp("\.") }
37

38
  describe '#branch_names_contains' do
39 40
    subject { repository.branch_names_contains(sample_commit.id) }

41 42 43
    it { is_expected.to include('master') }
    it { is_expected.not_to include('feature') }
    it { is_expected.not_to include('fix') }
44
  end
45

46
  describe '#tag_names_contains' do
D
Dmitriy Zaporozhets 已提交
47
    subject { repository.tag_names_contains(sample_commit.id) }
48

D
Dmitriy Zaporozhets 已提交
49 50
    it { is_expected.to include('v1.1.0') }
    it { is_expected.not_to include('v1.0.0') }
51 52
  end

53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70
  describe 'tags_sorted_by' do
    context 'name' do
      subject { repository.tags_sorted_by('name').map(&:name) }

      it { is_expected.to eq(['v1.1.0', 'v1.0.0']) }
    end

    context 'updated' do
      let(:tag_a) { repository.find_tag('v1.0.0') }
      let(:tag_b) { repository.find_tag('v1.1.0') }

      context 'desc' do
        subject { repository.tags_sorted_by('updated_desc').map(&:name) }

        before do
          double_first = double(committed_date: Time.now)
          double_last = double(committed_date: Time.now - 1.second)

71 72
          allow(tag_a).to receive(:dereferenced_target).and_return(double_first)
          allow(tag_b).to receive(:dereferenced_target).and_return(double_last)
73
          allow(repository).to receive(:tags).and_return([tag_a, tag_b])
74 75 76 77 78 79 80 81 82 83 84 85
        end

        it { is_expected.to eq(['v1.0.0', 'v1.1.0']) }
      end

      context 'asc' do
        subject { repository.tags_sorted_by('updated_asc').map(&:name) }

        before do
          double_first = double(committed_date: Time.now - 1.second)
          double_last = double(committed_date: Time.now)

86 87
          allow(tag_a).to receive(:dereferenced_target).and_return(double_last)
          allow(tag_b).to receive(:dereferenced_target).and_return(double_first)
88
          allow(repository).to receive(:tags).and_return([tag_a, tag_b])
89 90 91 92 93 94 95
        end

        it { is_expected.to eq(['v1.1.0', 'v1.0.0']) }
      end
    end
  end

96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115
  describe '#ref_name_for_sha' do
    context 'ref found' do
      it 'returns the ref' do
        allow_any_instance_of(Gitlab::Popen).to receive(:popen).
          and_return(["b8d95eb4969eefacb0a58f6a28f6803f8070e7b9 commit\trefs/environments/production/77\n", 0])

        expect(repository.ref_name_for_sha('bla', '0' * 40)).to eq 'refs/environments/production/77'
      end
    end

    context 'ref not found' do
      it 'returns nil' do
        allow_any_instance_of(Gitlab::Popen).to receive(:popen).
          and_return(["", 0])

        expect(repository.ref_name_for_sha('bla', '0' * 40)).to eq nil
      end
    end
  end

116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135
  describe '#ref_exists?' do
    context 'when ref exists' do
      it 'returns true' do
        expect(repository.ref_exists?('refs/heads/master')).to be true
      end
    end

    context 'when ref does not exist' do
      it 'returns false' do
        expect(repository.ref_exists?('refs/heads/non-existent')).to be false
      end
    end

    context 'when ref format is incorrect' do
      it 'returns false' do
        expect(repository.ref_exists?('refs/heads/invalid:master')).to be false
      end
    end
  end

136
  describe '#last_commit_for_path' do
D
Dmitriy Zaporozhets 已提交
137
    subject { repository.last_commit_for_path(sample_commit.id, '.gitignore').id }
138

D
Dmitriy Zaporozhets 已提交
139
    it { is_expected.to eq('c1acaa58bbcbc3eafe538cb8274ba387047b69f8') }
140
  end
141

H
Hiroyuki Sato 已提交
142 143 144 145 146 147 148 149
  describe '#last_commit_id_for_path' do
    subject { repository.last_commit_id_for_path(sample_commit.id, '.gitignore') }

    it { is_expected.to eq('c1acaa58bbcbc3eafe538cb8274ba387047b69f8') }
  end

  describe '#cache_last_commit_id_for_path' do
    it "caches #last_commit_id_for_path" do
H
Hiroyuki Sato 已提交
150 151 152 153
      cache = repository.send(:cache)
      key = "last_commit_id_for_path:#{sample_commit.id}:#{Digest::SHA1.hexdigest('.gitignore')}"
      expect(cache).to receive(:fetch).with(key).and_return('c1acaa5')
      expect(repository.cache_last_commit_id_for_path(sample_commit.id, '.gitignore')).to eq('c1acaa5')
H
Hiroyuki Sato 已提交
154 155 156
    end
  end

157
  describe '#find_commits_by_message' do
158 159
    it 'returns commits with messages containing a given string' do
      commit_ids = repository.find_commits_by_message('submodule').map(&:id)
160

161 162 163 164 165 166 167 168 169 170 171
      expect(commit_ids).to include('5937ac0a7beb003549fc5fd26fc247adbce4a52e')
      expect(commit_ids).to include('6f6d7e7ed97bb5f0054f2b1df789b39ca89b6ff9')
      expect(commit_ids).to include('cfe32cf61b73a0d5e9f13e774abde7ff789b1660')
      expect(commit_ids).not_to include('913c66a37b4a45b9769037c55c2d238bd0942d2e')
    end

    it 'is case insensitive' do
      commit_ids = repository.find_commits_by_message('SUBMODULE').map(&:id)

      expect(commit_ids).to include('5937ac0a7beb003549fc5fd26fc247adbce4a52e')
    end
172 173
  end

174
  describe '#blob_at' do
175 176 177 178 179 180
    context 'blank sha' do
      subject { repository.blob_at(Gitlab::Git::BLANK_SHA, '.gitignore') }

      it { is_expected.to be_nil }
    end
  end
181

182
  describe '#merged_to_root_ref?' do
183
    context 'merged branch without ff' do
184
      subject { repository.merged_to_root_ref?('branch-merged') }
F
Florent (HP) 已提交
185 186 187

      it { is_expected.to be_truthy }
    end
188

189 190
    # If the HEAD was ff then it will be false
    context 'merged with ff' do
F
Florent (HP) 已提交
191 192 193 194
      subject { repository.merged_to_root_ref?('improve/awesome') }

      it { is_expected.to be_truthy }
    end
195

196 197 198 199 200
    context 'not merged branch' do
      subject { repository.merged_to_root_ref?('not-merged-branch') }

      it { is_expected.to be_falsey }
    end
201 202 203 204 205 206

    context 'default branch' do
      subject { repository.merged_to_root_ref?('master') }

      it { is_expected.to be_falsey }
    end
207 208
  end

209
  describe '#can_be_merged?' do
210 211 212 213 214 215 216 217 218 219 220
    context 'mergeable branches' do
      subject { repository.can_be_merged?('0b4bc9a49b562e85de7cc9e834518ea6828729b9', 'master') }

      it { is_expected.to be_truthy }
    end

    context 'non-mergeable branches' do
      subject { repository.can_be_merged?('bb5206fee213d983da88c47f9cf4cc6caf9c66dc', 'feature') }

      it { is_expected.to be_falsey }
    end
F
Florent (HP) 已提交
221 222 223 224 225 226 227 228 229 230 231 232

    context 'non merged branch' do
      subject { repository.merged_to_root_ref?('fix') }

      it { is_expected.to be_falsey }
    end

    context 'non existent branch' do
      subject { repository.merged_to_root_ref?('non_existent_branch') }

      it { is_expected.to be_nil }
    end
233 234
  end

235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263
  describe '#commit' do
    context 'when ref exists' do
      it 'returns commit object' do
        expect(repository.commit('master'))
          .to be_an_instance_of Commit
      end
    end

    context 'when ref does not exist' do
      it 'returns nil' do
        expect(repository.commit('non-existent-ref')).to be_nil
      end
    end

    context 'when ref is not valid' do
      context 'when preceding tree element exists' do
        it 'returns nil' do
          expect(repository.commit('master:ref')).to be_nil
        end
      end

      context 'when preceding tree element does not exist' do
        it 'returns nil' do
          expect(repository.commit('non-existent:ref')).to be_nil
        end
      end
    end
  end

264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288
  describe "#commit_dir" do
    it "commits a change that creates a new directory" do
      expect do
        repository.commit_dir(user, 'newdir', 'Create newdir', 'master')
      end.to change { repository.commits('master').count }.by(1)

      newdir = repository.tree('master', 'newdir')
      expect(newdir.path).to eq('newdir')
    end

    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
        expect do
          repository.commit_dir(user, "newdir", "Add newdir", 'master', author_email: author_email, author_name: author_name)
        end.to change { repository.commits('master').count }.by(1)

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
  end

  describe "#commit_file" do
289 290
    it 'commits change to a file successfully' do
      expect do
291 292
        repository.commit_file(user, 'CHANGELOG', 'Changelog!',
                              'Updates file content',
293 294 295
                              'master', true)
      end.to change { repository.commits('master').count }.by(1)

296
      blob = repository.blob_at('master', 'CHANGELOG')
297

298
      expect(blob.data).to eq('Changelog!')
299
    end
300 301 302 303 304 305 306 307 308 309 310 311 312 313

    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
        expect do
          repository.commit_file(user, "README", 'README!', 'Add README',
                                'master', true, author_email: author_email, author_name: author_name)
        end.to change { repository.commits('master').count }.by(1)

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
314 315
  end

316
  describe "#update_file" do
T
tiagonbotelho 已提交
317
    it 'updates filename successfully' do
318 319
      expect do
        repository.update_file(user, 'NEWLICENSE', 'Copyright!',
T
tiagonbotelho 已提交
320 321
                                     branch: 'master',
                                     previous_path: 'LICENSE',
322 323
                                     message: 'Changes filename')
      end.to change { repository.commits('master').count }.by(1)
T
tiagonbotelho 已提交
324 325 326 327 328 329

      files = repository.ls_files('master')

      expect(files).not_to include('LICENSE')
      expect(files).to include('NEWLICENSE')
    end
330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408

    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
        repository.commit_file(user, "README", 'README!', 'Add README', 'master', true)

        expect do
          repository.update_file(user, 'README', "Updated README!",
                                branch: 'master',
                                previous_path: 'README',
                                message: 'Update README',
                                author_email: author_email,
                                author_name: author_name)
        end.to change { repository.commits('master').count }.by(1)

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
  end

  describe "#remove_file" do
    it 'removes file successfully' do
      repository.commit_file(user, "README", 'README!', 'Add README', 'master', true)

      expect do
        repository.remove_file(user, "README", "Remove README", 'master')
      end.to change { repository.commits('master').count }.by(1)

      expect(repository.blob_at('master', 'README')).to be_nil
    end

    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
        repository.commit_file(user, "README", 'README!', 'Add README', 'master', true)

        expect do
          repository.remove_file(user, "README", "Remove README", 'master', author_email: author_email, author_name: author_name)
        end.to change { repository.commits('master').count }.by(1)

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
  end

  describe '#get_committer_and_author' do
    it 'returns the committer and author data' do
      options = repository.get_committer_and_author(user)
      expect(options[:committer][:email]).to eq(user.email)
      expect(options[:author][:email]).to eq(user.email)
    end

    context 'when the email/name are given' do
      it 'returns an object containing the email/name' do
        options = repository.get_committer_and_author(user, email: author_email, name: author_name)
        expect(options[:author][:email]).to eq(author_email)
        expect(options[:author][:name]).to eq(author_name)
      end
    end

    context 'when the email is given but the name is not' do
      it 'returns the committer as the author' do
        options = repository.get_committer_and_author(user, email: author_email)
        expect(options[:author][:email]).to eq(user.email)
        expect(options[:author][:name]).to eq(user.name)
      end
    end

    context 'when the name is given but the email is not' do
      it 'returns nil' do
        options = repository.get_committer_and_author(user, name: author_name)
        expect(options[:author][:email]).to eq(user.email)
        expect(options[:author][:name]).to eq(user.name)
      end
    end
T
tiagonbotelho 已提交
409 410
  end

V
Valery Sizov 已提交
411 412
  describe "search_files_by_content" do
    let(:results) { repository.search_files_by_content('feature', 'master') }
413 414 415 416
    subject { results }

    it { is_expected.to be_an Array }

417
    it 'regex-escapes the query string' do
V
Valery Sizov 已提交
418
      results = repository.search_files_by_content("test\\", 'master')
419 420 421 422

      expect(results.first).not_to start_with('fatal:')
    end

423
    it 'properly handles an unmatched parenthesis' do
V
Valery Sizov 已提交
424
      results = repository.search_files_by_content("test(", 'master')
425 426 427 428

      expect(results.first).not_to start_with('fatal:')
    end

V
Valery Sizov 已提交
429
    it 'properly handles when query is not present' do
V
Valery Sizov 已提交
430
      results = repository.search_files_by_content('', 'master')
V
Valery Sizov 已提交
431 432 433 434 435 436

      expect(results).to match_array([])
    end

    it 'properly handles query when repo is empty' do
      repository = create(:empty_project).repository
V
Valery Sizov 已提交
437
      results = repository.search_files_by_content('test', 'master')
V
Valery Sizov 已提交
438 439 440 441

      expect(results).to match_array([])
    end

442 443 444 445
    describe 'result' do
      subject { results.first }

      it { is_expected.to be_an String }
446
      it { expect(subject.lines[2]).to eq("master:CHANGELOG:190:  - Feature: Replace teams with group membership\n") }
447 448
    end
  end
Z
Zeger-Jan van de Weg 已提交
449

V
Valery Sizov 已提交
450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471
  describe "search_files_by_name" do
    let(:results) { repository.search_files_by_name('files', 'master') }

    it 'returns result' do
      expect(results.first).to eq('files/html/500.html')
    end

    it 'properly handles when query is not present' do
      results = repository.search_files_by_name('', 'master')

      expect(results).to match_array([])
    end

    it 'properly handles query when repo is empty' do
      repository = create(:empty_project).repository

      results = repository.search_files_by_name('test', 'master')

      expect(results).to match_array([])
    end
  end

472 473 474 475 476 477 478 479 480 481
  describe '#create_ref' do
    it 'redirects the call to fetch_ref' do
      ref, ref_path = '1', '2'

      expect(repository).to receive(:fetch_ref).with(repository.path_to_repo, ref, ref_path)

      repository.create_ref(ref, ref_path)
    end
  end

482
  describe "#changelog", caching: true do
483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513
    it 'accepts changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('changelog')])

      expect(repository.changelog.name).to eq('changelog')
    end

    it 'accepts news instead of changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('news')])

      expect(repository.changelog.name).to eq('news')
    end

    it 'accepts history instead of changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('history')])

      expect(repository.changelog.name).to eq('history')
    end

    it 'accepts changes instead of changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('changes')])

      expect(repository.changelog.name).to eq('changes')
    end

    it 'is case-insensitive' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('CHANGELOG')])

      expect(repository.changelog.name).to eq('CHANGELOG')
    end
  end

514
  describe "#license_blob", caching: true do
515
    before do
516
      repository.remove_file(user, 'LICENSE', 'Remove LICENSE', 'master')
517 518
    end

519 520
    it 'handles when HEAD points to non-existent ref' do
      repository.commit_file(user, 'LICENSE', 'Copyright!', 'Add LICENSE', 'master', false)
521 522 523

      allow(repository).to receive(:file_on_head).
        and_raise(Rugged::ReferenceError)
524 525 526 527

      expect(repository.license_blob).to be_nil
    end

528 529 530 531 532 533 534
    it 'looks in the root_ref only' do
      repository.remove_file(user, 'LICENSE', 'Remove LICENSE', 'markdown')
      repository.commit_file(user, 'LICENSE', Licensee::License.new('mit').content, 'Add LICENSE', 'markdown', false)

      expect(repository.license_blob).to be_nil
    end

535 536
    it 'detects license file with no recognizable open-source license content' do
      repository.commit_file(user, 'LICENSE', 'Copyright!', 'Add LICENSE', 'master', false)
537 538 539 540

      expect(repository.license_blob.name).to eq('LICENSE')
    end

541 542 543
    %w[LICENSE LICENCE LiCensE LICENSE.md LICENSE.foo COPYING COPYING.md].each do |filename|
      it "detects '#{filename}'" do
        repository.commit_file(user, filename, Licensee::License.new('mit').content, "Add #{filename}", 'master', false)
544

545 546
        expect(repository.license_blob.name).to eq(filename)
      end
547 548 549
    end
  end

550
  describe '#license_key', caching: true do
551 552 553
    before do
      repository.remove_file(user, 'LICENSE', 'Remove LICENSE', 'master')
    end
Z
Zeger-Jan van de Weg 已提交
554

555
    it 'returns nil when no license is detected' do
556 557 558
      expect(repository.license_key).to be_nil
    end

559 560 561
    it 'returns nil when the repository does not exist' do
      expect(repository).to receive(:exists?).and_return(false)

562 563 564 565 566 567 568
      expect(repository.license_key).to be_nil
    end

    it 'detects license file with no recognizable open-source license content' do
      repository.commit_file(user, 'LICENSE', 'Copyright!', 'Add LICENSE', 'master', false)

      expect(repository.license_key).to be_nil
Z
Zeger-Jan van de Weg 已提交
569
    end
570

571 572
    it 'returns the license key' do
      repository.commit_file(user, 'LICENSE', Licensee::License.new('mit').content, 'Add LICENSE', 'master', false)
573

574
      expect(repository.license_key).to eq('mit')
575
    end
Z
Zeger-Jan van de Weg 已提交
576
  end
577

578
  describe "#gitlab_ci_yml", caching: true do
579 580 581 582 583 584 585 586 587 588 589 590 591
    it 'returns valid file' do
      files = [TestBlob.new('file'), TestBlob.new('.gitlab-ci.yml'), TestBlob.new('copying')]
      expect(repository.tree).to receive(:blobs).and_return(files)

      expect(repository.gitlab_ci_yml.name).to eq('.gitlab-ci.yml')
    end

    it 'returns nil if not exists' do
      expect(repository.tree).to receive(:blobs).and_return([])
      expect(repository.gitlab_ci_yml).to be_nil
    end

    it 'returns nil for empty repository' do
592
      allow(repository).to receive(:file_on_head).and_raise(Rugged::ReferenceError)
593 594 595 596
      expect(repository.gitlab_ci_yml).to be_nil
    end
  end

597
  describe '#add_branch' do
598
    context 'when pre hooks were successful' do
599
      it 'runs without errors' do
600
        hook = double(trigger: [true, nil])
601
        expect(Gitlab::Git::Hook).to receive(:new).exactly(3).times.and_return(hook)
602 603 604 605

        expect { repository.add_branch(user, 'new_feature', 'master') }.not_to raise_error
      end

606
      it 'creates the branch' do
607
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([true, nil])
608 609 610 611 612

        branch = repository.add_branch(user, 'new_feature', 'master')

        expect(branch.name).to eq('new_feature')
      end
613 614 615 616 617 618

      it 'calls the after_create_branch hook' do
        expect(repository).to receive(:after_create_branch)

        repository.add_branch(user, 'new_feature', 'master')
      end
619 620 621
    end

    context 'when pre hooks failed' do
622
      it 'gets an error' do
623
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([false, ''])
624 625 626 627 628 629

        expect do
          repository.add_branch(user, 'new_feature', 'master')
        end.to raise_error(GitHooksService::PreReceiveError)
      end

630
      it 'does not create the branch' do
631
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([false, ''])
632 633 634 635 636 637 638 639 640

        expect do
          repository.add_branch(user, 'new_feature', 'master')
        end.to raise_error(GitHooksService::PreReceiveError)
        expect(repository.find_branch('new_feature')).to be_nil
      end
    end
  end

641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658
  describe '#find_branch' do
    it 'loads a branch with a fresh repo' do
      expect(Gitlab::Git::Repository).to receive(:new).twice.and_call_original

      2.times do
        expect(repository.find_branch('feature')).not_to be_nil
      end
    end

    it 'loads a branch with a cached repo' do
      expect(Gitlab::Git::Repository).to receive(:new).once.and_call_original

      2.times do
        expect(repository.find_branch('feature', fresh_repo: false)).not_to be_nil
      end
    end
  end

659
  describe '#rm_branch' do
660 661 662
    let(:old_rev) { '0b4bc9a49b562e85de7cc9e834518ea6828729b9' } # git rev-parse feature
    let(:blank_sha) { '0000000000000000000000000000000000000000' }

663
    context 'when pre hooks were successful' do
664
      it 'runs without errors' do
665 666
        expect_any_instance_of(GitHooksService).to receive(:execute).
          with(user, project.repository.path_to_repo, old_rev, blank_sha, 'refs/heads/feature')
667 668 669 670

        expect { repository.rm_branch(user, 'feature') }.not_to raise_error
      end

671
      it 'deletes the branch' do
672
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([true, nil])
673 674 675 676 677 678 679 680

        expect { repository.rm_branch(user, 'feature') }.not_to raise_error

        expect(repository.find_branch('feature')).to be_nil
      end
    end

    context 'when pre hooks failed' do
681
      it 'gets an error' do
682
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([false, ''])
683 684 685 686 687 688

        expect do
          repository.rm_branch(user, 'new_feature')
        end.to raise_error(GitHooksService::PreReceiveError)
      end

689
      it 'does not delete the branch' do
690
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([false, ''])
691 692 693 694 695 696 697 698 699

        expect do
          repository.rm_branch(user, 'feature')
        end.to raise_error(GitHooksService::PreReceiveError)
        expect(repository.find_branch('feature')).not_to be_nil
      end
    end
  end

700
  describe '#update_branch_with_hooks' do
701
    let(:old_rev) { '0b4bc9a49b562e85de7cc9e834518ea6828729b9' } # git rev-parse feature
702
    let(:new_rev) { 'a74ae73c1ccde9b974a70e82b901588071dc142a' } # commit whose parent is old_rev
703

704
    context 'when pre hooks were successful' do
705 706
      before do
        expect_any_instance_of(GitHooksService).to receive(:execute).
707
          with(user, repository.path_to_repo, old_rev, new_rev, 'refs/heads/feature').
708
          and_yield.and_return(true)
709
      end
710

711
      it 'runs without errors' do
712
        expect do
713
          repository.update_branch_with_hooks(user, 'feature') { new_rev }
714 715
        end.not_to raise_error
      end
716

717
      it 'ensures the autocrlf Git option is set to :input' do
718 719
        expect(repository).to receive(:update_autocrlf_option)

720
        repository.update_branch_with_hooks(user, 'feature') { new_rev }
721
      end
722 723 724

      context "when the branch wasn't empty" do
        it 'updates the head' do
725
          expect(repository.find_branch('feature').dereferenced_target.id).to eq(old_rev)
726
          repository.update_branch_with_hooks(user, 'feature') { new_rev }
727
          expect(repository.find_branch('feature').dereferenced_target.id).to eq(new_rev)
728 729
        end
      end
730 731
    end

732 733
    context 'when the update adds more than one commit' do
      it 'runs without errors' do
734 735 736 737 738 739 740 741
        old_rev = '33f3729a45c02fc67d00adb1b8bca394b0e761d9'

        # old_rev is an ancestor of new_rev
        expect(repository.rugged.merge_base(old_rev, new_rev)).to eq(old_rev)

        # old_rev is not a direct ancestor (parent) of new_rev
        expect(repository.rugged.lookup(new_rev).parent_ids).not_to include(old_rev)

742 743 744
        branch = 'feature-ff-target'
        repository.add_branch(user, branch, old_rev)

745
        expect { repository.update_branch_with_hooks(user, branch) { new_rev } }.not_to raise_error
746 747 748 749 750
      end
    end

    context 'when the update would remove commits from the target branch' do
      it 'raises an exception' do
751
        branch = 'master'
752
        old_rev = repository.find_branch(branch).dereferenced_target.sha
753 754 755 756 757 758 759 760 761

        # The 'master' branch is NOT an ancestor of new_rev.
        expect(repository.rugged.merge_base(old_rev, new_rev)).not_to eq(old_rev)

        # Updating 'master' to new_rev would lose the commits on 'master' that
        # are not contained in new_rev. This should not be allowed.
        expect do
          repository.update_branch_with_hooks(user, branch) { new_rev }
        end.to raise_error(Repository::CommitError)
762 763 764
      end
    end

765
    context 'when pre hooks failed' do
766
      it 'gets an error' do
767
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([false, ''])
768 769

        expect do
770
          repository.update_branch_with_hooks(user, 'feature') { new_rev }
771 772 773
        end.to raise_error(GitHooksService::PreReceiveError)
      end
    end
774 775 776 777

    context 'when target branch is different from source branch' do
      before do
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([true, ''])
778
        allow(repository).to receive(:update_ref!)
779 780 781 782 783 784 785 786
      end

      it 'expires branch cache' do
        expect(repository).not_to receive(:expire_exists_cache)
        expect(repository).not_to receive(:expire_root_ref_cache)
        expect(repository).not_to receive(:expire_emptiness_caches)
        expect(repository).to     receive(:expire_branches_cache)

787
        repository.update_branch_with_hooks(user, 'new-feature') { new_rev }
788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807
      end
    end

    context 'when repository is empty' do
      before do
        allow_any_instance_of(Gitlab::Git::Hook).to receive(:trigger).and_return([true, ''])
      end

      it 'expires creation and branch cache' do
        empty_repository = create(:empty_project, :empty_repo).repository

        expect(empty_repository).to receive(:expire_exists_cache)
        expect(empty_repository).to receive(:expire_root_ref_cache)
        expect(empty_repository).to receive(:expire_emptiness_caches)
        expect(empty_repository).to receive(:expire_branches_cache)

        empty_repository.commit_file(user, 'CHANGELOG', 'Changelog!',
                                     'Updates file content', 'master', false)
      end
    end
808
  end
809

810 811 812 813 814 815
  describe '#exists?' do
    it 'returns true when a repository exists' do
      expect(repository.exists?).to eq(true)
    end

    it 'returns false when a repository does not exist' do
816
      allow(repository).to receive(:refs_directory_exists?).and_return(false)
817 818 819

      expect(repository.exists?).to eq(false)
    end
820 821 822 823 824 825

    it 'returns false when there is no namespace' do
      allow(repository).to receive(:path_with_namespace).and_return(nil)

      expect(repository.exists?).to eq(false)
    end
826 827
  end

828 829 830 831 832
  describe '#has_visible_content?' do
    subject { repository.has_visible_content? }

    describe 'when there are no branches' do
      before do
833
        allow(repository).to receive(:branch_count).and_return(0)
834 835 836 837 838 839
      end

      it { is_expected.to eq(false) }
    end

    describe 'when there are branches' do
840
      it 'returns true' do
841
        expect(repository).to receive(:branch_count).and_return(3)
842 843 844 845 846 847

        expect(subject).to eq(true)
      end
    end
  end

848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866
  describe '#update_autocrlf_option' do
    describe 'when autocrlf is not already set to :input' do
      before do
        repository.raw_repository.autocrlf = true
      end

      it 'sets autocrlf to :input' do
        repository.update_autocrlf_option

        expect(repository.raw_repository.autocrlf).to eq(:input)
      end
    end

    describe 'when autocrlf is already set to :input' do
      before do
        repository.raw_repository.autocrlf = :input
      end

      it 'does nothing' do
867
        expect(repository.raw_repository).not_to receive(:autocrlf=).
868 869 870 871 872 873 874
          with(:input)

        repository.update_autocrlf_option
      end
    end
  end

875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924
  describe '#empty?' do
    let(:empty_repository) { create(:project_empty_repo).repository }

    it 'returns true for an empty repository' do
      expect(empty_repository.empty?).to eq(true)
    end

    it 'returns false for a non-empty repository' do
      expect(repository.empty?).to eq(false)
    end

    it 'caches the output' do
      expect(repository.raw_repository).to receive(:empty?).
        once.
        and_return(false)

      repository.empty?
      repository.empty?
    end
  end

  describe '#root_ref' do
    it 'returns a branch name' do
      expect(repository.root_ref).to be_an_instance_of(String)
    end

    it 'caches the output' do
      expect(repository.raw_repository).to receive(:root_ref).
        once.
        and_return('master')

      repository.root_ref
      repository.root_ref
    end
  end

  describe '#expire_root_ref_cache' do
    it 'expires the root reference cache' do
      repository.root_ref

      expect(repository.raw_repository).to receive(:root_ref).
        once.
        and_return('foo')

      repository.expire_root_ref_cache

      expect(repository.root_ref).to eq('foo')
    end
  end

Y
Yorick Peterse 已提交
925
  describe '#expire_branch_cache' do
926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951
    # This method is private but we need it for testing purposes. Sadly there's
    # no other proper way of testing caching operations.
    let(:cache) { repository.send(:cache) }

    it 'expires the cache for all branches' do
      expect(cache).to receive(:expire).
        at_least(repository.branches.length).
        times

      repository.expire_branch_cache
    end

    it 'expires the cache for all branches when the root branch is given' do
      expect(cache).to receive(:expire).
        at_least(repository.branches.length).
        times

      repository.expire_branch_cache(repository.root_ref)
    end

    it 'expires the cache for a specific branch' do
      expect(cache).to receive(:expire).once

      repository.expire_branch_cache('foo')
    end
  end
952

953 954 955
  describe '#expire_emptiness_caches' do
    let(:cache) { repository.send(:cache) }

956 957 958
    it 'expires the caches for an empty repository' do
      allow(repository).to receive(:empty?).and_return(true)

959 960 961 962
      expect(cache).to receive(:expire).with(:empty?)

      repository.expire_emptiness_caches
    end
963 964 965 966 967 968 969 970

    it 'does not expire the cache for a non-empty repository' do
      allow(repository).to receive(:empty?).and_return(false)

      expect(cache).not_to receive(:expire).with(:empty?)

      repository.expire_emptiness_caches
    end
971 972
  end

973
  describe :skip_merged_commit do
974
    subject { repository.commits(Gitlab::Git::BRANCH_REF_PREFIX + "'test'", limit: 100, skip_merges: true).map{ |k| k.id } }
975 976 977

    it { is_expected.not_to include('e56497bb5f03a90a51293fc6d516788730953899') }
  end
978 979

  describe '#merge' do
980
    it 'merges the code and return the commit id' do
R
Rubén Dávila 已提交
981 982
      expect(merge_commit).to be_present
      expect(repository.blob_at(merge_commit.id, 'files/ruby/feature.rb')).to be_present
983
    end
984 985 986 987 988 989 990 991

    it 'sets the `in_progress_merge_commit_sha` flag for the given merge request' do
      merge_request = create(:merge_request, source_branch: 'feature', target_branch: 'master', source_project: project)
      merge_commit_id = repository.merge(user, merge_request, commit_options)
      repository.commit(merge_commit_id)

      expect(merge_request.in_progress_merge_commit_sha).to eq(merge_commit_id)
    end
992 993
  end

994 995 996
  describe '#revert' do
    let(:new_image_commit) { repository.commit('33f3729a45c02fc67d00adb1b8bca394b0e761d9') }
    let(:update_image_commit) { repository.commit('2f63565e7aac07bcdadb654e253078b727143ec4') }
997

998
    context 'when there is a conflict' do
999
      it 'aborts the operation' do
1000 1001 1002 1003 1004
        expect(repository.revert(user, new_image_commit, 'master')).to eq(false)
      end
    end

    context 'when commit was already reverted' do
1005
      it 'aborts the operation' do
1006 1007 1008 1009 1010 1011 1012
        repository.revert(user, update_image_commit, 'master')

        expect(repository.revert(user, update_image_commit, 'master')).to eq(false)
      end
    end

    context 'when commit can be reverted' do
1013
      it 'reverts the changes' do
1014 1015 1016 1017 1018
        expect(repository.revert(user, update_image_commit, 'master')).to be_truthy
      end
    end

    context 'reverting a merge commit' do
1019
      it 'reverts the changes' do
1020 1021 1022 1023 1024 1025
        merge_commit
        expect(repository.blob_at_branch('master', 'files/ruby/feature.rb')).to be_present

        repository.revert(user, merge_commit, 'master')
        expect(repository.blob_at_branch('master', 'files/ruby/feature.rb')).not_to be_present
      end
1026 1027
    end
  end
1028

P
P.S.V.R 已提交
1029 1030 1031 1032 1033 1034
  describe '#cherry_pick' do
    let(:conflict_commit) { repository.commit('c642fe9b8b9f28f9225d7ea953fe14e74748d53b') }
    let(:pickable_commit) { repository.commit('7d3b0f7cff5f37573aea97cebfd5692ea1689924') }
    let(:pickable_merge) { repository.commit('e56497bb5f03a90a51293fc6d516788730953899') }

    context 'when there is a conflict' do
1035
      it 'aborts the operation' do
P
P.S.V.R 已提交
1036 1037 1038 1039 1040
        expect(repository.cherry_pick(user, conflict_commit, 'master')).to eq(false)
      end
    end

    context 'when commit was already cherry-picked' do
1041
      it 'aborts the operation' do
P
P.S.V.R 已提交
1042 1043 1044 1045 1046 1047 1048
        repository.cherry_pick(user, pickable_commit, 'master')

        expect(repository.cherry_pick(user, pickable_commit, 'master')).to eq(false)
      end
    end

    context 'when commit can be cherry-picked' do
1049
      it 'cherry-picks the changes' do
P
P.S.V.R 已提交
1050 1051 1052 1053 1054
        expect(repository.cherry_pick(user, pickable_commit, 'master')).to be_truthy
      end
    end

    context 'cherry-picking a merge commit' do
1055
      it 'cherry-picks the changes' do
1056
        expect(repository.blob_at_branch('improve/awesome', 'foo/bar/.gitkeep')).to be_nil
P
P.S.V.R 已提交
1057

1058 1059
        repository.cherry_pick(user, pickable_merge, 'improve/awesome')
        expect(repository.blob_at_branch('improve/awesome', 'foo/bar/.gitkeep')).not_to be_nil
P
P.S.V.R 已提交
1060 1061 1062 1063
      end
    end
  end

1064 1065 1066 1067 1068 1069 1070
  describe '#before_delete' do
    describe 'when a repository does not exist' do
      before do
        allow(repository).to receive(:exists?).and_return(false)
      end

      it 'does not flush caches that depend on repository data' do
1071
        expect(repository).not_to receive(:expire_cache)
1072 1073 1074 1075

        repository.before_delete
      end

1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087
      it 'flushes the tags cache' do
        expect(repository).to receive(:expire_tags_cache)

        repository.before_delete
      end

      it 'flushes the branches cache' do
        expect(repository).to receive(:expire_branches_cache)

        repository.before_delete
      end

1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098
      it 'flushes the root ref cache' do
        expect(repository).to receive(:expire_root_ref_cache)

        repository.before_delete
      end

      it 'flushes the emptiness caches' do
        expect(repository).to receive(:expire_emptiness_caches)

        repository.before_delete
      end
1099 1100

      it 'flushes the exists cache' do
1101
        expect(repository).to receive(:expire_exists_cache).twice
1102 1103 1104

        repository.before_delete
      end
1105 1106 1107 1108 1109 1110 1111
    end

    describe 'when a repository exists' do
      before do
        allow(repository).to receive(:exists?).and_return(true)
      end

1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123
      it 'flushes the tags cache' do
        expect(repository).to receive(:expire_tags_cache)

        repository.before_delete
      end

      it 'flushes the branches cache' do
        expect(repository).to receive(:expire_branches_cache)

        repository.before_delete
      end

1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151
      it 'flushes the root ref cache' do
        expect(repository).to receive(:expire_root_ref_cache)

        repository.before_delete
      end

      it 'flushes the emptiness caches' do
        expect(repository).to receive(:expire_emptiness_caches)

        repository.before_delete
      end
    end
  end

  describe '#before_change_head' do
    it 'flushes the branch cache' do
      expect(repository).to receive(:expire_branch_cache)

      repository.before_change_head
    end

    it 'flushes the root ref cache' do
      expect(repository).to receive(:expire_root_ref_cache)

      repository.before_change_head
    end
  end

Y
Yorick Peterse 已提交
1152
  describe '#before_push_tag' do
1153
    it 'flushes the cache' do
1154 1155 1156
      expect(repository).to receive(:expire_statistics_caches)
      expect(repository).to receive(:expire_emptiness_caches)
      expect(repository).to receive(:expire_tags_cache)
1157

Y
Yorick Peterse 已提交
1158
      repository.before_push_tag
1159 1160 1161
    end
  end

1162
  describe '#before_import' do
1163 1164
    it 'flushes the repository caches' do
      expect(repository).to receive(:expire_content_cache)
1165 1166 1167 1168 1169

      repository.before_import
    end
  end

1170
  describe '#after_import' do
1171 1172
    it 'flushes and builds the cache' do
      expect(repository).to receive(:expire_content_cache)
1173 1174
      expect(repository).to receive(:expire_tags_cache)
      expect(repository).to receive(:expire_branches_cache)
1175 1176 1177

      repository.after_import
    end
1178 1179 1180
  end

  describe '#after_push_commit' do
1181 1182 1183 1184 1185 1186 1187
    it 'expires statistics caches' do
      expect(repository).to receive(:expire_statistics_caches).
        and_call_original

      expect(repository).to receive(:expire_branch_cache).
        with('master').
        and_call_original
1188

1189
      repository.after_push_commit('master')
1190 1191 1192 1193
    end
  end

  describe '#after_create_branch' do
1194
    it 'expires the branch caches' do
1195
      expect(repository).to receive(:expire_branches_cache)
1196 1197 1198 1199 1200 1201

      repository.after_create_branch
    end
  end

  describe '#after_remove_branch' do
1202
    it 'expires the branch caches' do
1203
      expect(repository).to receive(:expire_branches_cache)
1204 1205 1206 1207

      repository.after_remove_branch
    end
  end
1208

1209 1210 1211 1212 1213 1214
  describe '#after_create' do
    it 'flushes the exists cache' do
      expect(repository).to receive(:expire_exists_cache)

      repository.after_create
    end
1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226

    it 'flushes the root ref cache' do
      expect(repository).to receive(:expire_root_ref_cache)

      repository.after_create
    end

    it 'flushes the emptiness caches' do
      expect(repository).to receive(:expire_emptiness_caches)

      repository.after_create
    end
1227 1228
  end

1229 1230 1231 1232 1233 1234 1235 1236 1237 1238
  describe "#copy_gitattributes" do
    it 'returns true with a valid ref' do
      expect(repository.copy_gitattributes('master')).to be_truthy
    end

    it 'returns false with an invalid ref' do
      expect(repository.copy_gitattributes('invalid')).to be_falsey
    end
  end

Y
Yorick Peterse 已提交
1239 1240
  describe '#before_remove_tag' do
    it 'flushes the tag cache' do
1241 1242
      expect(repository).to receive(:expire_tags_cache).and_call_original
      expect(repository).to receive(:expire_statistics_caches).and_call_original
Y
Yorick Peterse 已提交
1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259

      repository.before_remove_tag
    end
  end

  describe '#branch_count' do
    it 'returns the number of branches' do
      expect(repository.branch_count).to be_an_instance_of(Fixnum)
    end
  end

  describe '#tag_count' do
    it 'returns the number of tags' do
      expect(repository.tag_count).to be_an_instance_of(Fixnum)
    end
  end

1260
  describe '#expire_branches_cache' do
Y
Yorick Peterse 已提交
1261
    it 'expires the cache' do
1262 1263 1264
      expect(repository).to receive(:expire_method_caches).
        with(%i(branch_names branch_count)).
        and_call_original
Y
Yorick Peterse 已提交
1265

1266
      repository.expire_branches_cache
Y
Yorick Peterse 已提交
1267 1268 1269
    end
  end

1270
  describe '#expire_tags_cache' do
Y
Yorick Peterse 已提交
1271
    it 'expires the cache' do
1272 1273 1274
      expect(repository).to receive(:expire_method_caches).
        with(%i(tag_names tag_count)).
        and_call_original
Y
Yorick Peterse 已提交
1275

1276
      repository.expire_tags_cache
Y
Yorick Peterse 已提交
1277 1278
    end
  end
1279

1280
  describe '#add_tag' do
1281 1282
    context 'with a valid target' do
      let(:user) { build_stubbed(:user) }
1283

1284 1285 1286 1287 1288 1289
      it 'creates the tag using rugged' do
        expect(repository.rugged.tags).to receive(:create).
          with('8.5', repository.commit('master').id,
            hash_including(message: 'foo',
                           tagger: hash_including(name: user.name, email: user.email))).
          and_call_original
1290

1291 1292 1293 1294 1295 1296 1297 1298
        repository.add_tag(user, '8.5', 'master', 'foo')
      end

      it 'returns a Gitlab::Git::Tag object' do
        tag = repository.add_tag(user, '8.5', 'master', 'foo')

        expect(tag).to be_a(Gitlab::Git::Tag)
      end
1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324

      it 'passes commit SHA to pre-receive and update hooks,\
        and tag SHA to post-receive hook' do
        pre_receive_hook = Gitlab::Git::Hook.new('pre-receive', repository.path_to_repo)
        update_hook = Gitlab::Git::Hook.new('update', repository.path_to_repo)
        post_receive_hook = Gitlab::Git::Hook.new('post-receive', repository.path_to_repo)

        allow(Gitlab::Git::Hook).to receive(:new).
          and_return(pre_receive_hook, update_hook, post_receive_hook)

        allow(pre_receive_hook).to receive(:trigger).and_call_original
        allow(update_hook).to receive(:trigger).and_call_original
        allow(post_receive_hook).to receive(:trigger).and_call_original

        tag = repository.add_tag(user, '8.5', 'master', 'foo')

        commit_sha = repository.commit('master').id
        tag_sha = tag.target

        expect(pre_receive_hook).to have_received(:trigger).
          with(anything, anything, commit_sha, anything)
        expect(update_hook).to have_received(:trigger).
          with(anything, anything, commit_sha, anything)
        expect(post_receive_hook).to have_received(:trigger).
          with(anything, anything, tag_sha, anything)
      end
1325 1326 1327 1328 1329 1330
    end

    context 'with an invalid target' do
      it 'returns false' do
        expect(repository.add_tag(user, '8.5', 'bar', 'foo')).to be false
      end
1331 1332 1333
    end
  end

1334 1335 1336 1337 1338 1339 1340 1341 1342 1343
  describe '#rm_branch' do
    let(:user) { create(:user) }

    it 'removes a branch' do
      expect(repository).to receive(:before_remove_branch)
      expect(repository).to receive(:after_remove_branch)

      repository.rm_branch(user, 'feature')
    end
  end
1344 1345 1346 1347

  describe '#rm_tag' do
    it 'removes a tag' do
      expect(repository).to receive(:before_remove_tag)
R
Robert Schilling 已提交
1348
      expect(repository.rugged.tags).to receive(:delete).with('v1.1.0')
1349

R
Robert Schilling 已提交
1350
      repository.rm_tag('v1.1.0')
1351 1352
    end
  end
1353 1354

  describe '#avatar' do
1355
    it 'returns nil if repo does not exist' do
1356 1357
      expect(repository).to receive(:file_on_head).
        and_raise(Rugged::ReferenceError)
1358 1359 1360 1361

      expect(repository.avatar).to eq(nil)
    end

1362
    it 'returns the first avatar file found in the repository' do
1363 1364 1365
      expect(repository).to receive(:file_on_head).
        with(:avatar).
        and_return(double(:tree, path: 'logo.png'))
1366 1367 1368 1369 1370

      expect(repository.avatar).to eq('logo.png')
    end

    it 'caches the output' do
1371 1372 1373 1374
      expect(repository).to receive(:file_on_head).
        with(:avatar).
        once.
        and_return(double(:tree, path: 'logo.png'))
1375

1376
      2.times { expect(repository.avatar).to eq('logo.png') }
1377 1378
    end
  end
1379

1380 1381 1382 1383 1384 1385 1386 1387 1388 1389
  describe '#expire_exists_cache' do
    let(:cache) { repository.send(:cache) }

    it 'expires the cache' do
      expect(cache).to receive(:expire).with(:exists?)

      repository.expire_exists_cache
    end
  end

1390
  describe "#keep_around" do
1391 1392 1393 1394
    it "does not fail if we attempt to reference bad commit" do
      expect(repository.kept_around?('abc1234')).to be_falsey
    end

1395 1396 1397 1398 1399
    it "stores a reference to the specified commit sha so it isn't garbage collected" do
      repository.keep_around(sample_commit.id)

      expect(repository.kept_around?(sample_commit.id)).to be_truthy
    end
1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415

    it "attempting to call keep_around on truncated ref does not fail" do
      repository.keep_around(sample_commit.id)
      ref = repository.send(:keep_around_ref_name, sample_commit.id)
      path = File.join(repository.path, ref)
      # Corrupt the reference
      File.truncate(path, 0)

      expect(repository.kept_around?(sample_commit.id)).to be_falsey

      repository.keep_around(sample_commit.id)

      expect(repository.kept_around?(sample_commit.id)).to be_falsey

      File.delete(path)
    end
1416
  end
1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430

  describe '#update_ref!' do
    it 'can create a ref' do
      repository.update_ref!('refs/heads/foobar', 'refs/heads/master', Gitlab::Git::BLANK_SHA)

      expect(repository.find_branch('foobar')).not_to be_nil
    end

    it 'raises CommitError when the ref update fails' do
      expect do
        repository.update_ref!('refs/heads/master', 'refs/heads/master', Gitlab::Git::BLANK_SHA)
      end.to raise_error(Repository::CommitError)
    end
  end
1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445

  describe '#contribution_guide', caching: true do
    it 'returns and caches the output' do
      expect(repository).to receive(:file_on_head).
        with(:contributing).
        and_return(Gitlab::Git::Tree.new(path: 'CONTRIBUTING.md')).
        once

      2.times do
        expect(repository.contribution_guide).
          to be_an_instance_of(Gitlab::Git::Tree)
      end
    end
  end

1446
  describe '#gitignore', caching: true do
1447 1448
    it 'returns and caches the output' do
      expect(repository).to receive(:file_on_head).
1449 1450
        with(:gitignore).
        and_return(Gitlab::Git::Tree.new(path: '.gitignore')).
1451 1452 1453
        once

      2.times do
1454
        expect(repository.gitignore).to be_an_instance_of(Gitlab::Git::Tree)
1455 1456 1457 1458
      end
    end
  end

1459
  describe '#koding_yml', caching: true do
1460 1461
    it 'returns and caches the output' do
      expect(repository).to receive(:file_on_head).
1462 1463
        with(:koding).
        and_return(Gitlab::Git::Tree.new(path: '.koding.yml')).
1464 1465 1466
        once

      2.times do
1467
        expect(repository.koding_yml).to be_an_instance_of(Gitlab::Git::Tree)
1468 1469 1470 1471
      end
    end
  end

1472 1473 1474 1475
  describe '#readme', caching: true do
    context 'with a non-existing repository' do
      it 'returns nil' do
        expect(repository).to receive(:tree).with(:head).and_return(nil)
1476

1477 1478 1479
        expect(repository.readme).to be_nil
      end
    end
1480

1481 1482 1483
    context 'with an existing repository' do
      it 'returns the README' do
        expect(repository.readme).to be_an_instance_of(Gitlab::Git::Blob)
1484 1485 1486 1487
      end
    end
  end

1488 1489 1490 1491
  describe '#expire_statistics_caches' do
    it 'expires the caches' do
      expect(repository).to receive(:expire_method_caches).
        with(%i(size commit_count))
1492

1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543
      repository.expire_statistics_caches
    end
  end

  describe '#expire_method_caches' do
    it 'expires the caches of the given methods' do
      expect_any_instance_of(RepositoryCache).to receive(:expire).with(:readme)
      expect_any_instance_of(RepositoryCache).to receive(:expire).with(:gitignore)

      repository.expire_method_caches(%i(readme gitignore))
    end
  end

  describe '#expire_all_method_caches' do
    it 'expires the caches of all methods' do
      expect(repository).to receive(:expire_method_caches).
        with(Repository::CACHED_METHODS)

      repository.expire_all_method_caches
    end
  end

  describe '#expire_avatar_cache' do
    it 'expires the cache' do
      expect(repository).to receive(:expire_method_caches).with(%i(avatar))

      repository.expire_avatar_cache
    end
  end

  describe '#file_on_head' do
    context 'with a non-existing repository' do
      it 'returns nil' do
        expect(repository).to receive(:tree).with(:head).and_return(nil)

        expect(repository.file_on_head(:readme)).to be_nil
      end
    end

    context 'with a repository that has no blobs' do
      it 'returns nil' do
        expect_any_instance_of(Tree).to receive(:blobs).and_return([])

        expect(repository.file_on_head(:readme)).to be_nil
      end
    end

    context 'with an existing repository' do
      it 'returns a Gitlab::Git::Tree' do
        expect(repository.file_on_head(:readme)).
          to be_an_instance_of(Gitlab::Git::Tree)
1544 1545 1546 1547
      end
    end
  end

1548 1549 1550 1551 1552 1553
  describe '#head_tree' do
    context 'with an existing repository' do
      it 'returns a Tree' do
        expect(repository.head_tree).to be_an_instance_of(Tree)
      end
    end
1554

1555 1556 1557 1558 1559
    context 'with a non-existing repository' do
      it 'returns nil' do
        expect(repository).to receive(:head_commit).and_return(nil)

        expect(repository.head_tree).to be_nil
1560 1561 1562 1563
      end
    end
  end

1564 1565 1566 1567 1568
  describe '#tree' do
    context 'using a non-existing repository' do
      before do
        allow(repository).to receive(:head_commit).and_return(nil)
      end
1569

1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634
      it 'returns nil' do
        expect(repository.tree(:head)).to be_nil
      end

      it 'returns nil when using a path' do
        expect(repository.tree(:head, 'README.md')).to be_nil
      end
    end

    context 'using an existing repository' do
      it 'returns a Tree' do
        expect(repository.tree(:head)).to be_an_instance_of(Tree)
      end
    end
  end

  describe '#size' do
    context 'with a non-existing repository' do
      it 'returns 0' do
        expect(repository).to receive(:exists?).and_return(false)

        expect(repository.size).to eq(0.0)
      end
    end

    context 'with an existing repository' do
      it 'returns the repository size as a Float' do
        expect(repository.size).to be_an_instance_of(Float)
      end
    end
  end

  describe '#commit_count' do
    context 'with a non-existing repository' do
      it 'returns 0' do
        expect(repository).to receive(:root_ref).and_return(nil)

        expect(repository.commit_count).to eq(0)
      end
    end

    context 'with an existing repository' do
      it 'returns the commit count' do
        expect(repository.commit_count).to be_an_instance_of(Fixnum)
      end
    end
  end

  describe '#cache_method_output', caching: true do
    context 'with a non-existing repository' do
      let(:value) do
        repository.cache_method_output(:cats, fallback: 10) do
          raise Rugged::ReferenceError
        end
      end

      it 'returns a fallback value' do
        expect(value).to eq(10)
      end

      it 'does not cache the data' do
        value

        expect(repository.instance_variable_defined?(:@cats)).to eq(false)
        expect(repository.send(:cache).exist?(:cats)).to eq(false)
1635 1636
      end
    end
1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666

    context 'with an existing repository' do
      it 'caches the output' do
        object = double

        expect(object).to receive(:number).once.and_return(10)

        2.times do
          val = repository.cache_method_output(:cats) { object.number }

          expect(val).to eq(10)
        end

        expect(repository.send(:cache).exist?(:cats)).to eq(true)
        expect(repository.instance_variable_get(:@cats)).to eq(10)
      end
    end
  end

  describe '#refresh_method_caches' do
    it 'refreshes the caches of the given types' do
      expect(repository).to receive(:expire_method_caches).
        with(%i(readme license_blob license_key))

      expect(repository).to receive(:readme)
      expect(repository).to receive(:license_blob)
      expect(repository).to receive(:license_key)

      repository.refresh_method_caches(%i(readme license))
    end
1667
  end
1668
end