Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
d1e0b1b3
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
d1e0b1b3
编写于
7月 03, 2017
作者:
T
Tiago Botelho
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Allow creation of files and directories with spaces in web UI
上级
81dba76b
变更
5
隐藏空白更改
内联
并排
Showing
5 changed file
with
35 addition
and
2 deletion
+35
-2
changelogs/unreleased/23162-allow-creation-of-files-and-dirs-with-spaces-in-web-ui.yml
...llow-creation-of-files-and-dirs-with-spaces-in-web-ui.yml
+4
-0
features/steps/project/source/browse_files.rb
features/steps/project/source/browse_files.rb
+1
-1
lib/gitlab/regex.rb
lib/gitlab/regex.rb
+1
-1
spec/lib/gitlab/git/index_spec.rb
spec/lib/gitlab/git/index_spec.rb
+19
-0
spec/models/repository_spec.rb
spec/models/repository_spec.rb
+10
-0
未找到文件。
changelogs/unreleased/23162-allow-creation-of-files-and-dirs-with-spaces-in-web-ui.yml
0 → 100644
浏览文件 @
d1e0b1b3
---
title
:
Allow creation of files and directories with spaces through Web UI
merge_request
:
12608
author
:
features/steps/project/source/browse_files.rb
浏览文件 @
d1e0b1b3
...
...
@@ -93,7 +93,7 @@ class Spinach::Features::ProjectSourceBrowseFiles < Spinach::FeatureSteps
end
step
'I fill the new file name with an illegal name'
do
fill_in
:file_name
,
with:
'
Spaces Not Allowed
'
fill_in
:file_name
,
with:
'
Filename/Slash
'
end
step
'I fill the new file name with a new directory'
do
...
...
lib/gitlab/regex.rb
浏览文件 @
d1e0b1b3
...
...
@@ -20,7 +20,7 @@ module Gitlab
end
def
file_name_regex
@file_name_regex
||=
/\A[
[[:alnum:]]_\-\.\@\+
]*\z/
.
freeze
@file_name_regex
||=
/\A[
^\/\0
]*\z/
.
freeze
end
def
file_name_regex_message
...
...
spec/lib/gitlab/git/index_spec.rb
浏览文件 @
d1e0b1b3
...
...
@@ -25,6 +25,16 @@ describe Gitlab::Git::Index, seed_helper: true do
expect
(
entry
).
not_to
be_nil
expect
(
repository
.
lookup
(
entry
[
:oid
]).
content
).
to
eq
(
options
[
:content
])
end
it
'creates the file if file_path has spaces in between words'
do
options
[
:file_path
]
=
'new file.txt'
index
.
create
(
options
)
entry
=
index
.
get
(
options
[
:file_path
])
expect
(
entry
).
not_to
be_nil
expect
(
repository
.
lookup
(
entry
[
:oid
]).
content
).
to
eq
(
options
[
:content
])
end
end
context
'when a file at that path exists'
do
...
...
@@ -81,6 +91,15 @@ describe Gitlab::Git::Index, seed_helper: true do
expect
(
entry
).
not_to
be_nil
end
it
'creates the dir if it has spaces in between words'
do
options
[
:file_path
]
=
'new dir'
index
.
create_dir
(
options
)
entry
=
index
.
get
(
options
[
:file_path
]
+
'/.gitkeep'
)
expect
(
entry
).
not_to
be_nil
end
end
context
'when a file at that path exists'
do
...
...
spec/models/repository_spec.rb
浏览文件 @
d1e0b1b3
...
...
@@ -347,6 +347,16 @@ describe Repository, models: true do
expect
(
blob
.
data
).
to
eq
(
'Changelog!'
)
end
it
'creates new file with spaces in between successfully'
do
expect
do
repository
.
create_file
(
user
,
'NEW FILE'
,
'File!'
,
message:
'Create NEW FILE'
,
branch_name:
'master'
)
end
.
to
change
{
repository
.
commits
(
'master'
).
count
}.
by
(
1
)
expect
(
repository
.
blob_at
(
'master'
,
'NEW FILE'
).
data
).
to
eq
(
'File!'
)
end
it
'respects the autocrlf setting'
do
repository
.
create_file
(
user
,
'hello.txt'
,
"Hello,
\r\n
World"
,
message:
'Add hello world'
,
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录