migration_test.rb 35.5 KB
Newer Older
1 2
require 'cases/helper'
require 'cases/migration/helper'
3
require 'bigdecimal/util'
4
require 'concurrent/atomic/count_down_latch'
5

J
Jeremy Kemper 已提交
6 7
require 'models/person'
require 'models/topic'
8
require 'models/developer'
A
Arun Agrawal 已提交
9
require 'models/computer'
10 11

require MIGRATIONS_ROOT + "/valid/2_we_need_reminders"
12 13
require MIGRATIONS_ROOT + "/rename/1_we_need_things"
require MIGRATIONS_ROOT + "/rename/2_rename_things"
14
require MIGRATIONS_ROOT + "/decimal/1_give_me_big_numbers"
15

16
class BigNumber < ActiveRecord::Base
17
  unless current_adapter?(:PostgreSQLAdapter, :SQLite3Adapter)
18
    attribute :value_of_e, :integer
19
  end
20
  attribute :my_house_population, :integer
21
end
22

23
class Reminder < ActiveRecord::Base; end
24

25
class Thing < ActiveRecord::Base; end
26

27
class MigrationTest < ActiveRecord::TestCase
28
  self.use_transactional_tests = false
29

30
  fixtures :people
31

32 33
  def setup
    super
A
Akira Matsuda 已提交
34
    %w(reminders people_reminders prefix_reminders_suffix p_things_s).each do |table|
A
Aaron Patterson 已提交
35 36 37
      Reminder.connection.drop_table(table) rescue nil
    end
    Reminder.reset_column_information
38
    @verbose_was, ActiveRecord::Migration.verbose = ActiveRecord::Migration.verbose, false
A
Akira Matsuda 已提交
39
    ActiveRecord::Base.connection.schema_cache.clear!
40
  end
41

G
Guo Xiang Tan 已提交
42
  teardown do
43 44 45
    ActiveRecord::Base.table_name_prefix = ""
    ActiveRecord::Base.table_name_suffix = ""

46 47
    ActiveRecord::Base.connection.initialize_schema_migrations_table
    ActiveRecord::Base.connection.execute "DELETE FROM #{ActiveRecord::Migrator.schema_migrations_table_name}"
48

49
    %w(things awesome_things prefix_things_suffix p_awesome_things_s ).each do |table|
50
      Thing.connection.drop_table(table) rescue nil
51
    end
52
    Thing.reset_column_information
53

54 55 56
    %w(reminders people_reminders prefix_reminders_suffix).each do |table|
      Reminder.connection.drop_table(table) rescue nil
    end
57
    Reminder.reset_table_name
58
    Reminder.reset_column_information
59

60 61 62 63 64 65
    %w(last_name key bio age height wealth birthday favorite_day
       moment_of_truth male administrator funny).each do |column|
      Person.connection.remove_column('people', column) rescue nil
    end
    Person.connection.remove_column("people", "first_name") rescue nil
    Person.connection.remove_column("people", "middle_name") rescue nil
66
    Person.connection.add_column("people", "first_name", :string)
67
    Person.reset_column_information
68 69

    ActiveRecord::Migration.verbose = @verbose_was
70
  end
71

72 73
  def test_migrator_versions
    migrations_path = MIGRATIONS_ROOT + "/valid"
74
    old_path = ActiveRecord::Migrator.migrations_paths
75 76 77 78
    ActiveRecord::Migrator.migrations_paths = migrations_path

    ActiveRecord::Migrator.up(migrations_path)
    assert_equal 3, ActiveRecord::Migrator.current_version
79
    assert_equal false, ActiveRecord::Migrator.needs_migration?
80 81 82

    ActiveRecord::Migrator.down(MIGRATIONS_ROOT + "/valid")
    assert_equal 0, ActiveRecord::Migrator.current_version
83
    assert_equal true, ActiveRecord::Migrator.needs_migration?
84

Y
Yves Senn 已提交
85
    ActiveRecord::SchemaMigration.create!(version: 3)
86 87 88 89 90 91
    assert_equal true, ActiveRecord::Migrator.needs_migration?
  ensure
    ActiveRecord::Migrator.migrations_paths = old_path
  end

  def test_migration_detection_without_schema_migration_table
92
    ActiveRecord::Base.connection.drop_table 'schema_migrations', if_exists: true
93 94 95 96 97 98

    migrations_path = MIGRATIONS_ROOT + "/valid"
    old_path = ActiveRecord::Migrator.migrations_paths
    ActiveRecord::Migrator.migrations_paths = migrations_path

    assert_equal true, ActiveRecord::Migrator.needs_migration?
99 100
  ensure
    ActiveRecord::Migrator.migrations_paths = old_path
101 102
  end

103 104 105 106 107 108 109 110 111 112 113 114 115
  def test_any_migrations
    old_path = ActiveRecord::Migrator.migrations_paths
    ActiveRecord::Migrator.migrations_paths = MIGRATIONS_ROOT + "/valid"

    assert ActiveRecord::Migrator.any_migrations?

    ActiveRecord::Migrator.migrations_paths = MIGRATIONS_ROOT + "/empty"

    assert_not ActiveRecord::Migrator.any_migrations?
  ensure
    ActiveRecord::Migrator.migrations_paths = old_path
  end

116
  def test_migration_version
117
    assert_nothing_raised { ActiveRecord::Migrator.run(:up, MIGRATIONS_ROOT + "/version_check", 20131219224947) }
118 119
  end

120 121 122 123
  def test_create_table_with_force_true_does_not_drop_nonexisting_table
    # using a copy as we need the drop_table method to
    # continue to work for the ensure block of the test
    temp_conn = Person.connection.dup
124 125 126

    assert_not_equal temp_conn, Person.connection

127 128
    temp_conn.create_table :testings2, :force => true do |t|
      t.column :foo, :string
129
    end
130
  ensure
131
    Person.connection.drop_table :testings2, if_exists: true
132
  end
133

134
  def test_migration_instance_has_connection
135
    migration = Class.new(ActiveRecord::Migration::Current).new
136
    assert_equal ActiveRecord::Base.connection, migration.connection
137
  end
138

139
  def test_method_missing_delegates_to_connection
140
    migration = Class.new(ActiveRecord::Migration::Current) {
141 142 143 144 145 146
      def connection
        Class.new {
          def create_table; "hi mom!"; end
        }.new
      end
    }.new
147

148
    assert_equal "hi mom!", migration.method_missing(:create_table)
149
  end
150

151 152 153 154 155
  def test_add_table_with_decimals
    Person.connection.drop_table :big_numbers rescue nil

    assert !BigNumber.table_exists?
    GiveMeBigNumbers.up
156
    BigNumber.reset_column_information
157 158 159 160 161 162 163 164 165

    assert BigNumber.create(
      :bank_balance => 1586.43,
      :big_bank_balance => BigDecimal("1000234000567.95"),
      :world_population => 6000000000,
      :my_house_population => 3,
      :value_of_e => BigDecimal("2.7182818284590452353602875")
    )

166
    b = BigNumber.first
167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209
    assert_not_nil b

    assert_not_nil b.bank_balance
    assert_not_nil b.big_bank_balance
    assert_not_nil b.world_population
    assert_not_nil b.my_house_population
    assert_not_nil b.value_of_e

    # TODO: set world_population >= 2**62 to cover 64-bit platforms and test
    # is_a?(Bignum)
    assert_kind_of Integer, b.world_population
    assert_equal 6000000000, b.world_population
    assert_kind_of Fixnum, b.my_house_population
    assert_equal 3, b.my_house_population
    assert_kind_of BigDecimal, b.bank_balance
    assert_equal BigDecimal("1586.43"), b.bank_balance
    assert_kind_of BigDecimal, b.big_bank_balance
    assert_equal BigDecimal("1000234000567.95"), b.big_bank_balance

    # This one is fun. The 'value_of_e' field is defined as 'DECIMAL' with
    # precision/scale explicitly left out.  By the SQL standard, numbers
    # assigned to this field should be truncated but that's seldom respected.
    if current_adapter?(:PostgreSQLAdapter)
      # - PostgreSQL changes the SQL spec on columns declared simply as
      # "decimal" to something more useful: instead of being given a scale
      # of 0, they take on the compile-time limit for precision and scale,
      # so the following should succeed unless you have used really wacky
      # compilation options
      # - SQLite2 has the default behavior of preserving all data sent in,
      # so this happens there too
      assert_kind_of BigDecimal, b.value_of_e
      assert_equal BigDecimal("2.7182818284590452353602875"), b.value_of_e
    elsif current_adapter?(:SQLite3Adapter)
      # - SQLite3 stores a float, in violation of SQL
      assert_kind_of BigDecimal, b.value_of_e
      assert_in_delta BigDecimal("2.71828182845905"), b.value_of_e, 0.00000000000001
    else
      # - SQL standard is an integer
      assert_kind_of Fixnum, b.value_of_e
      assert_equal 2, b.value_of_e
    end

    GiveMeBigNumbers.down
210
    assert_raise(ActiveRecord::StatementInvalid) { BigNumber.first }
211
  end
212

213
  def test_filtering_migrations
214
    assert_no_column Person, :last_name
215
    assert !Reminder.table_exists?
216

217 218
    name_filter = lambda { |migration| migration.name == "ValidPeopleHaveLastNames" }
    ActiveRecord::Migrator.up(MIGRATIONS_ROOT + "/valid", &name_filter)
219

220
    assert_column Person, :last_name
221
    assert_raise(ActiveRecord::StatementInvalid) { Reminder.first }
222

223 224
    ActiveRecord::Migrator.down(MIGRATIONS_ROOT + "/valid", &name_filter)

225
    assert_no_column Person, :last_name
226
    assert_raise(ActiveRecord::StatementInvalid) { Reminder.first }
227 228
  end

229
  class MockMigration < ActiveRecord::Migration::Current
230 231 232 233
    attr_reader :went_up, :went_down
    def initialize
      @went_up   = false
      @went_down = false
234 235
    end

236 237 238 239
    def up
      @went_up = true
      super
    end
240

241 242 243
    def down
      @went_down = true
      super
244
    end
245
  end
246

247 248 249 250
  def test_instance_based_migration_up
    migration = MockMigration.new
    assert !migration.went_up, 'have not gone up'
    assert !migration.went_down, 'have not gone down'
251

252 253 254 255
    migration.migrate :up
    assert migration.went_up, 'have gone up'
    assert !migration.went_down, 'have not gone down'
  end
256

257 258 259 260
  def test_instance_based_migration_down
    migration = MockMigration.new
    assert !migration.went_up, 'have not gone up'
    assert !migration.went_down, 'have not gone down'
261

262 263 264 265
    migration.migrate :down
    assert !migration.went_up, 'have gone up'
    assert migration.went_down, 'have not gone down'
  end
266

267 268 269 270
  if ActiveRecord::Base.connection.supports_ddl_transactions?
    def test_migrator_one_up_with_exception_and_rollback
      assert_no_column Person, :last_name

271
      migration = Class.new(ActiveRecord::Migration::Current) {
272 273 274 275 276 277
        def version; 100 end
        def migrate(x)
          add_column "people", "last_name", :string
          raise 'Something broke'
        end
      }.new
278

279
      migrator = ActiveRecord::Migrator.new(:up, [migration], 100)
280

281
      e = assert_raise(StandardError) { migrator.migrate }
282

283
      assert_equal "An error has occurred, this and all later migrations canceled:\n\nSomething broke", e.message
284

285 286
      assert_no_column Person, :last_name,
        "On error, the Migrator should revert schema changes but it did not."
B
bondarev 已提交
287 288
    end

289 290
    def test_migrator_one_up_with_exception_and_rollback_using_run
      assert_no_column Person, :last_name
B
bondarev 已提交
291

292
      migration = Class.new(ActiveRecord::Migration::Current) {
293 294 295 296 297 298
        def version; 100 end
        def migrate(x)
          add_column "people", "last_name", :string
          raise 'Something broke'
        end
      }.new
B
bondarev 已提交
299

300
      migrator = ActiveRecord::Migrator.new(:up, [migration], 100)
B
bondarev 已提交
301

302
      e = assert_raise(StandardError) { migrator.run }
B
bondarev 已提交
303

304
      assert_equal "An error has occurred, this migration was canceled:\n\nSomething broke", e.message
B
bondarev 已提交
305

306 307
      assert_no_column Person, :last_name,
        "On error, the Migrator should revert schema changes but it did not."
308 309
    end

310 311
    def test_migration_without_transaction
      assert_no_column Person, :last_name
312

313
      migration = Class.new(ActiveRecord::Migration::Current) {
314
        self.disable_ddl_transaction!
315

316 317 318 319 320 321
        def version; 101 end
        def migrate(x)
          add_column "people", "last_name", :string
          raise 'Something broke'
        end
      }.new
322

323 324 325
      migrator = ActiveRecord::Migrator.new(:up, [migration], 101)
      e = assert_raise(StandardError) { migrator.migrate }
      assert_equal "An error has occurred, all later migrations canceled:\n\nSomething broke", e.message
326

327 328 329 330 331 332 333
      assert_column Person, :last_name,
        "without ddl transactions, the Migrator should not rollback on error but it did."
    ensure
      Person.reset_column_information
      if Person.column_names.include?('last_name')
        Person.connection.remove_column('people', 'last_name')
      end
334
    end
335
  end
336

337
  def test_schema_migrations_table_name
338 339 340
    original_schema_migrations_table_name = ActiveRecord::Migrator.schema_migrations_table_name

    assert_equal "schema_migrations", ActiveRecord::Migrator.schema_migrations_table_name
341 342 343 344
    ActiveRecord::Base.table_name_prefix = "prefix_"
    ActiveRecord::Base.table_name_suffix = "_suffix"
    Reminder.reset_table_name
    assert_equal "prefix_schema_migrations_suffix", ActiveRecord::Migrator.schema_migrations_table_name
345 346 347
    ActiveRecord::Base.schema_migrations_table_name = "changed"
    Reminder.reset_table_name
    assert_equal "prefix_changed_suffix", ActiveRecord::Migrator.schema_migrations_table_name
348 349 350
    ActiveRecord::Base.table_name_prefix = ""
    ActiveRecord::Base.table_name_suffix = ""
    Reminder.reset_table_name
351 352 353 354
    assert_equal "changed", ActiveRecord::Migrator.schema_migrations_table_name
  ensure
    ActiveRecord::Base.schema_migrations_table_name = original_schema_migrations_table_name
    Reminder.reset_table_name
355 356
  end

357
  def test_proper_table_name_on_migration
358
    reminder_class = new_isolated_reminder_class
359 360 361
    migration = ActiveRecord::Migration.new
    assert_equal "table", migration.proper_table_name('table')
    assert_equal "table", migration.proper_table_name(:table)
362 363 364
    assert_equal "reminders", migration.proper_table_name(reminder_class)
    reminder_class.reset_table_name
    assert_equal reminder_class.table_name, migration.proper_table_name(reminder_class)
365 366 367 368

    # Use the model's own prefix/suffix if a model is given
    ActiveRecord::Base.table_name_prefix = "ARprefix_"
    ActiveRecord::Base.table_name_suffix = "_ARsuffix"
369 370 371 372 373 374 375
    reminder_class.table_name_prefix = 'prefix_'
    reminder_class.table_name_suffix = '_suffix'
    reminder_class.reset_table_name
    assert_equal "prefix_reminders_suffix", migration.proper_table_name(reminder_class)
    reminder_class.table_name_prefix = ''
    reminder_class.table_name_suffix = ''
    reminder_class.reset_table_name
376 377 378 379

    # Use AR::Base's prefix/suffix if string or symbol is given
    ActiveRecord::Base.table_name_prefix = "prefix_"
    ActiveRecord::Base.table_name_suffix = "_suffix"
380
    reminder_class.reset_table_name
381 382 383 384
    assert_equal "prefix_table_suffix", migration.proper_table_name('table', migration.table_name_options)
    assert_equal "prefix_table_suffix", migration.proper_table_name(:table, migration.table_name_options)
  end

385 386
  def test_rename_table_with_prefix_and_suffix
    assert !Thing.table_exists?
387 388
    ActiveRecord::Base.table_name_prefix = 'p_'
    ActiveRecord::Base.table_name_suffix = '_s'
389 390 391
    Thing.reset_table_name
    Thing.reset_sequence_name
    WeNeedThings.up
392
    Thing.reset_column_information
393 394

    assert Thing.create("content" => "hello world")
395
    assert_equal "hello world", Thing.first.content
396 397

    RenameThings.up
398
    Thing.table_name = "p_awesome_things_s"
399

400
    assert_equal "hello world", Thing.first.content
401 402 403 404 405 406 407 408 409 410 411
  ensure
    Thing.reset_table_name
    Thing.reset_sequence_name
  end

  def test_add_drop_table_with_prefix_and_suffix
    assert !Reminder.table_exists?
    ActiveRecord::Base.table_name_prefix = 'prefix_'
    ActiveRecord::Base.table_name_suffix = '_suffix'
    Reminder.reset_table_name
    Reminder.reset_sequence_name
412
    Reminder.reset_column_information
413 414
    WeNeedReminders.up
    assert Reminder.create("content" => "hello world", "remind_at" => Time.now)
415
    assert_equal "hello world", Reminder.first.content
416 417

    WeNeedReminders.down
418
    assert_raise(ActiveRecord::StatementInvalid) { Reminder.first }
419 420 421
  ensure
    Reminder.reset_sequence_name
  end
422

423 424 425
  def test_create_table_with_binary_column
    assert_nothing_raised {
      Person.connection.create_table :binary_testings do |t|
426
        t.column "data", :binary, :null => false
427
      end
428 429 430 431
    }

    columns = Person.connection.columns(:binary_testings)
    data_column = columns.detect { |c| c.name == "data" }
432

J
Jon Leighton 已提交
433
    assert_nil data_column.default
434

435
    Person.connection.drop_table :binary_testings, if_exists: true
436 437
  end

438 439 440 441
  unless mysql_enforcing_gtid_consistency?
    def test_create_table_with_query
      Person.connection.drop_table :table_from_query_testings rescue nil
      Person.connection.create_table(:person, force: true)
442

443
      Person.connection.create_table :table_from_query_testings, as: "SELECT id FROM person"
444

445 446 447
      columns = Person.connection.columns(:table_from_query_testings)
      assert_equal 1, columns.length
      assert_equal "id", columns.first.name
448

449 450
      Person.connection.drop_table :table_from_query_testings rescue nil
    end
451

452 453 454
    def test_create_table_with_query_from_relation
      Person.connection.drop_table :table_from_query_testings rescue nil
      Person.connection.create_table(:person, force: true)
455

456
      Person.connection.create_table :table_from_query_testings, as: Person.select(:id)
457

458 459 460
      columns = Person.connection.columns(:table_from_query_testings)
      assert_equal 1, columns.length
      assert_equal "id", columns.first.name
461

462 463
      Person.connection.drop_table :table_from_query_testings rescue nil
    end
464 465
  end

466 467 468 469 470 471 472 473 474 475 476
  if current_adapter? :OracleAdapter
    def test_create_table_with_custom_sequence_name
      # table name is 29 chars, the standard sequence name will
      # be 33 chars and should be shortened
      assert_nothing_raised do
        begin
          Person.connection.create_table :table_with_name_thats_just_ok do |t|
            t.column :foo, :string, :null => false
          end
        ensure
          Person.connection.drop_table :table_with_name_thats_just_ok rescue nil
477 478 479
        end
      end

480 481 482 483 484 485 486
      # should be all good w/ a custom sequence name
      assert_nothing_raised do
        begin
          Person.connection.create_table :table_with_name_thats_just_ok,
            :sequence_name => 'suitably_short_seq' do |t|
            t.column :foo, :string, :null => false
          end
487

488
          Person.connection.execute("select suitably_short_seq.nextval from dual")
489

490 491 492 493
        ensure
          Person.connection.drop_table :table_with_name_thats_just_ok,
            :sequence_name => 'suitably_short_seq' rescue nil
        end
494 495
      end

496 497 498 499
      # confirm the custom sequence got dropped
      assert_raise(ActiveRecord::StatementInvalid) do
        Person.connection.execute("select suitably_short_seq.nextval from dual")
      end
500
    end
501
  end
502

503 504 505
  if current_adapter?(:MysqlAdapter, :Mysql2Adapter, :PostgreSQLAdapter)
    def test_out_of_range_limit_should_raise
      Person.connection.drop_table :test_limits rescue nil
F
Franky W 已提交
506
      e = assert_raise(ActiveRecord::ActiveRecordError, "integer limit didn't raise") do
507 508 509
        Person.connection.create_table :test_integer_limits, :force => true do |t|
          t.column :bigone, :integer, :limit => 10
        end
510 511
      end

F
Franky W 已提交
512 513
      assert_match(/No integer type has byte size 10/, e.message)

514 515 516 517 518
      unless current_adapter?(:PostgreSQLAdapter)
        assert_raise(ActiveRecord::ActiveRecordError, "text limit didn't raise") do
          Person.connection.create_table :test_text_limits, :force => true do |t|
            t.column :bigtext, :text, :limit => 0xfffffffff
          end
519 520 521
        end
      end

522 523
      Person.connection.drop_table :test_limits rescue nil
    end
524 525
  end

526
  if ActiveRecord::Base.connection.supports_advisory_locks?
527
    def test_migrator_generates_valid_lock_id
528
      migration = Class.new(ActiveRecord::Migration::Current).new
529 530
      migrator = ActiveRecord::Migrator.new(:up, [migration], 100)

531
      lock_id = migrator.send(:generate_migrator_advisory_lock_id)
532

533 534 535 536
      assert ActiveRecord::Base.connection.get_advisory_lock(lock_id),
        "the Migrator should have generated a valid lock id, but it didn't"
      assert ActiveRecord::Base.connection.release_advisory_lock(lock_id),
        "the Migrator should have generated a valid lock id, but it didn't"
537 538
    end

539
    def test_generate_migrator_advisory_lock_id
540 541
      # It is important we are consistent with how we generate this so that
      # exclusive locking works across migrator versions
542
      migration = Class.new(ActiveRecord::Migration::Current).new
543 544
      migrator = ActiveRecord::Migrator.new(:up, [migration], 100)

545
      lock_id = migrator.send(:generate_migrator_advisory_lock_id)
546 547 548

      current_database = ActiveRecord::Base.connection.current_database
      salt = ActiveRecord::Migrator::MIGRATOR_SALT
549
      expected_id = Zlib.crc32(current_database) * salt
550

551 552 553
      assert lock_id == expected_id, "expected lock id generated by the migrator to be #{expected_id}, but it was #{lock_id} instead"
      assert lock_id.is_a?(Fixnum), "expected lock id to be a Fixnum, but it wasn't"
      assert lock_id.bit_length <= 63, "lock id must be a signed integer of max 63 bits magnitude"
554 555 556 557 558
    end

    def test_migrator_one_up_with_unavailable_lock
      assert_no_column Person, :last_name

559
      migration = Class.new(ActiveRecord::Migration::Current) {
560 561 562 563 564 565 566
        def version; 100 end
        def migrate(x)
          add_column "people", "last_name", :string
        end
      }.new

      migrator = ActiveRecord::Migrator.new(:up, [migration], 100)
567
      lock_id = migrator.send(:generate_migrator_advisory_lock_id)
568

569
      with_another_process_holding_lock(lock_id) do
570 571 572 573 574 575 576 577 578 579
        assert_raise(ActiveRecord::ConcurrentMigrationError) { migrator.migrate }
      end

      assert_no_column Person, :last_name,
        "without an advisory lock, the Migrator should not make any changes, but it did."
    end

    def test_migrator_one_up_with_unavailable_lock_using_run
      assert_no_column Person, :last_name

580
      migration = Class.new(ActiveRecord::Migration::Current) {
581 582 583 584 585 586 587
        def version; 100 end
        def migrate(x)
          add_column "people", "last_name", :string
        end
      }.new

      migrator = ActiveRecord::Migrator.new(:up, [migration], 100)
588
      lock_id = migrator.send(:generate_migrator_advisory_lock_id)
589

590
      with_another_process_holding_lock(lock_id) do
591 592 593 594 595 596 597 598
        assert_raise(ActiveRecord::ConcurrentMigrationError) { migrator.run }
      end

      assert_no_column Person, :last_name,
        "without an advisory lock, the Migrator should not make any changes, but it did."
    end
  end

599
  protected
600 601 602 603 604 605 606 607
    # This is needed to isolate class_attribute assignments like `table_name_prefix`
    # for each test case.
    def new_isolated_reminder_class
      Class.new(Reminder) {
        def self.name; "Reminder"; end
        def self.base_class; self; end
      }
    end
608

609
    def with_another_process_holding_lock(lock_id)
A
Aaron Patterson 已提交
610 611
      thread_lock = Concurrent::CountDownLatch.new
      test_terminated = Concurrent::CountDownLatch.new
612 613 614 615

      other_process = Thread.new do
        begin
          conn = ActiveRecord::Base.connection_pool.checkout
616
          conn.get_advisory_lock(lock_id)
A
Aaron Patterson 已提交
617 618
          thread_lock.count_down
          test_terminated.wait # hold the lock open until we tested everything
619
        ensure
620
          conn.release_advisory_lock(lock_id)
621 622 623 624
          ActiveRecord::Base.connection_pool.checkin(conn)
        end
      end

A
Aaron Patterson 已提交
625
      thread_lock.wait # wait until the 'other process' has the lock
626 627 628

      yield

A
Aaron Patterson 已提交
629
      test_terminated.count_down
630 631
      other_process.join
    end
632
end
633

634 635 636 637 638
class ReservedWordsMigrationTest < ActiveRecord::TestCase
  def test_drop_index_from_table_named_values
    connection = Person.connection
    connection.create_table :values, :force => true do |t|
      t.integer :value
639
    end
640

641 642 643
    assert_nothing_raised do
      connection.add_index :values, :value
      connection.remove_index :values, :column => :value
644
    end
645

646 647 648 649
    connection.drop_table :values rescue nil
  end
end

650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665
class ExplicitlyNamedIndexMigrationTest < ActiveRecord::TestCase
  def test_drop_index_by_name
    connection = Person.connection
    connection.create_table :values, force: true do |t|
      t.integer :value
    end

    assert_nothing_raised ArgumentError do
      connection.add_index :values, :value, name: 'a_different_name'
      connection.remove_index :values, column: :value, name: 'a_different_name'
    end

    connection.drop_table :values rescue nil
  end
end

666 667 668 669 670
if ActiveRecord::Base.connection.supports_bulk_alter?
  class BulkAlterTableMigrationsTest < ActiveRecord::TestCase
    def setup
      @connection = Person.connection
      @connection.create_table(:delete_me, :force => true) {|t| }
A
Akira Matsuda 已提交
671 672
      Person.reset_column_information
      Person.reset_sequence_name
673
    end
674

G
Guo Xiang Tan 已提交
675
    teardown do
676 677
      Person.connection.drop_table(:delete_me) rescue nil
    end
678

679 680
    def test_adding_multiple_columns
      assert_queries(1) do
681
        with_bulk_change_table do |t|
682
          t.column :name, :string
683
          t.string :qualification, :experience
684 685
          t.integer :age, :default => 0
          t.date :birthdate
686
          t.timestamps null: true
687
        end
688
      end
689

690 691
      assert_equal 8, columns.size
      [:name, :qualification, :experience].each {|s| assert_equal :string, column(s).type }
692
      assert_equal '0', column(:age).default
693
    end
694

695 696 697
    def test_removing_columns
      with_bulk_change_table do |t|
        t.string :qualification, :experience
698 699
      end

700
      [:qualification, :experience].each {|c| assert column(c) }
701

702 703 704 705
      assert_queries(1) do
        with_bulk_change_table do |t|
          t.remove :qualification, :experience
          t.string :qualification_experience
706
        end
707
      end
708

709 710 711
      [:qualification, :experience].each {|c| assert ! column(c) }
      assert column(:qualification_experience)
    end
712

713 714 715 716 717
    def test_adding_indexes
      with_bulk_change_table do |t|
        t.string :username
        t.string :name
        t.integer :age
718 719
      end

720 721
      # Adding an index fires a query every time to check if an index already exists or not
      assert_queries(3) do
722
        with_bulk_change_table do |t|
723 724
          t.index :username, :unique => true, :name => :awesome_username_index
          t.index [:name, :age]
725
        end
726
      end
727

728
      assert_equal 2, indexes.size
729

730 731 732
      name_age_index = index(:index_delete_me_on_name_and_age)
      assert_equal ['name', 'age'].sort, name_age_index.columns.sort
      assert ! name_age_index.unique
733

734 735
      assert index(:awesome_username_index).unique
    end
736

737 738 739 740
    def test_removing_index
      with_bulk_change_table do |t|
        t.string :name
        t.index :name
741
      end
742

743 744 745
      assert index(:index_delete_me_on_name)

      assert_queries(3) do
746
        with_bulk_change_table do |t|
747 748
          t.remove_index :name
          t.index :name, :name => :new_name_index, :unique => true
749
        end
750
      end
751

752
      assert ! index(:index_delete_me_on_name)
753

754 755 756
      new_name_index = index(:new_name_index)
      assert new_name_index.unique
    end
757

758 759 760 761
    def test_changing_columns
      with_bulk_change_table do |t|
        t.string :name
        t.date :birthdate
762
      end
763

764 765
      assert ! column(:name).default
      assert_equal :date, column(:birthdate).type
766

767 768 769
      # One query for columns (delete_me table)
      # One query for primary key (delete_me table)
      # One query to do the bulk change
770
      assert_queries(3, :ignore_none => true) do
771 772 773
        with_bulk_change_table do |t|
          t.change :name, :string, :default => 'NONAME'
          t.change :birthdate, :datetime
774
        end
775 776
      end

777 778 779
      assert_equal 'NONAME', column(:name).default
      assert_equal :datetime, column(:birthdate).type
    end
780

781
    protected
782

783 784 785
    def with_bulk_change_table
      # Reset columns/indexes cache as we're changing the table
      @columns = @indexes = nil
786

787 788
      Person.connection.change_table(:delete_me, :bulk => true) do |t|
        yield t
789
      end
790
    end
791

792 793 794
    def column(name)
      columns.detect {|c| c.name == name.to_s }
    end
795

796 797
    def columns
      @columns ||= Person.connection.columns('delete_me')
798 799
    end

800 801
    def index(name)
      indexes.detect {|i| i.name == name.to_s }
802 803
    end

804 805 806 807 808 809 810 811
    def indexes
      @indexes ||= Person.connection.indexes('delete_me')
    end
  end # AlterTableMigrationsTest

end

class CopyMigrationsTest < ActiveRecord::TestCase
812 813
  include ActiveSupport::Testing::Stream

814 815 816 817 818 819 820 821 822 823 824 825 826 827 828
  def setup
  end

  def clear
    ActiveRecord::Base.timestamped_migrations = true
    to_delete = Dir[@migrations_path + "/*.rb"] - @existing_migrations
    File.delete(*to_delete)
  end

  def test_copying_migrations_without_timestamps
    ActiveRecord::Base.timestamped_migrations = false
    @migrations_path = MIGRATIONS_ROOT + "/valid"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]

    copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy"})
A
Arun Agrawal 已提交
829 830
    assert File.exist?(@migrations_path + "/4_people_have_hobbies.bukkits.rb")
    assert File.exist?(@migrations_path + "/5_people_have_descriptions.bukkits.rb")
831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848
    assert_equal [@migrations_path + "/4_people_have_hobbies.bukkits.rb", @migrations_path + "/5_people_have_descriptions.bukkits.rb"], copied.map(&:filename)

    expected = "# This migration comes from bukkits (originally 1)"
    assert_equal expected, IO.readlines(@migrations_path + "/4_people_have_hobbies.bukkits.rb")[0].chomp

    files_count = Dir[@migrations_path + "/*.rb"].length
    copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy"})
    assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
    assert copied.empty?
  ensure
    clear
  end

  def test_copying_migrations_without_timestamps_from_2_sources
    ActiveRecord::Base.timestamped_migrations = false
    @migrations_path = MIGRATIONS_ROOT + "/valid"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]

849
    sources = {}
850 851 852
    sources[:bukkits] = MIGRATIONS_ROOT + "/to_copy"
    sources[:omg] = MIGRATIONS_ROOT + "/to_copy2"
    ActiveRecord::Migration.copy(@migrations_path, sources)
A
Arun Agrawal 已提交
853 854 855 856
    assert File.exist?(@migrations_path + "/4_people_have_hobbies.bukkits.rb")
    assert File.exist?(@migrations_path + "/5_people_have_descriptions.bukkits.rb")
    assert File.exist?(@migrations_path + "/6_create_articles.omg.rb")
    assert File.exist?(@migrations_path + "/7_create_comments.omg.rb")
857 858 859 860 861 862 863

    files_count = Dir[@migrations_path + "/*.rb"].length
    ActiveRecord::Migration.copy(@migrations_path, sources)
    assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
  ensure
    clear
  end
864

865 866 867
  def test_copying_migrations_with_timestamps
    @migrations_path = MIGRATIONS_ROOT + "/valid_with_timestamps"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]
868

869
    travel_to(Time.utc(2010, 7, 26, 10, 10, 10)) do
870
      copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
A
Arun Agrawal 已提交
871 872
      assert File.exist?(@migrations_path + "/20100726101010_people_have_hobbies.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100726101011_people_have_descriptions.bukkits.rb")
873 874 875
      expected = [@migrations_path + "/20100726101010_people_have_hobbies.bukkits.rb",
                  @migrations_path + "/20100726101011_people_have_descriptions.bukkits.rb"]
      assert_equal expected, copied.map(&:filename)
876

877
      files_count = Dir[@migrations_path + "/*.rb"].length
878
      copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
879 880 881
      assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
      assert copied.empty?
    end
882 883 884
  ensure
    clear
  end
885

886 887 888
  def test_copying_migrations_with_timestamps_from_2_sources
    @migrations_path = MIGRATIONS_ROOT + "/valid_with_timestamps"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]
889

890
    sources = {}
891 892 893
    sources[:bukkits] = MIGRATIONS_ROOT + "/to_copy_with_timestamps"
    sources[:omg]     = MIGRATIONS_ROOT + "/to_copy_with_timestamps2"

894
    travel_to(Time.utc(2010, 7, 26, 10, 10, 10)) do
895
      copied = ActiveRecord::Migration.copy(@migrations_path, sources)
A
Arun Agrawal 已提交
896 897 898 899
      assert File.exist?(@migrations_path + "/20100726101010_people_have_hobbies.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100726101011_people_have_descriptions.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100726101012_create_articles.omg.rb")
      assert File.exist?(@migrations_path + "/20100726101013_create_comments.omg.rb")
900
      assert_equal 4, copied.length
901 902 903 904 905

      files_count = Dir[@migrations_path + "/*.rb"].length
      ActiveRecord::Migration.copy(@migrations_path, sources)
      assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
    end
906 907 908
  ensure
    clear
  end
909

910 911 912
  def test_copying_migrations_with_timestamps_to_destination_with_timestamps_in_future
    @migrations_path = MIGRATIONS_ROOT + "/valid_with_timestamps"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]
913

914
    travel_to(Time.utc(2010, 2, 20, 10, 10, 10)) do
915
      ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
A
Arun Agrawal 已提交
916 917
      assert File.exist?(@migrations_path + "/20100301010102_people_have_hobbies.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100301010103_people_have_descriptions.bukkits.rb")
918

919 920 921 922
      files_count = Dir[@migrations_path + "/*.rb"].length
      copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
      assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
      assert copied.empty?
923
    end
924 925 926
  ensure
    clear
  end
927

928 929 930 931 932 933
  def test_copying_migrations_preserving_magic_comments
    ActiveRecord::Base.timestamped_migrations = false
    @migrations_path = MIGRATIONS_ROOT + "/valid"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]

    copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/magic"})
A
Arun Agrawal 已提交
934
    assert File.exist?(@migrations_path + "/4_currencies_have_symbols.bukkits.rb")
935 936 937 938 939 940 941 942 943 944 945 946 947
    assert_equal [@migrations_path + "/4_currencies_have_symbols.bukkits.rb"], copied.map(&:filename)

    expected = "# coding: ISO-8859-15\n# This migration comes from bukkits (originally 1)"
    assert_equal expected, IO.readlines(@migrations_path + "/4_currencies_have_symbols.bukkits.rb")[0..1].join.chomp

    files_count = Dir[@migrations_path + "/*.rb"].length
    copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/magic"})
    assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
    assert copied.empty?
  ensure
    clear
  end

948 949 950
  def test_skipping_migrations
    @migrations_path = MIGRATIONS_ROOT + "/valid_with_timestamps"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]
951 952

    sources = {}
953 954
    sources[:bukkits] = MIGRATIONS_ROOT + "/to_copy_with_timestamps"
    sources[:omg]     = MIGRATIONS_ROOT + "/to_copy_with_name_collision"
955

956 957 958 959
    skipped = []
    on_skip = Proc.new { |name, migration| skipped << "#{name} #{migration.name}" }
    copied = ActiveRecord::Migration.copy(@migrations_path, sources, :on_skip => on_skip)
    assert_equal 2, copied.length
960

961 962 963 964 965
    assert_equal 1, skipped.length
    assert_equal ["omg PeopleHaveHobbies"], skipped
  ensure
    clear
  end
966

967 968 969
  def test_skip_is_not_called_if_migrations_are_from_the_same_plugin
    @migrations_path = MIGRATIONS_ROOT + "/valid_with_timestamps"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]
970

971
    sources = {}
972
    sources[:bukkits] = MIGRATIONS_ROOT + "/to_copy_with_timestamps"
973

974 975 976 977
    skipped = []
    on_skip = Proc.new { |name, migration| skipped << "#{name} #{migration.name}" }
    copied = ActiveRecord::Migration.copy(@migrations_path, sources, :on_skip => on_skip)
    ActiveRecord::Migration.copy(@migrations_path, sources, :on_skip => on_skip)
978

979 980 981 982 983
    assert_equal 2, copied.length
    assert_equal 0, skipped.length
  ensure
    clear
  end
984

985 986 987
  def test_copying_migrations_to_non_existing_directory
    @migrations_path = MIGRATIONS_ROOT + "/non_existing"
    @existing_migrations = []
988

989
    travel_to(Time.utc(2010, 7, 26, 10, 10, 10)) do
990
      copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
A
Arun Agrawal 已提交
991 992
      assert File.exist?(@migrations_path + "/20100726101010_people_have_hobbies.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100726101011_people_have_descriptions.bukkits.rb")
993 994
      assert_equal 2, copied.length
    end
995 996 997 998
  ensure
    clear
    Dir.delete(@migrations_path)
  end
999

1000 1001 1002
  def test_copying_migrations_to_empty_directory
    @migrations_path = MIGRATIONS_ROOT + "/empty"
    @existing_migrations = []
1003

1004
    travel_to(Time.utc(2010, 7, 26, 10, 10, 10)) do
1005
      copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
A
Arun Agrawal 已提交
1006 1007
      assert File.exist?(@migrations_path + "/20100726101010_people_have_hobbies.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100726101011_people_have_descriptions.bukkits.rb")
1008
      assert_equal 2, copied.length
1009
    end
1010 1011
  ensure
    clear
1012
  end
1013 1014 1015 1016 1017 1018 1019 1020 1021

  def test_check_pending_with_stdlib_logger
    old, ActiveRecord::Base.logger = ActiveRecord::Base.logger, ::Logger.new($stdout)
    quietly do
      assert_nothing_raised { ActiveRecord::Migration::CheckPending.new(Proc.new {}).call({}) }
    end
  ensure
    ActiveRecord::Base.logger = old
  end
1022

1023
end