migration_test.rb 35.4 KB
Newer Older
1
require "cases/helper"
2
require "cases/migration/helper"
3 4
require 'bigdecimal/util'

J
Jeremy Kemper 已提交
5 6
require 'models/person'
require 'models/topic'
7
require 'models/developer'
A
Arun Agrawal 已提交
8
require 'models/computer'
9 10

require MIGRATIONS_ROOT + "/valid/2_we_need_reminders"
11 12
require MIGRATIONS_ROOT + "/rename/1_we_need_things"
require MIGRATIONS_ROOT + "/rename/2_rename_things"
13
require MIGRATIONS_ROOT + "/decimal/1_give_me_big_numbers"
14

15
class BigNumber < ActiveRecord::Base
16
  unless current_adapter?(:PostgreSQLAdapter, :SQLite3Adapter)
17
    attribute :value_of_e, :integer
18
  end
19
  attribute :my_house_population, :integer
20
end
21

22
class Reminder < ActiveRecord::Base; end
23

24
class Thing < ActiveRecord::Base; end
25

26
class MigrationTest < ActiveRecord::TestCase
27
  self.use_transactional_tests = false
28

29
  fixtures :people
30

31 32
  def setup
    super
A
Akira Matsuda 已提交
33
    %w(reminders people_reminders prefix_reminders_suffix p_things_s).each do |table|
A
Aaron Patterson 已提交
34 35 36
      Reminder.connection.drop_table(table) rescue nil
    end
    Reminder.reset_column_information
37
    @verbose_was, ActiveRecord::Migration.verbose = ActiveRecord::Migration.verbose, false
A
Akira Matsuda 已提交
38
    ActiveRecord::Base.connection.schema_cache.clear!
39
  end
40

G
Guo Xiang Tan 已提交
41
  teardown do
42 43 44
    ActiveRecord::Base.table_name_prefix = ""
    ActiveRecord::Base.table_name_suffix = ""

45 46
    ActiveRecord::Base.connection.initialize_schema_migrations_table
    ActiveRecord::Base.connection.execute "DELETE FROM #{ActiveRecord::Migrator.schema_migrations_table_name}"
47

48
    %w(things awesome_things prefix_things_suffix p_awesome_things_s ).each do |table|
49
      Thing.connection.drop_table(table) rescue nil
50
    end
51
    Thing.reset_column_information
52

53 54 55
    %w(reminders people_reminders prefix_reminders_suffix).each do |table|
      Reminder.connection.drop_table(table) rescue nil
    end
56
    Reminder.reset_table_name
57
    Reminder.reset_column_information
58

59 60 61 62 63 64
    %w(last_name key bio age height wealth birthday favorite_day
       moment_of_truth male administrator funny).each do |column|
      Person.connection.remove_column('people', column) rescue nil
    end
    Person.connection.remove_column("people", "first_name") rescue nil
    Person.connection.remove_column("people", "middle_name") rescue nil
65
    Person.connection.add_column("people", "first_name", :string)
66
    Person.reset_column_information
67 68

    ActiveRecord::Migration.verbose = @verbose_was
69
  end
70

71 72
  def test_migrator_versions
    migrations_path = MIGRATIONS_ROOT + "/valid"
73
    old_path = ActiveRecord::Migrator.migrations_paths
74 75 76 77
    ActiveRecord::Migrator.migrations_paths = migrations_path

    ActiveRecord::Migrator.up(migrations_path)
    assert_equal 3, ActiveRecord::Migrator.current_version
78
    assert_equal false, ActiveRecord::Migrator.needs_migration?
79 80 81

    ActiveRecord::Migrator.down(MIGRATIONS_ROOT + "/valid")
    assert_equal 0, ActiveRecord::Migrator.current_version
82
    assert_equal true, ActiveRecord::Migrator.needs_migration?
83

Y
Yves Senn 已提交
84
    ActiveRecord::SchemaMigration.create!(version: 3)
85 86 87 88 89 90
    assert_equal true, ActiveRecord::Migrator.needs_migration?
  ensure
    ActiveRecord::Migrator.migrations_paths = old_path
  end

  def test_migration_detection_without_schema_migration_table
91
    ActiveRecord::Base.connection.drop_table 'schema_migrations', if_exists: true
92 93 94 95 96 97

    migrations_path = MIGRATIONS_ROOT + "/valid"
    old_path = ActiveRecord::Migrator.migrations_paths
    ActiveRecord::Migrator.migrations_paths = migrations_path

    assert_equal true, ActiveRecord::Migrator.needs_migration?
98 99
  ensure
    ActiveRecord::Migrator.migrations_paths = old_path
100 101
  end

102 103 104 105 106 107 108 109 110 111 112 113 114
  def test_any_migrations
    old_path = ActiveRecord::Migrator.migrations_paths
    ActiveRecord::Migrator.migrations_paths = MIGRATIONS_ROOT + "/valid"

    assert ActiveRecord::Migrator.any_migrations?

    ActiveRecord::Migrator.migrations_paths = MIGRATIONS_ROOT + "/empty"

    assert_not ActiveRecord::Migrator.any_migrations?
  ensure
    ActiveRecord::Migrator.migrations_paths = old_path
  end

115
  def test_migration_version
116
    assert_nothing_raised { ActiveRecord::Migrator.run(:up, MIGRATIONS_ROOT + "/version_check", 20131219224947) }
117 118
  end

119 120 121 122
  def test_create_table_with_force_true_does_not_drop_nonexisting_table
    # using a copy as we need the drop_table method to
    # continue to work for the ensure block of the test
    temp_conn = Person.connection.dup
123 124 125

    assert_not_equal temp_conn, Person.connection

126 127
    temp_conn.create_table :testings2, :force => true do |t|
      t.column :foo, :string
128
    end
129
  ensure
130
    Person.connection.drop_table :testings2, if_exists: true
131
  end
132

133 134
  def test_migration_instance_has_connection
    migration = Class.new(ActiveRecord::Migration).new
135
    assert_equal ActiveRecord::Base.connection, migration.connection
136
  end
137

138 139 140 141 142 143 144 145
  def test_method_missing_delegates_to_connection
    migration = Class.new(ActiveRecord::Migration) {
      def connection
        Class.new {
          def create_table; "hi mom!"; end
        }.new
      end
    }.new
146

147
    assert_equal "hi mom!", migration.method_missing(:create_table)
148
  end
149

150 151 152 153 154
  def test_add_table_with_decimals
    Person.connection.drop_table :big_numbers rescue nil

    assert !BigNumber.table_exists?
    GiveMeBigNumbers.up
155
    BigNumber.reset_column_information
156 157 158 159 160 161 162 163 164

    assert BigNumber.create(
      :bank_balance => 1586.43,
      :big_bank_balance => BigDecimal("1000234000567.95"),
      :world_population => 6000000000,
      :my_house_population => 3,
      :value_of_e => BigDecimal("2.7182818284590452353602875")
    )

165
    b = BigNumber.first
166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208
    assert_not_nil b

    assert_not_nil b.bank_balance
    assert_not_nil b.big_bank_balance
    assert_not_nil b.world_population
    assert_not_nil b.my_house_population
    assert_not_nil b.value_of_e

    # TODO: set world_population >= 2**62 to cover 64-bit platforms and test
    # is_a?(Bignum)
    assert_kind_of Integer, b.world_population
    assert_equal 6000000000, b.world_population
    assert_kind_of Fixnum, b.my_house_population
    assert_equal 3, b.my_house_population
    assert_kind_of BigDecimal, b.bank_balance
    assert_equal BigDecimal("1586.43"), b.bank_balance
    assert_kind_of BigDecimal, b.big_bank_balance
    assert_equal BigDecimal("1000234000567.95"), b.big_bank_balance

    # This one is fun. The 'value_of_e' field is defined as 'DECIMAL' with
    # precision/scale explicitly left out.  By the SQL standard, numbers
    # assigned to this field should be truncated but that's seldom respected.
    if current_adapter?(:PostgreSQLAdapter)
      # - PostgreSQL changes the SQL spec on columns declared simply as
      # "decimal" to something more useful: instead of being given a scale
      # of 0, they take on the compile-time limit for precision and scale,
      # so the following should succeed unless you have used really wacky
      # compilation options
      # - SQLite2 has the default behavior of preserving all data sent in,
      # so this happens there too
      assert_kind_of BigDecimal, b.value_of_e
      assert_equal BigDecimal("2.7182818284590452353602875"), b.value_of_e
    elsif current_adapter?(:SQLite3Adapter)
      # - SQLite3 stores a float, in violation of SQL
      assert_kind_of BigDecimal, b.value_of_e
      assert_in_delta BigDecimal("2.71828182845905"), b.value_of_e, 0.00000000000001
    else
      # - SQL standard is an integer
      assert_kind_of Fixnum, b.value_of_e
      assert_equal 2, b.value_of_e
    end

    GiveMeBigNumbers.down
209
    assert_raise(ActiveRecord::StatementInvalid) { BigNumber.first }
210
  end
211

212
  def test_filtering_migrations
213
    assert_no_column Person, :last_name
214
    assert !Reminder.table_exists?
215

216 217
    name_filter = lambda { |migration| migration.name == "ValidPeopleHaveLastNames" }
    ActiveRecord::Migrator.up(MIGRATIONS_ROOT + "/valid", &name_filter)
218

219
    assert_column Person, :last_name
220
    assert_raise(ActiveRecord::StatementInvalid) { Reminder.first }
221

222 223
    ActiveRecord::Migrator.down(MIGRATIONS_ROOT + "/valid", &name_filter)

224
    assert_no_column Person, :last_name
225
    assert_raise(ActiveRecord::StatementInvalid) { Reminder.first }
226 227 228 229 230 231 232
  end

  class MockMigration < ActiveRecord::Migration
    attr_reader :went_up, :went_down
    def initialize
      @went_up   = false
      @went_down = false
233 234
    end

235 236 237 238
    def up
      @went_up = true
      super
    end
239

240 241 242
    def down
      @went_down = true
      super
243
    end
244
  end
245

246 247 248 249
  def test_instance_based_migration_up
    migration = MockMigration.new
    assert !migration.went_up, 'have not gone up'
    assert !migration.went_down, 'have not gone down'
250

251 252 253 254
    migration.migrate :up
    assert migration.went_up, 'have gone up'
    assert !migration.went_down, 'have not gone down'
  end
255

256 257 258 259
  def test_instance_based_migration_down
    migration = MockMigration.new
    assert !migration.went_up, 'have not gone up'
    assert !migration.went_down, 'have not gone down'
260

261 262 263 264
    migration.migrate :down
    assert !migration.went_up, 'have gone up'
    assert migration.went_down, 'have not gone down'
  end
265

266 267 268 269 270 271 272 273 274 275 276
  if ActiveRecord::Base.connection.supports_ddl_transactions?
    def test_migrator_one_up_with_exception_and_rollback
      assert_no_column Person, :last_name

      migration = Class.new(ActiveRecord::Migration) {
        def version; 100 end
        def migrate(x)
          add_column "people", "last_name", :string
          raise 'Something broke'
        end
      }.new
277

278
      migrator = ActiveRecord::Migrator.new(:up, [migration], 100)
279

280
      e = assert_raise(StandardError) { migrator.migrate }
281

282
      assert_equal "An error has occurred, this and all later migrations canceled:\n\nSomething broke", e.message
283

284 285
      assert_no_column Person, :last_name,
        "On error, the Migrator should revert schema changes but it did not."
B
bondarev 已提交
286 287
    end

288 289
    def test_migrator_one_up_with_exception_and_rollback_using_run
      assert_no_column Person, :last_name
B
bondarev 已提交
290

291 292 293 294 295 296 297
      migration = Class.new(ActiveRecord::Migration) {
        def version; 100 end
        def migrate(x)
          add_column "people", "last_name", :string
          raise 'Something broke'
        end
      }.new
B
bondarev 已提交
298

299
      migrator = ActiveRecord::Migrator.new(:up, [migration], 100)
B
bondarev 已提交
300

301
      e = assert_raise(StandardError) { migrator.run }
B
bondarev 已提交
302

303
      assert_equal "An error has occurred, this migration was canceled:\n\nSomething broke", e.message
B
bondarev 已提交
304

305 306
      assert_no_column Person, :last_name,
        "On error, the Migrator should revert schema changes but it did not."
307 308
    end

309 310
    def test_migration_without_transaction
      assert_no_column Person, :last_name
311

312 313
      migration = Class.new(ActiveRecord::Migration) {
        self.disable_ddl_transaction!
314

315 316 317 318 319 320
        def version; 101 end
        def migrate(x)
          add_column "people", "last_name", :string
          raise 'Something broke'
        end
      }.new
321

322 323 324
      migrator = ActiveRecord::Migrator.new(:up, [migration], 101)
      e = assert_raise(StandardError) { migrator.migrate }
      assert_equal "An error has occurred, all later migrations canceled:\n\nSomething broke", e.message
325

326 327 328 329 330 331 332
      assert_column Person, :last_name,
        "without ddl transactions, the Migrator should not rollback on error but it did."
    ensure
      Person.reset_column_information
      if Person.column_names.include?('last_name')
        Person.connection.remove_column('people', 'last_name')
      end
333
    end
334
  end
335

336
  def test_schema_migrations_table_name
337 338 339
    original_schema_migrations_table_name = ActiveRecord::Migrator.schema_migrations_table_name

    assert_equal "schema_migrations", ActiveRecord::Migrator.schema_migrations_table_name
340 341 342 343
    ActiveRecord::Base.table_name_prefix = "prefix_"
    ActiveRecord::Base.table_name_suffix = "_suffix"
    Reminder.reset_table_name
    assert_equal "prefix_schema_migrations_suffix", ActiveRecord::Migrator.schema_migrations_table_name
344 345 346
    ActiveRecord::Base.schema_migrations_table_name = "changed"
    Reminder.reset_table_name
    assert_equal "prefix_changed_suffix", ActiveRecord::Migrator.schema_migrations_table_name
347 348 349
    ActiveRecord::Base.table_name_prefix = ""
    ActiveRecord::Base.table_name_suffix = ""
    Reminder.reset_table_name
350 351 352 353
    assert_equal "changed", ActiveRecord::Migrator.schema_migrations_table_name
  ensure
    ActiveRecord::Base.schema_migrations_table_name = original_schema_migrations_table_name
    Reminder.reset_table_name
354 355
  end

356
  def test_proper_table_name_on_migration
357
    reminder_class = new_isolated_reminder_class
358 359 360
    migration = ActiveRecord::Migration.new
    assert_equal "table", migration.proper_table_name('table')
    assert_equal "table", migration.proper_table_name(:table)
361 362 363
    assert_equal "reminders", migration.proper_table_name(reminder_class)
    reminder_class.reset_table_name
    assert_equal reminder_class.table_name, migration.proper_table_name(reminder_class)
364 365 366 367

    # Use the model's own prefix/suffix if a model is given
    ActiveRecord::Base.table_name_prefix = "ARprefix_"
    ActiveRecord::Base.table_name_suffix = "_ARsuffix"
368 369 370 371 372 373 374
    reminder_class.table_name_prefix = 'prefix_'
    reminder_class.table_name_suffix = '_suffix'
    reminder_class.reset_table_name
    assert_equal "prefix_reminders_suffix", migration.proper_table_name(reminder_class)
    reminder_class.table_name_prefix = ''
    reminder_class.table_name_suffix = ''
    reminder_class.reset_table_name
375 376 377 378

    # Use AR::Base's prefix/suffix if string or symbol is given
    ActiveRecord::Base.table_name_prefix = "prefix_"
    ActiveRecord::Base.table_name_suffix = "_suffix"
379
    reminder_class.reset_table_name
380 381 382 383
    assert_equal "prefix_table_suffix", migration.proper_table_name('table', migration.table_name_options)
    assert_equal "prefix_table_suffix", migration.proper_table_name(:table, migration.table_name_options)
  end

384 385
  def test_rename_table_with_prefix_and_suffix
    assert !Thing.table_exists?
386 387
    ActiveRecord::Base.table_name_prefix = 'p_'
    ActiveRecord::Base.table_name_suffix = '_s'
388 389 390
    Thing.reset_table_name
    Thing.reset_sequence_name
    WeNeedThings.up
391
    Thing.reset_column_information
392 393

    assert Thing.create("content" => "hello world")
394
    assert_equal "hello world", Thing.first.content
395 396

    RenameThings.up
397
    Thing.table_name = "p_awesome_things_s"
398

399
    assert_equal "hello world", Thing.first.content
400 401 402 403 404 405 406 407 408 409 410
  ensure
    Thing.reset_table_name
    Thing.reset_sequence_name
  end

  def test_add_drop_table_with_prefix_and_suffix
    assert !Reminder.table_exists?
    ActiveRecord::Base.table_name_prefix = 'prefix_'
    ActiveRecord::Base.table_name_suffix = '_suffix'
    Reminder.reset_table_name
    Reminder.reset_sequence_name
411
    Reminder.reset_column_information
412 413
    WeNeedReminders.up
    assert Reminder.create("content" => "hello world", "remind_at" => Time.now)
414
    assert_equal "hello world", Reminder.first.content
415 416

    WeNeedReminders.down
417
    assert_raise(ActiveRecord::StatementInvalid) { Reminder.first }
418 419 420
  ensure
    Reminder.reset_sequence_name
  end
421

422 423 424
  def test_create_table_with_binary_column
    assert_nothing_raised {
      Person.connection.create_table :binary_testings do |t|
425
        t.column "data", :binary, :null => false
426
      end
427 428 429 430
    }

    columns = Person.connection.columns(:binary_testings)
    data_column = columns.detect { |c| c.name == "data" }
431

J
Jon Leighton 已提交
432
    assert_nil data_column.default
433

434
    Person.connection.drop_table :binary_testings, if_exists: true
435 436
  end

437 438 439 440
  unless mysql_enforcing_gtid_consistency?
    def test_create_table_with_query
      Person.connection.drop_table :table_from_query_testings rescue nil
      Person.connection.create_table(:person, force: true)
441

442
      Person.connection.create_table :table_from_query_testings, as: "SELECT id FROM person"
443

444 445 446
      columns = Person.connection.columns(:table_from_query_testings)
      assert_equal 1, columns.length
      assert_equal "id", columns.first.name
447

448 449
      Person.connection.drop_table :table_from_query_testings rescue nil
    end
450

451 452 453
    def test_create_table_with_query_from_relation
      Person.connection.drop_table :table_from_query_testings rescue nil
      Person.connection.create_table(:person, force: true)
454

455
      Person.connection.create_table :table_from_query_testings, as: Person.select(:id)
456

457 458 459
      columns = Person.connection.columns(:table_from_query_testings)
      assert_equal 1, columns.length
      assert_equal "id", columns.first.name
460

461 462
      Person.connection.drop_table :table_from_query_testings rescue nil
    end
463 464
  end

465 466 467 468 469 470 471 472 473 474 475
  if current_adapter? :OracleAdapter
    def test_create_table_with_custom_sequence_name
      # table name is 29 chars, the standard sequence name will
      # be 33 chars and should be shortened
      assert_nothing_raised do
        begin
          Person.connection.create_table :table_with_name_thats_just_ok do |t|
            t.column :foo, :string, :null => false
          end
        ensure
          Person.connection.drop_table :table_with_name_thats_just_ok rescue nil
476 477 478
        end
      end

479 480 481 482 483 484 485
      # should be all good w/ a custom sequence name
      assert_nothing_raised do
        begin
          Person.connection.create_table :table_with_name_thats_just_ok,
            :sequence_name => 'suitably_short_seq' do |t|
            t.column :foo, :string, :null => false
          end
486

487
          Person.connection.execute("select suitably_short_seq.nextval from dual")
488

489 490 491 492
        ensure
          Person.connection.drop_table :table_with_name_thats_just_ok,
            :sequence_name => 'suitably_short_seq' rescue nil
        end
493 494
      end

495 496 497 498
      # confirm the custom sequence got dropped
      assert_raise(ActiveRecord::StatementInvalid) do
        Person.connection.execute("select suitably_short_seq.nextval from dual")
      end
499
    end
500
  end
501

502 503 504
  if current_adapter?(:MysqlAdapter, :Mysql2Adapter, :PostgreSQLAdapter)
    def test_out_of_range_limit_should_raise
      Person.connection.drop_table :test_limits rescue nil
F
Franky W 已提交
505
      e = assert_raise(ActiveRecord::ActiveRecordError, "integer limit didn't raise") do
506 507 508
        Person.connection.create_table :test_integer_limits, :force => true do |t|
          t.column :bigone, :integer, :limit => 10
        end
509 510
      end

F
Franky W 已提交
511 512
      assert_match(/No integer type has byte size 10/, e.message)

513 514 515 516 517
      unless current_adapter?(:PostgreSQLAdapter)
        assert_raise(ActiveRecord::ActiveRecordError, "text limit didn't raise") do
          Person.connection.create_table :test_text_limits, :force => true do |t|
            t.column :bigtext, :text, :limit => 0xfffffffff
          end
518 519 520
        end
      end

521 522
      Person.connection.drop_table :test_limits rescue nil
    end
523 524
  end

525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597
  if ActiveRecord::Base.connection.supports_advisory_locks?
    def test_migrator_generates_valid_lock_key
      migration = Class.new(ActiveRecord::Migration).new
      migrator = ActiveRecord::Migrator.new(:up, [migration], 100)

      lock_key = migrator.send(:generate_migrator_advisory_lock_key)

      assert ActiveRecord::Base.connection.get_advisory_lock(lock_key),
        "the Migrator should have generated a valid lock key, but it didn't"
      assert ActiveRecord::Base.connection.release_advisory_lock(lock_key),
        "the Migrator should have generated a valid lock key, but it didn't"
    end

    def test_generate_migrator_advisory_lock_key
      # It is important we are consistent with how we generate this so that
      # exclusive locking works across migrator versions
      migration = Class.new(ActiveRecord::Migration).new
      migrator = ActiveRecord::Migrator.new(:up, [migration], 100)

      lock_key = migrator.send(:generate_migrator_advisory_lock_key)

      current_database = ActiveRecord::Base.connection.current_database
      salt = ActiveRecord::Migrator::MIGRATOR_SALT
      expected_key = Zlib.crc32(current_database) * salt

      assert lock_key == expected_key, "expected lock key generated by the migrator to be #{expected_key}, but it was #{lock_key} instead"
      assert lock_key.is_a?(Fixnum), "expected lock key to be a Fixnum, but it wasn't"
      assert lock_key.bit_length <= 63, "lock key must be a signed integer of max 63 bits magnitude"
    end

    def test_migrator_one_up_with_unavailable_lock
      assert_no_column Person, :last_name

      migration = Class.new(ActiveRecord::Migration) {
        def version; 100 end
        def migrate(x)
          add_column "people", "last_name", :string
        end
      }.new

      migrator = ActiveRecord::Migrator.new(:up, [migration], 100)
      lock_key = migrator.send(:generate_migrator_advisory_lock_key)

      with_another_process_holding_lock(lock_key) do
        assert_raise(ActiveRecord::ConcurrentMigrationError) { migrator.migrate }
      end

      assert_no_column Person, :last_name,
        "without an advisory lock, the Migrator should not make any changes, but it did."
    end

    def test_migrator_one_up_with_unavailable_lock_using_run
      assert_no_column Person, :last_name

      migration = Class.new(ActiveRecord::Migration) {
        def version; 100 end
        def migrate(x)
          add_column "people", "last_name", :string
        end
      }.new

      migrator = ActiveRecord::Migrator.new(:up, [migration], 100)
      lock_key = migrator.send(:generate_migrator_advisory_lock_key)

      with_another_process_holding_lock(lock_key) do
        assert_raise(ActiveRecord::ConcurrentMigrationError) { migrator.run }
      end

      assert_no_column Person, :last_name,
        "without an advisory lock, the Migrator should not make any changes, but it did."
    end
  end

598
  protected
599 600 601 602 603 604 605 606
    # This is needed to isolate class_attribute assignments like `table_name_prefix`
    # for each test case.
    def new_isolated_reminder_class
      Class.new(Reminder) {
        def self.name; "Reminder"; end
        def self.base_class; self; end
      }
    end
607 608

    def with_another_process_holding_lock(lock_key)
A
Aaron Patterson 已提交
609 610
      thread_lock = Concurrent::CountDownLatch.new
      test_terminated = Concurrent::CountDownLatch.new
611 612 613 614 615

      other_process = Thread.new do
        begin
          conn = ActiveRecord::Base.connection_pool.checkout
          conn.get_advisory_lock(lock_key)
A
Aaron Patterson 已提交
616 617
          thread_lock.count_down
          test_terminated.wait # hold the lock open until we tested everything
618 619 620 621 622 623
        ensure
          conn.release_advisory_lock(lock_key)
          ActiveRecord::Base.connection_pool.checkin(conn)
        end
      end

A
Aaron Patterson 已提交
624
      thread_lock.wait # wait until the 'other process' has the lock
625 626 627

      yield

A
Aaron Patterson 已提交
628
      test_terminated.count_down
629 630
      other_process.join
    end
631
end
632

633 634 635 636 637
class ReservedWordsMigrationTest < ActiveRecord::TestCase
  def test_drop_index_from_table_named_values
    connection = Person.connection
    connection.create_table :values, :force => true do |t|
      t.integer :value
638
    end
639

640 641 642
    assert_nothing_raised do
      connection.add_index :values, :value
      connection.remove_index :values, :column => :value
643
    end
644

645 646 647 648
    connection.drop_table :values rescue nil
  end
end

649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664
class ExplicitlyNamedIndexMigrationTest < ActiveRecord::TestCase
  def test_drop_index_by_name
    connection = Person.connection
    connection.create_table :values, force: true do |t|
      t.integer :value
    end

    assert_nothing_raised ArgumentError do
      connection.add_index :values, :value, name: 'a_different_name'
      connection.remove_index :values, column: :value, name: 'a_different_name'
    end

    connection.drop_table :values rescue nil
  end
end

665 666 667 668 669
if ActiveRecord::Base.connection.supports_bulk_alter?
  class BulkAlterTableMigrationsTest < ActiveRecord::TestCase
    def setup
      @connection = Person.connection
      @connection.create_table(:delete_me, :force => true) {|t| }
A
Akira Matsuda 已提交
670 671
      Person.reset_column_information
      Person.reset_sequence_name
672
    end
673

G
Guo Xiang Tan 已提交
674
    teardown do
675 676
      Person.connection.drop_table(:delete_me) rescue nil
    end
677

678 679
    def test_adding_multiple_columns
      assert_queries(1) do
680
        with_bulk_change_table do |t|
681
          t.column :name, :string
682
          t.string :qualification, :experience
683 684
          t.integer :age, :default => 0
          t.date :birthdate
685
          t.timestamps null: true
686
        end
687
      end
688

689 690
      assert_equal 8, columns.size
      [:name, :qualification, :experience].each {|s| assert_equal :string, column(s).type }
691
      assert_equal '0', column(:age).default
692
    end
693

694 695 696
    def test_removing_columns
      with_bulk_change_table do |t|
        t.string :qualification, :experience
697 698
      end

699
      [:qualification, :experience].each {|c| assert column(c) }
700

701 702 703 704
      assert_queries(1) do
        with_bulk_change_table do |t|
          t.remove :qualification, :experience
          t.string :qualification_experience
705
        end
706
      end
707

708 709 710
      [:qualification, :experience].each {|c| assert ! column(c) }
      assert column(:qualification_experience)
    end
711

712 713 714 715 716
    def test_adding_indexes
      with_bulk_change_table do |t|
        t.string :username
        t.string :name
        t.integer :age
717 718
      end

719 720
      # Adding an index fires a query every time to check if an index already exists or not
      assert_queries(3) do
721
        with_bulk_change_table do |t|
722 723
          t.index :username, :unique => true, :name => :awesome_username_index
          t.index [:name, :age]
724
        end
725
      end
726

727
      assert_equal 2, indexes.size
728

729 730 731
      name_age_index = index(:index_delete_me_on_name_and_age)
      assert_equal ['name', 'age'].sort, name_age_index.columns.sort
      assert ! name_age_index.unique
732

733 734
      assert index(:awesome_username_index).unique
    end
735

736 737 738 739
    def test_removing_index
      with_bulk_change_table do |t|
        t.string :name
        t.index :name
740
      end
741

742 743 744
      assert index(:index_delete_me_on_name)

      assert_queries(3) do
745
        with_bulk_change_table do |t|
746 747
          t.remove_index :name
          t.index :name, :name => :new_name_index, :unique => true
748
        end
749
      end
750

751
      assert ! index(:index_delete_me_on_name)
752

753 754 755
      new_name_index = index(:new_name_index)
      assert new_name_index.unique
    end
756

757 758 759 760
    def test_changing_columns
      with_bulk_change_table do |t|
        t.string :name
        t.date :birthdate
761
      end
762

763 764
      assert ! column(:name).default
      assert_equal :date, column(:birthdate).type
765

766 767 768
      # One query for columns (delete_me table)
      # One query for primary key (delete_me table)
      # One query to do the bulk change
769
      assert_queries(3, :ignore_none => true) do
770 771 772
        with_bulk_change_table do |t|
          t.change :name, :string, :default => 'NONAME'
          t.change :birthdate, :datetime
773
        end
774 775
      end

776 777 778
      assert_equal 'NONAME', column(:name).default
      assert_equal :datetime, column(:birthdate).type
    end
779

780
    protected
781

782 783 784
    def with_bulk_change_table
      # Reset columns/indexes cache as we're changing the table
      @columns = @indexes = nil
785

786 787
      Person.connection.change_table(:delete_me, :bulk => true) do |t|
        yield t
788
      end
789
    end
790

791 792 793
    def column(name)
      columns.detect {|c| c.name == name.to_s }
    end
794

795 796
    def columns
      @columns ||= Person.connection.columns('delete_me')
797 798
    end

799 800
    def index(name)
      indexes.detect {|i| i.name == name.to_s }
801 802
    end

803 804 805 806 807 808 809 810
    def indexes
      @indexes ||= Person.connection.indexes('delete_me')
    end
  end # AlterTableMigrationsTest

end

class CopyMigrationsTest < ActiveRecord::TestCase
811 812
  include ActiveSupport::Testing::Stream

813 814 815 816 817 818 819 820 821 822 823 824 825 826 827
  def setup
  end

  def clear
    ActiveRecord::Base.timestamped_migrations = true
    to_delete = Dir[@migrations_path + "/*.rb"] - @existing_migrations
    File.delete(*to_delete)
  end

  def test_copying_migrations_without_timestamps
    ActiveRecord::Base.timestamped_migrations = false
    @migrations_path = MIGRATIONS_ROOT + "/valid"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]

    copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy"})
A
Arun Agrawal 已提交
828 829
    assert File.exist?(@migrations_path + "/4_people_have_hobbies.bukkits.rb")
    assert File.exist?(@migrations_path + "/5_people_have_descriptions.bukkits.rb")
830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847
    assert_equal [@migrations_path + "/4_people_have_hobbies.bukkits.rb", @migrations_path + "/5_people_have_descriptions.bukkits.rb"], copied.map(&:filename)

    expected = "# This migration comes from bukkits (originally 1)"
    assert_equal expected, IO.readlines(@migrations_path + "/4_people_have_hobbies.bukkits.rb")[0].chomp

    files_count = Dir[@migrations_path + "/*.rb"].length
    copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy"})
    assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
    assert copied.empty?
  ensure
    clear
  end

  def test_copying_migrations_without_timestamps_from_2_sources
    ActiveRecord::Base.timestamped_migrations = false
    @migrations_path = MIGRATIONS_ROOT + "/valid"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]

848
    sources = {}
849 850 851
    sources[:bukkits] = MIGRATIONS_ROOT + "/to_copy"
    sources[:omg] = MIGRATIONS_ROOT + "/to_copy2"
    ActiveRecord::Migration.copy(@migrations_path, sources)
A
Arun Agrawal 已提交
852 853 854 855
    assert File.exist?(@migrations_path + "/4_people_have_hobbies.bukkits.rb")
    assert File.exist?(@migrations_path + "/5_people_have_descriptions.bukkits.rb")
    assert File.exist?(@migrations_path + "/6_create_articles.omg.rb")
    assert File.exist?(@migrations_path + "/7_create_comments.omg.rb")
856 857 858 859 860 861 862

    files_count = Dir[@migrations_path + "/*.rb"].length
    ActiveRecord::Migration.copy(@migrations_path, sources)
    assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
  ensure
    clear
  end
863

864 865 866
  def test_copying_migrations_with_timestamps
    @migrations_path = MIGRATIONS_ROOT + "/valid_with_timestamps"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]
867

868
    travel_to(Time.utc(2010, 7, 26, 10, 10, 10)) do
869
      copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
A
Arun Agrawal 已提交
870 871
      assert File.exist?(@migrations_path + "/20100726101010_people_have_hobbies.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100726101011_people_have_descriptions.bukkits.rb")
872 873 874
      expected = [@migrations_path + "/20100726101010_people_have_hobbies.bukkits.rb",
                  @migrations_path + "/20100726101011_people_have_descriptions.bukkits.rb"]
      assert_equal expected, copied.map(&:filename)
875

876
      files_count = Dir[@migrations_path + "/*.rb"].length
877
      copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
878 879 880
      assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
      assert copied.empty?
    end
881 882 883
  ensure
    clear
  end
884

885 886 887
  def test_copying_migrations_with_timestamps_from_2_sources
    @migrations_path = MIGRATIONS_ROOT + "/valid_with_timestamps"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]
888

889
    sources = {}
890 891 892
    sources[:bukkits] = MIGRATIONS_ROOT + "/to_copy_with_timestamps"
    sources[:omg]     = MIGRATIONS_ROOT + "/to_copy_with_timestamps2"

893
    travel_to(Time.utc(2010, 7, 26, 10, 10, 10)) do
894
      copied = ActiveRecord::Migration.copy(@migrations_path, sources)
A
Arun Agrawal 已提交
895 896 897 898
      assert File.exist?(@migrations_path + "/20100726101010_people_have_hobbies.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100726101011_people_have_descriptions.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100726101012_create_articles.omg.rb")
      assert File.exist?(@migrations_path + "/20100726101013_create_comments.omg.rb")
899
      assert_equal 4, copied.length
900 901 902 903 904

      files_count = Dir[@migrations_path + "/*.rb"].length
      ActiveRecord::Migration.copy(@migrations_path, sources)
      assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
    end
905 906 907
  ensure
    clear
  end
908

909 910 911
  def test_copying_migrations_with_timestamps_to_destination_with_timestamps_in_future
    @migrations_path = MIGRATIONS_ROOT + "/valid_with_timestamps"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]
912

913
    travel_to(Time.utc(2010, 2, 20, 10, 10, 10)) do
914
      ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
A
Arun Agrawal 已提交
915 916
      assert File.exist?(@migrations_path + "/20100301010102_people_have_hobbies.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100301010103_people_have_descriptions.bukkits.rb")
917

918 919 920 921
      files_count = Dir[@migrations_path + "/*.rb"].length
      copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
      assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
      assert copied.empty?
922
    end
923 924 925
  ensure
    clear
  end
926

927 928 929 930 931 932
  def test_copying_migrations_preserving_magic_comments
    ActiveRecord::Base.timestamped_migrations = false
    @migrations_path = MIGRATIONS_ROOT + "/valid"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]

    copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/magic"})
A
Arun Agrawal 已提交
933
    assert File.exist?(@migrations_path + "/4_currencies_have_symbols.bukkits.rb")
934 935 936 937 938 939 940 941 942 943 944 945 946
    assert_equal [@migrations_path + "/4_currencies_have_symbols.bukkits.rb"], copied.map(&:filename)

    expected = "# coding: ISO-8859-15\n# This migration comes from bukkits (originally 1)"
    assert_equal expected, IO.readlines(@migrations_path + "/4_currencies_have_symbols.bukkits.rb")[0..1].join.chomp

    files_count = Dir[@migrations_path + "/*.rb"].length
    copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/magic"})
    assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
    assert copied.empty?
  ensure
    clear
  end

947 948 949
  def test_skipping_migrations
    @migrations_path = MIGRATIONS_ROOT + "/valid_with_timestamps"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]
950 951

    sources = {}
952 953
    sources[:bukkits] = MIGRATIONS_ROOT + "/to_copy_with_timestamps"
    sources[:omg]     = MIGRATIONS_ROOT + "/to_copy_with_name_collision"
954

955 956 957 958
    skipped = []
    on_skip = Proc.new { |name, migration| skipped << "#{name} #{migration.name}" }
    copied = ActiveRecord::Migration.copy(@migrations_path, sources, :on_skip => on_skip)
    assert_equal 2, copied.length
959

960 961 962 963 964
    assert_equal 1, skipped.length
    assert_equal ["omg PeopleHaveHobbies"], skipped
  ensure
    clear
  end
965

966 967 968
  def test_skip_is_not_called_if_migrations_are_from_the_same_plugin
    @migrations_path = MIGRATIONS_ROOT + "/valid_with_timestamps"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]
969

970
    sources = {}
971
    sources[:bukkits] = MIGRATIONS_ROOT + "/to_copy_with_timestamps"
972

973 974 975 976
    skipped = []
    on_skip = Proc.new { |name, migration| skipped << "#{name} #{migration.name}" }
    copied = ActiveRecord::Migration.copy(@migrations_path, sources, :on_skip => on_skip)
    ActiveRecord::Migration.copy(@migrations_path, sources, :on_skip => on_skip)
977

978 979 980 981 982
    assert_equal 2, copied.length
    assert_equal 0, skipped.length
  ensure
    clear
  end
983

984 985 986
  def test_copying_migrations_to_non_existing_directory
    @migrations_path = MIGRATIONS_ROOT + "/non_existing"
    @existing_migrations = []
987

988
    travel_to(Time.utc(2010, 7, 26, 10, 10, 10)) do
989
      copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
A
Arun Agrawal 已提交
990 991
      assert File.exist?(@migrations_path + "/20100726101010_people_have_hobbies.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100726101011_people_have_descriptions.bukkits.rb")
992 993
      assert_equal 2, copied.length
    end
994 995 996 997
  ensure
    clear
    Dir.delete(@migrations_path)
  end
998

999 1000 1001
  def test_copying_migrations_to_empty_directory
    @migrations_path = MIGRATIONS_ROOT + "/empty"
    @existing_migrations = []
1002

1003
    travel_to(Time.utc(2010, 7, 26, 10, 10, 10)) do
1004
      copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
A
Arun Agrawal 已提交
1005 1006
      assert File.exist?(@migrations_path + "/20100726101010_people_have_hobbies.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100726101011_people_have_descriptions.bukkits.rb")
1007
      assert_equal 2, copied.length
1008
    end
1009 1010
  ensure
    clear
1011
  end
1012 1013 1014 1015 1016 1017 1018 1019 1020

  def test_check_pending_with_stdlib_logger
    old, ActiveRecord::Base.logger = ActiveRecord::Base.logger, ::Logger.new($stdout)
    quietly do
      assert_nothing_raised { ActiveRecord::Migration::CheckPending.new(Proc.new {}).call({}) }
    end
  ensure
    ActiveRecord::Base.logger = old
  end
1021

1022
end