migration_test.rb 32.0 KB
Newer Older
1
require "cases/helper"
2
require "cases/migration/helper"
3 4
require 'bigdecimal/util'

J
Jeremy Kemper 已提交
5 6
require 'models/person'
require 'models/topic'
7
require 'models/developer'
A
Arun Agrawal 已提交
8
require 'models/computer'
9 10

require MIGRATIONS_ROOT + "/valid/2_we_need_reminders"
11 12
require MIGRATIONS_ROOT + "/rename/1_we_need_things"
require MIGRATIONS_ROOT + "/rename/2_rename_things"
13
require MIGRATIONS_ROOT + "/decimal/1_give_me_big_numbers"
14

15
class BigNumber < ActiveRecord::Base
16
  unless current_adapter?(:PostgreSQLAdapter, :SQLite3Adapter)
17
    attribute :value_of_e, :integer
18
  end
19
  attribute :my_house_population, :integer
20
end
21

22
class Reminder < ActiveRecord::Base; end
23

24
class Thing < ActiveRecord::Base; end
25

26 27
class MigrationTest < ActiveRecord::TestCase
  self.use_transactional_fixtures = false
28

29
  fixtures :people
30

31 32
  def setup
    super
A
Akira Matsuda 已提交
33
    %w(reminders people_reminders prefix_reminders_suffix p_things_s).each do |table|
A
Aaron Patterson 已提交
34 35 36
      Reminder.connection.drop_table(table) rescue nil
    end
    Reminder.reset_column_information
37
    @verbose_was, ActiveRecord::Migration.verbose = ActiveRecord::Migration.verbose, false
A
Akira Matsuda 已提交
38
    ActiveRecord::Base.connection.schema_cache.clear!
39
  end
40

G
Guo Xiang Tan 已提交
41
  teardown do
42 43 44
    ActiveRecord::Base.table_name_prefix = ""
    ActiveRecord::Base.table_name_suffix = ""

45 46
    ActiveRecord::Base.connection.initialize_schema_migrations_table
    ActiveRecord::Base.connection.execute "DELETE FROM #{ActiveRecord::Migrator.schema_migrations_table_name}"
47

48
    %w(things awesome_things prefix_things_suffix p_awesome_things_s ).each do |table|
49
      Thing.connection.drop_table(table) rescue nil
50
    end
51
    Thing.reset_column_information
52

53 54 55
    %w(reminders people_reminders prefix_reminders_suffix).each do |table|
      Reminder.connection.drop_table(table) rescue nil
    end
56
    Reminder.reset_table_name
57
    Reminder.reset_column_information
58

59 60 61 62 63 64
    %w(last_name key bio age height wealth birthday favorite_day
       moment_of_truth male administrator funny).each do |column|
      Person.connection.remove_column('people', column) rescue nil
    end
    Person.connection.remove_column("people", "first_name") rescue nil
    Person.connection.remove_column("people", "middle_name") rescue nil
65
    Person.connection.add_column("people", "first_name", :string)
66
    Person.reset_column_information
67 68

    ActiveRecord::Migration.verbose = @verbose_was
69
  end
70

71 72
  def test_migrator_versions
    migrations_path = MIGRATIONS_ROOT + "/valid"
73
    old_path = ActiveRecord::Migrator.migrations_paths
74 75 76 77 78
    ActiveRecord::Migrator.migrations_paths = migrations_path

    ActiveRecord::Migrator.up(migrations_path)
    assert_equal 3, ActiveRecord::Migrator.current_version
    assert_equal 3, ActiveRecord::Migrator.last_version
79
    assert_equal false, ActiveRecord::Migrator.needs_migration?
80 81 82 83

    ActiveRecord::Migrator.down(MIGRATIONS_ROOT + "/valid")
    assert_equal 0, ActiveRecord::Migrator.current_version
    assert_equal 3, ActiveRecord::Migrator.last_version
84
    assert_equal true, ActiveRecord::Migrator.needs_migration?
85 86 87 88 89 90 91 92

    ActiveRecord::SchemaMigration.create!(:version => ActiveRecord::Migrator.last_version)
    assert_equal true, ActiveRecord::Migrator.needs_migration?
  ensure
    ActiveRecord::Migrator.migrations_paths = old_path
  end

  def test_migration_detection_without_schema_migration_table
93
    ActiveRecord::Base.connection.drop_table 'schema_migrations', if_exists: true
94 95 96 97 98 99

    migrations_path = MIGRATIONS_ROOT + "/valid"
    old_path = ActiveRecord::Migrator.migrations_paths
    ActiveRecord::Migrator.migrations_paths = migrations_path

    assert_equal true, ActiveRecord::Migrator.needs_migration?
100 101
  ensure
    ActiveRecord::Migrator.migrations_paths = old_path
102 103
  end

104 105 106 107 108 109 110 111 112 113 114 115 116
  def test_any_migrations
    old_path = ActiveRecord::Migrator.migrations_paths
    ActiveRecord::Migrator.migrations_paths = MIGRATIONS_ROOT + "/valid"

    assert ActiveRecord::Migrator.any_migrations?

    ActiveRecord::Migrator.migrations_paths = MIGRATIONS_ROOT + "/empty"

    assert_not ActiveRecord::Migrator.any_migrations?
  ensure
    ActiveRecord::Migrator.migrations_paths = old_path
  end

117 118 119 120
  def test_migration_version
    ActiveRecord::Migrator.run(:up, MIGRATIONS_ROOT + "/version_check", 20131219224947)
  end

121 122 123 124
  def test_create_table_with_force_true_does_not_drop_nonexisting_table
    # using a copy as we need the drop_table method to
    # continue to work for the ensure block of the test
    temp_conn = Person.connection.dup
125 126 127

    assert_not_equal temp_conn, Person.connection

128 129
    temp_conn.create_table :testings2, :force => true do |t|
      t.column :foo, :string
130
    end
131
  ensure
132
    Person.connection.drop_table :testings2, if_exists: true
133
  end
134

135 136 137
  def connection
    ActiveRecord::Base.connection
  end
138

139 140 141 142
  def test_migration_instance_has_connection
    migration = Class.new(ActiveRecord::Migration).new
    assert_equal connection, migration.connection
  end
143

144 145 146 147 148 149 150 151
  def test_method_missing_delegates_to_connection
    migration = Class.new(ActiveRecord::Migration) {
      def connection
        Class.new {
          def create_table; "hi mom!"; end
        }.new
      end
    }.new
152

153
    assert_equal "hi mom!", migration.method_missing(:create_table)
154
  end
155

156 157 158 159 160
  def test_add_table_with_decimals
    Person.connection.drop_table :big_numbers rescue nil

    assert !BigNumber.table_exists?
    GiveMeBigNumbers.up
161
    BigNumber.reset_column_information
162 163 164 165 166 167 168 169 170

    assert BigNumber.create(
      :bank_balance => 1586.43,
      :big_bank_balance => BigDecimal("1000234000567.95"),
      :world_population => 6000000000,
      :my_house_population => 3,
      :value_of_e => BigDecimal("2.7182818284590452353602875")
    )

171
    b = BigNumber.first
172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214
    assert_not_nil b

    assert_not_nil b.bank_balance
    assert_not_nil b.big_bank_balance
    assert_not_nil b.world_population
    assert_not_nil b.my_house_population
    assert_not_nil b.value_of_e

    # TODO: set world_population >= 2**62 to cover 64-bit platforms and test
    # is_a?(Bignum)
    assert_kind_of Integer, b.world_population
    assert_equal 6000000000, b.world_population
    assert_kind_of Fixnum, b.my_house_population
    assert_equal 3, b.my_house_population
    assert_kind_of BigDecimal, b.bank_balance
    assert_equal BigDecimal("1586.43"), b.bank_balance
    assert_kind_of BigDecimal, b.big_bank_balance
    assert_equal BigDecimal("1000234000567.95"), b.big_bank_balance

    # This one is fun. The 'value_of_e' field is defined as 'DECIMAL' with
    # precision/scale explicitly left out.  By the SQL standard, numbers
    # assigned to this field should be truncated but that's seldom respected.
    if current_adapter?(:PostgreSQLAdapter)
      # - PostgreSQL changes the SQL spec on columns declared simply as
      # "decimal" to something more useful: instead of being given a scale
      # of 0, they take on the compile-time limit for precision and scale,
      # so the following should succeed unless you have used really wacky
      # compilation options
      # - SQLite2 has the default behavior of preserving all data sent in,
      # so this happens there too
      assert_kind_of BigDecimal, b.value_of_e
      assert_equal BigDecimal("2.7182818284590452353602875"), b.value_of_e
    elsif current_adapter?(:SQLite3Adapter)
      # - SQLite3 stores a float, in violation of SQL
      assert_kind_of BigDecimal, b.value_of_e
      assert_in_delta BigDecimal("2.71828182845905"), b.value_of_e, 0.00000000000001
    else
      # - SQL standard is an integer
      assert_kind_of Fixnum, b.value_of_e
      assert_equal 2, b.value_of_e
    end

    GiveMeBigNumbers.down
215
    assert_raise(ActiveRecord::StatementInvalid) { BigNumber.first }
216
  end
217

218
  def test_filtering_migrations
219
    assert_no_column Person, :last_name
220
    assert !Reminder.table_exists?
221

222 223
    name_filter = lambda { |migration| migration.name == "ValidPeopleHaveLastNames" }
    ActiveRecord::Migrator.up(MIGRATIONS_ROOT + "/valid", &name_filter)
224

225
    assert_column Person, :last_name
226
    assert_raise(ActiveRecord::StatementInvalid) { Reminder.first }
227

228 229
    ActiveRecord::Migrator.down(MIGRATIONS_ROOT + "/valid", &name_filter)

230
    assert_no_column Person, :last_name
231
    assert_raise(ActiveRecord::StatementInvalid) { Reminder.first }
232 233 234 235 236 237 238
  end

  class MockMigration < ActiveRecord::Migration
    attr_reader :went_up, :went_down
    def initialize
      @went_up   = false
      @went_down = false
239 240
    end

241 242 243 244
    def up
      @went_up = true
      super
    end
245

246 247 248
    def down
      @went_down = true
      super
249
    end
250
  end
251

252 253 254 255
  def test_instance_based_migration_up
    migration = MockMigration.new
    assert !migration.went_up, 'have not gone up'
    assert !migration.went_down, 'have not gone down'
256

257 258 259 260
    migration.migrate :up
    assert migration.went_up, 'have gone up'
    assert !migration.went_down, 'have not gone down'
  end
261

262 263 264 265
  def test_instance_based_migration_down
    migration = MockMigration.new
    assert !migration.went_up, 'have not gone up'
    assert !migration.went_down, 'have not gone down'
266

267 268 269 270
    migration.migrate :down
    assert !migration.went_up, 'have gone up'
    assert migration.went_down, 'have not gone down'
  end
271

272 273 274 275 276 277 278 279 280 281 282
  if ActiveRecord::Base.connection.supports_ddl_transactions?
    def test_migrator_one_up_with_exception_and_rollback
      assert_no_column Person, :last_name

      migration = Class.new(ActiveRecord::Migration) {
        def version; 100 end
        def migrate(x)
          add_column "people", "last_name", :string
          raise 'Something broke'
        end
      }.new
283

284
      migrator = ActiveRecord::Migrator.new(:up, [migration], 100)
285

286
      e = assert_raise(StandardError) { migrator.migrate }
287

288
      assert_equal "An error has occurred, this and all later migrations canceled:\n\nSomething broke", e.message
289

290 291
      assert_no_column Person, :last_name,
        "On error, the Migrator should revert schema changes but it did not."
B
bondarev 已提交
292 293
    end

294 295
    def test_migrator_one_up_with_exception_and_rollback_using_run
      assert_no_column Person, :last_name
B
bondarev 已提交
296

297 298 299 300 301 302 303
      migration = Class.new(ActiveRecord::Migration) {
        def version; 100 end
        def migrate(x)
          add_column "people", "last_name", :string
          raise 'Something broke'
        end
      }.new
B
bondarev 已提交
304

305
      migrator = ActiveRecord::Migrator.new(:up, [migration], 100)
B
bondarev 已提交
306

307
      e = assert_raise(StandardError) { migrator.run }
B
bondarev 已提交
308

309
      assert_equal "An error has occurred, this migration was canceled:\n\nSomething broke", e.message
B
bondarev 已提交
310

311 312
      assert_no_column Person, :last_name,
        "On error, the Migrator should revert schema changes but it did not."
313 314
    end

315 316
    def test_migration_without_transaction
      assert_no_column Person, :last_name
317

318 319
      migration = Class.new(ActiveRecord::Migration) {
        self.disable_ddl_transaction!
320

321 322 323 324 325 326
        def version; 101 end
        def migrate(x)
          add_column "people", "last_name", :string
          raise 'Something broke'
        end
      }.new
327

328 329 330
      migrator = ActiveRecord::Migrator.new(:up, [migration], 101)
      e = assert_raise(StandardError) { migrator.migrate }
      assert_equal "An error has occurred, all later migrations canceled:\n\nSomething broke", e.message
331

332 333 334 335 336 337 338
      assert_column Person, :last_name,
        "without ddl transactions, the Migrator should not rollback on error but it did."
    ensure
      Person.reset_column_information
      if Person.column_names.include?('last_name')
        Person.connection.remove_column('people', 'last_name')
      end
339
    end
340
  end
341

342
  def test_schema_migrations_table_name
343 344 345
    original_schema_migrations_table_name = ActiveRecord::Migrator.schema_migrations_table_name

    assert_equal "schema_migrations", ActiveRecord::Migrator.schema_migrations_table_name
346 347 348 349
    ActiveRecord::Base.table_name_prefix = "prefix_"
    ActiveRecord::Base.table_name_suffix = "_suffix"
    Reminder.reset_table_name
    assert_equal "prefix_schema_migrations_suffix", ActiveRecord::Migrator.schema_migrations_table_name
350 351 352
    ActiveRecord::Base.schema_migrations_table_name = "changed"
    Reminder.reset_table_name
    assert_equal "prefix_changed_suffix", ActiveRecord::Migrator.schema_migrations_table_name
353 354 355
    ActiveRecord::Base.table_name_prefix = ""
    ActiveRecord::Base.table_name_suffix = ""
    Reminder.reset_table_name
356 357 358 359
    assert_equal "changed", ActiveRecord::Migrator.schema_migrations_table_name
  ensure
    ActiveRecord::Base.schema_migrations_table_name = original_schema_migrations_table_name
    Reminder.reset_table_name
360 361
  end

362
  def test_proper_table_name_on_migration
363
    reminder_class = new_isolated_reminder_class
364 365 366
    migration = ActiveRecord::Migration.new
    assert_equal "table", migration.proper_table_name('table')
    assert_equal "table", migration.proper_table_name(:table)
367 368 369
    assert_equal "reminders", migration.proper_table_name(reminder_class)
    reminder_class.reset_table_name
    assert_equal reminder_class.table_name, migration.proper_table_name(reminder_class)
370 371 372 373

    # Use the model's own prefix/suffix if a model is given
    ActiveRecord::Base.table_name_prefix = "ARprefix_"
    ActiveRecord::Base.table_name_suffix = "_ARsuffix"
374 375 376 377 378 379 380
    reminder_class.table_name_prefix = 'prefix_'
    reminder_class.table_name_suffix = '_suffix'
    reminder_class.reset_table_name
    assert_equal "prefix_reminders_suffix", migration.proper_table_name(reminder_class)
    reminder_class.table_name_prefix = ''
    reminder_class.table_name_suffix = ''
    reminder_class.reset_table_name
381 382 383 384

    # Use AR::Base's prefix/suffix if string or symbol is given
    ActiveRecord::Base.table_name_prefix = "prefix_"
    ActiveRecord::Base.table_name_suffix = "_suffix"
385
    reminder_class.reset_table_name
386 387 388 389
    assert_equal "prefix_table_suffix", migration.proper_table_name('table', migration.table_name_options)
    assert_equal "prefix_table_suffix", migration.proper_table_name(:table, migration.table_name_options)
  end

390 391
  def test_rename_table_with_prefix_and_suffix
    assert !Thing.table_exists?
392 393
    ActiveRecord::Base.table_name_prefix = 'p_'
    ActiveRecord::Base.table_name_suffix = '_s'
394 395 396
    Thing.reset_table_name
    Thing.reset_sequence_name
    WeNeedThings.up
397
    Thing.reset_column_information
398 399

    assert Thing.create("content" => "hello world")
400
    assert_equal "hello world", Thing.first.content
401 402

    RenameThings.up
403
    Thing.table_name = "p_awesome_things_s"
404

405
    assert_equal "hello world", Thing.first.content
406 407 408 409 410 411 412 413 414 415 416
  ensure
    Thing.reset_table_name
    Thing.reset_sequence_name
  end

  def test_add_drop_table_with_prefix_and_suffix
    assert !Reminder.table_exists?
    ActiveRecord::Base.table_name_prefix = 'prefix_'
    ActiveRecord::Base.table_name_suffix = '_suffix'
    Reminder.reset_table_name
    Reminder.reset_sequence_name
417
    Reminder.reset_column_information
418 419
    WeNeedReminders.up
    assert Reminder.create("content" => "hello world", "remind_at" => Time.now)
420
    assert_equal "hello world", Reminder.first.content
421 422

    WeNeedReminders.down
423
    assert_raise(ActiveRecord::StatementInvalid) { Reminder.first }
424 425 426
  ensure
    Reminder.reset_sequence_name
  end
427

428 429 430
  def test_create_table_with_binary_column
    assert_nothing_raised {
      Person.connection.create_table :binary_testings do |t|
431
        t.column "data", :binary, :null => false
432
      end
433 434 435 436
    }

    columns = Person.connection.columns(:binary_testings)
    data_column = columns.detect { |c| c.name == "data" }
437

J
Jon Leighton 已提交
438
    assert_nil data_column.default
439

440
    Person.connection.drop_table :binary_testings, if_exists: true
441 442
  end

443 444 445 446
  unless mysql_enforcing_gtid_consistency?
    def test_create_table_with_query
      Person.connection.drop_table :table_from_query_testings rescue nil
      Person.connection.create_table(:person, force: true)
447

448
      Person.connection.create_table :table_from_query_testings, as: "SELECT id FROM person"
449

450 451 452
      columns = Person.connection.columns(:table_from_query_testings)
      assert_equal 1, columns.length
      assert_equal "id", columns.first.name
453

454 455
      Person.connection.drop_table :table_from_query_testings rescue nil
    end
456

457 458 459
    def test_create_table_with_query_from_relation
      Person.connection.drop_table :table_from_query_testings rescue nil
      Person.connection.create_table(:person, force: true)
460

461
      Person.connection.create_table :table_from_query_testings, as: Person.select(:id)
462

463 464 465
      columns = Person.connection.columns(:table_from_query_testings)
      assert_equal 1, columns.length
      assert_equal "id", columns.first.name
466

467 468
      Person.connection.drop_table :table_from_query_testings rescue nil
    end
469 470
  end

471 472 473 474 475 476 477 478 479 480 481
  if current_adapter? :OracleAdapter
    def test_create_table_with_custom_sequence_name
      # table name is 29 chars, the standard sequence name will
      # be 33 chars and should be shortened
      assert_nothing_raised do
        begin
          Person.connection.create_table :table_with_name_thats_just_ok do |t|
            t.column :foo, :string, :null => false
          end
        ensure
          Person.connection.drop_table :table_with_name_thats_just_ok rescue nil
482 483 484
        end
      end

485 486 487 488 489 490 491
      # should be all good w/ a custom sequence name
      assert_nothing_raised do
        begin
          Person.connection.create_table :table_with_name_thats_just_ok,
            :sequence_name => 'suitably_short_seq' do |t|
            t.column :foo, :string, :null => false
          end
492

493
          Person.connection.execute("select suitably_short_seq.nextval from dual")
494

495 496 497 498
        ensure
          Person.connection.drop_table :table_with_name_thats_just_ok,
            :sequence_name => 'suitably_short_seq' rescue nil
        end
499 500
      end

501 502 503 504
      # confirm the custom sequence got dropped
      assert_raise(ActiveRecord::StatementInvalid) do
        Person.connection.execute("select suitably_short_seq.nextval from dual")
      end
505
    end
506
  end
507

508 509 510 511 512 513 514
  if current_adapter?(:MysqlAdapter, :Mysql2Adapter, :PostgreSQLAdapter)
    def test_out_of_range_limit_should_raise
      Person.connection.drop_table :test_limits rescue nil
      assert_raise(ActiveRecord::ActiveRecordError, "integer limit didn't raise") do
        Person.connection.create_table :test_integer_limits, :force => true do |t|
          t.column :bigone, :integer, :limit => 10
        end
515 516
      end

517 518 519 520 521
      unless current_adapter?(:PostgreSQLAdapter)
        assert_raise(ActiveRecord::ActiveRecordError, "text limit didn't raise") do
          Person.connection.create_table :test_text_limits, :force => true do |t|
            t.column :bigtext, :text, :limit => 0xfffffffff
          end
522 523 524
        end
      end

525 526
      Person.connection.drop_table :test_limits rescue nil
    end
527 528
  end

529
  protected
530 531 532 533 534 535 536 537
    # This is needed to isolate class_attribute assignments like `table_name_prefix`
    # for each test case.
    def new_isolated_reminder_class
      Class.new(Reminder) {
        def self.name; "Reminder"; end
        def self.base_class; self; end
      }
    end
538
end
539

540 541 542 543 544
class ReservedWordsMigrationTest < ActiveRecord::TestCase
  def test_drop_index_from_table_named_values
    connection = Person.connection
    connection.create_table :values, :force => true do |t|
      t.integer :value
545
    end
546

547 548 549
    assert_nothing_raised do
      connection.add_index :values, :value
      connection.remove_index :values, :column => :value
550
    end
551

552 553 554 555
    connection.drop_table :values rescue nil
  end
end

556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571
class ExplicitlyNamedIndexMigrationTest < ActiveRecord::TestCase
  def test_drop_index_by_name
    connection = Person.connection
    connection.create_table :values, force: true do |t|
      t.integer :value
    end

    assert_nothing_raised ArgumentError do
      connection.add_index :values, :value, name: 'a_different_name'
      connection.remove_index :values, column: :value, name: 'a_different_name'
    end

    connection.drop_table :values rescue nil
  end
end

572 573 574 575 576
if ActiveRecord::Base.connection.supports_bulk_alter?
  class BulkAlterTableMigrationsTest < ActiveRecord::TestCase
    def setup
      @connection = Person.connection
      @connection.create_table(:delete_me, :force => true) {|t| }
A
Akira Matsuda 已提交
577 578
      Person.reset_column_information
      Person.reset_sequence_name
579
    end
580

G
Guo Xiang Tan 已提交
581
    teardown do
582 583
      Person.connection.drop_table(:delete_me) rescue nil
    end
584

585 586
    def test_adding_multiple_columns
      assert_queries(1) do
587
        with_bulk_change_table do |t|
588
          t.column :name, :string
589
          t.string :qualification, :experience
590 591
          t.integer :age, :default => 0
          t.date :birthdate
592
          t.timestamps null: true
593
        end
594
      end
595

596 597
      assert_equal 8, columns.size
      [:name, :qualification, :experience].each {|s| assert_equal :string, column(s).type }
598
      assert_equal '0', column(:age).default
599
    end
600

601 602 603
    def test_removing_columns
      with_bulk_change_table do |t|
        t.string :qualification, :experience
604 605
      end

606
      [:qualification, :experience].each {|c| assert column(c) }
607

608 609 610 611
      assert_queries(1) do
        with_bulk_change_table do |t|
          t.remove :qualification, :experience
          t.string :qualification_experience
612
        end
613
      end
614

615 616 617
      [:qualification, :experience].each {|c| assert ! column(c) }
      assert column(:qualification_experience)
    end
618

619 620 621 622 623
    def test_adding_indexes
      with_bulk_change_table do |t|
        t.string :username
        t.string :name
        t.integer :age
624 625
      end

626 627
      # Adding an index fires a query every time to check if an index already exists or not
      assert_queries(3) do
628
        with_bulk_change_table do |t|
629 630
          t.index :username, :unique => true, :name => :awesome_username_index
          t.index [:name, :age]
631
        end
632
      end
633

634
      assert_equal 2, indexes.size
635

636 637 638
      name_age_index = index(:index_delete_me_on_name_and_age)
      assert_equal ['name', 'age'].sort, name_age_index.columns.sort
      assert ! name_age_index.unique
639

640 641
      assert index(:awesome_username_index).unique
    end
642

643 644 645 646
    def test_removing_index
      with_bulk_change_table do |t|
        t.string :name
        t.index :name
647
      end
648

649 650 651
      assert index(:index_delete_me_on_name)

      assert_queries(3) do
652
        with_bulk_change_table do |t|
653 654
          t.remove_index :name
          t.index :name, :name => :new_name_index, :unique => true
655
        end
656
      end
657

658
      assert ! index(:index_delete_me_on_name)
659

660 661 662
      new_name_index = index(:new_name_index)
      assert new_name_index.unique
    end
663

664 665 666 667
    def test_changing_columns
      with_bulk_change_table do |t|
        t.string :name
        t.date :birthdate
668
      end
669

670 671
      assert ! column(:name).default
      assert_equal :date, column(:birthdate).type
672

673 674 675
      # One query for columns (delete_me table)
      # One query for primary key (delete_me table)
      # One query to do the bulk change
676
      assert_queries(3, :ignore_none => true) do
677 678 679
        with_bulk_change_table do |t|
          t.change :name, :string, :default => 'NONAME'
          t.change :birthdate, :datetime
680
        end
681 682
      end

683 684 685
      assert_equal 'NONAME', column(:name).default
      assert_equal :datetime, column(:birthdate).type
    end
686

687
    protected
688

689 690 691
    def with_bulk_change_table
      # Reset columns/indexes cache as we're changing the table
      @columns = @indexes = nil
692

693 694
      Person.connection.change_table(:delete_me, :bulk => true) do |t|
        yield t
695
      end
696
    end
697

698 699 700
    def column(name)
      columns.detect {|c| c.name == name.to_s }
    end
701

702 703
    def columns
      @columns ||= Person.connection.columns('delete_me')
704 705
    end

706 707
    def index(name)
      indexes.detect {|i| i.name == name.to_s }
708 709
    end

710 711 712 713 714 715 716 717
    def indexes
      @indexes ||= Person.connection.indexes('delete_me')
    end
  end # AlterTableMigrationsTest

end

class CopyMigrationsTest < ActiveRecord::TestCase
718 719
  include ActiveSupport::Testing::Stream

720 721 722 723 724 725 726 727 728 729 730 731 732 733 734
  def setup
  end

  def clear
    ActiveRecord::Base.timestamped_migrations = true
    to_delete = Dir[@migrations_path + "/*.rb"] - @existing_migrations
    File.delete(*to_delete)
  end

  def test_copying_migrations_without_timestamps
    ActiveRecord::Base.timestamped_migrations = false
    @migrations_path = MIGRATIONS_ROOT + "/valid"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]

    copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy"})
A
Arun Agrawal 已提交
735 736
    assert File.exist?(@migrations_path + "/4_people_have_hobbies.bukkits.rb")
    assert File.exist?(@migrations_path + "/5_people_have_descriptions.bukkits.rb")
737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754
    assert_equal [@migrations_path + "/4_people_have_hobbies.bukkits.rb", @migrations_path + "/5_people_have_descriptions.bukkits.rb"], copied.map(&:filename)

    expected = "# This migration comes from bukkits (originally 1)"
    assert_equal expected, IO.readlines(@migrations_path + "/4_people_have_hobbies.bukkits.rb")[0].chomp

    files_count = Dir[@migrations_path + "/*.rb"].length
    copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy"})
    assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
    assert copied.empty?
  ensure
    clear
  end

  def test_copying_migrations_without_timestamps_from_2_sources
    ActiveRecord::Base.timestamped_migrations = false
    @migrations_path = MIGRATIONS_ROOT + "/valid"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]

755
    sources = {}
756 757 758
    sources[:bukkits] = MIGRATIONS_ROOT + "/to_copy"
    sources[:omg] = MIGRATIONS_ROOT + "/to_copy2"
    ActiveRecord::Migration.copy(@migrations_path, sources)
A
Arun Agrawal 已提交
759 760 761 762
    assert File.exist?(@migrations_path + "/4_people_have_hobbies.bukkits.rb")
    assert File.exist?(@migrations_path + "/5_people_have_descriptions.bukkits.rb")
    assert File.exist?(@migrations_path + "/6_create_articles.omg.rb")
    assert File.exist?(@migrations_path + "/7_create_comments.omg.rb")
763 764 765 766 767 768 769

    files_count = Dir[@migrations_path + "/*.rb"].length
    ActiveRecord::Migration.copy(@migrations_path, sources)
    assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
  ensure
    clear
  end
770

771 772 773
  def test_copying_migrations_with_timestamps
    @migrations_path = MIGRATIONS_ROOT + "/valid_with_timestamps"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]
774

775
    travel_to(Time.utc(2010, 7, 26, 10, 10, 10)) do
776
      copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
A
Arun Agrawal 已提交
777 778
      assert File.exist?(@migrations_path + "/20100726101010_people_have_hobbies.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100726101011_people_have_descriptions.bukkits.rb")
779 780 781
      expected = [@migrations_path + "/20100726101010_people_have_hobbies.bukkits.rb",
                  @migrations_path + "/20100726101011_people_have_descriptions.bukkits.rb"]
      assert_equal expected, copied.map(&:filename)
782

783
      files_count = Dir[@migrations_path + "/*.rb"].length
784
      copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
785 786 787
      assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
      assert copied.empty?
    end
788 789 790
  ensure
    clear
  end
791

792 793 794
  def test_copying_migrations_with_timestamps_from_2_sources
    @migrations_path = MIGRATIONS_ROOT + "/valid_with_timestamps"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]
795

796
    sources = {}
797 798 799
    sources[:bukkits] = MIGRATIONS_ROOT + "/to_copy_with_timestamps"
    sources[:omg]     = MIGRATIONS_ROOT + "/to_copy_with_timestamps2"

800
    travel_to(Time.utc(2010, 7, 26, 10, 10, 10)) do
801
      copied = ActiveRecord::Migration.copy(@migrations_path, sources)
A
Arun Agrawal 已提交
802 803 804 805
      assert File.exist?(@migrations_path + "/20100726101010_people_have_hobbies.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100726101011_people_have_descriptions.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100726101012_create_articles.omg.rb")
      assert File.exist?(@migrations_path + "/20100726101013_create_comments.omg.rb")
806
      assert_equal 4, copied.length
807 808 809 810 811

      files_count = Dir[@migrations_path + "/*.rb"].length
      ActiveRecord::Migration.copy(@migrations_path, sources)
      assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
    end
812 813 814
  ensure
    clear
  end
815

816 817 818
  def test_copying_migrations_with_timestamps_to_destination_with_timestamps_in_future
    @migrations_path = MIGRATIONS_ROOT + "/valid_with_timestamps"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]
819

820
    travel_to(Time.utc(2010, 2, 20, 10, 10, 10)) do
821
      ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
A
Arun Agrawal 已提交
822 823
      assert File.exist?(@migrations_path + "/20100301010102_people_have_hobbies.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100301010103_people_have_descriptions.bukkits.rb")
824

825 826 827 828
      files_count = Dir[@migrations_path + "/*.rb"].length
      copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
      assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
      assert copied.empty?
829
    end
830 831 832
  ensure
    clear
  end
833

834 835 836 837 838 839
  def test_copying_migrations_preserving_magic_comments
    ActiveRecord::Base.timestamped_migrations = false
    @migrations_path = MIGRATIONS_ROOT + "/valid"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]

    copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/magic"})
A
Arun Agrawal 已提交
840
    assert File.exist?(@migrations_path + "/4_currencies_have_symbols.bukkits.rb")
841 842 843 844 845 846 847 848 849 850 851 852 853
    assert_equal [@migrations_path + "/4_currencies_have_symbols.bukkits.rb"], copied.map(&:filename)

    expected = "# coding: ISO-8859-15\n# This migration comes from bukkits (originally 1)"
    assert_equal expected, IO.readlines(@migrations_path + "/4_currencies_have_symbols.bukkits.rb")[0..1].join.chomp

    files_count = Dir[@migrations_path + "/*.rb"].length
    copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/magic"})
    assert_equal files_count, Dir[@migrations_path + "/*.rb"].length
    assert copied.empty?
  ensure
    clear
  end

854 855 856
  def test_skipping_migrations
    @migrations_path = MIGRATIONS_ROOT + "/valid_with_timestamps"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]
857 858

    sources = {}
859 860
    sources[:bukkits] = MIGRATIONS_ROOT + "/to_copy_with_timestamps"
    sources[:omg]     = MIGRATIONS_ROOT + "/to_copy_with_name_collision"
861

862 863 864 865
    skipped = []
    on_skip = Proc.new { |name, migration| skipped << "#{name} #{migration.name}" }
    copied = ActiveRecord::Migration.copy(@migrations_path, sources, :on_skip => on_skip)
    assert_equal 2, copied.length
866

867 868 869 870 871
    assert_equal 1, skipped.length
    assert_equal ["omg PeopleHaveHobbies"], skipped
  ensure
    clear
  end
872

873 874 875
  def test_skip_is_not_called_if_migrations_are_from_the_same_plugin
    @migrations_path = MIGRATIONS_ROOT + "/valid_with_timestamps"
    @existing_migrations = Dir[@migrations_path + "/*.rb"]
876

877
    sources = {}
878
    sources[:bukkits] = MIGRATIONS_ROOT + "/to_copy_with_timestamps"
879

880 881 882 883
    skipped = []
    on_skip = Proc.new { |name, migration| skipped << "#{name} #{migration.name}" }
    copied = ActiveRecord::Migration.copy(@migrations_path, sources, :on_skip => on_skip)
    ActiveRecord::Migration.copy(@migrations_path, sources, :on_skip => on_skip)
884

885 886 887 888 889
    assert_equal 2, copied.length
    assert_equal 0, skipped.length
  ensure
    clear
  end
890

891 892 893
  def test_copying_migrations_to_non_existing_directory
    @migrations_path = MIGRATIONS_ROOT + "/non_existing"
    @existing_migrations = []
894

895
    travel_to(Time.utc(2010, 7, 26, 10, 10, 10)) do
896
      copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
A
Arun Agrawal 已提交
897 898
      assert File.exist?(@migrations_path + "/20100726101010_people_have_hobbies.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100726101011_people_have_descriptions.bukkits.rb")
899 900
      assert_equal 2, copied.length
    end
901 902 903 904
  ensure
    clear
    Dir.delete(@migrations_path)
  end
905

906 907 908
  def test_copying_migrations_to_empty_directory
    @migrations_path = MIGRATIONS_ROOT + "/empty"
    @existing_migrations = []
909

910
    travel_to(Time.utc(2010, 7, 26, 10, 10, 10)) do
911
      copied = ActiveRecord::Migration.copy(@migrations_path, {:bukkits => MIGRATIONS_ROOT + "/to_copy_with_timestamps"})
A
Arun Agrawal 已提交
912 913
      assert File.exist?(@migrations_path + "/20100726101010_people_have_hobbies.bukkits.rb")
      assert File.exist?(@migrations_path + "/20100726101011_people_have_descriptions.bukkits.rb")
914
      assert_equal 2, copied.length
915
    end
916 917
  ensure
    clear
918
  end
919 920 921 922 923 924 925 926 927

  def test_check_pending_with_stdlib_logger
    old, ActiveRecord::Base.logger = ActiveRecord::Base.logger, ::Logger.new($stdout)
    quietly do
      assert_nothing_raised { ActiveRecord::Migration::CheckPending.new(Proc.new {}).call({}) }
    end
  ensure
    ActiveRecord::Base.logger = old
  end
928

929
end